[Bug 53615] New: java.lang.OutOfMemoryError: GC overhead limit exceeded after upgrading from 7.0.28 to 7.0.29
https://issues.apache.org/bugzilla/show_bug.cgi?id=53615 Priority: P2 Bug ID: 53615 Assignee: dev@tomcat.apache.org Summary: java.lang.OutOfMemoryError: GC overhead limit exceeded after upgrading from 7.0.28 to 7.0.29 Severity: normal Classification: Unclassified OS: Linux Reporter: s.highlan...@gmail.com Hardware: PC Status: NEW Version: 7.0.29 Component: Catalina Product: Tomcat 7 I have upgraded my Tomcat from 7.0.28 to 7.0.29 and got OutOfMemory error after typing "catalina.sh run" from command line. The root element of my web.xml is http://java.sun.com/xml/ns/javaee"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://java.sun.com/xml/ns/javaee http://java.sun.com/xml/ns/javaee/web-app_2_5.xsd";> Environment : Ubuntu 12.04 x64, Oracle Jdk 1.6.0_33, without APR native libraries. I tried to increase heap memory from 1GB up to 4GB, it didn't help. --- Stack trace - java.util.concurrent.ExecutionException: java.lang.OutOfMemoryError: GC overhead limit exceeded at java.util.concurrent.FutureTask$Sync.innerGet(FutureTask.java:222) at java.util.concurrent.FutureTask.get(FutureTask.java:83) at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:1123) at org.apache.catalina.core.StandardEngine.startInternal(StandardEngine.java:302) at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:150) at org.apache.catalina.core.StandardService.startInternal(StandardService.java:443) at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:150) at org.apache.catalina.core.StandardServer.startInternal(StandardServer.java:732) at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:150) at org.apache.catalina.startup.Catalina.start(Catalina.java:675) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.apache.catalina.startup.Bootstrap.start(Bootstrap.java:322) at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:451) Caused by: java.lang.OutOfMemoryError: GC overhead limit exceeded at java.util.Arrays.copyOf(Arrays.java:2882) at java.lang.AbstractStringBuilder.expandCapacity(AbstractStringBuilder.java:100) at java.lang.AbstractStringBuilder.append(AbstractStringBuilder.java:390) at java.lang.StringBuilder.append(StringBuilder.java:119) at java.lang.StackTraceElement.toString(StackTraceElement.java:157) at java.lang.String.valueOf(String.java:2826) at java.lang.StringBuilder.append(StringBuilder.java:115) at java.lang.Throwable.printStackTrace(Throwable.java:512) at java.util.logging.SimpleFormatter.format(SimpleFormatter.java:72) at java.util.logging.StreamHandler.publish(StreamHandler.java:179) at java.util.logging.ConsoleHandler.publish(ConsoleHandler.java:88) at java.util.logging.Logger.log(Logger.java:478) at java.util.logging.Logger.doLog(Logger.java:500) at java.util.logging.Logger.logp(Logger.java:700) at org.apache.juli.logging.DirectJDKLog.log(DirectJDKLog.java:185) at org.apache.juli.logging.DirectJDKLog.error(DirectJDKLog.java:151) at org.apache.catalina.startup.HostConfig.deployDirectories(HostConfig.java:1025) at org.apache.catalina.startup.HostConfig.deployApps(HostConfig.java:474) at org.apache.catalina.startup.HostConfig.start(HostConfig.java:1413) at org.apache.catalina.startup.HostConfig.lifecycleEvent(HostConfig.java:313) at org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(LifecycleSupport.java:119) at org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(LifecycleBase.java:90) at org.apache.catalina.util.LifecycleBase.setStateInternal(LifecycleBase.java:401) at org.apache.catalina.util.LifecycleBase.setState(LifecycleBase.java:346) at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:1140) at org.apache.catalina.core.StandardHost.startInternal(StandardHost.java:785) at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:150) at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1559) at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1549) at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303) at java.util.concurrent.FutureTask.run(FutureTask.java:138) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 53615] java.lang.OutOfMemoryError: GC overhead limit exceeded after upgrading from 7.0.28 to 7.0.29
https://issues.apache.org/bugzilla/show_bug.cgi?id=53615 --- Comment #1 from John Miller --- Created attachment 29124 --> https://issues.apache.org/bugzilla/attachment.cgi?id=29124&action=edit org.apache.cataline.core.StandardContext occupies 769 MB (0.769 GB)! -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53615] java.lang.OutOfMemoryError: GC overhead limit exceeded after upgrading from 7.0.28 to 7.0.29
https://issues.apache.org/bugzilla/show_bug.cgi?id=53615 --- Comment #2 from John Miller --- Created attachment 29125 --> https://issues.apache.org/bugzilla/attachment.cgi?id=29125&action=edit Histogram -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53615] java.lang.OutOfMemoryError: GC overhead limit exceeded after upgrading from 7.0.28 to 7.0.29
https://issues.apache.org/bugzilla/show_bug.cgi?id=53615 --- Comment #3 from John Miller --- Created attachment 29126 --> https://issues.apache.org/bugzilla/attachment.cgi?id=29126&action=edit GC roots for top heap consumer -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53615] java.lang.OutOfMemoryError: GC overhead limit exceeded after upgrading from 7.0.28 to 7.0.29
https://issues.apache.org/bugzilla/show_bug.cgi?id=53615 --- Comment #4 from John Miller --- Created attachment 29127 --> https://issues.apache.org/bugzilla/attachment.cgi?id=29127&action=edit javaClassCache -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53535] Out of memory while performing ContextConfig.webConfig
https://issues.apache.org/bugzilla/show_bug.cgi?id=53535 John Miller changed: What|Removed |Added Blocks||53615 -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53615] java.lang.OutOfMemoryError: GC overhead limit exceeded after upgrading from 7.0.28 to 7.0.29
https://issues.apache.org/bugzilla/show_bug.cgi?id=53615 John Miller changed: What|Removed |Added Depends on||53535 -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53615] java.lang.OutOfMemoryError: GC overhead limit exceeded after upgrading from 7.0.28 to 7.0.29
https://issues.apache.org/bugzilla/show_bug.cgi?id=53615 John Miller changed: What|Removed |Added Depends on|53535 | -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53535] Out of memory while performing ContextConfig.webConfig
https://issues.apache.org/bugzilla/show_bug.cgi?id=53535 John Miller changed: What|Removed |Added Blocks|53615 | -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53615] java.lang.OutOfMemoryError: GC overhead limit exceeded after upgrading from 7.0.28 to 7.0.29
https://issues.apache.org/bugzilla/show_bug.cgi?id=53615 John Miller changed: What|Removed |Added Depends on||53535 -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53535] Out of memory while performing ContextConfig.webConfig
https://issues.apache.org/bugzilla/show_bug.cgi?id=53535 John Miller changed: What|Removed |Added Blocks||53615 -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53615] java.lang.OutOfMemoryError: GC overhead limit exceeded after upgrading from 7.0.28 to 7.0.29
https://issues.apache.org/bugzilla/show_bug.cgi?id=53615 John Miller changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #5 from John Miller --- *** This bug has been marked as a duplicate of bug 53535 *** -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53535] Out of memory while performing ContextConfig.webConfig
https://issues.apache.org/bugzilla/show_bug.cgi?id=53535 John Miller changed: What|Removed |Added CC||s.highlan...@gmail.com --- Comment #3 from John Miller --- *** Bug 53615 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1366708 - /tomcat/trunk/test/org/apache/catalina/authenticator/TesterDigestAuthenticatorPerformance.java
Author: markt Date: Sat Jul 28 16:50:11 2012 New Revision: 1366708 URL: http://svn.apache.org/viewvc?rev=1366708&view=rev Log: Fix (normally unused) DIGEST performance test. Failing to clear the cached principal meant that the DIGEST auth was only performed once per thread Modified: tomcat/trunk/test/org/apache/catalina/authenticator/TesterDigestAuthenticatorPerformance.java Modified: tomcat/trunk/test/org/apache/catalina/authenticator/TesterDigestAuthenticatorPerformance.java URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/authenticator/TesterDigestAuthenticatorPerformance.java?rev=1366708&r1=1366707&r2=1366708&view=diff == --- tomcat/trunk/test/org/apache/catalina/authenticator/TesterDigestAuthenticatorPerformance.java (original) +++ tomcat/trunk/test/org/apache/catalina/authenticator/TesterDigestAuthenticatorPerformance.java Sat Jul 28 16:50:11 2012 @@ -52,7 +52,7 @@ public class TesterDigestAuthenticatorPe @Test public void testSimple() throws Exception { -doTest(100, 100); +doTest(4, 10); } public void doTest(int threadCount, int requestCount) throws Exception { @@ -155,6 +155,8 @@ public class TesterDigestAuthenticatorPe if (authenticator.authenticate(request, response)) { success++; } +// Clear out authenticated user ready for next iteration +request.setUserPrincipal(null); } catch (IOException ioe) { // Ignore } - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1366709 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/catalina/authenticator/TesterDigestAuthenticatorPerformance.java
Author: markt Date: Sat Jul 28 16:51:51 2012 New Revision: 1366709 URL: http://svn.apache.org/viewvc?rev=1366709&view=rev Log: Fix (normally unused) DIGEST performance test. Failing to clear the cached principal meant that the DIGEST auth was only performed once per thread Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/test/org/apache/catalina/authenticator/TesterDigestAuthenticatorPerformance.java Propchange: tomcat/tc7.0.x/trunk/ -- Merged /tomcat/trunk:r1366708 Modified: tomcat/tc7.0.x/trunk/test/org/apache/catalina/authenticator/TesterDigestAuthenticatorPerformance.java URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/test/org/apache/catalina/authenticator/TesterDigestAuthenticatorPerformance.java?rev=1366709&r1=1366708&r2=1366709&view=diff == --- tomcat/tc7.0.x/trunk/test/org/apache/catalina/authenticator/TesterDigestAuthenticatorPerformance.java (original) +++ tomcat/tc7.0.x/trunk/test/org/apache/catalina/authenticator/TesterDigestAuthenticatorPerformance.java Sat Jul 28 16:51:51 2012 @@ -52,7 +52,7 @@ public class TesterDigestAuthenticatorPe @Test public void testSimple() throws Exception { -doTest(100, 100); +doTest(4, 10); } public void doTest(int threadCount, int requestCount) throws Exception { @@ -153,6 +153,8 @@ public class TesterDigestAuthenticatorPe if (authenticator.authenticate(request, response, config)) { success++; } +// Clear out authenticated user ready for next iteration +request.setUserPrincipal(null); } catch (IOException ioe) { // Ignore } - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1366720 - /tomcat/trunk/java/org/apache/catalina/authenticator/DigestAuthenticator.java
Author: markt Date: Sat Jul 28 18:01:47 2012 New Revision: 1366720 URL: http://svn.apache.org/viewvc?rev=1366720&view=rev Log: No need to parse user name twice with different methods Modified: tomcat/trunk/java/org/apache/catalina/authenticator/DigestAuthenticator.java Modified: tomcat/trunk/java/org/apache/catalina/authenticator/DigestAuthenticator.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/authenticator/DigestAuthenticator.java?rev=1366720&r1=1366719&r2=1366720&view=diff == --- tomcat/trunk/java/org/apache/catalina/authenticator/DigestAuthenticator.java (original) +++ tomcat/trunk/java/org/apache/catalina/authenticator/DigestAuthenticator.java Sat Jul 28 18:01:47 2012 @@ -244,7 +244,7 @@ public class DigestAuthenticator extends } if (principal != null) { -String username = parseUsername(authorization); +String username = digestInfo.getUsername(); register(request, response, principal, HttpServletRequest.DIGEST_AUTH, username, null); return (true); @@ -280,7 +280,10 @@ public class DigestAuthenticator extends * can be identified, return null * * @param authorization Authorization string to be parsed + * + * @deprecated Unused. Will be removed in Tomcat 8.0.x */ +@Deprecated protected String parseUsername(String authorization) { // Validate the authorization credentials format @@ -486,6 +489,12 @@ public class DigestAuthenticator extends this.validateUri = validateUri; } + +public String getUsername() { +return userName; +} + + public boolean validate(Request request, String authorization) { // Validate the authorization credentials format if (authorization == null) { - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1366721 - /tomcat/trunk/java/org/apache/catalina/authenticator/DigestAuthenticator.java
Author: markt Date: Sat Jul 28 18:02:27 2012 New Revision: 1366721 URL: http://svn.apache.org/viewvc?rev=1366721&view=rev Log: Remove unnecessary code Modified: tomcat/trunk/java/org/apache/catalina/authenticator/DigestAuthenticator.java Modified: tomcat/trunk/java/org/apache/catalina/authenticator/DigestAuthenticator.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/authenticator/DigestAuthenticator.java?rev=1366721&r1=1366720&r2=1366721&view=diff == --- tomcat/trunk/java/org/apache/catalina/authenticator/DigestAuthenticator.java (original) +++ tomcat/trunk/java/org/apache/catalina/authenticator/DigestAuthenticator.java Sat Jul 28 18:02:27 2012 @@ -14,18 +14,14 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - - package org.apache.catalina.authenticator; - import java.io.IOException; import java.security.MessageDigest; import java.security.NoSuchAlgorithmException; import java.security.Principal; import java.util.LinkedHashMap; import java.util.Map; -import java.util.StringTokenizer; import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletResponse; @@ -39,7 +35,6 @@ import org.apache.juli.logging.LogFactor import org.apache.tomcat.util.buf.B2CConverter; - /** * An Authenticator and Valve implementation of HTTP DIGEST * Authentication (see RFC 2069). @@ -48,7 +43,6 @@ import org.apache.tomcat.util.buf.B2CCon * @author Remy Maucherat * @version $Id$ */ - public class DigestAuthenticator extends AuthenticatorBase { private static final Log log = LogFactory.getLog(DigestAuthenticator.class); @@ -276,49 +270,6 @@ public class DigestAuthenticator extends /** - * Parse the username from the specified authorization string. If none - * can be identified, return null - * - * @param authorization Authorization string to be parsed - * - * @deprecated Unused. Will be removed in Tomcat 8.0.x - */ -@Deprecated -protected String parseUsername(String authorization) { - -// Validate the authorization credentials format -if (authorization == null) { -return (null); -} -if (!authorization.startsWith("Digest ")) { -return (null); -} -authorization = authorization.substring(7).trim(); - -StringTokenizer commaTokenizer = -new StringTokenizer(authorization, ","); - -while (commaTokenizer.hasMoreTokens()) { -String currentToken = commaTokenizer.nextToken(); -int equalSign = currentToken.indexOf('='); -if (equalSign < 0) { -return null; -} -String currentTokenName = -currentToken.substring(0, equalSign).trim(); -String currentTokenValue = -currentToken.substring(equalSign + 1).trim(); -if ("username".equals(currentTokenName)) { -return (removeQuotes(currentTokenValue)); -} -} - -return (null); - -} - - -/** * Removes the quotes on a string. RFC2617 states quotes are optional for * all parameters except realm. */ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1366723 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/authenticator/DigestAuthenticator.java
Author: markt Date: Sat Jul 28 18:04:29 2012 New Revision: 1366723 URL: http://svn.apache.org/viewvc?rev=1366723&view=rev Log: Don't parse username twice with different methods Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/catalina/authenticator/DigestAuthenticator.java Propchange: tomcat/tc7.0.x/trunk/ -- Merged /tomcat/trunk:r1366720 Modified: tomcat/tc7.0.x/trunk/java/org/apache/catalina/authenticator/DigestAuthenticator.java URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/authenticator/DigestAuthenticator.java?rev=1366723&r1=1366722&r2=1366723&view=diff == --- tomcat/tc7.0.x/trunk/java/org/apache/catalina/authenticator/DigestAuthenticator.java (original) +++ tomcat/tc7.0.x/trunk/java/org/apache/catalina/authenticator/DigestAuthenticator.java Sat Jul 28 18:04:29 2012 @@ -273,7 +273,7 @@ public class DigestAuthenticator extends } if (principal != null) { -String username = parseUsername(authorization); +String username = digestInfo.getUsername(); register(request, response, principal, HttpServletRequest.DIGEST_AUTH, username, null); @@ -310,7 +310,10 @@ public class DigestAuthenticator extends * can be identified, return null * * @param authorization Authorization string to be parsed + * + * @deprecated Unused. Will be removed in Tomcat 8.0.x */ +@Deprecated protected String parseUsername(String authorization) { // Validate the authorization credentials format @@ -518,6 +521,11 @@ public class DigestAuthenticator extends this.validateUri = validateUri; } + +public String getUsername() { +return userName; +} + public boolean validate(Request request, String authorization, LoginConfig config) { // Validate the authorization credentials format - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1366726 - /tomcat/trunk/java/org/apache/catalina/tribes/group/ChannelCoordinator.java
Author: markt Date: Sat Jul 28 18:29:04 2012 New Revision: 1366726 URL: http://svn.apache.org/viewvc?rev=1366726&view=rev Log: Clean-up. Refactor to avoid unnecessary object creation when not using default constructor Modified: tomcat/trunk/java/org/apache/catalina/tribes/group/ChannelCoordinator.java Modified: tomcat/trunk/java/org/apache/catalina/tribes/group/ChannelCoordinator.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/group/ChannelCoordinator.java?rev=1366726&r1=1366725&r2=1366726&view=diff == --- tomcat/trunk/java/org/apache/catalina/tribes/group/ChannelCoordinator.java (original) +++ tomcat/trunk/java/org/apache/catalina/tribes/group/ChannelCoordinator.java Sat Jul 28 18:29:04 2012 @@ -41,23 +41,25 @@ import org.apache.catalina.tribes.util.L * @version $Id$ */ public class ChannelCoordinator extends ChannelInterceptorBase implements MessageListener { -private ChannelReceiver clusterReceiver = new NioReceiver(); -private ChannelSender clusterSender = new ReplicationTransmitter(); -private MembershipService membershipService = new McastService(); +private ChannelReceiver clusterReceiver; +private ChannelSender clusterSender; +private MembershipService membershipService; private int startLevel = 0; public ChannelCoordinator() { -// Override default -this.optionFlag = Channel.SEND_OPTIONS_BYTE_MESSAGE | -Channel.SEND_OPTIONS_USE_ACK | -Channel.SEND_OPTIONS_SYNCHRONIZED_ACK; +this(new NioReceiver(), new ReplicationTransmitter(), +new McastService()); } public ChannelCoordinator(ChannelReceiver receiver, ChannelSender sender, MembershipService service) { -this(); + +this.optionFlag = Channel.SEND_OPTIONS_BYTE_MESSAGE | +Channel.SEND_OPTIONS_USE_ACK | +Channel.SEND_OPTIONS_SYNCHRONIZED_ACK; + this.setClusterReceiver(receiver); this.setClusterSender(sender); this.setMembershipService(service); - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1366727 - in /tomcat/trunk/java/org/apache/catalina/tribes/group: GroupChannel.java RpcChannel.java
Author: markt Date: Sat Jul 28 18:33:19 2012 New Revision: 1366727 URL: http://svn.apache.org/viewvc?rev=1366727&view=rev Log: Partial code clean-up for o.a.catalina.tribes - Add final prompted by UCDetector - Java 7 use of <> Modified: tomcat/trunk/java/org/apache/catalina/tribes/group/GroupChannel.java tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java Modified: tomcat/trunk/java/org/apache/catalina/tribes/group/GroupChannel.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/group/GroupChannel.java?rev=1366727&r1=1366726&r2=1366727&view=diff == --- tomcat/trunk/java/org/apache/catalina/tribes/group/GroupChannel.java (original) +++ tomcat/trunk/java/org/apache/catalina/tribes/group/GroupChannel.java Sat Jul 28 18:33:19 2012 @@ -80,7 +80,7 @@ public class GroupChannel extends Channe * - ChannelSender * - ChannelReceiver */ -protected ChannelCoordinator coordinator = new ChannelCoordinator(); +protected final ChannelCoordinator coordinator = new ChannelCoordinator(); /** * The first interceptor in the interceptor stack. @@ -92,12 +92,12 @@ public class GroupChannel extends Channe /** * A list of membership listeners that subscribe to membership announcements */ -protected ArrayList membershipListeners = new ArrayList(); +protected final ArrayList membershipListeners = new ArrayList<>(); /** * A list of channel listeners that subscribe to incoming messages */ -protected ArrayList channelListeners = new ArrayList(); +protected final ArrayList channelListeners = new ArrayList<>(); /** * If set to true, the GroupChannel will check to make sure that @@ -622,7 +622,7 @@ public class GroupChannel extends Channe * @version 1.0 */ public static class InterceptorIterator implements Iterator { -private ChannelInterceptor end; +private final ChannelInterceptor end; private ChannelInterceptor start; public InterceptorIterator(ChannelInterceptor start, ChannelInterceptor end) { this.end = end; @@ -667,8 +667,8 @@ public class GroupChannel extends Channe } protected volatile boolean doRun = true; -protected GroupChannel channel; -protected long sleepTime; +protected final GroupChannel channel; +protected final long sleepTime; public HeartbeatThread(GroupChannel channel, long sleepTime) { super(); this.setPriority(MIN_PRIORITY); Modified: tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java?rev=1366727&r1=1366726&r2=1366727&view=diff == --- tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java (original) +++ tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java Sat Jul 28 18:33:19 2012 @@ -48,7 +48,8 @@ public class RpcChannel implements Chann private byte[] rpcId; private int replyMessageOptions = 0; -private HashMap responseMap = new HashMap(); +private final HashMap responseMap = +new HashMap<>(); /** * Create an RPC channel. You can have several RPC channels attached to a group @@ -226,11 +227,11 @@ public class RpcChannel implements Chann * @version 1.0 */ public static class RpcCollector { -public ArrayList responses = new ArrayList(); -public RpcCollectorKey key; -public int options; +public final ArrayList responses = new ArrayList<>(); +public final RpcCollectorKey key; +public final int options; public int destcnt; -public long timeout; +public final long timeout; public RpcCollector(RpcCollectorKey key, int options, int destcnt, long timeout) { this.key = key; @@ -280,7 +281,7 @@ public class RpcChannel implements Chann } public static class RpcCollectorKey { -byte[] id; +final byte[] id; public RpcCollectorKey(byte[] id) { this.id = id; } - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1366729 - /tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java
Author: markt Date: Sat Jul 28 18:34:00 2012 New Revision: 1366729 URL: http://svn.apache.org/viewvc?rev=1366729&view=rev Log: Deprecate unused code Modified: tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java Modified: tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java?rev=1366729&r1=1366728&r2=1366729&view=diff == --- tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java (original) +++ tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java Sat Jul 28 18:34:00 2012 @@ -301,6 +301,10 @@ public class RpcChannel implements Chann } +/** + * @deprecated Unused - will be removed in Tomcat 8.0.x + */ +@Deprecated protected static String bToS(byte[] data) { StringBuilder buf = new StringBuilder(4*16); buf.append("{"); - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1366730 - /tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java
Author: markt Date: Sat Jul 28 18:34:24 2012 New Revision: 1366730 URL: http://svn.apache.org/viewvc?rev=1366730&view=rev Log: Remove unused code Modified: tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java Modified: tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java?rev=1366730&r1=1366729&r2=1366730&view=diff == --- tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java (original) +++ tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java Sat Jul 28 18:34:24 2012 @@ -300,18 +300,4 @@ public class RpcChannel implements Chann } } - -/** - * @deprecated Unused - will be removed in Tomcat 8.0.x - */ -@Deprecated -protected static String bToS(byte[] data) { -StringBuilder buf = new StringBuilder(4*16); -buf.append("{"); -for (int i=0; data!=null && i
svn commit: r1366731 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/tribes/group/RpcChannel.java
Author: markt Date: Sat Jul 28 18:35:33 2012 New Revision: 1366731 URL: http://svn.apache.org/viewvc?rev=1366731&view=rev Log: Deprecate unused code Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java Propchange: tomcat/tc7.0.x/trunk/ -- Merged /tomcat/trunk:r1366729 Modified: tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java?rev=1366731&r1=1366730&r2=1366731&view=diff == --- tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java (original) +++ tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java Sat Jul 28 18:35:33 2012 @@ -300,6 +300,10 @@ public class RpcChannel implements Chann } +/** + * @deprecated Unused - will be removed in Tomcat 8.0.x + */ +@Deprecated protected static String bToS(byte[] data) { StringBuilder buf = new StringBuilder(4*16); buf.append("{"); - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1366734 - /tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java
Author: markt Date: Sat Jul 28 18:44:39 2012 New Revision: 1366734 URL: http://svn.apache.org/viewvc?rev=1366734&view=rev Log: Deprecate unused parameter Modified: tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java Modified: tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java?rev=1366734&r1=1366733&r2=1366734&view=diff == --- tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java (original) +++ tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java Sat Jul 28 18:44:39 2012 @@ -89,7 +89,7 @@ public class RpcChannel implements Chann channelOptions & ~Channel.SEND_OPTIONS_SYNCHRONIZED_ACK; RpcCollectorKey key = new RpcCollectorKey(UUIDGenerator.randomUUID(false)); -RpcCollector collector = new RpcCollector(key,rpcOptions,destination.length,timeout); +RpcCollector collector = new RpcCollector(key,rpcOptions,destination.length); try { synchronized (collector) { if ( rpcOptions != NO_REPLY ) responseMap.put(key, collector); @@ -231,15 +231,29 @@ public class RpcChannel implements Chann public final RpcCollectorKey key; public final int options; public int destcnt; +/** + * @deprecated Unused - will be removed in Tomcat 8.0.x + */ +@Deprecated public final long timeout; -public RpcCollector(RpcCollectorKey key, int options, int destcnt, long timeout) { +/** + * @deprecated Use {@link RpcCollector#RpcCollector(RpcCollectorKey, + * int, int)} + */ +@Deprecated +public RpcCollector(RpcCollectorKey key, int options, int destcnt, +long timeout) { this.key = key; this.options = options; this.destcnt = destcnt; this.timeout = timeout; } +public RpcCollector(RpcCollectorKey key, int options, int destcnt) { +this(key, options, destcnt, 0); +} + public void addResponse(Serializable message, Member sender){ Response resp = new Response(sender,message); responses.add(resp); - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1366735 - /tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java
Author: markt Date: Sat Jul 28 18:45:25 2012 New Revision: 1366735 URL: http://svn.apache.org/viewvc?rev=1366735&view=rev Log: Remove deprecated code Modified: tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java Modified: tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java?rev=1366735&r1=1366734&r2=1366735&view=diff == --- tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java (original) +++ tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java Sat Jul 28 18:45:25 2012 @@ -231,27 +231,11 @@ public class RpcChannel implements Chann public final RpcCollectorKey key; public final int options; public int destcnt; -/** - * @deprecated Unused - will be removed in Tomcat 8.0.x - */ -@Deprecated -public final long timeout; - -/** - * @deprecated Use {@link RpcCollector#RpcCollector(RpcCollectorKey, - * int, int)} - */ -@Deprecated -public RpcCollector(RpcCollectorKey key, int options, int destcnt, -long timeout) { + +public RpcCollector(RpcCollectorKey key, int options, int destcnt) { this.key = key; this.options = options; this.destcnt = destcnt; -this.timeout = timeout; -} - -public RpcCollector(RpcCollectorKey key, int options, int destcnt) { -this(key, options, destcnt, 0); } public void addResponse(Serializable message, Member sender){ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1366736 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/tribes/group/RpcChannel.java
Author: markt Date: Sat Jul 28 18:47:00 2012 New Revision: 1366736 URL: http://svn.apache.org/viewvc?rev=1366736&view=rev Log: Deprecate unused code Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java Propchange: tomcat/tc7.0.x/trunk/ -- Merged /tomcat/trunk:r1366734 Modified: tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java?rev=1366736&r1=1366735&r2=1366736&view=diff == --- tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java (original) +++ tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java Sat Jul 28 18:47:00 2012 @@ -88,7 +88,7 @@ public class RpcChannel implements Chann channelOptions & ~Channel.SEND_OPTIONS_SYNCHRONIZED_ACK; RpcCollectorKey key = new RpcCollectorKey(UUIDGenerator.randomUUID(false)); -RpcCollector collector = new RpcCollector(key,rpcOptions,destination.length,timeout); +RpcCollector collector = new RpcCollector(key,rpcOptions,destination.length); try { synchronized (collector) { if ( rpcOptions != NO_REPLY ) responseMap.put(key, collector); @@ -230,15 +230,29 @@ public class RpcChannel implements Chann public RpcCollectorKey key; public int options; public int destcnt; +/** + * @deprecated Unused - will be removed in Tomcat 8.0.x + */ +@Deprecated public long timeout; - -public RpcCollector(RpcCollectorKey key, int options, int destcnt, long timeout) { + +/** + * @deprecated Use {@link RpcCollector#RpcCollector(RpcCollectorKey, + * int, int)} + */ +@Deprecated +public RpcCollector(RpcCollectorKey key, int options, int destcnt, +long timeout) { this.key = key; this.options = options; this.destcnt = destcnt; this.timeout = timeout; } +public RpcCollector(RpcCollectorKey key, int options, int destcnt) { +this(key, options, destcnt, 0); +} + public void addResponse(Serializable message, Member sender){ Response resp = new Response(sender,message); responses.add(resp); - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
buildbot success in ASF Buildbot on tomcat-7-trunk
The Buildbot has detected a restored build on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/751 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source Stamp: [branch tomcat/tc7.0.x/trunk] 1366736 Blamelist: markt Build succeeded! sincerely, -The Buildbot
[GUMP@vmgump]: Project tomcat-trunk-validate-eoln (in module tomcat-trunk) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-validate-eoln has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 31 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-trunk-validate-eoln : Tomcat 8.x, a web server implementing Java Servlet 3.1, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate-eoln/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -INFO- Failed with reason build failed The following work was performed: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate-eoln/gump_work/build_tomcat-trunk_tomcat-trunk-validate-eoln.html Work Name: build_tomcat-trunk_tomcat-trunk-validate-eoln (Type: Build) Work ended in a state of : Failed Elapsed: 1 sec Command Line: /usr/lib/jvm/java-6-openjdk/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml validate-eoln [Working Directory: /srv/gump/public/workspace/tomcat-trunk] CLASSPATH: /usr/lib/jvm/java-6-openjdk/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/classes:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar - Buildfile: /srv/gump/public/workspace/tomcat-trunk/build.xml build-prepare: [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/classes [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/build [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/build/bin [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/build/conf [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/build/lib [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/build/logs [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/build/temp [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/build/webapps compile-prepare: [copy] Copying 1 file to /srv/gump/public/workspace/tomcat-trunk/java/org/apache/catalina/startup [copy] Copying 1 file to /srv/gump/public/workspace/tomcat-trunk/webapps/docs validate-eoln: [javac] Compiling 1 source file to /srv/gump/public/workspace/tomcat-trunk/output/classes [javac] javac: invalid target release: 1.7 [javac] Usage: javac [javac] use -help for a list of possible options BUILD FAILED /srv/gump/public/workspace/tomcat-trunk/build.xml:523: Compile failed; see the compiler error output for details. Total time: 1 second - To subscribe to this information via syndicated feeds: - RSS: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate-eoln/rss.xml - Atom: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate-eoln/atom.xml == Gump Tracking Only === Produced by Apache Gump(TM) version 2.3. Gump Run 1229072012, vmgump.apache.org:vmgump:1229072012 Gump E-mail Identifier (unique within run) #6. -- Apache Gump http://gump.apache.org/ [Instance: vmgump] - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GUMP@vmgump]: Project tomcat-trunk-dbcp (in module tomcat-trunk) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-dbcp has an issue affecting its community integration. This issue affects 3 projects, and has been outstanding for 31 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-trunk : Tomcat 8.x, a web server implementing Java Servlet 3.1, ... - tomcat-trunk-dbcp : Tomcat 8.x, a web server implementing Java Servlet 3.1, ... - tomcat-trunk-test : Tomcat 8.x, a web server implementing Java Servlet 3.1, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-dbcp/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -INFO- Made directory [/srv/gump/public/workspace/tomcat-trunk/tomcat-deps] -INFO- Failed with reason build failed -INFO- Failed to extract fallback artifacts from Gump Repository The following work was performed: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-dbcp/gump_work/build_tomcat-trunk_tomcat-trunk-dbcp.html Work Name: build_tomcat-trunk_tomcat-trunk-dbcp (Type: Build) Work ended in a state of : Failed Elapsed: 2 secs Command Line: /usr/lib/jvm/java-6-openjdk/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Dcommons-pool.home=/srv/gump/public/workspace/commons-pool-1.x -Dcommons-dbcp.home=/srv/gump/public/workspace/commons-dbcp-1.x -Dtomcat-dbcp.jar=/srv/gump/public/workspace/tomcat-trunk/tomcat-deps/tomcat-dbcp-29072012.jar -Dtomcat-dbcp.home=/srv/gump/public/workspace/tomcat-trunk/tomcat-deps build-tomcat-dbcp [Working Directory: /srv/gump/public/workspace/tomcat-trunk] CLASSPATH: /usr/lib/jvm/java-6-openjdk/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/packages/jta-spec1_0_1/jta-spec1_0_1.jar - Buildfile: /srv/gump/public/workspace/tomcat-trunk/build.xml build-prepare: [delete] Deleting directory /srv/gump/public/workspace/tomcat-trunk/output/build/temp [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/build/temp build-manifests: [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/manifests [copy] Copying 12 files to /srv/gump/public/workspace/tomcat-trunk/output/manifests build-tomcat-dbcp: [copy] Copying 70 files to /srv/gump/public/workspace/tomcat-trunk/tomcat-deps [patch] patching file src/java/org/apache/commons/dbcp/DelegatingCallableStatement.java [patch] Hunk #1 succeeded at 661 (offset -113 lines). [patch] patching file src/java/org/apache/commons/dbcp/cpdsadapter/DriverAdapterCPDS.java [patch] patching file src/java/org/apache/commons/dbcp/DelegatingResultSet.java [patch] Hunk #1 succeeded at 1079 (offset -195 lines). [patch] patching file src/java/org/apache/commons/dbcp/PoolingDataSource.java [patch] Hunk #1 succeeded at 437 (offset -52 lines). [patch] patching file src/java/org/apache/commons/dbcp/DelegatingConnection.java [patch] Hunk #1 succeeded at 678 (offset -126 lines). [patch] patching file src/java/org/apache/commons/dbcp/PoolingDriver.java [patch] Hunk #1 succeeded at 497 (offset -4 lines). [patch] patching file src/java/org/apache/commons/dbcp/DelegatingStatement.java [patch] Hunk #1 succeeded at 484 (offset -45 lines). [patch] patching file src/java/org/apache/commons/dbcp/DelegatingDatabaseMetaData.java [patch] Hunk #1 succeeded at 1204 (offset -173 lines). [patch] patching file src/java/org/apache/commons/dbcp/BasicDataSource.java [patch] Hunk #1 succeeded at 28 with fuzz 1. [patch] Hunk #2 succeeded at 1782 (offset -19 lines). [patch] patching file src/java/org/apache/commons/dbcp/datasources/InstanceKeyDataSource.java [patch] Hunk #1 succeeded at 887 (offset -1 lines). [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/tomcat-deps/src/java/org/apache/tomcat/dbcp [move] Moving 75 files to /srv/gump/public/workspace/tomcat-trunk/tomcat-deps/src/java/org/apache/tomcat/dbcp [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/tomcat-deps/classes [javac] Compiling 66 source files to /srv
[GUMP@vmgump]: Project tomcat-tc7.0.x-validate (in module tomcat-7.0.x) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-validate has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 31 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-tc7.0.x-validate : Tomcat 7.x, a web server implementing Java Servlet 3.0, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-validate/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on checkstyle exists, no need to add for property checkstyle.jar. -INFO- Failed with reason build failed The following work was performed: http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-validate/gump_work/build_tomcat-7.0.x_tomcat-tc7.0.x-validate.html Work Name: build_tomcat-7.0.x_tomcat-tc7.0.x-validate (Type: Build) Work ended in a state of : Failed Elapsed: 1 sec Command Line: /usr/lib/jvm/java-6-openjdk/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/checkstyle-5.6-SNAPSHOT.jar -Dexecute.validate=true validate [Working Directory: /srv/gump/public/workspace/tomcat-7.0.x] CLASSPATH: /usr/lib/jvm/java-6-openjdk/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-5.6-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-29072012.jar:/srv/gump/public/workspace/apache-commons/cli/target/commons-cli-1.3-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/exec/target/commons-exec-1.1.1-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/validator/dist/commons-validator-29072012.jar:/srv/gump/public/workspace/junit/dist/junit-29072012.jar:/srv/gump /public/workspace/junit/dist/junit-dep-29072012.jar:/srv/gump/public/workspace/google-guava/guava/target/guava-*[0-9T].jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-29072012.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-29072012.jar:/srv/gump/public/workspace/commons-collections-3.x/target/commons-collections-3.3-SNAPSHOT.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/jdom/build/jdom.jar:/srv/gump/public/workspace/velocity-engine/bin/velocity-29072012.jar:/srv/gump/public/workspace/velocity-engine/bin/velocity-29072012-dep.jar - download-validate: proxyflags: setproxy: testexist: [echo] Testing for /srv/gump/public/workspace/checkstyle/target/checkstyle-5.6-SNAPSHOT.jar downloadzip: validate: [mkdir] Created dir: /srv/gump/public/workspace/tomcat-7.0.x/output/res/checkstyle BUILD FAILED /srv/gump/public/workspace/tomcat-7.0.x/build.xml:450: Could not create type checkstyle due to java.lang.NoClassDefFoundError: com/google/common/collect/Lists at com.puppycrawl.tools.checkstyle.CheckStyleTask.(CheckStyleTask.java:78) at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:57) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.lang.reflect.Constructor.newInstance(Constructor.java:532) at org.apache.tools.ant.AntTypeDefinition.innerCreateAndSet(AntTypeDefinition.java:328) at org.apache.tools.ant.AntTypeDefinition.createAndSet(AntTypeDefinition.java:274) at org.apache.tools.ant.AntTypeDefinition.icreate(AntTypeDefinition.java:219) at org.apache.tools.ant.AntTypeDefinition.create(AntTypeDefinition.java:206) at org.apache.tools.ant.ComponentHelper.createComponent(ComponentHelper.java:286) at org.apache.tools.ant.ComponentHelper.createComponent(ComponentHelper.java:264) at org.apache.tools.ant.UnknownElement.makeObject(UnknownElement.java:417) at org.apache.tools.ant.UnknownElement.maybeConfigure(UnknownElement.java:163) at org.apache.tools.ant.Task.perform(Task.java:347)
[GUMP@vmgump]: Project tomcat-trunk-validate (in module tomcat-trunk) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-validate has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 31 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-trunk-validate : Tomcat 8.x, a web server implementing Java Servlet 3.1, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on checkstyle exists, no need to add for property checkstyle.jar. -INFO- Failed with reason build failed The following work was performed: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/gump_work/build_tomcat-trunk_tomcat-trunk-validate.html Work Name: build_tomcat-trunk_tomcat-trunk-validate (Type: Build) Work ended in a state of : Failed Elapsed: 1 sec Command Line: /usr/lib/jvm/java-6-openjdk/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/checkstyle-5.6-SNAPSHOT.jar -Dexecute.validate=true validate [Working Directory: /srv/gump/public/workspace/tomcat-trunk] CLASSPATH: /usr/lib/jvm/java-6-openjdk/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-5.6-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-29072012.jar:/srv/gump/public/workspace/apache-commons/cli/target/commons-cli-1.3-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/exec/target/commons-exec-1.1.1-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/validator/dist/commons-validator-29072012.jar:/srv/gump/public/workspace/junit/dist/junit-29072012.jar:/srv/gump /public/workspace/junit/dist/junit-dep-29072012.jar:/srv/gump/public/workspace/google-guava/guava/target/guava-*[0-9T].jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-29072012.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-29072012.jar:/srv/gump/public/workspace/commons-collections-3.x/target/commons-collections-3.3-SNAPSHOT.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/jdom/build/jdom.jar:/srv/gump/public/workspace/velocity-engine/bin/velocity-29072012.jar:/srv/gump/public/workspace/velocity-engine/bin/velocity-29072012-dep.jar:/srv/gump/packages/javamail-1.4/mail.jar:/srv/gump/packages/javamail-1.4/lib/mailapi.jar:/srv/gump/packages/jaf-1.1ea/activation.jar - download-validate: proxyflags: setproxy: testexist: [echo] Testing for /srv/gump/public/workspace/checkstyle/target/checkstyle-5.6-SNAPSHOT.jar downloadzip: validate: [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/res/checkstyle BUILD FAILED /srv/gump/public/workspace/tomcat-trunk/build.xml:461: Could not create type checkstyle due to java.lang.NoClassDefFoundError: com/google/common/collect/Lists at com.puppycrawl.tools.checkstyle.CheckStyleTask.(CheckStyleTask.java:78) at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:57) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.lang.reflect.Constructor.newInstance(Constructor.java:532) at org.apache.tools.ant.AntTypeDefinition.innerCreateAndSet(AntTypeDefinition.java:328) at org.apache.tools.ant.AntTypeDefinition.createAndSet(AntTypeDefinition.java:274) at org.apache.tools.ant.AntTypeDefinition.icreate(AntTypeDefinition.java:219) at org.apache.tools.ant.AntTypeDefinition.create(AntTypeDefinition.java:206) at org.apache.tools.ant.ComponentHelper.createComponent(ComponentHelper.java:286) at org.apache.tools.ant.ComponentHelper.createComponent(ComponentHelper.java:264) at org.apache.tools.ant.UnknownElement.makeObject(UnknownElement.java:417) at org.apache.tools.an