[Bug 53138] Not able to download a file size of 740KB using NIO connector in tomcat version 7.0.27. But with the same configuration I was able to download that in tomcat 7.0.26.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53138 Robert Kish changed: What|Removed |Added CC||robert.k...@ncogroup.com -- You are receiving this mail because: You are the assignee for the bug.
[Bug 53138] Not able to download a file size of 740KB using NIO connector in tomcat version 7.0.27. But with the same configuration I was able to download that in tomcat 7.0.26.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53138 --- Comment #2 from Robert Kish --- I am having the same problem with my application. We have noticed only some files are not downloading, not all of them - there's no apparent pattern to the file size. We had one file that's 115397 download, but another that's 58 fail. What made it interesting was that the file did not download in IE 8, but the file did download in FF 12. This leads me to believe it's something browser specific about downloading the file. My searches led me to an item for 7.0.27, https://issues.apache.org/bugzilla/show_bug.cgi?id=52858 that looked interesting. Perhaps the issue relates to that change. -- You are receiving this mail because: You are the assignee for the bug.
[jira] [Created] (MTOMCAT-149) Error deploying on Tomcat 6
costas created MTOMCAT-149: -- Summary: Error deploying on Tomcat 6 Key: MTOMCAT-149 URL: https://issues.apache.org/jira/browse/MTOMCAT-149 Project: Apache Tomcat Maven Plugin Issue Type: Bug Components: tomcat6 Affects Versions: 2.0-beta-1 Environment: Apache Maven 2.2.1 (r801777; 2009-08-06 21:16:01+0200) Java version: 1.6.0_31 Java home: /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home Default locale: en_US, platform encoding: MacRoman OS name: "mac os x" version: "10.7.3" arch: "x86_64" Family: "mac" Reporter: costas Assignee: Olivier Lamy (*$^¨%`£) Deploying on Tomcat 6 throws the following exception: Caused by: org.apache.http.client.ClientProtocolException at org.apache.http.impl.client.AbstractHttpClient.execute(AbstractHttpClient.java:926) at org.apache.http.impl.client.AbstractHttpClient.execute(AbstractHttpClient.java:822) at org.apache.tomcat.maven.common.deployer.TomcatManager.invoke(TomcatManager.java:718) at org.apache.tomcat.maven.common.deployer.TomcatManager.deployImpl(TomcatManager.java:681) at org.apache.tomcat.maven.common.deployer.TomcatManager.deploy(TomcatManager.java:363) at org.apache.tomcat.maven.plugin.tomcat6.AbstractDeployWarMojo.deployWar(AbstractDeployWarMojo.java:87) at org.apache.tomcat.maven.plugin.tomcat6.AbstractDeployMojo.invokeManager(AbstractDeployMojo.java:86) at org.apache.tomcat.maven.plugin.tomcat6.AbstractCatalinaMojo.execute(AbstractCatalinaMojo.java:143) ... 20 more Caused by: org.apache.http.client.NonRepeatableRequestException: Cannot retry request with a non-repeatable request entity. The cause lists the reason the original request failed. at org.apache.http.impl.client.DefaultRequestDirector.tryExecute(DefaultRequestDirector.java:682) at org.apache.http.impl.client.DefaultRequestDirector.execute(DefaultRequestDirector.java:515) at org.apache.http.impl.client.AbstractHttpClient.execute(AbstractHttpClient.java:923) ... 27 more Caused by: java.net.SocketException: Broken pipe at java.net.SocketOutputStream.socketWrite0(Native Method) at java.net.SocketOutputStream.socketWrite(SocketOutputStream.java:92) at java.net.SocketOutputStream.write(SocketOutputStream.java:136) at org.apache.http.impl.io.AbstractSessionOutputBuffer.write(AbstractSessionOutputBuffer.java:163) at org.apache.http.impl.io.ContentLengthOutputStream.write(ContentLengthOutputStream.java:119) at org.apache.tomcat.maven.common.deployer.TomcatManager$RequestEntityImplementation.writeTo(TomcatManager.java:825) at org.apache.http.entity.HttpEntityWrapper.writeTo(HttpEntityWrapper.java:98) at org.apache.http.impl.client.EntityEnclosingRequestWrapper$EntityWrapper.writeTo(EntityEnclosingRequestWrapper.java:108) at org.apache.http.impl.entity.EntitySerializer.serialize(EntitySerializer.java:122) at org.apache.http.impl.AbstractHttpClientConnection.sendRequestEntity(AbstractHttpClientConnection.java:266) at org.apache.http.impl.conn.ManagedClientConnectionImpl.sendRequestEntity(ManagedClientConnectionImpl.java:197) at org.apache.http.protocol.HttpRequestExecutor.doSendRequest(HttpRequestExecutor.java:257) at org.apache.http.protocol.HttpRequestExecutor.execute(HttpRequestExecutor.java:125) at org.apache.http.impl.client.DefaultRequestDirector.tryExecute(DefaultRequestDirector.java:708) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Closed] (MTOMCAT-149) Error deploying on Tomcat 6
[ https://issues.apache.org/jira/browse/MTOMCAT-149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy (*$^¨%`£) closed MTOMCAT-149. -- Resolution: Duplicate Fix Version/s: 2.0 please test last SNAPSHOT > Error deploying on Tomcat 6 > --- > > Key: MTOMCAT-149 > URL: https://issues.apache.org/jira/browse/MTOMCAT-149 > Project: Apache Tomcat Maven Plugin > Issue Type: Bug > Components: tomcat6 >Affects Versions: 2.0-beta-1 > Environment: Apache Maven 2.2.1 (r801777; 2009-08-06 21:16:01+0200) > Java version: 1.6.0_31 > Java home: /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home > Default locale: en_US, platform encoding: MacRoman > OS name: "mac os x" version: "10.7.3" arch: "x86_64" Family: "mac" >Reporter: costas >Assignee: Olivier Lamy (*$^¨%`£) > Fix For: 2.0 > > > Deploying on Tomcat 6 throws the following exception: > Caused by: org.apache.http.client.ClientProtocolException > at > org.apache.http.impl.client.AbstractHttpClient.execute(AbstractHttpClient.java:926) > at > org.apache.http.impl.client.AbstractHttpClient.execute(AbstractHttpClient.java:822) > at > org.apache.tomcat.maven.common.deployer.TomcatManager.invoke(TomcatManager.java:718) > at > org.apache.tomcat.maven.common.deployer.TomcatManager.deployImpl(TomcatManager.java:681) > at > org.apache.tomcat.maven.common.deployer.TomcatManager.deploy(TomcatManager.java:363) > at > org.apache.tomcat.maven.plugin.tomcat6.AbstractDeployWarMojo.deployWar(AbstractDeployWarMojo.java:87) > at > org.apache.tomcat.maven.plugin.tomcat6.AbstractDeployMojo.invokeManager(AbstractDeployMojo.java:86) > at > org.apache.tomcat.maven.plugin.tomcat6.AbstractCatalinaMojo.execute(AbstractCatalinaMojo.java:143) > ... 20 more > Caused by: org.apache.http.client.NonRepeatableRequestException: Cannot retry > request with a non-repeatable request entity. The cause lists the reason the > original request failed. > at > org.apache.http.impl.client.DefaultRequestDirector.tryExecute(DefaultRequestDirector.java:682) > at > org.apache.http.impl.client.DefaultRequestDirector.execute(DefaultRequestDirector.java:515) > at > org.apache.http.impl.client.AbstractHttpClient.execute(AbstractHttpClient.java:923) > ... 27 more > Caused by: java.net.SocketException: Broken pipe > at java.net.SocketOutputStream.socketWrite0(Native Method) > at java.net.SocketOutputStream.socketWrite(SocketOutputStream.java:92) > at java.net.SocketOutputStream.write(SocketOutputStream.java:136) > at > org.apache.http.impl.io.AbstractSessionOutputBuffer.write(AbstractSessionOutputBuffer.java:163) > at > org.apache.http.impl.io.ContentLengthOutputStream.write(ContentLengthOutputStream.java:119) > at > org.apache.tomcat.maven.common.deployer.TomcatManager$RequestEntityImplementation.writeTo(TomcatManager.java:825) > at > org.apache.http.entity.HttpEntityWrapper.writeTo(HttpEntityWrapper.java:98) > at > org.apache.http.impl.client.EntityEnclosingRequestWrapper$EntityWrapper.writeTo(EntityEnclosingRequestWrapper.java:108) > at > org.apache.http.impl.entity.EntitySerializer.serialize(EntitySerializer.java:122) > at > org.apache.http.impl.AbstractHttpClientConnection.sendRequestEntity(AbstractHttpClientConnection.java:266) > at > org.apache.http.impl.conn.ManagedClientConnectionImpl.sendRequestEntity(ManagedClientConnectionImpl.java:197) > at > org.apache.http.protocol.HttpRequestExecutor.doSendRequest(HttpRequestExecutor.java:257) > at > org.apache.http.protocol.HttpRequestExecutor.execute(HttpRequestExecutor.java:125) > at > org.apache.http.impl.client.DefaultRequestDirector.tryExecute(DefaultRequestDirector.java:708) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Closed] (MTOMCAT-145) [2.0-beta-1] Unable to deploy
[ https://issues.apache.org/jira/browse/MTOMCAT-145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy (*$^¨%`£) closed MTOMCAT-145. -- > [2.0-beta-1] Unable to deploy > -- > > Key: MTOMCAT-145 > URL: https://issues.apache.org/jira/browse/MTOMCAT-145 > Project: Apache Tomcat Maven Plugin > Issue Type: Bug > Components: tomcat6 >Affects Versions: 2.0-beta-1 > Environment: Maven 3.0.4 command-line on Windows 7 x64 > Tomcat 6.0.13 > CentOs 4.9 >Reporter: Jeff Vincent >Assignee: Olivier Lamy (*$^¨%`£) >Priority: Critical > Fix For: 2.0 > > > I have been using the codhaus version of the tomcat-maven-plugin and am > trying to switch to the latest Apache Tomcat Maven Plugin. > Deploy works with the codhaus version using 'mvn tomcat:redeploy -Pdev02`. > The username/password are normally in my profile settings. > Deploy fails with apache version using: 'mvn tomcat6:redeploy -Pdev02'. > I've specified a entry in the settings.xml, and specified the same > value in the section of the the plugin to avoid > "[DEBUG] No server specified for authentication - using defaults" errors. > Below is my maven profile. I've tried changing the URL when running the > tomcat6:deploy/redeploy targets with and without a trailing '/text'. I get a > 404 with the '/text' and "Cannot invoke Tomcat manager" if I ommit the > '/text'. > Although, without the '/text' in the URL, it appears to upload the war as it > shows a progress indicator then fails with the error below: > > > dev02 > > false > > > > > org.apache.tomcat.maven > tomcat6-maven-plugin > 2.0-beta-1 > > war > http://10.12.4.2/manager > true > UTF-8 > UTF-8 > HTTP/1.1 > true > dev02 > > > > > > //- MAVEN OUTPUT > [DEBUG] Configuring mojo > org.apache.tomcat.maven:tomcat6-maven-plugin:2.0-beta-1:redeploy from plugin > realm > ClassRealm[plugin>org.apache.tomcat.maven:tomcat6-maven-plugin:2.0-beta-1, > parent: sun.misc.Launcher$AppClassLoader@3326b249] > [DEBUG] Configuring mojo > 'org.apache.tomcat.maven:tomcat6-maven-plugin:2.0-beta-1:redeploy' with basic > configurator --> > [DEBUG] (f) charset = UTF-8 > [DEBUG] (f) contextFile = > C:\Users\jvincent\Dev\Java\Domain\target\Domain-2012.04.04-SNAPSHOT\META-INF\context.xml > [DEBUG] (f) ignorePackaging = false > [DEBUG] (f) mode = war > [DEBUG] (f) packaging = war > [DEBUG] (f) path = /Domain > [DEBUG] (f) server = dev02 > [DEBUG] (f) update = true > [DEBUG] (f) url = http://10.12.4.2/manager > [DEBUG] (f) version = 2.0-beta-1 > [DEBUG] (f) warFile = > C:\Users\jvincent\Dev\Java\Domain\target\Domain-2012.04.04-SNAPSHOT.war > [DEBUG] -- end configuration -- > [INFO] Deploying war to http://10.12.4.2/Domain > Uploading: http://10.12.4.2/manager/deploy?path=%2FDomain&update=true > [Progress Indicator..] > [INFO] > > [INFO] BUILD FAILURE > [INFO] > > [INFO] Total time: 5.490s > [INFO] Finished at: Tue Apr 17 17:51:59 MDT 2012 > [INFO] Final Memory: 8M/244M > [INFO] > > [ERROR] Failed to execute goal > org.apache.tomcat.maven:tomcat6-maven-plugin:2.0-beta-1:redeploy > (default-cli) on project Domain: Cannot invoke Tomcat manager: > ClientProtocolException: Cannot retry request with a non-repeatable request > entity. -> [Help 1] > org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute > goal org.apache.tomcat.maven:tomcat6-maven-plugin:2.0-beta-1:redeploy > (default-cli) on project Domain: Cannot invoke Tomcat manager > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:217) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145) > at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84) > at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59) > at > org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183) > at > org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161) > at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:319) > at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156) >
[jira] [Updated] (MTOMCAT-119) tomcat7:run-war fails because it expects META-INF\context.xml
[
https://issues.apache.org/jira/browse/MTOMCAT-119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Olivier Lamy (*$^¨%`£) updated MTOMCAT-119:
---
Fix Version/s: (was: 2.0)
2.1
> tomcat7:run-war fails because it expects META-INF\context.xml
> -
>
> Key: MTOMCAT-119
> URL: https://issues.apache.org/jira/browse/MTOMCAT-119
> Project: Apache Tomcat Maven Plugin
> Issue Type: Bug
> Components: tomcat7
>Affects Versions: 2.0-beta-1
>Reporter: Antelink
>Assignee: Olivier Lamy (*$^¨%`£)
> Fix For: 2.1
>
>
> run-war and run-war-only goals fail on tomcat7 plugin, looking for the file
> =META-INF\context.xml=
> How to reproduce:
> * Use the archetype to create a project
> mvn archetype:generate -DarchetypeGroupId=org.apache.tomcat.maven
> -DarchetypeArtifactId=tomcat-maven-archetype -DarchetypeVersion=2.0-beta-1
> * Build it
> * cd basic-webapp
> * mvn org.apache.tomcat.maven:tomcat6-maven-plugin:run-war
> => works fine
> * mvn org.apache.tomcat.maven:tomcat7-maven-plugin:run
> => works fine
> * mvn org.apache.tomcat.maven:tomcat7-maven-plugin:run-war
> -> kaboom
> {code}
> [INFO] --- tomcat7-maven-plugin:2.0-beta-1:run-war (default-cli) @
> basic-webapp ---
> [INFO] Running war on http://localhost:9090/
> [INFO] Using existing Tomcat server configuration at
> C:\Users\SAMUEL~1.LAN\AppData\Local\Temp\com.antelink.toto\basic-webapp\target\tomcat
> févr. 16, 2012 6:56:24 PM org.apache.coyote.AbstractProtocol init
> Infos: Initializing ProtocolHandler ["http-bio-9090"]
> févr. 16, 2012 6:56:24 PM org.apache.catalina.core.StandardService
> startInternal
> Infos: Starting service Tomcat
> févr. 16, 2012 6:56:24 PM org.apache.catalina.core.StandardEngine
> startInternal
> Infos: Starting Servlet Engine: Apache Tomcat/7.0.25
> févr. 16, 2012 6:56:24 PM org.apache.catalina.startup.ContextConfig
> processContextConfig
> Grave: Missing context.xml:
> file:/C:/Users/SAMUEL~1.LAN/AppData/Local/Temp/com.antelink.toto/basic-webapp/target/basic-webapp-1.0-SNAPSHOT/META-INF/context.xml
> java.io.FileNotFoundException:
> C:\Users\SAMUEL~1.LAN\AppData\Local\Temp\com.antelink.toto\basic-webapp\target\basic-webapp-1.0-SNAPSHOT\META-INF\context.xml
> (Le fichier spécifié est introuvable)
> at java.io.FileInputStream.open(Native Method)
> at java.io.FileInputStream.(FileInputStream.java:138)
> at java.io.FileInputStream.(FileInputStream.java:97)
> at
> sun.net.www.protocol.file.FileURLConnection.connect(FileURLConnection.java:90)
> at
> sun.net.www.protocol.file.FileURLConnection.getInputStream(FileURLConnection.java:188)
> at java.net.URL.openStream(URL.java:1035)
> at
> org.apache.catalina.startup.ContextConfig.processContextConfig(ContextConfig.java:565)
> at
> org.apache.catalina.startup.ContextConfig.contextConfig(ContextConfig.java:546)
> at
> org.apache.catalina.startup.ContextConfig.init(ContextConfig.java:784)
> at
> org.apache.catalina.startup.ContextConfig.lifecycleEvent(ContextConfig.java:318)
> at
> org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(LifecycleSupport.java:119)
> at
> org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(LifecycleBase.java:90)
> at
> org.apache.catalina.util.LifecycleBase.setStateInternal(LifecycleBase.java:401)
> at org.apache.catalina.util.LifecycleBase.init(LifecycleBase.java:110)
> at
> org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:139)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Updated] (MTOMCAT-99) Make redeploy goal consistent with deploy goals
[ https://issues.apache.org/jira/browse/MTOMCAT-99?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy (*$^¨%`£) updated MTOMCAT-99: -- Fix Version/s: (was: 2.0) 2.1 > Make redeploy goal consistent with deploy goals > --- > > Key: MTOMCAT-99 > URL: https://issues.apache.org/jira/browse/MTOMCAT-99 > Project: Apache Tomcat Maven Plugin > Issue Type: Improvement >Affects Versions: 1.1 >Reporter: Michael Osipov >Assignee: Olivier Lamy (*$^¨%`£) > Fix For: 2.1 > > > Redeploy is the same as deploy but has the update flag set to true. redeploy > does not fork a package phase, deploy does. The behavior is diffrent. It > should be: > deploy <=> redeploy > deploy-only <=> redeploy-only -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Updated] (MTOMCAT-124) tomcat-maven-archetype unused generation parameters
[
https://issues.apache.org/jira/browse/MTOMCAT-124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Olivier Lamy (*$^¨%`£) updated MTOMCAT-124:
---
Fix Version/s: (was: 2.0)
2.1
> tomcat-maven-archetype unused generation parameters
> ---
>
> Key: MTOMCAT-124
> URL: https://issues.apache.org/jira/browse/MTOMCAT-124
> Project: Apache Tomcat Maven Plugin
> Issue Type: Improvement
>Affects Versions: 2.0-beta-1
>Reporter: patrick garcia
>Assignee: Olivier Lamy (*$^¨%`£)
>Priority: Trivial
> Labels: archetype, maven, tomcat
> Fix For: 2.1
>
> Attachments: MTOMCAT-124-tomcat-maven-archetype.patch
>
>
> I found several problems on the superb and very useful
> "tomcat-maven-archetype"
> The improvement I propos are the followings:
> 1/
> "groupId" and "version" can have default values but should be prompt for user
> value the same way as for "version" of
> "org.apache.maven.archetypes:maven-archetype-quickstart:1.1"
> "org.apache.maven.archetypes:maven-archetype-quickstart:1.1" proposes a
> default "version" and prompt the user for modification at the same time.
> Pressing enter validate the default value.
> 2/
> Following variables are not in used:
> artifactId-api
> artifactId-api-impl
> artifactId-webapp
> artifactId-webapp-exec
> artifactId-webapp-it
> This variables should impact the "mvn archetype:generate" behaviour
> 3/
> I propos to change the default values of :
> artifactId-api = ${artifactId}-api
> artifactId-api-impl = ${artifactId}-api-impl
> artifactId-webapp = ${artifactId}-webapp
> artifactId-webapp-exec = ${artifactId}-webapp-exec
> artifactId-webapp-it = ${artifactId}-webapp-it
> 4/
> rootArtifactId cat be renamed as artifactId with no default value
> I will propos patches for this later. I, first, have to understand
> "archetype" framework.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Updated] (MTOMCAT-148) Clarify run goal with respect to war overlays
[ https://issues.apache.org/jira/browse/MTOMCAT-148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy (*$^¨%`£) updated MTOMCAT-148: --- Fix Version/s: (was: 2.0) 2.1 > Clarify run goal with respect to war overlays > - > > Key: MTOMCAT-148 > URL: https://issues.apache.org/jira/browse/MTOMCAT-148 > Project: Apache Tomcat Maven Plugin > Issue Type: Improvement > Components: tomcat6, tomcat7 >Affects Versions: 2.0-beta-1 >Reporter: Jeff MAURY >Assignee: Olivier Lamy (*$^¨%`£) > Fix For: 2.1 > > > When a war project use war overlays, it may have resources that are inherited > from its war dependencies (JSP files, conf files, ...). > As the tomcat run goal uses warSourceDirectory as docRoot, it will lead to > inconsistent behaviour as some files will not be found by Tomcat. > This should either fixed or clearly stated in the documentation -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Updated] (MTOMCAT-128) The plugin ignores and/or parses web.xml incorrectally when using tomcatWebXml option
[
https://issues.apache.org/jira/browse/MTOMCAT-128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Olivier Lamy (*$^¨%`£) updated MTOMCAT-128:
---
Fix Version/s: (was: 2.0)
2.1
> The plugin ignores and/or parses web.xml incorrectally when using
> tomcatWebXml option
> -
>
> Key: MTOMCAT-128
> URL: https://issues.apache.org/jira/browse/MTOMCAT-128
> Project: Apache Tomcat Maven Plugin
> Issue Type: Bug
> Components: tomcat6, tomcat7
>Affects Versions: 2.0-beta-1
> Environment: openSUSE 12.1 32Bits
>Reporter: Gilberto C Andrade
>Assignee: Olivier Lamy (*$^¨%`£)
>Priority: Trivial
> Fix For: 2.1
>
>
> In our project(jpa-spring-wicket) we need to filter the web.xml file,
> changing some placeholder and putting it (the web.xml) in
> ${project.build.directory}/${project.build.finalName}/WEB-INF/web.xml.
> Using tomcat6-maven-plugin it find the correct file, but fail when parsing it:
>
> Caused by: java.lang.IllegalArgumentException: Duplicate context
> initialization parameter contextConfigLocation
> at
> org.apache.catalina.core.StandardContext.addParameter(StandardContext.java:2661)
> ... 52 more
> Mar 16, 2012 11:49:12 AM org.apache.catalina.startup.ContextConfig
> applicationWebConfig
> SEVERE: Parse error in application web.xml file at
> jndi:/localhost/a2p/WEB-INF/web.xml
> org.xml.sax.SAXParseException; systemId: jndi:/localhost/a2p/WEB-INF/web.xml;
> lineNumber: 15; columnNumber: 21; Error at (15, 21: Duplicate context
> initialization parameter contextConfigLocation
> at
> org.apache.tomcat.util.digester.Digester.createSAXException(Digester.java:2806)
>
> Using tomcat7-maven-plugin it find the correct file, but ignores it so using
> the original file which contain the ${placeholder}. Thus not initializing the
> application:
>
> INFO - ContextLoader - Root WebApplicationContext:
> initialization completed in 7808 ms
> INFO - WebXmlFile - web.xml: url mapping found for filter
> with name A2P: [/*]
> Mar 16, 2012 12:08:16 PM org.apache.catalina.core.StandardContext filterStart
> SEVERE: Exception starting filter A2P
> java.lang.IllegalArgumentException: Invalid configuration type:
> '${wicket.MODE}'. Must be "development" or "deployment".
> at
> org.apache.wicket.protocol.http.WebApplication.getConfigurationType(WebApplication.java:670)
> at org.apache.wicket.Application.configure(Application.java:297)
> at
> org.apache.wicket.protocol.http.WebApplication.internalInit(WebApplication.java:613)
> at org.apache.wicket.Application.initApplication(Application.java:806)
> at
> org.apache.wicket.protocol.http.WicketFilter.init(WicketFilter.java:346)
> at
> org.apache.wicket.protocol.http.WicketFilter.init(WicketFilter.java:286)
> at
> org.apache.catalina.core.ApplicationFilterConfig.initFilter(ApplicationFilterConfig.java:277)
> at
> org.apache.catalina.core.ApplicationFilterConfig.getFilter(ApplicationFilterConfig.java:258)
>
> The plugin configuration:
>
>
> org.apache.tomcat.maven
> tomcat7-maven-plugin
> 2.0-beta-1
>
> ${project.build.finalName}
>
> ${project.build.directory}/${project.build.finalName}/WEB-INF/web.xml
>
>
>
> I have the jetty plugin setup as well and working, so I would try with tomcat
> but without success until now.
> Regards
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Updated] (MTOMCAT-61) maven tomcat:run ignores the useSeperateTomcatClassloaded when using serverXml property
[ https://issues.apache.org/jira/browse/MTOMCAT-61?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy (*$^¨%`£) updated MTOMCAT-61: -- Fix Version/s: (was: 2.0) 2.1 > maven tomcat:run ignores the useSeperateTomcatClassloaded when using > serverXml property > --- > > Key: MTOMCAT-61 > URL: https://issues.apache.org/jira/browse/MTOMCAT-61 > Project: Apache Tomcat Maven Plugin > Issue Type: Bug >Affects Versions: 1.0 > Environment: Mac OS X, JDK 1.6, Maven 2.2.1 >Reporter: Lars Vonk >Assignee: Olivier Lamy (*$^¨%`£) > Fix For: 2.1 > > > When configuring the tomcat plugin as follows: > > true > /src/test/config/server.xml > > the useSeparateTomcatClassLoader is ignored. In our case this causes > classloading issues. > It could be it is not supported but that is not clear from the documentation. > If so I would like to know how I can add server.xml stuff in case of > tomcat:run (one this is the single sign on Valve). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Updated] (MTOMCAT-92) Bind tomcat to a self-chosen network interface
[ https://issues.apache.org/jira/browse/MTOMCAT-92?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy (*$^¨%`£) updated MTOMCAT-92: -- Fix Version/s: (was: 2.0) 2.1 > Bind tomcat to a self-chosen network interface > -- > > Key: MTOMCAT-92 > URL: https://issues.apache.org/jira/browse/MTOMCAT-92 > Project: Apache Tomcat Maven Plugin > Issue Type: Bug >Affects Versions: 1.1 >Reporter: Björn Michael >Assignee: Olivier Lamy (*$^¨%`£) > Fix For: 2.1 > > > Tomcat is bound to 0.0.0.0 (all interfaces) by default. I feel the need to > change this binding to e.g. localhost (127.0.0.1) or another interface by > adding a 127.0.0.1 to plugin configuration in pom.xml. This is > often necessary for security or firewall reasons during the development of > web applications. > Thanks in advance. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53138] Not able to download a file size of 740KB using NIO connector in tomcat version 7.0.27. But with the same configuration I was able to download that in tomcat 7.0.26.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53138
Filip Hanik changed:
What|Removed |Added
Status|NEW |NEEDINFO
--- Comment #3 from Filip Hanik ---
Just ran the sample app on a 7.0.27 download
HTTP/1.1 200 OK
Server: Apache-Coyote/1.1
Accept-Ranges: bytes
ETag: W/"757692-1335976856000"
Last-Modified: Wed, 02 May 2012 16:40:56 GMT
Content-Type: application/javascript
Content-Length: 757692
Date: Wed, 02 May 2012 16:43:11 GMT
and then I get all the bytes.
I was unable to reproduce it. The last bytes I get downloaded are:
Y.on('hashchange', function (e) {
pjax.updateTabState('hashchange');
}, win);
});
and that corresponds with the file contents
--
You are receiving this mail because:
You are the assignee for the bug.
[jira] [Commented] (MTOMCAT-149) Error deploying on Tomcat 6
[ https://issues.apache.org/jira/browse/MTOMCAT-149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266695#comment-13266695 ] costas commented on MTOMCAT-149: Latest snapshot provides this: [DEBUG] Trace org.apache.maven.lifecycle.LifecycleExecutionException: Cannot invoke Tomcat manager at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:719) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeStandaloneGoal(DefaultLifecycleExecutor.java:569) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:539) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:387) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:348) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:180) at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:328) at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:138) at org.apache.maven.cli.MavenCli.main(MavenCli.java:362) at org.apache.maven.cli.compat.CompatibleMain.main(CompatibleMain.java:60) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315) at org.codehaus.classworlds.Launcher.launch(Launcher.java:255) at org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430) at org.codehaus.classworlds.Launcher.main(Launcher.java:375) Caused by: org.apache.maven.plugin.MojoExecutionException: Cannot invoke Tomcat manager at org.apache.tomcat.maven.plugin.tomcat6.AbstractCatalinaMojo.execute(AbstractCatalinaMojo.java:152) at org.apache.tomcat.maven.plugin.tomcat6.AbstractWarCatalinaMojo.execute(AbstractWarCatalinaMojo.java:71) at org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:490) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:694) ... 17 more Caused by: java.net.SocketException: Broken pipe at java.net.SocketOutputStream.socketWrite0(Native Method) at java.net.SocketOutputStream.socketWrite(SocketOutputStream.java:92) at java.net.SocketOutputStream.write(SocketOutputStream.java:136) at org.apache.http.impl.io.AbstractSessionOutputBuffer.write(AbstractSessionOutputBuffer.java:163) at org.apache.http.impl.io.ContentLengthOutputStream.write(ContentLengthOutputStream.java:119) at org.apache.tomcat.maven.common.deployer.TomcatManager$RequestEntityImplementation.writeTo(TomcatManager.java:857) at org.apache.http.entity.HttpEntityWrapper.writeTo(HttpEntityWrapper.ja > Error deploying on Tomcat 6 > --- > > Key: MTOMCAT-149 > URL: https://issues.apache.org/jira/browse/MTOMCAT-149 > Project: Apache Tomcat Maven Plugin > Issue Type: Bug > Components: tomcat6 >Affects Versions: 2.0-beta-1 > Environment: Apache Maven 2.2.1 (r801777; 2009-08-06 21:16:01+0200) > Java version: 1.6.0_31 > Java home: /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home > Default locale: en_US, platform encoding: MacRoman > OS name: "mac os x" version: "10.7.3" arch: "x86_64" Family: "mac" >Reporter: costas >Assignee: Olivier Lamy (*$^¨%`£) > Fix For: 2.0 > > > Deploying on Tomcat 6 throws the following exception: > Caused by: org.apache.http.client.ClientProtocolException > at > org.apache.http.impl.client.AbstractHttpClient.execute(AbstractHttpClient.java:926) > at > org.apache.http.impl.client.AbstractHttpClient.execute(AbstractHttpClient.java:822) > at > org.apache.tomcat.maven.common.deployer.TomcatManager.invoke(TomcatManager.java:718) > at > org.apache.tomcat.maven.common.deployer.TomcatManager.deployImpl(TomcatManager.java:681) > at > org.apache.tomcat.maven.common.deployer.TomcatManager.deploy(TomcatManager.java:363) > at > org.apache.tomcat.maven.plugin.tomcat6.AbstractDeployWarMojo.deployWar(AbstractDeployWarMojo.java:87) > at > org.apache.tomcat.maven.plugin.tomcat6.AbstractDeployMojo.invokeManager(AbstractDeployMojo.java:86) > at > org.apache.tomcat.maven.plugin.tomcat6.AbstractCatalinaMojo.execute(AbstractCatalinaMojo.java:143) > ... 20 more > Caused by: org.apache.http.client.NonRepeatableRequestExcep
[jira] [Reopened] (MTOMCAT-149) Error deploying on Tomcat 6
[
https://issues.apache.org/jira/browse/MTOMCAT-149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
costas reopened MTOMCAT-149:
DEBUG] Configuring mojo
'org.apache.tomcat.maven:tomcat6-maven-plugin:2.0-SNAPSHOT:deploy' -->
[DEBUG] (f) charset = UTF-8
[DEBUG] (f) contextFile =
/Users/m/workspace/app/target/integration-api-1.0-SNAPSHOT/META-INF/context.xml
[DEBUG] (f) ignorePackaging = false
[DEBUG] (f) mode = war
[DEBUG] (f) packaging = war
[DEBUG] (f) password = tomcat
[DEBUG] (f) path = /integration-api
[DEBUG] (f) update = true
[DEBUG] (f) url = http://localhost:8080/manager
[DEBUG] (f) username = tomcat
[DEBUG] (f) version = 2.0-SNAPSHOT
[DEBUG] (f) warFile =
/Users/m/workspace/app/target/integration-api-1.0-SNAPSHOT.war
[DEBUG] -- end configuration --
[INFO] [tomcat6:deploy {execution: default-cli}]
[INFO] Deploying war to http://localhost:8080/integration-api
[DEBUG] No server specified for authentication - using defaults
Uploading:
http://localhost:8080/manager/deploy?path=%2Fintegration-api&update=true
12/21672 KB
May 2, 2012 6:41:25 PM org.apache.http.impl.client.DefaultRequestDirector
tryExecute
INFO: I/O exception (java.net.SocketException) caught when processing request:
Broken pipe
May 2, 2012 6:41:25 PM org.apache.http.impl.client.DefaultRequestDirector
tryExecute
INFO: Retrying request
Uploading:
http://localhost:8080/manager/deploy?path=%2Fintegration-api&update=true
12/21672 KB
May 2, 2012 6:41:25 PM org.apache.http.impl.client.DefaultRequestDirector
tryExecute
INFO: I/O exception (java.net.SocketException) caught when processing request:
Broken pipe
May 2, 2012 6:41:25 PM org.apache.http.impl.client.DefaultRequestDirector
tryExecute
INFO: Retrying request
Uploading:
http://localhost:8080/manager/deploy?path=%2Fintegration-api&update=true
12/21672 KB
May 2, 2012 6:41:25 PM org.apache.http.impl.client.DefaultRequestDirector
tryExecute
INFO: I/O exception (java.net.SocketException) caught when processing request:
Broken pipe
May 2, 2012 6:41:25 PM org.apache.http.impl.client.DefaultRequestDirector
tryExecute
INFO: Retrying request
Uploading:
http://localhost:8080/manager/deploy?path=%2Fintegration-api&update=true
> Error deploying on Tomcat 6
> ---
>
> Key: MTOMCAT-149
> URL: https://issues.apache.org/jira/browse/MTOMCAT-149
> Project: Apache Tomcat Maven Plugin
> Issue Type: Bug
> Components: tomcat6
>Affects Versions: 2.0-beta-1
> Environment: Apache Maven 2.2.1 (r801777; 2009-08-06 21:16:01+0200)
> Java version: 1.6.0_31
> Java home: /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home
> Default locale: en_US, platform encoding: MacRoman
> OS name: "mac os x" version: "10.7.3" arch: "x86_64" Family: "mac"
>Reporter: costas
>Assignee: Olivier Lamy (*$^¨%`£)
> Fix For: 2.0
>
>
> Deploying on Tomcat 6 throws the following exception:
> Caused by: org.apache.http.client.ClientProtocolException
> at
> org.apache.http.impl.client.AbstractHttpClient.execute(AbstractHttpClient.java:926)
> at
> org.apache.http.impl.client.AbstractHttpClient.execute(AbstractHttpClient.java:822)
> at
> org.apache.tomcat.maven.common.deployer.TomcatManager.invoke(TomcatManager.java:718)
> at
> org.apache.tomcat.maven.common.deployer.TomcatManager.deployImpl(TomcatManager.java:681)
> at
> org.apache.tomcat.maven.common.deployer.TomcatManager.deploy(TomcatManager.java:363)
> at
> org.apache.tomcat.maven.plugin.tomcat6.AbstractDeployWarMojo.deployWar(AbstractDeployWarMojo.java:87)
> at
> org.apache.tomcat.maven.plugin.tomcat6.AbstractDeployMojo.invokeManager(AbstractDeployMojo.java:86)
> at
> org.apache.tomcat.maven.plugin.tomcat6.AbstractCatalinaMojo.execute(AbstractCatalinaMojo.java:143)
> ... 20 more
> Caused by: org.apache.http.client.NonRepeatableRequestException: Cannot retry
> request with a non-repeatable request entity. The cause lists the reason the
> original request failed.
> at
> org.apache.http.impl.client.DefaultRequestDirector.tryExecute(DefaultRequestDirector.java:682)
> at
> org.apache.http.impl.client.DefaultRequestDirector.execute(DefaultRequestDirector.java:515)
> at
> org.apache.http.impl.client.AbstractHttpClient.execute(AbstractHttpClient.java:923)
> ... 27 more
> Caused by: java.net.SocketException: Broken pipe
> at java.net.SocketOutputStream.socketWrite0(Native Method)
> at java.net.SocketOutputStream.socketWrite(SocketOutputStream.java:92)
> at java.net.SocketOutputStream.write(SocketOutputStream.java:136)
> at
> org.apache.http.impl.io.AbstractSessionOutputBuffer.write(AbstractSessionOutputBuffer.java:163)
> at
> org.apache.http.impl.io.ContentLengthOutputStream.write(ContentLengthOutputStream.java:11
[Bug 53138] Not able to download a file size of 740KB using NIO connector in tomcat version 7.0.27. But with the same configuration I was able to download that in tomcat 7.0.26.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53138 --- Comment #4 from Filip Hanik --- Tested in Firefox 11 and Internet Explorer 9 -- You are receiving this mail because: You are the assignee for the bug.
svn commit: r1333114 - in /tomcat/trunk: java/org/apache/coyote/ java/org/apache/tomcat/util/net/ java/org/apache/tomcat/util/threads/ webapps/docs/ webapps/docs/config/
Author: fhanik
Date: Wed May 2 17:12:48 2012
New Revision: 1333114
URL: http://svn.apache.org/viewvc?rev=1333114&view=rev
Log:
https://issues.apache.org/bugzilla/show_bug.cgi?id=53173
Properly handle count down of maxConnections latch when entering edge cases.
Modified:
tomcat/trunk/java/org/apache/coyote/AbstractProtocol.java
tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java
tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java
tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
tomcat/trunk/java/org/apache/tomcat/util/threads/LimitLatch.java
tomcat/trunk/webapps/docs/changelog.xml
tomcat/trunk/webapps/docs/config/ajp.xml
tomcat/trunk/webapps/docs/config/http.xml
Modified: tomcat/trunk/java/org/apache/coyote/AbstractProtocol.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/AbstractProtocol.java?rev=1333114&r1=1333113&r2=1333114&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/AbstractProtocol.java (original)
+++ tomcat/trunk/java/org/apache/coyote/AbstractProtocol.java Wed May 2
17:12:48 2012
@@ -541,6 +541,12 @@ public abstract class AbstractProtocol i
SocketStatus status) {
Processor processor = connections.remove(socket.getSocket());
+if (status == SocketStatus.DISCONNECT && processor == null) {
+//nothing more to be done endpoint requested a close
+//and there are no object associated with this connection
+return SocketState.CLOSED;
+}
+
socket.setAsync(false);
try {
@@ -555,7 +561,9 @@ public abstract class AbstractProtocol i
SocketState state = SocketState.CLOSED;
do {
-if (processor.isAsync() || state == SocketState.ASYNC_END)
{
+if (status == SocketStatus.DISCONNECT) {
+//do nothing here, just wait for it to get recycled
+} else if (processor.isAsync() || state ==
SocketState.ASYNC_END) {
state = processor.asyncDispatch(status);
} else if (processor.isComet()) {
state = processor.event(status);
Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java?rev=1333114&r1=1333113&r2=1333114&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java Wed May
2 17:12:48 2012
@@ -163,7 +163,12 @@ public abstract class AbstractEndpoint {
LimitLatch latch = this.connectionLimitLatch;
if (latch != null) {
// Update the latch that enforces this
+if (maxCon == -1)
+releaseConnectionLatch();
+else
latch.setLimit(maxCon);
+} else if (maxCon > 0) {
+initializeConnectionLatch();
}
}
@@ -655,6 +660,7 @@ public abstract class AbstractEndpoint {
public abstract boolean getUsePolling();
protected LimitLatch initializeConnectionLatch() {
+if (maxConnections==-1) return null;
if (connectionLimitLatch==null) {
connectionLimitLatch = new LimitLatch(getMaxConnections());
}
@@ -668,11 +674,13 @@ public abstract class AbstractEndpoint {
}
protected void countUpOrAwaitConnection() throws InterruptedException {
+if (maxConnections==-1) return;
LimitLatch latch = connectionLimitLatch;
if (latch!=null) latch.countUpOrAwait();
}
protected long countDownConnection() {
+if (maxConnections==-1) return -1;
LimitLatch latch = connectionLimitLatch;
if (latch!=null) {
long result = latch.countDown();
Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java?rev=1333114&r1=1333113&r2=1333114&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java Wed May 2
17:12:48 2012
@@ -995,6 +995,8 @@ public class AprEndpoint extends Abstrac
// socket
socket = Socket.accept(serverSock);
} catch (Exception e) {
+//we didn't get a socket
+countDownConnection();
// Introduce delay if necessary
svn commit: r1333116 - in /tomcat/tc7.0.x/trunk: java/org/apache/coyote/ java/org/apache/tomcat/util/net/ java/org/apache/tomcat/util/threads/ webapps/docs/config/
Author: fhanik
Date: Wed May 2 17:15:46 2012
New Revision: 1333116
URL: http://svn.apache.org/viewvc?rev=1333116&view=rev
Log:
https://issues.apache.org/bugzilla/show_bug.cgi?id=53173
Properly count down maxConnections
Modified:
tomcat/tc7.0.x/trunk/java/org/apache/coyote/AbstractProtocol.java
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/threads/LimitLatch.java
tomcat/tc7.0.x/trunk/webapps/docs/config/ajp.xml
tomcat/tc7.0.x/trunk/webapps/docs/config/http.xml
Modified: tomcat/tc7.0.x/trunk/java/org/apache/coyote/AbstractProtocol.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/coyote/AbstractProtocol.java?rev=1333116&r1=1333115&r2=1333116&view=diff
==
--- tomcat/tc7.0.x/trunk/java/org/apache/coyote/AbstractProtocol.java (original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/coyote/AbstractProtocol.java Wed May
2 17:15:46 2012
@@ -541,6 +541,12 @@ public abstract class AbstractProtocol i
SocketStatus status) {
Processor processor = connections.remove(socket.getSocket());
+if (status == SocketStatus.DISCONNECT && processor == null) {
+//nothing more to be done endpoint requested a close
+//and there are no object associated with this connection
+return SocketState.CLOSED;
+}
+
socket.setAsync(false);
try {
@@ -555,7 +561,9 @@ public abstract class AbstractProtocol i
SocketState state = SocketState.CLOSED;
do {
-if (processor.isAsync() || state == SocketState.ASYNC_END)
{
+if (status == SocketStatus.DISCONNECT) {
+//do nothing here, just wait for it to get recycled
+} else if (processor.isAsync() || state ==
SocketState.ASYNC_END) {
state = processor.asyncDispatch(status);
} else if (processor.isComet()) {
state = processor.event(status);
Modified:
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java?rev=1333116&r1=1333115&r2=1333116&view=diff
==
--- tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java
(original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java
Wed May 2 17:15:46 2012
@@ -163,7 +163,12 @@ public abstract class AbstractEndpoint {
LimitLatch latch = this.connectionLimitLatch;
if (latch != null) {
// Update the latch that enforces this
+if (maxCon == -1)
+releaseConnectionLatch();
+else
latch.setLimit(maxCon);
+} else if (maxCon > 0) {
+initializeConnectionLatch();
}
}
@@ -655,6 +660,7 @@ public abstract class AbstractEndpoint {
public abstract boolean getUsePolling();
protected LimitLatch initializeConnectionLatch() {
+if (maxConnections==-1) return null;
if (connectionLimitLatch==null) {
connectionLimitLatch = new LimitLatch(getMaxConnections());
}
@@ -668,11 +674,13 @@ public abstract class AbstractEndpoint {
}
protected void countUpOrAwaitConnection() throws InterruptedException {
+if (maxConnections==-1) return;
LimitLatch latch = connectionLimitLatch;
if (latch!=null) latch.countUpOrAwait();
}
protected long countDownConnection() {
+if (maxConnections==-1) return -1;
LimitLatch latch = connectionLimitLatch;
if (latch!=null) {
long result = latch.countDown();
Modified: tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java?rev=1333116&r1=1333115&r2=1333116&view=diff
==
--- tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
(original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java Wed
May 2 17:15:46 2012
@@ -991,6 +991,8 @@ public class AprEndpoint extends Abstrac
// socket
socket = Socket.accept(serverSock);
} catch (Exception e) {
+//we didn't get a socket
+countDownConnection()
svn commit: r1333118 - /tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
Author: fhanik Date: Wed May 2 17:16:24 2012 New Revision: 1333118 URL: http://svn.apache.org/viewvc?rev=1333118&view=rev Log: update changelog for https://issues.apache.org/bugzilla/show_bug.cgi?id=53173 fix Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1333118&r1=1333117&r2=1333118&view=diff == --- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original) +++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Wed May 2 17:16:24 2012 @@ -82,6 +82,14 @@ + + + +53173 (1333116) : +Properly count down maxConnections (fhanik) + + + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53173] maxConnections feature hangs the system
https://issues.apache.org/bugzilla/show_bug.cgi?id=53173 Filip Hanik changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED OS||All --- Comment #1 from Filip Hanik --- Fixed in trunk r1333114 Fixed in 7.0.x r1333116 Will be made available in Apache Tomcat 7.0.28 and onwards Additional option added maxConnection=-1 to disable connection counting -- You are receiving this mail because: You are the assignee for the bug.
[Bug 53179] New: Missing ')' in "The HTTP Connector" documentation
https://issues.apache.org/bugzilla/show_bug.cgi?id=53179 Priority: P2 Bug ID: 53179 Assignee: dev@tomcat.apache.org Summary: Missing ')' in "The HTTP Connector" documentation Severity: trivial Classification: Unclassified OS: All Reporter: javucho1...@yahoo.com.mx Hardware: All Status: NEW Version: 7.0.27 Component: Documentation Product: Tomcat 7 Created attachment 28710 --> https://issues.apache.org/bugzilla/attachment.cgi?id=28710&action=edit Patch Found a minor issue on the documentation while creating a diagram: missing ')' after "acceptCount attribute". up to the configured maximum (the value of the acceptCount attribute[missing ')' here].Any further http://svn.apache.org/repos/asf/tomcat/tc7.0.x/trunk/webapps/docs/config/http.xml http://tomcat.apache.org/tomcat-7.0-doc/config/http.html The diagram: https://docs.google.com/drawings/pub?id=1rBLZ5CLTG1iRvRAiKdoIgw1WmFGBZ2mU92VQuhEaQPk&w=960&h=720 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 53179] Missing ')' in "The HTTP Connector" documentation
https://issues.apache.org/bugzilla/show_bug.cgi?id=53179 Javier Alcázar changed: What|Removed |Added URL||http://svn.apache.org/repos ||/asf/tomcat/tc7.0.x/trunk/w ||ebapps/docs/config/http.xml CC||javucho1...@yahoo.com.mx -- You are receiving this mail because: You are the assignee for the bug.
[jira] [Commented] (MTOMCAT-149) Error deploying on Tomcat 6
[ https://issues.apache.org/jira/browse/MTOMCAT-149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266835#comment-13266835 ] Olivier Lamy (*$^¨%`£) commented on MTOMCAT-149: any informations from the tomcat instance log files ? > Error deploying on Tomcat 6 > --- > > Key: MTOMCAT-149 > URL: https://issues.apache.org/jira/browse/MTOMCAT-149 > Project: Apache Tomcat Maven Plugin > Issue Type: Bug > Components: tomcat6 >Affects Versions: 2.0-beta-1 > Environment: Apache Maven 2.2.1 (r801777; 2009-08-06 21:16:01+0200) > Java version: 1.6.0_31 > Java home: /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home > Default locale: en_US, platform encoding: MacRoman > OS name: "mac os x" version: "10.7.3" arch: "x86_64" Family: "mac" >Reporter: costas >Assignee: Olivier Lamy (*$^¨%`£) > Fix For: 2.0 > > > Deploying on Tomcat 6 throws the following exception: > Caused by: org.apache.http.client.ClientProtocolException > at > org.apache.http.impl.client.AbstractHttpClient.execute(AbstractHttpClient.java:926) > at > org.apache.http.impl.client.AbstractHttpClient.execute(AbstractHttpClient.java:822) > at > org.apache.tomcat.maven.common.deployer.TomcatManager.invoke(TomcatManager.java:718) > at > org.apache.tomcat.maven.common.deployer.TomcatManager.deployImpl(TomcatManager.java:681) > at > org.apache.tomcat.maven.common.deployer.TomcatManager.deploy(TomcatManager.java:363) > at > org.apache.tomcat.maven.plugin.tomcat6.AbstractDeployWarMojo.deployWar(AbstractDeployWarMojo.java:87) > at > org.apache.tomcat.maven.plugin.tomcat6.AbstractDeployMojo.invokeManager(AbstractDeployMojo.java:86) > at > org.apache.tomcat.maven.plugin.tomcat6.AbstractCatalinaMojo.execute(AbstractCatalinaMojo.java:143) > ... 20 more > Caused by: org.apache.http.client.NonRepeatableRequestException: Cannot retry > request with a non-repeatable request entity. The cause lists the reason the > original request failed. > at > org.apache.http.impl.client.DefaultRequestDirector.tryExecute(DefaultRequestDirector.java:682) > at > org.apache.http.impl.client.DefaultRequestDirector.execute(DefaultRequestDirector.java:515) > at > org.apache.http.impl.client.AbstractHttpClient.execute(AbstractHttpClient.java:923) > ... 27 more > Caused by: java.net.SocketException: Broken pipe > at java.net.SocketOutputStream.socketWrite0(Native Method) > at java.net.SocketOutputStream.socketWrite(SocketOutputStream.java:92) > at java.net.SocketOutputStream.write(SocketOutputStream.java:136) > at > org.apache.http.impl.io.AbstractSessionOutputBuffer.write(AbstractSessionOutputBuffer.java:163) > at > org.apache.http.impl.io.ContentLengthOutputStream.write(ContentLengthOutputStream.java:119) > at > org.apache.tomcat.maven.common.deployer.TomcatManager$RequestEntityImplementation.writeTo(TomcatManager.java:825) > at > org.apache.http.entity.HttpEntityWrapper.writeTo(HttpEntityWrapper.java:98) > at > org.apache.http.impl.client.EntityEnclosingRequestWrapper$EntityWrapper.writeTo(EntityEnclosingRequestWrapper.java:108) > at > org.apache.http.impl.entity.EntitySerializer.serialize(EntitySerializer.java:122) > at > org.apache.http.impl.AbstractHttpClientConnection.sendRequestEntity(AbstractHttpClientConnection.java:266) > at > org.apache.http.impl.conn.ManagedClientConnectionImpl.sendRequestEntity(ManagedClientConnectionImpl.java:197) > at > org.apache.http.protocol.HttpRequestExecutor.doSendRequest(HttpRequestExecutor.java:257) > at > org.apache.http.protocol.HttpRequestExecutor.execute(HttpRequestExecutor.java:125) > at > org.apache.http.impl.client.DefaultRequestDirector.tryExecute(DefaultRequestDirector.java:708) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test has an issue affecting its community integration. This issue affects 1 projects. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-trunk-test : Tomcat 8.x, a web server implementing Java Servlet 3.1, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on tomcat-trunk-dbcp exists, no need to add for property tomcat-dbcp-src.jar. -DEBUG- Dependency on commons-daemon exists, no need to add for property commons-daemon.native.src.tgz. -DEBUG- Dependency on commons-daemon exists, no need to add for property tomcat-native.tar.gz. -DEBUG- Dependency on tomcat-trunk-dbcp exists, no need to add for property tomcat-dbcp.home. -INFO- Failed with reason build failed -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-trunk/output/build/logs The following work was performed: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/gump_work/build_tomcat-trunk_tomcat-trunk-test.html Work Name: build_tomcat-trunk_tomcat-trunk-test (Type: Build) Work ended in a state of : Failed Elapsed: 22 mins 17 secs Command Line: /usr/lib/jvm/java-6-openjdk/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Djunit.jar=/srv/gump/public/workspace/junit/dist/junit-02052012.jar -Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-02052012-native-src.tar.gz -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-02052012-native-src.tar.gz -Dexamples.sources.skip=true -Dtomcat-dbcp.home=/srv/gump/public/workspace/tomcat-trunk/tomcat-deps -Djdt.jar=/srv/gump/packages/eclipse/plugins/org.eclipse.jdt.core_3.4.2/jdtcore.jar -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-02052012.jar -Dtomcat-dbcp-src.jar=/srv/gump/public/workspace/tomcat-trunk/tomcat-deps/tomcat-dbcp-src.jar -Dtest.accesslog=true -Dcommons-pool.home=/srv/gump/public/workspace/commons-pool-1.x -Dcommons-dbcp.home=/ srv/gump/public/workspace/commons-dbcp-1.x -Dtomcat-dbcp.jar=/srv/gump/public/workspace/tomcat-trunk/tomcat-deps/tomcat-dbcp-02052012.jar test [Working Directory: /srv/gump/public/workspace/tomcat-trunk] CLASSPATH: /usr/lib/jvm/java-6-openjdk/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.jar:/srv/gump/public/workspace/tomcat-trunk/outp ut/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-jni.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-util.jar:/srv/gump/packages/javamail-1.4/mail.jar:/srv/gump/packages/javamail-1.4/lib/mailapi.jar:/srv/gump/packages/jaf-1.1ea/activation.jar:/srv/gump/packages/eclipse/plugins/org .eclipse.jdt.core_3.4.2/jdtcore.jar:/srv/gump/public/workspace/tomcat-trunk/tomcat-deps/tomcat-dbcp-02052012.jar:/srv/gump/public/workspace/apache-commons/daemon/dist/commons-da
svn commit: r1333161 - /tomcat/trunk/webapps/docs/windows-service-howto.xml
Author: rjung Date: Wed May 2 19:25:33 2012 New Revision: 1333161 URL: http://svn.apache.org/viewvc?rev=1333161&view=rev Log: Removing obsolete bug warning. Jira says "fixed in commons daemon 1.0.2", which happended long ago. Hope that's right ... Modified: tomcat/trunk/webapps/docs/windows-service-howto.xml Modified: tomcat/trunk/webapps/docs/windows-service-howto.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/windows-service-howto.xml?rev=1333161&r1=1333160&r2=1333161&view=diff == --- tomcat/trunk/webapps/docs/windows-service-howto.xml (original) +++ tomcat/trunk/webapps/docs/windows-service-howto.xml Wed May 2 19:25:33 2012 @@ -108,10 +108,6 @@ --Classpath=xx.jar as command line parameter. -Note: PR_DEPENDSON, PR_ENVIRONMENT, PR_JVMOPTIONS, -PR_JVMMS, PR_JVMMX, PR_JVMSS, PR_STARTPARAMS, PR_STOPPARAMS and -PR_STOPTIMEOUT will not work until this bug is fixed: -http://issues.apache.org/jira/browse/DAEMON-49";>DAEMON-49 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1333164 - in /tomcat/tc7.0.x/trunk: ./ webapps/docs/changelog.xml webapps/docs/windows-service-howto.xml
Author: rjung Date: Wed May 2 19:34:09 2012 New Revision: 1333164 URL: http://svn.apache.org/viewvc?rev=1333164&view=rev Log: Removing obsolete bug warning. Jira says "fixed in commons daemon 1.0.2", which happended long ago. Hope that's right ... Backport of r1333161 from trunk. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml tomcat/tc7.0.x/trunk/webapps/docs/windows-service-howto.xml Propchange: tomcat/tc7.0.x/trunk/ -- Merged /tomcat/trunk:r1333161 Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1333164&r1=1333163&r2=1333164&view=diff == --- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original) +++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Wed May 2 19:34:09 2012 @@ -104,6 +104,10 @@ +Remove obsolete bug warning from windows service +documentation page. (rjung) + + 53158: Fix documented defaults for DBCP. Patch provided by ph.dezanneau at gmail.com. (rjung) Modified: tomcat/tc7.0.x/trunk/webapps/docs/windows-service-howto.xml URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/windows-service-howto.xml?rev=1333164&r1=1333163&r2=1333164&view=diff == --- tomcat/tc7.0.x/trunk/webapps/docs/windows-service-howto.xml (original) +++ tomcat/tc7.0.x/trunk/webapps/docs/windows-service-howto.xml Wed May 2 19:34:09 2012 @@ -108,10 +108,6 @@ --Classpath=xx.jar as command line parameter. -Note: PR_DEPENDSON, PR_ENVIRONMENT, PR_JVMOPTIONS, -PR_JVMMS, PR_JVMMX, PR_JVMSS, PR_STARTPARAMS, PR_STOPPARAMS and -PR_STOPTIMEOUT will not work until this bug is fixed: -http://issues.apache.org/jira/browse/DAEMON-49";>DAEMON-49 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1333168 - in /tomcat/tc6.0.x/trunk: ./ java/org/apache/catalina/core/ webapps/docs/changelog.xml webapps/docs/windows-service-howto.xml
Author: rjung Date: Wed May 2 19:39:01 2012 New Revision: 1333168 URL: http://svn.apache.org/viewvc?rev=1333168&view=rev Log: Removing obsolete bug warning. Jira says "fixed in commons daemon 1.0.2", which happended long ago. Hope that's right ... Backport of r1333161 form trunk resp. r1333164 from tc7. Modified: tomcat/tc6.0.x/trunk/ (props changed) tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/ (props changed) tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml tomcat/tc6.0.x/trunk/webapps/docs/windows-service-howto.xml Propchange: tomcat/tc6.0.x/trunk/ -- Merged /tomcat/trunk:r1333161 Merged /tomcat/tc7.0.x/trunk:r1333164 Propchange: tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/ -- Merged /tomcat/tc7.0.x/trunk/java/org/apache/catalina/core:r1333164 Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml?rev=1333168&r1=1333167&r2=1333168&view=diff == --- tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml (original) +++ tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Wed May 2 19:39:01 2012 @@ -167,6 +167,10 @@ Patch provided by Felix Schumacher. (rjung) +Remove obsolete bug warning from windows service +documentation page. (rjung) + + 53158: Fix documented defaults for DBCP. Patch provided by ph.dezanneau at gmail.com. (rjung) Modified: tomcat/tc6.0.x/trunk/webapps/docs/windows-service-howto.xml URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/windows-service-howto.xml?rev=1333168&r1=1333167&r2=1333168&view=diff == --- tomcat/tc6.0.x/trunk/webapps/docs/windows-service-howto.xml (original) +++ tomcat/tc6.0.x/trunk/webapps/docs/windows-service-howto.xml Wed May 2 19:39:01 2012 @@ -108,10 +108,6 @@ --Classpath=xx.jar as command line parameter. -Note: PR_DEPENDSON, PR_ENVIRONMENT, PR_JVMOPTIONS, -PR_JVMMS, PR_JVMMX, PR_JVMSS, PR_STARTPARAMS, PR_STOPPARAMS and -PR_STOPTIMEOUT will not work until this bug is fixed: -http://issues.apache.org/jira/browse/DAEMON-49";>DAEMON-49 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53173] maxConnections feature hangs the system
https://issues.apache.org/bugzilla/show_bug.cgi?id=53173 --- Comment #2 from Filip Hanik --- Adding documentation to track cases where this can happen May 2, 2012 3:04:03 AM org.apache.tomcat.util.net.NioEndpoint$Acceptor run SEVERE: Socket accept failed java.io.IOException: Too many open files at sun.nio.ch.ServerSocketChannelImpl.accept0(Native Method) at sun.nio.ch.ServerSocketChannelImpl.accept(ServerSocketChannelImpl.java:152) at org.apache.tomcat.util.net.NioEndpoint$Acceptor.run(NioEndpoint.java:784) at java.lang.Thread.run(Thread.java:662) -- You are receiving this mail because: You are the assignee for the bug.
svn commit: r1333173 - /tomcat/trunk/webapps/docs/config/http.xml
Author: rjung Date: Wed May 2 19:51:49 2012 New Revision: 1333173 URL: http://svn.apache.org/viewvc?rev=1333173&view=rev Log: Fix trivial docs typo (missing ")"). Modified: tomcat/trunk/webapps/docs/config/http.xml Modified: tomcat/trunk/webapps/docs/config/http.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/http.xml?rev=1333173&r1=1333172&r2=1333173&view=diff == --- tomcat/trunk/webapps/docs/config/http.xml (original) +++ tomcat/trunk/webapps/docs/config/http.xml Wed May 2 19:51:49 2012 @@ -59,7 +59,7 @@ If still more simultaneous requests are received, they are stacked up inside the server socket created by the Connector, up to the configured maximum (the value of the acceptCount - attribute. Any further simultaneous requests will receive "connection + attribute). Any further simultaneous requests will receive "connection refused" errors, until resources are available to process them. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1333176 - in /tomcat/tc7.0.x/trunk: ./ webapps/docs/config/http.xml
Author: rjung Date: Wed May 2 19:55:10 2012 New Revision: 1333176 URL: http://svn.apache.org/viewvc?rev=1333176&view=rev Log: Fix trivial docs typo (missing ")"). Backport of r1333173 from trunk. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/webapps/docs/config/http.xml Propchange: tomcat/tc7.0.x/trunk/ -- Merged /tomcat/trunk:r1333173 Modified: tomcat/tc7.0.x/trunk/webapps/docs/config/http.xml URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/config/http.xml?rev=1333176&r1=1333175&r2=1333176&view=diff == --- tomcat/tc7.0.x/trunk/webapps/docs/config/http.xml (original) +++ tomcat/tc7.0.x/trunk/webapps/docs/config/http.xml Wed May 2 19:55:10 2012 @@ -59,7 +59,7 @@ If still more simultaneous requests are received, they are stacked up inside the server socket created by the Connector, up to the configured maximum (the value of the acceptCount - attribute. Any further simultaneous requests will receive "connection + attribute). Any further simultaneous requests will receive "connection refused" errors, until resources are available to process them. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1333177 - in /tomcat/tc6.0.x/trunk: ./ java/org/apache/catalina/core/ webapps/docs/config/http.xml
Author: rjung Date: Wed May 2 19:56:51 2012 New Revision: 1333177 URL: http://svn.apache.org/viewvc?rev=1333177&view=rev Log: Fix trivial docs typo (missing ")"). Backport of r1333173 from trunk resp. r1333176 from tc7.. Modified: tomcat/tc6.0.x/trunk/ (props changed) tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/ (props changed) tomcat/tc6.0.x/trunk/webapps/docs/config/http.xml Propchange: tomcat/tc6.0.x/trunk/ -- Merged /tomcat/trunk:r1333173 Merged /tomcat/tc7.0.x/trunk:r1333176 Propchange: tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/ -- Merged /tomcat/tc7.0.x/trunk/java/org/apache/catalina/core:r1333176 Modified: tomcat/tc6.0.x/trunk/webapps/docs/config/http.xml URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/config/http.xml?rev=1333177&r1=1333176&r2=1333177&view=diff == --- tomcat/tc6.0.x/trunk/webapps/docs/config/http.xml (original) +++ tomcat/tc6.0.x/trunk/webapps/docs/config/http.xml Wed May 2 19:56:51 2012 @@ -59,7 +59,7 @@ If still more simultaneous requests are received, they are stacked up inside the server socket created by the Connector, up to the configured maximum (the value of the acceptCount - attribute. Any further simultaneous requests will receive "connection + attribute). Any further simultaneous requests will receive "connection refused" errors, until resources are available to process them. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Commented] (MTOMCAT-149) Error deploying on Tomcat 6
[ https://issues.apache.org/jira/browse/MTOMCAT-149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266865#comment-13266865 ] costas commented on MTOMCAT-149: Nothing in the logs. A broken pipe exception probably means that the connection somehow ends before writing the file begins but I'm not sure how this happens. Would have expected something in the logs too. Having said that, using the tomcat-manager (web page) to deploy the same war file works correctly. > Error deploying on Tomcat 6 > --- > > Key: MTOMCAT-149 > URL: https://issues.apache.org/jira/browse/MTOMCAT-149 > Project: Apache Tomcat Maven Plugin > Issue Type: Bug > Components: tomcat6 >Affects Versions: 2.0-beta-1 > Environment: Apache Maven 2.2.1 (r801777; 2009-08-06 21:16:01+0200) > Java version: 1.6.0_31 > Java home: /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home > Default locale: en_US, platform encoding: MacRoman > OS name: "mac os x" version: "10.7.3" arch: "x86_64" Family: "mac" >Reporter: costas >Assignee: Olivier Lamy (*$^¨%`£) > Fix For: 2.0 > > > Deploying on Tomcat 6 throws the following exception: > Caused by: org.apache.http.client.ClientProtocolException > at > org.apache.http.impl.client.AbstractHttpClient.execute(AbstractHttpClient.java:926) > at > org.apache.http.impl.client.AbstractHttpClient.execute(AbstractHttpClient.java:822) > at > org.apache.tomcat.maven.common.deployer.TomcatManager.invoke(TomcatManager.java:718) > at > org.apache.tomcat.maven.common.deployer.TomcatManager.deployImpl(TomcatManager.java:681) > at > org.apache.tomcat.maven.common.deployer.TomcatManager.deploy(TomcatManager.java:363) > at > org.apache.tomcat.maven.plugin.tomcat6.AbstractDeployWarMojo.deployWar(AbstractDeployWarMojo.java:87) > at > org.apache.tomcat.maven.plugin.tomcat6.AbstractDeployMojo.invokeManager(AbstractDeployMojo.java:86) > at > org.apache.tomcat.maven.plugin.tomcat6.AbstractCatalinaMojo.execute(AbstractCatalinaMojo.java:143) > ... 20 more > Caused by: org.apache.http.client.NonRepeatableRequestException: Cannot retry > request with a non-repeatable request entity. The cause lists the reason the > original request failed. > at > org.apache.http.impl.client.DefaultRequestDirector.tryExecute(DefaultRequestDirector.java:682) > at > org.apache.http.impl.client.DefaultRequestDirector.execute(DefaultRequestDirector.java:515) > at > org.apache.http.impl.client.AbstractHttpClient.execute(AbstractHttpClient.java:923) > ... 27 more > Caused by: java.net.SocketException: Broken pipe > at java.net.SocketOutputStream.socketWrite0(Native Method) > at java.net.SocketOutputStream.socketWrite(SocketOutputStream.java:92) > at java.net.SocketOutputStream.write(SocketOutputStream.java:136) > at > org.apache.http.impl.io.AbstractSessionOutputBuffer.write(AbstractSessionOutputBuffer.java:163) > at > org.apache.http.impl.io.ContentLengthOutputStream.write(ContentLengthOutputStream.java:119) > at > org.apache.tomcat.maven.common.deployer.TomcatManager$RequestEntityImplementation.writeTo(TomcatManager.java:825) > at > org.apache.http.entity.HttpEntityWrapper.writeTo(HttpEntityWrapper.java:98) > at > org.apache.http.impl.client.EntityEnclosingRequestWrapper$EntityWrapper.writeTo(EntityEnclosingRequestWrapper.java:108) > at > org.apache.http.impl.entity.EntitySerializer.serialize(EntitySerializer.java:122) > at > org.apache.http.impl.AbstractHttpClientConnection.sendRequestEntity(AbstractHttpClientConnection.java:266) > at > org.apache.http.impl.conn.ManagedClientConnectionImpl.sendRequestEntity(ManagedClientConnectionImpl.java:197) > at > org.apache.http.protocol.HttpRequestExecutor.doSendRequest(HttpRequestExecutor.java:257) > at > org.apache.http.protocol.HttpRequestExecutor.execute(HttpRequestExecutor.java:125) > at > org.apache.http.impl.client.DefaultRequestDirector.tryExecute(DefaultRequestDirector.java:708) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
buildbot failure in ASF Buildbot on tomcat-trunk
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/2946 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source Stamp: [branch tomcat/trunk] 1333161 Blamelist: rjung BUILD FAILED: failed compile_1 sincerely, -The Buildbot
svn commit: r1333179 - /tomcat/tc5.5.x/trunk/container/webapps/docs/config/http.xml
Author: rjung Date: Wed May 2 20:02:14 2012 New Revision: 1333179 URL: http://svn.apache.org/viewvc?rev=1333179&view=rev Log: Fix trivial docs typo (missing ")"). Backport of r1333173 from trunk resp. r1333176 from tc7 resp. 1333177 from tc6. Modified: tomcat/tc5.5.x/trunk/container/webapps/docs/config/http.xml Modified: tomcat/tc5.5.x/trunk/container/webapps/docs/config/http.xml URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/container/webapps/docs/config/http.xml?rev=1333179&r1=1333178&r2=1333179&view=diff == --- tomcat/tc5.5.x/trunk/container/webapps/docs/config/http.xml (original) +++ tomcat/tc5.5.x/trunk/container/webapps/docs/config/http.xml Wed May 2 20:02:14 2012 @@ -61,7 +61,7 @@ If still more simultaneous requests are received, they are stacked up inside the server socket created by the Connector, up to the configured maximum (the value of the acceptCount - attribute. Any further simultaneous requests will receive "connection + attribute). Any further simultaneous requests will receive "connection refused" errors, until resources are available to process them. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53138] Not able to download a file size of 740KB using NIO connector in tomcat version 7.0.27. But with the same configuration I was able to download that in tomcat 7.0.26.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53138 --- Comment #5 from Robert Kish --- (In reply to comment #4) > Tested in > Firefox 11 and Internet Explorer 9 Tomcat installation: Running on HPUX 11.11: 64 bit JVM java version "1.6.0.14" Java(TM) SE Runtime Environment (build 1.6.0.14-jinteg_07_mar_2012_00_45-b00) Java HotSpot(TM) 64-Bit Server VM (build 20.6-b01-jre1.6.0.14-rc1b2 PA2.0W (aCC_AP), mixed mode) --- On Windows XP, Using IE 8, I get 114,688 bytes of the file. It takes a long time to download the file after the first chunk of data. I'm guessing it just gives up and stops. Using FF 12, I get about the same size of data initially - the file's progress is paused - I get the "Connecting" status - but after a while, the document completes and I get the whole size. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 53179] Missing ')' in "The HTTP Connector" documentation
https://issues.apache.org/bugzilla/show_bug.cgi?id=53179 Rainer Jung changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Rainer Jung --- Fixed in trunk, tc 7, tc 6 and tc 5.5 in revisions r1333173, r1333176, 1333177 and 1333179. Thanks. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 53180] New: DefaultInstanceManager#populateAnnotationsCache - incomplete check is used when validating for a setter method
https://issues.apache.org/bugzilla/show_bug.cgi?id=53180 Priority: P2 Bug ID: 53180 Assignee: dev@tomcat.apache.org Summary: DefaultInstanceManager#populateAnnotationsCache - incomplete check is used when validating for a setter method Severity: normal Classification: Unclassified OS: All Reporter: violet...@apache.org Hardware: All Status: NEW Version: 7.0.27 Component: Catalina Product: Tomcat 7 Created attachment 28711 --> https://issues.apache.org/bugzilla/attachment.cgi?id=28711&action=edit Patch proposal Hi, In org.apache.catalina.core.DefaultInstanceManager#populateAnnotationsCache, when iterating over methods in a given class, in one of the cases (when injection-target is specified) you validate whether the method is a valid setter method. In my opinion the check that is used for that validation is not complete. I would like to propose a patch (attached) that introduces additional checks in order to guarantee that the corresponding method is really suitable to be an injection target. I'm looking forward to your commends. Best Regards Violeta Georgieva -- You are receiving this mail because: You are the assignee for the bug.
[Bug 53138] Not able to download a file size of 740KB using NIO connector in tomcat version 7.0.27. But with the same configuration I was able to download that in tomcat 7.0.26.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53138 --- Comment #6 from Filip Hanik --- Thanks Robert, are you able to reproduce this on a non HPUX system with a more recent runtime? ie, can you reproduce the attached test case on your local laptop or workstation? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 53180] DefaultInstanceManager#populateAnnotationsCache - incomplete check is used when validating for a setter method
https://issues.apache.org/bugzilla/show_bug.cgi?id=53180 Violeta Georgieva changed: What|Removed |Added Attachment #28711|0 |1 is patch|| Attachment #28711|application/octet-stream|text/plain mime type|| -- You are receiving this mail because: You are the assignee for the bug.
[Bug 53138] Not able to download a file size of 740KB using NIO connector in tomcat version 7.0.27. But with the same configuration I was able to download that in tomcat 7.0.26.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53138 --- Comment #7 from Robert Kish --- (In reply to comment #6) > Thanks Robert, are you able to reproduce this on a non HPUX system with a > more recent runtime? ie, can you reproduce the attached test case on your > local laptop or workstation? Yes. I just finished testing this on my PC: Windows XP SP 3 32 bit JVM java version "1.7.0_03" Java(TM) SE Runtime Environment (build 1.7.0_03-b05) Java HotSpot(TM) Client VM (build 22.1-b02, mixed mode, sharing) It worked on Tomcat 7.0.26. I installed 7.0.27, and it didn't work. I went back to 7.0.26, and it works again. -- You are receiving this mail because: You are the assignee for the bug.
buildbot success in ASF Buildbot on tomcat-7-trunk
The Buildbot has detected a restored build on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/545 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source Stamp: [branch tomcat/tc7.0.x/trunk] 1333176 Blamelist: rjung Build succeeded! sincerely, -The Buildbot
[Bug 53138] Not able to download a file size of 740KB using NIO connector in tomcat version 7.0.27. But with the same configuration I was able to download that in tomcat 7.0.26.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53138 --- Comment #8 from Filip Hanik --- Thanks Robert, I can reproduce it with IE 9 if I hit the "Save" option when I hit refresh in the browser. I will check on this and see how it works out -- You are receiving this mail because: You are the assignee for the bug.
svn commit: r1333218 - in /tomcat/trunk: java/org/apache/tomcat/util/net/NioEndpoint.java webapps/docs/changelog.xml webapps/docs/config/http.xml
Author: fhanik
Date: Wed May 2 21:33:43 2012
New Revision: 1333218
URL: http://svn.apache.org/viewvc?rev=1333218&view=rev
Log:
Modify the default pollerThreadCount
as processors go, it gets very polluting and resource wasting to have 24,48 or
64 and more poller threads
Very hard for applications to see a performance benefit of more than 2 pollers
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
tomcat/trunk/webapps/docs/changelog.xml
tomcat/trunk/webapps/docs/config/http.xml
Modified: tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java?rev=1333218&r1=1333217&r2=1333218&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java Wed May 2
21:33:43 2012
@@ -333,7 +333,7 @@ public class NioEndpoint extends Abstrac
/**
* Poller thread count.
*/
-protected int pollerThreadCount =
Runtime.getRuntime().availableProcessors();
+protected int pollerThreadCount =
Math.min(2,Runtime.getRuntime().availableProcessors());
public void setPollerThreadCount(int pollerThreadCount) {
this.pollerThreadCount = pollerThreadCount; }
public int getPollerThreadCount() { return pollerThreadCount; }
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1333218&r1=1333217&r2=1333218&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Wed May 2 21:33:43 2012
@@ -72,6 +72,15 @@
+
+
+
+Update default value of pollerThreadCount for the NIO connector.
+The new default value will never go above 2 regardless of
+available processors. (fhanik)
+
+
+
Modified: tomcat/trunk/webapps/docs/config/http.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/http.xml?rev=1333218&r1=1333217&r2=1333218&view=diff
==
--- tomcat/trunk/webapps/docs/config/http.xml (original)
+++ tomcat/trunk/webapps/docs/config/http.xml Wed May 2 21:33:43 2012
@@ -608,8 +608,15 @@
(int)The number of threads to be used to run for the polling events.
-Default value is 1 per processor. Can't see a reason to go
-above that. But experiment and find your own results.
+Default value is 1 per processor up to and including
version 7.0.27.
+Default value as of version 7.0.28 is 1 per processor but
not more than 2.
+When accepting a socket, the operating system holds a global lock. So
the benefit of
+going above 2 threads diminishes rapidly. Having more than one thread
is for
+system that need to accept connections very rapidly. However usually
just
+increasing acceptCount will solve that problem.
+Increasing this value may also be beneficial when a large amount of
send file
+operations are going on.
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1333221 - in /tomcat/tc7.0.x/trunk: java/org/apache/tomcat/util/net/NioEndpoint.java webapps/docs/changelog.xml webapps/docs/config/http.xml
Author: fhanik
Date: Wed May 2 21:36:44 2012
New Revision: 1333221
URL: http://svn.apache.org/viewvc?rev=1333221&view=rev
Log:
Modify the default pollerThreadCount
as processors go, it gets very polluting and resource wasting to have 24,48 or
64 and more poller threads
Very hard for applications to see a performance benefit of more than 2 pollers
Modified:
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
tomcat/tc7.0.x/trunk/webapps/docs/config/http.xml
Modified: tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java?rev=1333221&r1=1333220&r2=1333221&view=diff
==
--- tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
(original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java Wed
May 2 21:36:44 2012
@@ -333,7 +333,7 @@ public class NioEndpoint extends Abstrac
/**
* Poller thread count.
*/
-protected int pollerThreadCount =
Runtime.getRuntime().availableProcessors();
+protected int pollerThreadCount =
Math.min(2,Runtime.getRuntime().availableProcessors());
public void setPollerThreadCount(int pollerThreadCount) {
this.pollerThreadCount = pollerThreadCount; }
public int getPollerThreadCount() { return pollerThreadCount; }
Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1333221&r1=1333220&r2=1333221&view=diff
==
--- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Wed May 2 21:36:44 2012
@@ -88,6 +88,11 @@
53173 (1333116) :
Properly count down maxConnections (fhanik)
+
+Update default value of pollerThreadCount for the NIO connector.
+The new default value will never go above 2 regardless of
+available processors. (fhanik)
+
Modified: tomcat/tc7.0.x/trunk/webapps/docs/config/http.xml
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/config/http.xml?rev=1333221&r1=1333220&r2=1333221&view=diff
==
--- tomcat/tc7.0.x/trunk/webapps/docs/config/http.xml (original)
+++ tomcat/tc7.0.x/trunk/webapps/docs/config/http.xml Wed May 2 21:36:44 2012
@@ -608,8 +608,15 @@
(int)The number of threads to be used to run for the polling events.
-Default value is 1 per processor. Can't see a reason to go
-above that. But experiment and find your own results.
+Default value is 1 per processor up to and including
version 7.0.27.
+Default value as of version 7.0.28 is 1 per processor but
not more than 2.
+When accepting a socket, the operating system holds a global lock. So
the benefit of
+going above 2 threads diminishes rapidly. Having more than one thread
is for
+system that need to accept connections very rapidly. However usually
just
+increasing acceptCount will solve that problem.
+Increasing this value may also be beneficial when a large amount of
send file
+operations are going on.
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53138] Not able to download a file size of 740KB using NIO connector in tomcat version 7.0.27. But with the same configuration I was able to download that in tomcat 7.0.26.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53138 --- Comment #9 from Filip Hanik --- In the meantime a workaround for this is to set useSendfile="false" -- You are receiving this mail because: You are the assignee for the bug.
[Bug 53138] Not able to download a file size of 740KB using NIO connector in tomcat version 7.0.27. But with the same configuration I was able to download that in tomcat 7.0.26.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53138 --- Comment #10 from Filip Hanik --- Current suspect is: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java?r1=1300872&r2=1300950&diff_format=h -- You are receiving this mail because: You are the assignee for the bug.
buildbot failure in ASF Buildbot on tomcat-7-trunk
The Buildbot has detected a new failure on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/546 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source Stamp: [branch tomcat/tc7.0.x/trunk] 1333221 Blamelist: fhanik BUILD FAILED: failed compile_1 sincerely, -The Buildbot
Re: svn commit: r1333218 - in /tomcat/trunk: java/org/apache/tomcat/util/net/NioEndpoint.java webapps/docs/changelog.xml webapps/docs/config/http.xml
Filip, On 5/2/12 5:33 PM, fha...@apache.org wrote: > Very hard for applications to see a performance benefit of more than 2 pollers [...] > -protected int pollerThreadCount = > Runtime.getRuntime().availableProcessors(); > +protected int pollerThreadCount = > Math.min(2,Runtime.getRuntime().availableProcessors()); I think you mean Math.max(). What you have is a minimum of 2 and a maximum of the number of cores, which is exactly the opposite of what your commit comment says is appropriate. -chris signature.asc Description: OpenPGP digital signature
RE: svn commit: r1333218 - in /tomcat/trunk: java/org/apache/tomcat/util/net/NioEndpoint.java webapps/docs/changelog.xml webapps/docs/config/http.xml
Math.min is the intention here. On a 64 core box, it should still only have 2
pollers, not 64
The comment should read ('from' instead of 'of')
> > Very hard for applications to see a performance benefit *from* more than 2
> pollers
> -Original Message-
> From: Christopher Schultz [mailto:ch...@christopherschultz.net]
> Sent: Wednesday, May 02, 2012 7:14 PM
> To: Tomcat Developers List
> Subject: Re: svn commit: r1333218 - in /tomcat/trunk:
> java/org/apache/tomcat/util/net/NioEndpoint.java
> webapps/docs/changelog.xml webapps/docs/config/http.xml
>
> Filip,
>
> On 5/2/12 5:33 PM, fha...@apache.org wrote:
> > Very hard for applications to see a performance benefit of more than 2
> pollers
>
> [...]
>
> > -protected int pollerThreadCount =
> Runtime.getRuntime().availableProcessors();
> > +protected int pollerThreadCount =
> Math.min(2,Runtime.getRuntime().availableProcessors());
>
> I think you mean Math.max(). What you have is a minimum of 2 and a
> maximum of the number of cores, which is exactly the opposite of what
> your commit comment says is appropriate.
>
> -chris
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
