Re: Duplicate String values
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 27/04/2012 01:37, Christopher Schultz wrote: > All, > > I've been doing some memory profiling on my webapp to see where I > can reduce our memory footprint a bit by combining equivalent > objects. YourKit has some nice utilities to look for duplicate > objects -- especially Strings. > > I can see that the string "java.lang.String" has lots of > duplicates. Many of the ones I've inspected so far can be > traced-back to catalina.mbeans.MBeanUtils and the registry of > MBeans that it contains. > > Would anyone object to using String-interning to share copies of > class names for MBeans? I could even restrict such interning to > Strings that start with "java.lang" since those are probably the > most-used ones, and those strings are probably already interned by > all the RTTI infrastructure in the JVM anyway. In principle, no objection. As always, I'll reserve final judgement until I see the commit diff. Mark -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJPmk2uAAoJEBDAHFovYFnnyT0P/RcD/tjhue64kOi/tNxA6nFT Sa+GCRpkQeaM1V8OovdzjQ09HjiHnwSdM2v0zLe5RsiohN0fJUr8ynVnCZUg8n1O aca5q++6gPQmYMjW1A+q9y0D08srcTygrT2vuvI2XFDrioiuKwrjrJxKJ3JW81U5 dkXIARArf0HXi/rHF92o7HxpZ0YbqKiRc+d34ATs+SBzKayio+EwEGPmWOYZoBbV lFQnoOlYeVQMlAFiPSn8qKFAE+jL5y9jUUQ49UmB9S/J43/bA+eAey881o/EePGR FMOOIJVfNZdFduLh/stPNLfxPo204dWzPawbLNbt1GNlkEO+GNeIwNYat+D3o1UK K7uN8ptxgp72L790+5VIkaQc1Nr5APtbvnooMG6zrVTT3KqeH0AFDnWjYTwTDQrC 8ZFW1nYV+bnppbuyest18UPKbclDiv7dVlFPIz8iqo+8qXj2YorMJOPtEECgGl/P cYqK+t3L7ukqYrtCqSLXdKEL6ydaJhWKHrJNsjC52PDVMTFtMbRdPeV2RDQ2jFwZ 7voZUL/CXB6xqvqEDSHLZuEZa4eUeKEGZf8eR8v+7V5XM1ix9r0r5jkWwWxlljjL qkJm0Rcj8BJjBP9475SL4iuvvVzS3XMx/gd2ZPKCt04YaAsqfK7tfis7aZOup9qm q/61iuBhdmusMOqn3Gwu =RMrw -END PGP SIGNATURE- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Updated] (MTOMCAT-144) resourcePaths returns null
[ https://issues.apache.org/jira/browse/MTOMCAT-144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy (*$^¨%`£) updated MTOMCAT-144: --- Fix Version/s: moreinfo please provide a sample project to reproduce. > resourcePaths returns null > -- > > Key: MTOMCAT-144 > URL: https://issues.apache.org/jira/browse/MTOMCAT-144 > Project: Apache Tomcat Maven Plugin > Issue Type: Bug > Components: tomcat7 >Affects Versions: 2.0 > Environment: windows tomcat7:run >Reporter: Per Wramdemark >Assignee: Olivier Lamy (*$^¨%`£) > Fix For: moreinfo > > > Hi, > Suddenly a few days ago (unclear exactly when) when i run the code below it > returns null. It worked two weeks ago and still works if I step back to > version 2.0-beta-1. > I'm running the goal "tomcat7:run" > code that returns null: > getServletContext().getResourcePaths(path); > pom config: > org.apache.tomcat.maven > tomcat7-maven-plugin > > 2.0-SNAPSHOT -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53139] Prevent showing keystore/truststore passwords via JMX in cleartext (with solution)
https://issues.apache.org/bugzilla/show_bug.cgi?id=53139 --- Comment #1 from Mark Thomas --- I not convinced that there is a security problem to solve here. JMX access is equivalent to full admin access and admins would be able to read those values in server.xml anyway. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 52996] Please backport r723889 from trunk to have MaxQueueSize attribute for Executor available in Tomcat 6
https://issues.apache.org/bugzilla/show_bug.cgi?id=52996 --- Comment #1 from Ruediger Pluem --- Created attachment 28687 --> https://issues.apache.org/bugzilla/attachment.cgi?id=28687&action=edit Backport of r723889 without changes to the Executor interface to Tomcat 6.0.x trunk As discussed on list: Backport version of r723889 without changes to the Executor interface to ensure backwards compatibility. -- You are receiving this mail because: You are the assignee for the bug.
RE: have Re: MaxQueueSize for Executor and Tomcat 6
> -Original Message- > From: Filip Hanik Mailing Lists [mailto:devli...@hanik.com] > Sent: Montag, 23. April 2012 17:37 > To: Tomcat Developers List > Subject: Re: have Re: MaxQueueSize for Executor and Tomcat 6 > > > > - Original Message - > > From: "Rüdiger Plüm, Vodafone Group" > > > > > Ok. As far as I can see the new method > > > > execute(Runnable command, long timeout, TimeUnit unit); > > > > of the Executor interface is implemented but not used. > > Would it still be an acceptable backport if > > > > 1. The changes to the Executor interface are removed from the patch > > 2. The implementation of execute(Runnable command, long timeout, > > TimeUnit unit); is removed from the patch. > > > > If yes I can update the patch. > > Yes Done. https://issues.apache.org/bugzilla/show_bug.cgi?id=52996 https://issues.apache.org/bugzilla/attachment.cgi?id=28687 Regards Rüdiger
Re: svn commit: r1303339 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/realm/RealmBase.java webapps/docs/changelog.xml
On 25/04/12 12:32, Mark Thomas wrote: On 25/04/2012 12:03, Brian Burch wrote: On 24/04/12 21:34, Mark Thomas wrote: On 24/04/2012 21:11, Mark Thomas wrote: On 24/04/2012 20:51, Brian Burch wrote: Sorry I haven't been able to quote the details of this commit made by markt a month ago, but I didn't keep a copy in my inbox. I previously submitted an enhancement to the corresponding test suite https://issues.apache.org/bugzilla/show_bug.cgi?id=53096 I fully expected all my test cases would succeed against mark's trivial bugfix. I recently brought my trunk sandbox up to svn: r1329909 and was puzzled to discover the relevant test case still FAILED! I've done a lot of digging and debugging, and come to the conclusion this problem is more subtle than originally thought. Does anyone know whether the current fix has been validated against a real android device? I suspect it doesn't work. I certainly didn't at the time, but I can quite easily. The issues are: 1. the one line change: -String md5a1 = getDigest(username, realm); +// In digest auth, digests are always lower case +String md5a1 = getDigest(username, realm).toLowerCase(Locale.ENGLISH); If I remember correctly, the intention was to be make tomcat more tolerant of clients that presented digest strings with upper case hexadecimal digits provided they were otherwise correct. The change in r1329909 seems to me as if it does nothing of relevance to that objective. Agreed. (if that was the objective). However, that was not the objective. The objective was to handle programs that created hashes for the user database that used capitals. The Android DIGEST auth issue was related to URIs. See https://issues.apache.org/bugzilla/show_bug.cgi?id=52954 Let me see what happens with 2.3.5 and 4.0.3 and decide then. Watch this space... BZ 52954 is not an issue in Android 4.0.3 but it is in 2.3.5. Given that 2.3.x is by far the most prevalent Android version at the moment we should certainly take a look at fixing BZ 52954. Upper/lower case digests from android clients is a red herring. I don't understand exactly what you mean by that. Didn't the original report say android http clients were sending HTTP Digest hex strings with upper case A-F, or was I just dreaming? You were dreaming. Go read BZ 52964. Not quite dreaming... it seems I created an imaginary cocktail of two bugs:- BZ 52953 Unlike BASIC Authentication, DIGEST mode does not work if the hash is stored in uppercase and BZ 52954 Allowing for broken android HTTP DIGEST support I thought (wrongly) they were both referring to android clients. r1329909 implied it was trying to resolve that issue, even if it was also resolving others. Unfortunately, r1329909 pointlessly manipulates a hex digest string that is already certain to contain lower case hex digits. No it didn't. And that isn't the right revision number either. We are discussing this: http://svn.apache.org/viewvc?view=revision&revision=r1303339 Careless of me to imply the change in question was the latest at the time I did my update. I'm glad you were paying attention and I hope I didn't waste any of your time. It now makes sense to me why your r1303339 hit the server-side recreation of the expected client digest. You were not addressing the case where an upper-case hex digit had arrived from an http client. I apologise for muddying the water. For what it is worth, here is my patch to achieve the "apparently desired" objective (my "situation 1"). You'll see that it also cleans up a debug parameter list by a) removing duplication of clientDigest and b) fixing a typo in a field label. That isn't the problem. Android has no problems sending digests in lower case s required by the spec. My suggested patch had three objectives (I assumed you would break it into smaller commits): 1. Would you please clean up the debug message parameters (as proposed in my diff)? It seems overkill to open a new bug for this trivial change. 2. In the case where an http client has sent an invalid digest string (anything that is not a lower case hex digit) rfc2617 seems to me to mandate http status 400 (syntax error, do not retry), but my tests show tomcat is sending 401 (unauthorized) when I inject "A" (or even "G") into the digest string. That looks like a new bug to me - what do you think? 3. My revised opinion is that r1303339 is effective, but tackles the user database problem too far down the track. RealmBase.getDigest(String username, String realmName) has two cases. When a cleartext password is available it can be trusted to return an rfc-compliant digest from org.apache.catalina.util.MD5Encoder.encode(). However, if the concrete implementation of getPassword returns a pre-digested password, getDigest should not simply trust the returned String to be rfc-compliant. I think it should a) validate the string and throw some sort of exception if it is not a meaningful md5 digest, and p
[Bug 48956] SSI regular expressions not working
https://issues.apache.org/bugzilla/show_bug.cgi?id=48956 Hipnosis changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #3 from Hipnosis --- Hi, I found a bug working with Tomcat, SSI and regular expression that is still unresolved and my work is essential for proper operation: For example: Resulting value: In a html file works correctly, but when working on Tomcat, a complex regular expression fails, and the page returns nothing from it. Regards and await your response. -- You are receiving this mail because: You are the assignee for the bug.
[GUMP@vmgump]: Project tomcat-tc7.0.x-test (in module tomcat-7.0.x) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-test has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 22 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-tc7.0.x-test : Tomcat 7.x, a web server implementing Java Servlet 3.0, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on tomcat-tc7.0.x-dbcp exists, no need to add for property tomcat-dbcp-src.jar. -DEBUG- Dependency on commons-daemon exists, no need to add for property commons-daemon.native.src.tgz. -DEBUG- Dependency on commons-daemon exists, no need to add for property tomcat-native.tar.gz. -DEBUG- Dependency on tomcat-tc7.0.x-dbcp exists, no need to add for property tomcat-dbcp.home. -INFO- Failed with reason build failed -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-7.0.x/output/build/logs The following work was performed: http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-test/gump_work/build_tomcat-7.0.x_tomcat-tc7.0.x-test.html Work Name: build_tomcat-7.0.x_tomcat-tc7.0.x-test (Type: Build) Work ended in a state of : Failed Elapsed: 22 mins 33 secs Command Line: /usr/lib/jvm/java-6-openjdk/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Djunit.jar=/srv/gump/public/workspace/junit/dist/junit-28042012.jar -Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-28042012-native-src.tar.gz -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-28042012-native-src.tar.gz -Dexamples.sources.skip=true -Dtomcat-dbcp.home=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps -Djdt.jar=/srv/gump/packages/eclipse/plugins/org.eclipse.jdt.core_3.4.2/jdtcore.jar -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-28042012.jar -Dtomcat-dbcp-src.jar=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps/tomcat-dbcp-src.jar -Dtest.accesslog=true -Dcommons-pool.home=/srv/gump/public/workspace/commons-pool-1.x -Dcommons-dbcp.home=/ srv/gump/public/workspace/commons-dbcp-1.x -Dtomcat-dbcp.jar=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps/tomcat-dbcp-28042012.jar test [Working Directory: /srv/gump/public/workspace/tomcat-7.0.x] CLASSPATH: /usr/lib/jvm/java-6-openjdk/lib/tools.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-7.0.x/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/servlet-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/outp ut/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/tomcat-util.jar:/srv/gump/packages/eclipse/plugins/org.eclipse.jdt.core_3.4.2/jdtcore.jar:/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps/tomcat-dbcp-28042012.jar:/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-28042012.jar:/srv/gump/ public/workspace/junit/dist/junit-28042012.jar - [junit] Apr 28, 2012 4:52:
[GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 3 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-trunk-test : Tomcat 8.x, a web server implementing Java Servlet 3.1, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on tomcat-trunk-dbcp exists, no need to add for property tomcat-dbcp-src.jar. -DEBUG- Dependency on commons-daemon exists, no need to add for property commons-daemon.native.src.tgz. -DEBUG- Dependency on commons-daemon exists, no need to add for property tomcat-native.tar.gz. -DEBUG- Dependency on tomcat-trunk-dbcp exists, no need to add for property tomcat-dbcp.home. -INFO- Failed with reason build failed -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-trunk/output/build/logs The following work was performed: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/gump_work/build_tomcat-trunk_tomcat-trunk-test.html Work Name: build_tomcat-trunk_tomcat-trunk-test (Type: Build) Work ended in a state of : Failed Elapsed: 22 mins 58 secs Command Line: /usr/lib/jvm/java-6-openjdk/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Djunit.jar=/srv/gump/public/workspace/junit/dist/junit-28042012.jar -Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-28042012-native-src.tar.gz -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-28042012-native-src.tar.gz -Dexamples.sources.skip=true -Dtomcat-dbcp.home=/srv/gump/public/workspace/tomcat-trunk/tomcat-deps -Djdt.jar=/srv/gump/packages/eclipse/plugins/org.eclipse.jdt.core_3.4.2/jdtcore.jar -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-28042012.jar -Dtomcat-dbcp-src.jar=/srv/gump/public/workspace/tomcat-trunk/tomcat-deps/tomcat-dbcp-src.jar -Dtest.accesslog=true -Dcommons-pool.home=/srv/gump/public/workspace/commons-pool-1.x -Dcommons-dbcp.home=/ srv/gump/public/workspace/commons-dbcp-1.x -Dtomcat-dbcp.jar=/srv/gump/public/workspace/tomcat-trunk/tomcat-deps/tomcat-dbcp-28042012.jar test [Working Directory: /srv/gump/public/workspace/tomcat-trunk] CLASSPATH: /usr/lib/jvm/java-6-openjdk/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.jar:/srv/gump/public/workspace/tomcat-trunk/outp ut/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-jni.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-util.jar:/srv/gump/packages/javamail-1.4/mail.jar:/srv/gump/packages/javamail-1.4/lib/mailapi.jar:/srv/gump/packages/jaf-1.1ea/activation.jar:/srv/gump/packages/eclipse/plugins/org .eclipse.jdt.core_3.4.2/jdtcore.jar:/srv/gump/public/workspace/tomcat-trunk/tomcat-deps/tomcat-dbcp-28042012.jar:/srv/gump/public/workspace
