DO NOT REPLY [Bug 52579] Tomcat5.5.35+Java1.5 cannot return proper value of a request parameter

2012-04-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52579

taffy-tyler6...@hotmail.co.uk changed:

   What|Removed |Added

 CC||taffy-tyler6...@hotmail.co.
   ||uk

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[jira] [Commented] (MTOMCAT-145) [2.0-beta-1] Unable to deploy

2012-04-18 Thread *$^¨%`£

[ 
https://issues.apache.org/jira/browse/MTOMCAT-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256394#comment-13256394
 ] 

Olivier Lamy (*$^¨%`£) commented on MTOMCAT-145:


Can you try 2.0-SNAPSHOT ?
This must/should be fixed!

> [2.0-beta-1] Unable to deploy 
> --
>
> Key: MTOMCAT-145
> URL: https://issues.apache.org/jira/browse/MTOMCAT-145
> Project: Apache Tomcat Maven Plugin
>  Issue Type: Bug
>  Components: tomcat6
>Affects Versions: 2.0-beta-1
> Environment: Maven 3.0.4 command-line on Windows 7 x64
> Tomcat 6.0.13 
> CentOs 4.9
>Reporter: Jeff Vincent
>Assignee: Olivier Lamy (*$^¨%`£)
>Priority: Critical
>
> I have been using the codhaus version of the tomcat-maven-plugin and am 
> trying to switch to the latest Apache Tomcat Maven Plugin.
> Deploy works with the codhaus version using 'mvn tomcat:redeploy -Pdev02`.  
> The username/password are normally in my profile settings.  
> Deploy fails with apache version using:  'mvn tomcat6:redeploy -Pdev02'.  
> I've specified a  entry in the settings.xml, and specified the same 
> value in the  section of the the plugin  to avoid 
> "[DEBUG] No server specified for authentication - using defaults" errors.
> Below is my maven profile.  I've tried changing the URL when running the 
> tomcat6:deploy/redeploy targets with and without a trailing '/text'.  I get a 
> 404 with the '/text' and "Cannot invoke Tomcat manager" if I ommit the 
> '/text'.
> Although, without the '/text' in the URL, it appears to upload the war as it 
> shows a progress indicator then fails with the error below:
> 
> 
>   dev02
>   
> false
>   
>   
> 
>   
> org.apache.tomcat.maven
> tomcat6-maven-plugin
> 2.0-beta-1
> 
>   war
>   http://10.12.4.2/manager
>   true
>   UTF-8
>   UTF-8
>   HTTP/1.1
>   true
>   dev02
> 
>   
> 
>   
> 
> //- MAVEN OUTPUT 
> [DEBUG] Configuring mojo 
> org.apache.tomcat.maven:tomcat6-maven-plugin:2.0-beta-1:redeploy from plugin 
> realm 
> ClassRealm[plugin>org.apache.tomcat.maven:tomcat6-maven-plugin:2.0-beta-1, 
> parent: sun.misc.Launcher$AppClassLoader@3326b249]
> [DEBUG] Configuring mojo 
> 'org.apache.tomcat.maven:tomcat6-maven-plugin:2.0-beta-1:redeploy' with basic 
> configurator -->
> [DEBUG]   (f) charset = UTF-8
> [DEBUG]   (f) contextFile = 
> C:\Users\jvincent\Dev\Java\Domain\target\Domain-2012.04.04-SNAPSHOT\META-INF\context.xml
> [DEBUG]   (f) ignorePackaging = false
> [DEBUG]   (f) mode = war
> [DEBUG]   (f) packaging = war
> [DEBUG]   (f) path = /Domain
> [DEBUG]   (f) server = dev02
> [DEBUG]   (f) update = true
> [DEBUG]   (f) url = http://10.12.4.2/manager
> [DEBUG]   (f) version = 2.0-beta-1
> [DEBUG]   (f) warFile = 
> C:\Users\jvincent\Dev\Java\Domain\target\Domain-2012.04.04-SNAPSHOT.war
> [DEBUG] -- end configuration --
> [INFO] Deploying war to http://10.12.4.2/Domain  
> Uploading: http://10.12.4.2/manager/deploy?path=%2FDomain&update=true
> [Progress Indicator..]
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 5.490s
> [INFO] Finished at: Tue Apr 17 17:51:59 MDT 2012
> [INFO] Final Memory: 8M/244M
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.tomcat.maven:tomcat6-maven-plugin:2.0-beta-1:redeploy 
> (default-cli) on project Domain: Cannot invoke Tomcat manager: 
> ClientProtocolException: Cannot retry request with a non-repeatable request 
> entity. -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.tomcat.maven:tomcat6-maven-plugin:2.0-beta-1:redeploy 
> (default-cli) on project Domain: Cannot invoke Tomcat manager
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:217)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161)
>   at org.apache.maven.DefaultMaven.doExecute(Def

[jira] [Created] (MTOMCAT-146) Multiple executions of run-war-only has Valve problems at shutdown

2012-04-18 Thread Benson Margulies (Created) (JIRA)
Multiple executions of run-war-only has Valve problems at shutdown
--

 Key: MTOMCAT-146
 URL: https://issues.apache.org/jira/browse/MTOMCAT-146
 Project: Apache Tomcat Maven Plugin
  Issue Type: Bug
  Components: tomcat6
Affects Versions: 2.0-beta-1
Reporter: Benson Margulies
Assignee: Olivier Lamy (*$^¨%`£)


{noformat}
INFO: Stopping Coyote HTTP/1.1 on http-51155
Apr 18, 2012 8:19:17 AM org.apache.catalina.core.StandardPipeline 
unregisterValve
INFO: Can't unregister valve 
org.apache.catalina.core.StandardEngineValve[localEngine]
javax.management.InstanceNotFoundException: 
localEngine:type=Valve,name=StandardEngineValve
at 
com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getMBean(DefaultMBeanServerInterceptor.java:1094)
at 
com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.exclusiveUnregisterMBean(DefaultMBeanServerInterceptor.java:415)
at 
com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.unregisterMBean(DefaultMBeanServerInterceptor.java:403)
at 
com.sun.jmx.mbeanserver.JmxMBeanServer.unregisterMBean(JmxMBeanServer.java:506)
at 
org.apache.catalina.core.StandardPipeline.unregisterValve(StandardPipeline.java:322)
at 
org.apache.catalina.core.StandardPipeline.stop(StandardPipeline.java:275)
at org.apache.catalina.core.ContainerBase.stop(ContainerBase.java:1103)
at org.apache.catalina.core.StandardEngine.stop(StandardEngine.java:468)
at org.apache.catalina.startup.Embedded.stop(Embedded.java:867)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at 
org.apache.tomcat.maven.common.run.EmbeddedRegistry.shutdownAll(EmbeddedRegistry.java:110)
at 
org.apache.tomcat.maven.plugin.tomcat6.ShutdownMojo.execute(ShutdownMojo.java:63)
{noformat}

{code}
  
  org.apache.tomcat.maven
  tomcat6-maven-plugin
  2.0-beta-1



tomcat-run

run-war-only

pre-integration-test

/
${tomcat.port}
UTF-8

${project.build.directory}/webapps/solr/
true
true
src/test/context.xml

  
${project.build.directory}/solr_home
  
${project.build.directory}/bt-rni-solr3x-plugins.jar
  ../../../../..





tomcat2-run

run-war-only

pre-integration-test

/
${tomcat2.port}
UTF-8

${project.build.directory}/webapps/solr2/

${project.build.directory}/tomcat2
true
true
src/test/context.xml

  
${project.build.directory}/solr2
  
${project.build.directory}/bt-rni-solr3x-plugins.jar
  ../../../../..






tomcat-shutdown

  
shutdown

post-integration-test



{code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 52853] @HandlesTypes not resolving classes when added as repository directory

2012-04-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52853

--- Comment #9 from Benjamin Muschko  2012-04-18 
12:50:10 UTC ---
I started to create a test case for this issue but I am not sure if it is
actually working as I was not able to run the tests using Ant. When asking the
question on the mailing list I didn't get a response:
http://tomcat.10.n6.nabble.com/Build-Tomcat-from-sources-on-GitHub-repo-td4884681.html.
Do you guys know what I am doing wrong? You can find my test case class
(org.apache.catalina.loader.TestHandleTypesWebappLoader.java) here:

https://github.com/bmuschko/tomcat70/blob/webapp-3.0-spring/test/org/apache/catalina/loader/TestHandleTypesWebappLoader.java

Any help would be highly appreciated.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 52853] @HandlesTypes not resolving classes when added as repository directory

2012-04-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52853

Benjamin Muschko  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



fireRequestDestroyEvent now fired by StandardHostValve instead of StandardContextValve

2012-04-18 Thread Martin Grotzke
Hi,

in r1164481 the notification of ServletRequestListeners was moved from
StandardContextValve to StandardHostValve.

This causes issues for memcached-session-manager (msm) in combination
with openwebbeans (OWB).

In short, msm is an alternative session manager that uses memcached as
for session storage. It uses a valve to track the start/end of a
request, at the end of the request (at the end of valve.invoke) msm
stores the session in memcached.

OWB uses a ServletRequestListener to prepare the session for failover
support on requestDestroyed.

With the change in tomcat (r1164481), OWB does no longer work with msm,
as the ServletRequestListener is now invoked by StandardHostValve
*after* msm has already writted the session to memcached - so the
changes by OWB are lost.

This is the issue in the OWB issue tracker btw:
https://issues.apache.org/jira/browse/OWB-646

AFAIU the commit message it's completely intended that StandardHostValve
now invokes StandardContext.fireRequestDestroyEvent.
So I assume you're not going to change this again - or do you see
alternative solutions for the problem that should be solved by this change?

Assuming that you're not going to change StandardHostValve, what would
you suggest how to integrate msm and OWB properly?

Thanx in advance,
cheers,
Martin





signature.asc
Description: OpenPGP digital signature


[jira] [Commented] (MTOMCAT-145) [2.0-beta-1] Unable to deploy

2012-04-18 Thread Jeff Vincent (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/MTOMCAT-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256661#comment-13256661
 ] 

Jeff Vincent commented on MTOMCAT-145:
--

Where is the snapshot repository?  If it is 
https://repository.apache.org/content/repositories/snapshots/, I'm having a 
hard time getting my Maven client or Archiva server to find it.

> [2.0-beta-1] Unable to deploy 
> --
>
> Key: MTOMCAT-145
> URL: https://issues.apache.org/jira/browse/MTOMCAT-145
> Project: Apache Tomcat Maven Plugin
>  Issue Type: Bug
>  Components: tomcat6
>Affects Versions: 2.0-beta-1
> Environment: Maven 3.0.4 command-line on Windows 7 x64
> Tomcat 6.0.13 
> CentOs 4.9
>Reporter: Jeff Vincent
>Assignee: Olivier Lamy (*$^¨%`£)
>Priority: Critical
>
> I have been using the codhaus version of the tomcat-maven-plugin and am 
> trying to switch to the latest Apache Tomcat Maven Plugin.
> Deploy works with the codhaus version using 'mvn tomcat:redeploy -Pdev02`.  
> The username/password are normally in my profile settings.  
> Deploy fails with apache version using:  'mvn tomcat6:redeploy -Pdev02'.  
> I've specified a  entry in the settings.xml, and specified the same 
> value in the  section of the the plugin  to avoid 
> "[DEBUG] No server specified for authentication - using defaults" errors.
> Below is my maven profile.  I've tried changing the URL when running the 
> tomcat6:deploy/redeploy targets with and without a trailing '/text'.  I get a 
> 404 with the '/text' and "Cannot invoke Tomcat manager" if I ommit the 
> '/text'.
> Although, without the '/text' in the URL, it appears to upload the war as it 
> shows a progress indicator then fails with the error below:
> 
> 
>   dev02
>   
> false
>   
>   
> 
>   
> org.apache.tomcat.maven
> tomcat6-maven-plugin
> 2.0-beta-1
> 
>   war
>   http://10.12.4.2/manager
>   true
>   UTF-8
>   UTF-8
>   HTTP/1.1
>   true
>   dev02
> 
>   
> 
>   
> 
> //- MAVEN OUTPUT 
> [DEBUG] Configuring mojo 
> org.apache.tomcat.maven:tomcat6-maven-plugin:2.0-beta-1:redeploy from plugin 
> realm 
> ClassRealm[plugin>org.apache.tomcat.maven:tomcat6-maven-plugin:2.0-beta-1, 
> parent: sun.misc.Launcher$AppClassLoader@3326b249]
> [DEBUG] Configuring mojo 
> 'org.apache.tomcat.maven:tomcat6-maven-plugin:2.0-beta-1:redeploy' with basic 
> configurator -->
> [DEBUG]   (f) charset = UTF-8
> [DEBUG]   (f) contextFile = 
> C:\Users\jvincent\Dev\Java\Domain\target\Domain-2012.04.04-SNAPSHOT\META-INF\context.xml
> [DEBUG]   (f) ignorePackaging = false
> [DEBUG]   (f) mode = war
> [DEBUG]   (f) packaging = war
> [DEBUG]   (f) path = /Domain
> [DEBUG]   (f) server = dev02
> [DEBUG]   (f) update = true
> [DEBUG]   (f) url = http://10.12.4.2/manager
> [DEBUG]   (f) version = 2.0-beta-1
> [DEBUG]   (f) warFile = 
> C:\Users\jvincent\Dev\Java\Domain\target\Domain-2012.04.04-SNAPSHOT.war
> [DEBUG] -- end configuration --
> [INFO] Deploying war to http://10.12.4.2/Domain  
> Uploading: http://10.12.4.2/manager/deploy?path=%2FDomain&update=true
> [Progress Indicator..]
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 5.490s
> [INFO] Finished at: Tue Apr 17 17:51:59 MDT 2012
> [INFO] Final Memory: 8M/244M
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.tomcat.maven:tomcat6-maven-plugin:2.0-beta-1:redeploy 
> (default-cli) on project Domain: Cannot invoke Tomcat manager: 
> ClientProtocolException: Cannot retry request with a non-repeatable request 
> entity. -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.tomcat.maven:tomcat6-maven-plugin:2.0-beta-1:redeploy 
> (default-cli) on project Domain: Cannot invoke Tomcat manager
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:217)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183)
>   at 
> org.apache.maven.lifecycle.int

[GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2012-04-18 Thread Bill Barker
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-test has an issue affecting its community integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk-test :  Tomcat 8.x, a web server implementing Java Servlet 
3.1,
...


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on tomcat-trunk-dbcp exists, no need to add for property 
tomcat-dbcp-src.jar.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
commons-daemon.native.src.tgz.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
tomcat-native.tar.gz.
 -DEBUG- Dependency on tomcat-trunk-dbcp exists, no need to add for property 
tomcat-dbcp.home.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/build/logs



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/gump_work/build_tomcat-trunk_tomcat-trunk-test.html
Work Name: build_tomcat-trunk_tomcat-trunk-test (Type: Build)
Work ended in a state of : Failed
Elapsed: 22 mins 10 secs
Command Line: /usr/lib/jvm/java-6-openjdk/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Djunit.jar=/srv/gump/public/workspace/junit/dist/junit-18042012.jar 
-Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-18042012-native-src.tar.gz
 
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-18042012-native-src.tar.gz
 -Dexamples.sources.skip=true 
-Dtomcat-dbcp.home=/srv/gump/public/workspace/tomcat-trunk/tomcat-deps 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/org.eclipse.jdt.core_3.4.2/jdtcore.jar
 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-18042012.jar
 
-Dtomcat-dbcp-src.jar=/srv/gump/public/workspace/tomcat-trunk/tomcat-deps/tomcat-dbcp-src.jar
 -Dtest.accesslog=true 
-Dcommons-pool.home=/srv/gump/public/workspace/commons-pool-1.x 
-Dcommons-dbcp.home=/
 srv/gump/public/workspace/commons-dbcp-1.x 
-Dtomcat-dbcp.jar=/srv/gump/public/workspace/tomcat-trunk/tomcat-deps/tomcat-dbcp-18042012.jar
 test 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-6-openjdk/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.jar:/srv/gump/public/workspace/tomcat-trunk/outp
 
ut/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-jni.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-util.jar:/srv/gump/packages/javamail-1.4/mail.jar:/srv/gump/packages/javamail-1.4/lib/mailapi.jar:/srv/gump/packages/jaf-1.1ea/activation.jar:/srv/gump/packages/eclipse/plugins/org
 
.eclipse.jdt.core_3.4.2/jdtcore.jar:/srv/gump/public/workspace/tomcat-trunk/tomcat-deps/tomcat-dbcp-18042012.jar:/srv/gump/public/workspace/apache-commons/daemon/dist/commons-da

svn commit: r1327617 - /tomcat/trunk/java/org/apache/catalina/ha/session/DeltaSession.java

2012-04-18 Thread kkolinko
Author: kkolinko
Date: Wed Apr 18 18:42:34 2012
New Revision: 1327617

URL: http://svn.apache.org/viewvc?rev=1327617&view=rev
Log:
Reduce indent 8->4. No functional change.
I thought I was looking at an inner class.

Modified:
tomcat/trunk/java/org/apache/catalina/ha/session/DeltaSession.java

Modified: tomcat/trunk/java/org/apache/catalina/ha/session/DeltaSession.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ha/session/DeltaSession.java?rev=1327617&r1=1327616&r2=1327617&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/ha/session/DeltaSession.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/ha/session/DeltaSession.java Wed Apr 
18 18:42:34 2012
@@ -112,139 +112,139 @@ public class DeltaSession extends Standa
 // - ReplicatedMapEntry
 
 /**
- * Has the object changed since last replication
- * and is not in a locked state
- * @return boolean
- */
-@Override
-public boolean isDirty() {
-return getDeltaRequest().getSize()>0;
-}
-
-/**
- * If this returns true, the map will extract the diff using getDiff()
- * Otherwise it will serialize the entire object.
- * @return boolean
- */
-@Override
-public boolean isDiffable() {
-return true;
-}
+ * Has the object changed since last replication
+ * and is not in a locked state
+ * @return boolean
+ */
+@Override
+public boolean isDirty() {
+return getDeltaRequest().getSize()>0;
+}
 
-/**
- * Returns a diff and sets the dirty map to false
- * @return byte[]
- * @throws IOException
- */
-@Override
-public byte[] getDiff() throws IOException {
-try{
-lock();
-return getDeltaRequest().serialize();
-}finally{
-unlock();
-}
+/**
+ * If this returns true, the map will extract the diff using getDiff()
+ * Otherwise it will serialize the entire object.
+ * @return boolean
+ */
+@Override
+public boolean isDiffable() {
+return true;
+}
+
+/**
+ * Returns a diff and sets the dirty map to false
+ * @return byte[]
+ * @throws IOException
+ */
+@Override
+public byte[] getDiff() throws IOException {
+try{
+lock();
+return getDeltaRequest().serialize();
+}finally{
+unlock();
 }
+}
+
+public ClassLoader[] getClassLoaders() {
+if ( manager instanceof BackupManager ) return 
((BackupManager)manager).getClassLoaders();
+else if ( manager instanceof ClusterManagerBase ) return 
((ClusterManagerBase)manager).getClassLoaders();
+else if ( manager instanceof StandardManager ) {
+StandardManager sm = (StandardManager)manager;
+return ClusterManagerBase.getClassLoaders(sm.getContainer());
+} else if ( manager instanceof ManagerBase ) {
+ManagerBase mb = (ManagerBase)manager;
+return ClusterManagerBase.getClassLoaders(mb.getContainer());
+}//end if
+return null;
+}
 
-public ClassLoader[] getClassLoaders() {
-if ( manager instanceof BackupManager ) return 
((BackupManager)manager).getClassLoaders();
-else if ( manager instanceof ClusterManagerBase ) return 
((ClusterManagerBase)manager).getClassLoaders();
-else if ( manager instanceof StandardManager ) {
-StandardManager sm = (StandardManager)manager;
-return ClusterManagerBase.getClassLoaders(sm.getContainer());
-} else if ( manager instanceof ManagerBase ) {
-ManagerBase mb = (ManagerBase)manager;
-return ClusterManagerBase.getClassLoaders(mb.getContainer());
-}//end if
-return null;
-}
-
-/**
- * Applies a diff to an existing object.
- * @param diff byte[]
- * @param offset int
- * @param length int
- * @throws IOException
- */
-@Override
-public void applyDiff(byte[] diff, int offset, int length) throws 
IOException, ClassNotFoundException {
+/**
+ * Applies a diff to an existing object.
+ * @param diff byte[]
+ * @param offset int
+ * @param length int
+ * @throws IOException
+ */
+@Override
+public void applyDiff(byte[] diff, int offset, int length) throws 
IOException, ClassNotFoundException {
+try {
+lock();
+ReplicationStream stream = ( (ClusterManager) 
getManager()).getReplicationStream(diff, offset, length);
+ClassLoader contextLoader = 
Thread.currentThread().getContextClassLoader();
 try {

svn commit: r1327623 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/ha/session/DeltaSession.java

2012-04-18 Thread kkolinko
Author: kkolinko
Date: Wed Apr 18 18:46:41 2012
New Revision: 1327623

URL: http://svn.apache.org/viewvc?rev=1327623&view=rev
Log:
Reduce indent 8->4. No functional change.
Backport of r1327617

Modified:
tomcat/tc7.0.x/trunk/   (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/DeltaSession.java

Propchange: tomcat/tc7.0.x/trunk/
--
  Merged /tomcat/trunk:r1327617

Modified: 
tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/DeltaSession.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/DeltaSession.java?rev=1327623&r1=1327622&r2=1327623&view=diff
==
--- tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/DeltaSession.java 
(original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/DeltaSession.java 
Wed Apr 18 18:46:41 2012
@@ -112,139 +112,139 @@ public class DeltaSession extends Standa
 // - ReplicatedMapEntry
 
 /**
- * Has the object changed since last replication
- * and is not in a locked state
- * @return boolean
- */
-@Override
-public boolean isDirty() {
-return getDeltaRequest().getSize()>0;
-}
-
-/**
- * If this returns true, the map will extract the diff using getDiff()
- * Otherwise it will serialize the entire object.
- * @return boolean
- */
-@Override
-public boolean isDiffable() {
-return true;
-}
+ * Has the object changed since last replication
+ * and is not in a locked state
+ * @return boolean
+ */
+@Override
+public boolean isDirty() {
+return getDeltaRequest().getSize()>0;
+}
 
-/**
- * Returns a diff and sets the dirty map to false
- * @return byte[]
- * @throws IOException
- */
-@Override
-public byte[] getDiff() throws IOException {
-try{
-lock();
-return getDeltaRequest().serialize();
-}finally{
-unlock();
-}
+/**
+ * If this returns true, the map will extract the diff using getDiff()
+ * Otherwise it will serialize the entire object.
+ * @return boolean
+ */
+@Override
+public boolean isDiffable() {
+return true;
+}
+
+/**
+ * Returns a diff and sets the dirty map to false
+ * @return byte[]
+ * @throws IOException
+ */
+@Override
+public byte[] getDiff() throws IOException {
+try{
+lock();
+return getDeltaRequest().serialize();
+}finally{
+unlock();
 }
+}
+
+public ClassLoader[] getClassLoaders() {
+if ( manager instanceof BackupManager ) return 
((BackupManager)manager).getClassLoaders();
+else if ( manager instanceof ClusterManagerBase ) return 
((ClusterManagerBase)manager).getClassLoaders();
+else if ( manager instanceof StandardManager ) {
+StandardManager sm = (StandardManager)manager;
+return ClusterManagerBase.getClassLoaders(sm.getContainer());
+} else if ( manager instanceof ManagerBase ) {
+ManagerBase mb = (ManagerBase)manager;
+return ClusterManagerBase.getClassLoaders(mb.getContainer());
+}//end if
+return null;
+}
 
-public ClassLoader[] getClassLoaders() {
-if ( manager instanceof BackupManager ) return 
((BackupManager)manager).getClassLoaders();
-else if ( manager instanceof ClusterManagerBase ) return 
((ClusterManagerBase)manager).getClassLoaders();
-else if ( manager instanceof StandardManager ) {
-StandardManager sm = (StandardManager)manager;
-return ClusterManagerBase.getClassLoaders(sm.getContainer());
-} else if ( manager instanceof ManagerBase ) {
-ManagerBase mb = (ManagerBase)manager;
-return ClusterManagerBase.getClassLoaders(mb.getContainer());
-}//end if
-return null;
-}
-
-/**
- * Applies a diff to an existing object.
- * @param diff byte[]
- * @param offset int
- * @param length int
- * @throws IOException
- */
-@Override
-public void applyDiff(byte[] diff, int offset, int length) throws 
IOException, ClassNotFoundException {
+/**
+ * Applies a diff to an existing object.
+ * @param diff byte[]
+ * @param offset int
+ * @param length int
+ * @throws IOException
+ */
+@Override
+public void applyDiff(byte[] diff, int offset, int length) throws 
IOException, ClassNotFoundException {
+try {
+lock();
+Repl

Re: svn commit: r1326941 - in /tomcat/tc7.0.x/trunk: java/org/apache/catalina/ha/session/ java/org/apache/catalina/tribes/tipis/ webapps/docs/

2012-04-18 Thread Konstantin Kolinko
2012/4/17  :
> Author: kfujino
> Date: Tue Apr 17 06:23:21 2012
> New Revision: 1326941
>
> URL: http://svn.apache.org/viewvc?rev=1326941&view=rev
> Log:
> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53087.
> In order to avoid that a backup node expire a session, replicate session 
> access time in BackupManager.
>
> Modified:
>    tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/DeltaSession.java
>    
> tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java
>    
> tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/tipis/ReplicatedMapEntry.java
>    tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
>

(...)

> Modified: 
> tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java
> URL: 
> http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java?rev=1326941&r1=1326940&r2=1326941&view=diff
> ==
> --- 
> tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java
>  (original)
> +++ 
> tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java
>  Tue Apr 17 06:23:21 2012
> @@ -402,8 +402,10 @@ public abstract class AbstractReplicated
>         if ( !entry.isSerializable() ) return;
>         if (entry.isPrimary() && entry.getBackupNodes()!= null && 
> entry.getBackupNodes().length > 0) {
>             Object value = entry.getValue();
> -            //check to see if we need to replicate this object 
> isDirty()||complete
> -            boolean repl = complete || ( (value instanceof 
> ReplicatedMapEntry) && ( (ReplicatedMapEntry) value).isDirty());
> +            //check to see if we need to replicate this object 
> isDirty()||complete || isAccessReplicate()
> +            boolean isDirty = ((value instanceof ReplicatedMapEntry) && 
> ((ReplicatedMapEntry) value).isDirty());
> +            boolean isAccess = ((value instanceof ReplicatedMapEntry) && 
> ((ReplicatedMapEntry) value).isAccessReplicate());
> +            boolean repl = complete || isDirty || isAccess;
>
>             if (!repl) {
>                 if ( log.isTraceEnabled() )
> @@ -412,9 +414,9 @@ public abstract class AbstractReplicated
>                 return;
>             }
>             //check to see if the message is diffable
> -            boolean diff = ( (value instanceof ReplicatedMapEntry) && ( 
> (ReplicatedMapEntry) value).isDiffable());
> +            boolean diff = ((value instanceof ReplicatedMapEntry) && 
> ((ReplicatedMapEntry) value).isDiffable());
>             MapMessage msg = null;
> -            if (diff) {
> +            if (diff && isDirty) {


What happens if "repl" variable is true because of "complete" being true?
Shouldn't it be
if (diff && (isDirty || complete))
?

I do not quite understand the code, but it seems that omitting
"complete" here will change its behaviour.

E.g. DeltaSession.isDiffable() always returns true, and thus I think
the old "if(diff)" block was executed regardless of the value of
"complete".


>                 ReplicatedMapEntry rentry = 
> (ReplicatedMapEntry)entry.getValue();

The above local variable could be moved outside this block, to avoid
multiple (instanceof) checks above.

>                 try {
>                     rentry.lock();
> @@ -432,6 +434,12 @@ public abstract class AbstractReplicated
>                 }
>
>             }
> +            if (msg == null && isAccess) {
> +                //construct a access message
> +                msg = new MapMessage(mapContextName, MapMessage.MSG_ACCESS,
> +                        false, (Serializable) entry.getKey(), null, null, 
> entry.getPrimary(),
> +                        entry.getBackupNodes());
> +            }
>             if (msg == null) {
>                 //construct a complete
>                 msg = new MapMessage(mapContextName, MapMessage.MSG_BACKUP,
> @@ -442,6 +450,9 @@ public abstract class AbstractReplicated
>             }
>             try {
>                 if ( channel!=null && entry.getBackupNodes()!= null && 
> entry.getBackupNodes().length > 0 ) {
> +                    if ((entry.getValue() instanceof ReplicatedMapEntry)) {
> +                        
> ((ReplicatedMapEntry)entry.getValue()).setLastTimeReplicated(System.currentTimeMillis());
> +                    }
>                     channel.send(entry.getBackupNodes(), msg, 
> channelSendOptions);
>                 }
>             } catch (ChannelException x) {
> @@ -670,6 +681,17 @@ public abstract class AbstractReplicated
>             } //end if
>             super.put(entry.getKey(), entry);
>         } //end if
> +
> +        if (mapmsg.getMsgType() == MapMessage.MSG_ACCESS) {
> +            MapEntry entry = (MapEntry)super.get(mapmsg.getKey());
> +            if (entry != null) {
> +                entry.setBackupNodes(mapmsg.getBackupNodes());
> +                entry.setPrim

svn commit: r1327670 - /tomcat/trunk/java/org/apache/catalina/core/DefaultInstanceManager.java

2012-04-18 Thread kkolinko
Author: kkolinko
Date: Wed Apr 18 20:34:02 2012
New Revision: 1327670

URL: http://svn.apache.org/viewvc?rev=1327670&view=rev
Log:
Save a bit of memory in annotations cache in DefaultInstanceManager
occupied by unused entries in annotation lists.

I could do the same by calling ArrayList.trimToSize(), preserving the Lists 
abstraction, but
1). That involves the same array copying operation as toArray() call that I am 
using,
2). I do not see any benefits from using List here, as the only operation with 
annotations
list after it has been created is iterating over it.

Thus I preferred to replace lists with explicit arrays.

Modified:
tomcat/trunk/java/org/apache/catalina/core/DefaultInstanceManager.java

Modified: tomcat/trunk/java/org/apache/catalina/core/DefaultInstanceManager.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/DefaultInstanceManager.java?rev=1327670&r1=1327669&r2=1327670&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/DefaultInstanceManager.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/core/DefaultInstanceManager.java Wed 
Apr 18 20:34:02 2012
@@ -30,7 +30,6 @@ import java.security.PrivilegedAction;
 import java.security.PrivilegedActionException;
 import java.security.PrivilegedExceptionAction;
 import java.util.ArrayList;
-import java.util.Collections;
 import java.util.List;
 import java.util.Map;
 import java.util.Properties;
@@ -69,8 +68,12 @@ public class DefaultInstanceManager impl
 private final Properties restrictedFilters = new Properties();
 private final Properties restrictedListeners = new Properties();
 private final Properties restrictedServlets = new Properties();
-private final Map,List> annotationCache =
-new WeakHashMap, List>();
+private final Map, AnnotationCacheEntry[]> annotationCache =
+new WeakHashMap, AnnotationCacheEntry[]>();
+
+// Used when there are no annotations in a class
+private static final AnnotationCacheEntry[] ANNOTATIONS_EMPTY
+= new AnnotationCacheEntry[0];
 
 public DefaultInstanceManager(Context context, Map> injectionMap, org.apache.catalina.Context catalinaContext, ClassLoader 
containerClassLoader) {
 classLoader = catalinaContext.getLoader().getClassLoader();
@@ -177,7 +180,7 @@ public class DefaultInstanceManager impl
 
 // At the end the postconstruct annotated
 // method is invoked
-List annotations;
+AnnotationCacheEntry[] annotations;
 synchronized (annotationCache) {
 annotations = annotationCache.get(clazz);
 }
@@ -213,7 +216,7 @@ public class DefaultInstanceManager impl
 
 // At the end the postconstruct annotated
 // method is invoked
-List annotations = null;
+AnnotationCacheEntry[] annotations = null;
 synchronized (annotationCache) {
 annotations = annotationCache.get(clazz);
 }
@@ -251,13 +254,19 @@ public class DefaultInstanceManager impl
 Map injections) throws IllegalAccessException,
 InvocationTargetException, NamingException {
 
+List annotations = null;
+
 while (clazz != null) {
-List annotations = null;
+AnnotationCacheEntry[] annotationsArray = null;
 synchronized (annotationCache) {
-annotations = annotationCache.get(clazz);
+annotationsArray = annotationCache.get(clazz);
 }
-if (annotations == null) {
-annotations = new ArrayList();
+if (annotationsArray == null) {
+if (annotations == null) {
+annotations = new ArrayList();
+} else {
+annotations.clear();
+}
 
 if (context != null) {
 // Initialize fields annotations for resource injection if
@@ -421,12 +430,15 @@ public class DefaultInstanceManager impl
 preDestroy.getParameterTypes(), null,
 AnnotationCacheEntryType.PRE_DESTROY));
 }
-if (annotations.size() == 0) {
-// Use common empty list to save memory
-annotations = Collections.emptyList();
+if (annotations.isEmpty()) {
+// Use common object to save memory
+annotationsArray = ANNOTATIONS_EMPTY;
+} else {
+annotationsArray = annotations.toArray(
+new AnnotationCacheEntry[annotations.size()]);
 }
 synchronized (annotationCache) {
-annotationCache.put(clazz, annotations);
+annotationCache.put(clazz, annotationsArray);
 }
 }
 clazz = clazz.getSuperclass();
@@ -455,7 +46

DO NOT REPLY [Bug 53085] [perf] [concurrency] DefaultInstanceManager.annotationCache is not optimal for more threads

2012-04-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53085

--- Comment #2 from Konstantin Kolinko  2012-04-18 
20:37:31 UTC ---
(In reply to comment #0)
> 2) the 'weakness' can achieved with String (classname) if it is acceptable to
> maintain annotations for class that can be already unloaded or with
> WeakReference

It cannot be String alone. You need {ClassLoader + String} to identify a class.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1327679 - /tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/

2012-04-18 Thread kkolinko
Author: kkolinko
Date: Wed Apr 18 20:59:35 2012
New Revision: 1327679

URL: http://svn.apache.org/viewvc?rev=1327679&view=rev
Log:
Delete explicit svn:mergeinfo property on org/apache/catalina/core
It was updated on each merge involving that subtree. I see no reason for it to 
be there - all mergeinfo is already in the root of the project.

Modified:
tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/   (props changed)

Propchange: tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/
('svn:mergeinfo' removed)



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1327680 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/DefaultInstanceManager.java webapps/docs/changelog.xml

2012-04-18 Thread kkolinko
Author: kkolinko
Date: Wed Apr 18 21:01:30 2012
New Revision: 1327680

URL: http://svn.apache.org/viewvc?rev=1327680&view=rev
Log:
Merged revision 1327670 from tomcat/trunk:
Save a bit of memory in annotations cache in DefaultInstanceManager
occupied by unused entries in annotation lists.

I could do the same by calling ArrayList.trimToSize(), preserving the Lists 
abstraction, but
1). That involves the same array copying operation as toArray() call that I am 
using,
2). I do not see any benefits from using List here, as the only operation with 
annotations
list after it has been created is iterating over it.

Thus I preferred to replace lists with explicit arrays.

Modified:
tomcat/tc7.0.x/trunk/   (props changed)

tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/DefaultInstanceManager.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc7.0.x/trunk/
--
  Merged /tomcat/trunk:r1327670

Modified: 
tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/DefaultInstanceManager.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/DefaultInstanceManager.java?rev=1327680&r1=1327679&r2=1327680&view=diff
==
--- 
tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/DefaultInstanceManager.java 
(original)
+++ 
tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/DefaultInstanceManager.java 
Wed Apr 18 21:01:30 2012
@@ -30,7 +30,6 @@ import java.security.PrivilegedAction;
 import java.security.PrivilegedActionException;
 import java.security.PrivilegedExceptionAction;
 import java.util.ArrayList;
-import java.util.Collections;
 import java.util.List;
 import java.util.Map;
 import java.util.Properties;
@@ -69,8 +68,12 @@ public class DefaultInstanceManager impl
 private final Properties restrictedFilters = new Properties();
 private final Properties restrictedListeners = new Properties();
 private final Properties restrictedServlets = new Properties();
-private final Map,List> annotationCache =
-new WeakHashMap, List>();
+private final Map, AnnotationCacheEntry[]> annotationCache =
+new WeakHashMap, AnnotationCacheEntry[]>();
+
+// Used when there are no annotations in a class
+private static final AnnotationCacheEntry[] ANNOTATIONS_EMPTY
+= new AnnotationCacheEntry[0];
 
 public DefaultInstanceManager(Context context, Map> injectionMap, org.apache.catalina.Context catalinaContext, ClassLoader 
containerClassLoader) {
 classLoader = catalinaContext.getLoader().getClassLoader();
@@ -177,7 +180,7 @@ public class DefaultInstanceManager impl
 
 // At the end the postconstruct annotated
 // method is invoked
-List annotations;
+AnnotationCacheEntry[] annotations;
 synchronized (annotationCache) {
 annotations = annotationCache.get(clazz);
 }
@@ -213,7 +216,7 @@ public class DefaultInstanceManager impl
 
 // At the end the postconstruct annotated
 // method is invoked
-List annotations = null;
+AnnotationCacheEntry[] annotations = null;
 synchronized (annotationCache) {
 annotations = annotationCache.get(clazz);
 }
@@ -251,13 +254,19 @@ public class DefaultInstanceManager impl
 Map injections) throws IllegalAccessException,
 InvocationTargetException, NamingException {
 
+List annotations = null;
+
 while (clazz != null) {
-List annotations = null;
+AnnotationCacheEntry[] annotationsArray = null;
 synchronized (annotationCache) {
-annotations = annotationCache.get(clazz);
+annotationsArray = annotationCache.get(clazz);
 }
-if (annotations == null) {
-annotations = new ArrayList();
+if (annotationsArray == null) {
+if (annotations == null) {
+annotations = new ArrayList();
+} else {
+annotations.clear();
+}
 
 if (context != null) {
 // Initialize fields annotations for resource injection if
@@ -421,12 +430,15 @@ public class DefaultInstanceManager impl
 preDestroy.getParameterTypes(), null,
 AnnotationCacheEntryType.PRE_DESTROY));
 }
-if (annotations.size() == 0) {
-// Use common empty list to save memory
-annotations = Collections.emptyList();
+if (annotations.isEmpty()) {
+// Use common object to save memory
+annotationsArray = ANNOTATIONS_EMPTY;
+} else {
+annotationsArray = annotations.toArray(
+new Ann

DO NOT REPLY [Bug 52853] @HandlesTypes not resolving classes when added as repository directory

2012-04-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52853

--- Comment #10 from Konstantin Kolinko  2012-04-18 
21:53:37 UTC ---
(In reply to comment #9)
> When asking the
> question on the mailing list I didn't get a response:
> http://tomcat.10.n6.nabble.com/Build-Tomcat-from-sources-on-GitHub-repo-td4884681.html.

There is no such question in the mailing list archives. You were fooled by
Nabble  - it did not sent the e-mail on your behalf, or it sent it so that it
was rejected. You may notice that that page has a yellow warning line.

I'd say that you have to subscribe to the mailing list properly.
http://tomcat.apache.org/lists.html

Anyway, you had to search the archives, as you are not the first one asking
this question:
http://markmail.org/message/ioay3hmulyp7o74w

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[jira] [Resolved] (MTOMCAT-145) [2.0-beta-1] Unable to deploy

2012-04-18 Thread Jeff Vincent (Resolved) (JIRA)

 [ 
https://issues.apache.org/jira/browse/MTOMCAT-145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Vincent resolved MTOMCAT-145.
--

   Resolution: Fixed
Fix Version/s: 2.0

Works with 2.0-SNAPSHOT

> [2.0-beta-1] Unable to deploy 
> --
>
> Key: MTOMCAT-145
> URL: https://issues.apache.org/jira/browse/MTOMCAT-145
> Project: Apache Tomcat Maven Plugin
>  Issue Type: Bug
>  Components: tomcat6
>Affects Versions: 2.0-beta-1
> Environment: Maven 3.0.4 command-line on Windows 7 x64
> Tomcat 6.0.13 
> CentOs 4.9
>Reporter: Jeff Vincent
>Assignee: Olivier Lamy (*$^¨%`£)
>Priority: Critical
> Fix For: 2.0
>
>
> I have been using the codhaus version of the tomcat-maven-plugin and am 
> trying to switch to the latest Apache Tomcat Maven Plugin.
> Deploy works with the codhaus version using 'mvn tomcat:redeploy -Pdev02`.  
> The username/password are normally in my profile settings.  
> Deploy fails with apache version using:  'mvn tomcat6:redeploy -Pdev02'.  
> I've specified a  entry in the settings.xml, and specified the same 
> value in the  section of the the plugin  to avoid 
> "[DEBUG] No server specified for authentication - using defaults" errors.
> Below is my maven profile.  I've tried changing the URL when running the 
> tomcat6:deploy/redeploy targets with and without a trailing '/text'.  I get a 
> 404 with the '/text' and "Cannot invoke Tomcat manager" if I ommit the 
> '/text'.
> Although, without the '/text' in the URL, it appears to upload the war as it 
> shows a progress indicator then fails with the error below:
> 
> 
>   dev02
>   
> false
>   
>   
> 
>   
> org.apache.tomcat.maven
> tomcat6-maven-plugin
> 2.0-beta-1
> 
>   war
>   http://10.12.4.2/manager
>   true
>   UTF-8
>   UTF-8
>   HTTP/1.1
>   true
>   dev02
> 
>   
> 
>   
> 
> //- MAVEN OUTPUT 
> [DEBUG] Configuring mojo 
> org.apache.tomcat.maven:tomcat6-maven-plugin:2.0-beta-1:redeploy from plugin 
> realm 
> ClassRealm[plugin>org.apache.tomcat.maven:tomcat6-maven-plugin:2.0-beta-1, 
> parent: sun.misc.Launcher$AppClassLoader@3326b249]
> [DEBUG] Configuring mojo 
> 'org.apache.tomcat.maven:tomcat6-maven-plugin:2.0-beta-1:redeploy' with basic 
> configurator -->
> [DEBUG]   (f) charset = UTF-8
> [DEBUG]   (f) contextFile = 
> C:\Users\jvincent\Dev\Java\Domain\target\Domain-2012.04.04-SNAPSHOT\META-INF\context.xml
> [DEBUG]   (f) ignorePackaging = false
> [DEBUG]   (f) mode = war
> [DEBUG]   (f) packaging = war
> [DEBUG]   (f) path = /Domain
> [DEBUG]   (f) server = dev02
> [DEBUG]   (f) update = true
> [DEBUG]   (f) url = http://10.12.4.2/manager
> [DEBUG]   (f) version = 2.0-beta-1
> [DEBUG]   (f) warFile = 
> C:\Users\jvincent\Dev\Java\Domain\target\Domain-2012.04.04-SNAPSHOT.war
> [DEBUG] -- end configuration --
> [INFO] Deploying war to http://10.12.4.2/Domain  
> Uploading: http://10.12.4.2/manager/deploy?path=%2FDomain&update=true
> [Progress Indicator..]
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 5.490s
> [INFO] Finished at: Tue Apr 17 17:51:59 MDT 2012
> [INFO] Final Memory: 8M/244M
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.tomcat.maven:tomcat6-maven-plugin:2.0-beta-1:redeploy 
> (default-cli) on project Domain: Cannot invoke Tomcat manager: 
> ClientProtocolException: Cannot retry request with a non-repeatable request 
> entity. -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.tomcat.maven:tomcat6-maven-plugin:2.0-beta-1:redeploy 
> (default-cli) on project Domain: Cannot invoke Tomcat manager
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:217)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:319)
>  

svn commit: r1327781 - /tomcat/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java

2012-04-18 Thread kfujino
Author: kfujino
Date: Thu Apr 19 02:17:01 2012
New Revision: 1327781

URL: http://svn.apache.org/viewvc?rev=1327781&view=rev
Log:
Apply Konstantin's suggestion.
"if (diff && (isDirty || complete))" block was executed regardless of the value 
of "complete".

Modified:

tomcat/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java

Modified: 
tomcat/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java?rev=1327781&r1=1327780&r2=1327781&view=diff
==
--- 
tomcat/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java 
(original)
+++ 
tomcat/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java 
Thu Apr 19 02:17:01 2012
@@ -406,10 +406,11 @@ public abstract class AbstractReplicated
 if ( entry == null ) return;
 if ( !entry.isSerializable() ) return;
 if (entry.isPrimary() && entry.getBackupNodes()!= null && 
entry.getBackupNodes().length > 0) {
-Object value = entry.getValue();
 //check to see if we need to replicate this object 
isDirty()||complete || isAccessReplicate()
-boolean isDirty = ((value instanceof ReplicatedMapEntry) && 
((ReplicatedMapEntry) value).isDirty());
-boolean isAccess = ((value instanceof ReplicatedMapEntry) && 
((ReplicatedMapEntry) value).isAccessReplicate());
+ReplicatedMapEntry rentry = null;
+if (entry.getValue() instanceof ReplicatedMapEntry) rentry = 
(ReplicatedMapEntry)entry.getValue();
+boolean isDirty = rentry != null && rentry.isDirty();
+boolean isAccess = rentry != null && rentry.isAccessReplicate();
 boolean repl = complete || isDirty || isAccess;
 
 if (!repl) {
@@ -419,10 +420,9 @@ public abstract class AbstractReplicated
 return;
 }
 //check to see if the message is diffable
-boolean diff = ((value instanceof ReplicatedMapEntry) && 
((ReplicatedMapEntry) value).isDiffable());
+boolean diff = rentry != null && rentry.isDiffable();
 MapMessage msg = null;
-if (diff && isDirty) {
-ReplicatedMapEntry rentry = 
(ReplicatedMapEntry)entry.getValue();
+if (diff && (isDirty || complete)) {
 try {
 rentry.lock();
 //construct a diff message
@@ -455,9 +455,7 @@ public abstract class AbstractReplicated
 }
 try {
 if ( channel!=null && entry.getBackupNodes()!= null && 
entry.getBackupNodes().length > 0 ) {
-if ((entry.getValue() instanceof ReplicatedMapEntry)) {
-
((ReplicatedMapEntry)entry.getValue()).setLastTimeReplicated(System.currentTimeMillis());
-}
+if (rentry != null) 
rentry.setLastTimeReplicated(System.currentTimeMillis());
 channel.send(entry.getBackupNodes(), msg, 
channelSendOptions);
 }
 } catch (ChannelException x) {



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1327784 - /tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java

2012-04-18 Thread kfujino
Author: kfujino
Date: Thu Apr 19 02:27:35 2012
New Revision: 1327784

URL: http://svn.apache.org/viewvc?rev=1327784&view=rev
Log:
Apply Konstantin's suggestion.
"if (diff && (isDirty || complete))" block was executed regardless of the value 
of "complete".

Modified:

tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java

Modified: 
tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java?rev=1327784&r1=1327783&r2=1327784&view=diff
==
--- 
tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java
 (original)
+++ 
tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java
 Thu Apr 19 02:27:35 2012
@@ -401,10 +401,11 @@ public abstract class AbstractReplicated
 if ( entry == null ) return;
 if ( !entry.isSerializable() ) return;
 if (entry.isPrimary() && entry.getBackupNodes()!= null && 
entry.getBackupNodes().length > 0) {
-Object value = entry.getValue();
 //check to see if we need to replicate this object 
isDirty()||complete || isAccessReplicate()
-boolean isDirty = ((value instanceof ReplicatedMapEntry) && 
((ReplicatedMapEntry) value).isDirty());
-boolean isAccess = ((value instanceof ReplicatedMapEntry) && 
((ReplicatedMapEntry) value).isAccessReplicate());
+ReplicatedMapEntry rentry = null;
+if (entry.getValue() instanceof ReplicatedMapEntry) rentry = 
(ReplicatedMapEntry)entry.getValue();
+boolean isDirty = rentry != null && rentry.isDirty();
+boolean isAccess = rentry != null && rentry.isAccessReplicate();
 boolean repl = complete || isDirty || isAccess;
 
 if (!repl) {
@@ -414,10 +415,9 @@ public abstract class AbstractReplicated
 return;
 }
 //check to see if the message is diffable
-boolean diff = ((value instanceof ReplicatedMapEntry) && 
((ReplicatedMapEntry) value).isDiffable());
+boolean diff = rentry != null && rentry.isDiffable();
 MapMessage msg = null;
-if (diff && isDirty) {
-ReplicatedMapEntry rentry = 
(ReplicatedMapEntry)entry.getValue();
+if (diff && (isDirty || complete)) {
 try {
 rentry.lock();
 //construct a diff message
@@ -450,9 +450,7 @@ public abstract class AbstractReplicated
 }
 try {
 if ( channel!=null && entry.getBackupNodes()!= null && 
entry.getBackupNodes().length > 0 ) {
-if ((entry.getValue() instanceof ReplicatedMapEntry)) {
-
((ReplicatedMapEntry)entry.getValue()).setLastTimeReplicated(System.currentTimeMillis());
-}
+if (rentry != null) 
rentry.setLastTimeReplicated(System.currentTimeMillis());
 channel.send(entry.getBackupNodes(), msg, 
channelSendOptions);
 }
 } catch (ChannelException x) {



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: svn commit: r1326941 - in /tomcat/tc7.0.x/trunk: java/org/apache/catalina/ha/session/ java/org/apache/catalina/tribes/tipis/ webapps/docs/

2012-04-18 Thread Keiichi Fujino
2012/4/19 Konstantin Kolinko :
>
> What happens if "repl" variable is true because of "complete" being true?
> Shouldn't it be
>    if (diff && (isDirty || complete))
> ?
>
> I do not quite understand the code, but it seems that omitting
> "complete" here will change its behaviour.
>
> E.g. DeltaSession.isDiffable() always returns true, and thus I think
> the old "if(diff)" block was executed regardless of the value of
> "complete".
>
>
>>                 ReplicatedMapEntry rentry = 
>> (ReplicatedMapEntry)entry.getValue();
>
> The above local variable could be moved outside this block, to avoid
> multiple (instanceof) checks above.
>

Thanks for the review.
You are right. My fix had changed former behavior.
I applied your suggestion.
"if (diff && (isDirty || complete))" block was executed regardless of
the value of "complete".


-- 
Keiichi.Fujino

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



buildbot success in ASF Buildbot on tomcat-trunk

2012-04-18 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while 
building ASF Buildbot.
Full details are available at:
 http://ci.apache.org/builders/tomcat-trunk/builds/2941

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: bb-vm_ubuntu

Build Reason: scheduler
Build Source Stamp: [branch tomcat/trunk] 1327781
Blamelist: kfujino

Build succeeded!

sincerely,
 -The Buildbot





[GUMP@vmgump]: Project jakarta-tomcat-catalina (in module jakarta-tomcat-catalina) failed

2012-04-18 Thread bobh
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project jakarta-tomcat-catalina has an issue affecting its community 
integration.
This issue affects 2 projects,
 and has been outstanding for 15 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- jakarta-tomcat-catalina :  Servlet 2.4 Reference Implementation
- jakarta-tomcat-jk :  Connectors to various web servers


Full details are available at:

http://vmgump.apache.org/gump/public/jakarta-tomcat-catalina/jakarta-tomcat-catalina/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on ant exists, no need to add for property ant.home.
 -DEBUG- Dependency on jmx exists, no need to add for property jmx.home.
 -DEBUG- Dependency on jaf exists, no need to add for property activation.home.
 -DEBUG- Dependency on jakarta-tomcat-coyote exists, no need to add for 
property tomcat-coyote.home.
 -INFO- Failed with reason build failed
 -INFO- Failed to extract fallback artifacts from Gump Repository



The following work was performed:
http://vmgump.apache.org/gump/public/jakarta-tomcat-catalina/jakarta-tomcat-catalina/gump_work/build_jakarta-tomcat-catalina_jakarta-tomcat-catalina.html
Work Name: build_jakarta-tomcat-catalina_jakarta-tomcat-catalina (Type: Build)
Work ended in a state of : Failed
Elapsed: 22 secs
Command Line: /usr/lib/jvm/java-6-openjdk/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only 
-Xbootclasspath/p:/srv/gump/public/workspace/xml-xerces2/build/xercesImpl.jar:/srv/gump/public/workspace/xml-commons/java/external/build/xml-apis.jar:/srv/gump/public/workspace/xml-xalan/build/xalan-unbundled.jar:/srv/gump/public/workspace/xml-xalan/build/serializer.jar
 org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Dtomcat33.home=--UnSet-- 
-Dcatalina.build=/srv/gump/public/workspace/jakarta-tomcat-catalina/build 
-Djmx.home=/srv/gump/packages/jmx-1_2_1-bin 
-Djdbc20ext.jar=/srv/gump/packages/jdbc2_0/jdbc2_0-stdext.jar 
-Djtc.home=/srv/gump/public/workspace/jakarta-tomcat-connectors 
-Djasper.home=/srv/gump/public/workspace/jakarta-tomcat-jasper_tc5 
-Dant.home=/srv/gump/public/workspace/ant/dist 
-Dcommons-io.jar=/srv/gump/public/workspace/apache-commons/io/target/commons-io-*[0-9T].jar
 -Dcompile.source=1.4 -Dcommons-collections.jar=/srv/gump/public/w
 orkspace/commons-collections-3.x/target/commons-collections-3.3-SNAPSHOT.jar 
-Dcatalina.deploy=/srv/gump/public/workspace/jakarta-tomcat-catalina/build 
-Djaas.jar=/srv/gump/packages/jaas1_0/lib/jaas.jar 
-Dcommons-fileupload.jar=/srv/gump/public/workspace/apache-commons/fileupload/target/commons-fileupload-19042012.jar
 
-Dcommons-digester.jar=/srv/gump/public/workspace/commons-digester-2.x/target/commons-digester-2.2-SNAPSHOT.jar
 
-Dtomcat-http11.jar=/srv/gump/public/workspace/jakarta-tomcat-connectors/http11/build/lib/tomcat-http11.jar
 -Dactivation.home=/srv/gump/packages/jaf-1.1ea 
-Dcatalina.home=/srv/gump/public/workspace/jakarta-tomcat-catalina/build 
-Dcommons-launcher.jar=/srv/gump/public/workspace/apache-commons/launcher/dist/bin/commons-launcher-19042012.jar
 -Dtomcat.build=/srv/gump/public/workspace/jakarta-tomcat-catalina/build 
-Dcommons-beanutils.jar=/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-19042012.jar
 -Dcommons-modeler.jar=/srv/gump/
 public/workspace/apache-commons/modeler/dist/commons-modeler-19042012.jar 
-Dtomcat-coyote.home=/srv/gump/public/workspace/jakarta-tomcat-connectors/coyote
 -Djmx-remote.jar=/srv/gump/packages/jmxremote-1_0_1-bin/lib/jmxremote.jar 
-Dcommons-logging-api.jar=/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-19042012.jar
 
-Dtomcat-dbcp.jar=/srv/gump/public/workspace/jakarta-tomcat-5/tomcat-deps/naming-factory-dbcp.jar
 -Djta.jar=/srv/gump/packages/jta-spec1_0_1/jta-spec1_0_1.jar deploy-catalina 
[Working Directory: /srv/gump/public/workspace/jakarta-tomcat-catalina]
CLASSPATH: 
/usr/lib/jvm/java-6-openjdk/lib/tools.jar:/srv/gump/public/workspace/jakarta-tomcat-catalina/build/server/classes:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/external/build/xml-apis-ext.jar:/srv/gump/packages/jaf-1.1ea/activation.jar:/srv/gump/packages/javamail-1.4/mail.jar:/srv/gump/packages/javamail-1.4/lib/mai

[GUMP@vmgump]: Project tomcat-tc7.0.x-test (in module tomcat-7.0.x) failed

2012-04-18 Thread Bill Barker
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-tc7.0.x-test has an issue affecting its community integration.
This issue affects 1 projects,
 and has been outstanding for 4 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-tc7.0.x-test :  Tomcat 7.x, a web server implementing Java Servlet 
3.0,
...


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-test/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on tomcat-tc7.0.x-dbcp exists, no need to add for property 
tomcat-dbcp-src.jar.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
commons-daemon.native.src.tgz.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
tomcat-native.tar.gz.
 -DEBUG- Dependency on tomcat-tc7.0.x-dbcp exists, no need to add for property 
tomcat-dbcp.home.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-7.0.x/output/build/logs



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-test/gump_work/build_tomcat-7.0.x_tomcat-tc7.0.x-test.html
Work Name: build_tomcat-7.0.x_tomcat-tc7.0.x-test (Type: Build)
Work ended in a state of : Failed
Elapsed: 22 mins 26 secs
Command Line: /usr/lib/jvm/java-6-openjdk/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Djunit.jar=/srv/gump/public/workspace/junit/dist/junit-19042012.jar 
-Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-19042012-native-src.tar.gz
 
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-19042012-native-src.tar.gz
 -Dexamples.sources.skip=true 
-Dtomcat-dbcp.home=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/org.eclipse.jdt.core_3.4.2/jdtcore.jar
 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-19042012.jar
 
-Dtomcat-dbcp-src.jar=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps/tomcat-dbcp-src.jar
 -Dtest.accesslog=true 
-Dcommons-pool.home=/srv/gump/public/workspace/commons-pool-1.x 
-Dcommons-dbcp.home=/
 srv/gump/public/workspace/commons-dbcp-1.x 
-Dtomcat-dbcp.jar=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps/tomcat-dbcp-19042012.jar
 test 
[Working Directory: /srv/gump/public/workspace/tomcat-7.0.x]
CLASSPATH: 
/usr/lib/jvm/java-6-openjdk/lib/tools.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-7.0.x/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/servlet-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/outp
 
ut/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/tomcat-util.jar:/srv/gump/packages/javamail-1.4/mail.jar:/srv/gump/packages/javamail-1.4/lib/mailapi.jar:/srv/gump/packages/jaf-1.1ea/activation.jar:/srv/gump/packages/eclipse/plugins/org.eclipse.jdt.core_3.4.2/jdtcore.jar:/srv/gump/public/workspace/tomcat-7.
 
0.x/tomcat-deps/tomcat-dbcp-19042012.jar:/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-19042012.jar:

[GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2012-04-18 Thread Bill Barker
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-test has an issue affecting its community integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk-test :  Tomcat 8.x, a web server implementing Java Servlet 
3.1,
...


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on tomcat-trunk-dbcp exists, no need to add for property 
tomcat-dbcp-src.jar.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
commons-daemon.native.src.tgz.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
tomcat-native.tar.gz.
 -DEBUG- Dependency on tomcat-trunk-dbcp exists, no need to add for property 
tomcat-dbcp.home.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/build/logs



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/gump_work/build_tomcat-trunk_tomcat-trunk-test.html
Work Name: build_tomcat-trunk_tomcat-trunk-test (Type: Build)
Work ended in a state of : Failed
Elapsed: 22 mins 49 secs
Command Line: /usr/lib/jvm/java-6-openjdk/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Djunit.jar=/srv/gump/public/workspace/junit/dist/junit-19042012.jar 
-Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-19042012-native-src.tar.gz
 
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-19042012-native-src.tar.gz
 -Dexamples.sources.skip=true 
-Dtomcat-dbcp.home=/srv/gump/public/workspace/tomcat-trunk/tomcat-deps 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/org.eclipse.jdt.core_3.4.2/jdtcore.jar
 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-19042012.jar
 
-Dtomcat-dbcp-src.jar=/srv/gump/public/workspace/tomcat-trunk/tomcat-deps/tomcat-dbcp-src.jar
 -Dtest.accesslog=true 
-Dcommons-pool.home=/srv/gump/public/workspace/commons-pool-1.x 
-Dcommons-dbcp.home=/
 srv/gump/public/workspace/commons-dbcp-1.x 
-Dtomcat-dbcp.jar=/srv/gump/public/workspace/tomcat-trunk/tomcat-deps/tomcat-dbcp-19042012.jar
 test 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-6-openjdk/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.jar:/srv/gump/public/workspace/tomcat-trunk/outp
 
ut/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-jni.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-util.jar:/srv/gump/packages/javamail-1.4/mail.jar:/srv/gump/packages/javamail-1.4/lib/mailapi.jar:/srv/gump/packages/jaf-1.1ea/activation.jar:/srv/gump/packages/eclipse/plugins/org
 
.eclipse.jdt.core_3.4.2/jdtcore.jar:/srv/gump/public/workspace/tomcat-trunk/tomcat-deps/tomcat-dbcp-19042012.jar:/srv/gump/public/workspace/apache-commons/daemon/dist/commons-da