RE: have Re: MaxQueueSize for Executor and Tomcat 6
Ping? > -Original Message- > From: Plüm, Rüdiger, Vodafone Group > [mailto:ruediger.pl...@vodafone.com] > Sent: Mittwoch, 11. April 2012 17:43 > To: Tomcat Developers List > Subject: RE: have Re: MaxQueueSize for Executor and Tomcat 6 > > > > > -Original Message- > > From: jean-frederic clere > Sent: Mittwoch, 11. April 2012 17:33 > > To: Tomcat Developers List > > Subject: Re: have Re: MaxQueueSize for Executor and Tomcat 6 > > > > On 04/11/2012 01:34 PM, Plüm, Rüdiger, Vodafone Group wrote: > > > > > > > > >> -Original Message- > > >> From: jean-frederic clere [mailto:jfcl...@gmail.com] > > >> Sent: Mittwoch, 11. April 2012 12:56 > > >> To: dev@tomcat.apache.org > > >> Subject: Re: have Re: MaxQueueSize for Executor and Tomcat 6 > > >> > > >> On 04/11/2012 09:36 AM, Plüm, Rüdiger, Vodafone Group wrote: > > >>> Ping? Some sponsor for the tc6.0 status file for the below? > > >> > > >> Won't break an application using their own executor that > implements > > the > > >> StandardExecutor? > > > > > > You mean because of the changed Executor interface? > > > > Yep. > > Ok. As far as I can see the new method > > execute(Runnable command, long timeout, TimeUnit unit); > > of the Executor interface is implemented but not used. > Would it still be an acceptable backport if > > 1. The changes to the Executor interface are removed from the patch > 2. The implementation of execute(Runnable command, long timeout, > TimeUnit unit); is removed from the patch. > > If yes I can update the patch. > > Regards > > Rüdiger > > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [jira] [Commented] (MTOMCAT-142) contextFile path="..." ignored when using tomcat7:run
That's a new one.
p
On 16 Apr 2012, at 02:07, PC Treasures Support wrote:
> Good Evening,
>
> I do apologize for the difficulty you are experiencing, I am going to
> forward this issue on to my Technician in the morning. Please send me
> your contact info so that I can get back with you on a resolution.
>
> On Sun, Apr 15, 2012 at 7:21 PM, Olivier Lamy (*$^¨%`£) (Commented) (JIRA) <
> j...@apache.org> wrote:
>
>>
>> [
>> https://issues.apache.org/jira/browse/MTOMCAT-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254460#comment-13254460]
>>
>> Olivier Lamy (*$^¨%`£) commented on MTOMCAT-142:
>>
>>
>> If I use the webapp is available on /foo
>>
>>> contextFile path="..." ignored when using tomcat7:run
>>> -
>>>
>>>Key: MTOMCAT-142
>>>URL: https://issues.apache.org/jira/browse/MTOMCAT-142
>>>Project: Apache Tomcat Maven Plugin
>>> Issue Type: Bug
>>> Components: tomcat7
>>> Affects Versions: 2.0-beta-1
>>> Reporter: Dave Syer
>>> Assignee: Olivier Lamy (*$^¨%`£)
>>>Fix For: 2.0
>>>
>>>
>>> contextFile path="..." ignored when using tomcat7:run. I have been
>> trying to use a custom context file (with contextFile config param). I can
>> see the context being logged in the console, but the path attribute is
>> ignored, and for all I know so are other settings (the app is always
>> deployed with path=${project.artifactId}).
>>
>> --
>> This message is automatically generated by JIRA.
>> If you think it was sent incorrectly, please contact your JIRA
>> administrators:
>> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
>> For more information on JIRA, see: http://www.atlassian.com/software/jira
>>
>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>
>>
>
>
> --
> Technical Support Center
>
> PC Treasures, Inc.
> 3720 S. Lapeer Rd.
> Auburn Hills, MI 48326
> 248.236.0061
> www.pctreasures.com
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Commented] (MTOMCAT-142) contextFile path="..." ignored when using tomcat7:run
[
https://issues.apache.org/jira/browse/MTOMCAT-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254593#comment-13254593
]
Dave Syer commented on MTOMCAT-142:
---
OK, yes that works. But does not work (and I think that's
correct), and breaks in the same way as MTOMCAT-141.
> contextFile path="..." ignored when using tomcat7:run
> -
>
> Key: MTOMCAT-142
> URL: https://issues.apache.org/jira/browse/MTOMCAT-142
> Project: Apache Tomcat Maven Plugin
> Issue Type: Bug
> Components: tomcat7
>Affects Versions: 2.0-beta-1
>Reporter: Dave Syer
>Assignee: Olivier Lamy (*$^¨%`£)
> Fix For: 2.0
>
>
> contextFile path="..." ignored when using tomcat7:run. I have been trying to
> use a custom context file (with contextFile config param). I can see the
> context being logged in the console, but the path attribute is ignored, and
> for all I know so are other settings (the app is always deployed with
> path=${project.artifactId}).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Created] (MTOMCAT-143) contextFile and tomcatUsers defined in pom.xml are not used with target tomcat7:run
contextFile and tomcatUsers defined in pom.xml are not used with target
tomcat7:run
---
Key: MTOMCAT-143
URL: https://issues.apache.org/jira/browse/MTOMCAT-143
Project: Apache Tomcat Maven Plugin
Issue Type: Bug
Components: tomcat7
Affects Versions: 2.0
Environment: linux
Reporter: Raphaël Zürcher
Assignee: Olivier Lamy (*$^¨%`£)
In the configuration of the plugin into my pom.xml, I've defined the path to
the contextFile and the tomcatUsers like this :
${appdir}/context.xml
${appdir}/tomcat-users.xml
It works using version 2.0-beta-1 and worked with 2.0-SNAPSHOT until a few days
ago. Tomcat7 start correctly, but my tomcat-users.xml is not used and I cannot
authentied services deployed on my tomcat. I use this configuration with
jenkins for testing.
Is there a regression in 2.0-SNAPSHOT or a new configuration issue ?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test has an issue affecting its community integration. This issue affects 1 projects. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-trunk-test : Tomcat 8.x, a web server implementing Java Servlet 3.1, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on tomcat-trunk-dbcp exists, no need to add for property tomcat-dbcp-src.jar. -DEBUG- Dependency on commons-daemon exists, no need to add for property commons-daemon.native.src.tgz. -DEBUG- Dependency on commons-daemon exists, no need to add for property tomcat-native.tar.gz. -DEBUG- Dependency on tomcat-trunk-dbcp exists, no need to add for property tomcat-dbcp.home. -INFO- Failed with reason build failed -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-trunk/output/build/logs The following work was performed: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/gump_work/build_tomcat-trunk_tomcat-trunk-test.html Work Name: build_tomcat-trunk_tomcat-trunk-test (Type: Build) Work ended in a state of : Failed Elapsed: 22 mins 37 secs Command Line: /usr/lib/jvm/java-6-openjdk/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Djunit.jar=/srv/gump/public/workspace/junit/dist/junit-16042012.jar -Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-16042012-native-src.tar.gz -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-16042012-native-src.tar.gz -Dexamples.sources.skip=true -Dtomcat-dbcp.home=/srv/gump/public/workspace/tomcat-trunk/tomcat-deps -Djdt.jar=/srv/gump/packages/eclipse/plugins/org.eclipse.jdt.core_3.4.2/jdtcore.jar -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-16042012.jar -Dtomcat-dbcp-src.jar=/srv/gump/public/workspace/tomcat-trunk/tomcat-deps/tomcat-dbcp-src.jar -Dtest.accesslog=true -Dcommons-pool.home=/srv/gump/public/workspace/commons-pool-1.x -Dcommons-dbcp.home=/ srv/gump/public/workspace/commons-dbcp-1.x -Dtomcat-dbcp.jar=/srv/gump/public/workspace/tomcat-trunk/tomcat-deps/tomcat-dbcp-16042012.jar test [Working Directory: /srv/gump/public/workspace/tomcat-trunk] CLASSPATH: /usr/lib/jvm/java-6-openjdk/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.jar:/srv/gump/public/workspace/tomcat-trunk/outp ut/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-jni.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-util.jar:/srv/gump/packages/javamail-1.4/mail.jar:/srv/gump/packages/javamail-1.4/lib/mailapi.jar:/srv/gump/packages/jaf-1.1ea/activation.jar:/srv/gump/packages/eclipse/plugins/org .eclipse.jdt.core_3.4.2/jdtcore.jar:/srv/gump/public/workspace/tomcat-trunk/tomcat-deps/tomcat-dbcp-16042012.jar:/srv/gump/public/workspace/apache-commons/daemon/dist/commons-da
DO NOT REPLY [Bug 53085] New: [perf] [concurrency] DefaultInstanceManager.annotationCache is not optimal for more threads
https://issues.apache.org/bugzilla/show_bug.cgi?id=53085 Bug #: 53085 Summary: [perf] [concurrency] DefaultInstanceManager.annotationCache is not optimal for more threads Product: Tomcat 7 Version: 7.0.26 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P3 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: martin.kocicak.k...@gmail.com Classification: Unclassified Created attachment 28616 --> https://issues.apache.org/bugzilla/attachment.cgi?id=28616 Screenshot : Thread states during test This is a small Concurrency problem also find during myfaces performance testing [1] org.apache.catalina.core.DefaultInstanceManager.annotationCache uses WeakHashMap for cache, but this approach needs sychronized get() access. This can lead to complete thread stuck at this lock - see attached screenshots from yourkit profiler. I think this problem is classical concurrent cache problem = many read but only few put()s, reads vastly outnumber writes. It this case is should be read without locking otherwise it is a concurrency bottleneck. I didn't check the code of DefaultInstanceManager deeply, following are suggestions only: 1) Normally is this concurrent-cache solvable with ConcurrentHashMap or with maps based on this type like [2] or [3] 2) the 'weakness' can achieved with String (classname) if it is acceptable to maintain annotations for class that can be already unloaded or with WeakReference [1] http://tomcat.markmail.org/thread/7bbvzmkvyvryvn44 [2] http://svn.apache.org/repos/asf/lucene/dev/trunk/solr/core/src/java/org/apache/solr/util/ConcurrentLFUCache.java [3] http://code.google.com/p/guava-libraries/wiki/CachesExplained -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 53085] [perf] [concurrency] DefaultInstanceManager.annotationCache is not optimal for more threads
https://issues.apache.org/bugzilla/show_bug.cgi?id=53085 --- Comment #1 from Martin Kočí 2012-04-16 18:43:44 UTC --- Created attachment 28617 --> https://issues.apache.org/bugzilla/attachment.cgi?id=28617 Screenshot: Monitor Usage during test -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1326764 - /tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java
Author: olamy
Date: Mon Apr 16 19:33:33 2012
New Revision: 1326764
URL: http://svn.apache.org/viewvc?rev=1326764&view=rev
Log:
[MTOMCAT-142] fix context file using / path
Modified:
tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java
Modified:
tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java
URL:
http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java?rev=1326764&r1=1326763&r2=1326764&view=diff
==
---
tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java
(original)
+++
tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java
Mon Apr 16 19:33:33 2012
@@ -466,8 +466,6 @@ public abstract class AbstractRunMojo
{
String contextPath = getPath();
-contextPath = "/".equals( contextPath ) ? "" : contextPath;
-
String baseDir = getDocBase().getAbsolutePath();
File overridedContextFile = getContextFile();
@@ -486,6 +484,8 @@ public abstract class AbstractRunMojo
}
}
+contextPath = "/".equals( contextPath ) ? "" : contextPath;
+
Context context = container.addWebapp( contextPath, baseDir );
context.setResources(
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Commented] (MTOMCAT-142) contextFile path="..." ignored when using tomcat7:run
[
https://issues.apache.org/jira/browse/MTOMCAT-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254954#comment-13254954
]
Olivier Lamy (*$^¨%`£) commented on MTOMCAT-142:
oops my bad. Should be better now with r1326764. (SNAPSHOT deployed)
> contextFile path="..." ignored when using tomcat7:run
> -
>
> Key: MTOMCAT-142
> URL: https://issues.apache.org/jira/browse/MTOMCAT-142
> Project: Apache Tomcat Maven Plugin
> Issue Type: Bug
> Components: tomcat7
>Affects Versions: 2.0-beta-1
>Reporter: Dave Syer
>Assignee: Olivier Lamy (*$^¨%`£)
> Fix For: 2.0
>
>
> contextFile path="..." ignored when using tomcat7:run. I have been trying to
> use a custom context file (with contextFile config param). I can see the
> context being logged in the console, but the path attribute is ignored, and
> for all I know so are other settings (the app is always deployed with
> path=${project.artifactId}).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Commented] (MTOMCAT-142) contextFile path="..." ignored when using tomcat7:run
[
https://issues.apache.org/jira/browse/MTOMCAT-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254956#comment-13254956
]
Hudson commented on MTOMCAT-142:
Integrated in TomcatMavenPlugin-mvn3.x #136 (See
[https://builds.apache.org/job/TomcatMavenPlugin-mvn3.x/136/])
[MTOMCAT-142] fix context file using / path (Revision 1326764)
Result = FAILURE
olamy : http://svn.apache.org/viewvc/?view=rev&rev=1326764
Files :
*
/tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java
> contextFile path="..." ignored when using tomcat7:run
> -
>
> Key: MTOMCAT-142
> URL: https://issues.apache.org/jira/browse/MTOMCAT-142
> Project: Apache Tomcat Maven Plugin
> Issue Type: Bug
> Components: tomcat7
>Affects Versions: 2.0-beta-1
>Reporter: Dave Syer
>Assignee: Olivier Lamy (*$^¨%`£)
> Fix For: 2.0
>
>
> contextFile path="..." ignored when using tomcat7:run. I have been trying to
> use a custom context file (with contextFile config param). I can see the
> context being logged in the console, but the path attribute is ignored, and
> for all I know so are other settings (the app is always deployed with
> path=${project.artifactId}).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Commented] (MTOMCAT-143) contextFile and tomcatUsers defined in pom.xml are not used with target tomcat7:run
[
https://issues.apache.org/jira/browse/MTOMCAT-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254973#comment-13254973
]
Olivier Lamy (*$^¨%`£) commented on MTOMCAT-143:
contextFile not used with current trunk ? Sure ??
Any sample project to show this issue ?
> contextFile and tomcatUsers defined in pom.xml are not used with target
> tomcat7:run
> ---
>
> Key: MTOMCAT-143
> URL: https://issues.apache.org/jira/browse/MTOMCAT-143
> Project: Apache Tomcat Maven Plugin
> Issue Type: Bug
> Components: tomcat7
>Affects Versions: 2.0
> Environment: linux
>Reporter: Raphaël Zürcher
>Assignee: Olivier Lamy (*$^¨%`£)
>
> In the configuration of the plugin into my pom.xml, I've defined the path to
> the contextFile and the tomcatUsers like this :
> ${appdir}/context.xml
> ${appdir}/tomcat-users.xml
> It works using version 2.0-beta-1 and worked with 2.0-SNAPSHOT until a few
> days ago. Tomcat7 start correctly, but my tomcat-users.xml is not used and I
> cannot authentied services deployed on my tomcat. I use this configuration
> with jenkins for testing.
> Is there a regression in 2.0-SNAPSHOT or a new configuration issue ?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Commented] (MTOMCAT-142) contextFile path="..." ignored when using tomcat7:run
[
https://issues.apache.org/jira/browse/MTOMCAT-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254983#comment-13254983
]
Dave Syer commented on MTOMCAT-142:
---
Yes, that works now. But only with path="/". Is that right? Or should it be
path=""?
> contextFile path="..." ignored when using tomcat7:run
> -
>
> Key: MTOMCAT-142
> URL: https://issues.apache.org/jira/browse/MTOMCAT-142
> Project: Apache Tomcat Maven Plugin
> Issue Type: Bug
> Components: tomcat7
>Affects Versions: 2.0-beta-1
>Reporter: Dave Syer
>Assignee: Olivier Lamy (*$^¨%`£)
> Fix For: 2.0
>
>
> contextFile path="..." ignored when using tomcat7:run. I have been trying to
> use a custom context file (with contextFile config param). I can see the
> context being logged in the console, but the path attribute is ignored, and
> for all I know so are other settings (the app is always deployed with
> path=${project.artifactId}).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Commented] (MTOMCAT-142) contextFile path="..." ignored when using tomcat7:run
[
https://issues.apache.org/jira/browse/MTOMCAT-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254991#comment-13254991
]
Olivier Lamy (*$^¨%`£) commented on MTOMCAT-142:
sure only "/" works. if path="" that's considered as no path defined.
> contextFile path="..." ignored when using tomcat7:run
> -
>
> Key: MTOMCAT-142
> URL: https://issues.apache.org/jira/browse/MTOMCAT-142
> Project: Apache Tomcat Maven Plugin
> Issue Type: Bug
> Components: tomcat7
>Affects Versions: 2.0-beta-1
>Reporter: Dave Syer
>Assignee: Olivier Lamy (*$^¨%`£)
> Fix For: 2.0
>
>
> contextFile path="..." ignored when using tomcat7:run. I have been trying to
> use a custom context file (with contextFile config param). I can see the
> context being logged in the console, but the path attribute is ignored, and
> for all I know so are other settings (the app is always deployed with
> path=${project.artifactId}).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1326781 - /tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java
Author: olamy Date: Mon Apr 16 20:09:53 2012 New Revision: 1326781 URL: http://svn.apache.org/viewvc?rev=1326781&view=rev Log: log contextPath used Modified: tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java Modified: tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java URL: http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java?rev=1326781&r1=1326780&r2=1326781&view=diff == --- tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java (original) +++ tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java Mon Apr 16 20:09:53 2012 @@ -486,6 +486,8 @@ public abstract class AbstractRunMojo contextPath = "/".equals( contextPath ) ? "" : contextPath; +getLog().info( "create webapp with contextPath: " + contextPath ); + Context context = container.addWebapp( contextPath, baseDir ); context.setResources( - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GUMP@vmgump]: Project jakarta-tomcat-catalina (in module jakarta-tomcat-catalina) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project jakarta-tomcat-catalina has an issue affecting its community integration. This issue affects 2 projects, and has been outstanding for 11 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - jakarta-tomcat-catalina : Servlet 2.4 Reference Implementation - jakarta-tomcat-jk : Connectors to various web servers Full details are available at: http://vmgump.apache.org/gump/public/jakarta-tomcat-catalina/jakarta-tomcat-catalina/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on ant exists, no need to add for property ant.home. -DEBUG- Dependency on jmx exists, no need to add for property jmx.home. -DEBUG- Dependency on jaf exists, no need to add for property activation.home. -DEBUG- Dependency on jakarta-tomcat-coyote exists, no need to add for property tomcat-coyote.home. -INFO- Failed with reason build failed -INFO- Failed to extract fallback artifacts from Gump Repository The following work was performed: http://vmgump.apache.org/gump/public/jakarta-tomcat-catalina/jakarta-tomcat-catalina/gump_work/build_jakarta-tomcat-catalina_jakarta-tomcat-catalina.html Work Name: build_jakarta-tomcat-catalina_jakarta-tomcat-catalina (Type: Build) Work ended in a state of : Failed Elapsed: 22 secs Command Line: /usr/lib/jvm/java-6-openjdk/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only -Xbootclasspath/p:/srv/gump/public/workspace/xml-xerces2/build/xercesImpl.jar:/srv/gump/public/workspace/xml-commons/java/external/build/xml-apis.jar:/srv/gump/public/workspace/xml-xalan/build/xalan-unbundled.jar:/srv/gump/public/workspace/xml-xalan/build/serializer.jar org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Dtomcat33.home=--UnSet-- -Dcatalina.build=/srv/gump/public/workspace/jakarta-tomcat-catalina/build -Djmx.home=/srv/gump/packages/jmx-1_2_1-bin -Djdbc20ext.jar=/srv/gump/packages/jdbc2_0/jdbc2_0-stdext.jar -Djtc.home=/srv/gump/public/workspace/jakarta-tomcat-connectors -Djasper.home=/srv/gump/public/workspace/jakarta-tomcat-jasper_tc5 -Dant.home=/srv/gump/public/workspace/ant/dist -Dcommons-io.jar=/srv/gump/public/workspace/apache-commons/io/target/commons-io-*[0-9T].jar -Dcompile.source=1.4 -Dcommons-collections.jar=/srv/gump/public/w orkspace/commons-collections-3.x/target/commons-collections-3.3-SNAPSHOT.jar -Dcatalina.deploy=/srv/gump/public/workspace/jakarta-tomcat-catalina/build -Djaas.jar=/srv/gump/packages/jaas1_0/lib/jaas.jar -Dcommons-fileupload.jar=/srv/gump/public/workspace/apache-commons/fileupload/target/commons-fileupload-17042012.jar -Dcommons-digester.jar=/srv/gump/public/workspace/commons-digester-2.x/target/commons-digester-2.2-SNAPSHOT.jar -Dtomcat-http11.jar=/srv/gump/public/workspace/jakarta-tomcat-connectors/http11/build/lib/tomcat-http11.jar -Dactivation.home=/srv/gump/packages/jaf-1.1ea -Dcatalina.home=/srv/gump/public/workspace/jakarta-tomcat-catalina/build -Dcommons-launcher.jar=/srv/gump/public/workspace/apache-commons/launcher/dist/bin/commons-launcher-17042012.jar -Dtomcat.build=/srv/gump/public/workspace/jakarta-tomcat-catalina/build -Dcommons-beanutils.jar=/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-17042012.jar -Dcommons-modeler.jar=/srv/gump/ public/workspace/apache-commons/modeler/dist/commons-modeler-17042012.jar -Dtomcat-coyote.home=/srv/gump/public/workspace/jakarta-tomcat-connectors/coyote -Djmx-remote.jar=/srv/gump/packages/jmxremote-1_0_1-bin/lib/jmxremote.jar -Dcommons-logging-api.jar=/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-17042012.jar -Dtomcat-dbcp.jar=/srv/gump/public/workspace/jakarta-tomcat-5/tomcat-deps/naming-factory-dbcp.jar -Djta.jar=/srv/gump/packages/jta-spec1_0_1/jta-spec1_0_1.jar deploy-catalina [Working Directory: /srv/gump/public/workspace/jakarta-tomcat-catalina] CLASSPATH: /usr/lib/jvm/java-6-openjdk/lib/tools.jar:/srv/gump/public/workspace/jakarta-tomcat-catalina/build/server/classes:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/external/build/xml-apis-ext.jar:/srv/gump/packages/jaf-1.1ea/activation.jar:/srv/gump/packages/javamail-1.4/mail.jar:/srv/gump/packages/javamail-1.4/lib/mai
[GUMP@vmgump]: Project tomcat-tc7.0.x-test (in module tomcat-7.0.x) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-test has an issue affecting its community integration. This issue affects 1 projects. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-tc7.0.x-test : Tomcat 7.x, a web server implementing Java Servlet 3.0, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on tomcat-tc7.0.x-dbcp exists, no need to add for property tomcat-dbcp-src.jar. -DEBUG- Dependency on commons-daemon exists, no need to add for property commons-daemon.native.src.tgz. -DEBUG- Dependency on commons-daemon exists, no need to add for property tomcat-native.tar.gz. -DEBUG- Dependency on tomcat-tc7.0.x-dbcp exists, no need to add for property tomcat-dbcp.home. -INFO- Failed with reason build failed -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-7.0.x/output/build/logs The following work was performed: http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-test/gump_work/build_tomcat-7.0.x_tomcat-tc7.0.x-test.html Work Name: build_tomcat-7.0.x_tomcat-tc7.0.x-test (Type: Build) Work ended in a state of : Failed Elapsed: 22 mins 22 secs Command Line: /usr/lib/jvm/java-6-openjdk/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Djunit.jar=/srv/gump/public/workspace/junit/dist/junit-17042012.jar -Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-17042012-native-src.tar.gz -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-17042012-native-src.tar.gz -Dexamples.sources.skip=true -Dtomcat-dbcp.home=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps -Djdt.jar=/srv/gump/packages/eclipse/plugins/org.eclipse.jdt.core_3.4.2/jdtcore.jar -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-17042012.jar -Dtomcat-dbcp-src.jar=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps/tomcat-dbcp-src.jar -Dtest.accesslog=true -Dcommons-pool.home=/srv/gump/public/workspace/commons-pool-1.x -Dcommons-dbcp.home=/ srv/gump/public/workspace/commons-dbcp-1.x -Dtomcat-dbcp.jar=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps/tomcat-dbcp-17042012.jar test [Working Directory: /srv/gump/public/workspace/tomcat-7.0.x] CLASSPATH: /usr/lib/jvm/java-6-openjdk/lib/tools.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-7.0.x/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/servlet-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/outp ut/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/tomcat-util.jar:/srv/gump/packages/javamail-1.4/mail.jar:/srv/gump/packages/javamail-1.4/lib/mailapi.jar:/srv/gump/packages/jaf-1.1ea/activation.jar:/srv/gump/packages/eclipse/plugins/org.eclipse.jdt.core_3.4.2/jdtcore.jar:/srv/gump/public/workspace/tomcat-7. 0.x/tomcat-deps/tomcat-dbcp-17042012.jar:/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-17042012.jar:/srv/gump/public/workspace/junit/dist/
[jira] [Commented] (MTOMCAT-143) contextFile and tomcatUsers defined in pom.xml are not used with target tomcat7:run
[
https://issues.apache.org/jira/browse/MTOMCAT-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255321#comment-13255321
]
Raphaël Zürcher commented on MTOMCAT-143:
-
Here is my configuration in pom.xml :
org.apache.tomcat.maven
tomcat7-maven-plugin
2.0-SNAPSHOT
TomcatRunner
${app.port}
/manager
${app.contexturl}
${appdir}/context.xml
${appdir}/tomcat-users.xml
true
true
${tomcat.fork}
tomcat-run
pre-integration-test
run-war-only
tomcat-shutdown
post-integration-test
shutdown
javax.servlet
javax.servlet-api
3.0.1
oracle.jdbc
ojdbc6
${oracle.version}
Since the middle of the last week, this doesn't work anymore. The definition of
my users in the specified tomcat-users.xml is not used.
> contextFile and tomcatUsers defined in pom.xml are not used with target
> tomcat7:run
> ---
>
> Key: MTOMCAT-143
> URL: https://issues.apache.org/jira/browse/MTOMCAT-143
> Project: Apache Tomcat Maven Plugin
> Issue Type: Bug
> Components: tomcat7
>Affects Versions: 2.0
> Environment: linux
>Reporter: Raphaël Zürcher
>Assignee: Olivier Lamy (*$^¨%`£)
>
> In the configuration of the plugin into my pom.xml, I've defined the path to
> the contextFile and the tomcatUsers like this :
> ${appdir}/context.xml
> ${appdir}/tomcat-users.xml
> It works using version 2.0-beta-1 and worked with 2.0-SNAPSHOT until a few
> days ago. Tomcat7 start correctly, but my tomcat-users.xml is not used and I
> cannot authentied services deployed on my tomcat. I use this configuration
> with jenkins for testing.
> Is there a regression in 2.0-SNAPSHOT or a new configuration issue ?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test has an issue affecting its community integration. This issue affects 1 projects. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-trunk-test : Tomcat 8.x, a web server implementing Java Servlet 3.1, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on tomcat-trunk-dbcp exists, no need to add for property tomcat-dbcp-src.jar. -DEBUG- Dependency on commons-daemon exists, no need to add for property commons-daemon.native.src.tgz. -DEBUG- Dependency on commons-daemon exists, no need to add for property tomcat-native.tar.gz. -DEBUG- Dependency on tomcat-trunk-dbcp exists, no need to add for property tomcat-dbcp.home. -INFO- Failed with reason build failed -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-trunk/output/build/logs The following work was performed: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/gump_work/build_tomcat-trunk_tomcat-trunk-test.html Work Name: build_tomcat-trunk_tomcat-trunk-test (Type: Build) Work ended in a state of : Failed Elapsed: 22 mins 36 secs Command Line: /usr/lib/jvm/java-6-openjdk/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Djunit.jar=/srv/gump/public/workspace/junit/dist/junit-17042012.jar -Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-17042012-native-src.tar.gz -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-17042012-native-src.tar.gz -Dexamples.sources.skip=true -Dtomcat-dbcp.home=/srv/gump/public/workspace/tomcat-trunk/tomcat-deps -Djdt.jar=/srv/gump/packages/eclipse/plugins/org.eclipse.jdt.core_3.4.2/jdtcore.jar -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-17042012.jar -Dtomcat-dbcp-src.jar=/srv/gump/public/workspace/tomcat-trunk/tomcat-deps/tomcat-dbcp-src.jar -Dtest.accesslog=true -Dcommons-pool.home=/srv/gump/public/workspace/commons-pool-1.x -Dcommons-dbcp.home=/ srv/gump/public/workspace/commons-dbcp-1.x -Dtomcat-dbcp.jar=/srv/gump/public/workspace/tomcat-trunk/tomcat-deps/tomcat-dbcp-17042012.jar test [Working Directory: /srv/gump/public/workspace/tomcat-trunk] CLASSPATH: /usr/lib/jvm/java-6-openjdk/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.jar:/srv/gump/public/workspace/tomcat-trunk/outp ut/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-jni.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-util.jar:/srv/gump/packages/javamail-1.4/mail.jar:/srv/gump/packages/javamail-1.4/lib/mailapi.jar:/srv/gump/packages/jaf-1.1ea/activation.jar:/srv/gump/packages/eclipse/plugins/org .eclipse.jdt.core_3.4.2/jdtcore.jar:/srv/gump/public/workspace/tomcat-trunk/tomcat-deps/tomcat-dbcp-17042012.jar:/srv/gump/public/workspace/apache-commons/daemon/dist/commons-da
DO NOT REPLY [Bug 53087] New: BackupManager does not replicate session access time.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53087 Bug #: 53087 Summary: BackupManager does not replicate session access time. Product: Tomcat 7 Version: trunk Platform: All OS/Version: All Status: NEW Severity: normal Priority: P2 Component: Cluster AssignedTo: dev@tomcat.apache.org ReportedBy: kfuj...@apache.org Classification: Unclassified Created attachment 28619 --> https://issues.apache.org/bugzilla/attachment.cgi?id=28619 BackupManager does not replicate session access time. BackupManager does not replicate session access time. If a primary session does not change an attribute but it is only access , non-primary session(backup node) expire session. I made a patch to replicate session access time. Best Regards. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1326938 - in /tomcat/trunk/java/org/apache/catalina: ha/session/DeltaSession.java tribes/tipis/AbstractReplicatedMap.java tribes/tipis/ReplicatedMapEntry.java
Author: kfujino
Date: Tue Apr 17 06:06:51 2012
New Revision: 1326938
URL: http://svn.apache.org/viewvc?rev=1326938&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53087.
In order to avoid that a backup node expire a session, replicate session access
time in BackupManager.
Modified:
tomcat/trunk/java/org/apache/catalina/ha/session/DeltaSession.java
tomcat/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java
tomcat/trunk/java/org/apache/catalina/tribes/tipis/ReplicatedMapEntry.java
Modified: tomcat/trunk/java/org/apache/catalina/ha/session/DeltaSession.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ha/session/DeltaSession.java?rev=1326938&r1=1326937&r2=1326938&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/ha/session/DeltaSession.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/ha/session/DeltaSession.java Tue Apr
17 06:06:51 2012
@@ -222,6 +222,30 @@ public class DeltaSession extends Standa
this.endAccess();
}
}
+
+/**
+ * If this returns true, to replicate that an object has been accessed
+ * @return boolean
+ */
+@Override
+public boolean isAccessReplicate() {
+long replDelta = System.currentTimeMillis() -
getLastTimeReplicated();
+if (maxInactiveInterval >=0 && replDelta > (maxInactiveInterval *
1000)) {
+return true;
+}
+return false;
+}
+
+/**
+ * Access to an existing object.
+ */
+@Override
+public void accessEntry() {
+this.access();
+this.setPrimarySession(false);
+this.endAccess();
+}
+
// - Session Properties
/**
@@ -843,7 +867,8 @@ public class DeltaSession extends Standa
}
}
-protected long getLastTimeReplicated() {
+@Override
+public long getLastTimeReplicated() {
return lastTimeReplicated;
}
@@ -852,7 +877,8 @@ public class DeltaSession extends Standa
return version;
}
-protected void setLastTimeReplicated(long lastTimeReplicated) {
+@Override
+public void setLastTimeReplicated(long lastTimeReplicated) {
this.lastTimeReplicated = lastTimeReplicated;
}
Modified:
tomcat/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java?rev=1326938&r1=1326937&r2=1326938&view=diff
==
---
tomcat/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java
(original)
+++
tomcat/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java
Tue Apr 17 06:06:51 2012
@@ -408,8 +408,10 @@ public abstract class AbstractReplicated
if ( !entry.isSerializable() ) return;
if (entry.isPrimary() && entry.getBackupNodes()!= null &&
entry.getBackupNodes().length > 0) {
Object value = entry.getValue();
-//check to see if we need to replicate this object
isDirty()||complete
-boolean repl = complete || ( (value instanceof ReplicatedMapEntry)
&& ( (ReplicatedMapEntry) value).isDirty());
+//check to see if we need to replicate this object
isDirty()||complete || isAccessReplicate()
+boolean isDirty = ((value instanceof ReplicatedMapEntry) &&
((ReplicatedMapEntry) value).isDirty());
+boolean isAccess = ((value instanceof ReplicatedMapEntry) &&
((ReplicatedMapEntry) value).isAccessReplicate());
+boolean repl = complete || isDirty || isAccess;
if (!repl) {
if ( log.isTraceEnabled() )
@@ -418,9 +420,9 @@ public abstract class AbstractReplicated
return;
}
//check to see if the message is diffable
-boolean diff = ( (value instanceof ReplicatedMapEntry) && (
(ReplicatedMapEntry) value).isDiffable());
+boolean diff = ((value instanceof ReplicatedMapEntry) &&
((ReplicatedMapEntry) value).isDiffable());
MapMessage msg = null;
-if (diff) {
+if (diff && isDirty) {
ReplicatedMapEntry rentry =
(ReplicatedMapEntry)entry.getValue();
try {
rentry.lock();
@@ -438,6 +440,12 @@ public abstract class AbstractReplicated
}
}
+if (msg == null && isAccess) {
+//construct a access message
+msg = new MapMessage(mapContextName, MapMessage.MSG_ACCESS,
+false, (Serializable) entry.getKey(), null, null,
entry.getPrimary(),
+entry.getBackupNodes())
svn commit: r1326941 - in /tomcat/tc7.0.x/trunk: java/org/apache/catalina/ha/session/ java/org/apache/catalina/tribes/tipis/ webapps/docs/
Author: kfujino
Date: Tue Apr 17 06:23:21 2012
New Revision: 1326941
URL: http://svn.apache.org/viewvc?rev=1326941&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53087.
In order to avoid that a backup node expire a session, replicate session access
time in BackupManager.
Modified:
tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/DeltaSession.java
tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java
tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/tipis/ReplicatedMapEntry.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
Modified:
tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/DeltaSession.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/DeltaSession.java?rev=1326941&r1=1326940&r2=1326941&view=diff
==
--- tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/DeltaSession.java
(original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/DeltaSession.java
Tue Apr 17 06:23:21 2012
@@ -222,6 +222,30 @@ public class DeltaSession extends Standa
this.endAccess();
}
}
+
+/**
+ * If this returns true, to replicate that an object has been accessed
+ * @return boolean
+ */
+@Override
+public boolean isAccessReplicate() {
+long replDelta = System.currentTimeMillis() -
getLastTimeReplicated();
+if (maxInactiveInterval >=0 && replDelta > (maxInactiveInterval *
1000)) {
+return true;
+}
+return false;
+}
+
+/**
+ * Access to an existing object.
+ */
+@Override
+public void accessEntry() {
+this.access();
+this.setPrimarySession(false);
+this.endAccess();
+}
+
// - Session Properties
/**
@@ -843,7 +867,8 @@ public class DeltaSession extends Standa
}
}
-protected long getLastTimeReplicated() {
+@Override
+public long getLastTimeReplicated() {
return lastTimeReplicated;
}
@@ -852,7 +877,8 @@ public class DeltaSession extends Standa
return version;
}
-protected void setLastTimeReplicated(long lastTimeReplicated) {
+@Override
+public void setLastTimeReplicated(long lastTimeReplicated) {
this.lastTimeReplicated = lastTimeReplicated;
}
Modified:
tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java?rev=1326941&r1=1326940&r2=1326941&view=diff
==
---
tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java
(original)
+++
tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java
Tue Apr 17 06:23:21 2012
@@ -402,8 +402,10 @@ public abstract class AbstractReplicated
if ( !entry.isSerializable() ) return;
if (entry.isPrimary() && entry.getBackupNodes()!= null &&
entry.getBackupNodes().length > 0) {
Object value = entry.getValue();
-//check to see if we need to replicate this object
isDirty()||complete
-boolean repl = complete || ( (value instanceof ReplicatedMapEntry)
&& ( (ReplicatedMapEntry) value).isDirty());
+//check to see if we need to replicate this object
isDirty()||complete || isAccessReplicate()
+boolean isDirty = ((value instanceof ReplicatedMapEntry) &&
((ReplicatedMapEntry) value).isDirty());
+boolean isAccess = ((value instanceof ReplicatedMapEntry) &&
((ReplicatedMapEntry) value).isAccessReplicate());
+boolean repl = complete || isDirty || isAccess;
if (!repl) {
if ( log.isTraceEnabled() )
@@ -412,9 +414,9 @@ public abstract class AbstractReplicated
return;
}
//check to see if the message is diffable
-boolean diff = ( (value instanceof ReplicatedMapEntry) && (
(ReplicatedMapEntry) value).isDiffable());
+boolean diff = ((value instanceof ReplicatedMapEntry) &&
((ReplicatedMapEntry) value).isDiffable());
MapMessage msg = null;
-if (diff) {
+if (diff && isDirty) {
ReplicatedMapEntry rentry =
(ReplicatedMapEntry)entry.getValue();
try {
rentry.lock();
@@ -432,6 +434,12 @@ public abstract class AbstractReplicated
}
}
+if (msg == null && isAccess) {
+//construct a access message
+msg = new MapMessage(mapContextNam
DO NOT REPLY [Bug 53087] BackupManager does not replicate session access time.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53087 Keiichi Fujino changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #1 from Keiichi Fujino 2012-04-17 06:24:03 UTC --- Fixed in 7.0.x and will be in 7.0.28 onwards. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
buildbot failure in ASF Buildbot on tomcat-trunk
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/2937 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source Stamp: [branch tomcat/trunk] 1326938 Blamelist: kfujino BUILD FAILED: failed compile_1 sincerely, -The Buildbot - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
