DO NOT REPLY [Bug 53000] New: Null-pointer exception catalina
https://issues.apache.org/bugzilla/show_bug.cgi?id=53000
Bug #: 53000
Summary: Null-pointer exception catalina
Product: Tomcat 6
Version: 6.0.35
Platform: PC
OS/Version: Windows Server 2003
Status: NEW
Severity: normal
Priority: P2
Component: Catalina
AssignedTo: dev@tomcat.apache.org
ReportedBy: h...@mckesson.nl
Classification: Unclassified
Catalina will generate a null-pointer exception in the
Response.java class.
org\apache\catalina\connector\Response.java
Line 1488:
protected boolean isEncodeable(final String location) {
if (getContext().isDisableURLRewriting()) <--- getContext() == null
return (false);
if (location == null)
return (false);
The getContext call seems null, this is since version 6.0.30, the code
above seems to be introduced in that version.
Is difficult to make an reproducable case, because it happens in a portal
application we use.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 53001] New: Behaviour of ResourceBundleELResolver
https://issues.apache.org/bugzilla/show_bug.cgi?id=53001 Bug #: 53001 Summary: Behaviour of ResourceBundleELResolver Product: Tomcat 7 Version: unspecified Platform: PC OS/Version: Linux Status: NEW Severity: normal Priority: P2 Component: Servlet & JSP API AssignedTo: dev@tomcat.apache.org ReportedBy: b.diedrich...@googlemail.com Classification: Unclassified I have discovered the the ResourceBundleELResolver from the tomcat el-api.jar behaves differently then the one from standard el-api. The difference lays in the handling of missing properties. The tomcat version will not set the resolved property to true such that evaluation continues and finally an exception is thrown. This causes pages to crash if a property can not be found (which I think is kind of unacceptable for production sites). The bahaviour was changed due to https://issues.apache.org/bugzilla/show_bug.cgi?id=46915. I think that changing the standard behaviour of "resolving" an unbound property by just returning its key is to throwing an exception was a strong decision. I would strongly recommend of reintroducing the old bahviour and fixing the issue 46915 in a different way. If someone can point my to the requirements and corner cases related to 46915, I will gladly provide an implementation. Until then, a workaround for everybody using jsf: Subclass the ResourceBundleELResolver and override its getValue(...) method. Change it such that it sets the PropertyResolved attribute to true before any exception might occur. Register this custom resolver in the faces-config.xml with -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Taglibs Parent POM 3
+1 Signatures and generic content OK On 03/26/2012 07:01 AM, Jeremy Boynes wrote: The proposed 3 release of Apache Taglibs Parent POM is now available for voting. Please vote on whether Apache Taglibs Parent 3 should be: [+1] Released, or [-1] Not released because ... Regards -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 53000] Null-pointer exception catalina
https://issues.apache.org/bugzilla/show_bug.cgi?id=53000 h...@mckesson.nl changed: What|Removed |Added Severity|normal |blocker -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1306869 - /tomcat/taglibs/trunks/
Author: olamy Date: Thu Mar 29 13:50:31 2012 New Revision: 1306869 URL: http://svn.apache.org/viewvc?rev=1306869&view=rev Log: ignore out directory Modified: tomcat/taglibs/trunks/ (props changed) Propchange: tomcat/taglibs/trunks/ -- --- svn:ignore (original) +++ svn:ignore Thu Mar 29 13:50:31 2012 @@ -1,5 +1,6 @@ .idea *.iml +out .project .classpath .settings - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 53000] Null-pointer exception catalina
https://issues.apache.org/bugzilla/show_bug.cgi?id=53000 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Comment #1 from Mark Thomas 2012-03-29 14:04:16 UTC --- You have a broken application and/or third party library that is illegally retaining a reference to a response object after the request/response processing has finished. The users list is the place to seek help. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1306874 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Thu Mar 29 14:16:05 2012 New Revision: 1306874 URL: http://svn.apache.org/viewvc?rev=1306874&view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1306874&r1=1306873&r2=1306874&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Mar 29 14:16:05 2012 @@ -162,6 +162,15 @@ PATCHES PROPOSED TO BACKPORT: +1: kkolinko -1: +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52983 + Remove unnecessary code that makes switching to other authentication methods + difficult. Also prevent the custom error pages for the Manager and Host + Manager applications from being accessed directly. + http://svn.apache.org/viewvc?view=revision&revision=1084103 + http://svn.apache.org/viewvc?view=revision&revision=1084109 + +1: mark + -1: + PATCHES/ISSUES THAT ARE STALLED - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52983] DIGEST auth broken on 6.0.x manager app because of redundant WWW-Authenticate header in 401.jsp
https://issues.apache.org/bugzilla/show_bug.cgi?id=52983 --- Comment #2 from Mark Thomas 2012-03-29 14:16:08 UTC --- I've proposed the fix that was applied to trunk and 7.0.x for 6.0.x. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52066] ConnectionPool.borrowConnection swallows interrupt state.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52066
Alexander Pogrebnyak changed:
What|Removed |Added
Status|RESOLVED|REOPENED
Resolution|FIXED |
--- Comment #9 from Alexander Pogrebnyak
2012-03-29 14:52:47 UTC ---
(In reply to comment #8)
> Please note that the interrupt flag was already cleared, this commit does
> change things around a bit
> http://svn.apache.org/viewvc?rev=1306410&view=rev
> I've made an adjustment based on a suggestion on the dev list
Reviewing the code I see these lines in close() and borrowConnection
catch (InterruptedException ex) {
...
if (!getPoolProperties().getPropagateInterruptState()) {
Thread.interrupted();
}
...
}
The problem is that this still does not set the interrupted status on the
thread, that's the common behavior of many flavors of wait methods. So, in
this case the handler have to make a call to interrupt itself.
The exception handler code should do this:
catch (InterruptedException ex) {
...
if (getPoolProperties().getPropagateInterruptState()) {
Thread.currentThread().interrupt();
} else {
Thread.interrupted();
}
...
}
The fix should be applied to lines 384 and and 631 of
org.apache.tomcat.jdbc.pool.ConnectionPool in
http://svn.apache.org/viewvc?view=revision&revision=1305931
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52066] ConnectionPool.borrowConnection swallows interrupt state.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52066 --- Comment #10 from Alexander Pogrebnyak 2012-03-29 14:57:47 UTC --- BTW, it is not related to this bug, but I don't know where to submit it otherwise. When I add a comment to this bug report and press `Save Changes` button Bugzilla does not redirect we to this report (52066), but instead goes to "ASF Bugzilla – Bug 48001". 48001 is completely unrelated report, but it was also submitted by me. If you could kindly reply to this comment with a proper channel I will submit this bug there. Thanks! -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Jenkins configuration
2012/3/29 Jeremy Boynes : > A checkout of trunks is building on my Mac using Maven 3.0.3 but failing in a > similar way to Jenkins with Maven 3.0.4 > It works with 3.0.4 if I remove the -T3 so that it builds single threaded, > but the last successful build #15 also used 3.0.4 and -T3 > > I propose to remove the -T3 in the configuration and try again with 3.0.4. > I'm new to Jenkins so please advise if there are any issues with that. Nice you found an concurrent access issue in a maven plugin (remote resources) using -T :-) So I have removed the -T3 > > However, we are also getting errors about the effective path of parent files > which I believe is caused because the aggregating pom in trunks is not > actually the parent of the modules it contains. This is because the structure > of taglibs was as four projects intended to be released independently > (parent, standard, rdc and extended) and not intended to be built as one. > but the parent is in reactors (i.e. a module in the aggregator pom) so not an issue. > I propose we keep that split in Jenkins and re-configure it into 4 projects > matching what would be released. That would also remove the aggregator stub > trunks. I like the idea about building all in one shot (at least for lazy maintenance convenience :-) ) > > On Mar 26, 2012, at 10:37 PM, Olivier Lamy wrote: > >> I setup the build on Jenkins long ago. >> Do you need some configuration change ? >> >> -- >> Olivier >> Le 27 mars 2012 03:38, "Jeremy Boynes" a écrit : >> >>> Thanks, request sent to Mladen as per that page. Do we know who set this >>> up? >>> >>> On Mar 26, 2012, at 12:30 PM, Olivier Lamy wrote: >>> Hello, See http://wiki.apache.org/general/Jenkins#How_do_I_get_an_account 2012/3/26 Jeremy Boynes : > Who controls permissions in Jenkins (builds.a.o)? Please can you grant >>> me build rights for Taglibs-All? >>> >>> >>> - >>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >>> For additional commands, e-mail: dev-h...@tomcat.apache.org >>> >>> > > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > -- Olivier Lamy Talend: http://coders.talend.com http://twitter.com/olamy | http://linkedin.com/in/olamy - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
RE: svn commit: r1306130 - in /tomcat/trunk/java/org/apache/catalina/startup: LocalStrings.properties UserConfig.java
> >> -Original Message-
> >> From: kfuj...@apache.org [mailto:kfuj...@apache.org]
> >> Sent: Tuesday, March 27, 2012 8:51 PM
> >> To: dev@tomcat.apache.org
> >> Subject: svn commit: r1306130 - in
> >> /tomcat/trunk/java/org/apache/catalina/startup: LocalStrings.properties
> >> UserConfig.java
> >>
> >> + for (Future result : results) {
> >> + try {
> >> + result.get();
> >> + } catch (Exception e) {
> >> +
> >>
> host.getLogger().error(sm.getString("userConfig.deploy.threaded.error"),
> >> e);
> >> + }
> >> + }
> >> }
> > [Filip Hanik]
> > If results[0].get() fails, are you not going to wait for the others to
> complete?
> >
>
> If results[0].get() fails, I am going to wait for the others to complete.
> Thus I implemented try-catch inside a loop.
> Is there wrong code in this rev?
> Or don't I understand your comment correctly?
[Filip Hanik]
You got it right, I just misread the location of the try-catch
>
> >
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> > For additional commands, e-mail: dev-h...@tomcat.apache.org
> >
>
>
>
> --
> Keiichi.Fujino
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1306946 - in /tomcat/trunk/modules/jdbc-pool/src: main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java test/java/org/apache/tomcat/jdbc/test/PoolCleanerTest.java
Author: fhanik
Date: Thu Mar 29 16:02:26 2012
New Revision: 1306946
URL: http://svn.apache.org/viewvc?rev=1306946&view=rev
Log:
Per http://tomcat.markmail.org/thread/j7jk7xalhs7t7op7
Threads in the connection pool should not be created using the context loader,
but rather the loader that loaded the pool
Modified:
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/PoolCleanerTest.java
Modified:
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java?rev=1306946&r1=1306945&r2=1306946&view=diff
==
---
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
(original)
+++
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
Thu Mar 29 16:02:26 2012
@@ -1217,13 +1217,16 @@ public class ConnectionPool {
unregisterCleaner(cleaner);
cleaners.add(cleaner);
if (poolCleanTimer == null) {
-poolCleanTimer = new Timer("PoolCleaner["
-+ System.identityHashCode(ConnectionPool.class
-.getClassLoader()) + ":"
-+ System.currentTimeMillis() + "]", true);
+ClassLoader loader =
Thread.currentThread().getContextClassLoader();
+try {
+
Thread.currentThread().setContextClassLoader(ConnectionPool.class.getClassLoader());
+poolCleanTimer = new Timer("PoolCleaner["+
System.identityHashCode(ConnectionPool.class.getClassLoader()) + ":"+
+ System.currentTimeMillis() + "]",
true);
+}finally {
+Thread.currentThread().setContextClassLoader(loader);
+}
}
-poolCleanTimer.scheduleAtFixedRate(cleaner, cleaner.sleepTime,
-cleaner.sleepTime);
+poolCleanTimer.scheduleAtFixedRate(cleaner,
cleaner.sleepTime,cleaner.sleepTime);
}
private static synchronized void unregisterCleaner(PoolCleaner cleaner) {
Modified:
tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/PoolCleanerTest.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/PoolCleanerTest.java?rev=1306946&r1=1306945&r2=1306946&view=diff
==
---
tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/PoolCleanerTest.java
(original)
+++
tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/PoolCleanerTest.java
Thu Mar 29 16:02:26 2012
@@ -17,6 +17,8 @@
package org.apache.tomcat.jdbc.test;
+import java.util.Map;
+
import org.apache.tomcat.jdbc.pool.ConnectionPool;
import org.apache.tomcat.jdbc.pool.DataSource;
@@ -26,19 +28,33 @@ public class PoolCleanerTest extends Def
super(name);
}
+private int countPoolCleanerThreads() {
+Map threadmap =
Thread.getAllStackTraces();
+int result = 0;
+for (Thread t : threadmap.keySet()) {
+if (t.getName().startsWith("PoolCleaner[")) result++;
+}
+return result;
+}
+
public void testPoolCleaner() throws Exception {
datasource.getPoolProperties().setTimeBetweenEvictionRunsMillis(2000);
datasource.getPoolProperties().setTestWhileIdle(true);
assertEquals("Pool cleaner should not be started
yet.",0,ConnectionPool.getPoolCleaners().size() );
assertNull("Pool timer should be null", ConnectionPool.getPoolTimer());
+assertEquals("Pool cleaner threads should not be present.",0,
countPoolCleanerThreads());
datasource.getConnection().close();
assertEquals("Pool cleaner should have 1
cleaner.",1,ConnectionPool.getPoolCleaners().size() );
assertNotNull("Pool timer should not be null",
ConnectionPool.getPoolTimer());
+assertEquals("Pool cleaner threads should be 1.",1,
countPoolCleanerThreads());
datasource.close();
assertEquals("Pool shutdown, no cleaners should be
present.",0,ConnectionPool.getPoolCleaners().size() );
assertNull("Pool timer should be null after shutdown",
ConnectionPool.getPoolTimer());
+assertEquals("Pool cleaner threads should not be present after
close.",0, countPoolCleanerThreads());
+
+
}
public void test2PoolCleaners() throws Exception {
@@ -49,11 +65,13 @@ public class PoolCleanerTest extends Def
assertEquals("Pool cleaner should not be started
yet.",0,ConnectionPool.getPoolCleaners().size() );
assertNull("Pool timer should be null", ConnectionPool.getPoolTimer());
+
svn commit: r1306955 - in /tomcat/tc7.0.x/trunk: modules/ webapps/docs/changelog.xml
Author: fhanik Date: Thu Mar 29 16:12:56 2012 New Revision: 1306955 URL: http://svn.apache.org/viewvc?rev=1306955&view=rev Log: http://markmail.org/message/j7jk7xalhs7t7op7 Correct class loader to load pool threads, to avoid the leak detector Modified: tomcat/tc7.0.x/trunk/modules/ (props changed) tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Propchange: tomcat/tc7.0.x/trunk/modules/ -- --- svn:externals (original) +++ svn:externals Thu Mar 29 16:12:56 2012 @@ -1 +1 @@ -^/tomcat/trunk/modules/jdbc-pool@1306410 jdbc-pool +^/tomcat/trunk/modules/jdbc-pool@1306946 jdbc-pool Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1306955&r1=1306954&r2=1306955&view=diff == --- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original) +++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Thu Mar 29 16:12:56 2012 @@ -234,6 +234,10 @@ + +Pool cleaner thread should be created using the classloader +that loaded the pool, not the context loader (fhanik) + 52804: Make pool properties serializable and cloneable. (fhanik) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Jenkins configuration
2012/3/29 Olivier Lamy : > 2012/3/29 Jeremy Boynes : >> A checkout of trunks is building on my Mac using Maven 3.0.3 but failing in >> a similar way to Jenkins with Maven 3.0.4 >> It works with 3.0.4 if I remove the -T3 so that it builds single threaded, >> but the last successful build #15 also used 3.0.4 and -T3 >> >> I propose to remove the -T3 in the configuration and try again with 3.0.4. >> I'm new to Jenkins so please advise if there are any issues with that. > Nice you found an concurrent access issue in a maven plugin (remote > resources) using -T :-) > So I have removed the -T3 already fixed in last version see https://jira.codehaus.org/browse/MRRESOURCES-54 >> >> However, we are also getting errors about the effective path of parent files >> which I believe is caused because the aggregating pom in trunks is not >> actually the parent of the modules it contains. This is because the >> structure of taglibs was as four projects intended to be released >> independently (parent, standard, rdc and extended) and not intended to be >> built as one. >> > but the parent is in reactors (i.e. a module in the aggregator pom) so > not an issue. >> I propose we keep that split in Jenkins and re-configure it into 4 projects >> matching what would be released. That would also remove the aggregator stub >> trunks. > I like the idea about building all in one shot (at least for lazy > maintenance convenience :-) ) >> >> On Mar 26, 2012, at 10:37 PM, Olivier Lamy wrote: >> >>> I setup the build on Jenkins long ago. >>> Do you need some configuration change ? >>> >>> -- >>> Olivier >>> Le 27 mars 2012 03:38, "Jeremy Boynes" a écrit : >>> Thanks, request sent to Mladen as per that page. Do we know who set this up? On Mar 26, 2012, at 12:30 PM, Olivier Lamy wrote: > Hello, > See http://wiki.apache.org/general/Jenkins#How_do_I_get_an_account > > > > 2012/3/26 Jeremy Boynes : >> Who controls permissions in Jenkins (builds.a.o)? Please can you grant me build rights for Taglibs-All? - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org >> >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >> For additional commands, e-mail: dev-h...@tomcat.apache.org >> > > > > -- > Olivier Lamy > Talend: http://coders.talend.com > http://twitter.com/olamy | http://linkedin.com/in/olamy -- Olivier Lamy Talend: http://coders.talend.com http://twitter.com/olamy | http://linkedin.com/in/olamy - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52066] ConnectionPool.borrowConnection swallows interrupt state.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52066 Filip Hanik changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||FIXED --- Comment #11 from Filip Hanik 2012-03-29 16:19:53 UTC --- http://www.apache.org/dev/#infrastructure -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52318] Version in tomcat-jdbc POM is conflicted with Version in MANIFEST for JULI JAR
https://issues.apache.org/bugzilla/show_bug.cgi?id=52318 --- Comment #13 from Filip Hanik 2012-03-29 16:21:19 UTC --- .22. > > The fix of this issue will be than: > tomcat-jdbc MANIFEST: > Import-Package: org.apache.juli.logging;version="[6.0, 7.1)" > OR may be > Import-Package: org.apache.juli.logging;version="[6.0, 8.0)" > > But be careful with that version range. This means tomcat-jdbc can run with > all > versions in [6.0.0, 7.1.0) of tomcat-juli. and that is correct. it can run with all versions of 6. so, can we get a patch or correct manifest, attached to this bug, and then we can get that taken care of -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52066] ConnectionPool.borrowConnection swallows interrupt state.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52066 --- Comment #12 from Alexander Pogrebnyak 2012-03-29 16:30:01 UTC --- (In reply to comment #11) > http://www.apache.org/dev/#infrastructure Created bug report https://issues.apache.org/jira/browse/INFRA-4620 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52066] ConnectionPool.borrowConnection swallows interrupt state.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52066 Alexander Pogrebnyak changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED | --- Comment #13 from Alexander Pogrebnyak 2012-03-29 16:32:21 UTC --- Reopening this bug, as there is no reply to my comment #9 -> https://issues.apache.org/bugzilla/show_bug.cgi?id=52066#c9. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52066] ConnectionPool.borrowConnection swallows interrupt state.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52066 Filip Hanik changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||FIXED --- Comment #14 from Filip Hanik 2012-03-29 16:37:34 UTC --- r1306410 a day or so ago -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52688] Add ability to remove old access log files
https://issues.apache.org/bugzilla/show_bug.cgi?id=52688 --- Comment #8 from Mark 2012-03-29 16:51:18 UTC --- I also realized that the default tomcat JULI FileHandler and AsyncFileHandler do not support deleting old files. So, I would either need to change these as well, or need to configure my installation of tomcat to use something else (like log4j). These things are not difficult, but it started to seem like I was on a pretty circuitous route to get the small feature I wanted. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
RE: AccessLogValve enhancement
After thinking about this some more, and deliberating on the subtle issues that were coming up, I decided to reduce the scope of my enhancement. I still like the idea of using a standard logger for this logging, but for now I thought I would focus more on my specific problem. I wrote more about this in the issue. https://issues.apache.org/bugzilla/show_bug.cgi?id=52688 Is this something that could be adopted in a future 7.0 release? -Original Message- From: Mark Claassen [mailto:markclaass...@gmail.com] Sent: Tuesday, March 27, 2012 11:17 AM To: Tomcat Developers List Subject: Re: AccessLogValve enhancement That improved my timings considerably. Instead of between 300 - 1100, they are between 100 - 330. However, they are still slower than the current mechanism. (Although, I am not sure how much this benchmark is worth, anyway.) I would imagine that the Async logger has lots of optimizations in it to handle the threading aspects; I wonder if it would be better under load than the current mechanism? This info is not going to catalina.out. Other comments? Suggestions for direction: 1) I can add my "outputLoggerName" attribute, which will switch the valve to use the JULI logger 2) I can create some sort of AccessLogWriter that the AccessLogValves will delegate their writing to - With 2 implementations, one being the current method and one being a JULI implementation - Potentially removing one in the future if performance is not an issue. 3) I can just add an attribute to the AccessLogValves to automatically delete older files 4) I can just make my own private subclass to do what I want, and leave the tomcat code unaltered 5) Scrap the current file writing implementation in the AccessLogValve and go straight JULI I would welcome any advice. Mark On Tue, Mar 27, 2012 at 9:46 AM, Konstantin Kolinko wrote: > 2012/3/27 Mark Claassen : > > > > I did a quick performance test, and it is true that the default > > mechanism is quite a bit faster than the standard JULI logger. For > > this test, I > just > > modified the source code to write each log message 1000 times. The > > first set of timings (in millis) is from the current AccessLogValve, > > and the second set is using JULI. > > > > AccessLogValve Elapsed Time: 8 > > AccessLogValve Elapsed Time: 19 > > AccessLogValve Elapsed Time: 63 > > AccessLogValve Elapsed Time: 6 > > AccessLogValve Elapsed Time: 7 > > AccessLogValve Elapsed Time: 8 > > > > INFO: AccessLogValve Elapsed Time: 830 > > INFO: AccessLogValve Elapsed Time: 1122 > > INFO: AccessLogValve Elapsed Time: 451 > > INFO: AccessLogValve Elapsed Time: 531 > > INFO: AccessLogValve Elapsed Time: 764 > > INFO: AccessLogValve Elapsed Time: 347 > > > > 1. Try to configure JULI with org.apache.juli.AsyncFileHandler. > It might show better numbers. > > (The usual FileHandler by default performs flush() after each log message). > > 2. Is the same printed to console? If yes then remove ConsoleHandler. > > Best regards, > Konstantin Kolinko > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For > additional commands, e-mail: dev-h...@tomcat.apache.org > > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52066] ConnectionPool.borrowConnection swallows interrupt state.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52066 --- Comment #15 from Alexander Pogrebnyak 2012-03-29 16:52:27 UTC --- (In reply to comment #14) > r1306410 > > a day or so ago Thanks a lot for fixing this!!! -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52066] ConnectionPool.borrowConnection swallows interrupt state.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52066 --- Comment #16 from Alexander Pogrebnyak 2012-03-29 16:54:55 UTC --- Dummy comment to test https://issues.apache.org/jira/browse/INFRA-4620 Please disregard. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1307019 - in /tomcat/trunk/java/org/apache: coyote/http11/NpnHandler.java tomcat/spdy/NetSupportOpenSSL.java tomcat/spdy/NetSupportSocket.java tomcat/spdy/SpdyConnection.java
Author: costin Date: Thu Mar 29 17:54:51 2012 New Revision: 1307019 URL: http://svn.apache.org/viewvc?rev=1307019&view=rev Log: Fix imports/licence. Modified: tomcat/trunk/java/org/apache/coyote/http11/NpnHandler.java tomcat/trunk/java/org/apache/tomcat/spdy/NetSupportOpenSSL.java tomcat/trunk/java/org/apache/tomcat/spdy/NetSupportSocket.java tomcat/trunk/java/org/apache/tomcat/spdy/SpdyConnection.java Modified: tomcat/trunk/java/org/apache/coyote/http11/NpnHandler.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/NpnHandler.java?rev=1307019&r1=1307018&r2=1307019&view=diff == --- tomcat/trunk/java/org/apache/coyote/http11/NpnHandler.java (original) +++ tomcat/trunk/java/org/apache/coyote/http11/NpnHandler.java Thu Mar 29 17:54:51 2012 @@ -1,5 +1,20 @@ /* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. */ + package org.apache.coyote.http11; import org.apache.coyote.Adapter; Modified: tomcat/trunk/java/org/apache/tomcat/spdy/NetSupportOpenSSL.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/spdy/NetSupportOpenSSL.java?rev=1307019&r1=1307018&r2=1307019&view=diff == --- tomcat/trunk/java/org/apache/tomcat/spdy/NetSupportOpenSSL.java (original) +++ tomcat/trunk/java/org/apache/tomcat/spdy/NetSupportOpenSSL.java Thu Mar 29 17:54:51 2012 @@ -1,15 +1,25 @@ /* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. */ package org.apache.tomcat.spdy; import java.io.IOException; -import java.net.Socket; -import java.nio.channels.ByteChannel; import java.util.Arrays; import java.util.List; -import javax.net.ssl.SSLEngine; - import org.apache.tomcat.jni.SSLExt; import org.apache.tomcat.jni.Status; import org.apache.tomcat.jni.socket.AprSocket; Modified: tomcat/trunk/java/org/apache/tomcat/spdy/NetSupportSocket.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/spdy/NetSupportSocket.java?rev=1307019&r1=1307018&r2=1307019&view=diff == --- tomcat/trunk/java/org/apache/tomcat/spdy/NetSupportSocket.java (original) +++ tomcat/trunk/java/org/apache/tomcat/spdy/NetSupportSocket.java Thu Mar 29 17:54:51 2012 @@ -1,4 +1,18 @@ /* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. */ package org.apache.tomcat.spdy; Modified: tomcat/trunk/java/org/apache/tomcat/spdy/SpdyConnection.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/spdy/SpdyConnection.java?rev=1307019&r1=1307018&r2=1307
svn commit: r1307027 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: kkolinko Date: Thu Mar 29 18:18:38 2012 New Revision: 1307027 URL: http://svn.apache.org/viewvc?rev=1307027&view=rev Log: vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1307027&r1=1307026&r2=1307027&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Mar 29 18:18:38 2012 @@ -168,7 +168,7 @@ PATCHES PROPOSED TO BACKPORT: Manager applications from being accessed directly. http://svn.apache.org/viewvc?view=revision&revision=1084103 http://svn.apache.org/viewvc?view=revision&revision=1084109 - +1: mark + +1: markt, kkolinko -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1307064 - in /tomcat/trunk/java/org/apache: coyote/http11/NpnHandler.java tomcat/spdy/NetSupportOpenSSL.java tomcat/spdy/NetSupportSocket.java
Author: kkolinko Date: Thu Mar 29 19:15:11 2012 New Revision: 1307064 URL: http://svn.apache.org/viewvc?rev=1307064&view=rev Log: svn:eol-style = native Modified: tomcat/trunk/java/org/apache/coyote/http11/NpnHandler.java (props changed) tomcat/trunk/java/org/apache/tomcat/spdy/NetSupportOpenSSL.java (props changed) tomcat/trunk/java/org/apache/tomcat/spdy/NetSupportSocket.java (props changed) Propchange: tomcat/trunk/java/org/apache/coyote/http11/NpnHandler.java -- svn:eol-style = native Propchange: tomcat/trunk/java/org/apache/tomcat/spdy/NetSupportOpenSSL.java -- svn:eol-style = native Propchange: tomcat/trunk/java/org/apache/tomcat/spdy/NetSupportSocket.java -- svn:eol-style = native - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1307079 - in /tomcat/trunk/java/org/apache: coyote/http11/ coyote/spdy/ tomcat/spdy/ tomcat/util/net/
Author: markt
Date: Thu Mar 29 19:55:07 2012
New Revision: 1307079
URL: http://svn.apache.org/viewvc?rev=1307079&view=rev
Log:
Whitespace / import police
Modified:
tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Protocol.java
tomcat/trunk/java/org/apache/coyote/http11/Http11AprProtocol.java
tomcat/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java
tomcat/trunk/java/org/apache/coyote/http11/Http11Protocol.java
tomcat/trunk/java/org/apache/coyote/http11/NpnHandler.java
tomcat/trunk/java/org/apache/coyote/spdy/SpdyAprNpnHandler.java
tomcat/trunk/java/org/apache/coyote/spdy/SpdyProcessor.java
tomcat/trunk/java/org/apache/tomcat/spdy/CompressDeflater6.java
tomcat/trunk/java/org/apache/tomcat/spdy/NetSupportOpenSSL.java
tomcat/trunk/java/org/apache/tomcat/spdy/NetSupportSocket.java
tomcat/trunk/java/org/apache/tomcat/spdy/SpdyConnection.java
tomcat/trunk/java/org/apache/tomcat/spdy/SpdyContext.java
tomcat/trunk/java/org/apache/tomcat/spdy/SpdyFrame.java
tomcat/trunk/java/org/apache/tomcat/spdy/SpdyStream.java
tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java
Modified: tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Protocol.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Protocol.java?rev=1307079&r1=1307078&r2=1307079&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Protocol.java
(original)
+++ tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Protocol.java Thu
Mar 29 19:55:07 2012
@@ -183,7 +183,7 @@ public abstract class AbstractHttp11Prot
public void setMaxKeepAliveRequests(int mkar) {
endpoint.setMaxKeepAliveRequests(mkar);
}
-
+
protected NpnHandler npnHandler;
public void setNpnHandler(String impl) {
try {
Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11AprProtocol.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/Http11AprProtocol.java?rev=1307079&r1=1307078&r2=1307079&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/Http11AprProtocol.java (original)
+++ tomcat/trunk/java/org/apache/coyote/http11/Http11AprProtocol.java Thu Mar
29 19:55:07 2012
@@ -19,14 +19,12 @@ package org.apache.coyote.http11;
import java.io.IOException;
import org.apache.coyote.AbstractProtocol;
-import org.apache.coyote.Adapter;
import org.apache.coyote.Processor;
import org.apache.coyote.http11.upgrade.UpgradeAprProcessor;
import org.apache.coyote.http11.upgrade.UpgradeInbound;
import org.apache.juli.logging.Log;
import org.apache.juli.logging.LogFactory;
import org.apache.tomcat.util.net.AbstractEndpoint;
-import org.apache.tomcat.util.net.AbstractEndpoint.Handler.SocketState;
import org.apache.tomcat.util.net.AprEndpoint;
import org.apache.tomcat.util.net.AprEndpoint.Handler;
import org.apache.tomcat.util.net.SocketStatus;
Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java?rev=1307079&r1=1307078&r2=1307079&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java (original)
+++ tomcat/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java Thu Mar
29 19:55:07 2012
@@ -84,7 +84,7 @@ public class Http11NioProtocol extends A
npnHandler.init(getEndpoint(), 0, adapter);
}
}
-
+
// Properties
private Http11ConnectionHandler cHandler;
@@ -222,7 +222,7 @@ public class Http11NioProtocol extends A
}
return super.process(socket, status);
}
-
+
/**
* Expected to be used by the handler once the processor is no longer
Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11Protocol.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/Http11Protocol.java?rev=1307079&r1=1307078&r2=1307079&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/Http11Protocol.java (original)
+++ tomcat/trunk/java/org/apache/coyote/http11/Http11Protocol.java Thu Mar 29
19:55:07 2012
@@ -91,7 +91,7 @@ public class Http11Protocol extends Abst
this.disableKeepAlivePercentage = disableKeepAlivePercentage;
}
}
-
+
@Override
public void start() throws Exception {
super.start();
@@ -144,7 +144,7 @@ public class Http11Protocol extends Abst
}
return super.process(socket, status);
}
-
+
/**
* Expected to be used by the handler once the proc
svn commit: r1307080 - in /tomcat/trunk/java/org/apache/coyote/http11: Http11NioProtocol.java Http11Protocol.java
Author: markt
Date: Thu Mar 29 19:59:37 2012
New Revision: 1307080
URL: http://svn.apache.org/viewvc?rev=1307080&view=rev
Log:
Import / @Override police
Modified:
tomcat/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java
tomcat/trunk/java/org/apache/coyote/http11/Http11Protocol.java
Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java?rev=1307080&r1=1307079&r2=1307080&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java (original)
+++ tomcat/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java Thu Mar
29 19:59:37 2012
@@ -29,7 +29,6 @@ import org.apache.coyote.http11.upgrade.
import org.apache.juli.logging.Log;
import org.apache.juli.logging.LogFactory;
import org.apache.tomcat.util.net.AbstractEndpoint;
-import org.apache.tomcat.util.net.AbstractEndpoint.Handler.SocketState;
import org.apache.tomcat.util.net.NioChannel;
import org.apache.tomcat.util.net.NioEndpoint;
import org.apache.tomcat.util.net.NioEndpoint.Handler;
@@ -212,6 +211,7 @@ public class Http11NioProtocol extends A
}
}
+@Override
public SocketState process(SocketWrapper socket,
SocketStatus status) {
if (proto.npnHandler != null) {
Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11Protocol.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/Http11Protocol.java?rev=1307080&r1=1307079&r2=1307080&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/Http11Protocol.java (original)
+++ tomcat/trunk/java/org/apache/coyote/http11/Http11Protocol.java Thu Mar 29
19:59:37 2012
@@ -25,7 +25,6 @@ import org.apache.coyote.http11.upgrade.
import org.apache.coyote.http11.upgrade.UpgradeInbound;
import org.apache.juli.logging.Log;
import org.apache.tomcat.util.net.AbstractEndpoint;
-import org.apache.tomcat.util.net.AbstractEndpoint.Handler.SocketState;
import org.apache.tomcat.util.net.JIoEndpoint;
import org.apache.tomcat.util.net.JIoEndpoint.Handler;
import org.apache.tomcat.util.net.SSLImplementation;
@@ -134,6 +133,7 @@ public class Http11Protocol extends Abst
return proto.sslImplementation;
}
+@Override
public SocketState process(SocketWrapper socket,
SocketStatus status) {
if (proto.npnHandler != null) {
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1307081 - /tomcat/trunk/java/org/apache/tomcat/spdy/SpdyContext.java
Author: markt
Date: Thu Mar 29 19:59:50 2012
New Revision: 1307081
URL: http://svn.apache.org/viewvc?rev=1307081&view=rev
Log:
Unnecessary code
Modified:
tomcat/trunk/java/org/apache/tomcat/spdy/SpdyContext.java
Modified: tomcat/trunk/java/org/apache/tomcat/spdy/SpdyContext.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/spdy/SpdyContext.java?rev=1307081&r1=1307080&r2=1307081&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/spdy/SpdyContext.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/spdy/SpdyContext.java Thu Mar 29
19:59:50 2012
@@ -222,7 +222,7 @@ public final class SpdyContext {
public void onStream(SpdyConnection spdyConnection, SpdyStream ch) throws
IOException {
if (handler instanceof NonBlockingSpdyHandler) {
handler.onStream(spdyConnection, ch);
-} else if (handler instanceof SpdyHandler) {
+} else {
getExecutor().execute(ch);
}
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1307083 - in /tomcat/trunk/java/org/apache/tomcat/spdy: NetSupportSocket.java SpdyStream.java
Author: markt
Date: Thu Mar 29 20:01:15 2012
New Revision: 1307083
URL: http://svn.apache.org/viewvc?rev=1307083&view=rev
Log:
@Override police
Modified:
tomcat/trunk/java/org/apache/tomcat/spdy/NetSupportSocket.java
tomcat/trunk/java/org/apache/tomcat/spdy/SpdyStream.java
Modified: tomcat/trunk/java/org/apache/tomcat/spdy/NetSupportSocket.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/spdy/NetSupportSocket.java?rev=1307083&r1=1307082&r2=1307083&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/spdy/NetSupportSocket.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/spdy/NetSupportSocket.java Thu Mar 29
20:01:15 2012
@@ -28,13 +28,16 @@ import javax.net.ssl.SSLSocket;
public class NetSupportSocket extends SpdyContext.NetSupport {
+@Override
public void onCreateEngine(Object engine) {
}
+@Override
public boolean isSpdy(Object socketW) {
return false;
}
+@Override
public SpdyConnection getConnection(String host, int port) throws
IOException {
try {
Socket sock = getSocket(host, port);
@@ -78,6 +81,7 @@ public class NetSupportSocket extends Sp
serverSocket.close();
}
+@Override
public void onAccept(Object socket) {
SpdyConnectionSocket ch = new SpdyConnectionSocket(ctx, (Socket)
socket);
ctx.getExecutor().execute(ch.inputThread);
Modified: tomcat/trunk/java/org/apache/tomcat/spdy/SpdyStream.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/spdy/SpdyStream.java?rev=1307083&r1=1307082&r2=1307083&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/spdy/SpdyStream.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/spdy/SpdyStream.java Thu Mar 29
20:01:15 2012
@@ -286,6 +286,7 @@ public class SpdyStream implements Runna
return current.readByte();
}
+@Override
public int read(byte b[], int off, int len) throws IOException {
fill();
if (current == null) {
@@ -298,9 +299,11 @@ public class SpdyStream implements Runna
return rd;
}
+@Override
public int available() throws IOException {
return 0;
}
+@Override
public void close() throws IOException {
// send RST if not closed
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1307084 - /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
Author: markt
Date: Thu Mar 29 20:03:20 2012
New Revision: 1307084
URL: http://svn.apache.org/viewvc?rev=1307084&view=rev
Log:
Fix a hanging test with APR. Connections using HTTP keep-alive were not closed
on Endpoint.stop() so a stop() start() sequence meant they were kept open with
any data sent being ignored until the connection timed out.
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java?rev=1307084&r1=1307083&r2=1307084&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java Thu Mar 29
20:03:20 2012
@@ -929,12 +929,19 @@ public class AprEndpoint extends Abstrac
return true;
}
-private void destroySocket(long socket)
-{
-if (running && socket != 0) {
-// If not running the socket will be destroyed by
-// parent pool or acceptor socket.
-// In any case disable double free which would cause JVM core.
+private void destroySocket(long socket) {
+// If not running the socket will be destroyed by
+// parent pool or acceptor socket.
+// In any case disable double free which would cause JVM core.
+destroySocket(socket, running);
+}
+
+private void destroySocket(long socket, boolean doIt) {
+// Be VERY careful if you call this method directly. If it is called
+// twice for the same socket the JVM will core. Currently this is only
+// called from Poller.closePollset() to ensure kept alive connections
+// are closed when calling stop() followed by start().
+if (doIt && socket != 0) {
Socket.destroy(socket);
countDownConnection();
}
@@ -1183,7 +1190,7 @@ public class AprEndpoint extends Abstrac
if (comet) {
processSocket(desc[n*2+1], SocketStatus.STOP);
} else {
-destroySocket(desc[n*2+1]);
+destroySocket(desc[n*2+1], true);
}
}
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1307088 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/net/AprEndpoint.java webapps/docs/changelog.xml
Author: markt
Date: Thu Mar 29 20:05:51 2012
New Revision: 1307088
URL: http://svn.apache.org/viewvc?rev=1307088&view=rev
Log:
Fix a hanging test with APR. Connections using HTTP keep-alive were not closed
on Endpoint.stop() so a stop() start() sequence meant they were kept open with
any data sent being ignored until the connection timed out.
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
Propchange: tomcat/tc7.0.x/trunk/
--
Merged /tomcat/trunk:r1307084
Modified: tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java?rev=1307088&r1=1307087&r2=1307088&view=diff
==
--- tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
(original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java Thu
Mar 29 20:05:51 2012
@@ -925,12 +925,19 @@ public class AprEndpoint extends Abstrac
return true;
}
-private void destroySocket(long socket)
-{
-if (running && socket != 0) {
-// If not running the socket will be destroyed by
-// parent pool or acceptor socket.
-// In any case disable double free which would cause JVM core.
+private void destroySocket(long socket) {
+// If not running the socket will be destroyed by
+// parent pool or acceptor socket.
+// In any case disable double free which would cause JVM core.
+destroySocket(socket, running);
+}
+
+private void destroySocket(long socket, boolean doIt) {
+// Be VERY careful if you call this method directly. If it is called
+// twice for the same socket the JVM will core. Currently this is only
+// called from Poller.closePollset() to ensure kept alive connections
+// are closed when calling stop() followed by start().
+if (doIt && socket != 0) {
Socket.destroy(socket);
countDownConnection();
}
@@ -1179,7 +1186,7 @@ public class AprEndpoint extends Abstrac
if (comet) {
processSocket(desc[n*2+1], SocketStatus.STOP);
} else {
-destroySocket(desc[n*2+1]);
+destroySocket(desc[n*2+1], true);
}
}
}
Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1307088&r1=1307087&r2=1307088&view=diff
==
--- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Thu Mar 29 20:05:51 2012
@@ -182,6 +182,12 @@
unlikely to impact normal usage but it does fix some unit test issues.
(markt)
+
+When using the APR connector ensure that any connections in a
keep-alive
+state are closed when the connector is stopped rather than when the
+connector is destroyed. This is important when stop() followed by
+start() is called on the connector. (markt)
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1307090 - /tomcat/trunk/java/org/apache/tomcat/jni/socket/AprSocket.java
Author: markt
Date: Thu Mar 29 20:11:02 2012
New Revision: 1307090
URL: http://svn.apache.org/viewvc?rev=1307090&view=rev
Log:
Return the port rather than always throwing an exception
Modified:
tomcat/trunk/java/org/apache/tomcat/jni/socket/AprSocket.java
Modified: tomcat/trunk/java/org/apache/tomcat/jni/socket/AprSocket.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/jni/socket/AprSocket.java?rev=1307090&r1=1307089&r2=1307090&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/jni/socket/AprSocket.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/jni/socket/AprSocket.java Thu Mar 29
20:11:02 2012
@@ -600,6 +600,7 @@ public class AprSocket implements Runnab
try {
long sa = Address.get(Socket.APR_LOCAL, socket);
Sockaddr addr = Address.getInfo(sa);
+return addr.port;
} catch (Exception ex) {
throw new IOException(ex);
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1307093 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java
Author: markt
Date: Thu Mar 29 20:19:18 2012
New Revision: 1307093
URL: http://svn.apache.org/viewvc?rev=1307093&view=rev
Log:
Line length
Remove unnecessary exception declaration
Remove @author tag
Modified:
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java
Modified:
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java?rev=1307093&r1=1307092&r2=1307093&view=diff
==
---
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java
(original)
+++
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java
Thu Mar 29 20:19:18 2012
@@ -20,18 +20,22 @@ import java.lang.reflect.Method;
import java.sql.SQLException;
/**
- * A DisposableConnectionFacade object is the top most interceptor that wraps
an object of type
- * {@link PooledConnection}. The ProxyCutOffConnection intercepts two methods:
+ * A DisposableConnectionFacade object is the top most interceptor that wraps
an
+ * object of type {@link PooledConnection}. The ProxyCutOffConnection
intercepts
+ * two methods:
*
- * {@link java.sql.Connection#close()} - returns the connection to the
pool then breaks the link between cutoff and the next interceptor. May be
called multiple times.
- * {@link java.lang.Object#toString()} - returns a custom string for
this object
+ * {@link java.sql.Connection#close()} - returns the connection to the
+ * pool then breaks the link between cutoff and the next interceptor.
+ * May be called multiple times.
+ * {@link java.lang.Object#toString()} - returns a custom string for this
+ * object
*
- * By default method comparisons is done on a String reference level, unless
the {@link PoolConfiguration#setUseEquals(boolean)} has been called
- * with a true argument.
- * @author Kevin Grainer
+ * By default method comparisons is done on a String reference level, unless
the
+ * {@link PoolConfiguration#setUseEquals(boolean)} has been called with a
+ * true argument.
*/
public class DisposableConnectionFacade extends JdbcInterceptor {
-protected DisposableConnectionFacade(JdbcInterceptor interceptor) throws
SQLException {
+protected DisposableConnectionFacade(JdbcInterceptor interceptor) {
setUseEquals(interceptor.isUseEquals());
setNext(interceptor);
}
@@ -41,7 +45,8 @@ public class DisposableConnectionFacade
}
@Override
-public Object invoke(Object proxy, Method method, Object[] args) throws
Throwable {
+public Object invoke(Object proxy, Method method, Object[] args)
+throws Throwable {
if (getNext()==null) {
if (compare(ISCLOSED_VAL, method)) {
return Boolean.TRUE;
@@ -61,7 +66,8 @@ public class DisposableConnectionFacade
if (compare(TOSTRING_VAL, method)) {
return "DisposableConnectionFacade[null]";
}
-throw new SQLException("PooledConnection has already been
closed.");
+throw new SQLException(
+"PooledConnection has already been closed.");
}
throw e;
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1306869 - /tomcat/taglibs/trunks/
When this "out" directory is created? It is not "target" as usually in Maven, not "output" as in Tomcat sources. Where it comes from? Just wondering. 2012/3/29 : > Author: olamy > Date: Thu Mar 29 13:50:31 2012 > New Revision: 1306869 > > URL: http://svn.apache.org/viewvc?rev=1306869&view=rev > Log: > ignore out directory > > Modified: > tomcat/taglibs/trunks/ (props changed) > > Propchange: tomcat/taglibs/trunks/ > -- > --- svn:ignore (original) > +++ svn:ignore Thu Mar 29 13:50:31 2012 > @@ -1,5 +1,6 @@ > .idea > *.iml > +out > .project > .classpath > .settings > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1307094 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DataSourceProxy.java
Author: markt
Date: Thu Mar 29 20:22:30 2012
New Revision: 1307094
URL: http://svn.apache.org/viewvc?rev=1307094&view=rev
Log:
Disable some warnings we can't do anything about
Modified:
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DataSourceProxy.java
Modified:
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DataSourceProxy.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DataSourceProxy.java?rev=1307094&r1=1307093&r2=1307094&view=diff
==
---
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DataSourceProxy.java
(original)
+++
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DataSourceProxy.java
Thu Mar 29 20:22:30 2012
@@ -61,12 +61,14 @@ public class DataSourceProxy implements
}
+@SuppressWarnings("unused") // Has to match signature in DataSource
public boolean isWrapperFor(Class iface) throws SQLException {
// we are not a wrapper of anything
return false;
}
+@SuppressWarnings("unused") // Has to match signature in DataSource
public T unwrap(Class iface) throws SQLException {
//we can't unwrap anything
return null;
@@ -175,7 +177,7 @@ public class DataSourceProxy implements
* {@link javax.sql.DataSource#getConnection()}
*/
public javax.sql.PooledConnection getPooledConnection(String username,
-String password) throws
SQLException {
+String password) throws SQLException {
return (javax.sql.PooledConnection) getConnection();
}
@@ -547,6 +549,7 @@ public class DataSourceProxy implements
* no-op
* {@link javax.sql.DataSource#getLogWriter}
*/
+@SuppressWarnings("unused") // Has to match signature in DataSource
public PrintWriter getLogWriter() throws SQLException {
return null;
}
@@ -556,6 +559,7 @@ public class DataSourceProxy implements
* no-op
* {@link javax.sql.DataSource#setLogWriter(PrintWriter)}
*/
+@SuppressWarnings("unused") // Has to match signature in DataSource
public void setLogWriter(PrintWriter out) throws SQLException {
// NOOP
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1307096 - in /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool: PoolExhaustedException.java PoolProperties.java interceptor/ConnectionState.java interceptor/Statem
Author: markt
Date: Thu Mar 29 20:31:19 2012
New Revision: 1307096
URL: http://svn.apache.org/viewvc?rev=1307096&view=rev
Log:
Fix a handful of Eclipse warnings
Modified:
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolExhaustedException.java
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/ConnectionState.java
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementDecoratorInterceptor.java
Modified:
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolExhaustedException.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolExhaustedException.java?rev=1307096&r1=1307095&r2=1307096&view=diff
==
---
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolExhaustedException.java
(original)
+++
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolExhaustedException.java
Thu Mar 29 20:31:19 2012
@@ -20,6 +20,8 @@ import java.sql.SQLException;
public class PoolExhaustedException extends SQLException {
+private static final long serialVersionUID = 3501536931777262475L;
+
public PoolExhaustedException() {
}
Modified:
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java?rev=1307096&r1=1307095&r2=1307096&view=diff
==
---
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java
(original)
+++
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java
Thu Mar 29 20:31:19 2012
@@ -35,6 +35,8 @@ import org.apache.juli.logging.LogFactor
*
*/
public class PoolProperties implements PoolConfiguration, Cloneable,
Serializable {
+
+private static final long serialVersionUID = -8519283440854213745L;
private static final Log log = LogFactory.getLog(PoolProperties.class);
public static final int DEFAULT_MAX_ACTIVE = 100;
Modified:
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/ConnectionState.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/ConnectionState.java?rev=1307096&r1=1307095&r2=1307096&view=diff
==
---
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/ConnectionState.java
(original)
+++
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/ConnectionState.java
Thu Mar 29 20:31:19 2012
@@ -131,7 +131,7 @@ public class ConnectionState extends Jdb
case 1:{result = transactionIsolation; break;}
case 2:{result = readOnly; break;}
case 3:{result = catalog; break;}
-default: result = null;
+default: // NOOP
}
//return cached result, if we have it
if (result!=null) return result;
Modified:
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementDecoratorInterceptor.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementDecoratorInterceptor.java?rev=1307096&r1=1307095&r2=1307096&view=diff
==
---
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementDecoratorInterceptor.java
(original)
+++
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementDecoratorInterceptor.java
Thu Mar 29 20:31:19 2012
@@ -160,7 +160,7 @@ public class StatementDecoratorIntercept
private Object actualProxy;
private Object connection;
private String sql;
-private Constructor constructor;
+private Constructor constructor;
public StatementProxy(T delegate, String sql) {
this.delegate = delegate;
@@ -189,10 +189,10 @@ public class StatementDecoratorIntercept
}
-public Constructor getConstructor() {
+public Constructor getConstructor() {
return constructor;
}
-public void setConstructor(Constructor constructor) {
+public void setConstructor(Constructor constructor) {
this.constructor = constructor;
}
public void closeInvoked() {
--
Re: AccessLogValve enhancement
2012/3/29 Mark Claassen : > After thinking about this some more, and deliberating on the subtle issues > that were coming up, I decided to reduce the scope of my > enhancement. I still like the idea of using a standard logger for this > logging, but for now I thought I would focus more on my > specific problem. I wrote more about this in the issue. > https://issues.apache.org/bugzilla/show_bug.cgi?id=52688 > > Is this something that could be adopted in a future 7.0 release? > To delete or otherwise rotate (move, compress, e-mail, etc.) old files - I think I would write a , or set up a shell script in cron. When logger starts to write a new file it has to do so quickly, because it happens in a synchronized block. Deleting is possible, because it is a quick operation as well. Though the tricky part is to find out what to delete. The files are named by date and they are not created unless necessary. The date format is configurable. E.g. it is possible to use it to generate different directories for different dates. IIRC JRE's java.util.logging.FileHandler can be configured to keep n old files, but it uses different naming scheme. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1306869 - /tomcat/taglibs/trunks/
intellij create that. 2012/3/29 Konstantin Kolinko : > When this "out" directory is created? > > > It is not "target" as usually in Maven, not "output" as in Tomcat > sources. Where it comes from? Just wondering. > > 2012/3/29 : >> Author: olamy >> Date: Thu Mar 29 13:50:31 2012 >> New Revision: 1306869 >> >> URL: http://svn.apache.org/viewvc?rev=1306869&view=rev >> Log: >> ignore out directory >> >> Modified: >> tomcat/taglibs/trunks/ (props changed) >> >> Propchange: tomcat/taglibs/trunks/ >> -- >> --- svn:ignore (original) >> +++ svn:ignore Thu Mar 29 13:50:31 2012 >> @@ -1,5 +1,6 @@ >> .idea >> *.iml >> +out >> .project >> .classpath >> .settings >> > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > -- Olivier Lamy Talend: http://coders.talend.com http://twitter.com/olamy | http://linkedin.com/in/olamy - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1306869 - /tomcat/taglibs/trunks/
When we use Eclipse IDE with Tomcat we configure it to use ".settings/output" as the output directory and ".settings" is already ignored. Maybe similar trick can be used here. http://svn.apache.org/viewvc/tomcat/trunk/res/ide-support/eclipse/eclipse.classpath?view=markup#l29 2012/3/30 Olivier Lamy : > intellij create that. > > 2012/3/29 Konstantin Kolinko : >> When this "out" directory is created? >> >> >> It is not "target" as usually in Maven, not "output" as in Tomcat >> sources. Where it comes from? Just wondering. >> >> 2012/3/29 : >>> Author: olamy >>> Date: Thu Mar 29 13:50:31 2012 >>> New Revision: 1306869 >>> >>> URL: http://svn.apache.org/viewvc?rev=1306869&view=rev >>> Log: >>> ignore out directory >>> >>> Modified: >>> tomcat/taglibs/trunks/ (props changed) >>> >>> Propchange: tomcat/taglibs/trunks/ >>> -- >>> --- svn:ignore (original) >>> +++ svn:ignore Thu Mar 29 13:50:31 2012 >>> @@ -1,5 +1,6 @@ >>> .idea >>> *.iml >>> +out >>> .project >>> .classpath >>> .settings >>> >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >> For additional commands, e-mail: dev-h...@tomcat.apache.org >> > > > > -- > Olivier Lamy > Talend: http://coders.talend.com > http://twitter.com/olamy | http://linkedin.com/in/olamy > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1307146 - in /tomcat/trunk: build.properties.default build.xml
Author: kkolinko
Date: Thu Mar 29 22:22:50 2012
New Revision: 1307146
URL: http://svn.apache.org/viewvc?rev=1307146&view=rev
Log:
Re: r1306716
- Fix wrong download location of npn-boot.jar
- Fix broken build.xml, as noted by Checkstyle.
I think whether we should use npn-boot.jar has to be discussed separately. I am
just fixing a broken build.
Modified:
tomcat/trunk/build.properties.default
tomcat/trunk/build.xml
Modified: tomcat/trunk/build.properties.default
URL:
http://svn.apache.org/viewvc/tomcat/trunk/build.properties.default?rev=1307146&r1=1307145&r2=1307146&view=diff
==
--- tomcat/trunk/build.properties.default (original)
+++ tomcat/trunk/build.properties.default Thu Mar 29 22:22:50 2012
@@ -131,11 +131,11 @@ jdt.jar=${jdt.home}/ecj-${jdt.version}.j
jdt.loc.1=http://archive.eclipse.org/eclipse/downloads/drops/${jdt.release}/ecj-${jdt.version}.jar
jdt.loc.2=http://download.eclipse.org/eclipse/downloads/drops/${jdt.release}/ecj-${jdt.version}.jar
-# NPN support
+# NPN support
npn.version=8.1.2.v20120308
npn.home=${base.path}/npn-${npn.version}
npn.jar=${npn.home}/npn-${npn.version}.jar
-npn.loc=http://repo2.maven.org/maven2/org/mortbay/jetty/npn/npn-api/${npn.version}/npn-boot-${npn.version}.jar
+npn.loc=http://repo2.maven.org/maven2/org/mortbay/jetty/npn/npn-boot/${npn.version}/npn-boot-${npn.version}.jar
# - Tomcat native library -
tomcat-native.version=1.1.23
Modified: tomcat/trunk/build.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/build.xml?rev=1307146&r1=1307145&r2=1307146&view=diff
==
--- tomcat/trunk/build.xml (original)
+++ tomcat/trunk/build.xml Thu Mar 29 22:22:50 2012
@@ -324,11 +324,11 @@
-
+
-
+
-
+
@@ -337,12 +337,12 @@
-
+
-
-
+
+
@@ -2350,7 +2350,7 @@ Apache Tomcat ${version} native binaries
-
+
Re: svn commit: r1307146 - in /tomcat/trunk: build.properties.default build.xml
2012/3/30 :
> Author: kkolinko
> Date: Thu Mar 29 22:22:50 2012
> New Revision: 1307146
>
> URL: http://svn.apache.org/viewvc?rev=1307146&view=rev
> Log:
> Re: r1306716
> - Fix wrong download location of npn-boot.jar
> - Fix broken build.xml, as noted by Checkstyle.
>
> I think whether we should use npn-boot.jar has to be discussed separately. I
> am just fixing a broken build.
>
> Modified:
> tomcat/trunk/build.properties.default
> tomcat/trunk/build.xml
>
> Modified: tomcat/trunk/build.properties.default
> URL:
> http://svn.apache.org/viewvc/tomcat/trunk/build.properties.default?rev=1307146&r1=1307145&r2=1307146&view=diff
> ==
> --- tomcat/trunk/build.properties.default (original)
> +++ tomcat/trunk/build.properties.default Thu Mar 29 22:22:50 2012
> @@ -131,11 +131,11 @@ jdt.jar=${jdt.home}/ecj-${jdt.version}.j
> jdt.loc.1=http://archive.eclipse.org/eclipse/downloads/drops/${jdt.release}/ecj-${jdt.version}.jar
> jdt.loc.2=http://download.eclipse.org/eclipse/downloads/drops/${jdt.release}/ecj-${jdt.version}.jar
>
> -# NPN support
> +# NPN support
> npn.version=8.1.2.v20120308
> npn.home=${base.path}/npn-${npn.version}
> npn.jar=${npn.home}/npn-${npn.version}.jar
> -npn.loc=http://repo2.maven.org/maven2/org/mortbay/jetty/npn/npn-api/${npn.version}/npn-boot-${npn.version}.jar
> +npn.loc=http://repo2.maven.org/maven2/org/mortbay/jetty/npn/npn-boot/${npn.version}/npn-boot-${npn.version}.jar
NOTE for hostname stability you can use repo.maven.apache.org (dns
entry hosted @asf)
>
> # - Tomcat native library -
> tomcat-native.version=1.1.23
>
> Modified: tomcat/trunk/build.xml
> URL:
> http://svn.apache.org/viewvc/tomcat/trunk/build.xml?rev=1307146&r1=1307145&r2=1307146&view=diff
> ==
> --- tomcat/trunk/build.xml (original)
> +++ tomcat/trunk/build.xml Thu Mar 29 22:22:50 2012
> @@ -324,11 +324,11 @@
>
>
>
> -
> +
>
> -
> +
>
> -
> +
>
>
>
> @@ -337,12 +337,12 @@
>
>
>
> -
> +
>
>
>
> -
> -
> +
> +
>
>
>
> @@ -2350,7 +2350,7 @@ Apache Tomcat ${version} native binaries
>
>
>
> -
> +
>
>
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
--
Olivier Lamy
Talend: http://coders.talend.com
http://twitter.com/olamy | http://linkedin.com/in/olamy
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
buildbot success in ASF Buildbot on tomcat-trunk
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/2913 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source Stamp: [branch tomcat/trunk] 1307146 Blamelist: kkolinko Build succeeded! sincerely, -The Buildbot
svn commit: r1307160 - in /tomcat/trunk: build.properties.default build.xml
Author: costin
Date: Thu Mar 29 23:18:34 2012
New Revision: 1307160
URL: http://svn.apache.org/viewvc?rev=1307160&view=rev
Log:
Fix npn location, make it optional
Modified:
tomcat/trunk/build.properties.default
tomcat/trunk/build.xml
Modified: tomcat/trunk/build.properties.default
URL:
http://svn.apache.org/viewvc/tomcat/trunk/build.properties.default?rev=1307160&r1=1307159&r2=1307160&view=diff
==
--- tomcat/trunk/build.properties.default (original)
+++ tomcat/trunk/build.properties.default Thu Mar 29 23:18:34 2012
@@ -135,7 +135,7 @@ jdt.loc.2=http://download.eclipse.org/ec
npn.version=8.1.2.v20120308
npn.home=${base.path}/npn-${npn.version}
npn.jar=${npn.home}/npn-${npn.version}.jar
-npn.loc=http://repo2.maven.org/maven2/org/mortbay/jetty/npn/npn-boot/${npn.version}/npn-boot-${npn.version}.jar
+npn.loc=http://repo1.maven.org/maven2/org/eclipse/jetty/npn/npn-api/${npn.version}/npn-api-${npn.version}.jar
# - Tomcat native library -
tomcat-native.version=1.1.23
Modified: tomcat/trunk/build.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/build.xml?rev=1307160&r1=1307159&r2=1307160&view=diff
==
--- tomcat/trunk/build.xml (original)
+++ tomcat/trunk/build.xml Thu Mar 29 23:18:34 2012
@@ -162,6 +162,8 @@
+
+
@@ -570,7 +572,10 @@
-->
-
+
+
+
+
@@ -2345,12 +2350,15 @@ Apache Tomcat ${version} native binaries
+
+
+
-
buildbot failure in ASF Buildbot on tomcat-trunk
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/2914 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source Stamp: [branch tomcat/trunk] 1307160 Blamelist: costin BUILD FAILED: failed compile_1 sincerely, -The Buildbot
Re: Jenkins configuration
On Mar 29, 2012, at 8:22 AM, Olivier Lamy wrote: > 2012/3/29 Jeremy Boynes : ... >> However, we are also getting errors about the effective path of parent files >> which I believe is caused because the aggregating pom in trunks is not >> actually the parent of the modules it contains. This is because the >> structure of taglibs was as four projects intended to be released >> independently (parent, standard, rdc and extended) and not intended to be >> built as one. >> > but the parent is in reactors (i.e. a module in the aggregator pom) so > not an issue. Maybe not now but it is causing Maven to warn: [WARNING] [WARNING] Some problems were encountered while building the effective model for org.apache.taglibs:taglibs-parent:pom:4-SNAPSHOT [WARNING] 'parent.relativePath' points at org.apache.tomcat.taglibs:taglibs-aggregator instead of org.apache:apache, please verify your project structure @ line 20, column 11 ... [WARNING] It is highly recommended to fix these problems because they threaten the stability of your build. [WARNING] [WARNING] For this reason, future Maven versions might no longer support building such malformed projects. [ >> I propose we keep that split in Jenkins and re-configure it into 4 projects >> matching what would be released. That would also remove the aggregator stub >> trunks. > I like the idea about building all in one shot (at least for lazy > maintenance convenience :-) ) It may be more convenient but it's not how we would do a release build. Each of those libraries has different levels of activity and would be released separately - that's what we should be building. Building them together increases the risk of unexpected cross-project issues. It's also building more than is impacted by any change. -- Jeremy - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[RESULT] Release Apache Taglibs Parent POM 3
WIth binding +1's from olamy, fhanik and mturk and my non-binding +1, I call the vote passed and will deploy the staged artefacts. Thanks Jeremy On Mar 29, 2012, at 4:55 AM, Mladen Turk wrote: > +1 > > Signatures and generic content OK > > On 03/26/2012 07:01 AM, Jeremy Boynes wrote: >> The proposed 3 release of Apache Taglibs Parent POM is now available for >> voting. >> >> Please vote on whether Apache Taglibs Parent 3 should be: >> [+1] Released, or >> [-1] Not released because ... >> > > Regards > -- > ^TM > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GUMP@vmgump]: Project tomcat-trunk-validate (in module tomcat-trunk) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-validate has an issue affecting its community integration. This issue affects 1 projects. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-trunk-validate : Tomcat 8.x, a web server implementing Java Servlet 3.1, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on checkstyle exists, no need to add for property checkstyle.jar. -INFO- Failed with reason build failed The following work was performed: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/gump_work/build_tomcat-trunk_tomcat-trunk-validate.html Work Name: build_tomcat-trunk_tomcat-trunk-validate (Type: Build) Work ended in a state of : Failed Elapsed: 30 secs Command Line: /usr/lib/jvm/java-6-openjdk/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/checkstyle-5.6-SNAPSHOT.jar -Dexecute.validate=true validate [Working Directory: /srv/gump/public/workspace/tomcat-trunk] CLASSPATH: /usr/lib/jvm/java-6-openjdk/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-5.6-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-30032012.jar:/srv/gump/public/workspace/apache-commons/cli/target/commons-cli-1.3-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/exec/target/commons-exec-1.1.1-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/validator/dist/commons-validator-30032012.jar:/srv/gump/public/workspace/junit/dist/junit-30032012.jar:/srv/gump /public/workspace/junit/dist/junit-dep-30032012.jar:/srv/gump/public/workspace/google-guava/guava/target/guava-latest.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-30032012.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-30032012.jar:/srv/gump/public/workspace/commons-collections-3.x/target/commons-collections-3.3-SNAPSHOT.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/jdom/build/jdom.jar:/srv/gump/public/workspace/velocity-engine/bin/velocity-30032012.jar:/srv/gump/public/workspace/velocity-engine/bin/velocity-30032012-dep.jar:/srv/gump/packages/javamail-1.4/mail.jar:/srv/gump/packages/javamail-1.4/lib/mailapi.jar:/srv/gump/packages/jaf-1.1ea/activation.jar - Buildfile: /srv/gump/public/workspace/tomcat-trunk/build.xml download-validate: proxyflags: setproxy: testexist: [echo] Testing for /srv/gump/public/workspace/checkstyle/target/checkstyle-5.6-SNAPSHOT.jar downloadzip: validate: [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/res/checkstyle [checkstyle] Running Checkstyle 5.6-SNAPSHOT on 2262 files [checkstyle] /srv/gump/public/workspace/tomcat-trunk/build.xml:165: Line matches the illegal pattern '\s+$'. [checkstyle] /srv/gump/public/workspace/tomcat-trunk/build.xml:165:1: File contains tab characters (this is the first instance). [checkstyle] /srv/gump/public/workspace/tomcat-trunk/build.xml:2354: Line matches the illegal pattern '\s+$'. BUILD FAILED /srv/gump/public/workspace/tomcat-trunk/build.xml:458: Got 3 errors and 0 warnings. Total time: 30 seconds - To subscribe to this information via syndicated feeds: - RSS: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/rss.xml - Atom: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/atom.xml == Gump Tracking Only === Produced by Apache Gump(TM) version 2.3. Gump Run 1230032012, vmgump.apache.org:vmgump:1230032012 Gump E-mail Identifier (unique within run) #31. -- Apache Gump http://gump.apache.org/ [Instance: vmgump] - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.or
[GUMP@vmgump]: Project tomcat-tc7.0.x-test (in module tomcat-7.0.x) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-test has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 8 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-tc7.0.x-test : Tomcat 7.x, a web server implementing Java Servlet 3.0, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on tomcat-tc7.0.x-dbcp exists, no need to add for property tomcat-dbcp-src.jar. -DEBUG- Dependency on commons-daemon exists, no need to add for property commons-daemon.native.src.tgz. -DEBUG- Dependency on commons-daemon exists, no need to add for property tomcat-native.tar.gz. -DEBUG- Dependency on tomcat-tc7.0.x-dbcp exists, no need to add for property tomcat-dbcp.home. -INFO- Failed with reason build failed -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-7.0.x/output/build/logs The following work was performed: http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-test/gump_work/build_tomcat-7.0.x_tomcat-tc7.0.x-test.html Work Name: build_tomcat-7.0.x_tomcat-tc7.0.x-test (Type: Build) Work ended in a state of : Failed Elapsed: 22 mins 16 secs Command Line: /usr/lib/jvm/java-6-openjdk/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Djunit.jar=/srv/gump/public/workspace/junit/dist/junit-30032012.jar -Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-30032012-native-src.tar.gz -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-30032012-native-src.tar.gz -Dexamples.sources.skip=true -Dtomcat-dbcp.home=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps -Djdt.jar=/srv/gump/packages/eclipse/plugins/org.eclipse.jdt.core_3.4.2/jdtcore.jar -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-30032012.jar -Dtomcat-dbcp-src.jar=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps/tomcat-dbcp-src.jar -Dtest.accesslog=true -Dcommons-pool.home=/srv/gump/public/workspace/commons-pool-1.x -Dcommons-dbcp.home=/ srv/gump/public/workspace/commons-dbcp-1.x -Dtomcat-dbcp.jar=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps/tomcat-dbcp-30032012.jar test [Working Directory: /srv/gump/public/workspace/tomcat-7.0.x] CLASSPATH: /usr/lib/jvm/java-6-openjdk/lib/tools.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-7.0.x/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/servlet-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/outp ut/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/tomcat-util.jar:/srv/gump/packages/javamail-1.4/mail.jar:/srv/gump/packages/javamail-1.4/lib/mailapi.jar:/srv/gump/packages/jaf-1.1ea/activation.jar:/srv/gump/packages/eclipse/plugins/org.eclipse.jdt.core_3.4.2/jdtcore.jar:/srv/gump/public/workspace/tomcat-7. 0.x/tomcat-deps/tomcat-dbcp-30032012.jar:/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-30032012.jar:
[GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test has an issue affecting its community integration. This issue affects 1 projects. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-trunk-test : Tomcat 8.x, a web server implementing Java Servlet 3.1, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on tomcat-trunk-dbcp exists, no need to add for property tomcat-dbcp-src.jar. -DEBUG- Dependency on commons-daemon exists, no need to add for property commons-daemon.native.src.tgz. -DEBUG- Dependency on commons-daemon exists, no need to add for property tomcat-native.tar.gz. -DEBUG- Dependency on tomcat-trunk-dbcp exists, no need to add for property tomcat-dbcp.home. -INFO- Failed with reason build failed -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-trunk/output/build/logs The following work was performed: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/gump_work/build_tomcat-trunk_tomcat-trunk-test.html Work Name: build_tomcat-trunk_tomcat-trunk-test (Type: Build) Work ended in a state of : Failed Elapsed: 13 secs Command Line: /usr/lib/jvm/java-6-openjdk/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Djunit.jar=/srv/gump/public/workspace/junit/dist/junit-30032012.jar -Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-30032012-native-src.tar.gz -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-30032012-native-src.tar.gz -Dexamples.sources.skip=true -Dtomcat-dbcp.home=/srv/gump/public/workspace/tomcat-trunk/tomcat-deps -Djdt.jar=/srv/gump/packages/eclipse/plugins/org.eclipse.jdt.core_3.4.2/jdtcore.jar -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-30032012.jar -Dtomcat-dbcp-src.jar=/srv/gump/public/workspace/tomcat-trunk/tomcat-deps/tomcat-dbcp-src.jar -Dtest.accesslog=true -Dcommons-pool.home=/srv/gump/public/workspace/commons-pool-1.x -Dcommons-dbcp.home=/ srv/gump/public/workspace/commons-dbcp-1.x -Dtomcat-dbcp.jar=/srv/gump/public/workspace/tomcat-trunk/tomcat-deps/tomcat-dbcp-30032012.jar test [Working Directory: /srv/gump/public/workspace/tomcat-trunk] CLASSPATH: /usr/lib/jvm/java-6-openjdk/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.jar:/srv/gump/public/workspace/tomcat-trunk/outp ut/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-util.jar:/srv/gump/packages/javamail-1.4/mail.jar:/srv/gump/packages/javamail-1.4/lib/mailapi.jar:/srv/gump/packages/jaf-1.1ea/activation.jar:/srv/gump/packages/eclipse/plugins/org.eclipse.jdt.core_3.4.2/jdtcore.jar:/srv/gump/public/workspace/tomcat-tr unk/tomcat-deps/tomcat-dbcp-30032012.jar:/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-30032012.jar:/srv/gump/public/workspace/junit/dist/junit-30032012.jar -
svn commit: r1307260 - /tomcat/trunk/build.xml
Author: costin
Date: Fri Mar 30 05:10:54 2012
New Revision: 1307260
URL: http://svn.apache.org/viewvc?rev=1307260&view=rev
Log:
Space police...
Modified:
tomcat/trunk/build.xml
Modified: tomcat/trunk/build.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/build.xml?rev=1307260&r1=1307259&r2=1307260&view=diff
==
--- tomcat/trunk/build.xml (original)
+++ tomcat/trunk/build.xml Fri Mar 30 05:10:54 2012
@@ -162,7 +162,7 @@
-
+
@@ -2351,7 +2351,7 @@ Apache Tomcat ${version} native binaries
-
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52318] Version in tomcat-jdbc POM is conflicted with Version in MANIFEST for JULI JAR
https://issues.apache.org/bugzilla/show_bug.cgi?id=52318 --- Comment #14 from pan4o 2012-03-30 06:31:58 UTC --- (In reply to comment #13) > .22. > > > > The fix of this issue will be than: > > tomcat-jdbc MANIFEST: > > Import-Package: org.apache.juli.logging;version="[6.0, 7.1)" > > OR may be > > Import-Package: org.apache.juli.logging;version="[6.0, 8.0)" > > > > But be careful with that version range. This means tomcat-jdbc can run with > > all > > versions in [6.0.0, 7.1.0) of tomcat-juli. > > and that is correct. it can run with all versions of 6. > so, can we get a patch or correct manifest, attached to this bug, and then we > can get that taken care of Hi Filip, how are you building your manifest files? I hope automatically? It´s enough to change the version range of tomcat-juli in the tomcat-jdbc MANIFEST. The problem is if I provide you a static correct tomcat-jdbc MANIFEST file for the version 7.0.22 ... perhaps it is not compatible with another versions of tomcat-jdbc ... should I? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
