svn commit: r1303698 - /tomcat/trunk/test/org/apache/catalina/tribes/group/TestGroupChannelSenderConnections.java
Author: markt
Date: Thu Mar 22 09:25:25 2012
New Revision: 1303698
URL: http://svn.apache.org/viewvc?rev=1303698&view=rev
Log:
Review of r1303587 by kkolinko. Ensure domain is set before channels are
started.
Modified:
tomcat/trunk/test/org/apache/catalina/tribes/group/TestGroupChannelSenderConnections.java
Modified:
tomcat/trunk/test/org/apache/catalina/tribes/group/TestGroupChannelSenderConnections.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/tribes/group/TestGroupChannelSenderConnections.java?rev=1303698&r1=1303697&r2=1303698&view=diff
==
---
tomcat/trunk/test/org/apache/catalina/tribes/group/TestGroupChannelSenderConnections.java
(original)
+++
tomcat/trunk/test/org/apache/catalina/tribes/group/TestGroupChannelSenderConnections.java
Thu Mar 22 09:25:25 2012
@@ -50,9 +50,11 @@ public class TestGroupChannelSenderConne
channels[i].getMembershipService().setPayload( ("Channel-" + (i +
1)).getBytes("ASCII"));
listeners[i] = new TestMsgListener( ("Listener-" + (i + 1)));
channels[i].addChannelListener(listeners[i]);
-channels[i].start(Channel.SND_RX_SEQ|Channel.SND_TX_SEQ);
}
TesterUtil.addRandomDomain(channels);
+for (int i = 0; i < channels.length; i++) {
+channels[i].start(Channel.SND_RX_SEQ|Channel.SND_TX_SEQ);
+}
}
public void sendMessages(long delay, long sleep) throws Exception {
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1303700 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/catalina/tribes/group/TestGroupChannelSenderConnections.java
Author: markt
Date: Thu Mar 22 09:26:08 2012
New Revision: 1303700
URL: http://svn.apache.org/viewvc?rev=1303700&view=rev
Log:
Review of r1303587 by kkolinko. Ensure domain is set before channels are
started.
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/test/org/apache/catalina/tribes/group/TestGroupChannelSenderConnections.java
Propchange: tomcat/tc7.0.x/trunk/
--
Merged /tomcat/trunk:r1303698
Modified:
tomcat/tc7.0.x/trunk/test/org/apache/catalina/tribes/group/TestGroupChannelSenderConnections.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/test/org/apache/catalina/tribes/group/TestGroupChannelSenderConnections.java?rev=1303700&r1=1303699&r2=1303700&view=diff
==
---
tomcat/tc7.0.x/trunk/test/org/apache/catalina/tribes/group/TestGroupChannelSenderConnections.java
(original)
+++
tomcat/tc7.0.x/trunk/test/org/apache/catalina/tribes/group/TestGroupChannelSenderConnections.java
Thu Mar 22 09:26:08 2012
@@ -50,9 +50,11 @@ public class TestGroupChannelSenderConne
channels[i].getMembershipService().setPayload( ("Channel-" + (i +
1)).getBytes("ASCII"));
listeners[i] = new TestMsgListener( ("Listener-" + (i + 1)));
channels[i].addChannelListener(listeners[i]);
-channels[i].start(Channel.SND_RX_SEQ|Channel.SND_TX_SEQ);
}
TesterUtil.addRandomDomain(channels);
+for (int i = 0; i < channels.length; i++) {
+channels[i].start(Channel.SND_RX_SEQ|Channel.SND_TX_SEQ);
+}
}
public void sendMessages(long delay, long sleep) throws Exception {
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Tomcat Wiki] Update of "bobbybelcher" by bobbybelcher
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "bobbybelcher" page has been changed by bobbybelcher: http://wiki.apache.org/tomcat/bobbybelcher New page: '''Grand National Tips''' Choosing the horse you want to put your Grand National bet on can be a tough one, especially if you are not a regular gambler on the horses. The favourites usually stand a good chance but every now and again the complete outsider comes in to win. Follow the below advice and you are in with a good chance to win some money. Here are a few [[http://www.grandnationalpro.com | Grand National tips]] to help you pick your horse, weight is all important. Pick a horse that weight no more than 11 stone. The only horse in history to win with a weight over that was Red Rum at 11 stone 3lbs.The range to look for is somewhere between 10st 7lbs and 11 stone. The horse should have completed and been placed in at least one of its last three races. This 3 mile steeplechase is tough on any horse and those that have not completed a 3 mile course will be unlikely to cope. Pick a horse that is nine to ten years of age, do not go lower as it has been 67 years since a 7 year old won and eight is also a little young for this type of race. Make it a British or Irish horse as they have received the specific training to handle this sort of race. Although a French horse did win in 2009 it is a rarity as they just do not have the training cope with the 3 mile race. So your tips are as follows place your bet on a nine to ten year old that weighs no more than 11 stone and has been in the top three and finished in at least one of the last three races. The last point to look for is that it is either British or Irish bred. Sometimes the rules are blown away by a rank outsider but these tips should guide you onto a good bet. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
buildbot failure in ASF Buildbot on tomcat-7-trunk
The Buildbot has detected a new failure on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/493 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source Stamp: [branch tomcat/tc7.0.x/trunk] 1303700 Blamelist: markt BUILD FAILED: failed compile_1 sincerely, -The Buildbot - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: buildbot failure in ASF Buildbot on tomcat-7-trunk
On 22/03/2012 10:04, build...@apache.org wrote: > The Buildbot has detected a new failure on builder tomcat-7-trunk while > building ASF Buildbot. > Full details are available at: > http://ci.apache.org/builders/tomcat-7-trunk/builds/493 > > Buildbot URL: http://ci.apache.org/ > > Buildslave for this Build: bb-vm_ubuntu > > Build Reason: scheduler > Build Source Stamp: [branch tomcat/tc7.0.x/trunk] 1303700 > Blamelist: markt > > BUILD FAILED: failed compile_1 > > sincerely, > -The Buildbot The failure was in: org.apache.catalina.comet.TestCometProcessor.testCometConnectorStop I have an idea of what might be going on here. I think what is happening is that a READ event is being processed at the time the connector is stopped. Because the socket is not registered for OP_READ at that point, no END event is sent during Poller#timeout(). If I am right, we need to adjust the Poller.add() methods to take this into account. This would explain why sometimes it works and sometimes it doesn't. Looking into fixing this is next on my to-do list although I might not get to it today. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat Connectors 1.2.34
On 20.03.2012 09:49, Mladen Turk wrote: Hi, Apache Tomcat Connectors 1.2.34 release candidate is ready for vote at [1]. This version solves regression(s) found in released version 1.2.33 and one long lasting IIS shared memory synchronization bug. The VOTE will remain open for at least 48 hours. The Apache Tomcat Connectors 1.2.34 is [ ] Stable, go ahead and release [ ] Broken because of ... +0. Observed problem: due to a typo in the config file (wrong name of jk status worker in a JkMount) the web server crashed during startup. Error log and possible not starting at all would be acceptable, crashing is not nice. If we were still at 1.2.32 I would be -1, but since 1.2.33 is out there and *really* broken, I'd say I'm neutral on whether this is acceptable. Stack: fe2764e4 extension_fix (1ddc00, 1dde30, 1ddde8, 1dc330, 6000, 6058) + 50 fe278354 uri_worker_map_ext (1ddc00, 1dc330, d25, fe29e120, 2, fe29e028) + d0 fe261db0 jk_post_config (8a868, 90310, 113eb0, 90310, 1d2e9b, 0) + 728 0003c90c ap_run_post_config (8a868, b8920, ba928, 90310, 1c4f70, 0) + 60 000296ac main (888f0, 8a868, 7f000, 0, ffbffb44, ffbffb54) + 62c 00028ba8 _start (0, 0, 0, 0, 0, 0) + 5c I could post details later, but I think they are not necessary for imminent release decision. Other stuff: - strange JK_REVISION, just "()". When I run the release script, the real svn revision is put into the variable. The value goes into the full exposed version. It was only introduced a few versions ago and the missing svn revision is not a real problem (as long as we don't reuse the tag). Details: - Sigs and hashes OK - key in KEYS file - gz and zip for src identical - src consistent with svn tag, except for the following minor points (no regression or fixed now) - LICENSE and NOTICE moved one directory up (OK) - KEYS not in dist (OK) - deprectated jk2 xdocs missing in dist (OK) - additional generated files in dist: aclocal.m4, configure, Makefile.in, config.h.in, html docs in docs (OK) - additional auto tool copied files in dist: install-sh, ltmain.sh, missing (OK) - build.properties.autoconf, native/build.xml and the jkant directory missing from dist. Not sure whether those still would do anything useful. Not a regression. Builds succesfully on - Solaris 8 Sparc as 32 Bit Binaries against 2.2 - Tool chain: - platform gcc except for Solaris (gcc 4.1.2 for Solaris 8) - CFLAGS: -O2 -g -Wall -fno-strict-aliasing (and -mpcu=v9 on Solaris) Rainer - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Tomcat Wiki] Update of "LocalBadContent" by KonstantinKolinko
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "LocalBadContent" page has been changed by KonstantinKolinko: http://wiki.apache.org/tomcat/LocalBadContent?action=diff&rev1=42&rev2=43 Comment: Add spam address g0g\.net google-seo-top\.com goldbetreview + grandnationalpro\.com hbgm\.cn hfire\.cn homepage\.mac\.com - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Tomcat Wiki] Update of "HowTo" by KonstantinKolinko
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "HowTo" page has been changed by KonstantinKolinko: http://wiki.apache.org/tomcat/HowTo?action=diff&rev1=115&rev2=116 Comment: Add answer on "How to create a heap dump". There is a link to on "FAQ/Troubleshooting_and_Diagnostics" page This will produce a thread dump on standard output, but may not be possible to capture to a file. + + == How do I obtain a heap dump? == + + See [[http://wiki.eclipse.org/index.php/MemoryAnalyzer#Getting_a_Heap_Dump|Getting a Heap Dump]] + on the help pages of [[http://eclipse.org/mat/|Eclipse Memory Analysis Tool]]. + + == How do I add my own custom MBean to monitor my application within Tomcat 5/6? == + First of all, you can read [[http://oss.wxnet.org/mbeans.html|this great tutorial]] from Christopher Blunck ( ch...@wxnet.org ). I will just add my comments and improvements. 1. Start your Tomcat and check that you have access to http://localhost:8080/manager/jmxproxy/. It means that JMX is enabled on your Tomcat configuration (if not, check if the following line is in your /conf/server.xml file : . Otherwise, check the Tomcat documentation to activate it). Let this page opened to check further if your custom Mbean is detected by Tomcat.<> - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1303747 - /tomcat/jk/trunk/native/common/jk_uri_worker_map.c
Author: mturk
Date: Thu Mar 22 12:22:44 2012
New Revision: 1303747
URL: http://svn.apache.org/viewvc?rev=1303747&view=rev
Log:
Fix crash in case of unknown worker
Modified:
tomcat/jk/trunk/native/common/jk_uri_worker_map.c
Modified: tomcat/jk/trunk/native/common/jk_uri_worker_map.c
URL:
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/common/jk_uri_worker_map.c?rev=1303747&r1=1303746&r2=1303747&view=diff
==
--- tomcat/jk/trunk/native/common/jk_uri_worker_map.c (original)
+++ tomcat/jk/trunk/native/common/jk_uri_worker_map.c Thu Mar 22 12:22:44 2012
@@ -554,6 +554,7 @@ void extension_fix(jk_pool_t *p, const c
jk_log(l, JK_LOG_ERROR,
"Could not find worker with name '%s' in uri map post
processing.",
name);
+return;
}
extension_fix_activation(p, name, jw, extensions, l);
if (extensions->fail_on_status_str) {
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52970] New: MethodNotFoundException when using enum as one of method arguments
https://issues.apache.org/bugzilla/show_bug.cgi?id=52970
Bug #: 52970
Summary: MethodNotFoundException when using enum as one of
method arguments
Product: Tomcat 7
Version: 7.0.26
Platform: PC
Status: NEW
Severity: normal
Priority: P2
Component: Servlet & JSP API
AssignedTo: dev@tomcat.apache.org
ReportedBy: bal...@gmail.com
Classification: Unclassified
Consider this JSF view snippet:
--
--
And this JSF bean snippet:
--
@ManagedBean
@RequestScoped
public class Bean {
public enum Type { FOO, BAR }
public void submit(Type type) {
System.out.println(type);
}
}
--
This results in a javax.el.MethodNotFoundException. It works in Glassfish 3. EL
2.2 spec 1.18.6 tells that a string must be coerced to enum of type T.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1303753 - /tomcat/jk/trunk/native/common/jk_uri_worker_map.c
Author: mturk
Date: Thu Mar 22 12:29:28 2012
New Revision: 1303753
URL: http://svn.apache.org/viewvc?rev=1303753&view=rev
Log:
Fix the code that doesn't care about errors or return parms.
Modified:
tomcat/jk/trunk/native/common/jk_uri_worker_map.c
Modified: tomcat/jk/trunk/native/common/jk_uri_worker_map.c
URL:
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/common/jk_uri_worker_map.c?rev=1303753&r1=1303752&r2=1303753&view=diff
==
--- tomcat/jk/trunk/native/common/jk_uri_worker_map.c (original)
+++ tomcat/jk/trunk/native/common/jk_uri_worker_map.c Thu Mar 22 12:29:28 2012
@@ -464,8 +464,8 @@ static void extension_fix_fail_on_status
}
-static void extension_fix_activation(jk_pool_t *p, const char *name,
jk_worker_t *jw,
- rule_extension_t *extensions,
jk_logger_t *l)
+static int extension_fix_activation(jk_pool_t *p, const char *name,
jk_worker_t *jw,
+rule_extension_t *extensions, jk_logger_t
*l)
{
JK_TRACE_ENTER(l);
@@ -487,8 +487,9 @@ static void extension_fix_activation(jk_
jk_log(l, JK_LOG_ERROR,
"can't alloc extensions activation list");
JK_TRACE_EXIT(l);
-return;
-} else if (JK_IS_DEBUG_LEVEL(l))
+return JK_FALSE;
+}
+else if (JK_IS_DEBUG_LEVEL(l))
jk_log(l, JK_LOG_DEBUG,
"Allocated activations array of size %d for lb worker
%s",
extensions->activation_size, name);
@@ -526,24 +527,24 @@ static void extension_fix_activation(jk_
}
JK_TRACE_EXIT(l);
-
+return JK_TRUE;
}
static void extension_fix_session(jk_pool_t *p, const char *name, jk_worker_t
*jw,
rule_extension_t *extensions, jk_logger_t *l)
{
-if (jw->type != JK_LB_WORKER_TYPE && extensions->session_cookie) {
-jk_log(l, JK_LOG_WARNING,
- "Worker %s is not of type lb, extension "
- JK_UWMAP_EXTENSION_SESSION_COOKIE " for %s ignored",
- name, extensions->session_cookie);
-}
-if (jw->type != JK_LB_WORKER_TYPE && extensions->session_path) {
-jk_log(l, JK_LOG_WARNING,
- "Worker %s is not of type lb, extension "
- JK_UWMAP_EXTENSION_SESSION_PATH " for %s ignored",
- name, extensions->session_path);
-}
+if (jw->type != JK_LB_WORKER_TYPE && extensions->session_cookie) {
+jk_log(l, JK_LOG_WARNING,
+"Worker %s is not of type lb, extension "
+JK_UWMAP_EXTENSION_SESSION_COOKIE " for %s ignored",
+name, extensions->session_cookie);
+}
+if (jw->type != JK_LB_WORKER_TYPE && extensions->session_path) {
+jk_log(l, JK_LOG_WARNING,
+"Worker %s is not of type lb, extension "
+JK_UWMAP_EXTENSION_SESSION_PATH " for %s ignored",
+name, extensions->session_path);
+}
}
void extension_fix(jk_pool_t *p, const char *name,
@@ -556,7 +557,8 @@ void extension_fix(jk_pool_t *p, const c
name);
return;
}
-extension_fix_activation(p, name, jw, extensions, l);
+if (!extension_fix_activation(p, name, jw, extensions, l))
+return;
if (extensions->fail_on_status_str) {
extension_fix_fail_on_status(p, name, extensions, l);
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat Connectors 1.2.34
On 03/22/2012 11:43 AM, Rainer Jung wrote: On 20.03.2012 09:49, Mladen Turk wrote: Hi, +0. Observed problem: due to a typo in the config file (wrong name of jk status worker in a JkMount) the web server crashed during startup. The fix was trivial. IMHO the entire extension_uri code is pretty unsafe. I tried to add few more checks and actually stop processing in case of error (looks like someone coded that in a hurry :) Regards -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1303755 - in /tomcat/jk/trunk: native/common/jk_version.h tools/jkrelease.sh
Author: mturk
Date: Thu Mar 22 12:39:56 2012
New Revision: 1303755
URL: http://svn.apache.org/viewvc?rev=1303755&view=rev
Log:
Axe JK_REVISION. We MUST NOT have different source in tag and release tarballs,
which this was the case.
Modified:
tomcat/jk/trunk/native/common/jk_version.h
tomcat/jk/trunk/tools/jkrelease.sh
Modified: tomcat/jk/trunk/native/common/jk_version.h
URL:
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/common/jk_version.h?rev=1303755&r1=1303754&r2=1303755&view=diff
==
--- tomcat/jk/trunk/native/common/jk_version.h (original)
+++ tomcat/jk/trunk/native/common/jk_version.h Thu Mar 22 12:39:56 2012
@@ -36,8 +36,6 @@
/* Release candidate */
#define JK_VERRC0
#define JK_RCSTRING "0"
-/* Source Control Revision as a suffix, e.g. "-r12345" */
-#define JK_REVISION ""
/** END OF AREA TO MODIFY BEFORE RELEASING */
@@ -70,7 +68,7 @@
#define JK_EXPOSED_VERSION JK_EXPOSED_VERSION_INT "-dev"
#endif
#endif
-#define JK_FULL_EXPOSED_VERSION JK_EXPOSED_VERSION JK_REVISION
+#define JK_FULL_EXPOSED_VERSION JK_EXPOSED_VERSION
#define JK_MAKEVERSION(major, minor, fix, beta) \
(((major) << 24) + ((minor) << 16) + ((fix) << 8) + (beta))
Modified: tomcat/jk/trunk/tools/jkrelease.sh
URL:
http://svn.apache.org/viewvc/tomcat/jk/trunk/tools/jkrelease.sh?rev=1303755&r1=1303754&r2=1303755&view=diff
==
--- tomcat/jk/trunk/tools/jkrelease.sh (original)
+++ tomcat/jk/trunk/tools/jkrelease.sh Thu Mar 22 12:39:56 2012
@@ -221,13 +221,6 @@ cd ${JK_DIST}.tmp/jk/xdocs
ant
cd ../../..
-# Update version information
-file=${JK_DIST}.tmp/jk/native/common/jk_version.h
-cp -p $file $file.orig
-sed -e 's/^#define JK_REVISION .*/#define JK_REVISION "'"$JK_SUFFIX"'"/' \
- $file.orig > $file
-rm $file.orig
-
# Copying things into the source distribution
copy_files ${JK_DIST}.tmp/jk $JK_DIST "$COPY_JK"
copy_files ${JK_DIST}.tmp/jk/native $JK_DIST "$COPY_NATIVE"
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52751] Optimized configuration of the system info displayed in the default error page
https://issues.apache.org/bugzilla/show_bug.cgi?id=52751 violet...@apache.org changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|WONTFIX | -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat Connectors 1.2.34
On 03/22/2012 11:43 AM, Rainer Jung wrote: On 20.03.2012 09:49, Mladen Turk wrote: Hi, - strange JK_REVISION, just "()". When I run the release script, the real svn revision is put into the variable. The value goes into the full exposed version. It was only introduced a few versions ago and the missing svn revision is not a real problem (as long as we don't reuse the tag). Remove that completely. I wasn't aware that jkrelease.sh actually modifies jk_version.sh We must have the same files as inside TAG, so if needed this hast to be done before TAG. Also from users PoV, that's useless info. We have release version and that's it. - build.properties.autoconf, native/build.xml and the jkant directory missing from dist. Not sure whether those still would do anything useful. Not a regression. Suppose we can remove those altogether. Regards -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[WITHDRAWN] Was: [VOTE] Release Apache Tomcat Connectors 1.2.34
[1] http://people.apache.org/~mturk/tomcat-connectors/jk-1.2.34/ Withdrawn because of crash in case of config typo. That's not acceptable. Will tag 1.2.35 later today. Regards -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52318] Version in tomcat-jdbc POM is conflicted with Version in MANIFEST for JULI JAR
https://issues.apache.org/bugzilla/show_bug.cgi?id=52318 --- Comment #6 from pan4o 2012-03-22 12:46:20 UTC --- [6.0.18, 7.0.0) means all versions from including 6.0.18 to except 7.0.0 - not including versions under 6.0.18 or above 7.0.0. To fix this issue, you have to change the MANIFEST: MANIFEST: org.apache.juli.logging;version="[7.0.0, 7.1.0)" OR org.apache.juli.logging;version="[7.0.0, 8.0.0)" Please refet to my last post in Bug 52381 Regards Pancho -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52381] Please add OSGi metadata
https://issues.apache.org/bugzilla/show_bug.cgi?id=52381 --- Comment #10 from pan4o 2012-03-22 12:51:21 UTC --- if you need a more detailed POM ... i will submit a complete one :) -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52381] Please add OSGi metadata
https://issues.apache.org/bugzilla/show_bug.cgi?id=52381 --- Comment #11 from Mark Thomas 2012-03-22 12:54:10 UTC --- The POM is no use since Tomcat is not built with Maven. What is required is details of what needs to go into the manifests. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Tomcat Wiki] Update of "HowTo/FasterStartUp" by KonstantinKolinko
Dear Wiki user,
You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change
notification.
The "HowTo/FasterStartUp" page has been changed by KonstantinKolinko:
http://wiki.apache.org/tomcat/HowTo/FasterStartUp?action=diff&rev1=13&rev2=14
Comment:
Add several Tomcat 7 tips to speed Tomcat start up
== Jars ==
1. Remove any jar files you don't need. When searching for classes every
JAR file needs to be examined to find the needed class. Also during webapp
startup, jar files are searched for TLD files. If the jar file is not there -
there is nothing to search.
+ 2. Tomcat 7.+: You can add jars that do not need to be scanned for TLD
files, Annotations and Web fragments to the value of
`tomcat.util.scan.DefaultJarScanner.jarsToSkip` property in
conf/catalina.properties file. Maybe later there would be a more convenient way
to configure this feature.
== Memory ==
1. Tweak memory parameters - Google is your friend.
@@ -16, +17 @@
1. Make sure your code is not doing slow things. (Use a profiler)
2. Remove any webapps you don't need. (So remove the all the webapps
installed with tomcat)
-
+ 3. Add metadata-complete="true" attribute to the element of your
WEB-INF/web.xml file, if you do not need the features that are enabled by the
default value of "false" of that attribute. This way Tomcat would not waste
time scanning the libraries to autodiscover annotated classes and web fragments.
+
+ == Starting several web applications in parallel ==
+
+ 1. With Tomcat 7.0.23+ you can configure it to start several web
applications in parallel. This is disabled by default but can be enabled by
setting the `startStopThreads` attribute of a '''Host''' to a value greater
than one.
+
+ == Entropy Source ==
+ 1. Tomcat 7+ heavily relies on !SecureRandom class to provide random values
for its session ids and in other places. Depending on your JRE it can cause
delays during startup if entropy source that is used to initialize
!SecureRandom is short of entropy. You will see warning in the logs when this
happens, e.g.:
+
+ {{{
+ org.apache.catalina.util.SessionIdGenerator createSecureRandom
+ INFO: Creation of SecureRandom instance for session ID generation using
[SHA1PRNG] took [5172] milliseconds.
+ }}}
+
+ There is a way to configure JRE to use a non-blocking entropy source by
setting the following system property: `-Djava.security.egd=file:/dev/./urandom`
+
+ Note the "`/./`" characters in the value. They are needed to work around
known [[http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6202721|JRE bug
#6202721]].
+
[[CategoryFAQ]]
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Tomcat Wiki] Trivial Update of "FAQ/Security" by KonstantinKolinko
Dear Wiki user,
You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change
notification.
The "FAQ/Security" page has been changed by KonstantinKolinko:
http://wiki.apache.org/tomcat/FAQ/Security?action=diff&rev1=12&rev2=13
Comment:
Replace 6.0 links with 7.0 ones.
<>
=== What is the default login for the manager and admin app? ===
- The admin and manager application do not provide a default login. Doing so is
a security flaw. You need to edit $CATALINA_HOME/conf/tomcat-users.xml if you
are using the default install.
[[http://tomcat.apache.org/tomcat-6.0-doc/manager-howto.html#Configuring%20Manager%20Application%20Access|Configuring
Manager Application Access]]
+ The admin and manager application do not provide a default login. Doing so is
a security flaw. You need to edit $CATALINA_HOME/conf/tomcat-users.xml if you
are using the default install.
[[http://tomcat.apache.org/tomcat-7.0-doc/manager-howto.html#Configuring%20Manager%20Application%20Access|Configuring
Manager Application Access]]
<>
=== How do I restrict access by ip address or remote host? ===
- By using the {{{RemoteHostValve}}} or {{{RemoteAddrValve}}}. Warning, these
valves rely on accurate incoming ip addresses or hostnames. So they can fall
victim to spoofing! See also {{{RemoteIpValve}}}.
[[http://tomcat.apache.org/tomcat-6.0-doc/config/valve.html|Valve Reference
Link]]
+ By using the {{{RemoteHostValve}}} or {{{RemoteAddrValve}}}. Warning, these
valves rely on accurate incoming ip addresses or hostnames. So they can fall
victim to spoofing! See also {{{RemoteIpValve}}}.
[[http://tomcat.apache.org/tomcat-7.0-doc/config/valve.html|Valve Reference
Link]]
<>
=== How do I use jsvc/procrun to run Tomcat on port 80 securely? ===
@@ -71, +71 @@
<>
=== How do I change the Server header in the response? ===
- In `server.xml` - add a "server" attribute to the Connector element.
http://tomcat.apache.org/tomcat-6.0-doc/config/http.html
+ In `server.xml` - add a "server" attribute to the Connector element.
http://tomcat.apache.org/tomcat-7.0-doc/config/http.html
<>
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1303769 - in /tomcat/jk/trunk: native/STATUS.txt native/common/jk_version.h native/configure.in tools/dist/README.html tools/dist/binaries/windows/README.html xdocs/miscellaneous/changelo
Author: mturk
Date: Thu Mar 22 13:08:33 2012
New Revision: 1303769
URL: http://svn.apache.org/viewvc?rev=1303769&view=rev
Log:
Bump the version
Modified:
tomcat/jk/trunk/native/STATUS.txt
tomcat/jk/trunk/native/common/jk_version.h
tomcat/jk/trunk/native/configure.in
tomcat/jk/trunk/tools/dist/README.html
tomcat/jk/trunk/tools/dist/binaries/windows/README.html
tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml
Modified: tomcat/jk/trunk/native/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/STATUS.txt?rev=1303769&r1=1303768&r2=1303769&view=diff
==
--- tomcat/jk/trunk/native/STATUS.txt (original)
+++ tomcat/jk/trunk/native/STATUS.txt Thu Mar 22 13:08:33 2012
@@ -18,7 +18,8 @@ Last modified at [$Date$]
Release:
-1.2.34 : current version
+1.2.35 : current version
+1.2.34 : not released
1.2.33 : released March 13, 2012
1.2.32 : released July 8, 2011
1.2.31 : released November 1, 2010
Modified: tomcat/jk/trunk/native/common/jk_version.h
URL:
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/common/jk_version.h?rev=1303769&r1=1303768&r2=1303769&view=diff
==
--- tomcat/jk/trunk/native/common/jk_version.h (original)
+++ tomcat/jk/trunk/native/common/jk_version.h Thu Mar 22 13:08:33 2012
@@ -26,7 +26,7 @@
/** START OF AREA TO MODIFY BEFORE RELEASING */
#define JK_VERMAJOR 1
#define JK_VERMINOR 2
-#define JK_VERFIX 34
+#define JK_VERFIX 35
/* set JK_VERISRELEASE to 1 when release (do not forget to commit!) */
#define JK_VERISRELEASE 1
Modified: tomcat/jk/trunk/native/configure.in
URL:
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/configure.in?rev=1303769&r1=1303768&r2=1303769&view=diff
==
--- tomcat/jk/trunk/native/configure.in (original)
+++ tomcat/jk/trunk/native/configure.in Thu Mar 22 13:08:33 2012
@@ -26,7 +26,7 @@ AC_CANONICAL_SYSTEM
dnl package and version. (synchronization with common/jk_version.h ?)
PACKAGE=mod_jk
-VERSION=1.2.34
+VERSION=1.2.35
AM_INIT_AUTOMAKE(${PACKAGE}, ${VERSION})
Modified: tomcat/jk/trunk/tools/dist/README.html
URL:
http://svn.apache.org/viewvc/tomcat/jk/trunk/tools/dist/README.html?rev=1303769&r1=1303768&r2=1303769&view=diff
==
--- tomcat/jk/trunk/tools/dist/README.html (original)
+++ tomcat/jk/trunk/tools/dist/README.html Thu Mar 22 13:08:33 2012
@@ -47,13 +47,13 @@ nearest mirror site!
% pgpk -a KEYS
-% pgpv tomcat-connectors-1.2.34-src.tar.gz.asc
+% pgpv tomcat-connectors-1.2.35-src.tar.gz.asc
or,
% pgp -ka KEYS
-% pgp tomcat-connectors-1.2.34-src.tar.gz.asc
+% pgp tomcat-connectors-1.2.35-src.tar.gz.asc
or,
% gpg --import KEYS
-% gpg --verify tomcat-connectors-1.2.34-src.tar.gz.asc
+% gpg --verify tomcat-connectors-1.2.35-src.tar.gz.asc
We offer MD5 and SHA1 hashes as an alternative to validate the integrity
Modified: tomcat/jk/trunk/tools/dist/binaries/windows/README.html
URL:
http://svn.apache.org/viewvc/tomcat/jk/trunk/tools/dist/binaries/windows/README.html?rev=1303769&r1=1303768&r2=1303769&view=diff
==
--- tomcat/jk/trunk/tools/dist/binaries/windows/README.html (original)
+++ tomcat/jk/trunk/tools/dist/binaries/windows/README.html Thu Mar 22 13:08:33
2012
@@ -35,7 +35,7 @@
connector to fail.
-The current stable release is 1.2.34
+The current stable release is 1.2.35
See the Apache Tomcat Connectors
http://tomcat.apache.org/connectors-doc/miscellaneous/changelog.html";>changelog
Modified: tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml?rev=1303769&r1=1303768&r2=1303769&view=diff
==
--- tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml (original)
+++ tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml Thu Mar 22 13:08:33 2012
@@ -40,11 +40,14 @@
new documentation project for JK was started.
-
+
+HTTPD: Fix crash on unknown worker names. (mturk)
+
+
IIS: Fix crash on worker process recycle. (mturk)
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1303772 - /tomcat/jk/trunk/native/iis/installer/isapi-redirector-win32-msi.ism
Author: mturk Date: Thu Mar 22 13:11:39 2012 New Revision: 1303772 URL: http://svn.apache.org/viewvc?rev=1303772&view=rev Log: Bump the version Modified: tomcat/jk/trunk/native/iis/installer/isapi-redirector-win32-msi.ism Modified: tomcat/jk/trunk/native/iis/installer/isapi-redirector-win32-msi.ism URL: http://svn.apache.org/viewvc/tomcat/jk/trunk/native/iis/installer/isapi-redirector-win32-msi.ism?rev=1303772&r1=1303771&r2=1303772&view=diff == --- tomcat/jk/trunk/native/iis/installer/isapi-redirector-win32-msi.ism (original) +++ tomcat/jk/trunk/native/iis/installer/isapi-redirector-win32-msi.ism Thu Mar 22 13:11:39 2012 @@ -3425,7 +3425,7 @@ TQBzAGkAAQBSAGUAbABlAGEAcwBlAA== ProductIDnone ProductLanguage1033 ProductNameTomcat Isapi Redirector - ProductVersion1.2.34 + ProductVersion1.2.35 ProgressType0install ProgressType1Installing ProgressType2installed - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1303773 - /tomcat/jk/tags/JK_1_2_35/
Author: mturk Date: Thu Mar 22 13:13:43 2012 New Revision: 1303773 URL: http://svn.apache.org/viewvc?rev=1303773&view=rev Log: Tag 1.2.35 Added: tomcat/jk/tags/JK_1_2_35/ - copied from r1303772, tomcat/jk/trunk/ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52381] Please add OSGi metadata
https://issues.apache.org/bugzilla/show_bug.cgi?id=52381 --- Comment #12 from pan4o 2012-03-22 13:18:20 UTC --- All dependencies (imports) you need in a project, should be in Import-Package: All packages you want to expose (make them public), should be in Export-Package: In the OSGI way you can expose throgh the Export-Package only that what you want to be public. In the sample MANIFEST we are exposing only our interfaces without exposing the implementation. Sooo no external package running in Karaf can access the implementation. Sample MANIFEST: Manifest-Version: 1.0 Export-Package: our.package;version="0.0.1.SNAPSHOT" Bundle-ClassPath: .,postgresql-9.0-801.jdbc4.jar,tomcat-jdbc-7.0.22.jar Built-By: hudson Tool: Bnd-1.15.0 Bundle-Name: our.package Created-By: Apache Maven Bundle Plugin Build-Jdk: 1.6.0_21 Bundle-Version: 0.0.1.SNAPSHOT Bnd-LastModified: 1330958118424 Bundle-ManifestVersion: 2 Embed-Dependency: *;artifactId=postgresql,*;artifactId=tomcat-jdbc Import-Package: org.springframework.jdbc.core.namedparam;version="[3 .0,4)",org.springframework.jdbc.core.simple;version="[3.0,4)",org.spr ingframework.jdbc.datasource;version="[3.0,4)",org.springframework.tr ansaction.annotation;version="[3.0,4)",org.w3c.dom,org.xml.sax Bundle-SymbolicName: our.package -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52751] Optimized configuration of the system info displayed in the default error page
https://issues.apache.org/bugzilla/show_bug.cgi?id=52751 --- Comment #5 from Konstantin Kolinko 2012-03-22 13:22:16 UTC --- I am OK with the patch, but there is a problem: it would not work if Tomcat is accessed through AJP protocol. The patch relies on the use of AbstractHttp11Protocol to get the "server" setting. Maybe the "server" attribute should be exposed through AbstractProtocol or Endpoint or elsewhere. I had a fear that the default value of "server" attribute which is documented to be "Apache-Coyote/1.1" will be visible here. Actually it should not be the case here. The "Apache-Coyote/1.1" string (aka Constants.SERVER_BYTES) is used by AbstractHttp11Processor only if the server attribute is null. > I would prefer to see the exact Tomcat version in the server header +1. I wonder though how coyote can get Tomcat version. Wouldn't that add an unwanted dependency between components. > particularly the line numbers in any stack trace. The stack traces can be hidden. Most error pages do not display them. One can configure a custom error page for error 500. > manipulating directly the jar file. Note, that there is no need to manipulate the jar file! One can create the following file: CATALINA_BASE/lib/org/apache/catalina/util/ServerInfo.properties (I thought it is mentioned in the FAQ, but cannot find it at this moment). It is written here: http://tomcat.apache.org/tomcat-7.0-doc/security-howto.html#Valves -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52751] Optimized configuration of the system info displayed in the default error page
https://issues.apache.org/bugzilla/show_bug.cgi?id=52751 --- Comment #6 from violet...@apache.org 2012-03-22 13:37:42 UTC --- (In reply to comment #5) > Maybe the "server" attribute should be exposed through AbstractProtocol or > Endpoint or elsewhere. I'll check that. > Note, that there is no need to manipulate the jar file! One can create the > following file: > CATALINA_BASE/lib/org/apache/catalina/util/ServerInfo.properties Unforutnately it is not so easy for us. We (Eclipse Virgo) are embeding Tomcat. Classloaders are a bit different in OSGi environment. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[VOTE] Release Apache Tomcat Connectors 1.2.35
Due to one bug that can crash httpd in case someone has typo in JkMount directive, 1.2.34 was cancelled and here is 1.2.35. The VOTE will remain open for at least 48 hours. The Apache Tomcat Connectors 1.2.35 is [ ] Stable, go ahead and release [ ] Broken because of ... [1] http://people.apache.org/~mturk/tomcat-connectors/jk-1.2.35/ Regards -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1303782 - /tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
Author: kkolinko Date: Thu Mar 22 13:50:28 2012 New Revision: 1303782 URL: http://svn.apache.org/viewvc?rev=1303782&view=rev Log: Explicitly mention the added option name. It is not really needed, but I think that so it will be easier to find it in the changelog if we are asked about this feature. The feature is Tomcat 6-specific, so there are questions why it is missing in Tomcat 7. Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml?rev=1303782&r1=1303781&r2=1303782&view=diff == --- tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml (original) +++ tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Thu Mar 22 13:50:28 2012 @@ -987,7 +987,8 @@ 49811: Add an option to disable URL rewriting on a per -Context basis. (markt) +Context basis. The option name is disableURLRewriting. +(markt) 49856: Expose the executor name for the connector via JMX. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52970] MethodNotFoundException when using enum as one of method arguments
https://issues.apache.org/bugzilla/show_bug.cgi?id=52970 Konstantin Kolinko changed: What|Removed |Added OS/Version||All --- Comment #1 from Konstantin Kolinko 2012-03-22 14:03:47 UTC --- What stacktrace is there in MethodNotFoundException? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52970] MethodNotFoundException when using enum as one of method arguments
https://issues.apache.org/bugzilla/show_bug.cgi?id=52970
--- Comment #2 from balusc 2012-03-22 14:06:13 UTC ---
Here it is:
javax.faces.el.MethodNotFoundException: javax.el.MethodNotFoundException:
/index.xhtml @15,58 action="#{bean.submit('FOO')}": Method not found:
com.example.Bean@385c1187.submit(java.lang.String)
at
javax.faces.component.MethodBindingMethodExpressionAdapter.invoke(MethodBindingMethodExpressionAdapter.java:92)
at
com.sun.faces.application.ActionListenerImpl.processAction(ActionListenerImpl.java:102)
at javax.faces.component.UICommand.broadcast(UICommand.java:315)
at javax.faces.component.UIViewRoot.broadcastEvents(UIViewRoot.java:794)
at
javax.faces.component.UIViewRoot.processApplication(UIViewRoot.java:1259)
at
com.sun.faces.lifecycle.InvokeApplicationPhase.execute(InvokeApplicationPhase.java:81)
at com.sun.faces.lifecycle.Phase.doPhase(Phase.java:101)
at com.sun.faces.lifecycle.LifecycleImpl.execute(LifecycleImpl.java:118)
at javax.faces.webapp.FacesServlet.service(FacesServlet.java:593)
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:305)
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
at
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:224)
at
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:169)
at
org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:472)
at
org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:168)
at
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:98)
at
org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:927)
at
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:118)
at
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:407)
at
org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:987)
at
org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:579)
at
org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:309)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
at java.lang.Thread.run(Thread.java:722)
Caused by: javax.el.MethodNotFoundException: /index.xhtml @15,58
action="#{bean.submit('FOO')}": Method not found:
com.example.Bean@385c1187.submit(java.lang.String)
at
com.sun.faces.facelets.el.TagMethodExpression.invoke(TagMethodExpression.java:109)
at
javax.faces.component.MethodBindingMethodExpressionAdapter.invoke(MethodBindingMethodExpressionAdapter.java:88)
... 24 more
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52970] MethodNotFoundException when using enum as one of method arguments
https://issues.apache.org/bugzilla/show_bug.cgi?id=52970 --- Comment #3 from Konstantin Kolinko 2012-03-22 14:25:10 UTC --- There is nothing in your stacktrace that comes from Tomcat EL implementation. There should be other "Caused by" somewhere further. Looking at method selection code in javax.el.BeanELResolver#invoke(..) - The "paramTypes" argument there is usually null. In that case the method is identified by the count of parameters, not by their types. If that were the case, type coercion will happen later and would not result in MethodNotFoundException. So where is it thrown from? - If the "paramTypes" argument is not-null then it will be used to select exact method. Is it your case? The requirements for BeanELResolver#invoke() API are set in EL 2.2 specification (see 2.2.9, page 38). I see no provision to respect EL coercion rules when paramTypes != null. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52970] MethodNotFoundException when using enum as one of method arguments
https://issues.apache.org/bugzilla/show_bug.cgi?id=52970 --- Comment #4 from balusc 2012-03-22 14:31:23 UTC --- It's indeed been swallowed/wrapped by Facelets. Here's the stacktrace as it is coming from `invoke()`: javax.el.MethodNotFoundException: Method not found: com.example.Bean@66a01572.submit(java.lang.String) at org.apache.el.util.ReflectionUtil.getMethod(ReflectionUtil.java:225) at org.apache.el.parser.AstValue.invoke(AstValue.java:251) at org.apache.el.MethodExpressionImpl.invoke(MethodExpressionImpl.java:278) at com.sun.faces.facelets.el.TagMethodExpression.invoke(TagMethodExpression.java:111) at javax.faces.component.MethodBindingMethodExpressionAdapter.invoke(MethodBindingMethodExpressionAdapter.java:88) at com.sun.faces.application.ActionListenerImpl.processAction(ActionListenerImpl.java:102) at javax.faces.component.UICommand.broadcast(UICommand.java:315) at javax.faces.component.UIViewRoot.broadcastEvents(UIViewRoot.java:794) at javax.faces.component.UIViewRoot.processApplication(UIViewRoot.java:1259) at com.sun.faces.lifecycle.InvokeApplicationPhase.execute(InvokeApplicationPhase.java:81) at com.sun.faces.lifecycle.Phase.doPhase(Phase.java:101) at com.sun.faces.lifecycle.LifecycleImpl.execute(LifecycleImpl.java:118) at javax.faces.webapp.FacesServlet.service(FacesServlet.java:593) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:305) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210) at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:224) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:169) at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:472) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:168) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:98) at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:927) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:118) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:407) at org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:987) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:579) at org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:309) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603) at java.lang.Thread.run(Thread.java:722) -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1303803 - /tomcat/trunk/java/org/apache/catalina/core/StandardPipeline.java
Author: markt
Date: Thu Mar 22 14:35:02 2012
New Revision: 1303803
URL: http://svn.apache.org/viewvc?rev=1303803&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52957
Ensure Valve implements Lifecycle before calling Lifecycle methods
Modified:
tomcat/trunk/java/org/apache/catalina/core/StandardPipeline.java
Modified: tomcat/trunk/java/org/apache/catalina/core/StandardPipeline.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/StandardPipeline.java?rev=1303803&r1=1303802&r2=1303803&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/StandardPipeline.java (original)
+++ tomcat/trunk/java/org/apache/catalina/core/StandardPipeline.java Thu Mar 22
14:35:02 2012
@@ -432,20 +432,20 @@ public class StandardPipeline extends Li
if (valve instanceof Contained)
((Contained) valve).setContainer(null);
-// Stop this valve if necessary
-if (getState().isAvailable()) {
-if (valve instanceof Lifecycle) {
+if (valve instanceof Lifecycle) {
+// Stop this valve if necessary
+if (getState().isAvailable()) {
try {
((Lifecycle) valve).stop();
} catch (LifecycleException e) {
log.error("StandardPipeline.removeValve: stop: ", e);
}
}
-}
-try {
-((Lifecycle) valve).destroy();
-} catch (LifecycleException e) {
-log.error("StandardPipeline.removeValve: destroy: ", e);
+try {
+((Lifecycle) valve).destroy();
+} catch (LifecycleException e) {
+log.error("StandardPipeline.removeValve: destroy: ", e);
+}
}
container.fireContainerEvent(Container.REMOVE_VALVE_EVENT, valve);
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52970] MethodNotFoundException when using enum as one of method arguments
https://issues.apache.org/bugzilla/show_bug.cgi?id=52970 --- Comment #5 from balusc 2012-03-22 14:35:56 UTC --- Indeed, the params being passed is null in Tomcat 7.0.26 while it contains the right values in Glassfish 3.x. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1303806 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/StandardPipeline.java webapps/docs/changelog.xml
Author: markt
Date: Thu Mar 22 14:37:46 2012
New Revision: 1303806
URL: http://svn.apache.org/viewvc?rev=1303806&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52957
Ensure Valve implements Lifecycle before calling Lifecycle methods
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/StandardPipeline.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
Propchange: tomcat/tc7.0.x/trunk/
--
Merged /tomcat/trunk:r1303803
Modified:
tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/StandardPipeline.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/StandardPipeline.java?rev=1303806&r1=1303805&r2=1303806&view=diff
==
--- tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/StandardPipeline.java
(original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/StandardPipeline.java
Thu Mar 22 14:37:46 2012
@@ -447,20 +447,20 @@ public class StandardPipeline extends Li
if (valve instanceof Contained)
((Contained) valve).setContainer(null);
-// Stop this valve if necessary
-if (getState().isAvailable()) {
-if (valve instanceof Lifecycle) {
+if (valve instanceof Lifecycle) {
+// Stop this valve if necessary
+if (getState().isAvailable()) {
try {
((Lifecycle) valve).stop();
} catch (LifecycleException e) {
log.error("StandardPipeline.removeValve: stop: ", e);
}
}
-}
-try {
-((Lifecycle) valve).destroy();
-} catch (LifecycleException e) {
-log.error("StandardPipeline.removeValve: destroy: ", e);
+try {
+((Lifecycle) valve).destroy();
+} catch (LifecycleException e) {
+log.error("StandardPipeline.removeValve: destroy: ", e);
+}
}
container.fireContainerEvent(Container.REMOVE_VALVE_EVENT, valve);
Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1303806&r1=1303805&r2=1303806&view=diff
==
--- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Thu Mar 22 14:37:46 2012
@@ -130,6 +130,10 @@
patch provided by Neale Rudd. (markt)
+52957: Ensure that a Valve implements Lifecycle before
+calling any Lifecycle methods on that Valve. (markt)
+
+
52958: Fix MBean descriptors for
org.apache.catalina.realm package. (markt)
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52957] ClassCastException while removing Valve
https://issues.apache.org/bugzilla/show_bug.cgi?id=52957 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||FIXED --- Comment #3 from Mark Thomas 2012-03-22 14:40:07 UTC --- Fixed in trunk and 7.0.x and will be included in 7.0.27 onwards. I went with a marginally more efficient patch. I did look more widely at where Lifecycle is used and it is essentially optional for a wide range of Components (Valve, Realm, Pipeline, Manager, Loader, etc.) I'm not against making it mandatory (neither am I strongly for it) but that is certainly a Tomcat 8 decision. If folks feel strongly about this, the dev list is the place to start the discussion. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52929] New release of mod_jk preventing chaining with mod_fcgid
https://issues.apache.org/bugzilla/show_bug.cgi?id=52929 --- Comment #1 from Konstantin Kolinko 2012-03-22 15:01:09 UTC --- Can you test with 1.2.35 release candidate? See [VOTE] thread on dev@ http://marc.info/?l=tomcat-dev&m=133242403912952&w=2 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52971] New: javax.servlet.context.tempdir return directory that do not exist, and finish with a _ underscore
https://issues.apache.org/bugzilla/show_bug.cgi?id=52971
Bug #: 52971
Summary: javax.servlet.context.tempdir return directory that do
not exist, and finish with a _ underscore
Product: Tomcat 7
Version: 7.0.12
Platform: PC
Status: NEW
Severity: normal
Priority: P2
Component: Catalina
AssignedTo: dev@tomcat.apache.org
ReportedBy: sebtar...@ncf.ca
Classification: Unclassified
servletContext.getAttribute("javax.servlet.context.tempdir") return a path that
do not exist because the end of the path finish with an underscore like
.../xyz/_
xyz exist but not _
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52971] javax.servlet.context.tempdir return directory that do not exist, and finish with a _ underscore
https://issues.apache.org/bugzilla/show_bug.cgi?id=52971 Konstantin Kolinko changed: What|Removed |Added OS/Version||All --- Comment #1 from Konstantin Kolinko 2012-03-22 15:10:58 UTC --- 1. Can you reproduce this on the up-to-date version of Tomcat 7 (7.0.26)? 2. How to reproduce this, step-by-step? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
buildbot success in ASF Buildbot on tomcat-7-trunk
The Buildbot has detected a restored build on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/494 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source Stamp: [branch tomcat/tc7.0.x/trunk] 1303806 Blamelist: markt Build succeeded! sincerely, -The Buildbot
DO NOT REPLY [Bug 52929] New release of mod_jk preventing chaining with mod_fcgid
https://issues.apache.org/bugzilla/show_bug.cgi?id=52929 Mladen Turk changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WONTFIX --- Comment #2 from Mladen Turk 2012-03-22 15:15:56 UTC --- 1.2.33 is broken. See the notice on stability issue http://tomcat.apache.org/connectors-doc/ We are in VOTE process for 1.2.35 so should be released in couple of days. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52929] New release of mod_jk preventing chaining with mod_fcgid
https://issues.apache.org/bugzilla/show_bug.cgi?id=52929 a...@corelius.net changed: What|Removed |Added Resolution|WONTFIX |FIXED --- Comment #3 from a...@corelius.net 2012-03-22 15:22:09 UTC --- Tested with 1.2.35 release candidate. Problem solved. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1303852 - /tomcat/trunk/webapps/ROOT/index.jsp
Author: kkolinko
Date: Thu Mar 22 15:48:37 2012
New Revision: 1303852
URL: http://svn.apache.org/viewvc?rev=1303852&view=rev
Log:
Replace two examples links in ROOT/index.jsp with one.
This is to make WebSocket examples more visible.
Modified:
tomcat/trunk/webapps/ROOT/index.jsp
Modified: tomcat/trunk/webapps/ROOT/index.jsp
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/ROOT/index.jsp?rev=1303852&r1=1303851&r2=1303852&view=diff
==
--- tomcat/trunk/webapps/ROOT/index.jsp (original)
+++ tomcat/trunk/webapps/ROOT/index.jsp Thu Mar 22 15:48:37 2012
@@ -91,8 +91,7 @@ request.setAttribute("tomcat7ExamplesUrl
-Servlet
Examples
-JSP
Examples
+Examples
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1303853 - in /tomcat/tc7.0.x/trunk: ./ webapps/ROOT/index.jsp
Author: kkolinko
Date: Thu Mar 22 15:50:45 2012
New Revision: 1303853
URL: http://svn.apache.org/viewvc?rev=1303853&view=rev
Log:
Merged revision 1303852 from tomcat/trunk:
Replace two examples links in ROOT/index.jsp with one.
This is to make WebSocket examples more visible.
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/webapps/ROOT/index.jsp
Propchange: tomcat/tc7.0.x/trunk/
--
Merged /tomcat/trunk:r1303852
Modified: tomcat/tc7.0.x/trunk/webapps/ROOT/index.jsp
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/ROOT/index.jsp?rev=1303853&r1=1303852&r2=1303853&view=diff
==
--- tomcat/tc7.0.x/trunk/webapps/ROOT/index.jsp (original)
+++ tomcat/tc7.0.x/trunk/webapps/ROOT/index.jsp Thu Mar 22 15:50:45 2012
@@ -91,8 +91,7 @@ request.setAttribute("tomcat7ExamplesUrl
-Servlet
Examples
-JSP
Examples
+Examples
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat Connectors 1.2.35
On 03/22/2012 02:46 PM, Mladen Turk wrote: The VOTE will remain open for at least 48 hours. The Apache Tomcat Connectors 1.2.35 is [X] Stable, go ahead and release [ ] Broken because of ... My vote. Since we already gathered enough votes for 1.2.34 and this version only fixes user config typo (no other functional change) think we can even close the vote before 48-hours time frame (given we collect two more +1s of course :) Regards -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
RE: [VOTE] Release Apache Tomcat Connectors 1.2.35
[X] Stable, go ahead and release > -Original Message- > From: Mladen Turk [mailto:mt...@apache.org] > Sent: Thursday, March 22, 2012 10:50 AM > To: Tomcat Developers List > Subject: Re: [VOTE] Release Apache Tomcat Connectors 1.2.35 > > On 03/22/2012 02:46 PM, Mladen Turk wrote: > > > > The VOTE will remain open for at least 48 hours. > > > > The Apache Tomcat Connectors 1.2.35 is > > [X] Stable, go ahead and release > > [ ] Broken because of ... > > > > > > My vote. > > Since we already gathered enough votes for 1.2.34 > and this version only fixes user config typo (no other functional change) > think we can even close the vote before 48-hours time frame > (given we collect two more +1s of course :) > > > > Regards > -- > ^TM > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
RE: svn commit: r1303082 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolExhaustedException.java
On windows, it wasn't picking up ~/.subversion/config but ~/AppData/Roaming/Subversion/config Filip > -Original Message- > From: Filip Hanik (mailing lists) [mailto:devli...@hanik.com] > Sent: Wednesday, March 21, 2012 6:17 PM > To: 'Tomcat Developers List' > Subject: RE: svn commit: r1303082 - /tomcat/trunk/modules/jdbc- > pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolExhaustedException. > java > > I got all that setup, it's not picking up my home directory, I will check to > see what it is looking for > > > -Original Message- > > From: Konstantin Kolinko [mailto:knst.koli...@gmail.com] > > Sent: Wednesday, March 21, 2012 4:26 PM > > To: Tomcat Developers List > > Subject: Re: svn commit: r1303082 - /tomcat/trunk/modules/jdbc- > > > pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolExhaustedException. > > java > > > > 2012/3/20 Filip Hanik (mailing lists) : > > > I need to investigate this, and why my config file is not being picked > up by > > subversion > > > > > > > Maybe you do not have this setting: > > > > [miscellany] > > enable-auto-props = yes > > > > in the file named "config" in Subversion configuration area. [1] > > The default value of it is "no". > > > > [1] http://svnbook.red-bean.com/en/1.7/svn.advanced.confarea.html > > > > > > > Best > > > Filip > > > > > >> -Original Message- > > >> From: kkoli...@apache.org [mailto:kkoli...@apache.org] > > >> Sent: Tuesday, March 20, 2012 12:39 PM > > >> To: dev@tomcat.apache.org > > >> Subject: svn commit: r1303082 - /tomcat/trunk/modules/jdbc- > > >> > > > pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolExhaustedException. > > >> java > > >> > > >> Author: kkolinko > > >> Date: Tue Mar 20 18:39:28 2012 > > >> New Revision: 1303082 > > >> > > >> URL: http://svn.apache.org/viewvc?rev=1303082&view=rev > > >> Log: > > >> svn:eol-style = native > > >> > > >> (...) > > >> > > > > Best regards, > > Konstantin Kolinko > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > > For additional commands, e-mail: dev-h...@tomcat.apache.org > > > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52957] ClassCastException while removing Valve
https://issues.apache.org/bugzilla/show_bug.cgi?id=52957 --- Comment #4 from violet...@apache.org 2012-03-22 19:10:57 UTC --- Thanks -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1304011 - /tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
Author: markt
Date: Thu Mar 22 19:47:58 2012
New Revision: 1304011
URL: http://svn.apache.org/viewvc?rev=1304011&view=rev
Log:
Still process events when closing to ensure that Comet connections that are in
use when the poller is stopped are sent an end event.
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
Modified: tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java?rev=1304011&r1=1304010&r2=1304011&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java Thu Mar 22
19:47:58 2012
@@ -963,7 +963,6 @@ public class NioEndpoint extends Abstrac
// exit, otherwise parallel closure of sockets which are still
// in the poller can cause problems
close = true;
-events.clear();
selector.wakeup();
}
@@ -998,6 +997,9 @@ public class NioEndpoint extends Abstrac
if ( r==null) r = new PollerEvent(socket,null,interestOps);
else r.reset(socket,null,interestOps);
addEvent(r);
+if (close) {
+processSocket(socket, SocketStatus.STOP, false);
+}
}
/**
@@ -1113,12 +1115,15 @@ public class NioEndpoint extends Abstrac
}
}
-boolean hasEvents = events();
+boolean hasEvents = false;
// Time to terminate?
if (close) {
+events();
timeout(0, false);
break;
+} else {
+hasEvents = events();
}
try {
if ( !close ) {
@@ -1132,6 +1137,7 @@ public class NioEndpoint extends Abstrac
wakeupCounter.set(0);
}
if (close) {
+events();
timeout(0, false);
selector.close();
break;
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1304012 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/net/NioEndpoint.java
Author: markt
Date: Thu Mar 22 19:48:52 2012
New Revision: 1304012
URL: http://svn.apache.org/viewvc?rev=1304012&view=rev
Log:
Still process events when closing to ensure that Comet connections that are in
use when the poller is stopped are sent an end event.
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
Propchange: tomcat/tc7.0.x/trunk/
--
Merged /tomcat/trunk:r1304011
Modified: tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java?rev=1304012&r1=1304011&r2=1304012&view=diff
==
--- tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
(original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java Thu
Mar 22 19:48:52 2012
@@ -963,7 +963,6 @@ public class NioEndpoint extends Abstrac
// exit, otherwise parallel closure of sockets which are still
// in the poller can cause problems
close = true;
-events.clear();
selector.wakeup();
}
@@ -998,6 +997,9 @@ public class NioEndpoint extends Abstrac
if ( r==null) r = new PollerEvent(socket,null,interestOps);
else r.reset(socket,null,interestOps);
addEvent(r);
+if (close) {
+processSocket(socket, SocketStatus.STOP, false);
+}
}
/**
@@ -1114,12 +1116,15 @@ public class NioEndpoint extends Abstrac
}
}
-boolean hasEvents = events();
+boolean hasEvents = false;
// Time to terminate?
if (close) {
+events();
timeout(0, false);
break;
+} else {
+hasEvents = events();
}
try {
if ( !close ) {
@@ -1133,6 +1138,7 @@ public class NioEndpoint extends Abstrac
wakeupCounter.set(0);
}
if (close) {
+events();
timeout(0, false);
selector.close();
break;
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1304011 - /tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
On 22/03/2012 19:47, ma...@apache.org wrote: > Author: markt > Date: Thu Mar 22 19:47:58 2012 > New Revision: 1304011 > > URL: http://svn.apache.org/viewvc?rev=1304011&view=rev > Log: > Still process events when closing to ensure that Comet connections that are > in use when the poller is stopped are sent an end event. I am hopeful this will fix the random failures we have been seeing with the unit tests. I was confident enough with this patch to port it to 7.0.x but Filip (or anyone else that understands the NIO code better than I do) if you have a chance it would be worth you looking it over to see if there is a better way to achieve what I was trying to do. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1302649 - /tomcat/trunk/java/org/apache/catalina/startup/Catalina.java
Chuck, On 3/19/12 9:53 PM, Caldarale, Charles R wrote: >> From: Christopher Schultz [mailto:ch...@christopherschultz.net] >> Subject: Re: svn commit: r1302649 - >> /tomcat/trunk/java/org/apache/catalina/startup/Catalina.java > >> There seems to be a difference between "system" and "bootstrap" but >> it's not evident merely from reading the javadoc. > > The bootstrap classloader (aka null or primordial classloader) is the > one the JVM uses to load the standard JRE classes - the ones in > rt.jar and a few other places; it cannot be overridden. The system > classloader is the one that handles the classpath setting, and can be > specified by system property if you don't want the default behavior. > The parent of all classloaders is eventually the bootstrap > classloader, simply because that's what you get when the classloader > reference is null. > >> In this case, system ~= bootstrap > > I have no idea what "~=" means, but it is never true that the system > classloader is the same as the bootstrap classloader. Yeah, I meant that this code uses "null" to mean "parent is the system ClassLoader" while the documentation for ClassLoader says that "null" means "parent is the bootstrap ClassLoader". The behavior established by this commit would be surprising to me given the javadocs. -chris signature.asc Description: OpenPGP digital signature
DO NOT REPLY [Bug 51966] Tomcat does not support ssha hashed passwords in all contexts
https://issues.apache.org/bugzilla/show_bug.cgi?id=51966 --- Comment #9 from Christopher Schultz 2012-03-22 20:22:45 UTC --- I recently added the capability to use salted and iterated hashes to my own DataSourceRealm -- but it's been diverging from TC's realms for quite a while. Mine does not use $ to separate the salt from the hash, so that essentially fixes my salt-length in stone. I might want to change my implementation ;) I'd be happy to share my code with the community, but either I or someone else will have to do some heavy work on it to get it to fit-in with the current Realm code in Tomcat. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1304035 - /tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java
Author: markt
Date: Thu Mar 22 20:31:56 2012
New Revision: 1304035
URL: http://svn.apache.org/viewvc?rev=1304035&view=rev
Log:
Only try to stop children that are currently started. Prevents error messages
appearing in logs.
Modified:
tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java
Modified: tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java?rev=1304035&r1=1304034&r2=1304035&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java (original)
+++ tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java Thu Mar 22
20:31:56 2012
@@ -1590,7 +1590,9 @@ public abstract class ContainerBase exte
@Override
public Void call() throws LifecycleException {
-child.stop();
+if (child.getState().isAvailable()) {
+child.stop();
+}
return null;
}
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1304037 - /tomcat/trunk/test/org/apache/catalina/loader/TestWebappClassLoaderExecutorMemoryLeak.java
Author: markt
Date: Thu Mar 22 20:32:41 2012
New Revision: 1304037
URL: http://svn.apache.org/viewvc?rev=1304037&view=rev
Log:
Observed strange NPE while running tests. This isn't much more than a guess at
what might have caused it.
Modified:
tomcat/trunk/test/org/apache/catalina/loader/TestWebappClassLoaderExecutorMemoryLeak.java
Modified:
tomcat/trunk/test/org/apache/catalina/loader/TestWebappClassLoaderExecutorMemoryLeak.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/loader/TestWebappClassLoaderExecutorMemoryLeak.java?rev=1304037&r1=1304036&r2=1304037&view=diff
==
---
tomcat/trunk/test/org/apache/catalina/loader/TestWebappClassLoaderExecutorMemoryLeak.java
(original)
+++
tomcat/trunk/test/org/apache/catalina/loader/TestWebappClassLoaderExecutorMemoryLeak.java
Thu Mar 22 20:32:41 2012
@@ -49,7 +49,8 @@ public class TestWebappClassLoaderExecut
((StandardContext) ctx).setClearReferencesStopThreads(true);
}
-Tomcat.addServlet(ctx, "taskServlet", new ExecutorServlet());
+ExecutorServlet executorServlet = new ExecutorServlet();
+Tomcat.addServlet(ctx, "taskServlet", executorServlet);
ctx.addServletMapping("/", "taskServlet");
tomcat.start();
@@ -67,8 +68,8 @@ public class TestWebappClassLoaderExecut
// ignore
}
-Assert.assertTrue(ExecutorServlet.tpe.isShutdown());
-Assert.assertTrue(ExecutorServlet.tpe.isTerminated());
+Assert.assertTrue(executorServlet.tpe.isShutdown());
+Assert.assertTrue(executorServlet.tpe.isTerminated());
}
static class ExecutorServlet extends HttpServlet {
@@ -79,7 +80,7 @@ public class TestWebappClassLoaderExecut
long n = 1000L;
int tpSize = 10;
-public static ThreadPoolExecutor tpe;
+public volatile ThreadPoolExecutor tpe;
@Override
protected void doGet(HttpServletRequest req, HttpServletResponse resp)
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1304038 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/ContainerBase.java test/org/apache/catalina/loader/TestWebappClassLoaderExecutorMemoryLeak.java
Author: markt
Date: Thu Mar 22 20:33:22 2012
New Revision: 1304038
URL: http://svn.apache.org/viewvc?rev=1304038&view=rev
Log:
Only try to stop children that are currently started. Prevents error messages
appearing in logs.
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/ContainerBase.java
tomcat/tc7.0.x/trunk/test/org/apache/catalina/loader/TestWebappClassLoaderExecutorMemoryLeak.java
Propchange: tomcat/tc7.0.x/trunk/
--
Merged /tomcat/trunk:r1304035
Modified: tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/ContainerBase.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/ContainerBase.java?rev=1304038&r1=1304037&r2=1304038&view=diff
==
--- tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/ContainerBase.java
(original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/ContainerBase.java Thu
Mar 22 20:33:22 2012
@@ -1578,7 +1578,9 @@ public abstract class ContainerBase exte
@Override
public Void call() throws LifecycleException {
-child.stop();
+if (child.getState().isAvailable()) {
+child.stop();
+}
return null;
}
}
Modified:
tomcat/tc7.0.x/trunk/test/org/apache/catalina/loader/TestWebappClassLoaderExecutorMemoryLeak.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/test/org/apache/catalina/loader/TestWebappClassLoaderExecutorMemoryLeak.java?rev=1304038&r1=1304037&r2=1304038&view=diff
==
---
tomcat/tc7.0.x/trunk/test/org/apache/catalina/loader/TestWebappClassLoaderExecutorMemoryLeak.java
(original)
+++
tomcat/tc7.0.x/trunk/test/org/apache/catalina/loader/TestWebappClassLoaderExecutorMemoryLeak.java
Thu Mar 22 20:33:22 2012
@@ -49,7 +49,8 @@ public class TestWebappClassLoaderExecut
((StandardContext) ctx).setClearReferencesStopThreads(true);
}
-Tomcat.addServlet(ctx, "taskServlet", new ExecutorServlet());
+ExecutorServlet executorServlet = new ExecutorServlet();
+Tomcat.addServlet(ctx, "taskServlet", executorServlet);
ctx.addServletMapping("/", "taskServlet");
tomcat.start();
@@ -67,8 +68,8 @@ public class TestWebappClassLoaderExecut
// ignore
}
-Assert.assertTrue(ExecutorServlet.tpe.isShutdown());
-Assert.assertTrue(ExecutorServlet.tpe.isTerminated());
+Assert.assertTrue(executorServlet.tpe.isShutdown());
+Assert.assertTrue(executorServlet.tpe.isTerminated());
}
static class ExecutorServlet extends HttpServlet {
@@ -79,7 +80,7 @@ public class TestWebappClassLoaderExecut
long n = 1000L;
int tpSize = 10;
-public static ThreadPoolExecutor tpe;
+public volatile ThreadPoolExecutor tpe;
@Override
protected void doGet(HttpServletRequest req, HttpServletResponse resp)
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1304040 - /tomcat/tc7.0.x/trunk/
Author: markt Date: Thu Mar 22 20:33:54 2012 New Revision: 1304040 URL: http://svn.apache.org/viewvc?rev=1304040&view=rev Log: Observed strange NPE while running tests. This isn't much more than a guess at what might have caused it. Modified: tomcat/tc7.0.x/trunk/ (props changed) Propchange: tomcat/tc7.0.x/trunk/ -- Merged /tomcat/trunk:r1304037 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1304040 - /tomcat/tc7.0.x/trunk/
On 22/03/2012 20:33, ma...@apache.org wrote: > Author: markt > Date: Thu Mar 22 20:33:54 2012 > New Revision: 1304040 > > URL: http://svn.apache.org/viewvc?rev=1304040&view=rev > Log: > Observed strange NPE while running tests. This isn't much more than a guess > at what might have caused it. > > Modified: > tomcat/tc7.0.x/trunk/ (props changed) > > Propchange: tomcat/tc7.0.x/trunk/ > -- > Merged /tomcat/trunk:r1304037 Grr. Actual change was in r 1304038 Sorry. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52974] New: NameNotFoundException is thrown when field/method is annotated with @Resource annotation
https://issues.apache.org/bugzilla/show_bug.cgi?id=52974 Bug #: 52974 Summary: NameNotFoundException is thrown when field/method is annotated with @Resource annotation Product: Tomcat 7 Version: 7.0.26 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P2 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: violet...@apache.org Classification: Unclassified Created attachment 28500 --> https://issues.apache.org/bugzilla/attachment.cgi?id=28500 Patch proposal Hi, I have a web application (attached) that has a Servlet with an annotated (@Resource) field and an annotated (@Resource) method. When I request the Servlet I'm receiving: javax.naming.NameNotFoundException: Name test.TestServlet is not bound in this Context org.apache.naming.NamingContext.lookup(NamingContext.java:820) org.apache.naming.NamingContext.lookup(NamingContext.java:168) org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:472) org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:98) I searched the sources and found that org.apache.catalina.startup.WebAnnotationSet processes and prepares for binding only @Resource annotation on a class level. However org.apache.catalina.core.DefaultInstanceManager tries to process @Resource annotation on field/method level and to inject the necessary Object. Unfortunately as the information is not processed and bound in the naming previously, NameNotFoundException is thrown. I would like to propose a patch (attached). I'm looking forward to your comments. Thanks in advance. Regards Violeta Georgieva Steps to reproduce the issue: 1. Deploy the attached web application 2. Request http://localhost:8080/test/TestServlet 3. NameNotFoundException is thrown 4. Apply the patch and restart Tomcat 5. Request http://localhost:8080/test/TestServlet 6. You should see in the browser "Annotated field: test Annotated method: test1" -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52974] NameNotFoundException is thrown when field/method is annotated with @Resource annotation
https://issues.apache.org/bugzilla/show_bug.cgi?id=52974 violet...@apache.org changed: What|Removed |Added Attachment #28500|0 |1 is patch|| Attachment #28500|application/octet-stream|text/plain mime type|| -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52974] NameNotFoundException is thrown when field/method is annotated with @Resource annotation
https://issues.apache.org/bugzilla/show_bug.cgi?id=52974 --- Comment #1 from violet...@apache.org 2012-03-22 20:45:03 UTC --- Created attachment 28501 --> https://issues.apache.org/bugzilla/attachment.cgi?id=28501 Sample application -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1304060 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: schultz Date: Thu Mar 22 21:04:23 2012 New Revision: 1304060 URL: http://svn.apache.org/viewvc?rev=1304060&view=rev Log: Updated patch list for backporting fix for BZ 52500 Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1304060&r1=1304059&r2=1304060&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Mar 22 21:04:23 2012 @@ -109,6 +109,10 @@ PATCHES PROPOSED TO BACKPORT: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52500 Add configurable mechanism to retrieve user names from X509 client certificates. trunk patch: http://svn.apache.org/viewvc?view=revision&revision=r1298476 + additional clean-up patches (good for markt?): + http://svn.apache.org/viewvc?view=revision&revision=r1298542 + http://svn.apache.org/viewvc?view=revision&revision=r1298577 + http://svn.apache.org/viewvc?view=revision&revision=r1298590 +1: schultz, fhanik +1: markt if clean-up is also applied -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat Connectors 1.2.35
Mladen, On 3/22/12 9:46 AM, Mladen Turk wrote: > The Apache Tomcat Connectors 1.2.35 is > [X] Stable, go ahead and release Works remarkably better than 1.2.33 ;) Smoke test on Linux x64 seems all is well. -chris signature.asc Description: OpenPGP digital signature
Re: svn commit: r1304011 - /tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
2012/3/22 :
> Author: markt
> Date: Thu Mar 22 19:47:58 2012
> New Revision: 1304011
>
> URL: http://svn.apache.org/viewvc?rev=1304011&view=rev
> Log:
> Still process events when closing to ensure that Comet connections that are
> in use when the poller is stopped are sent an end event.
>
> Modified:
> tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
>
> Modified: tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
> URL:
> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java?rev=1304011&r1=1304010&r2=1304011&view=diff
> ==
> --- tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java (original)
> +++ tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java Thu Mar 22
> 19:47:58 2012
> @@ -963,7 +963,6 @@ public class NioEndpoint extends Abstrac
> // exit, otherwise parallel closure of sockets which are still
> // in the poller can cause problems
> close = true;
> - events.clear();
> selector.wakeup();
> }
>
> @@ -998,6 +997,9 @@ public class NioEndpoint extends Abstrac
> if ( r==null) r = new PollerEvent(socket,null,interestOps);
> else r.reset(socket,null,interestOps);
> addEvent(r);
> + if (close) {
> + processSocket(socket, SocketStatus.STOP, false);
> + }
> }
>
> /**
> @@ -1113,12 +1115,15 @@ public class NioEndpoint extends Abstrac
> }
> }
>
> - boolean hasEvents = events();
> + boolean hasEvents = false;
>
> // Time to terminate?
> if (close) {
(1)
> + events();
> timeout(0, false);
> break;
> + } else {
> + hasEvents = events();
> }
> try {
> if ( !close ) {
> @@ -1132,6 +1137,7 @@ public class NioEndpoint extends Abstrac
> wakeupCounter.set(0);
> }
> if (close) {
(2)
> + events();
> timeout(0, false);
> selector.close();
> break;
>
Comparing (1) and (2),
both are terminating the loop, but the (2)nd block has
"selector.close()" call and (1)st does not have the call. I suspect
that both should have the close() call.
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1304135 - /tomcat/trunk/webapps/examples/websocket/echo.html
Author: kkolinko
Date: Thu Mar 22 23:36:47 2012
New Revision: 1304135
URL: http://svn.apache.org/viewvc?rev=1304135&view=rev
Log:
In "echo" websocket example: Treat the text typed by user and echoed by server
as plain text instead of HTML, effectively safe-guarding it.
Just noting that "chat" example is different and safe-guards at the server side.
Modified:
tomcat/trunk/webapps/examples/websocket/echo.html
Modified: tomcat/trunk/webapps/examples/websocket/echo.html
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/examples/websocket/echo.html?rev=1304135&r1=1304134&r2=1304135&view=diff
==
--- tomcat/trunk/webapps/examples/websocket/echo.html (original)
+++ tomcat/trunk/webapps/examples/websocket/echo.html Thu Mar 22 23:36:47 2012
@@ -111,7 +111,7 @@
var console = document.getElementById('console');
var p = document.createElement('p');
p.style.wordWrap = 'break-word';
-p.innerHTML = message;
+p.appendChild(document.createTextNode(message));
console.appendChild(p);
while (console.childNodes.length > 25) {
console.removeChild(console.firstChild);
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1304136 - in /tomcat/tc7.0.x/trunk: ./ webapps/examples/websocket/echo.html
Author: kkolinko
Date: Thu Mar 22 23:38:27 2012
New Revision: 1304136
URL: http://svn.apache.org/viewvc?rev=1304136&view=rev
Log:
Merged revision 1304135 from tomcat/trunk:
In "echo" websocket example: Treat the text typed by user and echoed by server
as plain text instead of HTML, effectively safe-guarding it.
Just noting that "chat" example is different and safe-guards at the server side.
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/webapps/examples/websocket/echo.html
Propchange: tomcat/tc7.0.x/trunk/
--
Merged /tomcat/trunk:r1304135
Modified: tomcat/tc7.0.x/trunk/webapps/examples/websocket/echo.html
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/examples/websocket/echo.html?rev=1304136&r1=1304135&r2=1304136&view=diff
==
--- tomcat/tc7.0.x/trunk/webapps/examples/websocket/echo.html (original)
+++ tomcat/tc7.0.x/trunk/webapps/examples/websocket/echo.html Thu Mar 22
23:38:27 2012
@@ -111,7 +111,7 @@
var console = document.getElementById('console');
var p = document.createElement('p');
p.style.wordWrap = 'break-word';
-p.innerHTML = message;
+p.appendChild(document.createTextNode(message));
console.appendChild(p);
while (console.childNodes.length > 25) {
console.removeChild(console.firstChild);
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1304145 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: kkolinko Date: Fri Mar 23 00:16:59 2012 New Revision: 1304145 URL: http://svn.apache.org/viewvc?rev=1304145&view=rev Log: Correct Mark's proposal. The proposed revisions were the same change in tc7 vs trunk. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1304145&r1=1304144&r2=1304145&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Fri Mar 23 00:16:59 2012 @@ -137,8 +137,9 @@ PATCHES PROPOSED TO BACKPORT: * https://issues.apache.org/bugzilla/show_bug.cgi?id=52811 Fix parsing of Content-Type - http://svn.apache.org/viewvc?rev=1300155&view=rev (new HTTP header parser) - http://svn.apache.org/viewvc?rev=1300161&view=rev (the actual fix) + http://svn.apache.org/viewvc?rev=1300154&view=rev (new HTTP header parser) + http://svn.apache.org/viewvc?rev=1300155&view=rev (the actual fix) + (=r1300157+r1300161 in TC7) +1: markt 0: fhanik - introducing a new parser this late into a release seems too risky for 6 -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1300154 [1/2] - in /tomcat/trunk: ./ java/org/apache/coyote/ java/org/apache/tomcat/util/http/parser/ test/org/apache/tomcat/util/http/parser/
2012/3/13 :
> Author: markt
> Date: Tue Mar 13 14:39:24 2012
> New Revision: 1300154
>
> URL: http://svn.apache.org/viewvc?rev=1300154&view=rev
> Log:
> Add an HTTP header parser. The driver for this was an attempt to fix
> https://issues.apache.org/bugzilla/show_bug.cgi?id=52811
>
> Parsing HTTP headers as per RFC2616 is not always as simple as it first
> appears. For headers that only use tokens the simple approach will normally
> be sufficient. However, for the other headers, while simple code meets 99.9%
> of cases, there are often some edge cases that make things far more
> complicated.
>
> The purpose of this parser is to let the parser worry about the edge cases.
> It provides strict parsing of HTTP header values assuming that wrapped header
> lines have already been unwrapped. (The Tomcat header processing code does
> the unwrapping.)
>
> The parser currently supports parsing of the following HTTP header values as
> per RFC 2616:
> - Content-Type
>
> Support for additional headers will be provided as required. A quick scan of
> the Tomcat code base suggested a couple of places where using this parser may
> be useful such as Ranges in the default servlet but there was not - at this
> point - a compelling case for immediate replacement. The expectation is that
> as problems are identified in header parsing, the fix will typically extend
> this parser to support the problematic header and then use the parser rather
> than custom code.
>
> Added:
> tomcat/trunk/java/org/apache/tomcat/util/http/parser/ (with props)
> tomcat/trunk/java/org/apache/tomcat/util/http/parser/AstAttribute.java
> (with props)
> tomcat/trunk/java/org/apache/tomcat/util/http/parser/AstMediaType.java
> (with props)
> tomcat/trunk/java/org/apache/tomcat/util/http/parser/AstParameter.java
> (with props)
> tomcat/trunk/java/org/apache/tomcat/util/http/parser/AstSubType.java
> (with props)
> tomcat/trunk/java/org/apache/tomcat/util/http/parser/AstType.java (with
> props)
> tomcat/trunk/java/org/apache/tomcat/util/http/parser/AstValue.java (with
> props)
> tomcat/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java
> (with props)
> tomcat/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.jjt
> (with props)
>
> tomcat/trunk/java/org/apache/tomcat/util/http/parser/HttpParserConstants.java
> (with props)
>
> tomcat/trunk/java/org/apache/tomcat/util/http/parser/HttpParserTokenManager.java
> (with props)
>
> tomcat/trunk/java/org/apache/tomcat/util/http/parser/HttpParserTreeConstants.java
> (with props)
>
> tomcat/trunk/java/org/apache/tomcat/util/http/parser/JJTHttpParserState.java
> (with props)
> tomcat/trunk/java/org/apache/tomcat/util/http/parser/Node.java (with
> props)
> tomcat/trunk/java/org/apache/tomcat/util/http/parser/ParseException.java
> (with props)
> tomcat/trunk/java/org/apache/tomcat/util/http/parser/SimpleCharStream.java
> (with props)
> tomcat/trunk/java/org/apache/tomcat/util/http/parser/SimpleNode.java
> (with props)
> tomcat/trunk/java/org/apache/tomcat/util/http/parser/Token.java (with
> props)
> tomcat/trunk/java/org/apache/tomcat/util/http/parser/TokenMgrError.java
> (with props)
> tomcat/trunk/test/org/apache/tomcat/util/http/parser/
> tomcat/trunk/test/org/apache/tomcat/util/http/parser/TestMediaType.java
> (with props)
> Modified:
> tomcat/trunk/.gitignore
> tomcat/trunk/build.xml
> tomcat/trunk/java/org/apache/coyote/Response.java
>
Reviewing HttpParser.jjt,
1) It seems that quoted text handling (" TOKEN"
construct) is slightly wrong in its handling of backslash character.
RFC2616:
[[[
quoted-string = ( <"> *(qdtext | quoted-pair ) <"> )
qdtext = >
The backslash character ("\") MAY be used as a single-character
quoting mechanism only within quoted-string and comment constructs.
quoted-pair= "\" CHAR
]]]
CHAR =
So quoted-pair is '\' + any character 0-127, but from the jjt file I
do not see it:
I do not see how it allows "any CHAR" after "\".
As far as I understand our implementation allows either double quote
or QUOTED_TEXT_CHAR, but QUOTED_TEXT_CHAR != CHAR. It does not include
"\", CTL characters, and wrongly includes character 128-255.
2) RFC2616: ch.3.7 Media Types
says
media-type = type "/" subtype *( ";" parameter )
type = token
subtype= token
and then
"Linear white space
(LWS) MUST NOT be used between the type and subtype, nor between an
attribute and its value."
I see that we allow LWS there, because our definitions of HTTP_TOKEN
and QUOTED_STRING already include leading and trailing LWS in them,
and thus there are trim() calls everywhere in the jjt file.
I am OK with it though, because I do not see any problem from it, but
maybe LWS could be removed from TOKEN and QUOTED_STRING constructs
along with those trim() calls.
[GUMP@vmgump]: Project tomcat-tc7.0.x-validate (in module tomcat-7.0.x) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-validate has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 4 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-tc7.0.x-validate : Tomcat 7.x, a web server implementing Java Servlet 3.0, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-validate/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on checkstyle exists, no need to add for property checkstyle.jar. -INFO- Failed with reason build failed The following work was performed: http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-validate/gump_work/build_tomcat-7.0.x_tomcat-tc7.0.x-validate.html Work Name: build_tomcat-7.0.x_tomcat-tc7.0.x-validate (Type: Build) Work ended in a state of : Failed Elapsed: 1 sec Command Line: /usr/lib/jvm/java-6-openjdk/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/checkstyle-5.6-SNAPSHOT.jar -Dexecute.validate=true validate [Working Directory: /srv/gump/public/workspace/tomcat-7.0.x] CLASSPATH: /usr/lib/jvm/java-6-openjdk/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-5.6-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-23032012.jar:/srv/gump/public/workspace/apache-commons/cli/target/commons-cli-1.3-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/exec/target/commons-exec-1.1.1-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/validator/dist/commons-validator-23032012.jar:/srv/gump/public/workspace/junit/dist/junit-23032012.jar:/srv/gump /public/workspace/junit/dist/junit-dep-23032012.jar:guava-gump-20032012.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-23032012.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-23032012.jar:/srv/gump/public/workspace/commons-collections-3.x/target/commons-collections-3.3-SNAPSHOT.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/jdom/build/jdom.jar:/srv/gump/public/workspace/velocity-engine/bin/velocity-23032012.jar:/srv/gump/public/workspace/velocity-engine/bin/velocity-23032012-dep.jar:/srv/gump/packages/javamail-1.4/mail.jar:/srv/gump/packages/javamail-1.4/lib/mailapi.jar:/srv/gump/packages/jaf-1.1ea/activation.jar - download-validate: proxyflags: setproxy: testexist: [echo] Testing for /srv/gump/public/workspace/checkstyle/target/checkstyle-5.6-SNAPSHOT.jar downloadzip: validate: [mkdir] Created dir: /srv/gump/public/workspace/tomcat-7.0.x/output/res/checkstyle BUILD FAILED /srv/gump/public/workspace/tomcat-7.0.x/build.xml:447: Could not create type checkstyle due to java.lang.NoClassDefFoundError: com/google/common/collect/Lists at com.puppycrawl.tools.checkstyle.CheckStyleTask.(CheckStyleTask.java:78) at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:57) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.lang.reflect.Constructor.newInstance(Constructor.java:532) at org.apache.tools.ant.AntTypeDefinition.innerCreateAndSet(AntTypeDefinition.java:328) at org.apache.tools.ant.AntTypeDefinition.createAndSet(AntTypeDefinition.java:274) at org.apache.tools.ant.AntTypeDefinition.icreate(AntTypeDefinition.java:219) at org.apache.tools.ant.AntTypeDefinition.create(AntTypeDefinition.java:206) at org.apache.tools.ant.ComponentHelper.createComponent(ComponentHelper.java:286) at org.apache.tools.ant.ComponentHelper.createComponent(ComponentHelper.java:264) at org.apache.tools.ant.UnknownElement.makeObject(UnknownElement.java:417) at org.apache.tools.ant.UnknownElement.maybeConfigure(Unk
[GUMP@vmgump]: Project tomcat-trunk-validate (in module tomcat-trunk) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-validate has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 4 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-trunk-validate : Tomcat 8.x, a web server implementing Java Servlet 3.1, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on checkstyle exists, no need to add for property checkstyle.jar. -INFO- Failed with reason build failed The following work was performed: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/gump_work/build_tomcat-trunk_tomcat-trunk-validate.html Work Name: build_tomcat-trunk_tomcat-trunk-validate (Type: Build) Work ended in a state of : Failed Elapsed: 1 sec Command Line: /usr/lib/jvm/java-6-openjdk/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/checkstyle-5.6-SNAPSHOT.jar -Dexecute.validate=true validate [Working Directory: /srv/gump/public/workspace/tomcat-trunk] CLASSPATH: /usr/lib/jvm/java-6-openjdk/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-5.6-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-23032012.jar:/srv/gump/public/workspace/apache-commons/cli/target/commons-cli-1.3-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/exec/target/commons-exec-1.1.1-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/validator/dist/commons-validator-23032012.jar:/srv/gump/public/workspace/junit/dist/junit-23032012.jar:/srv/gump /public/workspace/junit/dist/junit-dep-23032012.jar:guava-gump-20032012.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-23032012.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-23032012.jar:/srv/gump/public/workspace/commons-collections-3.x/target/commons-collections-3.3-SNAPSHOT.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/jdom/build/jdom.jar:/srv/gump/public/workspace/velocity-engine/bin/velocity-23032012.jar:/srv/gump/public/workspace/velocity-engine/bin/velocity-23032012-dep.jar:/srv/gump/packages/javamail-1.4/mail.jar:/srv/gump/packages/javamail-1.4/lib/mailapi.jar:/srv/gump/packages/jaf-1.1ea/activation.jar - download-validate: proxyflags: setproxy: testexist: [echo] Testing for /srv/gump/public/workspace/checkstyle/target/checkstyle-5.6-SNAPSHOT.jar downloadzip: validate: [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/res/checkstyle BUILD FAILED /srv/gump/public/workspace/tomcat-trunk/build.xml:444: Could not create type checkstyle due to java.lang.NoClassDefFoundError: com/google/common/collect/Lists at com.puppycrawl.tools.checkstyle.CheckStyleTask.(CheckStyleTask.java:78) at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:57) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.lang.reflect.Constructor.newInstance(Constructor.java:532) at org.apache.tools.ant.AntTypeDefinition.innerCreateAndSet(AntTypeDefinition.java:328) at org.apache.tools.ant.AntTypeDefinition.createAndSet(AntTypeDefinition.java:274) at org.apache.tools.ant.AntTypeDefinition.icreate(AntTypeDefinition.java:219) at org.apache.tools.ant.AntTypeDefinition.create(AntTypeDefinition.java:206) at org.apache.tools.ant.ComponentHelper.createComponent(ComponentHelper.java:286) at org.apache.tools.ant.ComponentHelper.createComponent(ComponentHelper.java:264) at org.apache.tools.ant.UnknownElement.makeObject(UnknownElement.java:417) at org.apache.tools.ant.UnknownElement.maybeConfigure(UnknownElement.j
