[jira] [Commented] (MTOMCAT-124) tomcat-maven-archetype unused generation parameters

2012-03-17 Thread patrick garcia (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/MTOMCAT-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231914#comment-13231914
 ] 

patrick garcia commented on MTOMCAT-124:


After applying the patch on tomcat-maven-plugin checkout ther is the folloing 
change to do:


to make all pom.xml consistent, it is necessary to remove 
"test-api-impl" from line 31 on file :

tomcat-maven-archetype\src\main\resources\archetype-resources\__rootArtifactId__-api-impl\pom.xml


> tomcat-maven-archetype unused generation parameters
> ---
>
> Key: MTOMCAT-124
> URL: https://issues.apache.org/jira/browse/MTOMCAT-124
> Project: Apache Tomcat Maven Plugin
>  Issue Type: Improvement
>Affects Versions: 2.0-beta-1
>Reporter: patrick garcia
>Assignee: Olivier Lamy
>Priority: Trivial
>  Labels: archetype, maven, tomcat
> Fix For: 2.0
>
> Attachments: MTOMCAT-124-tomcat-maven-archetype.patch
>
>
> I found several problems on the superb and very useful 
> "tomcat-maven-archetype"
> The improvement I propos are the followings:
> 1/
> "groupId" and "version" can have default values but should be prompt for user 
> value the same way as for "version" of 
> "org.apache.maven.archetypes:maven-archetype-quickstart:1.1"
> "org.apache.maven.archetypes:maven-archetype-quickstart:1.1" proposes a 
> default "version" and prompt the user for modification at the same time. 
> Pressing enter validate the default value.
> 2/
> Following variables are not in used:
>   artifactId-api
>   artifactId-api-impl
>   artifactId-webapp
>   artifactId-webapp-exec
>   artifactId-webapp-it
> This variables should impact the "mvn archetype:generate" behaviour
> 3/
> I propos to change the default values of :
>   artifactId-api = ${artifactId}-api
>   artifactId-api-impl = ${artifactId}-api-impl
>   artifactId-webapp = ${artifactId}-webapp
>   artifactId-webapp-exec = ${artifactId}-webapp-exec
>   artifactId-webapp-it = ${artifactId}-webapp-it
> 4/
> rootArtifactId cat be renamed as artifactId with no default value
> I will propos patches for this later. I, first, have to understand 
> "archetype" framework.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 52921] mod_jk 1.2.33 crashes Apache 2.2 when accessing HTML, GIF, etc.

2012-03-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52921

--- Comment #6 from Mladen Turk  2012-03-17 19:17:22 UTC ---
So I was able to reproduce it as well.
Seems the crash is inside handling rule extensions

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0xab1e7b40 (LWP 4822)]
0xb7cbd3ae in jk_map_to_storage (r=0xaa0024c8) at mod_jk.c:3783
3783rconf->rule_extensions = e;

(gdb) bt
#0  0xb7cbd3ae in jk_map_to_storage (r=0xaa0024c8) at mod_jk.c:3783
#1  0x08080598 in ap_run_map_to_storage ()
#2  0x0808123e in ap_process_request_internal ()
#3  0x080a2ca3 in ap_process_async_request ()
#4  0x0809f762 in ap_process_http_async_connection ()
#5  0x0809f932 in ap_process_http_connection ()
#6  0x08095e03 in ap_run_process_connection ()

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1301987 - /tomcat/jk/trunk/native/apache-2.0/mod_jk.c

2012-03-17 Thread mturk
Author: mturk
Date: Sat Mar 17 20:00:54 2012
New Revision: 1301987

URL: http://svn.apache.org/viewvc?rev=1301987&view=rev
Log:
Fix BZ52921

Modified:
tomcat/jk/trunk/native/apache-2.0/mod_jk.c

Modified: tomcat/jk/trunk/native/apache-2.0/mod_jk.c
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/apache-2.0/mod_jk.c?rev=1301987&r1=1301986&r2=1301987&view=diff
==
--- tomcat/jk/trunk/native/apache-2.0/mod_jk.c (original)
+++ tomcat/jk/trunk/native/apache-2.0/mod_jk.c Sat Mar 17 20:00:54 2012
@@ -3736,7 +3736,7 @@ static int jk_map_to_storage(request_rec
 
 jk_request_conf_t *rconf = ap_get_module_config(r->request_config, 
&jk_module);
 if (rconf == NULL) {
-jk_request_conf_t *rconf = apr_palloc(r->pool, 
sizeof(jk_request_conf_t));
+rconf = apr_palloc(r->pool, sizeof(jk_request_conf_t));
 rconf->jk_handled = JK_FALSE;
 rconf->rule_extensions = NULL;
 ap_set_module_config(r->request_config, &jk_module, rconf);



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 52921] mod_jk 1.2.33 crashes Apache 2.2 when accessing HTML, GIF, etc.

2012-03-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52921

Mladen Turk  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #7 from Mladen Turk  2012-03-17 20:01:40 UTC ---
Fixed in r1301987
Suppose 1.2.34 is coming pretty soon :)

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: svn commit: r1301987 - /tomcat/jk/trunk/native/apache-2.0/mod_jk.c

2012-03-17 Thread Rainer Jung

On 17.03.2012 21:00, mt...@apache.org wrote:

Author: mturk
Date: Sat Mar 17 20:00:54 2012
New Revision: 1301987

URL: http://svn.apache.org/viewvc?rev=1301987&view=rev
Log:
Fix BZ52921

Modified:
 tomcat/jk/trunk/native/apache-2.0/mod_jk.c

Modified: tomcat/jk/trunk/native/apache-2.0/mod_jk.c
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/apache-2.0/mod_jk.c?rev=1301987&r1=1301986&r2=1301987&view=diff
==
--- tomcat/jk/trunk/native/apache-2.0/mod_jk.c (original)
+++ tomcat/jk/trunk/native/apache-2.0/mod_jk.c Sat Mar 17 20:00:54 2012
@@ -3736,7 +3736,7 @@ static int jk_map_to_storage(request_rec

  jk_request_conf_t *rconf = 
ap_get_module_config(r->request_config,&jk_module);
  if (rconf == NULL) {
-jk_request_conf_t *rconf = apr_palloc(r->pool, 
sizeof(jk_request_conf_t));
+rconf = apr_palloc(r->pool, sizeof(jk_request_conf_t));


So silly, damn, sorry, thanks!

Regards,

Rainer


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 52833] NPE with 7.0.26

2012-03-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52833

--- Comment #8 from olamy  2012-03-17 22:06:13 UTC ---
What I don't understand is why in the parent classLoader chain having
SystemClassLoader is mandatory!
That's what the current code assume. Frankly I don't understand why you
consider that mandatory. In some env especially osgi it's not!. 
The patch just prevent a NPE in case of SystemClassLoader is not in the parent
classLoader chain.
Why that could not be a valid use case ?

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Commit e-mails at svn.apache.org reconfigured?

2012-03-17 Thread Konstantin Kolinko
Hi!

Just noticed the following message on ASF Infra twitter [1]
"The next commit mail per list will have to be moderated. This was
handled for lists named *cvs@ and *commits@. -- "

[1] http://twitter.com/#!/infrabot/statuses/181142363358507008

Maybe we will experience some delayed commit e-mails, so be aware.
Though I have not seen proper announcements or explanations what was
actually done and why.

Just to check:

> svn log https://svn.apache.org/repos/asf/tomcat --limit 3
starts with

r1301987 | mturk | 2012-03-18 00:00:54 +0400 (Вс, 18 мар 2012) | 1 line

Fix BZ52921


There was a commit e-mail for r1301987, so nothing has been lost yet.

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org