DO NOT REPLY [Bug 51953] Proposal: netmask filtering valve and filter
https://issues.apache.org/bugzilla/show_bug.cgi?id=51953 --- Comment #15 from Francis Galiegue 2011-10-06 07:34:50 UTC --- OK, I need advice. How should errors be handled and at which level? What should happen if one specified netmask is invalid? Should the Valve/Filter fail completely? What should be logged and how? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1179533 - in /tomcat/jk/trunk: native/common/jk_ajp_common.c xdocs/miscellaneous/changelog.xml
Author: rjung
Date: Thu Oct 6 08:45:08 2011
New Revision: 1179533
URL: http://svn.apache.org/viewvc?rev=1179533&view=rev
Log:
Improve logging when request does not fix into
an AJP packet.
Modified:
tomcat/jk/trunk/native/common/jk_ajp_common.c
tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml
Modified: tomcat/jk/trunk/native/common/jk_ajp_common.c
URL:
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/common/jk_ajp_common.c?rev=1179533&r1=1179532&r2=1179533&view=diff
==
--- tomcat/jk/trunk/native/common/jk_ajp_common.c (original)
+++ tomcat/jk/trunk/native/common/jk_ajp_common.c Thu Oct 6 08:45:08 2011
@@ -451,7 +451,7 @@ static int ajp_marshal_into_msgb(jk_msg_
if ((sc = sc_for_req_header(s->headers_names[i])) != UNKNOWN_METHOD) {
if (jk_b_append_int(msg, (unsigned short)sc)) {
jk_log(l, JK_LOG_ERROR,
- "failed appending the header name");
+ "failed appending the header code");
JK_TRACE_EXIT(l);
return JK_FALSE;
}
@@ -459,7 +459,7 @@ static int ajp_marshal_into_msgb(jk_msg_
else {
if (jk_b_append_string(msg, s->headers_names[i])) {
jk_log(l, JK_LOG_ERROR,
- "failed appending the header name");
+ "failed appending the header name '%s'",
s->headers_names[i]);
JK_TRACE_EXIT(l);
return JK_FALSE;
}
@@ -467,7 +467,7 @@ static int ajp_marshal_into_msgb(jk_msg_
if (jk_b_append_string(msg, s->headers_values[i])) {
jk_log(l, JK_LOG_ERROR,
- "failed appending the header value");
+ "failed appending the header value for header '%s' of
length %u", s->headers_names[i], strlen(s->headers_names[i]));
JK_TRACE_EXIT(l);
return JK_FALSE;
}
@@ -509,7 +509,7 @@ static int ajp_marshal_into_msgb(jk_msg_
jk_b_append_string(msg, s->query_string)) {
#endif
jk_log(l, JK_LOG_ERROR,
- "failed appending the query string");
+ "failed appending the query string of length %u",
strlen(s->query_string));
JK_TRACE_EXIT(l);
return JK_FALSE;
}
@@ -2429,8 +2429,8 @@ static int JK_METHOD ajp_service(jk_endp
if (!ajp_marshal_into_msgb(op->request, s, l, p)) {
*is_error = JK_HTTP_REQUEST_TOO_LARGE;
jk_log(l, JK_LOG_INFO,
-"Creating AJP message failed, "
-"without recovery");
+"Creating AJP message failed "
+"without recovery - check max_packet_size");
aw->s->client_errors++;
JK_TRACE_EXIT(l);
return JK_CLIENT_ERROR;
Modified: tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml?rev=1179533&r1=1179532&r2=1179533&view=diff
==
--- tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml (original)
+++ tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml Thu Oct 6 08:45:08 2011
@@ -70,6 +70,9 @@
HTTPD: Allow dynamic switching of requests to "stateless" using the
environment variable JK_STATELESS. (rjung)
+
+AJP: Improve logging when request does not fix into an AJP packet.
(rjung)
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Tomcat Wiki] Update of "PoweredBy" by JamieLast
Dear Wiki user,
You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change
notification.
The "PoweredBy" page has been changed by JamieLast:
http://wiki.apache.org/tomcat/PoweredBy?action=diff&rev1=367&rev2=368
[[http://wiki.astrogrid.org/bin/view/Astrogrid/WebHome|The AstroGrid]]
project uses Tomcat for its web applications, as documented on their
[[http://wiki.astrogrid.org/bin/view/AG2/WebAppManagement|wiki]].
=== Automated HomeFinder ===
- {{http://www.automatedhomefinder.com/ahf_display/images/ahf_logo_mid.png}}
[[http://www.automatedhomefinder.com|Colorado real estate]] company --
Automated Homefinder used Tomcat/JBoss for their production website for years,
allowing millions of home buyers to search a robust database for
[[http://www.automatedhomefinder.com/Denver-Northwest-Colorado-real-estate-for-sale.php|Denver
real estate]],
[[http://www.automatedhomefinder.com/Boulder-Colorado-real-estate-for-sale.php|Boulder
real estate]], and other real estate listings around Colorado.
+ {{http://www.automatedhomefinder.com/ahf_display/images/ahf_logo_mid.png}}
[[http://www.automatedhomefinder.com|Colorado real estate]] company --
Automated Homefinder used Tomcat/JBoss for their production website for years,
allowing millions of home buyers to search a robust database for
[[http://www.automatedhomefinder.com/Denver-Northwest-Colorado-real-estate-for-sale.php|Denver
real estate]],
[[http://www.automatedhomefinder.com/Boulder-Colorado-real-estate-for-sale.php|Boulder
real estate]], and other real estate listings around
Colorado[[http://technische-uebersetzung.blogage.de/entries/2011/10/5/Technische-Uebersetzung|.]]
=== BASE ===
The [[http://base.thep.lu.se/base2/index.html|BASE system]] runs on Tomcat.
[[http://base.thep.lu.se/base2/installation.html|Installation instructions]]
are also available.
@@ -75, +75 @@
{{http://www.become.com/images/become_home.gif}}
[[http://Become.com|Become.com]] - The statistics servers for this
massively-scaled shopping web crawler:
[[http://java.sun.com/developer/technicalArticles/WebServices/become/|Read
About It]]
=== BergenJerseyForeclosures.com ===
-
{{http://www.bergenjerseyforeclosures.com/templates/default/images/BergenJerseyForeclosures.png}}
[[http://www.bergenjerseyforeclosures.com|Bergen Jersey Foreclosures]] - The
most popular site for free [[http://www.bergenjerseyforeclosures.com|NJ
foreclosure]] listings has been powered by Tomcat for years since it was first
deployed.
+
{{http://www.bergenjerseyforeclosures.com/templates/default/images/BergenJerseyForeclosures.png}}
[[http://www.bergenjerseyforeclosures.com|Bergen Jersey Foreclosures]] - The
most popular site for free [[http://www.bergenjerseyforeclosures.com|NJ
foreclosure]] listings has been powered by Tomcat for years since it was first
deployed[[http://uebersetzer.blogieren.de/Erstes-Blog-b1/Ihr-Ubersetzer-b1-p1.htm|.]]
=== Bildergalerie ===
[[http://bildergalerie.pleier-it.de/|{{http://bildergalerie.pleier-it.de/img/Bildergal_Logo.png}}]]
[[http://bildergalerie.pleier-it.de/|Pleier-IT Bildergalerie (Picture
Gallery)]] is a German site providing free hosting of Picture Galleries,
developed by two students. It uses Apache Tomcat 7.
=== BlogScope.net ===
-
[[http://www.blogscope.net/|{{http://www.blogscope.net/images/blogscope-white-logo.png|http://www.blogscope.net/}}]]
[[http://www.blogscope.net/|BlogScope]] is a search and analysis tool for
blogosphere. Developed as research project at U of Toronto, built upon many
open source applications including Tomcat.
[[http://www.blogscope.net/about/|Read more about it]].
+
[[http://www.blogscope.net/|{{http://www.blogscope.net/images/blogscope-white-logo.png|http://www.blogscope.net/}}]]
[[http://www.blogscope.net/|BlogScope]] is a search and analysis tool for
blogosphere. Developed as research project at U of Toronto, built upon many
open source applications including Tomcat.
[[http://www.blogscope.net/about/|Read more about
it]][[http://sprachstudium.beeplog.de/224055_1133788.htm|.]]
=== BreakBIT ===
[[http://www.breakbit.com|BreakBIT]] Fairwizard - an integrated enterprise
management system for Fair and Exhibitions.
+ [[http://fachuebersetzung.blog.de/2011/10/04/fachuebersetzung-11965654/|.]]
+
+
+
+
+
=== Cactus ===
- {{http://jakarta.apache.org/cactus/images/logocactus.gif}}
[[http://jakarta.apache.org/cactus|Jakarta Cactus]] - A test framework for unit
testing server-side java code.
+ {{http://jakarta.apache.org/cactus/images/logocactus.gif}}
[[http://jakarta.apache.org/cactus|Jakarta Cactus]] - A test framework for unit
testing server-side java code[[http://yesbo.de/uebersetzt/2011/10/05/3/|.]]
=== CampRate ===
- {{http://camprate.com/images/logo.gif}} [[http://CampRate.com|CampRate.com]]
- Online Campground Directory and Reviews; Running Tomcat 5 and Struts.
+ {{http://camprate.com/images/logo.gif}} [[http://CampRate.com|CampR
[Tomcat Wiki] Update of "PoweredBy" by JamieLast
Dear Wiki user,
You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change
notification.
The "PoweredBy" page has been changed by JamieLast:
http://wiki.apache.org/tomcat/PoweredBy?action=diff&rev1=369&rev2=370
This section contains cases that publicly described their Tomcat experience
or installation.
=== AppFuse ===
- {{http://today.java.net/images/tiles/111-appfuse.gif}} Raible Designs'
[[http://today.java.net/pub/a/today/2004/07/15/thefuse.html|AppFuse]] runs best
on Tomcat. They wrote
[[http://raibledesigns.com/page/rd?anchor=resin_slower_than_tomcat_fails|an
interesting post]] comparing standards-compliance and performance on Tomcat and
other containers.
+ {{http://today.java.net/images/tiles/111-appfuse.gif}} Raible Designs'
[[http://today.java.net/pub/a/today/2004/07/15/thefuse.html|AppFuse]] runs best
on Tomcat. They wrote
[[http://raibledesigns.com/page/rd?anchor=resin_slower_than_tomcat_fails|an
interesting post]] comparing standards-compliance and performance on Tomcat and
other containers[[http://www.profi-fachuebersetzungen.de|.]]
=== Bonhams ===
{{http://www.bonhams.com/images/BonLogoGrey.jpg}}
[[http://www.bonhams.com/|Bonhams]] is an auction house founded in 1793,
running Tomcat and other open-source software, as detailed in
[[http://www.cio.com/article/print/22988|this article]] from
[[http://www.cio.com|CIO Magazine]].
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Tomcat Wiki] Update of "LocalBadContent" by ChuckCaldarale
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "LocalBadContent" page has been changed by ChuckCaldarale: http://wiki.apache.org/tomcat/LocalBadContent?action=diff&rev1=30&rev2=31 eukhost\.com evocatus\.com exactpages\.com + fachuebersetzung\.blog\.de fcpages\.com feeltime\.cn feeltime\.com @@ -65, +66 @@ isas\.com\.cn j\-cellular kogaryu\.com + konferenzdolmetscher\.over-blog\.de levidus\.com lo\.lee\.tv masterjin\.com @@ -90, +92 @@ shyxbc\.com\.cn signalsforex smbay\.cn + sprachstudium\.beeplog\.de + technische-uebersetzung\.blogage\.de tiffanyonsale\.org tinyurl\.com tnb120\.com\.cn tunfar\.com\.cn u-tokyo\.ac\.jp + uebersetzer\.blogieren\.de uebersetzung-deutsch-englisch\.com ulcertreatment\.org vergleich-riester-rente\.net @@ -110, +115 @@ xcyouth\.org\.cn xn--lnakuten-9za\.se yehuo\.cn + yesbo\.de zjeyu\.com zx\.slave\.ca zyseo\.com - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
