svn commit: r1178721 - in /tomcat/trunk/res/rat: ./ rat-excludes.txt
Author: kkolinko Date: Tue Oct 4 08:46:07 2011 New Revision: 1178721 URL: http://svn.apache.org/viewvc?rev=1178721&view=rev Log: rat-excludes.txt file for Buildbot INFRA-3948 Added: tomcat/trunk/res/rat/ (with props) tomcat/trunk/res/rat/rat-excludes.txt (with props) Propchange: tomcat/trunk/res/rat/ -- bugtraq:append = false Propchange: tomcat/trunk/res/rat/ -- bugtraq:label = Bugzilla ID (optional) Propchange: tomcat/trunk/res/rat/ -- --- bugtraq:message (added) +++ bugtraq:message Tue Oct 4 08:46:07 2011 @@ -0,0 +1 @@ +Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=%BUGID% Propchange: tomcat/trunk/res/rat/ -- bugtraq:url = https://issues.apache.org/bugzilla/show_bug.cgi?id=%BUGID% Added: tomcat/trunk/res/rat/rat-excludes.txt URL: http://svn.apache.org/viewvc/tomcat/trunk/res/rat/rat-excludes.txt?rev=1178721&view=auto == --- tomcat/trunk/res/rat/rat-excludes.txt (added) +++ tomcat/trunk/res/rat/rat-excludes.txt Tue Oct 4 08:46:07 2011 @@ -0,0 +1,21 @@ + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. + + Excludes file for Apache RAT tool run by ASF Buildbot, + http://incubator.apache.org/rat/ + + - HTML files in Documentation web application are generated from XML + +output/build/webapps/docs/*.html Propchange: tomcat/trunk/res/rat/rat-excludes.txt -- svn:eol-style = native Propchange: tomcat/trunk/res/rat/rat-excludes.txt -- svn:mime-type = text/plain - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1178723 - in /tomcat/tc7.0.x/trunk: ./ res/rat/
Author: kkolinko Date: Tue Oct 4 08:48:34 2011 New Revision: 1178723 URL: http://svn.apache.org/viewvc?rev=1178723&view=rev Log: Merged revision 1178721 from tomcat/trunk: rat-excludes.txt file for ASF Buildbot INFRA-3948 Added: tomcat/tc7.0.x/trunk/res/rat/ (props changed) - copied from r1178721, tomcat/trunk/res/rat/ Modified: tomcat/tc7.0.x/trunk/ (props changed) Propchange: tomcat/tc7.0.x/trunk/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Tue Oct 4 08:48:34 2011 @@ -1 +1 @@ -/tomcat/trunk:1156115,1156171,1156276,1156304,1156519,1156530,1156602,1157015,1157018,1157151,1157198,1157204,1157810,1157832,1157834,1157847,1157908,1157939,1158155,1158160,1158176,1158195,1158198-1158199,1158227,1158331,1158334-1158335,1158426,1160347,1160592,1160611,1160619,1160626,1160639,1160652,1160720-1160721,1160772,1160774,1160776,1161303,1161310,1161322,1161339,1161486,1161540,1161549,1161584,1162082,1162149,1162169,1162721,1162769,1162836,1162932,1163630,1164419,1164438,1164469,1164480,1164567,1165234,1165247-1165248,1165253,1165273,1165282,1165309,1165331,1165338,1165347,1165360-1165361,1165367-1165368,1165602,1165608,1165677,1165693,1165721,1165723,1165728,1165730,1165738,1165746,1165765,1165777,1165918,1165921,1166077,1166150-1166151,1166290,1166366,1166620,1166686,1166752,1166757,1167368,1167394,1169447,1170647,1171692,1172233-1172234,1172236,1172269,1172278,1172282,1172610,1172664,1172689,1172711,1173020-1173021,1173082,1173088,1173090,1173096,1173241,1173256 ,1173288,117,1173342,1173461,1173614,1173630,1173659,1173722,1174061,1174239,1174322,1174325,1174329-1174330,1174337-1174339,1174343,1174353,1174799,1174882,1174884,1174983,1175155,1175158,1175167,1175182,1175190,1175201,1175272,1175275,1175283,1175582,1175589-1175590,1175594,1175602,1175613,1175633,1175690,1175713,1175889,1175896,1175907,1176584,1176590,1176799,1177050,1177060,1177125,1177152,1177160,1177245,1177850,1177862,1177978,1178209,1178228,1178233,1178449,1178542,1178681 +/tomcat/trunk:1156115,1156171,1156276,1156304,1156519,1156530,1156602,1157015,1157018,1157151,1157198,1157204,1157810,1157832,1157834,1157847,1157908,1157939,1158155,1158160,1158176,1158195,1158198-1158199,1158227,1158331,1158334-1158335,1158426,1160347,1160592,1160611,1160619,1160626,1160639,1160652,1160720-1160721,1160772,1160774,1160776,1161303,1161310,1161322,1161339,1161486,1161540,1161549,1161584,1162082,1162149,1162169,1162721,1162769,1162836,1162932,1163630,1164419,1164438,1164469,1164480,1164567,1165234,1165247-1165248,1165253,1165273,1165282,1165309,1165331,1165338,1165347,1165360-1165361,1165367-1165368,1165602,1165608,1165677,1165693,1165721,1165723,1165728,1165730,1165738,1165746,1165765,1165777,1165918,1165921,1166077,1166150-1166151,1166290,1166366,1166620,1166686,1166752,1166757,1167368,1167394,1169447,1170647,1171692,1172233-1172234,1172236,1172269,1172278,1172282,1172610,1172664,1172689,1172711,1173020-1173021,1173082,1173088,1173090,1173096,1173241,1173256 ,1173288,117,1173342,1173461,1173614,1173630,1173659,1173722,1174061,1174239,1174322,1174325,1174329-1174330,1174337-1174339,1174343,1174353,1174799,1174882,1174884,1174983,1175155,1175158,1175167,1175182,1175190,1175201,1175272,1175275,1175283,1175582,1175589-1175590,1175594,1175602,1175613,1175633,1175690,1175713,1175889,1175896,1175907,1176584,1176590,1176799,1177050,1177060,1177125,1177152,1177160,1177245,1177850,1177862,1177978,1178209,1178228,1178233,1178449,1178542,1178681,1178721 Propchange: tomcat/tc7.0.x/trunk/res/rat/ -- bugtraq:append = false Propchange: tomcat/tc7.0.x/trunk/res/rat/ -- bugtraq:label = Bugzilla ID (optional) Propchange: tomcat/tc7.0.x/trunk/res/rat/ -- --- bugtraq:message (added) +++ bugtraq:message Tue Oct 4 08:48:34 2011 @@ -0,0 +1 @@ +Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=%BUGID% Propchange: tomcat/tc7.0.x/trunk/res/rat/ -- bugtraq:url = https://issues.apache.org/bugzilla/show_bug.cgi?id=%BUGID% - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Release Testing
All, I was thinking about the tests that various folks (Konstantin, Mladen, Rainer, etc.) perform and I was wondering if it might be a good idea for everyone to share their techniques for testing that could be automated. For example, contributing some scripts, etc. to a meta-test framework for things like gpg signature tests, md5 sum tests, checks for ASF references in source files, etc. It's possible that some of those tests may fail in certain environments (e.g. coming from svn instead of downloading the tarball you post) but not in others. I would volunteer to assemble everything into a sort of test suite that we could put into svn and have everyone run against their own local copies in whatever environment they have. It would obviously include things like "ant test" but also whatever automated checks folks have hand-rolled as they have been testing release candidate builds. Anyone who is interested, go ahead and reply to this thread and attach whatever scripts you already have, or even ideas for things that /could/ be automated but you haven't actually done, yet. Thanks, -chris signature.asc Description: OpenPGP digital signature
DO NOT REPLY [Bug 51952] New: IllegalStateException using CompressionFilter with Tomcat 7.0.21/22
https://issues.apache.org/bugzilla/show_bug.cgi?id=51952 Bug #: 51952 Summary: IllegalStateException using CompressionFilter with Tomcat 7.0.21/22 Product: Tomcat 7 Version: 7.0.21 Platform: Sun OS/Version: Solaris Status: NEW Severity: normal Priority: P2 Component: Jasper AssignedTo: dev@tomcat.apache.org ReportedBy: kari.sc...@cdw.com Classification: Unclassified Created attachment 27685 --> https://issues.apache.org/bugzilla/attachment.cgi?id=27685 Simple test to recreate CompressionFilter causing IllegalStateException Using Tomcat 7.0.21 or 7.0.22 with jdk1.6.0_26 on Solaris 10, mod_ajp and Apache 2.2.21, we get the following logged exception when a sendRedirect is used in a jsp and the CompressionFilter is enabled. It does not occur using 7.0.20. I've attached a gzipped tar file containing a simple test that reproduces the problem. test.jsp just contains a sendRedirect to test2.jsp and I've included the source code for the CompressionFilter and a simple web.xml file with this filter's entry. Hitting test.jsp logs the exception below. SEVERE: Servlet.service() for servlet [jsp] in context with path [] threw exception [java.lang.IllegalStateException: getWriter() has already been called for this response] with root cause java.lang.IllegalStateException: getWriter() has already been called for this response at org.apache.catalina.connector.Response.getOutputStream(Response.java:594) at org.apache.catalina.connector.ResponseFacade.getOutputStream(ResponseFacade.java:199) at com.tirerack.filters.CompressionResponseStream.(CompressionResponseStream.java:47) at com.tirerack.filters.CompressionServletResponseWrapper.createOutputStream(CompressionServletResponseWrapper.java:172) at com.tirerack.filters.CompressionServletResponseWrapper.getWriter(CompressionServletResponseWrapper.java:250) at org.apache.jasper.runtime.JspWriterImpl.initOut(JspWriterImpl.java:125) at org.apache.jasper.runtime.JspWriterImpl.flushBuffer(JspWriterImpl.java:118) at org.apache.jasper.runtime.PageContextImpl.release(PageContextImpl.java:190) at org.apache.jasper.runtime.JspFactoryImpl.internalReleasePageContext(JspFactoryImpl.java:123) at org.apache.jasper.runtime.JspFactoryImpl.releasePageContext(JspFactoryImpl.java:80) at org.apache.jsp.test_jsp._jspService(test_jsp.java:74) at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70) at javax.servlet.http.HttpServlet.service(HttpServlet.java:722) at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:433) at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:389) at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:333) at javax.servlet.http.HttpServlet.service(HttpServlet.java:722) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:304) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210) at com.tirerack.filters.CompressionFilter.doFilter(CompressionFilter.java:194) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:243) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210) at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:224) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:169) at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:472) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:168) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:100) at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:929) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:118) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:405) at org.apache.coyote.ajp.AjpProcessor.process(AjpProcessor.java:200) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:515) at org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:302) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) at java.lang.Thread.run(Thread.java:662) -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To
DO NOT REPLY [Bug 51952] IllegalStateException using CompressionFilter with Tomcat 7.0.21/22
https://issues.apache.org/bugzilla/show_bug.cgi?id=51952 Jess Holle changed: What|Removed |Added CC||je...@ptc.com --- Comment #1 from Jess Holle 2011-10-04 15:57:44 UTC --- I find this a bit funny as I had exactly the same issue with my own CompressionFilter. The issue is that 7.0.21 produces a response body *inside* sendRedirect(). This entails it obtaining a response writer therein, which your filter can't know has occurred as it's doing this at a level of the filter chain your filter can't see. This issue seemed easy enough to address -- for the test cases I initially saw. Unfortunately for your test case things are not so simple. I'm not at all sure how one can do a CompressionFilter with this Tomcat change in place -- as filters can no longer tell when it is safe to call getOutputStream(). I'm half inclined to remove the Tomcat "fix" that caused this from my Tomcat binary. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51741] Eclipse WTP "Serve modules without publishing" broken with tc7, needs patch in tomcat
https://issues.apache.org/bugzilla/show_bug.cgi?id=51741 --- Comment #4 from Mathieu Ouellet 2011-10-04 16:50:37 UTC --- Not sure about the expected behavior of the WepappClassLoader, but here's something I ran into while testing the new release 7.0.22. I'm still experiencing the issue when using org.apache.catalina.loader.WebappClassLoader.findResources(String). Unlike org.apache.catalina.loader.WebappClassLoader.findResource(String), it doesn't look for resources into the local repository using org.apache.catalina.loader.WebappClassLoader.findResourceInternal(String, String), where the fix to this bug can be found. Not sure if this is an expected behavior, but this use case doesn't seem to be covered by the fix. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51953] New: Proposal: netmask filtering valve and filter
https://issues.apache.org/bugzilla/show_bug.cgi?id=51953 Bug #: 51953 Summary: Proposal: netmask filtering valve and filter Product: Tomcat 7 Version: trunk Platform: All OS/Version: All Status: NEW Severity: normal Priority: P2 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: fgalie...@gmail.com Classification: Unclassified This patch series (three) is a first implementation of a netmask filtering, pretty much as Apache's "allow from" and "deny from" directives, but with some limitations. I submit these patches for review only for now. I have tested them with a main() and torturing the NetMask class with various corner cases and it survived all of it. The issue I have right now is writing a unit test. I cannot figure out how to do it atm, pointers to example code would be welcome. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51953] Proposal: netmask filtering valve and filter
https://issues.apache.org/bugzilla/show_bug.cgi?id=51953 --- Comment #1 from Francis Galiegue 2011-10-04 18:06:15 UTC --- Created attachment 27686 --> https://issues.apache.org/bugzilla/attachment.cgi?id=27686 As title says -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51953] Proposal: netmask filtering valve and filter
https://issues.apache.org/bugzilla/show_bug.cgi?id=51953 --- Comment #2 from Francis Galiegue 2011-10-04 18:06:30 UTC --- Created attachment 27687 --> https://issues.apache.org/bugzilla/attachment.cgi?id=27687 As title says -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51953] Proposal: netmask filtering valve and filter
https://issues.apache.org/bugzilla/show_bug.cgi?id=51953 Francis Galiegue changed: What|Removed |Added Attachment #27686|As title says |Netmask class description|| -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51953] Proposal: netmask filtering valve and filter
https://issues.apache.org/bugzilla/show_bug.cgi?id=51953 Francis Galiegue changed: What|Removed |Added Attachment #27687|As title says |Netmask filter description|| -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51953] Proposal: netmask filtering valve and filter
https://issues.apache.org/bugzilla/show_bug.cgi?id=51953 --- Comment #3 from Francis Galiegue 2011-10-04 18:07:25 UTC --- Created attachment 27688 --> https://issues.apache.org/bugzilla/attachment.cgi?id=27688 Netmask valve -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51953] Proposal: netmask filtering valve and filter
https://issues.apache.org/bugzilla/show_bug.cgi?id=51953 --- Comment #4 from Francis Galiegue 2011-10-04 18:46:53 UTC --- Created attachment 27689 --> https://issues.apache.org/bugzilla/attachment.cgi?id=27689 Whole patch (git diff origin/trunk..) -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51741] Eclipse WTP "Serve modules without publishing" broken with tc7, needs patch in tomcat
https://issues.apache.org/bugzilla/show_bug.cgi?id=51741 Sylvain Laurent changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED | --- Comment #5 from Sylvain Laurent 2011-10-04 19:11:46 UTC --- you're correct, my fix is not sufficient, I'll work on it soon. Unfortunately the code in tomcat is quite complex and feels like it has a lot of history, I have to be very careful not to break anything... -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51741] Eclipse WTP "Serve modules without publishing" broken with tc7, needs patch in tomcat
https://issues.apache.org/bugzilla/show_bug.cgi?id=51741 --- Comment #6 from Mathieu Ouellet 2011-10-04 19:52:40 UTC --- Thank you very much ! -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51953] Proposal: netmask filtering valve and filter
https://issues.apache.org/bugzilla/show_bug.cgi?id=51953 --- Comment #5 from Christopher Schultz 2011-10-04 20:52:36 UTC --- I might make this filter/valve a bit more generic: there's no reason to go through all the trouble of doing an InetAddress lookup, creating a BigInteger, shifting it, and then comparing it if there is no CIDR spec in the IP specified by the configuration. You could create a fairly generic IP-matching interface and then two implementations: one simple string-equals one and a more complicated netmask-matching one. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51953] Proposal: netmask filtering valve and filter
https://issues.apache.org/bugzilla/show_bug.cgi?id=51953 --- Comment #6 from Francis Galiegue 2011-10-04 21:05:25 UTC --- (In reply to comment #5) > I might make this filter/valve a bit more generic: there's no reason to go > through all the trouble of doing an InetAddress lookup, creating a BigInteger, > shifting it, and then comparing it if there is no CIDR spec in the IP > specified > by the configuration. > Well, the remote host is always an IP address in string form, so there is no lookup performed at all. When supplied with an IP address in string form, InetAddress.getByName() only validates the validity of the IP address (whether it be IPv4 and IPv6). Also, the current implementation also does simple IP matching, since if there is no CIDR the right shift is 0, thus an exact match is required. More to the point, I don't see how I could make this generic? It would mean dispatching at some point, but how? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51953] Proposal: netmask filtering valve and filter
https://issues.apache.org/bugzilla/show_bug.cgi?id=51953 --- Comment #7 from Christopher Schultz 2011-10-04 21:15:43 UTC --- This code is executed unconditionally: " final InetAddress addr = InetAddress.getByName(property); for (final NetMask nm: deny) if (nm.matches(addr)) " NetMask.matches does a new BigInteger().shiftRight (though the shift should be 0 bytes, and so should be pretty quick). Remember that this code may be executed for every request, include, and forward, so you'd better take every opportunity to reduce the amount of time required to run it. In terms of making it more generic, what I meant was that you would be able to quickly match exact-matches (using a simple String.equals) and only do the extra work when there was a netmask to actually check. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51953] Proposal: netmask filtering valve and filter
https://issues.apache.org/bugzilla/show_bug.cgi?id=51953 --- Comment #8 from Francis Galiegue 2011-10-04 21:30:27 UTC --- (In reply to comment #7) > This code is executed unconditionally: > > " > final InetAddress addr = InetAddress.getByName(property); > > for (final NetMask nm: deny) > if (nm.matches(addr)) > " > > NetMask.matches does a new BigInteger().shiftRight (though the shift should be > 0 bytes, and so should be pretty quick). > > Remember that this code may be executed for every request, include, and > forward, so you'd better take every opportunity to reduce the amount of time > required to run it. > Good point. I was tempted at first to do a byte[] manipulation but found BigInteger to be very practical, especially since it requires the byte array to be in network order -- which is what I wanted. I'll have that second implementation working and compare the results in speed. > In terms of making it more generic, what I meant was that you would be able to > quickly match exact-matches (using a simple String.equals) and only do the > extra work when there was a netmask to actually check. That's true, but consider :::127.0.0.1: it actually is the same than 127.0.0.1. An .equals() won't work here. OK, that's going far, but still. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51953] Proposal: netmask filtering valve and filter
https://issues.apache.org/bugzilla/show_bug.cgi?id=51953 Christopher Schultz changed: What|Removed |Added Attachment #27686|0 |1 is obsolete|| Attachment #27687|0 |1 is obsolete|| Attachment #27688|0 |1 is obsolete|| Attachment #27689|0 |1 is obsolete|| --- Comment #9 from Christopher Schultz 2011-10-04 21:53:31 UTC --- Created attachment 27691 --> https://issues.apache.org/bugzilla/attachment.cgi?id=27691 Unified patch for RemoteAddrNetmaskFilter Take a look at this implementation (Filter only, for now), which I believe is a bit simpler and also allows fast string-matching when there is no "/" in the allow/deny spec. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51956] New: RemoteAddrFilter uses remote host (not address) in doFilterEvent
https://issues.apache.org/bugzilla/show_bug.cgi?id=51956
Bug #: 51956
Summary: RemoteAddrFilter uses remote host (not address) in
doFilterEvent
Product: Tomcat 7
Version: trunk
Platform: PC
Status: NEW
Severity: normal
Priority: P2
Component: Catalina
AssignedTo: dev@tomcat.apache.org
ReportedBy: ch...@christopherschultz.net
Classification: Unclassified
public void doFilterEvent(CometEvent event, CometFilterChain chain)
throws IOException, ServletException {
processCometEvent(event.getHttpServletRequest().getRemoteHost(),
event, chain);
}
Use of getRemoteHost should be getRemoteAddr.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1178976 - /tomcat/trunk/java/org/apache/catalina/filters/RemoteAddrFilter.java
Author: schultz
Date: Tue Oct 4 21:59:20 2011
New Revision: 1178976
URL: http://svn.apache.org/viewvc?rev=1178976&view=rev
Log:
Fixed bug #51956: RemoteAddrFilter uses remote host (not address) in
doFilterEvent
Modified:
tomcat/trunk/java/org/apache/catalina/filters/RemoteAddrFilter.java
Modified: tomcat/trunk/java/org/apache/catalina/filters/RemoteAddrFilter.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/filters/RemoteAddrFilter.java?rev=1178976&r1=1178975&r2=1178976&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/filters/RemoteAddrFilter.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/filters/RemoteAddrFilter.java Tue Oct
4 21:59:20 2011
@@ -89,7 +89,7 @@ public final class RemoteAddrFilter
@Override
public void doFilterEvent(CometEvent event, CometFilterChain chain)
throws IOException, ServletException {
-processCometEvent(event.getHttpServletRequest().getRemoteHost(),
+processCometEvent(event.getHttpServletRequest().getRemoteAddr(),
event, chain);
}
@@ -97,5 +97,4 @@ public final class RemoteAddrFilter
protected Log getLogger() {
return log;
}
-
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1178979 - in /tomcat/tc7.0.x/trunk: java/org/apache/catalina/filters/RemoteAddrFilter.java webapps/docs/changelog.xml
Author: schultz
Date: Tue Oct 4 22:05:59 2011
New Revision: 1178979
URL: http://svn.apache.org/viewvc?rev=1178979&view=rev
Log:
Fixed bug #51956: RemoteAddrFilter uses remote host (not address) in
doFilterEvent
Modified:
tomcat/tc7.0.x/trunk/java/org/apache/catalina/filters/RemoteAddrFilter.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
Modified:
tomcat/tc7.0.x/trunk/java/org/apache/catalina/filters/RemoteAddrFilter.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/filters/RemoteAddrFilter.java?rev=1178979&r1=1178978&r2=1178979&view=diff
==
--- tomcat/tc7.0.x/trunk/java/org/apache/catalina/filters/RemoteAddrFilter.java
(original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/catalina/filters/RemoteAddrFilter.java
Tue Oct 4 22:05:59 2011
@@ -89,7 +89,7 @@ public final class RemoteAddrFilter
@Override
public void doFilterEvent(CometEvent event, CometFilterChain chain)
throws IOException, ServletException {
-processCometEvent(event.getHttpServletRequest().getRemoteHost(),
+processCometEvent(event.getHttpServletRequest().getRemoteAddr(),
event, chain);
}
Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1178979&r1=1178978&r2=1178979&view=diff
==
--- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Tue Oct 4 22:05:59 2011
@@ -60,6 +60,10 @@
51910: Prevent NPE on connector stop if Comet applications
are being used without the CometConnectionManagerValve. (markt)
+
+51956: RemoteAddrFilter used getRemoteHost instead of
+getRemoteAddr when filtering Comet events. (schultz)
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51956] RemoteAddrFilter uses remote host (not address) in doFilterEvent
https://issues.apache.org/bugzilla/show_bug.cgi?id=51956 Christopher Schultz changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED OS/Version||All --- Comment #1 from Christopher Schultz 2011-10-04 22:06:43 UTC --- Fixed in trunk, 7.0.x. Will be included in 7.0.23. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51952] IllegalStateException using CompressionFilter with Tomcat 7.0.21/22
https://issues.apache.org/bugzilla/show_bug.cgi?id=51952 --- Comment #2 from Mark Thomas 2011-10-05 02:41:26 UTC --- How about a new configuration attribute on the context that allows this behaviour to be enabled / disabled per context? See https://issues.apache.org/bugzilla/show_bug.cgi?id=41718 for why this behaviour was introduced. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51953] Proposal: netmask filtering valve and filter
https://issues.apache.org/bugzilla/show_bug.cgi?id=51953 Mark Thomas changed: What|Removed |Added Severity|normal |enhancement -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51952] IllegalStateException using CompressionFilter with Tomcat 7.0.21/22
https://issues.apache.org/bugzilla/show_bug.cgi?id=51952 --- Comment #3 from Jess Holle 2011-10-05 04:13:54 UTC --- Overall the RFC cited and the existing servlet API do not combine well when one considers things like compression Filters. I ended up figuring out a way to work around this in my own compression filter (with targeted catching of IllegalStateExceptions and appropriate fallback actions), but I will have to say that it wasn't pretty. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
