svn commit: r1177626 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Fri Sep 30 12:28:48 2011 New Revision: 1177626 URL: http://svn.apache.org/viewvc?rev=1177626&view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1177626&r1=1177625&r2=1177626&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Fri Sep 30 12:28:48 2011 @@ -114,6 +114,11 @@ PATCHES PROPOSED TO BACKPORT: +1: kkolinko -1: +* Fix BIO + SSL + Java7 + http://svn.apache.org/viewvc?view=revision&revision=1174884 + +1: markt + -1: + PATCHES/ISSUES THAT ARE STALLED - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1177729 - in /tomcat/maven-plugin/trunk: pom.xml tomcat-maven-plugin-it/src/main/java/org/codehaus/mojo/tomcat/it/AbstractWarProjectIT.java tomcat6-maven-plugin/pom.xml
Author: olamy
Date: Fri Sep 30 16:47:39 2011
New Revision: 1177729
URL: http://svn.apache.org/viewvc?rev=1177729&view=rev
Log:
add some properties for it tests debugging
Modified:
tomcat/maven-plugin/trunk/pom.xml
tomcat/maven-plugin/trunk/tomcat-maven-plugin-it/src/main/java/org/codehaus/mojo/tomcat/it/AbstractWarProjectIT.java
tomcat/maven-plugin/trunk/tomcat6-maven-plugin/pom.xml
Modified: tomcat/maven-plugin/trunk/pom.xml
URL:
http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/pom.xml?rev=1177729&r1=1177728&r2=1177729&view=diff
==
--- tomcat/maven-plugin/trunk/pom.xml (original)
+++ tomcat/maven-plugin/trunk/pom.xml Fri Sep 30 16:47:39 2011
@@ -50,10 +50,13 @@
2.9
4.9
2000
+false
+false
\
scp://people.apache.org/www/people.apache.org/repo/m2-ibiblio-rsync-repository
scp://people.apache.org/www/people.apache.org/repo/m2-snapshot-repository
scp://people.apache.org/www/tomcat.apache.org/maven-plugin-${project.version}
+
Modified:
tomcat/maven-plugin/trunk/tomcat-maven-plugin-it/src/main/java/org/codehaus/mojo/tomcat/it/AbstractWarProjectIT.java
URL:
http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat-maven-plugin-it/src/main/java/org/codehaus/mojo/tomcat/it/AbstractWarProjectIT.java?rev=1177729&r1=1177728&r2=1177729&view=diff
==
---
tomcat/maven-plugin/trunk/tomcat-maven-plugin-it/src/main/java/org/codehaus/mojo/tomcat/it/AbstractWarProjectIT.java
(original)
+++
tomcat/maven-plugin/trunk/tomcat-maven-plugin-it/src/main/java/org/codehaus/mojo/tomcat/it/AbstractWarProjectIT.java
Fri Sep 30 16:47:39 2011
@@ -92,6 +92,10 @@ public abstract class AbstractWarProject
webappHome = ResourceExtractor.simpleExtractResources( getClass(), "/"
+ getWarArtifactId() );
verifier = new Verifier( webappHome.getAbsolutePath() );
+verifier.setDebug( Boolean.getBoolean( "verifier.debug" ) );
+verifier.setDebugJvm( Boolean.getBoolean( "verifier.debugJvm" ) );
+verifier.displayStreamBuffers();
+
verifier.deleteArtifact( "org.codehaus.mojo.tomcat.it",
getWarArtifactId(), "1.0-SNAPSHOT", "war" );
}
@@ -128,11 +132,11 @@ public abstract class AbstractWarProject
thread.start();
LOG.info( "Executing verify on " + webappHome.getAbsolutePath() );
+/*
Map map = new HashMap();
map.put( "@project.version@", System.getProperty( "mojoVersion" ) );
System.out.println( " webappHome: " + webappHome );
-verifier.filterFile( "pom.xml", "pom.xml", "UTF-8", map );
-verifier.displayStreamBuffers();
+verifier.filterFile( "pom.xml", "pom.xml", "UTF-8", map );*/
verifier.executeGoal( "verify" );
thread.join();
Modified: tomcat/maven-plugin/trunk/tomcat6-maven-plugin/pom.xml
URL:
http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat6-maven-plugin/pom.xml?rev=1177729&r1=1177728&r2=1177729&view=diff
==
--- tomcat/maven-plugin/trunk/tomcat6-maven-plugin/pom.xml (original)
+++ tomcat/maven-plugin/trunk/tomcat6-maven-plugin/pom.xml Fri Sep 30 16:47:39
2011
@@ -227,6 +227,8 @@
${project.version}
+${verifier.debug}
+${verifier.debugJvm}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1177730 - in /tomcat/maven-plugin/trunk: pom.xml tomcat-maven-plugin-it/src/main/java/org/codehaus/mojo/tomcat/it/AbstractWarProjectIT.java tomcat6-maven-plugin/pom.xml
Author: olamy
Date: Fri Sep 30 16:48:31 2011
New Revision: 1177730
URL: http://svn.apache.org/viewvc?rev=1177730&view=rev
Log:
remove unused debug code, make distributionMngtId configurable
Modified:
tomcat/maven-plugin/trunk/pom.xml
tomcat/maven-plugin/trunk/tomcat-maven-plugin-it/src/main/java/org/codehaus/mojo/tomcat/it/AbstractWarProjectIT.java
tomcat/maven-plugin/trunk/tomcat6-maven-plugin/pom.xml
Modified: tomcat/maven-plugin/trunk/pom.xml
URL:
http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/pom.xml?rev=1177730&r1=1177729&r2=1177730&view=diff
==
--- tomcat/maven-plugin/trunk/pom.xml (original)
+++ tomcat/maven-plugin/trunk/pom.xml Fri Sep 30 16:48:31 2011
@@ -56,7 +56,7 @@
scp://people.apache.org/www/people.apache.org/repo/m2-ibiblio-rsync-repository
scp://people.apache.org/www/people.apache.org/repo/m2-snapshot-repository
scp://people.apache.org/www/tomcat.apache.org/maven-plugin-${project.version}
-
+apache.snapshots
@@ -386,7 +386,7 @@
${distributionReleaseUrl}
- apache.snapshots
+ ${distributionIdSnapshots}
Apache Development Snapshot Repository
${distributionSnapshotsUrl}
Modified:
tomcat/maven-plugin/trunk/tomcat-maven-plugin-it/src/main/java/org/codehaus/mojo/tomcat/it/AbstractWarProjectIT.java
URL:
http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat-maven-plugin-it/src/main/java/org/codehaus/mojo/tomcat/it/AbstractWarProjectIT.java?rev=1177730&r1=1177729&r2=1177730&view=diff
==
---
tomcat/maven-plugin/trunk/tomcat-maven-plugin-it/src/main/java/org/codehaus/mojo/tomcat/it/AbstractWarProjectIT.java
(original)
+++
tomcat/maven-plugin/trunk/tomcat-maven-plugin-it/src/main/java/org/codehaus/mojo/tomcat/it/AbstractWarProjectIT.java
Fri Sep 30 16:48:31 2011
@@ -94,7 +94,7 @@ public abstract class AbstractWarProject
verifier.setDebug( Boolean.getBoolean( "verifier.debug" ) );
verifier.setDebugJvm( Boolean.getBoolean( "verifier.debugJvm" ) );
-verifier.displayStreamBuffers();
+
verifier.deleteArtifact( "org.codehaus.mojo.tomcat.it",
getWarArtifactId(), "1.0-SNAPSHOT", "war" );
}
@@ -132,13 +132,10 @@ public abstract class AbstractWarProject
thread.start();
LOG.info( "Executing verify on " + webappHome.getAbsolutePath() );
-/*
-Map map = new HashMap();
-map.put( "@project.version@", System.getProperty( "mojoVersion" ) );
-System.out.println( " webappHome: " + webappHome );
-verifier.filterFile( "pom.xml", "pom.xml", "UTF-8", map );*/
verifier.executeGoal( "verify" );
+verifier.displayStreamBuffers();
+
thread.join();
return responseBodies[0];
Modified: tomcat/maven-plugin/trunk/tomcat6-maven-plugin/pom.xml
URL:
http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat6-maven-plugin/pom.xml?rev=1177730&r1=1177729&r2=1177730&view=diff
==
--- tomcat/maven-plugin/trunk/tomcat6-maven-plugin/pom.xml (original)
+++ tomcat/maven-plugin/trunk/tomcat6-maven-plugin/pom.xml Fri Sep 30 16:48:31
2011
@@ -41,8 +41,6 @@
2005
-
-
org.apache.maven
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1177731 - /tomcat/maven-plugin/trunk/pom.xml
Author: olamy Date: Fri Sep 30 16:48:52 2011 New Revision: 1177731 URL: http://svn.apache.org/viewvc?rev=1177731&view=rev Log: use wagon 2.0 release Modified: tomcat/maven-plugin/trunk/pom.xml Modified: tomcat/maven-plugin/trunk/pom.xml URL: http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/pom.xml?rev=1177731&r1=1177730&r2=1177731&view=diff == --- tomcat/maven-plugin/trunk/pom.xml (original) +++ tomcat/maven-plugin/trunk/pom.xml Fri Sep 30 16:48:52 2011 @@ -347,7 +347,7 @@ org.apache.maven.wagon wagon-ssh - 2.0-SNAPSHOT + 2.0 @@ -359,7 +359,7 @@ org.apache.maven.wagon wagon-ssh - 2.0-SNAPSHOT + 2.0 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 7.0.22
On 27/09/2011 17:36, Mark Thomas wrote: > The proposed Apache Tomcat 7.0.22 release is now available for voting. > > It can be obtained from: > http://people.apache.org/~markt/dev/tomcat-7/v7.0.22/ > The svn tag is: > http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_22/ > > The proposed 7.0.21 release is: > > [ ] Broken - do not release > [ ] Beta - go ahead and release as 7.0.22 Beta > [X] Stable - go ahead and release as 7.0.22 Stable EL TCK passes JSP TCK passes with HTTP (BIO, NIO, APR) Servlet TCK passes with HTTP, HTTP+mod_proxy_http, AJP+mod_jk, AJP+mod_proxy_ajp with all 3 variants (BIO, NIO, APR) Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[RESULT] [VOTE] Release Apache Tomcat 7.0.22
With 5 +1's (4 binding) the vote passes. I'll copy the binaries to mino now and announce the release once the mirrors have sync'd. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1177743 - /tomcat/maven-plugin/trunk/tomcat6-maven-plugin/pom.xml
Author: olamy
Date: Fri Sep 30 17:29:44 2011
New Revision: 1177743
URL: http://svn.apache.org/viewvc?rev=1177743&view=rev
Log:
upgrade tomcat6 plugin to last 6.0.33
Modified:
tomcat/maven-plugin/trunk/tomcat6-maven-plugin/pom.xml
Modified: tomcat/maven-plugin/trunk/tomcat6-maven-plugin/pom.xml
URL:
http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat6-maven-plugin/pom.xml?rev=1177743&r1=1177742&r2=1177743&view=diff
==
--- tomcat/maven-plugin/trunk/tomcat6-maven-plugin/pom.xml (original)
+++ tomcat/maven-plugin/trunk/tomcat6-maven-plugin/pom.xml Fri Sep 30 17:29:44
2011
@@ -34,7 +34,7 @@
-6.0.32
+6.0.33
${mavenVersion}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1177744 - /tomcat/maven-plugin/trunk/tomcat6-maven-plugin/pom.xml
Author: olamy Date: Fri Sep 30 17:30:16 2011 New Revision: 1177744 URL: http://svn.apache.org/viewvc?rev=1177744&view=rev Log: upgrade ecj compiler to 3.7 Modified: tomcat/maven-plugin/trunk/tomcat6-maven-plugin/pom.xml Modified: tomcat/maven-plugin/trunk/tomcat6-maven-plugin/pom.xml URL: http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat6-maven-plugin/pom.xml?rev=1177744&r1=1177743&r2=1177744&view=diff == --- tomcat/maven-plugin/trunk/tomcat6-maven-plugin/pom.xml (original) +++ tomcat/maven-plugin/trunk/tomcat6-maven-plugin/pom.xml Fri Sep 30 17:30:16 2011 @@ -106,7 +106,7 @@ org.eclipse.jdt.core.compiler ecj - 3.5.1 + 3.7 org.apache.tomcat - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1177745 - /tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/AbstractRunMojo.java
Author: olamy
Date: Fri Sep 30 17:30:51 2011
New Revision: 1177745
URL: http://svn.apache.org/viewvc?rev=1177745&view=rev
Log:
restore previous version with default naming enabled to not break to much users
Modified:
tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/AbstractRunMojo.java
Modified:
tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/AbstractRunMojo.java
URL:
http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/AbstractRunMojo.java?rev=1177745&r1=1177744&r2=1177745&view=diff
==
---
tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/AbstractRunMojo.java
(original)
+++
tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/AbstractRunMojo.java
Fri Sep 30 17:30:51 2011
@@ -259,15 +259,11 @@ public abstract class AbstractRunMojo
* naming disabled by default.
*
*
- * With release 1.2 of this plugin useNaming defaults to false as it does
for Tomcat 7. To enable it,
- * set this parameter to true or set the property
maven.tomcat.useNaming.
- *
- *
* Note: This setting is ignored if you provide a
server.xml for your
* Tomcat. Instead please configure naming in the server.xml.
*
*
- * @parameter expression="${maven.tomcat.useNaming}" default-value="false"
+ * @parameter expression="${maven.tomcat.useNaming}" default-value="true"
* @todo adopt documentation once Tomcat 7 is supported (MTOMCAT-62)
* @see http://tomcat.apache.org/tomcat-6.0-doc/api/org/apache/catalina/startup/Embedded.html";>org.apache.catalina.startup.Embedded
* @see http://tomcat.apache.org/tomcat-7.0-doc/api/org/apache/catalina/startup/Tomcat.html";>org.apache.catalina.startup.Tomcat
@@ -614,9 +610,9 @@ public abstract class AbstractRunMojo
private void startContainer()
throws IOException, LifecycleException, MojoExecutionException
{
-
// Set the system properties
setupSystemProperties();
+
final Embedded container;
if ( serverXml != null )
{
@@ -704,6 +700,7 @@ public abstract class AbstractRunMojo
container.start();
EmbeddedRegistry.getInstance().register( container );
+
}
protected ClassRealm getTomcatClassLoader()
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1177784 - /tomcat/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java
Author: markt
Date: Fri Sep 30 19:18:06 2011
New Revision: 1177784
URL: http://svn.apache.org/viewvc?rev=1177784&view=rev
Log:
Remove unused code.
The code to close comet connections has changed over the years and this
bit no longer does anything.
Modified:
tomcat/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java
Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java?rev=1177784&r1=1177783&r2=1177784&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java
(original)
+++ tomcat/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java Fri Sep
30 19:18:06 2011
@@ -314,17 +314,6 @@ public class Http11NioProcessor extends
comet = false;
cometClose = true;
-SelectionKey key =
socket.getSocket().getIOChannel().keyFor(socket.getSocket().getPoller().getSelector());
-if ( key != null ) {
-NioEndpoint.KeyAttachment attach = (NioEndpoint.KeyAttachment)
key.attachment();
-if ( attach!=null && attach.getComet()) {
-//if this is a comet connection
-//then execute the connection closure at the next selector
loop
-
//request.getAttributes().remove("org.apache.tomcat.comet.timeout");
-//attach.setTimeout(5000); //force a cleanup in 5 seconds
-//attach.setError(true); //this has caused concurrency
errors
-}
-}
try {
outputBuffer.endRequest();
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1177850 - /tomcat/trunk/webapps/docs/aio.xml
Author: kkolinko Date: Fri Sep 30 21:52:09 2011 New Revision: 1177850 URL: http://svn.apache.org/viewvc?rev=1177850&view=rev Log: Remove duplicate wrong line that should have been deleted in r535325. See the same text in the JavaDoc of the CometEvent class. Modified: tomcat/trunk/webapps/docs/aio.xml Modified: tomcat/trunk/webapps/docs/aio.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/aio.xml?rev=1177850&r1=1177849&r2=1177850&view=diff == --- tomcat/trunk/webapps/docs/aio.xml (original) +++ tomcat/trunk/webapps/docs/aio.xml Fri Sep 30 21:52:09 2011 @@ -85,7 +85,6 @@ EventType.READ: This indicates that input data is available, and that one read can be made without blocking. The available and ready methods of the InputStream or Reader may be used to determine if there is a risk of blocking: the servlet - should read while data is reported available, and can make one additional read should read while data is reported available. When encountering a read error, the servlet should report it by propagating the exception properly. Throwing an exception will cause the error event to be invoked, and the connection - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1177862 - /tomcat/trunk/webapps/docs/aio.xml
Author: kkolinko
Date: Fri Sep 30 22:21:35 2011
New Revision: 1177862
URL: http://svn.apache.org/viewvc?rev=1177862&view=rev
Log:
Remove one more unneeded line. Correct punctuation.
Modified:
tomcat/trunk/webapps/docs/aio.xml
Modified: tomcat/trunk/webapps/docs/aio.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/aio.xml?rev=1177862&r1=1177861&r2=1177862&view=diff
==
--- tomcat/trunk/webapps/docs/aio.xml (original)
+++ tomcat/trunk/webapps/docs/aio.xml Fri Sep 30 22:21:35 2011
@@ -123,7 +123,6 @@
method of the event.
EventSubType.CLIENT_DISCONNECT: The client connection was closed (sub
type of ERROR).
-method of the event.
EventSubType.IOEXCEPTION: An IO exception occurred, such as invalid
content, for example,
an invalid chunk block (sub type of ERROR).
@@ -306,7 +305,7 @@ public class ChatServlet
CometEvent event event.setTimeout(30*1000); or
event.getHttpServletRequest().setAttribute("org.apache.tomcat.comet.timeout",
new Integer(30 * 1000));
This sets the timeout to 30 seconds.
- Important note, in order to set this timeout, it has to be done on the
BEGIN event.
+ Important note: in order to set this timeout, it has to be done on the
BEGIN event.
The default value is soTimeout
If you are using the APR connector, all Comet connections will have the
same timeout value. It is soTimeout*50
@@ -339,10 +338,10 @@ public class ChatServlet
- org.apache.tomcat.sendfile.filename: Canonical filename of the file
which will be sent as
+ org.apache.tomcat.sendfile.filename: Canonical filename of
the file which will be sent as
a String
- org.apache.tomcat.sendfile.start: Start offset as a Long
- org.apache.tomcat.sendfile.end: End offset as a Long
+ org.apache.tomcat.sendfile.start: Start offset as a
Long
+ org.apache.tomcat.sendfile.end: End offset as a Long
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Comet API
Hi!
I was reading the Comet API documentation, that is "aio.html" in the
docs and Javadoc of catalina.comet.* classes.
Here are several notes.
CometEvent.java:
===
- #setTimeout():
a) @param timeout says it is positive value.
With recent Mark's fixes to timeout handling it also accepts "-1" as
the infinite timeout. It works great with Nio.
(I'll add setting -1 timeout to ChatServlet.).
With Http11AprProtocol you cannot set timeout: the method throws
java.lang.UnsupportedOperationException.
I think the value of "0" shall still be undocumented (I do not know
what it will do and it does not seem to be useful), so just "-1" can
be added.
b) Javadoc here says:
"The
web application SHOULD NOT attempt to reuse the request and
response objects after a timeout
as the error(HttpServletRequest,
HttpServletResponse) method indicates."
It contradicts with description of EventSubType TIMEOUT here and in
aio.html, that says that this event is not fatal and
"the connection will not be closed unless the servlet uses the close
method of the event".
c) I am not sure whether setTimeout() can be called in READ event. The
Javadoc here says just that it cannot be called outside of events
("asynchronously"), but aio.html explicitly mentions that BEGIN event
should be used to call setTimeout().
d) In "Comet timeouts" section in aio.html it is said that the default
timeout for "soTimeout" for Nio and "soTimeout*50" for Apr. I have not
looked where it is actually set in the code, but in HTTP Connector
documentation there is not attribute "soTimeout"
- #close():
a) "The servlet should perform any needed cleanup as if it had
received an END or ERROR event."
Does it need to perform the cleanup?
The description of EventType.READ event here and in aio.html also
mentions to perform cleanup before calling cose().
>From description of SESSION_END subtype of END event my understanding
would be that
it would receive it (maybe unless it was called in END or ERROR
events) and could cleanup there.
So, what SESSION_END is for?
- (Javadoc for EventType, EventSubType has no , and thus will
be unreadable.)
- (In SESSION_END do s/session/Comet session/ and do the same
replacement in aio.html, to avoid ambiguity).
CometProcessor
a) ("When this interface is implemented, the service method of the servlet will
never be called".
-Actually the service() method will be called - It is called if the
connector does not support Comet,
as ChatServlet example shows. The same applies to CometFilter as well
).
aio.html
==
a) Is CometEvent object available only as an argument of the event() method?
Can it be stored by cometprocessor between the events that it receives?
Or only HttpServletResponse and HttpServletRequest can be stored and
reused between events?
Thus, can a servlet call the CometEvent.close() method while it is
between events?
b) Can CometProcessor#event() be called for several events for the same
request&response pair at the same time? I guess that it cannot happen.
c) It is said "At any time, the servlet may end processing of the
request by using the close method of the event object."
Nothing is said about such methods of Servlet API as
OutputStream.close(), InputStream.close().
I guess they should result in receiving an END event, and in the END
event the sevlet will call CometEvent.close() to stop Comet
processing.
d) It is good to know that many Response methods will throw
IllegalStateException as aio.html clearly says that the response is
committed after BEGIN event.
What if we never called flush() on the output stream? Is it still "committed"?
If it is committed only "after BEGIN event",
can the servlet or filter call response.sendError() while it is in BEGIN event?
e) If a Connector is stopped, will it be SERVER_SHUTDOWN subtype of END event.
Though I think that during shutdown maybe WEBAPP_RELOAD will come first?
Will the event come if connector is stopped through JMX?
When a web application is stopped will it be WEBAPP_RELOAD?
Can these events come asynchronously with regards to other
BEGIN/READ/END/ERROR events for the same request&response pair?
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
