DO NOT REPLY [Bug 51276] Startup time is too high if there are few JARs in "lib/" and a few webapps.

2011-05-30 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=51276

--- Comment #7 from Mark Thomas  2011-05-30 08:55:57 UTC ---
Your test cases are not representative of the typical jar handling within
Tomcat.

As is explained in the code commentary in the patch, Jars in web applications
are referenced via JNDI URLs. Using JarFile with these URLs (or any non-file
URL) triggers the creation of a full copy of the jar file in the temp
directory. This is significantly slower than accessing the jar with
JarInputStream.

The issue you are seeing is as a result of using shared jars. While supported,
such an approach is not recommended due to the complications it can create both
when upgrading and with memory leaks on reload with some libraries. The shared
jars are referenced via file URLs so the switch to JarInputStream will result
in a slow down in that case.

As per comment #4, I'll see if there is an easy way to switch to JarFile for
jars referenced via file URLs rather than JNDI URLs

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 51294] New: Since 7.0.12 do not work option unpackWARs=true for WARs outside appBase

2011-05-30 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=51294

 Bug #: 51294
   Summary: Since 7.0.12 do not work option unpackWARs=true for
WARs outside appBase
   Product: Tomcat 7
   Version: 7.0.12
  Platform: All
OS/Version: All
Status: NEW
  Severity: minor
  Priority: P2
 Component: Catalina
AssignedTo: dev@tomcat.apache.org
ReportedBy: deadu...@mail.ru
Classification: Unclassified


In 7.0.12 was added in Changelog this line:
--
Don't unpack WAR files if they are not located in the Host's appBase. (markt)
--
It's change method of deployment from older versions of Tomcat (5.5, 6.0,
7.0.11) and forced to change logics on early configured servers.

May be need to add new parameter like 'unpackExternalWARs=true' to be able to
configure this? (Why outside WARs is worse than inside?)

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1129429 - /tomcat/jk/trunk/native/iis/jk_isapi_plugin.c

2011-05-30 Thread timw 
Author: timw
Date: Mon May 30 23:16:54 2011
New Revision: 1129429

URL: http://svn.apache.org/viewvc?rev=1129429&view=rev
Log:
Fixing compile error

Modified:
tomcat/jk/trunk/native/iis/jk_isapi_plugin.c

Modified: tomcat/jk/trunk/native/iis/jk_isapi_plugin.c
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/iis/jk_isapi_plugin.c?rev=1129429&r1=1129428&r2=1129429&view=diff
==
--- tomcat/jk/trunk/native/iis/jk_isapi_plugin.c (original)
+++ tomcat/jk/trunk/native/iis/jk_isapi_plugin.c Mon May 30 23:16:54 2011
@@ -958,6 +958,7 @@ static int JK_METHOD start_response(jk_w
 status >= s->extension.use_server_error_pages) {
 if (status == JK_HTTP_UNAUTHORIZED) {
 int found = JK_FALSE;
+unsigned int h;
 for (h = 0; h < num_of_headers; h++) {
 if (!strcasecmp(header_names[h], "WWW-Authenticate")) {
 /*



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org