DO NOT REPLY [Bug 51260] ALLOW_HTTP_SEPARATORS_IN_V0 not 100% reliable

2011-05-25 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51260

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID

--- Comment #2 from Mark Thomas  2011-05-25 07:25:14 UTC ---
Control characters are never valid in an HTTP header. The code is working as
designed.

A change to provide a better log message in this case (i.e. so suitable copy of
the problematic header is included in the exception message) would be a
reasonable enhancement request.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 51240] maxConnections not honors config when acceptorThreadCount > 1

2011-05-25 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51240

--- Comment #2 from Mark Thomas  2011-05-25 07:30:50 UTC ---
I agree with Filip's comment re forcing acceptorThreadCount to 1 but I'd still
like to get to the bottom of why the maxConnections limit isn't being enforced.
I'll try and look at this today.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 43968] [patch] support ipv6 with mod_jk

2011-05-25 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=43968

--- Comment #3 from Eiji Takahashi  2011-05-25 09:01:07 UTC 
---
Created attachment 27058
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=27058
patch for 1.2.30

Patch for 1.2.30.
I did only an easy connection test.

<>
worker.ajp1.host=::1
worker.ajp1.port=8009

regards.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 43968] [patch] support ipv6 with mod_jk

2011-05-25 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=43968

--- Comment #4 from Eiji Takahashi  2011-05-25 09:01:43 UTC 
---
Created attachment 27059
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=27059
patch for trunk

Patch for trunk.
I did only an easy connection test.

<>
worker.ajp1.host=::1
worker.ajp1.port=8009

regards.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 51240] maxConnections not honors config when acceptorThreadCount > 1

2011-05-25 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51240

--- Comment #3 from Tim Whittington  2011-05-25 10:37:48 UTC 
---
It looks like there's a race condition between the acceptor thread being
permitted to accept a connection and updating the connection counter.

Two acceptor threads can pass the awaitConnection() condition, accept a
connection, and then both call countUp(). The connection count then goes above
the signal level and awaitConnection() blocking condition will never be met as
long as the connections stays above max (since CounterLatch appears to be
designed to count both up and down, it compares the signal level exactly).

The fix could be to remove countUp()/countDown(), change CounterLatch.await()
to an CounterLatch.awaitAndIncrement()/CounterLatch.awaitAndDecrement() pair
and have the connection count atomically updated in Sync.tryAcquireShared()
using AtomicLong.compareAndSet() with the +1/-1 delta passed in as the
argument.

e.g:

protected int tryAcquireShared(int delta) {
while (true) {
final long current = count.get();
if (!released && (current == signal)) {
return -1;
}
if (count.compareAndSet(current, current + delta)) {
return 1;
}
}
}

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 51264] New: Context/Manager/Store configuration proposal

2011-05-25 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51264

 Bug #: 51264
   Summary: Context/Manager/Store configuration proposal
   Product: Tomcat 7
   Version: unspecified
  Platform: PC
OS/Version: Windows XP
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
AssignedTo: dev@tomcat.apache.org
ReportedBy: gjblaj...@gmail.com
Classification: Unclassified


Why is it the Persistent Store Store element does not contain a means to
reference a database link defined in the globalnamingresources, for example:

This is what is required




  




BUT couldn’t the tomcat accept this?




  




That way the application developer does not need to know the username and
password to the production database server nor does it need to be packaged in
his/her war file.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 51264] Context/Manager/Store configuration proposal

2011-05-25 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51264

Mark Thomas  changed:

   What|Removed |Added

   Severity|normal  |enhancement

--- Comment #1 from Mark Thomas  2011-05-25 11:14:25 UTC ---
Patches welcome.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 51260] ALLOW_HTTP_SEPARATORS_IN_V0 not 100% reliable

2011-05-25 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51260

--- Comment #3 from Dan Checkoway  2011-05-25 12:47:17 
UTC ---
Mark, from an efficiency standpoint alone, I still think those logical
conditions should be reordered in the code (i.e. don't bother invoking
isHttpToken if separators are allowed). 

It just happens that a byproduct of that fix would be that it fixes my issue as
well...  :-)

But I'd definitely appreciate a more informative message if that's possible.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org