DO NOT REPLY [Bug 49555] Custom Taglibs should support all parameters

2011-04-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49555

--- Comment #6 from Rowan Seymour  2011-04-15 06:21:00 
EDT ---
(In reply to comment #5)
> This has been fixed in 6.0.x and will be included in 6.0.30 onwards.

Fix for this bug seems to have removed the ability to use EL functions in
classes which are not accessible to Catalina's class loader, i.e.
ELFunctionMapper now calls something like...

tccl = Thread.currentThread().getContextClassLoader();
clazz = Class.forName(className, true, tccl);

In our app we have custom loader that provides classes from plugins for the
application. Previously these plugins were able to provide their own EL
functions but that broke in 6.0.30

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 49555] Custom Taglibs should support all parameters

2011-04-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49555

--- Comment #7 from Mark Thomas  2011-04-15 07:39:50 EDT ---
The EL implementation assumes that the tccl will be the web application class
loader and that all classes used by the web applciation will be visible to that
class loader. Depending on why you need a custom class loader then there are a
couple of options available including a custom loader and the
VirtualWebappLoader. The users list is the place to get help on which is best
for your use case.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1092670 - /tomcat/trunk/java/org/apache/catalina/valves/ValveBase.java

2011-04-15 Thread markt
Author: markt
Date: Fri Apr 15 11:47:35 2011
New Revision: 1092670

URL: http://svn.apache.org/viewvc?rev=1092670&view=rev
Log:
Better comment

Modified:
tomcat/trunk/java/org/apache/catalina/valves/ValveBase.java

Modified: tomcat/trunk/java/org/apache/catalina/valves/ValveBase.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/ValveBase.java?rev=1092670&r1=1092669&r2=1092670&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/valves/ValveBase.java (original)
+++ tomcat/trunk/java/org/apache/catalina/valves/ValveBase.java Fri Apr 15 
11:47:35 2011
@@ -64,7 +64,7 @@ public abstract class ValveBase extends 
 
 //-- Instance Variables
 /**
- * Does this valve support async reporting
+ * Does this valve support Servlet 3+ async requests?
  */
 protected boolean asyncSupported;
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 51070] New: High inconsistent startup time

2011-04-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51070

   Summary: High inconsistent startup time
   Product: Tomcat 7
   Version: 7.0.12
  Platform: PC
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
AssignedTo: dev@tomcat.apache.org
ReportedBy: gvage...@gmail.com


We observed some high inconsistent times during the startup of Tomcat.
The startup times vary from 843ms to 7388ms every time Tomcat starts while
everything else stays constant.
We test on a clean Tomcat distribution with no applications deployed.
The versions we checked are 7.0.12 and 7.0.6

The tests have been done with two different PC with the following details.

Environment:

1. Ubuntu Linux 10.10 64-bit
   Kernel 2.6.35-28-generic
   Java version 1.6.0_21
2. Ubuntu Linux 10.10 64-bit
   Kernel 2.6.35-28-generic
   Java version 1.6.0.24

Could you please advice on that?

Regards
George

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 51070] High inconsistent startup time

2011-04-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51070

Konstantin Kolinko  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID

--- Comment #1 from Konstantin Kolinko  2011-04-15 
08:22:54 EDT ---
There is no bug in your description, nor enough specifics. If you enabled debug
logging and located the issue to some specific step in the startup sequence it
were more useful. One known cause of slow startup can be misconfigured entropy
source used by random numbers generator.

Note, that Bugzilla is not a support forum. Ask on the users mailing list. 
http://tomcat.apache.org/bugreport.html#Bugzilla_is_not_a_support_forum

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1092697 - in /tomcat/site/trunk: docs/findhelp.html xdocs/findhelp.xml

2011-04-15 Thread kkolinko
Author: kkolinko
Date: Fri Apr 15 13:16:48 2011
New Revision: 1092697

URL: http://svn.apache.org/viewvc?rev=1092697&view=rev
Log:
Amend the page. Be more reserved when directing users to bugzilla.

Modified:
tomcat/site/trunk/docs/findhelp.html
tomcat/site/trunk/xdocs/findhelp.xml

Modified: tomcat/site/trunk/docs/findhelp.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/findhelp.html?rev=1092697&r1=1092696&r2=1092697&view=diff
==
--- tomcat/site/trunk/docs/findhelp.html (original)
+++ tomcat/site/trunk/docs/findhelp.html Fri Apr 15 13:16:48 2011
@@ -217,9 +217,14 @@ of help are presented in the same order 
 
 The first resource to check is the documentation. In addition to the Tomcat
 documentation (make sure you check the documentation for the version you are
-using) you should also check the relevant Servlet and/or JSP Specification 
documents.
-Much of Tomcat's behaviour is determined by these specifcations and the 
information in
-them is not typically duplciated in the Tomcat documentation.
+using) you should also check the relevant Servlet and/or JSP
+http://wiki.apache.org/tomcat/Specifications";>Specification 
documents.
+Much of Tomcat's behaviour is determined by these specifications and the 
information in
+them is not typically duplicated in the Tomcat documentation.
+
+The documentation is searchable – see input box at the top of the
+page. To limit results to a specific major version of Apache Tomcat you can
+add the number to the search string, wrapping it in quotes, e.g. "6.0".
 
 The logs which Apache Tomcat generates can be a valuable resource when 
trying
 to diagnose a problem. Please review them. You may want to enable debug output
@@ -245,11 +250,10 @@ lists. The mailing 
 information on how to use the mailing lists as well as subscription
 instructions.
 
-If you think you have found a bug, please following the 
-bug reporting steps. Particularly if you are
-using an older version of Apache Tomcat, there is a good chance that the
-problem has been fixed so it is always worth searching the bug database to
-see if ths is the case.
+If you have found a bug or propose an enhancement, follow the documented
+bug reporting steps. Please note, that Bugzilla
+is not a support forum. If you need help with your problem, use the users
+mailing list.
 
 There is also an IRC channel dedicated to Tomcat.
 

Modified: tomcat/site/trunk/xdocs/findhelp.xml
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/findhelp.xml?rev=1092697&r1=1092696&r2=1092697&view=diff
==
--- tomcat/site/trunk/xdocs/findhelp.xml (original)
+++ tomcat/site/trunk/xdocs/findhelp.xml Fri Apr 15 13:16:48 2011
@@ -16,9 +16,14 @@ of help are presented in the same order 
 
 The first resource to check is the documentation. In addition to the Tomcat
 documentation (make sure you check the documentation for the version you are
-using) you should also check the relevant Servlet and/or JSP Specification 
documents.
-Much of Tomcat's behaviour is determined by these specifcations and the 
information in
-them is not typically duplciated in the Tomcat documentation.
+using) you should also check the relevant Servlet and/or JSP
+http://wiki.apache.org/tomcat/Specifications";>Specification 
documents.
+Much of Tomcat's behaviour is determined by these specifications and the 
information in
+them is not typically duplicated in the Tomcat documentation.
+
+The documentation is searchable – see input box at the top of the
+page. To limit results to a specific major version of Apache Tomcat you can
+add the number to the search string, wrapping it in quotes, e.g. "6.0".
 
 The logs which Apache Tomcat generates can be a valuable resource when 
trying
 to diagnose a problem. Please review them. You may want to enable debug output
@@ -44,11 +49,10 @@ lists. The mailing 
 information on how to use the mailing lists as well as subscription
 instructions.
 
-If you think you have found a bug, please following the 
-bug reporting steps. Particularly if you are
-using an older version of Apache Tomcat, there is a good chance that the
-problem has been fixed so it is always worth searching the bug database to
-see if ths is the case.
+If you have found a bug or propose an enhancement, follow the documented
+bug reporting steps. Please note, that Bugzilla
+is not a support forum. If you need help with your problem, use the users
+mailing list.
 
 There is also an IRC channel dedicated to Tomcat.
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GUMP@vmgump]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2011-04-15 Thread Bill Barker
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-validate has an issue affecting its community integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk-validate :  Tomcat 7.x, a web server implementing Java 
Servlet 3.0,
...


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on checkstyle exists, no need to add for property 
checkstyle.jar.
 -INFO- Failed with reason build failed



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/gump_work/build_tomcat-trunk_tomcat-trunk-validate.html
Work Name: build_tomcat-trunk_tomcat-trunk-validate (Type: Build)
Work ended in a state of : Failed
Elapsed: 1 sec
Command Line: /usr/lib/jvm/java-6-openjdk/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/checkstyle-5.3-SNAPSHOT.jar
 -Dexecute.validate=true validate 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-6-openjdk/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/packages/junit3.8.1/junit.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-5.3-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-16042011.jar:/srv/gump/public/workspace/apache-commons/cli/target/commons-cli-16042011.jar:/srv/gump/public/workspace/apache-commons/validator/dist/commons-validator-16042011.jar:/srv/gump/public/workspace/junit/dist/junit-16042011.jar:/srv/gump/public/workspace/junit/dist/junit-dep-16042011.ja
 
r:guava-gump-15042011.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-16042011.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-16042011.jar:/srv/gump/public/workspace/commons-collections-3.x/target/commons-collections-3.3-SNAPSHOT.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/jdom/build/jdom.jar:/srv/gump/public/workspace/velocity-engine/bin/velocity-16042011.jar:/srv/gump/public/workspace/velocity-engine/bin/velocity-16042011-dep.jar:/srv/gump/packages/javamail-1.4/mail.jar:/srv/gump/packages/javamail-1.4/lib/mailapi.jar:/srv/gump/packages/jaf-1.1ea/activation.jar
-
download-validate:

proxyflags:

setproxy:

testexist:
 [echo] Testing  for 
/srv/gump/public/workspace/checkstyle/target/checkstyle-5.3-SNAPSHOT.jar

downloadzip:

validate:
[mkdir] Created dir: 
/srv/gump/public/workspace/tomcat-trunk/output/res/checkstyle

BUILD FAILED
/srv/gump/public/workspace/tomcat-trunk/build.xml:429: Could not create type 
checkstyle due to java.lang.NoClassDefFoundError: 
com/google/common/collect/Lists
at 
com.puppycrawl.tools.checkstyle.CheckStyleTask.(CheckStyleTask.java:78)
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at 
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:57)
at 
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.lang.reflect.Constructor.newInstance(Constructor.java:532)
at 
org.apache.tools.ant.AntTypeDefinition.innerCreateAndSet(AntTypeDefinition.java:328)
at 
org.apache.tools.ant.AntTypeDefinition.createAndSet(AntTypeDefinition.java:274)
at 
org.apache.tools.ant.AntTypeDefinition.icreate(AntTypeDefinition.java:219)
at 
org.apache.tools.ant.AntTypeDefinition.create(AntTypeDefinition.java:206)
at 
org.apache.tools.ant.ComponentHelper.createComponent(ComponentHelper.java:286)
at 
org.apache.tools.ant.ComponentHelper.createComponent(ComponentHelper.java:264)
at 
org.apache.tools.ant.UnknownElement.makeObject(UnknownElement.java:417)
at 
org.apache.tools.ant.UnknownElement.maybeConfigure(UnknownElement.java:163)
at org.apache.tools.ant.Task.perform(Task.java:347)
at org.apac

DO NOT REPLY [Bug 51073] New: Misconfigured SSLProtocol with an AprEndpoint silently falls back to ALL

2011-04-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51073

   Summary: Misconfigured SSLProtocol with an AprEndpoint silently
falls back to ALL
   Product: Tomcat 7
   Version: unspecified
  Platform: All
OS/Version: All
Status: NEW
  Severity: major
  Priority: P2
 Component: Connectors
AssignedTo: dev@tomcat.apache.org
ReportedBy: co...@colinharrington.net


When configuring tomcat with an SSL Connector with an AprEndpoint (using the
Http11AprProtocol) if you misconfigure the SSLProtocol, the it silently falls
back to "all" which can be very dangerous.

For example this configuration may seem convincing:


The Documentation states valid values for the SSL protocol, but if the values
don't line up exactly it defaults to "ALL"
http://tomcat.apache.org/tomcat-7.0-doc/config/http.html#SSL%20Support 
SSLProtocol: 'Protocol which may be used for communicating with clients. The
default is "all", with other acceptable values being "SSLv2", "SSLv3", "TLSv1"
and "SSLv2+SSLv3".'

Misconfiguration of an SSLProtocol should never silently fall back to enabling
all protocols.  At minimum, misconfiguration of this value should result in
logged error messages.  Since SSLv2 is vulnerable to several attacks known to
have some serious security flaws even allowing the possibility of
man-in-the-middle attacks, I think a misconfiguration should cause the
connector to fail.

@See
http://svn.apache.org/repos/asf/tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

I think that "all" should be specifically allowed (along with "" or null), and
all other unexpected values should fail loudly.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org