[Tomcat Wiki] Update of "PythonLanguage" by DanielBaktiar
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "PythonLanguage" page has been changed by DanielBaktiar. The comment on this change is: remove stale links, add the current Python wiki link. http://wiki.apache.org/tomcat/PythonLanguage?action=diff&rev1=4&rev2=5 -- ##language:en - Python is a dynamic object-oriented language. + Python is a dynamic, interpreted, interactive object-oriented language, built to be somewhere between mid-level language C and shell script. Python includes a lot of libraries out-of-the-box (motto: "battery included"). Links: + * [http://www.python.org/ Python Official Homepage] + * [http://wiki.python.org/ Python Official Wiki] - * http://www.python.org/ - * [[EfnetPythonWiki:FrontPage|#python Wiki]] - * http://python.faqts.com - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Tomcat Wiki] Trivial Update of "PythonLanguage" by DanielBaktiar
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "PythonLanguage" page has been changed by DanielBaktiar. The comment on this change is: tidy up wiki links. http://wiki.apache.org/tomcat/PythonLanguage?action=diff&rev1=5&rev2=6 -- Python is a dynamic, interpreted, interactive object-oriented language, built to be somewhere between mid-level language C and shell script. Python includes a lot of libraries out-of-the-box (motto: "battery included"). Links: - * [http://www.python.org/ Python Official Homepage] + * [[http://www.python.org/|Python Official Homepage]] - * [http://wiki.python.org/ Python Official Wiki] + * [[http://wiki.python.org/|Python Official Wiki]] - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49217] Accepting java keyword in EL
https://issues.apache.org/bugzilla/show_bug.cgi?id=49217 eldar.kama...@db.com changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED | --- Comment #11 from eldar.kama...@db.com 2011-03-02 04:06:44 EST --- Does not work in 7.0.4 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50850] Accepting java keyword in EL
https://issues.apache.org/bugzilla/show_bug.cgi?id=50850 Bug 50850 depends on bug 49217, which changed state. Bug 49217 Summary: Accepting java keyword in EL https://issues.apache.org/bugzilla/show_bug.cgi?id=49217 What|Old Value |New Value Status|RESOLVED|REOPENED Resolution|FIXED | -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49217] Accepting java keyword in EL
https://issues.apache.org/bugzilla/show_bug.cgi?id=49217 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||FIXED --- Comment #12 from Mark Thomas 2011-03-02 04:51:19 EST --- (In reply to comment #11) > Does not work in 7.0.4 Tomcat's 7's behaviour is as per the EL specification although the identifier check can be disabled as a temporary work-around for non-specification compliant applications. If you have any further questions on this, the users list is the place to seek help. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50850] Accepting java keyword in EL
https://issues.apache.org/bugzilla/show_bug.cgi?id=50850 Bug 50850 depends on bug 49217, which changed state. Bug 49217 Summary: Accepting java keyword in EL https://issues.apache.org/bugzilla/show_bug.cgi?id=49217 What|Old Value |New Value Status|REOPENED|RESOLVED Resolution||FIXED -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1074675 - in /tomcat/trunk: java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ webapps/docs/
On 01/03/2011 16:50, Filip Hanik - Dev Lists wrote: > On 2/28/2011 5:27 PM, Mark Thomas wrote: >> On 01/03/2011 00:16, Filip Hanik - Dev Lists wrote: >>> 4. SSLAuthenticator should have a flag to fail directly without trying >>> to reneg if the connector is misconfigured to avoid reneg for clients >>> vulnerable to the man in the middle reneg attack >> I don't understand what you mean in point 4. Could you try and expand on >> that. > Sure, a renegotiation with a non updated client, IIRC would bring > CVE-2009-3555 SSL Man-In-The-Middle attack. > Hence, some sysadmins should have the configuration option to only allow > the initial handshake. > Add in a flag that would say disableRenegotiation="true" (or similar). > Meaning, the only time the valve would work, is if the clientAuth="true" > in the connector. Ah, got it. That should be doable. Need to be careful that the SSLAuthenticator can correctly distinguish between the two cases but there should be enough information around already without the need to add another configuration option. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1075956 - /tomcat/trunk/java/org/apache/tomcat/util/net/SecureNioChannel.java
On 01/03/2011 18:13, fha...@apache.org wrote: > Author: fhanik > Date: Tue Mar 1 18:13:38 2011 > New Revision: 1075956 > > URL: http://svn.apache.org/viewvc?rev=1075956&view=rev > Log: > Simple implementation of a forced and blocking renegotiation with a SSL client Your simple is a heck of a lot more comprehensive that the second attempt I have in front of me. It looks great. I make some changes along the way to the unit tests as well. It looks like you spotted a number of the same issues I did. I'll merge in my changes. Cheers, Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1076178 - /tomcat/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java
Author: markt
Date: Wed Mar 2 11:43:06 2011
New Revision: 1076178
URL: http://svn.apache.org/viewvc?rev=1076178&view=rev
Log:
Save a few cycles
Modified:
tomcat/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java
Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java?rev=1076178&r1=1076177&r2=1076178&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java
(original)
+++ tomcat/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java Wed Mar
2 11:43:06 2011
@@ -643,7 +643,9 @@ public class Http11NioProcessor extends
}
try {
-Object sslO = sslSupport.getPeerCertificateChain(true);
+// use force=false since re-negotiation is handled above
+// (and it is a NO-OP for NIO anyway)
+Object sslO = sslSupport.getPeerCertificateChain(false);
if( sslO != null) {
request.setAttribute
(SSLSupport.CERTIFICATE_KEY, sslO);
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1076182 - in /tomcat/trunk/test/org/apache/tomcat/util/net: TestClientCert.java TestSsl.java TesterSupport.java
Author: markt
Date: Wed Mar 2 12:03:05 2011
New Revision: 1076182
URL: http://svn.apache.org/viewvc?rev=1076182&view=rev
Log:
Correct issues in the SSL renegotiation tests
Modified:
tomcat/trunk/test/org/apache/tomcat/util/net/TestClientCert.java
tomcat/trunk/test/org/apache/tomcat/util/net/TestSsl.java
tomcat/trunk/test/org/apache/tomcat/util/net/TesterSupport.java
Modified: tomcat/trunk/test/org/apache/tomcat/util/net/TestClientCert.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/tomcat/util/net/TestClientCert.java?rev=1076182&r1=1076181&r2=1076182&view=diff
==
--- tomcat/trunk/test/org/apache/tomcat/util/net/TestClientCert.java (original)
+++ tomcat/trunk/test/org/apache/tomcat/util/net/TestClientCert.java Wed Mar 2
12:03:05 2011
@@ -44,6 +44,10 @@ public class TestClientCert extends Tomc
public static final byte DATA = (byte)33;
public void testClientCertGet() throws Exception {
+if (!TesterSupport.isRenegotiationSupported(getTomcatInstance())) {
+return;
+}
+
// Unprotected resource
ByteChunk res =
getUrl("https://localhost:"; + getPort() + "/unprotected");
@@ -74,6 +78,9 @@ public class TestClientCert extends Tomc
public void doTestClientCertPost(int bodySize, boolean expectProtectedFail)
throws Exception {
+if (!TesterSupport.isRenegotiationSupported(getTomcatInstance())) {
+return;
+}
byte[] body = new byte[bodySize];
Arrays.fill(body, DATA);
@@ -105,11 +112,6 @@ public class TestClientCert extends Tomc
Tomcat tomcat = getTomcatInstance();
-String protocol = tomcat.getConnector().getProtocolHandlerClassName();
-if (protocol.indexOf("Apr") != -1) {
-return; // Disabled by default in 1.1.20 windows binary
(2010-07-27)
-}
-
TesterSupport.initSsl(tomcat);
// Need a web application with a protected and unprotected URL
Modified: tomcat/trunk/test/org/apache/tomcat/util/net/TestSsl.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/tomcat/util/net/TestSsl.java?rev=1076182&r1=1076181&r2=1076182&view=diff
==
--- tomcat/trunk/test/org/apache/tomcat/util/net/TestSsl.java (original)
+++ tomcat/trunk/test/org/apache/tomcat/util/net/TestSsl.java Wed Mar 2
12:03:05 2011
@@ -16,10 +16,13 @@
*/
package org.apache.tomcat.util.net;
+import java.io.BufferedReader;
import java.io.File;
import java.io.IOException;
import java.io.InputStream;
+import java.io.InputStreamReader;
import java.io.OutputStream;
+import java.io.Reader;
import javax.net.ssl.HandshakeCompletedEvent;
import javax.net.ssl.HandshakeCompletedListener;
@@ -97,101 +100,77 @@ public class TestSsl extends TomcatBaseT
// Make sure the NIO connector has read the request before the
handshake
Thread.sleep(100);
+
socket.startHandshake();
-handshakeDone = false;
-byte[] b = new byte[0];
-int maxTries = 5; // 5 sec should be enough - in NIO we'll timeout
-socket.setSoTimeout(1000);
-for (int i = 0; i < maxTries; i++) {
-try {
-is.read(b);
-} catch (IOException e) {
-// timeout
-}
-if (handshakeDone) {
-break;
-}
-}
+
os = socket.getOutputStream();
-if (!handshakeDone) {
-// success - we timedout without handshake
-return;
-}
+
try {
os.write("Host: localhost\n\n".getBytes());
} catch (IOException ex) {
-// success - connection closed
+ex.printStackTrace();
+fail("Re-negotiation failed");
+}
+Reader r = new InputStreamReader(is);
+BufferedReader br = new BufferedReader(r);
+String line = br.readLine();
+while (line != null) {
+// For testing System.out.println(line);
+line = br.readLine();
+}
+
+if (!handshakeDone) {
+// success - we timed-out without handshake
return;
}
fail("Re-negotiation worked");
-
}
public void testRenegotiateWorks() throws Exception {
Tomcat tomcat = getTomcatInstance();
+if (!TesterSupport.isRenegotiationSupported(tomcat)) {
+return;
+}
+
File appDir = new File(getBuildDirectory(), "webapps/examples");
// app dir is relative to server home
tomcat.addWebapp(null, "/examples", appDir.getAbsolutePath());
TesterSupport.initSsl(tomcat);
-// Enable MITM attack
-tomcat.getConnector().setAttribute("allowUnsafeLegacyRenegotiation",
"true");
-
svn commit: r1076190 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Wed Mar 2 12:30:54 2011 New Revision: 1076190 URL: http://svn.apache.org/viewvc?rev=1076190&view=rev Log: Vote for better patch Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1076190&r1=1076189&r2=1076190&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Wed Mar 2 12:30:54 2011 @@ -122,13 +122,8 @@ PATCHES PROPOSED TO BACKPORT: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48863 Provide an warning if there is a problem with a class path entry but use debug level logging if it is expected due to catalina home/base split - http://people.apache.org/~markt/patches/2011-02-28-bug48863-tc6.patch - +1: markt - -1: - - Improved patch (added r1076059): http://people.apache.org/~kkolinko/patches/2011-03-02_tc6_48863.patch - +1: kkolinko + +1: kkolinko, markt -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=28852 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1076197 - /tomcat/trunk/test/org/apache/tomcat/util/net/TestCustomSsl.java
Author: markt
Date: Wed Mar 2 12:42:34 2011
New Revision: 1076197
URL: http://svn.apache.org/viewvc?rev=1076197&view=rev
Log:
Better test for APR
Modified:
tomcat/trunk/test/org/apache/tomcat/util/net/TestCustomSsl.java
Modified: tomcat/trunk/test/org/apache/tomcat/util/net/TestCustomSsl.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/tomcat/util/net/TestCustomSsl.java?rev=1076197&r1=1076196&r2=1076197&view=diff
==
--- tomcat/trunk/test/org/apache/tomcat/util/net/TestCustomSsl.java (original)
+++ tomcat/trunk/test/org/apache/tomcat/util/net/TestCustomSsl.java Wed Mar 2
12:42:34 2011
@@ -50,7 +50,7 @@ public class TestCustomSsl extends Tomca
Tomcat tomcat = getTomcatInstance();
Connector connector = tomcat.getConnector();
-if (connector.getProtocol().indexOf("Apr") > -1) {
+if (connector.getProtocolHandlerClassName().contains("Apr")) {
// This test is only for JSSE based SSL connectors
return;
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1076206 - /tomcat/trunk/webapps/docs/changelog.xml
Author: markt Date: Wed Mar 2 13:17:37 2011 New Revision: 1076206 URL: http://svn.apache.org/viewvc?rev=1076206&view=rev Log: Update change log Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1076206&r1=1076205&r2=1076206&view=diff == --- tomcat/trunk/webapps/docs/changelog.xml (original) +++ tomcat/trunk/webapps/docs/changelog.xml Wed Mar 2 13:17:37 2011 @@ -56,6 +56,15 @@ + + + +49284: Add SSL re-negotiation support to the HTTP NIO +connector and extend test cases to cover CLIENT-CERT authentication. +(fhanik/markt) + + + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1076212 - in /tomcat/trunk: java/org/apache/naming/resources/DirContextURLConnection.java webapps/docs/changelog.xml
Author: markt
Date: Wed Mar 2 13:23:37 2011
New Revision: 1076212
URL: http://svn.apache.org/viewvc?rev=1076212&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=27988
Improve reporting of missing files
Modified:
tomcat/trunk/java/org/apache/naming/resources/DirContextURLConnection.java
tomcat/trunk/webapps/docs/changelog.xml
Modified:
tomcat/trunk/java/org/apache/naming/resources/DirContextURLConnection.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/naming/resources/DirContextURLConnection.java?rev=1076212&r1=1076211&r2=1076212&view=diff
==
--- tomcat/trunk/java/org/apache/naming/resources/DirContextURLConnection.java
(original)
+++ tomcat/trunk/java/org/apache/naming/resources/DirContextURLConnection.java
Wed Mar 2 13:23:37 2011
@@ -342,7 +342,8 @@ public class DirContextURLConnection
if (object != null)
return object;
-throw new FileNotFoundException();
+throw new FileNotFoundException(
+getURL() == null ? "null" : getURL().toString());
}
@@ -378,7 +379,8 @@ public class DirContextURLConnection
connect();
if (resource == null) {
-throw new FileNotFoundException();
+throw new FileNotFoundException(
+getURL() == null ? "null" : getURL().toString());
}
// Reopen resource
@@ -418,7 +420,8 @@ public class DirContextURLConnection
}
if ((resource == null) && (collection == null)) {
-throw new FileNotFoundException();
+throw new FileNotFoundException(
+getURL() == null ? "null" : getURL().toString());
}
Vector result = new Vector();
@@ -446,7 +449,8 @@ public class DirContextURLConnection
}
} catch (NamingException e) {
// Unexpected exception
-throw new FileNotFoundException();
+throw new FileNotFoundException(
+getURL() == null ? "null" : getURL().toString());
}
}
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1076212&r1=1076211&r2=1076212&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Wed Mar 2 13:23:37 2011
@@ -46,6 +46,9 @@
+27988: Improve reporting of missing files. (markt)
+
+
28852: Add URL encoding where missing to parameters in URLs
presented by Ant tasks to the Manager application. Based on a patch by
Stephane Bailliez. (mark)
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1076214 - in /tomcat: tc5.5.x/trunk/STATUS.txt tc6.0.x/trunk/STATUS.txt
Author: markt Date: Wed Mar 2 13:25:55 2011 New Revision: 1076214 URL: http://svn.apache.org/viewvc?rev=1076214&view=rev Log: Proposal Modified: tomcat/tc5.5.x/trunk/STATUS.txt tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=1076214&r1=1076213&r2=1076214&view=diff == --- tomcat/tc5.5.x/trunk/STATUS.txt (original) +++ tomcat/tc5.5.x/trunk/STATUS.txt Wed Mar 2 13:25:55 2011 @@ -60,3 +60,9 @@ PATCHES PROPOSED TO BACKPORT: http://svn.apache.org/viewvc?rev=1075458&view=rev +1: markt, kkolinko -1: + +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=27988 + Improve reporting of missing files + http://svn.apache.org/viewvc?rev=1076212&view=rev + +1: markt + -1: Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1076214&r1=1076213&r2=1076214&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Wed Mar 2 13:25:55 2011 @@ -133,3 +133,9 @@ PATCHES PROPOSED TO BACKPORT: http://svn.apache.org/viewvc?rev=1075458&view=rev +1: markt, kkolinko -1: + +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=27988 + Improve reporting of missing files + http://svn.apache.org/viewvc?rev=1076212&view=rev + +1: markt + -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49217] Accepting java keyword in EL
https://issues.apache.org/bugzilla/show_bug.cgi?id=49217 eldar.kama...@db.com changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED | --- Comment #13 from eldar.kama...@db.com 2011-03-02 08:29:37 EST --- > > If you have any further questions on this, the users list is the place to seek > help. OK, can you point me to the "users list"? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50850] Accepting java keyword in EL
https://issues.apache.org/bugzilla/show_bug.cgi?id=50850 Bug 50850 depends on bug 49217, which changed state. Bug 49217 Summary: Accepting java keyword in EL https://issues.apache.org/bugzilla/show_bug.cgi?id=49217 What|Old Value |New Value Status|RESOLVED|REOPENED Resolution|FIXED | -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 27988] Unhelpful FileNotFoundException raised
https://issues.apache.org/bugzilla/show_bug.cgi?id=27988 Mark Thomas changed: What|Removed |Added Component|Catalina|Catalina Version|4.1.29 |5.5.33 Product|Tomcat 4|Tomcat 5 --- Comment #2 from Mark Thomas 2011-03-02 08:30:41 EST --- The TLD scanning was completely re-written for Tomcat 7 so the error messages there should be a lot better. I have added the URL (where it isn't null) to the Exception message so it is available for any other code paths that may trigger it. This change has been made to 7.0.x and will be included in 7.0.9 onwards. I have also proposed the same change for 6.0.x and 5.5.x. Since 5.5.x is the oldest currently supported version, I am moving this bug to that version. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49217] Accepting java keyword in EL
https://issues.apache.org/bugzilla/show_bug.cgi?id=49217 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||FIXED -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50850] Accepting java keyword in EL
https://issues.apache.org/bugzilla/show_bug.cgi?id=50850 Bug 50850 depends on bug 49217, which changed state. Bug 49217 Summary: Accepting java keyword in EL https://issues.apache.org/bugzilla/show_bug.cgi?id=49217 What|Old Value |New Value Status|REOPENED|RESOLVED Resolution||FIXED -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50850] Accepting java keyword in EL
https://issues.apache.org/bugzilla/show_bug.cgi?id=50850 Mark Thomas changed: What|Removed |Added Depends on|49217 | --- Comment #2 from Mark Thomas 2011-03-02 08:33:09 EST --- "Depends on" updates are getting annoying -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49217] Accepting java keyword in EL
https://issues.apache.org/bugzilla/show_bug.cgi?id=49217 Mark Thomas changed: What|Removed |Added Blocks|50850 | -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 27091] path attribute must not be required in ant task install
https://issues.apache.org/bugzilla/show_bug.cgi?id=27091 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||WONTFIX --- Comment #6 from Mark Thomas 2011-03-02 08:41:02 EST --- The install task has been deprecated/removed. There are related issues with the deploy task but there are separate bugs (e.g. 47467) covering those issues. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1076218 - /tomcat/trunk/java/org/apache/catalina/security/SecurityListener.java
Author: markt
Date: Wed Mar 2 13:48:16 2011
New Revision: 1076218
URL: http://svn.apache.org/viewvc?rev=1076218&view=rev
Log:
Fix Javadoc
Modified:
tomcat/trunk/java/org/apache/catalina/security/SecurityListener.java
Modified: tomcat/trunk/java/org/apache/catalina/security/SecurityListener.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/security/SecurityListener.java?rev=1076218&r1=1076217&r2=1076218&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/security/SecurityListener.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/security/SecurityListener.java Wed
Mar 2 13:48:16 2011
@@ -72,8 +72,8 @@ public class SecurityListener implements
* effectively disables this check. User names will always be checked in a
* case insensitive manner.
*
- * @param userList A comma separated list of operating system users not
- * permitted to run Tomcat
+ * @param userNameList A comma separated list of operating system users
not
+ * permitted to run Tomcat
*/
public void setCheckedOsUsers(String userNameList) {
if (userNameList == null || userNameList.length() == 0) {
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 25273] Exception processing TLD at resource path - say where it is really looking for this file
https://issues.apache.org/bugzilla/show_bug.cgi?id=25273 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WONTFIX --- Comment #3 from Mark Thomas 2011-03-02 08:53:11 EST --- Tomcat 7 has improved TLD scanning that doe shave more explicit error messages. That said, a system admin really should know where the context is being served from. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1076222 - /tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java
Author: markt
Date: Wed Mar 2 13:55:19 2011
New Revision: 1076222
URL: http://svn.apache.org/viewvc?rev=1076222&view=rev
Log:
Remove unused code
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java
Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java?rev=1076222&r1=1076221&r2=1076222&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java Wed Mar
2 13:55:19 2011
@@ -73,37 +73,6 @@ public abstract class AbstractEndpoint {
UNBOUND, BOUND_ON_INIT, BOUND_ON_START
}
-// Standard SSL Configuration attributes
-// JSSE
-// Standard configuration attribute names
-public static final String SSL_ATTR_ALGORITHM = "algorithm";
-public static final String SSL_ATTR_CLIENT_AUTH = "clientAuth";
-public static final String SSL_ATTR_KEYSTORE_FILE = "keystoreFile";
-public static final String SSL_ATTR_KEYSTORE_PASS = "keystorePass";
-public static final String SSL_ATTR_KEYSTORE_TYPE = "keystoreType";
-public static final String SSL_ATTR_KEYSTORE_PROVIDER = "keystoreProvider";
-public static final String SSL_ATTR_SSL_PROTOCOL = "sslProtocol";
-public static final String SSL_ATTR_CIPHERS = "ciphers";
-public static final String SSL_ATTR_KEY_ALIAS = "keyAlias";
-public static final String SSL_ATTR_KEY_PASS = "keyPass";
-public static final String SSL_ATTR_TRUSTSTORE_FILE = "truststoreFile";
-public static final String SSL_ATTR_TRUSTSTORE_PASS = "truststorePass";
-public static final String SSL_ATTR_TRUSTSTORE_TYPE = "truststoreType";
-public static final String SSL_ATTR_TRUSTSTORE_PROVIDER =
-"truststoreProvider";
-public static final String SSL_ATTR_TRUSTSTORE_ALGORITHM =
-"truststoreAlgorithm";
-public static final String SSL_ATTR_CRL_FILE =
-"crlFile";
-public static final String SSL_ATTR_TRUST_MAX_CERT_LENGTH =
-"trustMaxCertLength";
-public static final String SSL_ATTR_SESSION_CACHE_SIZE =
-"sessionCacheSize";
-public static final String SSL_ATTR_SESSION_TIMEOUT =
-"sessionTimeout";
-public static final String SSL_ATTR_ALLOW_UNSAFE_RENEG =
-"allowUnsafeLegacyRenegotiation";
-
private static final int INITIAL_ERROR_DELAY = 50;
private static final int MAX_ERROR_DELAY = 1600;
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50854] New: Additional catalina.policy entries for when Security Manager enabled, for session display functionality
https://issues.apache.org/bugzilla/show_bug.cgi?id=50854
Summary: Additional catalina.policy entries for when Security
Manager enabled, for session display functionality
Product: Tomcat 7
Version: unspecified
Platform: All
OS/Version: All
Status: NEW
Severity: normal
Priority: P2
Component: Manager
AssignedTo: dev@tomcat.apache.org
ReportedBy: ne...@metawerx.net
When running under a security manager, in 7.0.x (and also around 6.0.29+), the
Sessions List options in the Tomcat Manager may display an error under certain
conditions.
CONDITION 1:
APR enabled, catalina.base == catalina.home:
- Encountered exception org.apache.jasper.JasperException:
javax.servlet.ServletException: java.lang.NoClassDefFoundError:
org/apache/catalina/ha/session/DeltaSession
This permission is required:
permission java.lang.RuntimePermission
"accessClassInPackage.org.apache.catalina.ha.*";
CONDITION 2:
Regardless of APR, if catalina.base != catalina.home and catalina.home is the
location of the webapps/manager application, this error displays:
FAIL - Encountered exception org.apache.jasper.JasperException: An exception
occurred processing JSP page /WEB-INF/jsp/sessionsList.jsp at line 99
96:
97: <% Iterator iter = activeSessions.iterator();
98:while (iter.hasNext()) {
99:Session currentSession = (Session) iter.next();
100:String currentSessionId =
JspHelper.escapeXml(currentSession.getId());
101: %>
102:
This is because the policy file assumes there is a per-instance webapps/manager
application in catalina.base, as opposed to a shared one in catalina.home.
Suggested fix, in catalina.policy, replace ...
// The Manager application needs access to the following packages to support
the
// session display functionality
grant codeBase "file:${catalina.base}/webapps/manager/-" {
permission java.lang.RuntimePermission
"accessClassInPackage.org.apache.catalina";
permission java.lang.RuntimePermission
"accessClassInPackage.org.apache.catalina.manager";
permission java.lang.RuntimePermission
"accessClassInPackage.org.apache.catalina.manager.util";
permission java.lang.RuntimePermission
"accessClassInPackage.org.apache.catalina.ha.*";
};
... with ...
// The Manager application needs access to the following packages to support
the
// session display functionality
grant codeBase "file:${catalina.home}/webapps/manager/-" {
permission java.lang.RuntimePermission
"accessClassInPackage.org.apache.catalina";
permission java.lang.RuntimePermission
"accessClassInPackage.org.apache.catalina.manager";
permission java.lang.RuntimePermission
"accessClassInPackage.org.apache.catalina.manager.util";
permission java.lang.RuntimePermission
"accessClassInPackage.org.apache.catalina.ha.*";
};
// If using a per instance webapps directory, i.e. ${catalina.base}/webapps,
// then the following permission will need to be uncommented
// grant codeBase "file:${catalina.base}/webapps/manager/-" {
// permission java.lang.RuntimePermission
"accessClassInPackage.org.apache.catalina";
// permission java.lang.RuntimePermission
"accessClassInPackage.org.apache.catalina.manager";
// permission java.lang.RuntimePermission
"accessClassInPackage.org.apache.catalina.manager.util";
// permission java.lang.RuntimePermission
"accessClassInPackage.org.apache.catalina.ha.*";
// };
* In the above, I've used the same commented-out approach as the one for the
"file:${catalina.base}/lib/-" permissions for consistency, but the
catalina.base permissions could also be left uncommented if most installations
copy the default webapps folder into each instance and use it from there, to
make larger deployments easier.
Best Regards,
Neale Rudd
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1076249 - in /tomcat/trunk: java/org/apache/catalina/core/ThreadLocalLeakPreventionListener.java webapps/docs/changelog.xml
Author: markt
Date: Wed Mar 2 15:19:58 2011
New Revision: 1076249
URL: http://svn.apache.org/viewvc?rev=1076249&view=rev
Log:
Speed up shut down when ThreadLocalLeakPreventionListener is enabled
Modified:
tomcat/trunk/java/org/apache/catalina/core/ThreadLocalLeakPreventionListener.java
tomcat/trunk/webapps/docs/changelog.xml
Modified:
tomcat/trunk/java/org/apache/catalina/core/ThreadLocalLeakPreventionListener.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/ThreadLocalLeakPreventionListener.java?rev=1076249&r1=1076248&r2=1076249&view=diff
==
---
tomcat/trunk/java/org/apache/catalina/core/ThreadLocalLeakPreventionListener.java
(original)
+++
tomcat/trunk/java/org/apache/catalina/core/ThreadLocalLeakPreventionListener.java
Wed Mar 2 15:19:58 2011
@@ -53,10 +53,13 @@ import org.apache.tomcat.util.threads.Th
*
*/
public class ThreadLocalLeakPreventionListener implements LifecycleListener,
-ContainerListener {
+ContainerListener {
+
private static final Log log =
LogFactory.getLog(ThreadLocalLeakPreventionListener.class);
+private volatile boolean serverStopping = false;
+
/**
* The string manager for this package.
*/
@@ -72,7 +75,7 @@ public class ThreadLocalLeakPreventionLi
try {
Lifecycle lifecycle = event.getLifecycle();
if (Lifecycle.AFTER_START_EVENT.equals(event.getType()) &&
-lifecycle instanceof Server) {
+lifecycle instanceof Server) {
// when the server starts, we register ourself as listener for
// all context
// as well as container event listener so that we know when new
@@ -81,8 +84,15 @@ public class ThreadLocalLeakPreventionLi
registerListenersForServer(server);
}
+if (Lifecycle.BEFORE_STOP_EVENT.equals(event.getType()) &&
+lifecycle instanceof Server) {
+// Server is shutting down, so thread pools will be shut down
so
+// there is no need to clean the threads
+serverStopping = true;
+}
+
if (Lifecycle.AFTER_STOP_EVENT.equals(event.getType()) &&
-lifecycle instanceof Context) {
+lifecycle instanceof Context) {
stopIdleThreads((Context) lifecycle);
}
} catch (Exception e) {
@@ -182,6 +192,8 @@ public class ThreadLocalLeakPreventionLi
*of its parent Service.
*/
private void stopIdleThreads(Context context) {
+if (serverStopping) return;
+
if (context instanceof StandardContext &&
!((StandardContext) context).getRenewThreadsWhenStoppingContext())
{
log.debug("Not renewing threads when the context is stopping, "
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1076249&r1=1076248&r2=1076249&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Wed Mar 2 15:19:58 2011
@@ -57,6 +57,10 @@
Improve handling of SSL renegotiation by failing earlier when the
request body contains more bytes than maxSavePostSize. (markt)
+
+Improve shut down speed by not renewing threads during shut down when
+the ThreadLocalLeakPreventionListener is enabled. (markt)
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1076212 - in /tomcat/trunk: java/org/apache/naming/resources/DirContextURLConnection.java webapps/docs/changelog.xml
2011/3/2 :
> Author: markt
> Date: Wed Mar 2 13:23:37 2011
> New Revision: 1076212
>
> URL: http://svn.apache.org/viewvc?rev=1076212&view=rev
> Log:
> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=27988
> Improve reporting of missing files
>
> Modified:
> tomcat/trunk/java/org/apache/naming/resources/DirContextURLConnection.java
> tomcat/trunk/webapps/docs/changelog.xml
>
>
> - throw new FileNotFoundException();
> + throw new FileNotFoundException(
> + getURL() == null ? "null" : getURL().toString());
There is simpler code that does the same as the above line:
String.valueOf(getURL())
> @@ -378,7 +379,8 @@ public class DirContextURLConnection
> connect();
>
> if (resource == null) {
> - throw new FileNotFoundException();
> + throw new FileNotFoundException(
> + getURL() == null ? "null" : getURL().toString());
> }
>
> // Reopen resource
> @@ -418,7 +420,8 @@ public class DirContextURLConnection
> }
>
> if ((resource == null) && (collection == null)) {
> - throw new FileNotFoundException();
> + throw new FileNotFoundException(
> + getURL() == null ? "null" : getURL().toString());
> }
>
> Vector result = new Vector();
> @@ -446,7 +449,8 @@ public class DirContextURLConnection
> }
> } catch (NamingException e) {
> // Unexpected exception
> - throw new FileNotFoundException();
> + throw new FileNotFoundException(
> + getURL() == null ? "null" : getURL().toString());
> }
> }
>
Best regards,
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49217] Accepting java keyword in EL
https://issues.apache.org/bugzilla/show_bug.cgi?id=49217 --- Comment #14 from Konstantin Kolinko 2011-03-02 10:56:12 EST --- (In reply to comment #13) > OK, can you point me to the "users list"? http://tomcat.apache.org/bugreport.html#Bugzilla_is_not_a_support_forum has the link -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50855] New: NullPointerException thrown in AuthenticatorBase.register method for null principal
https://issues.apache.org/bugzilla/show_bug.cgi?id=50855
Summary: NullPointerException thrown in
AuthenticatorBase.register method for null principal
Product: Tomcat 7
Version: 7.0.6
Platform: PC
OS/Version: Windows XP
Status: NEW
Severity: normal
Priority: P2
Component: Catalina
AssignedTo: dev@tomcat.apache.org
ReportedBy: dorin.bala...@bnm.md
The description is the same as for the older bug 39255, except it is produced
at
org.apache.catalina.authenticator.AuthenticatorBase.register(AuthenticatorBase.java:688)
Please, see the following link
https://issues.apache.org/bugzilla/show_bug.cgi?id=39255
This bug has been fixed for Tomcat 5.5.16, but it looks to appear again in
Tomcat 7.
This is the excerpt from AuthenticatorBase.java:
public void register(Request request, HttpServletResponse response,
Principal principal, String authType,
String username, String password) {
if (log.isDebugEnabled())
log.debug("Authenticated '" + principal.getName() + "' with type '"
+ authType + "'");
It is seen that there is no more condition to verify if principal is null.
Specifically, the NullPointerException is thrown when calling
HttpServletRequest.logout method from a JSF managed bean. According to Java EE
6 documentation, the logout method establishes null as the value returned when
getUserPrincipal, getRemoteUser, and getAuthType is called on the request.
Hence, the exception thrown.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[SECURITY] Tomcat 7 ignores @ServletSecurity annotations
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 As reported on the users list [1], both Tomcat 7.0.8 and the latest Tomcat 7 code from svn appear to ignore @ServletSecurity annotations. Assuming this issue is confirmed, it may lead to authentication bypass and information disclosure. The exact details are still being investigated but this e-mail is being provided to give users early warning of this public issue. If code changes are required to address this, they will be included in the next release of Tomcat 7, 7.0.10. The release process for 7.0.10 is expected to start once the investigation of this issue is complete. Mark on behalf of the Apache Tomcat security team [1] http://markmail.org/message/yzmyn44f5aetmm2r -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJNbnT/AAoJEBDAHFovYFnnfuMQAKwsYR44UklP4LH1n4m+pBby OUDiW0nbxCDDyIbk7Q/K0yzd34YAu/1k4fHTnAiFJ3FPkpSMSmKDxsBvY8lgHkOx gWWPx4RhJ+Iv2jqltyxITZFTpI6BIpU5Kl0oPH6q5RkO4GOw94HryYoLynID0u47 sfCgYqN6P4bCmXTofR+eRNTD7OGreNTmSVy96RyYOEV7vLs9Kffcj/QKyQFM0wj3 tlFSZ+YW+kQcolX28wNnWcWLlRyhsb6mCdcyYrYwjvnH0Y/PpNcdkdfqxQnH2X0a R6YFzW+flNURWmTxyZZKqB6vEjrckZ4q+AjodienOEmef/iSX5nBkIrFYEffMSeP SNAdfrtXJ3PSDCC1g15I21uU2hrYorPh22f8tLzK1MIDriplt0Fx1JSg4rBqUJnz UPVambUySxZ3xpyRWY8Sr9DlY4jfKsZT1RJRunmBfLdJBaIORY45fyHyNxXnMp0S p8mML0/aVDXxucpo12/DVtT7yLLVGUw55IA479qfkB8216Xog1DxeLA64MdFKTQo vrtJfOWg8UqguVaBij4PYohE8XM52mm4Ogy2g8VbnEot8JgKp9p+RQo8pZTzVbAo 8A8SbVKL3yMg9nIL/iOzBqpkCHJn5EL8bALh2en844gZ88fG9GCWxD7navY/Vf7b M9/R3+IwpRrosZWFHng1 =/RPi -END PGP SIGNATURE- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50857] New: Test failures on Windows 7, 24 thread system
https://issues.apache.org/bugzilla/show_bug.cgi?id=50857 Summary: Test failures on Windows 7, 24 thread system Product: Tomcat Modules Version: unspecified Platform: PC Status: NEW Severity: normal Priority: P2 Component: jdbc-pool AssignedTo: dev@tomcat.apache.org ReportedBy: fha...@apache.org testPoolThreads20Connections10FairAsync [junit] java.sql.SQLException: [tomcat-pool-10] NoWait: Pool empty. Unable to fetch a connection, none available[10 in use]. [junit] at org.apache.tomcat.jdbc.pool.ConnectionPool.borrowConnection(ConnectionPool.java:615) [junit] at org.apache.tomcat.jdbc.pool.ConnectionPool.getConnectionAsync(ConnectionPool.java:143) [junit] at org.apache.tomcat.jdbc.pool.DataSourceProxy.getConnectionAsync(DataSourceProxy.java:122) [junit] at org.apache.tomcat.jdbc.test.FairnessTest$TestThread.run(FairnessTest.java:231) -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
STATUS.txt reviews
I wanted to throw out an idea of an alternative or complementary way to handle our STATUS.txt files, and this solution can apply to our CTR branches as well. The solution would be http://www.reviewboard.org/ If there is an interest, I can spend some time configuring an instance for one of our branches and we can give it a test run and see if we like it. Any takers? Filip - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: STATUS.txt reviews
On 02/03/2011 20:57, Filip Hanik - Dev Lists wrote: > I wanted to throw out an idea of an alternative or complementary way to > handle our STATUS.txt files, and this solution can apply to our CTR > branches as well. > The solution would be http://www.reviewboard.org/ > If there is an interest, I can spend some time configuring an instance > for one of our branches and we can give it a test run and see if we like > it. > > Any takers? If you go down that route, use the reviewboard instance provided by ASF infra. I am currently neutral on this. I can see the benefits of reviewboard but I like that by keeping things simple I can easily work off-line. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1076380 - /tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
Author: fhanik
Date: Wed Mar 2 21:15:07 2011
New Revision: 1076380
URL: http://svn.apache.org/viewvc?rev=1076380&view=rev
Log:
https://issues.apache.org/bugzilla/show_bug.cgi?id=50857
Timeouts have to be trapped, and properly handled
Modified:
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
Modified:
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java?rev=1076380&r1=1076379&r2=1076380&view=diff
==
---
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
(original)
+++
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
Wed Mar 2 21:15:07 2011
@@ -140,11 +140,16 @@ public class ConnectionPool {
* @throws SQLException
*/
public Future getConnectionAsync() throws SQLException {
-PooledConnection pc = this.borrowConnection(0, null, null);
-if (pc!=null) {
-
-return new ConnectionFuture(pc);
-}
+try {
+PooledConnection pc = borrowConnection(0, null, null);
+if (pc!=null) {
+return new ConnectionFuture(pc);
+}
+}catch (SQLException x) {
+if (x.getMessage().indexOf("NoWait")<0) {
+throw x;
+}
+}
//we can only retrieve a future if the underlying queue supports it.
if (idle instanceof FairBlockingQueue) {
Future pcf =
((FairBlockingQueue)idle).pollAsync();
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: STATUS.txt reviews
On 3/2/2011 2:05 PM, Mark Thomas wrote: On 02/03/2011 20:57, Filip Hanik - Dev Lists wrote: I wanted to throw out an idea of an alternative or complementary way to handle our STATUS.txt files, and this solution can apply to our CTR branches as well. The solution would be http://www.reviewboard.org/ If there is an interest, I can spend some time configuring an instance for one of our branches and we can give it a test run and see if we like it. Any takers? If you go down that route, use the reviewboard instance provided by ASF infra. didn't know we had one, excellent! I am currently neutral on this. I can see the benefits of reviewboard but I like that by keeping things simple I can easily work off-line. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - No virus found in this message. Checked by AVG - www.avg.com Version: 10.0.1204 / Virus Database: 1435/3477 - Release Date: 03/02/11 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1076385 - /tomcat/trunk/modules/jdbc-pool/doc/changelog.xml
Author: fhanik Date: Wed Mar 2 21:18:18 2011 New Revision: 1076385 URL: http://svn.apache.org/viewvc?rev=1076385&view=rev Log: Doco update Modified: tomcat/trunk/modules/jdbc-pool/doc/changelog.xml Modified: tomcat/trunk/modules/jdbc-pool/doc/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/doc/changelog.xml?rev=1076385&r1=1076384&r2=1076385&view=diff == --- tomcat/trunk/modules/jdbc-pool/doc/changelog.xml (original) +++ tomcat/trunk/modules/jdbc-pool/doc/changelog.xml Wed Mar 2 21:18:18 2011 @@ -32,6 +32,7 @@ 1073531 50805 Only initialize connections once when async (fhanik) + 1076380 50857 Correctly handle timeouts when the pool is busy when async (fhanik) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50857] Test failures on Windows 7, 24 thread system
https://issues.apache.org/bugzilla/show_bug.cgi?id=50857 Filip Hanik changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED OS/Version||All --- Comment #1 from Filip Hanik 2011-03-02 16:21:53 EST --- Fixed in r1076385 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1076424 - /tomcat/tags/JDBC_POOL_1_1_0_0/
Author: fhanik Date: Wed Mar 2 22:05:09 2011 New Revision: 1076424 URL: http://svn.apache.org/viewvc?rev=1076424&view=rev Log: Tag for release Added: tomcat/tags/JDBC_POOL_1_1_0_0/ (props changed) - copied from r1076423, tomcat/trunk/modules/jdbc-pool/ Propchange: tomcat/tags/JDBC_POOL_1_1_0_0/ -- --- svn:ignore (added) +++ svn:ignore Wed Mar 2 22:05:09 2011 @@ -0,0 +1,7 @@ +build.properties +includes +output +.settings +.classpath +bin + Propchange: tomcat/tags/JDBC_POOL_1_1_0_0/ -- svn:mergeinfo = /tomcat/tc6.0.x/trunk/modules/jdbc-pool:742915 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[VOTE] Release jdbc-pool 1.1.0.0
Source and Binary Packages http://people.apache.org/~fhanik/jdbc-pool/v1.1.0.0/ Tag http://svn.apache.org/repos/asf/tomcat/tags/JDBC_POOL_1_1_0_0/ Documentation http://people.apache.org/~fhanik/jdbc-pool/jdbc-pool.html The proposed 1.1.0.0 release is: [ ] Broken - do not release [ ] Alpha - go ahead and release as 1.1.0.0 Alpha [ ] Beta - go ahead and release as 1.1.0.0 Beta [ ] Stable - go ahead and release as 1.1.0.0 Stable best Filip - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
ExtensionValidator scope
It doesn't appear ExtensionValidator will look in parent classloaders for extensions (e.g. tomcat.home/lib/). Has this ever been discussed and what would you imagine might be the best way to do it? -David - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release jdbc-pool 1.1.0.0
On 2 March 2011 22:09, Filip Hanik - Dev Lists wrote: > Source and Binary Packages > http://people.apache.org/~fhanik/jdbc-pool/v1.1.0.0/ tomcat-juli.jar has NOTICE and LICENSE files, but none of the pool jars do. apache-tomcat-jdbc-1.1.0.0-src.zip contains the file test/org/apache/tomcat/jdbc/test/Bug50571.java which is not in the SVN TAG. > Tag > http://svn.apache.org/repos/asf/tomcat/tags/JDBC_POOL_1_1_0_0/ JDBC_POOL_1_1_0_0/test/org/apache/tomcat/jdbc/test/Bug50805.java has no AL header > Documentation > http://people.apache.org/~fhanik/jdbc-pool/jdbc-pool.html > > The proposed 1.1.0.0 release is: > > [ ] Broken - do not release > [ ] Alpha - go ahead and release as 1.1.0.0 Alpha > [ ] Beta - go ahead and release as 1.1.0.0 Beta > [ ] Stable - go ahead and release as 1.1.0.0 Stable > > best > Filip > > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
