DO NOT REPLY [Bug 50825] New: Site still has links to Jakarta for mailing lists etc

2011-02-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50825

   Summary: Site still has links to Jakarta for mailing lists etc
   Product: Taglibs
   Version: unspecified
  Platform: PC
OS/Version: Windows XP
Status: NEW
  Severity: normal
  Priority: P2
 Component: RDC Taglib
AssignedTo: dev@tomcat.apache.org
ReportedBy: s...@apache.org


The current RDC site has menu items

* Mailing Lists
* Bugs
* Building
* CI

which still link to the Jakarta site.

However, there are also entries for all of these (except Building) under
"Project Information" which point to local resources.

The outdated links should be removed.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[taglibs] downloads and Jakarta references

2011-02-24 Thread sebb
The RDC and JSTL pages still point to the Jakarta site for download links.

Would it be possible to create local download pages instead?

The download links don't appear on the Jakarta site, so it means the
html and cgi files need special handling.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1074132 - /tomcat/trunk/java/org/apache/catalina/valves/CrawlerSessionManagerValve.java

2011-02-24 Thread markt
Author: markt
Date: Thu Feb 24 13:11:17 2011
New Revision: 1074132

URL: http://svn.apache.org/viewvc?rev=1074132&view=rev
Log:
Restore the CrawlerSessionManagerValve
Local testing with Jira 4.2.4 shows it works.

Added:
tomcat/trunk/java/org/apache/catalina/valves/CrawlerSessionManagerValve.java
  - copied, changed from r1067803, 
tomcat/trunk/java/org/apache/catalina/valves/CrawlerSessionManagerValve.java

Copied: 
tomcat/trunk/java/org/apache/catalina/valves/CrawlerSessionManagerValve.java 
(from r1067803, 
tomcat/trunk/java/org/apache/catalina/valves/CrawlerSessionManagerValve.java)
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/CrawlerSessionManagerValve.java?p2=tomcat/trunk/java/org/apache/catalina/valves/CrawlerSessionManagerValve.java&p1=tomcat/trunk/java/org/apache/catalina/valves/CrawlerSessionManagerValve.java&r1=1067803&r2=1074132&rev=1074132&view=diff
==
--- 
tomcat/trunk/java/org/apache/catalina/valves/CrawlerSessionManagerValve.java 
(original)
+++ 
tomcat/trunk/java/org/apache/catalina/valves/CrawlerSessionManagerValve.java 
Thu Feb 24 13:11:17 2011
@@ -25,7 +25,6 @@ import java.util.concurrent.ConcurrentHa
 import java.util.regex.Pattern;
 
 import javax.servlet.ServletException;
-import javax.servlet.http.Cookie;
 import javax.servlet.http.HttpSession;
 
 import org.apache.catalina.LifecycleException;
@@ -151,9 +150,6 @@ public class CrawlerSessionManagerValve 
 sessionInfo = uaIpSessionInfo.get(clientIp);
 if (sessionInfo != null) {
 request.setRequestedSessionId(sessionInfo.getSessionId());
-// Hack for testing with Jira
-request.addCookie(new Cookie("JSESSIONID",
-sessionInfo.getSessionId()));
 if (log.isDebugEnabled()) {
 log.debug(request.hashCode() +
 ": SessionID=" + sessionInfo.getSessionId());



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: svn commit: r1074132 - /tomcat/trunk/java/org/apache/catalina/valves/CrawlerSessionManagerValve.java

2011-02-24 Thread Mark Thomas
On 24/02/2011 13:11, ma...@apache.org wrote:
> Author: markt
> Date: Thu Feb 24 13:11:17 2011
> New Revision: 1074132
> 
> URL: http://svn.apache.org/viewvc?rev=1074132&view=rev
> Log:
> Restore the CrawlerSessionManagerValve
> Local testing with Jira 4.2.4 shows it works.

Next up, testing with the ASF test Jira instance.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 50826] New: (Embedded) Tomcat.destroy() throws java.lang.IllegalArgumentException

2011-02-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50826

   Summary: (Embedded) Tomcat.destroy() throws
java.lang.IllegalArgumentException
   Product: Tomcat 7
   Version: 7.0.8
  Platform: PC
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
AssignedTo: dev@tomcat.apache.org
ReportedBy: max.valjan...@gmail.com


Embedded Tomcat sometimes throws this exception when calling destroy() method:

java.lang.IllegalArgumentException: null source
at java.util.EventObject.(EventObject.java:56)
at javax.management.Notification.(Notification.java:184)
at
org.apache.catalina.core.StandardContext.destroyInternal(StandardContext.java:5433)
at org.apache.catalina.util.LifecycleBase.destroy(LifecycleBase.java:285)
at
org.apache.catalina.core.ContainerBase.removeChild(ContainerBase.java:969)
at
org.apache.catalina.core.ContainerBase.destroyInternal(ContainerBase.java:1108)
at org.apache.catalina.util.LifecycleBase.destroy(LifecycleBase.java:285)
at
org.apache.catalina.core.ContainerBase.removeChild(ContainerBase.java:969)
at
org.apache.catalina.core.ContainerBase.destroyInternal(ContainerBase.java:1108)
at org.apache.catalina.util.LifecycleBase.destroy(LifecycleBase.java:285)
at
org.apache.catalina.core.StandardService.destroyInternal(StandardService.java:593)
at org.apache.catalina.util.LifecycleBase.destroy(LifecycleBase.java:285)
at
org.apache.catalina.core.StandardServer.destroyInternal(StandardServer.java:786)
at org.apache.catalina.util.LifecycleBase.destroy(LifecycleBase.java:285)
at org.apache.catalina.startup.Tomcat.destroy(Tomcat.java:323)
at
su.msk.jet.nioproxy.rule.config.EmbeddedWebserver.stop(EmbeddedWebserver.java:26)

I think that StandardContext.destroyInternal() misses check that
this.getObjectName()!=null

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1074159 - /tomcat/trunk/java/org/apache/catalina/valves/CrawlerSessionManagerValve.java

2011-02-24 Thread markt
Author: markt
Date: Thu Feb 24 14:15:34 2011
New Revision: 1074159

URL: http://svn.apache.org/viewvc?rev=1074159&view=rev
Log:
Avoid NPE if no u-a header

Modified:
tomcat/trunk/java/org/apache/catalina/valves/CrawlerSessionManagerValve.java

Modified: 
tomcat/trunk/java/org/apache/catalina/valves/CrawlerSessionManagerValve.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/CrawlerSessionManagerValve.java?rev=1074159&r1=1074158&r2=1074159&view=diff
==
--- 
tomcat/trunk/java/org/apache/catalina/valves/CrawlerSessionManagerValve.java 
(original)
+++ 
tomcat/trunk/java/org/apache/catalina/valves/CrawlerSessionManagerValve.java 
Thu Feb 24 14:15:34 2011
@@ -125,10 +125,13 @@ public class CrawlerSessionManagerValve 
 
 // Is this a crawler - cheack the UA headers
 Enumeration uaHeaders = request.getHeaders("user-agent");
-String uaHeader = uaHeaders.nextElement();
+String uaHeader = null;
+if (uaHeaders.hasMoreElements()) {
+uaHeader = uaHeaders.nextElement();
+}
 
 // If more than one UA header - assume not a bot
-if (!uaHeaders.hasMoreElements()) {
+if (uaHeader != null && !uaHeaders.hasMoreElements()) {
 
 if (log.isDebugEnabled()) {
 log.debug(request.hashCode() + ": UserAgent=" + uaHeader);



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1074168 - /tomcat/trunk/java/org/apache/catalina/valves/CrawlerSessionManagerValve.java

2011-02-24 Thread markt
Author: markt
Date: Thu Feb 24 14:39:39 2011
New Revision: 1074168

URL: http://svn.apache.org/viewvc?rev=1074168&view=rev
Log:
Fix comment typo

Modified:
tomcat/trunk/java/org/apache/catalina/valves/CrawlerSessionManagerValve.java

Modified: 
tomcat/trunk/java/org/apache/catalina/valves/CrawlerSessionManagerValve.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/CrawlerSessionManagerValve.java?rev=1074168&r1=1074167&r2=1074168&view=diff
==
--- 
tomcat/trunk/java/org/apache/catalina/valves/CrawlerSessionManagerValve.java 
(original)
+++ 
tomcat/trunk/java/org/apache/catalina/valves/CrawlerSessionManagerValve.java 
Thu Feb 24 14:39:39 2011
@@ -123,7 +123,7 @@ public class CrawlerSessionManagerValve 
 // If the incoming request has a session ID, no action is required
 if (request.getRequestedSessionId() == null) {
 
-// Is this a crawler - cheack the UA headers
+// Is this a crawler - check the UA headers
 Enumeration uaHeaders = request.getHeaders("user-agent");
 String uaHeader = null;
 if (uaHeaders.hasMoreElements()) {



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1074192 - in /tomcat/trunk/webapps/docs: changelog.xml config/valve.xml

2011-02-24 Thread markt
Author: markt
Date: Thu Feb 24 16:01:38 2011
New Revision: 1074192

URL: http://svn.apache.org/viewvc?rev=1074192&view=rev
Log:
Add documentation for the Crawler Session Manager Valve.

Modified:
tomcat/trunk/webapps/docs/changelog.xml
tomcat/trunk/webapps/docs/config/valve.xml

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1074192&r1=1074191&r2=1074192&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Thu Feb 24 16:01:38 2011
@@ -130,6 +130,14 @@
 ServletContext.getResourcePaths() includes static 
resources
 packaged in JAR files in its output. (markt)
   
+  
+Web crawlers can trigger the creation of many thousands of sessions as
+they crawl a site which may result in significant memory consumption.
+Thw new Crawler Session Manager Valve ensures that crawlers are
+associated with a single session - just like normal users - regardless
+of whether or not they provide a session token with their requests.
+(markt)
+  
 
   
   

Modified: tomcat/trunk/webapps/docs/config/valve.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/valve.xml?rev=1074192&r1=1074191&r2=1074192&view=diff
==
--- tomcat/trunk/webapps/docs/config/valve.xml (original)
+++ tomcat/trunk/webapps/docs/config/valve.xml Thu Feb 24 16:01:38 2011
@@ -880,6 +880,62 @@
 
 
 
+
+
+  
+  
+Web crawlers can trigger the creation of many thousands of sessions as
+they crawl a site which may result in significant memory consumption. This
+Valve ensures that crawlers are associated with a single session - just 
like
+normal users - regardless of whether or not they provide a session token
+with their requests.
+
+This Valve may be used at the Engine, Host or
+Context level as required. Normally, this Valve would be used
+at the Engine level.
+
+If used in conjunction with Remote IP valve then the Remote IP valve
+should be defined before this valve to ensure that the correct client IP
+address is presented to this valve.
+
+  
+
+  
+
+The Crawler Session Manager Valve supports the
+following configuration attributes:
+
+
+
+  
+Java class name of the implementation to use.  This MUST be set to
+org.apache.catalina.valves.CrawlerSessionManagerValve.
+
+  
+
+  
+Regular expression (using java.util.regex) that the 
user
+agent HTTP request header is matched against to determine if a request
+is from a web crawler. If not set, the default of
+.*GoogleBot.*|.*bingbot.*|.*Yahoo! Slurp.* is used.
+  
+
+  
+The minimum time in seconds that the Crawler Session Manager Valve
+should keep the mapping of client IP to session ID in memory without 
any
+activity from the client. The client IP / session cache will be
+periodically purged of mappings that have been inactive for longer than
+this interval. If not specified the default value of 60
+will be used.
+  
+
+
+
+  
+
+
+
+
 
 
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: svn commit: r1074192 - in /tomcat/trunk/webapps/docs: changelog.xml config/valve.xml

2011-02-24 Thread Mark Thomas
On 24/02/2011 16:01, ma...@apache.org wrote:
> Author: markt
> Date: Thu Feb 24 16:01:38 2011
> New Revision: 1074192
> 
> URL: http://svn.apache.org/viewvc?rev=1074192&view=rev
> Log:
> Add documentation for the Crawler Session Manager Valve.

This worked well on the ASF Jira test instance. There are a couple of
lifecycle bugs to fix and then I think I'll be ready to tag 7.0.9.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1074215 - in /tomcat/trunk: java/org/apache/catalina/core/StandardContext.java webapps/docs/changelog.xml

2011-02-24 Thread markt
Author: markt
Date: Thu Feb 24 17:03:27 2011
New Revision: 1074215

URL: http://svn.apache.org/viewvc?rev=1074215&view=rev
Log:
Don't start NamingResources multiple times

Modified:
tomcat/trunk/java/org/apache/catalina/core/StandardContext.java
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/catalina/core/StandardContext.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/StandardContext.java?rev=1074215&r1=1074214&r2=1074215&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/StandardContext.java (original)
+++ tomcat/trunk/java/org/apache/catalina/core/StandardContext.java Thu Feb 24 
17:03:27 2011
@@ -1952,24 +1952,36 @@ public class StandardContext extends Con
 support.firePropertyChange("namingResources",
oldNamingResources, this.namingResources);
 
-// If set from server.xml, getObjectKeyPropertiesNameOnly() will
-// trigger an NPE. Initial registration takes place on INIT. 
-if (getState() != LifecycleState.NEW) {
-if (oldNamingResources != null) {
-try {
-oldNamingResources.stop();
-oldNamingResources.destroy();
-} catch (LifecycleException e) {
-log.warn("standardContext.namingResource.destroy.fail", e);
-}
+if (getState() == LifecycleState.NEW ||
+getState() == LifecycleState.INITIALIZING ||
+getState() == LifecycleState.INITIALIZED) {
+// NEW will occur if Context is defined in server.xml
+// At this point getObjectKeyPropertiesNameOnly() will trigger an
+// NPE.
+// INITIALIZED will occur if the Context is defined in a 
context.xml
+// file
+// If started now, a second start will be attempted when the 
context
+// starts
+
+// In both cases, return and let context init the namingResources
+// when it starts
+return;
+}
+
+if (oldNamingResources != null) {
+try {
+oldNamingResources.stop();
+oldNamingResources.destroy();
+} catch (LifecycleException e) {
+log.warn("standardContext.namingResource.destroy.fail", e);
 }
-if (namingResources != null) {
-try {
-namingResources.init();
-namingResources.start();
-} catch (LifecycleException e) {
-log.warn("standardContext.namingResource.init.fail", e);
-}
+}
+if (namingResources != null) {
+try {
+namingResources.init();
+namingResources.start();
+} catch (LifecycleException e) {
+log.warn("standardContext.namingResource.init.fail", e);
 }
 }
 }

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1074215&r1=1074214&r2=1074215&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Thu Feb 24 17:03:27 2011
@@ -138,6 +138,10 @@
 of whether or not they provide a session token with their requests.
 (markt)
   
+  
+Don't attempt to start NamingResources for Contexts multiple 
times.
+(markt) 
+  
 
   
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: svn commit: r1074192 - in /tomcat/trunk/webapps/docs: changelog.xml config/valve.xml

2011-02-24 Thread Felix Schumacher

On Thu, 24 Feb 2011 16:01:39 -,  wrote:

Author: markt
Date: Thu Feb 24 16:01:38 2011
New Revision: 1074192

URL: http://svn.apache.org/viewvc?rev=1074192&view=rev
Log:
Add documentation for the Crawler Session Manager Valve.

Modified:
tomcat/trunk/webapps/docs/changelog.xml
tomcat/trunk/webapps/docs/config/valve.xml

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:

http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1074192&r1=1074191&r2=1074192&view=diff

==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Thu Feb 24 16:01:38 2011
@@ -130,6 +130,14 @@
 ServletContext.getResourcePaths() includes
static resources
 packaged in JAR files in its output. (markt)
   
+  
+Web crawlers can trigger the creation of many thousands of
sessions as
+they crawl a site which may result in significant memory
consumption.
+Thw new Crawler Session Manager Valve ensures that crawlers 
are

The new Crawler ...

regards
 Felix


+associated with a single session - just like normal users -
regardless
+of whether or not they provide a session token with their 
requests.

+(markt)
+  
 
   
   

Modified: tomcat/trunk/webapps/docs/config/valve.xml
URL:

http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/valve.xml?rev=1074192&r1=1074191&r2=1074192&view=diff

==
--- tomcat/trunk/webapps/docs/config/valve.xml (original)
+++ tomcat/trunk/webapps/docs/config/valve.xml Thu Feb 24 16:01:38 
2011

@@ -880,6 +880,62 @@
 


+
+
+  
+
+Web crawlers can trigger the creation of many thousands of
sessions as
+they crawl a site which may result in significant memory
consumption. This
+Valve ensures that crawlers are associated with a single session
- just like
+normal users - regardless of whether or not they provide a 
session token

+with their requests.
+
+This Valve may be used at the Engine,
Host or
+Context level as required. Normally, this Valve
would be used
+at the Engine level.
+
+If used in conjunction with Remote IP valve then the Remote 
IP valve
+should be defined before this valve to ensure that the correct 
client IP

+address is presented to this valve.
+
+  
+
+  
+
+The Crawler Session Manager Valve supports 
the

+following configuration attributes:
+
+
+
+  
+Java class name of the implementation to use.  This MUST
be set to
+

org.apache.catalina.valves.CrawlerSessionManagerValve.
+
+  
+
+  
+Regular expression (using java.util.regex)
that the user
+agent HTTP request header is matched against to determine if
a request
+is from a web crawler. If not set, the default of
+.*GoogleBot.*|.*bingbot.*|.*Yahoo! Slurp.* is 
used.

+  
+
+  
+The minimum time in seconds that the Crawler Session
Manager Valve
+should keep the mapping of client IP to session ID in memory
without any
+activity from the client. The client IP / session cache will 
be

+periodically purged of mappings that have been inactive for
longer than
+this interval. If not specified the default value of 
60

+will be used.
+  
+
+
+
+  
+
+
+
+
 





-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1074225 - in /tomcat/trunk: java/org/apache/catalina/core/StandardContext.java test/org/apache/catalina/startup/TestTomcat.java webapps/docs/changelog.xml

2011-02-24 Thread markt
Author: markt
Date: Thu Feb 24 17:25:38 2011
New Revision: 1074225

URL: http://svn.apache.org/viewvc?rev=1074225&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50826
Avoid IAE when Tomcat instance is destroyed without every being started.
Add a test case for this.

Modified:
tomcat/trunk/java/org/apache/catalina/core/StandardContext.java
tomcat/trunk/test/org/apache/catalina/startup/TestTomcat.java
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/catalina/core/StandardContext.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/StandardContext.java?rev=1074225&r1=1074224&r2=1074225&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/StandardContext.java (original)
+++ tomcat/trunk/java/org/apache/catalina/core/StandardContext.java Thu Feb 24 
17:25:38 2011
@@ -5486,11 +5486,15 @@ public class StandardContext extends Con
 ((Lifecycle) loader).destroy();
 }
 
-// Send j2ee.object.deleted notification 
-Notification notification = 
-new Notification("j2ee.object.deleted", this.getObjectName(), 
- sequenceNumber.getAndIncrement());
-broadcaster.sendNotification(notification);
+// If in state NEW when destroy is called, the object name will never
+// have been set so the notification can't be created
+if (getObjectName() != null) { 
+// Send j2ee.object.deleted notification 
+Notification notification = 
+new Notification("j2ee.object.deleted", this.getObjectName(), 
+ sequenceNumber.getAndIncrement());
+broadcaster.sendNotification(notification);
+}
 
 if (namingResources != null) {
 namingResources.destroy();

Modified: tomcat/trunk/test/org/apache/catalina/startup/TestTomcat.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/startup/TestTomcat.java?rev=1074225&r1=1074224&r2=1074225&view=diff
==
--- tomcat/trunk/test/org/apache/catalina/startup/TestTomcat.java (original)
+++ tomcat/trunk/test/org/apache/catalina/startup/TestTomcat.java Thu Feb 24 
17:25:38 2011
@@ -326,4 +326,21 @@ public class TestTomcat extends TomcatBa
 assertTrue(res.toString().contains("http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1074225&r1=1074224&r2=1074225&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Thu Feb 24 17:25:38 2011
@@ -133,7 +133,7 @@
   
 Web crawlers can trigger the creation of many thousands of sessions as
 they crawl a site which may result in significant memory consumption.
-Thw new Crawler Session Manager Valve ensures that crawlers are
+The new Crawler Session Manager Valve ensures that crawlers are
 associated with a single session - just like normal users - regardless
 of whether or not they provide a session token with their requests.
 (markt)
@@ -142,6 +142,11 @@
 Don't attempt to start NamingResources for Contexts multiple 
times.
 (markt) 
   
+  
+50826: Avoid IllegalArgumentException if an
+embedded Tomcat instance that includes at least one Context is 
destroyed
+without ever being started. (markt)
+  
 
   
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: svn commit: r1074192 - in /tomcat/trunk/webapps/docs: changelog.xml config/valve.xml

2011-02-24 Thread Mark Thomas
On 24/02/2011 17:22, Felix Schumacher wrote:
> On Thu, 24 Feb 2011 16:01:39 -,  wrote:
>> Author: markt
>> Date: Thu Feb 24 16:01:38 2011
>> New Revision: 1074192



>> +Thw new Crawler Session Manager Valve ensures that crawlers are
> The new Crawler ...

Fixed. Thanks.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 50826] (Embedded) Tomcat.destroy() throws java.lang.IllegalArgumentException

2011-02-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50826

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #1 from Mark Thomas  2011-02-24 12:26:54 EST ---
Thanks for the report. This has been fixed in 7.0.x and will be included in
7.0.9 onwards.

To avoid it in the meantime, ensure that the embedded Tomcat instance is
started before you destroy it.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 48717] Session listeners not called on cluster node start

2011-02-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48717

--- Comment #8 from David Rees  2011-02-24 17:48:44 EST ---
Thanks - so I guess to test this I'd have to apply the patch to Tomcat source
and build it myself?

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 48717] Session listeners not called on cluster node start

2011-02-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48717

--- Comment #9 from Mark Thomas  2011-02-24 17:52:52 EST ---
'fraid so.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org