svn commit: r1072929 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-02-21 Thread kkolinko
Author: kkolinko
Date: Mon Feb 21 11:27:02 2011
New Revision: 1072929

URL: http://svn.apache.org/viewvc?rev=1072929&view=rev
Log:
vote

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1072929&r1=1072928&r2=1072929&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Mon Feb 21 11:27:02 2011
@@ -130,7 +130,7 @@ PATCHES PROPOSED TO BACKPORT:
   reads from the request since this causes various problems in the connectors
   which do not expect this.
   http://svn.apache.org/viewvc?rev=1072042&view=rev
-  +1: markt, mturk
+  +1: markt, mturk, kkolinko
   -1:
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48863
@@ -138,4 +138,14 @@ PATCHES PROPOSED TO BACKPORT:
   Based on a patch by Ralf Hauser.
   http://people.apache.org/~markt/patches/2011-02-18-bug48870.patch
   +1: markt
+  -0: kkolinko: If I understand it corretly, it will nag about missing
+${catalina.base}/lib when running with separate home and base and that
+directory does not exist. I think that is too common issue to use warn(),
+and will need i18n if we would use info() and maybe use a simpler
+message for the common "does not exist" case. That will need a new
+patch.
+For the proposed patch: I am +1 to use it as is if s/log.warn/log.debug/.
+While we are at it, maybe add messages for the IS_JAR, IS_GLOB branches
+as well.
   -1:
+



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1072958 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt java/org/apache/catalina/connector/OutputBuffer.java webapps/docs/changelog.xml

2011-02-21 Thread markt
Author: markt
Date: Mon Feb 21 12:53:15 2011
New Revision: 1072958

URL: http://svn.apache.org/viewvc?rev=1072958&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50189
Once the application has finished writing to the response, prevent further 
reads from the request since this causes various problems in the connectors 
which do not expect this.

Modified:
tomcat/tc6.0.x/trunk/   (props changed)
tomcat/tc6.0.x/trunk/STATUS.txt
tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/OutputBuffer.java
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc6.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Feb 21 12:53:15 2011
@@ -1 +1 @@
-/tomcat/trunk:601180,606992,612607,630314,640888,652744,653247,666232,673796,673820,677910,683969,683982,684001,684081,684234,684269-684270,685177,687503,687645,689402,690781,691392,691805,692748,693378,694992,695053,695311,696780,696782,698012,698227,698236,698613,699427,699634,701355,709294,709811,709816,710063,710066,710125,710205,711126,711600,712461,712467,713953,714002,718360,719119,719124,719602,719626,719628,720046,720069,721040,721286,721708,721886,723404,723738,726052,727303,728032,728768,728947,729057,729567,729569,729571,729681,729809,729815,729934,730250,730590,731651,732859,732863,734734,740675,740684,742677,742697,742714,744160,744238,746321,746384,746425,747834,747863,748344,750258,750291,750921,751286-751287,751289,751295,752323,753039,757335,757774,758249,758365,758596,758616,758664,759074,761601,762868,762929,762936-762937,763166,763183,763193,763228,763262,763298,763302,763325,763599,763611,763654,763681,763706,764985,764997,765662,768335,769979,770716,77
 
0809,770876,772872,776921,776924,776935,776945,777464,777466,777576,777625,778379,778523-778524,781528,781779,782145,782791,783316,783696,783724,783756,783762,783766,783863,783934,784453,784602,784614,785381,785688,785768,785859,786468,786487,786490,786496,786667,787627,787770,787985,789389,790405,791041,791184,791194,791224,791243,791326,791328,791789,792740,793372,793757,793882,793981,794082,794673,794822,795043,795152,795210,795457,795466,797168,797425,797596,797607,802727,802940,804462,804544,804734,805153,809131,809603,810916,810977,812125,812137,812432,813001,813013,813866,814180,814708,814876,815972,816252,817442,817822,819339,819361,820110,820132,820874,820954,821397,828196,828201,828210,828225,828759,830378-830379,830999,831106,831774,831785,831828,831850,831860,832214,832218,833121,833545,834047,835036,835336,836405,881396,881412,883130,883134,883146,883165,883177,883362,883565,884341,885038,885231,885241,885260,885901,885991,886019,888072,889363,889606,889716,8901
 
39,890265,890349-890350,890417,891185-891187,891583,892198,892341,892415,892464,892555,892812,892814,892817,892843,892887,893321,893493,894580,894586,894805,894831,895013,895045,895057,895191,895392,895703,896370,896384,897380-897381,897776,898126,898256,898468,898527,898555,898558,898718,898836,898906,899284,899348,899420,899653,899769-899770,899783,899788,899792,899916,899918-899919,899935,899949,903916,905020,905151,905722,905728,905735,907311,907513,907538,907652,907819,907825,907864,908002,908721,908754,908759,909097,909206,909212,909525,909636,909869,909875,909887,910266,910370,910442,910471,910485,910974,915226,915737,915861,916097,916141,916157,916170,917598,917633,918093,918489,918594,918684,918787,918792,918799,918803,918885,919851,919914,920025,920055,920298,920449,920596,920824,920840,921444,922010,926716,927062,927621,928482,928695,928732,928798,931709,932357,932967,935105,935983,939491,939551,940064,941356,941463,944409,944416,945231,945808,945835,945841,946686
 
,948057,950164,950596,950614,950851,950905,951615,953434,954435,955648,955655,956832,957130,957830,958192,960701,961948,962865,962872,962881,962900,963106,963865,963868,964614,966177-966178,966292,966692,966863,981815,988448,991837,993042,1001955,1002185,1002263,1002274,1002349,1002359,1002362,1002481,1002514,1003461,1003481,1003488,1003556,1003572,1003581,1003861,1004393,1004409,1004415,1004868-1004869,1004912,1005452,1005467,1005647,1005802,1022120,1022134,1022323,1022415,1022606,1022623,1024224,1024251,1026042,1026784,1026912,1026920,1029767,1033415,1033448,1033842,1033897,1037715,1037794,1037887,1037924,1038041,1042022,1042029,1042447,1042452,1042494,1044944,1044987,1050249,1055055,1055236,1055458,1055975,1056264,1056828,1056889,1059881,1061412,1061442,1061446,1062398,1064652,1066244
+/tomcat/trunk:601180,606992,612607,630314,640888,652744,653247,666232,673796,673820,677910,683969,683982,684001,684081,684234,684269-684270,685177,687503,687645,689402,690781,691392,691805,692748,693378,694992,695053,695311,696780,696782,698012,698227,698236,698613,699427,699634,701355,709294,709811,709816,710063,710066,710125,710205,711126,711600,712461,712467,713953,714002,718360,719119,719124,719602,719626,719628,720046,720069,7

DO NOT REPLY [Bug 50189] AJP connector sends GET BODY CHUNK when reading after response closed

2011-02-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50189

--- Comment #5 from Mark Thomas  2011-02-21 07:53:34 EST ---
Fixed in 6.0.x and will be included in 6.0.33 onwards.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1072960 - /tomcat/trunk/java/org/apache/catalina/startup/ClassLoaderFactory.java

2011-02-21 Thread markt
Author: markt
Date: Mon Feb 21 12:59:50 2011
New Revision: 1072960

URL: http://svn.apache.org/viewvc?rev=1072960&view=rev
Log:
Fix javadoc

Modified:
tomcat/trunk/java/org/apache/catalina/startup/ClassLoaderFactory.java

Modified: tomcat/trunk/java/org/apache/catalina/startup/ClassLoaderFactory.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/startup/ClassLoaderFactory.java?rev=1072960&r1=1072959&r2=1072960&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/startup/ClassLoaderFactory.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/startup/ClassLoaderFactory.java Mon 
Feb 21 12:59:50 2011
@@ -140,12 +140,9 @@ public final class ClassLoaderFactory {
  * Create and return a new class loader, based on the configuration
  * defaults and the specified directory paths:
  *
- * @param locations Array of strings containing class directories, jar 
files,
- *  jar directories or URLS that should be added to the repositories of
- *  the class loader. The type is given by the member of param types.
- * @param types Array of types for the members of param locations.
- *  Possible values are IS_DIR (class directory), IS_JAR (single jar file),
- *  IS_GLOB (directory of jar files) and IS_URL (URL).
+ * @param repositories List of class directories, jar files, jar 
directories
+ * or URLS that should be added to the repositories of
+ * the class loader.
  * @param parent Parent class loader for the new class loader, or
  *  null for the system class loader.
  *



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Tomcat Wiki] Update of "PoweredBy" by prosch

2011-02-21 Thread Apache Wiki
Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change 
notification.

The "PoweredBy" page has been changed by prosch.
http://wiki.apache.org/tomcat/PoweredBy?action=diff&rev1=317&rev2=318

--

  #pragma section-numbers 2
  = Sites, Applications, and Systems that are Powered By Tomcat =
- This page is a list of some, in all likelihood a very small fraction 
actually, of the sites out there that use [[http://tomcat.apache.org|Apache 
Tomcat]] in production.  For security and other policy-related reasons, many 
organizations choose not to disclose the server they use.  Tomcat has been 
downloaded more than 10 million times: assuming even a 1% production adoption 
rate results in more than 10 installations.  As an aside for the curious, 
you can see recent Tomcat download statistics on 
[[http://people.apache.org/~vgritsenko/stats/projects/tomcat.html|Vadim 
Gritsenko's page]].  Note, however, that these represent downloads from 
apache.org servers only, and not from mirrors, so they are likely to represent 
only a small minority of downloads: the total number is much (more than an 
order of magnitude) greater.  Companies that support Tomcat, such as 
[[http://www.springsource.com|SpringSource]] claim more than half of the global 
Fortune 500 as their clients.
+ This page is a list of some, in all likelihood a very small fraction 
actually, of the sites out there that use [[http://tomcat.apache.org|Apache 
Tomcat]] in production.  For security and other policy-related reasons, many 
organizations choose not to disclose the server they use.  Tomcat has been 
downloaded more than 10 million times: assuming even a 1% production adoption 
rate results in more than 10 installations.  As an aside for the curious, 
you can see recent Tomcat download statistics on 
[[http://people.apache.org/~vgritsenko/stats/projects/tomcat.html|Vadim 
Gritsenko's page]].  Note, however, that these represent downloads from 
apache.org servers only, and not from mirrors, so they are likely to represent 
only a small minority of downloads: the total number is much (more than an 
order of magnitude) greater.  Companies that support Tomcat, such as 
[[http://www.springsource.com|SpringSource]] claim more than half of the global 
Fortune 500 as their clients. [[http://tinyurl.com/36m4g9x|Übersetzung Deutsch 
Englisch]]
  
  This page is organized by categories: [[#pub|sites with publications]], 
[[#user|sites added by users]], [[#surveys|independent surveys]], and 
[[#more|more]].  Anyone can and is encouraged to add to this page: please add 
your site, application, or system as you see fit.  You do need to register with 
the Apache wiki system to edit this page: simply click the login or user 
preferences links at the top right of your screen to do so.  Don't worry if you 
don't think it fits here or into any particular category: we would like to see 
your application listed no matter how big, how small, or how miscategorized ;)  
Some of these applications are simply compatible with, ship with, or run on 
Tomcat.  Others are specifically designed or documented with Tomcat as the 
container in mind.
  

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1072962 - /tomcat/trunk/build.properties.default

2011-02-21 Thread markt
Author: markt
Date: Mon Feb 21 13:15:53 2011
New Revision: 1072962

URL: http://svn.apache.org/viewvc?rev=1072962&view=rev
Log:
Servletapi-2.3 appears to have disappeared from the maven1 repo.
Switch everything to maven2 repo

Modified:
tomcat/trunk/build.properties.default

Modified: tomcat/trunk/build.properties.default
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/build.properties.default?rev=1072962&r1=1072961&r2=1072962&view=diff
==
--- tomcat/trunk/build.properties.default (original)
+++ tomcat/trunk/build.properties.default Mon Feb 21 13:15:53 2011
@@ -60,7 +60,7 @@ base-tomcat.loc.1=${base-apache.loc.1}/t
 base-tomcat.loc.2=${base-apache.loc.2}/tomcat
 
 base-sf.loc=http://downloads.sourceforge.net
-base-maven1.loc=http://repo1.maven.org/maven
+base-maven.loc=http://repo2.maven.org/maven2
 
 # Mirror, was used when there were problems with the main SF downloads site
 # base-sf.loc=http://sunet.dl.sourceforge.net
@@ -80,37 +80,37 @@ commons-logging-src.tar.gz=${commons-log
 # - Avalon Framework (required by commons logging) -
 avalon-framework.version=4.1.3
 avalon-framework.home=${base.path}/avalon-framework-${avalon-framework.version}
-avalon-framework.loc=${base-maven1.loc}/avalon-framework/jars/avalon-framework-${avalon-framework.version}.jar
+avalon-framework.loc=${base-maven.loc}/avalon-framework/avalon-framework/${avalon-framework.version}/avalon-framework-${avalon-framework.version}.jar
 
avalon-framework.jar=${avalon-framework.home}/avalon-framework-${avalon-framework.version}.jar
 
 # - log4j (required by commons logging) -
 log4j.version=1.2.12
 log4j.home=${base.path}/log4j-${log4j.version}
-log4j.loc=${base-maven1.loc}/log4j/jars/log4j-${log4j.version}.jar
+log4j.loc=${base-maven.loc}/log4j/log4j/${log4j.version}/log4j-${log4j.version}.jar
 log4j.jar=${log4j.home}/log4j-${log4j.version}.jar
 
 # - logkit (required by commons logging) -
 logkit.version=1.0.1
 logkit.home=${base.path}/logkit-${logkit.version}
-logkit.loc=${base-maven1.loc}/logkit/jars/logkit-${logkit.version}.jar
+logkit.loc=${base-maven.loc}/logkit/logkit/${logkit.version}/logkit-${logkit.version}.jar
 logkit.jar=${logkit.home}/logkit-${logkit.version}.jar
 
 # - servletapi (required by commons logging) -
 servletapi.version=2.3
 servletapi.home=${base.path}/servletapi-${servletapi.version}
-servletapi.loc=${base-maven1.loc}/servletapi/jars/servletapi-${servletapi.version}.jar
+servletapi.loc=${base-maven.loc}/servletapi/servletapi/${servletapi.version}/servletapi-${servletapi.version}.jar
 servletapi.jar=${servletapi.home}/servletapi-${servletapi.version}.jar
 
 # - Webservices - JAX RPC -
 jaxrpc-lib.version=1.1-rc4
 jaxrpc-lib.home=${base.path}/jaxrpc-${jaxrpc-lib.version}
-jaxrpc-lib.loc=http://repo1.maven.org/maven2/geronimo-spec/geronimo-spec-jaxrpc/${jaxrpc-lib.version}/geronimo-spec-jaxrpc-${jaxrpc-lib.version}.jar
+jaxrpc-lib.loc=${base-maven.loc}/geronimo-spec/geronimo-spec-jaxrpc/${jaxrpc-lib.version}/geronimo-spec-jaxrpc-${jaxrpc-lib.version}.jar
 
jaxrpc-lib.jar=${jaxrpc-lib.home}/geronimo-spec-jaxrpc-${jaxrpc-lib.version}.jar
 
 # - Webservices - WSDL4J -
 wsdl4j-lib.version=1.6.1
 wsdl4j-lib.home=${base.path}/wsdl4j-${wsdl4j-lib.version}
-wsdl4j-lib.loc=http://repo1.maven.org/maven2/wsdl4j/wsdl4j/${wsdl4j-lib.version}/wsdl4j-${wsdl4j-lib.version}.jar
+wsdl4j-lib.loc=${base-maven.loc}/wsdl4j/wsdl4j/${wsdl4j-lib.version}/wsdl4j-${wsdl4j-lib.version}.jar
 wsdl4j-lib.jar=${wsdl4j-lib.home}/wsdl4j-${wsdl4j-lib.version}.jar
 
 # - Eclipse JDT, version 3.2 or later -



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



PoweredBy reverted to revision 317 on Tomcat Wiki

2011-02-21 Thread Apache Wiki
Dear wiki user,

You have subscribed to a wiki page "Tomcat Wiki" for change notification.

The page PoweredBy has been reverted to revision 317 by KonstantinKolinko.
The comment on this change is: Reverted to r317 to remove spam.
http://wiki.apache.org/tomcat/PoweredBy?action=diff&rev1=318&rev2=319

--

  #pragma section-numbers 2
  = Sites, Applications, and Systems that are Powered By Tomcat =
- This page is a list of some, in all likelihood a very small fraction 
actually, of the sites out there that use [[http://tomcat.apache.org|Apache 
Tomcat]] in production.  For security and other policy-related reasons, many 
organizations choose not to disclose the server they use.  Tomcat has been 
downloaded more than 10 million times: assuming even a 1% production adoption 
rate results in more than 10 installations.  As an aside for the curious, 
you can see recent Tomcat download statistics on 
[[http://people.apache.org/~vgritsenko/stats/projects/tomcat.html|Vadim 
Gritsenko's page]].  Note, however, that these represent downloads from 
apache.org servers only, and not from mirrors, so they are likely to represent 
only a small minority of downloads: the total number is much (more than an 
order of magnitude) greater.  Companies that support Tomcat, such as 
[[http://www.springsource.com|SpringSource]] claim more than half of the global 
Fortune 500 as their clients. [[http://tinyurl.com/36m4g9x|Übersetzung Deutsch 
Englisch]]
+ This page is a list of some, in all likelihood a very small fraction 
actually, of the sites out there that use [[http://tomcat.apache.org|Apache 
Tomcat]] in production.  For security and other policy-related reasons, many 
organizations choose not to disclose the server they use.  Tomcat has been 
downloaded more than 10 million times: assuming even a 1% production adoption 
rate results in more than 10 installations.  As an aside for the curious, 
you can see recent Tomcat download statistics on 
[[http://people.apache.org/~vgritsenko/stats/projects/tomcat.html|Vadim 
Gritsenko's page]].  Note, however, that these represent downloads from 
apache.org servers only, and not from mirrors, so they are likely to represent 
only a small minority of downloads: the total number is much (more than an 
order of magnitude) greater.  Companies that support Tomcat, such as 
[[http://www.springsource.com|SpringSource]] claim more than half of the global 
Fortune 500 as their clients.
  
  This page is organized by categories: [[#pub|sites with publications]], 
[[#user|sites added by users]], [[#surveys|independent surveys]], and 
[[#more|more]].  Anyone can and is encouraged to add to this page: please add 
your site, application, or system as you see fit.  You do need to register with 
the Apache wiki system to edit this page: simply click the login or user 
preferences links at the top right of your screen to do so.  Don't worry if you 
don't think it fits here or into any particular category: we would like to see 
your application listed no matter how big, how small, or how miscategorized ;)  
Some of these applications are simply compatible with, ship with, or run on 
Tomcat.  Others are specifically designed or documented with Tomcat as the 
container in mind.
  

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Tomcat Wiki] Update of "LocalBadContent" by KonstantinKolinko

2011-02-21 Thread Apache Wiki
Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change 
notification.

The "LocalBadContent" page has been changed by KonstantinKolinko.
The comment on this change is: Prohibit use of tinyurl.com, because of certain 
spammer.
http://wiki.apache.org/tomcat/LocalBadContent?action=diff&rev1=9&rev2=10

--

  shyxbc\.com\.cn
  smbay\.cn
  tiffanyonsale\.org
+ tinyurl\.com
  tnb120\.com\.cn
  tunfar\.com\.cn
  u-tokyo\.ac\.jp

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Reaching ulimit values for open files can generate huge log files

2011-02-21 Thread Mark Thomas
The ASF Sonar installation managed to generate 46GB of identical log
messages [1] today in the 8 hours it took to notice it was down.

While better monitoring would/should have identified the problem sooner,
it does demonstrate a problem with the acceptor threads in all three
endpoints. If there is a system-level issue that causes the accept()
call to always fail (such as hitting the ulimit) then the endpoint
essentially enters a loop where it logs an error message for every
iteration of the loop. This will result in many log messages per second.

I'd like to do something about this. I was thinking of something along
the lines of the following for each endpoint.

Index: java/org/apache/tomcat/util/net/JIoEndpoint.java
===
--- java/org/apache/tomcat/util/net/JIoEndpoint.java(revision 1072939)
+++ java/org/apache/tomcat/util/net/JIoEndpoint.java(working copy)
@@ -183,9 +183,19 @@
 @Override
 public void run() {

+int errorDelay = 0;
+
 // Loop until we receive a shutdown command
 while (running) {

+if (errorDelay > 0) {
+try {
+Thread.sleep(errorDelay);
+} catch (InterruptedException e) {
+// Ignore
+}
+}
+
 // Loop if endpoint is paused
 while (paused && running) {
 try {
@@ -225,9 +235,15 @@
 // Ignore
 }
 }
+errorDelay = 0;
 } catch (IOException x) {
 if (running) {
 log.error(sm.getString("endpoint.accept.fail"), x);
+if (errorDelay == 0) {
+errorDelay = 50;
+} else if (errorDelay < 1600) {
+errorDelay = errorDelay * 2;
+}
 }
 } catch (NullPointerException npe) {
 if (running) {



Thoughts / comments?

Mark


[1] http://pastebin.com/CrsujeW4

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Reaching ulimit values for open files can generate huge log files

2011-02-21 Thread Ian Darwin
On 02/21/11 10:21, Mark Thomas wrote:
> The ASF Sonar installation managed to generate 46GB of identical log
> messages [1] today in the 8 hours it took to notice it was down.

Continuing to drive down the cost of disk storage :-)

> While better monitoring would/should have identified the problem sooner,
> it does demonstrate a problem with the acceptor threads in all three
> endpoints. If there is a system-level issue that causes the accept()
> call to always fail (such as hitting the ulimit) then the endpoint
> essentially enters a loop where it logs an error message for every
> iteration of the loop. This will result in many log messages per second.
> 
> I'd like to do something about this. I was thinking of something along
> the lines of the following for each endpoint.
> 
> Index: java/org/apache/tomcat/util/net/JIoEndpoint.java
> ===
> --- java/org/apache/tomcat/util/net/JIoEndpoint.java  (revision 1072939)
> +++ java/org/apache/tomcat/util/net/JIoEndpoint.java  (working copy)
> @@ -183,9 +183,19 @@
>  @Override
>  public void run() {
> 
> +int errorDelay = 0;
> +
>  // Loop until we receive a shutdown command
>  while (running) {
> 
> +if (errorDelay > 0) {
> +try {
> +Thread.sleep(errorDelay);
> +} catch (InterruptedException e) {
> +// Ignore
> +}
> +}
> +
>  // Loop if endpoint is paused
>  while (paused && running) {
>  try {
> @@ -225,9 +235,15 @@
>  // Ignore
>  }
>  }
> +errorDelay = 0;
>  } catch (IOException x) {
>  if (running) {
>  log.error(sm.getString("endpoint.accept.fail"), x);
> +if (errorDelay == 0) {
> +errorDelay = 50;
> +} else if (errorDelay < 1600) {
> +errorDelay = errorDelay * 2;
> +}
>  }
>  } catch (NullPointerException npe) {
>  if (running) {
> 
> 
> 
> Thoughts / comments?

+1 - a bit of smarts in reducing redundant logging is usually a good thing.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1073019 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-02-21 Thread markt
Author: markt
Date: Mon Feb 21 15:31:05 2011
New Revision: 1073019

URL: http://svn.apache.org/viewvc?rev=1073019&view=rev
Log:
Withdraw patch while I work on a better one

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1073019&r1=1073018&r2=1073019&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Mon Feb 21 15:31:05 2011
@@ -124,20 +124,3 @@ PATCHES PROPOSED TO BACKPORT:
   http://svn.apache.org/viewvc?rev=1070609&view=rev
   +1: markt, kkolinko
   -1:
-
-* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48863
-  Better logging when specifying an invalid directory for a class loader.
-  Based on a patch by Ralf Hauser.
-  http://people.apache.org/~markt/patches/2011-02-18-bug48870.patch
-  +1: markt
-  -0: kkolinko: If I understand it corretly, it will nag about missing
-${catalina.base}/lib when running with separate home and base and that
-directory does not exist. I think that is too common issue to use warn(),
-and will need i18n if we would use info() and maybe use a simpler
-message for the common "does not exist" case. That will need a new
-patch.
-For the proposed patch: I am +1 to use it as is if s/log.warn/log.debug/.
-While we are at it, maybe add messages for the IS_JAR, IS_GLOB branches
-as well.
-  -1:
-



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1073047 - /tomcat/trunk/java/org/apache/catalina/startup/ClassLoaderFactory.java

2011-02-21 Thread markt
Author: markt
Date: Mon Feb 21 16:23:05 2011
New Revision: 1073047

URL: http://svn.apache.org/viewvc?rev=1073047&view=rev
Log:
Smarter solution for bug 48863

Modified:
tomcat/trunk/java/org/apache/catalina/startup/ClassLoaderFactory.java

Modified: tomcat/trunk/java/org/apache/catalina/startup/ClassLoaderFactory.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/startup/ClassLoaderFactory.java?rev=1073047&r1=1073046&r2=1073047&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/startup/ClassLoaderFactory.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/startup/ClassLoaderFactory.java Mon 
Feb 21 16:23:05 2011
@@ -168,9 +168,9 @@ public final class ClassLoaderFactory {
 } else if (repository.getType() == RepositoryType.DIR) {
 File directory = new File(repository.getLocation());
 directory = new File(directory.getCanonicalPath());
-if (!directory.exists() || !directory.isDirectory() ||
-!directory.canRead())
- continue;
+if (!validateFile(directory, RepositoryType.DIR)) {
+continue;
+}
 URL url = directory.toURI().toURL();
 if (log.isDebugEnabled())
 log.debug("  Including directory " + url);
@@ -178,21 +178,16 @@ public final class ClassLoaderFactory {
 } else if (repository.getType() == RepositoryType.JAR) {
 File file=new File(repository.getLocation());
 file = new File(file.getCanonicalPath());
-if (!file.exists() || !file.canRead())
+if (!validateFile(file, RepositoryType.JAR)) {
 continue;
+}
 URL url = file.toURI().toURL();
 if (log.isDebugEnabled())
 log.debug("  Including jar file " + url);
 set.add(url);
 } else if (repository.getType() == RepositoryType.GLOB) {
 File directory=new File(repository.getLocation());
-if (!directory.exists() || !directory.isDirectory() ||
-!directory.canRead()) {
-log.warn("Problem with directory [" +
-directory.getAbsolutePath() + "], exists: [" +
-directory.exists() + "], isDirectory: [" +
-directory.isDirectory() + "], canRead: [" +
-directory.canRead() + "]");
+if (!validateFile(directory, RepositoryType.GLOB)) {
 continue;
 }
 if (log.isDebugEnabled())
@@ -236,6 +231,38 @@ public final class ClassLoaderFactory {
 });
 }
 
+private static boolean validateFile(File file,
+RepositoryType type) {
+if (RepositoryType.DIR == type || RepositoryType.GLOB == type) {
+if (!file.exists() || !file.isDirectory() || !file.canRead()) {
+String msg = "Problem with directory [" +
+file.getAbsolutePath() + "], exists: [" +
+file.exists() + "], isDirectory: [" +
+file.isDirectory() + "], canRead: [" +
+file.canRead() + "]";
+
+if (!Bootstrap.getCatalinaHome().equals(
+Bootstrap.getCatalinaBase()) &&
+file.getAbsolutePath().startsWith(
+Bootstrap.getCatalinaBase())) {
+
+log.debug(msg);
+} else {
+log.warn(msg);
+}
+return false;
+}
+} else if (RepositoryType.JAR == type) {
+if (!file.exists() || !file.canRead()) {
+log.warn("Problem with JAR file [" +
+file.getAbsolutePath() + "], exists: [" +
+file.exists() + "], canRead: [" +
+file.canRead() + "]");
+return false;
+}
+}
+return true;
+}
 
 public static enum RepositoryType {
 DIR,



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [Tomcat Wiki] Update of "LocalBadContent" by KonstantinKolinko

2011-02-21 Thread sebb
On 21 February 2011 13:37, Apache Wiki  wrote:
> Dear Wiki user,
>
> You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for 
> change notification.
>
> The "LocalBadContent" page has been changed by KonstantinKolinko.
> The comment on this change is: Prohibit use of tinyurl.com, because of 
> certain spammer.
> http://wiki.apache.org/tomcat/LocalBadContent?action=diff&rev1=9&rev2=10

Note that LocalBadContent is not just for URLs - any text can be
matched, so it would be possible to match "Übersetzung Deutsch
Englisch" - and/or variations thereof - instead.

> --
>
>  shyxbc\.com\.cn
>  smbay\.cn
>  tiffanyonsale\.org
> + tinyurl\.com
>  tnb120\.com\.cn
>  tunfar\.com\.cn
>  u-tokyo\.ac\.jp
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Reaching ulimit values for open files can generate huge log files

2011-02-21 Thread Konstantin Kolinko
2011/2/21 Mark Thomas :
> The ASF Sonar installation managed to generate 46GB of identical log
> messages [1] today in the 8 hours it took to notice it was down.
>
> While better monitoring would/should have identified the problem sooner,
> it does demonstrate a problem with the acceptor threads in all three
> endpoints. If there is a system-level issue that causes the accept()
> call to always fail (such as hitting the ulimit) then the endpoint
> essentially enters a loop where it logs an error message for every
> iteration of the loop. This will result in many log messages per second.
>
> I'd like to do something about this. I was thinking of something along
> the lines of the following for each endpoint.
>
> Index: java/org/apache/tomcat/util/net/JIoEndpoint.java
>
> Thoughts / comments?
>

+1

I thought that maybe the try/catch triggering this should cover accept
only and not processSocket, but actually that does not matter as
processSocket already catches Throwable.

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1073075 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-02-21 Thread markt
Author: markt
Date: Mon Feb 21 17:19:42 2011
New Revision: 1073075

URL: http://svn.apache.org/viewvc?rev=1073075&view=rev
Log:
New proposal for 48863

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1073075&r1=1073074&r2=1073075&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Mon Feb 21 17:19:42 2011
@@ -124,3 +124,10 @@ PATCHES PROPOSED TO BACKPORT:
   http://svn.apache.org/viewvc?rev=1070609&view=rev
   +1: markt, kkolinko
   -1:
+
+* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48863
+  Provide an warning if there is a problem with a class path entry but use 
debug
+  level logging if it is expected due to catalina home/base split
+  http://people.apache.org/~markt/patches/2011-02-21-bug48863.patch
+  +1: markt
+  -1:



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Reaching ulimit values for open files can generate huge log files

2011-02-21 Thread Tim Funk
Do you want to limit the try/catch scope to just 
serverSocketFactory.acceptSocket since setSocketOptions() can also throw 
IOException?


Is there a case where a client can induce an exception while 
setSocketOptions() is processing?



-Tim

On 2/21/2011 10:21 AM, Mark Thomas wrote:

The ASF Sonar installation managed to generate 46GB of identical log
messages [1] today in the 8 hours it took to notice it was down.

While better monitoring would/should have identified the problem sooner,
it does demonstrate a problem with the acceptor threads in all three
endpoints. If there is a system-level issue that causes the accept()
call to always fail (such as hitting the ulimit) then the endpoint
essentially enters a loop where it logs an error message for every
iteration of the loop. This will result in many log messages per second.

I'd like to do something about this. I was thinking of something along
the lines of the following for each endpoint.


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Tomcat Wiki] Update of "MemoryLeakProtection" by SylvainLaurent

2011-02-21 Thread Apache Wiki
Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change 
notification.

The "MemoryLeakProtection" page has been changed by SylvainLaurent.
http://wiki.apache.org/tomcat/MemoryLeakProtection?action=diff&rev1=13&rev2=14

--

  
  = Summary matrix =
  ||'''Leak cause'''||'''Detected by tomcat'''||'''Fixed by 
tomcat'''||'''Possible enhancements'''||
- ||[[#customThreadLocal|Custom ThreadLocal class]]||>=6.0.24||6.0.24-6.0.26 
but is unsafe. Made optional from 6.0.27|| [[#48837|Detect child 
classloaders]], [[#49159|BZ 49159]] ||
- ||[[#webappClassInstanceAsThreadLocalValue|Webapp class instance as 
ThreadLocal value]]||>=6.0.24||6.0.24-6.0.26 but is unsafe. Made optional from 
6.0.27|| [[#48837|Detect child classloaders]], [[#49159|BZ 49159]] ||
+ ||[[#customThreadLocal|Custom ThreadLocal class]]||>=6.0.24|| >= 7.0.6 ||  ||
+ ||[[#webappClassInstanceAsThreadLocalValue|Webapp class instance as 
ThreadLocal value]]||>=6.0.24|| >= 7.0.6 || ||
- ||[[#webappClassInstanceAsThreadLocalIndirectValue|Webapp class instance 
indirectly held through a ThreadLocal value]]||no||no||[[#49159|Renew threads 
in the worker pool]]||
+ ||[[#webappClassInstanceAsThreadLocalIndirectValue|Webapp class instance 
indirectly held through a ThreadLocal value]]||no|| >= 7.0.6 || ||
- ||[[#threadLocalPseudoLeak|ThreadLocal pseudo-leak]]||>=6.0.24||6.0.24-6.0.26 
but is unsafe. Made optional from 6.0.27||[[#49159|BZ 49159]]||
+ ||[[#threadLocalPseudoLeak|ThreadLocal pseudo-leak]]||>=6.0.24|| >= 7.0.6 || 
||
- ||[[#cclThreadSpawnedByWebApp|ContextClassLoader / Threads spawned by 
webapps]]||>=6.0.24||In 6.0.24-6.0.26 {{{TimerThread}}} are stopped but it may 
lead to problems. Optional from 6.0.27 with the 
{{{clearReferencesStopTimerThreads}}} flag. Other threads may be stopped with 
the {{{clearReferencesStopThreads}}} flag, but it's unsafe. ||[[#48837|Detect 
child classloaders]], Fix the application to stop the thread when the 
application is stopped||
+ ||[[#cclThreadSpawnedByWebApp|ContextClassLoader / Threads spawned by 
webapps]]||>=6.0.24||In 6.0.24-6.0.26 {{{TimerThread}}} are stopped but it may 
lead to problems. Optional from 6.0.27 with the 
{{{clearReferencesStopTimerThreads}}} flag. Other threads may be stopped with 
the {{{clearReferencesStopThreads}}} flag, but it's unsafe. || Fix the 
application to stop the thread when the application is stopped||
- ||[[#cclThreadSpawnedByCommonClassLoader|ContextClassLoader / Threads spawned 
by classes loaded by the common classloader]]||>=6.0.24||In 6.0.24-6.0.26 
{{{TimerThread}}} are stopped but it may lead to problems. Optional from 6.0.27 
with the {{{clearReferencesStopTimerThreads}}} flag. Other threads may be 
stopped with the {{{clearReferencesStopThreads}}} flag, but it's unsafe. 
||[[#48837|Detect child classloaders]], fix the offending code (set the correct 
CCL when spawning the thread)||
+ ||[[#cclThreadSpawnedByCommonClassLoader|ContextClassLoader / Threads spawned 
by classes loaded by the common classloader]]||>=6.0.24||In 6.0.24-6.0.26 
{{{TimerThread}}} are stopped but it may lead to problems. Optional from 6.0.27 
with the {{{clearReferencesStopTimerThreads}}} flag. Other threads may be 
stopped with the {{{clearReferencesStopThreads}}} flag, but it's unsafe. ||Fix 
the offending code (set the correct CCL when spawning the thread)||
  ||[[#cclThreadSpawnedByJRE|ContextClassLoader / Threads spawned by JRE 
classes]]|| no || >=6.0.24 pre-spawns some known offenders || ||
  ||[[#staticClassVariables|static class variables]]|| no ||> 6.0.? . Disabled 
by default with tomcat 7|| ||
  ||[[#LogFactory|LogFactory]]||  ||> 6.0.? || ||
@@ -82, +82 @@

  
  Hopefully tomcat 6.0.24 can detect the leak when the application is stopped: 
each Thread in the JVM is examined, and the internal structures of the Thread 
and {{{ThreadLocal}}} classes are introspected to see if either the 
{{{ThreadLocal}}} instance or the value bound to it were loaded by the 
{{{WebAppClassLoader}}} of the application being stopped.
  
+ In this particular case, the leak is detected and a message is logged. 
- In this particular case, the leak is detected and a message is logged. Tomcat 
6.0.24 to 6.0.26 modify internal structures of the JDK ({{{ThreadLocalMap}}}) 
to remove the reference to the {{{ThreadLocal}}} instance, but this is unsafe 
(see [[#48895]]) so that it became optional and disabled by default from 6.0.27.
+ Tomcat 6.0.24 to 6.0.26 modify internal structures of the JDK 
({{{ThreadLocalMap}}}) to remove the reference to the {{{ThreadLocal}}} 
instance, but this is unsafe (see [[#48895]]) so that it became optional and 
disabled by default from 6.0.27.
+ Starting with Tomcat 7.0.6, the threads of the pool are renewed so that the 
leak is safely fixed. 
  
  {{{
  Mar 16, 2010 11:47:24 PM org.apache.catalina.loader.WebappClassLoader 
clearThreadLocalMap
  SEVERE: A web application created a ThreadLocal 

[Tomcat Wiki] Trivial Update of "MemoryLeakProtection" by SylvainLaurent

2011-02-21 Thread Apache Wiki
Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change 
notification.

The "MemoryLeakProtection" page has been changed by SylvainLaurent.
http://wiki.apache.org/tomcat/MemoryLeakProtection?action=diff&rev1=14&rev2=15

--

   * [[http://www.eclipse.org/mat|Eclipse Memory Analysis Tool]]
  
  Related issues
-  * 
<>[[https://issues.apache.org/bugzilla/show_bug.cgi?id=48837|48837]]
 - Memory leaks protection does not cure leaks triggered by JSP pages code
   * <>[[https://issues.apache.org/bugzilla/show_bug.cgi?id= 
49159|49159]] - Improve ThreadLocal memory leak clean-up
   * [[http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4957990|Sun bug 
4957990]] - In some cases the Server JVM fails to collect classloaders. 
According to [[http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4957990|this 
page]] it should have been fixed with java 6u16 but actually it was not. It 
seems to be fixed with 6u21 (documented 
[[http://download.java.net/jdk6/6u21/promoted/b03/changes/JDK6u21.list.html|here]]
 and verified by the author of this wiki page).
   * [[http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6916498|Sun bug 
6916498]] - An exception can keep a classloader in memory if the stack trace 
that was recorded when it was created contains a reference to one of its 
classes. Some fixes have been made in tomcat (see 
[[https://issues.apache.org/bugzilla/show_bug.cgi?id=50460|BZ 50460]]), but 
some library or JRE code may still create a leak that is undetected by tools 
because of this JVM bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Page Tomcat 中文文档 deleted from Tomcat Wiki

2011-02-21 Thread Apache Wiki
Dear wiki user,

You have subscribed to a wiki page "Tomcat Wiki" for change notification.

The page "Tomcat 中文文档" has been deleted by markt.
The comment on this change is: Incorrect information that the original poster 
failed to correct when asked..
http://wiki.apache.org/tomcat/Tomcat%20%E4%B8%AD%E6%96%87%E6%96%87%E6%A1%A3

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Page Category:OSS Tomcat deleted from Tomcat Wiki

2011-02-21 Thread Apache Wiki
Dear wiki user,

You have subscribed to a wiki page "Tomcat Wiki" for change notification.

The page "Category:OSS Tomcat" has been deleted by markt.
The comment on this change is: Cleaning up orphaned pages.
http://wiki.apache.org/tomcat/Category%3AOSS%20Tomcat

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Page ErikMartensen deleted from Tomcat Wiki

2011-02-21 Thread Apache Wiki
Dear wiki user,

You have subscribed to a wiki page "Tomcat Wiki" for change notification.

The page "ErikMartensen" has been deleted by markt.
The comment on this change is: Cleaning up orphaned pages.
http://wiki.apache.org/tomcat/ErikMartensen

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Page FasterStartUpShareJars deleted from Tomcat Wiki

2011-02-21 Thread Apache Wiki
Dear wiki user,

You have subscribed to a wiki page "Tomcat Wiki" for change notification.

The page "FasterStartUpShareJars" has been deleted by markt.
The comment on this change is: Cleaning up orphaned pages. Also bad advice..
http://wiki.apache.org/tomcat/FasterStartUpShareJars

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Page JakartaTomcat deleted from Tomcat Wiki

2011-02-21 Thread Apache Wiki
Dear wiki user,

You have subscribed to a wiki page "Tomcat Wiki" for change notification.

The page "JakartaTomcat" has been deleted by markt.
The comment on this change is: Cleaning up orphaned pages.
http://wiki.apache.org/tomcat/JakartaTomcat

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Page JürgenHermann deleted from Tomcat Wiki

2011-02-21 Thread Apache Wiki
Dear wiki user,

You have subscribed to a wiki page "Tomcat Wiki" for change notification.

The page "JürgenHermann" has been deleted by markt.
The comment on this change is: Cleaning up orphaned pages.
http://wiki.apache.org/tomcat/J%C3%BCrgenHermann

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Page OJBProjectPages/TomcatReloadBreaksOjB deleted from Tomcat Wiki

2011-02-21 Thread Apache Wiki
Dear wiki user,

You have subscribed to a wiki page "Tomcat Wiki" for change notification.

The page "OJBProjectPages/TomcatReloadBreaksOjB" has been deleted by markt.
The comment on this change is: Cleaning up orphaned pages.
http://wiki.apache.org/tomcat/OJBProjectPages/TomcatReloadBreaksOjB

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Page Tomcat 安装/使用 deleted from Tomcat Wiki

2011-02-21 Thread Apache Wiki
Dear wiki user,

You have subscribed to a wiki page "Tomcat Wiki" for change notification.

The page "Tomcat 安装/使用" has been deleted by markt.
The comment on this change is: Cleaning up orphaned pages.
http://wiki.apache.org/tomcat/Tomcat%20%E5%AE%89%E8%A3%85/%E4%BD%BF%E7%94%A8

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Page TomcatWeb deleted from Tomcat Wiki

2011-02-21 Thread Apache Wiki
Dear wiki user,

You have subscribed to a wiki page "Tomcat Wiki" for change notification.

The page "TomcatWeb" has been deleted by markt.
The comment on this change is: Cleaning up orphaned pages. Also very out of 
date..
http://wiki.apache.org/tomcat/TomcatWeb

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Page Tomcat/Jk2Connector deleted from Tomcat Wiki

2011-02-21 Thread Apache Wiki
Dear wiki user,

You have subscribed to a wiki page "Tomcat Wiki" for change notification.

The page "Tomcat/Jk2Connector" has been deleted by markt.
The comment on this change is: Cleaning up orphaned pages.
http://wiki.apache.org/tomcat/Tomcat/Jk2Connector

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Page Tomcat/Jk2RemoteJmx deleted from Tomcat Wiki

2011-02-21 Thread Apache Wiki
Dear wiki user,

You have subscribed to a wiki page "Tomcat Wiki" for change notification.

The page "Tomcat/Jk2RemoteJmx" has been deleted by markt.
The comment on this change is: Cleaning up orphaned pages.
http://wiki.apache.org/tomcat/Tomcat/Jk2RemoteJmx

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Page TomcatFAQ deleted from Tomcat Wiki

2011-02-21 Thread Apache Wiki
Dear wiki user,

You have subscribed to a wiki page "Tomcat Wiki" for change notification.

The page "TomcatFAQ" has been deleted by markt.
The comment on this change is: Cleaning up orphaned pages.
http://wiki.apache.org/tomcat/TomcatFAQ

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Page TomcatFAQ/ModJK2OnRedHat deleted from Tomcat Wiki

2011-02-21 Thread Apache Wiki
Dear wiki user,

You have subscribed to a wiki page "Tomcat Wiki" for change notification.

The page "TomcatFAQ/ModJK2OnRedHat" has been deleted by markt.
The comment on this change is: Cleaning up orphaned pages.
http://wiki.apache.org/tomcat/TomcatFAQ/ModJK2OnRedHat

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Page Tomcat/Howto deleted from Tomcat Wiki

2011-02-21 Thread Apache Wiki
Dear wiki user,

You have subscribed to a wiki page "Tomcat Wiki" for change notification.

The page "Tomcat/Howto" has been deleted by markt.
The comment on this change is: Cleaning up orphaned pages.
http://wiki.apache.org/tomcat/Tomcat/Howto

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Tomcat Wiki] Update of "HowTo/FasterStartUp" by KonstantinKolinko

2011-02-21 Thread Apache Wiki
Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change 
notification.

The "HowTo/FasterStartUp" page has been changed by KonstantinKolinko.
The comment on this change is: Remove an advise that is really bad. Add 
category..
http://wiki.apache.org/tomcat/HowTo/FasterStartUp?action=diff&rev1=12&rev2=13

--

  = How do I make Tomcat startup faster? =
  
  == Jars ==
-  1.  If you are loading many web applications which which have the same jars 
in their WEB-INF/lib then consider moving the shared jars from WEB-INF/lib into 
the tomcat shared directory {catalina.home}/shared/lib
-  This will reduce the memory used by each web app, reduce the size of your 
your war files, and increase start up time.
-  See http://tomcat.apache.org/tomcat-5.5-doc/class-loader-howto.html
- 
-  2.  Remove any jar files you don't need. When searching for classes every 
JAR file needs to be examined to find the needed class. Also during webapp 
startup, jar files are searched for TLD files. If the jar file is not there - 
there is nothing to search.
+  1.  Remove any jar files you don't need. When searching for classes every 
JAR file needs to be examined to find the needed class. Also during webapp 
startup, jar files are searched for TLD files. If the jar file is not there - 
there is nothing to search.
  
  == Memory ==
   1.  Tweak memory parameters - Google is your friend.
@@ -21, +17 @@

   1.  Make sure your code is not doing slow things. (Use a profiler)
   2.  Remove any webapps you don't need. (So remove the all the webapps 
installed with tomcat)
   
+ 
+ [[CategoryFAQ]]
  

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1073184 - /tomcat/trunk/java/org/apache/catalina/valves/SSLValve.java

2011-02-21 Thread markt
Author: markt
Date: Mon Feb 21 23:21:09 2011
New Revision: 1073184

URL: http://svn.apache.org/viewvc?rev=1073184&view=rev
Log:
Convert to Javadoc comment and add some additional info

Modified:
tomcat/trunk/java/org/apache/catalina/valves/SSLValve.java

Modified: tomcat/trunk/java/org/apache/catalina/valves/SSLValve.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/SSLValve.java?rev=1073184&r1=1073183&r2=1073184&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/valves/SSLValve.java (original)
+++ tomcat/trunk/java/org/apache/catalina/valves/SSLValve.java Mon Feb 21 
23:21:09 2011
@@ -28,22 +28,35 @@ import org.apache.catalina.Globals;
 import org.apache.catalina.connector.Request;
 import org.apache.catalina.connector.Response;
 
-/*
- * Valve to fill the SSL informations in the request
- * mod_header is used to fill the headers and the valve
- * will fill the parameters of the request.
+/**
+ * When using mod_proxy_http, the client SSL information is not included in the
+ * protocol (unlike mod_jk and mod_proxy_ajp). To make the client SSL
+ * information available to Tomcat, some additional configuration is required.
+ * In httpd, mod_headers is used to add the SSL information as HTTP headers. In
+ * Tomcat, this valve is used to read the information from the HTTP headers and
+ * insert it into the request.
+ * 
+ * Note: Ensure that the headers are always set by httpd for all requests to
+ * prevent a client spoofing SSL information by sending fake headers. 
+ * 
  * In httpd.conf add the following:
- * 
+ * 
+ * 
  *   RequestHeader set SSL_CLIENT_CERT "%{SSL_CLIENT_CERT}s"
  *   RequestHeader set SSL_CIPHER "%{SSL_CIPHER}s"
  *   RequestHeader set SSL_SESSION_ID "%{SSL_SESSION_ID}s"
  *   RequestHeader set SSL_CIPHER_USEKEYSIZE "%{SSL_CIPHER_USEKEYSIZE}s"
- * 
- *
- * @author Jean-Frederic Clere
- * @version $Id$
+ * 
+ * 
+ * 
+ * In server.xml, configure this valve under the Engine element in server.xml:
+ * 
+ * 
+ *   
+ *   
+ * 
+ * 
  */
-
 public class SSLValve extends ValveBase {
 
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 39053] include Tomcat embedded sample

2011-02-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=39053

Mark Thomas  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution||WONTFIX

--- Comment #6 from Mark Thomas  2011-02-21 19:08:35 EST ---
For the now deprecated Embedded class, Catalina serves as an example.

For the new Tomcat class, there are numerous examples in the unit tests.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 24739] Control of secure flag when establishing sessions through https using cookies

2011-02-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=24739

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WONTFIX

--- Comment #3 from Mark Thomas  2011-02-21 19:13:23 EST ---
On further reflection, I am closing this as WONTFIX. I can't see a valid,
secure use case for creating a session of https and then exposing the session
ID over http.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org