date:20110118

DO NOT REPLY [Bug 50604] Incorrect dependency in jasper.pom for eclipse ecj

2011-01-18 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=50604

--- Comment #3 from Mark Thomas  2011-01-18 04:41:14 EST ---
Background:

Up to 6.0.29 the Tomcat build process went through a convoluted process to
generate what was essentially ecj.jar from jdt.jar. This meant a 40MB+ download
was required to create a 1MB jar. The advantage was that the Jar was a Tomcat
jar and was uploaded as part of the upload process.

7.0.x and 6.0.30 onwards use ecj.jar directly to speed up the build process.


Issue:

As far as I can tell from Googling, the Eclipse jars have been uploaded
manually by various third parties. I'll add looking at this to my todo list but
there is no reason stopping you doing it yourself and since this is your itch I
suspect you'll get this done faster than I will. I did see from looking at the
comments in one of the poms [1] that the process appeared to have been
automated although since it is just ecj.jar then it shouldn't be too hard to do
manually.

[1]
http://repo2.maven.org/maven2/org/eclipse/jdt/core/compiler/ecj/3.5.1/ecj-3.5.1.pom

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 50606] Error running CGI executable in Tomcat 6.0.30

2011-01-18 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=50606

Konstantin Kolinko  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID

--- Comment #1 from Konstantin Kolinko  2011-01-18 
04:52:18 EST ---
You have

  executable
  


i.e. you are setting executable="". The logs say that the attempt to execute ""
failed.

The change between 6.0.29 and 6.0.30 in CGIServlet is 
http://svn.apache.org/viewvc?view=revision&revision=1004424

In 6.0.29 the command to be executed was built as a single string,
concatenating the components. In 6.0.30 all the components are passes in as an
array.

Are you sure that the empty string is a valid value for the "executable"? I do
not think that that is a valid value. Thus I am closing this issue as INVALID.


If you need further assistance, please ask on the users@ list.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Hosting the current Tomcat Maven Plugin from mojo codehaus

2011-01-18 Thread Olivier Lamy

Hi Folks,
As you probably know there is a Tomcat Maven plugin available
@codehaus [1] which provide various maven goals to use tomcat during
dev process.
So the probably best and more natural place to host is (IMHO) the ASF
repo (in the tomcat path).
The two main contributors Mark Hobson (asf id : markh) and myself (asf
id : olamy) are already ASF committers.

So WDYT ? (Note : if this goes well, I will have to start an other
vote in the codehaus mojo dev ml).

Thanks,
-- 
Olivier Lamy
http://twitter.com/olamy
http://www.linkedin.com/in/olamy

[1] http://mojo.codehaus.org/tomcat-maven-plugin/

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Hosting the current Tomcat Maven Plugin from mojo codehaus

2011-01-18 Thread Mark Thomas

On 18/01/2011 10:32, Olivier Lamy wrote:
> Hi Folks,
> As you probably know there is a Tomcat Maven plugin available
> @codehaus [1] which provide various maven goals to use tomcat during
> dev process.
> So the probably best and more natural place to host is (IMHO) the ASF
> repo (in the tomcat path).
> The two main contributors Mark Hobson (asf id : markh) and myself (asf
> id : olamy) are already ASF committers.
> 
> So WDYT ? (Note : if this goes well, I will have to start an other
> vote in the codehaus mojo dev ml).

+1. Seems like an ideal candidate for /tomcat/modules to me.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Hosting the current Tomcat Maven Plugin from mojo codehaus

2011-01-18 Thread Konstantin Kolinko

2011/1/18 Mark Thomas :
> On 18/01/2011 10:32, Olivier Lamy wrote:
>> Hi Folks,
>> As you probably know there is a Tomcat Maven plugin available
>> @codehaus [1] which provide various maven goals to use tomcat during
>> dev process.
>> So the probably best and more natural place to host is (IMHO) the ASF
>> repo (in the tomcat path).
>> The two main contributors Mark Hobson (asf id : markh) and myself (asf
>> id : olamy) are already ASF committers.
>>
>> So WDYT ? (Note : if this goes well, I will have to start an other
>> vote in the codehaus mojo dev ml).
>
> +1. Seems like an ideal candidate for /tomcat/modules to me.
>
> Mark
>

+1

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Time for 5.5.32??

2011-01-18 Thread jean-frederic clere


On 01/17/2011 03:02 PM, Jim Jagielski wrote:

I'd like to look over the remaining STATUS of 5.5 in hopes of
getting a 5.5.32 out soon... I'll RM.

Comments?


+1

Cheers

Jean-Frederic

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Improving CGIServlet - path and args to the executable

2011-01-18 Thread Konstantin Kolinko

Hi!

In 6.0.30 to fix BZ 49657 we changed the way how cgi command is built
in CGI Servlet:
http://svn.apache.org/viewvc?view=revision&revision=1004424

Earlier implementation used to build the command as a single string,
wrapping parts of it in double quotes. The new implementation uses
Runtime.exec(String[]) and passes all arguments separate from each
other as an array.

This causes regression for people using empty value for "executable"
init-param, as reported in
https://issues.apache.org/bugzilla/show_bug.cgi?id=50606

I closed BZ 50606 as INVALID but now I am changing my mind. Looking around

1) there are sites that recommend using an empty string for "executable"
http://stackoverflow.com/questions/499456/cgi-and-tomcat/500527#500527

Apparently it is to run programs that themselves are executables, as
*.exe on Windows.

2) some put in arguments for the executable, as "cmd /q /c"
http://webcache.googleusercontent.com/search?q=cache:njmdNKdXzNMJ:www.tek-tips.com/faqs.cfm%3Ffid%3D6467
(Should be http://www.tek-tips.com/faqs.cfm?fid=6467 but the original
site is inaccessible now).

I do not like to revert r1004424 and bother with quotes, nor I want to
parse "executable" into separate strings.
So I think of the following:
1. Allow empty value of "executable" init-param
2. Introduce additional init-params to explicitly specify additional arguments:
"executable-arg-1"
"executable-arg-2"
etc. starting with "1"

So cmd /q /c will be written as


  executable
  cmd.exe


  executable-arg-1
  /q


  executable-arg-2
  /c


What do you think?

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1060465 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt java/org/apache/catalina/ha/deploy/WarWatcher.java webapps/docs/changelog.xml

2011-01-18 Thread markt

Author: markt
Date: Tue Jan 18 16:55:14 2011
New Revision: 1060465

URL: http://svn.apache.org/viewvc?rev=1060465&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50600
Avoid ConcurrentModificationException when removing WAR via FarmWarDeployer

Modified:
tomcat/tc6.0.x/trunk/   (props changed)
tomcat/tc6.0.x/trunk/STATUS.txt
tomcat/tc6.0.x/trunk/java/org/apache/catalina/ha/deploy/WarWatcher.java
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc6.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Tue Jan 18 16:55:14 2011
@@ -1 +1 @@
-/tomcat/trunk:601180,606992,612607,630314,640888,652744,653247,666232,673796,673820,677910,683969,683982,684001,684081,684234,684269-684270,685177,687503,687645,689402,690781,691392,691805,692748,693378,694992,695053,695311,696780,696782,698012,698227,698236,698613,699427,699634,701355,709294,709811,709816,710063,710066,710125,710205,711126,711600,712461,712467,713953,714002,718360,719119,719124,719602,719626,719628,720046,720069,721040,721286,721708,721886,723404,723738,726052,727303,728032,728768,728947,729057,729567,729569,729571,729681,729809,729815,729934,730250,730590,731651,732859,732863,734734,740675,740684,742677,742697,742714,744160,744238,746321,746384,746425,747834,747863,748344,750258,750291,750921,751286-751287,751289,751295,752323,753039,757335,757774,758249,758365,758596,758616,758664,759074,761601,762868,762929,762936-762937,763166,763183,763193,763228,763262,763298,763302,763325,763599,763611,763654,763681,763706,764985,764997,765662,768335,769979,770716,77
 
0809,770876,772872,776921,776924,776935,776945,777464,777466,777576,777625,778379,778523-778524,781528,781779,782145,782791,783316,783696,783724,783756,783762,783766,783863,783934,784453,784602,784614,785381,785688,785768,785859,786468,786487,786490,786496,786667,787627,787770,787985,789389,790405,791041,791184,791194,791224,791243,791326,791328,791789,792740,793372,793757,793882,793981,794082,794673,794822,795043,795152,795210,795457,795466,797168,797425,797596,797607,802727,802940,804462,804544,804734,805153,809131,809603,810916,810977,812125,812137,812432,813001,813013,813866,814180,814708,814876,815972,816252,817442,817822,819339,819361,820110,820132,820874,820954,821397,828196,828201,828210,828225,828759,830378-830379,830999,831106,831774,831785,831828,831850,831860,832214,832218,833121,833545,834047,835036,835336,836405,881396,881412,883130,883134,883146,883165,883177,883362,883565,884341,885038,885231,885241,885260,885901,885991,886019,888072,889363,889606,889716,8901
 
39,890265,890349-890350,890417,891185-891187,891583,892198,892341,892415,892464,892555,892812,892814,892817,892843,892887,893321,893493,894580,894586,894805,894831,895013,895045,895057,895191,895392,895703,896370,896384,897380-897381,897776,898126,898256,898468,898527,898555,898558,898718,898836,898906,899284,899348,899420,899653,899769-899770,899783,899788,899792,899916,899918-899919,899935,899949,903916,905020,905151,905722,905728,905735,907311,907513,907538,907652,907819,907825,907864,908002,908721,908754,908759,909097,909206,909212,909525,909636,909869,909875,909887,910266,910370,910442,910471,910485,910974,915226,915737,915861,916097,916141,916157,916170,917598,917633,918093,918489,918594,918684,918787,918792,918799,918803,918885,919851,919914,920025,920055,920298,920449,920596,920824,920840,921444,922010,926716,927062,927621,928482,928695,928732,928798,931709,932357,932967,935105,935983,939491,939551,940064,941356,941463,944409,944416,945231,945808,945835,945841,946686
 
,948057,950164,950596,950614,950851,950905,951615,953434,954435,955648,955655,956832,957130,957830,958192,960701,961948,962865,962872,962881,962900,963106,963865,963868,964614,966177-966178,966292,966692,966863,981815,988448,991837,993042,1001955,1002185,1002263,1002274,1002349,1002359,1002362,1002481,1002514,1003461,1003481,1003488,1003556,1003572,1003581,1003861,1004393,1004409,1004415,1004868-1004869,1004912,1005452,1005467,1005647,1005802,1022120,1022134,1022323,1022415,1022606,1022623,1024224,1024251,1026042,1026784,1026912,1026920,1029767,1033415,1033448,1033842,1033897,1037715,1037794,1037887,1037924,1038041,1042022,1042029,1042447,1042452,1042494,1044944,1044987,1055055,1055236,1055458,1056264
+/tomcat/trunk:601180,606992,612607,630314,640888,652744,653247,666232,673796,673820,677910,683969,683982,684001,684081,684234,684269-684270,685177,687503,687645,689402,690781,691392,691805,692748,693378,694992,695053,695311,696780,696782,698012,698227,698236,698613,699427,699634,701355,709294,709811,709816,710063,710066,710125,710205,711126,711600,712461,712467,713953,714002,718360,719119,719124,719602,719626,719628,720046,720069,721040,721286,721708,721886,723404,723738,726052,727303,728032,728768,728947,729057,729567,729569,729571,729681,729809,729815,729934,730250,730590,731651,732859,732863,734734,740675,740684,74267

DO NOT REPLY [Bug 50600] ConcurrentModificationException removing WAR via FarmWarDeployer

2011-01-18 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=50600

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #2 from Mark Thomas  2011-01-18 11:55:38 EST ---
Fixed in 6.0.x and will be included in 6.0.31 onwards

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1060467 - in /tomcat/tc6.0.x/trunk: ./ java/org/apache/catalina/ java/org/apache/catalina/core/ java/org/apache/catalina/startup/ webapps/docs/ webapps/docs/config/

2011-01-18 Thread markt

Author: markt
Date: Tue Jan 18 17:01:07 2011
New Revision: 1060467

URL: http://svn.apache.org/viewvc?rev=1060467&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50205
Add deployIgnore to Host
Based on a patch by Jim Riggs (markt/kkolinko)

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
tomcat/tc6.0.x/trunk/java/org/apache/catalina/Host.java
tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/StandardHost.java
tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/mbeans-descriptors.xml
tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/HostConfig.java

tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/LocalStrings.properties
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
tomcat/tc6.0.x/trunk/webapps/docs/config/host.xml

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1060467&r1=1060466&r2=1060467&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Jan 18 17:01:07 2011
@@ -145,15 +145,3 @@ PATCHES PROPOSED TO BACKPORT:
   http://svn.apache.org/viewvc?rev=1056889&view=rev
   +1: kkolinko, markt, kfujino
   -1:
-
-* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50205
-  Add deployIgnore to Host
-  Based on a patch by Jim Riggs
-  http://svn.apache.org/viewvc?rev=1057275&view=rev
-  +1: markt
-  -1:
-
-  Updated patch (merge of revs.1057275,1057788,1057990):
-  http://people.apache.org/~kkolinko/patches/2011-01-17_tc6_50205.patch
-  +1: kkolinko, kfujino
-  -1:

Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/Host.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/Host.java?rev=1060467&r1=1060466&r2=1060467&view=diff
==
--- tomcat/tc6.0.x/trunk/java/org/apache/catalina/Host.java (original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/Host.java Tue Jan 18 17:01:07 
2011
@@ -14,10 +14,9 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-
-
 package org.apache.catalina;
 
+import java.util.regex.Pattern;
 
 
 /**
@@ -181,6 +180,30 @@ public interface Host extends Container 
 public void setXmlNamespaceAware(boolean xmlNamespaceAware);
 
 
+/**
+ * Return the regular expression that defines the files and directories in
+ * the host's {@link #appBase} that will be ignored by the automatic
+ * deployment process.
+ */
+public String getDeployIgnore();
+
+
+/**
+ * Return the compiled regular expression that defines the files and
+ * directories in the host's {@link #appBase} that will be ignored by the
+ * automatic deployment process.
+ */
+public Pattern getDeployIgnorePattern();
+
+
+/**
+ * Set the regular expression that defines the files and directories in
+ * the host's {@link #appBase} that will be ignored by the automatic
+ * deployment process.
+ */
+public void setDeployIgnore(String deployIgnore);
+
+
 // - Public Methods
 
 

Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/StandardHost.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/StandardHost.java?rev=1060467&r1=1060466&r2=1060467&view=diff
==
--- tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/StandardHost.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/StandardHost.java Tue 
Jan 18 17:01:07 2011
@@ -23,6 +23,7 @@ import java.util.ArrayList;
 import java.util.List;
 import java.util.Map;
 import java.util.WeakHashMap;
+import java.util.regex.Pattern;
 
 import javax.management.MBeanServer;
 import javax.management.ObjectName;
@@ -180,6 +181,14 @@ public class StandardHost
  private Map childClassLoaders =
  new WeakHashMap();
 
+ /**
+  * Any file or directory in {@link #appBase} that this pattern matches 
will
+  * be ignored by the automatic deployment process (both
+  * {@link #deployOnStartup} and {@link #autoDeploy}).
+  */
+ private Pattern deployIgnore = null;
+
+
 // - Properties
 
 
@@ -384,8 +393,8 @@ public class StandardHost
this.errorReportValveClass);
 
 }
-
-
+
+
 /**
  * Return the canonical, fully qualified, name of the virtual host
  * this Container represents.
@@ -496,6 +505,52 @@ public class StandardHost
 }
 
 
+/**
+ * Return the regular expression that defines the files and directories in
+ * the host's {@link #appBase} that will be ignored by the automatic
+ * deployment process.
+ */
+public String getDeployIgnore() {

DO NOT REPLY [Bug 50205] Add deployIgnorePaths attribute to StandardHost

2011-01-18 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=50205

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #4 from Mark Thomas  2011-01-18 12:01:30 EST ---
Fixed in 6.0.x and will be included in 6.0.31 onwards.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1060472 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-01-18 Thread markt

Author: markt
Date: Tue Jan 18 17:04:20 2011
New Revision: 1060472

URL: http://svn.apache.org/viewvc?rev=1060472&view=rev
Log:
Vote

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1060472&r1=1060471&r2=1060472&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Jan 18 17:04:20 2011
@@ -96,8 +96,8 @@ PATCHES PROPOSED TO BACKPORT:
   +1: markt, rjung
   -1:
   rjung: getSessionExpireRate() and getSessionCreateRate() could share a common
- implementation (same method body expcept for the input list). The 
member
-  "duration" of SessionTiming doesn not seem to get used.
+ implementation (same method body except for the input list). The 
member
+  "duration" of SessionTiming does not seem to get used.
 
 * Backport AprEndpoint shutdown patch (BZ49795 and similar).
   http://people.apache.org/~mturk/tomcat/patches/tomcat-6.0.x-aprshutdown.patch
@@ -131,7 +131,7 @@ PATCHES PROPOSED TO BACKPORT:
   -1:
   Additional patch (not important):
   http://svn.apache.org/viewvc?rev=1056828&view=rev
-  +1: kkolinko
+  +1: kkolinko, markt
   -1:
   
 * Add helper class to allow a shared data source with different credentials



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1060477 - /tomcat/tc5.5.x/trunk/STATUS.txt

2011-01-18 Thread markt

Author: markt
Date: Tue Jan 18 17:07:39 2011
New Revision: 1060477

URL: http://svn.apache.org/viewvc?rev=1060477&view=rev
Log:
Vote

Modified:
tomcat/tc5.5.x/trunk/STATUS.txt

Modified: tomcat/tc5.5.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=1060477&r1=1060476&r2=1060477&view=diff
==
--- tomcat/tc5.5.x/trunk/STATUS.txt (original)
+++ tomcat/tc5.5.x/trunk/STATUS.txt Tue Jan 18 17:07:39 2011
@@ -64,7 +64,7 @@ PATCHES PROPOSED TO BACKPORT:
svn copy ../../trunk/res/uninst.ico build/resources/
   2. Apply patch:
http://people.apache.org/~kkolinko/patches/2011-01-17_tc55_tomcat-nsi.patch
-  +1: kkolinko
+  +1: kkolinko, markt
   -1:
 
For reference: here is the diff of tomcat.nsi of trunk @1059900 if I copy
@@ -73,21 +73,21 @@ PATCHES PROPOSED TO BACKPORT:
 
 * Configure manager, host-manager and admin webapps to use HttpOnly for 
session cookies
   http://people.apache.org/~kkolinko/patches/2010-11-22_tc55_httpOnly.patch
-  +1: kkolinko, rjung
+  +1: kkolinko, rjung, markt
   -1:
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50460
   Avoid leak caused by using a cached exception instance
   http://svn.apache.org/viewvc?rev=1044987&view=rev
   (without the @Override annotations)
-  +1: kkolinko, rjung
+  +1: kkolinko, rjung, markt
   -1:
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50547
   Add time stamp for CHANGE_SESSION_ID and SESSION_EXPIRED message.
   http://svn.apache.org/viewvc?view=revision&revision=1055798
   https://issues.apache.org/bugzilla/attachment.cgi?id=26482 (patch against 
tc5.5)
-  +1: kfujino
+  +1: kfujino, markt
   -1:
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50550
@@ -100,19 +100,19 @@ PATCHES PROPOSED TO BACKPORT:
 
   Additional patch (not important):
   http://svn.apache.org/viewvc?rev=1056828&view=rev
-  +1: kkolinko
+  +1: kkolinko, markt
   -1:
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47319
   Return IP address rather than null for getRemoteHost() and the APR connector
   http://svn.apache.org/viewvc?view=revision&revision=1056414
   (markt's patch)
-  +1: kkolinko, rjung
+  +1: kkolinko, rjung, markt
   -1:
 
 * Additional patch for bug 50413:
   Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50413#c6
   Serve the error page regardless of "Range" header in the original request.
   http://svn.apache.org/viewvc?rev=1056889&view=rev
-  +1: kkolinko
+  +1: kkolinko, markt
   -1:



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1060486 - in /tomcat/trunk/webapps: docs/config/host.xml docs/deployer-howto.xml docs/html-manager-howto.xml docs/jndi-datasource-examples-howto.xml docs/manager-howto.xml docs/realm-howt

2011-01-18 Thread kkolinko

Author: kkolinko
Date: Tue Jan 18 17:30:24 2011
New Revision: 1060486

URL: http://svn.apache.org/viewvc?rev=1060486&view=rev
Log:
Documentation fixes:
1) role name: s/manager/manager-script/ (BZ 50599),
s/manager-script/admin-script/ on 401/403 pages of host-manager webapp (a typo)
2) there is no property "debug" on the Context, nor on several other classes 
(realms, authenticators)

Modified:
tomcat/trunk/webapps/docs/config/host.xml
tomcat/trunk/webapps/docs/deployer-howto.xml
tomcat/trunk/webapps/docs/html-manager-howto.xml
tomcat/trunk/webapps/docs/jndi-datasource-examples-howto.xml
tomcat/trunk/webapps/docs/manager-howto.xml
tomcat/trunk/webapps/docs/realm-howto.xml
tomcat/trunk/webapps/host-manager/401.jsp
tomcat/trunk/webapps/host-manager/403.jsp

Modified: tomcat/trunk/webapps/docs/config/host.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/host.xml?rev=1060486&r1=1060485&r2=1060486&view=diff
==
--- tomcat/trunk/webapps/docs/config/host.xml (original)
+++ tomcat/trunk/webapps/docs/config/host.xml Tue Jan 18 17:30:24 2011
@@ -554,8 +554,7 @@
 
 
   ...
-  
+  
   ...
 
 

Modified: tomcat/trunk/webapps/docs/deployer-howto.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/deployer-howto.xml?rev=1060486&r1=1060485&r2=1060486&view=diff
==
--- tomcat/trunk/webapps/docs/deployer-howto.xml (original)
+++ tomcat/trunk/webapps/docs/deployer-howto.xml Tue Jan 18 17:30:24 2011
@@ -324,7 +324,7 @@
 
 
 username: Tomcat Manager username (user should 
have a role of
-manager)
+manager-script)
 
 password: Tomcat Manager password.
 

Modified: tomcat/trunk/webapps/docs/html-manager-howto.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/html-manager-howto.xml?rev=1060486&r1=1060485&r2=1060486&view=diff
==
--- tomcat/trunk/webapps/docs/html-manager-howto.xml (original)
+++ tomcat/trunk/webapps/docs/html-manager-howto.xml Tue Jan 18 17:30:24 2011
@@ -387,8 +387,7 @@ web application Context just as if it we
 Tomcat server.xml configuration file. Here is an
 example for Tomcat running on Windows:
 
-
+
 
   
   
+   crossContext="true" reloadable="true">
 
 
+
 
 
 
@@ -164,7 +164,7 @@ could be restricted by the remote IP add
 an example of restricting access to the localhost by IP address:
 
 
+ docBase="/usr/local/kinetic/tomcat7/server/webapps/manager">
  
 
@@ -389,8 +389,7 @@ web application Context just as if it we
 Tomcat server.xml configuration file. Here is an
 example:
 
-

svn commit: r1060489 - in /tomcat/tc6.0.x/trunk/webapps/docs: config/host.xml html-manager-howto.xml jndi-datasource-examples-howto.xml manager-howto.xml realm-howto.xml

2011-01-18 Thread kkolinko

Author: kkolinko
Date: Tue Jan 18 17:41:46 2011
New Revision: 1060489

URL: http://svn.apache.org/viewvc?rev=1060489&view=rev
Log:
Documentation fixes:
there is no property "debug" on the Context, nor on several other classes 
(realms, authenticators)
CTR: docs

Modified:
tomcat/tc6.0.x/trunk/webapps/docs/config/host.xml
tomcat/tc6.0.x/trunk/webapps/docs/html-manager-howto.xml
tomcat/tc6.0.x/trunk/webapps/docs/jndi-datasource-examples-howto.xml
tomcat/tc6.0.x/trunk/webapps/docs/manager-howto.xml
tomcat/tc6.0.x/trunk/webapps/docs/realm-howto.xml

Modified: tomcat/tc6.0.x/trunk/webapps/docs/config/host.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/config/host.xml?rev=1060489&r1=1060488&r2=1060489&view=diff
==
--- tomcat/tc6.0.x/trunk/webapps/docs/config/host.xml (original)
+++ tomcat/tc6.0.x/trunk/webapps/docs/config/host.xml Tue Jan 18 17:41:46 2011
@@ -524,8 +524,7 @@
 
 
   ...
-  
+  
   ...
 
 

Modified: tomcat/tc6.0.x/trunk/webapps/docs/html-manager-howto.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/html-manager-howto.xml?rev=1060489&r1=1060488&r2=1060489&view=diff
==
--- tomcat/tc6.0.x/trunk/webapps/docs/html-manager-howto.xml (original)
+++ tomcat/tc6.0.x/trunk/webapps/docs/html-manager-howto.xml Tue Jan 18 
17:41:46 2011
@@ -387,8 +387,7 @@ web application Context just as if it we
 Tomcat server.xml configuration file. Here is an
 example for Tomcat running on Windows:
 
-
+
 
   
   
+   crossContext="true" reloadable="true">
 
 
 
 
@@ -395,8 +395,7 @@ web application Context just as if it we
 Tomcat server.xml configuration file. Here is an
 example:
 
-
+

svn commit: r1060515 - in /tomcat/tc5.5.x/trunk/container: modules/cluster/etc/ modules/storeconfig-ha/test/conf/ modules/storeconfig/test/conf/ webapps/docs/

2011-01-18 Thread kkolinko

Author: kkolinko
Date: Tue Jan 18 18:26:50 2011
New Revision: 1060515

URL: http://svn.apache.org/viewvc?rev=1060515&view=rev
Log:
Documentation fixes:
there is no property "debug" on the Context, nor on several other classes 
(realms, authenticators)
Updated cluster-server.xml sample file (aligned it with the default server.xml).
CTR: docs and sample configuration files

Modified:
tomcat/tc5.5.x/trunk/container/modules/cluster/etc/cluster-server.xml
tomcat/tc5.5.x/trunk/container/modules/storeconfig-ha/test/conf/server.xml
tomcat/tc5.5.x/trunk/container/modules/storeconfig/test/conf/server.xml
tomcat/tc5.5.x/trunk/container/webapps/docs/html-manager-howto.xml

tomcat/tc5.5.x/trunk/container/webapps/docs/jndi-datasource-examples-howto.xml
tomcat/tc5.5.x/trunk/container/webapps/docs/manager-howto.xml
tomcat/tc5.5.x/trunk/container/webapps/docs/realm-howto.xml

Modified: tomcat/tc5.5.x/trunk/container/modules/cluster/etc/cluster-server.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/container/modules/cluster/etc/cluster-server.xml?rev=1060515&r1=1060514&r2=1060515&view=diff
==
--- tomcat/tc5.5.x/trunk/container/modules/cluster/etc/cluster-server.xml 
(original)
+++ tomcat/tc5.5.x/trunk/container/modules/cluster/etc/cluster-server.xml Tue 
Jan 18 18:26:50 2011
@@ -24,10 +24,10 @@
  listens for a shutdown command on the indicated port.
 
  Note:  A "Server" is not itself a "Container", so you may not
- define subcomponents such as "Valves" or "Loggers" at this level.
+ define subcomponents such as "Valves" at this level.
  -->
 
-
+
 
 
   
@@ -37,10 +37,8 @@
(in the ClassLoader sense) of files to add to the default list.
e.g. descriptors="/com/myfirm/mypackage/mbean-descriptor.xml"
   -->
-  
-  
+  
+  
   
   
   
@@ -73,7 +71,7 @@
but this is not required.
 
Note:  A "Service" is not itself a "Container", so you may not
-   define subcomponents such as "Valves" or "Loggers" at this level.
+   define subcomponents such as "Valves" at this level.
-->
 
   
@@ -89,8 +87,6 @@
  entry.  SSL support requires the following steps (see the SSL Config
  HOWTO in the Tomcat 5 documentation bundle for more detailed
  instructions):
- * If your JDK version 1.3 or prior, download and install JSSE 1.0.2 or
-   later, and put the JAR files into "$JAVA_HOME/jre/lib/ext".
  * Execute:
  %JAVA_HOME%\bin\keytool -genkey -alias tomcat -keyalg RSA 
(Windows)
  $JAVA_HOME/bin/keytool -genkey -alias tomcat -keyalg RSA  (Unix)
@@ -105,40 +101,33 @@
  IP address of the remote client.
 -->
 
-
-
+
+
 
 
 
 
 
 
-
+
 
 
 
 
 
@@ -148,11 +137,11 @@
  on to the appropriate Host (virtual host). -->
 
  
  
 
-
+
 
   
 
-  
-  
-
   
 
   
   
+ resourceName="UserDatabase"/>
 
   
@@ -196,7 +180,7 @@
stored in a database and accessed via JDBC -->
 
   
 
   
 
   
 
   
-  

 
@@ -275,7 +259,6 @@
 
 
   
@@ -337,8 +320,7 @@
  user identity maintained across *all* web applications contained
  in this virtual host. -->
 
 
 
 
-
-
-
 
 

Modified: 
tomcat/tc5.5.x/trunk/container/modules/storeconfig-ha/test/conf/server.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/container/modules/storeconfig-ha/test/conf/server.xml?rev=1060515&r1=1060514&r2=1060515&view=diff
==
--- tomcat/tc5.5.x/trunk/container/modules/storeconfig-ha/test/conf/server.xml 
(original)
+++ tomcat/tc5.5.x/trunk/container/modules/storeconfig-ha/test/conf/server.xml 
Tue Jan 18 18:26:50 2011
@@ -27,7 +27,7 @@
  define subcomponents such as "Valves" or "Loggers" at this level.
  -->
 
-
+
 
 
   
@@ -37,10 +37,8 @@
(in the ClassLoader sense) of files to add to the default list.
e.g. descriptors="/com/myfirm/mypackage/mbean-descriptor.xml"
   -->
-  
-  
+  
+  
 
   
   
@@ -100,7 +98,7 @@
 
 
@@ -118,13 +116,13 @@
 
 -->
 
 
 
 
 
@@ -133,7 +131,7 @@
 
 -->
 
@@ -143,11 +141,11 @@
  on to the appropriate Host (virtual host). -->
 
  
  
 
-
+
 
   
   
+ resourceName="UserDatabase"/>
 
   
@@ -186,7 +184,7 @@
stored in a database and accessed via JDBC -->
 
   
 
   
 
   
-  
 
@@ -351,8 +349,7 @@
  user identity maintained across *all* web applications contained
  in this virtual host. -->
 
 
 
 
-
+
 
 
   
@@ -37,10 +37,8 @@
(in the ClassLoader sense) of files to a

svn commit: r1060524 - in /tomcat: tc6.0.x/trunk/java/org/apache/catalina/ant/jmx/JMXAccessorInvokeTask.java tc6.0.x/trunk/webapps/docs/monitoring.xml trunk/java/org/apache/catalina/ant/jmx/JMXAccesso

2011-01-18 Thread kkolinko

Author: kkolinko
Date: Tue Jan 18 18:38:02 2011
New Revision: 1060524

URL: http://svn.apache.org/viewvc?rev=1060524&view=rev
Log:
Correct a typo in documentation

Modified:

tomcat/tc6.0.x/trunk/java/org/apache/catalina/ant/jmx/JMXAccessorInvokeTask.java
tomcat/tc6.0.x/trunk/webapps/docs/monitoring.xml
tomcat/trunk/java/org/apache/catalina/ant/jmx/JMXAccessorInvokeTask.java
tomcat/trunk/webapps/docs/monitoring.xml

Modified: 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/ant/jmx/JMXAccessorInvokeTask.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/ant/jmx/JMXAccessorInvokeTask.java?rev=1060524&r1=1060523&r2=1060524&view=diff
==
--- 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/ant/jmx/JMXAccessorInvokeTask.java
 (original)
+++ 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/ant/jmx/JMXAccessorInvokeTask.java
 Tue Jan 18 18:38:02 2011
@@ -60,8 +60,8 @@ import org.apache.tools.ant.BuildExcepti
  * 
  *   
  * 
  *   

Modified: tomcat/tc6.0.x/trunk/webapps/docs/monitoring.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/monitoring.xml?rev=1060524&r1=1060523&r2=1060524&view=diff
==
--- tomcat/tc6.0.x/trunk/webapps/docs/monitoring.xml (original)
+++ tomcat/tc6.0.x/trunk/webapps/docs/monitoring.xml Tue Jan 18 18:38:02 2011
@@ -611,13 +611,13 @@ Example to create a new access logger va
 
  
  
  
 
-Now you can find new MBean with name stored at 
${acccesLoggerObjectName}
+Now you can find new MBean with name stored at 
${accessLoggerObjectName}
 property.
   
 

Modified: 
tomcat/trunk/java/org/apache/catalina/ant/jmx/JMXAccessorInvokeTask.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ant/jmx/JMXAccessorInvokeTask.java?rev=1060524&r1=1060523&r2=1060524&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/ant/jmx/JMXAccessorInvokeTask.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/ant/jmx/JMXAccessorInvokeTask.java 
Tue Jan 18 18:38:02 2011
@@ -60,8 +60,8 @@ import org.apache.tools.ant.BuildExcepti
  * 
  *   
  * 
  *   

Modified: tomcat/trunk/webapps/docs/monitoring.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/monitoring.xml?rev=1060524&r1=1060523&r2=1060524&view=diff
==
--- tomcat/trunk/webapps/docs/monitoring.xml (original)
+++ tomcat/trunk/webapps/docs/monitoring.xml Tue Jan 18 18:38:02 2011
@@ -611,13 +611,13 @@ Example to create a new access logger va
 
  
  
  
 
-Now you can find new MBean with name stored at 
${acccesLoggerObjectName}
+Now you can find new MBean with name stored at 
${accessLoggerObjectName}
 property.
   
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Tomcat 7.0.x. still CTR?

2011-01-18 Thread Christopher Schultz

All,

Since Tomcat 7.0.x went stable, does that change the commit policy, or
are we still doing commit-them-review?

Thanks,
-chris



signature.asc
Description: OpenPGP digital signature

svn commit: r1060538 - in /tomcat/trunk: java/org/apache/jasper/ java/org/apache/jasper/resources/ java/org/apache/naming/factory/webservices/ java/org/apache/tomcat/util/buf/ res/findbugs/

2011-01-18 Thread markt

Author: markt
Date: Tue Jan 18 18:57:45 2011
New Revision: 1060538

URL: http://svn.apache.org/viewvc?rev=1060538&view=rev
Log:
Fix the last of the high priority FindBugs warnings

Modified:
tomcat/trunk/java/org/apache/jasper/JspC.java
tomcat/trunk/java/org/apache/jasper/resources/LocalStrings.properties
tomcat/trunk/java/org/apache/naming/factory/webservices/ServiceProxy.java
tomcat/trunk/java/org/apache/tomcat/util/buf/StringCache.java
tomcat/trunk/res/findbugs/filter-false-positives.xml

Modified: tomcat/trunk/java/org/apache/jasper/JspC.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/JspC.java?rev=1060538&r1=1060537&r2=1060538&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/JspC.java (original)
+++ tomcat/trunk/java/org/apache/jasper/JspC.java Tue Jan 18 18:57:45 2011
@@ -151,7 +151,6 @@ public class JspC implements Options {
 insertBefore.add("");
 }
 
-protected static int die;
 protected String classPath = null;
 protected URLClassLoader loader = null;
 protected boolean trimSpaces = false;
@@ -251,8 +250,9 @@ public class JspC implements Options {
 if (arg.length == 0) {
 System.out.println(Localizer.getMessage("jspc.usage"));
 } else {
+JspC jspc = null;
 try {
-JspC jspc = new JspC();
+jspc = new JspC();
 jspc.setArgs(arg);
 if (jspc.helpNeeded) {
 System.out.println(Localizer.getMessage("jspc.usage"));
@@ -261,8 +261,8 @@ public class JspC implements Options {
 }
 } catch (JasperException je) {
 System.err.println(je);
-if (die != NO_DIE_LEVEL) {
-System.exit(die);
+if (jspc != null && jspc.dieLevel != NO_DIE_LEVEL) {
+System.exit(jspc.dieLevel);
 }
 }
 }
@@ -279,7 +279,6 @@ public class JspC implements Options {
 String tok;
 
 dieLevel = NO_DIE_LEVEL;
-die = dieLevel;
 
 while ((tok = nextArg()) != null) {
 if (tok.equals(SWITCH_VERBOSE)) {
@@ -341,7 +340,6 @@ public class JspC implements Options {
 } catch (NumberFormatException nfe) {
 dieLevel = DEFAULT_DIE_LEVEL;
 }
-die = dieLevel;
 } else if (tok.equals(SWITCH_HELP)) {
 helpNeeded = true;
 } else if (tok.equals(SWITCH_POOLING)) {
@@ -804,8 +802,8 @@ public class JspC implements Options {
  * includes.
  */
 public void setUriroot( String s ) {
-if( s==null ) {
-uriRoot = s;
+if (s == null) {
+uriRoot = null;
 return;
 }
 try {
@@ -1097,8 +1095,12 @@ public class JspC implements Options {
 fis.close();
 fos.close();
 
-webXml2.delete();
-(new File(webxmlFile)).delete();
+if(!webXml2.delete() && log.isDebugEnabled())
+log.debug(Localizer.getMessage("jspc.delete.fail",
+webXml2.toString()));
+
+if (!(new File(webxmlFile)).delete() && log.isDebugEnabled())
+log.debug(Localizer.getMessage("jspc.delete.fail", webxmlFile));
 
 }
 

Modified: tomcat/trunk/java/org/apache/jasper/resources/LocalStrings.properties
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/resources/LocalStrings.properties?rev=1060538&r1=1060537&r2=1060538&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/resources/LocalStrings.properties 
(original)
+++ tomcat/trunk/java/org/apache/jasper/resources/LocalStrings.properties Tue 
Jan 18 18:57:45 2011
@@ -296,6 +296,7 @@ jspc.error.jasperException=error-the fil
 jspc.error.generalException=ERROR-the file ''{0}'' generated the following 
general exception:
 jspc.error.fileDoesNotExist=The file argument ''{0}'' does not exist
 jspc.error.emptyWebApp=-webapp requires a trailing file argument
+jspc.delete.fail=Failed to delete file [{0}]
 jsp.error.library.invalid=JSP page is invalid according to library {0}: {1}
 jsp.error.tlvclass.instantiation=Failed to load or instantiate 
TagLibraryValidator class: {0}
 jsp.error.tlv.invalid.page=Validation error messages from TagLibraryValidator 
for {0} in {1}

Modified: 
tomcat/trunk/java/org/apache/naming/factory/webservices/ServiceProxy.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/naming/factory/webservices/ServiceProxy.java?rev=1060538&r1=1060537&r2=1060538&view=diff
==
--- tomcat/trunk/java/org/apache/naming/factory/webservices/ServiceProxy.java 
(original)
+++ tomcat/trunk/java/org/apache/naming/factory/webservices/Ser

Re: Tomcat 7.0.x. still CTR?

2011-01-18 Thread Mark Thomas

On 18/01/2011 18:41, Christopher Schultz wrote:
> All,
> 
> Since Tomcat 7.0.x went stable, does that change the commit policy, or
> are we still doing commit-them-review?

The plan was to switch to R-T-C and to create /tc7.0.x/trunk from the
first stable tag.

I'm leaning towards seeing how things go with 7.0.6 and if they go well
switch to R-T-C from the 7.0.7 tag.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Tomcat 7.0.x. still CTR?

2011-01-18 Thread Tim Funk

My preference is to remain CTR on the idea the anything of significance 
be proposed so there would be consensus to push it into 7.0 or branch to 7.X


-Tim


On 1/18/2011 1:41 PM, Christopher Schultz wrote:

All,

Since Tomcat 7.0.x went stable, does that change the commit policy, or
are we still doing commit-them-review?


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Improving CGIServlet - path and args to the executable

2011-01-18 Thread sebb

On 18 January 2011 16:19, Konstantin Kolinko  wrote:
> Hi!
>
> In 6.0.30 to fix BZ 49657 we changed the way how cgi command is built
> in CGI Servlet:
> http://svn.apache.org/viewvc?view=revision&revision=1004424
>
> Earlier implementation used to build the command as a single string,
> wrapping parts of it in double quotes. The new implementation uses
> Runtime.exec(String[]) and passes all arguments separate from each
> other as an array.
>
> This causes regression for people using empty value for "executable"
> init-param, as reported in
> https://issues.apache.org/bugzilla/show_bug.cgi?id=50606
>
> I closed BZ 50606 as INVALID but now I am changing my mind. Looking around
>
> 1) there are sites that recommend using an empty string for "executable"
> http://stackoverflow.com/questions/499456/cgi-and-tomcat/500527#500527
>
> Apparently it is to run programs that themselves are executables, as
> *.exe on Windows.

The empty string is assumed to be "perl", according to:

http://tomcat.apache.org/tomcat-6.0-doc/cgi-howto.html#Configuration
and
http://tomcat.apache.org/tomcat-7.0-doc/cgi-howto.html#Configuration

which says:

"executable - The of the executable to be used to run the script.
Default is perl." (sic)

BTW: s/The of/The name of/

> 2) some put in arguments for the executable, as "cmd /q /c"
> http://webcache.googleusercontent.com/search?q=cache:njmdNKdXzNMJ:www.tek-tips.com/faqs.cfm%3Ffid%3D6467
> (Should be http://www.tek-tips.com/faqs.cfm?fid=6467 but the original
> site is inaccessible now).
>
> I do not like to revert r1004424 and bother with quotes, nor I want to
> parse "executable" into separate strings.
> So I think of the following:
> 1. Allow empty value of "executable" init-param

See above.

> 2. Introduce additional init-params to explicitly specify additional 
> arguments:
> "executable-arg-1"
> "executable-arg-2"
> etc. starting with "1"
>
> So cmd /q /c will be written as
>
> 
>  executable
>  cmd.exe
> 
> 
>  executable-arg-1
>  /q
> 
> 
>  executable-arg-2
>  /c
> 
>
> What do you think?

Ant has a nicer format:







This would be tricky to fit into the existing scheme, but something
similar could perhaps be added as an alternative to the current
scheme?

I.e. leave the existing scheme (and don't bother trying to deal with
quotes), and add the new scheme for handling parameters properly.

> Best regards,
> Konstantin Kolinko
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Improving CGIServlet - path and args to the executable

2011-01-18 Thread Konstantin Kolinko

2011/1/18 sebb :
>
> The empty string is assumed to be "perl", according to:
>

No. Absence of this init-param is what will be "perl".

Setting it explicitly overwrites the default.

if (getServletConfig().getInitParameter("executable") != null) {
cgiExecutable = getServletConfig().getInitParameter("executable");
}

>> So cmd /q /c will be written as
>>
>> 
>>  executable
>>  cmd.exe
>> 
>> 
>>  executable-arg-1
>>  /q
>> 
>> 
>>  executable-arg-2
>>  /c
>> 
>>
>> What do you think?
>
> Ant has a nicer format:
>
> 
>    
>    
>    
> 

That above was a part of web.xml.  Maybe you mean "arg-1", "arg-2" etc
(instead of "executable-arg-1")?


Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1060555 - in /tomcat: tc5.5.x/trunk/container/webapps/docs/windows-service-howto.xml tc6.0.x/trunk/webapps/docs/windows-service-howto.xml

2011-01-18 Thread kkolinko

Author: kkolinko
Date: Tue Jan 18 20:15:59 2011
New Revision: 1060555

URL: http://svn.apache.org/viewvc?rev=1060555&view=rev
Log:
Correct a typo in documentation

Modified:
tomcat/tc5.5.x/trunk/container/webapps/docs/windows-service-howto.xml
tomcat/tc6.0.x/trunk/webapps/docs/windows-service-howto.xml

Modified: tomcat/tc5.5.x/trunk/container/webapps/docs/windows-service-howto.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/container/webapps/docs/windows-service-howto.xml?rev=1060555&r1=1060554&r2=1060555&view=diff
==
--- tomcat/tc5.5.x/trunk/container/webapps/docs/windows-service-howto.xml 
(original)
+++ tomcat/tc5.5.x/trunk/container/webapps/docs/windows-service-howto.xml Tue 
Jan 18 20:15:59 2011
@@ -163,7 +163,7 @@
 
 --JavaHome
 JAVA_HOME
-Set a different JAVA_HOME then defined by JAVA_HOME environment
+Set a different JAVA_HOME than defined by JAVA_HOME environment
 variable
 
 

Modified: tomcat/tc6.0.x/trunk/webapps/docs/windows-service-howto.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/windows-service-howto.xml?rev=1060555&r1=1060554&r2=1060555&view=diff
==
--- tomcat/tc6.0.x/trunk/webapps/docs/windows-service-howto.xml (original)
+++ tomcat/tc6.0.x/trunk/webapps/docs/windows-service-howto.xml Tue Jan 18 
20:15:59 2011
@@ -167,7 +167,7 @@
 
 --JavaHome
 JAVA_HOME
-Set a different JAVA_HOME then defined by JAVA_HOME environment
+Set a different JAVA_HOME than defined by JAVA_HOME environment
 variable
 
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1060560 - in /tomcat/tc5.5.x/trunk: ./ container/webapps/admin/ container/webapps/docs/ container/webapps/host-manager/ container/webapps/manager/

2011-01-18 Thread kkolinko

Author: kkolinko
Date: Tue Jan 18 20:26:56 2011
New Revision: 1060560

URL: http://svn.apache.org/viewvc?rev=1060560&view=rev
Log:
Configure manager, host-manager and admin webapps to use HttpOnly for session 
cookies

Modified:
tomcat/tc5.5.x/trunk/STATUS.txt
tomcat/tc5.5.x/trunk/container/webapps/admin/admin.xml
tomcat/tc5.5.x/trunk/container/webapps/docs/changelog.xml
tomcat/tc5.5.x/trunk/container/webapps/host-manager/host-manager.xml
tomcat/tc5.5.x/trunk/container/webapps/host-manager/manager.xml
tomcat/tc5.5.x/trunk/container/webapps/manager/manager.xml

Modified: tomcat/tc5.5.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=1060560&r1=1060559&r2=1060560&view=diff
==
--- tomcat/tc5.5.x/trunk/STATUS.txt (original)
+++ tomcat/tc5.5.x/trunk/STATUS.txt Tue Jan 18 20:26:56 2011
@@ -71,11 +71,6 @@ PATCHES PROPOSED TO BACKPORT:
patched tomcat.nsi of tc5.5 on top of it:
(  
http://people.apache.org/~kkolinko/patches/2011-01-17_tc55_tomcat-nsi-of-tc7_vs_tc55.diff
 )
 
-* Configure manager, host-manager and admin webapps to use HttpOnly for 
session cookies
-  http://people.apache.org/~kkolinko/patches/2010-11-22_tc55_httpOnly.patch
-  +1: kkolinko, rjung, markt
-  -1:
-
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50460
   Avoid leak caused by using a cached exception instance
   http://svn.apache.org/viewvc?rev=1044987&view=rev

Modified: tomcat/tc5.5.x/trunk/container/webapps/admin/admin.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/container/webapps/admin/admin.xml?rev=1060560&r1=1060559&r2=1060560&view=diff
==
--- tomcat/tc5.5.x/trunk/container/webapps/admin/admin.xml (original)
+++ tomcat/tc5.5.x/trunk/container/webapps/admin/admin.xml Tue Jan 18 20:26:56 
2011
@@ -25,7 +25,7 @@
 
 
 
+ antiResourceLocking="false" antiJARLocking="false" useHttpOnly="true">

Re: Improving CGIServlet - path and args to the executable

2011-01-18 Thread sebb

On 18 January 2011 19:48, Konstantin Kolinko  wrote:
> 2011/1/18 sebb :
>>
>> The empty string is assumed to be "perl", according to:
>>
>
> No. Absence of this init-param is what will be "perl".
>
> Setting it explicitly overwrites the default.
>
>        if (getServletConfig().getInitParameter("executable") != null) {
>            cgiExecutable = getServletConfig().getInitParameter("executable");
>        }

I see, perhaps the docs could make this more obvious?

>>> So cmd /q /c will be written as
>>>
>>> 
>>>  executable
>>>  cmd.exe
>>> 
>>> 
>>>  executable-arg-1
>>>  /q
>>> 
>>> 
>>>  executable-arg-2
>>>  /c
>>> 
>>>
>>> What do you think?
>>
>> Ant has a nicer format:
>>
>> 
>>    
>>    
>>    
>> 
>
> That above was a part of web.xml.  Maybe you mean "arg-1", "arg-2" etc
> (instead of "executable-arg-1")?

No, I meant that the Ant format is much easier to use, and could
perhaps be added to web.xml.

Instead of


 executable
 cmd.exe


 executable-arg-1
 /q


 executable-arg-2
 /c


you would allow:


   
   


which is very much simpler

Or perhaps extend param to allow multiple values:


 executable
 cmd.exe
 /q
 /c


But maybe they would both be too hard to add to the current XML syntax.

And both assume that ordering is preserved when parsing multiple tags
with the same name.

>
> Best regards,
> Konstantin Kolinko
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Improving CGIServlet - path and args to the executable

2011-01-18 Thread Mark Thomas

On 18/01/2011 16:19, Konstantin Kolinko wrote:
> So I think of the following:
> 1. Allow empty value of "executable" init-param

+1. We can just drop that element from the String[]

> 2. Introduce additional init-params to explicitly specify additional 
> arguments:
> "executable-arg-1"
> "executable-arg-2"
> etc. starting with "1"

+1. I assume you'd do this in a loop looking for executable-arg-N
starting with N=1 and incrementing until the parameter didn't exist.

> What do you think?

Go for it.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1060586 - in /tomcat/trunk: java/org/apache/catalina/core/ java/org/apache/catalina/loader/ java/org/apache/catalina/realm/ java/org/apache/catalina/ssi/ java/org/apache/jasper/runtime/ j

2011-01-18 Thread markt

Author: markt
Date: Tue Jan 18 21:33:14 2011
New Revision: 1060586

URL: http://svn.apache.org/viewvc?rev=1060586&view=rev
Log:
Fix Findbugs and Eclipse warnings

Modified:
tomcat/trunk/java/org/apache/catalina/core/ApplicationDispatcher.java
tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java
tomcat/trunk/java/org/apache/catalina/realm/LockOutRealm.java
tomcat/trunk/java/org/apache/catalina/ssi/SSIServletExternalResolver.java
tomcat/trunk/java/org/apache/jasper/runtime/JspFactoryImpl.java
tomcat/trunk/java/org/apache/juli/ClassLoaderLogManager.java
tomcat/trunk/java/org/apache/naming/resources/FileDirContext.java
tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java

tomcat/trunk/java/org/apache/tomcat/util/threads/DedicatedThreadExecutor.java
tomcat/trunk/test/org/apache/catalina/connector/TestMaxConnections.java

Modified: tomcat/trunk/java/org/apache/catalina/core/ApplicationDispatcher.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/ApplicationDispatcher.java?rev=1060586&r1=1060585&r2=1060586&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/ApplicationDispatcher.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/core/ApplicationDispatcher.java Tue 
Jan 18 21:33:14 2011
@@ -130,7 +130,7 @@ final class ApplicationDispatcher
  * variables causes threading issues and state is too complex to pass and
  * return single ServletRequest or ServletResponse objects.
  */
-private class State {
+private static class State {
 State(ServletRequest request, ServletResponse response,
 boolean including) {
 this.outerRequest = request;

Modified: tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java?rev=1060586&r1=1060585&r2=1060586&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java Tue Jan 
18 21:33:14 2011
@@ -156,7 +156,7 @@ public class WebappClassLoader
 }
 
 
-protected final class PrivilegedGetClassLoader
+protected static final class PrivilegedGetClassLoader
 implements PrivilegedAction {
 
 public Class clazz;

Modified: tomcat/trunk/java/org/apache/catalina/realm/LockOutRealm.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/realm/LockOutRealm.java?rev=1060586&r1=1060585&r2=1060586&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/realm/LockOutRealm.java (original)
+++ tomcat/trunk/java/org/apache/catalina/realm/LockOutRealm.java Tue Jan 18 
21:33:14 2011
@@ -379,7 +379,7 @@ public class LockOutRealm extends Combin
 }
 
 
-protected class LockRecord {
+protected static class LockRecord {
 private AtomicInteger failures = new AtomicInteger(0);
 private long lastFailureTime = 0;
 

Modified: 
tomcat/trunk/java/org/apache/catalina/ssi/SSIServletExternalResolver.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ssi/SSIServletExternalResolver.java?rev=1060586&r1=1060585&r2=1060586&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/ssi/SSIServletExternalResolver.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/ssi/SSIServletExternalResolver.java 
Tue Jan 18 21:33:14 2011
@@ -74,6 +74,7 @@ public class SSIServletExternalResolver 
 }
 
 
+@Override
 public void log(String message, Throwable throwable) {
 //We can't assume that Servlet.log( message, null )
 //is the same as Servlet.log( message ), since API
@@ -86,6 +87,7 @@ public class SSIServletExternalResolver 
 }
 
 
+@Override
 public void addVariableNames(Collection variableNames) {
 for (int i = 0; i < VARIABLE_NAMES.length; i++) {
 String variableName = VARIABLE_NAMES[i];
@@ -132,6 +134,7 @@ public class SSIServletExternalResolver 
 }
 
 
+@Override
 public void setVariableValue(String name, String value) {
 if (!isNameReserved(name)) {
 req.setAttribute(name, value);
@@ -139,6 +142,7 @@ public class SSIServletExternalResolver 
 }
 
 
+@Override
 public String getVariableValue(String name) {
 String retVal = null;
 Object object = getReqAttributeIgnoreCase(name);
@@ -331,6 +335,7 @@ public class SSIServletExternalResolver 
 return retVal;
 }
 
+@Override
 public Date getCurrentDate() {
 return new Date();
 }
@@ -480,6 +485,7 @@ public class SSIServletExternal

DO NOT REPLY [Bug 50613] New: ConnectionPool.size corruption when evictions enabled:

2011-01-18 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=50613

   Summary: ConnectionPool.size corruption when evictions enabled:
   Product: Tomcat Modules
   Version: unspecified
  Platform: PC
Status: NEW
  Severity: major
  Priority: P2
 Component: jdbc-pool
AssignedTo: dev@tomcat.apache.org
ReportedBy: jnorri...@gmail.com


When (the various forms of) eviction run on the connection pool,
ConnectionPool.size goes negative.  This appears to be a concurrency problem.

Attached is a unit test that illustrates the issue.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Tomcat Wiki] Update of "PoweredBy" by prosch

2011-01-18 Thread Apache Wiki

Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change 
notification.

The "PoweredBy" page has been changed by prosch.
http://wiki.apache.org/tomcat/PoweredBy?action=diff&rev1=292&rev2=293

--

  
  This page is organized by categories: [[#pub|sites with publications]], 
[[#user|sites added by users]], [[#surveys|independent surveys]], and 
[[#more|more]].  Anyone can and is encouraged to add to this page: please add 
your site, application, or system as you see fit.  You do need to register with 
the Apache wiki system to edit this page: simply click the login or user 
preferences links at the top right of your screen to do so.  Don't worry if you 
don't think it fits here or into any particular category: we would like to see 
your application listed no matter how big, how small, or how miscategorized ;)  
Some of these applications are simply compatible with, ship with, or run on 
Tomcat.  Others are specifically designed or documented with Tomcat as the 
container in mind.
  
- Please note that all the corporate logos and names used below are trademarked 
by their respective organizations.  These organizations are not affiliated with 
this web site or with The Apache Software Foundation, and make no claims 
regarding The Foundation or its products.  Further, in most cases the companies 
are not aware of their being listed on this site at all.
+ Please note that all the corporate logos and names used below are trademarked 
by their respective organizations.  These organizations are not affiliated with 
this web site or with The Apache Software Foundation, and make no claims 
regarding The Foundation or its products.  Further, in most cases the companies 
are not aware of their being listed on this site at all. "* 
[http://www.profischnell.com Spanisch Deutsch 
Übersetzung][http://www.profi-fachuebersetzung.de/uebersetzung/uebersetzung-deutsch-niederlaendisch.html
 Niederländisch Deutsch 
Übersetzung][http://www.uebersetzung-deutsch-englisch.com Übersetzung Deutsch 
Englisch][http://www.xn--bersetzungsbro-frankfurt-uscm.de Übersetzungsagentur 
Frankfurt]
+ 
  
  <>
  

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Tomcat Wiki] Update of "PoweredBy" by prosch

2011-01-18 Thread Apache Wiki

Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change 
notification.

The "PoweredBy" page has been changed by prosch.
http://wiki.apache.org/tomcat/PoweredBy?action=diff&rev1=293&rev2=294

--

  
  This page is organized by categories: [[#pub|sites with publications]], 
[[#user|sites added by users]], [[#surveys|independent surveys]], and 
[[#more|more]].  Anyone can and is encouraged to add to this page: please add 
your site, application, or system as you see fit.  You do need to register with 
the Apache wiki system to edit this page: simply click the login or user 
preferences links at the top right of your screen to do so.  Don't worry if you 
don't think it fits here or into any particular category: we would like to see 
your application listed no matter how big, how small, or how miscategorized ;)  
Some of these applications are simply compatible with, ship with, or run on 
Tomcat.  Others are specifically designed or documented with Tomcat as the 
container in mind.
  
- Please note that all the corporate logos and names used below are trademarked 
by their respective organizations.  These organizations are not affiliated with 
this web site or with The Apache Software Foundation, and make no claims 
regarding The Foundation or its products.  Further, in most cases the companies 
are not aware of their being listed on this site at all. "* 
[http://www.profischnell.com Spanisch Deutsch 
Übersetzung][http://www.profi-fachuebersetzung.de/uebersetzung/uebersetzung-deutsch-niederlaendisch.html
 Niederländisch Deutsch 
Übersetzung][http://www.uebersetzung-deutsch-englisch.com Übersetzung Deutsch 
Englisch][http://www.xn--bersetzungsbro-frankfurt-uscm.de Übersetzungsagentur 
Frankfurt]
+ Please note that all the corporate logos and names used below are trademarked 
by their respective organizations.  These organizations are not affiliated with 
this web site or with The Apache Software Foundation, and make no claims 
regarding The Foundation or its products.  Further, in most cases the companies 
are not aware of their being listed on this site at all. "* 
[http://www.profischnell.com|Spanisch Deutsch 
Übersetzung][http://www.profi-fachuebersetzung.de/uebersetzung/uebersetzung-deutsch-niederlaendisch.html|Niederländisch
 Deutsch Übersetzung][http://www.uebersetzung-deutsch-englisch.com|Übersetzung 
Deutsch 
Englisch][http://www.xn--bersetzungsbro-frankfurt-uscm.de|Übersetzungsagentur 
Frankfurt]
  
  
  <>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Tomcat Wiki] Update of "PoweredBy" by prosch

2011-01-18 Thread Apache Wiki

Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change 
notification.

The "PoweredBy" page has been changed by prosch.
http://wiki.apache.org/tomcat/PoweredBy?action=diff&rev1=294&rev2=295

--

  
  This page is organized by categories: [[#pub|sites with publications]], 
[[#user|sites added by users]], [[#surveys|independent surveys]], and 
[[#more|more]].  Anyone can and is encouraged to add to this page: please add 
your site, application, or system as you see fit.  You do need to register with 
the Apache wiki system to edit this page: simply click the login or user 
preferences links at the top right of your screen to do so.  Don't worry if you 
don't think it fits here or into any particular category: we would like to see 
your application listed no matter how big, how small, or how miscategorized ;)  
Some of these applications are simply compatible with, ship with, or run on 
Tomcat.  Others are specifically designed or documented with Tomcat as the 
container in mind.
  
- Please note that all the corporate logos and names used below are trademarked 
by their respective organizations.  These organizations are not affiliated with 
this web site or with The Apache Software Foundation, and make no claims 
regarding The Foundation or its products.  Further, in most cases the companies 
are not aware of their being listed on this site at all. "* 
[http://www.profischnell.com|Spanisch Deutsch 
Übersetzung][http://www.profi-fachuebersetzung.de/uebersetzung/uebersetzung-deutsch-niederlaendisch.html|Niederländisch
 Deutsch Übersetzung][http://www.uebersetzung-deutsch-englisch.com|Übersetzung 
Deutsch 
Englisch][http://www.xn--bersetzungsbro-frankfurt-uscm.de|Übersetzungsagentur 
Frankfurt]
+ Please note that all the corporate logos and names used below are trademarked 
by their respective organizations.  These organizations are not affiliated with 
this web site or with The Apache Software Foundation, and make no claims 
regarding The Foundation or its products.  Further, in most cases the companies 
are not aware of their being listed on this site at all. "* 
[[http://www.profischnell.com|Spanisch Deutsch 
Übersetzung]][[http://www.profi-fachuebersetzung.de/uebersetzung/uebersetzung-deutsch-niederlaendisch.html|Niederländisch
 Deutsch Übersetzung]] 
[[http://www.uebersetzung-deutsch-englisch.com|Übersetzung Deutsch 
Englisch]][[http://www.xn--bersetzungsbro-frankfurt-uscm.de|Übersetzungsagentur 
Frankfurt]]
  
  
  <>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

PoweredBy reverted to revision 292 on Tomcat Wiki

2011-01-18 Thread Apache Wiki

Dear wiki user,

You have subscribed to a wiki page "Tomcat Wiki" for change notification.

The page PoweredBy has been reverted to revision 292 by ChuckCaldarale.
The comment on this change is: Spam removal..
http://wiki.apache.org/tomcat/PoweredBy?action=diff&rev1=295&rev2=296

--

  
  This page is organized by categories: [[#pub|sites with publications]], 
[[#user|sites added by users]], [[#surveys|independent surveys]], and 
[[#more|more]].  Anyone can and is encouraged to add to this page: please add 
your site, application, or system as you see fit.  You do need to register with 
the Apache wiki system to edit this page: simply click the login or user 
preferences links at the top right of your screen to do so.  Don't worry if you 
don't think it fits here or into any particular category: we would like to see 
your application listed no matter how big, how small, or how miscategorized ;)  
Some of these applications are simply compatible with, ship with, or run on 
Tomcat.  Others are specifically designed or documented with Tomcat as the 
container in mind.
  
+ Please note that all the corporate logos and names used below are trademarked 
by their respective organizations.  These organizations are not affiliated with 
this web site or with The Apache Software Foundation, and make no claims 
regarding The Foundation or its products.  Further, in most cases the companies 
are not aware of their being listed on this site at all.
- Please note that all the corporate logos and names used below are trademarked 
by their respective organizations.  These organizations are not affiliated with 
this web site or with The Apache Software Foundation, and make no claims 
regarding The Foundation or its products.  Further, in most cases the companies 
are not aware of their being listed on this site at all. "* 
[[http://www.profischnell.com|Spanisch Deutsch 
Übersetzung]][[http://www.profi-fachuebersetzung.de/uebersetzung/uebersetzung-deutsch-niederlaendisch.html|Niederländisch
 Deutsch Übersetzung]] 
[[http://www.uebersetzung-deutsch-englisch.com|Übersetzung Deutsch 
Englisch]][[http://www.xn--bersetzungsbro-frankfurt-uscm.de|Übersetzungsagentur 
Frankfurt]]
- 
  
  <>
  

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 21283] [PATCH] check for null inputstream before parsing xml in ParseUtils.parseXmlDocument

2011-01-18 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=21283

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #2 from Mark Thomas  2011-01-18 18:43:19 EST ---
This is fixed in newer versions of Tomcat (I was testing 7.0.x). A better
exception is thrown as well as reporting the file the triggered the error.

If there is a scenario where a useful error message isn't reported, please
re-open this issue provide the steps to reproduce (or a test case) and someone
will take a look.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1060627 - in /tomcat/trunk/webapps: docs/changelog.xml host-manager/META-INF/context.xml manager/META-INF/context.xml

2011-01-18 Thread markt

Author: markt
Date: Wed Jan 19 00:00:59 2011
New Revision: 1060627

URL: http://svn.apache.org/viewvc?rev=1060627&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=22278
Add a commented out RemoteAddrValve that limits access to the Manager and Host 
Manager applications to localhost.
Based on a patch by Yann Cébron.

Modified:
tomcat/trunk/webapps/docs/changelog.xml
tomcat/trunk/webapps/host-manager/META-INF/context.xml
tomcat/trunk/webapps/manager/META-INF/context.xml

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1060627&r1=1060626&r2=1060627&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Wed Jan 19 00:00:59 2011
@@ -111,6 +111,11 @@
   
 
   
+22278: Add a commented out RemoteAddrValve that
+limits access to the Manager and Host Manager applications to 
localhost.
+Based on a patch by Yann CÃ©bron. (markt)
+  
+  
 Correct a handful of Javadoc warnings. (markt)
   
   

Modified: tomcat/trunk/webapps/host-manager/META-INF/context.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/host-manager/META-INF/context.xml?rev=1060627&r1=1060626&r2=1060627&view=diff
==
--- tomcat/trunk/webapps/host-manager/META-INF/context.xml (original)
+++ tomcat/trunk/webapps/host-manager/META-INF/context.xml Wed Jan 19 00:00:59 
2011
@@ -15,4 +15,13 @@
   See the License for the specific language governing permissions and
   limitations under the License.
 -->
-
+
+  
+  
+
\ No newline at end of file

Modified: tomcat/trunk/webapps/manager/META-INF/context.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/manager/META-INF/context.xml?rev=1060627&r1=1060626&r2=1060627&view=diff
==
--- tomcat/trunk/webapps/manager/META-INF/context.xml (original)
+++ tomcat/trunk/webapps/manager/META-INF/context.xml Wed Jan 19 00:00:59 2011
@@ -15,4 +15,13 @@
   See the License for the specific language governing permissions and
   limitations under the License.
 -->
-
+
+  
+  
+



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 22278] [PATCH] Include RemoteAddrValve in manager.xml

2011-01-18 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=22278

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #2 from Mark Thomas  2011-01-18 19:01:52 EST ---
Fixed in 7.0.x and will be included in 7.0.7 onwards.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1060627 - in /tomcat/trunk/webapps: docs/changelog.xml host-manager/META-INF/context.xml manager/META-INF/context.xml

2011-01-18 Thread Mark Thomas

On 19/01/2011 00:00, ma...@apache.org wrote:
> Author: markt
> Date: Wed Jan 19 00:00:59 2011
> New Revision: 1060627
> 
> URL: http://svn.apache.org/viewvc?rev=1060627&view=rev
> Log:
> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=22278
> Add a commented out RemoteAddrValve that limits access to the Manager and 
> Host Manager applications to localhost.
> Based on a patch by Yann Cébron.

I thought about extending this and enabling the Valve by default along
with adding additional information to the 403 error page.

Whilst I like to from a security point of view, I do wonder how much
stuff it would break for users and how much traffic it would generate on
the users list.

Thoughts?

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 22113] Improvable Exception Message "Cannot create resource instance"

2011-01-18 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=22113

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #1 from Mark Thomas  2011-01-18 19:14:56 EST ---
This is fixed in all current Tomcat versions.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1060643 - /tomcat/trunk/webapps/docs/security-howto.xml

2011-01-18 Thread markt

Author: markt
Date: Wed Jan 19 01:01:42 2011
New Revision: 1060643

URL: http://svn.apache.org/viewvc?rev=1060643&view=rev
Log:
Expand the non-Tomcat settings section

Modified:
tomcat/trunk/webapps/docs/security-howto.xml

Modified: tomcat/trunk/webapps/docs/security-howto.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/security-howto.xml?rev=1060643&r1=1060642&r2=1060643&view=diff
==
--- tomcat/trunk/webapps/docs/security-howto.xml (original)
+++ tomcat/trunk/webapps/docs/security-howto.xml Wed Jan 19 01:01:42 2011
@@ -50,11 +50,25 @@
   
 Tomcat configuration should not be the only line of defense. The other
 components in the system (operating system, network, database, etc.) should
-also be secured. For the operating system, consider limiting the privileges
-of the user under which Tomcat is running and limiting access to Tomcat's
-files by other users. At the network level, consider using a firewall to
-limit both incoming and outgoing connections to only those connections you 
-expect to be present.
+also be secured.
+Tomcat should not be run under the root user. Create a dedicated user 
for
+the Tomcat process and provide that user with the minimum necessary
+permissions for the operating system. For example, it should not be 
possible
+to log on remotely using the Tomcat user.
+File permissions should also be suitable restricted. Taking the Tomcat
+instances at the ASF as an example (where auto-deployment is disabled and
+web applications are deployed as exploded directories), the standard
+configuration is to have all Tomcat files owned by root with group Tomcat
+and whilst owner has read/write priviliges, group only has read and world
+has no permissions. The exceptions are the logs, temp and work directory
+that are owned by the Tomcat user rather than root. This means that even if
+an attacker compromises the Tomcat process, they can't change the
+Tomcat configuration, deploy new web applications or modify existing web
+applications. The Tomcat process runs with a umask of 007 to maintain these
+permissions.
+At the network level, consider using a firewall to limit both incoming
+and outgoing connections to only those connections you  expect to be
+present.
   
   
   
@@ -210,14 +224,15 @@
 
 
 
-  It is strongly recommended that an AccessLogValve is configured. These
-  are normally configured per host but may also be configured per engine or
-  per context as required.
+  It is strongly recommended that an AccessLogValve is configured. The
+  default Tomcat configuration includes an AccessLogValve. These are
+  normally configured per host but may also be configured per engine or per
+  context as required.
   
   Any administrative application should be protected by a
   RemoteAddressValve. (Note that this Valve is also available as a Filter.)
-  The allow attribute should be used to limit access to a 
set of known
-  trusted hosts.
+  The allow attribute should be used to limit access to a
+  set of known trusted hosts.
   
   The default ErrorReportValve includes the Tomcat version number in the
   response sent to clients. To avoid this, custom error handling can be



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 22405] warn if not deploy with umask "0077" or if deployed as "root" and provide tutorial URL "Secure deployment"

2011-01-18 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=22405

--- Comment #4 from Mark Thomas  2011-01-18 20:07:00 EST ---
The Tomcat 7 docs include a section on security considerations. I have expanded
the OS section for 7.0.7 to cover file permissions, umask etc.

I am still thinking about if/how to implement the user, umask etc. checks.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1060627 - in /tomcat/trunk/webapps: docs/changelog.xml host-manager/META-INF/context.xml manager/META-INF/context.xml

2011-01-18 Thread Tim Funk

+1 - It might be nice to match 127.0.0.[0-9]{1,3} so it is more virtual 
machine friendly for those who map localhost to an alternate loopback 
address.


-Tim

On 1/18/2011 7:04 PM, Mark Thomas wrote:

On 19/01/2011 00:00, ma...@apache.org wrote:

Author: markt
Date: Wed Jan 19 00:00:59 2011
New Revision: 1060627

URL: http://svn.apache.org/viewvc?rev=1060627&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=22278
Add a commented out RemoteAddrValve that limits access to the Manager and Host 
Manager applications to localhost.
Based on a patch by Yann Cébron.


I thought about extending this and enabling the Valve by default along
with adding additional information to the 403 error page.

Whilst I like to from a security point of view, I do wonder how much
stuff it would break for users and how much traffic it would generate on
the users list.


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 50613] ConnectionPool.size corruption when evictions enabled:

2011-01-18 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=50613

Sebb  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO
 OS/Version||All

--- Comment #1 from Sebb  2011-01-18 21:30:58 EST ---
There's no attachment ...

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 50613] ConnectionPool.size corruption when evictions enabled:

2011-01-18 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=50613

--- Comment #2 from Jeremy Norris  2011-01-18 22:49:17 EST 
---
Created an attachment (id=26513)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26513)
JUnit test case

Diff is against trunk, http://svn.apache.org/repos/asf/tomcat/trunk, 20110118

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

43 matches

Mail list logo