DO NOT REPLY [Bug 50272] New: Usage of variables named as java keyword leads to .jsp/.tag compilation error
https://issues.apache.org/bugzilla/show_bug.cgi?id=50272
Summary: Usage of variables named as java keyword leads to
.jsp/.tag compilation error
Product: Tomcat 7
Version: 7.0.4
Platform: PC
Status: NEW
Severity: regression
Priority: P2
Component: Jasper
AssignedTo: dev@tomcat.apache.org
ReportedBy: eugene.petre...@jetbrains.com
Consider .jsp file source with failure:
${class}
Another case:
I have a bean with getter: boolean isNew() available in jsp under name foo.
The following .jsp crashes:
AAA
The same issues are found in .tag files.
I included c prefix taglib with
<%@ taglib prefix="c" uri="http://java.sun.com/jsp/jstl/core"; %>
Is there a workaround to add a prefix for all variable names in generated java
code in order to make my application working with Tomcat7 without changes? My
application works under Tomcat6.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50120] .class in a jsp results in an invalid idetifier
https://issues.apache.org/bugzilla/show_bug.cgi?id=50120 Mark Thomas changed: What|Removed |Added CC||eugene.petre...@jetbrains.c ||om --- Comment #3 from Mark Thomas 2010-11-15 07:48:45 EST --- *** Bug 50272 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50272] Usage of variables named as java keyword leads to .jsp/.tag compilation error
https://issues.apache.org/bugzilla/show_bug.cgi?id=50272 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||DUPLICATE OS/Version||All --- Comment #1 from Mark Thomas 2010-11-15 07:48:44 EST --- The EL spec does not permit the examples you quote. *** This bug has been marked as a duplicate of bug 50120 *** -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1035285 - /tomcat/trunk/java/org/apache/catalina/core/StandardContext.java
Author: markt
Date: Mon Nov 15 14:14:30 2010
New Revision: 1035285
URL: http://svn.apache.org/viewvc?rev=1035285&view=rev
Log:
Align default with Context Javadoc.
Modified:
tomcat/trunk/java/org/apache/catalina/core/StandardContext.java
Modified: tomcat/trunk/java/org/apache/catalina/core/StandardContext.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/StandardContext.java?rev=1035285&r1=1035284&r2=1035285&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/StandardContext.java (original)
+++ tomcat/trunk/java/org/apache/catalina/core/StandardContext.java Mon Nov 15
14:14:30 2010
@@ -813,14 +813,18 @@ public class StandardContext extends Con
private Set resourceOnlyServlets = new HashSet();
-private String webappVersion;
+private String webappVersion = "";
// - Context Properties
@Override
public void setWebappVersion(String webappVersion) {
-this.webappVersion = webappVersion;
+if (null == webappVersion) {
+this.webappVersion = "";
+} else {
+this.webappVersion = webappVersion;
+}
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [PATCH] Parallel deployment
On 08/11/2010 18:05, Remy Maucherat wrote: > On Mon, 2010-11-08 at 18:26 +0100, Rainer Jung wrote: >> On 08.11.2010 18:05, Remy Maucherat wrote: >>> I'll up that to -1, with another concern I've just thought about: if >>> using a session id path which includes more than one webapp, the version >>> numbers will have problems matching between the two webapps. >> >> You mean situations like portals / emptysessionpath? > > It is replaced by direct session path configuration in Servlet 3, but > the problem is the same as with the old portal workaround from previous > versions. I have updated the proposed patch to match the session ID using the session manager: http://people.apache.org/~markt/patches/2010-11-15-parallel-deployment.patch The docs, manager app work and clustering tests still need to be completed but I wanted to give folks sight of where I was up to. As always, feedback welcome. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50120] .class in a jsp results in an invalid idetifier
https://issues.apache.org/bugzilla/show_bug.cgi?id=50120 Eugene Petrenko changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVALID | --- Comment #4 from Eugene Petrenko 2010-11-15 09:48:01 EST --- This is the breaking change for us to switch to Tomcat7. We have quite a big codebase to search for keyword usages in .jsp/.tag files. Is there a property/parameters/setting to enforce older behavior (like in 6.0) of jsp compiler? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50273] New: AprEndpoint logs socket accept fails altough error is harmless
https://issues.apache.org/bugzilla/show_bug.cgi?id=50273 Summary: AprEndpoint logs socket accept fails altough error is harmless Product: Tomcat 6 Version: 6.0.29 Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Priority: P2 Component: Native:Integration AssignedTo: dev@tomcat.apache.org ReportedBy: 1983-01...@gmx.net I use the above Tomcat on my HP-UX 11.23 system. I have compiled libtcnative 1.1.20 successfully. Tomcat is spamming my log files with this error message: 5.11.2010 09:06:29 org.apache.tomcat.util.net.AprEndpoint$Acceptor run SCHWERWIEGEND: Socket accept failed org.apache.tomcat.jni.Error: Kein Pufferplatz verfügbar at org.apache.tomcat.jni.Socket.accept(Native Method) at org.apache.tomcat.util.net.AprEndpoint$Acceptor.run(AprEndpoint.java:1169) at java.lang.Thread.run(Thread.java:619) In English: No buffer space available. I googled for the problem and this out: http://forums.devx.com/archive/index.php/t-99967.html This bug occurs with the IE6 & IE8 on our setup. I wasn't able to filter this our with java logging, it simple ignored loading my filter. Searching the APR docs I found this: http://dev.ariel-networks.com/apr/apr-tutorial/html/apr-tutorial-13.html Section "Detection of the remote host closed the socket" The error seems to be harmless, a debug or info would satisfy here but in the level severe it simply spams my disk. Is there a way to fix that according to the APR docs? I have no clue in C. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50273] AprEndpoint logs socket accept fails altough error is harmless
https://issues.apache.org/bugzilla/show_bug.cgi?id=50273 Michael Osipov <1983-01...@gmx.net> changed: What|Removed |Added Platform|PC |HP OS/Version|Windows XP |HP-UX -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1035316 - /tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
Author: kkolinko Date: Mon Nov 15 15:42:58 2010 New Revision: 1035316 URL: http://svn.apache.org/viewvc?rev=1035316&view=rev Log: Amend some entries in the changelog file, for better formatting and readability. Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml?rev=1035316&r1=1035315&r2=1035316&view=diff == --- tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml (original) +++ tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Mon Nov 15 15:42:58 2010 @@ -108,7 +108,8 @@ avoid. (markt) -49749: Use httpOnly setting when creating SSO cookie. (markt) +49749: Respect httpOnly setting of Context +when creating SSO cookie. (markt) Provide better web application state information via JMX. (markt) @@ -154,20 +155,21 @@ org.apache.catalina.security.SecurityUtil. (markt) -Add a new filter to provide generic cross-site request forgery (CSRF) +Add a new filter, org.apache.catalina.filters.CsrfPreventionFilter, +to provide generic cross-site request forgery (CSRF) protection for web applications. (markt) -Make sure Contexts defined in server.xml pick up any configClass setting -from the parent Host. (markt) +Make sure Contexts defined in server.xml pick up any configClass +setting from the parent Host. (markt) -Avoid a NPE for APR connector unlockAccept with default soTimeout -(mturk). +Avoid a NPE for APR connector unlockAccept with default soTimeout. +(mturk) 48738: Add support for flushing gzipped output. Based on a @@ -189,10 +191,10 @@ 49521: Disable scanning for a free port in Jk AJP/1.3 -connector by default. Do not change maxPort field value of ChannelSocket +connector by default. Do not change maxPort field value of ChannelSocket in its setPort() and init() methods. Add support for maxPort attribute on a Connector -element as a synonym for channelSocket.maxPort +element as a synonym for channelSocket.maxPort. (kkolinko) 49625: Ensure Vary header is set if response may be @@ -272,13 +274,14 @@ make sure isPrimarySession is changed to true. (kfujino) -Add support for maxActiveSessions attribute to BackupManager. (kfujino) +Add support for maxActiveSessions attribute to +BackupManager. (kfujino) Improve sending an access message in DeltaManager. -maxInactiveInterval of not Manager but the session is used. -If maxInactiveInterval is negative, an access message is not sending. -(kfujino) +Use maxInactiveInterval not of the Manager, but of the session. +If maxInactiveInterval is negative, the access message is not +being sent. (kfujino) @@ -290,15 +293,15 @@ Configure the Manager web application to use the new CSRF protection. To -take advantge of this protection, the manager role must be removed from -all users and the new manager-gui and manager-script roles used instead. -(markt) +take advantage of this protection, the manager role must be +removed from all users and the new manager-gui and +manager-script roles used instead. (markt) Configure the Host Manager web application to use the new CSRF -protection. To take advantge of this protection, the admin role must be -removed from all users and the new admin-gui and admin-script roles used -instead. (markt) +protection. To take advantge of this protection, the admin role +must be removed from all users and the new admin-gui and +admin-script roles used instead. (markt) @@ -318,8 +321,8 @@ Panagiotis Astithas. (kkolinko) -49861: Don't log RMI ports formatted with commas for the -JMX remote listener. (markt) +49861: Fix formatting of log messages in JXM remote listener. +Do not use commas when printing RMI port numbers. (markt) @@ -363,7 +366,7 @@ (markt) -49351: Fix possible NPe when embedding and no name is +49351: Fix possible NPE when embedding and no name is specified for the Service. (markt) @@ -371,13 +374,14 @@ POST request. (markt) -49414: Differentiate between request threads and application +49414: Improve diagnostic of memory leaks. +Differentiate between request th
DO NOT REPLY [Bug 50120] .class in a jsp results in an invalid idetifier
https://issues.apache.org/bugzilla/show_bug.cgi?id=50120 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||INVALID --- Comment #5 from Mark Thomas 2010-11-15 10:51:46 EST --- The same fix has been / will be applied to Tomcat 6. In the short-term you can use org.apache.el.parser.SKIP_IDENTIFIER_CHECK to bypass the check but that is not a viable long term solution. As time consuming as it may be, you'll need to review your apps for illegal EL and fix any issues. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50120] .class in a jsp results in an invalid idetifier
https://issues.apache.org/bugzilla/show_bug.cgi?id=50120 Konstantin Kolinko changed: What|Removed |Added Resolution|INVALID |DUPLICATE --- Comment #6 from Konstantin Kolinko 2010-11-15 10:57:23 EST --- *** This bug has been marked as a duplicate of bug 49217 *** -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49217] Accepting java keyword in EL
https://issues.apache.org/bugzilla/show_bug.cgi?id=49217 Konstantin Kolinko changed: What|Removed |Added CC||joker8achtu...@googlemail.c ||om --- Comment #8 from Konstantin Kolinko 2010-11-15 10:57:23 EST --- *** Bug 50120 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49217] Accepting java keyword in EL
https://issues.apache.org/bugzilla/show_bug.cgi?id=49217 --- Comment #9 from Konstantin Kolinko 2010-11-15 10:59:45 EST --- Note, that in 6.0 this check is off by default. One has to set org.apache.el.parser.SKIP_IDENTIFIER_CHECK property to "false" to enable it. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1035326 - /tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
Author: kkolinko Date: Mon Nov 15 16:02:39 2010 New Revision: 1035326 URL: http://svn.apache.org/viewvc?rev=1035326&view=rev Log: Add changelog entry for r1030599. Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml?rev=1035326&r1=1035325&r2=1035326&view=diff == --- tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml (original) +++ tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Mon Nov 15 16:02:39 2010 @@ -220,6 +220,11 @@ + +49217: Ensure that identifiers used in EL meet the +requirements of the Java Language Specification. This check is off by +default and can be enabled by setting a system property. (markt) + 49665: Provide better information including JSP file name and location when a missing file is detected during TLD handling. Patch - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1035360 - in /tomcat/trunk/java/org/apache/catalina/manager: HTMLManagerServlet.java LocalStrings.properties
Author: markt
Date: Mon Nov 15 17:29:45 2010
New Revision: 1035360
URL: http://svn.apache.org/viewvc?rev=1035360&view=rev
Log:
Parallel deployment
Add a version column to the HTML Manager output.
Modified:
tomcat/trunk/java/org/apache/catalina/manager/HTMLManagerServlet.java
tomcat/trunk/java/org/apache/catalina/manager/LocalStrings.properties
Modified: tomcat/trunk/java/org/apache/catalina/manager/HTMLManagerServlet.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/manager/HTMLManagerServlet.java?rev=1035360&r1=1035359&r2=1035360&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/manager/HTMLManagerServlet.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/manager/HTMLManagerServlet.java Mon
Nov 15 17:29:45 2010
@@ -35,7 +35,6 @@ import java.util.Locale;
import java.util.Map;
import java.util.Random;
import java.util.Set;
-import java.util.TreeMap;
import javax.servlet.ServletException;
import javax.servlet.http.HttpServletRequest;
@@ -444,70 +443,70 @@ public final class HTMLManagerServlet ex
writer.print(MessageFormat.format(Constants.MANAGER_SECTION, args));
// Apps Header Section
-args = new Object[6];
+args = new Object[7];
args[0] = smClient.getString("htmlManagerServlet.appsTitle");
args[1] = smClient.getString("htmlManagerServlet.appsPath");
-args[2] = smClient.getString("htmlManagerServlet.appsName");
-args[3] = smClient.getString("htmlManagerServlet.appsAvailable");
-args[4] = smClient.getString("htmlManagerServlet.appsSessions");
-args[5] = smClient.getString("htmlManagerServlet.appsTasks");
+args[2] = smClient.getString("htmlManagerServlet.appsVersion");
+args[3] = smClient.getString("htmlManagerServlet.appsName");
+args[4] = smClient.getString("htmlManagerServlet.appsAvailable");
+args[5] = smClient.getString("htmlManagerServlet.appsSessions");
+args[6] = smClient.getString("htmlManagerServlet.appsTasks");
writer.print(MessageFormat.format(APPS_HEADER_SECTION, args));
// Apps Row Section
-// Create sorted map of deployed applications context paths.
+// Create sorted map of deployed applications by context name.
Container children[] = host.findChildren();
-String contextPaths[] = new String[children.length];
+String contextNames[] = new String[children.length];
for (int i = 0; i < children.length; i++)
-contextPaths[i] = children[i].getName();
-
-TreeMap sortedContextPathsMap =
-new TreeMap();
+contextNames[i] = children[i].getName();
-for (int i = 0; i < contextPaths.length; i++) {
-String displayPath = contextPaths[i];
-sortedContextPathsMap.put(displayPath, contextPaths[i]);
-}
-
+Arrays.sort(contextNames);
+
String appsStart = smClient.getString("htmlManagerServlet.appsStart");
String appsStop = smClient.getString("htmlManagerServlet.appsStop");
String appsReload =
smClient.getString("htmlManagerServlet.appsReload");
-String appsUndeploy =
smClient.getString("htmlManagerServlet.appsUndeploy");
+String appsUndeploy =
+smClient.getString("htmlManagerServlet.appsUndeploy");
String appsExpire =
smClient.getString("htmlManagerServlet.appsExpire");
+String noVersion = "" +
+smClient.getString("htmlManagerServlet.noVersion") + "";
-Iterator> iterator =
-sortedContextPathsMap.entrySet().iterator();
boolean isHighlighted = true;
boolean isDeployed = true;
String highlightColor = null;
-while (iterator.hasNext()) {
-// Bugzilla 34818, alternating row colors
-isHighlighted = !isHighlighted;
-if(isHighlighted) {
-highlightColor = "#C3F3C3";
-} else {
-highlightColor = "#FF";
-}
+for (String contextName : contextNames) {
+Context ctxt = (Context) host.findChild(contextName);
+
+if (ctxt != null) {
+// Bugzilla 34818, alternating row colors
+isHighlighted = !isHighlighted;
+if(isHighlighted) {
+highlightColor = "#C3F3C3";
+} else {
+highlightColor = "#FF";
+}
-Map.Entry entry = iterator.next();
-String displayPath = entry.getKey();
-String contextPath = entry.getValue();
-Context ctxt = (Context) host.findChild(contextPath);
-if (displayPath.equals("")) {
-displayPath = "/";
-}
+String contextPath = ctxt.getPath();
+String displayPath = contextPath;
+
svn commit: r1035366 - /tomcat/trunk/java/org/apache/catalina/manager/HTMLManagerServlet.java
Author: markt
Date: Mon Nov 15 17:35:56 2010
New Revision: 1035366
URL: http://svn.apache.org/viewvc?rev=1035366&view=rev
Log:
Opps. Encoded display text rather than link.
Modified:
tomcat/trunk/java/org/apache/catalina/manager/HTMLManagerServlet.java
Modified: tomcat/trunk/java/org/apache/catalina/manager/HTMLManagerServlet.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/manager/HTMLManagerServlet.java?rev=1035366&r1=1035365&r2=1035366&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/manager/HTMLManagerServlet.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/manager/HTMLManagerServlet.java Mon
Nov 15 17:35:56 2010
@@ -501,8 +501,8 @@ public final class HTMLManagerServlet ex
}
args = new Object[7];
-args[0] = "" +
-URL_ENCODER.encode(displayPath) + "";
+args[0] = "" + displayPath + "";
args[1] = ctxt.getWebappVersion();
if ("".equals(args[1])) {
args[1]= noVersion;
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1035371 - /tomcat/trunk/java/org/apache/catalina/manager/HTMLManagerServlet.java
Author: markt
Date: Mon Nov 15 17:52:18 2010
New Revision: 1035371
URL: http://svn.apache.org/viewvc?rev=1035371&view=rev
Log:
Remove unused methods
Reduce visibility of methods where possible
Modified:
tomcat/trunk/java/org/apache/catalina/manager/HTMLManagerServlet.java
Modified: tomcat/trunk/java/org/apache/catalina/manager/HTMLManagerServlet.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/manager/HTMLManagerServlet.java?rev=1035371&r1=1035370&r2=1035371&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/manager/HTMLManagerServlet.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/manager/HTMLManagerServlet.java Mon
Nov 15 17:52:18 2010
@@ -393,7 +393,7 @@ public final class HTMLManagerServlet ex
* @param response The response
* @param message a message to display
*/
-public void list(HttpServletRequest request,
+protected void list(HttpServletRequest request,
HttpServletResponse response,
String message,
StringManager smClient) throws IOException {
@@ -687,7 +687,7 @@ public final class HTMLManagerServlet ex
* @param idle Expire all sessions with idle time ≥ idle for this
context
* @return message String
*/
-public String sessions(String path, int idle, StringManager smClient) {
+protected String sessions(String path, int idle, StringManager smClient) {
StringWriter stringWriter = new StringWriter();
PrintWriter printWriter = new PrintWriter(stringWriter);
@@ -698,19 +698,6 @@ public final class HTMLManagerServlet ex
}
/**
- * Display session information and invoke list.
- *
- * @see ManagerServlet#sessions(PrintWriter, String, StringManager)
- *
- * @param path Context path of the application to list session information
- * @return message String
- */
-public String sessions(String path, StringManager smClient) {
-
-return sessions(path, -1, smClient);
-}
-
-/**
* Start the web application at the specified context path.
*
* @see ManagerServlet#start(PrintWriter, String, StringManager)
@@ -718,7 +705,7 @@ public final class HTMLManagerServlet ex
* @param path Context path of the application to be started
* @return message String
*/
-public String start(String path, StringManager smClient) {
+protected String start(String path, StringManager smClient) {
StringWriter stringWriter = new StringWriter();
PrintWriter printWriter = new PrintWriter(stringWriter);
@@ -976,7 +963,7 @@ public final class HTMLManagerServlet ex
* @return number of invalidated sessions
* @throws IOException
*/
-public int invalidateSessions(String path, String[] sessionIds,
+protected int invalidateSessions(String path, String[] sessionIds,
StringManager smClient) throws IOException {
if (null == sessionIds) {
return 0;
@@ -1014,7 +1001,7 @@ public final class HTMLManagerServlet ex
* @return true if there was an attribute removed, false otherwise
* @throws IOException
*/
-public boolean removeSessionAttribute(String path, String sessionId,
+protected boolean removeSessionAttribute(String path, String sessionId,
String attributeName, StringManager smClient) throws IOException {
HttpSession session = getSessionForPathAndId(path, sessionId,
smClient).getSession();
if (null == session) {
@@ -1035,35 +1022,6 @@ public final class HTMLManagerServlet ex
return wasPresent;
}
-/**
- * Sets the maximum inactive interval (session timeout) an HttpSession
- * @param sessionId
- * @param maxInactiveInterval in seconds
- * @return old value for maxInactiveInterval
- * @throws IOException
- */
-public int setSessionMaxInactiveInterval(String path, String sessionId,
-int maxInactiveInterval, StringManager smClient) throws
IOException {
-HttpSession session = getSessionForPathAndId(path, sessionId,
smClient).getSession();
-if (null == session) {
-// Shouldn't happen, but let's play nice...
-if (debug >= 1) {
-log("WARNING: can't set timout for null session " + sessionId);
-}
-return 0;
-}
-try {
-int oldMaxInactiveInterval = session.getMaxInactiveInterval();
-session.setMaxInactiveInterval(maxInactiveInterval);
-return oldMaxInactiveInterval;
-} catch (IllegalStateException ise) {
-if (debug >= 1) {
-log("Can't set MaxInactiveInterval '" + maxInactiveInterval +
"' for invalidated session id " + sessionId);
-}
-return 0;
-}
-}
-
protected Comparator getComparator(String sortBy) {
svn commit: r1035401 - /tomcat/tc6.0.x/trunk/webapps/docs/config/systemprops.xml
Author: kkolinko Date: Mon Nov 15 18:48:50 2010 New Revision: 1035401 URL: http://svn.apache.org/viewvc?rev=1035401&view=rev Log: Reformat the document. Improve wording in several places. Print default values on separate lines, for better readability. Modified: tomcat/tc6.0.x/trunk/webapps/docs/config/systemprops.xml Modified: tomcat/tc6.0.x/trunk/webapps/docs/config/systemprops.xml URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/config/systemprops.xml?rev=1035401&r1=1035400&r2=1035401&view=diff == --- tomcat/tc6.0.x/trunk/webapps/docs/config/systemprops.xml (original) +++ tomcat/tc6.0.x/trunk/webapps/docs/config/systemprops.xml Mon Nov 15 18:48:50 2010 @@ -44,8 +44,8 @@ If true, the clustering module will attempt to use DNS to - resolve any host names provided in the cluster configuration. If not - specified, the default value of false will be used. + resolve any host names provided in the cluster configuration. + If not specified, the default value of false will be used. @@ -55,30 +55,30 @@ - - If true, when coercing expressions to numbers - "" and null will be coerced to zero as required - by the specification. If not specified, the default value of - true will be used. - - - + The number of javax.el.BeanELResolver.BeanProperties objects that will - be cached by the EL Parser. If not specified, the default of - 1000 will be used. + be cached by the EL Parser. + If not specified, the default of 1000 will be used. - + The number of parsed EL expressions that will be cached by the EL - Parser. If not specified, the default of 5000 will be used. - + Parser. + If not specified, the default of 5000 will be used. + + + + If true, when coercing EL expressions to numbers + "" and null will be coerced to zero as required + by the specification. + If not specified, the default value of true will be used. - - If true, when parsing expressions, identifiers will not be + + If true, when parsing EL expressions, identifiers will not be checked to ensure that they conform to the Java Language Specification for - Java identifiers. If not specified, the default value of - true will be used. + Java identifiers. + If not specified, the default value of true will be used. @@ -89,63 +89,68 @@ The name of the variable to use for the expression language expression - factory. If not specified, the default value of - _el_expressionfactory will be used. + factory. + If not specified, the default value of _el_expressionfactory + will be used. - The name of the variable to use for the instance manager factory. If - not specified, the default value of _jsp_instancemanager will - be used. + The name of the variable to use for the instance manager factory. + If not specified, the default value of _jsp_instancemanager + will be used. If true, the requirement to have the object referenced in jsp:getProperty action to be previously "introduced" to the JSP processor, as specified in the chapter JSP.5.3 of JSP 2.0 and - later specifications, is enforced. If not specified, the specification - compliant default of true will be used. + later specifications, is enforced. + If not specified, the specification compliant default of true + will be used. If false the requirements for escaping quotes in JSP attributes will be relaxed so that an unescaped quote will not - cause an error. If not specified, the specification compliant default of + cause an error. + If not specified, the specification compliant default of true will be used. If true, any tag buffer that expands beyond org.apache.jasper.Constants.DEFAULT_TAG_BUFFER_SIZE will be - destroyed and a new buffer created of the default size. If not specified, - the default value of false will be used. + destroyed and a new buffer created of the default size. + If not specified, the default value of false will be used. If true, a ThreadLocal PageContext pool will - be used. If not specified, the default value of true will be - used. + be used. + If not specified, the default value of true will be used. - The size of the ThreadLocal PageContext. If not specified, - the default value of 8 will be used. + The size of the ThreadLocal PageContext. + If not specified, the default value of 8 will be used. - The base class of the Servlets generated from the JSPs. If not - specified, the default value of
DO NOT REPLY [Bug 50275] New: Mod_JK does not set chunk size for response with chunked transfer encoding
https://issues.apache.org/bugzilla/show_bug.cgi?id=50275 Summary: Mod_JK does not set chunk size for response with chunked transfer encoding Product: Tomcat Connectors Version: 1.2.27 Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Priority: P2 Component: mod_jk AssignedTo: dev@tomcat.apache.org ReportedBy: andre.piw...@pacificorp.com Mod_JK does not handle correctly the case when Transfer-Encoding header is set to chunked on HTTP response returned from Tomcat via AJP. Transfer-Encoding is set on HttpServletResponse and no Content-Length header is set. In this scenario Mod_JK returns response to client with Transfer-Encoding set to chunked, but it fails to set chunk-size before the body. When the same response is returned with no Transfer-Encoding and no Content-Length set, Mod_JK sets Transfer-Encoding to chunked, sets the chunk size and returns response to the client. Transfer-Encoding is a hop-to-hop header and does not have to be set on the response from Mod_JK to client, but when it is I would expect Mod_JK set the chunk size. Server Apache/2.2.11 (Win32) mod_ssl/2.2.11 OpenSSL/0.9.8i mod_jk/1.2.27 Apache Tomcat 5.5.30 using AJP/1.3. Also, happens on SunOS and with other versions of Tomcat and with Apache 2.2.14. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1035479 - /tomcat/tc6.0.x/trunk/webapps/docs/config/systemprops.xml
Author: kkolinko Date: Mon Nov 15 22:42:46 2010 New Revision: 1035479 URL: http://svn.apache.org/viewvc?rev=1035479&view=rev Log: Correctly document the default value of org.apache.jasper.Constants.PRECOMPILE property. The value is "jsp_precompile". Modified: tomcat/tc6.0.x/trunk/webapps/docs/config/systemprops.xml Modified: tomcat/tc6.0.x/trunk/webapps/docs/config/systemprops.xml URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/config/systemprops.xml?rev=1035479&r1=1035478&r2=1035479&view=diff == --- tomcat/tc6.0.x/trunk/webapps/docs/config/systemprops.xml (original) +++ tomcat/tc6.0.x/trunk/webapps/docs/config/systemprops.xml Mon Nov 15 22:42:46 2010 @@ -166,8 +166,8 @@ The name of the query parameter that causes the JSP engine to just pregenerate the servlet but not invoke it. - If not specified, the default value of - org.apache.catalina.jsp_precompile will be used. + If not specified, the default value of jsp_precompile + will be used, as defined by JSP specification (JSP.11.4.2). - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1035489 - /tomcat/trunk/webapps/docs/config/systemprops.xml
Author: kkolinko Date: Mon Nov 15 23:50:18 2010 New Revision: 1035489 URL: http://svn.apache.org/viewvc?rev=1035489&view=rev Log: Reformat the document. Print default values on separate lines, for better readability. Correctly document the default value of org.apache.jasper.Constants.PRECOMPILE property. The value is "jsp_precompile". Modified: tomcat/trunk/webapps/docs/config/systemprops.xml Modified: tomcat/trunk/webapps/docs/config/systemprops.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/systemprops.xml?rev=1035489&r1=1035488&r2=1035489&view=diff == --- tomcat/trunk/webapps/docs/config/systemprops.xml (original) +++ tomcat/trunk/webapps/docs/config/systemprops.xml Mon Nov 15 23:50:18 2010 @@ -55,8 +55,8 @@ If true, the clustering module will attempt to use DNS to - resolve any host names provided in the cluster configuration. If not - specified, the default value of false will be used. + resolve any host names provided in the cluster configuration. + If not specified, the default value of false will be used. @@ -66,30 +66,30 @@ - - If true, when coercing expressions to numbers - "" and null will be coerced to zero as required - by the specification. If not specified, the default value of - true will be used. + + The number of javax.el.BeanELResolver.BeanProperties objects that will + be cached by the EL Parser. + If not specified, the default of 1000 will be used. - - If true, when parsing expressions, identifiers will not be - checked to ensure that they conform to the Java Language Specification for - Java identifiers. If not specified, the default value of - false will be used. + + The number of parsed EL expressions that will be cached by the EL + Parser. + If not specified, the default of 5000 will be used. - - The number of javax.el.BeanELResolver.BeanProperties objects that will - be cached by the EL Parser. If not specified, the default of - 1000 will be used. + + If true, when coercing expressions to numbers + "" and null will be coerced to zero as required + by the specification. + If not specified, the default value of true will be used. - - The number of parsed EL expressions that will be cached by the EL - Parser. If not specified, the default of 5000 will be used. - + + If true, when parsing expressions, identifiers will not be + checked to ensure that they conform to the Java Language Specification for + Java identifiers. + If not specified, the default value of false will be used. @@ -100,70 +100,76 @@ The name of the variable to use for the expression language expression - factory. If not specified, the default value of - _el_expressionfactory will be used. + factory. + If not specified, the default value of _el_expressionfactory + will be used. - The name of the variable to use for the instance manager factory. If - not specified, the default value of _jsp_instancemanager will - be used. + The name of the variable to use for the instance manager factory. + If not specified, the default value of _jsp_instancemanager + will be used. If true, the requirement to have the object referenced in jsp:getProperty action to be previously "introduced" to the JSP processor, as specified in the chapter JSP.5.3 of JSP 2.0 and - later specifications, is enforced. If not specified, the specification - compliant default of true will be used. + later specifications, is enforced. + If not specified, the specification compliant default of + true will be used. If false the requirements for escaping quotes in JSP attributes will be relaxed so that an unescaped quote will not - cause an error. If not specified, the specification compliant default of + cause an error. + If not specified, the specification compliant default of true will be used. If false the requirements for whitespace before an attribute name will be relaxed so that the lack of whitespace will not - cause an error. If not specified, the specification compliant default of + cause an error. + If not specified, the specification compliant default of true will be used. If true, any tag buffer that expands beyond org.apache.jasper.Constants.DEFAULT_TAG_BUFFER_SIZE will be - destroyed and a new buffer created of the default size. If not specified, - the default value of false will be used. + destroyed and a new buffer created of the default size. + If not specified, the default value
svn commit: r1035502 - /tomcat/trunk/webapps/docs/logging.xml
Author: kkolinko Date: Tue Nov 16 00:19:36 2010 New Revision: 1035502 URL: http://svn.apache.org/viewvc?rev=1035502&view=rev Log: Move block outside of list to avoid indent, and thus reduce horizontal scrolling. Do not nest lists into . Modified: tomcat/trunk/webapps/docs/logging.xml Modified: tomcat/trunk/webapps/docs/logging.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/logging.xml?rev=1035502&r1=1035501&r2=1035502&view=diff == --- tomcat/trunk/webapps/docs/logging.xml (original) +++ tomcat/trunk/webapps/docs/logging.xml Tue Nov 16 00:19:36 2010 @@ -230,11 +230,11 @@ java.util.logging.ConsoleHandler.formatt named tomcat.log. - - + Create a file called log4j.properties with the following content -and save it into $CATALINA_HOME/lib. - +and save it into $CATALINA_HOME/lib. + + log4j.rootLogger=INFO, CATALINA # Define all the appenders @@ -275,9 +275,8 @@ log4j.appender.CONSOLE.conversionPattern log4j.logger.org.apache.catalina.core.ContainerBase.[Catalina].[localhost]=INFO, LOCALHOST log4j.logger.org.apache.catalina.core.ContainerBase.[Catalina].[localhost].[/manager]=INFO, MANAGER log4j.logger.org.apache.catalina.core.ContainerBase.[Catalina].[localhost].[/host-manager]=INFO, HOST-MANAGER - - - + + http://logging.apache.org/log4j";>Download Log4J (v1.2 or later) and place the log4j jar in $CATALINA_HOME/lib. @@ -294,8 +293,7 @@ log4j.logger.org.apache.catalina.core.Co Delete $CATALINA_BASE/conf/logging.properties to prevent java.util.logging generating zero length log files. Start Tomcat - - + This log4j configuration mirrors the default java.util.logging setup - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1035505 - /tomcat/trunk/webapps/docs/logging.xml
Author: kkolinko Date: Tue Nov 16 00:23:40 2010 New Revision: 1035505 URL: http://svn.apache.org/viewvc?rev=1035505&view=rev Log: Wrap long lines in a properties file example. Modified: tomcat/trunk/webapps/docs/logging.xml Modified: tomcat/trunk/webapps/docs/logging.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/logging.xml?rev=1035505&r1=1035504&r2=1035505&view=diff == --- tomcat/trunk/webapps/docs/logging.xml (original) +++ tomcat/trunk/webapps/docs/logging.xml Tue Nov 16 00:23:40 2010 @@ -273,8 +273,10 @@ log4j.appender.CONSOLE.conversionPattern # Configure which loggers log to which appenders log4j.logger.org.apache.catalina.core.ContainerBase.[Catalina].[localhost]=INFO, LOCALHOST -log4j.logger.org.apache.catalina.core.ContainerBase.[Catalina].[localhost].[/manager]=INFO, MANAGER -log4j.logger.org.apache.catalina.core.ContainerBase.[Catalina].[localhost].[/host-manager]=INFO, HOST-MANAGER +log4j.logger.org.apache.catalina.core.ContainerBase.[Catalina].[localhost].[/manager]=\ + INFO, MANAGER +log4j.logger.org.apache.catalina.core.ContainerBase.[Catalina].[localhost].[/host-manager]=\ + INFO, HOST-MANAGER http://logging.apache.org/log4j";>Download Log4J - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49711] HttpServletRequest#getParts() does not work in a Filter
https://issues.apache.org/bugzilla/show_bug.cgi?id=49711 --- Comment #7 from balusc 2010-11-15 19:40:59 EST --- FYI: this issue is currently reported on servlet-spec-public: https://servlet-spec-public.dev.java.net/issues/show_bug.cgi?id=14 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1035518 - in /tomcat/trunk/webapps/docs: changelog.xml logging.xml
Author: kkolinko Date: Tue Nov 16 02:54:12 2010 New Revision: 1035518 URL: http://svn.apache.org/viewvc?rev=1035518&view=rev Log: Improve logging documentation. I completely rewrote the "Introduction" section of the page, to provide a lot more of details. Modified: tomcat/trunk/webapps/docs/changelog.xml tomcat/trunk/webapps/docs/logging.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1035518&r1=1035517&r2=1035518&view=diff == --- tomcat/trunk/webapps/docs/changelog.xml (original) +++ tomcat/trunk/webapps/docs/changelog.xml Tue Nov 16 02:54:12 2010 @@ -234,6 +234,9 @@ distributed Manager implementations to report full session information through the HTML Manager. (markt) + +Improve Tomcat Logging documentation. (kkolinko) + Modified: tomcat/trunk/webapps/docs/logging.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/logging.xml?rev=1035518&r1=1035517&r2=1035518&view=diff == --- tomcat/trunk/webapps/docs/logging.xml (original) +++ tomcat/trunk/webapps/docs/logging.xml Tue Nov 16 02:54:12 2010 @@ -36,30 +36,123 @@ - Tomcat uses + Logging in Apache Tomcat is implemented with the help of http://commons.apache.org/logging";>Apache Commons Logging - throughout its internal code. - Commons Logging provides Tomcat with the ability to log - hierarchically across various log levels without needing to rely on a + library. That library is a thin wrapper above different logging + frameworks. It provides Tomcat with the ability to log + hierarchically across various log levels without the need to rely on a particular logging implementation. - By default, only java.util.logging is available for the logs generated by - the Tomcat internal loggers, as Tomcat uses a package renamed commons - logging implementation which is hardcoded to use java.util.logging. Use of - alternative logging frameworks requires building or downloading an - extras component which include a full - commons-logging implementation. Instructions for configuring the extras - components to enable log4j to be used for Tomcat's internal logging may be - found below. + Since Tomcat 6.0, Tomcat uses a private package-renamed implementation of + Apache Commons Logging, to allow web applications to use their own + independent copies of the original Apache Commons Logging library. + In the default distribution this private copy of the library + is simplified and hardcoded to use the java.util.logging framework. - Tomcat no longer uses localhost_log as the runtime - exception/stack trace log. These types of error are usually thrown by - uncaught exceptions, but are still valuable to the developer. They can now - be found in the stdout log file (catalina.out). + To configure Tomcat to use alternative logging frameworks for its internal + logging, one has to replace the logging library with the one that is built + with the full implementation. Such library is provided as an extras + component. Instructions on how to configure Tomcat to use Log4j framework + for its internal logging may be found below. + + + + A web application running on Apache Tomcat can: + + + +Use logging API provided by the Java Servlets specification, +javax.servlet.ServletContext.log(...) + + +Use system logging API, java.util.logging. + + +Use any logging framework of its choice. + + + + + The logging frameworks used by different web applications run independently + of each other. See class loading + for more details. + The exception to this rule is java.util.logging, if it used + directly or indirectly by your logging library. That is because it is loaded + by the system and is shared across web applications. + + + + Apache Tomcat has its own implementation of several key elements of + java.util.logging API. This implementation is called "JULI". + The key component there is a custom LogManager implementation, + that is aware of different web applications running on Tomcat (and + their different class loaders). It supports private per-application + logging configurations. It is also notified by Tomcat when a web application + is unloaded from memory, so that the references to its classes can be + cleared, preventing memory leaks. + This java.util.logging implementation is enabled by providing + certain system properties when starting Java. The Apache Tomcat startup + scrip
