Re: [g...@vmgump]: Project tomcat-taglibs-standard (in module tomcat-taglibs) failed
On 2010-11-02, Jeremy Boynes wrote: > This started failing with r1029387. If I remove the > bundle from the spec module then the reactor > starts resolving it again. Could this be something with the bundle > plugin not working with the package goal? I don't think so. It is more likely that the reactor inside Gump needs to use the install goal so -impl is inside the local repo when -compat resolves its dependencies. This is not the first time I've seen this sort of behavior inside Gump. I've changed the goal used by Gump from package to install - let's see whether this helps. Stefan - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48685] Spnego Support in Tomcat
https://issues.apache.org/bugzilla/show_bug.cgi?id=48685 Michael Osipov changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #15 from Michael Osipov 2010-11-02 06:17:55 EDT --- Mark, in my opinion all of these additional dependencies are superfluous. I wrote a SpnegoAuthenticator for our webapps in less than 300 lines of code. All you need is Java 6 with native SPNEGO support. Our Active Directory forrest contains serveral thousand accounts which perfectly work with this solution. I would donate the code and adapt if this will be necessary. More over, I wrote a supplemental Active Directoy Realm which retrieves the roles and authenticates itself with Kerberos either as the Tomcat server or even better as the client connecting to the Tomcat server (credential delegation through Kerberos). Michael -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50197] New: Provide *.sh scripts with jsvc
https://issues.apache.org/bugzilla/show_bug.cgi?id=50197 Summary: Provide *.sh scripts with jsvc Product: Tomcat 6 Version: unspecified Platform: PC OS/Version: All Status: NEW Severity: normal Priority: P2 Component: Native:Packaging AssignedTo: dev@tomcat.apache.org ReportedBy: sg...@gmx.net Tomcat comes with predefined shell scripts which work very well. A lot of people compile commons daemon but need to alter those scripts over and over again. Please provide those scripts in a jsvc-style way "catalina.jsvc.sh" by default. People would only need to compile the source and start using it. I personally refrained using JSVC because I did not want to alter and test the modified shell scripts. It would really be a great benefit for all Tomcat users. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1029996 - /tomcat/trunk/java/org/apache/catalina/core/mbeans-descriptors.xml
Author: rjung Date: Tue Nov 2 10:32:59 2010 New Revision: 1029996 URL: http://svn.apache.org/viewvc?rev=1029996&view=rev Log: The jspFile attribute is no longer available in the StandardWrapper as of r1003589. Modified: tomcat/trunk/java/org/apache/catalina/core/mbeans-descriptors.xml Modified: tomcat/trunk/java/org/apache/catalina/core/mbeans-descriptors.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/mbeans-descriptors.xml?rev=1029996&r1=1029995&r2=1029996&view=diff == --- tomcat/trunk/java/org/apache/catalina/core/mbeans-descriptors.xml (original) +++ tomcat/trunk/java/org/apache/catalina/core/mbeans-descriptors.xml Tue Nov 2 10:32:59 2010 @@ -1590,11 +1590,6 @@ type="boolean" writeable="false"/> - - - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50175] Enhance memory leak detection by selectively applying methods,
https://issues.apache.org/bugzilla/show_bug.cgi?id=50175 --- Comment #4 from Leon Rosenberg 2010-11-02 06:35:02 EDT --- I think we should generally distinguish the different usage scenarios. For what I know, most people who use tomcat in production environment (in portals or b2c sites) do not use application reloading, because their tomcat-clusters are limited to one, main, application, and the restart of tomcat is safer and faster as the reload. For them most of the detection (if not all) do not make any sense: - daemon threads will be switched off on shutdown. - non-daemon threads will prevent shutdown and considered bugs - thread-local leakage is not really interested because all threads will be shut down anyway - what else? Than there are developers, which maybe use war-reloading (personally i think ctrl-c, arrow-up, enter is faster ;-) ), they will face OOM problems unless they fix all the leaks and/or replace the libs they are using. Still, as a developer I would like to be able to turn it, or have it off by default. Than there are people who use application reloading in production, and the question remains if this info is useful for the operation of the site. However, at least for the first category of people, who never use reloading, this leak detection is pretty useless, isn't it? Therefor, I would support any idea to reduce this 'in-this-usecase-unneeded-check-and-output' :-) -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1029999 - /tomcat/trunk/java/org/apache/catalina/realm/mbeans-descriptors.xml
Author: rjung Date: Tue Nov 2 10:55:05 2010 New Revision: 102 URL: http://svn.apache.org/viewvc?rev=102&view=rev Log: Fix MBean description. Modified: tomcat/trunk/java/org/apache/catalina/realm/mbeans-descriptors.xml Modified: tomcat/trunk/java/org/apache/catalina/realm/mbeans-descriptors.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/realm/mbeans-descriptors.xml?rev=102&r1=1029998&r2=102&view=diff == --- tomcat/trunk/java/org/apache/catalina/realm/mbeans-descriptors.xml (original) +++ tomcat/trunk/java/org/apache/catalina/realm/mbeans-descriptors.xml Tue Nov 2 10:55:05 2010 @@ -168,7 +168,7 @@ type="java.lang.String"/>
svn commit: r1030000 - in /tomcat/trunk/java/org/apache/catalina: core/mbeans-descriptors.xml valves/mbeans-descriptors.xml
Author: rjung Date: Tue Nov 2 10:57:26 2010 New Revision: 103 URL: http://svn.apache.org/viewvc?rev=103&view=rev Log: Fix some MBean descriptors: - "asyncSupported" needs is="true" for Valves - "containerName" is gone in valves since r940802 - "enabled" uses "get" instead of "is" Modified: tomcat/trunk/java/org/apache/catalina/core/mbeans-descriptors.xml tomcat/trunk/java/org/apache/catalina/valves/mbeans-descriptors.xml Modified: tomcat/trunk/java/org/apache/catalina/core/mbeans-descriptors.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/mbeans-descriptors.xml?rev=103&r1=102&r2=103&view=diff == --- tomcat/trunk/java/org/apache/catalina/core/mbeans-descriptors.xml (original) +++ tomcat/trunk/java/org/apache/catalina/core/mbeans-descriptors.xml Tue Nov 2 10:57:26 2010 @@ -1102,6 +1102,7 @@ http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/mbeans-descriptors.xml?rev=103&r1=102&r2=103&view=diff == --- tomcat/trunk/java/org/apache/catalina/valves/mbeans-descriptors.xml (original) +++ tomcat/trunk/java/org/apache/catalina/valves/mbeans-descriptors.xml Tue Nov 2 10:57:26 2010 @@ -25,6 +25,7 @@ - - - - - - - @@ -227,6 +217,7 @@ - - @@ -277,12 +264,9 @@ - - - -
DO NOT REPLY [Bug 50198] New: Fix possible NPE warning and remove one-time init from loop
https://issues.apache.org/bugzilla/show_bug.cgi?id=50198 Summary: Fix possible NPE warning and remove one-time init from loop Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Windows XP Status: NEW Severity: minor Priority: P2 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: s...@apache.org Created an attachment (id=26249) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26249) As per title -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1030014 - in /tomcat/trunk: java/org/apache/jasper/compiler/ java/org/apache/jasper/resources/ java/org/apache/jasper/servlet/ java/org/apache/jasper/util/ webapps/docs/
Author: rjung
Date: Tue Nov 2 12:14:43 2010
New Revision: 1030014
URL: http://svn.apache.org/viewvc?rev=1030014&view=rev
Log:
Add logging and JMX support to JSP unloading.
Also need to make getContent() public in
FastRemovalDequeue to support logging.
Modified:
tomcat/trunk/java/org/apache/jasper/compiler/JspRuntimeContext.java
tomcat/trunk/java/org/apache/jasper/resources/LocalStrings.properties
tomcat/trunk/java/org/apache/jasper/servlet/JspServlet.java
tomcat/trunk/java/org/apache/jasper/servlet/mbeans-descriptors.xml
tomcat/trunk/java/org/apache/jasper/util/FastRemovalDequeue.java
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/java/org/apache/jasper/compiler/JspRuntimeContext.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/compiler/JspRuntimeContext.java?rev=1030014&r1=1030013&r2=1030014&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/compiler/JspRuntimeContext.java
(original)
+++ tomcat/trunk/java/org/apache/jasper/compiler/JspRuntimeContext.java Tue Nov
2 12:14:43 2010
@@ -69,6 +69,11 @@ public final class JspRuntimeContext {
*/
private AtomicInteger jspReloadCount = new AtomicInteger(0);
+/*
+ * Counts how many times JSPs have been unloaded in this webapp.
+ */
+private AtomicInteger jspUnloadCount = new AtomicInteger(0);
+
/**
* Preload classes required at runtime by a JSP servlet so that
* we don't get a defineClassInPackage security exception.
@@ -158,6 +163,10 @@ public final class JspRuntimeContext {
if (options.getMaxLoadedJsps() > 0) {
jspQueue = new
FastRemovalDequeue(options.getMaxLoadedJsps());
+if (log.isDebugEnabled()) {
+log.debug(Localizer.getMessage("jsp.message.jsp_queue_created",
+ "" +
options.getMaxLoadedJsps(), context.getContextPath()));
+}
}
/* Init parameter is in seconds, locally we use milliseconds */
@@ -229,9 +238,17 @@ public final class JspRuntimeContext {
* @return an unloadHandle that can be pushed to front of queue at later
execution times.
* */
public FastRemovalDequeue.Entry push(JspServletWrapper
jsw) {
+if (log.isTraceEnabled()) {
+log.trace(Localizer.getMessage("jsp.message.jsp_added",
+ jsw.getJspUri(),
context.getContextPath()));
+}
FastRemovalDequeue.Entry entry = jspQueue.push(jsw);
JspServletWrapper replaced = entry.getReplaced();
if (replaced != null) {
+if (log.isDebugEnabled()) {
+
log.debug(Localizer.getMessage("jsp.message.jsp_removed_excess",
+ jsw.getJspUri(),
context.getContextPath()));
+}
unloadJspServletWrapper(replaced);
}
return entry;
@@ -243,6 +260,11 @@ public final class JspRuntimeContext {
* @param unloadHandle the unloadHandle for the jsp.
* */
public void makeYoungest(FastRemovalDequeue.Entry
unloadHandle) {
+if (log.isTraceEnabled()) {
+JspServletWrapper jsw = unloadHandle.getContent();
+log.trace(Localizer.getMessage("jsp.message.jsp_queue_update",
+ jsw.getJspUri(),
context.getContextPath()));
+}
jspQueue.moveFirst(unloadHandle);
}
@@ -320,6 +342,36 @@ public final class JspRuntimeContext {
return jspReloadCount.intValue();
}
+/**
+ * Gets the number of JSPs that are in the JSP limiter queue
+ *
+ * @return The number of JSPs (in the webapp with which this JspServlet is
+ * associated) that are in the JSP limiter queue
+ */
+public int getJspQueueLength() {
+if (jspQueue != null) {
+return jspQueue.getSize();
+}
+return -1;
+}
+
+/**
+ * Increments the JSP unload counter.
+ */
+public void incrementJspUnloadCount() {
+jspUnloadCount.incrementAndGet();
+}
+
+/**
+ * Gets the number of JSPs that have been unloaded.
+ *
+ * @return The number of JSPs (in the webapp with which this JspServlet is
+ * associated) that have been unloaded
+ */
+public int getJspUnloadCount() {
+return jspUnloadCount.intValue();
+}
+
/**
* Method used by background thread to check the JSP dependencies
@@ -523,6 +575,7 @@ public final class JspRuntimeContext {
synchronized(jsw) {
jsw.destroy();
}
+jspUnloadCount.incrementAndGet();
}
@@ -531,6 +584,14 @@ public final class JspRuntimeContext {
*/
public void checkUnload() {
+if (log.isTraceEnabled()) {
+int queueLength = -1;
+if (jspQueue != null) {
+queueLength = jspQ
svn commit: r1030037 - /tomcat/trunk/java/org/apache/jasper/compiler/JspRuntimeContext.java
Author: rjung
Date: Tue Nov 2 13:30:52 2010
New Revision: 1030037
URL: http://svn.apache.org/viewvc?rev=1030037&view=rev
Log:
Log the right JSP.
Modified:
tomcat/trunk/java/org/apache/jasper/compiler/JspRuntimeContext.java
Modified: tomcat/trunk/java/org/apache/jasper/compiler/JspRuntimeContext.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/compiler/JspRuntimeContext.java?rev=1030037&r1=1030036&r2=1030037&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/compiler/JspRuntimeContext.java
(original)
+++ tomcat/trunk/java/org/apache/jasper/compiler/JspRuntimeContext.java Tue Nov
2 13:30:52 2010
@@ -247,7 +247,7 @@ public final class JspRuntimeContext {
if (replaced != null) {
if (log.isDebugEnabled()) {
log.debug(Localizer.getMessage("jsp.message.jsp_removed_excess",
- jsw.getJspUri(),
context.getContextPath()));
+ replaced.getJspUri(),
context.getContextPath()));
}
unloadJspServletWrapper(replaced);
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48685] Spnego Support in Tomcat
https://issues.apache.org/bugzilla/show_bug.cgi?id=48685 --- Comment #16 from Mark Thomas 2010-11-02 12:12:59 EDT --- (In reply to comment #15) > in my opinion all of these additional dependencies are superfluous. I wrote a > SpnegoAuthenticator for our webapps in less than 300 lines of code. All you > need is Java 6 with native SPNEGO support. Good to hear. > I would donate the code and adapt if this will be necessary. That would be great. > More over, I wrote > a supplemental Active Directoy Realm which retrieves the roles and > authenticates itself with Kerberos either as the Tomcat server or even better > as the client connecting to the Tomcat server (credential delegation through > Kerberos). That sounds interesting too. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49099] Using % after context prefix results in 400 but nothing is logged in access log
https://issues.apache.org/bugzilla/show_bug.cgi?id=49099 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||FIXED --- Comment #6 from Mark Thomas 2010-11-02 14:13:11 EDT --- This has been fixed in 6.0.x and will be included in 6.0.30 onwards. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [g...@vmgump]: Project tomcat-taglibs-standard (in module tomcat-taglibs) failed
The package goal should work as the reactor resolves dependencies using the built artifacts rather than the local repository. It does work with the normal "jar" packaging and fails with "bundle" packaging so there is something going on. Using the install goal modifies the local repository and allows this to work. However, a build failure will result in an inconsistent local repository. We can turn bundling back on if we're OK with that happening on the build system (I don't know what else Gump is doing around the build e.g. is it wiping the local repo). On Nov 2, 2010, at 2:18 AM, Stefan Bodewig wrote: > On 2010-11-02, Jeremy Boynes wrote: > >> This started failing with r1029387. If I remove the >> bundle from the spec module then the reactor >> starts resolving it again. Could this be something with the bundle >> plugin not working with the package goal? > > I don't think so. It is more likely that the reactor inside Gump needs > to use the install goal so -impl is inside the local repo when -compat > resolves its dependencies. This is not the first time I've seen this > sort of behavior inside Gump. > > I've changed the goal used by Gump from package to install - let's see > whether this helps. > > Stefan > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50168] destory method is called twice while the child is destoryed directly
https://issues.apache.org/bugzilla/show_bug.cgi?id=50168 --- Comment #5 from Tim Funk 2010-11-02 15:17:10 EDT --- I don't think the patch works. What I (think I) notice is StandardWrapperValve being destroyed for each servlet in the webapp. By default there is the default servlet and jsp servlet. If you enable ssi and cgi, I think you will see the call being done 4 times. Why? TBD. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1030188 - in /tomcat/tc6.0.x/trunk: ./ java/org/apache/catalina/ java/org/apache/catalina/connector/ java/org/apache/catalina/core/ java/org/apache/catalina/valves/ java/org/apache/coyote
Author: markt Date: Tue Nov 2 19:26:07 2010 New Revision: 1030188 URL: http://svn.apache.org/viewvc?rev=1030188&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49099 Include requests rejected by CoyoteAdapter in the access log(s) Added: tomcat/tc6.0.x/trunk/java/org/apache/catalina/AccessLog.java (with props) Modified: tomcat/tc6.0.x/trunk/ (props changed) tomcat/tc6.0.x/trunk/STATUS.txt tomcat/tc6.0.x/trunk/java/org/apache/catalina/Container.java tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/ContainerBase.java tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/StandardEngine.java tomcat/tc6.0.x/trunk/java/org/apache/catalina/valves/AccessLogValve.java tomcat/tc6.0.x/trunk/java/org/apache/catalina/valves/JDBCAccessLogValve.java tomcat/tc6.0.x/trunk/java/org/apache/coyote/Adapter.java tomcat/tc6.0.x/trunk/java/org/apache/coyote/ajp/AjpAprProcessor.java tomcat/tc6.0.x/trunk/java/org/apache/coyote/ajp/AjpProcessor.java tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/Http11Processor.java tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml tomcat/tc6.0.x/trunk/webapps/docs/config/valve.xml Propchange: tomcat/tc6.0.x/trunk/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Tue Nov 2 19:26:07 2010 @@ -1 +1 @@ -/tomcat/trunk:601180,606992,612607,630314,640888,652744,653247,666232,673796,673820,677910,683969,683982,684001,684081,684234,684269-684270,685177,687503,687645,689402,690781,691392,691805,692748,693378,694992,695053,695311,696780,696782,698012,698227,698236,698613,699427,699634,701355,709294,709811,709816,710063,710066,710125,710205,711126,711600,712461,712467,713953,714002,718360,719119,719124,719602,719626,719628,720046,720069,721040,721286,721708,721886,723404,723738,726052,727303,728032,728768,728947,729057,729567,729569,729571,729681,729809,729815,729934,730250,730590,731651,732859,732863,734734,740675,740684,742677,742697,742714,744160,744238,746321,746384,746425,747834,747863,748344,750258,750291,750921,751286-751287,751289,751295,752323,753039,757335,757774,758249,758365,758596,758616,758664,759074,761601,762868,762929,762936-762937,763166,763183,763193,763228,763262,763298,763302,763325,763599,763611,763654,763681,763706,764985,764997,765662,768335,769979,770716,77 0809,770876,772872,776921,776924,776935,776945,777464,777466,777576,777625,778379,778523-778524,781528,781779,782145,782791,783316,783696,783724,783756,783762,783766,783863,783934,784453,784602,784614,785381,785688,785768,785859,786468,786487,786490,786496,786667,787627,787770,787985,789389,790405,791041,791184,791194,791224,791243,791326,791328,791789,792740,793372,793757,793882,793981,794082,794673,794822,795043,795152,795210,795457,795466,797168,797425,797596,797607,802727,802940,804462,804544,804734,805153,809131,809603,810916,810977,812125,812137,812432,813001,813013,813866,814180,814708,814876,815972,816252,817442,817822,819339,819361,820110,820132,820874,820954,821397,828196,828201,828210,828225,828759,830378-830379,830999,831106,831774,831785,831828,831850,831860,832214,832218,833121,833545,834047,835036,835336,836405,881396,881412,883130,883134,883146,883165,883177,883362,883565,884341,885038,885231,885241,885260,885901,885991,886019,888072,889363,889606,889716,8901 39,890265,890349-890350,890417,891185-891187,891583,892198,892341,892415,892464,892555,892812,892814,892817,892843,892887,893321,893493,894580,894586,894805,894831,895013,895045,895057,895191,895392,895703,896370,896384,897380-897381,897776,898126,898256,898468,898527,898555,898558,898718,898836,898906,899284,899348,899420,899653,899769-899770,899783,899788,899792,899916,899918-899919,899935,899949,903916,905020,905151,905722,905728,905735,907311,907513,907538,907652,907819,907825,907864,908002,908721,908754,908759,909097,909206,909212,909525,909636,909869,909875,909887,910266,910370,910442,910471,910485,910974,915226,915737,915861,916097,916141,916157,916170,917598,917633,918093,918489,918594,918684,918787,918792,918799,918803,918885,919851,919914,920025,920055,920298,920449,920596,920824,920840,921444,922010,926716,927062,927621,928482,928695,928732,928798,931709,932357,932967,935105,935983,939491,939551,940064,941356,941463,944409,944416,945231,945808,945835,945841,946686 ,948057,950164,950596,950614,950851,950905,951615,953434,954435,955648,955655,956832,957130,957830,958192,960701,963868,964614,966177-966178,966292,966692,981815,991837,993042,1001955,1002185,1002263,1002274,1002349,1002359,1002362,1002481,1002514,1003481,1003488,1003556,1003572,1003581,1003861,1004868-1004869,1005452,1005467,1005647,1005802,1022120,1022134,1022606,1022623,1024224,1024251,10260
svn commit: r1030237 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: kkolinko Date: Tue Nov 2 21:32:38 2010 New Revision: 1030237 URL: http://svn.apache.org/viewvc?rev=1030237&view=rev Log: proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1030237&r1=1030236&r2=1030237&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Nov 2 21:32:38 2010 @@ -232,3 +232,10 @@ PATCHES PROPOSED TO BACKPORT: +1: mturk, rjung, kkolinko -1: +* Additional minor patch / followup to r1030188 + Add logging for some rare case in Http11Processor.parseHost() + To reproduce, send a HTTP/1.1 request with an invalid value for the port + number in the Host header. + http://people.apache.org/~kkolinko/patches/2010-11-03_tc6_49099_Http11Processor.patch + +1: kkolinko + -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1030253 - /tomcat/trunk/java/org/apache/catalina/core/StandardEngine.java
Author: kkolinko
Date: Tue Nov 2 22:04:44 2010
New Revision: 1030253
URL: http://svn.apache.org/viewvc?rev=1030253&view=rev
Log:
Improve handling of nulls in StandardEngine.logAccess()
This takes care of the case when findChild(getDefaultHost()) returns null.
Modified:
tomcat/trunk/java/org/apache/catalina/core/StandardEngine.java
Modified: tomcat/trunk/java/org/apache/catalina/core/StandardEngine.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/StandardEngine.java?rev=1030253&r1=1030252&r2=1030253&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/StandardEngine.java (original)
+++ tomcat/trunk/java/org/apache/catalina/core/StandardEngine.java Tue Nov 2
22:04:44 2010
@@ -313,26 +313,27 @@ public class StandardEngine extends Cont
}
if (!logged && useDefault) {
-Host host = null;
if (defaultAccessLog == null) {
// If we reached this point, this Engine can't have an
AccessLog
// Look in the defaultHost
-host = (Host) findChild(getDefaultHost());
-defaultAccessLog = host.getAccessLog();
-
-if (defaultAccessLog == null) {
-// Try the ROOT context of default host
-Context context = (Context) host.findChild("");
-if (context != null) {
-defaultAccessLog = context.getAccessLog();
-}
+Host host = (Host) findChild(getDefaultHost());
+if (host != null) {
+defaultAccessLog = host.getAccessLog();
if (defaultAccessLog == null) {
-defaultAccessLog = new NoopAccessLog();
+// Try the ROOT context of default host
+Context context = (Context) host.findChild("");
+if (context != null) {
+defaultAccessLog = context.getAccessLog();
+}
}
}
+
+if (defaultAccessLog == null) {
+defaultAccessLog = new NoopAccessLog();
+}
}
-
+
defaultAccessLog.log(request, response, time);
}
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1030264 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: kkolinko Date: Tue Nov 2 22:21:13 2010 New Revision: 1030264 URL: http://svn.apache.org/viewvc?rev=1030264&view=rev Log: proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1030264&r1=1030263&r2=1030264&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Nov 2 22:21:13 2010 @@ -239,3 +239,12 @@ PATCHES PROPOSED TO BACKPORT: http://people.apache.org/~kkolinko/patches/2010-11-03_tc6_49099_Http11Processor.patch +1: kkolinko -1: + +* Followup to r1030188 + Avoid NPE in StandardEngine.logAccess(..) if default host or its ROOT + context are null. + To reproduce, start Tomcat without the ROOT webapp and make an invalid + request. An NPE happens. It is backport of r966570, r1030253. + http://people.apache.org/~kkolinko/patches/2010-11-03_tc6_49099_StandardEngine.patch + +1: kkolinko + -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50201] New: StandardEngine.defaultAccessLog may become stale when ROOT webapp is redeployed
https://issues.apache.org/bugzilla/show_bug.cgi?id=50201 Summary: StandardEngine.defaultAccessLog may become stale when ROOT webapp is redeployed Product: Tomcat 6 Version: 6.0.29 Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Priority: P2 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: knst.koli...@gmail.com In tc6.0.x-dev after r1030188 (will be 6.0.30) and in TC 7.0.4: The method StandardEngine.logAccess(..) performs lookup of a default AccessLog implementation and caches it as StandardEngine.defaultAccessLog. This value is not updated if the default host or its ROOT webapp are changed. The most important use case here is when the ROOT webapp is redeployed or restarted. To reproduce: 1. Configure an access log valve in the ROOT webapp. Remove access log valves from Engine and Host if there are any. 2. Start Tomcat and do some malformed request 3. Undeploy and redeploy the ROOT webapp. E.g. rename ROOT -> ROOT1, wait until undeployment happens and rename it back. 4. Do some malformed request. Expected behaviour: the request has to be logged. Actual behaviour: the request is not logged. Notes: 1. This does not happen if an access log valve is also configured on the Host or Engine. The default server.xml of Tomcat 7 does have such a valve in the default Host. 2. Restarting the ROOT webapp (e.g. touching its web.xml) is not enough to trigger this. (Apparently it does not cause closing of the valve). 3. It is not detected as a memory leak. (Apparently the Valve is not loaded with webapp's classloader). So, the requests not being logged is the only effect of this issue that I am observing. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
IIS-Tomcat Integration
We are trying to integrate IIS and Tomcat. We get the Service temporarily unavailable or Bad Gateway message. isapi_redirect.properties extension_uri=/tomcat/isapi_redirect.dll log_file=C:\apps\Tomcat 6.0\logs\jk_iis.log log_level=trace worker_file=C:\apps\Tomcat 6.0\conf\workers.properties worker_mount_file=C:\apps\Tomcat 6.0\conf\uriworkermap.properties workers.properties worker.list=testWorker worker.testWorker.type=ajp13 worker.testWorker.host=localhost worker.testWorker.port=8009 worker.testWorker.ping_mode=A worker.testWorker.socket_timeout=60 worker.testWorker.prepost_timeout=1 worker.testWorker.socket_connect_timeout=1 worker.testWorker.connection_pool_size=200 worker.testWorker.connection_pool_timeout=300 worker.testWorker.retries=20 worker.testWorker.socket_keepalive=1 worker.testWorker.socket_timeout=10 worker.testWorker.cachesize=10 worker.testWorker.cache_timeout=600 Error: 2): (testWorker) cping/cpong after connecting to the backend server failed (errno=60) [Tue Nov 02 15:59:57.941 2010] [2000:2584] [trace] jk_ajp_common.c (996): exit [Tue Nov 02 15:59:57.941 2010] [2000:2584] [error] jk_ajp_common.c (1585): (testWorker) connecting to backend failed. Tomcat is probably not started or is listening on the wrong port (errno=60) [Tue Nov 02 15:59:57.941 2010] [2000:2584] [trace] jk_ajp_common.c (1589): exit [Tue Nov 02 15:59:57.941 2010] [2000:2584] [info] jk_ajp_common.c (2540): (testWorker) sending request to tomcat failed (recoverable), because of error during request sending (attempt=17) [Tue Nov 02 15:59:57.941 2010] [2000:2584] [trace] jk_ajp_common.c (801): enter Any help would be greatly appreciated. Thanks! -- View this message in context: http://old.nabble.com/IIS-Tomcat-Integration-tp30119258p30119258.html Sent from the Tomcat - Dev mailing list archive at Nabble.com. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50202] New: web.xml cant load because of
https://issues.apache.org/bugzilla/show_bug.cgi?id=50202 Summary: web.xml cant load because of Product: Tomcat 5 Version: 5.5.31 Platform: PC OS/Version: Windows XP Status: NEW Severity: blocker Priority: P2 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: willschumac...@gmail.com Hi When I put these lines: org.springframework.web.context.ContextLoaderListener my appln can't load at all. When I go to http://localhost:8080/app it's not loaded (HTTP 404). But when I remove those lines it loads correctly. I've put the necessary lib containing org.springframework.web.context.ContextLoaderListener in ./app/WEB-INF/lib. Context-param is set: contextConfigLocation classpath:./springContext.xml No stack trace is shown. The error message in log is: 03-Nov-2010 10:21:48 INFO HostConfig:863 - Deploying web application archive wma.war 03-Nov-2010 10:21:49 ERROR StandardContext:4253 - Error listenerStart 03-Nov-2010 10:21:49 ERROR StandardContext:4280 - Context [/wma] startup failed due to previous errors When I set the logging to DEBUG level, I don't see anything extra ordinary. Thanks. Will -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: IIS-Tomcat Integration
On 03/11/2010 03:12, sbpdvlpr wrote: > > We are trying to integrate IIS and Tomcat. We get the Service temporarily > unavailable or Bad Gateway message. > > isapi_redirect.properties > extension_uri=/tomcat/isapi_redirect.dll > log_file=C:\apps\Tomcat 6.0\logs\jk_iis.log > log_level=trace > worker_file=C:\apps\Tomcat 6.0\conf\workers.properties > worker_mount_file=C:\apps\Tomcat 6.0\conf\uriworkermap.properties > > workers.properties > worker.list=testWorker > worker.testWorker.type=ajp13 > worker.testWorker.host=localhost > worker.testWorker.port=8009 > worker.testWorker.ping_mode=A > worker.testWorker.socket_timeout=60 > worker.testWorker.prepost_timeout=1 > worker.testWorker.socket_connect_timeout=1 > worker.testWorker.connection_pool_size=200 > worker.testWorker.connection_pool_timeout=300 > worker.testWorker.retries=20 > worker.testWorker.socket_keepalive=1 > worker.testWorker.socket_timeout=10 > worker.testWorker.cachesize=10 > worker.testWorker.cache_timeout=600 > > Error: > 2): (testWorker) cping/cpong after connecting to the backend server failed > (errno=60) > [Tue Nov 02 15:59:57.941 2010] [2000:2584] [trace] jk_ajp_common.c (996): > exit > [Tue Nov 02 15:59:57.941 2010] [2000:2584] [error] jk_ajp_common.c (1585): > (testWorker) connecting to backend failed. Tomcat is probably not started or > is listening on the wrong port (errno=60) > [Tue Nov 02 15:59:57.941 2010] [2000:2584] [trace] jk_ajp_common.c (1589): > exit > [Tue Nov 02 15:59:57.941 2010] [2000:2584] [info] jk_ajp_common.c (2540): > (testWorker) sending request to tomcat failed (recoverable), because of > error during request sending (attempt=17) > [Tue Nov 02 15:59:57.941 2010] [2000:2584] [trace] jk_ajp_common.c (801): > enter > > Any help would be greatly appreciated. > > Thanks! Please ask this question on the Tomcat Users Mailing List. p 0x62590808.asc Description: application/pgp-keys signature.asc Description: OpenPGP digital signature
DO NOT REPLY [Bug 50202] web.xml cant load because of
https://issues.apache.org/bugzilla/show_bug.cgi?id=50202 Pid changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Comment #1 from Pid 2010-11-03 02:55:04 EDT --- Bugzilla is not a support forum. Please ask this question on the Tomcat Users Mailing List. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
