DO NOT REPLY [Bug 49732] reply_timeout can't wait forever.

2010-11-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49732

Ryuichi Yoshihara  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|INVALID |
 AssignedTo|dev@tomcat.apache.org   |yoshihara.ryu...@oss.ntt.co
   ||.jp

--- Comment #2 from Ryuichi Yoshihara  
2010-11-01 04:14:53 EDT ---
Created an attachment (id=26244)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26244)
Patch of "jk_ajp_common.c" and "jk_connect.c"

 Surely, remove socket_timeout, wait forever.
 However, socket_timeout influences all of connections.
 I want it to wait forever only when the response is returned from Tomcat.

 I made patch.

 Best regards.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Invalid message recieved with signature

2010-11-01 Thread Weibin Yao

Hi tomcat developers,
   Our tomcat_5.5.20 servers encounter a lot of error logs:

/2010-11-1 14:58:10 org.apache.coyote.ajp.AjpMessage processHeader
: Invalid message recieved with signature 13410
2010-11-1 14:58:10 
org.apache.coyote.ajp.AjpAprProtocol$AjpConnectionHandler process

: Error reading request, ignored
java.lang.StringIndexOutOfBoundsException: String index out of range: 30076
   at java.lang.String.checkBounds(String.java:402)
   at java.lang.String.(String.java:443)
   at 
org.apache.tomcat.util.buf.ByteChunk.toStringInternal(ByteChunk.java:498)
   at 
org.apache.tomcat.util.buf.StringCache.toString(StringCache.java:310)

   at org.apache.tomcat.util.buf.ByteChunk.toString(ByteChunk.java:491)
   at 
org.apache.tomcat.util.buf.MessageBytes.toString(MessageBytes.java:209)
   at 
org.apache.coyote.RequestInfo.updateCounters(RequestInfo.java:146)

   at org.apache.coyote.Request.updateCounters(Request.java:488)
   at 
org.apache.coyote.ajp.AjpAprProcessor.process(AjpAprProcessor.java:450)
   at 
org.apache.coyote.ajp.AjpAprProtocol$AjpConnectionHandler.process(AjpAprProtocol.java:452)
   at 
org.apache.tomcat.util.net.AprEndpoint$Worker.run(AprEndpoint.java:1285)

   at java.lang.Thread.run(Thread.java:619)
/

   We use this servers as upload servers, most of the AJP requests are 
POST method. This a debug log:


/2010-11-1 14:19:33 org.apache.coyote.ajp.AjpMessage processHeader
: Invalid message recieved with signature 11565
2010-11-1 14:19:33 org.apache.coyote.ajp.AjpMessage dump
▒▒▒: In: : [...@cc5b10 4/11569
2010-11-1 14:19:33 org.apache.coyote.ajp.AjpMessage dump
▒▒▒: 2d 2d 2d 2d 02 04 00 08 48 54 54 50 2f 31 2e 30  | HTTP/1.0
2010-11-1 14:19:33 org.apache.coyote.ajp.AjpMessage dump
▒▒▒: 00 00 0a 2f 75 70 6c 6f 61 64 2e 64 6f 00 00 0c  | .../upload.do...
2010-11-1 14:19:33 org.apache.coyote.ajp.AjpMessage dump
▒▒▒: 31 38 33 2e 31 37 2e 38 2e 32 30 38 00 ff ff 00  | 183.17.8.208.??.
2010-11-1 14:19:33 org.apache.coyote.ajp.AjpMessage dump
▒▒▒: 14 75 70 6c 6f 61 64 2e 70 68 6f 74 6f 2e 31 36  | .upload.photo.16
2010-11-1 14:19:33 org.apache.coyote.ajp.AjpMessage dump
▒▒▒: 33 2e 63 6f 6d 00 00 50 00 00 0d a0 0b 00 14 75  | 3.com..P...?...u
2010-11-1 14:19:33 org.apache.coyote.ajp.AjpMessage dump
▒▒▒: 70 6c 6f 61 64 2e 70 68 6f 74 6f 2e 31 36 33 2e  | pload.photo.163.
2010-11-1 14:19:33 org.apache.coyote.ajp.AjpMessage dump
▒▒▒: 63 6f 6d 00 00 0f 58 2d 46 6f 72 77 61 72 64 65  | com...X-Forwarde
2010-11-1 14:19:33 org.apache.coyote.ajp.AjpMessage dump
▒▒▒: 64 2d 46 6f 72 00 00 0c 31 38 33 2e 31 37 2e 38  | d-For...183.17.8
2010-11-1 14:19:33 org.apache.coyote.ajp.AjpMessage dump
▒▒▒: 2e 32 30 38 00 00 09 58 2d 46 72 6f 6d 2d 49 50  | .208...X-From-IP
2010-11-1 14:19:33 org.apache.coyote.ajp.AjpMessage dump
▒▒▒: 00 00 0c 31 38 33 2e 31 37 2e 38 2e 32 30 38 00  | ...183.17.8.208.
2010-11-1 14:19:33 org.apache.coyote.ajp.AjpMessage dump
▒▒▒: 00 0a 58 2d 46 72 6f 6d 2d 49 53 50 00 00 01 32  | ..X-From-ISP...2
2010-11-1 14:19:33 org.apache.coyote.ajp.AjpMessage dump
▒▒▒: 00 a0 06 00 05 63 6c 6f 73 65 00 a0 0d 00 14 75  | .?...close.?...u
2010-11-1 14:19:33 org.apache.coyote.ajp.AjpMessage dump
▒▒▒: 70 6c 6f 61 64 2e 70 68 6f 74 6f 2e 31 36 33 2e  | pload.photo.163.
2010-11-1 14:19:33 org.apache.coyote.ajp.AjpMessage dump
▒▒▒: 63 6f 6d 00 a0 01 00 06 74 65 78 74 2f 2a 00 a0  | com.?...text/*.?
2010-11-1 14:19:33 org.apache.coyote.ajp.AjpMessage dump
.../*

   *It seems that the packet's 4 bytes in the beginning are incorrect.
  
   Meanwhile I also captured all the TCP packets with port 8009 by 
tcpdump. I found all the TCP packet's header are all fine which is 
beginning with 0x1234.


   We use apache2.2.3, libapache2-mod-jk_1.2.21 and tomcat_5.5.20.
   The boxes system are 2.6.18-4-686 #1 SMP Mon Mar 26 17:17:36 UTC 
2007 i686 GNU/Linux.


--

Weibin Yao


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 49732] reply_timeout can't wait forever.

2010-11-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49732

Konstantin Kolinko  changed:

   What|Removed |Added

 AssignedTo|yoshihara.ryu...@oss.ntt.co |dev@tomcat.apache.org
   |.jp |

--- Comment #3 from Konstantin Kolinko  2010-11-01 
05:24:13 EDT ---
Reverted "Assigned To" field to the default value.
Please, do not change it.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: svn commit: r1029423 - in /tomcat: tc5.5.x/trunk/STATUS.txt tc6.0.x/trunk/STATUS.txt

2010-11-01 Thread Konstantin Kolinko
2010/11/1 Mark Thomas :
> On 31/10/2010 13:13, kkoli...@apache.org wrote:
>> Modified: tomcat/tc6.0.x/trunk/STATUS.txt
>> --- tomcat/tc6.0.x/trunk/STATUS.txt (original)
>> +++ tomcat/tc6.0.x/trunk/STATUS.txt Sun Oct 31 17:13:51 2010
>> @@ -230,12 +230,14 @@ PATCHES PROPOSED TO BACKPORT:
>>    Allow 32-bit and 64-bit JDKs to be selected on 64-bit platforms
>>    http://svn.apache.org/viewvc?rev=1027504&view=rev
>>    +1: markt, mturk
>> -  -1:
>> +  -1: kkolinko: The function checkJava spawns a .bat file
>> +   (ExecWait '"$R0.bat"'). It is visible as a flickering black window
>> +   when I go from JRE selection page to the next page in TC7 installer.
>>     kkolinko: merging r1027504 does not perform cleanly
>
> The not merging cleanly I can fix when I get a moment. The briefly
> displayed command window is trickier. I don't know if it can be hidden.
> I certainly see it happen reasonably frequently when I install all sorts
> of Windows software. At the moment, I view it as a necessary evil for
> being able to support installing to 32-bit JVMs on 64-bit platforms.
>
> If Garrett (the MS open source guy) is at ApacheCon I'll try and pester
> him to see if there is a better way (e.g. looking for a magic number in
> a .exe or .dll). If anyone has any better ideas please speak up.
>

Some thoughts:

1. We do not need this check at all on a 32-bit OS.


2. If the JRE is installed to its default location, there are
different locations for 32 bit and 64 bit programs.

3. I found the following:
[1] http://msdn.microsoft.com/en-us/library/ms973190.aspx
mentions System.Reflection.Module.GetPEKind

Searching for "GetPEKind" gives some more pointers
[2] 
http://www.geekpedia.com/Thread27309_How-Do-I-Tell-If-A-DLL-Is-X86-X64-Or-AnyCpu.html
[3] 
http://stackoverflow.com/questions/480696/how-to-find-if-native-dll-is-compiled-as-x64-or-x86


4. We can write a Java class and execute it with javaw.exe
System.getProperty("os.arch");
[4] 
http://stackoverflow.com/questions/807263/how-do-i-detect-which-kind-of-jre-is-installed-32bit-vs-64bit


Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: svn commit: r1029423 - in /tomcat: tc5.5.x/trunk/STATUS.txt tc6.0.x/trunk/STATUS.txt

2010-11-01 Thread Mark Thomas
On 01/11/2010 06:43, Konstantin Kolinko wrote:
> 2010/11/1 Mark Thomas :
>> On 31/10/2010 13:13, kkoli...@apache.org wrote:
>>> Modified: tomcat/tc6.0.x/trunk/STATUS.txt
>>> --- tomcat/tc6.0.x/trunk/STATUS.txt (original)
>>> +++ tomcat/tc6.0.x/trunk/STATUS.txt Sun Oct 31 17:13:51 2010
>>> @@ -230,12 +230,14 @@ PATCHES PROPOSED TO BACKPORT:
>>>Allow 32-bit and 64-bit JDKs to be selected on 64-bit platforms
>>>http://svn.apache.org/viewvc?rev=1027504&view=rev
>>>+1: markt, mturk
>>> -  -1:
>>> +  -1: kkolinko: The function checkJava spawns a .bat file
>>> +   (ExecWait '"$R0.bat"'). It is visible as a flickering black window
>>> +   when I go from JRE selection page to the next page in TC7 installer.
>>> kkolinko: merging r1027504 does not perform cleanly
>>
>> The not merging cleanly I can fix when I get a moment. The briefly
>> displayed command window is trickier. I don't know if it can be hidden.
>> I certainly see it happen reasonably frequently when I install all sorts
>> of Windows software. At the moment, I view it as a necessary evil for
>> being able to support installing to 32-bit JVMs on 64-bit platforms.
>>
>> If Garrett (the MS open source guy) is at ApacheCon I'll try and pester
>> him to see if there is a better way (e.g. looking for a magic number in
>> a .exe or .dll). If anyone has any better ideas please speak up.
>>
> 
> Some thoughts:
> 
> 1. We do not need this check at all on a 32-bit OS.

Yep. Should be possible to avoid this check on a 32-bit OS.

> 2. If the JRE is installed to its default location, there are
> different locations for 32 bit and 64 bit programs.

True, but not something we can depend on. We can't even be sure that the
64-bit JVM hasn't been installed to the default 32-bit location.

> 3. I found the following:
> [1] http://msdn.microsoft.com/en-us/library/ms973190.aspx
> mentions System.Reflection.Module.GetPEKind

That requires .NET and not every machine has installed the .NET runtime.
I don't want to make having .NET a pre-requisite for a correctly
operating installer.

> 4. We can write a Java class and execute it with javaw.exe
> System.getProperty("os.arch");
> [4] 
> http://stackoverflow.com/questions/807263/how-do-i-detect-which-kind-of-jre-is-installed-32bit-vs-64bit

That could work. I quite like the look of the ExeDetect code. *If* we
can get that working in NSIS then we can avoid starting up another process.

Something else for me to work on at ApacheCon :)

Mark



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: svn commit: r1029527 [1/2] - in /tomcat/trunk/java/org/apache/catalina: ./ connector/ core/ ha/deploy/ loader/ manager/ mbeans/ realm/ session/ startup/ util/

2010-11-01 Thread Mark Thomas
On 01/11/2010 07:00, Mark Thomas wrote:
> On 01/11/2010 06:50, Gurkan Erdogdu wrote:
>> Hi;
>>
>> After this commit I am not able to deploy applications using manager
> 
> OK, I'll take a look. I did some simple tests to make sure nothing major
> was broken but I didn't test that. As a workaround, just copying the WAR
> to the webapps directory should work.

It won't. looking at it now...

Mark



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1029616 - /tomcat/trunk/java/org/apache/catalina/startup/HostConfig.java

2010-11-01 Thread markt
Author: markt
Date: Mon Nov  1 11:26:00 2010
New Revision: 1029616

URL: http://svn.apache.org/viewvc?rev=1029616&view=rev
Log:
Parallel deployment
Fix regression that broke WAR deployments

Modified:
tomcat/trunk/java/org/apache/catalina/startup/HostConfig.java

Modified: tomcat/trunk/java/org/apache/catalina/startup/HostConfig.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/startup/HostConfig.java?rev=1029616&r1=1029615&r2=1029616&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/startup/HostConfig.java (original)
+++ tomcat/trunk/java/org/apache/catalina/startup/HostConfig.java Mon Nov  1 
11:26:00 2010
@@ -478,7 +478,7 @@ public class HostConfig
 
 File appBase = appBase();
 File configBase = configBase();
-ContextName cn = new ContextName(name);
+ContextName cn = new ContextName(name, null);
 String baseName = cn.getBaseName();
 
 // Deploy XML descriptors from configBase



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Invalid message recieved with signature

2010-11-01 Thread Rainer Jung

On 01.11.2010 09:35, Weibin Yao wrote:

Hi tomcat developers,
Our tomcat_5.5.20 servers encounter a lot of error logs:

/2010-11-1 14:58:10 org.apache.coyote.ajp.AjpMessage processHeader
: Invalid message recieved with signature 13410
2010-11-1 14:58:10
org.apache.coyote.ajp.AjpAprProtocol$AjpConnectionHandler process
: Error reading request, ignored
java.lang.StringIndexOutOfBoundsException: String index out of range: 30076
at java.lang.String.checkBounds(String.java:402)
at java.lang.String.(String.java:443)
at
org.apache.tomcat.util.buf.ByteChunk.toStringInternal(ByteChunk.java:498)
at org.apache.tomcat.util.buf.StringCache.toString(StringCache.java:310)
at org.apache.tomcat.util.buf.ByteChunk.toString(ByteChunk.java:491)
at org.apache.tomcat.util.buf.MessageBytes.toString(MessageBytes.java:209)
at org.apache.coyote.RequestInfo.updateCounters(RequestInfo.java:146)
at org.apache.coyote.Request.updateCounters(Request.java:488)
at org.apache.coyote.ajp.AjpAprProcessor.process(AjpAprProcessor.java:450)
at
org.apache.coyote.ajp.AjpAprProtocol$AjpConnectionHandler.process(AjpAprProtocol.java:452)

at org.apache.tomcat.util.net.AprEndpoint$Worker.run(AprEndpoint.java:1285)
at java.lang.Thread.run(Thread.java:619)
/

We use this servers as upload servers, most of the AJP requests are POST
method. This a debug log:

/2010-11-1 14:19:33 org.apache.coyote.ajp.AjpMessage processHeader
: Invalid message recieved with signature 11565
2010-11-1 14:19:33 org.apache.coyote.ajp.AjpMessage dump
▒▒▒: In: : [...@cc5b10 4/11569
2010-11-1 14:19:33 org.apache.coyote.ajp.AjpMessage dump
▒▒▒: 2d 2d 2d 2d 02 04 00 08 48 54 54 50 2f 31 2e 30 | HTTP/1.0
2010-11-1 14:19:33 org.apache.coyote.ajp.AjpMessage dump
▒▒▒: 00 00 0a 2f 75 70 6c 6f 61 64 2e 64 6f 00 00 0c | .../upload.do...
2010-11-1 14:19:33 org.apache.coyote.ajp.AjpMessage dump
▒▒▒: 31 38 33 2e 31 37 2e 38 2e 32 30 38 00 ff ff 00 | 183.17.8.208.??.
2010-11-1 14:19:33 org.apache.coyote.ajp.AjpMessage dump
▒▒▒: 14 75 70 6c 6f 61 64 2e 70 68 6f 74 6f 2e 31 36 | .upload.photo.16
2010-11-1 14:19:33 org.apache.coyote.ajp.AjpMessage dump
▒▒▒: 33 2e 63 6f 6d 00 00 50 00 00 0d a0 0b 00 14 75 | 3.com..P...?...u
2010-11-1 14:19:33 org.apache.coyote.ajp.AjpMessage dump
▒▒▒: 70 6c 6f 61 64 2e 70 68 6f 74 6f 2e 31 36 33 2e | pload.photo.163.
2010-11-1 14:19:33 org.apache.coyote.ajp.AjpMessage dump
▒▒▒: 63 6f 6d 00 00 0f 58 2d 46 6f 72 77 61 72 64 65 | com...X-Forwarde
2010-11-1 14:19:33 org.apache.coyote.ajp.AjpMessage dump
▒▒▒: 64 2d 46 6f 72 00 00 0c 31 38 33 2e 31 37 2e 38 | d-For...183.17.8
2010-11-1 14:19:33 org.apache.coyote.ajp.AjpMessage dump
▒▒▒: 2e 32 30 38 00 00 09 58 2d 46 72 6f 6d 2d 49 50 | .208...X-From-IP
2010-11-1 14:19:33 org.apache.coyote.ajp.AjpMessage dump
▒▒▒: 00 00 0c 31 38 33 2e 31 37 2e 38 2e 32 30 38 00 | ...183.17.8.208.
2010-11-1 14:19:33 org.apache.coyote.ajp.AjpMessage dump
▒▒▒: 00 0a 58 2d 46 72 6f 6d 2d 49 53 50 00 00 01 32 | ..X-From-ISP...2
2010-11-1 14:19:33 org.apache.coyote.ajp.AjpMessage dump
▒▒▒: 00 a0 06 00 05 63 6c 6f 73 65 00 a0 0d 00 14 75 | .?...close.?...u
2010-11-1 14:19:33 org.apache.coyote.ajp.AjpMessage dump
▒▒▒: 70 6c 6f 61 64 2e 70 68 6f 74 6f 2e 31 36 33 2e | pload.photo.163.
2010-11-1 14:19:33 org.apache.coyote.ajp.AjpMessage dump
▒▒▒: 63 6f 6d 00 a0 01 00 06 74 65 78 74 2f 2a 00 a0 | com.?...text/*.?
2010-11-1 14:19:33 org.apache.coyote.ajp.AjpMessage dump
.../*

*It seems that the packet's 4 bytes in the beginning are incorrect.


Right.


Meanwhile I also captured all the TCP packets with port 8009 by tcpdump.
I found all the TCP packet's header are all fine which is beginning with
0x1234.


Very strange.


We use apache2.2.3, libapache2-mod-jk_1.2.21 and tomcat_5.5.20.
The boxes system are 2.6.18-4-686 #1 SMP Mon Mar 26 17:17:36 UTC 2007
i686 GNU/Linux.


Which exact Java version? There was a JVMbug on x86 introduced in about 
1.6.0_18 and solved in _21:


http://bugs.sun.com/view_bug.do?bug_id=6875866

In addition mod_jk improved a lot since 1.2.21, which is more than 3.5 
years oldand e.g. has security problems. Roughly the same is true for 
Apache 2.2.3 and Tomcat 5.5.20. Not saying we definitely fixed something 
that looks like the below, but before investigating it seems better to 
do updates first.


Regards,

Rainer

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 50189] AJP connector sends GET BODY CHUNK when reading after response closed

2010-11-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50189

--- Comment #1 from Rainer Jung  2010-11-01 07:42:48 
EDT ---
Thanks for the report. Which version of mod_jk and which config are you using?

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[ANN] Apache Tomcat Connectors 1.2.31 released

2010-11-01 Thread Mladen Turk

The Apache Tomcat team announces the immediate availability of
Apache Tomcat Connectors 1.2.31 stable.

Apache Tomcat Connectors 1.2.31 concentrates mainly on bug fixes.

Please refer to the change log for the list of changes:
http://tomcat.apache.org/connectors-doc/miscellaneous/changelog.html

Downloads:
http://tomcat.apache.org/download-connectors.cgi

Please note that syncing the release to the download mirrors
might take up to 48 hours.



Thank you
--
The Apache Tomcat Team

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: svn commit: r1029527 [1/2] - in /tomcat/trunk/java/org/apache/catalina: ./ connector/ core/ ha/deploy/ loader/ manager/ mbeans/ realm/ session/ startup/ util/

2010-11-01 Thread Gurkan Erdogdu
Thanks Mark!


Works as expected now.

--Gurkan


- Original Message 
From: Mark Thomas 
To: Tomcat Developers List 
Sent: Mon, November 1, 2010 1:17:24 PM
Subject: Re: svn commit: r1029527 [1/2] - in 
/tomcat/trunk/java/org/apache/catalina: ./ connector/ core/ ha/deploy/ loader/ 
manager/ mbeans/ realm/ session/ startup/ util/

On 01/11/2010 07:00, Mark Thomas wrote:
> On 01/11/2010 06:50, Gurkan Erdogdu wrote:
>> Hi;
>>
>> After this commit I am not able to deploy applications using manager
> 
> OK, I'll take a look. I did some simple tests to make sure nothing major
> was broken but I didn't test that. As a workaround, just copying the WAR
> to the webapps directory should work.

It won't. looking at it now...

Mark



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1029622 - /tomcat/jk/trunk/xdocs/index.xml

2010-11-01 Thread mturk
Author: mturk
Date: Mon Nov  1 12:32:49 2010
New Revision: 1029622

URL: http://svn.apache.org/viewvc?rev=1029622&view=rev
Log:
Fix typo

Modified:
tomcat/jk/trunk/xdocs/index.xml

Modified: tomcat/jk/trunk/xdocs/index.xml
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/xdocs/index.xml?rev=1029622&r1=1029621&r2=1029622&view=diff
==
--- tomcat/jk/trunk/xdocs/index.xml (original)
+++ tomcat/jk/trunk/xdocs/index.xml Mon Nov  1 12:32:49 2010
@@ -45,7 +45,7 @@ manual is described in more detail below
 
 
 
-1 November 
2010 - JK-1.2.31 released
+1 November 
2010 - JK-1.2.31 released
 The Apache Tomcat team is proud to announce the immediate availability
 of Tomcat Connectors 1.2.31 Stable. This release contains mainly bug fixes
 
@@ -56,7 +56,7 @@ manual is described in more detail below
 
 
 
-26 February 2010 
- JK-1.2.30 released
+26 February 2010 
- JK-1.2.30 released
 The Apache Tomcat team is proud to announce the immediate availability
 of Tomcat Connectors 1.2.30 Stable. This release contains mainly bug fixes
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1029623 - /tomcat/jk/trunk/xdocs/project.xml

2010-11-01 Thread mturk
Author: mturk
Date: Mon Nov  1 12:34:20 2010
New Revision: 1029623

URL: http://svn.apache.org/viewvc?rev=1029623&view=rev
Log:
Add missing year

Modified:
tomcat/jk/trunk/xdocs/project.xml

Modified: tomcat/jk/trunk/xdocs/project.xml
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/xdocs/project.xml?rev=1029623&r1=1029622&r2=1029623&view=diff
==
--- tomcat/jk/trunk/xdocs/project.xml (original)
+++ tomcat/jk/trunk/xdocs/project.xml Mon Nov  1 12:34:20 2010
@@ -67,6 +67,7 @@
 
 
 
+
 
 
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: svn commit: r1029622 - /tomcat/jk/trunk/xdocs/index.xml

2010-11-01 Thread Rainer Jung

On 01.11.2010 13:32, mt...@apache.org wrote:

Author: mturk
Date: Mon Nov  1 12:32:49 2010
New Revision: 1029622

URL: http://svn.apache.org/viewvc?rev=1029622&view=rev
Log:
Fix typo

Modified:
 tomcat/jk/trunk/xdocs/index.xml

Modified: tomcat/jk/trunk/xdocs/index.xml
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/xdocs/index.xml?rev=1029622&r1=1029621&r2=1029622&view=diff
==
--- tomcat/jk/trunk/xdocs/index.xml (original)
+++ tomcat/jk/trunk/xdocs/index.xml Mon Nov  1 12:32:49 2010
@@ -45,7 +45,7 @@ manual is described in more detail below
  
  
  
-1 November 2010 
-JK-1.2.31 released
+1 November 2010 
-JK-1.2.31 released


Oups.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: svn commit: r1029623 - /tomcat/jk/trunk/xdocs/project.xml

2010-11-01 Thread Rainer Jung

On 01.11.2010 13:34, mt...@apache.org wrote:

Author: mturk
Date: Mon Nov  1 12:34:20 2010
New Revision: 1029623

URL: http://svn.apache.org/viewvc?rev=1029623&view=rev
Log:
Add missing year

Modified:
 tomcat/jk/trunk/xdocs/project.xml

Modified: tomcat/jk/trunk/xdocs/project.xml
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/xdocs/project.xml?rev=1029623&r1=1029622&r2=1029623&view=diff
==
--- tomcat/jk/trunk/xdocs/project.xml (original)
+++ tomcat/jk/trunk/xdocs/project.xml Mon Nov  1 12:34:20 2010
@@ -67,6 +67,7 @@
  

  
+
  
  
  


I think there's another project.xml in every subdir...

Regards,

Rainer

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1029653 - /tomcat/jk/trunk/xdocs/index.xml

2010-11-01 Thread rjung
Author: rjung
Date: Mon Nov  1 13:41:51 2010
New Revision: 1029653

URL: http://svn.apache.org/viewvc?rev=1029653&view=rev
Log:
Fix links and copy&paste error in headline.

Modified:
tomcat/jk/trunk/xdocs/index.xml

Modified: tomcat/jk/trunk/xdocs/index.xml
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/xdocs/index.xml?rev=1029653&r1=1029652&r2=1029653&view=diff
==
--- tomcat/jk/trunk/xdocs/index.xml (original)
+++ tomcat/jk/trunk/xdocs/index.xml Mon Nov  1 13:41:51 2010
@@ -45,7 +45,7 @@ manual is described in more detail below
 
 
 
-1 November 
2010 - JK-1.2.31 released
+1 November 
2010 - JK-1.2.31 released
 The Apache Tomcat team is proud to announce the immediate availability
 of Tomcat Connectors 1.2.31 Stable. This release contains mainly bug fixes
 
@@ -56,7 +56,7 @@ manual is described in more detail below
 
 
 
-26 February 2010 
- JK-1.2.30 released
+1 March 2010 - 
JK-1.2.30 released
 The Apache Tomcat team is proud to announce the immediate availability
 of Tomcat Connectors 1.2.30 Stable. This release contains mainly bug fixes
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1029654 - in /tomcat/jk/trunk/xdocs: ajp/project.xml generic_howto/project.xml miscellaneous/project.xml reference/project.xml webserver_howto/project.xml

2010-11-01 Thread rjung
Author: rjung
Date: Mon Nov  1 13:44:58 2010
New Revision: 1029654

URL: http://svn.apache.org/viewvc?rev=1029654&view=rev
Log:
Add 2010 news to all menues.

Modified:
tomcat/jk/trunk/xdocs/ajp/project.xml
tomcat/jk/trunk/xdocs/generic_howto/project.xml
tomcat/jk/trunk/xdocs/miscellaneous/project.xml
tomcat/jk/trunk/xdocs/reference/project.xml
tomcat/jk/trunk/xdocs/webserver_howto/project.xml

Modified: tomcat/jk/trunk/xdocs/ajp/project.xml
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/xdocs/ajp/project.xml?rev=1029654&r1=1029653&r2=1029654&view=diff
==
--- tomcat/jk/trunk/xdocs/ajp/project.xml (original)
+++ tomcat/jk/trunk/xdocs/ajp/project.xml Mon Nov  1 13:44:58 2010
@@ -67,6 +67,7 @@
 
 
 
+
 
 
 

Modified: tomcat/jk/trunk/xdocs/generic_howto/project.xml
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/xdocs/generic_howto/project.xml?rev=1029654&r1=1029653&r2=1029654&view=diff
==
--- tomcat/jk/trunk/xdocs/generic_howto/project.xml (original)
+++ tomcat/jk/trunk/xdocs/generic_howto/project.xml Mon Nov  1 13:44:58 2010
@@ -67,6 +67,7 @@
 
 
 
+
 
 
 

Modified: tomcat/jk/trunk/xdocs/miscellaneous/project.xml
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/xdocs/miscellaneous/project.xml?rev=1029654&r1=1029653&r2=1029654&view=diff
==
--- tomcat/jk/trunk/xdocs/miscellaneous/project.xml (original)
+++ tomcat/jk/trunk/xdocs/miscellaneous/project.xml Mon Nov  1 13:44:58 2010
@@ -67,6 +67,7 @@
 
 
 
+
 
 
 

Modified: tomcat/jk/trunk/xdocs/reference/project.xml
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/xdocs/reference/project.xml?rev=1029654&r1=1029653&r2=1029654&view=diff
==
--- tomcat/jk/trunk/xdocs/reference/project.xml (original)
+++ tomcat/jk/trunk/xdocs/reference/project.xml Mon Nov  1 13:44:58 2010
@@ -67,6 +67,7 @@
 
 
 
+
 
 
 

Modified: tomcat/jk/trunk/xdocs/webserver_howto/project.xml
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/xdocs/webserver_howto/project.xml?rev=1029654&r1=1029653&r2=1029654&view=diff
==
--- tomcat/jk/trunk/xdocs/webserver_howto/project.xml (original)
+++ tomcat/jk/trunk/xdocs/webserver_howto/project.xml Mon Nov  1 13:44:58 2010
@@ -67,6 +67,7 @@
 
 
 
+
 
 
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: svn commit: r1029623 - /tomcat/jk/trunk/xdocs/project.xml

2010-11-01 Thread Rainer Jung

Fixed this and the index.xml typo in svn and on live.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: svn commit: r1029423 - in /tomcat: tc5.5.x/trunk/STATUS.txt tc6.0.x/trunk/STATUS.txt

2010-11-01 Thread William A. Rowe Jr.
On 11/1/2010 5:58 AM, Mark Thomas wrote:
> On 01/11/2010 06:43, Konstantin Kolinko wrote:
>> 2010/11/1 Mark Thomas :
>>> On 31/10/2010 13:13, kkoli...@apache.org wrote:
 Modified: tomcat/tc6.0.x/trunk/STATUS.txt
 --- tomcat/tc6.0.x/trunk/STATUS.txt (original)
 +++ tomcat/tc6.0.x/trunk/STATUS.txt Sun Oct 31 17:13:51 2010
 @@ -230,12 +230,14 @@ PATCHES PROPOSED TO BACKPORT:
Allow 32-bit and 64-bit JDKs to be selected on 64-bit platforms
http://svn.apache.org/viewvc?rev=1027504&view=rev
+1: markt, mturk
 -  -1:
 +  -1: kkolinko: The function checkJava spawns a .bat file
 +   (ExecWait '"$R0.bat"'). It is visible as a flickering black window
 +   when I go from JRE selection page to the next page in TC7 installer.
 kkolinko: merging r1027504 does not perform cleanly
>>>
>>> The not merging cleanly I can fix when I get a moment. The briefly
>>> displayed command window is trickier. I don't know if it can be hidden.
>>> I certainly see it happen reasonably frequently when I install all sorts
>>> of Windows software. At the moment, I view it as a necessary evil for
>>> being able to support installing to 32-bit JVMs on 64-bit platforms.
>>>
>>> If Garrett (the MS open source guy) is at ApacheCon I'll try and pester
>>> him to see if there is a better way (e.g. looking for a magic number in
>>> a .exe or .dll). If anyone has any better ideas please speak up.

Some of this lives in apr_thread_proc.c for win32 in apr.  Will be happy
to offer pointers when I arrive.

>> Some thoughts:
>>
>> 1. We do not need this check at all on a 32-bit OS.
> 
> Yep. Should be possible to avoid this check on a 32-bit OS.

I wouldn't, some people will pre-stage things on a 32 bit machine to prepare
for mass copy to 64 bits.  Odd edge case but one to consider.

>> 3. I found the following:
>> [1] http://msdn.microsoft.com/en-us/library/ms973190.aspx
>> mentions System.Reflection.Module.GetPEKind
> 
> That requires .NET and not every machine has installed the .NET runtime.
> I don't want to make having .NET a pre-requisite for a correctly
> operating installer.

Hmmm, I believe every now-current version does have some minimum level of both
vbscript, wsh script and .net.

There is a way to do this in C that is pretty straightforward.  The choice
could easily be propagated to the microsoft system installer (MSI), but you
do get into the scenario where both JVMs are installed on a machine.
Fortunately these are not side by side as on solaris and similar.



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [ANN] Apache Tomcat Connectors 1.2.31 released

2010-11-01 Thread Christopher Schultz
Mladen,

On 11/1/2010 7:43 AM, Mladen Turk wrote:
> The Apache Tomcat team announces the immediate availability of
> Apache Tomcat Connectors 1.2.31 stable.

You bastards. I just got done with 5 days of round-the-clock connector
performance testing.

Can't you guys work any slower?!

;)

-chris



signature.asc
Description: OpenPGP digital signature


Re: [ANN] Apache Tomcat Connectors 1.2.31 released

2010-11-01 Thread Rainer Jung

On 01.11.2010 15:32, Christopher Schultz wrote:

Mladen,

On 11/1/2010 7:43 AM, Mladen Turk wrote:

The Apache Tomcat team announces the immediate availability of
Apache Tomcat Connectors 1.2.31 stable.


You bastards. I just got done with 5 days of round-the-clock connector
performance testing.

Can't you guys work any slower?!


I'm sure you automted all tests :-P

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 49819] Improved index.html for default ROOT application

2010-11-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49819

--- Comment #20 from Tim Funk  2010-11-01 11:10:11 EDT ---
fyi ... I am looking to apply this today

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 49819] Improved index.html for default ROOT application

2010-11-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49819

Tim Funk  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #21 from Tim Funk  2010-11-01 11:33:26 EDT ---
thanks .. change applied via revision 1029708

Changes made to attached index.jsp
- 404's fixed
- Some other urls made more exact
- Used EL for many of the urls (helpful in case the domain changes or doc
prefix changes)
- Used EL for the YEAR

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1029719 - /tomcat/trunk/java/org/apache/juli/FileHandler.java

2010-11-01 Thread funkman
Author: funkman
Date: Mon Nov  1 15:48:32 2010
New Revision: 1029719

URL: http://svn.apache.org/viewvc?rev=1029719&view=rev
Log:
bug 49180

Add option to disable log rotation in FileHandler
credit: Pid (pidster at apache )


Modified:
tomcat/trunk/java/org/apache/juli/FileHandler.java

Modified: tomcat/trunk/java/org/apache/juli/FileHandler.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/juli/FileHandler.java?rev=1029719&r1=1029718&r2=1029719&view=diff
==
--- tomcat/trunk/java/org/apache/juli/FileHandler.java (original)
+++ tomcat/trunk/java/org/apache/juli/FileHandler.java Mon Nov  1 15:48:32 2010
@@ -95,6 +95,12 @@ public class FileHandler
 
 
 /**
+ * Determines whether the logfile is rotatable
+ */
+private boolean rotatable = true;
+
+
+/**
  * The PrintWriter to which we are currently logging, if any.
  */
 private volatile PrintWriter writer = null;
@@ -134,7 +140,7 @@ public class FileHandler
 
 writerLock.readLock().lock();
 // If the date has changed, switch log files
-if (!date.equals(tsDate)) {
+if (rotatable && !date.equals(tsDate)) {
 // Update to writeLock before we switch
 writerLock.readLock().unlock();
 writerLock.writeLock().lock();
@@ -245,6 +251,7 @@ public class FileHandler
 ClassLoader cl = Thread.currentThread().getContextClassLoader();
 
 // Retrieve configuration of logging file name
+rotatable = Boolean.parseBoolean(getProperty(className + ".rotatable", 
"true"));
 if (directory == null)
 directory = getProperty(className + ".directory", "logs");
 if (prefix == null)
@@ -326,7 +333,7 @@ public class FileHandler
 writerLock.writeLock().lock();
 try {
 String pathname = dir.getAbsolutePath() + File.separator +
-prefix + date + suffix;
+prefix + (rotatable ? date : "") + suffix;
 String encoding = getEncoding();
 FileOutputStream fos = new FileOutputStream(pathname, true);
 OutputStream os = bufferSize>0?new 
BufferedOutputStream(fos,bufferSize):fos;



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1029720 - /tomcat/trunk/webapps/docs/changelog.xml

2010-11-01 Thread funkman
Author: funkman
Date: Mon Nov  1 15:53:22 2010
New Revision: 1029720

URL: http://svn.apache.org/viewvc?rev=1029720&view=rev
Log:
changelog update

Modified:
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1029720&r1=1029719&r2=1029720&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Mon Nov  1 15:53:22 2010
@@ -83,6 +83,10 @@
 default, the existing Tomcat 6.0.x welcome file handling is used.
 (markt)
   
+  
+49180: Add option to disable log rotation in 
+juli FileHandler. credit: Pid (pidster at apache )
+  
 
   
   
@@ -165,6 +169,9 @@
 be installed. If a 64-bit JDK is selected, the 64-bit service wrapper
 and the 64-bit native DLL will be installed. (markt)
   
+  
+49819: redesign of home page by Pid (pidster at apache )
+  
 
   
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 49180] Add option to disable log rotation in FileHandler.

2010-11-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49180

Tim Funk  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #2 from Tim Funk  2010-11-01 11:54:56 EDT ---
applied change via http://svn.apache.org/viewvc?rev=1029719&view=rev

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 49126] jasper.compiler.Generator.createJspId() can generate negative number

2010-11-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49126

Tim Funk  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID

--- Comment #2 from Tim Funk  2010-11-01 12:18:34 EDT ---
If I read this correctly createJspId [private] is used by setJspId and the docs
for JspIdConsumer.html#setJspId(java.lang.String) allow for '-' in the id as
long as it isn't first. So a - in the middle is OK. 

http://download.oracle.com/javaee/5/api/javax/servlet/jsp/tagext/JspIdConsumer.html#setJspId(java.lang.String)

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1029755 - in /tomcat/trunk: java/org/apache/catalina/mbeans/MBeanUtils.java java/org/apache/catalina/valves/ValveBase.java webapps/docs/changelog.xml

2010-11-01 Thread markt
Author: markt
Date: Mon Nov  1 17:22:33 2010
New Revision: 1029755

URL: http://svn.apache.org/viewvc?rev=1029755&view=rev
Log:
Make Tomcat more tolerant of nulls when generating JMX names for Valves.

Modified:
tomcat/trunk/java/org/apache/catalina/mbeans/MBeanUtils.java
tomcat/trunk/java/org/apache/catalina/valves/ValveBase.java
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/catalina/mbeans/MBeanUtils.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/mbeans/MBeanUtils.java?rev=1029755&r1=1029754&r2=1029755&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/mbeans/MBeanUtils.java (original)
+++ tomcat/trunk/java/org/apache/catalina/mbeans/MBeanUtils.java Mon Nov  1 
17:22:33 2010
@@ -1690,7 +1690,7 @@ public class MBeanUtils {
 
 Container c = container;
 StringBuilder keyProperties = new StringBuilder();
-int unknown = 0;
+int containerCount = 0;
 
 // Work up container hierarchy, add a component to the name for
 // each container
@@ -1708,10 +1708,16 @@ public class MBeanUtils {
 } else if (c instanceof Host) {
 keyProperties.append(",host=");
 keyProperties.append(c.getName());
+} else if (c == null) {
+// May happen in unit testing and/or some embedding scenarios
+keyProperties.append(",container");
+keyProperties.append(containerCount++);
+keyProperties.append("=null");
+break;
 } else {
 // Should never happen...
-keyProperties.append(",unknown");
-keyProperties.append(unknown++);
+keyProperties.append(",container");
+keyProperties.append(containerCount++);
 keyProperties.append('=');
 keyProperties.append(c.getName());
 }

Modified: tomcat/trunk/java/org/apache/catalina/valves/ValveBase.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/ValveBase.java?rev=1029755&r1=1029754&r2=1029755&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/valves/ValveBase.java (original)
+++ tomcat/trunk/java/org/apache/catalina/valves/ValveBase.java Mon Nov  1 
17:22:33 2010
@@ -27,6 +27,7 @@ import org.apache.catalina.Contained;
 import org.apache.catalina.Container;
 import org.apache.catalina.LifecycleException;
 import org.apache.catalina.LifecycleState;
+import org.apache.catalina.Pipeline;
 import org.apache.catalina.Valve;
 import org.apache.catalina.comet.CometEvent;
 import org.apache.catalina.connector.Request;
@@ -289,19 +290,24 @@ public abstract class ValveBase extends 
 name.append(MBeanUtils.getContainerKeyProperties(container));
 
 int seq = 0;
-for (Valve valve : container.getPipeline().getValves()) {
-// Skip null valves
-if (valve == null) {
-continue;
-}
-// Only compare valves in pipeline until we find this valve
-if (valve == this) {
-break;
-}
-if (valve.getClass() == this.getClass()) {
-// Duplicate valve earlier in pipeline
-// increment sequence number
-seq ++;
+
+// Pipeline may not be present in unit testing
+Pipeline p = container.getPipeline();
+if (p != null) {
+for (Valve valve : p.getValves()) {
+// Skip null valves
+if (valve == null) {
+continue;
+}
+// Only compare valves in pipeline until we find this valve
+if (valve == this) {
+break;
+}
+if (valve.getClass() == this.getClass()) {
+// Duplicate valve earlier in pipeline
+// increment sequence number
+seq ++;
+}
 }
 }
 

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1029755&r1=1029754&r2=1029755&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Mon Nov  1 17:22:33 2010
@@ -87,6 +87,10 @@
 49180: Add option to disable log rotation in 
 juli FileHandler. credit: Pid (pidster at apache )
   
+  
+Make Tomcat more tolerant of null when generating JMX 
names
+for Valves. (markt)
+  
 
   
   



-
To unsubscribe, e-mail: dev-un

svn commit: r1029767 - /tomcat/trunk/java/org/apache/catalina/core/StandardEngine.java

2010-11-01 Thread markt
Author: markt
Date: Mon Nov  1 17:51:19 2010
New Revision: 1029767

URL: http://svn.apache.org/viewvc?rev=1029767&view=rev
Log:
Review comment from kkolinko
Make sure we initialize StandardEngine.accessLog

Modified:
tomcat/trunk/java/org/apache/catalina/core/StandardEngine.java

Modified: tomcat/trunk/java/org/apache/catalina/core/StandardEngine.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/StandardEngine.java?rev=1029767&r1=1029766&r2=1029767&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/StandardEngine.java (original)
+++ tomcat/trunk/java/org/apache/catalina/core/StandardEngine.java Mon Nov  1 
17:51:19 2010
@@ -307,7 +307,7 @@ public class StandardEngine extends Cont
 
 boolean logged = false;
 
-if (accessLog != null) {
+if (getAccessLog() != null) {
 accessLog.log(request, response, time);
 logged = true;
 }



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1029770 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-11-01 Thread markt
Author: markt
Date: Mon Nov  1 17:57:49 2010
New Revision: 1029770

URL: http://svn.apache.org/viewvc?rev=1029770&view=rev
Log:
Respond to review comments

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1029770&r1=1029769&r2=1029770&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Mon Nov  1 17:57:49 2010
@@ -109,11 +109,20 @@ PATCHES PROPOSED TO BACKPORT:
   kkolinko (Re: rjung): I understand that it is intended: It is logged in all
   parents, but not in the siblings (because passing 'false' as useDefault
   argument when calling getParent().logAccess(..)).
+  
+  markt (Re: rjung): It is done this way to maintain default behaviour. If you
+  define an AccessLog for a Host and an Engine, requests to the Host will be
+  logged in both. The logged flag is used to determine if we need to try and
+  find a default logger to ensure the request is logged somewhere.
 
   kkolinko: I do not quite understand why CoyoteAdapter.log() recycles
   request and response even if it did not create them, but I do not see
   valid reasons why it should not. Access logging occurs once request
   processing is completed, so it seems valid to recycle them at that point.
+  
+  markt (Re: kkolinko): CoyoteAdapter.log() recycles the request and response
+  since it may get called without a call to CoyoteAdapter.service() and it was
+  easier to always recycle than to figure out if a recycle was required or not.
 
 
 * Backport the CSRF prevention filter to Tomcat 6 and configure the Manager and



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 50192] New: performance issue after revision 746425

2010-11-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50192

   Summary: performance issue after revision 746425
   Product: Tomcat 7
   Version: trunk
  Platform: PC
OS/Version: Windows XP
Status: NEW
  Severity: normal
  Priority: P2
 Component: Jasper
AssignedTo: dev@tomcat.apache.org
ReportedBy: robert_goff...@yahoo.com


Revision 746425 changed at least 2 files: ELResolverImpl and ELContextImpl.  I
believe this causes an unnecessary performance regression in these two files.

In ELResolverImpl, every time that getDefaultResolver is called with security
enabled, a new Object is going to be created.  It appears as if
getDefaultResolver is going to be called a lot and this could significantly
hurt performance.  I understand changing the DefaultResolver to be private and
allowing access to it through the getter method, however, I don't believe a new
object needs to be created every time the method is called.

In ELContextImpl, why does a new FunctionMapper need to be created for each
ELContextImpl?

Thanks.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: DO NOT REPLY [Bug 49819] Improved index.html for default ROOT application

2010-11-01 Thread Pid
On 01/11/2010 15:33, bugzi...@apache.org wrote:
> https://issues.apache.org/bugzilla/show_bug.cgi?id=49819
> 
> Tim Funk  changed:
> 
>What|Removed |Added
> 
>  Status|NEW |RESOLVED
>  Resolution||FIXED
> 
> --- Comment #21 from Tim Funk  2010-11-01 11:33:26 EDT ---
> thanks .. change applied via revision 1029708
> 
> Changes made to attached index.jsp
> - 404's fixed
> - Some other urls made more exact
> - Used EL for many of the urls (helpful in case the domain changes or doc
> prefix changes)
> - Used EL for the YEAR
> 

Cool. :)


p


0x62590808.asc
Description: application/pgp-keys


signature.asc
Description: OpenPGP digital signature


DO NOT REPLY [Bug 49295] JMXAccessorTask.getProperties() - return Properties not Map?

2010-11-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49295

Tim Funk  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID

--- Comment #1 from Tim Funk  2010-11-01 17:30:59 EDT ---
Properties implements Map,  also a Hashtable may alternately be returned. But
since the public API returns map - there is no problem.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 49317] org.apache.catalina.util.Base64 interface needs refactoring

2010-11-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49317

Tim Funk  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WONTFIX

--- Comment #2 from Tim Funk  2010-11-01 17:34:00 EDT ---
Since this is internal for tomcat only - I am marking as WONTFIX since it is
change without any functional need.

If a webapp needs a Base64 util class, there are many other public
implementations.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 49318] add a Negotiate (Kerberos/NTLM) authenticator / integrate Waffle

2010-11-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49318

--- Comment #1 from Tim Funk  2010-11-01 17:39:08 EDT ---
Cannot find the code based on the link below.

Perhaps the first step is documenting this in the Tomcat wiki first on how to
use this for those who wish to try this on their own.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 50175] Enhance memory leak detection by selectively applying methods,

2010-11-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50175

--- Comment #3 from Pid  2010-11-01 17:52:38 EDT ---
(In reply to comment #2)
> What is the final purpose ? speedup the shutdown process or avoid warnings
> about potential leaks when shutting down ?

A bit of both, a User list discussion prompted this.
Some of the leak detection/prevention methods aren't a concern if the JVM is
shutting down, but after some thought I'm in two minds about it.

> Regarding the patch, we also have to take into account the fact that tomcat 
> can
> be embedded, and I don't know if org.apache.catalina.startup.Catalina.stop() 
> is
> being called only in non-embedded mode.

Fair point. I don't think the patch is complete, I need to think about it more.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 50168] destory method is called twice while the child is destoryed directly

2010-11-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50168

Tim Funk  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID

--- Comment #1 from Tim Funk  2010-11-01 18:08:06 EDT ---
When StandardContext is destroyed is destroys assets is manages which also have
their own lifecycle. So you might be seeing those log messages. (Most likely
StandardManager)

Please reopen with more proof if this diagnosis is wrong.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 50194] New: ELParsing fails when an expression with function contains a dash (minus) on 6.0.2.20 and up

2010-11-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50194

   Summary: ELParsing fails when an expression with function
contains a dash (minus) on 6.0.2.20 and up
   Product: Tomcat 6
   Version: 6.0.20
  Platform: PC
OS/Version: Windows XP
Status: NEW
  Severity: regression
  Priority: P2
 Component: Jasper
AssignedTo: dev@tomcat.apache.org
ReportedBy: jsarto...@hotmail.com


Hello,
There is possibly a regression in the ELParser code on Tomcat 6.0.2.20.  The
issue I see works fine on Tomcat 6.0.2.18. 
I've also tried on Tomcat 6.0.2.29 and it is still failing.

A JSF application which uses Facelets (with .xhtml files) and a custom tag
which contains an expression with a function call starts to fail in Tomcat
6.0.2.20.  

The code snippet from the app is:
--
http://www.w3.org/1999/xhtml";
xmlns:ui="http://java.sun.com/jsf/facelets";
xmlns:h="http://java.sun.com/jsf/html";
xmlns:f="http://java.sun.com/jsf/core";
xmlns:pre-posttag="http://www.test.com/dash";>




-

The exception thrown is (See caused by section):

Throwable occurred: com.sun.facelets.tag.TagAttributeException: /test.xhtml
@20,63 rendered="#{pre-posttag:test()}" Function 'posttag:test' not found
at com.sun.facelets.tag.TagAttribute.getValueExpression(TagAttribute.java:259)
at
com.sun.facelets.tag.jsf.ComponentRule$ValueExpressionMetadata.applyMetadata(ComponentRule.java:69)
at com.sun.facelets.tag.MetadataImpl.applyMetadata(MetadataImpl.java:36)
.

Caused by: javax.el.ELException: Function 'posttag:test' not found
at org.apache.el.lang.ExpressionBuilder.visit(ExpressionBuilder.java:175)
at org.apache.el.parser.SimpleNode.accept(SimpleNode.java:145)
at org.apache.el.parser.SimpleNode.accept(SimpleNode.java:148)
at org.apache.el.lang.ExpressionBuilder.prepare(ExpressionBuilder.java:133)
at org.apache.el.lang.ExpressionBuilder.build(ExpressionBuilder.java:151)
at
org.apache.el.lang.ExpressionBuilder.createValueExpression(ExpressionBuilder.java:194)
at
org.apache.el.ExpressionFactoryImpl.createValueExpression(ExpressionFactoryImpl.java:68)
at com.sun.facelets.tag.TagAttribute.getValueExpression(TagAttribute.java:256)
... 35 more


I've been narrowing the problem down but I cannot find the appropriate way to
fix this as it's generated code.  The issue appears to be caused by the changes
made to the code in this revision:

http://svn.apache.org/viewvc?view=revision&revision=681737

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 50194] ELParsing fails when an expression with function contains a dash (minus) on 6.0.2.20 and up

2010-11-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50194

--- Comment #1 from Jay S  2010-11-01 18:25:14 EDT ---
Sorry, meant to add more description.  The issue appears to be in the parsing
of the expression,  the dash in the namespace for the tag is now causing a
problem.  As you can see in the exception, which states:
Function 'posttag:test' not found

the "pre-" is missing.  I've been trying to debug the code, but it's been very
difficult to debug since it's generated code.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 50189] AJP connector sends GET BODY CHUNK when reading after response closed

2010-11-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50189

--- Comment #2 from James Roper  2010-11-01 20:18:23 EDT ---
The version of mod_jk is 1.2.28 on CentOS 5.4.

If you are unable to reproduce this issue, let me know and I'll do more
investigations to reproduce it on my side, I'll see if I can reproduce it on
later versions of Tomcat and I'll attach tcpdump logs etc.  I haven't done that
yet because the only logs and environment that I have handy are a production
environment, and the logs contain sensitive information, but I'm hoping my
description so far is adequate.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 50168] destory method is called twice while the child is destoryed directly

2010-11-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50168

Pid  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|INVALID |

--- Comment #2 from Pid  2010-11-01 20:42:06 EDT ---
(In reply to comment #1)
> When StandardContext is destroyed is destroys assets is manages which also 
> have
> their own lifecycle. So you might be seeing those log messages. (Most likely
> StandardManager)
> 
> Please reopen with more proof if this diagnosis is wrong.

I'm also seeing this on undeploying any app via the Manager application.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 49511] IIS 7.5 incorrect logging: pfc->pFilterContext is per-connection not per-request

2010-11-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49511

Tim Whittington  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[g...@vmgump]: Project tomcat-taglibs-standard (in module tomcat-taglibs) failed

2010-11-01 Thread Gump
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-taglibs-standard has an issue affecting its community 
integration.
This issue affects 2 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-taglibs-standard :  Standard Taglib
- tomcat-taglibs-standard-install :  JSP Taglibs


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-taglibs/tomcat-taglibs-standard/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -INFO- Optional dependency httpunit failed with reason build failed
 -DEBUG- (Gump generated) Maven2 Settings in: 
/srv/gump/public/workspace/tomcat-taglibs/standard/gump_mvn_settings.xml
 -INFO- Failed with reason build failed
 -DEBUG- Maven POM in: 
/srv/gump/public/workspace/tomcat-taglibs/standard/pom.xml
 -DEBUG- Extracted fallback artifacts from Gump Repository



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-taglibs/tomcat-taglibs-standard/gump_work/build_tomcat-taglibs_tomcat-taglibs-standard.html
Work Name: build_tomcat-taglibs_tomcat-taglibs-standard (Type: Build)
Work ended in a state of : Failed
Elapsed: 19 secs
Command Line: mvn --batch-mode -DskipTests=true --settings 
/srv/gump/public/workspace/tomcat-taglibs/standard/gump_mvn_settings.xml 
package 
[Working Directory: /srv/gump/public/workspace/tomcat-taglibs/standard]
-
[INFO] Compiling 7 source files to 
/srv/gump/public/workspace/tomcat-taglibs/standard/impl/target/test-classes
[INFO] [surefire:test {execution: default-test}]
[INFO] Tests are skipped.
[INFO] [bundle:bundle {execution: default-bundle}]
[INFO] 
[INFO] Building Apache Standard Taglib - JSTL 1.0 Compatibility
[INFO]task-segment: [package]
[INFO] 
[INFO] [remote-resources:process {execution: default}]
[INFO] snapshot org.apache.taglibs:taglibs-standard-impl:1.2-SNAPSHOT: checking 
for updates from apache.snapshots
Downloading: 
http://localhost:8192/repo/m2-snapshot-repository/org/apache/taglibs/taglibs-standard-impl/1.2-SNAPSHOT/taglibs-standard-impl-1.2-SNAPSHOT.jar
[INFO] Unable to find resource 
'org.apache.taglibs:taglibs-standard-impl:jar:1.2-SNAPSHOT' in repository 
apache.snapshots (http://repository.apache.org/snapshots)
[INFO] 
[ERROR] BUILD ERROR
[INFO] 
[INFO] Failed to resolve dependencies for one or more projects in the reactor. 
Reason: Missing:
--
1) org.apache.taglibs:taglibs-standard-impl:jar:1.2-SNAPSHOT

  Try downloading the file manually from the project website.

  Then, install it using the command: 
  mvn install:install-file -DgroupId=org.apache.taglibs 
-DartifactId=taglibs-standard-impl -Dversion=1.2-SNAPSHOT -Dpackaging=jar 
-Dfile=/path/to/file

  Alternatively, if you host your own repository you can deploy the file there: 
  mvn deploy:deploy-file -DgroupId=org.apache.taglibs 
-DartifactId=taglibs-standard-impl -Dversion=1.2-SNAPSHOT -Dpackaging=jar 
-Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id]

  Path to dependency: 
1) org.apache.taglibs:taglibs-standard-compat:bundle:1.2-SNAPSHOT
2) org.apache.taglibs:taglibs-standard-impl:jar:1.2-SNAPSHOT

--
1 required artifact is missing.

for artifact: 
  org.apache.taglibs:taglibs-standard-compat:bundle:1.2-SNAPSHOT

from the specified remote repositories:
  gump-central (http://localhost:8192/maven2),
  gump-apache.snapshots (http://localhost:8192/repo/m2-snapshot-repository)



[INFO] 
[INFO] For more information, run Maven with the -e switch
[INFO] 
[INFO] Total time: 18 seconds
[INFO] Finished at: Tue Nov 02 01:33:49 UTC 2010
[INFO] Final Memory: 40M/97M
[INFO] 
-

To subscribe to this information via syndicated feeds:
- RSS: 
http://vmgump.apache.org/gump/public/tomcat-taglibs/tomcat-taglibs-standard/rss.xml
- Atom: 
http://vmgump.apache.org/gump/public/tomcat-taglibs/tomcat-taglibs-standard/atom.xml

== Gump Tracking Only ===
Produced by Gump version 2.3.
Gump Run 29001201112010, vmgump.apache.org:vmgump:29001201112010
Gump E-mail Identifier (unique within run) #4.

--
Apache Gum

DO NOT REPLY [Bug 50168] destory method is called twice while the child is destoryed directly

2010-11-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50168

--- Comment #3 from Ivan  2010-11-01 22:08:52 EDT ---
(In reply to comment #1)
> When StandardContext is destroyed is destroys assets is manages which also 
> have
> their own lifecycle. So you might be seeing those log messages. (Most likely
> StandardManager)
> 
> Please reopen with more proof if this diagnosis is wrong.

Not sure I understand your comments clearly. From the stack trace, while
destorying the standcontext directly, it will check check whether its parent is
null, if not, it will call the parent.removeChild() method, but removeChild
method also try to destory the child. (As it does not known who calls the
method).
I will reopen the it, and try to attach a patch file.
thanks.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 50168] destory method is called twice while the child is destoryed directly

2010-11-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50168

--- Comment #4 from Ivan  2010-11-01 22:11:16 EDT ---
Created an attachment (id=26248)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26248)
Simple patch

Try to provide a patch for it. Might not be proper, but it should be helpful to
find what happens.
Exception for the issue about double destory invocation, also, seems that
Mapper.unregister action occurs before its  internal destory (e.g. remove
welcome resources).

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [taglibs] [Bug 50064] bundle-ify the taglibs jars

2010-11-01 Thread Rex Wang
Thanks Jeremy,

Is that because the group id dose not start with org.apache.tomcat...?

2010/11/1 Jeremy Boynes 

> Patch applied but unable to deploy to the snapshot repository.
> I don't see an entry for taglibs in Nexus so opening a issue with them to
> get us created.
>
> On Oct 31, 2010, at 11:26 AM, bugzi...@apache.org wrote:
>
> > https://issues.apache.org/bugzilla/show_bug.cgi?id=50064
> >
> > --- Comment #7 from Jeremy Boynes  2010-10-31
> 14:26:45 EDT ---
> > Patches applied, thanks.
> >
> > --
> > Configure bugmail:
> https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
> > --- You are receiving this mail because: ---
> > You are the assignee for the bug.
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> > For additional commands, e-mail: dev-h...@tomcat.apache.org
> >
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


-- 
Lei Wang (Rex)
rwonly AT apache.org


Re: [g...@vmgump]: Project tomcat-taglibs-standard (in module tomcat-taglibs) failed

2010-11-01 Thread Jeremy Boynes
This started failing with r1029387. If I remove the 
bundle from the spec module then the reactor starts 
resolving it again. Could this be something with the bundle plugin not working 
with the package goal?

I'm going to revert the bundle packaging until we can resolve this.

On Nov 1, 2010, at 6:33 PM, Gump wrote:

> To whom it may engage...
> 
> This is an automated request, but not an unsolicited one. For 
> more information please visit http://gump.apache.org/nagged.html, 
> and/or contact the folk at gene...@gump.apache.org.
> 
> Project tomcat-taglibs-standard has an issue affecting its community 
> integration.
> This issue affects 2 projects.
> The current state of this project is 'Failed', with reason 'Build Failed'.
> For reference only, the following projects are affected by this:
>- tomcat-taglibs-standard :  Standard Taglib
>- tomcat-taglibs-standard-install :  JSP Taglibs
> 
> 
> Full details are available at:
>
> http://vmgump.apache.org/gump/public/tomcat-taglibs/tomcat-taglibs-standard/index.html
> 
> That said, some information snippets are provided here.
> 
> The following annotations (debug/informational/warning/error messages) were 
> provided:
> -INFO- Optional dependency httpunit failed with reason build failed
> -DEBUG- (Gump generated) Maven2 Settings in: 
> /srv/gump/public/workspace/tomcat-taglibs/standard/gump_mvn_settings.xml
> -INFO- Failed with reason build failed
> -DEBUG- Maven POM in: 
> /srv/gump/public/workspace/tomcat-taglibs/standard/pom.xml
> -DEBUG- Extracted fallback artifacts from Gump Repository
> 
> 
> 
> The following work was performed:
> http://vmgump.apache.org/gump/public/tomcat-taglibs/tomcat-taglibs-standard/gump_work/build_tomcat-taglibs_tomcat-taglibs-standard.html
> Work Name: build_tomcat-taglibs_tomcat-taglibs-standard (Type: Build)
> Work ended in a state of : Failed
> Elapsed: 19 secs
> Command Line: mvn --batch-mode -DskipTests=true --settings 
> /srv/gump/public/workspace/tomcat-taglibs/standard/gump_mvn_settings.xml 
> package 
> [Working Directory: /srv/gump/public/workspace/tomcat-taglibs/standard]
> -
> [INFO] Compiling 7 source files to 
> /srv/gump/public/workspace/tomcat-taglibs/standard/impl/target/test-classes
> [INFO] [surefire:test {execution: default-test}]
> [INFO] Tests are skipped.
> [INFO] [bundle:bundle {execution: default-bundle}]
> [INFO] 
> 
> [INFO] Building Apache Standard Taglib - JSTL 1.0 Compatibility
> [INFO]task-segment: [package]
> [INFO] 
> 
> [INFO] [remote-resources:process {execution: default}]
> [INFO] snapshot org.apache.taglibs:taglibs-standard-impl:1.2-SNAPSHOT: 
> checking for updates from apache.snapshots
> Downloading: 
> http://localhost:8192/repo/m2-snapshot-repository/org/apache/taglibs/taglibs-standard-impl/1.2-SNAPSHOT/taglibs-standard-impl-1.2-SNAPSHOT.jar
> [INFO] Unable to find resource 
> 'org.apache.taglibs:taglibs-standard-impl:jar:1.2-SNAPSHOT' in repository 
> apache.snapshots (http://repository.apache.org/snapshots)
> [INFO] 
> 
> [ERROR] BUILD ERROR
> [INFO] 
> 
> [INFO] Failed to resolve dependencies for one or more projects in the 
> reactor. Reason: Missing:
> --
> 1) org.apache.taglibs:taglibs-standard-impl:jar:1.2-SNAPSHOT
> 
>  Try downloading the file manually from the project website.
> 
>  Then, install it using the command: 
>  mvn install:install-file -DgroupId=org.apache.taglibs 
> -DartifactId=taglibs-standard-impl -Dversion=1.2-SNAPSHOT -Dpackaging=jar 
> -Dfile=/path/to/file
> 
>  Alternatively, if you host your own repository you can deploy the file 
> there: 
>  mvn deploy:deploy-file -DgroupId=org.apache.taglibs 
> -DartifactId=taglibs-standard-impl -Dversion=1.2-SNAPSHOT -Dpackaging=jar 
> -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id]
> 
>  Path to dependency: 
>   1) org.apache.taglibs:taglibs-standard-compat:bundle:1.2-SNAPSHOT
>   2) org.apache.taglibs:taglibs-standard-impl:jar:1.2-SNAPSHOT
> 
> --
> 1 required artifact is missing.
> 
> for artifact: 
>  org.apache.taglibs:taglibs-standard-compat:bundle:1.2-SNAPSHOT
> 
> from the specified remote repositories:
>  gump-central (http://localhost:8192/maven2),
>  gump-apache.snapshots (http://localhost:8192/repo/m2-snapshot-repository)
> 
> 
> 
> [INFO] 
> 
> [INFO] For more information, run Maven with the -e switch
> [INFO] 
> 
> [INFO] Total time: 18 seconds
> [INFO] Finished at: Tue Nov 02 01:33:49 UTC 2010
> [INFO] Final Memory: 40M/97M
> [INFO] 
> ---

svn commit: r1029947 - in /tomcat/taglibs/standard/trunk: compat/pom.xml impl/pom.xml jstlel/pom.xml spec/pom.xml

2010-11-01 Thread jboynes
Author: jboynes
Date: Tue Nov  2 04:10:22 2010
New Revision: 1029947

URL: http://svn.apache.org/viewvc?rev=1029947&view=rev
Log:
revert bundle packaging as it breaks Gump

Modified:
tomcat/taglibs/standard/trunk/compat/pom.xml
tomcat/taglibs/standard/trunk/impl/pom.xml
tomcat/taglibs/standard/trunk/jstlel/pom.xml
tomcat/taglibs/standard/trunk/spec/pom.xml

Modified: tomcat/taglibs/standard/trunk/compat/pom.xml
URL: 
http://svn.apache.org/viewvc/tomcat/taglibs/standard/trunk/compat/pom.xml?rev=1029947&r1=1029946&r2=1029947&view=diff
==
--- tomcat/taglibs/standard/trunk/compat/pom.xml (original)
+++ tomcat/taglibs/standard/trunk/compat/pom.xml Tue Nov  2 04:10:22 2010
@@ -32,7 +32,6 @@
 
   taglibs-standard-compat
   1.2-SNAPSHOT
-  bundle
 
   Apache Standard Taglib - JSTL 1.0 Compatibility
 

Modified: tomcat/taglibs/standard/trunk/impl/pom.xml
URL: 
http://svn.apache.org/viewvc/tomcat/taglibs/standard/trunk/impl/pom.xml?rev=1029947&r1=1029946&r2=1029947&view=diff
==
--- tomcat/taglibs/standard/trunk/impl/pom.xml (original)
+++ tomcat/taglibs/standard/trunk/impl/pom.xml Tue Nov  2 04:10:22 2010
@@ -32,7 +32,6 @@
 
   taglibs-standard-impl
   1.2-SNAPSHOT
-  bundle
   
   Apache Standard Taglib - JSTL Implementation
 

Modified: tomcat/taglibs/standard/trunk/jstlel/pom.xml
URL: 
http://svn.apache.org/viewvc/tomcat/taglibs/standard/trunk/jstlel/pom.xml?rev=1029947&r1=1029946&r2=1029947&view=diff
==
--- tomcat/taglibs/standard/trunk/jstlel/pom.xml (original)
+++ tomcat/taglibs/standard/trunk/jstlel/pom.xml Tue Nov  2 04:10:22 2010
@@ -32,7 +32,6 @@
 
   taglibs-standard-jstlel
   1.2-SNAPSHOT
-  bundle
 
   Apache Standard Taglib - JSTL 1.0 EL Support
 

Modified: tomcat/taglibs/standard/trunk/spec/pom.xml
URL: 
http://svn.apache.org/viewvc/tomcat/taglibs/standard/trunk/spec/pom.xml?rev=1029947&r1=1029946&r2=1029947&view=diff
==
--- tomcat/taglibs/standard/trunk/spec/pom.xml (original)
+++ tomcat/taglibs/standard/trunk/spec/pom.xml Tue Nov  2 04:10:22 2010
@@ -28,7 +28,6 @@
 
   taglibs-standard-spec
   1.2-SNAPSHOT
-  bundle
   
   Apache Standard Taglib - JSTL Specification API
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [taglibs] [Bug 50064] bundle-ify the taglibs jars

2010-11-01 Thread Jeremy Boynes
On Nov 1, 2010, at 7:42 PM, Rex Wang wrote:

> Thanks Jeremy,
> 
> Is that because the group id dose not start with org.apache.tomcat...?

I think so. I opened the issue asking for org.apache.taglibs to be added as 
that's the current group id.
https://issues.apache.org/jira/browse/INFRA-3129


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [g...@vmgump]: Project tomcat-taglibs-standard (in module tomcat-taglibs) failed

2010-11-01 Thread Rex Wang
I don't think so. After deploy the artifacts to apache.snapshots, I think
this problem can go away.



2010/11/2 Jeremy Boynes 

> This started failing with r1029387. If I remove the
> bundle from the spec module then the reactor starts
> resolving it again. Could this be something with the bundle plugin not
> working with the package goal?
>
> I'm going to revert the bundle packaging until we can resolve this.
>
> On Nov 1, 2010, at 6:33 PM, Gump wrote:
>
> > To whom it may engage...
> >
> > This is an automated request, but not an unsolicited one. For
> > more information please visit http://gump.apache.org/nagged.html,
> > and/or contact the folk at gene...@gump.apache.org.
> >
> > Project tomcat-taglibs-standard has an issue affecting its community
> integration.
> > This issue affects 2 projects.
> > The current state of this project is 'Failed', with reason 'Build
> Failed'.
> > For reference only, the following projects are affected by this:
> >- tomcat-taglibs-standard :  Standard Taglib
> >- tomcat-taglibs-standard-install :  JSP Taglibs
> >
> >
> > Full details are available at:
> >
> http://vmgump.apache.org/gump/public/tomcat-taglibs/tomcat-taglibs-standard/index.html
> >
> > That said, some information snippets are provided here.
> >
> > The following annotations (debug/informational/warning/error messages)
> were provided:
> > -INFO- Optional dependency httpunit failed with reason build failed
> > -DEBUG- (Gump generated) Maven2 Settings in:
> /srv/gump/public/workspace/tomcat-taglibs/standard/gump_mvn_settings.xml
> > -INFO- Failed with reason build failed
> > -DEBUG- Maven POM in:
> /srv/gump/public/workspace/tomcat-taglibs/standard/pom.xml
> > -DEBUG- Extracted fallback artifacts from Gump Repository
> >
> >
> >
> > The following work was performed:
> >
> http://vmgump.apache.org/gump/public/tomcat-taglibs/tomcat-taglibs-standard/gump_work/build_tomcat-taglibs_tomcat-taglibs-standard.html
> > Work Name: build_tomcat-taglibs_tomcat-taglibs-standard (Type: Build)
> > Work ended in a state of : Failed
> > Elapsed: 19 secs
> > Command Line: mvn --batch-mode -DskipTests=true --settings
> /srv/gump/public/workspace/tomcat-taglibs/standard/gump_mvn_settings.xml
> package
> > [Working Directory: /srv/gump/public/workspace/tomcat-taglibs/standard]
> > -
> > [INFO] Compiling 7 source files to
> /srv/gump/public/workspace/tomcat-taglibs/standard/impl/target/test-classes
> > [INFO] [surefire:test {execution: default-test}]
> > [INFO] Tests are skipped.
> > [INFO] [bundle:bundle {execution: default-bundle}]
> > [INFO]
> 
> > [INFO] Building Apache Standard Taglib - JSTL 1.0 Compatibility
> > [INFO]task-segment: [package]
> > [INFO]
> 
> > [INFO] [remote-resources:process {execution: default}]
> > [INFO] snapshot org.apache.taglibs:taglibs-standard-impl:1.2-SNAPSHOT:
> checking for updates from apache.snapshots
> > Downloading:
> http://localhost:8192/repo/m2-snapshot-repository/org/apache/taglibs/taglibs-standard-impl/1.2-SNAPSHOT/taglibs-standard-impl-1.2-SNAPSHOT.jar
> > [INFO] Unable to find resource
> 'org.apache.taglibs:taglibs-standard-impl:jar:1.2-SNAPSHOT' in repository
> apache.snapshots (http://repository.apache.org/snapshots)
> > [INFO]
> 
> > [ERROR] BUILD ERROR
> > [INFO]
> 
> > [INFO] Failed to resolve dependencies for one or more projects in the
> reactor. Reason: Missing:
> > --
> > 1) org.apache.taglibs:taglibs-standard-impl:jar:1.2-SNAPSHOT
> >
> >  Try downloading the file manually from the project website.
> >
> >  Then, install it using the command:
> >  mvn install:install-file -DgroupId=org.apache.taglibs
> -DartifactId=taglibs-standard-impl -Dversion=1.2-SNAPSHOT -Dpackaging=jar
> -Dfile=/path/to/file
> >
> >  Alternatively, if you host your own repository you can deploy the file
> there:
> >  mvn deploy:deploy-file -DgroupId=org.apache.taglibs
> -DartifactId=taglibs-standard-impl -Dversion=1.2-SNAPSHOT -Dpackaging=jar
> -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id]
> >
> >  Path to dependency:
> >   1) org.apache.taglibs:taglibs-standard-compat:bundle:1.2-SNAPSHOT
> >   2) org.apache.taglibs:taglibs-standard-impl:jar:1.2-SNAPSHOT
> >
> > --
> > 1 required artifact is missing.
> >
> > for artifact:
> >  org.apache.taglibs:taglibs-standard-compat:bundle:1.2-SNAPSHOT
> >
> > from the specified remote repositories:
> >  gump-central (http://localhost:8192/maven2),
> >  gump-apache.snapshots (
> http://localhost:8192/repo/m2-snapshot-repository)
> >
> >
> >
> > [INFO]
> 
> > [INFO] For more information, run Maven with the -e switch
> >