DO NOT REPLY [Bug 50064] New: bundle-ify the taglibs jars

2010-10-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50064

   Summary: bundle-ify the taglibs jars
   Product: Taglibs
   Version: 1.2.0
  Platform: PC
OS/Version: Windows XP
Status: NEW
  Severity: normal
  Priority: P2
 Component: Standard Taglib
AssignedTo: dev@tomcat.apache.org
ReportedBy: rwo...@gmail.com


Hi Devs,

Hope tomcat community can consider bundle-ify the jars so that they can be used
in OSGi framework. Currently, we have to make the bundles by ourselves. There
are two approaches to achieve this.
One is bundle-ify the "spec" and "impl" jars directly. 
The other one is make a separate mvn project to do this job and bind the two
jar together as a bundle. As shown in the patch.

Any comments about this idea?

-Rex

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 50064] bundle-ify the taglibs jars

2010-10-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50064

--- Comment #1 from Rex Wang  2010-10-09 03:20:20 EDT ---
Created an attachment (id=26145)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26145)
A patch for approach #2

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: The status of tomcat taglibs project?

2010-10-09 Thread Rex Wang
Thank you sebb and Jeremy,

Glad to see many fixes in the past few weeks. And I have more questions :-)

1. I open a new item(#50064) in bugzilla to discuss bundle-ify the taglibs
jars and also provided a patch. Any comments about this idea?

2. When do you plan to make the first release? Our project really wants to
switch to the open source implementation..

3. For the patch in #48773, could anyone help review and apply it?

-Rex

2010/9/30 Jeremy Boynes 

> On Sep 24, 2010, at 11:37 PM, Rex Wang wrote:
> > Could anyone tell me any clue about this? or it has never  been built
> since
> > transferred from jakarta project?
>
> I can confirm I have built it but, as sebb said, you need to install the
> parent pom locally first as there's no released version.
>
> > And, does tomcat community have any plan to release the taglibs?
>
> We should :-)
> --
> Jeremy
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


-- 
Lei Wang (Rex)
rwonly AT apache.org


Re: [taglibs] Pick common format for test class names

2010-10-09 Thread Rex Wang
+1 for *Test.java

2010/10/8 Jeremy Boynes 

> We have different formats for test class names and need to specifically
> list them in the pom.xml file.
>
> i'd like to propose picking a standard format and using a single wildcarded
> pattern to select them. The defaults for the surefire plugin are:
>**/Test*.java
>**/*Test.java
>**/*TestCase.java
>
> i would suggest one of the latter 2 to avoid conflicts with inner classes
> (e.g. TestTransformSupport$1)
>
> Thoughts?
> Jeremy
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


-- 
Lei Wang (Rex)
rwonly AT apache.org


DO NOT REPLY [Bug 50065] New: Wrong handling of non-latin1 characters in HTTP request parameters.

2010-10-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50065

   Summary: Wrong handling of non-latin1 characters in HTTP
request parameters.
   Product: Tomcat 7
   Version: 7.0.2
  Platform: PC
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
AssignedTo: dev@tomcat.apache.org
ReportedBy: aanisi...@inbox.ru


Created an attachment (id=26146)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26146)
Example app

It seems that after URL-decoding a parameter value that value is treated as a
string in some 1-byte charset, but not as a string encoded with a charset
specified by http's request character encoding.

  To reproduce, run an attached application. The start page has a link to a
test servlet and passes it a parameter that has non-latin1 characters. The test
servlet, in turn, creates two files in the current working directory into which
it prints the following two values:

 1. req.getParameter("parameter")
 2. new String(req.getParameter("parameter").getBytes("latin1"),"utf-8")

  The second file contains the actual value of the parameter, while the first
one contains some junk which looks like a result of utf-8 encoding a string
that was created by treating the original utf-8 value as a string in some
1-byte charset.

  The full source code for the test servlet is in
WEB-INF/classes/TestServlet.java.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 11248] DefaultServlet doesn't send expires header

2010-10-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=11248

Artem Anisimov  changed:

   What|Removed |Added

  Attachment #26072|0   |1
is obsolete||

--- Comment #3 from Artem Anisimov  2010-10-09 06:32:05 EDT 
---
Created an attachment (id=26147)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26147)
Patch that allows specifying expiration period for static content.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 48716] Embedded Tomcat JULI aggressively resetting default logging configuration

2010-10-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48716

--- Comment #20 from S. Ali Tokmen  2010-10-09 
09:26:24 EDT ---
Hello Mark

(In reply to comment #19)
> I've added the additional check before the reset() call to trunk and it will 
> be
> in 7.0.4 onwards.

I guess the patch is the one I see by inspecting the Tomcat source code using:

svn diff -r 1005801:1005802 http://svn.apache.org/repos/asf/tomcat/trunk/

Which has the following check before the call ro reset():

   
if(!LogManager.getLogManager().getClass().getName().equals("java.util.logging.LogManager"))

The fix is good for me, thank you. Could you please also port it to Tomcat
6.0.x ?

When trying to find the fix suggested in my comments, I've actually seen that
the LogManager doesn't have a removeLogger method; which makes the actual patch
pretty complex.

Cheers

S. Ali Tokmen
http://ali.tokmen.com/

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 50066] New: Cannot compile recursive tag with ant if it uses a class from the webapp

2010-10-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50066

   Summary: Cannot compile recursive tag with ant if it uses a
class from the webapp
   Product: Tomcat 6
   Version: 6.0.29
  Platform: All
OS/Version: All
Status: NEW
  Severity: major
  Priority: P2
 Component: Jasper
AssignedTo: dev@tomcat.apache.org
ReportedBy: sylvain.laur...@gmail.com


The following simple tag file cannot be compiled with the jspc ant task (or the
jpsc maven plugin) :

<%@ taglib prefix="c" uri="http://java.sun.com/jsp/jstl/core"; %>
<%@ taglib prefix="tags" tagdir="/WEB-INF/tags" %>

Hello world !




The error is 
org.apache.jasper.JasperException: /WEB-INF/tags/recursive.tag(21,0) Unable to
load tag handler class "org.apache.taglibs.standard.tag.rt.core.IfTag" for tag
"c:if"

It's OK when the compilation is done "online", when the first jsp that uses
this tag is called with a http request.

The problem is that japer's TagFileProcessor does not set the correct
classloader when compiling recursive tags. It works in online mode because the
parent classloader of the jsp classloader is the webapp classloader.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 50066] Cannot compile recursive tag with ant if it uses a class from the webapp

2010-10-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50066

--- Comment #1 from sylvain.laur...@gmail.com 2010-10-09 09:52:48 EDT ---
Created an attachment (id=26148)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26148)
patch for trunk (tc7)

The issue occurs both in tomcat 6 and 7

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 50066] Cannot compile recursive tag with ant if it uses a class from the webapp

2010-10-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50066

--- Comment #2 from sylvain.laur...@gmail.com 2010-10-09 09:53:21 EDT ---
Created an attachment (id=26149)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26149)
patch for tomcat 6

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[taglibs] JRE version, was: How about splitting up the resource bundle?

2010-10-09 Thread Jeremy Boynes
On Oct 8, 2010, at 10:40 AM, Kris Schneider wrote:

> On Thu, Oct 7, 2010 at 9:29 PM, Jeremy Boynes  wrote:
>> Now that we require 1.5, I refactored Resources to use varargs rather than 
>> having multiple methods taking combinations of parameters. However, now that 
>> it is greatly simplified, i was wondering whether we should replace the 
>> single resource bundle containing messages for all implementations with 
>> smaller ones associated with each tag or tag library.
> 
> When you say, "we require 1.5", are you talking about code
> specifically for a JSTL 1.2 impl? If it's code that's targeted at a
> JSTL 1.1 impl, then it should really run on something as crusty as
> Java 1.3 (minimum for a JSP 2.0 standalone container).

I was referring to trunk which would be our 1.2 impl which requires a JSP 2.1 
container and JDK1.5. Of course, it stills need to support 1.1 and 1.0 tags but 
would be able use features from the newer runtime environment to do so. This is 
related to the other proposal for switching to the EL implementation provided 
by 2.1 (javax.el) rather than continuing to package our own.

Users needing to run in JSP2.0 and JDK1.3 or 1.4 environments could continue to 
use the 1.1.x branches with bugfixes backported as needed.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [taglibs] Proposal to separate out 1.0 functionality

2010-10-09 Thread Jeremy Boynes
On Oct 7, 2010, at 11:15 PM, Rahul Akolkar wrote:
> On Thu, Oct 7, 2010 at 9:48 PM, Jeremy Boynes  wrote:
...
>> A further refinement would be to refactor the 1.0 code to use the JSP EL 
>> support from javax.el.
>> 
> 
> 
> 1.0 code? That would preclude its use unless javax.el is provided.

To clarify, this would be the code in our 1.2 implementation (trunk) that 
provides compatibility for running 1.0 tags in 1.2-level environment. The 
existing 1.1 and 1.0 branches would not change.

The JSTL1.2 spec requires JSP2.1 which would ensure javax.el is provided. There 
are existing dependencies on this package in the JSTL1.2 api classes (for 
example, IndexedValueExpression depends on javax.el.ELContext) we are not 
introducing anything new.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Tomcat Wiki] Update of "PoweredBy" by PidSter

2010-10-09 Thread Apache Wiki
Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change 
notification.

The "PoweredBy" page has been changed by PidSter.
http://wiki.apache.org/tomcat/PoweredBy?action=diff&rev1=269&rev2=270

--

  
  === TheServerSide.com ===
  {{http://www.theserverside.com/skin/images/header_logotype.gif}} 
[[http://www.theserverside.com/tss?service=direct/0/NewsThread/threadViewer.markNoisy.link&sp=l28395&sp=l136428|Tomcat
 is among the market leaders]] in this survey by 
[[http://www.theserverside.com|TheServerSide.com]].
- 
- === Translation agency ===
- [[http://www.profischnell.com|Übersetzung Polnisch Deutsch]] Translation 
agency for all languages e. g. spanish, french. (Multilanguages)
  
  <>
  

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[taglibs] Release for 1.2, was: The status of tomcat taglibs project?

2010-10-09 Thread Jeremy Boynes
On Oct 9, 2010, at 12:37 AM, Rex Wang wrote:
> 
> 2. When do you plan to make the first release? Our project really wants to
> switch to the open source implementation..

Trunk now passes the JSTL1.2 TCK so we can release when we want to. However, 
there have already been some large changes in the 1.2 stream (such as the move 
to the Tomcat project, using a 1.5 runtime, switching to Maven build) that will 
be visible to users so if we are going to make any others my vote would be to 
do that before releasing 1.2.0 so they are only impacted once; examples of 
these are:

* using a different XPath implementation to fix the performance issues with the 
XML tags (changes dependencies)
* splitting out the 1.0 compatibility support into a different artifact
* clean-up on the Maven POMs (especially any changes that impact the parent POM)

We may also need to revise the release process based on the move to the Tomcat 
project and Maven build.

With that in mind, what do people think about shooting for a release towards 
the end of the month?

Re: svn commit: r1006033 - in /tomcat/trunk: java/org/apache/catalina/startup/ContextConfig.java webapps/docs/changelog.xml

2010-10-09 Thread Sylvain Laurent
This commit broke all default webapps (ROOT, examples, docs). a 404 is returned 
instead...


On 8 oct. 2010, at 23:37, ma...@apache.org wrote:

> Author: markt
> Date: Fri Oct  8 21:37:19 2010
> New Revision: 1006033
> 
> URL: http://svn.apache.org/viewvc?rev=1006033&view=rev
> Log:
> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50059
> Always make JAR resources available
> 
> Modified:
>tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java
>tomcat/trunk/webapps/docs/changelog.xml
> 
> Modified: tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java
> URL: 
> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java?rev=1006033&r1=1006032&r2=1006033&view=diff
> ==
> --- tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java 
> (original)
> +++ tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java Fri Oct  
> 8 21:37:19 2010
> @@ -1214,7 +1214,7 @@ public class ContextConfig
> webXmlVersion = Double.parseDouble(webXml.getVersion());
> }
> 
> -if (webXmlVersion >= 3 && !webXml.isMetadataComplete()) {
> +if (webXmlVersion >= 3) {
> // Ordering is important here
> 
> // Step 1. Identify all the JARs packaged with the application
> @@ -1222,67 +1222,78 @@ public class ContextConfig
> // point.
> Map fragments = processJarsForWebFragments();
> 
> -// Step 2. Order the fragments.
> -Set orderedFragments =
> -WebXml.orderWebFragments(webXml, fragments);
> -
> -// Step 3. Look for ServletContainerInitializer implementations
> -ok = processServletContainerInitializers(orderedFragments);
> -
> -// Step 4. Process /WEB-INF/classes for annotations
> -// This will add any matching classes to the typeInitializerMap
> -if (ok) {
> -URL webinfClasses;
> -try {
> -webinfClasses =
> -
> context.getServletContext().getResource("/WEB-INF/classes");
> -processAnnotationsUrl(webinfClasses, webXml);
> -} catch (MalformedURLException e) {
> -
> log.error(sm.getString("contextConfig.webinfClassesUrl"), e);
> +// Only need to process fragments and annotations if metadata is
> +// not complete
> +Set orderedFragments = null;
> +if  (!webXml.isMetadataComplete()) {
> +// Step 2. Order the fragments.
> +orderedFragments = WebXml.orderWebFragments(webXml, 
> fragments);
> +
> +// Step 3. Look for ServletContainerInitializer 
> implementations
> +ok = processServletContainerInitializers(orderedFragments);
> +
> +// Step 4. Process /WEB-INF/classes for annotations
> +// This will add any matching classes to the 
> typeInitializerMap
> +if (ok) {
> +URL webinfClasses;
> +try {
> +webinfClasses = 
> context.getServletContext().getResource(
> +"/WEB-INF/classes");
> +processAnnotationsUrl(webinfClasses, webXml);
> +} catch (MalformedURLException e) {
> +log.error(sm.getString(
> +"contextConfig.webinfClassesUrl"), e);
> +}
> }
> -}
> -
> -// Step 5. Process JARs for annotations - only need to process 
> those
> -// fragments we are going to use
> -// This will add any matching classes to the typeInitializerMap
> -if (ok) {
> -processAnnotations(orderedFragments);
> -}
> -
> -// Step 6. Merge web-fragment.xml files into the main web.xml 
> file.
> -if (ok) {
> -ok = webXml.merge(orderedFragments);
> -}
> -
> -// Step 6.5 Convert explicitly mentioned jsps to servlets
> -if (!false) {
> -convertJsps(webXml);
> -}
> -
> -// Step 7. Apply merged web.xml to Context
> -if (ok) {
> -webXml.configureContext(context);
> -
> -// Step 7a. Make the merged web.xml available to other
> -// components, specifically Jasper, to save those components
> -// from having to re-generate it.
> -// TODO Use a ServletContainerInitializer for Jasper
> -String mergedWebXml = webXml.toXml();
> -context.getServletContext().setAttribute(
> -   org.apache.tomcat.util.scan.Constants.MERGED_WEB_XML,
> -mergedWebXml);
> -if

DO NOT REPLY [Bug 49159] Improve ThreadLocal memory leak clean-up

2010-10-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49159

sylvain.laur...@gmail.com changed:

   What|Removed |Added

  Attachment #25411|0   |1
is obsolete||
  Attachment #26108|0   |1
is obsolete||

--- Comment #12 from sylvain.laur...@gmail.com 2010-10-09 17:14:35 EDT ---
Created an attachment (id=26150)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26150)
patch tc7 renew threads RC1

Here is my proposed "RC1" patch for tc7.

- new property threadRenewalDelay on StandardThreadExecutor (default is 1000ms)
- new property renewThreadsWhenStoppingContext on StandardContext (default is
true)
- removed property clearReferencesThreadLocals on StandardContext
- Transformed the clearReferencesThreadLocals behavior of WebappClassLoader
into a checkThreadLocalsForLeaks behavior
- updated documentation
- successfully performed some tests with JMeter

I'll try to propose an equivalent patch for tomcat 6 in a few days...

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1006229 - /tomcat/taglibs/standard/trunk/impl/src/main/java/org/apache/taglibs/standard/tag/common/sql/DataSourceWrapper.java

2010-10-09 Thread jboynes
Author: jboynes
Date: Sat Oct  9 22:26:48 2010
New Revision: 1006229

URL: http://svn.apache.org/viewvc?rev=1006229&view=rev
Log:
apply patch from Jarek Gawor for bugzilla #48773

Modified:

tomcat/taglibs/standard/trunk/impl/src/main/java/org/apache/taglibs/standard/tag/common/sql/DataSourceWrapper.java

Modified: 
tomcat/taglibs/standard/trunk/impl/src/main/java/org/apache/taglibs/standard/tag/common/sql/DataSourceWrapper.java
URL: 
http://svn.apache.org/viewvc/tomcat/taglibs/standard/trunk/impl/src/main/java/org/apache/taglibs/standard/tag/common/sql/DataSourceWrapper.java?rev=1006229&r1=1006228&r2=1006229&view=diff
==
--- 
tomcat/taglibs/standard/trunk/impl/src/main/java/org/apache/taglibs/standard/tag/common/sql/DataSourceWrapper.java
 (original)
+++ 
tomcat/taglibs/standard/trunk/impl/src/main/java/org/apache/taglibs/standard/tag/common/sql/DataSourceWrapper.java
 Sat Oct  9 22:26:48 2010
@@ -19,8 +19,10 @@ package org.apache.taglibs.standard.tag.
 
 import java.io.PrintWriter;
 import java.sql.Connection;
+import java.sql.Driver;
 import java.sql.DriverManager;
 import java.sql.SQLException;
+import java.util.Properties;
 
 import javax.sql.DataSource;
 
@@ -34,7 +36,7 @@ import org.apache.taglibs.standard.resou
  * @author Hans Bergsten
  */
 public class DataSourceWrapper implements DataSource {
-private String driverClassName;
+private Driver driver;
 private String jdbcURL;
 private String userName;
 private String password;
@@ -43,8 +45,6 @@ public class DataSourceWrapper implement
 throws ClassNotFoundException, InstantiationException, 
 IllegalAccessException {
 
-this.driverClassName = driverClassName;
-
 //get the classloader
 ClassLoader cl;
 SecurityManager sm = System.getSecurityManager();
@@ -57,7 +57,10 @@ public class DataSourceWrapper implement
 }
 //done getting classloader
 
-Class.forName(driverClassName, true, cl).newInstance();
+Object instance = Class.forName(driverClassName, true, 
cl).newInstance();
+if (instance instanceof Driver) {
+driver = (Driver) instance;
+}
 }
 
 public void setJdbcURL(String jdbcURL) {
@@ -77,16 +80,27 @@ public class DataSourceWrapper implement
  * set properties.
  */
 public Connection getConnection() throws SQLException {
-   Connection conn = null;
-   if (userName != null) {
-   conn = DriverManager.getConnection(jdbcURL, userName, password);
-   }
-   else {
-   conn = DriverManager.getConnection(jdbcURL);
-   }
-   return conn;
+Connection conn = null;
+if (driver != null) {
+Properties props = new Properties();
+if (userName != null) {
+props.put("user", userName);
+}
+if (password != null) {
+props.put("password", password);
+}
+conn = driver.connect(jdbcURL, props);
+}
+if (conn == null) {
+if (userName != null) {
+conn = DriverManager.getConnection(jdbcURL, userName, 
password);
+} else {
+conn = DriverManager.getConnection(jdbcURL);
+}
+}
+return conn;
 }
-
+
 /**
  * Always throws a SQLException. Username and password are set
  * in the constructor and can not be changed.



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 48773] DataSourceWrapper and DriverManager problems

2010-10-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48773

Jeremy Boynes  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #1 from Jeremy Boynes  2010-10-09 18:28:25 EDT 
---
Patch applied as r1006229.
Thanks

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Patch for DataSourceWrapper #48773, problem with memory leak

2010-10-09 Thread Jeremy Boynes
On Oct 9, 2010, at 12:37 AM, Rex Wang wrote:
> 3. For the patch in #48773, could anyone help review and apply it?


I think there's a problem here that would cause a memory leak when the JDBC 
Driver is bundled with an application jar. When the driver class is 
instantiated, it is meant to register itself with DriverManager creating a hard 
reference to a class loaded by the application ClassLoader. This would prevent 
the webapp from unloading causing a memory leak.

This would appear to be an existing issue so I applied the patch and resolved 
the bug. I'll open another to track.
--
Jeremy


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 50068] New: Memory leak with Driver registration

2010-10-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50068

   Summary: Memory leak with Driver registration
   Product: Taglibs
   Version: 1.2.0
  Platform: PC
Status: NEW
  Severity: normal
  Priority: P2
 Component: Standard Taglib
AssignedTo: dev@tomcat.apache.org
ReportedBy: jboy...@apache.org


The  tag may instantiate a new instance of a JDBC Driver
from a Class name supplied as a tag attribute. This is done using the
application's ClassLoader. The JDBC specification recommends that
implementations register instances of their Driver with the DriverManager
during class (static) initialization. As a result, the DriverManager will
retain references to classes loaded by the application ClassLoader leading to a
memory leak.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1006230 - /tomcat/taglibs/standard/trunk/impl/src/main/java/org/apache/taglibs/standard/tag/common/sql/DriverTag.java

2010-10-09 Thread jboynes
Author: jboynes
Date: Sat Oct  9 22:46:59 2010
New Revision: 1006230

URL: http://svn.apache.org/viewvc?rev=1006230&view=rev
Log:
remove obsolete DriverTag implementation as it has been replaced with 
SetDataSource and is no longer used

Removed:

tomcat/taglibs/standard/trunk/impl/src/main/java/org/apache/taglibs/standard/tag/common/sql/DriverTag.java


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1006231 - /tomcat/taglibs/taglibs-parent/trunk/pom.xml

2010-10-09 Thread jboynes
Author: jboynes
Date: Sat Oct  9 23:07:29 2010
New Revision: 1006231

URL: http://svn.apache.org/viewvc?rev=1006231&view=rev
Log:
update parent POM with other mail archives that are online

Modified:
tomcat/taglibs/taglibs-parent/trunk/pom.xml

Modified: tomcat/taglibs/taglibs-parent/trunk/pom.xml
URL: 
http://svn.apache.org/viewvc/tomcat/taglibs/taglibs-parent/trunk/pom.xml?rev=1006231&r1=1006230&r2=1006231&view=diff
==
--- tomcat/taglibs/taglibs-parent/trunk/pom.xml (original)
+++ tomcat/taglibs/taglibs-parent/trunk/pom.xml Sat Oct  9 23:07:29 2010
@@ -59,14 +59,14 @@
   taglibs-user-unsubscr...@tomcat.apache.org
   taglibs-u...@tomcat.apache.org
   
http://mail-archives.apache.org/mod_mbox/tomcat-taglibs-user/
-  
   
-  -->
 
 
   Old Taglibs User Archive



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1006232 - /tomcat/taglibs/taglibs-parent/trunk/pom.xml

2010-10-09 Thread jboynes
Author: jboynes
Date: Sat Oct  9 23:21:41 2010
New Revision: 1006232

URL: http://svn.apache.org/viewvc?rev=1006232&view=rev
Log:
Configure resource path in parent POM to include LICENSE and NOTICE files in 
addition to default Maven resource path

Add NOTICE file

Modified:
tomcat/taglibs/taglibs-parent/trunk/pom.xml

Modified: tomcat/taglibs/taglibs-parent/trunk/pom.xml
URL: 
http://svn.apache.org/viewvc/tomcat/taglibs/taglibs-parent/trunk/pom.xml?rev=1006232&r1=1006231&r2=1006232&view=diff
==
--- tomcat/taglibs/taglibs-parent/trunk/pom.xml (original)
+++ tomcat/taglibs/taglibs-parent/trunk/pom.xml Sat Oct  9 23:21:41 2010
@@ -114,8 +114,7 @@
 
   
   
-src/main/resources/META-INF
-META-INF
+src/main/resources
   
 
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1006233 - in /tomcat/taglibs/standard/trunk: NOTICE.txt impl/LICENSE.txt impl/NOTICE.txt impl/pom.xml spec/LICENSE.txt spec/NOTICE.txt

2010-10-09 Thread jboynes
Author: jboynes
Date: Sat Oct  9 23:22:49 2010
New Revision: 1006233

URL: http://svn.apache.org/viewvc?rev=1006233&view=rev
Log:
ensure LICENSE and NOTICE file are included in every project jar

Added:
tomcat/taglibs/standard/trunk/impl/LICENSE.txt
  - copied unchanged from r1005806, 
tomcat/taglibs/standard/trunk/LICENSE.txt
tomcat/taglibs/standard/trunk/impl/NOTICE.txt   (with props)
tomcat/taglibs/standard/trunk/spec/LICENSE.txt
  - copied unchanged from r1005806, 
tomcat/taglibs/standard/trunk/LICENSE.txt
tomcat/taglibs/standard/trunk/spec/NOTICE.txt   (with props)
Modified:
tomcat/taglibs/standard/trunk/NOTICE.txt
tomcat/taglibs/standard/trunk/impl/pom.xml

Modified: tomcat/taglibs/standard/trunk/NOTICE.txt
URL: 
http://svn.apache.org/viewvc/tomcat/taglibs/standard/trunk/NOTICE.txt?rev=1006233&r1=1006232&r2=1006233&view=diff
==
--- tomcat/taglibs/standard/trunk/NOTICE.txt (original)
+++ tomcat/taglibs/standard/trunk/NOTICE.txt Sat Oct  9 23:22:49 2010
@@ -1,7 +1,5 @@
-Apache Jakarta Standards Taglib
+Apache Tomcat Standard Taglib
 Copyright 2001-2010 The Apache Software Foundation
 
 This product includes software developed by
 The Apache Software Foundation (http://www.apache.org/).
-
-Includes code from Commons Collections (LRUMap and the classes/interfaces it 
requires).

Added: tomcat/taglibs/standard/trunk/impl/NOTICE.txt
URL: 
http://svn.apache.org/viewvc/tomcat/taglibs/standard/trunk/impl/NOTICE.txt?rev=1006233&view=auto
==
--- tomcat/taglibs/standard/trunk/impl/NOTICE.txt (added)
+++ tomcat/taglibs/standard/trunk/impl/NOTICE.txt Sat Oct  9 23:22:49 2010
@@ -0,0 +1,5 @@
+Apache Tomcat Standard Taglib Implementation
+Copyright 2001-2010 The Apache Software Foundation
+
+This product includes software developed by
+The Apache Software Foundation (http://www.apache.org/).

Propchange: tomcat/taglibs/standard/trunk/impl/NOTICE.txt
--
svn:eol-style = native

Modified: tomcat/taglibs/standard/trunk/impl/pom.xml
URL: 
http://svn.apache.org/viewvc/tomcat/taglibs/standard/trunk/impl/pom.xml?rev=1006233&r1=1006232&r2=1006233&view=diff
==
--- tomcat/taglibs/standard/trunk/impl/pom.xml (original)
+++ tomcat/taglibs/standard/trunk/impl/pom.xml Sat Oct  9 23:22:49 2010
@@ -129,6 +129,14 @@
   
   
   
+.
+META-INF
+
+  NOTICE.txt
+  LICENSE.txt
+
+  
+  
   src/main/java
   
   **/*.properties

Added: tomcat/taglibs/standard/trunk/spec/NOTICE.txt
URL: 
http://svn.apache.org/viewvc/tomcat/taglibs/standard/trunk/spec/NOTICE.txt?rev=1006233&view=auto
==
--- tomcat/taglibs/standard/trunk/spec/NOTICE.txt (added)
+++ tomcat/taglibs/standard/trunk/spec/NOTICE.txt Sat Oct  9 23:22:49 2010
@@ -0,0 +1,5 @@
+Apache Tomcat Standard Taglib Specification API
+Copyright 2001-2010 The Apache Software Foundation
+
+This product includes software developed by
+The Apache Software Foundation (http://www.apache.org/).

Propchange: tomcat/taglibs/standard/trunk/spec/NOTICE.txt
--
svn:eol-style = native



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1006234 - in /tomcat/taglibs/standard/trunk/impl: ./ src/main/java/org/apache/taglibs/standard/lang/jstl/ src/main/java/org/apache/taglibs/standard/resources/ src/main/resources/META-INF/

2010-10-09 Thread jboynes
Author: jboynes
Date: Sat Oct  9 23:33:46 2010
New Revision: 1006234

URL: http://svn.apache.org/viewvc?rev=1006234&view=rev
Log:
move resources to location in default Maven resources tree to remove need for 
custom definition

Added:
tomcat/taglibs/standard/trunk/impl/src/main/resources/META-INF/c-1_0-rt.tld
  - copied unchanged from r1005806, 
tomcat/taglibs/standard/trunk/impl/src/main/resources/META-INF/tlds/c-1_0-rt.tld
tomcat/taglibs/standard/trunk/impl/src/main/resources/META-INF/c-1_0.tld
  - copied unchanged from r1005806, 
tomcat/taglibs/standard/trunk/impl/src/main/resources/META-INF/tlds/c-1_0.tld
tomcat/taglibs/standard/trunk/impl/src/main/resources/META-INF/c-1_1.tld
  - copied unchanged from r1005806, 
tomcat/taglibs/standard/trunk/impl/src/main/resources/META-INF/tlds/c-1_1.tld
tomcat/taglibs/standard/trunk/impl/src/main/resources/META-INF/c.tld
  - copied unchanged from r1005806, 
tomcat/taglibs/standard/trunk/impl/src/main/resources/META-INF/tlds/c.tld

tomcat/taglibs/standard/trunk/impl/src/main/resources/META-INF/fmt-1_0-rt.tld
  - copied unchanged from r1005806, 
tomcat/taglibs/standard/trunk/impl/src/main/resources/META-INF/tlds/fmt-1_0-rt.tld
tomcat/taglibs/standard/trunk/impl/src/main/resources/META-INF/fmt-1_0.tld
  - copied unchanged from r1005806, 
tomcat/taglibs/standard/trunk/impl/src/main/resources/META-INF/tlds/fmt-1_0.tld
tomcat/taglibs/standard/trunk/impl/src/main/resources/META-INF/fmt.tld
  - copied unchanged from r1005806, 
tomcat/taglibs/standard/trunk/impl/src/main/resources/META-INF/tlds/fmt.tld
tomcat/taglibs/standard/trunk/impl/src/main/resources/META-INF/fn.tld
  - copied unchanged from r1005806, 
tomcat/taglibs/standard/trunk/impl/src/main/resources/META-INF/tlds/fn.tld

tomcat/taglibs/standard/trunk/impl/src/main/resources/META-INF/permittedTaglibs.tld
  - copied unchanged from r1005806, 
tomcat/taglibs/standard/trunk/impl/src/main/resources/META-INF/tlds/permittedTaglibs.tld

tomcat/taglibs/standard/trunk/impl/src/main/resources/META-INF/scriptfree.tld
  - copied unchanged from r1005806, 
tomcat/taglibs/standard/trunk/impl/src/main/resources/META-INF/tlds/scriptfree.tld

tomcat/taglibs/standard/trunk/impl/src/main/resources/META-INF/sql-1_0-rt.tld
  - copied unchanged from r1005806, 
tomcat/taglibs/standard/trunk/impl/src/main/resources/META-INF/tlds/sql-1_0-rt.tld
tomcat/taglibs/standard/trunk/impl/src/main/resources/META-INF/sql-1_0.tld
  - copied unchanged from r1005806, 
tomcat/taglibs/standard/trunk/impl/src/main/resources/META-INF/tlds/sql-1_0.tld
tomcat/taglibs/standard/trunk/impl/src/main/resources/META-INF/sql.tld
  - copied unchanged from r1005806, 
tomcat/taglibs/standard/trunk/impl/src/main/resources/META-INF/tlds/sql.tld
tomcat/taglibs/standard/trunk/impl/src/main/resources/META-INF/x-1_0-rt.tld
  - copied unchanged from r1005806, 
tomcat/taglibs/standard/trunk/impl/src/main/resources/META-INF/tlds/x-1_0-rt.tld
tomcat/taglibs/standard/trunk/impl/src/main/resources/META-INF/x-1_0.tld
  - copied unchanged from r1005806, 
tomcat/taglibs/standard/trunk/impl/src/main/resources/META-INF/tlds/x-1_0.tld
tomcat/taglibs/standard/trunk/impl/src/main/resources/META-INF/x.tld
  - copied unchanged from r1005806, 
tomcat/taglibs/standard/trunk/impl/src/main/resources/META-INF/tlds/x.tld
tomcat/taglibs/standard/trunk/impl/src/main/resources/org/
tomcat/taglibs/standard/trunk/impl/src/main/resources/org/apache/
tomcat/taglibs/standard/trunk/impl/src/main/resources/org/apache/taglibs/

tomcat/taglibs/standard/trunk/impl/src/main/resources/org/apache/taglibs/standard/

tomcat/taglibs/standard/trunk/impl/src/main/resources/org/apache/taglibs/standard/lang/

tomcat/taglibs/standard/trunk/impl/src/main/resources/org/apache/taglibs/standard/lang/jstl/

tomcat/taglibs/standard/trunk/impl/src/main/resources/org/apache/taglibs/standard/lang/jstl/Resources.properties
   (props changed)
  - copied unchanged from r1005806, 
tomcat/taglibs/standard/trunk/impl/src/main/java/org/apache/taglibs/standard/lang/jstl/Resources.properties

tomcat/taglibs/standard/trunk/impl/src/main/resources/org/apache/taglibs/standard/lang/jstl/Resources_ja.properties
   (props changed)
  - copied unchanged from r1005806, 
tomcat/taglibs/standard/trunk/impl/src/main/java/org/apache/taglibs/standard/lang/jstl/Resources_ja.properties

tomcat/taglibs/standard/trunk/impl/src/main/resources/org/apache/taglibs/standard/resources/

tomcat/taglibs/standard/trunk/impl/src/main/resources/org/apache/taglibs/standard/resources/Resources.properties
   (props changed)
  - copied unchanged from r1005806, 
tomcat/taglibs/standard/trunk/impl/src/main/java/org/apache/taglibs/standard/resources/Resources.properties

tomcat/taglibs/standard/trunk/impl/src/main/resources/org/apache/taglibs/standard/resources/Resources_ja.properties
   (props

svn commit: r1006235 - /tomcat/taglibs/taglibs-parent/trunk/NOTICE.txt

2010-10-09 Thread jboynes
Author: jboynes
Date: Sat Oct  9 23:34:55 2010
New Revision: 1006235

URL: http://svn.apache.org/viewvc?rev=1006235&view=rev
Log:
fix project name

Modified:
tomcat/taglibs/taglibs-parent/trunk/NOTICE.txt

Modified: tomcat/taglibs/taglibs-parent/trunk/NOTICE.txt
URL: 
http://svn.apache.org/viewvc/tomcat/taglibs/taglibs-parent/trunk/NOTICE.txt?rev=1006235&r1=1006234&r2=1006235&view=diff
==
--- tomcat/taglibs/taglibs-parent/trunk/NOTICE.txt (original)
+++ tomcat/taglibs/taglibs-parent/trunk/NOTICE.txt Sat Oct  9 23:34:55 2010
@@ -1,4 +1,4 @@
-Apache Jakarta Taglib Parent
+Apache Tomcat Taglib Parent
 Copyright 2009-2010 The Apache Software Foundation
 
 This product includes software developed by



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1006237 - in /tomcat/taglibs: standard/trunk/impl/pom.xml standard/trunk/spec/pom.xml taglibs-parent/trunk/pom.xml

2010-10-09 Thread jboynes
Author: jboynes
Date: Sun Oct 10 00:37:21 2010
New Revision: 1006237

URL: http://svn.apache.org/viewvc?rev=1006237&view=rev
Log:
Set JDK level using default maven.compiler.* properties

Modified:
tomcat/taglibs/standard/trunk/impl/pom.xml
tomcat/taglibs/standard/trunk/spec/pom.xml
tomcat/taglibs/taglibs-parent/trunk/pom.xml

Modified: tomcat/taglibs/standard/trunk/impl/pom.xml
URL: 
http://svn.apache.org/viewvc/tomcat/taglibs/standard/trunk/impl/pom.xml?rev=1006237&r1=1006236&r2=1006237&view=diff
==
--- tomcat/taglibs/standard/trunk/impl/pom.xml (original)
+++ tomcat/taglibs/standard/trunk/impl/pom.xml Sun Oct 10 00:37:21 2010
@@ -122,20 +122,10 @@
   
 UTF-8
 UTF-8
-1.5
-1.5
   
 
   
 
-  
-org.apache.maven.plugins
-maven-compiler-plugin
-
-  1.5
-  1.5
-
-  
 
   
 org.apache.maven.plugins
@@ -166,7 +156,7 @@
 maven-pmd-plugin
 2.3
 
-  ${maven.compile.target}
+  ${maven.compiler.target}
 
 
   

Modified: tomcat/taglibs/standard/trunk/spec/pom.xml
URL: 
http://svn.apache.org/viewvc/tomcat/taglibs/standard/trunk/spec/pom.xml?rev=1006237&r1=1006236&r2=1006237&view=diff
==
--- tomcat/taglibs/standard/trunk/spec/pom.xml (original)
+++ tomcat/taglibs/standard/trunk/spec/pom.xml Sun Oct 10 00:37:21 2010
@@ -84,17 +84,4 @@
 

 
-  
-
-  
-org.apache.maven.plugins
-maven-compiler-plugin
-
-  1.5
-  1.5
-
-  
-
-  
-
 

Modified: tomcat/taglibs/taglibs-parent/trunk/pom.xml
URL: 
http://svn.apache.org/viewvc/tomcat/taglibs/taglibs-parent/trunk/pom.xml?rev=1006237&r1=1006236&r2=1006237&view=diff
==
--- tomcat/taglibs/taglibs-parent/trunk/pom.xml (original)
+++ tomcat/taglibs/taglibs-parent/trunk/pom.xml Sun Oct 10 00:37:21 2010
@@ -131,8 +131,8 @@
   
${project.version}
   
${project.organization.name}
   org.apache
-  
${maven.compile.source}
-  
${maven.compile.target}
+  
${maven.compiler.source}
+  
${maven.compiler.target}
 
   
 
@@ -150,8 +150,8 @@
   
${project.version}
   
${project.organization.name}
   org.apache
-  
${maven.compile.source}
-  
${maven.compile.target}
+  
${maven.compiler.source}
+  
${maven.compiler.target}
 
   
 
@@ -197,10 +197,9 @@
 
   
 
-
+1.5
+1.5
+
 
 ${project.artifactId}
 RC1



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1006238 - in /tomcat/taglibs/standard/trunk: impl/pom.xml spec/pom.xml

2010-10-09 Thread jboynes
Author: jboynes
Date: Sun Oct 10 00:40:14 2010
New Revision: 1006238

URL: http://svn.apache.org/viewvc?rev=1006238&view=rev
Log:
fix project names

Modified:
tomcat/taglibs/standard/trunk/impl/pom.xml
tomcat/taglibs/standard/trunk/spec/pom.xml

Modified: tomcat/taglibs/standard/trunk/impl/pom.xml
URL: 
http://svn.apache.org/viewvc/tomcat/taglibs/standard/trunk/impl/pom.xml?rev=1006238&r1=1006237&r2=1006238&view=diff
==
--- tomcat/taglibs/standard/trunk/impl/pom.xml (original)
+++ tomcat/taglibs/standard/trunk/impl/pom.xml Sun Oct 10 00:40:14 2010
@@ -32,7 +32,7 @@
 
   taglibs-standard-impl
   1.2-SNAPSHOT
-  Jakarta Standard Taglib - JSTL Implementation
+  Apache Standard Taglib - JSTL Implementation
 
   2001
   

Modified: tomcat/taglibs/standard/trunk/spec/pom.xml
URL: 
http://svn.apache.org/viewvc/tomcat/taglibs/standard/trunk/spec/pom.xml?rev=1006238&r1=1006237&r2=1006238&view=diff
==
--- tomcat/taglibs/standard/trunk/spec/pom.xml (original)
+++ tomcat/taglibs/standard/trunk/spec/pom.xml Sun Oct 10 00:40:14 2010
@@ -28,7 +28,7 @@
 
   taglibs-standard-spec
   1.2-SNAPSHOT
-  Jakarta Standard Taglib - JSTL Specification API
+  Apache Standard Taglib - JSTL Specification API
 
   2001
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1006239 - in /tomcat/taglibs/standard/trunk: ./ impl/ spec/ standard-test/

2010-10-09 Thread jboynes
Author: jboynes
Date: Sun Oct 10 00:45:34 2010
New Revision: 1006239

URL: http://svn.apache.org/viewvc?rev=1006239&view=rev
Log:
set svn:ignore to ignore IDE files and build target

Modified:
tomcat/taglibs/standard/trunk/   (props changed)
tomcat/taglibs/standard/trunk/impl/   (props changed)
tomcat/taglibs/standard/trunk/spec/   (props changed)
tomcat/taglibs/standard/trunk/standard-test/   (props changed)

Propchange: tomcat/taglibs/standard/trunk/
--
--- svn:ignore (added)
+++ svn:ignore Sun Oct 10 00:45:34 2010
@@ -0,0 +1 @@
+*.iml

Propchange: tomcat/taglibs/standard/trunk/impl/
--
--- svn:ignore (added)
+++ svn:ignore Sun Oct 10 00:45:34 2010
@@ -0,0 +1,2 @@
+target
+*.iml

Propchange: tomcat/taglibs/standard/trunk/spec/
--
--- svn:ignore (added)
+++ svn:ignore Sun Oct 10 00:45:34 2010
@@ -0,0 +1,2 @@
+target
+*.iml

Propchange: tomcat/taglibs/standard/trunk/standard-test/
--
--- svn:ignore (added)
+++ svn:ignore Sun Oct 10 00:45:34 2010
@@ -0,0 +1,2 @@
+target
+*.iml



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1006240 - in /tomcat/taglibs/standard/trunk/impl: ./ src/test/java/org/apache/taglibs/standard/ src/test/java/org/apache/taglibs/standard/functions/ src/test/java/org/apache/taglibs/stand

2010-10-09 Thread jboynes
Author: jboynes
Date: Sun Oct 10 01:00:38 2010
New Revision: 1006240

URL: http://svn.apache.org/viewvc?rev=1006240&view=rev
Log:
Rename tests to match default **/*Test.java pattern

Added:

tomcat/taglibs/standard/trunk/impl/src/test/java/org/apache/taglibs/standard/VersionTest.java
   (contents, props changed)
  - copied, changed from r1006238, 
tomcat/taglibs/standard/trunk/impl/src/test/java/org/apache/taglibs/standard/TestVersion.java

tomcat/taglibs/standard/trunk/impl/src/test/java/org/apache/taglibs/standard/functions/FunctionsTest.java
   (contents, props changed)
  - copied, changed from r1006238, 
tomcat/taglibs/standard/trunk/impl/src/test/java/org/apache/taglibs/standard/functions/TestFunctions.java

tomcat/taglibs/standard/trunk/impl/src/test/java/org/apache/taglibs/standard/lang/jstl/test/StaticFunctionTest.java
   (contents, props changed)
  - copied, changed from r1006238, 
tomcat/taglibs/standard/trunk/impl/src/test/java/org/apache/taglibs/standard/lang/jstl/test/StaticFunctionTests.java

tomcat/taglibs/standard/trunk/impl/src/test/java/org/apache/taglibs/standard/resources/ResourcesTest.java
  - copied, changed from r1006238, 
tomcat/taglibs/standard/trunk/impl/src/test/java/org/apache/taglibs/standard/resources/TestResources.java

tomcat/taglibs/standard/trunk/impl/src/test/java/org/apache/taglibs/standard/tag/common/core/SetSupportTest.java
   (contents, props changed)
  - copied, changed from r1006238, 
tomcat/taglibs/standard/trunk/impl/src/test/java/org/apache/taglibs/standard/tag/common/core/TestSetSupport.java

tomcat/taglibs/standard/trunk/impl/src/test/java/org/apache/taglibs/standard/tag/common/xml/TransformSupportTest.java
  - copied, changed from r1006238, 
tomcat/taglibs/standard/trunk/impl/src/test/java/org/apache/taglibs/standard/tag/common/xml/TestTransformSupport.java
Removed:

tomcat/taglibs/standard/trunk/impl/src/test/java/org/apache/taglibs/standard/TestVersion.java

tomcat/taglibs/standard/trunk/impl/src/test/java/org/apache/taglibs/standard/functions/TestFunctions.java

tomcat/taglibs/standard/trunk/impl/src/test/java/org/apache/taglibs/standard/lang/jstl/test/StaticFunctionTests.java

tomcat/taglibs/standard/trunk/impl/src/test/java/org/apache/taglibs/standard/resources/TestResources.java

tomcat/taglibs/standard/trunk/impl/src/test/java/org/apache/taglibs/standard/tag/common/core/TestSetSupport.java

tomcat/taglibs/standard/trunk/impl/src/test/java/org/apache/taglibs/standard/tag/common/xml/TestTransformSupport.java

tomcat/taglibs/standard/trunk/impl/src/test/java/org/apache/taglibs/standard/tag/el/

tomcat/taglibs/standard/trunk/impl/src/test/java/org/apache/taglibs/standard/testutil/
Modified:
tomcat/taglibs/standard/trunk/impl/pom.xml

Modified: tomcat/taglibs/standard/trunk/impl/pom.xml
URL: 
http://svn.apache.org/viewvc/tomcat/taglibs/standard/trunk/impl/pom.xml?rev=1006240&r1=1006239&r2=1006240&view=diff
==
--- tomcat/taglibs/standard/trunk/impl/pom.xml (original)
+++ tomcat/taglibs/standard/trunk/impl/pom.xml Sun Oct 10 01:00:38 2010
@@ -131,13 +131,6 @@
 org.apache.maven.plugins
 maven-surefire-plugin
 
-  
-
org/apache/taglibs/standard/lang/jstl/test/StaticFunctionTests.java
-org/apache/taglibs/standard/TestVersion.java
-
org/apache/taglibs/standard/resources/TestResources.java
-
org/apache/taglibs/standard/tag/common/core/TestSetSupport.java
-
org/apache/taglibs/standard/tag/common/xml/TestTransformSupport.java
-  
   
 
 

Copied: 
tomcat/taglibs/standard/trunk/impl/src/test/java/org/apache/taglibs/standard/VersionTest.java
 (from r1006238, 
tomcat/taglibs/standard/trunk/impl/src/test/java/org/apache/taglibs/standard/TestVersion.java)
URL: 
http://svn.apache.org/viewvc/tomcat/taglibs/standard/trunk/impl/src/test/java/org/apache/taglibs/standard/VersionTest.java?p2=tomcat/taglibs/standard/trunk/impl/src/test/java/org/apache/taglibs/standard/VersionTest.java&p1=tomcat/taglibs/standard/trunk/impl/src/test/java/org/apache/taglibs/standard/TestVersion.java&r1=1006238&r2=1006240&rev=1006240&view=diff
==
--- 
tomcat/taglibs/standard/trunk/impl/src/test/java/org/apache/taglibs/standard/TestVersion.java
 (original)
+++ 
tomcat/taglibs/standard/trunk/impl/src/test/java/org/apache/taglibs/standard/VersionTest.java
 Sun Oct 10 01:00:38 2010
@@ -19,11 +19,11 @@ package org.apache.taglibs.standard;
 
 import junit.framework.*;
 
-public class TestVersion
+public class VersionTest
 extends TestCase {
 private Version version = null;
 
-public TestVersion(String name) {
+public VersionTest(String name) {
 super(name);
 }
 

Propchange: 
tomcat/taglibs/standard/trunk/impl/src/tes

svn commit: r1006241 - /tomcat/taglibs/taglibs-parent/trunk/

2010-10-09 Thread jboynes
Author: jboynes
Date: Sun Oct 10 01:01:58 2010
New Revision: 1006241

URL: http://svn.apache.org/viewvc?rev=1006241&view=rev
Log:
ignore IDE files

Modified:
tomcat/taglibs/taglibs-parent/trunk/   (props changed)

Propchange: tomcat/taglibs/taglibs-parent/trunk/
--
--- svn:ignore (added)
+++ svn:ignore Sun Oct 10 01:01:58 2010
@@ -0,0 +1 @@
+*.iml



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1006242 - /tomcat/taglibs/standard/trunk/standard-test/

2010-10-09 Thread jboynes
Author: jboynes
Date: Sun Oct 10 01:04:29 2010
New Revision: 1006242

URL: http://svn.apache.org/viewvc?rev=1006242&view=rev
Log:
ignore test files

Modified:
tomcat/taglibs/standard/trunk/standard-test/   (props changed)

Propchange: tomcat/taglibs/standard/trunk/standard-test/
--
--- svn:ignore (original)
+++ svn:ignore Sun Oct 10 01:04:29 2010
@@ -1,2 +1,4 @@
 target
 *.iml
+cactustest
+derby.log



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1006243 - in /tomcat/taglibs/standard/trunk/src: main/ test/

2010-10-09 Thread jboynes
Author: jboynes
Date: Sun Oct 10 01:08:47 2010
New Revision: 1006243

URL: http://svn.apache.org/viewvc?rev=1006243&view=rev
Log:
remove empty directories

Removed:
tomcat/taglibs/standard/trunk/src/main/
tomcat/taglibs/standard/trunk/src/test/


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1006244 - /tomcat/taglibs/standard/trunk/impl/pom.xml

2010-10-09 Thread jboynes
Author: jboynes
Date: Sun Oct 10 01:12:22 2010
New Revision: 1006244

URL: http://svn.apache.org/viewvc?rev=1006244&view=rev
Log:
remove duplicate dependency

Modified:
tomcat/taglibs/standard/trunk/impl/pom.xml

Modified: tomcat/taglibs/standard/trunk/impl/pom.xml
URL: 
http://svn.apache.org/viewvc/tomcat/taglibs/standard/trunk/impl/pom.xml?rev=1006244&r1=1006243&r2=1006244&view=diff
==
--- tomcat/taglibs/standard/trunk/impl/pom.xml (original)
+++ tomcat/taglibs/standard/trunk/impl/pom.xml Sun Oct 10 01:12:22 2010
@@ -69,11 +69,6 @@
 
   
   
-  junit
-  junit
-  4.8.1
-  
-  
   org.apache.taglibs
   taglibs-standard-spec
   1.2-SNAPSHOT



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 50065] Wrong handling of non-latin1 characters in HTTP request parameters.

2010-10-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50065

--- Comment #1 from Chuck Caldarale  2010-10-09 
22:38:38 EDT ---
(In reply to comment #0)
> It seems that after URL-decoding a parameter value that value is treated as a
> string in some 1-byte charset, but not as a string encoded with a charset
> specified by http's request character encoding.

So where in the RFCs or EE specs can you find justification for the behavior
you wish to see versus the behavior Tomcat exhibits?

To quote from section 14.17 of RFC 2616:

"The Content-Type entity-header field indicates the media type of the
entity-body sent to the recipient"

Note the reference to the entity-body; it says nothing about the parameters on
the URI - which are interpreted as ISO-8859-1, since there is no standard to
allow URIs in other character sets.  You can specify the  attributes
URIEncoding or useBodyEncodingForURI in the Tomcat config if you want to change
the default behavior.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org