svn commit: r996261 - in /tomcat/trunk/java/org/apache: coyote/http11/Http11Processor.java tomcat/util/net/AbstractEndpoint.java tomcat/util/net/JIoEndpoint.java

[markt]

Author: markt
Date: Sun Sep 12 08:05:35 2010
New Revision: 996261

URL: http://svn.apache.org/viewvc?rev=996261&view=rev
Log:
Fix Eclipse warnings prior to working on bz49884 refactoring

Modified:
tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java
tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java
tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java

Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java?rev=996261&r1=996260&r2=996261&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java (original)
+++ tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java Sun Sep 12 
08:05:35 2010
@@ -325,7 +325,7 @@ public class Http11Processor extends Abs
 }
 
 
-public SocketState asyncDispatch(SocketStatus status) throws IOException {
+public SocketState asyncDispatch(SocketStatus status) {
 
 RequestInfo rp = request.getRequestProcessor();
 try {
@@ -405,6 +405,7 @@ public class Http11Processor extends Abs
  * @param actionCode Type of the action
  * @param param Action parameter
  */
+@Override
 public void action(ActionCode actionCode, Object param) {
 
 if (actionCode == ActionCode.ACTION_COMMIT) {

Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java?rev=996261&r1=996260&r2=996261&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java 
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java Sun Sep 
12 08:05:35 2010
@@ -462,15 +462,16 @@ public abstract class AbstractEndpoint {
 public abstract void destroy() throws Exception;
 
 public String adjustRelativePath(String path, String relativeTo) {
-File f = new File(path);
+String newPath = path;
+File f = new File(newPath);
 if ( !f.isAbsolute()) {
-path = relativeTo + File.separator + path;
-f = new File(path);
+newPath = relativeTo + File.separator + newPath;
+f = new File(newPath);
 }
 if (!f.exists()) {
-getLog().warn("configured file:["+path+"] does not exist.");
+getLog().warn("configured file:["+newPath+"] does not exist.");
 }
-return path;
+return newPath;
 }
 
 public String defaultIfNull(String val, String defaultValue) {

Modified: tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java?rev=996261&r1=996260&r2=996261&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java Sun Sep 12 
08:05:35 2010
@@ -239,6 +239,7 @@ public class JIoEndpoint extends Abstrac
 this.status = status;
 }
 
+@Override
 public void run() {
 boolean launch = false;
 try {
@@ -551,6 +552,7 @@ public class JIoEndpoint extends Abstrac
 this.cl = cl;
 }
 
+@Override
 public Void run() {
 Thread.currentThread().setContextClassLoader(cl);
 return null;



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: DO NOT REPLY [Bug 49234] JMX Descriptor Modifications

[Rainer Jung]

On 12.09.2010 03:45, bugzi...@apache.org wrote:

https://issues.apache.org/bugzilla/show_bug.cgi?id=49234

--- Comment #93 from Mark Thomas  2010-09-11 21:44:59 EDT ---
I got to the bottom of the problem. The correct parent class loader was not
being passed down the object hierarchy. I fixed that and applied your patch. I
can now get to the point where I can create a context with static content and
JSPs via JMX from a server.xml that just contains a Server object. Woot!


Nice!

Rainer

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Adding Host node to server.xml

[Wesley Acheson]

Hi,

I'm looking at adding a host node to server.xml on the 6.0 branch via
host manager, If I get this correct there can be more than one service
node which in turn has one Engine which contains the hosts.

So assuming there are multiple Service nodes how do I know which
Engine node to add the Host node to?

does (Service) host.getParent() make sense, If so is service name both
compulsory and guaranteed to be unique?

Regards,

Wes

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Adding Host node to server.xml

[Mark Thomas]

On 12/09/2010 09:59, Wesley Acheson wrote:
> Hi,
> 
> I'm looking at adding a host node to server.xml on the 6.0 branch via
> host manager, If I get this correct there can be more than one service
> node which in turn has one Engine which contains the hosts.
> 
> So assuming there are multiple Service nodes how do I know which
> Engine node to add the Host node to?

Take a look at how the Host manager adds hosts currently. It will add
them to the correct engine.

> does (Service) host.getParent() make sense, If so is service name both
> compulsory and guaranteed to be unique?

Get the correct engine the way host manager does (or something similar).
You then want engine.getService()

Yes, you can safely assume service names are a) non-null and b) unique.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Adding Host node to server.xml

[Wesley Acheson]

On Sun, Sep 12, 2010 at 11:28 AM, Mark Thomas  wrote:
> On 12/09/2010 09:59, Wesley Acheson wrote:

>> does (Service) host.getParent() make sense, If so is service name both
>> compulsory and guaranteed to be unique?
>
> Get the correct engine the way host manager does (or something similar).
> You then want engine.getService()
>
> Yes, you can safely assume service names are a) non-null and b) unique.
>
> Mark
>

I may be being blind, but I don't find any references to service for
the HostManager. The engine is found by host.getParent(). I assume
(okay I missed out a node there) Its okay for (Service)
engine.getService().

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 49917] New: Wrong invocation sequence of javax.servlet.ServletRequestListener after request

[bugzilla]

https://issues.apache.org/bugzilla/show_bug.cgi?id=49917

   Summary: Wrong invocation sequence of
javax.servlet.ServletRequestListener after request
   Product: Tomcat 6
   Version: 6.0.29
  Platform: All
OS/Version: All
Status: NEW
  Severity: minor
  Priority: P2
 Component: Catalina
AssignedTo: dev@tomcat.apache.org
ReportedBy: erling.mo...@infored.no


org.apache.catalina.core.StandardContextValve.invoke(Request, Response):

javax.servlet.ServletRequestListener instances are called in the same sequence
after (requestDestroyed) the request as they are before (requestInitialized).

I suspect this is an error, as other listeners are called in reverse order on
exit.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Bug report for Tomcat 5 [2010/09/12]

[bugzilla]

+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|27122|Opn|Enh|2004-02-20|IE plugins cannot access components through Tomcat|
|28039|Opn|Enh|2004-03-30|Cluster Support for SingleSignOn  |
|29494|Inf|Enh|2004-06-10|No way to set PATH when running as a service on Wi|
|33262|Inf|Enh|2005-01-27|Service Manager autostart should check for adminis|
|33453|Opn|Enh|2005-02-08|Jasper should recompile JSP files whose datestamps|
|33671|Opn|Enh|2005-02-21|Manual Windows service installation with custom na|
|34801|New|Enh|2005-05-08|PATCH: CGIServlet does not terminate child after a|
|34805|Ass|Enh|2005-05-08|warn about invalid security constraint url pattern|
|34868|Ass|Enh|2005-05-11|allow to register a trust store for a session that|
|35054|Inf|Enh|2005-05-25|warn if appBase is not existing as a File or direc|
|36362|New|Enh|2005-08-25|missing check for Java reserved keywords in tag fi|
|36569|Inf|Enh|2005-09-09|Redirects produce illegal URL's   |
|36837|Inf|Enh|2005-09-28|Looking for ProxyHandler implementation of Http re|
|36922|Inf|Enh|2005-10-04|setup.sh file mis-advertised and missing  |
|37018|Ass|Enh|2005-10-11|Document how to use tomcat-SSL with a pkcs11 token|
|37334|Inf|Enh|2005-11-02|Realm digest property not aligned with the adminis|
|38216|Inf|Enh|2006-01-10|Extend Jmxproxy to allow call of MBean Operations |
|38268|Inf|Enh|2006-01-13|User friendly: Need submit button on adding/deleti|
|38360|Inf|Enh|2006-01-24|Domain for session cookies|
|38546|Inf|Enh|2006-02-07|Google bot sends invalid If-Modifed-Since Header, |
|38577|Inf|Enh|2006-02-08|Enhance logging of security failures  |
|38916|Inf|Enh|2006-03-10|HttpServletRequest cannot handle multipart request|
|39053|Inf|Enh|2006-03-21|include Tomcat embedded sample|
|39740|New|Enh|2006-06-07|semi-colon ; isn't allowed as a query argument sep|
|39862|Inf|Enh|2006-06-22|provide support for protocol-independent GenericSe|
|40211|Inf|Enh|2006-08-08|Compiled JSP don't indent HTML code   |
|40402|New|Enh|2006-09-03|Manager should display Exceptions |
|40510|New|Enh|2006-09-14|installer does not create shortcuts for all users |
|40712|New|Enh|2006-10-10|Realm admin error.|
|40728|Inf|Enh|2006-10-11|Catalina MBeans use non-serializable classes  |
|40766|New|Enh|2006-10-16|Using an unsecure jsessionid with mod_proxy_ajp ov|
|40881|Opn|Enh|2006-11-02|Unable to receive message through  TCP channel -> |
|41007|Opn|Enh|2006-11-20|Can't define customized 503 error page|
|41179|New|Enh|2006-12-15|400 Bad Request response during auto re-deployment|
|41227|Opn|Enh|2006-12-21|When the jasper compiler fails to compile a JSP, i|
|41337|Opn|Enh|2007-01-10|Display an error page if no cert is available on C|
|41496|New|Enh|2007-01-30|set a security provider for jsse in a connector co|
|41498|New|Enh|2007-01-30|allRolesMode Realm configuration option not docume|
|41539|Inf|Enh|2007-02-05|NullPointerException during Embedded tomcat restar|
|41673|New|Enh|2007-02-21|Jasper output the message of compiling error using|
|41697|Ver|Enh|2007-02-25|make visible in debug output if charset from brows|
|41709|Inf|Enh|2007-02-26|When calling the API that relates to the buffer af|
|41718|New|Enh|2007-02-27|Status 302 response to GET request has no body whe|
|42416|New|Enh|2007-05-14|Tomcat startup hangs and AJP13 connector port 8009|
|43423|New|Enh|2007-09-18|catalina.sh -force too fast   |
|43538|New|Enh|2007-10-02|[patch] Show the hostname and IP address in the ma|
|43796|Inf|Enh|2007-11-05|Add MIME type mapping for the "log" extension |
|43866|New|Enh|2007-11-14|add support for session attribute propagation with|
|43925|Opn|Enh|2007-11-21|org.apache.jasper.runtime.BodyContentImpl causing |
|43960|New|Enh|2007-11-26|Expose StandardWrapper unavailable and/or availabl|
|43991|New|Enh|2007-11-29|Contributing a URLResourceFactory |
|44216|

Bug report for Taglibs [2010/09/12]

[bugzilla]

+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|27717|New|Maj|2004-03-16| very slow in JSTL 1.1 |
|33934|New|Cri|2005-03-09|[standard] memory leak in jstl c:set tag  |
|38193|Ass|Enh|2006-01-09|[RDC] BuiltIn Grammar support for Field   |
|38600|Ass|Enh|2006-02-10|[RDC] Enable RDCs to be used in X+V markup (X+RDC)|
|42413|New|Nor|2007-05-14|[PATCH] Log Taglib enhancements   |
|43640|New|Nor|2007-10-16|Move the tests package to JUnit   |
|45197|Ass|Nor|2008-06-12|Need to support the JSTL 1.2 specification|
|46052|New|Nor|2008-10-21|SetLocaleSupport is slow to initialize when many l|
|48333|New|Nor|2009-12-02|TLD generator |
|48773|New|Nor|2010-02-19|DataSourceWrapper and DriverManager problems  |
|49292|New|Nor|2010-05-14|Memory leak in org.apache.taglibs.standard.lang.js|
|49578|New|Nor|2010-07-09|XPath handling only supports single reference to v|
|49900|New|Nor|2010-09-08|BundleSupport.release() does not call super.releas|
+-+---+---+--+--+
| Total   13 bugs   |
+---+

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Bug report for Tomcat 7 [2010/09/12]

[bugzilla]

+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|48550|New|Enh|2010-01-14|Update examples and default server.xml to use UTF-|
|48692|New|Enh|2010-02-07|Provide option to parse application/x-www-form-url|
|48837|New|Enh|2010-03-01|Memory leaks protection does not cure leaks trigge|
|48870|New|Enh|2010-03-08|avoid parallel arrays of base types   |
|48892|New|Enh|2010-03-11|Use URIEncoding from server.xml for decoding post |
|49000|New|Enh|2010-03-26|Cookie parsing bug when an empty value has an equa|
|49100|New|Enh|2010-04-12|Mutable public constants: MemberImpl.TRIBES_MBR_BE|
|49101|New|Enh|2010-04-12|All constants in tribes.transport.Constants are mu|
|49102|New|Enh|2010-04-12|coyote.ajp.Constants - 3 "constant" arrays are mut|
|49125|New|Enh|2010-04-14|toString on byte[] array probably is not correct  |
|49126|New|Enh|2010-04-14|jasper.compiler.Generator.createJspId() can genera|
|49142|New|Enh|2010-04-16|Missing serialVersionUIDs |
|49159|New|Enh|2010-04-20|Improve ThreadLocal memory leak clean-up  |
|49165|New|Enh|2010-04-21|Enhancement - Allow %{TIME_FORMAT}t As Configurati|
|49180|New|Enh|2010-04-24|Add option to disable log rotation in FileHandler.|
|49234|New|Nor|2010-04-30|JMX Descriptor Modifications  |
|49284|New|Enh|2010-05-12|Implement SSL renegotiation for the NIO connector |
|49290|New|Enh|2010-05-14|Using a JarScanner with scanAllDirectories=true ca|
|49295|New|Enh|2010-05-14|JMXAccessorTask.getProperties() - return Propertie|
|49297|New|Min|2010-05-15|Whitespace absence is allowed before attribute nam|
|49317|New|Enh|2010-05-20|org.apache.catalina.util.Base64 interface needs re|
|49318|New|Enh|2010-05-20|add a Negotiate (Kerberos/NTLM) authenticator / in|
|49395|New|Enh|2010-06-06|manager.findLeaks : display the date when the leak|
|49426|New|Nor|2010-06-11|Manager app wrongly localized |
|49589|New|Enh|2010-07-12|Tag handlers with constant attribute values are al|
|49591|New|Enh|2010-07-13|Custom error page always uses Transfer-Encoding: c|
|49650|New|Enh|2010-07-26|Streamline package.access property definition in c|
|49683|New|Nor|2010-08-01|Separate keep-alive and connection timeout with AP|
|49711|New|Enh|2010-08-05|HttpServletRequest#getParts() does not work in a F|
|49785|New|Enh|2010-08-19|Enabling TLS for JNDIRealm|
|49819|New|Enh|2010-08-25|Improved index.html for default ROOT application  |
|49821|New|Enh|2010-08-25|Tomcat CLI|
|49884|New|Nor|2010-09-04|NullPointerException in org.apache.catalina.core.A|
|49909|New|Nor|2010-09-10|jstl 1.2 not support  |
|49914|New|Nor|2010-09-10|Filter on url-pattern of "/" is not invoked   |
|49916|New|Nor|2010-09-11|use an init-param for jspFile on explicit jsp serv|
+-+---+---+--+--+
| Total   36 bugs   |
+---+

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Bug report for Tomcat Connectors [2010/09/12]

[bugzilla]

+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|34526|Opn|Nor|2005-04-19|Truncated content in decompressed requests from mo|
|35959|Opn|Enh|2005-08-01|mod_jk not independant of UseCanonicalName|
|36155|Opn|Nor|2005-08-12|tomcat chooses wrong host if using mod_jk |
|39967|Inf|Nor|2006-07-05|mod_jk gives segmentation fault when apache is sta|
|40208|Inf|Nor|2006-08-08|Request-Dump when ErrorDocument in httpd.conf is a|
|41170|Inf|Nor|2006-12-13|single crlf in header termination crashes app.|
|41923|Opn|Nor|2007-03-21|Tomcat doesnt recognized client abort |
|42366|Inf|Nor|2007-05-09|Memory leak in newer mod_jk version when connectio|
|42554|Opn|Nor|2007-05-31|mod_ssl + mod_jk with status_worker does not work |
|43303|New|Enh|2007-09-04|Versioning under Windows not reported by many conn|
|43968|New|Enh|2007-11-26|[patch] support ipv6 with mod_jk  |
|44290|New|Nor|2008-01-24|mod_jk/1.2.26: retry is not useful for an importan|
|44349|New|Maj|2008-02-04|mod_jk/1.2.26 module does not read worker.status.s|
|44379|New|Enh|2008-02-07|convert the output of strftime into UTF-8 |
|44454|New|Nor|2008-02-19|busy count reported in mod_jk inflated, causes inc|
|44571|New|Enh|2008-03-10|Limits busy per worker to a threshold |
|45063|New|Nor|2008-05-22|JK-1.2.26 IIS ISAPI filter issue when running diff|
|45313|New|Nor|2008-06-30|mod_jk 1.2.26 & apache 2.2.9 static compiled on so|
|45395|New|Min|2008-07-14|MsgAjp dump method does not dump packet when being|
|46337|New|Nor|2008-12-04|real worker name is wrong |
|46406|New|Enh|2008-12-16|Supporting relative paths in isapi_redirect.proper|
|46676|New|Enh|2009-02-09|Configurable test request for Watchdog thread |
|46767|New|Enh|2009-02-25|mod_jk to send DECLINED in case no fail-over tomca|
|47038|New|Enh|2009-04-15|USE_FLOCK_LK redefined compiler warning when using|
|47327|New|Enh|2009-06-07|remote_user not logged in apache logfile  |
|47617|New|Enh|2009-07-31|include time spent doing ajp_get_endpoint() in err|
|47678|New|Nor|2009-08-11|Unable to allocate shared memory when using isapi_|
|47679|New|Nor|2009-08-11|Not all headers get passed to Tomcat server from i|
|47692|New|Reg|2009-08-12|Can not compile mod_jk with apache2.0.63 and tomca|
|47714|New|Cri|2009-08-20|Reponse mixed between users   |
|47750|New|Maj|2009-08-27|Loss of worker settings when changing via jkstatus|
|47795|New|Maj|2009-09-07|service sticky_session not being set correctly wit|
|47840|Inf|Min|2009-09-14|A broken worker name is written in the log file.  |
|48191|New|Maj|2009-11-13|Problem with mod_jk 1.2.28 - Can not render up the|
|48490|New|Nor|2010-01-05|Changing a node to stopped in uriworkermap.propert|
|48501|New|Enh|2010-01-07|Log rotation for ISAPI Redirector |
|48513|New|Enh|2010-01-09|IIS Quick setup instructions  |
|48564|New|Nor|2010-01-18|Unable to turn off retries for LB worker  |
|48830|New|Nor|2010-03-01|IIS shutdown blocked in endpoint service when serv|
|48891|Opn|Enh|2010-03-11|Missing EOL-style settings in tomcat/jk/trunk |
|48925|New|Maj|2010-03-16|((ServletRequest) request).getLocalAddr() returns |
|48940|New|Maj|2010-03-18|IIS to Tomcat occasionally fails on POST with T-E |
|49035|New|Maj|2010-04-01|data lost when post a multipart/form-data form|
|49048|New|Nor|2010-04-05|ACL not applied to redirect URLs  |
|49063|New|Enh|2010-04-07|Please add JkStripSession status in jk-status work|
|49135|New|Enh|2010-04-16|SPDY Connector for The Tomcat |
|49413|Opn|Reg|2010-06-09|Apache Mod_jk 1.2.30 is shutting down communicatio|
|49469|New|Enh|2010-06-19|Workers status page has negative number of connect|
|49511|New|Maj|2010-06-28|IIS 7.5 incorrect logging: pfc->pFilterContext is |
|49822|New|Enh|2010-08-25|Add hash lb worker method |
|49903|New|Enh|2010-09-09|Make workers file reloadable  |
+-+

Bug report for Tomcat Native [2010/09/12]

[bugzilla]

+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|38372|Inf|Cri|2006-01-25|tcnative-1.dll response overflow corruption, parti|
|41361|New|Nor|2007-01-14|Content lost when read by a slow client.  |
|42090|New|Cri|2007-04-11|tcnative badly handles some OpenSSL disconnections|
|45392|New|Nor|2008-07-14|No OCSP support for client SSL verification   |
|46041|New|Cri|2008-10-20|Tomcat service is terminated unexpectedly (tcnativ|
|46179|New|Maj|2008-11-10|apr ssl client authentication |
|46571|New|Nor|2009-01-21|tcnative blocks in APR poll on Solaris|
|47319|New|Nor|2009-06-05|With APR, getRemoteHost() returns NULL for unknown|
|47851|New|Nor|2009-09-16|thread-safety issues in the TC native Java code   |
|48253|New|Min|2009-11-20|Tomcat Native patch - adding dynamic locking callb|
|48655|New|Nor|2010-02-02|Active multipart downloads prevent tomcat shutdown|
|49038|Inf|Nor|2010-04-02|Crash in tcnative |
|49556|New|Cri|2010-07-05|the proc.create function used args as env to get t|
|49557|New|Cri|2010-07-05|index erro in the loop to get the env info in the |
|49595|New|Cri|2010-07-15|Tomcat crashes in tcnative-1.dll frequently   |
|49851|New|Blk|2010-08-31|JNI Registry.deleteKey and Registry.deleteValue co|
+-+---+---+--+--+
| Total   16 bugs   |
+---+

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Bug report for Tomcat 6 [2010/09/12]

[bugzilla]

+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|39661|Opn|Enh|2006-05-25|Please document JULI FileHandler configuration pro|
|41128|Inf|Enh|2006-12-07|Reference to java Thread name from RequestProcesso|
|41679|New|Enh|2007-02-22|SemaphoreValve should be able to filter on url pat|
|41791|New|Enh|2007-03-07|Tomcat behaves inconsistently concerning flush-pac|
|41883|Ass|Enh|2007-03-18|use abstract wrapper instead of plain X509Certific|
|41944|New|Enh|2007-03-25|Start running the RAT tool to see where we're miss|
|41992|New|Enh|2007-03-30|Need ability to set OS process title  |
|42463|New|Enh|2007-05-20|"crossContext" and classloader issues - pls amend |
|43001|New|Enh|2007-07-30|JspC lacks setMappedFile and setDie for use in Ant|
|43003|New|Enh|2007-07-30|Separate dependent component download and build ta|
|43400|New|Enh|2007-09-14|enum support for tag libs |
|43497|New|Enh|2007-09-26|Add ability to escape rendered output of JSP expre|
|43548|Opn|Enh|2007-10-04|xml schema for tomcat-users.xml   |
|43642|New|Enh|2007-10-17|Add prestartminSpareThreads attribute for Executor|
|43682|New|Enh|2007-10-23|JULI: web-inf/classes/logging.properties to suppor|
|43742|New|Enh|2007-10-30|.tag compiles  performed one at a time -- extremel|
|43790|Ass|Enh|2007-11-03|concurrent access issue on TagHandlerPool |
|43979|New|Enh|2007-11-27|Add abstraction for Java and Classfile output |
|44047|New|Enh|2007-12-10|Provide a way for Tomcat to serve up error pages w|
|44199|New|Enh|2008-01-10|expose current backlog queue size |
|44225|New|Enh|2008-01-14|SSL connector tries to load the private keystore f|
|44264|New|Enh|2008-01-18|Clustering - Support for disabling multicasting an|
|44284|New|Enh|2008-01-23|Support java.lang.Iterable in c:forEach tag   |
|44294|New|Enh|2008-01-25|Support for EL functions with varargs |
|44299|New|Enh|2008-01-26|Provider manager app with a log out button|
|44312|New|Enh|2008-01-28|Warn when overwritting docBase of the default Host|
|44598|New|Enh|2008-03-13|JAASRealm is suppressing Exceptions   |
|44645|New|Enh|2008-03-20|[Patch] JNDIRealm - Doesn't support JNDI "java.nam|
|44787|New|Enh|2008-04-09|provide more error context on "java.lang.IllegalSt|
|44818|New|Enh|2008-04-13|tomcat hangs with GET when content-length is defin|
|45014|New|Enh|2008-05-15|Request and Response classes should have wrappers |
|45282|New|Enh|2008-06-25|NioReceiver doesn't close cleanly, leaving sockets|
|45283|Opn|Enh|2008-06-25|Allow multiple authenticators to be added to pipel|
|45428|New|Enh|2008-07-18|warn if the tomcat stop doesn't complete  |
|45654|New|Enh|2008-08-19|use static methods and attributes in a direct way!|
|45731|New|Enh|2008-09-02|Enhancement request : pluggable httpsession cache |
|45832|New|Enh|2008-09-18|add DIGEST authentication support to Ant tasks|
|45871|New|Enh|2008-09-23|Support for salted and digested patches in DataSou|
|45878|New|Enh|2008-09-24|Generated jars do not contain proper manifests or |
|45879|Opn|Enh|2008-09-24|Windows installer fails to install NOTICE and RELE|
|45931|Opn|Enh|2008-10-01|trimSpaces incorrectly modifies output|
|45995|New|Enh|2008-10-13|RFE - MIME type extension not case sensitive  |
|46173|New|Enh|2008-11-09|Small patch for manager app: Setting an optional c|
|46263|New|Enh|2008-11-21|Tomcat reloading of context does not update contex|
|46264|New|Enh|2008-11-21|Shutting down tomcat with large number of contexts|
|46284|New|Enh|2008-11-24|Add flag to DeltaManager that blocks processing cl|
|46350|New|Enh|2008-12-05|Maven repository should contain source bundles|
|46451|New|Enh|2008-12-30|Configure svn:bugtraq properties  |
|46461|New|Enh|2009-01-01|fail graceful on dns changes for connectors/hosts |
|46497|New|Enh|2009-01-08|Install Tomcat Deployer/ANT on Windows Platform   |
|46558|New|Enh|2009-01-19|Shutdown port with address binding|
|46655|

Bug report for Tomcat Modules [2010/09/12]

[bugzilla]

+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|48240|New|Nor|2009-11-19|Tomcat-Lite missing @Override markers |
|48268|New|Nor|2009-11-23|Patch to fix generics in tomcat-lite  |
|48861|New|Nor|2010-03-04|Files without AL headers  |
|49543|New|Enh|2010-07-02|Request for a "shared" datasource configuration as|
|49584|New|Nor|2010-07-12|Borrowers Getting Stuck   |
|49685|New|Nor|2010-08-02|Unsafe synchronization in class ManagedBean   |
|49686|New|Nor|2010-08-02|Using an instance lock to protect static shared da|
+-+---+---+--+--+
| Total7 bugs   |
+---+

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 49914] Filter on url-pattern of "/" is not invoked

[bugzilla]

https://issues.apache.org/bugzilla/show_bug.cgi?id=49914

--- Comment #1 from Martin Gainty  2010-09-12 09:03:17 EDT 
---
  /* same as TC 6 up until checkUnusualURLPattern  */
/**
 * Validate the syntax of a proposed 
 * for conformance with specification requirements.
 *
 * @param urlPattern URL pattern to be validated
 */
private boolean validateURLPattern(String urlPattern) {
if (urlPattern == null)
return (false);
if (urlPattern.indexOf('\n') >= 0 || urlPattern.indexOf('\r') >= 0) {
return (false);
}
if (urlPattern.startsWith("*.")) {
if (urlPattern.indexOf('/') < 0) {
checkUnusualURLPattern(urlPattern);
return (true);
} else
return (false);
}
if ( (urlPattern.startsWith("/")) &&
(urlPattern.indexOf("*.") < 0)) {
checkUnusualURLPattern(urlPattern);
return (true);
} else
return (false);
}

/**
 * Check for unusual but valid s.
 * See Bugzilla 34805, 43079 & 43080
 */
private void checkUnusualURLPattern(String urlPattern) {
if (log.isInfoEnabled()) {
if(urlPattern.endsWith("*") && (urlPattern.length() < 2 ||
urlPattern.charAt(urlPattern.length()-2) != '/')) {
log.info("Suspicious url pattern: \"" + urlPattern + "\"" +
" in context [" + getName() + "] - see" +
" section SRV.11.2 of the Servlet specification" );
}
}
}

/*TESTCASE: if the url-pattern is / then urlPattern.length() =1 and the
  urlPattern.charAt(urlPattern.length()-2) is urlPattern.charAt(-1)
  would throw NPE
  fix would be to have checkUnusualURLPattern throw NPE as here */
private boolean validateURLPattern(String urlPattern) {
if (urlPattern == null)
return (false);
if (urlPattern.indexOf('\n') >= 0 || urlPattern.indexOf('\r') >= 0) {
return (false);
}
if (urlPattern.startsWith("*.")) {
if (urlPattern.indexOf('/') < 0) {
checkUnusualURLPattern(urlPattern);
return (true);
} else
return (false);
}
if ( (urlPattern.startsWith("/")) &&
(urlPattern.indexOf("*.") < 0)) 
{
  try
  {
checkUnusualURLPattern(urlPattern);
  }
  catch(NullPointerException npe)
  {
   System.err.println("checkUnusualURLPattern has thrown NPE for
urlPattern="+urlPattern+" message="+npe.getMessage());
  }
  return (true);
} else
return (false);
}
/*change checkUnusualURLPattern method to throw NPE */
private void checkUnusualURLPattern(String urlPattern) throws
NullPointerException {
if (log.isInfoEnabled()) 
{
 try
 {
if(urlPattern.endsWith("*") && (urlPattern.length() < 2 ||
urlPattern.charAt(urlPattern.length()-2) != '/')) 
{
log.info("Suspicious url pattern: \"" + urlPattern + "\"" +
" in context [" + getName() + "] - see" +
" section SRV.11.2 of the Servlet specification" );
}
}
catch(NullPointerException npe)
{ //re throw NPE
  throw NullPointerException(npe.getMessage());
}
}

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 49917] Wrong invocation sequence of javax.servlet.ServletRequestListener after request

[bugzilla]

https://issues.apache.org/bugzilla/show_bug.cgi?id=49917

--- Comment #1 from Chuck Caldarale  2010-09-12 
09:57:00 EDT ---
(In reply to comment #0)
> javax.servlet.ServletRequestListener instances are called in the same sequence
> after (requestDestroyed) the request as they are before (requestInitialized).

As stated in SRV.10.3.3 of the spec:

"The Web container registers the listener instances according to the interfaces
they implement and the order in which they appear in the deployment descriptor.
During Web application execution, listeners are invoked in the order of their
registration."

Section SRV.10.3.4 of the spec explicitly states reverse invocations is done
only for shutdown events:

"On application shutdown, listeners are notified in reverse order to their
declarations with notifications to session listeners preceeding [sic]
notifications to context listeners.  Session listeners must be notified of
session invalidations prior to context listeners being notified of application
shutdown."

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 49917] Wrong invocation sequence of javax.servlet.ServletRequestListener after request

[bugzilla]

https://issues.apache.org/bugzilla/show_bug.cgi?id=49917

Chuck Caldarale  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Async refactoring

[Mark Thomas]

Digging into the root causes of [1] it appears that there are a number
of threading / timing issues with the current AsyncContextImpl. Running
the provided test case with ab -n 50 -c 20 triggers the error every
couple of runs. The error appears to occur when the thread where
complete() is called finishes before the thread where startAsync() is
called.

There were a number of places / ways this could happen:
- the checks if current state are not thread safe
- the state changes are atomic but the actions that are part of that
state were not atomic
- the spec requirement the complete() and dispatch() must wait until the
thread where startAsync() is called completes are not met
- socket level processing is handled by the executor so there is no
guarantee of processing order

I had a couple of false starts trying to fix this but my current attempt
[2] is showing some promise. The test case from [1] runs without error
with ab -n 5000 -c 400 with or without -k.

At the moment [2] is in a very rough and ready state and only handles
startAsync() and complete() for the BIO HTTP connector. I wanted to give
folks early sight of this patch so I could incorporate any early feedback.

I plan to expand the patch to cover dispatch(), timeouts, the other
connectors, passing our test cases and passing the TCK before
committing. I'm not sure how long that will take. I hope to get this
done this week.

Mark

[1] https://issues.apache.org/bugzilla/show_bug.cgi?id=49884
[2]
http://people.apache.org/~markt/patches/2010-09-12-async-refactoring.patch

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 48674] Tomcat Virtual Host Manager application doesn't persist newly created virtual hosts

[bugzilla]

https://issues.apache.org/bugzilla/show_bug.cgi?id=48674

--- Comment #3 from Wesley  2010-09-12 14:40:28 EDT 
---
Created an attachment (id=26019)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26019)
Rough patch to provide persistance to the host manager.

This needs some cleanup but it is functional.

At tbe meoment errors are being swallowed. I'm not sure what to do with the
though.

Should the manager show success if the runtime addition was successful but the
persistent addition wasn't?

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 48674] Tomcat Virtual Host Manager application doesn't persist newly created virtual hosts

[bugzilla]

https://issues.apache.org/bugzilla/show_bug.cgi?id=48674

Wesley  changed:

   What|Removed |Added

 CC||wesley.ache...@gmail.com
   Platform|PC  |All
Version|6.0.24  |6.0.29
 OS/Version|Linux   |All

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 48501] Log rotation for ISAPI Redirector

[bugzilla]

https://issues.apache.org/bugzilla/show_bug.cgi?id=48501

Tim Whittington  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 49511] IIS 7.5 incorrect logging: pfc->pFilterContext is per-connection not per-request

[bugzilla]

https://issues.apache.org/bugzilla/show_bug.cgi?id=49511

Tim Whittington  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #2 from Tim Whittington  2010-09-12 19:24:44 EDT 
---
What is happening here is:
 - pFilterContext is allocated per connection/session
 - the uri and query are being correctly set on each request (even if
pFilterContext has been allocated)
 - the uri and query are being set correctly in the HTTP_FILTER_LOG structure
 - the uri and query are not overwritten until the next request has started

The documentation of HTTP FILTER_LOG
(http://msdn.microsoft.com/en-us/library/ms525464%28v=VS.90%29.aspx) states
that the memory used for the uri and query variables "must remain valid until
the next filter notification", implying that logging occurs before the next
HttpFilterProc notification.

https://forums.iis.net/p/1156804/1900220.aspx and other forum questions with
response from Microsoft reps seems to support this theory.

It's implicit (and occasionally explicit) in all the ISAPI code and advice that
I've seen (even by Microsoft ISAPI reps) that IIS serialises requests through
the ISAPI filter (even for Keep-Alive and pipelined requests).
i.e. you can expect a sequence of ISAPI event notifications through
HttpFilterProc to conclude before a new sequence starts.
I can find no structure, documentation, or advice on how to implement
per-request data structures (aside from implementing something custom under
pFilterContext), which lends weight to this theory.

However if all this were true, then there would be no issue with the logging in
the redirector now - the memory in pFilterContext is allocated once per
connection, and is consistent from the SF_NOTIFY_LOG event until the subsequent
request is started.

The only explanation I can see for this kind of behaviour then is that the
actual log writing is being done outside the ISAPI event sequence and after the
next request has entered HttpFilterProc and changed the uri and query values.
i.e. we get a something like
 - SF_NOTIFY_PREPROC_HEADERS request 1
 -  request 1
 - SF_NOTIFY_LOG request 1
 - SF_NOTIFY_PREPROC_HEADERS request 2
 - 

If this is the case, then setting pfc->pFilterContext to NULL in the
SF_NOTIFY_LOG seems to be the only fix.

This will introduce a per-request memory growth of sizeof(isapi_log_data_t) (~
4k) that will only be freed on termination of the connection though, which may
be unacceptable. (We could implement a freeing of the previous log data in
SF_NOTIFY_LOG, but we're still not sure that the actual logging would take
place before that event. We could also trim the actual memory usage by using
AllocMem individually on the uri and query parts, rather than allocating a
struct with pre-allocated buffers.)

Posts like this one from David Wang (Microsoft) indicate that this is standard
practice however (I've seen numerous examples and mentions of this technique
from MS reps). The code explicitly NULLs pFilterContext on request start,
without checking whether it was allocated previously for that session.
http://groups.google.ie/group/microsoft.public.platformsdk.internet.server.isapi-dev/msg/8d3a72b740735860


What also doesn't make sense is the assertion in the original report that:

"all requests on the same connection (keep-alive enabled) are logged with the
same (probably the first) request uri (and query string)"

What I would expect to see instead is that some (or in the extreme case) all of
the requests on the same connection are logged with the request uri of a
subsequent request (i.e. not the first, but perhaps the last).

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 49511] IIS 7.5 incorrect logging: pfc->pFilterContext is per-connection not per-request

[bugzilla]

https://issues.apache.org/bugzilla/show_bug.cgi?id=49511

--- Comment #3 from Attila Király  2010-09-13 
02:17:40 EDT ---
I can add the following:
to fix the logging problem I recompiled the isapi redirector with the MS
mentioned code modification (adding pfc->pFilterContext = NULL;). The modified
dll is used in production for 2 months now. The logging problem is gone and the
system is stable. So the fix is good in practice.


"What I would expect to see instead is that some (or in the extreme case) all
of
the requests on the same connection are logged with the request uri of a
subsequent request (i.e. not the first, but perhaps the last)."
I see the logic behind this but what we experienced was the opposit of this.
Even when we made only a single request to a jsp that contained a js file and
the js pulled down a gif (so 3 requests overall) we saw 3 jsp entries in the
log. That was the problem because the log is analyzed and the gif plays a
special role in it. However the gif was never found. I think the reason for
this is that the redirect filter was only set to serve the jsp files (dynamic
content) but the js and gif (the static content) were served by the IIS itself.
So the filter did not update the uri and query info when the js and gif
requests were processed.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 49511] IIS 7.5 incorrect logging: pfc->pFilterContext is per-connection not per-request

[bugzilla]

https://issues.apache.org/bugzilla/show_bug.cgi?id=49511

Attila Király  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org