DO NOT REPLY [Bug 49909] New: jstl 1.2 not support
https://issues.apache.org/bugzilla/show_bug.cgi?id=49909 Summary: jstl 1.2 not support Product: Tomcat 7 Version: trunk Platform: PC Status: NEW Severity: normal Priority: P2 Component: Servlet & JSP API AssignedTo: dev@tomcat.apache.org ReportedBy: dlpo...@163.com Created an attachment (id=26011) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26011) run log I get the R995577 from svn, and complied. Report err when run my webapp that lib include jstl.jar v1.2. But run the examples with jstl.jar v1.1.2 and standard.jar v1.1.2 was work fined. Is the tc7 not support jstal 1.2? The exception stack in the attachment. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49909] jstl 1.2 not support
https://issues.apache.org/bugzilla/show_bug.cgi?id=49909 dl changed: What|Removed |Added Component|Servlet & JSP API |Catalina OS/Version||Windows 7 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49909] jstl 1.2 not support
https://issues.apache.org/bugzilla/show_bug.cgi?id=49909 dl changed: What|Removed |Added OS/Version||All --- Comment #1 from dl 2010-09-10 06:24:43 EDT --- But work fined with jstl V1.2 on version build 2010-08-22 from svn. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r995751 - in /tomcat/jk/trunk/native/common: jk_connect.c jk_connect.h
Author: mturk
Date: Fri Sep 10 11:24:22 2010
New Revision: 995751
URL: http://svn.apache.org/viewvc?rev=995751&view=rev
Log:
Log local socket address
Modified:
tomcat/jk/trunk/native/common/jk_connect.c
tomcat/jk/trunk/native/common/jk_connect.h
Modified: tomcat/jk/trunk/native/common/jk_connect.c
URL:
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/common/jk_connect.c?rev=995751&r1=995750&r2=995751&view=diff
==
--- tomcat/jk/trunk/native/common/jk_connect.c (original)
+++ tomcat/jk/trunk/native/common/jk_connect.c Fri Sep 10 11:24:22 2010
@@ -496,7 +496,7 @@ jk_sock_t jk_open_socket(struct sockaddr
"failed setting SIO_KEEPALIVE_VALS (errno=%d)", errno);
jk_close_socket(sd, l);
JK_TRACE_EXIT(l);
-return JK_INVALID_SOCKET;
+return JK_INVALID_SOCKET;
}
if (JK_IS_DEBUG_LEVEL(l))
jk_log(l, JK_LOG_DEBUG,
@@ -718,9 +718,11 @@ int jk_shutdown_socket(jk_sock_t sd, jk_
}
save_errno = errno;
-if (JK_IS_DEBUG_LEVEL(l))
-jk_log(l, JK_LOG_DEBUG, "About to shutdown socket %d", sd);
-
+if (JK_IS_DEBUG_LEVEL(l)) {
+char buf[64];
+jk_log(l, JK_LOG_DEBUG, "About to shutdown socket %d %s",
+ sd, jk_dump_sinfo(sd, buf));
+}
/* Shut down the socket for write, which will send a FIN
* to the peer.
*/
@@ -935,6 +937,21 @@ char *jk_dump_hinfo(struct sockaddr_in *
return buf;
}
+char *jk_dump_sinfo(jk_sock_t sd, char *buf)
+{
+struct sockaddr_in s_addr;
+socklen_t s_alen;
+
+s_alen = sizeof(struct sockaddr);
+if (getsockname(sd, (struct sockaddr *)&s_addr, &s_alen) == 0) {
+return jk_dump_hinfo(&s_addr, buf);
+}
+else {
+sprintf(buf, "???%d:%d", sd, errno);
+return buf;
+}
+}
+
/** Wait for input event on socket until timeout
* @param sd socket to use
* @param timeout wait timeout in milliseconds
@@ -989,7 +1006,7 @@ int jk_is_input_event(jk_sock_t sd, int
}
errno = save_errno;
JK_TRACE_EXIT(l);
-return JK_FALSE;
+return JK_FALSE;
}
errno = 0;
JK_TRACE_EXIT(l);
Modified: tomcat/jk/trunk/native/common/jk_connect.h
URL:
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/common/jk_connect.h?rev=995751&r1=995750&r2=995751&view=diff
==
--- tomcat/jk/trunk/native/common/jk_connect.h (original)
+++ tomcat/jk/trunk/native/common/jk_connect.h Fri Sep 10 11:24:22 2010
@@ -54,6 +54,8 @@ int jk_tcp_socket_recvfull(jk_sock_t sd,
char *jk_dump_hinfo(struct sockaddr_in *saddr, char *buf);
+char *jk_dump_sinfo(jk_sock_t sd, char *buf);
+
int jk_is_input_event(jk_sock_t sd, int timeout, jk_logger_t *l);
int jk_is_socket_connected(jk_sock_t sd, jk_logger_t *l);
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48813] Allow the parameter org.apache.el.parser.COERCE_TO_ZERO to be set on runtime
https://issues.apache.org/bugzilla/show_bug.cgi?id=48813 arkadi.shish...@gmail.com changed: What|Removed |Added CC||arkadi.shish...@gmail.com -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r995898 - in /tomcat/jk/trunk/native/common: jk_connect.c portable.h
Author: mturk
Date: Fri Sep 10 17:45:59 2010
New Revision: 995898
URL: http://svn.apache.org/viewvc?rev=995898&view=rev
Log:
Log both local and remote address
Modified:
tomcat/jk/trunk/native/common/jk_connect.c
tomcat/jk/trunk/native/common/portable.h
Modified: tomcat/jk/trunk/native/common/jk_connect.c
URL:
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/common/jk_connect.c?rev=995898&r1=995897&r2=995898&view=diff
==
--- tomcat/jk/trunk/native/common/jk_connect.c (original)
+++ tomcat/jk/trunk/native/common/jk_connect.c Fri Sep 10 17:45:59 2010
@@ -719,8 +719,8 @@ int jk_shutdown_socket(jk_sock_t sd, jk_
save_errno = errno;
if (JK_IS_DEBUG_LEVEL(l)) {
-char buf[64];
-jk_log(l, JK_LOG_DEBUG, "About to shutdown socket %d %s",
+char buf[128];
+jk_log(l, JK_LOG_DEBUG, "About to shutdown socket %d [%s]",
sd, jk_dump_sinfo(sd, buf));
}
/* Shut down the socket for write, which will send a FIN
@@ -940,16 +940,27 @@ char *jk_dump_hinfo(struct sockaddr_in *
char *jk_dump_sinfo(jk_sock_t sd, char *buf)
{
struct sockaddr_in s_addr;
+struct sockaddr_in r_addr;
socklen_t s_alen;
s_alen = sizeof(struct sockaddr);
if (getsockname(sd, (struct sockaddr *)&s_addr, &s_alen) == 0) {
-return jk_dump_hinfo(&s_addr, buf);
-}
-else {
-sprintf(buf, "???%d:%d", sd, errno);
-return buf;
+s_alen = sizeof(struct sockaddr);
+if (getpeername(sd, (struct sockaddr *)&r_addr, &s_alen) == 0) {
+unsigned long laddr = (unsigned
long)htonl(s_addr.sin_addr.s_addr);
+unsigned short lport = (unsigned short)htons(s_addr.sin_port);
+unsigned long raddr = (unsigned
long)htonl(r_addr.sin_addr.s_addr);
+unsigned short rport = (unsigned short)htons(r_addr.sin_port);
+sprintf(buf, "%d.%d.%d.%d:%d -> %d.%d.%d.%d:%d",
+(int)(laddr >> 24), (int)((laddr >> 16) & 0xff),
+(int)((laddr >> 8) & 0xff), (int)(laddr & 0xff),
(int)lport,
+(int)(raddr >> 24), (int)((raddr >> 16) & 0xff),
+(int)((raddr >> 8) & 0xff), (int)(raddr & 0xff),
(int)rport);
+return buf;
+}
}
+sprintf(buf, "error=%d", errno);
+return buf;
}
/** Wait for input event on socket until timeout
Modified: tomcat/jk/trunk/native/common/portable.h
URL:
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/common/portable.h?rev=995898&r1=995897&r2=995898&view=diff
==
--- tomcat/jk/trunk/native/common/portable.h (original)
+++ tomcat/jk/trunk/native/common/portable.h Fri Sep 10 17:45:59 2010
@@ -1,18 +1,110 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-/* On most platform this file is overwritten when doing configure */
-/* DON'T COMMIT THE FILE IT BREAKS windoze and Netware, commit the sample file
*/
+/* common/portable.h. Generated by configure. */
+/* common/portable.h.in. Generated from configure.in by autoheader. */
+
+/* Define to 1 if you have the header file. */
+#define HAVE_DLFCN_H 1
+
+/* Have flock() */
+#define HAVE_FLOCK 1
+
+/* Define to 1 if you have the header file. */
+#define HAVE_INTTYPES_H 1
+
+/* Define to 1 if you have the header file. */
+#define HAVE_MEMORY_H 1
+
+/* Have poll() */
+#define HAVE_POLL 1
+
+/* Define to 1 if you have the header file. */
+#define HAVE_POLL_H 1
+
+/* Have snprintf() */
+#define HAVE_SNPRINTF 1
+
+/* Define to 1 if you have the header file. */
+#define HAVE_STDINT_H 1
+
+/* Define to 1 if you have the header file. */
+#define HAVE_STDLIB_H 1
+
+/* Define to 1 if you have the header file. */
+#define HAVE_STRINGS_H 1
+
+/* Define to 1 if you have the header file. */
+#define HAVE_STRING_H 1
+
+/* Define to 1 if you have the header file. */
+/* #undef HAVE_SYS_FILIO_H */
+
+/* Define to 1 if you have the header file. */
+#define HAVE_SYS_STAT_H 1
+
+/* Define to 1 if you have the header file. */
+#define HAVE_SYS_TYPES_H 1
+
+/* Define to 1 if you have the header file. */
+#
svn commit: r995901 - /tomcat/jk/trunk/native/common/portable.h
Author: mturk Date: Fri Sep 10 17:48:15 2010 New Revision: 995901 URL: http://svn.apache.org/viewvc?rev=995901&view=rev Log: Oops. We should really do something with that portable.h Modified: tomcat/jk/trunk/native/common/portable.h Modified: tomcat/jk/trunk/native/common/portable.h URL: http://svn.apache.org/viewvc/tomcat/jk/trunk/native/common/portable.h?rev=995901&r1=995900&r2=995901&view=diff == --- tomcat/jk/trunk/native/common/portable.h (original) +++ tomcat/jk/trunk/native/common/portable.h Fri Sep 10 17:48:15 2010 @@ -1,110 +1,18 @@ -/* common/portable.h. Generated by configure. */ -/* common/portable.h.in. Generated from configure.in by autoheader. */ - -/* Define to 1 if you have the header file. */ -#define HAVE_DLFCN_H 1 - -/* Have flock() */ -#define HAVE_FLOCK 1 - -/* Define to 1 if you have the header file. */ -#define HAVE_INTTYPES_H 1 - -/* Define to 1 if you have the header file. */ -#define HAVE_MEMORY_H 1 - -/* Have poll() */ -#define HAVE_POLL 1 - -/* Define to 1 if you have the header file. */ -#define HAVE_POLL_H 1 - -/* Have snprintf() */ -#define HAVE_SNPRINTF 1 - -/* Define to 1 if you have the header file. */ -#define HAVE_STDINT_H 1 - -/* Define to 1 if you have the header file. */ -#define HAVE_STDLIB_H 1 - -/* Define to 1 if you have the header file. */ -#define HAVE_STRINGS_H 1 - -/* Define to 1 if you have the header file. */ -#define HAVE_STRING_H 1 - -/* Define to 1 if you have the header file. */ -/* #undef HAVE_SYS_FILIO_H */ - -/* Define to 1 if you have the header file. */ -#define HAVE_SYS_STAT_H 1 - -/* Define to 1 if you have the header file. */ -#define HAVE_SYS_TYPES_H 1 - -/* Define to 1 if you have the header file. */ -#define HAVE_UNISTD_H 1 - -/* Have vsnprintf() */ -#define HAVE_VSNPRINTF 1 - -/* Name of package */ -#define PACKAGE "mod_jk" - -/* Define to the address where bug reports for this package should be sent. */ -#define PACKAGE_BUGREPORT "" - -/* Define to the full name of this package. */ -#define PACKAGE_NAME "" - -/* Define to the full name and version of this package. */ -#define PACKAGE_STRING "" - -/* Define to the one symbol short name of this package. */ -#define PACKAGE_TARNAME "" - -/* Define to the version of this package. */ -#define PACKAGE_VERSION "" - -/* The size of a `char', as computed by sizeof. */ -#define SIZEOF_CHAR 1 - -/* The size of a `int', as computed by sizeof. */ -#define SIZEOF_INT 4 - -/* The size of a `long', as computed by sizeof. */ -#define SIZEOF_LONG 4 - -/* The size of a `longlong', as computed by sizeof. */ -#define SIZEOF_LONGLONG 0 - -/* The size of a `long double', as computed by sizeof. */ -#define SIZEOF_LONG_DOUBLE 12 - -/* The size of a `long long', as computed by sizeof. */ -#define SIZEOF_LONG_LONG 8 - -/* The size of pid_t */ -#define SIZEOF_PID_T 4 - -/* The size of pthread_t */ -#define SIZEOF_PTHREAD_T 4 - -/* The size of a `short', as computed by sizeof. */ -#define SIZEOF_SHORT 2 - -/* Define to 1 if you have the ANSI C header files. */ -#define STDC_HEADERS 1 - -/* Define to use SOCK_CLOEXEC with socket() */ -/* #undef USE_SOCK_CLOEXEC */ - -/* Define to use SO_RCVTIMEO with setsockopt() */ -#define USE_SO_RCVTIMEO 1 - -/* Define to use SO_SNDTIMEO with setsockopt() */ -#define USE_SO_SNDTIMEO 1 - -/* Version number of package */ -#define VERSION "1.2.29" +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +/* On most platform this file is overwritten when doing configure */ +/* DON'T COMMIT THE FILE IT BREAKS windoze and Netware, commit the sample file */ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r995901 - /tomcat/jk/trunk/native/common/portable.h
On 9/10/2010 12:48 PM, mt...@apache.org wrote: > Author: mturk > Date: Fri Sep 10 17:48:15 2010 > New Revision: 995901 > > URL: http://svn.apache.org/viewvc?rev=995901&view=rev > Log: > Oops. We should really do something with that portable.h svn rm it. The make files need simple cat portable.h.in > portable.h statements to generate timestamped flavors on netware/win32/os2. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49914] New: Filter on url-pattern of "/" is not invoked
https://issues.apache.org/bugzilla/show_bug.cgi?id=49914
Summary: Filter on url-pattern of "/" is not invoked
Product: Tomcat 7
Version: 7.0.2
Platform: PC
OS/Version: Windows XP
Status: NEW
Severity: normal
Priority: P2
Component: Catalina
AssignedTo: dev@tomcat.apache.org
ReportedBy: bal...@gmail.com
A filter on an url-pattern of "/" is not invoked when requesting the context
root URL like http://localhost:8080/contextname/. This is regardless where the
url-pattern is definied. In web.xml as / or in
filter class as @WebFilter(urlPatterns={"/"})
This works fine on Tomcat 6.x and Glassfish v3.0.1.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r995991 - /tomcat/trunk/conf/server.xml
Author: markt Date: Fri Sep 10 21:35:55 2010 New Revision: 995991 URL: http://svn.apache.org/viewvc?rev=995991&view=rev Log: Remove pointless comment. Schema validation moved to the context Modified: tomcat/trunk/conf/server.xml Modified: tomcat/trunk/conf/server.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/conf/server.xml?rev=995991&r1=995990&r2=995991&view=diff == --- tomcat/trunk/conf/server.xml (original) +++ tomcat/trunk/conf/server.xml Fri Sep 10 21:35:55 2010 @@ -117,9 +117,6 @@ resourceName="UserDatabase"/> - - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49915] New: [Patch] o.a.c.c.StandardServer swallows error on storeConfig.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49915 Summary: [Patch] o.a.c.c.StandardServer swallows error on storeConfig. Product: Tomcat 6 Version: unspecified Platform: PC OS/Version: Windows Vista Status: NEW Severity: normal Priority: P2 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: wesley.ache...@gmail.com When o.a.c.c.StandardServer#storeConfig is called all exceptions were getting swallowed. This lead to the impresssion it was working correctly when saved either through the manager application /manager/save or through jconsole. I've removed the catch throwable block and thrown an exception upon not finding the registerd MBean. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Catching throwable.
I'm looking through the source now where I'm seeing a lot of Throwables caught. I was always told this was bad practice is there a reason for this? Some I could understand but there seems to be places where throwable is caught even though the javadocs say it throws an exception. And by your handling of the throwable it looks like you know what to expect the throwable to be. Just getting my head arround it. Wes - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r995901 - /tomcat/jk/trunk/native/common/portable.h
On 09/10/2010 08:06 PM, William A. Rowe Jr. wrote: On 9/10/2010 12:48 PM, mt...@apache.org wrote: Author: mturk Date: Fri Sep 10 17:48:15 2010 New Revision: 995901 URL: http://svn.apache.org/viewvc?rev=995901&view=rev Log: Oops. We should really do something with that portable.h svn rm it. The make files need simple cat portable.h.in> portable.h statements to generate timestamped flavors on netware/win32/os2. Well it's already excluded in jk_global.h by #if !defined(WIN32) && !defined(AS400) && !defined(NETWARE) #include "portable.h" #endif So, dunno if we need to ship that at the first place. Regards -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49916] New: use an init-param for jspFile on explicit jsp servlets
https://issues.apache.org/bugzilla/show_bug.cgi?id=49916 Summary: use an init-param for jspFile on explicit jsp servlets Product: Tomcat 7 Version: trunk Platform: PC Status: NEW Severity: normal Priority: P2 Component: Jasper AssignedTo: dev@tomcat.apache.org ReportedBy: djen...@apache.org Created an attachment (id=26017) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26017) patch to translate jsp-file elements to jspServlet init params A element in web.xml can include a jsp-file rather than a servlet class. Currently in catalina and jasper this is handled by a bunch of runtime code that tracks the jsp file outside the servlet and feeds it to the servlet as a request attribute. This requires a bunch of runtime code, some of which is marked "hold your nose". Instead, it's possible to supply the jsp-file as an init-param to the jsp servlet instance that is set up to handle this element. This makes runtime handling of these jsp servlets identical to all other servlets and transfers the small amount of jsp-aware code still needed in catalina to the deployment phase. The attached patch appears to pass all the tomcat tests and doesn't appear to cause any tck problems in the geronimo-tomcat integration. In this patch, JspServlet will still respond to the jsp file as a request attribute but catalina won't send it. Thus jasper is backwards compatible with earlier catalina versions but catalina is not backward compatible for explicitly mentioned jsp-file in servlet elements with earlier jasper versions. It would be helpful to geronimo to apply the JspServlet patch even if the catalina changes aren't applied as we are using this technique in the geronimo-jetty integration and are subclassing JspServlet to provide this behavior. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Can jsp-file be a JspServlet init-param?
On Sep 8, 2010, at 11:48 PM, Mark Thomas wrote: > On 09/09/2010 00:54, David Jencks wrote: >> I've recently rewritten the geronimo-jetty integration to work off the >> servlet 3 *Registration classes. This works great except for servlets >> backed by jsp files, since there's no way to tell the servlet container >> through the ServletRegistration interface that its actually something with >> this extra jsp file name that needs to be added through some special process >> into the request. > > That looks like an oversight in the 3.0 spec. I'm not sure why you think that. A servlet extension mechanism such as a jsp engine can use the servlet 3 API to add servlets directly. I think it would make more sense to completely remove any mention of jsp from web.xml and the servlet spec and run jsps off a separate configuration file. > >> However, its easy to subclass the JspServlet so it gets the jsp file value >> from an init param, and of course its easy to set the init param from the >> web.xml. This appears to work fine. >> >> Is there some reason I've missed that this is a bad idea? > > Well, it would be container specific rather than defined by the spec but > since the spec offers no way to define it, I don't see there is a choice. The existing way of using a servlet request attribute to feed the jsp file to the instance of the jsp servlet set up for a particular servlet element is also not mentioned in the spec. It does need some special attention on each request. My proposal moves all the jsp-aware code in catalina to the deploy phase and allows treating these explicitly set up JspServlet instances just like any other servlet. > >> If not, would the jasper community consider a patch to modify the JspServlet >> so it directly looks for such an init-param? > > Patches always get considered. excellent, see https://issues.apache.org/bugzilla/show_bug.cgi?id=49916 If I've understood the tomcat build this passes all the tests and also appears to cause no tck problems in the geronimo-tomcat integration. > >> And would the tomcat community consider simplifying the runtime code to use >> this init-param instead of a Constants.JSP_FILE request attribute? > > As usual, it would depend on the patch. thanks! david jencks > > Mark > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
