Bug report for Taglibs [2010/09/05]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |27717|New|Maj|2004-03-16| very slow in JSTL 1.1 | |33934|New|Cri|2005-03-09|[standard] memory leak in jstl c:set tag | |38193|Ass|Enh|2006-01-09|[RDC] BuiltIn Grammar support for Field | |38600|Ass|Enh|2006-02-10|[RDC] Enable RDCs to be used in X+V markup (X+RDC)| |42413|New|Nor|2007-05-14|[PATCH] Log Taglib enhancements | |43640|New|Nor|2007-10-16|Move the tests package to JUnit | |45197|Ass|Nor|2008-06-12|Need to support the JSTL 1.2 specification| |46052|New|Nor|2008-10-21|SetLocaleSupport is slow to initialize when many l| |48333|New|Nor|2009-12-02|TLD generator | |48773|New|Nor|2010-02-19|DataSourceWrapper and DriverManager problems | |49292|New|Nor|2010-05-14|Memory leak in org.apache.taglibs.standard.lang.js| |49578|New|Nor|2010-07-09|XPath handling only supports single reference to v| +-+---+---+--+--+ | Total 12 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Tomcat 5 [2010/09/05]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |27122|Opn|Enh|2004-02-20|IE plugins cannot access components through Tomcat| |28039|Opn|Enh|2004-03-30|Cluster Support for SingleSignOn | |29494|Inf|Enh|2004-06-10|No way to set PATH when running as a service on Wi| |33262|Inf|Enh|2005-01-27|Service Manager autostart should check for adminis| |33453|Opn|Enh|2005-02-08|Jasper should recompile JSP files whose datestamps| |33671|Opn|Enh|2005-02-21|Manual Windows service installation with custom na| |34801|New|Enh|2005-05-08|PATCH: CGIServlet does not terminate child after a| |34805|Ass|Enh|2005-05-08|warn about invalid security constraint url pattern| |34868|Ass|Enh|2005-05-11|allow to register a trust store for a session that| |35054|Inf|Enh|2005-05-25|warn if appBase is not existing as a File or direc| |36362|New|Enh|2005-08-25|missing check for Java reserved keywords in tag fi| |36569|Inf|Enh|2005-09-09|Redirects produce illegal URL's | |36837|Inf|Enh|2005-09-28|Looking for ProxyHandler implementation of Http re| |36922|Inf|Enh|2005-10-04|setup.sh file mis-advertised and missing | |37018|Ass|Enh|2005-10-11|Document how to use tomcat-SSL with a pkcs11 token| |37334|Inf|Enh|2005-11-02|Realm digest property not aligned with the adminis| |38216|Inf|Enh|2006-01-10|Extend Jmxproxy to allow call of MBean Operations | |38268|Inf|Enh|2006-01-13|User friendly: Need submit button on adding/deleti| |38360|Inf|Enh|2006-01-24|Domain for session cookies| |38546|Inf|Enh|2006-02-07|Google bot sends invalid If-Modifed-Since Header, | |38577|Inf|Enh|2006-02-08|Enhance logging of security failures | |38916|Inf|Enh|2006-03-10|HttpServletRequest cannot handle multipart request| |39053|Inf|Enh|2006-03-21|include Tomcat embedded sample| |39740|New|Enh|2006-06-07|semi-colon ; isn't allowed as a query argument sep| |39862|Inf|Enh|2006-06-22|provide support for protocol-independent GenericSe| |40211|Inf|Enh|2006-08-08|Compiled JSP don't indent HTML code | |40402|New|Enh|2006-09-03|Manager should display Exceptions | |40510|New|Enh|2006-09-14|installer does not create shortcuts for all users | |40712|New|Enh|2006-10-10|Realm admin error.| |40728|Inf|Enh|2006-10-11|Catalina MBeans use non-serializable classes | |40766|New|Enh|2006-10-16|Using an unsecure jsessionid with mod_proxy_ajp ov| |40881|Opn|Enh|2006-11-02|Unable to receive message through TCP channel -> | |41007|Opn|Enh|2006-11-20|Can't define customized 503 error page| |41179|New|Enh|2006-12-15|400 Bad Request response during auto re-deployment| |41227|Opn|Enh|2006-12-21|When the jasper compiler fails to compile a JSP, i| |41337|Opn|Enh|2007-01-10|Display an error page if no cert is available on C| |41496|New|Enh|2007-01-30|set a security provider for jsse in a connector co| |41498|New|Enh|2007-01-30|allRolesMode Realm configuration option not docume| |41539|Inf|Enh|2007-02-05|NullPointerException during Embedded tomcat restar| |41673|New|Enh|2007-02-21|Jasper output the message of compiling error using| |41697|Ver|Enh|2007-02-25|make visible in debug output if charset from brows| |41709|Inf|Enh|2007-02-26|When calling the API that relates to the buffer af| |41718|New|Enh|2007-02-27|Status 302 response to GET request has no body whe| |42416|New|Enh|2007-05-14|Tomcat startup hangs and AJP13 connector port 8009| |43423|New|Enh|2007-09-18|catalina.sh -force too fast | |43538|New|Enh|2007-10-02|[patch] Show the hostname and IP address in the ma| |43796|Inf|Enh|2007-11-05|Add MIME type mapping for the "log" extension | |43866|New|Enh|2007-11-14|add support for session attribute propagation with| |43925|Opn|Enh|2007-11-21|org.apache.jasper.runtime.BodyContentImpl causing | |43960|New|Enh|2007-11-26|Expose StandardWrapper unavailable and/or availabl| |43991|New|Enh|2007-11-29|Contributing a URLResourceFactory | |44216|
Bug report for Tomcat 7 [2010/09/05]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |48550|New|Enh|2010-01-14|Update examples and default server.xml to use UTF-| |48692|New|Enh|2010-02-07|Provide option to parse application/x-www-form-url| |48837|New|Enh|2010-03-01|Memory leaks protection does not cure leaks trigge| |48870|New|Enh|2010-03-08|avoid parallel arrays of base types | |48892|New|Enh|2010-03-11|Use URIEncoding from server.xml for decoding post | |49000|New|Enh|2010-03-26|Cookie parsing bug when an empty value has an equa| |49100|New|Enh|2010-04-12|Mutable public constants: MemberImpl.TRIBES_MBR_BE| |49101|New|Enh|2010-04-12|All constants in tribes.transport.Constants are mu| |49102|New|Enh|2010-04-12|coyote.ajp.Constants - 3 "constant" arrays are mut| |49125|New|Enh|2010-04-14|toString on byte[] array probably is not correct | |49126|New|Enh|2010-04-14|jasper.compiler.Generator.createJspId() can genera| |49142|New|Enh|2010-04-16|Missing serialVersionUIDs | |49159|New|Enh|2010-04-20|Improve ThreadLocal memory leak clean-up | |49165|New|Enh|2010-04-21|Enhancement - Allow %{TIME_FORMAT}t As Configurati| |49180|New|Enh|2010-04-24|Add option to disable log rotation in FileHandler.| |49234|New|Nor|2010-04-30|JMX Descriptor Modifications | |49284|New|Enh|2010-05-12|Implement SSL renegotiation for the NIO connector | |49290|New|Enh|2010-05-14|Using a JarScanner with scanAllDirectories=true ca| |49295|New|Enh|2010-05-14|JMXAccessorTask.getProperties() - return Propertie| |49297|New|Min|2010-05-15|Whitespace absence is allowed before attribute nam| |49317|New|Enh|2010-05-20|org.apache.catalina.util.Base64 interface needs re| |49318|New|Enh|2010-05-20|add a Negotiate (Kerberos/NTLM) authenticator / in| |49395|New|Enh|2010-06-06|manager.findLeaks : display the date when the leak| |49426|New|Nor|2010-06-11|Manager app wrongly localized | |49589|New|Enh|2010-07-12|Tag handlers with constant attribute values are al| |49591|New|Enh|2010-07-13|Custom error page always uses Transfer-Encoding: c| |49650|New|Enh|2010-07-26|Streamline package.access property definition in c| |49683|New|Nor|2010-08-01|Separate keep-alive and connection timeout with AP| |49711|New|Enh|2010-08-05|HttpServletRequest#getParts() does not work in a F| |49785|New|Enh|2010-08-19|Enabling TLS for JNDIRealm| |49802|New|Reg|2010-08-23|Shutdown of AJP Connector do not work | |49819|New|Enh|2010-08-25|Improved index.html for default ROOT application | |49821|New|Enh|2010-08-25|Tomcat CLI| |49883|New|Nor|2010-09-04|java.lang.UnsupportedOperationException: The getNa| |49884|New|Nor|2010-09-04|NullPointerException in org.apache.catalina.core.A| +-+---+---+--+--+ | Total 35 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Tomcat Connectors [2010/09/05]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |34526|Opn|Nor|2005-04-19|Truncated content in decompressed requests from mo| |35959|Opn|Enh|2005-08-01|mod_jk not independant of UseCanonicalName| |36155|Opn|Nor|2005-08-12|tomcat chooses wrong host if using mod_jk | |39967|Inf|Nor|2006-07-05|mod_jk gives segmentation fault when apache is sta| |40208|Inf|Nor|2006-08-08|Request-Dump when ErrorDocument in httpd.conf is a| |41170|Inf|Nor|2006-12-13|single crlf in header termination crashes app.| |41923|Opn|Nor|2007-03-21|Tomcat doesnt recognized client abort | |42366|Inf|Nor|2007-05-09|Memory leak in newer mod_jk version when connectio| |42554|Opn|Nor|2007-05-31|mod_ssl + mod_jk with status_worker does not work | |43303|New|Enh|2007-09-04|Versioning under Windows not reported by many conn| |43968|New|Enh|2007-11-26|[patch] support ipv6 with mod_jk | |44290|New|Nor|2008-01-24|mod_jk/1.2.26: retry is not useful for an importan| |44349|New|Maj|2008-02-04|mod_jk/1.2.26 module does not read worker.status.s| |44379|New|Enh|2008-02-07|convert the output of strftime into UTF-8 | |44454|New|Nor|2008-02-19|busy count reported in mod_jk inflated, causes inc| |44571|New|Enh|2008-03-10|Limits busy per worker to a threshold | |45063|New|Nor|2008-05-22|JK-1.2.26 IIS ISAPI filter issue when running diff| |45313|New|Nor|2008-06-30|mod_jk 1.2.26 & apache 2.2.9 static compiled on so| |45395|New|Min|2008-07-14|MsgAjp dump method does not dump packet when being| |46337|New|Nor|2008-12-04|real worker name is wrong | |46406|New|Enh|2008-12-16|Supporting relative paths in isapi_redirect.proper| |46676|New|Enh|2009-02-09|Configurable test request for Watchdog thread | |46767|New|Enh|2009-02-25|mod_jk to send DECLINED in case no fail-over tomca| |47038|New|Enh|2009-04-15|USE_FLOCK_LK redefined compiler warning when using| |47327|New|Enh|2009-06-07|remote_user not logged in apache logfile | |47617|New|Enh|2009-07-31|include time spent doing ajp_get_endpoint() in err| |47678|New|Nor|2009-08-11|Unable to allocate shared memory when using isapi_| |47679|New|Nor|2009-08-11|Not all headers get passed to Tomcat server from i| |47692|New|Reg|2009-08-12|Can not compile mod_jk with apache2.0.63 and tomca| |47714|New|Cri|2009-08-20|Reponse mixed between users | |47750|New|Maj|2009-08-27|Loss of worker settings when changing via jkstatus| |47795|New|Maj|2009-09-07|service sticky_session not being set correctly wit| |47840|Inf|Min|2009-09-14|A broken worker name is written in the log file. | |48191|New|Maj|2009-11-13|Problem with mod_jk 1.2.28 - Can not render up the| |48490|New|Nor|2010-01-05|Changing a node to stopped in uriworkermap.propert| |48501|New|Enh|2010-01-07|Log rotation for ISAPI Redirector | |48513|New|Enh|2010-01-09|IIS Quick setup instructions | |48564|New|Nor|2010-01-18|Unable to turn off retries for LB worker | |48830|New|Nor|2010-03-01|IIS shutdown blocked in endpoint service when serv| |48925|New|Maj|2010-03-16|((ServletRequest) request).getLocalAddr() returns | |48940|New|Maj|2010-03-18|IIS to Tomcat occasionally fails on POST with T-E | |49035|New|Maj|2010-04-01|data lost when post a multipart/form-data form| |49048|New|Nor|2010-04-05|ACL not applied to redirect URLs | |49063|New|Enh|2010-04-07|Please add JkStripSession status in jk-status work| |49135|New|Enh|2010-04-16|SPDY Connector for The Tomcat | |49413|Opn|Reg|2010-06-09|Apache Mod_jk 1.2.30 is shutting down communicatio| |49469|New|Enh|2010-06-19|Workers status page has negative number of connect| |49511|New|Maj|2010-06-28|IIS 7.5 incorrect logging: pfc->pFilterContext is | |49822|New|Enh|2010-08-25|Add hash lb worker method | +-+---+---+--+--+ | Total 49 bugs | +--
Bug report for Tomcat Modules [2010/09/05]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |48240|New|Nor|2009-11-19|Tomcat-Lite missing @Override markers | |48268|New|Nor|2009-11-23|Patch to fix generics in tomcat-lite | |48817|New|Nor|2010-02-25|Skip validation query and use JDBC API for validat| |48861|New|Nor|2010-03-04|Files without AL headers | |49543|New|Enh|2010-07-02|Request for a "shared" datasource configuration as| |49584|New|Nor|2010-07-12|Borrowers Getting Stuck | |49685|New|Nor|2010-08-02|Unsafe synchronization in class ManagedBean | |49686|New|Nor|2010-08-02|Using an instance lock to protect static shared da| |49831|New|Nor|2010-08-26|Issue with closing XAConnections on MSSQL | +-+---+---+--+--+ | Total9 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Tomcat Native [2010/09/05]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |38372|Inf|Cri|2006-01-25|tcnative-1.dll response overflow corruption, parti| |41361|New|Nor|2007-01-14|Content lost when read by a slow client. | |42090|New|Cri|2007-04-11|tcnative badly handles some OpenSSL disconnections| |45392|New|Nor|2008-07-14|No OCSP support for client SSL verification | |46041|New|Cri|2008-10-20|Tomcat service is terminated unexpectedly (tcnativ| |46179|New|Maj|2008-11-10|apr ssl client authentication | |46571|New|Nor|2009-01-21|tcnative blocks in APR poll on Solaris| |47319|New|Nor|2009-06-05|With APR, getRemoteHost() returns NULL for unknown| |47851|New|Nor|2009-09-16|thread-safety issues in the TC native Java code | |48253|New|Min|2009-11-20|Tomcat Native patch - adding dynamic locking callb| |48655|New|Nor|2010-02-02|Active multipart downloads prevent tomcat shutdown| |48891|Opn|Enh|2010-03-11|Missing EOL-style settings in tomcat/jk/trunk | |49038|Inf|Nor|2010-04-02|Crash in tcnative | |49556|New|Cri|2010-07-05|the proc.create function used args as env to get t| |49557|New|Cri|2010-07-05|index erro in the loop to get the env info in the | |49595|New|Cri|2010-07-15|Tomcat crashes in tcnative-1.dll frequently | |49851|New|Blk|2010-08-31|JNI Registry.deleteKey and Registry.deleteValue co| +-+---+---+--+--+ | Total 17 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Tomcat 6 [2010/09/05]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |39661|Opn|Enh|2006-05-25|Please document JULI FileHandler configuration pro| |41128|Inf|Enh|2006-12-07|Reference to java Thread name from RequestProcesso| |41679|New|Enh|2007-02-22|SemaphoreValve should be able to filter on url pat| |41791|New|Enh|2007-03-07|Tomcat behaves inconsistently concerning flush-pac| |41883|Ass|Enh|2007-03-18|use abstract wrapper instead of plain X509Certific| |41944|New|Enh|2007-03-25|Start running the RAT tool to see where we're miss| |41992|New|Enh|2007-03-30|Need ability to set OS process title | |42463|New|Enh|2007-05-20|"crossContext" and classloader issues - pls amend | |43001|New|Enh|2007-07-30|JspC lacks setMappedFile and setDie for use in Ant| |43003|New|Enh|2007-07-30|Separate dependent component download and build ta| |43400|New|Enh|2007-09-14|enum support for tag libs | |43497|New|Enh|2007-09-26|Add ability to escape rendered output of JSP expre| |43548|Opn|Enh|2007-10-04|xml schema for tomcat-users.xml | |43642|New|Enh|2007-10-17|Add prestartminSpareThreads attribute for Executor| |43682|New|Enh|2007-10-23|JULI: web-inf/classes/logging.properties to suppor| |43742|New|Enh|2007-10-30|.tag compiles performed one at a time -- extremel| |43790|Ass|Enh|2007-11-03|concurrent access issue on TagHandlerPool | |43979|New|Enh|2007-11-27|Add abstraction for Java and Classfile output | |44047|New|Enh|2007-12-10|Provide a way for Tomcat to serve up error pages w| |44199|New|Enh|2008-01-10|expose current backlog queue size | |44225|New|Enh|2008-01-14|SSL connector tries to load the private keystore f| |44264|New|Enh|2008-01-18|Clustering - Support for disabling multicasting an| |44284|New|Enh|2008-01-23|Support java.lang.Iterable in c:forEach tag | |44294|New|Enh|2008-01-25|Support for EL functions with varargs | |44299|New|Enh|2008-01-26|Provider manager app with a log out button| |44312|New|Enh|2008-01-28|Warn when overwritting docBase of the default Host| |44598|New|Enh|2008-03-13|JAASRealm is suppressing Exceptions | |44645|New|Enh|2008-03-20|[Patch] JNDIRealm - Doesn't support JNDI "java.nam| |44787|New|Enh|2008-04-09|provide more error context on "java.lang.IllegalSt| |44818|New|Enh|2008-04-13|tomcat hangs with GET when content-length is defin| |45014|New|Enh|2008-05-15|Request and Response classes should have wrappers | |45282|New|Enh|2008-06-25|NioReceiver doesn't close cleanly, leaving sockets| |45283|Opn|Enh|2008-06-25|Allow multiple authenticators to be added to pipel| |45428|New|Enh|2008-07-18|warn if the tomcat stop doesn't complete | |45654|New|Enh|2008-08-19|use static methods and attributes in a direct way!| |45731|New|Enh|2008-09-02|Enhancement request : pluggable httpsession cache | |45832|New|Enh|2008-09-18|add DIGEST authentication support to Ant tasks| |45871|New|Enh|2008-09-23|Support for salted and digested patches in DataSou| |45878|New|Enh|2008-09-24|Generated jars do not contain proper manifests or | |45879|Opn|Enh|2008-09-24|Windows installer fails to install NOTICE and RELE| |45931|Opn|Enh|2008-10-01|trimSpaces incorrectly modifies output| |45995|New|Enh|2008-10-13|RFE - MIME type extension not case sensitive | |46173|New|Enh|2008-11-09|Small patch for manager app: Setting an optional c| |46263|New|Enh|2008-11-21|Tomcat reloading of context does not update contex| |46264|New|Enh|2008-11-21|Shutting down tomcat with large number of contexts| |46284|New|Enh|2008-11-24|Add flag to DeltaManager that blocks processing cl| |46350|New|Enh|2008-12-05|Maven repository should contain source bundles| |46451|New|Enh|2008-12-30|Configure svn:bugtraq properties | |46461|New|Enh|2009-01-01|fail graceful on dns changes for connectors/hosts | |46497|New|Enh|2009-01-08|Install Tomcat Deployer/ANT on Windows Platform | |46558|New|Enh|2009-01-19|Shutdown port with address binding| |46655|
DO NOT REPLY [Bug 48891] Missing EOL-style settings in tomcat/jk/trunk
https://issues.apache.org/bugzilla/show_bug.cgi?id=48891 Rainer Jung changed: What|Removed |Added Component|Library |Common Product|Tomcat Native |Tomcat Connectors -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r992881 - in /tomcat/trunk: java/org/apache/tomcat/util/net/AprEndpoint.java java/org/apache/tomcat/util/net/JIoEndpoint.java java/org/apache/tomcat/util/net/NioEndpoint.java webapps/docs/
Author: markt Date: Sun Sep 5 19:47:36 2010 New Revision: 992881 URL: http://svn.apache.org/viewvc?rev=992881&view=rev Log: Make sure acceptor threads are stopped when the connector is stopped. Also fix @Override warnings for the method Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java?rev=992881&r1=992880&r2=992881&view=diff == --- tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java (original) +++ tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java Sun Sep 5 19:47:36 2010 @@ -918,6 +918,7 @@ public class AprEndpoint extends Abstrac * The background thread that listens for incoming TCP/IP connections and * hands them off to an appropriate processor. */ +@Override public void run() { // Loop until we receive a shutdown command Modified: tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java?rev=992881&r1=992880&r2=992881&view=diff == --- tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java (original) +++ tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java Sun Sep 5 19:47:36 2010 @@ -173,13 +173,14 @@ public class JIoEndpoint extends Abstrac * The background thread that listens for incoming TCP/IP connections and * hands them off to an appropriate processor. */ +@Override public void run() { // Loop until we receive a shutdown command while (running) { // Loop if endpoint is paused -while (paused) { +while (paused && running) { try { Thread.sleep(1000); } catch (InterruptedException e) { Modified: tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java?rev=992881&r1=992880&r2=992881&view=diff == --- tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java (original) +++ tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java Sun Sep 5 19:47:36 2010 @@ -802,11 +802,12 @@ public class NioEndpoint extends Abstrac * The background thread that listens for incoming TCP/IP connections and * hands them off to an appropriate processor. */ +@Override public void run() { // Loop until we receive a shutdown command while (running) { // Loop if endpoint is paused -while (paused) { +while (paused && running) { try { Thread.sleep(1000); } catch (InterruptedException e) { Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=992881&r1=992880&r2=992881&view=diff == --- tomcat/trunk/webapps/docs/changelog.xml (original) +++ tomcat/trunk/webapps/docs/changelog.xml Sun Sep 5 19:47:36 2010 @@ -135,6 +135,10 @@ Further work to reduce the code duplication in the HTTP connectors. (markt) + +Make sure acceptor threads are stopped when the connector is stopped. +(markt) + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r992882 - in /tomcat/trunk: java/org/apache/tomcat/util/net/JIoEndpoint.java webapps/docs/changelog.xml
Author: markt Date: Sun Sep 5 19:49:53 2010 New Revision: 992882 URL: http://svn.apache.org/viewvc?rev=992882&view=rev Log: Make sure async timeout thread is stopped when the connector is stopped. Correct copy and pasted comment Also fix @Override warning for the method Modified: tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java?rev=992882&r1=992881&r2=992882&view=diff == --- tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java (original) +++ tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java Sun Sep 5 19:49:53 2010 @@ -128,9 +128,10 @@ public class JIoEndpoint extends Abstrac */ protected class AsyncTimeout implements Runnable { /** - * The background thread that listens for incoming TCP/IP connections and - * hands them off to an appropriate processor. + * The background thread that checks async requests and fires the + * timeout if there has been no activity. */ +@Override public void run() { // Loop until we receive a shutdown command @@ -152,7 +153,7 @@ public class JIoEndpoint extends Abstrac } // Loop if endpoint is paused -while (paused) { +while (paused && running) { try { Thread.sleep(1000); } catch (InterruptedException e) { Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=992882&r1=992881&r2=992882&view=diff == --- tomcat/trunk/webapps/docs/changelog.xml (original) +++ tomcat/trunk/webapps/docs/changelog.xml Sun Sep 5 19:49:53 2010 @@ -139,6 +139,10 @@ Make sure acceptor threads are stopped when the connector is stopped. (markt) + +Make sure async timeout thread is stopped when the connector is stopped. +(markt) + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r992890 - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/catalina/core/ java/org/apache/coyote/ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ java/org/a
Author: markt Date: Sun Sep 5 20:36:16 2010 New Revision: 992890 URL: http://svn.apache.org/viewvc?rev=992890&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49802 Allow the connectors to be stopped via JMX. Modified: tomcat/trunk/java/org/apache/catalina/connector/Connector.java tomcat/trunk/java/org/apache/catalina/core/StandardService.java tomcat/trunk/java/org/apache/coyote/ProtocolHandler.java tomcat/trunk/java/org/apache/coyote/ajp/AjpAprProcessor.java tomcat/trunk/java/org/apache/coyote/ajp/AjpAprProtocol.java tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java tomcat/trunk/java/org/apache/coyote/ajp/AjpProtocol.java tomcat/trunk/java/org/apache/coyote/ajp/LocalStrings.properties tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Protocol.java tomcat/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java tomcat/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java tomcat/trunk/java/org/apache/coyote/http11/LocalStrings.properties tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/java/org/apache/catalina/connector/Connector.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/Connector.java?rev=992890&r1=992889&r2=992890&view=diff == --- tomcat/trunk/java/org/apache/catalina/connector/Connector.java (original) +++ tomcat/trunk/java/org/apache/catalina/connector/Connector.java Sun Sep 5 20:36:16 2010 @@ -916,6 +916,14 @@ public class Connector extends Lifecycle setState(LifecycleState.STOPPING); +try { +protocolHandler.stop(); +} catch (Exception e) { +throw new LifecycleException +(sm.getString + ("coyoteConnector.protocolHandlerStopFailed", e)); +} + // MapperListener doesn't follow Lifecycle conventions mapperListener.destroy(); } Modified: tomcat/trunk/java/org/apache/catalina/core/StandardService.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/StandardService.java?rev=992890&r1=992889&r2=992890&view=diff == --- tomcat/trunk/java/org/apache/catalina/core/StandardService.java (original) +++ tomcat/trunk/java/org/apache/catalina/core/StandardService.java Sun Sep 5 20:36:16 2010 @@ -377,13 +377,13 @@ public class StandardService extends Lif /** * Retrieves executor by name, null if not found - * @param name String + * @param executorName String * @return Executor */ -public Executor getExecutor(String name) { +public Executor getExecutor(String executorName) { synchronized (executors) { for (Executor executor: executors) { -if (name.equals(executor.getName())) +if (executorName.equals(executor.getName())) return executor; } } @@ -462,7 +462,7 @@ public class StandardService extends Lif @Override protected void stopInternal() throws LifecycleException { -// Stop our defined Connectors first +// Pause connectors first synchronized (connectors) { for (Connector connector: connectors) { try { @@ -475,13 +475,6 @@ public class StandardService extends Lif } } -// Heuristic: Sleep for a while to ensure pause of the connector -try { -Thread.sleep(1000); -} catch (InterruptedException e) { -// Ignore -} - if(log.isInfoEnabled()) log.info(sm.getString("standardService.stop.name", this.name)); setState(LifecycleState.STOPPING); @@ -492,14 +485,15 @@ public class StandardService extends Lif container.stop(); } } -// FIXME pero -- Why container stop first? KeepAlive connections can send request! -// Stop our defined Connectors first + +// Now stop the connectors synchronized (connectors) { for (Connector connector: connectors) { -if (LifecycleState.INITIALIZED.equals( +if (!LifecycleState.STARTED.equals( connector.getState())) { -// If Service fails to start, connectors may not have been -// started +// Connectors only need stopping if they are currently +// started. They may have failed to start or may h
DO NOT REPLY [Bug 49802] Shutdown of AJP Connector do not work
https://issues.apache.org/bugzilla/show_bug.cgi?id=49802 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #2 from Mark Thomas 2010-09-05 16:37:41 EDT --- This bug has been fixed in 7.0.x and will be included in 7.0.3 onwards. Note: There is scope for further re-factoring to align the protocols and the endpoints with the new life-cycle code in 7.0.x. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r992891 - in /tomcat/trunk: java/org/apache/catalina/realm/CombinedRealm.java webapps/docs/changelog.xml
Author: markt Date: Sun Sep 5 20:43:38 2010 New Revision: 992891 URL: http://svn.apache.org/viewvc?rev=992891&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49883 Return a name for use in log messages rather than throwing an UnsupportedOperationException Modified: tomcat/trunk/java/org/apache/catalina/realm/CombinedRealm.java tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/java/org/apache/catalina/realm/CombinedRealm.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/realm/CombinedRealm.java?rev=992891&r1=992890&r2=992891&view=diff == --- tomcat/trunk/java/org/apache/catalina/realm/CombinedRealm.java (original) +++ tomcat/trunk/java/org/apache/catalina/realm/CombinedRealm.java Sun Sep 5 20:43:38 2010 @@ -48,6 +48,10 @@ public class CombinedRealm extends Realm */ protected List realms = new LinkedList(); +/** + * Descriptive information about this Realm implementation. + */ +protected static final String name = "CombinedRealm"; /** * Add a realm to the list of realms that will be used to authenticate @@ -263,13 +267,7 @@ public class CombinedRealm extends Realm @Override protected String getName() { -// This method should never be called -// Stack trace will show where this was called from -UnsupportedOperationException uoe = -new UnsupportedOperationException( -sm.getString("combinedRealm.getName")); -log.error(sm.getString("combinedRealm.unexpectedMethod"), uoe); -throw uoe; +return name; } @Override Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=992891&r1=992890&r2=992891&view=diff == --- tomcat/trunk/webapps/docs/changelog.xml (original) +++ tomcat/trunk/webapps/docs/changelog.xml Sun Sep 5 20:43:38 2010 @@ -118,6 +118,11 @@ 49876: Fix the generics warnings in the copied Apache Jakarta BCEL code. Based on a patch by Gábor. (markt) + +49883: Ensure that the CombinedRealm returns a name for use +in log messages rather than throwing an +UnsupportedOperationException. (markt) + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49883] java.lang.UnsupportedOperationException: The getName() method should never be called
https://issues.apache.org/bugzilla/show_bug.cgi?id=49883 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED OS/Version||All --- Comment #1 from Mark Thomas 2010-09-05 16:43:58 EDT --- Thanks for the report. This has been fixed in trunk and will be included in 7.0.3 onwards. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r992895 - /tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java
Author: markt Date: Sun Sep 5 21:08:42 2010 New Revision: 992895 URL: http://svn.apache.org/viewvc?rev=992895&view=rev Log: Misc code clean-up. Modified: tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java Modified: tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java?rev=992895&r1=992894&r2=992895&view=diff == --- tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java (original) +++ tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java Sun Sep 5 21:08:42 2010 @@ -217,7 +217,7 @@ public class AsyncContextImpl implements } } } else { -throw new IllegalStateException("Dispatch not allowed. Invalid state:"+state.get()); +throw new IllegalStateException("Start not allowed. Invalid state:"+state.get()); } } @@ -298,10 +298,6 @@ public class AsyncContextImpl implements return (state.get()==AsyncState.NOT_STARTED); } -public void setCompleted() { -this.state.set(AsyncState.NOT_STARTED); -} - public void doInternalDispatch() throws ServletException, IOException { if (this.state.compareAndSet(AsyncState.TIMING_OUT, AsyncState.TIMING_OUT_NEED_COMPLETE)) { @@ -408,7 +404,8 @@ public class AsyncContextImpl implements @Override public void setTimeout(long timeout) { this.timeout = timeout; - request.getCoyoteRequest().action(ActionCode.ACTION_ASYNC_SETTIMEOUT,new Long(timeout)); +request.getCoyoteRequest().action(ActionCode.ACTION_ASYNC_SETTIMEOUT, +Long.valueOf(timeout)); } public void setTimeoutState() { - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49884] NullPointerException in org.apache.catalina.core.AsyncContextImpl.doInternalComplete
https://issues.apache.org/bugzilla/show_bug.cgi?id=49884 Mark Thomas changed: What|Removed |Added OS/Version||All --- Comment #2 from Mark Thomas 2010-09-05 17:10:09 EDT --- The state changes in AsyncContextImpl aren't atomic so I think what you are seeing is the result of multiple parallel calls to doInternalComplete(). Am I correct in thinking this error is fairly rare? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49884] NullPointerException in org.apache.catalina.core.AsyncContextImpl.doInternalComplete
https://issues.apache.org/bugzilla/show_bug.cgi?id=49884 --- Comment #3 from Kevin 2010-09-05 17:42:02 EDT --- (In reply to comment #2) > The state changes in AsyncContextImpl aren't atomic so I think what you are > seeing is the result of multiple parallel calls to doInternalComplete(). Am I > correct in thinking this error is fairly rare? Yes, it is rare. The reason I reported this is that I'm load testing this servlet (well, my real servlet, but this one just to repro the problem), and every once in a while I get a 200 or 500 response that takes over 10 seconds whereas the average is half a second (using AccessLogValve %D to see this). I ran with tracing and noticed this NPE and thought maybe it's somehow related to the sporadic long request, but I don't know if it's root cause. Also, it is preceded by the "TIMING OUT!" entry, so maybe this NPE is just a side effect of the timeout? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org