Re: svn commit: r992461 - /tomcat/trunk/java/org/apache/catalina/startup/CatalinaProperties.java

2010-09-04 Thread Rainer Jung

On 03.09.2010 22:41, ma...@apache.org wrote:

Author: markt
Date: Fri Sep  3 20:41:25 2010
New Revision: 992461

URL: http://svn.apache.org/viewvc?rev=992461&view=rev
Log:
Remove debug code that was added in r991959

Modified:
 tomcat/trunk/java/org/apache/catalina/startup/CatalinaProperties.java


Big Oups, sorry and thanks!

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Preliminary Tomcat 5.5.31 Builds.

2010-09-04 Thread Rainer Jung

Hi Jim,

On 03.09.2010 21:20, Jim Jagielski wrote:

The prelim builds can be found at:

http://people.apache.org/~jim/tomcat-5.5/

I will call for an official vote early next week...


The mail factory classes are still missing, cf. BZ 49647 for details.

I guess you don't have activation.jar and mail.jar on the build system 
and property full.dist is not set. No need to retag, only reroll.


Regards,

Rainer

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Preliminary Tomcat 5.5.31 Builds.

2010-09-04 Thread Jim Jagielski

On Sep 4, 2010, at 5:52 AM, Rainer Jung wrote:

> Hi Jim,
> 
> On 03.09.2010 21:20, Jim Jagielski wrote:
>> The prelim builds can be found at:
>> 
>>  http://people.apache.org/~jim/tomcat-5.5/
>> 
>> I will call for an official vote early next week...
> 
> The mail factory classes are still missing, cf. BZ 49647 for details.
> 
> I guess you don't have activation.jar and mail.jar on the build system and 
> property full.dist is not set. No need to retag, only reroll.
> 

Grrr will reroll.

Thx for the catch!



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r992628 - /tomcat/tc5.5.x/trunk/build/BUILDING.txt

2010-09-04 Thread jim
Author: jim
Date: Sat Sep  4 15:48:32 2010
New Revision: 992628

URL: http://svn.apache.org/viewvc?rev=992628&view=rev
Log:
More 5.5 build notes

Modified:
tomcat/tc5.5.x/trunk/build/BUILDING.txt

Modified: tomcat/tc5.5.x/trunk/build/BUILDING.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/build/BUILDING.txt?rev=992628&r1=992627&r2=992628&view=diff
==
--- tomcat/tc5.5.x/trunk/build/BUILDING.txt (original)
+++ tomcat/tc5.5.x/trunk/build/BUILDING.txt Sat Sep  4 15:48:32 2010
@@ -33,7 +33,9 @@ is known to work). Do the following:
   Tomcat can be built using a 1.4.x JDK but you will need to copy the contents
   of the compat directory (created by the build process) to your build 
directory
   before Tomcat will start.
- 
+
+  The standard ASF distributions are built with a 1.4.x JDK.
+
 * If the JDK is already installed, skip to (1).
 
 * Download a Java Development Kit (JDK) release (version 1.4.x or later) from:
@@ -161,7 +163,8 @@ The documentation can be easily rebuild,
 
 (8) Building a release running tests:
 
-do
+Ensure that 'full.dist=on' is set in build.properties
+and do
 cd ${tomcat.source}/build
 ant release
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Preliminary Tomcat 5.5.31 Builds.

2010-09-04 Thread Jim Jagielski

On Sep 4, 2010, at 11:40 AM, Jim Jagielski wrote:

> 
> On Sep 4, 2010, at 5:52 AM, Rainer Jung wrote:
> 
>> Hi Jim,
>> 
>> On 03.09.2010 21:20, Jim Jagielski wrote:
>>> The prelim builds can be found at:
>>> 
>>> http://people.apache.org/~jim/tomcat-5.5/
>>> 
>>> I will call for an official vote early next week...
>> 
>> The mail factory classes are still missing, cf. BZ 49647 for details.
>> 
>> I guess you don't have activation.jar and mail.jar on the build system and 
>> property full.dist is not set. No need to retag, only reroll.
>> 
> 
> Grrr will reroll.
> 
> Thx for the catch!

OK, when trying to build to include those, I'm running into
some build/compile errors. My guess it because of using the
1.4.2 JDK... So setting full.dist=on fails. I will try with
a 1.5.x JDK and see where it goes...
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Preliminary Tomcat 5.5.31 Builds.

2010-09-04 Thread Jim Jagielski

On Sep 4, 2010, at 12:10 PM, Jim Jagielski wrote:

> 
> On Sep 4, 2010, at 11:40 AM, Jim Jagielski wrote:
> 
>> 
>> On Sep 4, 2010, at 5:52 AM, Rainer Jung wrote:
>> 
>>> Hi Jim,
>>> 
>>> On 03.09.2010 21:20, Jim Jagielski wrote:
 The prelim builds can be found at:
 
http://people.apache.org/~jim/tomcat-5.5/
 
 I will call for an official vote early next week...
>>> 
>>> The mail factory classes are still missing, cf. BZ 49647 for details.
>>> 
>>> I guess you don't have activation.jar and mail.jar on the build system and 
>>> property full.dist is not set. No need to retag, only reroll.
>>> 
>> 
>> Grrr will reroll.
>> 
>> Thx for the catch!
> 

Anyone have any problems if I simply fix the build setup
to download and build those jars if full.dist is set...?
In addition to that change and the updating of BUILDING.txt,
we should hopefully have a repeatable build...

Those changes won't be in the 5.5.31 tag but will be
in the dev branch...


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Preliminary Tomcat 5.5.31 Builds.

2010-09-04 Thread Jim Jagielski

On Sep 4, 2010, at 12:28 PM, Jim Jagielski wrote:
> 
> Anyone have any problems if I simply fix the build setup
> to download and build those jars if full.dist is set...?
> In addition to that change and the updating of BUILDING.txt,
> we should hopefully have a repeatable build...
> 
> Those changes won't be in the 5.5.31 tag but will be
> in the dev branch...
> 


This is the plan: I will put copies of activation.jar and
mail.jar under my people.apache.org site. When full.dist is
set to on, 'ant download' will download the jarfiles from
there and place them in the expected location. At which
point, 'ant release' will complete as required...


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Preliminary Tomcat 5.5.31 Builds.

2010-09-04 Thread Rainer Jung

On 04.09.2010 18:28, Jim Jagielski wrote:


On Sep 4, 2010, at 12:10 PM, Jim Jagielski wrote:



On Sep 4, 2010, at 11:40 AM, Jim Jagielski wrote:



On Sep 4, 2010, at 5:52 AM, Rainer Jung wrote:


Hi Jim,

On 03.09.2010 21:20, Jim Jagielski wrote:

The prelim builds can be found at:

http://people.apache.org/~jim/tomcat-5.5/

I will call for an official vote early next week...


The mail factory classes are still missing, cf. BZ 49647 for details.

I guess you don't have activation.jar and mail.jar on the build system and 
property full.dist is not set. No need to retag, only reroll.



Grrr will reroll.

Thx for the catch!




Anyone have any problems if I simply fix the build setup
to download and build those jars if full.dist is set...?
In addition to that change and the updating of BUILDING.txt,
we should hopefully have a repeatable build...

Those changes won't be in the 5.5.31 tag but will be
in the dev branch...


I'd be fine with it as since full.dist is not set by default. I don't 
know anything about the history of this though. I'm just guessing, that 
they are not downloaded by default because of licensing.


A more complete solution could be adding geronimo-javamail and 
geronimo-activation to download and compile as standard dependencies. 
Just an idea, I never used or tested this though but recently noticed an 
analogous discussion about JavaMail dependency on commons-dev.


Hopefully someone else knows more?

Regards,

Rainer

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r992667 - in /tomcat/tc5.5.x/trunk/build: build.properties.default build.xml

2010-09-04 Thread jim
Author: jim
Date: Sat Sep  4 19:54:45 2010
New Revision: 992667

URL: http://svn.apache.org/viewvc?rev=992667&view=rev
Log:
Pull JAF and Javamail when needed

Modified:
tomcat/tc5.5.x/trunk/build/build.properties.default
tomcat/tc5.5.x/trunk/build/build.xml

Modified: tomcat/tc5.5.x/trunk/build/build.properties.default
URL: 
http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/build/build.properties.default?rev=992667&r1=992666&r2=992667&view=diff
==
--- tomcat/tc5.5.x/trunk/build/build.properties.default (original)
+++ tomcat/tc5.5.x/trunk/build/build.properties.default Sat Sep  4 19:54:45 2010
@@ -68,6 +68,10 @@ base-sf.loc=http://switch.dl.sourceforge
 # - Additional Tomcat files base location -
 base-tomcat.loc=http://archive.apache.org/dist/tomcat
 
+# - Additional Optional-but-Required-for-Release files base location -
+activation.loc=http://people.apache.org/~jim/tomcat-5.5-opt-jars/jaf-1.1.1/activation.jar
+mail.loc=http://people.apache.org/~jim/tomcat-5.5-opt-jars/javamail-1.4.1/mail.jar
+
 # --
 #REQUIRED LIBRARIES
 # --

Modified: tomcat/tc5.5.x/trunk/build/build.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/build/build.xml?rev=992667&r1=992666&r2=992667&view=diff
==
--- tomcat/tc5.5.x/trunk/build/build.xml (original)
+++ tomcat/tc5.5.x/trunk/build/build.xml Sat Sep  4 19:54:45 2010
@@ -2101,11 +2101,28 @@
   
 
 
+
+
+
 
 
 
   
 
+  
+
+  
+  
+  
+
+
+
+  
+  
+  
+
+  
+  
   
 
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Preliminary Tomcat 5.5.31 Builds.

2010-09-04 Thread Jim Jagielski

On Sep 4, 2010, at 1:01 PM, Rainer Jung wrote:
> 
> A more complete solution could be adding geronimo-javamail and 
> geronimo-activation to download and compile as standard dependencies. Just an 
> idea, I never used or tested this though but recently noticed an analogous 
> discussion about JavaMail dependency on commons-dev.
> 

Yeah... Likely something to consider for the next go around...
For right now, we have a work-around.


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Preliminary Tomcat 5.5.31-r2 Builds.

2010-09-04 Thread Jim Jagielski
The prelim builds can be found at:

http://people.apache.org/~jim/tomcat-5.5/

I will call for an official vote early next week...

NOTE: This is the new roll which addresses the mail factory classes
missing, cf. BZ 49647

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r992707 - /tomcat/tc5.5.x/trunk/STATUS.txt

2010-09-04 Thread rjung
Author: rjung
Date: Sun Sep  5 01:22:20 2010
New Revision: 992707

URL: http://svn.apache.org/viewvc?rev=992707&view=rev
Log:
Proposal.

Modified:
tomcat/tc5.5.x/trunk/STATUS.txt

Modified: tomcat/tc5.5.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=992707&r1=992706&r2=992707&view=diff
==
--- tomcat/tc5.5.x/trunk/STATUS.txt (original)
+++ tomcat/tc5.5.x/trunk/STATUS.txt Sun Sep  5 01:22:20 2010
@@ -66,3 +66,9 @@ PATCHES PROPOSED TO BACKPORT:
   -- see attachment 25657 in BZ 49521, but I do not think that it is worth it.)
   jim: Also not comfortable with such a change this late in the game
regarding default behavior of a stable branch.
+
+* Add "**/*.pom" to "src.files" patternset in build.xml to fixcrlf
+  container/modules/groupcom/build/mvn/tribes.pom.
+  +1: rjung
+  -1:
+



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 49883] New: java.lang.UnsupportedOperationException: The getName() method should never be called

2010-09-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49883

   Summary: java.lang.UnsupportedOperationException: The getName()
method should never be called
   Product: Tomcat 7
   Version: trunk
  Platform: PC
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
AssignedTo: dev@tomcat.apache.org
ReportedBy: ke...@infofinity.com


Hi, I am running Tomcat trunk (revision 992708, 2010-09-03). I added this line
to conf/logging.properties:

org.apache.catalina.level=FINEST

The server fails to start with:

Throwable occurred: java.lang.UnsupportedOperationException: The getName()
method should never be called
at org.apache.catalina.realm.CombinedRealm.getName(CombinedRealm.java:268)
at org.apache.catalina.realm.RealmBase.toString(RealmBase.java:1015)
at java.text.MessageFormat.subformat(MessageFormat.java:1258)
at java.text.MessageFormat.format(MessageFormat.java:807)
at
org.apache.tomcat.util.res.StringManager.getString(StringManager.java:152)
at org.apache.catalina.util.LifecycleBase.setState(LifecycleBase.java:320)
at org.apache.catalina.util.LifecycleBase.setState(LifecycleBase.java:305)
at org.apache.catalina.util.LifecycleBase.init(LifecycleBase.java:98)
at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:131)
at
org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:1020)
at
org.apache.catalina.core.StandardEngine.startInternal(StandardEngine.java:276)
at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:140)
at
org.apache.catalina.core.StandardService.startInternal(StandardService.java:429)
at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:140)
at
org.apache.catalina.core.StandardServer.startInternal(StandardServer.java:649)
at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:140)
at org.apache.catalina.startup.Catalina.start(Catalina.java:584)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:48)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:600)
at org.apache.catalina.startup.Bootstrap.start(Bootstrap.java:289)
at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:416)
java.lang.reflect.InvocationTargetException
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:48)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:600)
at org.apache.catalina.startup.Bootstrap.start(Bootstrap.java:289)
at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:416)
Caused by: java.lang.UnsupportedOperationException: The getName() method should
never be called
at org.apache.catalina.realm.CombinedRealm.getName(CombinedRealm.java:268)
at org.apache.catalina.realm.RealmBase.toString(RealmBase.java:1015)
at java.text.MessageFormat.subformat(MessageFormat.java:1258)
at java.text.MessageFormat.format(MessageFormat.java:807)
at
org.apache.tomcat.util.res.StringManager.getString(StringManager.java:152)
at org.apache.catalina.util.LifecycleBase.setState(LifecycleBase.java:320)
at org.apache.catalina.util.LifecycleBase.setState(LifecycleBase.java:305)
at org.apache.catalina.util.LifecycleBase.init(LifecycleBase.java:98)
at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:131)
at
org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:1020)
at
org.apache.catalina.core.StandardEngine.startInternal(StandardEngine.java:276)
at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:140)
at
org.apache.catalina.core.StandardService.startInternal(StandardService.java:429)
at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:140)
at
org.apache.catalina.core.StandardServer.startInternal(StandardServer.java:649)
at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:140)
at org.apache.catalina.startup.Catalina.start(Catalina.java:584)
... 6 more


If I comment out that line in logging.properties, the server starts fine.
Looking at the code in LifecycleBase line 320, it is a log.debug call:

if (log.isDebugEnabled()) {
log.debug(sm.getString("lifecycleBase.setState", this, state));
}

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h

DO NOT REPLY [Bug 49884] New: NullPointerException in org.apache.catalina.core.AsyncContextImpl.doInternalComplete

2010-09-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49884

   Summary: NullPointerException in
org.apache.catalina.core.AsyncContextImpl.doInternalCo
mplete
   Product: Tomcat 7
   Version: trunk
  Platform: PC
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
AssignedTo: dev@tomcat.apache.org
ReportedBy: ke...@infofinity.com


Hi, I'm running Tomcat trunk (revision 992708, 2010-09-03) and I'm hitting an
async servlet (see attached) with Apache Bench, and every once in a while I see
a NullPointerException in
org.apache.catalina.core.AsyncContextImpl.doInternalComplete:

Sep 4, 2010 8:09:39 PM org.apache.catalina.core.AsyncContextImpl
doInternalDispatch
FINE: TIMING OUT!
Sep 4, 2010 8:09:40 PM org.apache.catalina.core.AsyncContextImpl
doInternalDispatch
FINE: TIMING OUT!
Sep 4, 2010 8:09:40 PM org.apache.catalina.core.AsyncContextImpl
doInternalComplete
SEVERE: 
Throwable occurred: java.lang.NullPointerException
at
org.apache.catalina.core.AsyncContextImpl.doInternalComplete(AsyncContextImpl.java:384)
at
org.apache.catalina.core.AsyncContextImpl.doInternalDispatch(AsyncContextImpl.java:327)
at
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:238)
at
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:201)
at
org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:163)
at
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:108)
at
org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:557)
at
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:118)
at
org.apache.catalina.connector.CoyoteAdapter.asyncDispatch(CoyoteAdapter.java:301)
at
org.apache.coyote.http11.Http11Processor.asyncDispatch(Http11Processor.java:333)
at
org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:258)
at
org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:257)
at
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:898)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:920)
at java.lang.Thread.run(Thread.java:736)

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 49884] NullPointerException in org.apache.catalina.core.AsyncContextImpl.doInternalComplete

2010-09-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49884

--- Comment #1 from Kevin  2010-09-04 23:24:22 EDT ---
Created an attachment (id=25989)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25989)
Servlet used to reproduce the problem

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org