svn commit: r958362 - in /tomcat/trunk: java/org/apache/tomcat/util/net/JIoEndpoint.java test/org/apache/catalina/core/TestAsyncListener.java webapps/docs/changelog.xml
Author: pero
Date: Sun Jun 27 11:02:10 2010
New Revision: 958362
URL: http://svn.apache.org/viewvc?rev=958362&view=rev
Log:
Start JioEndpoint timeout thread, to handle timeout a AsyncListener.
Added:
tomcat/trunk/test/org/apache/catalina/core/TestAsyncListener.java (with
props)
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java?rev=958362&r1=958361&r2=958362&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java Sun Jun 27
11:02:10 2010
@@ -399,6 +399,10 @@ public class JIoEndpoint extends Abstrac
acceptorThread.setDaemon(getDaemon());
acceptorThread.start();
}
+
+// Start async timeout thread
+Thread timeoutThread = new Thread(new AsyncTimeout(), getName() +
"-AsyncTimeout");
+timeoutThread.start();
}
}
Added: tomcat/trunk/test/org/apache/catalina/core/TestAsyncListener.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/core/TestAsyncListener.java?rev=958362&view=auto
==
--- tomcat/trunk/test/org/apache/catalina/core/TestAsyncListener.java (added)
+++ tomcat/trunk/test/org/apache/catalina/core/TestAsyncListener.java Sun Jun
27 11:02:10 2010
@@ -0,0 +1,179 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.catalina.core;
+
+import java.io.File;
+import java.io.IOException;
+
+import javax.servlet.AsyncContext;
+import javax.servlet.AsyncListener;
+import javax.servlet.AsyncEvent;
+import javax.servlet.ServletException;
+import javax.servlet.ServletResponse;
+import javax.servlet.http.HttpServlet;
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+
+import org.apache.catalina.Context;
+import org.apache.catalina.Wrapper;
+import org.apache.catalina.startup.Tomcat;
+import org.apache.catalina.startup.TomcatBaseTest;
+import org.apache.tomcat.util.buf.ByteChunk;
+
+/**
+ * Check Servlet 3.0 AsyncListener.
+ *
+ * @author Peter Rossbach
+ * @version $Revision$
+ */
+public class TestAsyncListener extends TomcatBaseTest {
+
+public void testTimeout() throws Exception {
+// Setup Tomcat instance
+Tomcat tomcat = getTomcatInstance();
+
+// Must have a real docBase - just use temp
+File docBase = new File(System.getProperty("java.io.tmpdir"));
+
+// Create the folder that will trigger the redirect
+File foo = new File(docBase, "async");
+if (!foo.exists() && !foo.mkdirs()) {
+fail("Unable to create async directory in docBase");
+}
+
+Context ctx = tomcat.addContext("/", docBase.getAbsolutePath());
+
+TimeoutServlet timeout = new TimeoutServlet();
+
+Wrapper wrapper = Tomcat.addServlet(ctx, "time", timeout);
+wrapper.setAsyncSupported(true);
+ctx.addServletMapping("/async", "time");
+
+tomcat.start();
+ByteChunk res = getUrl("http://localhost:"; + getPort() + "/async");
+Thread.sleep(4000);
+assertEquals(1,timeout.getAsyncTimeout());
+//assertEquals(1,timeout.getAsyncStart());
+assertEquals(1,timeout.getAsyncComplete());
+//assertEquals("hello start: " + timeout.getStart() + "\n",
res.toString());
+assertNull(res.toString());
+}
+
+private static class TimeoutServlet extends HttpServlet {
+private static final long serialVersionUID = 1L;
+
+private volatile int asyncStart = 0;
+private volatile int asyncComplete = 0;
+private volatile int asyncTimeout = 0;
+private volatile int asyncError = 0;
+
+private volatile long start;
+
+private int getAsyncTimeout() {
+return as
Proposal: Some todo's at AsyncContext detected...
Hi!
I detected some Todo's at AsyncContext
- AsyncContext.createListener
We don't make a resource injection or make it configurable!
Servlet 3.0 API comment:
"This method supports resource injection if the given clazz
represents a Managed Bean. See the Java EE platform and JSR 299
specifications for additional details about Managed Beans and resource
injection."
- I miss the is[Started,Completed] methods at AsyncContext interface
The only way to detect a completed state at AsyncContext inside
an AsyncListener is:
if (ac.getResponse() != null)
AsyncListener got an event, with empty state... -- Very strange!
Can't we clear all AsyncListener after send complete and before
we refresh the AsyncContext state?
How can a user handle a completed situation?
see o.a.c.core.TestAsyncListener
- AsyncContext.start() dosen't really start a thread!
We create wrapper of a Runnable, but we don't start a thread...
Error handling seam a little bit strange.
We only throw a RuntimeException(ex) and log an error!
Servlet API comment:
"Causes the container to dispatch a thread, possibly from a
managed thread pool, to run the specified Runnable. The container may
propagate appropriate contextual information to the Runnable."
How can we implement that?
Start everytime a new thread without pooling?
Use the connector executor pool from request?
Then we must extend the ProtocolHandler interface
with getExecutor() signature.
Use a separate Executor pool per Engine/Host or Context
How do we have to implemented the error handling?
- JioEndpoint has a timeout detection thread, but we don't start it!
I easy fix it with revision 958362,
but the polling strategy is slow and ineffectiv.
I didn't make a test at NIO/APR-HTTP or AJP-Connectors.
- After the timeout event is emitted, the completed method is
automatically called!
Servlet API 3.0 Spec says:
■In the event that an asynchronous operation times out, the container
must run
through the following steps:
■ Invoke the AsyncListener.onTimeout method on all the AsyncListener
instances registered with the ServletRequest on which the asynchronous
operation was initiated.
■ If none of the listeners called AsyncContext.complete() or any of
the
AsyncContext.dispatch methods, perform an error dispatch with a status
code equal to HttpServletResponse.SC_INTERNAL_SERVER_ERROR.
■ If no matching error page was found, or the error page did not call
AsyncContext.complete() or any of the AsyncContext.dispatch
methods, the container MUST call AsyncContext.complete().
===
I miss the implementation that we call the error page!
- Currently a AsyncListener can't reinit a async cycle!
see o.a.c.connector.Request.startAsync
... L1555ff
if (asyncContext==null) {
asyncContext = new AsyncContextImpl(this);
} else if (asyncContext.isStarted()) {
throw new IllegalStateException("Already started.");
}
...
What does this spec definition really mean?
=== Ch 2 Page 18
■public void onStartAsync(AsyncEvent event) - Is used to notify the
listener that a new asynchronous cycle is being initiated via a call
to one of the
ServletRequest.startAsync methods. The AsyncContext corresponding
to the asynchronous operation that is being reinitialized may be
obtained by
calling AsyncEvent.getAsyncContext on the given event.
- AsyncListener doesn't receive a onStartAsync event.
We don't implement it.
At AsyncListenerWrapper fireOnStartAsync is missing
As AsyncContext.startAsync method doesn't emit an event
- ContextClassLoader at AsyncContext.dispatch is not set!
I can't see that we correcly set the application
ContextClassLoader before
we dispatch the Request. What must we do at a CrossContext
dispatch?
- After first complete async cycle, an AsyncListner receive
onStartAsync as code start next async cycle?
Why doesn't the Servlet 3.0 TCK check basic AsyncContext
functionalities?
It seams that we better start a open test suite implementation at the
new Servlet 3.0 API.
Regards,
Peter
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Taglibs [2010/06/27]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |27717|New|Maj|2004-03-16| very slow in JSTL 1.1 | |33934|New|Cri|2005-03-09|[standard] memory leak in jstl c:set tag | |38193|Ass|Enh|2006-01-09|[RDC] BuiltIn Grammar support for Field | |38600|Ass|Enh|2006-02-10|[RDC] Enable RDCs to be used in X+V markup (X+RDC)| |42413|New|Nor|2007-05-14|[PATCH] Log Taglib enhancements | |43640|New|Nor|2007-10-16|Move the tests package to JUnit | |45197|Ass|Nor|2008-06-12|Need to support the JSTL 1.2 specification| |46052|New|Nor|2008-10-21|SetLocaleSupport is slow to initialize when many l| |48333|New|Nor|2009-12-02|TLD generator | |48773|New|Nor|2010-02-19|DataSourceWrapper and DriverManager problems | |49292|New|Nor|2010-05-14|Memory leak in org.apache.taglibs.standard.lang.js| +-+---+---+--+--+ | Total 11 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Tomcat 5 [2010/06/27]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |27122|Opn|Enh|2004-02-20|IE plugins cannot access components through Tomcat| |28039|Opn|Enh|2004-03-30|Cluster Support for SingleSignOn | |29494|Inf|Enh|2004-06-10|No way to set PATH when running as a service on Wi| |33262|Inf|Enh|2005-01-27|Service Manager autostart should check for adminis| |33453|Opn|Enh|2005-02-08|Jasper should recompile JSP files whose datestamps| |33671|Opn|Enh|2005-02-21|Manual Windows service installation with custom na| |34801|New|Enh|2005-05-08|PATCH: CGIServlet does not terminate child after a| |34805|Ass|Enh|2005-05-08|warn about invalid security constraint url pattern| |34868|Ass|Enh|2005-05-11|allow to register a trust store for a session that| |35054|Inf|Enh|2005-05-25|warn if appBase is not existing as a File or direc| |36133|Inf|Enh|2005-08-10|Support JSS SSL implementation| |36362|New|Enh|2005-08-25|missing check for Java reserved keywords in tag fi| |36569|Inf|Enh|2005-09-09|Redirects produce illegal URL's | |36837|Inf|Enh|2005-09-28|Looking for ProxyHandler implementation of Http re| |36922|Inf|Enh|2005-10-04|setup.sh file mis-advertised and missing | |37018|Ass|Enh|2005-10-11|Document how to use tomcat-SSL with a pkcs11 token| |37334|Inf|Enh|2005-11-02|Realm digest property not aligned with the adminis| |37449|Opn|Enh|2005-11-10|Two UserDatabaseRealm break manager user | |37485|Inf|Enh|2005-11-14|I'd like to run init SQL after JDBC Connection cre| |38216|Inf|Enh|2006-01-10|Extend Jmxproxy to allow call of MBean Operations | |38268|Inf|Enh|2006-01-13|User friendly: Need submit button on adding/deleti| |38360|Inf|Enh|2006-01-24|Domain for session cookies| |38546|Inf|Enh|2006-02-07|Google bot sends invalid If-Modifed-Since Header, | |38577|Inf|Enh|2006-02-08|Enhance logging of security failures | |38916|Inf|Enh|2006-03-10|HttpServletRequest cannot handle multipart request| |39053|Inf|Enh|2006-03-21|include Tomcat embedded sample| |39740|New|Enh|2006-06-07|semi-colon ; isn't allowed as a query argument sep| |39862|Inf|Enh|2006-06-22|provide support for protocol-independent GenericSe| |40211|Inf|Enh|2006-08-08|Compiled JSP don't indent HTML code | |40222|Inf|Enh|2006-08-09|Default Tomcat configuration alows easy session hi| |40402|New|Enh|2006-09-03|Manager should display Exceptions | |40510|New|Enh|2006-09-14|installer does not create shortcuts for all users | |40712|New|Enh|2006-10-10|Realm admin error.| |40728|Inf|Enh|2006-10-11|Catalina MBeans use non-serializable classes | |40766|New|Enh|2006-10-16|Using an unsecure jsessionid with mod_proxy_ajp ov| |40881|Opn|Enh|2006-11-02|Unable to receive message through TCP channel -> | |41007|Opn|Enh|2006-11-20|Can't define customized 503 error page| |41179|New|Enh|2006-12-15|400 Bad Request response during auto re-deployment| |41227|Opn|Enh|2006-12-21|When the jasper compiler fails to compile a JSP, i| |41337|Opn|Enh|2007-01-10|Display an error page if no cert is available on C| |41496|New|Enh|2007-01-30|set a security provider for jsse in a connector co| |41498|New|Enh|2007-01-30|allRolesMode Realm configuration option not docume| |41539|Inf|Enh|2007-02-05|NullPointerException during Embedded tomcat restar| |41673|New|Enh|2007-02-21|Jasper output the message of compiling error using| |41697|Ver|Enh|2007-02-25|make visible in debug output if charset from brows| |41709|Inf|Enh|2007-02-26|When calling the API that relates to the buffer af| |41718|New|Enh|2007-02-27|Status 302 response to GET request has no body whe| |42416|New|Enh|2007-05-14|Tomcat startup hangs and AJP13 connector port 8009| |43423|New|Enh|2007-09-18|catalina.sh -force too fast | |43538|New|Enh|2007-10-02|[patch] Show the hostname and IP address in the ma| |43796|Inf|Enh|2007-11-05|Add MIME type mapping for the "log" extension | |43866|
Bug report for Tomcat 6 [2010/06/27]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |39661|Opn|Enh|2006-05-25|Please document JULI FileHandler configuration pro| |41128|Inf|Enh|2006-12-07|Reference to java Thread name from RequestProcesso| |41679|New|Enh|2007-02-22|SemaphoreValve should be able to filter on url pat| |41791|New|Enh|2007-03-07|Tomcat behaves inconsistently concerning flush-pac| |41883|Ass|Enh|2007-03-18|use abstract wrapper instead of plain X509Certific| |41944|New|Enh|2007-03-25|Start running the RAT tool to see where we're miss| |41992|New|Enh|2007-03-30|Need ability to set OS process title | |42463|New|Enh|2007-05-20|"crossContext" and classloader issues - pls amend | |43001|New|Enh|2007-07-30|JspC lacks setMappedFile and setDie for use in Ant| |43003|New|Enh|2007-07-30|Separate dependent component download and build ta| |43400|New|Enh|2007-09-14|enum support for tag libs | |43497|New|Enh|2007-09-26|Add ability to escape rendered output of JSP expre| |43548|Opn|Enh|2007-10-04|xml schema for tomcat-users.xml | |43642|New|Enh|2007-10-17|Add prestartminSpareThreads attribute for Executor| |43682|New|Enh|2007-10-23|JULI: web-inf/classes/logging.properties to suppor| |43742|New|Enh|2007-10-30|.tag compiles performed one at a time -- extremel| |43790|Ass|Enh|2007-11-03|concurrent access issue on TagHandlerPool | |43979|New|Enh|2007-11-27|Add abstraction for Java and Classfile output | |44047|New|Enh|2007-12-10|Provide a way for Tomcat to serve up error pages w| |44106|New|Enh|2007-12-19|autodeploy configures directories which do not con| |44199|New|Enh|2008-01-10|expose current backlog queue size | |44225|New|Enh|2008-01-14|SSL connector tries to load the private keystore f| |44264|New|Enh|2008-01-18|Clustering - Support for disabling multicasting an| |44284|New|Enh|2008-01-23|Support java.lang.Iterable in c:forEach tag | |44294|New|Enh|2008-01-25|Support for EL functions with varargs | |44299|New|Enh|2008-01-26|Provider manager app with a log out button| |44312|New|Enh|2008-01-28|Warn when overwritting docBase of the default Host| |44598|New|Enh|2008-03-13|JAASRealm is suppressing Exceptions | |44645|New|Enh|2008-03-20|[Patch] JNDIRealm - Doesn't support JNDI "java.nam| |44787|New|Enh|2008-04-09|provide more error context on "java.lang.IllegalSt| |44818|New|Enh|2008-04-13|tomcat hangs with GET when content-length is defin| |45014|New|Enh|2008-05-15|Request and Response classes should have wrappers | |45282|New|Enh|2008-06-25|NioReceiver doesn't close cleanly, leaving sockets| |45283|Opn|Enh|2008-06-25|Allow multiple authenticators to be added to pipel| |45428|New|Enh|2008-07-18|warn if the tomcat stop doesn't complete | |45654|New|Enh|2008-08-19|use static methods and attributes in a direct way!| |45731|New|Enh|2008-09-02|Enhancement request : pluggable httpsession cache | |45832|New|Enh|2008-09-18|add DIGEST authentication support to Ant tasks| |45871|New|Enh|2008-09-23|Support for salted and digested patches in DataSou| |45878|New|Enh|2008-09-24|Generated jars do not contain proper manifests or | |45879|Opn|Enh|2008-09-24|Windows installer fails to install NOTICE and RELE| |45931|Opn|Enh|2008-10-01|trimSpaces incorrectly modifies output| |45995|New|Enh|2008-10-13|RFE - MIME type extension not case sensitive | |46173|New|Enh|2008-11-09|Small patch for manager app: Setting an optional c| |46263|New|Enh|2008-11-21|Tomcat reloading of context does not update contex| |46264|New|Enh|2008-11-21|Shutting down tomcat with large number of contexts| |46284|New|Enh|2008-11-24|Add flag to DeltaManager that blocks processing cl| |46350|New|Enh|2008-12-05|Maven repository should contain source bundles| |46451|New|Enh|2008-12-30|Configure svn:bugtraq properties | |46461|New|Enh|2009-01-01|fail graceful on dns changes for connectors/hosts | |46497|New|Enh|2009-01-08|Install Tomcat Deployer/ANT on Windows Platform | |46558|
Bug report for Tomcat 7 [2010/06/27]
+---+
| Bugzilla Bug ID |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) |
| | +-+
| | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major |
| | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial |
| | | +-+
| | | | Date Posted |
| | | | +--+
| | | | | Description |
| | | | | |
|48240|New|Nor|2009-11-19|Tomcat-Lite missing @Override markers |
|48268|New|Nor|2009-11-23|Patch to fix generics in tomcat-lite |
|48297|New|Nor|2009-11-28|webservices.ServiceRefFactory.initHandlerChain add|
|48550|New|Enh|2010-01-14|Update examples and default server.xml to use UTF-|
|48648|New|Nor|2010-01-31|Blank page (dropped connection) when running TC7 w|
|48692|New|Enh|2010-02-07|Provide option to parse application/x-www-form-url|
|48817|New|Nor|2010-02-25|Skip validation query and use JDBC API for validat|
|48837|New|Enh|2010-03-01|Memory leaks protection does not cure leaks trigge|
|48861|New|Nor|2010-03-04|Files without AL headers |
|48870|New|Enh|2010-03-08|avoid parallel arrays of base types |
|48891|New|Enh|2010-03-11|Missing EOL-style settings in tomcat/jk/trunk |
|48892|New|Enh|2010-03-11|Use URIEncoding from server.xml for decoding post |
|48998|New|Enh|2010-03-26|Proposal : port mod_expires in java as ExpiresFilt|
|49000|New|Enh|2010-03-26|Cookie parsing bug when an empty value has an equa|
|49100|New|Enh|2010-04-12|Mutable public constants: MemberImpl.TRIBES_MBR_BE|
|49101|New|Enh|2010-04-12|All constants in tribes.transport.Constants are mu|
|49102|New|Enh|2010-04-12|coyote.ajp.Constants - 3 "constant" arrays are mut|
|49125|New|Enh|2010-04-14|toString on byte[] array probably is not correct |
|49126|New|Enh|2010-04-14|jasper.compiler.Generator.createJspId() can genera|
|49127|New|Enh|2010-04-14|SimpleTcpReplicationManager.startInternal() ignore|
|49128|New|Enh|2010-04-14|loader.WebappClassLoader.start() ignores Exception|
|49130|New|Enh|2010-04-14|NSIS - clarify that service is always installed |
|49142|New|Enh|2010-04-16|Missing serialVersionUIDs |
|49159|New|Enh|2010-04-20|Improve ThreadLocal memory leak clean-up |
|49165|New|Enh|2010-04-21|Enhancement - Allow %{TIME_FORMAT}t As Configurati|
|49180|New|Enh|2010-04-24|Add option to disable log rotation in FileHandler.|
|49182|New|Enh|2010-04-24|Documentation patch for setclasspath.sh |
|49234|New|Nor|2010-04-30|JMX Descriptor Modifications |
|49268|New|Enh|2010-05-10|Use checkstyle to enforce common code style |
|49284|New|Enh|2010-05-12|Implement SSL renegotiation for the NIO connector |
|49290|New|Enh|2010-05-14|Using a JarScanner with scanAllDirectories=true ca|
|49295|New|Enh|2010-05-14|JMXAccessorTask.getProperties() - return Propertie|
|49297|New|Min|2010-05-15|Whitespace absence is allowed before attribute nam|
|49317|New|Enh|2010-05-20|org.apache.catalina.util.Base64 interface needs re|
|49318|New|Enh|2010-05-20|add a Negotiate (Kerberos/NTLM) authenticator / in|
|49395|New|Enh|2010-06-06|manager.findLeaks : display the date when the leak|
|49426|New|Nor|2010-06-11|Manager app wrongly localized |
|49428|New|Nor|2010-06-11|Fix WebDAV mounts from Windows Mini-Redirector cli|
|49442|New|Enh|2010-06-15|Make StringManager fields final |
|49478|New|Enh|2010-06-21|Add encoding parameter to AddDefaultCharSetFilter |
|49503|New|Nor|2010-06-25|Connectors do not bind to their ports in Catalina.|
+-+---+---+--+--+
| Total 41 bugs |
+---+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Tomcat Connectors [2010/06/27]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |34526|Opn|Nor|2005-04-19|Truncated content in decompressed requests from mo| |35959|Opn|Enh|2005-08-01|mod_jk not independant of UseCanonicalName| |36155|Opn|Nor|2005-08-12|tomcat chooses wrong host if using mod_jk | |39967|Inf|Nor|2006-07-05|mod_jk gives segmentation fault when apache is sta| |40208|Inf|Nor|2006-08-08|Request-Dump when ErrorDocument in httpd.conf is a| |41170|Inf|Nor|2006-12-13|single crlf in header termination crashes app.| |41923|Opn|Nor|2007-03-21|Tomcat doesnt recognized client abort | |42366|Inf|Nor|2007-05-09|Memory leak in newer mod_jk version when connectio| |42554|Opn|Nor|2007-05-31|mod_ssl + mod_jk with status_worker does not work | |43303|New|Enh|2007-09-04|Versioning under Windows not reported by many conn| |43968|New|Enh|2007-11-26|[patch] support ipv6 with mod_jk | |44290|New|Nor|2008-01-24|mod_jk/1.2.26: retry is not useful for an importan| |44349|New|Maj|2008-02-04|mod_jk/1.2.26 module does not read worker.status.s| |44379|New|Enh|2008-02-07|convert the output of strftime into UTF-8 | |44454|New|Nor|2008-02-19|busy count reported in mod_jk inflated, causes inc| |44571|New|Enh|2008-03-10|Limits busy per worker to a threshold | |45063|New|Nor|2008-05-22|JK-1.2.26 IIS ISAPI filter issue when running diff| |45313|New|Nor|2008-06-30|mod_jk 1.2.26 & apache 2.2.9 static compiled on so| |45395|New|Min|2008-07-14|MsgAjp dump method does not dump packet when being| |46337|New|Nor|2008-12-04|real worker name is wrong | |46406|New|Enh|2008-12-16|Supporting relative paths in isapi_redirect.proper| |46676|New|Enh|2009-02-09|Configurable test request for Watchdog thread | |46767|New|Enh|2009-02-25|mod_jk to send DECLINED in case no fail-over tomca| |47038|New|Enh|2009-04-15|USE_FLOCK_LK redefined compiler warning when using| |47327|New|Enh|2009-06-07|remote_user not logged in apache logfile | |47617|New|Enh|2009-07-31|include time spent doing ajp_get_endpoint() in err| |47678|New|Nor|2009-08-11|Unable to allocate shared memory when using isapi_| |47679|New|Nor|2009-08-11|Not all headers get passed to Tomcat server from i| |47692|New|Reg|2009-08-12|Can not compile mod_jk with apache2.0.63 and tomca| |47714|New|Cri|2009-08-20|Reponse mixed between users | |47750|New|Maj|2009-08-27|Loss of worker settings when changing via jkstatus| |47795|New|Maj|2009-09-07|service sticky_session not being set correctly wit| |47840|Inf|Min|2009-09-14|A broken worker name is written in the log file. | |48191|New|Maj|2009-11-13|Problem with mod_jk 1.2.28 - Can not render up the| |48490|New|Nor|2010-01-05|Changing a node to stopped in uriworkermap.propert| |48501|New|Enh|2010-01-07|Log rotation for ISAPI Redirector | |48513|New|Enh|2010-01-09|IIS Quick setup instructions | |48564|New|Nor|2010-01-18|Unable to turn off retries for LB worker | |48830|New|Nor|2010-03-01|IIS shutdown blocked in endpoint service when serv| |48925|New|Maj|2010-03-16|((ServletRequest) request).getLocalAddr() returns | |48940|New|Maj|2010-03-18|IIS to Tomcat occasionally fails on POST with T-E | |49035|New|Maj|2010-04-01|data lost when post a multipart/form-data form| |49048|New|Nor|2010-04-05|ACL not applied to redirect URLs | |49063|New|Enh|2010-04-07|Please add JkStripSession status in jk-status work| |49135|New|Enh|2010-04-16|SPDY Connector for The Tomcat | |49413|Opn|Reg|2010-06-09|Apache Mod_jk 1.2.30 is shutting down communicatio| |49469|New|Enh|2010-06-19|Workers status page has negative number of connect| +-+---+---+--+--+ | Total 47 bugs | +---+ - To unsubscribe
Bug report for Tomcat Native [2010/06/27]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |38372|Inf|Cri|2006-01-25|tcnative-1.dll response overflow corruption, parti| |41361|New|Nor|2007-01-14|Content lost when read by a slow client. | |42090|New|Cri|2007-04-11|tcnative badly handles some OpenSSL disconnections| |45392|New|Nor|2008-07-14|No OCSP support for client SSL verification | |46041|New|Cri|2008-10-20|Tomcat service is terminated unexpectedly (tcnativ| |46179|New|Maj|2008-11-10|apr ssl client authentication | |46571|New|Nor|2009-01-21|tcnative blocks in APR poll on Solaris| |47319|New|Nor|2009-06-05|With APR, getRemoteHost() returns NULL for unknown| |47851|New|Nor|2009-09-16|thread-safety issues in the TC native Java code | |48253|New|Min|2009-11-20|Tomcat Native patch - adding dynamic locking callb| |48655|New|Nor|2010-02-02|Active multipart downloads prevent tomcat shutdown| |49038|Inf|Nor|2010-04-02|Crash in tcnative | +-+---+---+--+--+ | Total 12 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49234] JMX Descriptor Modifications
https://issues.apache.org/bugzilla/show_bug.cgi?id=49234 --- Comment #51 from chamith buddhika 2010-06-27 07:38:53 EDT --- I cannot seem to find classes FastCommonAccessLogValve, RequestDamperValve and RequestListenerValve described in o.a.Catalina.Valves. Have they been removed from the code base? Will it be possible to remove their descriptors? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49509] New: JULI does not read logging config from Java home dir
https://issues.apache.org/bugzilla/show_bug.cgi?id=49509 Summary: JULI does not read logging config from Java home dir Product: Tomcat 5 Version: 5.5.23 Platform: Macintosh Status: NEW Severity: normal Priority: P2 Component: Unknown AssignedTo: dev@tomcat.apache.org ReportedBy: jsb_apa...@360works.com Changes that I am making to /Library/Java/Home/lib/logging.properties ( /Library/Java/Home is always the Java home directory on OS X ) are not having any effect on logging. It works correctly if I take the logging.properties file from that directory and copy it into the compiled classes directory. This gives me the impression that JULI is only reading the config file from the classloader, and not from the Java home directory as documented. The Tomcat docs at http://tomcat.apache.org/tomcat-5.5-doc/logging.html state: logging can be configured at the following layers: In the JDK's logging.properties file. Check your JAVA_HOME environment setting to see which JDK Tomcat is using (or maybe JRE 5.0 as Tomcat can now run on a JRE from version 5.5). The file will be in $JAVA_HOME/jre/lib. Alternately, it can also use a global configuration file located elsewhere by using the system property java.util.logging.config.file, or programmatic configuration using java.util.logging.config.class. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49234] JMX Descriptor Modifications
https://issues.apache.org/bugzilla/show_bug.cgi?id=49234 --- Comment #52 from Rainer Jung 2010-06-27 13:15:50 EDT --- (In reply to comment #51) > I cannot seem to find classes FastCommonAccessLogValve, RequestDamperValve and > RequestListenerValve described in o.a.Catalina.Valves. Have they been removed > from the code base? Will it be possible to remove their descriptors? See: http://svn.apache.org/viewvc?view=revision&revision=769347 http://svn.apache.org/viewvc?view=revision&revision=805375 http://svn.apache.org/viewvc?view=revision&revision=302036 Regards, Rainer -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49509] JULI does not read logging config from Java home dir
https://issues.apache.org/bugzilla/show_bug.cgi?id=49509 Konstantin Kolinko changed: What|Removed |Added Component|Unknown |Webapps:Documentation OS/Version||All --- Comment #1 from Konstantin Kolinko 2010-06-27 13:39:46 EDT --- The documentation is incomplete there. Actually, the standard startup script, bin/catalina.sh, passes the following argument when launching the JVM: -Djava.util.logging.config.file="$CATALINA_BASE/conf/logging.properties thus you can find the configuration file in the "conf" directory. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49510] New: Remove dependency on classes copied from commons
https://issues.apache.org/bugzilla/show_bug.cgi?id=49510 Summary: Remove dependency on classes copied from commons Product: Taglibs Version: 1.2.0 Platform: Macintosh Status: NEW Severity: enhancement Priority: P2 Component: Standard Taglib AssignedTo: dev@tomcat.apache.org ReportedBy: jboy...@apache.org The "extra" package in standard-impl contains classes copied from Commons Collections, primarily LRUMap used in ElEvaluator and FormatDateSupport. Comments indicate this can be replaced with LinkedHashMap if the baseline is set to Java 1.4 and the project is now using Java5 so these could be removed. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49510] Remove dependency on classes copied from commons
https://issues.apache.org/bugzilla/show_bug.cgi?id=49510 --- Comment #1 from Jeremy Boynes 2010-06-27 13:52:47 EDT --- Created an attachment (id=25647) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25647) Patch remove dependencies on LRUMap Once applied, the project will compile with the extras directory removed completely. There's other things in there that don't appear to be used. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49509] JULI does not read logging config from Java home dir
https://issues.apache.org/bugzilla/show_bug.cgi?id=49509 --- Comment #2 from Jesse Barnum 2010-06-27 14:18:20 EDT --- Thanks for the fast response. I'm embedding Tomcat inside my application, so I'm not using the standard startup script. Why not just have it read from $JAVA_HOME/lib/logging.properties by default, like any other Java application? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r958406 - /tomcat/trunk/webapps/docs/changelog.xml
Author: pero Date: Sun Jun 27 18:41:48 2010 New Revision: 958406 URL: http://svn.apache.org/viewvc?rev=958406&view=rev Log: remove second fix entry. Sorry! Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=958406&r1=958405&r2=958406&view=diff == --- tomcat/trunk/webapps/docs/changelog.xml (original) +++ tomcat/trunk/webapps/docs/changelog.xml Sun Jun 27 18:41:48 2010 @@ -38,10 +38,6 @@ -Start JioEndpoint timeout thread, to inform AsyncListner as async timeout is set -and application thread doesn't finished. (pero) - - GSOC 2010. Continue work to align MBean descriptors with reality. Patch provided by Chamith Buddhika. (markt) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[taglibs] Thread safety in FormatDateSupport
I was looking at a patch for FormatDateSupport [1] to remove its dependency on a copy of LRUMap taken from Commons and have a question on the thread safety involved as, although the cache is synchronized, the formatters it contains are used outside that block. This was discussed in bug 32311 [2] but the synchronization code suggested there wasn't added. Am I missing something, or should I reopen 32311 and add a patch? -- Jeremy [1] http://svn.apache.org/repos/asf/tomcat/taglibs/standard/trunk/impl/src/main/java/org/apache/taglibs/standard/tag/common/fmt/FormatDateSupport.java [2] https://issues.apache.org/bugzilla/show_bug.cgi?id=32311#c4
svn commit: r958438 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: kkolinko Date: Mon Jun 28 01:49:19 2010 New Revision: 958438 URL: http://svn.apache.org/viewvc?rev=958438&view=rev Log: vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=958438&r1=958437&r2=958438&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Mon Jun 28 01:49:19 2010 @@ -89,6 +89,7 @@ PATCHES PROPOSED TO BACKPORT: http://people.apache.org/~rjung/patches/2010-05-14-loader-backport-r936823.patch +1: rjung +1: markt if r956252 is also applied + +1: kkolinko if r956252 is also applied -1: Expose the new WebappLoader flag in the VirtualWebappLoader, @@ -103,11 +104,14 @@ PATCHES PROPOSED TO BACKPORT: http://people.apache.org/~rjung/patches/2010-05-14-loader-backport-r936825.patch +1: rjung -1: + -0: kkolinko: The patch itself is OK, but I think having a synonym will + cause confusion. I'd prefer not to invent a new name, but mention the + one that we already have when documenting virtualClasspath. Respect configurable search order in getURLs(). http://svn.apache.org/viewvc?view=revision&revision=936892 http://people.apache.org/~rjung/patches/2010-05-14-loader-backport-r936892.patch - +1: rjung + +1: rjung, kkolinko -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49343 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49509] JULI does not read logging config from Java home dir
https://issues.apache.org/bugzilla/show_bug.cgi?id=49509 --- Comment #3 from Konstantin Kolinko 2010-06-27 22:28:55 EDT --- > Why not just have it read from > $JAVA_HOME/lib/logging.properties by default, like any other Java application? It does, from $JRE_HOME/lib/logging.properties. There is a rule in the conf/catalina.policy to allow reading that file. There are chances that your logging is misconfigured. Tomcat JULI is just an implementation of java.util.logging (JUL), and unless JUL is configured to use JULI when the application starts (using those java.util.logging.* properties passed by catalina.sh) it will not be used. Moreover, Tomcat does not use it directly, but through the commons-logging library. That would be a question for the users@ mailing list. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49505] ApplicationHttpRequest.setAttribute doesn't call the wrapper's setAttribute in case of "special" attributes
https://issues.apache.org/bugzilla/show_bug.cgi?id=49505
ran...@hotmail.com changed:
What|Removed |Added
Resolution|INVALID |FIXED
--- Comment #2 from ran...@hotmail.com 2010-06-27 22:48:41 EDT ---
Thanks Mark, several issues.
1. considering Tomcat is open-source and so, do you think it would be a big
problem if I replace the code
if (!setSpecial(name, value)) {
getRequest().setAttribute(name, value);
}
with
setSpecial(name, value));
getRequest().setAttribute(name, value);
?
In my tests, my code seems to work fine with the modified version, is just that
I might not realize all the implications of doing this.
2. talking about specification. It's true that the spec doesn't state clearly
that the attributes must be set using the wrapper's setAttribute, but one must
wonder why that kind of overriding would be allowed, if not to be used by the
container. In this particular case, the choice looks somewhat random (call
setAttributes only on some attributes, but not on all), and is obviously
limiting for the user.
appreciate your help,
Ranjix
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49505] ApplicationHttpRequest.setAttribute doesn't call the wrapper's setAttribute in case of "special" attributes
https://issues.apache.org/bugzilla/show_bug.cgi?id=49505 ran...@hotmail.com changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED | -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49505] ApplicationHttpRequest.setAttribute doesn't call the wrapper's setAttribute in case of "special" attributes
https://issues.apache.org/bugzilla/show_bug.cgi?id=49505 --- Comment #3 from ran...@hotmail.com 2010-06-27 23:11:05 EDT --- p.s. regarding "Your wrapper should be able to call getAttribute() to determine if these attributes have been set." I do call the wrapper's getAttribute method to see if those attributes have been set, but they weren't (although I'm in an included jsp), since the setAttribute on the wrapper hasn't been called (because of the "if setSpecial" thing). hope it's more clear, thanks. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
