svn commit: r957130 - in /tomcat/trunk/java/org/apache/catalina/core: JreMemoryLeakPreventionListener.java LocalStrings.properties
Author: markt Date: Wed Jun 23 07:40:19 2010 New Revision: 957130 URL: http://svn.apache.org/viewvc?rev=957130&view=rev Log: Improve the fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=49230 Don't log an error about loading Sun class on non-Sun JVMs. Use i18n for message. Modified: tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java tomcat/trunk/java/org/apache/catalina/core/LocalStrings.properties Modified: tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java?rev=957130&r1=957129&r2=957130&view=diff == --- tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java (original) +++ tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java Wed Jun 23 07:40:19 2010 @@ -201,8 +201,13 @@ public class JreMemoryLeakPreventionList try { Class.forName("sun.net.www.http.HttpClient"); } catch (ClassNotFoundException e) { -log.error("Could not prevent sun.net.www.http.HttpClient" + - " from being loaded.", e); +if (System.getProperty("java.vendor").startsWith("Sun")) { +log.error(sm.getString( +"jreLeakListener.keepAliveFail"), e); +} else { +log.debug(sm.getString( +"jreLeakListener.keepAliveFail"), e); +} } } Modified: tomcat/trunk/java/org/apache/catalina/core/LocalStrings.properties URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/LocalStrings.properties?rev=957130&r1=957129&r2=957130&view=diff == --- tomcat/trunk/java/org/apache/catalina/core/LocalStrings.properties (original) +++ tomcat/trunk/java/org/apache/catalina/core/LocalStrings.properties Wed Jun 23 07:40:19 2010 @@ -76,6 +76,7 @@ httpEngineMapper.container=This containe httpHostMapper.container=This container is not a StandardHost interceptorValve.alreadyStarted=InterceptorValve has already been started interceptorValve.notStarted=InterceptorValve has not yet been started +jreLeakListener.keepAliveFail=Failed to trigger creation of the sun.net.www.http.HttpClient class during Tomcat start to prevent possible memory leaks. This is expected on non-Sun JVMs. jreLeakListener.gcDaemonFail=Failed to trigger creation of the GC Daemon thread during Tomcat start to prevent possible memory leaks. This is expected on non-Sun JVMs. jreLeakListener.jarUrlConnCacheFail=Failed to disable Jar URL connection caching by default jreLeakListener.xmlParseFail=Error whilst attempting to prevent memory leaks during XML parsing - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r957132 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Wed Jun 23 07:43:13 2010 New Revision: 957132 URL: http://svn.apache.org/viewvc?rev=957132&view=rev Log: Propose update. Remove old votes since the patch has changed Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=957132&r1=957131&r2=957132&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Wed Jun 23 07:43:13 2010 @@ -171,7 +171,6 @@ PATCHES PROPOSED TO BACKPORT: Additional JRE leak protection. HttpClient keep-alive thread Patch by Rob Kooper http://svn.apache.org/viewvc?rev=956832&view=rev - +1: markt, kfujino + http://svn.apache.org/viewvc?rev=957130&view=rev + +1: markt -1: - kkolinko: +1 if it is off by default, +0 otherwise, because handling of - non-Sun JREs should be improved here. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49230] sun.net.www.http.KeepAliveCache preventing classloader from being garbage collected
https://issues.apache.org/bugzilla/show_bug.cgi?id=49230 --- Comment #3 from Mark Thomas 2010-06-23 03:44:14 EDT --- I've aligned the patch with how we handle other Sun specific issues for non-Sun JVMs. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r957139 - /tomcat/trunk/java/org/apache/catalina/filters/CsrfPreventionFilter.java
Author: markt Date: Wed Jun 23 08:14:14 2010 New Revision: 957139 URL: http://svn.apache.org/viewvc?rev=957139&view=rev Log: Trim the value before adding to the list Review feedback from kkolinko Modified: tomcat/trunk/java/org/apache/catalina/filters/CsrfPreventionFilter.java Modified: tomcat/trunk/java/org/apache/catalina/filters/CsrfPreventionFilter.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/filters/CsrfPreventionFilter.java?rev=957139&r1=957138&r2=957139&view=diff == --- tomcat/trunk/java/org/apache/catalina/filters/CsrfPreventionFilter.java (original) +++ tomcat/trunk/java/org/apache/catalina/filters/CsrfPreventionFilter.java Wed Jun 23 08:14:14 2010 @@ -70,7 +70,7 @@ public class CsrfPreventionFilter extend public void setEntryPoints(String entryPoints) { String values[] = entryPoints.split(","); for (String value : values) { -this.entryPoints.add(value); +this.entryPoints.add(value.trim()); } } - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r957152 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: kkolinko Date: Wed Jun 23 10:51:47 2010 New Revision: 957152 URL: http://svn.apache.org/viewvc?rev=957152&view=rev Log: vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=957152&r1=957151&r2=957152&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Wed Jun 23 10:51:47 2010 @@ -39,6 +39,15 @@ PATCHES PROPOSED TO BACKPORT: -1: fhanik - easier to pass in the root path (lib/bin) to the macro instead of hacking around it if we remove the SCP auto feature, then there should be something to replace it with (http://ant.apache.org/manual/OptionalTasks/scp.html) + -1: kkolinko: + 1. Ignoring ${maven.repo.url} in does not look good, +because that is a valuable argument, provided by deploy-snapshot, +deploy-staging and deploy-release targets. +I say/agree that there can be several implementations of this deploy +action (ssh + key, local, ssh + pwd?), so maybe split it into several +implementations and select one based on what property is defined. + 2. It publishes wrong tomcat-juli.jar, as already noted, +http://markmail.org/message/5sysomjlrfhcd3ec * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48545 Truststores don't have to have passwords @@ -172,5 +181,5 @@ PATCHES PROPOSED TO BACKPORT: Patch by Rob Kooper http://svn.apache.org/viewvc?rev=956832&view=rev http://svn.apache.org/viewvc?rev=957130&view=rev - +1: markt + +1: markt, kkolinko -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
SEVERE: Error listenerStart
Jun 23, 2010 3:14:33 PM org.apache.catalina.core.StandardContext addApplicationListener INFO: The listener "org.springframework.web.context.ContextLoaderListener" is already configured for this context. The duplicate definition has been ignored. Jun 23, 2010 3:14:34 PM org.apache.catalina.core.StandardContext start SEVERE: Error listenerStart Jun 23, 2010 3:14:34 PM org.apache.catalina.core.StandardContext start SEVERE: Context [/ALS] startup failed due to previous errors Please help me to solve this problem, thanks in advance, Rajeev -- View this message in context: http://old.nabble.com/SEVERE%3A-Error-listenerStart-tp28970671p28970671.html Sent from the Tomcat - Dev mailing list archive at Nabble.com. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: SEVERE: Error listenerStart
On 23/06/2010 12:40, rajeevP wrote: > > Jun 23, 2010 3:14:33 PM org.apache.catalina.core.StandardContext > addApplicationListener > INFO: The listener "org.springframework.web.context.ContextLoaderListener" > is already configured for this context. The duplicate definition has been > ignored. > Jun 23, 2010 3:14:34 PM org.apache.catalina.core.StandardContext start > SEVERE: Error listenerStart > Jun 23, 2010 3:14:34 PM org.apache.catalina.core.StandardContext start > SEVERE: Context [/ALS] startup failed due to previous errors > > Please help me to solve this problem, thanks in advance, > Rajeev This would be a question for the Tomcat Users list. p signature.asc Description: OpenPGP digital signature
[Tomcat Wiki] Update of "PoweredBy" by RichardKnowles
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "PoweredBy" page has been changed by RichardKnowles. http://wiki.apache.org/tomcat/PoweredBy?action=diff&rev1=260&rev2=261 -- === TrycksaksTorget === {{http://www.trycksakstorget.se/images/v2/main_logo.gif}} [[http://www.trycksakstorget.se/|TrycksaksTorget]] - webbased print solutions. + + === Virtual Pair Programmers === + {{https://www.virtualpairprogrammers.com/img/logo.gif}} [[http://www.virtualpairprogrammers.com|VirtualPairProgrammers]] - power their E-Commerce operation on Tomcat. === Volagratis.it === [[http://www.volagratis.com/vg1/home.do?utm_source=VG&utm_medium=TOM&utm_campaign=1|Volagratis.it]] is an E-Commerce site. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49030] Processing of Tomcat Connector configuration can leave some connectors uninitialized
https://issues.apache.org/bugzilla/show_bug.cgi?id=49030 --- Comment #4 from Konstantin Kolinko 2010-06-23 09:08:38 EDT --- I like this, but there are caveats implementing this feature: 1. Connectors that fail in a call to initialize() will also likely to fail in start(), pause(), stop(). Thus all the loops over connectors have to be safeguarded. This includes loops over array returned by StandardService.findConnectors(), e.g. in ServerLifecycleListener#destroyMBeans(Service). 2. Need to reimplement support for org.apache.catalina.startup.EXIT_ON_INIT_FAILURE=true configuration property [1], [2]. [1] http://tomcat.apache.org/tomcat-6.0-doc/config/systemprops.html [2] https://issues.apache.org/bugzilla/show_bug.cgi?id=48625 As a test case for this feature one can try to start a second instance of Tomcat using the same configuration. If the above EXIT_ON_INIT_FAILURE setting is added to conf/catalina.properties, Tomcat 6.0.27 will abort startup on the first init() failure. If the init() exception were caught and startup continued, as proposed patch does, the abort does not happen. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Log all http request
Hello, we've a web service that receives SOAP RPC-encoded xml requests on HTTP through axis and tomcat 5.5. We'd like to log every xml rq we receive using a Filter, because we've to write the xml to a file whose name depends on the xml request. The problem is that one can call SevletRequest.getReader once. So we extended HttpServletRequestWrapper with the class in attachment, to read the request body once in a string and then to wrap the getReader method. Then we create a "clone" of the request we receive in the filter Is this a good way or there's another standard way to read HTTP request body in a Filter? Should we implement an axis handler? Many many thanks in advance Best regards Bartolomeo package com.siap.Utility; import java.io.BufferedReader; import java.io.ByteArrayInputStream; import java.io.StringReader; import javax.servlet.ServletInputStream; import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletRequestWrapper; /** * Filtra le richieste ai WebServices per salvare l'xml di richiesta e salvarlo in un determinato * path con un nome specifico * @author Marco Rosa - 23/giu/10 */ public class SiapHttpServletRequestWrapper extends HttpServletRequestWrapper { String rq_xml = ""; SiapHttpServletRequestWrapper( HttpServletRequest rq ){ super(rq); // save xml StringBuffer strbuf = new StringBuffer(""); try{ BufferedReader reader = rq.getReader(); //... Loop as long as there are input lines. String line = null; while ((line=reader.readLine()) != null) { strbuf.append(line); strbuf.append("\n"); // Write system dependent end of line. } //... Close reader and writer. reader.close(); // Close to unlock. rq_xml = strbuf.toString(); }catch( Exception e){ } } private class SiapServletInputStream extends ServletInputStream{ ByteArrayInputStream m_r =null; SiapServletInputStream( ByteArrayInputStream r ){ m_r = r; } public int read(){ return m_r.read(); } public int read(byte[] b, int off, int len) { return m_r.read(b, off, len ); } //public int readLine(byte[] b, int off, int len) { // return m_r.readLine( b, off, len); //} } public ServletInputStream getInputStream(){ SiapServletInputStream retVal = null; try{ retVal = new SiapServletInputStream(new ByteArrayInputStream(rq_xml.getBytes("UTF-8"))); }catch(Exception e ){ } return retVal; } public BufferedReader getReader(){ return new BufferedReader( new StringReader(rq_xml) ); } /** * * @author Marco Rosa - 23/giu/10 */ public String getRq_xml() { return rq_xml; } /** * * @author Marco Rosa - 23/giu/10 */ public void setRq_xml(String rq_xml) { this.rq_xml = rq_xml; } } - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49494] New: Conflict with Oracle TNSListener resolved by upgrading to Tomcat 6
https://issues.apache.org/bugzilla/show_bug.cgi?id=49494 Summary: Conflict with Oracle TNSListener resolved by upgrading to Tomcat 6 Product: Tomcat 5 Version: Unknown Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Priority: P2 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: steven.calk...@crossmediasolutions.de The Oracle TNS Listeners from 9.2 through 11, running as a windows service would automatically start on boot then stop when running concurrently with TOMCAT 5.5 up to subversion 17. I did not test whether later versions produced this effect. The Oracle TNS Listeners could be started manually, so it was not a major problem. Upgrading to Tomcat 6 eliminated the problem. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49494] Conflict with Oracle TNSListener resolved by upgrading to Tomcat 6
https://issues.apache.org/bugzilla/show_bug.cgi?id=49494 Steven Calkins changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49495] New: EL evaluator does not evaluate expression following #
https://issues.apache.org/bugzilla/show_bug.cgi?id=49495 Summary: EL evaluator does not evaluate expression following # Product: Tomcat 6 Version: 6.0.24 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P2 Component: Jasper AssignedTo: dev@tomcat.apache.org ReportedBy: kg...@speakeasy.net I have the following expression in a tag: The evaluated expression contains the segment "((#${lookupParameters}#))" without the expression ${lookupParameters} being evaluated. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49495] EL evaluator does not evaluate expression following #
https://issues.apache.org/bugzilla/show_bug.cgi?id=49495 --- Comment #1 from Konstantin Kolinko 2010-06-23 17:49:39 EDT --- Looks like a duplicate of bug 49081. Please try with 6.0.27 http://markmail.org/thread/hqq3fc7u6nc257ee -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49081] EL expression preceded by a # in an attribute value of jsp documents
https://issues.apache.org/bugzilla/show_bug.cgi?id=49081 Ken Geis changed: What|Removed |Added CC||kg...@speakeasy.net --- Comment #3 from Ken Geis 2010-06-23 17:57:37 EDT --- *** Bug 49495 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49495] EL evaluator does not evaluate expression following #
https://issues.apache.org/bugzilla/show_bug.cgi?id=49495 Ken Geis changed: What|Removed |Added Status|NEW |RESOLVED Resolution||DUPLICATE --- Comment #2 from Ken Geis 2010-06-23 17:57:36 EDT --- Sorry, I did try to search for an existing bug before filing, but it's hard to search on #! I am comfortable with resolving this as a duplicate. It looks like an identical issue, and I don't have much chance to try it out on a Tomcat version that's unreleased and not part of an Ubuntu distribution. *** This bug has been marked as a duplicate of bug 49081 *** -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49030] Processing of Tomcat Connector configuration can leave some connectors uninitialized
https://issues.apache.org/bugzilla/show_bug.cgi?id=49030 --- Comment #5 from Konstantin Kolinko 2010-06-23 21:47:06 EDT --- Created an attachment (id=25633) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25633) 2010-06-24_tc6_bug49030.patch Patch for tc6.0.x -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r957400 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: kkolinko Date: Thu Jun 24 01:48:57 2010 New Revision: 957400 URL: http://svn.apache.org/viewvc?rev=957400&view=rev Log: vote and proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=957400&r1=957399&r2=957400&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Jun 24 01:48:57 2010 @@ -64,11 +64,13 @@ PATCHES PROPOSED TO BACKPORT: ignored http://people.apache.org/~markt/patches/2010-06-14-bug49030.patch +1: markt - -1: - +0: kkolinko: good, but maybe we should also prevent against starting - those connectors, that failed to initialize, in StandardService#start()? - markt: We could, but that would make the patch more complex. My preference - is to keep this fix simple + -1: kkolinko: it breaks the fix for BZ 48625 +https://issues.apache.org/bugzilla/show_bug.cgi?id=49030#c4 + + Alternative patch: + https://issues.apache.org/bugzilla/attachment.cgi?id=25633 + +1: kkolinko + -1: * Configure Tomcat to use HttpOnly for session cookies by default http://people.apache.org/~kkolinko/patches/2010-04-21_tc6_context_httpOnly.patch - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49234] JMX Descriptor Modifications
https://issues.apache.org/bugzilla/show_bug.cgi?id=49234 chamith buddhika changed: What|Removed |Added Attachment #25517|0 |1 is obsolete|| --- Comment #36 from chamith buddhika 2010-06-23 22:06:33 EDT --- Created an attachment (id=25634) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25634) o.a.Catalina.ha Modified Patch Adds missed incorrectly out resetStatistics() function in earlier patch. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49234] JMX Descriptor Modifications
https://issues.apache.org/bugzilla/show_bug.cgi?id=49234 chamith buddhika changed: What|Removed |Added Attachment #25564|0 |1 is obsolete|| --- Comment #37 from chamith buddhika 2010-06-23 22:32:46 EDT --- Created an attachment (id=25635) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25635) o.a.Catalina.tribes.membership Modified Patch Adds correct handling of nulls missing in the previous patch. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org