DO NOT REPLY [Bug 49426] Manager app wrongly localized

[bugzilla]

https://issues.apache.org/bugzilla/show_bug.cgi?id=49426

--- Comment #3 from Marc Guillemot  2010-06-14 03:13:31 
EDT ---
OK, you're right. What about holding the ResourceBundle in a ThreadLocal?

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 49414] Wrong memory leak detection: executor thread reported as web app thread

[bugzilla]

https://issues.apache.org/bugzilla/show_bug.cgi?id=49414

--- Comment #2 from Marc Guillemot  2010-06-14 03:20:42 
EDT ---
(In reply to comment #1)
> Tomcat already waits (I think 20s is the default) for requests to complete
> before shutting down the webapp.

???
If you run the provided unit test, you will see that Tomcat doesn't wait 20
secondes for requests to complete.

> A still running request, particularly if deadlocked, would trigger a memory
> leak so I think this is something that the leak detection should be reporting.
> I agree a better message is required to make clear the correct root cause in
> this scenario. I don't have any strong feelings at this point as to the best
> way to go. At first glance a ThreadGroup looks reasonable.

Thinking at it again, it would surely not be bad to have a "Tomcat ThreadGroup"
but it wouldn't solve the problem here: user Threads started from a webapp
without a specified ThreadGroup would belong to the Tomcat ThreadGroup too. In
this case it wouldn't help to distinguish "Tomcat threads" from "user threads".

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: DBCP Deadlock

[elankumaran]

Hi Filip Hanik,

We are using the dbcp 1.2.2 with Tomcat 5 & 6 version. We are experiencing
the dead lock issue in the getNumIdle() method of GenericObjectPool class.
Can i update to dpcp 1.4 version in order to fix the issue?

Thread dump:
"http-8080-Processor17" daemon prio=10 tid=0x2aabdc017400 nid=0x2ec2
waiting for monitor entry [0x42d99000..0x42d9aa10]
   java.lang.Thread.State: BLOCKED (on object monitor)
at
org.apache.commons.pool.impl.GenericObjectPool.getNumIdle(GenericObjectPool.java:911)
- waiting to lock <0x2aab002a0b28> (a
org.apache.commons.dbcp.AbandonedObjectPool)
at
org.apache.commons.dbcp.AbandonedObjectPool.borrowObject(AbandonedObjectPool.java:78)
at
org.apache.commons.dbcp.PoolingDataSource.getConnection(PoolingDataSource.java:96)
at
org.apache.commons.dbcp.BasicDataSource.getConnection(BasicDataSource.java:880)

Thanks in advance,
Elan


Filip Hanik - Dev Lists wrote:
> 
> I have submitted a patch for this to commons
> 
> https://issues.apache.org/jira/browse/DBCP-270
> 
> Filip
> 
> Metta wrote:
>> I'm running TC 6.0.16 on 64Bit RH Linux 5.1
>>
>> We're seeing a deadlock in the tomcat-dbcp - looks like it's to do with
>> the
>> abandoned connection checking. I thought 6.0.16 used the
>> commons-dbcp-1.2.2
>> release which supposedly fixes this issue?
>>
>> =
>> "Timer-3":
>>   waiting to lock monitor 0x53b40548 (object 0x2aaabf3210f0,
>> a
>> org.apache.tomcat.dbcp.dbcp.PoolableConnection),
>>   which is held by "TP-Processor27"
>> "TP-Processor27":
>>   waiting to lock monitor 0x53b404d0 (object 0x2aaab9fa8b08,
>> a
>> org.apache.tomcat.dbcp.pool.impl.GenericObjectPool),
>>   which is held by "Timer-3"
>>
>> Java stack information for the threads listed above:
>> ===
>> "Timer-3":
>> at
>> org.apache.tomcat.dbcp.dbcp.AbandonedTrace.addTrace(AbandonedTrace.java:175)
>> - waiting to lock <0x2aaabf3210f0> (a
>> org.apache.tomcat.dbcp.dbcp.PoolableConnection)
>> at
>> org.apache.tomcat.dbcp.dbcp.AbandonedTrace.init(AbandonedTrace.java:92)
>> at
>> org.apache.tomcat.dbcp.dbcp.AbandonedTrace.(AbandonedTrace.java:82)
>> at
>> org.apache.tomcat.dbcp.dbcp.DelegatingStatement.(DelegatingStatement.java:61)
>> at
>> org.apache.tomcat.dbcp.dbcp.DelegatingConnection.createStatement(DelegatingConnection.java:224)
>> at
>> org.apache.tomcat.dbcp.dbcp.PoolableConnectionFactory.validateConnection(PoolableConnectionFactory.java:331)
>> at
>> org.apache.tomcat.dbcp.dbcp.PoolableConnectionFactory.validateObject(PoolableConnectionFactory.java:312)
>> at
>> org.apache.tomcat.dbcp.pool.impl.GenericObjectPool.evict(GenericObjectPool.java:1217)
>> - locked <0x2aaab9fa8b08> (a
>> org.apache.tomcat.dbcp.pool.impl.GenericObjectPool)
>> at
>> org.apache.tomcat.dbcp.pool.impl.GenericObjectPool$Evictor.run(GenericObjectPool.java:1341)
>> at java.util.TimerThread.mainLoop(Timer.java:512)
>> at java.util.TimerThread.run(Timer.java:462)
>> "TP-Processor27":
>> at
>> org.apache.tomcat.dbcp.pool.impl.GenericObjectPool.addObjectToPool(GenericObjectPool.java:1136)
>> - waiting to lock <0x2aaab9fa8b08> (a
>> org.apache.tomcat.dbcp.pool.impl.GenericObjectPool)
>> at
>> org.apache.tomcat.dbcp.pool.impl.GenericObjectPool.returnObject(GenericObjectPool.java:1076)
>> at
>> org.apache.tomcat.dbcp.dbcp.PoolableConnection.close(PoolableConnection.java:87)
>> - locked <0x2aaabf3210f0> (a
>> org.apache.tomcat.dbcp.dbcp.PoolableConnection)
>> 
>>   
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 
> 
> 

-- 
View this message in context: 
http://old.nabble.com/DBCP-Deadlock-tp17999703p28876880.html
Sent from the Tomcat - Dev mailing list archive at Nabble.com.


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r954383 - /tomcat/trunk/webapps/docs/changelog.xml

[markt]

Author: markt
Date: Mon Jun 14 09:35:49 2010
New Revision: 954383

URL: http://svn.apache.org/viewvc?rev=954383&view=rev
Log:
Modules are separate - should have own changelog etc.

Modified:
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=954383&r1=954382&r2=954383&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Mon Jun 14 09:35:49 2010
@@ -237,14 +237,6 @@
   
 
   
-  
-
-  
-691359 Added in a Bayeux protocol implementation built on 
top
-of the Tomcat CometProcessor interface. (fhanik)
-  
-
-  
   
 
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r954384 - in /tomcat/trunk: bin/setclasspath.sh conf/web.xml webapps/docs/changelog.xml webapps/docs/jasper-howto.xml

[markt]

Author: markt
Date: Mon Jun 14 09:36:55 2010
New Revision: 954384

URL: http://svn.apache.org/viewvc?rev=954384&view=rev
Log:
Remove all references to Jikes since it won't work on a 1.6 jdk

Modified:
tomcat/trunk/bin/setclasspath.sh
tomcat/trunk/conf/web.xml
tomcat/trunk/webapps/docs/changelog.xml
tomcat/trunk/webapps/docs/jasper-howto.xml

Modified: tomcat/trunk/bin/setclasspath.sh
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/bin/setclasspath.sh?rev=954384&r1=954383&r2=954384&view=diff
==
--- tomcat/trunk/bin/setclasspath.sh (original)
+++ tomcat/trunk/bin/setclasspath.sh Mon Jun 14 09:36:55 2010
@@ -98,17 +98,6 @@ if [ -z "$JAVA_ENDORSED_DIRS" ]; then
   JAVA_ENDORSED_DIRS="$BASEDIR"/endorsed
 fi
 
-# OSX hack to CLASSPATH
-JIKESPATH=
-if [ `uname -s` = "Darwin" ]; then
-  
OSXHACK="/System/Library/Frameworks/JavaVM.framework/Versions/CurrentJDK/Classes"
-  if [ -d "$OSXHACK" ]; then
-for i in "$OSXHACK"/*.jar; do
-  JIKESPATH="$JIKESPATH":"$i"
-done
-  fi
-fi
-
 # Set standard commands for invoking Java.
 _RUNJAVA="$JRE_HOME"/bin/java
 if [ "$os400" != "true" ]; then

Modified: tomcat/trunk/conf/web.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/conf/web.xml?rev=954384&r1=954383&r2=954384&view=diff
==
--- tomcat/trunk/conf/web.xml (original)
+++ tomcat/trunk/conf/web.xml Mon Jun 14 09:36:55 2010
@@ -222,10 +222,6 @@
   
   
   
-  
-  
-  
-  
 
 
 jsp

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=954384&r1=954383&r2=954384&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Mon Jun 14 09:36:55 2010
@@ -33,6 +33,7 @@
   
 
 
+
 
   
 
@@ -42,6 +43,13 @@
   
 
   
+  
+
+  
+Remove references to Jikes since it does not support Java 6. (markt)
+  
+
+  
 
 
   

Modified: tomcat/trunk/webapps/docs/jasper-howto.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/jasper-howto.xml?rev=954384&r1=954383&r2=954384&view=diff
==
--- tomcat/trunk/webapps/docs/jasper-howto.xml (original)
+++ tomcat/trunk/webapps/docs/jasper-howto.xml Mon Jun 14 09:36:55 2010
@@ -373,30 +373,6 @@ depending on the application.
 
 
 
-
-
-If you wish to use
-http://oss.software.ibm.com/developerworks/opensource/jikes/";>
-Jikes to compile JSP pages:
-
-From your Ant installation, copy ant.jar
-and (if it's available: Ant 1.5 and later) ant-launcher.jar to 
-$CATALINA_HOME/lib.
-Download and install jikes. jikes must support the -encoding option.
-Execute jikes -help to verify that it was built with support
-for -encoding.
-Set the init parameter compiler to jikes.
-Define the property -Dbuild.compiler.emacs=true when starting
-Tomcat by adding it to your CATALINA_OPTS environment variable.
-This changes how jikes outputs error messages so that it is compatible with
-Jasper.
-If you get an error reporting that jikes can't use UTF8 encoding, try
-setting the init parameter javaEncoding to
-ISO-8859-1.
-
-
-
-
 
 
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r954393 - /tomcat/tc6.0.x/tags/TOMCAT_6_0_27/

[jfclere]

Author: jfclere
Date: Mon Jun 14 09:51:46 2010
New Revision: 954393

URL: http://svn.apache.org/viewvc?rev=954393&view=rev
Log:
Release 6.0.27

Added:
tomcat/tc6.0.x/tags/TOMCAT_6_0_27/   (props changed)
  - copied from r954391, tomcat/tc6.0.x/trunk/

Propchange: tomcat/tc6.0.x/tags/TOMCAT_6_0_27/
--
--- svn:ignore (added)
+++ svn:ignore Mon Jun 14 09:51:46 2010
@@ -0,0 +1,5 @@
+.classpath
+.project
+.settings
+output
+build.properties

Propchange: tomcat/tc6.0.x/tags/TOMCAT_6_0_27/
--
--- svn:mergeinfo (added)
+++ svn:mergeinfo Mon Jun 14 09:51:46 2010
@@ -0,0 +1 @@
+/tomcat/trunk:601180,606992,612607,630314,640888,652744,653247,666232,673796,673820,677910,683969,683982,684001,684081,684234,684269-684270,685177,687503,687645,689402,690781,691392,691805,692748,693378,694992,695053,695311,696780,696782,698012,698227,698236,698613,699427,699634,701355,709294,709811,709816,710063,710066,710125,710205,711126,711600,712461,712467,713953,714002,718360,719119,719124,719602,719626,719628,720046,720069,721040,721286,721708,721886,723404,723738,726052,727303,728032,728768,728947,729057,729567,729569,729571,729681,729809,729815,729934,730250,730590,731651,732859,732863,734734,740675,740684,742677,742697,742714,744160,744238,746321,746384,746425,747834,747863,748344,750258,750291,750921,751286-751287,751289,751295,752323,753039,757335,757774,758249,758365,758596,758616,758664,759074,761601,762868,762929,762936-762937,763166,763183,763193,763228,763262,763298,763302,763325,763599,763611,763654,763681,763706,764985,764997,765662,768335,769979,770716,77
 
0809,770876,772872,776921,776924,776935,776945,777464,777466,777576,777625,778379,778523-778524,781528,781779,782145,782791,783316,783696,783724,783756,783762,783766,783863,783934,784453,784602,784614,785381,785688,785768,785859,786468,786487,786490,786496,786667,787627,787770,787985,789389,790405,791041,791184,791194,791224,791243,791326,791328,791789,792740,793372,793757,793882,793981,794082,794673,794822,795043,795152,795210,795457,795466,797168,797425,797596,797607,802727,802940,804462,804544,804734,805153,809131,809603,810916,810977,812125,812137,812432,813001,813013,813866,814180,814708,814876,815972,816252,817442,817822,819339,819361,820110,820132,820874,820954,821397,828196,828201,828210,828225,828759,830378-830379,830999,831106,831774,831785,831828,831850,831860,832214,832218,833121,833545,834047,835036,835336,836405,881396,881412,883130,883134,883146,883165,883177,883362,883565,884341,885038,885231,885241,885260,885901,885991,886019,888072,889363,889606,889716,8901
 
39,890265,890349-890350,890417,891185-891187,891583,892198,892341,892415,892464,892555,892812,892814,892817,892843,892887,893321,893493,894580,894586,894805,894831,895013,895045,895057,895191,895392,895703,896370,896384,897380-897381,897776,898126,898256,898468,898527,898555,898558,898718,898836,898906,899284,899348,899420,899653,899769-899770,899783,899788,899792,899916,899918-899919,899935,899949,903916,905020,905151,905722,905728,905735,907311,907513,907538,907652,907819,907825,907864,908002,908721,908754,908759,909097,909206,909212,909525,909636,909869,909875,909887,910266,910370,910442,910471,910485,910974,915226,915737,915861,916097,916141,916157,916170,917598,917633,918093,918489,918594,918684,918787,918792,918799,918803,918885,919851,919914,920025,920055,920298,920449,920596,920824,920840,921444,922010,926716,927062,927621,928482,928695,928732,928798,931709,932357,932967,935105,935983,939491,939551,940064,941356,941463,944409,944416,945231,945808,945835,945841,946686
 ,948057,950164,950596,950614,950851,950905,951615



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: ISAPI Redirector issue | Building |

[vini mr]

Hi Team,

How do I link (give a reference to) the MSVCRT library statically? Is the
Source code of  MSVCRT library available?
I'm totally confused on this. Please guide me.

Thanks,
Vinay


On Thu, Jun 10, 2010 at 11:21 PM, sebb  wrote:

> On 10/06/2010, Mladen Turk  wrote:
> > On 06/10/2010 06:02 PM, vini mr wrote:
> >
> > >
> > > i build the .dll on windows xp 32 bit using Microsoft Visual studio
> 2008
> > > with complier version 6.0.
> > >
> > >
> >
> >  Use Visual Studio 6sp5 and Windows 2003R2 Platform SDK.
> >  This combination of tools was used for building the
> >  official binaries.
> >
> >
> >
> > >
> > > now when i use this dll which was build. i am noticing its not working
> > fine
> > > and only blank page is being displayed.
> > >
> > >
> >
> >  Like said, the produced .dll is probably linked with higher
> >  MSVCRT version (caused by using VS2008) then the one IIS uses.
> >  Now, your .dll injects that higher MSVCRT inside the IIS process,
> >  and everything starts to fall apart.
> >
>
> Alternatively, it may work if you link the MSVCRT library statically,
> rather than as a DLL.
> The output DLL will be larger, but it won't have a reference to the
> (wrong) MSVCRT DLL.
>
> >  Regards
> >  --
> >  ^TM
> >
> > -
> >  To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> >  For additional commands, e-mail: dev-h...@tomcat.apache.org
> >
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

svn commit: r954423 - /tomcat/trunk/java/org/apache/catalina/startup/Catalina.java

[markt]

Author: markt
Date: Mon Jun 14 12:17:59 2010
New Revision: 954423

URL: http://svn.apache.org/viewvc?rev=954423&view=rev
Log:
After deprecating the Embedded class, move the package access/protection 
initialisation to Catalina

Modified:
tomcat/trunk/java/org/apache/catalina/startup/Catalina.java

Modified: tomcat/trunk/java/org/apache/catalina/startup/Catalina.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/startup/Catalina.java?rev=954423&r1=954422&r2=954423&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/startup/Catalina.java (original)
+++ tomcat/trunk/java/org/apache/catalina/startup/Catalina.java Mon Jun 14 
12:17:59 2010
@@ -34,6 +34,7 @@ import org.apache.catalina.Container;
 import org.apache.catalina.LifecycleException;
 import org.apache.catalina.Server;
 import org.apache.catalina.core.StandardServer;
+import org.apache.catalina.security.SecurityConfig;
 import org.apache.juli.ClassLoaderLogManager;
 import org.apache.tomcat.util.IntrospectionUtils;
 import org.apache.tomcat.util.digester.Digester;
@@ -130,6 +131,14 @@ public class Catalina {
  */
 protected boolean useNaming = true;
 
+
+// --- Constructors
+
+public Catalina() {
+setSecurityProtection();
+}
+
+
 // - Properties
 
 
@@ -768,6 +777,16 @@ public class Catalina {
 }
 
 
+/**
+ * Set the security package access/protection.
+ */
+protected void setSecurityProtection(){
+SecurityConfig securityConfig = SecurityConfig.newInstance();
+securityConfig.setPackageDefinition();
+securityConfig.setPackageAccess();
+}
+
+
 // --- CatalinaShutdownHook Inner Class
 
 // XXX Should be moved to embedded !



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r954427 - /tomcat/trunk/java/org/apache/catalina/security/SecurityClassLoad.java

[markt]

Author: markt
Date: Mon Jun 14 12:29:03 2010
New Revision: 954427

URL: http://svn.apache.org/viewvc?rev=954427&view=rev
Log:
Cleanup. Make consistent, remove duplication, correct names.

Modified:
tomcat/trunk/java/org/apache/catalina/security/SecurityClassLoad.java

Modified: tomcat/trunk/java/org/apache/catalina/security/SecurityClassLoad.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/security/SecurityClassLoad.java?rev=954427&r1=954426&r2=954427&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/security/SecurityClassLoad.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/security/SecurityClassLoad.java Mon 
Jun 14 12:29:03 2010
@@ -42,59 +42,59 @@ public final class SecurityClassLoad {
 loadSessionPackage(loader);
 loadUtilPackage(loader);
 loadJavaxPackage(loader);
-loadCoyotePackage(loader);
+loadConnectorPackage(loader);
 loadTomcatPackage(loader);
 }
 
 
 private final static void loadCorePackage(ClassLoader loader)
 throws Exception {
-String basePackage = "org.apache.catalina.";
+String basePackage = "org.apache.catalina.core.";
 loader.loadClass
 (basePackage +
- "core.ApplicationContextFacade$1");
+ "ApplicationContextFacade$1");
 loader.loadClass
 (basePackage +
- "core.ApplicationDispatcher$PrivilegedForward");
+ "ApplicationDispatcher$PrivilegedForward");
 loader.loadClass
 (basePackage +
- "core.ApplicationDispatcher$PrivilegedInclude");
+ "ApplicationDispatcher$PrivilegedInclude");
 loader.loadClass
 (basePackage +
-"core.AsyncContextImpl");
+"AsyncContextImpl");
 loader.loadClass
 (basePackage +
-"core.AsyncContextImpl$AsyncState");
+"AsyncContextImpl$AsyncState");
 loader.loadClass
 (basePackage +
-"core.AsyncContextImpl$DebugException");
+"AsyncContextImpl$DebugException");
 loader.loadClass
 (basePackage +
-"core.AsyncContextImpl$1");
+"AsyncContextImpl$1");
 loader.loadClass
 (basePackage +
-"core.AsyncContextImpl$2");
+"AsyncContextImpl$2");
 loader.loadClass
 (basePackage +
-"core.AsyncListenerWrapper");
+"AsyncListenerWrapper");
 loader.loadClass
 (basePackage +
- "core.ContainerBase$PrivilegedAddChild");
+ "ContainerBase$PrivilegedAddChild");
 loader.loadClass
 (basePackage +
- "core.DefaultInstanceManager$1");
+ "DefaultInstanceManager$1");
 loader.loadClass
 (basePackage +
- "core.DefaultInstanceManager$2");
+ "DefaultInstanceManager$2");
 loader.loadClass
 (basePackage +
- "core.DefaultInstanceManager$3");
+ "DefaultInstanceManager$3");
 loader.loadClass
 (basePackage +
- "core.DefaultInstanceManager$4");
+ "DefaultInstanceManager$4");
 loader.loadClass
 (basePackage +
- "core.DefaultInstanceManager$5");
+ "DefaultInstanceManager$5");
 loader.loadClass
 (basePackage +
  "core.ApplicationHttpRequest$AttributeNamesEnumerator");
@@ -103,26 +103,24 @@ public final class SecurityClassLoad {
 
 private final static void loadLoaderPackage(ClassLoader loader)
 throws Exception {
-String basePackage = "org.apache.catalina.";
+String basePackage = "org.apache.catalina.loader.";
 loader.loadClass
 (basePackage +
- "loader.WebappClassLoader$PrivilegedFindResourceByName");
+ "WebappClassLoader$PrivilegedFindResourceByName");
 }
 
 
 private final static void loadSessionPackage(ClassLoader loader)
 throws Exception {
-String basePackage = "org.apache.catalina.";
+String basePackage = "org.apache.catalina.session.";
 loader.loadClass
-(basePackage + "session.StandardSession");
+(basePackage + "StandardSession");
 loader.loadClass
-(basePackage + "session.StandardSession$PrivilegedSetTccl");
+(basePackage + "StandardSession$PrivilegedSetTccl");
 loader.loadClass
-(basePackage +
- "session.StandardSession$1");
+(basePackage + "StandardSession$1");
 loader.loadClass
-(basePackage +
- "session.StandardManager$PrivilegedDoUnload");
+(basePackage + "StandardManager$PrivilegedDoUnload");
 }
 
 
@@ -140,7 +138,7 @@ public f

svn commit: r954429 - /tomcat/trunk/java/org/apache/catalina/security/SecurityClassLoad.java

[markt]

Author: markt
Date: Mon Jun 14 12:32:32 2010
New Revision: 954429

URL: http://svn.apache.org/viewvc?rev=954429&view=rev
Log:
Previous cleanup missed one string

Modified:
tomcat/trunk/java/org/apache/catalina/security/SecurityClassLoad.java

Modified: tomcat/trunk/java/org/apache/catalina/security/SecurityClassLoad.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/security/SecurityClassLoad.java?rev=954429&r1=954428&r2=954429&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/security/SecurityClassLoad.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/security/SecurityClassLoad.java Mon 
Jun 14 12:32:32 2010
@@ -97,7 +97,7 @@ public final class SecurityClassLoad {
  "DefaultInstanceManager$5");
 loader.loadClass
 (basePackage +
- "core.ApplicationHttpRequest$AttributeNamesEnumerator");
+ "ApplicationHttpRequest$AttributeNamesEnumerator");
 }
 
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r954435 - /tomcat/trunk/conf/catalina.policy

[markt]

Author: markt
Date: Mon Jun 14 12:53:20 2010
New Revision: 954435

URL: http://svn.apache.org/viewvc?rev=954435&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49213
Add permissions required by Manager application

Modified:
tomcat/trunk/conf/catalina.policy

Modified: tomcat/trunk/conf/catalina.policy
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/conf/catalina.policy?rev=954435&r1=954434&r2=954435&view=diff
==
--- tomcat/trunk/conf/catalina.policy (original)
+++ tomcat/trunk/conf/catalina.policy Mon Jun 14 12:53:20 2010
@@ -186,6 +186,14 @@ grant { 
 };
 
 
+// The Manager application needs access to the following packages to support 
the
+// session display functionality
+grant codeBase "file:${catalina.home}/webapps/manager/-" {
+permission java.lang.RuntimePermission 
"accessClassInPackage.org.apache.catalina";
+permission java.lang.RuntimePermission 
"accessClassInPackage.org.apache.catalina.manager";
+permission java.lang.RuntimePermission 
"accessClassInPackage.org.apache.catalina.manager.util";
+};
+
 // You can assign additional permissions to particular web applications by
 // adding additional "grant" entries here, based on the code base for that
 // application, /WEB-INF/classes/, or /WEB-INF/lib/ jar files.



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r954436 - /tomcat/tc6.0.x/trunk/STATUS.txt

[markt]

Author: markt
Date: Mon Jun 14 12:56:42 2010
New Revision: 954436

URL: http://svn.apache.org/viewvc?rev=954436&view=rev
Log:
Proposal

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=954436&r1=954435&r2=954436&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Mon Jun 14 12:56:42 2010
@@ -138,3 +138,9 @@ PATCHES PROPOSED TO BACKPORT:
   http://svn.apache.org/viewvc?rev=953434&view=rev
   +1: markt, kkolinko
   -1: 
+
+* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49213
+  Additional permissions required by Manager app
+  http://svn.apache.org/viewvc?view=revision&revision=954435  
+  +1: markt
+  -1: 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 7.0.0 as beta

[Henri Gomez]

people.apache.org seems to be down ;(

2010/6/14 Mark Thomas :
> On 13/06/2010 23:15, Mark Thomas wrote:
>> The proposed Apache Tomcat 7.0.0 release is now available for voting.
>>
>> It can be obtained from:
>> http://people.apache.org/~markt/dev/tomcat-7/v7.0.0/
>> The svn tag is:
>> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_0/
>>
>> Based on testing of RC4, feedback received on RC1-RC4, the currently
>> open bugs against 7.0.x and the extensive refactoring that has taken
>> place both of the connectors and the lifecycle componenets, I am
>> proposing to release 7.0.0 as a beta release.
>>
>> And now for the important bit:
>>
>> The propsoed 7.0.0 release is
>> [ ] Broken - do not release
>> [ ] Alpha  - go ahead and release as 7.0.0 Alpha
>> [X] Beta   - go ahead and release as 7.0.0 Beta
>
> To kick things off.
>
> TCK's all pass with a security manager and all connectors with the known
> exception of NIO + SSL that does not support renegotiation.
>
> Unit tests all pass.
>
> Mark
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 7.0.0 as beta

[Martin Dubuc]

I have been running RC4 for a couple of days and it seems to be fairly
stable. I would recommend release it as 7.0.0 Beta.

However, there is an issue with the el. It can't deal with literals, which
will be a problem for all applications using JSF converters. There was a
similar issue when Tomcat 6.0.2. came out. You can go back in the mailing
list archive read message in tomcat-dev Nov. 29, 2006 16:39:21 GMT and
titled "Problem with JSF 1.2 converters in Tomcat 6.0.2":

http://marc.info/?l=tomcat-dev&m=116482838430229&w=2

I sent a message to Rémy, who handled that issue back then, but haven't got
news back from him.

I know we discussed el licensing a while back on the list. Hopefully it will
not be a problem modifying that code.

Martin

On Sun, Jun 13, 2010 at 6:15 PM, Mark Thomas  wrote:

> The proposed Apache Tomcat 7.0.0 release is now available for voting.
>
> It can be obtained from:
> http://people.apache.org/~markt/dev/tomcat-7/v7.0.0/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_0/
>
> Based on testing of RC4, feedback received on RC1-RC4, the currently
> open bugs against 7.0.x and the extensive refactoring that has taken
> place both of the connectors and the lifecycle componenets, I am
> proposing to release 7.0.0 as a beta release.
>
> And now for the important bit:
>
> The propsoed 7.0.0 release is
> [ ] Broken - do not release
> [ ] Alpha  - go ahead and release as 7.0.0 Alpha
> [ ] Beta   - go ahead and release as 7.0.0 Beta
>
> Mark
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

DO NOT REPLY [Bug 49434] New: twice declaration of a variable in a JSP.

[bugzilla]

https://issues.apache.org/bugzilla/show_bug.cgi?id=49434

   Summary: twice declaration of a variable in a JSP.
   Product: Tomcat 6
   Version: 6.0.24
  Platform: All
OS/Version: All
Status: NEW
  Severity: regression
  Priority: P2
 Component: Catalina
AssignedTo: dev@tomcat.apache.org
ReportedBy: dominiquehen...@gmail.com


When declaring a variable in jsp in struts for example (), it works well for code generation and compilation by tomcat. Then
when I declare the same variable again ()
it crashes to the compilation by tomcat.
Here is an example of code from the page of liferay 4.4.2
ext\ext-web\docroot\html\portal\layout\edit\url.jsp:






In a previous version of tomcat (6.0.16) it works well. My variable is declared
once in the generated java code.

Best regards 

Dominique Henaff

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: ISAPI Redirector issue | Building |

[Mladen Turk]

On 06/14/2010 07:57 AM, vini mr wrote:

Hi Team,

According to your instructions , i have created the environment of
windows 2003 server standard edition with visual studio 6.0 with sp5..
while Building i am getting 63 errors. I have attached the file which
has all the errors which are shown during the build process.
Kindly let me know the further process to build the same.



You will also need the Server 2003r2 platform SDK, and if
building from GUI adjust the include and lib directories
from the SDK to take precedence over the ones from visual studio.

I'm not using GUI for building (ever), so cannot tell you
what exactly to look in 2003, but in 6.0 there was something
like 'options->directories' where you could set up the
the order of include and lib directories.

Regards
--
^TM

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: ISAPI Redirector issue | Building |

[Mladen Turk]

On 06/14/2010 12:42 PM, vini mr wrote:

Hi Team,

How do I link (give a reference to) the MSVCRT library statically? Is the
Source code of  MSVCRT library available?


This is determined by the cl.exe itself and you cannot
change that at will.


I'm totally confused on this. Please guide me.



You are not the only one. Try building with static msvcrt
(this is /MT compiler option) like sebb suggested


Regards
--
^TM

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: ISAPI Redirector issue | Building |

[Len Popp]

On Mon, Jun 14, 2010 at 10:51, Mladen Turk  wrote:

> You will also need the Server 2003r2 platform SDK, and if
> building from GUI adjust the include and lib directories
> from the SDK to take precedence over the ones from visual studio.
>

After you install the Server 2003 Platform SDK, here's how to tell Visual
Studio 6 to use the new platform SDK:
- Run VS6.
- Open the View > Options dialog.
- Add the appropriate directories for the Server 2003 Platform SDK.
- Note that you must add include, lib and source directories separately,
using the "Show directories for" dropdown.
- Make sure the new directories are at the top of the list, so they are
searched first.

The procedure for Visual Studio 2008 is similar.

FYI, the compile error messages have to do with items defined in httpext.h,
which are not present in older versions of the Platform SDK.
-- 
Len

Re: tag 6.0.27 on Monday

[Peter Roßbach]

Hi Jean-Frederic,

only the last 6.0.26 release has a wrong normal juli.jar. Can you  
correct this? Please, made a check after

tomcat 6.0.27 maven publish.

No regression...

Many thanks
Peter


Am 14.06.2010 um 08:57 schrieb jean-frederic clere:


On 06/13/2010 11:09 AM, Peter Roßbach wrote:

Hi Jenn-Frederic,

at the 6.0.26 Release we have deployed a wrong juli.jar at the  
maven repo:


http://tomcat.apache.org/dev/dist/m2-repository/org/apache/tomcat/juli/6.0.26/juli-6.0.26.jar


This jar is the commons-logging/log4j juli package.


hm not really sure what is wrong. That is not regression what do you
except there?

Cheers

Jean-Frederic

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org





-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r954553 - /tomcat/trunk/webapps/docs/changelog.xml

[markt]

Author: markt
Date: Mon Jun 14 16:52:33 2010
New Revision: 954553

URL: http://svn.apache.org/viewvc?rev=954553&view=rev
Log:
Update changelog

Modified:
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=954553&r1=954552&r2=954553&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Mon Jun 14 16:52:33 2010
@@ -33,7 +33,8 @@
   
 
 
-
+
 
   
 
@@ -41,6 +42,11 @@
 GSOC 2010. Continue work to align MBean descriptors with reality. Patch
 provided by Chamith Buddhika. (markt)
   
+  
+When running under a security manager, enforce package access and
+package definition restrictions defined in the catalina.properties 
file.
+(markt)
+  
 
   
   
@@ -50,6 +56,15 @@
   
 
   
+  
+
+  
+49213: Add the permissions necessary to enable the Manager
+application to operate currently when running with a security manager.
+(markt)
+  
+
+  
 
 
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 49209] AccessControlException when undeploying application

[bugzilla]

https://issues.apache.org/bugzilla/show_bug.cgi?id=49209

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WORKSFORME

--- Comment #3 from Mark Thomas  2010-06-14 12:55:19 EDT ---
This works for me with the latest 6.0.x code. I don't recall any relevant
changes since 6.0.26.

If you still see this issue, please feel free to re-open but you'll need to
provide the simplest complete set of steps to reproduce this from a clean
6.0.26 install.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 49213] Manager application doesn't work in security mode

[bugzilla]

https://issues.apache.org/bugzilla/show_bug.cgi?id=49213

--- Comment #1 from Mark Thomas  2010-06-14 12:56:02 EDT ---
Fixed in 7.0.x and will be included in 7.0.1 onwards.

Proposed for 6.0.x

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: DBCP Deadlock

[Mark Thomas]

On 14/06/2010 09:07, elankumaran wrote:


Hi Filip Hanik,

We are using the dbcp 1.2.2 with Tomcat 5&  6 version. We are experiencing
the dead lock issue in the getNumIdle() method of GenericObjectPool class.
Can i update to dpcp 1.4 version in order to fix the issue?


That would be a question for the users mailing list.

Mark



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r954555 - /tomcat/tc6.0.x/trunk/STATUS.txt

[markt]

Author: markt
Date: Mon Jun 14 17:01:32 2010
New Revision: 954555

URL: http://svn.apache.org/viewvc?rev=954555&view=rev
Log:
Update patch, address one review issue, respond to the other.

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=954555&r1=954554&r2=954555&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Mon Jun 14 17:01:32 2010
@@ -53,14 +53,13 @@ PATCHES PROPOSED TO BACKPORT:
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49030
   Failure of one connector should not leave some connectors started and some
   ignored
-  http://svn.apache.org/viewvc?rev=929521&view=rev
+  http://people.apache.org/~markt/patches/2010-06-14-bug49030.patch
   +1: markt
   -1: 
   +0: kkolinko: good, but maybe we should also prevent against starting
-those connectors, that failed to initialize, in StandardService#start()?
-Also the message name (some generic name, "connector.failed"), vs.
-message text ("starting"),  vs. what actually happened (initialize()) -
-I won't insist on fixing that inconsistency.
+  those connectors, that failed to initialize, in StandardService#start()?
+  markt: We could, but that would make the patch more complex. My 
preference
+  is to keep this fix simple
 
 * Configure Tomcat to use HttpOnly for session cookies by default
   
http://people.apache.org/~kkolinko/patches/2010-04-21_tc6_context_httpOnly.patch



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 49178] Running tomcat/6.0.26 with security manager generates ORACLE jdbc error

[bugzilla]

https://issues.apache.org/bugzilla/show_bug.cgi?id=49178

Mark Thomas  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution||FIXED

--- Comment #6 from Mark Thomas  2010-06-14 13:04:47 EDT ---
The additional permission has been added (as a comment) to catalina.policy and
will be included in 6.0.27 onwards.

If you still see this issue, feel free to re-open this bug report but you will
need to include the exact, complete (and simplest) set of steps to reproduce
this on a clean install of the latest stable 6.0.x release.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 49434] twice declaration of a variable in a JSP.

[bugzilla]

https://issues.apache.org/bugzilla/show_bug.cgi?id=49434

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE

--- Comment #1 from Mark Thomas  2010-06-14 13:31:03 EDT ---


*** This bug has been marked as a duplicate of bug 48616 ***

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 48616] Struts 1.2 and bean:define tag throws jsp 1.1 regression exception

[bugzilla]

https://issues.apache.org/bugzilla/show_bug.cgi?id=48616

Mark Thomas  changed:

   What|Removed |Added

 CC||dominiquehen...@gmail.com

--- Comment #29 from Mark Thomas  2010-06-14 13:31:03 EDT ---
*** Bug 49434 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 49436] New: Cannot use JMX to save changes to tomcat-users.xml

[bugzilla]

https://issues.apache.org/bugzilla/show_bug.cgi?id=49436

   Summary: Cannot use JMX to save changes to tomcat-users.xml
   Product: Tomcat 6
   Version: 6.0.26
  Platform: PC
OS/Version: Windows XP
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
AssignedTo: dev@tomcat.apache.org
ReportedBy: david.tu...@sky.com


In version 6.0.26 org.apache.catalina.users.MemoryUserDatabase sets readonly =
true. In version 5.5.29 org.apache.catalina.users.MemoryUserDatabase sets
readonly = false. This means that the save method will default to logging an
error message rather than saving the user database file.

public void save()
throws Exception
{
if(getReadonly())
{
log.error(sm.getString("memoryUserDatabase.readOnly"));
return;
}

The message that is displayed in 6.0.26 is:
memoryUserDatabase.readOnly=User database has been configured to be read only.
Changes cannot be saved

I cannot find any documentation or a JMX management bean to set readonly =
false.
Hence the save method I was using in Tomcat 5.0.28 and tomcat 5.5.29 no longer
works.

David Tugby

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 49422] hudson does not work on tomcat 7.0.0 rc4

[bugzilla]

https://issues.apache.org/bugzilla/show_bug.cgi?id=49422

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID

--- Comment #3 from Mark Thomas  2010-06-14 14:47:38 EDT ---
This was triggered by fixing bug47378 which implemented a spec mandated
requirement for welcome file mapping. This has its issues - see that bug report
and the linked Jetty discussion for details.

The upshot is that welcome files are inherited from Tomcat's default web.xml
and include index.jsp. Tomcat is (correctly as per the spec) matching the
index.jsp welcome file to the JSP servlet which in turn is returning a 404 to
the user since index.jsp doesn't exist.

I have doubled checked the Servlet 3.0 spec wording on welcome files and I
believe Tomcat is spec complaint here.

I hate to bounce this one back to Hudson, but I think fixing this is going to
require a change to Hudson. The simplest change is to switch the mapping to
"/*" rather than "/". This effectively bypasses the welcome file process and
ensures *all* requests are mapped to the desired servlet.

Alternative options include:
- requiring users to remove any global welcome files
- setting an empty set of welcome files in Hudson's web.xml

Since the desired behaviour is to map everything to the Stapler servlet and not
use use welcome files then I would recommend switching to a mapping of "/*"
since that will always bypass any welcome file settings as is desired in this
case.

I am closing this as invalid since Tomcat is implementing the spec correctly
here.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 47378] welcome-file ignores servlet mapping

[bugzilla]

https://issues.apache.org/bugzilla/show_bug.cgi?id=47378

Mark Thomas  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
  Component|Servlet & JSP API   |Servlet & JSP API
Version|unspecified |trunk
 Resolution||FIXED
Product|Tomcat 6|Tomcat 7
   Target Milestone|default |---

--- Comment #20 from Mark Thomas  2010-06-14 14:50:54 EDT ---
Backporting this to 6.0.x is going to cause some nasty surprises for users such
as bug 49422. Therefore, I think this should be fixed only in Tomcat 7.

I am therefore moving this to Tomcat 7 and marking it as fixed.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 49436] Cannot use JMX to save changes to tomcat-users.xml

[bugzilla]

https://issues.apache.org/bugzilla/show_bug.cgi?id=49436

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID

--- Comment #1 from Mark Thomas  2010-06-14 16:32:13 EDT ---
Tomcat home page...
  http://tomcat.apache.org/

...which links to the Tomcat 6 docs...
  http://tomcat.apache.org/tomcat-6.0-doc/index.html

...which has a link for configuration...
  http://tomcat.apache.org/tomcat-6.0-doc/config/index.html

...which documents Realms...
  http://tomcat.apache.org/tomcat-6.0-doc/config/realm.html

...including the UserDatabaseRealm which in turn links to the JNDI how-to...
 
http://tomcat.apache.org/tomcat-6.0-doc/jndi-resources-howto.html#UserDatabase%20Resources

...which describes how to set the readonly attribute.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r954650 - /tomcat/trunk/java/org/apache/jasper/compiler/Validator.java

[markt]

Author: markt
Date: Mon Jun 14 21:23:23 2010
New Revision: 954650

URL: http://svn.apache.org/viewvc?rev=954650&view=rev
Log:
Fix problem with JSF convertors - restore behaviour prior to r894720 that only 
checks a subsets of types for validity

Modified:
tomcat/trunk/java/org/apache/jasper/compiler/Validator.java

Modified: tomcat/trunk/java/org/apache/jasper/compiler/Validator.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/compiler/Validator.java?rev=954650&r1=954649&r2=954650&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/compiler/Validator.java (original)
+++ tomcat/trunk/java/org/apache/jasper/compiler/Validator.java Mon Jun 14 
21:23:23 2010
@@ -1159,13 +1159,27 @@ class Validator {
 (n, 
"jsp.error.unknown_attribute_type",
  tldAttr.getName(), expectedType);
 }
-// Check casting
-try {
-
EXPRESSION_FACTORY.coerceToType(attrs.getValue(i), expectedClass);
-} catch (Exception e) {
-err.jspError
-(n, "jsp.error.coerce_to_type",
- tldAttr.getName(), expectedType, 
attrs.getValue(i));
+// Check casting - not possible for all 
types
+if (String.class.equals(expectedClass) ||
+expectedClass == Long.TYPE ||
+expectedClass == Double.TYPE ||
+expectedClass == Byte.TYPE ||
+expectedClass == Short.TYPE ||
+expectedClass == Integer.TYPE ||
+expectedClass == Float.TYPE ||
+
Number.class.isAssignableFrom(expectedClass) ||
+
Character.class.equals(expectedClass) ||
+Character.TYPE == expectedClass ||
+
Boolean.class.equals(expectedClass) ||
+Boolean.TYPE == expectedClass ||
+expectedClass.isEnum()) {
+try {
+
EXPRESSION_FACTORY.coerceToType(attrs.getValue(i), expectedClass);
+} catch (Exception e) {
+err.jspError
+(n, "jsp.error.coerce_to_type",
+ tldAttr.getName(), 
expectedType, attrs.getValue(i));
+}
 }
 }
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r954651 - /tomcat/trunk/java/org/apache/el/lang/ELSupport.java

[markt]

Author: markt
Date: Mon Jun 14 21:23:49 2010
New Revision: 954651

URL: http://svn.apache.org/viewvc?rev=954651&view=rev
Log:
Remove an unused method

Modified:
tomcat/trunk/java/org/apache/el/lang/ELSupport.java

Modified: tomcat/trunk/java/org/apache/el/lang/ELSupport.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/el/lang/ELSupport.java?rev=954651&r1=954650&r2=954651&view=diff
==
--- tomcat/trunk/java/org/apache/el/lang/ELSupport.java (original)
+++ tomcat/trunk/java/org/apache/el/lang/ELSupport.java Mon Jun 14 21:23:49 2010
@@ -414,25 +414,6 @@ public class ELSupport {
 }
 }
 
-public final static void checkType(final Object obj, final Class type)
-throws ELException {
-if (String.class.equals(type)) {
-coerceToString(obj);
-}
-if (ELArithmetic.isNumberType(type)) {
-coerceToNumber(obj, type);
-}
-if (Character.class.equals(type) || Character.TYPE == type) {
-coerceToCharacter(obj);
-}
-if (Boolean.class.equals(type) || Boolean.TYPE == type) {
-coerceToBoolean(obj);
-}
-if (type.isEnum()) {
-coerceToEnum(obj, type);
-}
-}
-
 public final static Object coerceToType(final Object obj,
 final Class type) throws ELException {
 if (type == null || Object.class.equals(type) ||



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r954652 - /tomcat/trunk/webapps/docs/changelog.xml

[markt]

Author: markt
Date: Mon Jun 14 21:25:26 2010
New Revision: 954652

URL: http://svn.apache.org/viewvc?rev=954652&view=rev
Log:
Update changelog

Modified:
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=954652&r1=954651&r2=954652&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Mon Jun 14 21:25:26 2010
@@ -54,6 +54,10 @@
   
 Remove references to Jikes since it does not support Java 6. (markt)
   
+  
+Correct over zealous type checking for EL in attributes that broke the
+use of JSF convertors. (markt)
+  
 
   
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 7.0.0 as beta

[Mark Thomas]

On 14/06/2010 14:27, Martin Dubuc wrote:

I have been running RC4 for a couple of days and it seems to be fairly
stable. I would recommend release it as 7.0.0 Beta.

However, there is an issue with the el. It can't deal with literals, which
will be a problem for all applications using JSF converters. There was a
similar issue when Tomcat 6.0.2. came out. You can go back in the mailing
list archive read message in tomcat-dev Nov. 29, 2006 16:39:21 GMT and
titled "Problem with JSF 1.2 converters in Tomcat 6.0.2":

http://marc.info/?l=tomcat-dev&m=116482838430229&w=2


Thanks for the report. The issue has been fixed.


I sent a message to Rémy, who handled that issue back then, but haven't got
news back from him.


I can't speak for Remy but private messages to developers tend to get 
ignored. The rule for Tomcat - as it is for all ASF projects - is if it 
didn't happen on the mailing list then it never happened. Issues should 
not be raised directly with individual committers but with the community 
as a whole either directly on the dev list or better still as a Bugzilla 
entry.



I know we discussed el licensing a while back on the list. Hopefully it will
not be a problem modifying that code.


Huh? I have no idea what you are referring to here. Tomcat's EL 
implementation is - and always has been - ALv2 licensed.


Mark



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 49426] Manager app wrongly localized

[bugzilla]

https://issues.apache.org/bugzilla/show_bug.cgi?id=49426

--- Comment #4 from Mark Thomas  2010-06-14 17:48:05 EDT ---
(In reply to comment #3)
> OK, you're right. What about holding the ResourceBundle in a ThreadLocal?

Given all the issues we have seen with memory leaks and ThreadLocals I'd rather
not.

Some additional thoughts:
- we could just pass the Locale around with the writer
- I wonder how hard it would be to extend StringManager (efficiently - which
may be the slightly tricky bit) to support multiple Locales
- in determining which Locale to use we need to call request.getLocales() and
check each in turn until we find a suitable match.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Some general questions about tomcat instead of GlassFish

[Christopher Schultz]

Pouya,

On 6/12/2010 12:14 PM, j jj wrote:
>

Please use a semi-legitimate name when posting to the list: this should
be easy to configure in your email reader. Also, there's no need to put
underscores_between_your_words_in_the_subject, as this is not some kind
of wiki.

> Would you please tell me that we can use tomcat instead of GlassFish or 
> no?(Yes/No Why?)

Deciding between Tomcat and Glassfish is really a matter of application
requirements: GlassFish is a full J2EE server, while Tomcat is limited
to a Java servlet container/web server. GlassFish actually uses Tomcat
internally as its servlet container and web server, and adds features to it.

If you only need a servlet container and web server, Tomcat can meet
your needs. If you need additional services provided by a J2EE server
(EJB, JMX, etc.) then you'll want GlassFish.

> Which of JSF or Struts is more compatible with tomcat?

Both are equally compatible.

> Please say to me something about maven,Is this a project management table or 
> no ,What is this ?

Maven is a build tool. Whether Tomcat has been mavenized shouldn't be
relevant if you are developing web applications for deployment onto Tomcat.

-chris



signature.asc
Description: OpenPGP digital signature