.classpath and .project in src distribution (was: svn commit: r937993)

2010-04-27 Thread Konstantin Kolinko 
2010/4/26  :
> Author: pero
> Date: Mon Apr 26 10:46:01 2010
> New Revision: 937993
>
> URL: http://svn.apache.org/viewvc?rev=937993&view=rev
> Log:
> Include .project and .classpath files to src distribution.
> s. http://ant.apache.org/manual/dirtasks.html#defaultexcludes to not include 
> scm files!
>

The ".project" and ".classpath" files do not have ASL header. I do not
think that we should include them in the src distribution how they
are.

Eclipse IDE overwrites them from time to time, so keeping a header in
them looks like a lot of work, e.g. we did that once already:
http://svn.apache.org/viewvc?view=revision&revision=746405

One way to deal with it could be to make a copy of them under
different names, e.g.
".classpath.tmpl.xml, ".project.tmpl.xml", and ignore existing
".classpath" and ".project":
http://subversion.apache.org/faq.html#ignore-commit

What do you think?

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r938348 - /tomcat/trunk/java/org/apache/catalina/core/StandardContext.java

2010-04-27 Thread kkolinko 
Author: kkolinko
Date: Tue Apr 27 08:04:41 2010
New Revision: 938348

URL: http://svn.apache.org/viewvc?rev=938348&view=rev
Log:
Simplify code

Modified:
tomcat/trunk/java/org/apache/catalina/core/StandardContext.java

Modified: tomcat/trunk/java/org/apache/catalina/core/StandardContext.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/StandardContext.java?rev=938348&r1=938347&r2=938348&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/StandardContext.java (original)
+++ tomcat/trunk/java/org/apache/catalina/core/StandardContext.java Tue Apr 27 
08:04:41 2010
@@ -25,6 +25,7 @@ import java.io.InputStream;
 import java.io.InputStreamReader;
 import java.net.URL;
 import java.util.ArrayList;
+import java.util.Arrays;
 import java.util.HashMap;
 import java.util.Hashtable;
 import java.util.Iterator;
@@ -1096,9 +1097,8 @@ public class StandardContext
  */
 public void addApplicationEventListener(Object listener) {
 int len = applicationEventListenersObjects.length;
-Object[] newListeners = new Object[len + 1];
-System.arraycopy(applicationEventListenersObjects, 0,
-newListeners, 0, len);
+Object[] newListeners = Arrays.copyOf(applicationEventListenersObjects,
+len + 1);
 newListeners[len] = listener;
 applicationEventListenersObjects = newListeners;
 }
@@ -1135,9 +1135,8 @@ public class StandardContext
  */
 public void addApplicationLifecycleListener(Object listener) {
 int len = applicationLifecycleListenersObjects.length;
-Object[] newListeners = new Object[len + 1];
-System.arraycopy(applicationLifecycleListenersObjects, 0,
-newListeners, 0, len);
+Object[] newListeners = Arrays.copyOf(
+applicationLifecycleListenersObjects, len + 1);
 newListeners[len] = listener;
 applicationLifecycleListenersObjects = newListeners;
 }
@@ -2410,15 +2409,12 @@ public class StandardContext
 
 synchronized (applicationParametersLock) {
 String newName = parameter.getName();
-for (int i = 0; i < applicationParameters.length; i++) {
-if (newName.equals(applicationParameters[i].getName()) &&
-!applicationParameters[i].getOverride())
+for (ApplicationParameter p : applicationParameters) {
+if (newName.equals(p.getName()) && !p.getOverride())
 return;
 }
-ApplicationParameter results[] =
-new ApplicationParameter[applicationParameters.length + 1];
-System.arraycopy(applicationParameters, 0, results, 0,
- applicationParameters.length);
+ApplicationParameter results[] = Arrays.copyOf(
+applicationParameters, applicationParameters.length + 1);
 results[applicationParameters.length] = parameter;
 applicationParameters = results;
 }
@@ -2598,8 +2594,8 @@ public class StandardContext
 validateFilterMap(filterMap);
 // Add this filter mapping to our registered set
 synchronized (filterMapsLock) {
-FilterMap results[] =new FilterMap[filterMaps.length + 1];
-System.arraycopy(filterMaps, 0, results, 0, filterMaps.length);
+FilterMap results[] = Arrays.copyOf(filterMaps,
+filterMaps.length + 1);
 results[filterMaps.length] = filterMap;
 filterMaps = results;
 }



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r938363 - /tomcat/trunk/java/org/apache/catalina/core/ApplicationContext.java

2010-04-27 Thread kkolinko 
Author: kkolinko
Date: Tue Apr 27 09:01:37 2010
New Revision: 938363

URL: http://svn.apache.org/viewvc?rev=938363&view=rev
Log:
If the class implements both interfaces then call 
addApplicationLifecycleListener only once.

Modified:
tomcat/trunk/java/org/apache/catalina/core/ApplicationContext.java

Modified: tomcat/trunk/java/org/apache/catalina/core/ApplicationContext.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/ApplicationContext.java?rev=938363&r1=938362&r2=938363&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/ApplicationContext.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/core/ApplicationContext.java Tue Apr 
27 09:01:37 2010
@@ -1266,13 +1266,9 @@ public class ApplicationContext
 match = true;
 }
 
-if (t instanceof HttpSessionListener) {
-context.addApplicationLifecycleListener(t);
-match = true;
-}
-
-if (t instanceof ServletContextListener) {
-// TODO SERVLET3 - also need to check caller? spec isn't clear
+if (t instanceof HttpSessionListener
+|| t instanceof ServletContextListener) {
+// TODO SERVLET3 - if ServletContextListener then also need to 
check caller? spec isn't clear
 context.addApplicationLifecycleListener(t);
 match = true;
 }



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r938363 - /tomcat/trunk/java/org/apache/catalina/core/ApplicationContext.java

2010-04-27 Thread Konstantin Kolinko 
2010/4/27  :
> Author: kkolinko
> Date: Tue Apr 27 09:01:37 2010
> New Revision: 938363
>
> URL: http://svn.apache.org/viewvc?rev=938363&view=rev
> Log:
> If the class implements both interfaces then call 
> addApplicationLifecycleListener only once.
>
> Modified:
>    tomcat/trunk/java/org/apache/catalina/core/ApplicationContext.java
>
> Modified: tomcat/trunk/java/org/apache/catalina/core/ApplicationContext.java
> URL: 
> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/ApplicationContext.java?rev=938363&r1=938362&r2=938363&view=diff
> ==
> --- tomcat/trunk/java/org/apache/catalina/core/ApplicationContext.java 
> (original)
> +++ tomcat/trunk/java/org/apache/catalina/core/ApplicationContext.java Tue 
> Apr 27 09:01:37 2010
> @@ -1266,13 +1266,9 @@ public class ApplicationContext
>             match = true;
>         }
>
> -        if (t instanceof HttpSessionListener) {
> -            context.addApplicationLifecycleListener(t);
> -            match = true;
> -        }
> -
> -        if (t instanceof ServletContextListener) {
> -            // TODO SERVLET3 - also need to check caller? spec isn't clear
> +        if (t instanceof HttpSessionListener
> +                || t instanceof ServletContextListener) {
> +            // TODO SERVLET3 - if ServletContextListener then also need to 
> check caller? spec isn't clear
>             context.addApplicationLifecycleListener(t);
>             match = true;
>         }
>

Regarding the "TODO SERVLET3" comment in the above fragment:

Reading the first few sentences at the beginning of Chapter 4.4,
( "These methods can only be called during the initialization of the
application either
from the contexInitialized method of a ServletContextListener
implementation or from the onStartup method of a
ServletContainerInitializer implementation." )
it looks that it is a state check:

a) Before we start calling ServletContextListener.contextInitialized()
any listeners allowed in addListener() can be added.

b) Once we started calling
ServletContextListener.contextInitialized(), a new
ServletContextListener cannot be added anymore.

c) Once contextInitialized() calls are done, no more listeners,
servlets, filters can be added programmatically.

Implementing this as a call chain check as the comment suggests, thus
using try+catch+check stack,  seems too costly and impractical.


PS. I am not ready to implement this right now, but maybe somebody is.


Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: .classpath and .project in src distribution (was: svn commit: r937993)

2010-04-27 Thread sebb 
On 27/04/2010, Konstantin Kolinko  wrote:
> 2010/4/26  :
>  > Author: pero
>  > Date: Mon Apr 26 10:46:01 2010
>  > New Revision: 937993
>  >
>  > URL: http://svn.apache.org/viewvc?rev=937993&view=rev
>  > Log:
>  > Include .project and .classpath files to src distribution.
>  > s. http://ant.apache.org/manual/dirtasks.html#defaultexcludes to not 
> include scm files!
>  >
>
>  The ".project" and ".classpath" files do not have ASL header. I do not
>  think that we should include them in the src distribution how they
>  are.
>
>  Eclipse IDE overwrites them from time to time, so keeping a header in
>  them looks like a lot of work, e.g. we did that once already:
>  http://svn.apache.org/viewvc?view=revision&revision=746405
>
>  One way to deal with it could be to make a copy of them under
>  different names, e.g.
>  ".classpath.tmpl.xml, ".project.tmpl.xml", and ignore existing
>  ".classpath" and ".project":
>  http://subversion.apache.org/faq.html#ignore-commit
>
>  What do you think?

Also, the files are not necessarily the same for all users.

For example, the classpath file may have a different JRE entry if the
Eclipse default does not match the Tomcat default. Also, the local
classpath file may have entries for source and javadoc jars.

The project file may be different between users. E.g. if the project
is set up to include additional features such as PMD or Findbugs etc.
these will be added to the project file.

How about adding the following starter files to SVN/source archives:

eclipse.classpath
eclipse.project

These can be documented in the "eclipse.readme" file or similar.

>  Best regards,
>  Konstantin Kolinko
>
>  -
>  To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>  For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r938363 - /tomcat/trunk/java/org/apache/catalina/core/ApplicationContext.java

2010-04-27 Thread Pid 
On 27/04/2010 11:19, Konstantin Kolinko wrote:
> 2010/4/27  :
>> Author: kkolinko
>> Date: Tue Apr 27 09:01:37 2010
>> New Revision: 938363
>>
>> URL: http://svn.apache.org/viewvc?rev=938363&view=rev
>> Log:
>> If the class implements both interfaces then call 
>> addApplicationLifecycleListener only once.
>>
>> Modified:
>>tomcat/trunk/java/org/apache/catalina/core/ApplicationContext.java
>>
>> Modified: tomcat/trunk/java/org/apache/catalina/core/ApplicationContext.java
>> URL: 
>> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/ApplicationContext.java?rev=938363&r1=938362&r2=938363&view=diff
>> ==
>> --- tomcat/trunk/java/org/apache/catalina/core/ApplicationContext.java 
>> (original)
>> +++ tomcat/trunk/java/org/apache/catalina/core/ApplicationContext.java Tue 
>> Apr 27 09:01:37 2010
>> @@ -1266,13 +1266,9 @@ public class ApplicationContext
>> match = true;
>> }
>>
>> -if (t instanceof HttpSessionListener) {
>> -context.addApplicationLifecycleListener(t);
>> -match = true;
>> -}
>> -
>> -if (t instanceof ServletContextListener) {
>> -// TODO SERVLET3 - also need to check caller? spec isn't clear
>> +if (t instanceof HttpSessionListener
>> +|| t instanceof ServletContextListener) {
>> +// TODO SERVLET3 - if ServletContextListener then also need to 
>> check caller? spec isn't clear
>> context.addApplicationLifecycleListener(t);
>> match = true;
>> }
>>

I don't think the above change is valid as-is.  (I reopened 49181 with
an explanation as to why I wanted to change the previous patch.)

My reading of the spec suggested that ServletContextListener's can't be
added dynamically unless they also implement another EventListener
interface.


> Regarding the "TODO SERVLET3" comment in the above fragment:
> 
> Reading the first few sentences at the beginning of Chapter 4.4,
> ( "These methods can only be called during the initialization of the
> application either
> from the contexInitialized method of a ServletContextListener
> implementation or from the onStartup method of a
> ServletContainerInitializer implementation." )
> it looks that it is a state check:
> 
> a) Before we start calling ServletContextListener.contextInitialized()
> any listeners allowed in addListener() can be added.
> 
> b) Once we started calling
> ServletContextListener.contextInitialized(), a new
> ServletContextListener cannot be added anymore.
> 
> c) Once contextInitialized() calls are done, no more listeners,
> servlets, filters can be added programmatically.
> 
> Implementing this as a call chain check as the comment suggests, thus
> using try+catch+check stack,  seems too costly and impractical.

I agree, my idea was to pass a wrapped ServletContext to anything that
shouldn't be able to call those methods, delegating the other methods
but throwing an exception on the dynamic addListener etc methods.

yes/no/fail?


p

> PS. I am not ready to implement this right now, but maybe somebody is.
>
> Best regards,
> Konstantin Kolinko
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 




signature.asc
Description: OpenPGP digital signature

DO NOT REPLY [Bug 49178] Running tomcat/6.0.26 with security manager generates ORACLE jdbc error

2010-04-27 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=49178

--- Comment #4 from Konstantin Kolinko  2010-04-27 
08:43:08 EDT ---
Created an attachment (id=25362)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25362)
Bug49178PermissionUrlTest.java - sample code to check Java API behaviour

The preceding slash in the permission is how Java behaves. It is not specific
to Tomcat.

I am attaching a sample class that demonstrates Java API behaviour. When I am
running it on Windows XP with Sun JRE 6u20 as
 "java -cp . Bug49178PermissionUrlTest c:\projects\sample.txt"
it prints:

// File:
C:\PROJECTS\sample.txt
// URL:
file:/C:/PROJECTS/sample.txt
// URL.getPath():
/C:/PROJECTS/sample.txt
// URLConnection.getPermission():
(java.io.FilePermission \C:\PROJECTS\sample.txt read)
// File(url.getPath()).getCanonicalPath()
C:\PROJECTS\sample.txt
// FilePermission.equals()
true

The Permission is printed with preceding slash, but that does not matter,
because the FilePermissions are compared by canonical paths, and the canonical
path is constructed correctly regardless of that slash.

Suresh,  are you running with separate CATALINA_HOME and CATALINA_BASE? The
classes mentioned in the "access denied" stacktrace -- where their jars are
located?

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 49022] JSP Container Class Loader :Unable to load class for JSP

2010-04-27 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=49022

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID

--- Comment #2 from Mark Thomas  2010-04-27 08:48:28 EDT ---
Deleting the work directory whilst Tomcat is running is not supported.

I took a quick look to see if I could find a way to handle the deleting of the
work directory but I could not see any obvious solutions.

Since deleting the work directory is unsupported, I am closing this as INVALID.

That said, if you want to research this further yourself and come up with a
solution feel free to re-open this issue and attach a patch. However, be aware
that the patch will need to be a simple one with no noticeable side-effects for
normal usage, otherwise it is likely to be rejected.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 49038] Crash in tcnative

2010-04-27 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=49038

--- Comment #4 from Mark Thomas  2010-04-27 08:49:39 EDT ---
Please try with the latest version of tc Native which is 1.1.20.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r938430 - /tomcat/trunk/webapps/docs/config/server.xml

2010-04-27 Thread markt 
Author: markt
Date: Tue Apr 27 12:50:38 2010
New Revision: 938430

URL: http://svn.apache.org/viewvc?rev=938430&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49073

Modified:
tomcat/trunk/webapps/docs/config/server.xml

Modified: tomcat/trunk/webapps/docs/config/server.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/server.xml?rev=938430&r1=938429&r2=938430&view=diff
==
--- tomcat/trunk/webapps/docs/config/server.xml (original)
+++ tomcat/trunk/webapps/docs/config/server.xml Tue Apr 27 12:50:38 2010
@@ -66,7 +66,11 @@
 
 
   The TCP/IP port number on which this server waits for a shutdown
-  command. Set to -1 to disable the shutdown port.
+  command. Set to -1 to disable the shutdown port. Note:
+  Disabling the shutdown port will prevent shutdown.bat and catalina.bat
+  from stopping the Tomcat process on Windows operating systems. Operating
+  systems that use the *.sh scripts will not be affected by disabling the
+  shutdown port.
 
 
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r938431 - /tomcat/tc6.0.x/trunk/webapps/docs/config/server.xml

2010-04-27 Thread markt 
Author: markt
Date: Tue Apr 27 12:51:11 2010
New Revision: 938431

URL: http://svn.apache.org/viewvc?rev=938431&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49073
Improve shutdown port docs

Modified:
tomcat/tc6.0.x/trunk/webapps/docs/config/server.xml

Modified: tomcat/tc6.0.x/trunk/webapps/docs/config/server.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/config/server.xml?rev=938431&r1=938430&r2=938431&view=diff
==
--- tomcat/tc6.0.x/trunk/webapps/docs/config/server.xml (original)
+++ tomcat/tc6.0.x/trunk/webapps/docs/config/server.xml Tue Apr 27 12:51:11 2010
@@ -62,7 +62,11 @@
 
   The TCP/IP port number on which this server waits for a shutdown
   command.  This connection must be initiated from the same server
-  computer that is running this instance of Tomcat.
+  computer that is running this instance of Tomcat. Set to -1
+  to disable the shutdown port. Note: Disabling the shutdown port will
+  prevent shutdown.bat and catalina.bat from stopping the Tomcat process
+  on Windows operating systems. Operating systems that use the *.sh scripts
+  will not be affected by disabling the shutdown port.
 
 
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r938432 - /tomcat/tc5.5.x/trunk/container/webapps/docs/config/server.xml

2010-04-27 Thread markt 
Author: markt
Date: Tue Apr 27 12:51:27 2010
New Revision: 938432

URL: http://svn.apache.org/viewvc?rev=938432&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49073
Improve shutdown port docs

Modified:
tomcat/tc5.5.x/trunk/container/webapps/docs/config/server.xml

Modified: tomcat/tc5.5.x/trunk/container/webapps/docs/config/server.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/container/webapps/docs/config/server.xml?rev=938432&r1=938431&r2=938432&view=diff
==
--- tomcat/tc5.5.x/trunk/container/webapps/docs/config/server.xml (original)
+++ tomcat/tc5.5.x/trunk/container/webapps/docs/config/server.xml Tue Apr 27 
12:51:27 2010
@@ -59,7 +59,11 @@
 
   The TCP/IP port number on which this server waits for a shutdown
   command.  This connection must be initiated from the same server
-  computer that is running this instance of Tomcat.
+  computer that is running this instance of Tomcat. Set to -1
+  to disable the shutdown port. Note: Disabling the shutdown port will
+  prevent shutdown.bat and catalina.bat from stopping the Tomcat process
+  on Windows operating systems. Operating systems that use the *.sh scripts
+  will not be affected by disabling the shutdown port.
 
 
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 49073] Ability to disable shutdown port not documented

2010-04-27 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=49073

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED
Summary|Ability to disable sutdown  |Ability to disable shutdown
   |port not documented |port not documented

--- Comment #1 from Mark Thomas  2010-04-27 08:52:13 EDT ---
The updated comment isn't correct for operating systems that use catalina.sh,
the shutdown script will still work (since the PID file is used to identify the
process to shutdown). On operating systems that use catalina.bat, the shutdown
script will no longer work since it utilises the shutdown port.

I have updated the docs for Tomcat 5, 6 & 7 accordingly.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 49099] Using % after context prefix results in 400 but nothing is logged in access log

2010-04-27 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=49099

--- Comment #3 from Mark Thomas  2010-04-27 08:53:26 EDT ---
There is currently no way within Tomcat to log the malformed requests. There
are a couple of options for addressing this. The ideal would include adding
entries to the access log, if any, but that is going to be more complex than
the simple solution of using Tomcat's standard logging. I'll kick off a
discussion on the dev list about how this might be done.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: .classpath and .project in src distribution (was: svn commit: r937993)

2010-04-27 Thread Peter Roßbach 
The current setup of the .project and .classpath files works good for  
many years.
I think it was helpfull for user of the src distribution, also use the  
correct eclipse setup.


The license issue is really bad and we must fixit! We can do that with  
a little ant task.


To move .project and .classpath to temp files.
+1

Can we use eclipse.project.default and eclispe.classpath.default as  
names?


Peter



Am 27.04.2010 um 09:18 schrieb Konstantin Kolinko:


2010/4/26  :

Author: pero
Date: Mon Apr 26 10:46:01 2010
New Revision: 937993

URL: http://svn.apache.org/viewvc?rev=937993&view=rev
Log:
Include .project and .classpath files to src distribution.
s. http://ant.apache.org/manual/dirtasks.html#defaultexcludes to  
not include scm files!




The ".project" and ".classpath" files do not have ASL header. I do not
think that we should include them in the src distribution how they
are.

Eclipse IDE overwrites them from time to time, so keeping a header in
them looks like a lot of work, e.g. we did that once already:
http://svn.apache.org/viewvc?view=revision&revision=746405

One way to deal with it could be to make a copy of them under
different names, e.g.
".classpath.tmpl.xml, ".project.tmpl.xml", and ignore existing
".classpath" and ".project":
http://subversion.apache.org/faq.html#ignore-commit

What do you think?

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org





-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 49195] New: Using -1 as shutdown port with Windows service works, but prints error message

2010-04-27 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=49195

   Summary: Using -1 as shutdown port with Windows service works,
but prints error message
   Product: Tomcat 6
   Version: 6.0.26
  Platform: PC
OS/Version: Windows XP
Status: NEW
  Severity: minor
  Priority: P2
 Component: Catalina
AssignedTo: dev@tomcat.apache.org
ReportedBy: knst.koli...@gmail.com


1. Install Tomcat as a service on Windows
2. Specify https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 49073] Ability to disable shutdown port not documented

2010-04-27 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=49073

--- Comment #2 from Konstantin Kolinko  2010-04-27 
10:26:36 EDT ---
Re: r938430, r938431, r938432

> (since the PID file is used to identify the process to shutdown)

The PID file is created only if $CATALINA_PID is defined, which is optional and
is not defined by default.


Windows service launcher and jsvc should be able to use -1 as well. As of now,
there is a cosmetic issue though, - bug 49195.

There is also undocumented value of post="-2", though it is unlikely that it
would ever used in a configuration file, see StandardServer#await().

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 49196] New: NPE in PageContext.getErrorData()

2010-04-27 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=49196

   Summary: NPE in PageContext.getErrorData()
   Product: Tomcat 6
   Version: 6.0.26
  Platform: PC
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
AssignedTo: dev@tomcat.apache.org
ReportedBy: bo...@folgmann.de


This bug is present in some older versions also, but I haven't had time until
now to file the report. Here it is:

I've got

  
403
/free/login/denied.jsp
  

in web.xml and call pageContext.getErrorData() in denied.jsp.

THIS WORKS FINE!

What does not work is if the user is HTTP-redirected to denied.jsp or simply
calls it by entering the URL in his browser. In this case the JSP throws

java.lang.NullPointerException
at javax.servlet.jsp.PageContext.getErrorData(PageContext.java:515)
at
org.apache.jsp.free.login.denied_jsp._jspService(denied_jsp.java:389)
at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
at
org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:377)
at
org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:313)
at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:260)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
at com.folgmann.filters.AuthFilter.doFilter(AuthFilter.java:446)
at
com.folgmann.filters.HttpFilterSupport.doFilter(HttpFilterSupport.java:41)
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
at
com.folgmann.filters.ValidatingThreadPoolFilter.doFilter(ValidatingThreadPoolFilter.java:138)
at
com.folgmann.filters.HttpFilterSupport.doFilter(HttpFilterSupport.java:41)
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
at com.folgmann.filters.CharsetFilter.doFilter(CharsetFilter.java:114)
at
com.folgmann.filters.HttpFilterSupport.doFilter(HttpFilterSupport.java:41)
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
at
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
at
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
at
org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:465)
at
org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
at
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
at
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
at
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:298)
at
org.apache.jk.server.JkCoyoteHandler.invoke(JkCoyoteHandler.java:190)
at org.apache.jk.common.HandlerRequest.invoke(HandlerRequest.java:291)
at org.apache.jk.common.ChannelSocket.invoke(ChannelSocket.java:769)
at
org.apache.jk.common.ChannelSocket.processConnection(ChannelSocket.java:698)
at
org.apache.jk.common.ChannelSocket$SocketConnection.runIt(ChannelSocket.java:891)
at
org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:690)
at java.lang.Thread.run(Thread.java:619)

I'm sure that this wasn't intended by the JSP spec. I suggest that
pageContext.getErrorData() returns null instead when an error page is not
called like an error page should be called.

Tnx,
 boris

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Tomcat Job Opportunities at SpringSource

2010-04-27 Thread Colby Berger (c) 
I am very interested in speaking to you about a Java EE/Tomcat opportunity with 
SpringSource/VMware.  This is an Senior level position and we are looking for 
someone that has great communication skills along with the technical skills. 
This position will be working with Tomcat and S2's tc Server.  You will be 
providing consulting and training services (includes design, development, 
architecture, configuration, installation, troubleshooting and training work) 
to new and existing clients of SpringSource. This position will allow you to 
work from your home office when not at client sites.  The travel requirement is 
approximately 2-3 weeks a month travel.

If interested please email me at cber...@vmware.com 
or call me at the numbers below.


Respectfully,
Colby Berger
Recruiting Consultant
cber...@vmware.com
Office: 407-522-5088
cell: 407-538-6771

DO NOT REPLY [Bug 49197] New: ServletRequest/HttpSession is not visible in custom realm

2010-04-27 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=49197

   Summary: ServletRequest/HttpSession is not visible in custom
realm
   Product: Tomcat 6
   Version: 6.0.26
  Platform: PC
OS/Version: Windows XP
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
AssignedTo: dev@tomcat.apache.org
ReportedBy: srinivas_j...@yahoo.com


I have a requirement to build a custom login module which will use a RESTful
web service call to do the authentication which I completed. Now once the
authentication is done I need to create a session attribute so that I can use
that as token for further requests. basically my question is how to access
SeveltRequest/HttpSession in the custom login module?

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 49198] New: There are no binaries for mod_jk for 64bit?

2010-04-27 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=49198

   Summary: There are no binaries for mod_jk for 64bit?
   Product: Tomcat Connectors
   Version: 1.2.28
  Platform: PC
OS/Version: Windows Server 2003
Status: NEW
  Severity: blocker
  Priority: P2
 Component: mod_jk
AssignedTo: dev@tomcat.apache.org
ReportedBy: ron.perk...@infor.com


What is the solution for connecting Tomcat and Apache Web Server using 64bit?

Thanks, Ron

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 49198] There are no binaries for mod_jk for 64bit?

2010-04-27 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=49198

--- Comment #1 from Konstantin Kolinko  2010-04-27 
11:40:18 EDT ---
AFAIK, there are no official 64-bit Windows builds of Apache HTTPD. Why there
should be mod_jk ones?

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 49198] There are no binaries for mod_jk for 64bit?

2010-04-27 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=49198

ron.perk...@infor.com changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #2 from ron.perk...@infor.com 2010-04-27 12:00:30 EDT ---
We wanted to support the 64-bit Tomcat version with a version of Apache Web
Server... but as you say I cannot find any official 64-bit build of Apache
HTTPD.

So am I right in thinking that Apache currently does not fully support a 64-bit
solution between 64-bit Tomcat and Apachre HTTPD ?

Thanks

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 49198] There are no binaries for mod_jk for 64bit?

2010-04-27 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=49198

ron.perk...@infor.com changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 49198] There are no binaries for mod_jk for 64bit?

2010-04-27 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=49198

--- Comment #3 from Rainer Jung  2010-04-27 12:49:44 
EDT ---
The connection between HTTPD and Tomcat is done via clear text network
protocols. These protocols are not 32Bit/64Bit aware. So you can mix and match
between 32Bit and 64Bit Apache and Tomcat.

Usually you need 64Bit because of more threads per process or because of more
memory needed to handle the load. Since in the combination of Apache and Tomcat
usually the most resource demanding aspect is running on the Tomcat part, you
only need 64Bit processes for Tomcat, but not for Apache.

All common 64Bit operating systems support running a 32Bit binary without
problems.

So I suggest you stick to 32Bit Apache but use 64Bit Tomcat.

Concerning 64Bit Tomcat: Tomcat Core is pure Java, so you switch between 32Bit
and 64Bit by simply switching the JVM.

When running as a service on Windows or when including the so-called tcnative
(alias APR connector) on any OS, you will add native code which is different
between 32Bit and 64Bit. So for those parts you will need to retrieve the
correct version.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 49198] There are no binaries for mod_jk for 64bit?

2010-04-27 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=49198

Rainer Jung  changed:

   What|Removed |Added

   Severity|blocker |enhancement

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 49201] New: DLL version for Apache HTTPD not available

2010-04-27 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=49201

   Summary: DLL version for Apache HTTPD not available
   Product: Tomcat Connectors
   Version: unspecified
  Platform: PC
OS/Version: Windows XP
Status: NEW
  Severity: normal
  Priority: P2
 Component: mod_jk
AssignedTo: dev@tomcat.apache.org
ReportedBy: q8e...@gmail.com


The DLL version for Apache HTTPD is not available

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 49201] DLL version for Apache HTTPD not available

2010-04-27 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=49201

Konstantin Kolinko  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID

--- Comment #1 from Konstantin Kolinko  2010-04-27 
14:13:58 EDT ---
What, what? Why? Anybody cares?

Please read all that is written here:
http://tomcat.apache.org/bugreport.html#Bugzilla_is_not_a_support_forum

If you are a newbie or have trouble installing, please read the docs and use
the users@ list to ask questions. Someone may help you. Bugzilla is not a
support forum.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 49201] DLL version for Apache HTTPD not available

2010-04-27 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=49201

Konstantin Kolinko  changed:

   What|Removed |Added

Version|unspecified |1.2.30
 Resolution|INVALID |DUPLICATE

--- Comment #2 from Konstantin Kolinko  2010-04-27 
14:51:50 EDT ---
It looks that I know what you meant, but that is a known issue. Please be more
specific next time.


In the current 1.2.30 version of mod_jk there is no version resource in the
following files:
win32:
- mod_jk-1.2.30-httpd-2.0.53.so
- mod_jk-1.2.30-httpd-2.2.3.so
- nsapi_redirect-1.2.30.dll

The following files have a version resource:
win32/win64 amd/win64 ia versions of
- isapi_redirect-1.2.30.dll

Steps to reproduce:
1. In explorer - right click on the file. Select "Properties".
2. Actual behaviour: There is no "Version" page in the properties dialog.
Expected behaviour: To have a "Version" page that displays version of the
library and copyright information.

*** This bug has been marked as a duplicate of bug 43303 ***

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 43303] Versioning under Windows not reported by many connector components

2010-04-27 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=43303

Konstantin Kolinko  changed:

   What|Removed |Added

 CC||q8e...@gmail.com

--- Comment #4 from Konstantin Kolinko  2010-04-27 
14:51:50 EDT ---
*** Bug 49201 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Need advice to notify StandardExecutor when a webapp is stopped

2010-04-27 Thread Sylvain Laurent 
Do you mean one declared in server.xml ? or have the StandardThreadExecutor 
register itself as a LifeCycleListener ? In the latter case, my problem is how 
do I get a reference to StandardContext instances from the 
StandardThreadExecutor ?

Sylvain

On 27 avr. 2010, at 08:46, Konstantin Kolinko wrote:

> 2010/4/27 Sylvain Laurent :
>> Hello,
>> 
>> In order to provide a protection agains this type of memory leak 
>> http://wiki.apache.org/tomcat/MemoryLeakProtection#webappClassInstanceAsThreadLocalIndirectValue
>>  , I experimented with renewing the ThreadPoolExecutor in the 
>> org.apache.catalina.core.StandardThreadExecutor. It works when I invoke my 
>> renewThreads method through JMX, but now I'd like it to be invoked after a 
>> webapp is being stopped.
>> 
>> What's the best way to do that ? a LifeCycle listener to be registered 
>> somewhere ?
>> 
> 
> I would try to use a LifecycleListener registered on StandardContext.
> 
> Best regards,
> Konstantin Kolinko
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r938736 - /tomcat/trunk/webapps/docs/index.xml

2010-04-27 Thread funkman 
Author: funkman
Date: Wed Apr 28 00:24:13 2010
New Revision: 938736

URL: http://svn.apache.org/viewvc?rev=938736&view=rev
Log:
s/2.1/2.2/ for jsp spec version


Modified:
tomcat/trunk/webapps/docs/index.xml

Modified: tomcat/trunk/webapps/docs/index.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/index.xml?rev=938736&r1=938735&r2=938736&view=diff
==
--- tomcat/trunk/webapps/docs/index.xml (original)
+++ tomcat/trunk/webapps/docs/index.xml Wed Apr 28 00:24:13 2010
@@ -36,7 +36,7 @@
 This is the top-level entry point of the documentation bundle for the
 Apache Tomcat Servlet/JSP container.  Apache Tomcat version 
7.0
 implements the
-Servlet 3.0 and JavaServer Pages 2.1 specifications from the
+Servlet 3.0 and JavaServer Pages 2.2 specifications from the
 http://www.jcp.org";>Java Community Process, and includes many
 additional features that make it a useful platform for developing and deploying
 web applications and web services.



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r938737 - /tomcat/trunk/webapps/docs/setup.xml

2010-04-27 Thread funkman 
Author: funkman
Date: Wed Apr 28 00:26:27 2010
New Revision: 938737

URL: http://svn.apache.org/viewvc?rev=938737&view=rev
Log:
java 6, not java5

Modified:
tomcat/trunk/webapps/docs/setup.xml

Modified: tomcat/trunk/webapps/docs/setup.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/setup.xml?rev=938737&r1=938736&r2=938737&view=diff
==
--- tomcat/trunk/webapps/docs/setup.xml (original)
+++ tomcat/trunk/webapps/docs/setup.xml Wed Apr 28 00:26:27 2010
@@ -64,7 +64,7 @@
 administration tool and its documentation).
 Java location: The installer will use the registry
 or the JAVA_HOME environment variable to determine the base path
-of a J2SE 5 JRE.
+of a J2SE 6 JRE.
 
 Tray icon: When Tomcat is run as a service, there
 will not be any tray icon present when Tomcat is running. Note that



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r938739 - /tomcat/trunk/webapps/docs/building.xml

2010-04-27 Thread funkman 
Author: funkman
Date: Wed Apr 28 00:34:46 2010
New Revision: 938739

URL: http://svn.apache.org/viewvc?rev=938739&view=rev
Log:
minor tweaks for versions 

Modified:
tomcat/trunk/webapps/docs/building.xml

Modified: tomcat/trunk/webapps/docs/building.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/building.xml?rev=938739&r1=938738&r2=938739&view=diff
==
--- tomcat/trunk/webapps/docs/building.xml (original)
+++ tomcat/trunk/webapps/docs/building.xml Wed Apr 28 00:34:46 2010
@@ -42,7 +42,7 @@ Tomcat. The following is a step by step 
 
 
 
-
+
 
 
 The Sun JDK can be downloaded http://java.sun.com/j2se/";>here.
@@ -178,7 +178,7 @@ Variables to add two new Classpath varia
 
 
  TOMCAT_LIBS_BASEthe base path where the binary dependencies 
have been downloaded
- ANT_HOMEthe base path of Ant 1.6.2 or later
+ ANT_HOMEthe base path of Ant 1.6.5 or later
 
 
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 49205] New: context path has first character removed on deploy of war file causing failed deployment

2010-04-27 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=49205

   Summary: context path has first character removed on deploy of
war file causing failed deployment
   Product: Tomcat 6
   Version: 6.0.26
  Platform: PC
OS/Version: Linux
Status: NEW
  Severity: major
  Priority: P2
 Component: Catalina
AssignedTo: dev@tomcat.apache.org
ReportedBy: p...@geekpete.com


Subject: context path has first character removed on deploy of war file causing
failed deployment

Excerpt from server.xml:



Upon starting tomcat, the war file is exploded and two directories
are created inside the deploy directory where the testapp.war resides:
estapp/
testapp/

Catalina.out shows:

28/04/2010 11:08:58 AM org.apache.catalina.core.AprLifecycleListener init
INFO: The APR based Apache Tomcat Native library which allows optimal
performance in production environments was not found on the java.library.path:
/apps/jre1.6.0_20/lib/i386/client:/apps/jre1.6.0_20/lib/i386:/apps/jre1.6.0_20/../lib/i386:/usr/java/packages/lib/i386:/lib:/usr/lib
28/04/2010 11:08:59 AM org.apache.coyote.http11.Http11Protocol init
INFO: Initializing Coyote HTTP/1.1 on http-8480
28/04/2010 11:08:59 AM org.apache.catalina.startup.Catalina load
INFO: Initialization processed in 475 ms
28/04/2010 11:08:59 AM org.apache.catalina.core.StandardService start
INFO: Starting service Catalina
28/04/2010 11:08:59 AM org.apache.catalina.core.StandardEngine start
INFO: Starting Servlet Engine: Apache Tomcat/6.0.26
28/04/2010 11:09:00 AM org.apache.catalina.core.ApplicationContext log
INFO: Set web app root system property: 'webapp.root' =
[/data/tomcat/testapp/deploy/estapp/]
log4j:WARN No appenders could be found for logger
(org.springframework.web.servlet.DispatcherServlet).
log4j:WARN Please initialize the log4j system properly.
28/04/2010 11:09:00 AM org.apache.catalina.core.ApplicationContext log
INFO: Initializing Spring FrameworkServlet 'testapp'
28/04/2010 11:09:01 AM org.apache.catalina.startup.HostConfig deployWAR
INFO: Deploying web application archive testapp.war
28/04/2010 11:09:02 AM org.apache.catalina.core.StandardContext listenerStart
SEVERE: Exception sending context initialized event to listener instance of
class org.springframework.web.util.Log4jConfigListener
java.lang.IllegalStateException: Web app root system property already set to
different value: 'webapp.root' = [/data/tomcat/testapp/deploy/estapp/] instead
of [/data/tomcat/testapp/deploy/testapp/] - Choose unique values for the
'webAppRootKey' context-param in your web.xml files!
at
org.springframework.web.util.WebUtils.setWebAppRootSystemProperty(WebUtils.java:146)
at
org.springframework.web.util.Log4jWebConfigurer.initLogging(Log4jWebConfigurer.java:118)
at
org.springframework.web.util.Log4jConfigListener.contextInitialized(Log4jConfigListener.java:47)
at
org.apache.catalina.core.StandardContext.listenerStart(StandardContext.java:3972)
at
org.apache.catalina.core.StandardContext.start(StandardContext.java:4467)
at
org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:791)
at
org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:771)
at
org.apache.catalina.core.StandardHost.addChild(StandardHost.java:546)
at
org.apache.catalina.startup.HostConfig.deployWAR(HostConfig.java:905)
at
org.apache.catalina.startup.HostConfig.deployWARs(HostConfig.java:740)
at
org.apache.catalina.startup.HostConfig.deployApps(HostConfig.java:500)
at org.apache.catalina.startup.HostConfig.start(HostConfig.java:1277)
at
org.apache.catalina.startup.HostConfig.lifecycleEvent(HostConfig.java:321)
at
org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(LifecycleSupport.java:119)
at
org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1053)
at org.apache.catalina.core.StandardHost.start(StandardHost.java:785)
at
org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1045)
at
org.apache.catalina.core.StandardEngine.start(StandardEngine.java:443)
at
org.apache.catalina.core.StandardService.start(StandardService.java:519)
at
org.apache.catalina.core.StandardServer.start(StandardServer.java:710)
at org.apache.catalina.startup.Catalina.start(Catalina.java:581)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at org.apache.catalina.startup.Bootstrap.start(Bootstrap.java:289)
at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:414)
28/04/2010 11:09:02 AM org.apache.catalina.core.StandardContext start
SEVERE: Error listenerStart
28/04/2010 11:09:0

DO NOT REPLY [Bug 49205] context path has first character removed on deploy of war file causing failed deployment

2010-04-27 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=49205

--- Comment #1 from Peter  2010-04-27 21:59:23 EDT ---
My current workaround is to use this configuration in my server.xml:




The leading "x" is removed as per the bug and the correct context is then in
place with no errors shown in Catalina.out. There is also only one correct
exploded war directory of "testapp" inside the deploy directory.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r937975 - /tomcat/trunk/java/org/apache/catalina/core/StandardContext.java

2010-04-27 Thread Ivan 
I still get the java.lang.ArrayIndexOutOfBoundsException, i think that it
should be

filterMapInsertPoint + 1,

--->
System.arraycopy(filterMaps, filterMapInsertPoint, results,
filterMapInsertPoint + 1,
filterMaps.length - filterMapInsertPoint);
<---

2010/4/26 Giulio Quaresima 

> You need more coffee ;)
> 100 - (10 + 1) is algebraically equivalent to 100 - 10 - 1
>
>
> Tim Funk wrote:
>
>> Got it
>>
>> thanks
>>
>> -Tim
>>
>> On 4/26/2010 6:36 AM, Mark Thomas wrote:
>>
>>> On 26/04/2010 11:33, Tim Funk wrote:
>>>
 I'm feeling stupid at the moment. (Or need more coffee) But why do the
 parenthesis make a difference? (Since only addition/subtraction is done
 and no multiplication - I can't tell why this fixes it)

>>>
>>> 100 - 10 + 1 = 91
>>> 100 - (10 + 1) = 89
>>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>
>>
>>
>>
> --
> *
> * Dott. Giulio Quaresima (Ph.D) *
> *   *
> * Area Reti e Servizi Web   *
> * Ripartizione Servizi Informatici e Statistici *
> * Università degli Studi di Perugia *
> * P.zza Università 1 - 06081 Perugia (PG)   *
> * Tel. 075 585 5183 - 075 585 5172  *
> * Fax  075 585 5172 *
> * e-mail giulio.quares...@unipg.it  *
> *
>
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


-- 
Ivan

Re: Tomcat Job Opportunities at SpringSource

2010-04-27 Thread Karl San Gabriel 
Is this valid for non-US citizens?

On Tue, Apr 27, 2010 at 10:45 AM, Colby Berger (c) wrote:

> I am very interested in speaking to you about a Java EE/Tomcat opportunity
> with SpringSource/VMware.  This is an Senior level position and we are
> looking for someone that has great communication skills along with the
> technical skills. This position will be working with Tomcat and S2's tc
> Server.  You will be providing consulting and training services (includes
> design, development, architecture, configuration, installation,
> troubleshooting and training work) to new and existing clients of
> SpringSource. This position will allow you to work from your home office
> when not at client sites.  The travel requirement is approximately 2-3 weeks
> a month travel.
>
> If interested please email me at cber...@vmware.com cber...@vmware.com> or call me at the numbers below.
>
>
> Respectfully,
> Colby Berger
> Recruiting Consultant
> cber...@vmware.com
> Office: 407-522-5088
> cell: 407-538-6771
>
>

DO NOT REPLY [Bug 49205] context path has first character removed on deploy of war file causing failed deployment

2010-04-27 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=49205

Peter  changed:

   What|Removed |Added

 CC||p...@geekpete.com

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Tomcat Job Opportunities at SpringSource

2010-04-27 Thread jean-frederic clere 
On 04/28/2010 05:14 AM, Karl San Gabriel wrote:
> Is this valid for non-US citizens?

There is a list j...@apache.org for ASF related jobs, please use that
one for this topic.

Cheers

Jean-Frederic

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org