DO NOT REPLY [Bug 49059] New: Exception while deploying Hudson with subversion.hpi plugin
https://issues.apache.org/bugzilla/show_bug.cgi?id=49059 Summary: Exception while deploying Hudson with subversion.hpi plugin Product: Tomcat 5 Version: Unknown Platform: PC OS/Version: Windows XP Status: NEW Severity: major Priority: P2 Component: Unknown AssignedTo: dev@tomcat.apache.org ReportedBy: jana...@gmail.com After installing the subversion.hpi plugin. While re-starting the tomcat following exception is displayed and not able to view the Hudson login page Please suggest me if i am missing some thing while re-starting the tomcat Exception in Logs: Apr 7, 2010 12:14:51 PM hudson.WebAppMain$2 run SEVERE: Failed to initialize Hudson java.lang.NoClassDefFoundError: hudson/model/RootAction at java.lang.ClassLoader.defineClass1(Native Method) at java.lang.ClassLoader.defineClass(ClassLoader.java:620) at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:124) at java.net.URLClassLoader.defineClass(URLClassLoader.java:260) at java.net.URLClassLoader.access$100(URLClassLoader.java:56) at java.net.URLClassLoader$1.run(URLClassLoader.java:195) at java.security.AccessController.doPrivileged(Native Method) at java.net.URLClassLoader.findClass(URLClassLoader.java:188) at java.lang.ClassLoader.loadClass(ClassLoader.java:306) at java.lang.ClassLoader.loadClass(ClassLoader.java:251) at hudson.PluginManager$UberClassLoader.findClass(PluginManager.java:380) at java.lang.ClassLoader.loadClass(ClassLoader.java:306) at java.lang.ClassLoader.loadClass(ClassLoader.java:251) at net.java.sezpoz.IndexItem.element(IndexItem.java:109) at hudson.ExtensionFinder$Sezpoz.findExtensions(ExtensionFinder.java:87) at hudson.ExtensionList.load(ExtensionList.java:190) at hudson.ExtensionList.ensureLoaded(ExtensionList.java:176) at hudson.ExtensionList.iterator(ExtensionList.java:107) at hudson.ExtensionList.load(ExtensionList.java:189) at hudson.ExtensionList.ensureLoaded(ExtensionList.java:176) at hudson.ExtensionList.iterator(ExtensionList.java:107) at hudson.model.Hudson.(Hudson.java:547) at hudson.WebAppMain$2.run(WebAppMain.java:191) Exception in thread "hudson initialization thread" java.lang.NoClassDefFoundError: hudson/model/RootAction at java.lang.ClassLoader.defineClass1(Native Method) at java.lang.ClassLoader.defineClass(ClassLoader.java:620) at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:124) at java.net.URLClassLoader.defineClass(URLClassLoader.java:260) at java.net.URLClassLoader.access$100(URLClassLoader.java:56) at java.net.URLClassLoader$1.run(URLClassLoader.java:195) at java.security.AccessController.doPrivileged(Native Method) at java.net.URLClassLoader.findClass(URLClassLoader.java:188) at java.lang.ClassLoader.loadClass(ClassLoader.java:306) at java.lang.ClassLoader.loadClass(ClassLoader.java:251) at hudson.PluginManager$UberClassLoader.findClass(PluginManager.java:380) at java.lang.ClassLoader.loadClass(ClassLoader.java:306) at java.lang.ClassLoader.loadClass(ClassLoader.java:251) at net.java.sezpoz.IndexItem.element(IndexItem.java:109) at hudson.ExtensionFinder$Sezpoz.findExtensions(ExtensionFinder.java:87) at hudson.ExtensionList.load(ExtensionList.java:190) at hudson.ExtensionList.ensureLoaded(ExtensionList.java:176) at hudson.ExtensionList.iterator(ExtensionList.java:107) at hudson.ExtensionList.load(ExtensionList.java:189) at hudson.ExtensionList.ensureLoaded(ExtensionList.java:176) at hudson.ExtensionList.iterator(ExtensionList.java:107) at hudson.model.Hudson.(Hudson.java:547) at hudson.WebAppMain$2.run(WebAppMain.java:191) Apr 7, 2010 12:16:29 PM org.apache.coyote.http11.Http11Protocol pause -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49059] Exception while deploying Hudson with subversion.hpi plugin
https://issues.apache.org/bugzilla/show_bug.cgi?id=49059 Konstantin Kolinko changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Comment #1 from Konstantin Kolinko 2010-04-07 07:19:33 UTC --- Please ask on the users mailing list. http://tomcat.apache.org/bugreport.html#Bugzilla%20is%20not%20a%20support%20forum http://tomcat.apache.org/lists.html#tomcat-users -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r931462 - /tomcat/tc5.5.x/trunk/STATUS.txt
Author: kfujino Date: Wed Apr 7 08:35:23 2010 New Revision: 931462 URL: http://svn.apache.org/viewvc?rev=931462&view=rev Log: Vote Modified: tomcat/tc5.5.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=931462&r1=931461&r2=931462&view=diff == --- tomcat/tc5.5.x/trunk/STATUS.txt (original) +++ tomcat/tc5.5.x/trunk/STATUS.txt Wed Apr 7 08:35:23 2010 @@ -80,7 +80,7 @@ PATCHES PROPOSED TO BACKPORT: Prevent AccessControlException if first access is to a JSP that uses a FunctionMapper https://issues.apache.org/bugzilla/attachment.cgi?id=25094 (it is markt's r915070) - +1: kkolinko, markt + +1: kkolinko, markt, kfujino -1: * Remove JSSE13Factory, JSSE13SocketFactory classes, @@ -115,7 +115,7 @@ PATCHES PROPOSED TO BACKPORT: Only attempt APR initialization if the has been specified It is backport of r911300. (fix by fhanik) http://people.apache.org/~kkolinko/patches/2010-03-11_tc55_bug48613.patch - +1: kkolinko, markt + +1: kkolinko, markt, kfujino -1: * Update to NSIS 2.46 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r931463 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: kfujino Date: Wed Apr 7 08:40:52 2010 New Revision: 931463 URL: http://svn.apache.org/viewvc?rev=931463&view=rev Log: Vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=931463&r1=931462&r2=931463&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Wed Apr 7 08:40:52 2010 @@ -282,7 +282,7 @@ PATCHES PROPOSED TO BACKPORT: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48862 Port pero's patch to add backlog to JK ChannelSocket http://svn.apache.org/viewvc?view=revision&revision=493480 - +1: markt, kkolinko + +1: markt, kkolinko, kfujino -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48895 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: GSOC 2010
Hi All, I have prepared my proposal on JMX enhancement GSOC project. You can find it here. http://wiki.apache.org/general/BuddhikaChamith/Tomcat_GSOC2010_Proposal_BuddhikaChamith Any suggestions and comments are welcome. Best Regards, Chamith
DO NOT REPLY [Bug 49045] JMX Enhancement- Provision of MBeanFactory createStandardService
https://issues.apache.org/bugzilla/show_bug.cgi?id=49045 --- Comment #3 from chamith buddhika 2010-04-07 11:45:01 UTC --- (In reply to comment #2) Hi Mark, > You should be targeting your patches at Tomcat 7 aka trunk. Please raise bugs > against Tomcat 7 too. I will raise a bug for Tomcat 7 as well. > The Factory can be associated with a Server or a Service. If it is associated > with a Service it isn't valid to try adding another Service. That should > probably throw an Exception. Here what I was thinking was since technically a Server can contain more than one service that it would be possible to add another service to the server associated with the current service component in the MBeanFactory. I will change it to throw an exception. > Why are you creating an Engine too? Only a Service should be created. Creating > an Engine should be a separate method. Please correct me if I am wrong here. Since one service is always mapped only to one Engine component it would be not possible to use an existing registered Engine component with the newly created service without any side effects. Hence the creation of a brand new engine within the new service. I saw this has been done in the removed codes using ServerFactory as well. Another option would be that user can seperately create an Engine component prior to Service creation and register it and then use it to create the new Service. I will add a separate method to create an Engine component in that case. > I haven't looked at this in much detail but I'd be surprised if modifying the > modeler code is necessary. I'd find a method on a bean that does work (eg the > addAlias() method on a host) and see if anything is different about the way it > is set up compared to the MBeanFactory. I will look in to this further. Thanks -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49062] New: JMX Enhancement- Provision of MBeanFactory createStandardService
https://issues.apache.org/bugzilla/show_bug.cgi?id=49062 Summary: JMX Enhancement- Provision of MBeanFactory createStandardService Product: Tomcat 7 Version: trunk Platform: PC OS/Version: All Status: NEW Severity: normal Priority: P2 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: chamibuddh...@gmail.com Created an attachment (id=25240) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25240) JMX Enhancement- Provision of MBeanFactory createStandardService Currently MBeanFactory doesn't have a method for creating a new StandardService MBean. This would become an issue for future enhancements of JMX support in Tomcat. As per discussions with Mark, this enhancement is suggested as a starting point for possible future enhancements in JMX support. Attached the initial patch regarding this. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r931550 - in /tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool: ConnectionPool.java JdbcInterceptor.java PoolProperties.java PooledConnection.java interceptor/StatementCache
Author: fhanik
Date: Wed Apr 7 13:54:21 2010
New Revision: 931550
URL: http://svn.apache.org/viewvc?rev=931550&view=rev
Log:
Start working on a statement cache. Add in disconnect event for interceptors,
make the statement decorator extensible
Added:
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/interceptor/StatementCache.java
(with props)
Modified:
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/JdbcInterceptor.java
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/PoolProperties.java
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/PooledConnection.java
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/interceptor/StatementDecoratorInterceptor.java
Modified:
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java?rev=931550&r1=931549&r2=931550&view=diff
==
---
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
(original)
+++
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
Wed Apr 7 13:54:21 2010
@@ -959,10 +959,26 @@ public class ConnectionPool {
* @param con
*/
protected void finalize(PooledConnection con) {
-// NOOP
+JdbcInterceptor handler = con.getHandler();
+while (handler!=null) {
+handler.reset(null, null);
+handler=handler.getNext();
+}
}
/**
+ * Hook to perform final actions on a pooled connection object once it has
been disconnected and will be discarded
+ * @param con
+ */
+protected void disconnectEvent(PooledConnection con, boolean finalizing) {
+JdbcInterceptor handler = con.getHandler();
+while (handler!=null) {
+handler.disconnected(this, con, finalizing);
+handler=handler.getNext();
+}
+}
+
+/**
* Return the object that is potentially registered in JMX for
notifications
* @return the object implementing the {...@link
org.apache.tomcat.jdbc.pool.jmx.ConnectionPoolMBean} interface
*/
Modified:
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/JdbcInterceptor.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/JdbcInterceptor.java?rev=931550&r1=931549&r2=931550&view=diff
==
---
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/JdbcInterceptor.java
(original)
+++
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/JdbcInterceptor.java
Wed Apr 7 13:54:21 2010
@@ -149,6 +149,18 @@ public abstract class JdbcInterceptor im
public abstract void reset(ConnectionPool parent, PooledConnection con);
/**
+ * Called when {...@link java.sql.Connection#close()} is called on the
underlying connection.
+ * This is to notify the interceptors, that the physical connection has
been released.
+ * Implementation of this method should be thought through with care, as
no actions should trigger an exception.
+ * @param parent - the connection pool that this connection belongs to
+ * @param con- the pooled connection that holds this connection
+ * @param finalizing - if this connection is finalizing. True means that
the pooled connection will not reconnect the underlying connection
+ */
+public void disconnected(ConnectionPool parent, PooledConnection con,
boolean finalizing) {
+}
+
+
+/**
* Returns the properties configured for this interceptor
* @return the configured properties for this interceptor
*/
Modified:
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/PoolProperties.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/PoolProperties.java?rev=931550&r1=931549&r2=931550&view=diff
==
---
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/PoolProperties.java
(original)
+++
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/PoolProperties.java
Wed Apr 7 13:54:21 2010
@@ -811,6 +811,77 @@ public class PoolProperties implements P
public String getValue() {
return value;
}
+
+public boolean getValueAsBoolean(boolean def) {
+if (value==null) return def;
+if ("true".equals(value)) return true;
+if ("false".equals(value)) return false;
+return def;
+}
+
+public int getValueAsInt(int def) {
+
Re: Move Jakarta Slide and Taglibs to the Attic?
To summarize this thread, consensus seems to be to move both to the Attic. I will proceed to call a formal vote today, which will be held on the gene...@jakarta list. -Rahul On Sun, Feb 28, 2010 at 9:31 PM, Rahul Akolkar wrote: > This is cross-posted to reach most of the potentially interested > folks, please reply to the gene...@jakarta.a.o mailing list. > > Quick recap, Jakarta retired Slide in Nov '07 and most of Taglibs in > Oct '09 (barring three that moved to Tomcat -- for the purpose of this > email, Taglibs refers to the retired bits that remain in Jakarta). > When our last board report was submitted, there was a > question/suggestion whether Slide and Taglibs should be moved to the > Attic. Anyone thinks otherwise? > > I'll wait three weeks for any responses, please reply by 3/21 if you > have any comments. > > -Rahul > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49063] New: Please add JkStripSession status in jk-status worker output
https://issues.apache.org/bugzilla/show_bug.cgi?id=49063 Summary: Please add JkStripSession status in jk-status worker output Product: Tomcat Connectors Version: unspecified Platform: PC OS/Version: Windows NT Status: NEW Severity: enhancement Priority: P2 Component: mod_jk AssignedTo: dev@tomcat.apache.org ReportedBy: ch...@christopherschultz.net During debugging of a problem that turned out to be my own web application's fault, it would have been very helpful to confirm via the jk-status worker that JKStripSession was in effect for my VirtualHost. Can you add a display for that configuration value? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48882] win32 binary for mod_jk 1.2.30 and Apache 2.0.x
https://issues.apache.org/bugzilla/show_bug.cgi?id=48882 --- Comment #1 from Christopher Schultz 2010-04-07 16:12:13 UTC --- It seems there is a binary for this configuration available now. westmc: have you been able to successfully use it? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48882] win32 binary for mod_jk 1.2.30 and Apache 2.0.x
https://issues.apache.org/bugzilla/show_bug.cgi?id=48882 Mladen Turk changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #2 from Mladen Turk 2010-04-07 18:15:23 UTC --- Closing that cause the binaries are uploaded -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Chunked encoding should be used also when not using keepalive
On 02/04/2010 18:30, Costin Manolache wrote:
The question is what to use by default - yes, the spec allows you to use
either.
Closing the connection has the benefit of saving few bytes on network and
maybe few cycles on server.
Chunked has the benefit of better detecting failures - since a close could
happen for other reasons besides normal end. Seems like a good deal to me.
That was my instinct but I wanted some hard numbers to back it up. After
dealing with various networking issues associated with the rate the
connections are created and destroyed in a test where there is no
keep-alive, I was able to complete some tests using:
ab -n 10 -c 1 http://localhost:8080/index.html
With and without the proposed patch requests were being handled in the
4400 to 4500 requests per second range with no discernible difference
between the two.
Therefore, I am going to apply the patch to 7.0.x and propose it for
6.0.x and 5.5.x on the grounds that it adds benefit for no detectable
overhead.
Mark
Costin
On Fri, Apr 2, 2010 at 8:46 AM, Filip Hanik - Dev Lists
wrote:
so the spec says, use apples or oranges, we use oranges, and you want
apples
my suggestion would be to write a filter and set the chunked header
yourself
On 04/02/2010 09:25 AM, Óscar Frías Barranco wrote:
Ok, but it does not say that chunked encoding cannot be used when closing
the connection.
In fact chunked encoding takes precedence over connection close in the
determination of the transfer-length:
http://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html#sec4.4
Oscar
On Fri, Apr 2, 2010 at 17:09, Filip Hanik - Dev Lists
wrote:
The HTTP spec says that when you close the connection, that is the
delimiter for the content.
Filip
On 04/01/2010 04:02 AM, Óscar Frías Barranco wrote:
Hello.
Currently Tomcat HTTP 1.1 Connector disables the use of chunked encoding
if
keepalive is not used. This happens when an HTTP 1.1 request contains a
"Connection: close" header.
I propose to change Coyote to use chunked encoding (for HTTP 1.1) even
if
keepalive is disabled.
Chunked transfer-encoding is an alternative to content-length, for use
when
the content-length cannot initially be determined. While it is
mandatory
to
have either of them to support keep-alive, its use is not restricted to
keep-alive and one useful immediate benefit of using it is to allow a
client
to distinguish a connection abort from a complete response in order to
avoid
storing truncated data.
Another useful case is when a reverse-proxy is installed in front of the
server, and this reverse proxy tries to maintain keep-alive connections
with
the clients and intends to close the connections with the servers (like
apache 1.3, haproxy, and I think nginx). The lack of content-length and
chunked encoding prevents the proxy from keeping client connections
alive.
The "connection: close" sent by the proxy to the server only indicates
that
the proxy will send just one request to the server, not that it does not
care about the response length. The same is true when that proxy
caches.
Without any content-length nor chunked encoding, the cache could store
and
distribute truncated response believing they are complete, while this
would
not happen with chunked encoding because the cache will be able to know
it
has not seen the end of the response.
The fix seems easy. This is the patch:
Index: java/org/apache/coyote/http11/Http11Processor.java
===
--- java/org/apache/coyote/http11/Http11Processor.javaTue Mar 09
18:09:50 CET 2010
+++ java/org/apache/coyote/http11/Http11Processor.javaTue Mar 09
18:09:50 CET 2010
@@ -1547,7 +1547,7 @@
(outputFilters[Constants.IDENTITY_FILTER]);
contentDelimitation = true;
} else {
-if (entityBody&&http11&&keepAlive) {
+if (entityBody&&http11) {
outputBuffer.addActiveFilter
(outputFilters[Constants.CHUNKED_FILTER]);
contentDelimitation = true;
What do you think ?
Regards,
Oscar Frias
Trabber.com
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49045] JMX Enhancement- Provision of MBeanFactory createStandardService
https://issues.apache.org/bugzilla/show_bug.cgi?id=49045 Mark Thomas changed: What|Removed |Added Component|Catalina|Catalina Version|unspecified |trunk Product|Tomcat 6|Tomcat 7 Target Milestone|default |--- --- Comment #4 from Mark Thomas 2010-04-07 19:20:00 UTC --- (In reply to comment #3) > I will raise a bug for Tomcat 7 as well. That wasn't quite what I meant. I meant that this bug should be against Tomcat 7, not Tomcat 6. I'll move it. > Here what I was thinking was since technically a Server can contain more than > one service that it would be possible to add another service to the server > associated with the current service component in the MBeanFactory. I will > change it to throw an exception. There are cases where there is a service with no server. Hence the exception is the better option. > Please correct me if I am wrong here. Since one service is always mapped only > to one Engine component it would be not possible to use an existing registered > Engine component with the newly created service without any side effects. > Hence > the creation of a brand new engine within the new service. I saw this has been > done in the removed codes using ServerFactory as well. Another option would be > that user can seperately create an Engine component prior to Service creation > and register it and then use it to create the new Service. I will add a > separate method to create an Engine component in that case. You are correct that there is a 1 to 1 mapping between service and engine. For simplicity, I'd still keep them separate. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49062] JMX Enhancement- Provision of MBeanFactory createStandardService
https://issues.apache.org/bugzilla/show_bug.cgi?id=49062 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||DUPLICATE --- Comment #1 from Mark Thomas 2010-04-07 19:20:19 UTC --- *** This bug has been marked as a duplicate of bug 49045 *** -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49045] JMX Enhancement- Provision of MBeanFactory createStandardService
https://issues.apache.org/bugzilla/show_bug.cgi?id=49045 --- Comment #5 from Mark Thomas 2010-04-07 19:20:19 UTC --- *** Bug 49062 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r931659 - /tomcat/tc5.5.x/trunk/STATUS.txt
Author: markt Date: Wed Apr 7 19:58:50 2010 New Revision: 931659 URL: http://svn.apache.org/viewvc?rev=931659&view=rev Log: Votes Modified: tomcat/tc5.5.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=931659&r1=931658&r2=931659&view=diff == --- tomcat/tc5.5.x/trunk/STATUS.txt (original) +++ tomcat/tc5.5.x/trunk/STATUS.txt Wed Apr 7 19:58:50 2010 @@ -56,7 +56,7 @@ PATCHES PROPOSED TO BACKPORT: Mark ResourceEntry.loadedClass as volatile. http://svn.apache.org/viewvc?rev=927877&view=rev - +1: kkolinko + +1: kkolinko, markt -1: @@ -150,18 +150,18 @@ PATCHES PROPOSED TO BACKPORT: Ensure web application class loader is used when calling session listeners http://svn.apache.org/viewvc?view=revision&revision=899138 http://svn.apache.org/viewvc?view=revision&revision=900131 - +1: kfujino, kkolinko + +1: kfujino, kkolinko, markt -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48843 Prevent possible deadlock for worker allocation in APR https://issues.apache.org/bugzilla/attachment.cgi?id=25226 - +1: kkolinko + +1: kkolinko, markt -1: * Backport AprLifecycleListener messages from TC 6.0 It fixes "Cannot find message" messages that are printed to the log when Tomcat is being started and Tomcat-Native library is present http://people.apache.org/~kkolinko/patches/2010-04-07_tc55_AprLifecycleListener_messages.patch - +1: kkolinko + +1: kkolinko, markt -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r931664 - /tomcat/trunk/java/org/apache/catalina/loader/LocalStrings.properties
Author: markt
Date: Wed Apr 7 20:11:57 2010
New Revision: 931664
URL: http://svn.apache.org/viewvc?rev=931664&view=rev
Log:
Fix typo
Modified:
tomcat/trunk/java/org/apache/catalina/loader/LocalStrings.properties
Modified: tomcat/trunk/java/org/apache/catalina/loader/LocalStrings.properties
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/loader/LocalStrings.properties?rev=931664&r1=931663&r2=931664&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/loader/LocalStrings.properties
(original)
+++ tomcat/trunk/java/org/apache/catalina/loader/LocalStrings.properties Wed
Apr 7 20:11:57 2010
@@ -47,7 +47,7 @@ webappClassLoader.stopThreadFail=Failed
webappClassLoader.stopTimerThreadFail=Failed to terminate TimerThread named
[{0}] for web application [{1}]
webappClassLoader.validationErrorJarPath=Unable to validate JAR entry with
name {0}
webappClassLoader.warnThread=The web application [{0}] appears to have started
a thread named [{1}] but has failed to stop it. This is very likely to create a
memory leak.
-webappClassLoader.warnTimerThread=The web application [{0}] appears to have
started a TimerThread named [{1}] via the java.util.Timer API but has failed to
stop it. To prevent a memory leak, the timer (and hence the associated thread)
has been forcibly cancelled.
+webappClassLoader.warnTimerThread=The web application [{0}] appears to have
started a TimerThread named [{1}] via the java.util.Timer API but has failed to
stop it. To prevent a memory leak, the timer (and hence the associated thread)
has been forcibly canceled.
webappClassLoader.wrongVersion=(unable to load class {0})
webappLoader.addRepository=Adding repository {0}
webappLoader.deploy=Deploying class repositories to work directory {0}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r931666 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt java/org/apache/catalina/loader/LocalStrings.properties java/org/apache/catalina/loader/WebappClassLoader.java webapps/docs/changelog.xml
Author: markt Date: Wed Apr 7 20:19:24 2010 New Revision: 931666 URL: http://svn.apache.org/viewvc?rev=931666&view=rev Log: Improve log messages when a potential leak is detected by including the name of the offending context Modified: tomcat/tc6.0.x/trunk/ (props changed) tomcat/tc6.0.x/trunk/STATUS.txt tomcat/tc6.0.x/trunk/java/org/apache/catalina/loader/LocalStrings.properties tomcat/tc6.0.x/trunk/java/org/apache/catalina/loader/WebappClassLoader.java tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Propchange: tomcat/tc6.0.x/trunk/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Wed Apr 7 20:19:24 2010 @@ -1 +1 @@ -/tomcat/trunk:601180,606992,612607,630314,640888,652744,653247,666232,673796,673820,677910,683969,683982,684001,684081,684234,684269-684270,685177,687503,687645,689402,690781,691392,691805,692748,693378,694992,695053,695311,696780,696782,698012,698227,698236,698613,699427,699634,701355,709294,709811,709816,710063,710066,710125,710205,711126,711600,712461,712467,713953,714002,718360,719119,719124,719602,719626,719628,720046,720069,721040,721286,721708,721886,723404,723738,726052,727303,728032,728768,728947,729057,729567,729569,729571,729681,729809,729815,729934,730250,730590,731651,732859,732863,734734,740675,740684,742677,742697,742714,744160,744238,746321,746384,746425,747834,747863,748344,750258,750291,750921,751286-751287,751289,751295,752323,753039,757335,757774,758249,758365,758596,758616,758664,759074,761601,762868,762929,762936-762937,763166,763183,763193,763228,763262,763298,763302,763325,763599,763611,763654,763681,763706,764985,764997,765662,768335,769979,770716,77 0809,770876,772872,776921,776924,776935,776945,777464,777466,777576,777625,778379,778523-778524,781528,781779,782145,782791,783316,783696,783724,783756,783762,783766,783863,783934,784453,784602,784614,785381,785688,785768,785859,786468,786487,786490,786496,786667,787627,787770,787985,789389,790405,791041,791184,791194,791224,791243,791326,791328,791789,792740,793372,793757,793882,793981,794082,794673,794822,795043,795152,795210,795457,795466,797168,797425,797596,797607,802727,802940,804462,804544,804734,805153,809131,809603,810916,810977,812125,812137,812432,813001,813013,813866,814180,814708,814876,815972,816252,817442,817822,819339,819361,820110,820132,820874,820954,821397,828196,828201,828210,828225,828759,830378-830379,830999,831106,831774,831785,831828,831850,831860,832214,832218,833121,833545,834047,835036,835336,836405,881396,881412,883130,883134,883146,883165,883177,883362,883565,884341,885038,885231,885241,885260,885901,885991,886019,888072,889363,889606,889716,8901 39,890265,890349-890350,890417,891185-891187,891583,892198,892341,892415,892464,892555,892812,892814,892817,892843,892887,893321,893493,894580,894586,894805,894831,895013,895045,895057,895191,895392,895703,896370,896384,897380-897381,897776,898126,898256,898468,898527,898555,898558,898718,898836,898906,899284,899348,899420,899653,899769-899770,899783,899788,899792,899916,899918-899919,899935,899949,903916,905020,905151,905722,905728,905735,907311,907513,907538,907652,907819,907825,907864,908002,908721,908754,908759,909097,909206,909212,909525,909636,909869,909875,909887,910266,910370,910442,910471,910974,915226,915737,915861,916097,916141,916157,916170,917598,917633,918093,918594,918684,918787,918792,918799,918885,919851,919914,920025,920055,920596 +/tomcat/trunk:601180,606992,612607,630314,640888,652744,653247,666232,673796,673820,677910,683969,683982,684001,684081,684234,684269-684270,685177,687503,687645,689402,690781,691392,691805,692748,693378,694992,695053,695311,696780,696782,698012,698227,698236,698613,699427,699634,701355,709294,709811,709816,710063,710066,710125,710205,711126,711600,712461,712467,713953,714002,718360,719119,719124,719602,719626,719628,720046,720069,721040,721286,721708,721886,723404,723738,726052,727303,728032,728768,728947,729057,729567,729569,729571,729681,729809,729815,729934,730250,730590,731651,732859,732863,734734,740675,740684,742677,742697,742714,744160,744238,746321,746384,746425,747834,747863,748344,750258,750291,750921,751286-751287,751289,751295,752323,753039,757335,757774,758249,758365,758596,758616,758664,759074,761601,762868,762929,762936-762937,763166,763183,763193,763228,763262,763298,763302,763325,763599,763611,763654,763681,763706,764985,764997,765662,768335,769979,770716,77 0809,770876,772872,776921,776924,776935,776945,777464,777466,777576,777625,778379,778523-778524,781528,781779,782145,782791,783316,783696,783724,783756,783762,783766,783863,783934,784453,784602,784614,785381,785688,785768,785859,786468,786487,786490,786496,786667,787627,787770,787985,789389,790405,791041,791184,791194,791224,791243,791326,791328,791789,792740,793372,793757,793882,793981,794082,794673,794822,795043,795152,795210,795457,795466,797168,797425,797596,797607,802727,802940,804462,804544,804734,805153,809131,809603,8
svn commit: r931679 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt java/org/apache/catalina/core/StandardHostValve.java webapps/docs/changelog.xml
Author: markt Date: Wed Apr 7 20:44:15 2010 New Revision: 931679 URL: http://svn.apache.org/viewvc?rev=931679&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48661 Make error page behavior consistent. If a response has been committed, include the error page Modified: tomcat/tc6.0.x/trunk/ (props changed) tomcat/tc6.0.x/trunk/STATUS.txt tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/StandardHostValve.java tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Propchange: tomcat/tc6.0.x/trunk/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Wed Apr 7 20:44:15 2010 @@ -1 +1 @@ -/tomcat/trunk:601180,606992,612607,630314,640888,652744,653247,666232,673796,673820,677910,683969,683982,684001,684081,684234,684269-684270,685177,687503,687645,689402,690781,691392,691805,692748,693378,694992,695053,695311,696780,696782,698012,698227,698236,698613,699427,699634,701355,709294,709811,709816,710063,710066,710125,710205,711126,711600,712461,712467,713953,714002,718360,719119,719124,719602,719626,719628,720046,720069,721040,721286,721708,721886,723404,723738,726052,727303,728032,728768,728947,729057,729567,729569,729571,729681,729809,729815,729934,730250,730590,731651,732859,732863,734734,740675,740684,742677,742697,742714,744160,744238,746321,746384,746425,747834,747863,748344,750258,750291,750921,751286-751287,751289,751295,752323,753039,757335,757774,758249,758365,758596,758616,758664,759074,761601,762868,762929,762936-762937,763166,763183,763193,763228,763262,763298,763302,763325,763599,763611,763654,763681,763706,764985,764997,765662,768335,769979,770716,77 0809,770876,772872,776921,776924,776935,776945,777464,777466,777576,777625,778379,778523-778524,781528,781779,782145,782791,783316,783696,783724,783756,783762,783766,783863,783934,784453,784602,784614,785381,785688,785768,785859,786468,786487,786490,786496,786667,787627,787770,787985,789389,790405,791041,791184,791194,791224,791243,791326,791328,791789,792740,793372,793757,793882,793981,794082,794673,794822,795043,795152,795210,795457,795466,797168,797425,797596,797607,802727,802940,804462,804544,804734,805153,809131,809603,810916,810977,812125,812137,812432,813001,813013,813866,814180,814708,814876,815972,816252,817442,817822,819339,819361,820110,820132,820874,820954,821397,828196,828201,828210,828225,828759,830378-830379,830999,831106,831774,831785,831828,831850,831860,832214,832218,833121,833545,834047,835036,835336,836405,881396,881412,883130,883134,883146,883165,883177,883362,883565,884341,885038,885231,885241,885260,885901,885991,886019,888072,889363,889606,889716,8901 39,890265,890349-890350,890417,891185-891187,891583,892198,892341,892415,892464,892555,892812,892814,892817,892843,892887,893321,893493,894580,894586,894805,894831,895013,895045,895057,895191,895392,895703,896370,896384,897380-897381,897776,898126,898256,898468,898527,898555,898558,898718,898836,898906,899284,899348,899420,899653,899769-899770,899783,899788,899792,899916,899918-899919,899935,899949,903916,905020,905151,905722,905728,905735,907311,907513,907538,907652,907819,907825,907864,908002,908721,908754,908759,909097,909206,909212,909525,909636,909869,909875,909887,910266,910370,910442,910471,910974,915226,915737,915861,916097,916141,916157,916170,917598,917633,918093,918594,918684,918787,918792,918799,918885,919851,919914,920025,920055,920298,920596 +/tomcat/trunk:601180,606992,612607,630314,640888,652744,653247,666232,673796,673820,677910,683969,683982,684001,684081,684234,684269-684270,685177,687503,687645,689402,690781,691392,691805,692748,693378,694992,695053,695311,696780,696782,698012,698227,698236,698613,699427,699634,701355,709294,709811,709816,710063,710066,710125,710205,711126,711600,712461,712467,713953,714002,718360,719119,719124,719602,719626,719628,720046,720069,721040,721286,721708,721886,723404,723738,726052,727303,728032,728768,728947,729057,729567,729569,729571,729681,729809,729815,729934,730250,730590,731651,732859,732863,734734,740675,740684,742677,742697,742714,744160,744238,746321,746384,746425,747834,747863,748344,750258,750291,750921,751286-751287,751289,751295,752323,753039,757335,757774,758249,758365,758596,758616,758664,759074,761601,762868,762929,762936-762937,763166,763183,763193,763228,763262,763298,763302,763325,763599,763611,763654,763681,763706,764985,764997,765662,768335,769979,770716,77 0809,770876,772872,776921,776924,776935,776945,777464,777466,777576,777625,778379,778523-778524,781528,781779,782145,782791,783316,783696,783724,783756,783762,783766,783863,783934,784453,784602,784614,785381,785688,785768,785859,786468,786487,786490,786496,786667,787627,787770,787985,789389,790405,791041,791184,791194,791224,791243,791326,791328,791789,792740,793372,793757,793882,793981,794082,794673,794822,795043,795152,795210,795457,795466,797168,797425,797596,797607,802727,802940,804462,804544,804734,805153,809131,809603,810916,810977,812125,812
DO NOT REPLY [Bug 48661] inconsistent error page behavior
https://issues.apache.org/bugzilla/show_bug.cgi?id=48661 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #2 from Mark Thomas 2010-04-07 20:44:20 UTC --- The fix has been applied to 6.0.x and will be included in 6.0.27 onwards. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48882] win32 binary for mod_jk 1.2.30 and Apache 2.0.x
https://issues.apache.org/bugzilla/show_bug.cgi?id=48882 --- Comment #3 from wes...@gmail.com 2010-04-07 21:21:55 UTC --- Yes, it worked for me. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r931699 - in /tomcat/trunk/java/org/apache/tomcat/util/net: AbstractEndpoint.java JIoEndpoint.java NioEndpoint.java
Author: markt
Date: Wed Apr 7 21:46:55 2010
New Revision: 931699
URL: http://svn.apache.org/viewvc?rev=931699&view=rev
Log:
Further corrections to SSL session timeout attribute name.
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java
tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java
tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java?rev=931699&r1=931698&r2=931699&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java Wed Apr
7 21:46:55 2010
@@ -559,9 +559,9 @@ public abstract class AbstractEndpoint {
public String getSessionCacheSize() { return sessionCacheSize;}
public void setSessionCacheSize(String s) { sessionCacheSize = s;}
-private String sessionCacheTimeout = "86400";
-public String getSessionCacheTimeout() { return sessionCacheTimeout;}
-public void setSessionCacheTimeout(String s) { sessionCacheTimeout = s;}
+private String sessionTimeout = "86400";
+public String getSessionTimeout() { return sessionTimeout;}
+public void setSessionTimeout(String s) { sessionTimeout = s;}
private String allowUnsafeLegacyRenegotiation = null;
public String getAllowUnsafeLegacyRenegotiation() {
Modified: tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java?rev=931699&r1=931698&r2=931699&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java Wed Apr 7
21:46:55 2010
@@ -342,7 +342,7 @@ public class JIoEndpoint extends Abstrac
serverSocketFactory.setAttribute(SSL_ATTR_SESSION_CACHE_SIZE,
getSessionCacheSize());
serverSocketFactory.setAttribute(SSL_ATTR_SESSION_TIMEOUT,
-getSessionCacheTimeout());
+getSessionTimeout());
serverSocketFactory.setAttribute(SSL_ATTR_ALLOW_UNSAFE_RENEG,
getAllowUnsafeLegacyRenegotiation());
}
Modified: tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java?rev=931699&r1=931698&r2=931699&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java Wed Apr 7
21:46:55 2010
@@ -539,9 +539,9 @@ public class NioEndpoint extends Abstrac
sessionContext.setSessionCacheSize(
Integer.parseInt(getSessionCacheSize()));
}
-if (getSessionCacheTimeout() != null) {
+if (getSessionTimeout() != null) {
sessionContext.setSessionTimeout(
-Integer.parseInt(getSessionCacheTimeout()));
+Integer.parseInt(getSessionTimeout()));
}
}
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r931701 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Wed Apr 7 21:54:17 2010 New Revision: 931701 URL: http://svn.apache.org/viewvc?rev=931701&view=rev Log: Vote Update patch to address comments Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=931701&r1=931700&r2=931701&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Wed Apr 7 21:54:17 2010 @@ -194,17 +194,15 @@ PATCHES PROPOSED TO BACKPORT: Mark ResourceEntry.loadedClass as volatile. http://svn.apache.org/viewvc?rev=927877&view=rev - +1: kkolinko + +1: kkolinko, markt -1: * Correct SSL session timeout attribute name - http://people.apache.org/~markt/patches/2010-03-18-SslSessionTimeout.patch + http://people.apache.org/~markt/patches/2010-04-07-SslSessionTimeout.patch +1: markt -1: - kkolinko: In NioEndpoint (and in AbstractEndpoint in trunk) there is -#setSessionCacheTimeout(String). It will need renaming as well? -Generally, I would be against renaming some attributes, but this one -is already documented as "sessionTimeout" in config/http.xml, though, + kkolinko: Generally, I would be against renaming some attributes, but this +one is already documented as "sessionTimeout" in config/http.xml, though, still, renaming might break someone's configurations. * Fix cluster regression, previous incorrect patch - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r931706 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/jk/common/ChannelSocket.java webapps/docs/changelog.xml
Author: markt
Date: Wed Apr 7 22:07:04 2010
New Revision: 931706
URL: http://svn.apache.org/viewvc?rev=931706&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48862
Port pero's patch to add backlog to JK ChannelSocket
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
tomcat/tc6.0.x/trunk/java/org/apache/jk/common/ChannelSocket.java
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=931706&r1=931705&r2=931706&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Wed Apr 7 22:07:04 2010
@@ -264,12 +264,6 @@ PATCHES PROPOSED TO BACKPORT:
+1: kkolinko
-1:
-* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48862
- Port pero's patch to add backlog to JK ChannelSocket
- http://svn.apache.org/viewvc?view=revision&revision=493480
- +1: markt, kkolinko, kfujino
- -1:
-
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48895
Make clearing thread locals optional and disabled by default since it isn't
thread-safe
Modified: tomcat/tc6.0.x/trunk/java/org/apache/jk/common/ChannelSocket.java
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/jk/common/ChannelSocket.java?rev=931706&r1=931705&r2=931706&view=diff
==
--- tomcat/tc6.0.x/trunk/java/org/apache/jk/common/ChannelSocket.java (original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/jk/common/ChannelSocket.java Wed Apr
7 22:07:04 2010
@@ -83,6 +83,7 @@ public class ChannelSocket extends JkHan
private int startPort=8009;
private int maxPort=8019; // 0 for backward compat.
private int port=startPort;
+private int backlog = 0;
private InetAddress inet;
private int serverTimeout;
private boolean tcpNoDelay=true; // nodelay to true by default
@@ -263,12 +264,16 @@ public class ChannelSocket extends JkHan
}
public int getMaxSpareThreads() {
-return tp.getMaxSpareThreads();
+return tp.getMaxSpareThreads();
}
public void setBacklog(int i) {
+this.backlog = i;
}
-
+
+public int getBacklog() {
+return backlog;
+}
/* */
ServerSocket sSocket;
@@ -367,9 +372,9 @@ public class ChannelSocket extends JkHan
for( int i=startPort; i<=maxPort; i++ ) {
try {
if( inet == null ) {
-sSocket = new ServerSocket( i, 0 );
+sSocket = new ServerSocket( i, backlog );
} else {
-sSocket=new ServerSocket( i, 0, inet );
+sSocket=new ServerSocket( i, backlog, inet );
}
port=i;
break;
Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml?rev=931706&r1=931705&r2=931706&view=diff
==
--- tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Wed Apr 7 22:07:04 2010
@@ -52,6 +52,14 @@
+
+
+
+48862: Add support for the backlog parameter to the AJP
+connector. (pero/markt)
+
+
+
Update to Commons Daemon 1.0.2. Use service launcher (procrun)
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48862] AJP Connector ignores Backlog configuration parameter
https://issues.apache.org/bugzilla/show_bug.cgi?id=48862 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #2 from Mark Thomas 2010-04-07 22:07:04 UTC --- This has been fixed in 6.0.x and will be included in 6.0.27 onwards. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r931708 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Wed Apr 7 22:12:07 2010 New Revision: 931708 URL: http://svn.apache.org/viewvc?rev=931708&view=rev Log: Votes Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=931708&r1=931707&r2=931708&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Wed Apr 7 22:12:07 2010 @@ -300,7 +300,7 @@ PATCHES PROPOSED TO BACKPORT: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49051 memberAlive is not called if member has not already existed in membership. http://svn.apache.org/viewvc?view=revision&revision=931061 - +1: kfujino + +1: kfujino, markt -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49018 @@ -310,5 +310,5 @@ PATCHES PROPOSED TO BACKPORT: message, printed by that action. That is to allow proper translation of those messages, though I cannot provide such translation by myself. http://svn.apache.org/viewvc?rev=931415&view=rev - +1: kkolinko + +1: kkolinko, markt -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r931709 - in /tomcat/trunk/java/org/apache/coyote/http11: Http11AprProcessor.java Http11NioProcessor.java Http11Processor.java
Author: markt
Date: Wed Apr 7 22:17:19 2010
New Revision: 931709
URL: http://svn.apache.org/viewvc?rev=931709&view=rev
Log:
Use chunked encoding for http 1.1 requests with no content-length (regardless
of keep-alive) so client can differentiate between complete and partial
responses.
Modified:
tomcat/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java
tomcat/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java
tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java
Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java?rev=931709&r1=931708&r2=931709&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java
(original)
+++ tomcat/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java Wed Apr
7 22:17:19 2010
@@ -1646,7 +1646,7 @@ public class Http11AprProcessor implemen
(outputFilters[Constants.IDENTITY_FILTER]);
contentDelimitation = true;
} else {
-if (entityBody && http11 && keepAlive) {
+if (entityBody && http11) {
outputBuffer.addActiveFilter
(outputFilters[Constants.CHUNKED_FILTER]);
contentDelimitation = true;
Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java?rev=931709&r1=931708&r2=931709&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java
(original)
+++ tomcat/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java Wed Apr
7 22:17:19 2010
@@ -1146,7 +1146,7 @@ public class Http11NioProcessor extends
(outputFilters[Constants.IDENTITY_FILTER]);
contentDelimitation = true;
} else {
-if (entityBody && http11 && keepAlive) {
+if (entityBody && http11) {
outputBuffer.addActiveFilter
(outputFilters[Constants.CHUNKED_FILTER]);
contentDelimitation = true;
Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java?rev=931709&r1=931708&r2=931709&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java (original)
+++ tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java Wed Apr 7
22:17:19 2010
@@ -900,7 +900,7 @@ public class Http11Processor extends Abs
(outputFilters[Constants.IDENTITY_FILTER]);
contentDelimitation = true;
} else {
-if (entityBody && http11 && keepAlive) {
+if (entityBody && http11) {
outputBuffer.addActiveFilter
(outputFilters[Constants.CHUNKED_FILTER]);
contentDelimitation = true;
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r931710 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Wed Apr 7 22:18:57 2010 New Revision: 931710 URL: http://svn.apache.org/viewvc?rev=931710&view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=931710&r1=931709&r2=931710&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Wed Apr 7 22:18:57 2010 @@ -312,3 +312,10 @@ PATCHES PROPOSED TO BACKPORT: http://svn.apache.org/viewvc?rev=931415&view=rev +1: kkolinko, markt -1: + +* Use chunked encoding for http 1.1 requests with no content-length (regardless + of keep-alive) so client can differentiate between complete and partial + responses. + http://svn.apache.org/viewvc?rev=931709&view=rev + +1: markt + -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r931711 - /tomcat/tc5.5.x/trunk/STATUS.txt
Author: markt Date: Wed Apr 7 22:20:00 2010 New Revision: 931711 URL: http://svn.apache.org/viewvc?rev=931711&view=rev Log: Proposal Modified: tomcat/tc5.5.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=931711&r1=931710&r2=931711&view=diff == --- tomcat/tc5.5.x/trunk/STATUS.txt (original) +++ tomcat/tc5.5.x/trunk/STATUS.txt Wed Apr 7 22:20:00 2010 @@ -165,3 +165,10 @@ PATCHES PROPOSED TO BACKPORT: http://people.apache.org/~kkolinko/patches/2010-04-07_tc55_AprLifecycleListener_messages.patch +1: kkolinko, markt -1: + +* Use chunked encoding for http 1.1 requests with no content-length (regardless + of keep-alive) so client can differentiate between complete and partial + responses. + http://svn.apache.org/viewvc?rev=931709&view=rev (less NIO) + +1: markt + -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r931734 - in /tomcat: tc5.5.x/trunk/STATUS.txt tc6.0.x/trunk/STATUS.txt
Author: kkolinko Date: Thu Apr 8 00:12:07 2010 New Revision: 931734 URL: http://svn.apache.org/viewvc?rev=931734&view=rev Log: votes Modified: tomcat/tc5.5.x/trunk/STATUS.txt tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=931734&r1=931733&r2=931734&view=diff == --- tomcat/tc5.5.x/trunk/STATUS.txt (original) +++ tomcat/tc5.5.x/trunk/STATUS.txt Thu Apr 8 00:12:07 2010 @@ -170,5 +170,5 @@ PATCHES PROPOSED TO BACKPORT: of keep-alive) so client can differentiate between complete and partial responses. http://svn.apache.org/viewvc?rev=931709&view=rev (less NIO) - +1: markt + +1: markt, kkolinko -1: Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=931734&r1=931733&r2=931734&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Apr 8 00:12:07 2010 @@ -300,7 +300,7 @@ PATCHES PROPOSED TO BACKPORT: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49051 memberAlive is not called if member has not already existed in membership. http://svn.apache.org/viewvc?view=revision&revision=931061 - +1: kfujino, markt + +1: kfujino, markt, kkolinko -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49018 @@ -317,5 +317,5 @@ PATCHES PROPOSED TO BACKPORT: of keep-alive) so client can differentiate between complete and partial responses. http://svn.apache.org/viewvc?rev=931709&view=rev - +1: markt + +1: markt, kkolinko -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Tomcat n NIO?
Hi I just want to ask if anyone in Tomcat dev would implement Java Nio framework for the Tomcat engine? I wonder if it makes the Tomcat performance over high capacity requests faster? That is all Thanks Rendra - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
