DO NOT REPLY [Bug 49051] New: Decrease in response by TcpFailureDetector.

2010-04-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49051

   Summary: Decrease in response by TcpFailureDetector.
   Product: Tomcat 6
   Version: 6.0.26
  Platform: All
OS/Version: All
Status: NEW
  Severity: normal
  Priority: P2
 Component: Cluster
AssignedTo: dev@tomcat.apache.org
ReportedBy: kfuj...@apache.org


[Configuration]
Cluster configuration.
TcpFailureDetector is used. 
Synchronous replication

ChannelException is thrown when the destination node downs in the session
replication.
ChannelException is caught by TcpFailureDetector, 
and verifies the member in TcpFailureDetector#memberDisappeared.

In TcpFailureDetector#memberAlive method, 
the member who failed in replication is checked to see if the member really is
down.
Because member already is gone, TcpFailureDetector#memberAlive do the timeout
in 1 sec(default 1 sec).
Then, member is removed from membership by membership#removeMember, 
and super.memberDisappeared(member) will be called. 

TcpFailureDetector#memberDisappeared is as follows. 
===
public void memberDisappeared(Member member) {
...skip
synchronized (membership) {
//check to see if the member really is gone
//if the payload is not a shutdown message
if (shutdown || !memberAlive(member)) {
//not correct, we need to maintain the map
membership.removeMember( (MemberImpl) member);
removeSuspects.remove(member);
notify = true;
} else {
//add the member as suspect
removeSuspects.put(member, new Long(System.currentTimeMillis()));
}
}
...skip
}
===
All threads to wait for the acquisition of the lock of membership call the
memberAlive method every time. 
And, the timeout will be done every time in 1 sec. 
As result,
in high-concurrent, decrease in a cruel response may happen.

For instance, 
when 100 threads waiting for the lock of membership, 
the thread to have acquired the lock at the end can not return the response for
100 sec. 

If member has not already existed in membership, TcpFailureDetector#memberAlive
method need not be called. 

I made a patch.

Best regards.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 49051] Decrease in response by TcpFailureDetector.

2010-04-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49051

--- Comment #1 from Keiichi Fujino  2010-04-06 09:13:50 UTC 
---
Created an attachment (id=25233)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25233)
TcpFailureDetector's patch

I made a patch.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r931061 - /tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/TcpFailureDetector.java

2010-04-06 Thread kfujino
Author: kfujino
Date: Tue Apr  6 09:25:59 2010
New Revision: 931061

URL: http://svn.apache.org/viewvc?rev=931061&view=rev
Log:
memberAlive is not called if member has not already existed in membership. 

Modified:

tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/TcpFailureDetector.java

Modified: 
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/TcpFailureDetector.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/TcpFailureDetector.java?rev=931061&r1=931060&r2=931061&view=diff
==
--- 
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/TcpFailureDetector.java
 (original)
+++ 
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/TcpFailureDetector.java
 Tue Apr  6 09:25:59 2010
@@ -145,6 +145,11 @@ public class TcpFailureDetector extends 
 if(log.isInfoEnabled())
 log.info("Received memberDisappeared["+member+"] message. Will 
verify.");
 synchronized (membership) {
+if (!membership.contains(member)) {
+if(log.isInfoEnabled())
+log.info("Verification complete. Member already 
disappeared["+member+"]");
+return;
+}
 //check to see if the member really is gone
 //if the payload is not a shutdown message
 if (shutdown || !memberAlive(member)) {



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r931062 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-04-06 Thread kfujino
Author: kfujino
Date: Tue Apr  6 09:35:11 2010
New Revision: 931062

URL: http://svn.apache.org/viewvc?rev=931062&view=rev
Log:
Proposal for BZ49051

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=931062&r1=931061&r2=931062&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Apr  6 09:35:11 2010
@@ -317,3 +317,9 @@ PATCHES PROPOSED TO BACKPORT:
   Patch provided by Cyrille Le Clerc
   +1: markt, kkolinko
   -1: 
+
+* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49051
+  memberAlive is not called if member has not already existed in membership. 
+  http://svn.apache.org/viewvc?view=revision&revision=931061
+  +1: kfujino
+  -1: 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 49051] Decrease in response by TcpFailureDetector.

2010-04-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49051

--- Comment #2 from Keiichi Fujino  2010-04-06 09:39:29 UTC 
---
Fixed in trunk and proposed for 6.0.x.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: GSoC Tomcat SPDY Connectors

2010-04-06 Thread jean-frederic clere
On 04/05/2010 06:11 AM, Costin Manolache wrote:
> next protocol negotiation

http://tools.ietf.org/html/draft-agl-tls-nextprotoneg-00.html

Cheers

Jean-Frederic

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: svn commit: r931061 - /tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/TcpFailureDetector.java

2010-04-06 Thread Filip Hanik - Dev Lists

Excellent, welcome aboard!!

Filip

On 04/06/2010 03:25 AM, kfuj...@apache.org wrote:

Author: kfujino
Date: Tue Apr  6 09:25:59 2010
New Revision: 931061

URL: http://svn.apache.org/viewvc?rev=931061&view=rev
Log:
memberAlive is not called if member has not already existed in membership.

Modified:
 
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/TcpFailureDetector.java

Modified: 
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/TcpFailureDetector.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/TcpFailureDetector.java?rev=931061&r1=931060&r2=931061&view=diff
==
--- 
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/TcpFailureDetector.java
 (original)
+++ 
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/TcpFailureDetector.java
 Tue Apr  6 09:25:59 2010
@@ -145,6 +145,11 @@ public class TcpFailureDetector extends
  if(log.isInfoEnabled())
  log.info("Received memberDisappeared["+member+"] message. Will 
verify.");
  synchronized (membership) {
+if (!membership.contains(member)) {
+if(log.isInfoEnabled())
+log.info("Verification complete. Member already 
disappeared["+member+"]");
+return;
+}
  //check to see if the member really is gone
  //if the payload is not a shutdown message
  if (shutdown || !memberAlive(member)) {



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org


   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 48685] Spnego Support in Tomcat

2010-04-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48685

--- Comment #13 from Mark Thomas  2010-04-06 14:15:58 UTC ---
Adding all those JARs to a standard Tomcat installation isn't going to be
acceptable. How feasible is a lighter weight implementation? A new
authenticator and new realm is about the limit of what I would find acceptable.

Also, you haven't yet answered my question regarding the SPNEGO protocol.
Specifically:
Some explanation of how this maps to
http://msdn.microsoft.com/en-us/library/ms995330.aspx and step 5 of "SPNEGO
Token Handshake via HTTP Headers" in particular would also help.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 46632] mod_jk's sockets close prematurely when the server forks a child

2010-04-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46632

letuan88153  changed:

   What|Removed |Added

 OS/Version|Linux   |Windows XP

--- Comment #3 from letuan88153  2010-04-06 14:54:53 UTC 
---
Name: Le Van Tuan
Class: LPI- IP-MAC
Country: Viet Nam

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 46632] mod_jk's sockets close prematurely when the server forks a child

2010-04-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46632

letuan88153  changed:

   What|Removed |Added

URL||http://localhost:8080/green
   ||stone3/library?a=p&sa=home

--- Comment #4 from letuan88153  2010-04-06 14:57:01 UTC 
---
Name: Le Van Tuan
Class: LPI- IP-MAC
Country: Viet Nam

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 46632] mod_jk's sockets close prematurely when the server forks a child

2010-04-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46632

Mark Thomas  changed:

   What|Removed |Added

URL|http://localhost:8080/green |
   |stone3/library?a=p&sa=home  |

--- Comment #5 from Mark Thomas  2010-04-06 15:00:58 UTC ---
Spam removal

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release build 5.5.29

2010-04-06 Thread Filip Hanik - Dev Lists

On 03/31/2010 07:52 AM, Filip Hanik - Dev Lists wrote:
[X] Stable 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 47712] NoSuchFieldException when trying to use Tomcat Native library

2010-04-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47712

b...@visi.com changed:

   What|Removed |Added

 CC||b...@visi.com

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release build 5.5.29

2010-04-06 Thread Jim Jagielski

On Mar 31, 2010, at 9:52 AM, Filip Hanik - Dev Lists wrote:

> The candidates binaries are available here:
> http://people.apache.org/~fhanik/tomcat/tomcat-5.5/v5.5.29/
> 
> According to the release process, the 5.5.29 tag is:
> [ ] Broken
> [ ] Alpha
> [ ] Beta
> [X] Stable
> 

+1


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 49045] JMX Enhancement- Provision of MBeanFactory createStandardService

2010-04-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49045

--- Comment #2 from Mark Thomas  2010-04-06 21:32:20 UTC ---
A couple of comments.

You should be targeting your patches at Tomcat 7 aka trunk. Please raise bugs
against Tomcat 7 too.

The Factory can be associated with a Server or a Service. If it is associated
with a Service it isn't valid to try adding another Service. That should
probably throw an Exception.

If the Factory is associated with a Server then casting container to Server
should work.

Why are you creating an Engine too? Only a Service should be created. Creating
an Engine should be a separate method.

I haven't looked at this in much detail but I'd be surprised if modifying the
modeler code is necessary. I'd find a method on a bean that does work (eg the
addAlias() method on a host) and see if anything is different about the way it
is set up compared to the MBeanFactory.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 49038] Crash in tcnative

2010-04-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49038

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #2 from Mark Thomas  2010-04-06 21:33:39 UTC ---
Marking as NEEDINFO - waiting for tc native version

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 46632] mod_jk's sockets close prematurely when the server forks a child

2010-04-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46632

Konstantin Kolinko  changed:

   What|Removed |Added

 OS/Version|Windows XP  |Linux

--- Comment #6 from Konstantin Kolinko  2010-04-06 
22:52:25 UTC ---
Restoring the original value of OS/Version field.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release build 5.5.29

2010-04-06 Thread Konstantin Kolinko
2010/3/31 Filip Hanik - Dev Lists :
> The candidates binaries are available here:
> http://people.apache.org/~fhanik/tomcat/tomcat-5.5/v5.5.29/
>
> According to the release process, the 5.5.29 tag is:
> [ ] Broken
> [ ] Alpha
> [ ] Beta
> [x] Stable

Observed issues are listed below. I think these are not show stoppers.


1) https://issues.apache.org/bugzilla/show_bug.cgi?id=48580#c6
AccessControlException if first access is to a JSP that uses a FunctionMapper

The patch is already in STATUS for some long time, but needs a third vote.

This is not a regression, it can be observed with 5.5.28. I do not
like it, but I do not remember users reporting this issue.


2) The following is displayed in the logs when I run on Windows with
tcnative-1.dll being present:

03.04.2010 18:24:31 org.apache.catalina.core.AprLifecycleListener init
INFO: Cannot find message associated with key aprListener.tcnValid
03.04.2010 18:24:31 org.apache.catalina.core.AprLifecycleListener init
INFO: Cannot find message associated with key aprListener.flags

We forgot to port some messages from TC 6.0.
Just cosmetics, does not impact functionality.

I will propose a patch.


3) APR initialization will be attempted always, even if
AprLifecycleListener was not specified in server.xml
https://issues.apache.org/bugzilla/show_bug.cgi?id=48613

Can be resolved by removing unneeded *.dll/*.so file of Tomcat-Native.
The informational message "Apache Tomcat Native library ... was not
found" may annoy someone, but it does not impact functionality.

The patch is already in STATUS for some time, but needs a third vote.


Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r931408 - /tomcat/tc5.5.x/trunk/STATUS.txt

2010-04-06 Thread kkolinko
Author: kkolinko
Date: Wed Apr  7 02:35:41 2010
New Revision: 931408

URL: http://svn.apache.org/viewvc?rev=931408&view=rev
Log:
proposal

Modified:
tomcat/tc5.5.x/trunk/STATUS.txt

Modified: tomcat/tc5.5.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=931408&r1=931407&r2=931408&view=diff
==
--- tomcat/tc5.5.x/trunk/STATUS.txt (original)
+++ tomcat/tc5.5.x/trunk/STATUS.txt Wed Apr  7 02:35:41 2010
@@ -158,3 +158,10 @@ PATCHES PROPOSED TO BACKPORT:
   https://issues.apache.org/bugzilla/attachment.cgi?id=25226
   +1: kkolinko
   -1:
+
+* Backport AprLifecycleListener messages from TC 6.0
+  It fixes "Cannot find message" messages that are printed to the log when
+  Tomcat is being started and Tomcat-Native library is present
+  
http://people.apache.org/~kkolinko/patches/2010-04-07_tc55_AprLifecycleListener_messages.patch
+  +1: kkolinko
+  -1:



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r931409 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/LocalStrings.properties

2010-04-06 Thread kkolinko
Author: kkolinko
Date: Wed Apr  7 02:41:08 2010
New Revision: 931409

URL: http://svn.apache.org/viewvc?rev=931409&view=rev
Log:
CTR
Trivial: correct misprint in a message

Modified:
tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/LocalStrings.properties

Modified: 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/LocalStrings.properties
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/LocalStrings.properties?rev=931409&r1=931408&r2=931409&view=diff
==
--- tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/LocalStrings.properties 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/LocalStrings.properties 
Wed Apr  7 02:41:08 2010
@@ -36,7 +36,7 @@ applicationResponse.badParent=Cannot loc
 applicationResponse.badResponse=Response is not a 
javax.servlet.ServletResponseWrapper
 aprListener.aprInit=The APR based Apache Tomcat Native library which allows 
optimal performance in production environments was not found on the 
java.library.path: {0}
 aprListener.tcnInvalid=An incompatible version {0} of the APR based Apache 
Tomcat Native library is installed, while Tomcat requires version {1} 
-aprListener.tcnVersion=An older version {0} of the APR based Apache Tomcat 
Native library is installed, while Tomcat recommends version greater then {1}
+aprListener.tcnVersion=An older version {0} of the APR based Apache Tomcat 
Native library is installed, while Tomcat recommends version greater than {1}
 aprListener.aprDestroy=Failed shutdown of APR based Apache Tomcat Native 
library
 aprListener.sslInit=Failed to initialize the SSLEngine.
 aprListener.tcnValid=Loaded APR based Apache Tomcat Native library {0}.



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r931415 - in /tomcat/trunk/java/org/apache/catalina/manager: LocalStrings.properties LocalStrings_de.properties LocalStrings_es.properties LocalStrings_fr.properties LocalStrings_ja.proper

2010-04-06 Thread kkolinko
Author: kkolinko
Date: Wed Apr  7 03:24:08 2010
New Revision: 931415

URL: http://svn.apache.org/viewvc?rev=931415&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49018
Fix processing of time argument in the "Expire sessions" action in the Manager 
web application

Also, provide separate templates for the "managerServlet.sessiontimeout" 
message, to allow it to be properly translated into other languages. I cannot 
provide the actual translations, though. The translated variants of the new 
messages are now a mix of English and translated text, which just mimics the 
old behaviour.

Modified:
tomcat/trunk/java/org/apache/catalina/manager/LocalStrings.properties
tomcat/trunk/java/org/apache/catalina/manager/LocalStrings_de.properties
tomcat/trunk/java/org/apache/catalina/manager/LocalStrings_es.properties
tomcat/trunk/java/org/apache/catalina/manager/LocalStrings_fr.properties
tomcat/trunk/java/org/apache/catalina/manager/LocalStrings_ja.properties
tomcat/trunk/java/org/apache/catalina/manager/ManagerServlet.java

Modified: tomcat/trunk/java/org/apache/catalina/manager/LocalStrings.properties
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/manager/LocalStrings.properties?rev=931415&r1=931414&r2=931415&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/manager/LocalStrings.properties 
(original)
+++ tomcat/trunk/java/org/apache/catalina/manager/LocalStrings.properties Wed 
Apr  7 03:24:08 2010
@@ -100,7 +100,9 @@ managerServlet.saveFail=FAIL - Configura
 managerServlet.saved=OK - Server configuration saved
 managerServlet.savedContext=OK - Context {0} configuration saved
 managerServlet.sessiondefaultmax=Default maximum session inactive interval {0} 
minutes
-managerServlet.sessiontimeout={0} minutes:{1} sessions
+managerServlet.sessiontimeout={0} minutes: {1} sessions
+managerServlet.sessiontimeout.unlimited=unlimited time: {0} sessions
+managerServlet.sessiontimeout.expired={0} minutes: {1} sessions were expired
 managerServlet.sessions=OK - Session information for application at context 
path {0}
 managerServlet.started=OK - Started application at context path {0}
 managerServlet.startFailed=FAIL - Application at context path {0} could not be 
started

Modified: 
tomcat/trunk/java/org/apache/catalina/manager/LocalStrings_de.properties
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/manager/LocalStrings_de.properties?rev=931415&r1=931414&r2=931415&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/manager/LocalStrings_de.properties 
(original)
+++ tomcat/trunk/java/org/apache/catalina/manager/LocalStrings_de.properties 
Wed Apr  7 03:24:08 2010
@@ -79,7 +79,10 @@ managerServlet.resourcesType=OK - Auflis
 managerServlet.rolesList=OK - Auflistung der Sicherheits-Rollen
 managerServlet.saveFail=FEHLER - Speichern der Konfiguration fehlgeschlagen: 
{0}
 managerServlet.sessiondefaultmax=Voreingestellter Sitzungsablauf nach maximal 
{0} Minuten Inaktivit\u00e4t
+#TODO: Please review the following three messages. These are displayed when 
"Expire sessions" button is pressed in the Manager webapp:
 managerServlet.sessiontimeout={0} Minuten: {1} Sitzungen
+managerServlet.sessiontimeout.unlimited=unlimited Minuten: {0} Sitzungen
+managerServlet.sessiontimeout.expired={0} Minuten: expired {1} Sitzungen
 managerServlet.sessions=OK - Sitzungs-Informationen f\u00fcr Anwendung mit 
Kontext Pfad {0}
 managerServlet.started=OK - Anwendung mit Kontext Pfad {0} gestartet
 managerServlet.startFailed=FEHLER - Anwendung mit Kontext Pfad {0} konnte 
nicht gestartet werden

Modified: 
tomcat/trunk/java/org/apache/catalina/manager/LocalStrings_es.properties
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/manager/LocalStrings_es.properties?rev=931415&r1=931414&r2=931415&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/manager/LocalStrings_es.properties 
(original)
+++ tomcat/trunk/java/org/apache/catalina/manager/LocalStrings_es.properties 
Wed Apr  7 03:24:08 2010
@@ -86,7 +86,10 @@ managerServlet.saveFail = FAIL - Fallo a
 managerServlet.saved = OK - Configuraci\u00F3n de Servidor guardada
 managerServlet.savedContext = OK - Configuraci\u00F3n de Contexto {0} guardada
 managerServlet.sessiondefaultmax = Intervalo m\u00E1ximo por defecto de 
sesi\u00F3n inactiva {0} minutos
-managerServlet.sessiontimeout = {0} minutos\: {1} sesiones
+#TODO: Please review the following three messages. These are displayed when 
"Expire sessions" button is pressed in the Manager webapp:
+managerServlet.sessiontimeout={0} minutos: {1} sesiones
+managerServlet.sessiontimeout.unlimited=unlimited minutos: {0} sesiones
+managerServlet.sessiontimeout.expired={0} minutos: expired {1} sesiones
 managerS

DO NOT REPLY [Bug 49018] Timeout argument misprocessed when expiring sessions from Tomcat Manager

2010-04-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49018

--- Comment #1 from Konstantin Kolinko  2010-04-07 
03:35:03 UTC ---
Fixed in trunk (r931415), proposed for 6.0.x.

Tomcat 5.5.x is not affected by this issue: it does not have "Expire sessions"
action in the Manager app.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r931418 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-04-06 Thread kkolinko
Author: kkolinko
Date: Wed Apr  7 03:38:46 2010
New Revision: 931418

URL: http://svn.apache.org/viewvc?rev=931418&view=rev
Log:
proposal

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=931418&r1=931417&r2=931418&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Wed Apr  7 03:38:46 2010
@@ -323,3 +323,13 @@ PATCHES PROPOSED TO BACKPORT:
   http://svn.apache.org/viewvc?view=revision&revision=931061
   +1: kfujino
   -1: 
+
+* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49018
+  Fix processing of time argument in the "Expire sessions" action in the
+  Manager web application.
+  The patch also provides separate templates for different variants of a
+  message, printed by that action. That is to allow proper translation of
+  those messages, though I cannot provide such translation by myself.
+  http://svn.apache.org/viewvc?rev=931415&view=rev
+  +1: kkolinko
+  -1:



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org