Re: Spnego support in tomcat- patch available
Can someone review and provide comments on the patch? On Mon, Mar 29, 2010 at 3:25 PM, Ashish Jain wrote: > Can someone review and provide comments on the uploaded patch? > > > On Fri, Mar 26, 2010 at 8:11 PM, Ashish Jain wrote: > >> Hi Tomcat Developers, >> >> I have reworked the patch for Spnego support in tomcat. It is awaiting >> valuable comments from one of the tomcat developers/committers. >> The link for bugzilla is >> https://issues.apache.org/bugzilla/show_bug.cgi?id=48685. Kindly review >> and provide your comments. >> >> Thanks >> Ashish >> > >
Re: Tomcat 5.5 does not compile
When this fix will publish in Revision 902650 ? I am also getting same error by adding the fix for Revision 902650. Viju On 26/03/2010 17:05, Mark Thomas wrote: > On 26/03/2010 16:58, Filip Hanik - Dev Lists wrote: >> Somehow 1.5 classes got inserted. 5.5 is compiled using JDK 1.4 > > The first one was me. I'll fix that now. Done. The others look like me too. Fixing them now... Mark >> build-catalina-core: >> [javac] Compiling 319 source files to >> C:\development\tomcat\tc5build\tc5.5.x\trunk\build\build\classes >> [javac] >> C:\development\tomcat\tc5build\tc5.5.x\trunk\container\catalina\src\share\or g\apache\catalina\loader\WebappC >> >> lassLoader.java:2150: cannot resolve symbol >> [javac] symbol : constructor IllegalArgumentException >> (java.lang.String,java.io.IOException) >> [javac] location: class java.lang.IllegalArgumentException >> [javac] throw new >> IllegalArgumentException( >> [javac] ^ >> [javac] >> C:\development\tomcat\tc5build\tc5.5.x\trunk\container\catalina\src\share\or g\apache\catalina\startup\HostCo >> >> nfig.java:750: cannot resolve symbol >> [javac] symbol : class StringBuilder >> [javac] location: class org.apache.catalina.startup.HostConfig >> [javac] StringBuilder docBase; >> [javac] ^ >> [javac] >> C:\development\tomcat\tc5build\tc5.5.x\trunk\container\catalina\src\share\or g\apache\catalina\startup\HostCo >> >> nfig.java:755: cannot resolve symbol >> [javac] symbol : class StringBuilder >> [javac] location: class org.apache.catalina.startup.HostConfig >> [javac] docBase = new StringBuilder(canonicalAppBase); >> [javac] ^ >> [javac] Note: Some input files use or override a deprecated API. >> [javac] Note: Recompile with -deprecation for details. >> [javac] 3 errors >> >> BUILD FAILED
Re: tomcat jsp, login strategy
2010/3/30 Stéphanie Cettou : > Hi, > > I have a JSP application. > The login is implemented with database. > > > I need to increase the security. I want that the user have only 3 > retry for the login, the user must change the password every months, I > need a password policy (8 char, Maj and min,...). > > How I can implement this? > > I think to use active directory, but I can't manage user and passwords > directly with tomcat, or yes? > > Thanks, > > Stéphanie > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: tomcat jsp, login strategy
This isn't a question for the dev list. http://tomcat.apache.org/lists.html On 30/03/2010 15:21, Stéphanie Cettou wrote: > 2010/3/30 Stéphanie Cettou : >> Hi, >> >> I have a JSP application. >> The login is implemented with database. >> >> > >> I need to increase the security. I want that the user have only 3 >> retry for the login, the user must change the password every months, I >> need a password policy (8 char, Maj and min,...). >> >> How I can implement this? >> >> I think to use active directory, but I can't manage user and passwords >> directly with tomcat, or yes? >> >> Thanks, >> >> Stéphanie >> > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Comet Tomcat 6.0.20 problem
Hello everybody, is it possible to perform client and server push through the same connection via tomcat comet? The picture in the Low-Latency-Script tells me that it is possible, but how? Thanks in advance -Chris Chris wrote: I'm facing a strange problem,or maybe its even me. I want to create a bidirectional communication between a client using async socket and my tomcat webserver using apr. Everything seems to be setup correctly and I receive the first client POST properly also the answer is written and read by the client, but if the client now tries to send a second piece of xml, I always receive a CLIENT_DISCONNECT, I expected a call of the READ event. Wireshark tells me that the client sent it properly to the server but somehow tomcat doesnt like it. On server I use the chatServer example, a bit modified, cause I read the content inside the read event and not at the begin event. Am I doing something really wrong? I read somewhere that it is possible to use bidirectional communication but somehow it doesnt work. Communiction looks like this: Client POST /url/servlet HTTP/1.1 Host: localhost:8080 User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.0.13) Gecko/2009080315 Ubuntu/9.04 (jaunty) Firefox/3.0.13 Transfer-Encoding: chunked 145 ___ Server HTTP/1.1 200 OK Server: Apache-Coyote/1.1 Set-Cookie: JSESSIONID=F9A0B9BAB695EDB6C51253A24D8989D9; Path=/streamcam_gwt Transfer-Encoding: chunked Date: Mon, 29 Mar 2010 15:44:25 GMT 9a ___ Client _ 8E Thanks in advance. -Chris - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r929181 - in /tomcat/trunk/java/org/apache: catalina/connector/CoyoteAdapter.java catalina/core/AsyncContextImpl.java coyote/http11/Http11Processor.java
Author: fhanik
Date: Tue Mar 30 16:03:32 2010
New Revision: 929181
URL: http://svn.apache.org/viewvc?rev=929181&view=rev
Log:
Clear up state handling a bit
Modified:
tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java
tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java
tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java
Modified: tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java?rev=929181&r1=929180&r2=929181&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java Tue Mar
30 16:03:32 2010
@@ -280,7 +280,7 @@ public class CoyoteAdapter implements Ad
AsyncContextImpl asyncConImpl =
(AsyncContextImpl)request.getAsyncContext();
//TODO SERVLET3 - async
//configure settings for timed out
-asyncConImpl.setErrorState();
+asyncConImpl.setErrorState(new IOException("Socket error."));
}
while (success) {
AsyncContextImpl impl =
(AsyncContextImpl)request.getAsyncContext();
@@ -302,12 +302,15 @@ public class CoyoteAdapter implements Ad
//TODO SERVLET3 - async
async = false;
break;
+} else if
(impl.getState()==AsyncContextImpl.AsyncState.ERROR_DISPATCHING) {
+async = false;
+success = false;
+
connector.getContainer().getPipeline().getFirst().invoke(request, response);
} else {
try {
connector.getContainer().getPipeline().getFirst().invoke(request, response);
-}catch (RuntimeException x) {
-success = false;
-} finally {
+} catch (RuntimeException x) {
+impl.setErrorState(x);
}
}
}
@@ -394,7 +397,7 @@ public class CoyoteAdapter implements Ad
}
boolean comet = false;
-boolean async = request.isAsyncStarted();
+boolean async = false;
try {
@@ -431,12 +434,12 @@ public class CoyoteAdapter implements Ad
if (asyncConImpl!=null &&
asyncConImpl.getState()==AsyncContextImpl.AsyncState.STARTED) {
res.action(ActionCode.ACTION_ASYNC_START,
request.getAsyncContext());
async = true;
-} else if (asyncConImpl!=null &&
-
(asyncConImpl.getState()==AsyncContextImpl.AsyncState.DISPATCHING ||
-
asyncConImpl.getState()==AsyncContextImpl.AsyncState.COMPLETING ||
-
asyncConImpl.getState()==AsyncContextImpl.AsyncState.TIMING_OUT ||
-
asyncConImpl.getState()==AsyncContextImpl.AsyncState.ERROR_DISPATCHING)) {
+} else if (request.isAsyncDispatching()) {
asyncDispatch(req, res, SocketStatus.OPEN);
+if (request.isAsyncStarted()) {
+async = true;
+res.action(ActionCode.ACTION_ASYNC_START,
request.getAsyncContext());
+}
} else if (!comet) {
response.finishResponse();
req.action(ActionCode.ACTION_POST_REQUEST , null);
Modified: tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java?rev=929181&r1=929180&r2=929181&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java (original)
+++ tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java Tue Mar 30
16:03:32 2010
@@ -389,7 +389,8 @@ public class AsyncContextImpl implements
state.set(AsyncState.TIMING_OUT);
}
-public void setErrorState() {
+public void setErrorState(Throwable t) {
+if (t!=null) request.setAttribute(RequestDispatcher.ERROR_EXCEPTION,
t);
state.set(AsyncState.ERROR_DISPATCHING);
}
Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java?rev=929181&r1=929180&r2=929181&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java (original)
+++ tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java Tue Mar 30
16:03:32 2010
@@ -318,21 +318,19 @@ public class Http11Processor extends A
Re: svn commit: r928798 - in /tomcat/trunk: java/org/apache/catalina/core/ java/org/apache/catalina/loader/ webapps/docs/config/
On 29/03/2010, ma...@apache.org wrote: > Author: markt > Date: Mon Mar 29 15:01:14 2010 > New Revision: 928798 > > URL: http://svn.apache.org/viewvc?rev=928798&view=rev > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48895 > Make clearing thread locals optional and disabled by default since it isn't > thread-safe However, the new boolean flag (clearReferencesThreadLocals) that controls the process is not safely published between threads. It should probably be volatile. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49024] New: Enhance RemoteIpFilter docs
https://issues.apache.org/bugzilla/show_bug.cgi?id=49024 Summary: Enhance RemoteIpFilter docs Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Mac OS X 10.4 Status: NEW Severity: enhancement Priority: P2 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: clecl...@apache.org Created an attachment (id=25213) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25213) RemoteIpFilter docs enhancement As discussed on the mailing list, here is a proposed enhancement of the docs of the RemoteIpFilter (/config/filter.html). This enhancement adds the followings chapters in RemoteIpFilter doc : * Basic configuration to handle 'x-forwarded-for' * Basic configuration to handle 'x-forwarded-for' and 'x-forwarded-proto' * Advanced configuration with internal proxies * Advanced configuration with trusted proxies * Advanced configuration with internal and trusted proxies * Advanced configuration with an untrusted proxy Each configuration sample comes with a simulation of headers and request.getXxx() values before and after the RemoteIpFilter to explain how it works. If this docs enhancement is accepted, I would be happy to do the same work for the RemoteIpValve. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r928798 - in /tomcat/trunk: java/org/apache/catalina/core/ java/org/apache/catalina/loader/ webapps/docs/config/
2010/3/30 sebb : > On 29/03/2010, ma...@apache.org wrote: >> Author: markt >> Date: Mon Mar 29 15:01:14 2010 >> New Revision: 928798 >> >> URL: http://svn.apache.org/viewvc?rev=928798&view=rev >> Log: >> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48895 >> Make clearing thread locals optional and disabled by default since it isn't >> thread-safe > > However, the new boolean flag (clearReferencesThreadLocals) that > controls the process is not safely published between threads. It > should probably be volatile. > Startup is performed by a single thread, and it will set the value of this field. According to the memory model all the threads started after that will see the assigned value. I do not remember any of the "option value" fields in Tomcat being marked as volatile. All of them are usual fields. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r928798 - in /tomcat/trunk: java/org/apache/catalina/core/ java/org/apache/catalina/loader/ webapps/docs/config/
On 30/03/2010, Konstantin Kolinko wrote: > 2010/3/30 sebb : > > > On 29/03/2010, ma...@apache.org wrote: > >> Author: markt > >> Date: Mon Mar 29 15:01:14 2010 > >> New Revision: 928798 > >> > >> URL: http://svn.apache.org/viewvc?rev=928798&view=rev > >> Log: > >> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48895 > >> Make clearing thread locals optional and disabled by default since it > isn't thread-safe > > > > However, the new boolean flag (clearReferencesThreadLocals) that > > controls the process is not safely published between threads. It > > should probably be volatile. > > > > > Startup is performed by a single thread, and it will set the value of > this field. OK, in that case not a problem. However, it seems to me that this assumption should be documented in the StandardContext class. I think I saw a recent Bugzilla which suggested using multiple threads to speed startup, in which case the assumption might become incorrect. > According to the memory model all the threads started after that will > see the assigned value. Agreed; it's only a problem if two active threads access the same mutable variable. > I do not remember any of the "option value" fields in Tomcat being > marked as volatile. All of them are usual fields. > > Best regards, > > Konstantin Kolinko > > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r929284 - /tomcat/trunk/java/org/apache/catalina/connector/Request.java
Author: markt Date: Tue Mar 30 21:01:02 2010 New Revision: 929284 URL: http://svn.apache.org/viewvc?rev=929284&view=rev Log: When changing a session ID, use the internal add cookie method in the same way as when first creating a session cookie. Modified: tomcat/trunk/java/org/apache/catalina/connector/Request.java Modified: tomcat/trunk/java/org/apache/catalina/connector/Request.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/Request.java?rev=929284&r1=929283&r2=929284&view=diff == --- tomcat/trunk/java/org/apache/catalina/connector/Request.java (original) +++ tomcat/trunk/java/org/apache/catalina/connector/Request.java Tue Mar 30 21:01:02 2010 @@ -2284,7 +2284,7 @@ public class Request Cookie newCookie = ApplicationSessionCookieConfig.createSessionCookie(context, newSessionId, secure); -response.addCookie(newCookie); +response.addCookieInternal(newCookie); } } - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48913] Request.changeSessionId adds a second Set-Cookie JSESSIONID
https://issues.apache.org/bugzilla/show_bug.cgi?id=48913 --- Comment #1 from Mark Thomas 2010-03-30 21:59:05 UTC --- I can confirm that the current implementation does not expect other components to force the creation of a session earlier in the pipeline. This looks to be fixable but I'm worried about the overhead that will be associated with the fix. My performance concerns may be unfounded but if you were able to find an alternative solution (eg not requiring the session to be created in your custom authenticator) then that might be a better overall solution. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r929335 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Tue Mar 30 23:03:51 2010 New Revision: 929335 URL: http://svn.apache.org/viewvc?rev=929335&view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=929335&r1=929334&r2=929335&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Mar 30 23:03:51 2010 @@ -286,3 +286,10 @@ PATCHES PROPOSED TO BACKPORT: http://svn.apache.org/viewvc?rev=928798&view=rev +1: markt -1: + +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48917 + Correct name of mod_jk module in ApacheConfig + https://issues.apache.org/bugzilla/attachment.cgi?id=25132 + Patch provided by Todd Hicks + +1: markt + -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48917] ApacheConfig.java update windows default module mod_jk.dll -> mod_jk.so
https://issues.apache.org/bugzilla/show_bug.cgi?id=48917 --- Comment #3 from Mark Thomas 2010-03-30 23:04:05 UTC --- Sure. I have proposed (and voted for) your patch. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48913] Request.changeSessionId adds a second Set-Cookie JSESSIONID
https://issues.apache.org/bugzilla/show_bug.cgi?id=48913 --- Comment #2 from Mark Thomas 2010-03-30 23:06:18 UTC --- Created an attachment (id=25219) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25219) Proposed patch to remove previously set session cookies I haven't applied the attached patch to trunk. I'd appreciate some feedback onthe patch before I do. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48738] [PATCH]Allow GzipOutputFilter to send partial result when flushBuffer() is called
https://issues.apache.org/bugzilla/show_bug.cgi?id=48738 James Ward changed: What|Removed |Added CC||ja...@jamesward.org -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Spnego support in tomcat- patch available
Can someone review and provide comments on the uploaded patch? On Tue, Mar 30, 2010 at 2:11 PM, Ashish Jain wrote: > Can someone review and provide comments on the patch? > > > On Mon, Mar 29, 2010 at 3:25 PM, Ashish Jain wrote: > >> Can someone review and provide comments on the uploaded patch? >> >> >> On Fri, Mar 26, 2010 at 8:11 PM, Ashish Jain wrote: >> >>> Hi Tomcat Developers, >>> >>> I have reworked the patch for Spnego support in tomcat. It is awaiting >>> valuable comments from one of the tomcat developers/committers. >>> The link for bugzilla is >>> https://issues.apache.org/bugzilla/show_bug.cgi?id=48685. Kindly review >>> and provide your comments. >>> >>> Thanks >>> Ashish >>> >> >> >
DO NOT REPLY [Bug 41992] Need ability to set OS process title
https://issues.apache.org/bugzilla/show_bug.cgi?id=41992 --- Comment #3 from Matthew Sacks 2010-03-31 04:55:12 UTC --- Usually JAVA_EXEC is something that is defined by environment variables outside of the scope of the Tomcat startup scripts themselves. Furthermore it is something more suited to be placed in the $PATH environment variable on Unix-based systems. I do not see a need to modify startup.sh and shutdown.sh. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
