date:20100218

Re: jk/cluster - intelligent systems load

2010-02-18 Thread jean-frederic clere

On 02/17/2010 10:46 PM, Costin Manolache wrote:
> On Wed, Feb 17, 2010 at 11:58 AM, Mladen Turk  wrote:
> 
>> On 02/17/2010 07:37 PM, Costin Manolache wrote:
>>
>>> On Wed, Feb 17, 2010 at 12:38 AM, Mladen Turk  wrote:
>>>
>>>
>>> The reasons I suggest using SPDY as a replacement for AJP - and supporting
>>> SPDY
>>>
>>
>> I have nothing against SPDY and it really looks cool,
>> but IMHO it's doesn't look and feel like the rest of RFC
>> protocol specifications.
>> If you can push those guys to create a well known RFC-like
>> doc, I'm sure that overall internet community will benefit
>> from it.
>>
> 
> SPDY is still in development - there is an open mailing list and
> quite a few proposals/changes/discussions. I would guess
> the end result will end up as a RFC-like. Feel free to join the
> mailing list and push or volunteer for anything :-)
> 
> The implementations - chrome, mod_spdy are also open source
> and with ASF-like license.
> 
> 
> 
>>
>> OTOH we are discussing this 'protocol thing' for years instead like
>> you noticed we concentrate on the tasks we wish to do.
>> Think if we start from the protocol side we will stay there (nowhere)
>> for few more years (although SPDY might be even more then we need).
> 
> 
> I think what matters is having a working SPDY implementation in tomcat,
> inter-operable
> with chrome/mod_spdy/google. If we start with this we'll probably make
> more progress than by discussing protocols :-)

Yep, I have noted that people are preparing an implementation for httpd
so at some point it will just "porting" that code to TC.

Cheers

Jean-Frederic

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: HttpSessionActivationListener sessionDidActivate not called on cluster node startup

2010-02-18 Thread Mark Thomas

On 18/02/2010 04:39, David Rees wrote:
> Resending to dev - first two posts to users have netted no response.
> 
> I've entered a bug, too:
> https://issues.apache.org/bugzilla/show_bug.cgi?id=48717
> 
> Any ideas, guys?  Having this work would greatly simplify life for me,
> but I've looked at the code a bit and can't figure out why it doesn't
> work...

Patience. We know it is there. It isn't the only open bug in Bugzilla
(although there are an awful lot less open bugs than there used to be).
Other bugs have been open longer.

I can't speak for the other committers but I tend to look at bugs that
have been open longest first. The good news is that the backlog is also
a lot shorter than it used to be (now less than a month) so 48717 should
get looked at in the next few weeks.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r911298 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/javax/servlet/jsp/JspContext.java webapps/docs/changelog.xml

2010-02-18 Thread markt

Author: markt
Date: Thu Feb 18 09:48:01 2010
New Revision: 911298

URL: http://svn.apache.org/viewvc?rev=911298&view=rev
Log:
Don't use @Deprecated as spec doesn't

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
tomcat/tc6.0.x/trunk/java/javax/servlet/jsp/JspContext.java
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=911298&r1=911297&r2=911298&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Feb 18 09:48:01 2010
@@ -68,12 +68,6 @@
   -1: remm: no for TC 6.0
   -1: funkman : api change in Session.java for .x.x release
 
-* Remove @Deprecated annotations from javax.servlet.jsp.JspContext
-  Part of http://svn.apache.org/viewvc?rev=899635&view=rev
-  
http://svn.apache.org/viewvc/tomcat/trunk/java/javax/servlet/jsp/JspContext.java?view=diff&r1=899634&r2=899635&pathrev=899635
-  +1: kkolinko, markt, mturk
-  -1:
-
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48613
   Only attempt APR initialization if the  has been specified
   http://svn.apache.org/viewvc?rev=904224&view=rev

Modified: tomcat/tc6.0.x/trunk/java/javax/servlet/jsp/JspContext.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/javax/servlet/jsp/JspContext.java?rev=911298&r1=911297&r2=911298&view=diff
==
--- tomcat/tc6.0.x/trunk/java/javax/servlet/jsp/JspContext.java (original)
+++ tomcat/tc6.0.x/trunk/java/javax/servlet/jsp/JspContext.java Thu Feb 18 
09:48:01 2010
@@ -225,7 +225,7 @@
  * @deprecated As of JSP 2.1, replaced by
  * JspApplicationContext.getExpressionFactory()
  */
-@Deprecated
+@SuppressWarnings("dep-ann") // TCK signature test fails with annotation
 public abstract ExpressionEvaluator getExpressionEvaluator();
 
 
@@ -243,7 +243,7 @@
  * which can be obtained by
  * jspContext.getELContext().getELResolver()
  */
-@Deprecated
+@SuppressWarnings("dep-ann") // TCK signature test fails with annotation
 public abstract VariableResolver getVariableResolver();
 
 /**

Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml?rev=911298&r1=911297&r2=911298&view=diff
==
--- tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Thu Feb 18 09:48:01 2010
@@ -62,6 +62,11 @@
 be present in the names of CATALINA_HOME/_BASE and the current 
directory
 used to call the Tomcat scripts. (kkolinko)
   
+  
+Don't use @Deprecated annotations in
+javax.servlet.jsp.JspContext since the specification does
+not include them in the API definition. (markt)
+  
 
   
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r911300 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/core/AprLifecycleListener.java webapps/docs/changelog.xml

2010-02-18 Thread markt

Author: markt
Date: Thu Feb 18 09:53:12 2010
New Revision: 911300

URL: http://svn.apache.org/viewvc?rev=911300&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48613
Only attempt APR initialization if the  has been specified (fhanik)

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/AprLifecycleListener.java
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=911300&r1=911299&r2=911300&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Feb 18 09:53:12 2010
@@ -68,12 +68,6 @@
   -1: remm: no for TC 6.0
   -1: funkman : api change in Session.java for .x.x release
 
-* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48613
-  Only attempt APR initialization if the  has been specified
-  http://svn.apache.org/viewvc?rev=904224&view=rev
-  +1: fhanik, markt, kkolinko, mturk
-  -1: 
-
 * Fix the maven stuff for the maven repo.
   Before it does't find tomcat-juli.jar and the remoteRepository seems broken .
   http://people.apache.org/~jfclere/patches/maven.patch

Modified: 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/AprLifecycleListener.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/AprLifecycleListener.java?rev=911300&r1=911299&r2=911300&view=diff
==
--- 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/AprLifecycleListener.java 
(original)
+++ 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/AprLifecycleListener.java 
Thu Feb 18 09:53:12 2010
@@ -46,6 +46,7 @@
 
 private static Log log = LogFactory.getLog(AprLifecycleListener.class);
 
+private static boolean instanceCreated = false;
 /**
  * The string manager for this package.
  */
@@ -71,9 +72,14 @@
 protected static boolean aprAvailable = false;
 
 public static boolean isAprAvailable() {
-init();
+//https://issues.apache.org/bugzilla/show_bug.cgi?id=48613
+if (instanceCreated) init();
 return aprAvailable;
 }
+
+public AprLifecycleListener() {
+instanceCreated = true;
+}
 
 // -- LifecycleListener Methods
 

Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml?rev=911300&r1=911299&r2=911300&view=diff
==
--- tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Thu Feb 18 09:53:12 2010
@@ -38,6 +38,10 @@
   
 
   
+48613: Further fixes to ensure APRLifecycleListener is only
+used if defined in server.xml. (fhanik)
+  
+  
 48614: Correct JULI log file buffering so default behaviour
 is no buffering. (fhanik)
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 48613] AprLifecycleListener tries to initialize even if it is not configured in server.xml

2010-02-18 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=48613

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #8 from Mark Thomas  2010-02-18 09:53:33 UTC ---
That patch had been applied to trunk and will be included in 6.0.25 onwards.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 48757] Tomcat deletes content of symbolic links on undeploy of application.

2010-02-18 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=48757

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE

--- Comment #1 from Mark Thomas  2010-02-18 09:56:22 UTC ---


*** This bug has been marked as a duplicate of bug 39226 ***

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 39226] Manager app deletes contents of symbolic links on undeploy

2010-02-18 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=39226

Mark Thomas  changed:

   What|Removed |Added

 CC||rad...@gmail.com

--- Comment #3 from Mark Thomas  2010-02-18 09:56:22 UTC ---
*** Bug 48757 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r911301 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/jasper/compiler/Compiler.java webapps/docs/changelog.xml

2010-02-18 Thread markt

Author: markt
Date: Thu Feb 18 09:59:39 2010
New Revision: 911301

URL: http://svn.apache.org/viewvc?rev=911301&view=rev
Log:
Add some debug logging where exceptions where previously swallowed

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
tomcat/tc6.0.x/trunk/java/org/apache/jasper/compiler/Compiler.java
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=911301&r1=911300&r2=911301&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Feb 18 09:59:39 2010
@@ -76,11 +76,6 @@
if we remove the SCP auto feature, then there should be 
something to replace it with
(http://ant.apache.org/manual/OptionalTasks/scp.html)  
 
-* Add some debug logging where exceptions where previously swallowed
-  http://svn.apache.org/viewvc?rev=904834&view=rev
-  +1: markt, kkolinko, mturk
-  -1:
-
 * Fix various EL TCK failures
   http://svn.apache.org/viewvc?view=rev&rev=899653 (signatures)
+1: markt, kkolinko

Modified: tomcat/tc6.0.x/trunk/java/org/apache/jasper/compiler/Compiler.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/jasper/compiler/Compiler.java?rev=911301&r1=911300&r2=911301&view=diff
==
--- tomcat/tc6.0.x/trunk/java/org/apache/jasper/compiler/Compiler.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/jasper/compiler/Compiler.java Thu Feb 
18 09:59:39 2010
@@ -419,6 +419,7 @@
 }
 uc.getInputStream().close();
 } catch (Exception e) {
+log.debug("Problem accessing resource. Treat as outdated.", e);
 return true;
 }
 
@@ -481,6 +482,7 @@
 return true;
 }
 } catch (Exception e) {
+log.debug("Problem accessing resource. Treat as outdated.", e);
 return true;
 }
 }

Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml?rev=911301&r1=911300&r2=911301&view=diff
==
--- tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Thu Feb 18 09:59:39 2010
@@ -47,6 +47,14 @@
   
 
   
+  
+
+  
+Add some debug logging to the compiler where exceptions were previously
+swallowed. (markt)
+  
+
+  
   
 
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r911303 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt java/org/apache/catalina/startup/Catalina.java webapps/docs/changelog.xml webapps/docs/config/systemprops.xml

2010-02-18 Thread markt

Author: markt
Date: Thu Feb 18 10:04:37 2010
New Revision: 911303

URL: http://svn.apache.org/viewvc?rev=911303&view=rev
Log:
Add a system property that lets the startup phase exit if the server encounters 
an exception during the initialization phase. The default is false, which means 
the behavior from today remains unchanged. (fhanik)

Modified:
tomcat/tc6.0.x/trunk/   (props changed)
tomcat/tc6.0.x/trunk/STATUS.txt
tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/Catalina.java
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
tomcat/tc6.0.x/trunk/webapps/docs/config/systemprops.xml

Propchange: tomcat/tc6.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Thu Feb 18 10:04:37 2010
@@ -1,2 +1,2 @@
 /tomcat:883362
-/tomcat/trunk:601180,606992,612607,630314,640888,652744,653247,666232,673796,673820,677910,683969,683982,684001,684081,684234,684269-684270,685177,687503,687645,689402,690781,691392,691805,692748,693378,694992,695053,695311,696780,696782,698012,698227,698236,698613,699427,699634,701355,709294,709811,709816,710063,710066,710125,710205,711126,711600,712461,712467,713953,714002,718360,719119,719124,719602,719626,719628,720046,720069,721040,721286,721708,721886,723404,723738,726052,727303,728032,728768,728947,729057,729567,729569,729571,729681,729809,729815,729934,730250,730590,731651,732859,732863,734734,740675,740684,742677,742697,742714,744160,744238,746321,746384,746425,747834,747863,748344,750258,750291,750921,751286-751287,751289,751295,753039,757335,757774,758249,758365,758596,758616,758664,759074,761601,762868,762929,762936-762937,763166,763183,763193,763228,763262,763298,763302,763325,763599,763611,763654,763681,763706,764985,764997,765662,768335,769979,770716,770809,77
 
0876,772872,776921,776924,776935,776945,777464,777466,777576,777625,778379,778523-778524,781528,781779,782145,782791,783316,783696,783724,783756,783762,783766,783863,783934,784453,784602,784614,785381,785688,785768,785859,786468,786487,786490,786496,786667,787627,787770,787985,789389,790405,791041,791184,791194,791224,791243,791326,791328,791789,792740,793372,793757,793882,793981,794082,794673,794822,795043,795152,795210,795457,795466,797168,797425,797596,797607,802727,802940,804462,804544,804734,805153,809131,809603,810916,810977,812125,812137,812432,813001,813013,813866,814180,814708,814876,815972,816252,817442,817822,819339,819361,820110,820132,820874,820954,821397,828196,828201,828210,828225,828759,830378-830379,830999,831106,831774,831785,831828,831850,831860,832214,832218,833121,833545,834047,835036,835336,836405,881396,881412,883130,883134,883146,883165,883177,883362,883565,884341,885038,885231,885241,885260,885901,885991,886019,888072,889363,889606,889716,890139,8902
 
65,890349-890350,890417,891185-891187,891583,892198,892341,892415,892464,892555,892812,892814,892817,892843,892887,893321,893493,894580,894586,894805,894831,895013,895045,895057,895191,895392,895703,896370,896384,897380-897381,897776,898126,898256,898468,898527,898555,898558,898718,898836,898906,899284,899348,899420,903916,905151,908721
+/tomcat/trunk:601180,606992,612607,630314,640888,652744,653247,666232,673796,673820,677910,683969,683982,684001,684081,684234,684269-684270,685177,687503,687645,689402,690781,691392,691805,692748,693378,694992,695053,695311,696780,696782,698012,698227,698236,698613,699427,699634,701355,709294,709811,709816,710063,710066,710125,710205,711126,711600,712461,712467,713953,714002,718360,719119,719124,719602,719626,719628,720046,720069,721040,721286,721708,721886,723404,723738,726052,727303,728032,728768,728947,729057,729567,729569,729571,729681,729809,729815,729934,730250,730590,731651,732859,732863,734734,740675,740684,742677,742697,742714,744160,744238,746321,746384,746425,747834,747863,748344,750258,750291,750921,751286-751287,751289,751295,752323,753039,757335,757774,758249,758365,758596,758616,758664,759074,761601,762868,762929,762936-762937,763166,763183,763193,763228,763262,763298,763302,763325,763599,763611,763654,763681,763706,764985,764997,765662,768335,769979,770716,77
 
0809,770876,772872,776921,776924,776935,776945,777464,777466,777576,777625,778379,778523-778524,781528,781779,782145,782791,783316,783696,783724,783756,783762,783766,783863,783934,784453,784602,784614,785381,785688,785768,785859,786468,786487,786490,786496,786667,787627,787770,787985,789389,790405,791041,791184,791194,791224,791243,791326,791328,791789,792740,793372,793757,793882,793981,794082,794673,794822,795043,795152,795210,795457,795466,797168,797425,797596,797607,802727,802940,804462,804544,804734,805153,809131,809603,810916,810977,812125,812137,812432,813001,813013,813866,814180,814708,814876,815972,816252,817442,817822,819339,819361,820110,820132,820874,820954,821397,828196,828201,828210,828225,828759,830378-830379,830999,831106,831774,831785,831828,831850,831860,832214,832218,833121,833545,834047,835036,835336,836405,881396,881

DO NOT REPLY [Bug 48625] Server started in illegal state

2010-02-18 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=48625

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #2 from Mark Thomas  2010-02-18 10:04:42 UTC ---
The patch has been applied to trunk and will be included in 6.0.25 onwards.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r911310 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/jasper/compiler/Generator.java java/org/apache/jasper/compiler/ScriptingVariabler.java webapps/docs/changelog.xml

2010-02-18 Thread markt

Author: markt
Date: Thu Feb 18 10:27:33 2010
New Revision: 911310

URL: http://svn.apache.org/viewvc?rev=911310&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48616
This is a regression caused by the fix for 
https://issues.apache.org/bugzilla/show_bug.cgi?id=42390
JspFragments are scriptless, so no need to declare or sync scripting variables 
for fragments. Since errors in syncing the scripting variables for JSP 
Fragments caused 48616 & 42390, this fixes both these bugs too. (kkolinko)

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
tomcat/tc6.0.x/trunk/java/org/apache/jasper/compiler/Generator.java
tomcat/tc6.0.x/trunk/java/org/apache/jasper/compiler/ScriptingVariabler.java
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=911310&r1=911309&r2=911310&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Feb 18 10:27:33 2010
@@ -143,18 +143,6 @@
   +1: markt, kkolinko
   -1: 
 
-* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48616
-  This is a regression caused by the fix for
-  https://issues.apache.org/bugzilla/show_bug.cgi?id=42390
-  JspFragments are scriptless, so no need to declare or sync scripting
-  variables for fragments. Since errors in syncing the scripting variables for
-  JSP Fragments caused 48616 & 42390, this fixes both these bugs too.
-  https://issues.apache.org/bugzilla/show_bug.cgi?id=48616#c21
-  (https://issues.apache.org/bugzilla/attachment.cgi?id=24992)
-  +1: kkolinko, markt, mturk
-  -1:
-
-
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48612
   Prevent exception on shutdown
   Port of r896193 and r905343

Modified: tomcat/tc6.0.x/trunk/java/org/apache/jasper/compiler/Generator.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/jasper/compiler/Generator.java?rev=911310&r1=911309&r2=911310&view=diff
==
--- tomcat/tc6.0.x/trunk/java/org/apache/jasper/compiler/Generator.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/jasper/compiler/Generator.java Thu Feb 
18 10:27:33 2010
@@ -333,6 +333,9 @@
 }
 
 public void visit(Node.CustomTag n) throws JasperException {
+// XXX - Actually there is no need to declare those
+// "_jspx_" + varName + "_" + nestingLevel variables when we 
are
+// inside a JspFragment.
 
 if (n.getCustomNestingLevel() > 0) {
 TagVariableInfo[] tagVarInfos = n.getTagVariableInfos();
@@ -2484,6 +2487,11 @@
 }
 
 private void declareScriptingVars(Node.CustomTag n, int scope) {
+if (isFragment) {
+// No need to declare Java variables, if we inside a
+// JspFragment, because a fragment is always scriptless.
+return;
+}
 
 Vector vec = n.getScriptingVars(scope);
 if (vec != null) {
@@ -2531,6 +2539,14 @@
 if (n.getCustomNestingLevel() == 0) {
 return;
 }
+if (isFragment) {
+// No need to declare Java variables, if we inside a
+// JspFragment, because a fragment is always scriptless.
+// Thus, there is no need to save/ restore/ sync them.
+// Note, that JspContextWrapper.syncFoo() methods will take
+// care of saving/ restoring/ sync'ing of JspContext 
attributes.
+return;
+}
 
 TagVariableInfo[] tagVarInfos = n.getTagVariableInfos();
 VariableInfo[] varInfos = n.getVariableInfos();
@@ -2591,6 +2607,14 @@
 if (n.getCustomNestingLevel() == 0) {
 return;
 }
+if (isFragment) {
+// No need to declare Java variables, if we inside a
+// JspFragment, because a fragment is always scriptless.
+// Thus, there is no need to save/ restore/ sync them.
+// Note, that JspContextWrapper.syncFoo() methods will take
+// care of saving/ restoring/ sync'ing of JspContext 
attributes.
+return;
+}
 
 TagVariableInfo[] tagVarInfos = n.getTagVariableInfos();
 VariableInfo[] varInfos = n.getVariableInfos();
@@ -2645,6 +2669,15 @@
  * given scope.
  */
 private void syncScriptingVars(Node.CustomTag n, int scope) {
+if (isFragment) {
+// No need to declare Java variables, if we inside a
+// JspFragment, because a fragment is always scriptless.
+// Thus, there is no need to save/ restore/ sync them.
+// Note, that JspContextWrapper

DO NOT REPLY [Bug 48616] Struts 1.2 and bean:define tag throws jsp 1.1 regression exception

2010-02-18 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=48616

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #25 from Mark Thomas  2010-02-18 10:28:20 UTC ---
This has been fixed in trunk and applied to 6.0.x. It will be included in
6.0.25 onwards.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 48616] Struts 1.2 and bean:define tag throws jsp 1.1 regression exception

2010-02-18 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=48616

Mark Thomas  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
  Component|Jasper  |Jasper
Version|6.0.24  |5.5.28
 Resolution|FIXED   |
Product|Tomcat 6|Tomcat 5
   Target Milestone|default |---

--- Comment #26 from Mark Thomas  2010-02-18 10:28:59 UTC ---
Re-open to track to 5.5.x

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 48763] AJP Connectors fail when POST requests don't have a Content-Length header

2010-02-18 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=48763

jfclere  changed:

   What|Removed |Added

 CC||jfcl...@gmail.com

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r911321 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/connector/Connector.java java/org/apache/catalina/mbeans/MBeanUtils.java webapps/docs/changelog.xml

2010-02-18 Thread markt

Author: markt
Date: Thu Feb 18 10:47:34 2010
New Revision: 911321

URL: http://svn.apache.org/viewvc?rev=911321&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48612
Prevent exception on shutdown if the address attribute is specified for a 
connector

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Connector.java
tomcat/tc6.0.x/trunk/java/org/apache/catalina/mbeans/MBeanUtils.java
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=911321&r1=911320&r2=911321&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Feb 18 10:47:34 2010
@@ -143,13 +143,6 @@
   +1: markt, kkolinko
   -1: 
 
-* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48612
-  Prevent exception on shutdown
-  Port of r896193 and r905343
-  http://people.apache.org/~markt/patches/2010-02-01-bug48612.patch
-  +1: markt, kkolinko, mturk
-  -1: 
-  
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48653
   RemoteIpValve : request.secure and request.scheme are not forced to "false"
   and "http" if X-Forwarded-Proto=http

Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Connector.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Connector.java?rev=911321&r1=911320&r2=911321&view=diff
==
--- tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Connector.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Connector.java Thu 
Feb 18 10:47:34 2010
@@ -956,14 +956,21 @@
 
 protected ObjectName createObjectName(String domain, String type)
 throws MalformedObjectNameException {
-String encodedAddr = null;
-if (getProperty("address") != null) {
-encodedAddr = URLEncoder.encode(getProperty("address").toString());
-}
-String addSuffix = (getProperty("address") == null) ? "" : ",address="
-+ encodedAddr;
-ObjectName _oname = new ObjectName(domain + ":type=" + type + ",port="
-+ getPort() + addSuffix);
+Object addressObj = getProperty("address");
+
+StringBuilder sb = new StringBuilder(domain);
+sb.append(":type=");
+sb.append(type);
+sb.append(",port=");
+sb.append(getPort());
+if (addressObj != null) {
+String address = addressObj.toString();
+if (address.length() > 0) {
+sb.append(",address=");
+sb.append(ObjectName.quote(address));
+}
+}
+ObjectName _oname = new ObjectName(sb.toString());
 return _oname;
 }
 

Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/mbeans/MBeanUtils.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/mbeans/MBeanUtils.java?rev=911321&r1=911320&r2=911321&view=diff
==
--- tomcat/tc6.0.x/trunk/java/org/apache/catalina/mbeans/MBeanUtils.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/mbeans/MBeanUtils.java Thu 
Feb 18 10:47:34 2010
@@ -742,21 +742,30 @@
 
 ObjectName name = null;
 try {
-String address = (String)
+Object addressObj =
 IntrospectionUtils.getProperty(connector, "address");
 Integer port = (Integer)
 IntrospectionUtils.getProperty(connector, "port");
+
 StringBuffer sb = new StringBuffer(domain);
 sb.append(":type=Connector");
-sb.append(",port=" + port);
-if ((address != null) && (address.length()>0)) {
-sb.append(",address=" + address);
+sb.append(",port=");
+sb.append(port);
+if (addressObj != null) {
+String address = addressObj.toString();
+if (address.length() > 0) {
+sb.append(",address=");
+sb.append(ObjectName.quote(address));
+}
 }
 name = new ObjectName(sb.toString());
 return (name);
 } catch (Exception e) {
-throw new MalformedObjectNameException
-("Cannot create object name for " + connector+e);
+MalformedObjectNameException mone =
+new MalformedObjectNameException
+("Cannot create object name for " + connector);
+mone.initCause(e);
+throw mone;
 }
 }
 

Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml?rev=911321&r1=911320&

DO NOT REPLY [Bug 48612] java.net.Inet4Address cannot be cast to java.lang.String

2010-02-18 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=48612

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #2 from Mark Thomas  2010-02-18 10:47:55 UTC ---
This has been fixed in 6.0.x and will be included in 6.0.25 onwards.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r911354 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt java/org/apache/catalina/core/StandardService.java webapps/docs/changelog.xml

2010-02-18 Thread markt

Author: markt
Date: Thu Feb 18 12:09:09 2010
New Revision: 911354

URL: http://svn.apache.org/viewvc?rev=911354&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48039
Return from StandardService.start() immediately if service is already started

Modified:
tomcat/tc6.0.x/trunk/   (props changed)
tomcat/tc6.0.x/trunk/STATUS.txt
tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/StandardService.java
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc6.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Thu Feb 18 12:09:09 2010
@@ -1,2 +1,2 @@
 /tomcat:883362
-/tomcat/trunk:601180,606992,612607,630314,640888,652744,653247,666232,673796,673820,677910,683969,683982,684001,684081,684234,684269-684270,685177,687503,687645,689402,690781,691392,691805,692748,693378,694992,695053,695311,696780,696782,698012,698227,698236,698613,699427,699634,701355,709294,709811,709816,710063,710066,710125,710205,711126,711600,712461,712467,713953,714002,718360,719119,719124,719602,719626,719628,720046,720069,721040,721286,721708,721886,723404,723738,726052,727303,728032,728768,728947,729057,729567,729569,729571,729681,729809,729815,729934,730250,730590,731651,732859,732863,734734,740675,740684,742677,742697,742714,744160,744238,746321,746384,746425,747834,747863,748344,750258,750291,750921,751286-751287,751289,751295,752323,753039,757335,757774,758249,758365,758596,758616,758664,759074,761601,762868,762929,762936-762937,763166,763183,763193,763228,763262,763298,763302,763325,763599,763611,763654,763681,763706,764985,764997,765662,768335,769979,770716,77
 
0809,770876,772872,776921,776924,776935,776945,777464,777466,777576,777625,778379,778523-778524,781528,781779,782145,782791,783316,783696,783724,783756,783762,783766,783863,783934,784453,784602,784614,785381,785688,785768,785859,786468,786487,786490,786496,786667,787627,787770,787985,789389,790405,791041,791184,791194,791224,791243,791326,791328,791789,792740,793372,793757,793882,793981,794082,794673,794822,795043,795152,795210,795457,795466,797168,797425,797596,797607,802727,802940,804462,804544,804734,805153,809131,809603,810916,810977,812125,812137,812432,813001,813013,813866,814180,814708,814876,815972,816252,817442,817822,819339,819361,820110,820132,820874,820954,821397,828196,828201,828210,828225,828759,830378-830379,830999,831106,831774,831785,831828,831850,831860,832214,832218,833121,833545,834047,835036,835336,836405,881396,881412,883130,883134,883146,883165,883177,883362,883565,884341,885038,885231,885241,885260,885901,885991,886019,888072,889363,889606,889716,8901
 
39,890265,890349-890350,890417,891185-891187,891583,892198,892341,892415,892464,892555,892812,892814,892817,892843,892887,893321,893493,894580,894586,894805,894831,895013,895045,895057,895191,895392,895703,896370,896384,897380-897381,897776,898126,898256,898468,898527,898555,898558,898718,898836,898906,899284,899348,899420,903916,905151,908721
+/tomcat/trunk:601180,606992,612607,630314,640888,652744,653247,666232,673796,673820,677910,683969,683982,684001,684081,684234,684269-684270,685177,687503,687645,689402,690781,691392,691805,692748,693378,694992,695053,695311,696780,696782,698012,698227,698236,698613,699427,699634,701355,709294,709811,709816,710063,710066,710125,710205,711126,711600,712461,712467,713953,714002,718360,719119,719124,719602,719626,719628,720046,720069,721040,721286,721708,721886,723404,723738,726052,727303,728032,728768,728947,729057,729567,729569,729571,729681,729809,729815,729934,730250,730590,731651,732859,732863,734734,740675,740684,742677,742697,742714,744160,744238,746321,746384,746425,747834,747863,748344,750258,750291,750921,751286-751287,751289,751295,752323,753039,757335,757774,758249,758365,758596,758616,758664,759074,761601,762868,762929,762936-762937,763166,763183,763193,763228,763262,763298,763302,763325,763599,763611,763654,763681,763706,764985,764997,765662,768335,769979,770716,77
 
0809,770876,772872,776921,776924,776935,776945,777464,777466,777576,777625,778379,778523-778524,781528,781779,782145,782791,783316,783696,783724,783756,783762,783766,783863,783934,784453,784602,784614,785381,785688,785768,785859,786468,786487,786490,786496,786667,787627,787770,787985,789389,790405,791041,791184,791194,791224,791243,791326,791328,791789,792740,793372,793757,793882,793981,794082,794673,794822,795043,795152,795210,795457,795466,797168,797425,797596,797607,802727,802940,804462,804544,804734,805153,809131,809603,810916,810977,812125,812137,812432,813001,813013,813866,814180,814708,814876,815972,816252,817442,817822,819339,819361,820110,820132,820874,820954,821397,828196,828201,828210,828225,828759,830378-830379,830999,831106,831774,831785,831828,831850,831860,832214,832218,833121,833545,834047,835036,835336,836405,881396,881412,883130,883134,883146,883165,883177,883362,883565,884341,885038,885231,885241,885260,885901,885991,886019,888072,889363,88

DO NOT REPLY [Bug 48039] org.apache.catalina.core.StandardService start method doesn't return immediately when it has started already

2010-02-18 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=48039

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #2 from Mark Thomas  2010-02-18 12:09:12 UTC ---
This has been fixed in 6.0.x and will be included in 6.0.25 onwards.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r911360 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt java/javax/servlet/jsp/JspFactory.java webapps/docs/changelog.xml

2010-02-18 Thread markt

Author: markt
Date: Thu Feb 18 12:13:12 2010
New Revision: 911360

URL: http://svn.apache.org/viewvc?rev=911360&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48170
Remove unnecessary syncs that cause issues under load

Modified:
tomcat/tc6.0.x/trunk/   (props changed)
tomcat/tc6.0.x/trunk/STATUS.txt
tomcat/tc6.0.x/trunk/java/javax/servlet/jsp/JspFactory.java
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc6.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Thu Feb 18 12:13:12 2010
@@ -1,2 +1,2 @@
 /tomcat:883362
-/tomcat/trunk:601180,606992,612607,630314,640888,652744,653247,666232,673796,673820,677910,683969,683982,684001,684081,684234,684269-684270,685177,687503,687645,689402,690781,691392,691805,692748,693378,694992,695053,695311,696780,696782,698012,698227,698236,698613,699427,699634,701355,709294,709811,709816,710063,710066,710125,710205,711126,711600,712461,712467,713953,714002,718360,719119,719124,719602,719626,719628,720046,720069,721040,721286,721708,721886,723404,723738,726052,727303,728032,728768,728947,729057,729567,729569,729571,729681,729809,729815,729934,730250,730590,731651,732859,732863,734734,740675,740684,742677,742697,742714,744160,744238,746321,746384,746425,747834,747863,748344,750258,750291,750921,751286-751287,751289,751295,752323,753039,757335,757774,758249,758365,758596,758616,758664,759074,761601,762868,762929,762936-762937,763166,763183,763193,763228,763262,763298,763302,763325,763599,763611,763654,763681,763706,764985,764997,765662,768335,769979,770716,77
 
0809,770876,772872,776921,776924,776935,776945,777464,777466,777576,777625,778379,778523-778524,781528,781779,782145,782791,783316,783696,783724,783756,783762,783766,783863,783934,784453,784602,784614,785381,785688,785768,785859,786468,786487,786490,786496,786667,787627,787770,787985,789389,790405,791041,791184,791194,791224,791243,791326,791328,791789,792740,793372,793757,793882,793981,794082,794673,794822,795043,795152,795210,795457,795466,797168,797425,797596,797607,802727,802940,804462,804544,804734,805153,809131,809603,810916,810977,812125,812137,812432,813001,813013,813866,814180,814708,814876,815972,816252,817442,817822,819339,819361,820110,820132,820874,820954,821397,828196,828201,828210,828225,828759,830378-830379,830999,831106,831774,831785,831828,831850,831860,832214,832218,833121,833545,834047,835036,835336,836405,881396,881412,883130,883134,883146,883165,883177,883362,883565,884341,885038,885231,885241,885260,885901,885991,886019,888072,889363,889606,889716,8901
 
39,890265,890349-890350,890417,891185-891187,891583,892198,892341,892415,892464,892555,892812,892814,892817,892843,892887,893321,893493,894580,894586,894805,894831,895013,895045,895057,895191,895392,895703,896370,896384,897380-897381,897776,898126,898256,898468,898527,898555,898558,898718,898836,898906,899284,899348,899420,903916,905151,905728,908721
+/tomcat/trunk:601180,606992,612607,630314,640888,652744,653247,666232,673796,673820,677910,683969,683982,684001,684081,684234,684269-684270,685177,687503,687645,689402,690781,691392,691805,692748,693378,694992,695053,695311,696780,696782,698012,698227,698236,698613,699427,699634,701355,709294,709811,709816,710063,710066,710125,710205,711126,711600,712461,712467,713953,714002,718360,719119,719124,719602,719626,719628,720046,720069,721040,721286,721708,721886,723404,723738,726052,727303,728032,728768,728947,729057,729567,729569,729571,729681,729809,729815,729934,730250,730590,731651,732859,732863,734734,740675,740684,742677,742697,742714,744160,744238,746321,746384,746425,747834,747863,748344,750258,750291,750921,751286-751287,751289,751295,752323,753039,757335,757774,758249,758365,758596,758616,758664,759074,761601,762868,762929,762936-762937,763166,763183,763193,763228,763262,763298,763302,763325,763599,763611,763654,763681,763706,764985,764997,765662,768335,769979,770716,77
 
0809,770876,772872,776921,776924,776935,776945,777464,777466,777576,777625,778379,778523-778524,781528,781779,782145,782791,783316,783696,783724,783756,783762,783766,783863,783934,784453,784602,784614,785381,785688,785768,785859,786468,786487,786490,786496,786667,787627,787770,787985,789389,790405,791041,791184,791194,791224,791243,791326,791328,791789,792740,793372,793757,793882,793981,794082,794673,794822,795043,795152,795210,795457,795466,797168,797425,797596,797607,802727,802940,804462,804544,804734,805153,809131,809603,810916,810977,812125,812137,812432,813001,813013,813866,814180,814708,814876,815972,816252,817442,817822,819339,819361,820110,820132,820874,820954,821397,828196,828201,828210,828225,828759,830378-830379,830999,831106,831774,831785,831828,831850,831860,832214,832218,833121,833545,834047,835036,835336,836405,881396,881412,883130,883134,883146,883165,883177,883362,883565,884341,885038,885231,885241,885260,885901,885991,886019,888072,889363,889606,889716,8901
 
39,890265,

DO NOT REPLY [Bug 48170] Unnecessary synchronization by JspFactory.getDefaultFactory contributes to stability problems

2010-02-18 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=48170

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #5 from Mark Thomas  2010-02-18 12:13:33 UTC ---
This has been fixed in 6.0.x and will be included in 6.0.25 onwards.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r911368 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt java/org/apache/jasper/servlet/JspServletWrapper.java webapps/docs/changelog.xml

2010-02-18 Thread markt

Author: markt
Date: Thu Feb 18 12:31:24 2010
New Revision: 911368

URL: http://svn.apache.org/viewvc?rev=911368&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48582
Avoid NPE on background compile

Modified:
tomcat/tc6.0.x/trunk/   (props changed)
tomcat/tc6.0.x/trunk/STATUS.txt
tomcat/tc6.0.x/trunk/java/org/apache/jasper/servlet/JspServletWrapper.java
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc6.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Thu Feb 18 12:31:24 2010
@@ -1,2 +1,2 @@
 /tomcat:883362
-/tomcat/trunk:601180,606992,612607,630314,640888,652744,653247,666232,673796,673820,677910,683969,683982,684001,684081,684234,684269-684270,685177,687503,687645,689402,690781,691392,691805,692748,693378,694992,695053,695311,696780,696782,698012,698227,698236,698613,699427,699634,701355,709294,709811,709816,710063,710066,710125,710205,711126,711600,712461,712467,713953,714002,718360,719119,719124,719602,719626,719628,720046,720069,721040,721286,721708,721886,723404,723738,726052,727303,728032,728768,728947,729057,729567,729569,729571,729681,729809,729815,729934,730250,730590,731651,732859,732863,734734,740675,740684,742677,742697,742714,744160,744238,746321,746384,746425,747834,747863,748344,750258,750291,750921,751286-751287,751289,751295,752323,753039,757335,757774,758249,758365,758596,758616,758664,759074,761601,762868,762929,762936-762937,763166,763183,763193,763228,763262,763298,763302,763325,763599,763611,763654,763681,763706,764985,764997,765662,768335,769979,770716,77
 
0809,770876,772872,776921,776924,776935,776945,777464,777466,777576,777625,778379,778523-778524,781528,781779,782145,782791,783316,783696,783724,783756,783762,783766,783863,783934,784453,784602,784614,785381,785688,785768,785859,786468,786487,786490,786496,786667,787627,787770,787985,789389,790405,791041,791184,791194,791224,791243,791326,791328,791789,792740,793372,793757,793882,793981,794082,794673,794822,795043,795152,795210,795457,795466,797168,797425,797596,797607,802727,802940,804462,804544,804734,805153,809131,809603,810916,810977,812125,812137,812432,813001,813013,813866,814180,814708,814876,815972,816252,817442,817822,819339,819361,820110,820132,820874,820954,821397,828196,828201,828210,828225,828759,830378-830379,830999,831106,831774,831785,831828,831850,831860,832214,832218,833121,833545,834047,835036,835336,836405,881396,881412,883130,883134,883146,883165,883177,883362,883565,884341,885038,885231,885241,885260,885901,885991,886019,888072,889363,889606,889716,8901
 
39,890265,890349-890350,890417,891185-891187,891583,892198,892341,892415,892464,892555,892812,892814,892817,892843,892887,893321,893493,894580,894586,894805,894831,895013,895045,895057,895191,895392,895703,896370,896384,897380-897381,897776,898126,898256,898468,898527,898555,898558,898718,898836,898906,899284,899348,899420,903916,905151,905728,907825,908721
+/tomcat/trunk:601180,606992,612607,630314,640888,652744,653247,666232,673796,673820,677910,683969,683982,684001,684081,684234,684269-684270,685177,687503,687645,689402,690781,691392,691805,692748,693378,694992,695053,695311,696780,696782,698012,698227,698236,698613,699427,699634,701355,709294,709811,709816,710063,710066,710125,710205,711126,711600,712461,712467,713953,714002,718360,719119,719124,719602,719626,719628,720046,720069,721040,721286,721708,721886,723404,723738,726052,727303,728032,728768,728947,729057,729567,729569,729571,729681,729809,729815,729934,730250,730590,731651,732859,732863,734734,740675,740684,742677,742697,742714,744160,744238,746321,746384,746425,747834,747863,748344,750258,750291,750921,751286-751287,751289,751295,752323,753039,757335,757774,758249,758365,758596,758616,758664,759074,761601,762868,762929,762936-762937,763166,763183,763193,763228,763262,763298,763302,763325,763599,763611,763654,763681,763706,764985,764997,765662,768335,769979,770716,77
 
0809,770876,772872,776921,776924,776935,776945,777464,777466,777576,777625,778379,778523-778524,781528,781779,782145,782791,783316,783696,783724,783756,783762,783766,783863,783934,784453,784602,784614,785381,785688,785768,785859,786468,786487,786490,786496,786667,787627,787770,787985,789389,790405,791041,791184,791194,791224,791243,791326,791328,791789,792740,793372,793757,793882,793981,794082,794673,794822,795043,795152,795210,795457,795466,797168,797425,797596,797607,802727,802940,804462,804544,804734,805153,809131,809603,810916,810977,812125,812137,812432,813001,813013,813866,814180,814708,814876,815972,816252,817442,817822,819339,819361,820110,820132,820874,820954,821397,828196,828201,828210,828225,828759,830378-830379,830999,831106,831774,831785,831828,831850,831860,832214,832218,833121,833545,834047,835036,835336,836405,881396,881412,883130,883134,883146,883165,883177,883362,883565,884341,885038,885231,885241,885260,885901,885991,886019,888072,889363,889606,889716,8901
 
39,890265,

DO NOT REPLY [Bug 48582] JspServletWrapper.getServletContext() throws NullPointerException

2010-02-18 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=48582

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #4 from Mark Thomas  2010-02-18 12:31:46 UTC ---
This has been fixed in 6.0.x and will be included in 6.0.25 onwards.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 48763] AJP Connectors fail when POST requests don't have a Content-Length header

2010-02-18 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=48763

--- Comment #2 from Bruce G. Stewart  2010-02-18 14:07:12 
UTC ---
Created an attachment (id=25015)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25015)
Read the first body chunk of an APR request that has a Transfer-Encoding
header.

A proposed patch against tag/TOMCAT_6_0_24 is attached.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 48763] AJP Connectors fail when POST requests don't have a Content-Length header

2010-02-18 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=48763

--- Comment #3 from Mladen Turk  2010-02-18 14:20:27 UTC ---
OK, So the patch just executes if C-L is zero or not set but T-E is.
Seems reasonable. However I'd make sure the T-E is > 0 like we
are doing with C-L.

If you don't provide a complete patch I'll make something similar
in trunk, so we'll see weather it'll get backported, although I
see why it shouldn't cause it's not just a nice feature, it's a law :) 

Thanks

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 48763] AJP Connectors fail when POST requests don't have a Content-Length header

2010-02-18 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=48763

--- Comment #4 from Mladen Turk  2010-02-18 14:25:32 UTC ---
I meant T-E == chunked obviously :)

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 48767] New: bin/catalina.sh can't stop Tomcat

2010-02-18 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=48767

   Summary: bin/catalina.sh can't stop Tomcat
   Product: Tomcat 6
   Version: 6.0.24
  Platform: PC
OS/Version: Linux
Status: NEW
  Severity: critical
  Priority: P2
 Component: Catalina
AssignedTo: dev@tomcat.apache.org
ReportedBy: t...@jokura.jp


Hi

I trying version 6.0.24, but I'm in trouble.

I started Tomcat by bin/catalina.sh start.
and I tried stop Tomcat by bin/catalina.sh stop.

but Tomcat was not stop.
I counld see the tomcat pid from "ps aux | grep java"

I also tried stop Tomcat by telnet.
I connected to shutdown port(8005) and typed SHUTDOWN.
this way could not stop Tomcat.

trying Tomcat is just downloaded one.
extract package and copy to /usr/local/tomcat6 only.

what's wrong?

see also command history.

[r...@localhost tomcat6]# java -version
java version "1.6.0_18"
Java(TM) SE Runtime Environment (build 1.6.0_18-b07)
Java HotSpot(TM) Client VM (build 16.0-b13, mixed mode, sharing)

[r...@localhost tomcat6]# ./bin/catalina.sh start
Using CATALINA_BASE:   /usr/local/tomcat6
Using CATALINA_HOME:   /usr/local/tomcat6
Using CATALINA_TMPDIR: /usr/local/tomcat6/temp
Using JRE_HOME:/usr/java/jdk
Using CLASSPATH:   /usr/local/tomcat6/bin/bootstrap.jar
[r...@localhost tomcat6]# netstat -na | grep 8005
tcp0  0 127.0.0.1:8005  0.0.0.0:*  
LISTEN  
[r...@localhost tomcat6]# ./bin/catalina.sh stop
Using CATALINA_BASE:   /usr/local/tomcat6
Using CATALINA_HOME:   /usr/local/tomcat6
Using CATALINA_TMPDIR: /usr/local/tomcat6/temp
Using JRE_HOME:/usr/java/jdk
Using CLASSPATH:   /usr/local/tomcat6/bin/bootstrap.jar
Tomcat did not stop in time. PID file was not removed.
[r...@localhost tomcat6]# ps aux | grep java
root 25148 12.6  2.3 1202860 47988 pts/0   Sl   23:20   0:04
/usr/java/jdk/bin/java
-Djava.util.logging.config.file=/usr/local/tomcat6/conf/logging.properties
-Djava.util.logging.manager=org.apache.juli.ClassLoaderLogManager -server
-Djava.awt.headless=true -Djava.net.preferIPv4Stack=true -Xms1024m -Xmx1024m
-XX:-UseConcMarkSweepGC -XX:+AggressiveOpts -XX:SurvivorRatio=8
-XX:NewSize=320m -XX:MaxNewSize=320m
-Djava.endorsed.dirs=/usr/local/tomcat6/endorsed -classpath
/usr/local/tomcat6/bin/bootstrap.jar -Dcatalina.base=/usr/local/tomcat6
-Dcatalina.home=/usr/local/tomcat6 -Djava.io.tmpdir=/usr/local/tomcat6/temp
org.apache.catalina.startup.Bootstrap start
root 25217  0.0  0.0   4992   756 pts/0R+   23:20   0:00 grep java

[r...@localhost tomcat6]# ./bin/catalina.sh start
Using CATALINA_BASE:   /usr/local/tomcat6
Using CATALINA_HOME:   /usr/local/tomcat6
Using CATALINA_TMPDIR: /usr/local/tomcat6/temp
Using JRE_HOME:/usr/java/jdk
Using CLASSPATH:   /usr/local/tomcat6/bin/bootstrap.jar
[r...@localhost tomcat6]# netstat -na | grep 8005
tcp0  0 127.0.0.1:8005  0.0.0.0:*  
LISTEN  
[r...@localhost tomcat6]# ps aux | grep java
root 25076 26.5  2.2 1201704 46792 pts/0   Sl   23:15   0:03
/usr/java/jdk/bin/java
-Djava.util.logging.config.file=/usr/local/tomcat6/conf/logging.properties
-Djava.util.logging.manager=org.apache.juli.ClassLoaderLogManager -server
-Djava.awt.headless=true -Djava.net.preferIPv4Stack=true -Xms1024m -Xmx1024m
-XX:-UseConcMarkSweepGC -XX:+AggressiveOpts -XX:SurvivorRatio=8
-XX:NewSize=320m -XX:MaxNewSize=320m
-Djava.endorsed.dirs=/usr/local/tomcat6/endorsed -classpath
/usr/local/tomcat6/bin/bootstrap.jar -Dcatalina.base=/usr/local/tomcat6
-Dcatalina.home=/usr/local/tomcat6 -Djava.io.tmpdir=/usr/local/tomcat6/temp
org.apache.catalina.startup.Bootstrap start
root 25101  0.0  0.0   4992   768 pts/0R+   23:15   0:00 grep java
[r...@localhost tomcat6]# telnet 127.0.0.1 8005
Trying 127.0.0.1...
Connected to localhost.localdomain (127.0.0.1).
Escape character is '^]'.
SHUTDOWN
Connection closed by foreign host.
[r...@localhost tomcat6]# ps aux | grep java
root 25076  9.4  2.3 1202028 48068 pts/0   Sl   23:15   0:04
/usr/java/jdk/bin/java
-Djava.util.logging.config.file=/usr/local/tomcat6/conf/logging.properties
-Djava.util.logging.manager=org.apache.juli.ClassLoaderLogManager -server
-Djava.awt.headless=true -Djava.net.preferIPv4Stack=true -Xms1024m -Xmx1024m
-XX:-UseConcMarkSweepGC -XX:+AggressiveOpts -XX:SurvivorRatio=8
-XX:NewSize=320m -XX:MaxNewSize=320m
-Djava.endorsed.dirs=/usr/local/tomcat6/endorsed -classpath
/usr/local/tomcat6/bin/bootstrap.jar -Dcatalina.base=/usr/local/tomcat6
-Dcatalina.home=/usr/local/tomcat6 -Djava.io.tmpdir=/usr/local/tomcat6/temp
org.apache.catalina.startup.Bootstrap start
root 25106  0.0  0.0   4992   772 pts/0R+   23:16   0:00 grep java

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-

DO NOT REPLY [Bug 48763] AJP Connectors fail when POST requests don't have a Content-Length header

2010-02-18 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=48763

--- Comment #5 from jfclere  2010-02-18 14:54:11 UTC ---
Do I miss something: In mod_proxy we have:
+++
/* read the first bloc of data */
input_brigade = apr_brigade_create(p, r->connection->bucket_alloc);
tenc = apr_table_get(r->headers_in, "Transfer-Encoding");
if (tenc && (strcasecmp(tenc, "chunked") == 0)) {
/* The AJP protocol does not want body data yet */
ap_log_error(APLOG_MARK, APLOG_DEBUG, 0, r->server,
 "proxy: request is chunked");
} else {
+++
The patch would just block and never get it no?

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 48763] AJP Connectors fail when POST requests don't have a Content-Length header

2010-02-18 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=48763

--- Comment #6 from Remy Maucherat  2010-02-18 14:57:48 UTC ---
Before putting any fix, the question is if the first body message will be
automatically sent (so Jean-Frédéric thinks it is only the case for c-l > 0,
from what I understood).

All AJP implementations must have the same behavior, otherwise this is big
trouble.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 48763] AJP Connectors fail when POST requests don't have a Content-Length header

2010-02-18 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=48763

--- Comment #7 from Mladen Turk  2010-02-18 15:04:10 UTC ---
Right, seems we'll need a descent test case when to issue a read.
However the major problem is that read is issued although not a
valid AJP sequence (no C-L header) and that should be rejected
by the AJP connector instead simply requesting a body chunk from
mod_proxy/mod_jk if Servlet thinks this is valid POST request.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 48763] AJP Connectors fail when POST requests don't have a Content-Length header

2010-02-18 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=48763

--- Comment #8 from Mladen Turk  2010-02-18 15:13:17 UTC ---
Are we supporting T-E chunked with the AJP at the first place.
Seems to me we don't have any filter inserted inside AJP like
we have for HTTP. If not, then T-E=chunked and C-L=0 should
be treated as invalid request and connection dropped to prevent
any further problems.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 48767] bin/catalina.sh can't stop Tomcat

2010-02-18 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=48767

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID

--- Comment #1 from Mark Thomas  2010-02-18 15:21:55 UTC ---
Bugzilla is not a support forum. Please use the users mailing list.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 47242] request for AJP command line client

2010-02-18 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=47242

--- Comment #3 from chamith buddhika  2010-02-18 
15:36:16 UTC ---
Any updates on this? I would like to have a look at this if this is required.
But I would need some advice on AJP and the the use case requirements since I
am relatively new to the project.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r911481 - in /tomcat/trunk/java/org/apache/coyote/ajp: AjpAprProcessor.java AjpProcessor.java

2010-02-18 Thread mturk

Author: mturk
Date: Thu Feb 18 16:44:57 2010
New Revision: 911481

URL: http://svn.apache.org/viewvc?rev=911481&view=rev
Log:
Make sure we favor the values from AjpMessage.processHeader. If the signature 
is invalid len can be any random number in that case

Modified:
tomcat/trunk/java/org/apache/coyote/ajp/AjpAprProcessor.java
tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java

Modified: tomcat/trunk/java/org/apache/coyote/ajp/AjpAprProcessor.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/ajp/AjpAprProcessor.java?rev=911481&r1=911480&r2=911481&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/ajp/AjpAprProcessor.java (original)
+++ tomcat/trunk/java/org/apache/coyote/ajp/AjpAprProcessor.java Thu Feb 18 
16:44:57 2010
@@ -1112,8 +1112,10 @@
 
 first = false;
 bodyMessage.reset();
-readMessage(bodyMessage, false, false);
-
+if (!readMessage(bodyMessage, false, false)) {
+// Invalid message
+return false;
+}
 // No data received.
 if (bodyMessage.getLen() == 0) {
 // just the header
@@ -1182,11 +1184,21 @@
 read(headerLength);
 }
 inputBuffer.get(message.getBuffer(), 0, headerLength);
-message.processHeader();
-read(message.getLen());
-inputBuffer.get(message.getBuffer(), headerLength, message.getLen());
-
-return true;
+int messageLength = message.processHeader();
+if (messageLength < 0) {
+// Invalid AJP header signature
+// TODO: Throw some exception and close the connection to frontend.
+return false;
+}
+else if (messageLength == 0) {
+// Zero length message.
+return true;
+}
+else {
+read(messageLength);
+inputBuffer.get(message.getBuffer(), headerLength, messageLength);
+return true;
+}
 
 }
 

Modified: tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java?rev=911481&r1=911480&r2=911481&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java (original)
+++ tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java Thu Feb 18 
16:44:57 2010
@@ -1062,8 +1062,10 @@
 
 first = false;
 bodyMessage.reset();
-readMessage(bodyMessage);
-
+if (!readMessage(bodyMessage)) {
+// Invalid message
+return false;
+}
 // No data received.
 if (bodyMessage.getLen() == 0) {
 // just the header
@@ -1119,14 +1121,24 @@
 throws IOException {
 
 byte[] buf = message.getBuffer();
+int headerLength = message.getHeaderLength();
 
-read(buf, 0, message.getHeaderLength());
-
-message.processHeader();
-read(buf, message.getHeaderLength(), message.getLen());
-
-return true;
+read(buf, 0, headerLength);
 
+int messageLength = message.processHeader();
+if (messageLength < 0) {
+// Invalid AJP header signature
+// TODO: Throw some exception and close the connection to frontend.
+return false;
+}
+else if (messageLength == 0) {
+// Zero length message.
+return true;
+}
+else {
+read(buf, headerLength, messageLength);
+return true;
+}
 }
 
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 48760] Tomcat breaks in serving large files (>=1.8MB) under high load and high threading.

2010-02-18 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=48760

--- Comment #10 from Stefan Kendall  2010-02-18 17:01:18 
UTC ---
(In reply to comment #9)
> Une cacheObjectMaxSize="0" on the Context element and stop wasting your time
> posting nonsense ...

Remy, your comment does not make sense.

As per the documentation, files over 512KB are not cached (default setting). My
file is 1.8MB large; I stated this in my initial bugpost.

Docs:
http://tomcat.apache.org/tomcat-6.0-doc/config/context.html

Furthermore, I even tried this supposed fix (although it made no sense given
the documentation), and it did not work. The only fix for this issue, still, is
to remove the "optimization" introduced in Tomcat 5-5.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 48600] Performance issue with tags

2010-02-18 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=48600

--- Comment #10 from Remy Maucherat  2010-02-18 17:40:37 UTC 
---
(In reply to comment #9)
> With JBoss 5.0.0 GA, the class 
> org.apache.catalina.core.StandardContext.DummyAnnotationProcessor
> implements an empty processor.
> It's hard coding to use this "special" version.

Yes, but this "implementation" does nothing but delegate to the
InstanceManager, which then does the same things as Tomcat's
AnnotationProcessor (except slightly slower). For some background history, the
AnnotationProcessor interface was replaced with the InstanceManager interface
to also take over the object instance creation.

AS 5 scans injections ahead of time, so it does what your caching does more or
less. The main problem here is that the newer JSP specs made tags non poolable
in many cases, *and* injectable. Not a very good plan ...

BTW, your patch would need some syncs I think.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: jk/cluster - intelligent systems load

2010-02-18 Thread Costin Manolache

On Thu, Feb 18, 2010 at 12:00 AM, jean-frederic clere wrote:

> On 02/17/2010 10:46 PM, Costin Manolache wrote:
> > On Wed, Feb 17, 2010 at 11:58 AM, Mladen Turk  wrote:
> >
> >> On 02/17/2010 07:37 PM, Costin Manolache wrote:
> >>
> >>> On Wed, Feb 17, 2010 at 12:38 AM, Mladen Turk
>  wrote:
> >>>
> >>>
> >>> The reasons I suggest using SPDY as a replacement for AJP - and
> supporting
> >>> SPDY
> >>>
> >>
> >> I have nothing against SPDY and it really looks cool,
> >> but IMHO it's doesn't look and feel like the rest of RFC
> >> protocol specifications.
> >> If you can push those guys to create a well known RFC-like
> >> doc, I'm sure that overall internet community will benefit
> >> from it.
> >>
> >
> > SPDY is still in development - there is an open mailing list and
> > quite a few proposals/changes/discussions. I would guess
> > the end result will end up as a RFC-like. Feel free to join the
> > mailing list and push or volunteer for anything :-)
> >
> > The implementations - chrome, mod_spdy are also open source
> > and with ASF-like license.
> >
> >
> >
> >>
> >> OTOH we are discussing this 'protocol thing' for years instead like
> >> you noticed we concentrate on the tasks we wish to do.
> >> Think if we start from the protocol side we will stay there (nowhere)
> >> for few more years (although SPDY might be even more then we need).
> >
> >
> > I think what matters is having a working SPDY implementation in tomcat,
> > inter-operable
> > with chrome/mod_spdy/google. If we start with this we'll probably make
> > more progress than by discussing protocols :-)
>
> Yep, I have noted that people are preparing an implementation for httpd
> so at some point it will just "porting" that code to TC.
>
>
http://code.google.com/p/mod-spdy/

Costin



> Cheers
>
> Jean-Frederic
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

DO NOT REPLY [Bug 48763] AJP Connectors fail when POST requests don't have a Content-Length header

2010-02-18 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=48763

--- Comment #9 from Bruce G. Stewart  2010-02-18 18:26:40 
UTC ---
I am using the ISAPI_Redirect IIS plugin 1.2.28.0 with IIS Version 7.

I see there is a separate build that offers "chunking transfer support". Would
it solve my problem if I used that without patching Tomcat? Or make things
worse? (I should probably go read the source and leave you guys alone.)

Thanks for your help and attention. I appreciate it.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: jk/cluster - intelligent systems load

2010-02-18 Thread Henri Gomez

If we goes back to the original thread and using Hyperic stuff in a
servlet filter or whatever Tomcat extension ?

Could it be usefull for jk, mod_proxy, mod_cluster ?

Or a specific servlet should/could be provided for such collect
purpose and it Will be called by remote at it's own rate ?

2010/2/18, Costin Manolache :
> On Thu, Feb 18, 2010 at 12:00 AM, jean-frederic clere
> wrote:
>
>> On 02/17/2010 10:46 PM, Costin Manolache wrote:
>> > On Wed, Feb 17, 2010 at 11:58 AM, Mladen Turk  wrote:
>> >
>> >> On 02/17/2010 07:37 PM, Costin Manolache wrote:
>> >>
>> >>> On Wed, Feb 17, 2010 at 12:38 AM, Mladen Turk
>>  wrote:
>> >>>
>> >>>
>> >>> The reasons I suggest using SPDY as a replacement for AJP - and
>> supporting
>> >>> SPDY
>> >>>
>> >>
>> >> I have nothing against SPDY and it really looks cool,
>> >> but IMHO it's doesn't look and feel like the rest of RFC
>> >> protocol specifications.
>> >> If you can push those guys to create a well known RFC-like
>> >> doc, I'm sure that overall internet community will benefit
>> >> from it.
>> >>
>> >
>> > SPDY is still in development - there is an open mailing list and
>> > quite a few proposals/changes/discussions. I would guess
>> > the end result will end up as a RFC-like. Feel free to join the
>> > mailing list and push or volunteer for anything :-)
>> >
>> > The implementations - chrome, mod_spdy are also open source
>> > and with ASF-like license.
>> >
>> >
>> >
>> >>
>> >> OTOH we are discussing this 'protocol thing' for years instead like
>> >> you noticed we concentrate on the tasks we wish to do.
>> >> Think if we start from the protocol side we will stay there (nowhere)
>> >> for few more years (although SPDY might be even more then we need).
>> >
>> >
>> > I think what matters is having a working SPDY implementation in tomcat,
>> > inter-operable
>> > with chrome/mod_spdy/google. If we start with this we'll probably make
>> > more progress than by discussing protocols :-)
>>
>> Yep, I have noted that people are preparing an implementation for httpd
>> so at some point it will just "porting" that code to TC.
>>
>>
> http://code.google.com/p/mod-spdy/
>
> Costin
>
>
>
>> Cheers
>>
>> Jean-Frederic
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>
>>
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 48763] AJP Connectors fail when POST requests don't have a Content-Length header

2010-02-18 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=48763

--- Comment #10 from Mladen Turk  2010-02-18 19:50:04 UTC ---
Isapi chunking is for sending the chunked data.
Won't help you there.
Anyhow your patch is wrong cause it just hides the symptoms.
The real problem is that client EOF is not handled correctly.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 48760] Tomcat breaks in serving large files (>=1.8MB) under high load and high threading.

2010-02-18 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=48760

--- Comment #11 from Stefan Kendall  2010-02-18 20:02:19 
UTC ---
gfuser9...@yahoo.co.uk has presented a reasoned explanation of what is
happening below. Apparently, this is a problem that needs to be backported from
Glassfish.

I've copied the e-mail below:

Now, really the REAL bug fix in Tomcat you need to port 
back from
 Glassfish is actually this 

http://fisheye5.cenqua.com/changelog/glassfish?cs=SJSAS91_FCS_BRANCH%3Asultal%3A20080904082511

This is the actual root cause for 45601 which is not
updated back to Tomcat bug entry in the late 2008 but 
this is the RCA and is fixed in SUN Glassfish Application
server (where they share the same common TC code).

--
Here's the salient point:
--
0. You notice the issue happens in DefaultServlet copyRange
   as all your submitters submit

- The code all do something like this
   InputStream resourceInputStream 
  = cacheEntry.resource.streamContent();

1. So they all take a FileResource/Resource from
   a cache entry  (which is looked up from some cache)

2. Now We know that this is a FileResource (static resource)

3. Finally most of the code will have this

   reader = new
 InputStreamReader(resourceInputStream,
   fileEncoding);
   copyRange(reader,) <-- do something
   reader.close();

4.
 Now, you notice that reader.close() will CLOSE
   the underlying FileInputStream when it is run.

5. Hence, there is a SUBTLE race in FileResource.streamContent
   where a TWO or more threads get the SAME InputStream.
   This is due to the FACT that multiple requests can
   get hold of the same cached entry and hence due to
   the BAD way the FileResource streamContent stuff the
   InputStream to a temp instance variable.. 

   Due to MT scheduling (it is possible to get a MT schedule
   where two threads gets the some common InputStream.)
   [Please see TC code to see why this can happen]

Testing?

It is easy to ARTIFICIALLY reproduce & to confirm
You can slow things down in the
 FileResource.streamContent()
by putting delays and etc (or also printing
the resulting InputStream in the copy while
doing two or more parallel wget for the same
FileResource of filesize of some large MB to see.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 48760] Tomcat breaks in serving large files (>=1.8MB) under high load and high threading.

2010-02-18 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=48760

Mark Thomas  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|DUPLICATE   |

--- Comment #12 from Mark Thomas  2010-02-18 20:26:25 UTC ---
Bingo. That looks like the sort of analysis that is needed to move this
forward. Re-opening to take a look at this potential race condition.

Note that we can't just copy the Glassfish patch without jumping through some
legal licensing hoops that I'd prefer to avoid.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: jk/cluster - intelligent systems load

2010-02-18 Thread Costin Manolache

On Thu, Feb 18, 2010 at 10:57 AM, Henri Gomez  wrote:

> If we goes back to the original thread and using Hyperic stuff in a
> servlet filter or whatever Tomcat extension ?
>
>
Absolutely - a filter would be perfect and will work with any servlet
engine.
There are some problems with making sure this doesn't leak out - i.e.
an X-header inserted by mod_proxy and make sure it filters X-headers
from the response.



> Could it be usefull for jk, mod_proxy, mod_cluster ?
>
> Or a specific servlet should/could be provided for such collect
> purpose and it Will be called by remote at it's own rate ?
>

That would work too, even better - a status servlet, which may provide
additional data, like number of sessions, java memory, etc. Don't we have
one already - dumping all jmx data ? Probably need to output data
in an easier to parse format, and I guess mod_proxy configuration would
be a bit tricky if you want to use multiple variables, but doable.

Costin



>
> 2010/2/18, Costin Manolache :
> > On Thu, Feb 18, 2010 at 12:00 AM, jean-frederic clere
> > wrote:
> >
> >> On 02/17/2010 10:46 PM, Costin Manolache wrote:
> >> > On Wed, Feb 17, 2010 at 11:58 AM, Mladen Turk 
> wrote:
> >> >
> >> >> On 02/17/2010 07:37 PM, Costin Manolache wrote:
> >> >>
> >> >>> On Wed, Feb 17, 2010 at 12:38 AM, Mladen Turk
> >>  wrote:
> >> >>>
> >> >>>
> >> >>> The reasons I suggest using SPDY as a replacement for AJP - and
> >> supporting
> >> >>> SPDY
> >> >>>
> >> >>
> >> >> I have nothing against SPDY and it really looks cool,
> >> >> but IMHO it's doesn't look and feel like the rest of RFC
> >> >> protocol specifications.
> >> >> If you can push those guys to create a well known RFC-like
> >> >> doc, I'm sure that overall internet community will benefit
> >> >> from it.
> >> >>
> >> >
> >> > SPDY is still in development - there is an open mailing list and
> >> > quite a few proposals/changes/discussions. I would guess
> >> > the end result will end up as a RFC-like. Feel free to join the
> >> > mailing list and push or volunteer for anything :-)
> >> >
> >> > The implementations - chrome, mod_spdy are also open source
> >> > and with ASF-like license.
> >> >
> >> >
> >> >
> >> >>
> >> >> OTOH we are discussing this 'protocol thing' for years instead like
> >> >> you noticed we concentrate on the tasks we wish to do.
> >> >> Think if we start from the protocol side we will stay there (nowhere)
> >> >> for few more years (although SPDY might be even more then we need).
> >> >
> >> >
> >> > I think what matters is having a working SPDY implementation in
> tomcat,
> >> > inter-operable
> >> > with chrome/mod_spdy/google. If we start with this we'll probably make
> >> > more progress than by discussing protocols :-)
> >>
> >> Yep, I have noted that people are preparing an implementation for httpd
> >> so at some point it will just "porting" that code to TC.
> >>
> >>
> > http://code.google.com/p/mod-spdy/
> >
> > Costin
> >
> >
> >
> >> Cheers
> >>
> >> Jean-Frederic
> >>
> >> -
> >> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> >> For additional commands, e-mail: dev-h...@tomcat.apache.org
> >>
> >>
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

svn commit: r911601 - /tomcat/trunk/java/org/apache/juli/ClassLoaderLogManager.java

2010-02-18 Thread markt

Author: markt
Date: Thu Feb 18 21:35:48 2010
New Revision: 911601

URL: http://svn.apache.org/viewvc?rev=911601&view=rev
Log:
Comment typo

Modified:
tomcat/trunk/java/org/apache/juli/ClassLoaderLogManager.java

Modified: tomcat/trunk/java/org/apache/juli/ClassLoaderLogManager.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/juli/ClassLoaderLogManager.java?rev=911601&r1=911600&r2=911601&view=diff
==
--- tomcat/trunk/java/org/apache/juli/ClassLoaderLogManager.java (original)
+++ tomcat/trunk/java/org/apache/juli/ClassLoaderLogManager.java Thu Feb 18 
21:35:48 2010
@@ -305,7 +305,7 @@
  * Shuts down the logging system.
  */
 public void shutdown() {
-// The JVM us being shutdown. Make sure all loggers for all class
+// The JVM is being shutdown. Make sure all loggers for all class
 // loaders are shutdown
 for (ClassLoaderLogInfo clLogInfo : classLoaderLoggers.values()) {
 for (Logger logger : clLogInfo.loggers.values()) {



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 47242] request for AJP command line client

2010-02-18 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=47242

--- Comment #4 from Ken Van Camp  2010-02-18 
21:37:38 UTC ---
I have not heard any updates, but I'll give you a little more detail on my use
case: It is frequently useful to be able to test the health of a web server by
making individual requests to it, for instance if receiving reports of server
being unreachable.  We may also wish to institute automated health checks from
a script or third-party software, and it is easy to do both over an HTTP
connection because many tools exist.  Over AJP, however, this is not generally
feasible.

My Tomcat web server is not on the Internet - it sits behind an IIS proxy
server.  Users connect to the IIS proxy over HTTPS, and the proxy communicates
to my Tomcat server over AJP.  When I get reports that my web server is
unreachable via the proxy over HTTPS, my next step is to hit my Tomcat server
over HTTP and verify that's working.  If Tomcat is working properly over HTTP,
but the proxy is not responding over HTTPS, there are still a number of
possible causes, including the proxy server itself, network connectivity
between the proxy and Tomcat, and the AJP connections on Tomcat.  I currently
have no way to directly test Tomcat over AJP - no simple tools exist that I
know of.

There are many possible ways to fill this need - one way I've found useful, and
fairly reusable, in the HTTP world is a simple command line tool like wget,
which is a standard command-line utility in Linux.  It allows me to issue a
simple GET request from the command line, or a script, which may be used to
check the health of my web server, and may be automated.

Wget has a large number of command line options, but all of my use cases could
be satisfied with probably just one of them: a timeout option so the request
doesn't hang there forever if the server is unresponsive.  The only other
parameter I need to give this wget-like AJP utility is the URL I'd like to hit
on Tomcat.

Please let me know if you need any further clarification.  Thanks.
Ken

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 48763] AJP Connectors fail when POST requests don't have a Content-Length header

2010-02-18 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=48763

--- Comment #11 from Bruce G. Stewart  2010-02-18 22:39:32 
UTC ---
If the isapi_redirector is not supposed to send the first body block of such a
message until it receives a get-body message, then the isapi_redirector must be
faulty.

On the very first request, and all that follow, the first body block is
available on the apr socket immediately after the header is read. With short
messages, refillReadBuffer() is never called. With longer ones, the first read
picks up a couple of hundred bytes, and refillReadBuffer gets the rest.

I haven't seen any problem related to the end of request data being mishandled.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 48772] New: Bad information in impl module pom.xml

2010-02-18 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=48772

   Summary: Bad information in impl module pom.xml
   Product: Taglibs
   Version: nightly
  Platform: PC
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: P2
 Component: Standard Taglib
AssignedTo: dev@tomcat.apache.org
ReportedBy: jga...@gmail.com


Created an attachment (id=25021)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25021)
Patch for the pom.xml

The impl/pom.xml in trunk contains invalid  information that causes
a jar file to be created with duplicate classes with bad package names.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 47242] request for AJP command line client

2010-02-18 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=47242

--- Comment #5 from Bill Barker  2010-02-19 04:56:29 UTC 
---
(In reply to comment #3)
> Any updates on this? I would like to have a look at this if this is required.
> But I would need some advice on AJP and the the use case requirements since I
> am relatively new to the project.

As the initial contributor to the JMeter AJP/1.3 Sampler (mentioned by Sebb), I
would look there for a starting point.  That contains all of the Java code to
create an AJP/1.3 client.

Personally, I prefer working with JMeter for this type of low-level connection
analysis, but if you want to create a stand-alone version, knock yourself out.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 48773] New: DataSourceWrapper and DriverManager problems

2010-02-18 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=48773

   Summary: DataSourceWrapper and DriverManager problems
   Product: Taglibs
   Version: nightly
  Platform: PC
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: P2
 Component: Standard Taglib
AssignedTo: dev@tomcat.apache.org
ReportedBy: jga...@gmail.com


Created an attachment (id=25022)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25022)
Patch for this issue.

In certain situations the DataSourceWrapper is not able to connect to the
database even if a driver class name was explicitly set. The core of the
problem is that the DriverManager uses the caller's classloader (in this case
the classloader of DataSourceWrapper) to find a driver for the given url. In
some cases the classloader of DataSourceWrapper might be totally different and
separate from the context classloader that registered the driver with
DriverManager. In these cases the DriverManager will not "see" the driver
registered earlier because of the different classloaders and the
DataSourceWrapper.getConnection() will fail with "unable to find suitable
driver" type of error message.

One easy work solution for this problem is to actually use the driver object
that was registered in setDriverClassName() to connect to the database. And if
the connection fails then fallback to using the DriverManager API.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 48763] AJP Connectors fail when POST requests don't have a Content-Length header

2010-02-18 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=48763

--- Comment #12 from Mladen Turk  2010-02-19 05:27:31 UTC ---
Special first body message is only send if C-L is present as this is defined by
AJP protocol spec.
If it's there without C-L this is faulty and this should be fixed.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 48774] New: DNS Aliasing breaks tomcat session management

2010-02-18 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=48774

   Summary: DNS Aliasing breaks tomcat session management
   Product: Tomcat 6
   Version: unspecified
  Platform: PC
OS/Version: All
Status: NEW
  Severity: enhancement
  Priority: P2
 Component: Catalina
AssignedTo: dev@tomcat.apache.org
ReportedBy: jrop...@gmail.com


One of the big problems that comet applications encounter is the 2 connection
limit of the HTTP specification, which some browsers (eg, IE6 and IE7) adhere
strictly to.  The most common approach to getting around this is DNS aliasing,
where a wildcard DNS record causing all requests for all subdomains of a host
to go to that host.  However, there is no way to configure what domain the
JSESSIONID gets set on, which is always set to the incoming host name.  This
completely breaks Tomcat session management when DNS aliasing is being used.

If tomcat is to support comet (which it does), this seems like a pretty major
hole in its support of it, considering most comet implementations use DNS
aliasing.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r911720 - /tomcat/jk/trunk/tools/jkrelease.sh

2010-02-18 Thread mturk

Author: mturk
Date: Fri Feb 19 07:13:09 2010
New Revision: 911720

URL: http://svn.apache.org/viewvc?rev=911720&view=rev
Log:
Make md5 and sha1 signatures during release

Modified:
tomcat/jk/trunk/tools/jkrelease.sh

Modified: tomcat/jk/trunk/tools/jkrelease.sh
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/tools/jkrelease.sh?rev=911720&r1=911719&r2=911720&view=diff
==
--- tomcat/jk/trunk/tools/jkrelease.sh (original)
+++ tomcat/jk/trunk/tools/jkrelease.sh Fri Feb 19 07:13:09 2010
@@ -292,8 +292,27 @@
 perl ${JK_DIST}/tools/lineends.pl --cr ${JK_DIST}
 zip -9 -r ${JK_DIST}.zip ${JK_DIST}
 
+# Try to locate a MD5 binary
+md5_bin="`which md5sum 2>/dev/null || type md5sum 2>&1`"
+if [ -x "$md5_bin" ]; then
+MD5SUM="$md5_bin --binary "
+else
+MD5SUM="echo  "
+fi
+# Try to locate a SHA1 binary
+sha1_bin="`which sha1sum 2>/dev/null || type sha1sum 2>&1`"
+if [ -x "$sha1_bin" ]; then
+SHA1SUM="$sha1_bin --binary "
+else
+SHA1SUM="echo  "
+fi
 # Create detached signature and verify it
 archive=${JK_DIST}.tar.gz
 sign_and_verify $archive
+$MD5SUM $archive > $archive.md5 
+$SHA1SUM $archive > $archive.sha1 
 archive=${JK_DIST}.zip
 sign_and_verify $archive
+$MD5SUM $archive > $archive.md5 
+$SHA1SUM $archive > $archive.sha1 
+



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r911725 - in /tomcat/jk/trunk/native: iis/Makefile.x86 netscape/Makefile.vc

2010-02-18 Thread mturk

Author: mturk
Date: Fri Feb 19 07:35:47 2010
New Revision: 911725

URL: http://svn.apache.org/viewvc?rev=911725&view=rev
Log:
Embed manifest if generated by cl

Modified:
tomcat/jk/trunk/native/iis/Makefile.x86
tomcat/jk/trunk/native/netscape/Makefile.vc

Modified: tomcat/jk/trunk/native/iis/Makefile.x86
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/iis/Makefile.x86?rev=911725&r1=911724&r2=911725&view=diff
==
--- tomcat/jk/trunk/native/iis/Makefile.x86 (original)
+++ tomcat/jk/trunk/native/iis/Makefile.x86 Fri Feb 19 07:35:47 2010
@@ -110,6 +110,8 @@
 $(LINK32) @<<
   $(LINK32_FLAGS) $(LINK32_OBJS) commode.obj
 <<
+   IF EXIST $(OUTDIR)\isapi_redirect.manifest \
+   mt -nologo -manifest $(OUTDIR)\isapi_redirect.manifest 
-outputresource:$(OUTDIR)\isapi_redirect.dll;2
 
 CPP_PROJ=/nologo /MD /W3 /Zi /O2 /I "..\common" /I "pcre" /I 
"$(JAVA_HOME)\include" /I "$(JAVA_HOME)\include\win32" $(CFLAGS) /D "WIN32" /D 
"NDEBUG" /D "_WINDOWS" /D "JK_ISAPI" /D "ISAPI_EXPORTS" /D "HAS_PCRE" /D 
"PCRE_STATIC" /Fo"$(INTDIR)\\" /Fd"$(INTDIR)\isapi_redirector_src" /FD /c 
 

Modified: tomcat/jk/trunk/native/netscape/Makefile.vc
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/netscape/Makefile.vc?rev=911725&r1=911724&r2=911725&view=diff
==
--- tomcat/jk/trunk/native/netscape/Makefile.vc (original)
+++ tomcat/jk/trunk/native/netscape/Makefile.vc Fri Feb 19 07:35:47 2010
@@ -67,7 +67,7 @@
 if not exist "$(OUTDIR)/$(NULL)" mkdir "$(OUTDIR)"
 
 CPP=cl.exe
-CPP_PROJ=/nologo /MD /W3 /Zi /O2 /I "..\common" /I "$(SUNONE_HOME)\include" /I 
"$(JAVA_HOME)\include" /I "$(JAVA_HOME)\include\win32" /D "WIN32" /D "NDEBUG" 
/D "_WINDOWS" /D "_MBCS" /D "_USRDLL" /D "JK_NSAPI" /D "NSAPI_EXPORTS" /D 
"XP_WIN32" /D "MCC_HTTPD" /D "SPAPI20" /Fo"$(INTDIR)\\" 
/Fd"Release/nsapi_redirect_src" /FD /c 
+CPP_PROJ=/nologo /MD /W3 /Zi /O2 /I "..\common" /I "$(SUNONE_HOME)\include" /I 
"$(JAVA_HOME)\include" /I "$(JAVA_HOME)\include\win32" /D "WIN32" /D "NDEBUG" 
/D "_WINDOWS" /D "_MBCS" /D "_USRDLL" /D "JK_NSAPI" /D "NSAPI_EXPORTS" /D 
"XP_WIN32" /D "MCC_HTTPD" /D "SPAPI20" /Fo"$(INTDIR)\\" 
/Fd"$(OUTDIR)\nsapi_redirect_src" /FD /c 
 
 .c{$(INTDIR)}.obj::
$(CPP) @<<
@@ -136,15 +136,8 @@
 $(LINK32) @<<
   $(LINK32_FLAGS) $(LINK32_OBJS)
 <<
-
-
-!IF "$(NO_EXTERNAL_DEPS)" != "1"
-!IF EXISTS("nsapi.dep")
-!INCLUDE "nsapi.dep"
-!ELSE 
-!MESSAGE Warning: cannot find "nsapi.dep"
-!ENDIF 
-!ENDIF 
+   IF EXIST $(OUTDIR)\nsapi_redirect.manifest \
+   mt -nologo -manifest $(OUTDIR)\nsapi_redirect.manifest 
-outputresource:$(OUTDIR)\nsapi_redirect.dll;2
 
 
 !IF "$(CFG)" == "nsapi - Win32 Release"



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

52 matches

Mail list logo