Re: GSOC 2010
On 12/02/2010 07:21, buddhika chamith wrote: > I am Buddhika Chamith, a final year student from University of Moratuwa, Sri > Lanka. I am hoping to participate in GSOC 2010 program. This would be my > second GSOC. Last year I worked in and successfully completed Apache ODE > project titled "Apache ODE integration in BPELUnit". [1] > > I would be willing to work on Apache Tomcat project this year if you are > planning put any ideas forward. I have experience in developing web > applications with JSP(which I think would be beneficial) and have some > understanding of tomcat internals. (I went through some of the architecture > documentations). Great! It is always good to see people interested in Tomact. > So are there any project ideas being considered as yet for Tomcat this year? Not yet. We need to kick off a discussion on this. > I saw last year projects ideas (regarding JMX, Valves etc). Also are there > any specific areas that I have to be aware in order to work with Tomcat? I can't speak for any other potential mentors (and assuming that some of the Tomcat ideas are accepted for GSOC), but I will not be accepting applications from a student unless they have already provided an acceptable patch for at least one and preferably more currently open, non-trivial bugzilla items (bugs or enhancements). Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Tomcat Wiki] Update of "GSOC" by markt
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "GSOC" page has been changed by markt. http://wiki.apache.org/tomcat/GSOC?action=diff&rev1=2&rev2=3 -- The Tomcat project participated / is participating in the following Google Summers of Code: * [[SummerOfCode2005]] - 2005 * [[SummerOfCode2009]] - 2009 + * [[SummerOfCode2010]] - 2010 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Minor Error in Documentation
Hello folks; I think that there is a minor error in Tomcat 6 documentation ( http://tomcat.apache.org/tomcat-6.0-doc/monitoring.html). It says that to setup JMX remote access you have to add set CATALINA_OPTS="-Dcom.sun.management.jmxremote \ -Dcom.sun.management.jmxremote.port=%my.jmx.port% \ -Dcom.sun.management.jmxremote.ssl=false \ -Dcom.sun.management.jmxremote.authenticate=false" into tomcat startup script. Client does not connect to JMX after adding above setting because quotations marks are put around CATALINA_OPTS=*"* bla ..bla *". *If you remove "" everything works as expected. Thanks; --Gurkan
[Tomcat Wiki] Update of "SummerOfCode2010" by markt
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "SummerOfCode2010" page has been changed by markt. The comment on this change is: Add some initial ideas. http://wiki.apache.org/tomcat/SummerOfCode2010 -- New page: = Google Summer of Code 2010 = == Important Notes == The application process has not yet started. This page is to record possible projects assuming the ASF and the Tomcat project does participate in this year's summer of code. The actual list of projects will be determined as the application process progresses. Anyone is free to add ideas to this list. If you are not a Tomcat committer please do not add a committer as a potential mentor for a project unless they have agreed to do so. == Ideas == ||Title||Mentor||Description|| ||JMX||markt||Update the JMX descriptors to more accurately reflect the properties and methods of the underlying objects, taking particular care about which attributes should be read-only and which read-write. Then add additional functionality as necessary to enable a complete Tomcat instance to be configured entirely via JMX (ie start with a Server with no config and create everythins via JMX).|| ||Security docs||markt||Update the security pages etc to include svn revisions for each fix, update the release notes to include the CVE reference with the fix, update the svn logs to include the CVE reference. This will require a lot of cross-checking to ensure that the correct CVEs and svn references are added, particularly for the older vulnerabilities. This would include the 5.5.x, 6.0.x and 7.0.x code-bases.|| ||JSR196||markt||Provide a JSR196 implementation|| - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [Tomcat Wiki] Update of "SummerOfCode2010" by markt
On 12/02/2010 09:08, Apache Wiki wrote: > Dear Wiki user, > > You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for > change notification. > > The "SummerOfCode2010" page has been changed by markt. > The comment on this change is: Add some initial ideas. Folks - feel free to add your own ideas and to provide feedback on the current ones. The sooner we start this discussion, the better prepared for GSOC2010 we will be. Cheers, Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r909321 - /tomcat/trunk/webapps/docs/monitoring.xml
Author: markt Date: Fri Feb 12 09:58:13 2010 New Revision: 909321 URL: http://svn.apache.org/viewvc?rev=909321&view=rev Log: Remove quotes from example - they break it Modified: tomcat/trunk/webapps/docs/monitoring.xml Modified: tomcat/trunk/webapps/docs/monitoring.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/monitoring.xml?rev=909321&r1=909320&r2=909321&view=diff == --- tomcat/trunk/webapps/docs/monitoring.xml (original) +++ tomcat/trunk/webapps/docs/monitoring.xml Fri Feb 12 09:58:13 2010 @@ -47,10 +47,10 @@ The following is a quick configuration guide for Java 6: Add the following parameters to your Tomcat startup script: -set CATALINA_OPTS="-Dcom.sun.management.jmxremote \ +set CATALINA_OPTS=-Dcom.sun.management.jmxremote \ -Dcom.sun.management.jmxremote.port=%my.jmx.port% \ -Dcom.sun.management.jmxremote.ssl=false \ --Dcom.sun.management.jmxremote.authenticate=false" +-Dcom.sun.management.jmxremote.authenticate=false - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r909322 - /tomcat/tc6.0.x/trunk/webapps/docs/monitoring.xml
Author: markt Date: Fri Feb 12 09:58:40 2010 New Revision: 909322 URL: http://svn.apache.org/viewvc?rev=909322&view=rev Log: Remove quotes from example - they break it Modified: tomcat/tc6.0.x/trunk/webapps/docs/monitoring.xml Modified: tomcat/tc6.0.x/trunk/webapps/docs/monitoring.xml URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/monitoring.xml?rev=909322&r1=909321&r2=909322&view=diff == --- tomcat/tc6.0.x/trunk/webapps/docs/monitoring.xml (original) +++ tomcat/tc6.0.x/trunk/webapps/docs/monitoring.xml Fri Feb 12 09:58:40 2010 @@ -47,10 +47,10 @@ The following is a quick configuration guide for Java 5: Add the following parameters to your Tomcat startup script: -set CATALINA_OPTS="-Dcom.sun.management.jmxremote \ +set CATALINA_OPTS=-Dcom.sun.management.jmxremote \ -Dcom.sun.management.jmxremote.port=%my.jmx.port% \ -Dcom.sun.management.jmxremote.ssl=false \ --Dcom.sun.management.jmxremote.authenticate=false" +-Dcom.sun.management.jmxremote.authenticate=false - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r909324 - /tomcat/tc5.5.x/trunk/container/webapps/docs/monitoring.xml
Author: markt Date: Fri Feb 12 09:59:09 2010 New Revision: 909324 URL: http://svn.apache.org/viewvc?rev=909324&view=rev Log: Remove quotes from example - they break it Modified: tomcat/tc5.5.x/trunk/container/webapps/docs/monitoring.xml Modified: tomcat/tc5.5.x/trunk/container/webapps/docs/monitoring.xml URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/container/webapps/docs/monitoring.xml?rev=909324&r1=909323&r2=909324&view=diff == --- tomcat/tc5.5.x/trunk/container/webapps/docs/monitoring.xml (original) +++ tomcat/tc5.5.x/trunk/container/webapps/docs/monitoring.xml Fri Feb 12 09:59:09 2010 @@ -47,10 +47,10 @@ For quick installation you find here a short installation guide: Add the following parameters to your tomcat startup script: -set CATALINA_OPTS="-Dcom.sun.management.jmxremote \ +set CATALINA_OPTS=-Dcom.sun.management.jmxremote \ -Dcom.sun.management.jmxremote.port=%my.jmx.port% \ -Dcom.sun.management.jmxremote.ssl=false \ --Dcom.sun.management.jmxremote.authenticate=false" +-Dcom.sun.management.jmxremote.authenticate=false - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Minor Error in Documentation
On 12/02/2010 08:57, Gurkan Erdogdu wrote: > Hello folks; > > I think that there is a minor error in Tomcat 6 documentation ( > http://tomcat.apache.org/tomcat-6.0-doc/monitoring.html). It says that to > setup JMX remote access you have to add > > set CATALINA_OPTS="-Dcom.sun.management.jmxremote \ > -Dcom.sun.management.jmxremote.port=%my.jmx.port% \ > -Dcom.sun.management.jmxremote.ssl=false \ > -Dcom.sun.management.jmxremote.authenticate=false" > > into tomcat startup script. Client does not connect to JMX after adding > above setting because quotations marks are put around CATALINA_OPTS=*"* bla > ..bla *". *If you remove "" everything works as expected. Thanks - fixed in trunk, 6.0.x and 5.5.x Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Minor Error in Documentation
2010/2/12 Mark Thomas :
> Thanks - fixed in trunk, 6.0.x and 5.5.x
That example is a mix of Windows and Unix syntaxes.
On Windows 1) no quotes, 2) "\" is not supported as continuation character
On Unix 1) "set " is not needed and is indeed a different command.
You just do the assignment. Quotes are needed. 2) %my.jmx.port% will
be ${my.jmx.port}
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Tomcat Wiki] Update of "SummerOfCode2010" by JeanFrede ricClere
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "SummerOfCode2010" page has been changed by JeanFredericClere. http://wiki.apache.org/tomcat/SummerOfCode2010?action=diff&rev1=1&rev2=2 -- ||JMX||markt||Update the JMX descriptors to more accurately reflect the properties and methods of the underlying objects, taking particular care about which attributes should be read-only and which read-write. Then add additional functionality as necessary to enable a complete Tomcat instance to be configured entirely via JMX (ie start with a Server with no config and create everythins via JMX).|| ||Security docs||markt||Update the security pages etc to include svn revisions for each fix, update the release notes to include the CVE reference with the fix, update the svn logs to include the CVE reference. This will require a lot of cross-checking to ensure that the correct CVEs and svn references are added, particularly for the older vulnerabilities. This would include the 5.5.x, 6.0.x and 7.0.x code-bases.|| ||JSR196||markt||Provide a JSR196 implementation|| + ||SPDY||jfclere||Create Connector that supports the SPDY protocol (Seehttp://dev.chromium.org/spdy/spdy-whitepaper) || - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Minor Error in Documentation
On 12/02/2010 10:40, Konstantin Kolinko wrote:
> 2010/2/12 Mark Thomas :
>> Thanks - fixed in trunk, 6.0.x and 5.5.x
>
> That example is a mix of Windows and Unix syntaxes.
>
> On Windows 1) no quotes, 2) "\" is not supported as continuation character
My assumption was that the continuation character was used to indicate
that the line was broken up over several lines but should be on a single
one. A long single line is going to look horrible in a browser. I agree
this might not be clear to readers.
> On Unix 1) "set " is not needed and is indeed a different command.
> You just do the assignment. Quotes are needed. 2) %my.jmx.port% will
> be ${my.jmx.port}
I think the example is meant to be Windows.
Mark
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Tomcat Wiki] Update of "SummerOfCode2010" by Konstanti nKolinko
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "SummerOfCode2010" page has been changed by KonstantinKolinko. The comment on this change is: correct links. http://wiki.apache.org/tomcat/SummerOfCode2010?action=diff&rev1=2&rev2=3 -- == Ideas == ||Title||Mentor||Description|| - ||JMX||markt||Update the JMX descriptors to more accurately reflect the properties and methods of the underlying objects, taking particular care about which attributes should be read-only and which read-write. Then add additional functionality as necessary to enable a complete Tomcat instance to be configured entirely via JMX (ie start with a Server with no config and create everythins via JMX).|| + ||JMX||markt||Update the JMX descriptors to more accurately reflect the properties and methods of the underlying objects, taking particular care about which attributes should be read-only and which read-write. Then add additional functionality as necessary to enable a complete Tomcat instance to be configured entirely via JMX (ie start with a Server with no config and create everything via JMX).|| ||Security docs||markt||Update the security pages etc to include svn revisions for each fix, update the release notes to include the CVE reference with the fix, update the svn logs to include the CVE reference. This will require a lot of cross-checking to ensure that the correct CVEs and svn references are added, particularly for the older vulnerabilities. This would include the 5.5.x, 6.0.x and 7.0.x code-bases.|| - ||JSR196||markt||Provide a JSR196 implementation|| + ||JSR196||markt||Provide a [[http://jcp.org/en/jsr/detail?id=196|JSR196]] implementation|| - ||SPDY||jfclere||Create Connector that supports the SPDY protocol (Seehttp://dev.chromium.org/spdy/spdy-whitepaper) || + ||SPDY||jfclere||Create Connector that supports the SPDY protocol (See [[http://dev.chromium.org/spdy/spdy-whitepaper]]) || - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r909097 - in /tomcat/trunk/java/org/apache/catalina/loader: LocalStrings.properties WebappClassLoader.java
On 12/02/2010 02:52, Bill Barker wrote:
>
>
> wrote in message
> news:20100211180956.bfd5f2388...@eris.apache.org...
>> Author: markt
>> Date: Thu Feb 11 18:09:08 2010
>> New Revision: 909097
>>
>> URL: http://svn.apache.org/viewvc?rev=909097&view=rev
>> Log:
>> Improved memory leak prevention for resource ResourceBundle
>> +private void clearReferencesResourceBundles() {
>> +// Get a reference to the cache
>> +try {
>> +Field cacheListField =
>> +ResourceBundle.class.getDeclaredField("cacheList");
>> +cacheListField.setAccessible(true);
>> +
>
> I don't see anywhere in the documentation that says that there is a
> cacheList field. Have you tried this with a non-Sun JVM?
It works with the 1.6.0 SR7 64-bit JDK on linux from IBM. I haven't
tested any further.
Granted it is undocumented, but most of the memory leak protection
involves using reflection to dig at internals that aren't normally
exposed there is always going to be a risk. This should be fairly same
as we don't need to dig too far to get to what we need.
Mark
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r909097 - in /tomcat/trunk/java/org/apache/catalina/loader: LocalStrings.properties WebappClassLoader.java
On 12/02/2010 12:32, Mark Thomas wrote:
> On 12/02/2010 02:52, Bill Barker wrote:
>>
>>
>> wrote in message
>> news:20100211180956.bfd5f2388...@eris.apache.org...
>>> Author: markt
>>> Date: Thu Feb 11 18:09:08 2010
>>> New Revision: 909097
>>>
>>> URL: http://svn.apache.org/viewvc?rev=909097&view=rev
>>> Log:
>>> Improved memory leak prevention for resource ResourceBundle
>
>
>
>>> +private void clearReferencesResourceBundles() {
>>> +// Get a reference to the cache
>>> +try {
>>> +Field cacheListField =
>>> +ResourceBundle.class.getDeclaredField("cacheList");
>>> +cacheListField.setAccessible(true);
>>> +
>>
>> I don't see anywhere in the documentation that says that there is a
>> cacheList field. Have you tried this with a non-Sun JVM?
>
> It works with the 1.6.0 SR7 64-bit JDK on linux from IBM. I haven't
> tested any further.
I take that back. It looks like I get an error. Not sure why my first
test missed it. I'll see what I can do to handle that more gracefully.
Mark
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
jk/cluster - intelligent systems load
Hi to all, Some times ago, we discuss about mod_jk/cluster and more intelligent strategy to be use for the dispatching system. One point was to get system load informations about the various Tomcat instances involved in a cluster, to send request to the lowest loaded Tomcat. Hyperic Sigar, http://www.hyperic.com/products/sigar.html, seems to provide such informations for various OS. Could it be interesting to add such 'extension' to Tomcat, so it could be able to send back to jk/cluster so they could get the best decisions ? New commands could be added to AJP13, as done previously with cping/cpong, http://tomcat.apache.org/connectors-doc/ajp/ajpv13ext.html. What do you think about ? - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: jk/cluster - intelligent systems load
On 12/02/2010 15:20, Henri Gomez wrote: > Hi to all, > > Some times ago, we discuss about mod_jk/cluster and more intelligent > strategy to be use for the dispatching system. > > One point was to get system load informations about the various Tomcat > instances involved in a cluster, to send request to the lowest loaded > Tomcat. > > Hyperic Sigar, http://www.hyperic.com/products/sigar.html, seems to > provide such informations for various OS. > > Could it be interesting to add such 'extension' to Tomcat, so it could > be able to send back to jk/cluster so they could get the best > decisions ? > > New commands could be added to AJP13, as done previously with > cping/cpong, http://tomcat.apache.org/connectors-doc/ajp/ajpv13ext.html. > > What do you think about ? I like the general idea. My personal favourite in terms of implementation is to pass the information via response headers as it allows interoperability with the widest possible range of front-end load balancers. The info can be passed back with every request or only for requests to a particular URL. Then you get into how you measure load. I don't think that there will be a one size fits all solution. I imagine that it would need to be fairly easy for folks to implement their own load measurements. Using response headers makes that simple to do providing we get the definition of that header format right. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r909525 - /tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java
Author: markt
Date: Fri Feb 12 17:49:49 2010
New Revision: 909525
URL: http://svn.apache.org/viewvc?rev=909525&view=rev
Log:
Looks like the ResourceBundle leaks are triggered by a GC bug - only seems to
affect Sun JVMs.
The fix is also Sun specific so only log a debug message if the internal field
can't be found on a non-Sun JVM (it isn't there for IBM for example)
Modified:
tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java
Modified: tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java?rev=909525&r1=909524&r2=909525&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java Fri Feb
12 17:49:49 2010
@@ -1782,6 +1782,10 @@
}
// Clear the resource bundle cache
+// This shouldn't be necessary, the cache uses weak references but
+// it has caused leaks. Oddly, using the leak detection code in
+// standard host allows the class loader to be GC'd. This has been seen
+// on Sun but not IBM JREs. Maybe a bug in Sun's GC impl?
clearReferencesResourceBundles();
// Clear the classloader reference in the VM's bean introspector
@@ -2395,8 +2399,13 @@
log.error(sm.getString(
"webappClassLoader.clearReferencesResourceBundlesFail"),
e);
} catch (NoSuchFieldException e) {
-log.error(sm.getString(
-"webappClassLoader.clearReferencesResourceBundlesFail"),
e);
+if (System.getProperty("java.vendor").startsWith("Sun")) {
+log.error(sm.getString(
+"webappClassLoader.clearReferencesResourceBundlesFail"), e);
+} else {
+log.debug(sm.getString(
+"webappClassLoader.clearReferencesResourceBundlesFail"), e);
+}
} catch (IllegalArgumentException e) {
log.error(sm.getString(
"webappClassLoader.clearReferencesResourceBundlesFail"),
e);
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r909526 - /tomcat/trunk/java/org/apache/catalina/core/StandardHost.java
Author: markt
Date: Fri Feb 12 17:50:22 2010
New Revision: 909526
URL: http://svn.apache.org/viewvc?rev=909526&view=rev
Log:
Make class loader registration more robust
Modified:
tomcat/trunk/java/org/apache/catalina/core/StandardHost.java
Modified: tomcat/trunk/java/org/apache/catalina/core/StandardHost.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/StandardHost.java?rev=909526&r1=909525&r2=909526&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/StandardHost.java (original)
+++ tomcat/trunk/java/org/apache/catalina/core/StandardHost.java Fri Feb 12
17:50:22 2010
@@ -30,7 +30,10 @@
import org.apache.catalina.Container;
import org.apache.catalina.Context;
import org.apache.catalina.Host;
+import org.apache.catalina.Lifecycle;
+import org.apache.catalina.LifecycleEvent;
import org.apache.catalina.LifecycleException;
+import org.apache.catalina.LifecycleListener;
import org.apache.catalina.Valve;
import org.apache.catalina.loader.WebappClassLoader;
import org.apache.catalina.startup.HostConfig;
@@ -579,17 +582,33 @@
throw new IllegalArgumentException
(sm.getString("standardHost.notContext"));
super.addChild(child);
-
-// Record a reference to the context's class loader to aid memory leak
-// detection
-if (child.getLoader() != null) {
-childClassLoaders.put(child.getLoader().getClassLoader(),
-child.getName());
+
+if (child instanceof Lifecycle) {
+((Lifecycle) child).addLifecycleListener(
+new MemoryLeakTrackingListener());
}
}
/**
+ * Used to ensure the regardless of {...@link Context} implementation, a
record
+ * is kept of the class loader used every time a context starts.
+ */
+private class MemoryLeakTrackingListener implements LifecycleListener {
+@Override
+public void lifecycleEvent(LifecycleEvent event) {
+if (event.getType().equals(Lifecycle.AFTER_START_EVENT)) {
+if (event.getSource() instanceof Context) {
+Context context = ((Context) event.getSource());
+childClassLoaders.put(context.getLoader().getClassLoader(),
+context.getServletContext().getContextPath());
+}
+}
+}
+}
+
+
+/**
* Attempt to identify the contexts that have a class loader memory leak.
* This is usually triggered on context reload. Note: This method attempts
* to force a full garbage collection. This should be used with extreme
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r909528 - in /tomcat/trunk/java/org/apache/catalina/manager: HTMLManagerServlet.java LocalStrings.properties ManagerServlet.java
Author: markt
Date: Fri Feb 12 17:51:06 2010
New Revision: 909528
URL: http://svn.apache.org/viewvc?rev=909528&view=rev
Log:
Add a find leaks option - with a suitable warning to the manager app (html &
text)
Modified:
tomcat/trunk/java/org/apache/catalina/manager/HTMLManagerServlet.java
tomcat/trunk/java/org/apache/catalina/manager/LocalStrings.properties
tomcat/trunk/java/org/apache/catalina/manager/ManagerServlet.java
Modified: tomcat/trunk/java/org/apache/catalina/manager/HTMLManagerServlet.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/manager/HTMLManagerServlet.java?rev=909528&r1=909527&r2=909528&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/manager/HTMLManagerServlet.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/manager/HTMLManagerServlet.java Fri
Feb 12 17:51:06 2010
@@ -218,6 +218,8 @@
message = start(path);
} else if (command.equals("/stop")) {
message = stop(path);
+} else if (command.equals("/findleaks")) {
+message = findleaks();
} else {
// Try GET
doGet(request,response);
@@ -616,6 +618,17 @@
args[4] = newNonce;
writer.print(MessageFormat.format(UPLOAD_SECTION, args));
+// Diagnostics section
+args = new Object[6];
+args[0] = sm.getString("htmlManagerServlet.diagnosticsTitle");
+args[1] = sm.getString("htmlManagerServlet.diagnosticsLeak");
+args[2] = response.encodeURL(
+request.getContextPath() + "/html/findleaks");
+args[3] = newNonce;
+args[4] = sm.getString("htmlManagerServlet.diagnosticsLeakWarning");
+args[5] = sm.getString("htmlManagerServlet.diagnosticsLeakButton");
+writer.print(MessageFormat.format(DIAGNOSTICS_SECTION, args));
+
// Server Header Section
args = new Object[7];
args[0] = sm.getString("htmlManagerServlet.serverTitle");
@@ -751,6 +764,33 @@
}
/**
+ * Find potential memory leaks caused by web application reload.
+ *
+ * @see ManagerServlet#findleaks(PrintWriter)
+ *
+ * @return message String
+ */
+protected String findleaks() {
+
+StringBuilder msg = new StringBuilder();
+
+StringWriter stringWriter = new StringWriter();
+PrintWriter printWriter = new PrintWriter(stringWriter);
+
+super.findleaks(printWriter);
+
+if (stringWriter.getBuffer().length() > 0) {
+msg.append(sm.getString("htmlManagerServlet.findleaksList"));
+msg.append(stringWriter.toString());
+} else {
+msg.append(sm.getString("htmlManagerServlet.findleaksNone"));
+}
+
+return msg.toString();
+}
+
+
+/**
* @see javax.servlet.Servlet#getServletInfo()
*/
@Override
@@ -1126,7 +1166,7 @@
" \n" +
" \n" +
" \n" +
-" " +
" {10} {12} \n" +
" \n" +
" \n" +
@@ -1137,11 +1177,11 @@
" \n" +
" {1} \n" +
" " +
-" " +
" " +
" \n" +
" " +
-" " +
" " +
" \n" +
" " +
@@ -1153,7 +1193,7 @@
" \n" +
" \n" +
" \n" +
-" " +
" {10} {12} \n" +
" \n" +
" \n" +
@@ -1163,13 +1203,13 @@
private static final String STOPPED_DEPLOYED_APPS_ROW_BUTTON_SECTION =
" \n" +
" " +
-" " +
" " +
" \n" +
" {3} \n" +
" {5} \n" +
" " +
-" " +
" " +
" \n" +
" \n" +
@@ -1179,11 +1219,11 @@
" \n" +
" {1} \n" +
" " +
-" " +
" " +
" \n" +
" " +
-" " +
" " +
" \n" +
" {7} \n" +
@@ -1193,7 +1233,7 @@
private static final String STOPPED_NONDEPLOYED_APPS_ROW_BUTTON_SECTION =
" \n" +
" " +
-" " +
" " +
" \n" +
" {3} \n" +
@@ -1215,7 +1255,7 @@
"\n" +
" \n" +
"\n" +
-"" +
"\n" +
"\n" +
" \n" +
@@ -1285,4 +1325,31 @@
"\n" +
"\n";
+private static final String DIAGNOSTICS_SECTION =
+"\n" +
+"\n" +
+" {0}\n" +
+"\n" +
+"\n" +
+" {1}\n" +
+"\n" +
+"\n" +
+" \n" +
+"\n" +
+"" +
+"\n" +
+"\n" +
+" \n" +
+" \n" +
+" \n" +
+" \n" +
+" {4}\n" +
+" \n" +
+"\n" +
+"\n" +
+"\n" +
+"\n" +
+"\n" +
+"\n" +
+"";
}
Modified: tomcat/trunk/java/org/apache/catalina/manager/LocalStrings.properties
URL:
http://svn
svn commit: r909542 - in /tomcat/trunk/webapps/docs: html-manager-howto.xml manager-howto.xml
Author: markt Date: Fri Feb 12 18:03:48 2010 New Revision: 909542 URL: http://svn.apache.org/viewvc?rev=909542&view=rev Log: Document new findleaks command Modified: tomcat/trunk/webapps/docs/html-manager-howto.xml tomcat/trunk/webapps/docs/manager-howto.xml Modified: tomcat/trunk/webapps/docs/html-manager-howto.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/html-manager-howto.xml?rev=909542&r1=909541&r2=909542&view=diff == --- tomcat/trunk/webapps/docs/html-manager-howto.xml (original) +++ tomcat/trunk/webapps/docs/html-manager-howto.xml Fri Feb 12 18:03:48 2010 @@ -36,7 +36,7 @@ Tomcat. This document is for the HTML web interface to the web application manager. -The interface is divided into five sections: +The interface is divided into six sections: Message - Displays success and failure messages. Manager - General manager operations like list and @@ -44,6 +44,7 @@ Applications - List of web applications and commands. Deploy - Deploying web applications. + Diagnostocs - Identifying potential problems. Server Information - Information about the Tomcat server. @@ -546,6 +547,19 @@ + + +The find leaks diagnostic triggers a full garbage collection. It +should be used with extreme caution on production systems. + +The find leaks diagnostic attempts to identify web applications that have +caused memory leaks when they were reloaded. Results should always be confirmed +with a profiler. The diagnostic uses additional functionality provided by the +StandardHost implementation. It will not work if a custom host is used that +does not extend StandardHost. + + + This section displays information about Tomcat, the operating system of Modified: tomcat/trunk/webapps/docs/manager-howto.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/manager-howto.xml?rev=909542&r1=909541&r2=909542&view=diff == --- tomcat/trunk/webapps/docs/manager-howto.xml (original) +++ tomcat/trunk/webapps/docs/manager-howto.xml Fri Feb 12 18:03:48 2010 @@ -51,6 +51,8 @@ Stop an Existing Application Undeploy an Existing Application +Server Status +Finding memory leaks Executing Manager Commands With Ant @@ -891,6 +893,35 @@ + + + +http://localhost:8080/manager/text/findleaks + + +The find leaks diagnostic triggers a full garbage collection. It +should be used with extreme caution on production systems. + +The find leaks diagnostic attempts to identify web applications that have +caused memory leaks when they were reloaded. Results should always be confirmed +with a profiler. The diagnostic uses additional functionality provided by the +StandardHost implementation. It will not work if a custom host is used that +does not extend StandardHost. + +If this command succeeds, you will see a response like this: + +/leaking-webapp + + +Each context path for a web application that is believed to have triggered a +memory leak when it was reloaded will be listed on a new line. If an application +has been reloaded several times, it may be listed several times. + +If the command does not succeed, the response will start with +FAIL and include an error message. + + + From this link , you can view information about the server. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r909563 - /tomcat/trunk/java/org/apache/catalina/core/StandardHost.java
Author: markt
Date: Fri Feb 12 19:15:32 2010
New Revision: 909563
URL: http://svn.apache.org/viewvc?rev=909563&view=rev
Log:
Add listener before child is added else listener won't get called on first load
Modified:
tomcat/trunk/java/org/apache/catalina/core/StandardHost.java
Modified: tomcat/trunk/java/org/apache/catalina/core/StandardHost.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/StandardHost.java?rev=909563&r1=909562&r2=909563&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/StandardHost.java (original)
+++ tomcat/trunk/java/org/apache/catalina/core/StandardHost.java Fri Feb 12
19:15:32 2010
@@ -578,15 +578,16 @@
@Override
public void addChild(Container child) {
+if (child instanceof Lifecycle) {
+((Lifecycle) child).addLifecycleListener(
+new MemoryLeakTrackingListener());
+}
+
if (!(child instanceof Context))
throw new IllegalArgumentException
(sm.getString("standardHost.notContext"));
super.addChild(child);
-if (child instanceof Lifecycle) {
-((Lifecycle) child).addLifecycleListener(
-new MemoryLeakTrackingListener());
-}
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r909573 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Fri Feb 12 19:31:07 2010 New Revision: 909573 URL: http://svn.apache.org/viewvc?rev=909573&view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=909573&r1=909572&r2=909573&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Fri Feb 12 19:31:07 2010 @@ -313,7 +313,8 @@ -1: * More memory leak prevent - ResourceBundle - http://svn.apache.org/viewvc?rev=909097&view=rev + http://svn.apache.org/viewvc?rev=909097&view=rev (original) + http://svn.apache.org/viewvc?rev=909525&view=rev (improvements) +1: markt -1: @@ -323,3 +324,8 @@ http://svn.apache.org/viewvc?rev=909212&view=rev +1: kkolinko -1: + +* Memory leak detection for JMX and manager + http://people.apache.org/~markt/patches/2010-02-12-memory-leak-detection.patch + +1: markt + -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r909613 - /tomcat/trunk/.classpath
Author: markt Date: Fri Feb 12 21:34:20 2010 New Revision: 909613 URL: http://svn.apache.org/viewvc?rev=909613&view=rev Log: Update for new Eclipse lib Align with new trunk build script Modified: tomcat/trunk/.classpath Modified: tomcat/trunk/.classpath URL: http://svn.apache.org/viewvc/tomcat/trunk/.classpath?rev=909613&r1=909612&r2=909613&view=diff == --- tomcat/trunk/.classpath (original) +++ tomcat/trunk/.classpath Fri Feb 12 21:34:20 2010 @@ -4,12 +4,11 @@ - - + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r909636 - /tomcat/trunk/java/org/apache/catalina/servlets/WebdavServlet.java
Author: markt
Date: Fri Feb 12 22:12:48 2010
New Revision: 909636
URL: http://svn.apache.org/viewvc?rev=909636&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48318
Handle case where WebDAV resource is in directory listing but is not accessible
Modified:
tomcat/trunk/java/org/apache/catalina/servlets/WebdavServlet.java
Modified: tomcat/trunk/java/org/apache/catalina/servlets/WebdavServlet.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/servlets/WebdavServlet.java?rev=909636&r1=909635&r2=909636&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/servlets/WebdavServlet.java (original)
+++ tomcat/trunk/java/org/apache/catalina/servlets/WebdavServlet.java Fri Feb
12 22:12:48 2010
@@ -2039,6 +2039,11 @@
return;
CacheEntry cacheEntry = resources.lookupCache(path);
+if (!cacheEntry.exists) {
+ // File is in directory listing but doesn't appear to exist
+ // Broken symlink or odd permission settings?
+ return;
+}
generatedXML.writeElement(null, "response", XMLWriter.OPENING);
String status = new String("HTTP/1.1 " + WebdavStatus.SC_OK + " "
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r909637 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Fri Feb 12 22:15:54 2010 New Revision: 909637 URL: http://svn.apache.org/viewvc?rev=909637&view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=909637&r1=909636&r2=909637&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Fri Feb 12 22:15:54 2010 @@ -329,3 +329,10 @@ http://people.apache.org/~markt/patches/2010-02-12-memory-leak-detection.patch +1: markt -1: + +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48318 + Handle case where WebDAV resource is in directory listing but is not + accessible + http://svn.apache.org/viewvc?rev=909636&view=rev + +1: markt + -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48318] WebDAV servlet returns 500 if files not readable
https://issues.apache.org/bugzilla/show_bug.cgi?id=48318 --- Comment #1 from Mark Thomas 2010-02-12 22:16:32 UTC --- This has been fixed in trunk and proposed for 6.0.x -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48323] AccessControlException on AJP connector, in security mode
https://issues.apache.org/bugzilla/show_bug.cgi?id=48323 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #2 from Mark Thomas 2010-02-12 23:17:31 UTC --- This works for me with the latest 6.0.x. I suspect the fix for bug47963 refactored the code in such a way as to avoid this issue. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r909652 - in /tomcat/site/trunk: docs/lists.html xdocs/lists.xml
Author: kkolinko Date: Fri Feb 12 23:17:59 2010 New Revision: 909652 URL: http://svn.apache.org/viewvc?rev=909652&view=rev Log: Add a reference to the ASF Public Forum Archive Policy Modified: tomcat/site/trunk/docs/lists.html tomcat/site/trunk/xdocs/lists.xml Modified: tomcat/site/trunk/docs/lists.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/lists.html?rev=909652&r1=909651&r2=909652&view=diff == --- tomcat/site/trunk/docs/lists.html (original) +++ tomcat/site/trunk/docs/lists.html Fri Feb 12 23:17:59 2010 @@ -297,6 +297,8 @@ The http://wiki.apache.org/tomcat/FAQ";>FAQ and http://wiki.apache.org/tomcat/HowTo";>How To pages are available at the http://wiki.apache.org/tomcat/";>Tomcat Wiki. + Usage of these mailing lists is subject to the + http://www.apache.org/foundation/public-archives.html";>Public Forum Archive Policy. Modified: tomcat/site/trunk/xdocs/lists.xml URL: http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/lists.xml?rev=909652&r1=909651&r2=909652&view=diff == --- tomcat/site/trunk/xdocs/lists.xml (original) +++ tomcat/site/trunk/xdocs/lists.xml Fri Feb 12 23:17:59 2010 @@ -86,6 +86,8 @@ The http://wiki.apache.org/tomcat/FAQ";>FAQ and http://wiki.apache.org/tomcat/HowTo";>How To pages are available at the http://wiki.apache.org/tomcat/";>Tomcat Wiki. + Usage of these mailing lists is subject to the + http://www.apache.org/foundation/public-archives.html";>Public Forum Archive Policy. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r909659 - in /tomcat/site/trunk/xdocs: getinvolved.xml lists.xml stylesheets/project.xml
Author: kkolinko Date: Fri Feb 12 23:32:55 2010 New Revision: 909659 URL: http://svn.apache.org/viewvc?rev=909659&view=rev Log: Update links to Tomcat Wiki in the site menu and on several pages. Those links should be not http://wiki.apache.org/tomcat but http://wiki.apache.org/tomcat/ I am using a direct link to http://wiki.apache.org/tomcat/FrontPage instead of the above, because i18n is misconfigured in our MoinMoin and backfires - see https://issues.apache.org/jira/browse/INFRA-2251 Modified: tomcat/site/trunk/xdocs/getinvolved.xml tomcat/site/trunk/xdocs/lists.xml tomcat/site/trunk/xdocs/stylesheets/project.xml Modified: tomcat/site/trunk/xdocs/getinvolved.xml URL: http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/getinvolved.xml?rev=909659&r1=909658&r2=909659&view=diff == --- tomcat/site/trunk/xdocs/getinvolved.xml (original) +++ tomcat/site/trunk/xdocs/getinvolved.xml Fri Feb 12 23:32:55 2010 @@ -18,7 +18,7 @@ Answer questions posted to the mailing lists. Contribute to the http://wiki.apache.org/tomcat/FAQ";>FAQ or - http://wiki.apache.org/tomcat";>Wiki. + http://wiki.apache.org/tomcat/FrontPage";>Wiki. Contribute other documentation patches, either for the website or for the Apache Tomcat user documentation. http://issues.apache.org/bugzilla";>Investigate bugs that have Modified: tomcat/site/trunk/xdocs/lists.xml URL: http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/lists.xml?rev=909659&r1=909658&r2=909659&view=diff == --- tomcat/site/trunk/xdocs/lists.xml (original) +++ tomcat/site/trunk/xdocs/lists.xml Fri Feb 12 23:32:55 2010 @@ -85,7 +85,7 @@ archives (links are below) are also searchable. The http://wiki.apache.org/tomcat/FAQ";>FAQ and http://wiki.apache.org/tomcat/HowTo";>How To pages - are available at the http://wiki.apache.org/tomcat/";>Tomcat Wiki. + are available at the http://wiki.apache.org/tomcat/FrontPage";>Tomcat Wiki. Usage of these mailing lists is subject to the http://www.apache.org/foundation/public-archives.html";>Public Forum Archive Policy. Modified: tomcat/site/trunk/xdocs/stylesheets/project.xml URL: http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/stylesheets/project.xml?rev=909659&r1=909658&r2=909659&view=diff == --- tomcat/site/trunk/xdocs/stylesheets/project.xml (original) +++ tomcat/site/trunk/xdocs/stylesheets/project.xml Fri Feb 12 23:32:55 2010 @@ -40,7 +40,7 @@ -http://wiki.apache.org/tomcat"/> +http://wiki.apache.org/tomcat/FrontPage"/> - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r909660 - /tomcat/site/trunk/docs/
Author: kkolinko Date: Fri Feb 12 23:38:27 2010 New Revision: 909660 URL: http://svn.apache.org/viewvc?rev=909660&view=rev Log: Followup to r909659 - updating the generated pages. Modified: tomcat/site/trunk/docs/bugreport.html tomcat/site/trunk/docs/contact.html tomcat/site/trunk/docs/download-55.html tomcat/site/trunk/docs/download-60.html tomcat/site/trunk/docs/download-connectors.html tomcat/site/trunk/docs/download-native.html tomcat/site/trunk/docs/findhelp.html tomcat/site/trunk/docs/getinvolved.html tomcat/site/trunk/docs/heritage.html tomcat/site/trunk/docs/index.html tomcat/site/trunk/docs/irc.html tomcat/site/trunk/docs/legal.html tomcat/site/trunk/docs/lists.html tomcat/site/trunk/docs/migration.html tomcat/site/trunk/docs/oldnews.html tomcat/site/trunk/docs/resources.html tomcat/site/trunk/docs/security-3.html tomcat/site/trunk/docs/security-4.html tomcat/site/trunk/docs/security-5.html tomcat/site/trunk/docs/security-6.html tomcat/site/trunk/docs/security-7.html tomcat/site/trunk/docs/security-impact.html tomcat/site/trunk/docs/security-jk.html tomcat/site/trunk/docs/security-native.html tomcat/site/trunk/docs/security.html tomcat/site/trunk/docs/svn.html tomcat/site/trunk/docs/whichversion.html tomcat/site/trunk/docs/whoweare.html Modified: tomcat/site/trunk/docs/bugreport.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/bugreport.html?rev=909660&r1=909659&r2=909660&view=diff == --- tomcat/site/trunk/docs/bugreport.html (original) +++ tomcat/site/trunk/docs/bugreport.html Fri Feb 12 23:38:27 2010 @@ -138,7 +138,7 @@ Mailing Lists -http://wiki.apache.org/tomcat";>Wiki +http://wiki.apache.org/tomcat/FrontPage";>Wiki Modified: tomcat/site/trunk/docs/contact.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/contact.html?rev=909660&r1=909659&r2=909660&view=diff == --- tomcat/site/trunk/docs/contact.html (original) +++ tomcat/site/trunk/docs/contact.html Fri Feb 12 23:38:27 2010 @@ -137,7 +137,7 @@ Mailing Lists -http://wiki.apache.org/tomcat";>Wiki +http://wiki.apache.org/tomcat/FrontPage";>Wiki Modified: tomcat/site/trunk/docs/download-55.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/download-55.html?rev=909660&r1=909659&r2=909660&view=diff == --- tomcat/site/trunk/docs/download-55.html (original) +++ tomcat/site/trunk/docs/download-55.html Fri Feb 12 23:38:27 2010 @@ -137,7 +137,7 @@ Mailing Lists -http://wiki.apache.org/tomcat";>Wiki +http://wiki.apache.org/tomcat/FrontPage";>Wiki Modified: tomcat/site/trunk/docs/download-60.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/download-60.html?rev=909660&r1=909659&r2=909660&view=diff == --- tomcat/site/trunk/docs/download-60.html (original) +++ tomcat/site/trunk/docs/download-60.html Fri Feb 12 23:38:27 2010 @@ -137,7 +137,7 @@ Mailing Lists -http://wiki.apache.org/tomcat";>Wiki +http://wiki.apache.org/tomcat/FrontPage";>Wiki Modified: tomcat/site/trunk/docs/download-connectors.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/download-connectors.html?rev=909660&r1=909659&r2=909660&view=diff == --- tomcat/site/trunk/docs/download-connectors.html (original) +++ tomcat/site/trunk/docs/download-connectors.html Fri Feb 12 23:38:27 2010 @@ -137,7 +137,7 @@ Mailing Lists -http://wiki.apache.org/tomcat";>Wiki +http://wiki.apache.org/tomcat/FrontPage";>Wiki Modified: tomcat/site/trunk/docs/download-native.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/download-native.html?rev=909660&r1=909659&r2=909660&view=diff == --- tomcat/site/trunk/docs/download-native.html (original) +++ tomcat/site/trunk/docs/download-native.html Fri Feb 12 23:38:27 2010 @@ -3,17 +3,17 @@ Apache Tomcat - Tomcat Native Downloads - - + + - - + + http://tomcat.apache.org/";> - + @@ -24,28 +24,28 @@ http://www.apache.org/";> -http://www.apache.org/images/asf-logo.gif"; /> +http://www.apache.org/images/asf-logo.gif"; align="right" alt="Apache Logo" border="0"/> -http://www.google.com/search";> - - - +http://www.google.com/search"; method="get"> + + + - + - + - + Apache Tomcat @@ -137,7 +137,7 @@ Mailing Lists -http://wiki.apache.org/tomcat";>Wiki +http://wiki.apache.org/tomcat/FrontPage";>Wiki @@ -171,11 +171,11 @@ - - + + - + Tomcat Native Downloads @@ -199,10 +199,10 @@ Recent releases
Re: svn commit: r907390 - in /tomcat/site/trunk: docs/whoweare.html xdocs/whoweare.xml
2010/2/11 Mark Thomas : > On 07/02/2010 07:33, t...@apache.org wrote: >> Author: timw >> Date: Sun Feb 7 07:33:25 2010 >> New Revision: 907390 >> >> URL: http://svn.apache.org/viewvc?rev=907390&view=rev >> Log: >> Adding timw to committers list. > > Tim when you did svn up on people.a.o you didn't set your umask first. > You are now the only person that can modify this file. Please can you do > a chmod g+w on that file so anyone in the Tomcat group can update it. > > Cheers, > > Mark > SVN ignores those permissions. I just updated that file (in r909660) and it just let me to do so, regardless of -rw-r--r-- mode of it. Note, that the .svn/entries file even has -r--r--r-- on it, but is updated by svn. Still, having umask 002 in your .profile is recommended. Mark, please update the group owner for the tomcat-5.5-doc symlink. It is owned by your private group (markt) right now. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r909673 - /tomcat/trunk/java/org/apache/catalina/connector/Connector.java
Author: fhanik
Date: Sat Feb 13 00:51:47 2010
New Revision: 909673
URL: http://svn.apache.org/viewvc?rev=909673&view=rev
Log:
fix compilation error
Modified:
tomcat/trunk/java/org/apache/catalina/connector/Connector.java
Modified: tomcat/trunk/java/org/apache/catalina/connector/Connector.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/Connector.java?rev=909673&r1=909672&r2=909673&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/connector/Connector.java (original)
+++ tomcat/trunk/java/org/apache/catalina/connector/Connector.java Sat Feb 13
00:51:47 2010
@@ -539,7 +539,7 @@
/**
* Return the port number on which we listen for requests.
- */
+ /
public int getPort() {
return (this.port);
@@ -558,6 +558,10 @@
setProperty("port", String.valueOf(port));
}
+
+public int getPort() {
+return this.port;
+}
/**
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r909673 - /tomcat/trunk/java/org/apache/catalina/connector/Connector.java
2010/2/13 :
> Author: fhanik
> Date: Sat Feb 13 00:51:47 2010
> New Revision: 909673
>
> URL: http://svn.apache.org/viewvc?rev=909673&view=rev
> Log:
> fix compilation error
>
> Modified:
> tomcat/trunk/java/org/apache/catalina/connector/Connector.java
>
What is this? The new code is equivalent to the old one, but with a
broken javadoc comment.
> Modified: tomcat/trunk/java/org/apache/catalina/connector/Connector.java
> URL:
> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/Connector.java?rev=909673&r1=909672&r2=909673&view=diff
> ==
> --- tomcat/trunk/java/org/apache/catalina/connector/Connector.java (original)
> +++ tomcat/trunk/java/org/apache/catalina/connector/Connector.java Sat Feb 13
> 00:51:47 2010
> @@ -539,7 +539,7 @@
>
> /**
> * Return the port number on which we listen for requests.
> - */
> + /
> public int getPort() {
>
> return (this.port);
> @@ -558,6 +558,10 @@
> setProperty("port", String.valueOf(port));
>
> }
> +
> + public int getPort() {
> + return this.port;
> + }
>
>
> /**
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
