Re: svn commit: r881414 - in /tomcat: tc5.5.x/trunk/STATUS.txt tc6.0.x/trunk/STATUS.txt

2009-11-22 Thread Mark Thomas
Konstantin Kolinko wrote:
> 2009/11/17  :
>> Author: markt
>> Date: Tue Nov 17 17:57:23 2009
>> New Revision: 881414
>>
>> +
>> +* Update to commons-pool 1.5.4
>> +  http://svn.apache.org/viewvc?rev=881412&view=rev
>> +  +1: markt
>> +  -1:
>>
> 
> Just a note: 1.5.4 is not yet available for download.

This is now available.

Mark




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: svn commit: r882320 - in /tomcat/trunk/java/org/apache/tomcat/util/net/jsse: JSSESocketFactory.java JSSESupport.java

2009-11-22 Thread Mark Thomas
Mark Thomas wrote:
> Bill Barker wrote:
>> This looks like it should work (haven't tested it yet), but hoping that 
>> there are people that can test on non-Sun JVMs to see if there could be 
>> problems.  This patch is a little heavy on knowing how the JVM implements 
>> things :(.
> 
> Yes, I was testing on a recent Sun 1.6 JVM. I just tested this with a
> recent 1.6 IBM JVM with the same results so things are looking good.
> 
> I've got access to some HP-UX boxes via work so I'll test it on that too
> and report back.

HP-UX works with this patch too.

Mark




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r883119 - /tomcat/trunk/dist.xml

2009-11-22 Thread markt
Author: markt
Date: Sun Nov 22 18:59:06 2009
New Revision: 883119

URL: http://svn.apache.org/viewvc?rev=883119&view=rev
Log:
Remove old comment

Modified:
tomcat/trunk/dist.xml

Modified: tomcat/trunk/dist.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/dist.xml?rev=883119&r1=883118&r2=883119&view=diff
==
--- tomcat/trunk/dist.xml (original)
+++ tomcat/trunk/dist.xml Sun Nov 22 18:59:06 2009
@@ -69,8 +69,6 @@
   
   
 
-  
-
   
   
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r883125 - /tomcat/trunk/dist.xml

2009-11-22 Thread markt
Author: markt
Date: Sun Nov 22 19:18:19 2009
New Revision: 883125

URL: http://svn.apache.org/viewvc?rev=883125&view=rev
Log: (empty)

Modified:
tomcat/trunk/dist.xml

Modified: tomcat/trunk/dist.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/dist.xml?rev=883125&r1=883124&r2=883125&view=diff
==
--- tomcat/trunk/dist.xml (original)
+++ tomcat/trunk/dist.xml Sun Nov 22 19:18:19 2009
@@ -77,6 +77,28 @@
 
   
 
+  
+  
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+  
+
   
   
@@ -590,6 +612,10 @@
 
   
   
+
+  
+
 
   
 
@@ -602,9 +628,10 @@
 
   
   
-
+
+  
+
 
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn propchange: r883125 - svn:log

2009-11-22 Thread markt
Author: markt
Revision: 883125
Modified property: svn:log

Modified: svn:log at Sun Nov 22 19:28:06 2009
--
--- svn:log (original)
+++ svn:log Sun Nov 22 19:28:06 2009
@@ -0,0 +1,3 @@
+Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47609
+Implment fail-safe EOL conversion for source disributions
+Based on a patch provided by sebb


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r883129 - in /tomcat: tc5.5.x/trunk/STATUS.txt tc6.0.x/trunk/STATUS.txt

2009-11-22 Thread markt
Author: markt
Date: Sun Nov 22 19:31:36 2009
New Revision: 883129

URL: http://svn.apache.org/viewvc?rev=883129&view=rev
Log:
Proposal

Modified:
tomcat/tc5.5.x/trunk/STATUS.txt
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc5.5.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=883129&r1=883128&r2=883129&view=diff
==
--- tomcat/tc5.5.x/trunk/STATUS.txt (original)
+++ tomcat/tc5.5.x/trunk/STATUS.txt Sun Nov 22 19:31:36 2009
@@ -258,3 +258,10 @@
   http://people.apache.org/~markt/patches/2009-11-20-cve2009-3555-v2.patch
   +1: markt
   -1: 
+
+* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47609
+  Implment fail-safe EOL conversion for source disributions
+  Based on a patch provided by sebb
+  http://svn.apache.org/viewvc?rev=883125&view=rev
+  +1: markt
+  -1: 

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=883129&r1=883128&r2=883129&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Sun Nov 22 19:31:36 2009
@@ -413,3 +413,9 @@
   +1: fhanik
   -1: 
 
+* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47609
+  Implment fail-safe EOL conversion for source disributions
+  Based on a patch provided by sebb
+  http://svn.apache.org/viewvc?rev=883125&view=rev
+  +1: markt
+  -1: 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 47609] Failsafe EOL conversion

2009-11-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47609

--- Comment #6 from Mark Thomas  2009-11-22 11:31:59 GMT ---
Modified patch applied to trunk and proposed for 6.0.x and 5.5.x

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r883130 - /tomcat/trunk/java/org/apache/catalina/session/ManagerBase.java

2009-11-22 Thread markt
Author: markt
Date: Sun Nov 22 19:39:33 2009
New Revision: 883130

URL: http://svn.apache.org/viewvc?rev=883130&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47718
Correct file descriptor leak on context reload/stop
Patch provided by George Sexton

Modified:
tomcat/trunk/java/org/apache/catalina/session/ManagerBase.java

Modified: tomcat/trunk/java/org/apache/catalina/session/ManagerBase.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/session/ManagerBase.java?rev=883130&r1=883129&r2=883130&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/session/ManagerBase.java (original)
+++ tomcat/trunk/java/org/apache/catalina/session/ManagerBase.java Sun Nov 22 
19:39:33 2009
@@ -709,6 +709,15 @@
 public void destroy() {
 if( oname != null )
 Registry.getRegistry(null, null).unregisterComponent(oname);
+if (randomIS!=null) {
+try {
+randomIS.close();
+} catch (IOException ioe) {
+log.warn("Failed to close randomIS.");
+}
+randomIS=null;
+}
+
 initialized=false;
 oname = null;
 }



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r883131 - in /tomcat: tc5.5.x/trunk/STATUS.txt tc6.0.x/trunk/STATUS.txt

2009-11-22 Thread markt
Author: markt
Date: Sun Nov 22 19:41:33 2009
New Revision: 883131

URL: http://svn.apache.org/viewvc?rev=883131&view=rev
Log:
Proposal

Modified:
tomcat/tc5.5.x/trunk/STATUS.txt
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc5.5.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=883131&r1=883130&r2=883131&view=diff
==
--- tomcat/tc5.5.x/trunk/STATUS.txt (original)
+++ tomcat/tc5.5.x/trunk/STATUS.txt Sun Nov 22 19:41:33 2009
@@ -265,3 +265,11 @@
   http://svn.apache.org/viewvc?rev=883125&view=rev
   +1: markt
   -1: 
+
+* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47718
+  Correct file descriptor leak on context stop/reload
+  Patch provided by George Sexton
+  http://svn.apache.org/viewvc?rev=883130&view=rev
+  +1: markt
+  -1: 
+  
\ No newline at end of file

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=883131&r1=883130&r2=883131&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Sun Nov 22 19:41:33 2009
@@ -419,3 +419,10 @@
   http://svn.apache.org/viewvc?rev=883125&view=rev
   +1: markt
   -1: 
+
+* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47718
+  Correct file descriptor leak on context stop/reload
+  Patch provided by George Sexton
+  http://svn.apache.org/viewvc?rev=883130&view=rev
+  +1: markt
+  -1: 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 47718] ManagerBase leaks fd to /dev/urandom when context stopped

2009-11-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47718

--- Comment #2 from Mark Thomas  2009-11-22 11:41:38 GMT ---
Many thanks for the patch. It has been applied to trunk and proposed for 6.0.x
and 5.5.x

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r883134 - /tomcat/trunk/java/org/apache/catalina/core/NamingContextListener.java

2009-11-22 Thread markt
Author: markt
Date: Sun Nov 22 19:59:51 2009
New Revision: 883134

URL: http://svn.apache.org/viewvc?rev=883134&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47997
Process changes to the naming resources for all JNDI contexts, not just the 
global one.
Patch by Michael Allman

Modified:
tomcat/trunk/java/org/apache/catalina/core/NamingContextListener.java

Modified: tomcat/trunk/java/org/apache/catalina/core/NamingContextListener.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/NamingContextListener.java?rev=883134&r1=883133&r2=883134&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/NamingContextListener.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/core/NamingContextListener.java Sun 
Nov 22 19:59:51 2009
@@ -239,6 +239,8 @@
 (sm.getString("naming.namingContextCreationFailed", e));
 }
 
+namingResources.addPropertyChangeListener(this);
+
 // Binding the naming context to the class loader
 if (container instanceof Context) {
 // Setting the context in read only mode
@@ -253,7 +255,6 @@
 }
 
 if (container instanceof Server) {
-namingResources.addPropertyChangeListener(this);
 org.apache.naming.factory.ResourceLinkFactory.setGlobalContext
 (namingContext);
 try {
@@ -448,9 +449,7 @@
 
 
 /**
- * Process property change events.  Currently, only listens to such events
- * on the NamingResources instance for the global naming
- * resources.
+ * Process property change events.
  *
  * @param event The property change event that has occurred
  */
@@ -481,7 +480,7 @@
 
 
 /**
- * Process a property change on the global naming resources, by making the
+ * Process a property change on the naming resources, by making the
  * corresponding addition or removal to the associated JNDI context.
  *
  * @param name Property name of the change to be processed
@@ -492,9 +491,6 @@
   Object oldValue,
   Object newValue) {
 
-// NOTE - It seems that the Context for global JNDI resources
-// is left in read-write mode, so we do not have to change it here
-
 if (name.equals("ejb")) {
 if (oldValue != null) {
 ContextEjb ejb = (ContextEjb) oldValue;



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r883135 - in /tomcat: tc5.5.x/trunk/STATUS.txt tc6.0.x/trunk/STATUS.txt

2009-11-22 Thread markt
Author: markt
Date: Sun Nov 22 20:02:18 2009
New Revision: 883135

URL: http://svn.apache.org/viewvc?rev=883135&view=rev
Log:
Proposal

Modified:
tomcat/tc5.5.x/trunk/STATUS.txt
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc5.5.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=883135&r1=883134&r2=883135&view=diff
==
--- tomcat/tc5.5.x/trunk/STATUS.txt (original)
+++ tomcat/tc5.5.x/trunk/STATUS.txt Sun Nov 22 20:02:18 2009
@@ -272,4 +272,9 @@
   http://svn.apache.org/viewvc?rev=883130&view=rev
   +1: markt
   -1: 
-  
\ No newline at end of file
+  
+* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47997
+  Process changes for all naming contexts, not just the global one
+  http://svn.apache.org/viewvc?rev=883134&view=rev
+  +1: markt
+  -1: 

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=883135&r1=883134&r2=883135&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Sun Nov 22 20:02:18 2009
@@ -426,3 +426,9 @@
   http://svn.apache.org/viewvc?rev=883130&view=rev
   +1: markt
   -1: 
+
+* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47997
+  Process changes for all naming contexts, not just the global one
+  http://svn.apache.org/viewvc?rev=883134&view=rev
+  +1: markt
+  -1: 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 47997] NamingContextListener fails to add itself as a PropertyChangeListener to all namingResources

2009-11-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47997

--- Comment #2 from Mark Thomas  2009-11-22 12:02:47 GMT ---
Thanks for the patch. It has been applied to trunk and proposed for 6.0.x and
5.5.x

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 47998] NamingResourcesMBean.removeResource(String) is defective

2009-11-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47998

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID

--- Comment #1 from Mark Thomas  2009-11-22 12:32:11 GMT ---
NamingResourcesMBean.addResource() calls
MBeanUtils.createObjectName(String,ContextResource) which does use
ObjectName.quote()

If is possible that there are some code paths that miss this. If you have a
test case that demonstrates an issue here, please reopen this issue,
describe/attach your test case and someone will take a look. If a patch is
required, I suspect it will be slightly different to the one proposed here.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r883145 - /tomcat/trunk/java/org/apache/catalina/startup/WebRuleSet.java

2009-11-22 Thread markt
Author: markt
Date: Sun Nov 22 20:44:09 2009
New Revision: 883145

URL: http://svn.apache.org/viewvc?rev=883145&view=rev
Log:
Fix some Eclipse warnings

Modified:
tomcat/trunk/java/org/apache/catalina/startup/WebRuleSet.java

Modified: tomcat/trunk/java/org/apache/catalina/startup/WebRuleSet.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/startup/WebRuleSet.java?rev=883145&r1=883144&r2=883145&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/startup/WebRuleSet.java (original)
+++ tomcat/trunk/java/org/apache/catalina/startup/WebRuleSet.java Sun Nov 22 
20:44:09 2009
@@ -631,6 +631,7 @@
 final class SetLoginConfig extends Rule {
 protected boolean isLoginConfigSet = false;
 public SetLoginConfig() {
+// NO-OP
 }
 
 @Override
@@ -653,6 +654,7 @@
 final class SetJspConfig extends Rule {
 protected boolean isJspConfigSet = false;
 public SetJspConfig() {
+// NO-OP
 }
 
 @Override
@@ -675,6 +677,7 @@
 final class SetSessionConfig extends Rule {
 protected boolean isSessionConfigSet = false;
 public SetSessionConfig() {
+// NO-OP
 }
 
 @Override
@@ -698,6 +701,7 @@
 final class SetAuthConstraintRule extends Rule {
 
 public SetAuthConstraintRule() {
+// NO-OP
 }
 
 @Override
@@ -723,6 +727,7 @@
 final class SetDistributableRule extends Rule {
 
 public SetDistributableRule() {
+// NO-OP
 }
 
 @Override
@@ -789,6 +794,7 @@
 final class ServletDefCreateRule extends Rule {
 
 public ServletDefCreateRule() {
+// NO-OP
 }
 
 @Override
@@ -946,6 +952,7 @@
 final class IgnoreAnnotationsRule extends Rule {
 
 public IgnoreAnnotationsRule() {
+// NO-OP
 }
 
 @Override
@@ -971,6 +978,7 @@
 final class AbsoluteOrderingRule extends Rule {
 
 public AbsoluteOrderingRule() {
+// NO-OP
 }
 
 @Override
@@ -987,6 +995,7 @@
 final class RelativeOrderingRule extends Rule {
 
 public RelativeOrderingRule() {
+// NO-OP
 }
 
 @Override
@@ -1004,6 +1013,7 @@
 final class SoapHeaderRule extends Rule {
 
 public SoapHeaderRule() {
+// NO-OP
 }
 
 /**
@@ -1039,6 +1049,7 @@
 final class ServiceQnameRule extends Rule {
 
 public ServiceQnameRule() {
+// NO-OP
 }
 
 /**



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 47998] NamingResourcesMBean.removeResource(String) is defective

2009-11-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47998

--- Comment #2 from Michael Allman  2009-11-22 12:48:00 UTC ---
Ok.  Looks like I was calling "removeResource" with a name I built, not the
name I got back from "addResource".  My bad.

Thanks for the feedback.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r883146 - /tomcat/trunk/java/org/apache/catalina/startup/WebRuleSet.java

2009-11-22 Thread markt
Author: markt
Date: Sun Nov 22 20:49:04 2009
New Revision: 883146

URL: http://svn.apache.org/viewvc?rev=883146&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47453
Need to be able to override metadata complete if set in the global web.xml
Patch provided by Keiichi Fujino

Modified:
tomcat/trunk/java/org/apache/catalina/startup/WebRuleSet.java

Modified: tomcat/trunk/java/org/apache/catalina/startup/WebRuleSet.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/startup/WebRuleSet.java?rev=883146&r1=883145&r2=883146&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/startup/WebRuleSet.java (original)
+++ tomcat/trunk/java/org/apache/catalina/startup/WebRuleSet.java Sun Nov 22 
20:49:04 2009
@@ -962,6 +962,8 @@
 String value = attributes.getValue("metadata-complete");
 if ("true".equals(value)) {
 webxml.setMetadataComplete(true);
+} else if ("false".equals(value)) {
+webxml.setMetadataComplete(false);
 }
 if (digester.getLogger().isDebugEnabled()) {
 digester.getLogger().debug



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r883147 - in /tomcat: tc5.5.x/trunk/STATUS.txt tc6.0.x/trunk/STATUS.txt

2009-11-22 Thread markt
Author: markt
Date: Sun Nov 22 20:51:52 2009
New Revision: 883147

URL: http://svn.apache.org/viewvc?rev=883147&view=rev
Log:
Proposal

Modified:
tomcat/tc5.5.x/trunk/STATUS.txt
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc5.5.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=883147&r1=883146&r2=883147&view=diff
==
--- tomcat/tc5.5.x/trunk/STATUS.txt (original)
+++ tomcat/tc5.5.x/trunk/STATUS.txt Sun Nov 22 20:51:52 2009
@@ -278,3 +278,10 @@
   http://svn.apache.org/viewvc?rev=883134&view=rev
   +1: markt
   -1: 
+
+* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47453
+  Need to be able to override metadata complete if set in the global web.xml
+  Patch provided by Keiichi Fujino
+  http://svn.apache.org/viewvc?rev=883146&view=rev
+  +1: markt
+  -1: 

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=883147&r1=883146&r2=883147&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Sun Nov 22 20:51:52 2009
@@ -432,3 +432,10 @@
   http://svn.apache.org/viewvc?rev=883134&view=rev
   +1: markt
   -1: 
+
+* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47453
+  Need to be able to override metadata complete if set in the global web.xml
+  Patch provided by Keiichi Fujino
+  http://svn.apache.org/viewvc?rev=883146&view=rev
+  +1: markt
+  -1: 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 47462] The annotation doesn't become effective.(metadata-complete="false" is not effective.)

2009-11-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47462

--- Comment #1 from Mark Thomas  2009-11-22 12:52:02 GMT ---
Thanks for the patch. It has been applied to trunk and proposed for 5.5.x and
6.0.x

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Tomcat Wiki] Update of "Tomcat/UTF-8" by JuanGarcia

2009-11-22 Thread Apache Wiki
Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change 
notification.

The "Tomcat/UTF-8" page has been changed by JuanGarcia.
The comment on this change is: Properly propagate the exception if there is a 
dangerous misconfiguration.
http://wiki.apache.org/tomcat/Tomcat/UTF-8?action=diff&rev1=12&rev2=13

--

 }
 catch(UnsupportedEncodingException e)
 {
+ throw new RuntimeException(e);
- //  TODO: This should never happen. The UnsupportedEncodingException
- // should be propagated instead of swallowed. This error would indicate
- // a severe misconfiguration of the JVM.
- 
- // As we can't translate just send back the best guess.
- System.out.println("UnsupportedEncodingException is: " +
- e.getMessage());
- utf8String = isoString;
 }
}
else

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 47554] o.a.c.h.s.JvmRouteBinderValve doesn't set HttpOnly flag to session Cookie.

2009-11-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47554

--- Comment #4 from Mark Thomas  2009-11-22 14:07:11 GMT ---
This was fixed in trunk in r802146

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 47554] o.a.c.h.s.JvmRouteBinderValve doesn't set HttpOnly flag to session Cookie.

2009-11-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47554

Mark Thomas  changed:

   What|Removed |Added

  Attachment #24013|0   |1
is obsolete||
  Attachment #24014|0   |1
is obsolete||

--- Comment #5 from Mark Thomas  2009-11-22 14:15:02 GMT ---
Created an attachment (id=24585)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24585)
Update patch for 6.0.x

The provided patch for 6.0.x doe snot update the debug log message. An updated
patch is attached which will be proposed for 6.0.x and 5.5.x

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r883154 - in /tomcat: tc5.5.x/trunk/STATUS.txt tc6.0.x/trunk/STATUS.txt

2009-11-22 Thread markt
Author: markt
Date: Sun Nov 22 22:16:32 2009
New Revision: 883154

URL: http://svn.apache.org/viewvc?rev=883154&view=rev
Log:
Proposal

Modified:
tomcat/tc5.5.x/trunk/STATUS.txt
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc5.5.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=883154&r1=883153&r2=883154&view=diff
==
--- tomcat/tc5.5.x/trunk/STATUS.txt (original)
+++ tomcat/tc5.5.x/trunk/STATUS.txt Sun Nov 22 22:16:32 2009
@@ -285,3 +285,9 @@
   http://svn.apache.org/viewvc?rev=883146&view=rev
   +1: markt
   -1: 
+
+* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47554
+  httpOnly flag not applied to migrated session cookie
+  https://issues.apache.org/bugzilla/show_bug.cgi?id=47554
+  +1: markt
+  -1: 

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=883154&r1=883153&r2=883154&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Sun Nov 22 22:16:32 2009
@@ -439,3 +439,9 @@
   http://svn.apache.org/viewvc?rev=883146&view=rev
   +1: markt
   -1: 
+
+* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47554
+  httpOnly flag not applied to migrated session cookie
+  https://issues.apache.org/bugzilla/show_bug.cgi?id=47554
+  +1: markt
+  -1: 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 47626] File of directory which referred by symbolic link was deleted.

2009-11-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47626

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WONTFIX

--- Comment #4 from Mark Thomas  2009-11-22 14:19:00 GMT ---
Agree with Tim.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 47626] File of directory which referred by symbolic link was deleted.

2009-11-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47626

--- Comment #5 from Mark Thomas  2009-11-22 14:20:14 GMT ---
Note that Tomcat 7 includes alias support that provides a safe way of doing
this sort of thing.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 47655] NullPointerException in MimeHeaders

2009-11-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47655

Mark Thomas  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution||INVALID

--- Comment #6 from Mark Thomas  2009-11-22 14:21:04 GMT ---
No response in three months, assume it was an app issue.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r883165 - in /tomcat/trunk/java/org/apache/catalina/tribes: group/interceptors/DomainFilterInterceptor.java membership/McastService.java

2009-11-22 Thread markt
Author: markt
Date: Sun Nov 22 22:37:43 2009
New Revision: 883165

URL: http://svn.apache.org/viewvc?rev=883165&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47799
Unable to configure domain in Membership and DomainFilterInterceptor
Patch provided by Keiichi Fujino

Modified:

tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/DomainFilterInterceptor.java
tomcat/trunk/java/org/apache/catalina/tribes/membership/McastService.java

Modified: 
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/DomainFilterInterceptor.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/DomainFilterInterceptor.java?rev=883165&r1=883164&r2=883165&view=diff
==
--- 
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/DomainFilterInterceptor.java
 (original)
+++ 
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/DomainFilterInterceptor.java
 Sun Nov 22 22:37:43 2009
@@ -104,4 +104,13 @@
 public void setDomain(byte[] domain) {
 this.domain = domain;
 }
+
+public void setDomain(String domain) {
+if ( domain == null ) return;
+if (domain.startsWith("{"))
+
setDomain(org.apache.catalina.tribes.util.Arrays.fromString(domain));
+   else
+setDomain(org.apache.catalina.tribes.util.Arrays.convert(domain));
+}
+
 }

Modified: 
tomcat/trunk/java/org/apache/catalina/tribes/membership/McastService.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/membership/McastService.java?rev=883165&r1=883164&r2=883165&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/tribes/membership/McastService.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/tribes/membership/McastService.java 
Sun Nov 22 22:37:43 2009
@@ -30,6 +30,7 @@
 import org.apache.catalina.tribes.MessageListener;
 import org.apache.catalina.tribes.io.ChannelData;
 import org.apache.catalina.tribes.io.XByteBuffer;
+import org.apache.catalina.tribes.util.Arrays;
 import org.apache.catalina.tribes.util.StringManager;
 import org.apache.catalina.tribes.util.UUIDGenerator;
 
@@ -619,6 +620,12 @@
 }
 }
 
+public void setDomain(String domain) {
+if ( domain == null ) return;
+if ( domain.startsWith("{") ) setDomain(Arrays.fromString(domain));
+else setDomain(Arrays.convert(domain));
+}
+
 /**
  * Simple test program
  * @param args Command-line arguments



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r883166 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-11-22 Thread markt
Author: markt
Date: Sun Nov 22 22:38:46 2009
New Revision: 883166

URL: http://svn.apache.org/viewvc?rev=883166&view=rev
Log:
Proposal

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=883166&r1=883165&r2=883166&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Sun Nov 22 22:38:46 2009
@@ -445,3 +445,10 @@
   https://issues.apache.org/bugzilla/show_bug.cgi?id=47554
   +1: markt
   -1: 
+
+* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47799
+  Unable to configure domain in Membership and DomainFilterInterceptor
+  Patch provided by Keiichi Fujino
+  http://svn.apache.org/viewvc?rev=883165&view=rev
+  +1: markt
+  -1: 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 47799] Domain does not work in Membership and DomainFilterInterceptor.

2009-11-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47799

--- Comment #4 from Mark Thomas  2009-11-22 14:39:00 GMT ---
Thanks for the patch. It has been applied to trunk and proposed for 6.0.x

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r883169 - /tomcat/trunk/java/org/apache/catalina/startup/TldConfig.java

2009-11-22 Thread markt
Author: markt
Date: Sun Nov 22 22:41:21 2009
New Revision: 883169

URL: http://svn.apache.org/viewvc?rev=883169&view=rev
Log:
Clean up

Modified:
tomcat/trunk/java/org/apache/catalina/startup/TldConfig.java

Modified: tomcat/trunk/java/org/apache/catalina/startup/TldConfig.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/startup/TldConfig.java?rev=883169&r1=883168&r2=883169&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/startup/TldConfig.java (original)
+++ tomcat/trunk/java/org/apache/catalina/startup/TldConfig.java Sun Nov 22 
22:41:21 2009
@@ -293,7 +293,7 @@
 }
 
 public void addApplicationListener( String s ) {
-//if(log.isDebugEnabled())
+if(log.isDebugEnabled())
 log.debug( "Add tld listener " + s);
 listeners.add(s);
 }
@@ -322,7 +322,7 @@
  * 
  * @exception Exception if a fatal input/output or parsing error occurs
  */
-public void execute() throws Exception {
+public void execute() {
 long t1=System.currentTimeMillis();
 
 /*



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 47841] CombinedRealm fails to switch to other realm

2009-11-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47841

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID

--- Comment #1 from Mark Thomas  2009-11-22 14:50:41 GMT ---
In the scenario you describe, with the configuration provided, Tomcat will try
the UserdatabaseRealm first and then the JNDIRealm.

If the LDAP server isn't available, then Tomcat will wait for the connection to
time out.

The timeout is not currently configurable. It is debatable how useful that
would be since if the LDAP server was down, you system is likely to have real
issues.

If you have a use case where configuring the timeout would be useful, please
create an enhancement request. Enhancement requests with patches and a good
justification usually get looked at faster.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r883177 - /tomcat/trunk/java/org/apache/naming/NamingContext.java

2009-11-22 Thread markt
Author: markt
Date: Sun Nov 22 22:56:53 2009
New Revision: 883177

URL: http://svn.apache.org/viewvc?rev=883177&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48049
Correct copy and paste error and call correct function

Modified:
tomcat/trunk/java/org/apache/naming/NamingContext.java

Modified: tomcat/trunk/java/org/apache/naming/NamingContext.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/naming/NamingContext.java?rev=883177&r1=883176&r2=883177&view=diff
==
--- tomcat/trunk/java/org/apache/naming/NamingContext.java (original)
+++ tomcat/trunk/java/org/apache/naming/NamingContext.java Sun Nov 22 22:56:53 
2009
@@ -470,7 +470,7 @@
 
 if (name.size() > 1) {
 if (entry.type == NamingEntry.CONTEXT) {
-((Context) entry.value).unbind(name.getSuffix(1));
+((Context) entry.value).destroySubcontext(name.getSuffix(1));
 } else {
 throw new NamingException
 (sm.getString("namingContext.contextExpected"));



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r883179 - in /tomcat: tc5.5.x/trunk/STATUS.txt tc6.0.x/trunk/STATUS.txt

2009-11-22 Thread markt
Author: markt
Date: Sun Nov 22 22:58:35 2009
New Revision: 883179

URL: http://svn.apache.org/viewvc?rev=883179&view=rev
Log:
Proposal

Modified:
tomcat/tc5.5.x/trunk/STATUS.txt
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc5.5.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=883179&r1=883178&r2=883179&view=diff
==
--- tomcat/tc5.5.x/trunk/STATUS.txt (original)
+++ tomcat/tc5.5.x/trunk/STATUS.txt Sun Nov 22 22:58:35 2009
@@ -291,3 +291,10 @@
   https://issues.apache.org/bugzilla/show_bug.cgi?id=47554
   +1: markt
   -1: 
+
+* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48049
+  Fix copy and paste error and call correct function
+  Patch provided by gingyang.xu
+  http://svn.apache.org/viewvc?rev=883177&view=rev
+  +1: markt
+  -1: 

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=883179&r1=883178&r2=883179&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Sun Nov 22 22:58:35 2009
@@ -452,3 +452,10 @@
   http://svn.apache.org/viewvc?rev=883165&view=rev
   +1: markt
   -1: 
+
+* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48049
+  Fix copy and paste error and call correct function
+  Patch provided by gingyang.xu
+  http://svn.apache.org/viewvc?rev=883177&view=rev
+  +1: markt
+  -1: 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 48049] org.apache.naming.NamingContext's destroySubcontext() method doesn't invoke itself recursively, but invoke unbind() method

2009-11-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48049

--- Comment #1 from Mark Thomas  2009-11-22 14:58:51 GMT ---
Thanks for the patch. It has been committed to trunk and proposed for 6.0.x and
5.5.x

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Bug report for Taglibs [2009/11/22]

2009-11-22 Thread bugzilla
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
| 6347|New|Nor|2002-02-10|io:param should url encode|
| 6390|New|Nor|2002-02-12|valueOf evaluates &'s to & when the & was part|
| 6613|New|Nor|2002-02-21|cannot use xtags:style more than one time per page|
| 8694|Ver|Maj|2002-05-01|Exception when trying to acces the Map.entry compo|
| 8723|Ver|Nor|2002-05-02|use of xsltSystemID does not take effect if xslt a|
| 9257|Ver|Nor|2002-05-20|ELParser doesn't parse non-ascii value|
| 9581|Ver|Min|2002-06-03|update SQL examples to allow for the inputting of |
| 9968|Ver|Maj|2002-06-18|c:url prepends path to page relative URLs |
|10175|Ver|Nor|2002-06-24|Welcome file absent from standard-examples.war in |
|11217|Unc|Blk|2002-07-26|Custom Tag Library Error: 'Tag library ""not found|
|11347|New|Maj|2002-07-31|xtags:if test="position()!=last()" - position() & |
|11361|New|Enh|2002-08-01|Allow user to create own URIResolver  |
|12133|New|Blk|2002-08-28|scrape not work for some urls the request for a co|
|12618|New|Maj|2002-09-13|Mode attribute on xtags:template & xtags:applyTemp|
|12620|New|Nor|2002-09-13|position() and last() do not work in xtags:templat|
|13794|New|Blk|2002-10-20|Unable to list the tag librairies in the custom ta|
|13971|New|Maj|2002-10-25|Style tag does not work with Tomcat 4 with xml or |
|14214|New|Maj|2002-11-04|[PATCH] io:http - can't invoke POS|
|15129|New|Nor|2002-12-06|Distribution of this CTLX is unuseable|
|15551|New|Nor|2002-12-19|error: output must have content-handler property  |
|17211|New|Blk|2003-02-19|FIX: Tomcat 4.1.x taglib pooling causes problems  |
|18198|New|Nor|2003-03-20|[PATCH] Cache - Overloading CacheUtil methods |
|18499|New|Enh|2003-03-30|[cache] per cache entry lifetime  |
|18716|Inf|Nor|2003-04-04|XTAGS LIBRARY PROBLEM IN 4.1.18   |
|19292|New|Enh|2003-04-24|request tag add the ability to store output in pag|
|19754|New|Nor|2003-05-08|TLDParser web.xml and errorstag   |
|20725|New|Nor|2003-06-12|Incorrect property setter signature for Tag handle|
|21928|New|Nor|2003-07-28|Extra space added in the return text of xtags |
|22765|New|Nor|2003-08-27|Wrong values from position() and last() functions |
|23363|New|Maj|2003-09-23|JNDI Taglib does not close context when using  |
|27323|New|Enh|2004-02-29|Remove useless tag  |
|27597|New|Nor|2004-03-11|: set Content-Type header  |
|27717|New|Maj|2004-03-16| very slow in JSTL 1.1 |
|27978|New|Nor|2004-03-26|URLTag nesting into BodyTag does not work more the|
|28280|New|Nor|2004-04-08|bug in xtags:parse whith using a attribute reader |
|28301|New|Nor|2004-04-08|XTags are not working for Tomcat 4.1.18   |
|28814|New|Nor|2004-05-06|mt:header  are ignored|
|28913|New|Maj|2004-05-11|Content-Type not working properly |
|29194|New|Nor|2004-05-25|xml-namespaces not supported  |
|30050|Ass|Maj|2004-07-12|Explicit dependency to Xalan breaks JSTL xml tags |
|30427|New|Nor|2004-08-01|Response contents can be truncated prematurely|
|31009|New|Nor|2004-09-02|io:http tag caches JSPWriter  |
|31859|New|Enh|2004-10-23|Add filename based Content-ID to attachments and u|
|31869|New|Enh|2004-10-24|Allow DataHandler attachments in the attach tag   |
|33032|New|Nor|2005-01-11|string() works incorrectly in conjunction with sco|
|33934|New|Cri|2005-03-09|[standard] memory leak in jstl c:set tag  |
|34137|New|Nor|2005-03-22|getAttribute using iterate reuses bodycontent on 2|
|34703|New|Maj|2005-05-02|Invalid synchronization in PageData leads to java.|
|34786|New|Nor|2005-05-06|Attachments are not cleared in between re-uses of |
|34788|New|Nor|2005-05-06|Cannot set the filename of an attachment independe|
|34789|New|Nor|2005-05-06|Cannot send multi-part Plain Text and HTML emails |
|35780|New|Nor|2005-07-18|Missing attr

Bug report for Tomcat 6 [2009/11/22]

2009-11-22 Thread bugzilla
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|39661|Opn|Enh|2006-05-25|Please document JULI FileHandler configuration pro|
|41128|Inf|Enh|2006-12-07|Reference to java Thread name from RequestProcesso|
|41679|New|Enh|2007-02-22|SemaphoreValve should be able to filter on url pat|
|41791|New|Enh|2007-03-07|Tomcat behaves inconsistently concerning flush-pac|
|41883|Ass|Enh|2007-03-18|use abstract wrapper instead of plain X509Certific|
|41944|New|Enh|2007-03-25|Start running the RAT tool to see where we're miss|
|41992|New|Enh|2007-03-30|Need ability to set OS process title  |
|42463|New|Enh|2007-05-20|"crossContext" and classloader issues - pls amend |
|43001|New|Enh|2007-07-30|JspC lacks setMappedFile and setDie for use in Ant|
|43003|New|Enh|2007-07-30|Separate dependent component download and build ta|
|43400|New|Enh|2007-09-14|enum support for tag libs |
|43497|New|Enh|2007-09-26|Add ability to escape rendered output of JSP expre|
|43548|Opn|Enh|2007-10-04|xml schema for tomcat-users.xml   |
|43642|New|Enh|2007-10-17|Add prestartminSpareThreads attribute for Executor|
|43682|New|Enh|2007-10-23|JULI: web-inf/classes/logging.properties to suppor|
|43742|New|Enh|2007-10-30|.tag compiles  performed one at a time -- extremel|
|43790|Ass|Enh|2007-11-03|concurrent access issue on TagHandlerPool |
|43979|New|Enh|2007-11-27|Add abstraction for Java and Classfile output |
|44047|New|Enh|2007-12-10|Provide a way for Tomcat to serve up error pages w|
|44106|New|Enh|2007-12-19|autodeploy configures directories which do not con|
|44199|New|Enh|2008-01-10|expose current backlog queue size |
|44225|New|Enh|2008-01-14|SSL connector tries to load the private keystore f|
|44264|New|Enh|2008-01-18|Clustering - Support for disabling multicasting an|
|44265|New|Enh|2008-01-18|Improve JspWriterImpl performance with "inline" su|
|44284|New|Enh|2008-01-23|Support java.lang.Iterable in c:forEach tag   |
|44294|New|Enh|2008-01-25|Support for EL functions with varargs |
|44299|New|Enh|2008-01-26|Provider manager app with a log out button|
|44312|New|Enh|2008-01-28|Warn when overwritting docBase of the default Host|
|44598|New|Enh|2008-03-13|JAASRealm is suppressing Exceptions   |
|44645|New|Enh|2008-03-20|[Patch] JNDIRealm - Doesn't support JNDI "java.nam|
|44787|New|Enh|2008-04-09|provide more error context on "java.lang.IllegalSt|
|44818|New|Enh|2008-04-13|tomcat hangs with GET when content-length is defin|
|45014|New|Enh|2008-05-15|Request and Response classes should have wrappers |
|45255|New|Enh|2008-06-23|support disable jsessionid from url against sessio|
|45282|New|Enh|2008-06-25|NioReceiver doesn't close cleanly, leaving sockets|
|45283|Opn|Enh|2008-06-25|Allow multiple authenticators to be added to pipel|
|45428|New|Enh|2008-07-18|warn if the tomcat stop doesn't complete  |
|45654|New|Enh|2008-08-19|use static methods and attributes in a direct way!|
|45731|New|Enh|2008-09-02|Enhancement request : pluggable httpsession cache |
|45794|New|Enh|2008-09-12|Patch causes JNDIRealm to bind with user entered c|
|45832|New|Enh|2008-09-18|add DIGEST authentication support to Ant tasks|
|45871|New|Enh|2008-09-23|Support for salted and digested patches in DataSou|
|45878|New|Enh|2008-09-24|Generated jars do not contain proper manifests or |
|45879|Opn|Enh|2008-09-24|Windows installer fails to install NOTICE and RELE|
|45931|Opn|Enh|2008-10-01|trimSpaces incorrectly modifies output|
|45995|New|Enh|2008-10-13|RFE - MIME type extension not case sensitive  |
|46173|New|Enh|2008-11-09|Small patch for manager app: Setting an optional c|
|46263|New|Enh|2008-11-21|Tomcat reloading of context does not update contex|
|46264|New|Enh|2008-11-21|Shutting down tomcat with large number of contexts|
|46284|New|Enh|2008-11-24|Add flag to DeltaManager that blocks processing cl|
|46323|New|Enh|2008-12-02|NTLM Authentication for Microsoft Active Directory|
|46350|

Bug report for Tomcat Connectors [2009/11/22]

2009-11-22 Thread bugzilla
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|24427|New|Enh|2003-11-05|Tomcat mod_jk - Excludes in Redirection   |
|34526|Opn|Nor|2005-04-19|Truncated content in decompressed requests from mo|
|35959|Opn|Enh|2005-08-01|mod_jk not independant of UseCanonicalName|
|36155|Opn|Nor|2005-08-12|tomcat chooses wrong host if using mod_jk |
|36169|New|Enh|2005-08-12|[PATCH] Enable chunked encoding for requests in II|
|38895|Inf|Nor|2006-03-08|Http headers with an underscore "_" change into hy|
|39967|Inf|Nor|2006-07-05|mod_jk gives segmentation fault when apache is sta|
|40208|Inf|Nor|2006-08-08|Request-Dump when ErrorDocument in httpd.conf is a|
|41170|Inf|Nor|2006-12-13|single crlf in header termination crashes app.|
|41430|New|Reg|2007-01-22|JkOptions +ForwardDirectories with Apache's Direct|
|41695|New|Maj|2007-02-24|mod_jk with httpd 2.0.58 on Solaris-10 11/06 dumpi|
|41923|Opn|Nor|2007-03-21|Tomcat doesnt recognized client abort |
|42366|Inf|Nor|2007-05-09|Memory leak in newer mod_jk version when connectio|
|42554|Opn|Nor|2007-05-31|mod_ssl + mod_jk with status_worker does not work |
|43303|New|Enh|2007-09-04|Versioning under Windows not reported by many conn|
|43821|New|Enh|2007-11-08|provide client AJP IP address |
|43968|New|Enh|2007-11-26|[patch] support ipv6 with mod_jk  |
|44290|New|Nor|2008-01-24|mod_jk/1.2.26: retry is not useful for an importan|
|44349|New|Maj|2008-02-04|mod_jk/1.2.26 module does not read worker.status.s|
|44379|New|Enh|2008-02-07|convert the output of strftime into UTF-8 |
|44454|New|Nor|2008-02-19|busy count reported in mod_jk inflated, causes inc|
|44571|New|Enh|2008-03-10|Limits busy per worker to a threshold |
|45063|New|Nor|2008-05-22|JK-1.2.26 IIS ISAPI filter issue when running diff|
|45182|New|Enh|2008-06-10|Add functionality to automate the jkmanager disabl|
|45313|New|Nor|2008-06-30|mod_jk 1.2.26 & apache 2.2.9 static compiled on so|
|45357|Opn|Enh|2008-07-07|Add property to specify custom maintenance page wh|
|45395|New|Min|2008-07-14|MsgAjp dump method does not dump packet when being|
|45610|New|Nor|2008-08-11|status-worker: Bug in request parameter parsing fo|
|46337|New|Nor|2008-12-04|real worker name is wrong |
|46406|New|Enh|2008-12-16|Supporting relative paths in isapi_redirect.proper|
|46503|New|Nor|2009-01-09|Garbage characters in cluster domain field|
|46632|New|Nor|2009-01-29|mod_jk's sockets close prematurely when the server|
|46676|New|Enh|2009-02-09|Configurable test request for Watchdog thread |
|46763|New|Enh|2009-02-24|Improve treatment of jk_log_lock. |
|46767|New|Enh|2009-02-25|mod_jk to send DECLINED in case no fail-over tomca|
|46862|New|Nor|2009-03-16|Status worker Properties output format (worker.wlb|
|46893|New|Nor|2009-03-23|mod_jk statically compiled always outputs warning |
|47038|New|Enh|2009-04-15|USE_FLOCK_LK redefined compiler warning when using|
|47222|New|Nor|2009-05-19|Changes made to ping_timeout via Status Worker not|
|47224|New|Nor|2009-05-19|Hostname and Port Changes from Status Worker do no|
|47327|New|Enh|2009-06-07|remote_user not logged in apache logfile  |
|47617|New|Enh|2009-07-31|include time spent doing ajp_get_endpoint() in err|
|47678|New|Nor|2009-08-11|Unable to allocate shared memory when using isapi_|
|47679|New|Nor|2009-08-11|Not all headers get passed to Tomcat server from i|
|47692|New|Blk|2009-08-12|Can not compile mod_jk with apache2.0.63 and tomca|
|47714|New|Cri|2009-08-20|Reponse mixed between users   |
|47750|New|Maj|2009-08-27|Loss of worker settings when changing via jkstatus|
|47795|New|Nor|2009-09-07|service sticky_session not being set correctly wit|
|47806|New|Blk|2009-09-08|HTTP 500 internal server error|
|47840|New|Min|2009-09-14|A broken worker name is written in the log file.  |
|47983|New|Nor|2009-10-12|typo in documentation |
|48069|

Bug report for Tomcat 7 [2009/11/22]

2009-11-22 Thread bugzilla
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|47823|New|Enh|2009-09-11|Inconsistent naming of boolean getters in Standard|
|48178|New|Nor|2009-11-11|org.apache.tomcat.lite.Locale2Charset.defaultMap i|
|48222|New|Enh|2009-11-18|Source JARs empty in maven central|
|48233|Inf|Nor|2009-11-18|Loggers should be private |
|48235|New|Nor|2009-11-18|org.apache.catalina.core.ContainerBase.threadDone |
|48238|New|Nor|2009-11-19|Tomcat-lite won't compile |
|48239|New|Nor|2009-11-19|HexUtils exposes public array |
|48240|New|Nor|2009-11-19|Tomcat-Lite missing @Override markers |
|48248|New|Nor|2009-11-20|tribes.group.interceptors.MessageDispatchIntercept|
|48249|New|Nor|2009-11-20|org.apache.tomcat.util.net.NioBlockingSelector.Blo|
+-+---+---+--+--+
| Total   10 bugs   |
+---+

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Bug report for Tomcat 5 [2009/11/22]

2009-11-22 Thread bugzilla
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|27122|Opn|Enh|2004-02-20|IE plugins cannot access components through Tomcat|
|28039|Opn|Enh|2004-03-30|Cluster Support for SingleSignOn  |
|29494|Inf|Enh|2004-06-10|No way to set PATH when running as a service on Wi|
|33262|Inf|Enh|2005-01-27|Service Manager autostart should check for adminis|
|33453|Opn|Enh|2005-02-08|Jasper should recompile JSP files whose datestamps|
|33671|Opn|Enh|2005-02-21|Manual Windows service installation with custom na|
|34801|New|Enh|2005-05-08|PATCH: CGIServlet does not terminate child after a|
|34805|Ass|Enh|2005-05-08|warn about invalid security constraint url pattern|
|34868|Ass|Enh|2005-05-11|allow to register a trust store for a session that|
|35054|Inf|Enh|2005-05-25|warn if appBase is not existing as a File or direc|
|36133|Inf|Enh|2005-08-10|Support JSS SSL implementation|
|36362|New|Enh|2005-08-25|missing check for Java reserved keywords in tag fi|
|36569|Inf|Enh|2005-09-09|Redirects produce illegal URL's   |
|36837|Inf|Enh|2005-09-28|Looking for ProxyHandler implementation of Http re|
|36922|Inf|Enh|2005-10-04|setup.sh file mis-advertised and missing  |
|37018|Ass|Enh|2005-10-11|Document how to use tomcat-SSL with a pkcs11 token|
|37334|Inf|Enh|2005-11-02|Realm digest property not aligned with the adminis|
|37449|Opn|Enh|2005-11-10|Two UserDatabaseRealm break manager user  |
|37485|Inf|Enh|2005-11-14|I'd like to run init SQL after JDBC Connection cre|
|37847|Ass|Enh|2005-12-09|Allow User To Optionally Specify Catalina Output F|
|37848|Opn|Trv|2005-12-09|Inappropriate Output From catalina.sh When No Term|
|38216|Inf|Enh|2006-01-10|Extend Jmxproxy to allow call of MBean Operations |
|38268|Inf|Enh|2006-01-13|User friendly: Need submit button on adding/deleti|
|38360|Inf|Enh|2006-01-24|Domain for session cookies|
|38546|Inf|Enh|2006-02-07|Google bot sends invalid If-Modifed-Since Header, |
|38577|Inf|Enh|2006-02-08|Enhance logging of security failures  |
|38743|New|Min|2006-02-21|when using APR, JKS options are silently ignored  |
|38797|Opn|Nor|2006-02-27|5.5.12 and 5.5.15 emit different code on  |
|41007|Opn|Enh|2006-11-20|Can't define customized 503 error page|
|41179|New|Enh|2006-12-15|400 Bad Request response during auto re-deployment|
|41227|Opn|Enh|2006-12-21|When the jasper compiler fails to compile a JSP, i|
|41337|Opn|Enh|2007-01-10|Display an error page if no cert is available on C|
|41496|New|Enh|2007-01-30|set a security provider for jsse in a connector co|
|41498|New|Enh|2007-01-30|allRolesMode Realm configuration option not docume|
|41539|Inf|Enh|2007-02-05|NullPointerException during Embedded tomcat restar|
|41673|New|Enh|2007-02-21|Jasper output the message of compiling error using|
|41697|Ver|Enh|2007-02-25|make visible in debug output if charset from brows|
|41709|Inf|Enh|2007-02-26|When calling the API that relates to the buffer af|
|41718|New|Enh|2007-02-27|Status 302 response to GET request has no body whe|
|42390|New|Maj|2007-05-11|JSP compilation error with nested tagfile tags wit|
|42416|New|Enh|2007-05-14|Tomcat startup hangs and AJP13 connector port 8009|
|43423|New|Enh|2007-09-18|catalina.sh -force too fast   |
|43538|New|Enh|2007-10-02|[patch] Show the hostname and IP address in the ma|
|43796|Inf|Enh|2007-11-05|Add MIME type mapping for the "log" extension |
|43866|New|Enh|2007-11-14|add support for session attribute propagation with|
|43925|Opn|Enh|2007-11-21|org.apache.jasper.runtime.BodyContentImpl causing |
|43960|New|Enh|2007-11-26|Expose StandardWrapper unavailable and/or availabl|
|43991|New|Enh|2007-11-29|Contributing a URLResourceFactory |
|44041|Opn|Cri|2007-12-07|WebappClassLoader duplicate class definition under|
|44216|New|Enh|2008-01-11|Don't reuse session ID even if emptySessionPath=tr|
|44309|New|Enh|2008-01-28|Possible overriding the security state of the conn|
|44399|New|Enh|

Bug report for Tomcat Native [2009/11/22]

2009-11-22 Thread bugzilla
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|38372|Inf|Cri|2006-01-25|tcnative-1.dll response overflow corruption, parti|
|41361|New|Nor|2007-01-14|Content lost when read by a slow client.  |
|42090|New|Cri|2007-04-11|tcnative badly handles some OpenSSL disconnections|
|45392|New|Nor|2008-07-14|No OCSP support for client SSL verification   |
|46041|New|Cri|2008-10-20|Tomcat service is terminated unexpectedly (tcnativ|
|46179|New|Maj|2008-11-10|apr ssl client authentication |
|46571|New|Nor|2009-01-21|tcnative blocks in APR poll on Solaris|
|47319|New|Nor|2009-06-05|With APR, getRemoteHost() returns NULL for unknown|
|47851|New|Nor|2009-09-16|thread-safety issues in the TC native Java code   |
|48129|New|Nor|2009-11-04|[PATCH] Fix build with OpenSSL 1.0.0-beta3|
|48253|New|Min|2009-11-20|Tomcat Native patch - adding dynamic locking callb|
+-+---+---+--+--+
| Total   11 bugs   |
+---+

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r883181 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-11-22 Thread markt
Author: markt
Date: Sun Nov 22 23:14:48 2009
New Revision: 883181

URL: http://svn.apache.org/viewvc?rev=883181&view=rev
Log:
Proposal

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=883181&r1=883180&r2=883181&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Sun Nov 22 23:14:48 2009
@@ -459,3 +459,8 @@
   http://svn.apache.org/viewvc?rev=883177&view=rev
   +1: markt
   -1: 
+
+* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48113
+  Display IP addresses using 0-255 rather than -128 to +127
+  Port Filip's patch from trunk
+  http://svn.eu.apache.org/viewvc?view=revision&revision=758249



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 48113] Member hostname components are printed as signed 8bits

2009-11-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48113

--- Comment #1 from Mark Thomas  2009-11-22 15:14:51 GMT ---
This was fixed in trunk in r758249. I have proposed the same patch for 6.0.x

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 48116] Cannot use JAXP 1.4 XML APIs from JDK 1.6 without use of 'endorsed'

2009-11-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48116

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID

--- Comment #7 from Mark Thomas  2009-11-22 15:15:29 GMT ---
JVM issue therefore, not a Tomcat bug.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 48218] Comet example chat.ChatServlet fails to start when running with SecurityManager

2009-11-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48218

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WONTFIX

--- Comment #2 from Mark Thomas  2009-11-22 15:17:44 GMT ---
Thought about this some more and there is no easy fix for 6.0.x that doesn't
break the API. Note this has been fixed for 7.0.x but is a WONTFIX for 6.0.x.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r883183 - /tomcat/trunk/test/org/apache/catalina/startup/TestTomcatSSL.java

2009-11-22 Thread markt
Author: markt
Date: Sun Nov 22 23:25:35 2009
New Revision: 883183

URL: http://svn.apache.org/viewvc?rev=883183&view=rev
Log:
Use correct attribute name now all the renaming code has been removed

Modified:
tomcat/trunk/test/org/apache/catalina/startup/TestTomcatSSL.java

Modified: tomcat/trunk/test/org/apache/catalina/startup/TestTomcatSSL.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/startup/TestTomcatSSL.java?rev=883183&r1=883182&r2=883183&view=diff
==
--- tomcat/trunk/test/org/apache/catalina/startup/TestTomcatSSL.java (original)
+++ tomcat/trunk/test/org/apache/catalina/startup/TestTomcatSSL.java Sun Nov 22 
23:25:35 2009
@@ -71,7 +71,7 @@
 tomcat.getConnector().setProperty("sslProtocol",
 "tls");
 // test runs in output/tmp
-tomcat.getConnector().setAttribute("keystore", 
+tomcat.getConnector().setAttribute("keystoreFile", 
 "../../test/org/apache/catalina/startup/test.keystore");
 }
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: svn commit: r883169 - /tomcat/trunk/java/org/apache/catalina/startup/TldConfig.java

2009-11-22 Thread Bill Barker

 wrote in message 
news:2009114121.9d6642388...@eris.apache.org...
> Author: markt
> Date: Sun Nov 22 22:41:21 2009
> New Revision: 883169
>
> URL: http://svn.apache.org/viewvc?rev=883169&view=rev
> Log:
> Clean up
>
> Modified:
>tomcat/trunk/java/org/apache/catalina/startup/TldConfig.java
>
> Modified: tomcat/trunk/java/org/apache/catalina/startup/TldConfig.java
> URL: 
> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/startup/TldConfig.java?rev=883169&r1=883168&r2=883169&view=diff
> ==
> --- tomcat/trunk/java/org/apache/catalina/startup/TldConfig.java 
> (original)
> +++ tomcat/trunk/java/org/apache/catalina/startup/TldConfig.java Sun Nov 
> 22 22:41:21 2009
> @@ -293,7 +293,7 @@
> }
>
> public void addApplicationListener( String s ) {
> -//if(log.isDebugEnabled())
> +if(log.isDebugEnabled())
> log.debug( "Add tld listener " + s);
> listeners.add(s);
> }
> @@ -322,7 +322,7 @@
>  *
>  * @exception Exception if a fatal input/output or parsing error 
> occurs
>  */
> -public void execute() throws Exception {
> +public void execute() {
> long t1=System.currentTimeMillis();
>
> /*

Could also cleanup the JavaDoc comment when you get a chance. 




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 48236] another workaround for CVE-2009-3555 for the BIO connector

2009-11-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48236

--- Comment #6 from Mark Thomas  2009-11-22 15:26:22 GMT ---
There is also org.apache.catalina.startup.TestTomcatSSL although a couple of
tests are failing at the moment and I need to figure out why. I suspect it is
because of some recent refactoring.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r883184 - /tomcat/trunk/java/org/apache/catalina/startup/TldConfig.java

2009-11-22 Thread markt
Author: markt
Date: Sun Nov 22 23:29:05 2009
New Revision: 883184

URL: http://svn.apache.org/viewvc?rev=883184&view=rev
Log:
Cleanup Javadoc as well as code

Modified:
tomcat/trunk/java/org/apache/catalina/startup/TldConfig.java

Modified: tomcat/trunk/java/org/apache/catalina/startup/TldConfig.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/startup/TldConfig.java?rev=883184&r1=883183&r2=883184&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/startup/TldConfig.java (original)
+++ tomcat/trunk/java/org/apache/catalina/startup/TldConfig.java Sun Nov 22 
23:29:05 2009
@@ -319,8 +319,6 @@
  * The set of shared JARs to be scanned for TLDs is narrowed down by
  * the noTldJars class variable, which contains the names of JARs
  * that are known not to contain any TLDs.
- * 
- * @exception Exception if a fatal input/output or parsing error occurs
  */
 public void execute() {
 long t1=System.currentTimeMillis();



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: svn commit: r883169 - /tomcat/trunk/java/org/apache/catalina/startup/TldConfig.java

2009-11-22 Thread Mark Thomas
Bill Barker wrote:
>  wrote in message 
> news:2009114121.9d6642388...@eris.apache.org...
>> Author: markt
>> Date: Sun Nov 22 22:41:21 2009
>> New Revision: 883169
>>
>> URL: http://svn.apache.org/viewvc?rev=883169&view=rev
>> Log:
>> Clean up

> Could also cleanup the JavaDoc comment when you get a chance. 
Fair cop. Done.

Mark




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r883186 - /tomcat/trunk/java/org/apache/catalina/manager/LocalStrings_es.properties

2009-11-22 Thread markt
Author: markt
Date: Sun Nov 22 23:31:18 2009
New Revision: 883186

URL: http://svn.apache.org/viewvc?rev=883186&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48257
Patch provided by Guillermo Gutiérrez

Modified:
tomcat/trunk/java/org/apache/catalina/manager/LocalStrings_es.properties

Modified: 
tomcat/trunk/java/org/apache/catalina/manager/LocalStrings_es.properties
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/manager/LocalStrings_es.properties?rev=883186&r1=883185&r2=883186&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/manager/LocalStrings_es.properties 
(original)
+++ tomcat/trunk/java/org/apache/catalina/manager/LocalStrings_es.properties 
Sun Nov 22 23:31:18 2009
@@ -93,7 +93,7 @@
 managerServlet.started = OK - Arrancada aplicaci\u00F3n en trayectoria de 
contexto {0}
 managerServlet.startFailed = FALLO - No se pudo arrancar la aplicaci\u00F3n en 
trayectoria de contexto {0}
 managerServlet.stopped = OK - Parada aplicaci\u00F3n en trayectoria de 
contexto {0}
-managerServlet.undeployed = OK - Replegada aplicacaci\u00F3n en trayectoria de 
contexto {0}
+managerServlet.undeployed = OK - Replegada aplicaci\u00F3n en trayectoria de 
contexto {0}
 managerServlet.unknownCommand = FALLO - Comando desconocido {0}
 managerServlet.userDatabaseError = FALLO - No puedo resolver referencia de 
base de datos de usuario
 managerServlet.userDatabaseMissing = FALLO - No se encuentra disponible base 
de datos de usuario



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r883187 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/manager/LocalStrings_es.properties

2009-11-22 Thread markt
Author: markt
Date: Sun Nov 22 23:32:05 2009
New Revision: 883187

URL: http://svn.apache.org/viewvc?rev=883187&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48257
Patch provided by Guillermo Gutiérrez

Modified:

tomcat/tc6.0.x/trunk/java/org/apache/catalina/manager/LocalStrings_es.properties

Modified: 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/manager/LocalStrings_es.properties
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/manager/LocalStrings_es.properties?rev=883187&r1=883186&r2=883187&view=diff
==
--- 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/manager/LocalStrings_es.properties
 (original)
+++ 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/manager/LocalStrings_es.properties
 Sun Nov 22 23:32:05 2009
@@ -93,7 +93,7 @@
 managerServlet.started = OK - Arrancada aplicaci\u00F3n en trayectoria de 
contexto {0}
 managerServlet.startFailed = FALLO - No se pudo arrancar la aplicaci\u00F3n en 
trayectoria de contexto {0}
 managerServlet.stopped = OK - Parada aplicaci\u00F3n en trayectoria de 
contexto {0}
-managerServlet.undeployed = OK - Replegada aplicacaci\u00F3n en trayectoria de 
contexto {0}
+managerServlet.undeployed = OK - Replegada aplicaci\u00F3n en trayectoria de 
contexto {0}
 managerServlet.unknownCommand = FALLO - Comando desconocido {0}
 managerServlet.userDatabaseError = FALLO - No puedo resolver referencia de 
base de datos de usuario
 managerServlet.userDatabaseMissing = FALLO - No se encuentra disponible base 
de datos de usuario



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 48257] typo in spanish translation

2009-11-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48257

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #1 from Mark Thomas  2009-11-22 15:32:17 GMT ---
Thanks for the patch. I have applied it to trunk and 6.0.x.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r883188 - /tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

2009-11-22 Thread markt
Author: markt
Date: Sun Nov 22 23:33:52 2009
New Revision: 883188

URL: http://svn.apache.org/viewvc?rev=883188&view=rev
Log:
Update change log

Modified:
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml?rev=883188&r1=883187&r2=883188&view=diff
==
--- tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Sun Nov 22 23:33:52 2009
@@ -185,6 +185,10 @@
 lead to a NoClassDefFoundError on first access of first jsp.
 (kkolinko/markt)
   
+  
+48257: Correct error in Spanish translations. Patch provided
+by Guillermo Gutiérrez. (markt)
+  
   
 Deprecate the caseSensitive option on the
 StandardContext which will be removed in Tomcat 7 onwards.



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 48192] Allow to specify the SSLSocket class in connector tag of server.xml

2009-11-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48192

Bill Barker  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||WONTFIX

--- Comment #4 from Bill Barker  2009-11-22 15:48:13 UTC 
---
There has been the capability to specify a custom SSLImplementation since
Tomcat 3.3.  That would be the proper way to inject your own SSL handling code
into Tomcat.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r883196 - in /tomcat/trunk/java/org/apache/tomcat/util/net: AbstractEndpoint.java NioEndpoint.java jsse/JSSESocketFactory.java

2009-11-22 Thread markt
Author: markt
Date: Mon Nov 23 00:11:11 2009
New Revision: 883196

URL: http://svn.apache.org/viewvc?rev=883196&view=rev
Log:
Fix failing SSL test
Prevent NPE in NIO connector when using SSL and the default keystore password

Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java
tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java

Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java?rev=883196&r1=883195&r2=883196&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java 
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java Mon Nov 
23 00:11:11 2009
@@ -26,6 +26,7 @@
 import org.apache.juli.logging.Log;
 import org.apache.juli.logging.LogFactory;
 import org.apache.tomcat.util.IntrospectionUtils;
+import org.apache.tomcat.util.net.jsse.JSSESocketFactory;
 import org.apache.tomcat.util.res.StringManager;
 import org.apache.tomcat.util.threads.ResizableExecutor;
 import org.apache.tomcat.util.threads.TaskQueue;
@@ -503,7 +504,7 @@
 public String getKeyAlias() { return keyAlias;}
 public void setKeyAlias(String s ) { keyAlias = s;}
 
-private String keyPass = "changeit";
+private String keyPass = JSSESocketFactory.DEFAULT_KEY_PASS;
 public String getKeyPass() { return keyPass;}
 public void setKeyPass(String s ) { this.keyPass = s;}
 

Modified: tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java?rev=883196&r1=883195&r2=883196&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java Mon Nov 23 
00:11:11 2009
@@ -53,6 +53,7 @@
 import org.apache.juli.logging.LogFactory;
 import org.apache.tomcat.util.IntrospectionUtils;
 import org.apache.tomcat.util.net.SecureNioChannel.ApplicationBufferHandler;
+import org.apache.tomcat.util.net.jsse.JSSESocketFactory;
 import org.apache.tomcat.util.net.jsse.NioX509KeyManager;
 
 /**
@@ -504,7 +505,11 @@
 // Initialize SSL if needed
 if (isSSLEnabled()) {
 // Initialize SSL
-char[] passphrase = getKeystorePass().toCharArray();
+String keystorePass = getKeystorePass();
+if (keystorePass == null) {
+keystorePass = JSSESocketFactory.DEFAULT_KEY_PASS;
+}
+char[] passphrase = keystorePass.toCharArray();
 
 char[] tpassphrase = 
(getTruststorePass()!=null)?getTruststorePass().toCharArray():passphrase;
 String ttype = 
(getTruststoreType()!=null)?getTruststoreType():getKeystoreType();

Modified: 
tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java?rev=883196&r1=883195&r2=883196&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java 
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java 
Mon Nov 23 00:11:11 2009
@@ -84,15 +84,15 @@
 private static final StringManager sm =
 StringManager.getManager("org.apache.tomcat.util.net.jsse.res");
 
-// defaults
+// Defaults - made public where re-used
 static String defaultProtocol = "TLS";
 static boolean defaultClientAuth = false;
 static String defaultKeystoreType = "JKS";
 private static final String defaultKeystoreFile
 = System.getProperty("user.home") + "/.keystore";
-private static final String defaultKeyPass = "changeit";
 private static final int defaultSessionCacheSize = 0;
 private static final int defaultSessionTimeout = 86400;
+public static final String DEFAULT_KEY_PASS = "changeit";
 
 static final org.apache.juli.logging.Log log =
 org.apache.juli.logging.LogFactory.getLog(JSSESocketFactory.class);
@@ -259,7 +259,7 @@
 String keyPass = (String)attributes.get(
 AbstractEndpoint.SSL_ATTR_KEY_PASS);
 if (keyPass == null) {
-keyPass = defaultKeyPass;
+keyPass = DEFAULT_KEY_PASS;
 }
 String keystorePass = (String)attributes.get(
 AbstractEndpoint.SSL_ATTR_KEYSTORE_PASS);



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r883198 - /tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Protocol.java

2009-11-22 Thread markt
Author: markt
Date: Mon Nov 23 00:23:41 2009
New Revision: 883198

URL: http://svn.apache.org/viewvc?rev=883198&view=rev
Log:
Add missing property

Modified:
tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Protocol.java

Modified: tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Protocol.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Protocol.java?rev=883198&r1=883197&r2=883198&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Protocol.java 
(original)
+++ tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Protocol.java Mon 
Nov 23 00:23:41 2009
@@ -383,6 +383,12 @@
 public void setSessionTimeout(String 
s){endpoint.setTruststoreAlgorithm(s);}
 public String getSessionTimeout(){ return 
endpoint.getTruststoreAlgorithm();}
 
+public void setAllowUnsafeLegacyRenegotiation(String s) {
+endpoint.setAllowUnsafeLegacyRenegotiation(s);
+}
+public String getAllowUnsafeLegacyRenegotiation() {
+return endpoint.getAllowUnsafeLegacyRenegotiation();
+}
 
 public abstract void init() throws Exception;
 public abstract void start() throws Exception;



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r883199 - /tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java

2009-11-22 Thread markt
Author: markt
Date: Mon Nov 23 00:28:03 2009
New Revision: 883199

URL: http://svn.apache.org/viewvc?rev=883199&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48249
Use volatile since field is accessed by multiple threads

Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java

Modified: tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java?rev=883199&r1=883198&r2=883199&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java 
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java Mon 
Nov 23 00:28:03 2009
@@ -194,7 +194,7 @@
 
 
 protected class BlockPoller extends Thread {
-protected boolean run = true;
+protected volatile boolean run = true;
 protected Selector selector = null;
 protected ConcurrentLinkedQueue events = new 
ConcurrentLinkedQueue();
 public void disable() { run = false; selector.wakeup();}



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 48249] org.apache.tomcat.util.net.NioBlockingSelector.BlockPoller.run <= volatile

2009-11-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48249

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #1 from Mark Thomas  2009-11-22 16:28:11 GMT ---
Fixed in trunk.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r883200 - in /tomcat/trunk/java/org/apache/catalina/tribes: group/GroupChannel.java group/interceptors/MessageDispatchInterceptor.java group/interceptors/TcpPingInterceptor.java membership

2009-11-22 Thread markt
Author: markt
Date: Mon Nov 23 00:31:43 2009
New Revision: 883200

URL: http://svn.apache.org/viewvc?rev=883200&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48248
Use volatile since field is accessed by multiple threads

Modified:
tomcat/trunk/java/org/apache/catalina/tribes/group/GroupChannel.java

tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/MessageDispatchInterceptor.java

tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/TcpPingInterceptor.java

tomcat/trunk/java/org/apache/catalina/tribes/membership/McastServiceImpl.java

Modified: tomcat/trunk/java/org/apache/catalina/tribes/group/GroupChannel.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/group/GroupChannel.java?rev=883200&r1=883199&r2=883200&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/tribes/group/GroupChannel.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/tribes/group/GroupChannel.java Mon 
Nov 23 00:31:43 2009
@@ -644,7 +644,7 @@
 return counter++;
 }
 
-protected boolean doRun = true;
+protected volatile boolean doRun = true;
 protected GroupChannel channel;
 protected long sleepTime;
 public HeartbeatThread(GroupChannel channel, long sleepTime) {

Modified: 
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/MessageDispatchInterceptor.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/MessageDispatchInterceptor.java?rev=883200&r1=883199&r2=883200&view=diff
==
--- 
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/MessageDispatchInterceptor.java
 (original)
+++ 
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/MessageDispatchInterceptor.java
 Mon Nov 23 00:31:43 2009
@@ -42,7 +42,7 @@
 
 protected long maxQueueSize = 1024*1024*64; //64MB
 protected FastQueue queue = new FastQueue();
-protected boolean run = false;
+protected volatile boolean run = false;
 protected Thread msgDispatchThread = null;
 protected long currentSize = 0;
 protected boolean useDeepClone = true;

Modified: 
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/TcpPingInterceptor.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/TcpPingInterceptor.java?rev=883200&r1=883199&r2=883200&view=diff
==
--- 
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/TcpPingInterceptor.java
 (original)
+++ 
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/TcpPingInterceptor.java
 Mon Nov 23 00:31:43 2009
@@ -52,7 +52,7 @@
 
 protected boolean useThread = false;
 protected boolean staticOnly = false;
-protected boolean running = true;
+protected volatile boolean running = true;
 protected PingThread thread = null;
 protected static AtomicInteger cnt = new AtomicInteger(0);
 

Modified: 
tomcat/trunk/java/org/apache/catalina/tribes/membership/McastServiceImpl.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/membership/McastServiceImpl.java?rev=883200&r1=883199&r2=883200&view=diff
==
--- 
tomcat/trunk/java/org/apache/catalina/tribes/membership/McastServiceImpl.java 
(original)
+++ 
tomcat/trunk/java/org/apache/catalina/tribes/membership/McastServiceImpl.java 
Mon Nov 23 00:31:43 2009
@@ -57,8 +57,8 @@
 /**
  * Internal flag used for the listen thread that listens to the 
multicasting socket.
  */
-protected boolean doRunSender = false;
-protected boolean doRunReceiver = false;
+protected volatile boolean doRunSender = false;
+protected volatile boolean doRunReceiver = false;
 protected int startLevel = 0;
 /**
  * Socket that we intend to listen to
@@ -575,7 +575,7 @@
 }//class SenderThread
 
 protected static class RecoveryThread extends Thread {
-static boolean running = false;
+static volatile boolean running = false;
 McastServiceImpl parent = null;
 public RecoveryThread(McastServiceImpl parent) {
 this.parent = parent;



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 48248] tribes.group.interceptors.MessageDispatchInterceptor.run should be volatile

2009-11-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48248

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #2 from Mark Thomas  2009-11-22 16:31:47 GMT ---
Fixed in trunk.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 48239] HexUtils exposes public array

2009-11-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48239

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #1 from Mark Thomas  2009-11-22 16:36:05 GMT ---
Thanks for the patch. It wasn't quite complete. I added the extra changes
required.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r883201 - in /tomcat/trunk/java/org/apache: coyote/ajp/ coyote/http11/ coyote/http11/filters/ tomcat/util/buf/

2009-11-22 Thread markt
Author: markt
Date: Mon Nov 23 00:36:10 2009
New Revision: 883201

URL: http://svn.apache.org/viewvc?rev=883201&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48239
HexUtils exposes public array
Based on a patch provided by sebb

Modified:
tomcat/trunk/java/org/apache/coyote/ajp/AjpAprProcessor.java
tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java
tomcat/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java
tomcat/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java
tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java
tomcat/trunk/java/org/apache/coyote/http11/filters/ChunkedInputFilter.java
tomcat/trunk/java/org/apache/coyote/http11/filters/ChunkedOutputFilter.java
tomcat/trunk/java/org/apache/tomcat/util/buf/HexUtils.java
tomcat/trunk/java/org/apache/tomcat/util/buf/MessageBytes.java

Modified: tomcat/trunk/java/org/apache/coyote/ajp/AjpAprProcessor.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/ajp/AjpAprProcessor.java?rev=883201&r1=883200&r2=883201&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/ajp/AjpAprProcessor.java (original)
+++ tomcat/trunk/java/org/apache/coyote/ajp/AjpAprProcessor.java Mon Nov 23 
00:36:10 2009
@@ -920,7 +920,7 @@
 int port = 0;
 int mult = 1;
 for (int i = valueL - 1; i > colonPos; i--) {
-int charValue = HexUtils.DEC[valueB[i + valueS]];
+int charValue = HexUtils.getDec(valueB[i + valueS]);
 if (charValue == -1) {
 // Invalid character
 error = true;

Modified: tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java?rev=883201&r1=883200&r2=883201&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java (original)
+++ tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java Mon Nov 23 
00:36:10 2009
@@ -925,7 +925,7 @@
 int port = 0;
 int mult = 1;
 for (int i = valueL - 1; i > colonPos; i--) {
-int charValue = HexUtils.DEC[valueB[i + valueS]];
+int charValue = HexUtils.getDec(valueB[i + valueS]);
 if (charValue == -1) {
 // Invalid character
 error = true;

Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java?rev=883201&r1=883200&r2=883201&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java 
(original)
+++ tomcat/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java Mon Nov 
23 00:36:10 2009
@@ -1480,7 +1480,7 @@
 int port = 0;
 int mult = 1;
 for (int i = valueL - 1; i > colonPos; i--) {
-int charValue = HexUtils.DEC[valueB[i + valueS]];
+int charValue = HexUtils.getDec(valueB[i + valueS]);
 if (charValue == -1) {
 // Invalid character
 error = true;

Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java?rev=883201&r1=883200&r2=883201&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java 
(original)
+++ tomcat/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java Mon Nov 
23 00:36:10 2009
@@ -1036,7 +1036,7 @@
 int port = 0;
 int mult = 1;
 for (int i = valueL - 1; i > colonPos; i--) {
-int charValue = HexUtils.DEC[valueB[i + valueS]];
+int charValue = HexUtils.getDec(valueB[i + valueS]);
 if (charValue == -1) {
 // Invalid character
 error = true;

Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java?rev=883201&r1=883200&r2=883201&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java (original)
+++ tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java Mon Nov 23 
00:36:10 2009
@@ -995,7 +995,7 @@
 int port = 0;
 int mult = 1;
 for (int i = valueL - 1; i > colonPos; i--) {
-int charValue = HexUtils.DEC[valueB[i + valueS]];
+int charValue = H

svn commit: r883203 - /tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java

2009-11-22 Thread markt
Author: markt
Date: Mon Nov 23 00:37:36 2009
New Revision: 883203

URL: http://svn.apache.org/viewvc?rev=883203&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=482
Use volatile since field is accessed by multiple threads

Modified:
tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java

Modified: tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java?rev=883203&r1=883202&r2=883203&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java (original)
+++ tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java Mon Nov 23 
00:37:36 2009
@@ -278,7 +278,7 @@
 /**
  * The background thread completion semaphore.
  */
-private boolean threadDone = false;
+private volatile boolean threadDone = false;
 
 
 // - Properties



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 48235] org.apache.catalina.core.ContainerBase.threadDone should be volatile

2009-11-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48235

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #1 from Mark Thomas  2009-11-22 16:37:46 GMT ---
Fixed in trunk.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 48233] Loggers should be private

2009-11-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48233

Mark Thomas  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution||FIXED

--- Comment #6 from Mark Thomas  2009-11-22 16:45:41 GMT ---
Patch applied. Many thanks.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 48239] HexUtils exposes public array

2009-11-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48239

--- Comment #2 from Sebb  2009-11-22 17:02:00 UTC ---
(In reply to comment #1)
> Thanks for the patch. It wasn't quite complete. I added the extra changes
> required.

Oops, sorry, the patch was missing fixes to the files that also had non-private
loggers.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 48250] Character Encoding on HTTP Conector

2009-11-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48250

Konstantin Kolinko  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID

--- Comment #1 from Konstantin Kolinko  2009-11-22 
20:29:27 UTC ---
Please read
http://catb.org/~esr/faqs/smart-questions.html#chronology
and provide a sample application that demonstrates erroneous behaviour on the
recent version of Tomcat, that is 5.5.28 as of now.

Your description is not enough neither to diagnose nor to reproduce the
problem.

The filters do what they are designed to do. I suppose there is an error in how
you use them. Please address support questions to the users@ list, and search
the list archives,
http://tomcat.apache.org/lists.html

Note also that there is also a FAQ on the Tomcat site,
http://wiki.apache.org/tomcat/FAQ

> But works on all versions of Tomcat in windows and version 6 of Tomcat on
> Linux.

Probably what differs is the default code page of the user account that is used
to run Tomcat.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: svn commit: r883181 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-11-22 Thread Konstantin Kolinko
2009/11/23  :
> Author: markt
> Date: Sun Nov 22 23:14:48 2009
> New Revision: 883181
>
> URL: http://svn.apache.org/viewvc?rev=883181&view=rev
> Log:
> Proposal
>
> Modified:
>    tomcat/tc6.0.x/trunk/STATUS.txt
>
> +
> +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48113
> +  Display IP addresses using 0-255 rather than -128 to +127
> +  Port Filip's patch from trunk
> +  http://svn.eu.apache.org/viewvc?view=revision&revision=758249
>

No positive vote? :)  Actually this fix is just wrong.

This:
+if (asInt) buf.append((int)data[offset++]);
performs widening byte -> int, preserving the sign.

It should be
+if (asInt) buf.append(data[offset++] & 0xff);
as in the original patch:
https://issues.apache.org/bugzilla/show_bug.cgi?id=48113#c0

Also maybe call this argument "asUnsigned"?
(The original patch calls it "unsigned", but I do not like it. It
looks like a reserved word, though it is not on the JLS list of
reserved keywords - ch.3.9 of JLS )


Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 48192] Allow to specify the SSLSocket class in connector tag of server.xml

2009-11-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48192

Ralf Hauser  changed:

   What|Removed |Added

 CC||hau...@acm.org,
   ||more...@privasphere.com

--- Comment #5 from Ralf Hauser  2009-11-22 22:32:26 UTC ---
Bill, do you mean "sslProtocol" of
http://tomcat.apache.org/tomcat-6.0-doc/ssl-howto.html#Edit%20the%20Tomcat%20Configuration%20File
?
If so, isn't a different security provider a rather big piece of code to change
for just some minor subclassing of a few (or even just 1) class?

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org