svn commit: r831217 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: kkolinko Date: Fri Oct 30 07:30:10 2009 New Revision: 831217 URL: http://svn.apache.org/viewvc?rev=831217&view=rev Log: vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=831217&r1=831216&r2=831217&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Fri Oct 30 07:30:10 2009 @@ -294,10 +294,25 @@ https://issues.apache.org/bugzilla/attachment.cgi?id=24276 +1: rjung, markt -1: + +1: kkolinko:( +Should be applied when tc-native 1.1.17 is released, +because of native method names and argument types changes. + +We will need to update minimum required version +(in o.a.c.core.AprLifecycleListener, o.a.c.connector.Connector). + +Also, attachment.cgi?id=24276 looks like a wrong patch to vote. +It is a documentation patch. There is no need to vote for it. And it is +not for Socket.java. + ) rjung: Note that java/org/apache/tomcat/jni/Buffer.java is missing in TC 6. Don't know, whether we should add it. It is in 5.5, trunk and tcnative 1.1. markt: Happy either way with slight preference for adding it + kkolinko: Either way is OK, but, as I cannot find any usages of Buffer + methods neither in TC 5.5 nor in trunk, I would prefer to remove this + class at least from trunk, but better from both, and even from native + side. * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47267 http://svn.apache.org/viewvc?rev=817822&view=rev - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48066] ant.jar is needless in build.xml
https://issues.apache.org/bugzilla/show_bug.cgi?id=48066 --- Comment #3 from qingyang.xu 2009-10-30 02:20:06 UTC --- (In reply to comment #2) > whether ant.jar is included or not depends on the includeAntRuntime attribute > of the javac task which - for better or worse - happens to default to true. > > It may be a good idea to set this attribute explicitly. Good comment! Thanks a lot. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48088] New: Servlet implementing SingleThreadModel are initialized twice
https://issues.apache.org/bugzilla/show_bug.cgi?id=48088
Summary: Servlet implementing SingleThreadModel are initialized
twice
Product: Tomcat 5
Version: 5.5.28
Platform: PC
OS/Version: All
Status: NEW
Severity: normal
Priority: P2
Component: Catalina
AssignedTo: dev@tomcat.apache.org
ReportedBy: anthony.goub...@wanadoo.nl
When a Servlet implements javax.servlet.SingleThreadModel the method init is
called twice. This should not happen according to the Servlet specification.
http://developer.java.sun.com/developer/onlineTraining/Servlets/Fundamentals/servlets.html#lifeCycle
I first saw the bug when someone tried when someone submitted a bug in my open
source web services framework "xins"
http://sourceforge.net/tracker/?func=detail&aid=2884574&group_id=71598&atid=531814
(bug submitted from Linux with Tomcat 5.5.25)
Here the petstore demo is initialized at the start-up of Tomcat and with the
first request http://localhost:8080/petstore/. This apparently happens on the
same Servlet object.
I've attached the war file that contains removed code so that the Servlet
initializes correctly the first time without looking for a database.
Source code and Demo available at http://xins.sourceforge.net/
I've tried to reproduce it (See code below) and had a slightly different
behaviour:
The init method is called twice but at the first request and it seems to be
done on 2 different objects as the exception is not thrown. The destroy method
is also called twice at the end.
public class SimpleServlet extends HttpServlet implements
javax.servlet.SingleThreadModel {
private boolean initialized = false;
private int initCount = 0;
public void init(ServletConfig config)
throws IllegalArgumentException, ServletException {
if (initialized) {
throw new ServletException("Servlet already initialized. Should not
happen according to the specs.");
}
initialized = true;
System.err.println(" Initialized -");
initCount++;
}
public void doGet(HttpServletRequest request,
HttpServletResponse response)
throws ServletException, IOException {
PrintWriter out = response.getWriter();
out.println("SimpleServlet Executed " + initCount);
out.flush();
out.close();
}
public void destroy() {
initialized = false;
System.err.println(" destroy");
}
}
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r831361 - /tomcat/trunk/java/javax/servlet/http/Cookie.java
Author: markt
Date: Fri Oct 30 16:02:40 2009
New Revision: 831361
URL: http://svn.apache.org/viewvc?rev=831361&view=rev
Log:
Re-add code that was incorrectly removed in recent changes
Modified:
tomcat/trunk/java/javax/servlet/http/Cookie.java
Modified: tomcat/trunk/java/javax/servlet/http/Cookie.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/javax/servlet/http/Cookie.java?rev=831361&r1=831360&r2=831361&view=diff
==
--- tomcat/trunk/java/javax/servlet/http/Cookie.java (original)
+++ tomcat/trunk/java/javax/servlet/http/Cookie.java Fri Oct 30 16:02:40 2009
@@ -563,7 +563,7 @@
for (int i = 0; i < len; i++) {
char c = value.charAt(i);
-if (c < 0x20 || c >= 0x7f ||
+if (c < 0x20 || c >= 0x7f || tspecials.indexOf(c) != -1 ||
(STRICT_NAMING && tspecials2.indexOf(c) != -1)) {
return false;
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r831442 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: fhanik
Date: Fri Oct 30 20:22:00 2009
New Revision: 831442
URL: http://svn.apache.org/viewvc?rev=831442&view=rev
Log:
votes
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=831442&r1=831441&r2=831442&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Fri Oct 30 20:22:00 2009
@@ -131,7 +131,7 @@
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=39231
http://people.apache.org/~markt/patches/2009-08-16-bug39231.patch
JAAS LoginContext expects a call to logout()
- +1: markt, jim
+ +1: markt, jim, fhanik
-1:
* Improve NIO connector shutdown time by doing shutdowns in parallel
@@ -213,7 +213,7 @@
Update AccessLogValve and ExtendedAccessLogValve with all the recent
threading
improvements
http://people.apache.org/~markt/patches/2009-08-15-AccessLogValve-tc6.patch
- +1: markt, kkolinko
+ +1: markt, kkolinko, fhanik
-1:
kkolinko: Also +1 to use StringBuilder everywhere in those classes, with
@@ -224,20 +224,28 @@
Better handling of PID files
https://issues.apache.org/bugzilla/attachment.cgi?id=24202
+1: markt
+ +1: fhanik (although, on .sh, I think we could get rid of 'Bootstrap stop'
by now, shutdown hooks have been available for quite some time)
-1:
+
+
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=44041
Threading issue in classloading. Adds a sync so please check performance
http://svn.apache.org/viewvc?rev=805182&view=rev
+1: markt
0: jim
- -1:
+ -1: fhanik, I would say a thread safe, yet concurrent implementation would do
+ synchronized (className.intern()) {
+//perform class loading
+ }
+ instead of synchronizing the entire method and hence only allowing class
loading one class at a time
+
* Allow per instance log4j.properties, JAR files (JDBC drivers) etc
http://svn.apache.org/viewvc?rev=810916&view=rev
http://svn.apache.org/viewvc?rev=810977&view=rev
http://svn.apache.org/viewvc?rev=821397&view=rev
- +1: markt, kkolinko
+ +1: markt, kkolinko, fhanik
-1:
kkolinko: re RUNNING.txt update: it'd be better to replace "eg" with "e.g."
@@ -292,7 +300,7 @@
http://svn.apache.org/viewvc?rev=706574&view=rev
Plus the last hunk for Socket.java in
https://issues.apache.org/bugzilla/attachment.cgi?id=24276
- +1: rjung, markt
+ +1: rjung, markt, fhanik
-1:
+1: kkolinko:(
Should be applied when tc-native 1.1.17 is released,
@@ -337,20 +345,20 @@
That's a problem in case a session listener needs the changed attribute.
Has already been fixed in trunk, OACC and tc5.5.x.
http://svn.apache.org/viewvc?rev=818062&view=rev (trunk)
- +1: rjung, pero
+ +1: rjung, pero, fhanik
-1:
* Fix memory leak causes by a JRE implementation change in 1.6.0_15 onwards
http://svn.apache.org/viewvc?view=revision&revision=828196
http://svn.apache.org/viewvc?view=revision&revision=830378
http://svn.apache.org/viewvc?view=revision&revision=830379
- +1: markt, kkolinko
+ +1: markt, kkolinko, fhanik
-1:
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48019
Be more careful about skipping over sections we aren't interested in
http://svn.apache.org/viewvc?view=revision&revision=828201
- +1: markt, kkolinko
+ +1: markt, kkolinko, fhanik
-1:
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48009
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
