DO NOT REPLY [Bug 47926] New: pathelement 'ant.jar' of path 'tomcat.classpath' is needless in build.xml
https://issues.apache.org/bugzilla/show_bug.cgi?id=47926 Summary: pathelement 'ant.jar' of path 'tomcat.classpath' is needless in build.xml Product: Tomcat 6 Version: 6.0.20 Platform: PC OS/Version: Linux Status: NEW Severity: trivial Priority: P2 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: qingyang...@qunar.com following is the relevant parts of the 'build.xml' file: ... ... ... ... However, if you delete the first item () in the path element whose id is 'tomcat.classpath', the target of 'compile' still runs successfully, and if you invoke ant as "ant -v", you can see that 'ant.jar' has already been included in the classpath. For example, the following is the output on my machine: ... ... Compiling 1052 source files to /home/xuqy/Downloads/apache-tomcat-6.0.20-src/output/classes [javac] Using modern compiler [javac] Compilation arguments: [javac] '-d' [javac] '/home/xuqy/Downloads/apache-tomcat-6.0.20-src/output/classes' [javac] '-classpath' [javac] '/home/xuqy/Downloads/apache-tomcat-6.0.20-src/output/classes:/home/xuqy/tomcat-base-path/eclipse/plugins/org.eclipse.jdt.core_3.3.1.v_780_R33x.jar:/usr/local/apache-ant-1.7.1/lib/ant-launcher.jar:/usr/local/apache-ant-1.7.1/lib/xercesImpl.jar:/usr/local/apache-ant-1.7.1/lib/ant-jdepend.jar:/usr/local/apache-ant-1.7.1/lib/ant-javamail.jar:/usr/local/apache-ant-1.7.1/lib/ant-commons-net.jar:/usr/local/apache-ant-1.7.1/lib/ant-apache-oro.jar:/usr/local/apache-ant-1.7.1/lib/ant.jar:/usr/local/apache-ant-1.7.1/lib/ant-weblogic.jar:/usr/local/apache-ant-1.7.1/lib/xml-apis.jar:/usr/local/apache-ant-1.7.1/lib/ant-jmf.jar:/usr/local/apache-ant-1.7.1/lib/ant-trax.jar:/usr/local/apache-ant-1.7.1/lib/ant-jsch.jar:/usr/local/apache-ant-1.7.1/lib/ant-commons-logging.jar:/usr/local/apache-ant-1.7.1/lib/ant-apache-regexp.jar:/usr/local/apache-ant-1.7.1/lib/ant-swing.jar:/usr/local/apache-ant-1.7.1/lib/ant-junit.jar:/usr/local/apache-ant-1.7.1/lib/ant-testutil.jar:/usr/local/apache-ant-1.7.1 /lib/ant-antlr.jar:/usr/local/apache-ant-1.7.1/lib/ant-jai.jar:/usr/local/apache-ant-1.7.1/lib/ant-nodeps.jar:/usr/local/apache-ant-1.7.1/lib/ant-apache-bsf.jar:/usr/local/apache-ant-1.7.1/lib/ant-apache-resolver.jar:/usr/local/apache-ant-1.7.1/lib/ant-netrexx.jar:/usr/local/apache-ant-1.7.1/lib/ant-starteam.jar:/usr/local/apache-ant-1.7.1/lib/ant-apache-log4j.jar:/usr/local/apache-ant-1.7.1/lib/ant-stylebook.jar:/usr/local/apache-ant-1.7.1/lib/ant-apache-bcel.jar:/usr/lib/jvm/java-6-sun-1.6.0.16/lib/tools.jar' [javac] '-sourcepath' [javac] '/home/xuqy/Downloads/apache-tomcat-6.0.20-src/java' [javac] '-target' [javac] '1.5' [javac] '-g' [javac] '-source' [javac] '1.5' -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r820710 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: fhanik Date: Thu Oct 1 16:36:11 2009 New Revision: 820710 URL: http://svn.apache.org/viewvc?rev=820710&view=rev Log: votes Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=820710&r1=820709&r2=820710&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Oct 1 16:36:11 2009 @@ -222,18 +222,19 @@ +1: fhanik -1: rjung: Note discussion at http://marc.info/?t=12518257461&r=1&w=2 + fhanik @rjung: The scheme for file:// has two slashes, that's the definition. * Allow per instance log4j.properties, JAR files (JDBC drivers) etc http://svn.apache.org/viewvc?rev=810916&view=rev http://svn.apache.org/viewvc?rev=810977&view=rev - +1: markt, rjung + +1: markt, rjung, fhanik -1: * Allow per instance configuration of JULI or log4j for core Tomcat logging This requires the classpath change above http://svn.apache.org/viewvc?rev=810976&view=rev - +1: markt, rjung + +1: markt, rjung, fhanik -1: rjung: I think you have to switch HOME and BASE in the following changed lines in logging.xml: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r810132 - /tomcat/tc6.0.x/trunk/STATUS.txt
I am in favor of using file.toURI().toString(), as proposed by Rainer. To construct an URL by simply prepending "file:" + several slashes to the path is simply wrong. Spaces are not allowed in an URL (see chapter 2.4.3 of RFC2396) and must be encoded as %20, as well as % symbols in the file name must be encoded as %25. The protocol handler for file: protocol unescapes %-encoded symbols when opening URLConnection to the file, so if the original file name contained '%' symbol, it should have been escaped. (sun.net.www.protocol.file.Handler#openConnection(..)) Best regards, Konstantin Kolinko 2009/9/1 Rainer Jung : > On 01.09.2009 20:48, Larry Isaacs wrote: >> Hi Filip, >> >> I have a vague recollection about tripping over this issue while working on >> the Tomcat support in the Eclipse Web Tools Platform. WTP has its own >> version(s) of VirtualWebappLoader, called WtpWebappLoader, to address it. >> If I'm recalling the issue correctly, pre-pending "file:/" worked on >> Windows, but not on Linux since an absolute path ended up as >> "file://somedir/...". I believe with the change below, pre-pending >> "file://" will work for Linux, but not for Windows, i.e. >> "file://C:/somedir/..." is going to have problems. If it helps, I went with >> the URL form "file:/somedir/..." and used the following code snippet to get >> it working for Windows and Linux in WtpWebappLoader: > > Good point. > >> >> String path = file.getAbsolutePath(); >> if (path.startsWith("/")) { >> path = "file:" + path; >> } else { >> path = "file:/" + path; >> } >> if (file.isDirectory()) { >> addRepository(path + "/"); >> } else { >> addRepository(path); > > Why not: file.toURI().toString() > > It seems this is not cheap, but should handle as much annoyances as > possible (drive letters, directory trailing slashes, UNC notation). > > Regards, > > Rainer > >>> -Original Message- >>> From: fha...@apache.org [mailto:fha...@apache.org] >>> Sent: Tuesday, September 01, 2009 1:22 PM >>> To: dev@tomcat.apache.org >>> Subject: svn commit: r810132 - /tomcat/tc6.0.x/trunk/STATUS.txt >>> >>> Author: fhanik >>> Date: Tue Sep 1 17:21:59 2009 >>> New Revision: 810132 >>> >>> URL: http://svn.apache.org/viewvc?rev=810132&view=rev >>> Log: >>> proposal >>> >>> Modified: >>> tomcat/tc6.0.x/trunk/STATUS.txt >>> >>> Modified: tomcat/tc6.0.x/trunk/STATUS.txt >>> URL: >>> http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=810132 >>> &r1=810131&r2=810132&view=diff >>> === >>> === >>> --- tomcat/tc6.0.x/trunk/STATUS.txt (original) >>> +++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Sep 1 17:21:59 2009 >>> @@ -321,3 +321,25 @@ >>> +1: funkman >>> -1: >>> >>> + >>> +* Fix VirtualWebappClassLoader file directives >>> + Index: java/org/apache/catalina/loader/VirtualWebappLoader.java >>> +=== >>> +--- java/org/apache/catalina/loader/VirtualWebappLoader.java >>> (revision 810099) >>> java/org/apache/catalina/loader/VirtualWebappLoader.java >>> (working copy) >>> +@@ -92,9 +92,9 @@ >>> + continue; >>> + } >>> + if (file.isDirectory()) { >>> +- addRepository("file:/" + file.getAbsolutePath() + >>> "/"); >>> ++ addRepository("file://" + file.getAbsolutePath() + >>> "/"); >>> + } else { >>> +- addRepository("file:/" + file.getAbsolutePath()); >>> ++ addRepository("file://" + file.getAbsolutePath()); >>> + } >>> + } >>> + >>> + +1: fhanik >>> + -1: >>> + >>> + >>> >>> >>> >>> - >>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >>> For additional commands, e-mail: dev-h...@tomcat.apache.org >>> >> >> > > -- > kippdata > informationstechnologie GmbH Tel: 0228 98549 -0 > Bornheimer Str. 33a Fax: 0228 98549 -50 > 53111 Bonn www.kippdata.de > > HRB 8018 Amtsgericht Bonn / USt.-IdNr. DE 196 457 417 > Geschäftsführer: Dr. Thomas Höfer, Rainer Jung, Sven Maurmann > === > kippdata > informationstechnologie GmbH Tel: +49 228 98549 -0 > Bornheimer Str. 33a Fax: +49 228 98549 -50 > D-53111 Bonn www.kippdata.de > > HRB 8018 Amtsgericht Bonn / USt.-IdNr. DE 196 457 417 > Geschäftsführer: Dr. Thomas Höfer, Rainer Jung, Sven Maurmann > > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For a
svn commit: r820858 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: kkolinko Date: Fri Oct 2 01:01:23 2009 New Revision: 820858 URL: http://svn.apache.org/viewvc?rev=820858&view=rev Log: votes Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=820858&r1=820857&r2=820858&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Fri Oct 2 01:01:23 2009 @@ -151,7 +151,7 @@ when I have done more testing) for embeddability become possible. Step 1: Clean-up http://svn.apache.org/viewvc?view=rev&revision=647344 - +1: markt + +1: markt, kkolinko -1: Step 2: Make validation configuration per-context http://svn.apache.org/viewvc?view=rev&revision=751502 @@ -202,7 +202,7 @@ 0: jim -1: -* Fix VirtualWebappClassLoader file directives +* Fix VirtualWebappLoader file directives Index: java/org/apache/catalina/loader/VirtualWebappLoader.java === --- java/org/apache/catalina/loader/VirtualWebappLoader.java (revision 810099) @@ -220,7 +220,7 @@ } +1: fhanik - -1: + -1: kkolinko: either way does not properly escape symbols, such as '%'. file.toURI().toString() has to be used here. See discussion. rjung: Note discussion at http://marc.info/?t=12518257461&r=1&w=2 fhanik @rjung: The scheme for file:// has two slashes, that's the definition. @@ -347,6 +347,10 @@ that file (because part of a webapp), but maybe it would be cleaner to do this for the installer target only, e.g. saving the file, fixcrlf, run nsi, restoring file. + kkolinko: Another way to fix it would be to place a copy of that file + into %CATALINA_HOME% (with proper CRLF endings) and display that one in + the installer, leaving the one in the ROOT webapp as is. Note, that we + already have these two copies of the file in our zip/tgz distributions. * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47499 Don't swallow BindException - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r820867 - /tomcat/tc5.5.x/trunk/STATUS.txt
Author: kkolinko Date: Fri Oct 2 02:18:33 2009 New Revision: 820867 URL: http://svn.apache.org/viewvc?rev=820867&view=rev Log: votes Modified: tomcat/tc5.5.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=820867&r1=820866&r2=820867&view=diff == --- tomcat/tc5.5.x/trunk/STATUS.txt (original) +++ tomcat/tc5.5.x/trunk/STATUS.txt Fri Oct 2 02:18:33 2009 @@ -151,7 +151,7 @@ They are not present in TC 6.0 and trunk. svn rm https://svn.apache.org/repos/asf/tomcat/tc5.5.x/trunk/connectors/jni/test svn rm https://svn.apache.org/repos/asf/tomcat/tc5.5.x/trunk/connectors/jni/examples - +1: rjung, markt + +1: rjung, markt, kkolinko -1: * Clean up native classes (connectors/jni) in TC 5.5: @@ -159,7 +159,7 @@ That's the only task used (called) by our top level build.xml - Remove build.properties.default. All that's needed is in the top level file - +1: rjung, markt + +1: rjung, markt, kkolinko -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47878 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r820874 - /tomcat/trunk/res/META-INF/bootstrap.jar.manifest
Author: kkolinko Date: Fri Oct 2 03:16:12 2009 New Revision: 820874 URL: http://svn.apache.org/viewvc?rev=820874&view=rev Log: tomcat-coyote.jar (former tomcat-util.jar before rev.389946) is not needed by bootstrap classes Modified: tomcat/trunk/res/META-INF/bootstrap.jar.manifest Modified: tomcat/trunk/res/META-INF/bootstrap.jar.manifest URL: http://svn.apache.org/viewvc/tomcat/trunk/res/META-INF/bootstrap.jar.manifest?rev=820874&r1=820873&r2=820874&view=diff == --- tomcat/trunk/res/META-INF/bootstrap.jar.manifest (original) +++ tomcat/trunk/res/META-INF/bootstrap.jar.manifest Fri Oct 2 03:16:12 2009 @@ -1,5 +1,5 @@ Manifest-Version: 1.0 Main-Class: org.apache.catalina.startup.Bootstrap -Class-Path: commons-daemon.jar tomcat-coyote.jar +Class-Path: commons-daemon.jar Specification-Title: Catalina Specification-Version: @VERSION_MAJOR_MINOR@ \ No newline at end of file - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r820880 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: kkolinko Date: Fri Oct 2 04:07:21 2009 New Revision: 820880 URL: http://svn.apache.org/viewvc?rev=820880&view=rev Log: votes, veto, proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=820880&r1=820879&r2=820880&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Fri Oct 2 04:07:21 2009 @@ -227,15 +227,24 @@ * Allow per instance log4j.properties, JAR files (JDBC drivers) etc http://svn.apache.org/viewvc?rev=810916&view=rev http://svn.apache.org/viewvc?rev=810977&view=rev - +1: markt, rjung, fhanik + +1: markt, rjung, fhanik, kkolinko -1: + kkolinko: A side effect of this change will be that when catalina.home + and catalina.base are the same, all the jar files will be listed twice. + I doubt that it will cause any issues (reading the same jar file twice + should be possible, and should not cause any additional locking or + whatever, though wasting resources). + An alternative would be to document this option and to instruct people to + modify catalina.properties, or we can guard against duplicate URLs in + o.a.c.startup.ClassLoaderFactory * Allow per instance configuration of JULI or log4j for core Tomcat logging This requires the classpath change above http://svn.apache.org/viewvc?rev=810976&view=rev +1: markt, rjung, fhanik - -1: + -1: kkolinko: we should not remove tomcat-juli.jar from bootstrap.jar.manifest + rjung: I think you have to switch HOME and BASE in the following changed lines in logging.xml: + If you have multiple instances of Tomcat, each with a separate @@ -246,7 +255,23 @@ I think that $CATALINA_BASE/bin is also to be mentioned as one you may need to create. Though it is mentioned in RUNNING.txt, it is a recent addition and I do not think that all configurations have it. -I have not reviewed the main part of this patch yet, so no vote. + kkolinko: Regarding /res/bootstrap.jar.manifest change: +It will cause problems e.g. in Eclipse IDE. +If I configure a Tomcat server instance there, it is created with a +classpath that consists only of bootstrap.jar and JDK's tools.jar. That +has to be changed to include tomcat-juli.jar as well. +While that is configurable, it is not so obvious (you have to click +some underlined text on some wordy page) and there can be a lot of +confusion when the product ceases functioning out-of-the box. + +I also like that I can run Tomcat easily by typing "java -jar bootstrap.jar start" +That option will also be lost. + +I think that we can implement the same feature by adding +${CATALINA_BASE}/bin/tomcat-juli.jar to the classpath before +bootstrap.jar We can propose people to manually remove +tomcat-juli.jar from ${CATALINA_HOME}/bin if they want, though I doubt +that that will be necessary. * Add additional permission required by JULI @@ -390,3 +415,8 @@ http://svn.apache.org/viewvc?rev=820132&view=rev +1: kkolinko -1: + +* Remove tomcat-coyote.jar reference from bootstrap.jar manifest file + http://svn.apache.org/viewvc?rev=820874&view=rev + +1: kkolinko + -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 47797] The body of the request is lost when you send the POST method !
https://issues.apache.org/bugzilla/show_bug.cgi?id=47797 Eugene changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED | --- Comment #12 from Eugene 2009-10-01 22:20:08 PDT --- I embed several count of code in Http11Processor and StandardEngineValve. In Http11Processor,process() I added next after invoke inputBuffer.parseRequestLine(); : if (request.unparsedURI().equals("/lost-post/generic")) { log.error("--"); StringBuffer stringBuffer = new StringBuffer(); for (int i = 0; i < inputBuffer.buf.length; i++) { stringBuffer.append((char) inputBuffer.buf[i]); } log.error(stringBuffer); log.error("LENGTH: "+ inputBuffer.buf.length); log.error("++"); } and in StandardEngineValve.invoke() I added next code: --- if (request.getWrapper().getName().equals("LostPostGenericServlet")) { log.error("-"); StringBuffer stringBuffer = new StringBuffer(); InputStream input = request.getInputStream(); int i=request.getContentLength(); int c; while (((c = input. read()) != -1) && (--i > 0)) { stringBuffer.append((char) c); } input.close(); log.error(stringBuffer); PrintWriter out = response.getWriter(); if (stringBuffer.length() > 0) { StringBuffer xmlBuffer = new StringBuffer(); xmlBuffer.append(""); xmlBuffer.append(""); xmlBuffer.append("OK"); xmlBuffer.append(""); out.print(xmlBuffer); System.out.println("OK"); } else { StringBuffer xmlBuffer2 = new StringBuffer(); xmlBuffer2.append(""); xmlBuffer2.append(""); xmlBuffer2.append("FAILED"); xmlBuffer2.append(""); out.print(xmlBuffer2); System.out.println("FAILED"); } out.close(); log.error("++"); return; } --- So added code in Http11Processor print entire buffer, whereas code in StandardEngineValve print content of body from CoyoteInputStream. When I increase loading at tomcat (with help of Grinder) happen this error, and code in Http11Processor print normal request with body, whereas code in StandardEngineValve print empty string: ** ... 2009-10-01 20:11:30,588 ERROR [Http11Processor] - 2009-10-01 20:11:30,589 ERROR [Http11Processor] POST /lost-post/generic HTTP/1.1 Accept-Encoding: gzip,deflate Content-Type: text/xml;charset=UTF-8 SOAPAction: "" User-Agent: Jakarta Commons-HttpClient/3.1 Host: 172.20.0.3:8080 Content-Length: 389 EISTMPull.getEntitlement 00020215B9FE DTV PPV e2:$Version="1"" ntent-type:application/x-www-form-urlencoded; charset=UTF-88 content-length:633 j_username=00%3A02%3A02%3A14%3A47%3A2e&j_password=702007D314410 2009-10-01 20:11:30,589 ERROR [Http11Processor] LENGTH: 8192 2009-10-01 20:11:30,589 ERROR [Http11Processor] ++ 2009-10-01 20:11:30,589 ERROR [StandardEngineValve] - 2009-10-01 20:11:30,589 ERROR [StandardEngineValve] 2009-10-01 20:11:30,590 ERROR [StandardEngineValve] ++ .. * Therefore error happen inside tomcat ! During parsing body of request. Often this happen during increase loading at other applications deployed in tomcat. I conclude several tomcat classes, which uses in JBossWeb, because don't know, which version of tomcat 5.5 used in JbossWeb 2.0.3.GA Many thanks in advance for any some help. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For addit
DO NOT REPLY [Bug 47797] The body of the request is lost when you send the POST method !
https://issues.apache.org/bugzilla/show_bug.cgi?id=47797 --- Comment #13 from Eugene 2009-10-01 22:21:35 PDT --- Created an attachment (id=24330) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24330) My Http11Processor class -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 47797] The body of the request is lost when you send the POST method !
https://issues.apache.org/bugzilla/show_bug.cgi?id=47797 --- Comment #14 from Eugene 2009-10-01 22:24:07 PDT --- Created an attachment (id=24331) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24331) My InputBuffer -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 47797] The body of the request is lost when you send the POST method !
https://issues.apache.org/bugzilla/show_bug.cgi?id=47797 --- Comment #15 from Eugene 2009-10-01 22:27:48 PDT --- Created an attachment (id=24332) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24332) My StandardEngineValve -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 47797] The body of the request is lost when you send the POST method !
https://issues.apache.org/bugzilla/show_bug.cgi?id=47797 --- Comment #16 from Eugene 2009-10-01 22:29:09 PDT --- This is link to svn at JBossWeb with tomcat 5.5.X inside: http://anonsvn.jboss.org/repos/jbossweb/branches/2.0.x -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 47930] New: PersistentManager (using filestore) can return different session objects linked to the same session ID, when Tomcat is restarted
https://issues.apache.org/bugzilla/show_bug.cgi?id=47930 Summary: PersistentManager (using filestore) can return different session objects linked to the same session ID, when Tomcat is restarted Product: Tomcat 6 Version: 6.0.20 Platform: PC OS/Version: Linux Status: NEW Severity: normal Priority: P2 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: sean.soerja...@smartsgroup.com Created an attachment (id=24333) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24333) Sample webapp and scripts to reproduce issue When using PersistentManager with a filestore backing, I've noticed that (near) simultaneous requests with the same session ID, can cause PersistentManager to return two different session objects, shortly after restarting Tomcat. I have included a sample webapp, with a test script to create simultaneous HTTP requests to a servlet, that reproduces this issue. General steps to reproduce: 0. Configure PersistentManager to use FileStore. 1. Make a HTTP request to a servlet, and establish a new session. Note the new session ID created on the server. 2. Restart Tomcat (cleanly shutdown and startup). 3. Shortly after Tomcat starts and initialises, make near simultaneous HTTP requests to a servlet using the previously established session cookie. 4. Output the session IDs and session object hashcodes on the server side, that is associated with each request. 5. Some of the reported session object hashcodes will be different (even though their session IDs are the same). Additionally the HttpSessionListener will report that the additional sessions are created/destroyed. Expected results: Session object hashcodes should be the same for the requests (and have the same session ID). Notes on the included attachment: - sessionTest.zip contains a sample webapp with two servlets. The LoginServlet establishes a new session for a request. The TestServlet will use the session cookie attached to a request, and will retrieve the session object (printing its ID and hex-encoded object hashcode). SessionListener will log each time a session is created or destroyed. - The session_test.sh script will automatically start/shutdown Tomcat, and make HTTP requests using curl. You may have to change the location of TOMCAT_HOME, the URL of the deployed webapp, and the COOKIE path. - Using the sample webapp and script will not always reproduce the issue. It may take a few goes for it to reproduce it. Example output: [tom...@localhost sessionTest]$ ./session_test.sh Starting Tomcat.. Logging in to init new session.. New sessiond ID: JSESSIONID=09DDD0198C190E3394C19808DD8E074A New session obj hashcode: 3e5e9db7 --- Shutting down Tomcat.. Starting Tomcat.. Session ID: JSESSIONID=09DDD0198C190E3394C19808DD8E074A Session obj hashcode: 46bb05de --- Session ID: JSESSIONID=09DDD0198C190E3394C19808DD8E074A Session obj hashcode: 46bb05de --- Session ID: JSESSIONID=09DDD0198C190E3394C19808DD8E074A Session obj hashcode: 68acbd3a --- Session ID: JSESSIONID=09DDD0198C190E3394C19808DD8E074A Session obj hashcode: 46bb05de --- Session ID: JSESSIONID=09DDD0198C190E3394C19808DD8E074A Session obj hashcode: 24bb6086 --- Session ID: JSESSIONID=09DDD0198C190E3394C19808DD8E074A Session obj hashcode: 24bb6086 --- Removing cookie /tmp/foo.cookie Shutting down Tomcat.. Notice that we have three different session objects tied to the same session ID, after the requests are made (with hashcodes: 46bb05de, 68acbd3a, 24bb6086). -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org