DO NOT REPLY [Bug 47918] New: Wrong description in o.a.c.startup.mbeans-desriptors.xml for the HostConfig operations

2009-09-30 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47918

   Summary: Wrong description in
o.a.c.startup.mbeans-desriptors.xml for the HostConfig
operations
   Product: Tomcat 7
   Version: trunk
  Platform: All
OS/Version: All
Status: NEW
  Keywords: PatchAvailable
  Severity: normal
  Priority: P2
 Component: Catalina
AssignedTo: dev@tomcat.apache.org
ReportedBy: u...@cscc.de
CC: u...@cscc.de


Created an attachment (id=24324)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24324)
Patch for Tomcat 7 trunk

I just came across this one yesterday while exploring how the whole deployment
process works.

The the following mbean operations for the mbean HostConfig in
o.a.c.startup.mbeans-desriptors.xml have all the same description "Add a web
application name to the serviced list":

addServiced, isServiced, removeServiced


This just looks ugly if somebody tries to discover the mbeans with for example
jconsole.

This bug is filed for Tomcate 7 but I have seen this in the lastes Tomcat 6
branch as well.

addServiced: Add a web application to the serviced list to show it gets
serviced by another component
isServiced: Is a web application serviced by another component
removeServiced: Remove a web application from the serviced list to show it
isn't serviced by another component


Patch is attached. I have done it with:

svn diff -x -u java\org\apache\catalina\startup\mbeans-descriptors.xml >
java.org.apache.catalina.startup.mbeans-descriptors.xml

under Windows.

-- 
Kind Regards
Uwe Günther

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 37848] Inappropriate Output From catalina.sh When No Terminal Available

2009-09-30 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=37848

Eric Herman  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |

--- Comment #2 from Eric Herman  2009-09-30 00:48:42 PDT ---
Shouldn't the "Using Security Manager" messages be similarly guarded?


diff -Naur original/apache-tomcat-6.0.20/bin/catalina.sh
bug37848/apache-tomcat-6.0.20/bin/catalina.sh
--- original/apache-tomcat-6.0.20/bin/catalina.sh2009-05-14
01:15:04.0 +0200
+++ bug37848/apache-tomcat-6.0.20/bin/catalina.sh2009-09-30
09:33:54.0 +0200
@@ -241,7 +241,9 @@
   else
 shift
 if [ "$1" = "-security" ] ; then
-  echo "Using Security Manager"
+  if [ $have_tty -eq 1 ]; then
+echo "Using Security Manager"
+  fi
   shift
   exec "$_RUNJDB" "$LOGGING_CONFIG" $JAVA_OPTS $CATALINA_OPTS \
 -Djava.endorsed.dirs="$JAVA_ENDORSED_DIRS" -classpath "$CLASSPATH" \
@@ -267,7 +269,9 @@

   shift
   if [ "$1" = "-security" ] ; then
-echo "Using Security Manager"
+if [ $have_tty -eq 1 ]; then
+  echo "Using Security Manager"
+fi
 shift
 exec "$_RUNJAVA" "$LOGGING_CONFIG" $JAVA_OPTS $CATALINA_OPTS \
   -Djava.endorsed.dirs="$JAVA_ENDORSED_DIRS" -classpath "$CLASSPATH" \
@@ -291,7 +295,9 @@
   shift
   touch "$CATALINA_BASE"/logs/catalina.out
   if [ "$1" = "-security" ] ; then
-echo "Using Security Manager"
+if [ $have_tty -eq 1 ]; then
+  echo "Using Security Manager"
+fi
 shift
 "$_RUNJAVA" "$LOGGING_CONFIG" $JAVA_OPTS $CATALINA_OPTS \
   -Djava.endorsed.dirs="$JAVA_ENDORSED_DIRS" -classpath "$CLASSPATH" \

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 47919] New: Log Tomcat & Java environment variables in addition to echoing to the screen

2009-09-30 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47919

   Summary: Log Tomcat & Java environment variables in addition to
echoing to the screen
   Product: Tomcat 6
   Version: unspecified
  Platform: PC
OS/Version: All
Status: NEW
  Severity: enhancement
  Priority: P2
 Component: Catalina
AssignedTo: dev@tomcat.apache.org
ReportedBy: e...@freesa.org


When looking at a catalina.out, it's not always clear what the environment
variables resolved to at the time the process was started.

This information may be echoed to the screen if not started by hand, but that
may be gone by the time we're looking at the log file.

It would be helpful to log these variables to the catalina.out at startup.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 47919] Log Tomcat & Java environment variables in addition to echoing to the screen

2009-09-30 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47919

--- Comment #1 from Eric Herman  2009-09-30 01:40:43 PDT ---
Created an attachment (id=24325)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24325)
example patch for logging environment variables to catalina.out at start time 

Perhaps doing something a little like this.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r820220 - /tomcat/trunk/java/org/apache/catalina/ha/backend/HeartbeatListener.java

2009-09-30 Thread jfclere
Author: jfclere
Date: Wed Sep 30 09:03:25 2009
New Revision: 820220

URL: http://svn.apache.org/viewvc?rev=820220&view=rev
Log:
Add port in the message.

Modified:
tomcat/trunk/java/org/apache/catalina/ha/backend/HeartbeatListener.java

Modified: 
tomcat/trunk/java/org/apache/catalina/ha/backend/HeartbeatListener.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ha/backend/HeartbeatListener.java?rev=820220&r1=820219&r2=820220&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/ha/backend/HeartbeatListener.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/ha/backend/HeartbeatListener.java Wed 
Sep 30 09:03:25 2009
@@ -113,7 +113,7 @@
 return;
 }
 String output = new String();
-output = "v=1&ready=" + coll.ready + "&busy=" + coll.busy;
+output = "v=1&ready=" + coll.ready + "&busy=" + coll.busy + 
"&port=" + port;
 try {
 sender.send(output);
 } catch (Exception ex) {



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 47919] Log Tomcat & Java environment variables in addition to echoing to the screen

2009-09-30 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47919

--- Comment #2 from Eric Herman  2009-09-30 03:32:30 PDT ---
or perhaps cleaner as:

diff -u catalina.sh.orig catalina.sh
--- catalina.sh.orig2009-09-30 10:22:39.039478613 +0200
+++ catalina.sh2009-09-30 11:26:31.606955254 +0200
@@ -265,6 +265,22 @@

   shift
   touch "$CATALINA_BASE"/logs/catalina.out
+
+  CATALINA_OUT="$CATALINA_BASE"/logs/catalina.out
+  cat <> $CATALINA_OUT
+Using CATALINA_BASE:  $CATALINA_BASE
+Using CATALINA_HOME:  $CATALINA_HOME
+Using CATALINA_TMPDIR:$CATALINA_TMPDIR
+Using JAVA_HOME:  $JAVA_HOME
+Using JRE_HOME:   $JRE_HOME
+Using _RUNJAVA:   $_RUNJAVA
+Using _RUNJAVA -version   $($_RUNJAVA -version 2>&1)
+Using JAVA_OPTS:  $JAVA_OPTS
+Using CATALINA_OPTS:  $CATALINA_OPTS
+Using JAVA_ENDORSED_DIRS: $JAVA_ENDORSED_DIRS
+Using CLASSPATH:  $CLASSPATH
+EOF
+
   if [ "$1" = "-security" ] ; then
 echo "Using Security Manager"
 shift

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org