DO NOT REPLY [Bug 47797] The body of the request is lost when you send the POST method !
https://issues.apache.org/bugzilla/show_bug.cgi?id=47797 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||FIXED --- Comment #11 from Mark Thomas 2009-09-29 13:00:38 BST --- If this issue is with 5.5.21 and I can't reproduce it with 5.5.x then it has already been fixed. Tomcat does not provide patches for older versions. Upgrading is your only option. You would be best following this up with the JBoss folks. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r819899 - /tomcat/trunk/java/org/apache/tomcat/util/net/SocketProperties.java
Author: jfclere Date: Tue Sep 29 12:20:57 2009 New Revision: 819899 URL: http://svn.apache.org/viewvc?rev=819899&view=rev Log: timeout can't be negative... Modified: tomcat/trunk/java/org/apache/tomcat/util/net/SocketProperties.java Modified: tomcat/trunk/java/org/apache/tomcat/util/net/SocketProperties.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/SocketProperties.java?rev=819899&r1=819898&r2=819899&view=diff == --- tomcat/trunk/java/org/apache/tomcat/util/net/SocketProperties.java (original) +++ tomcat/trunk/java/org/apache/tomcat/util/net/SocketProperties.java Tue Sep 29 12:20:57 2009 @@ -203,7 +203,7 @@ if (soLingerOn != null && soLingerTime != null) socket.setSoLinger(soLingerOn.booleanValue(), soLingerTime.intValue()); -if (soTimeout != null) +if (soTimeout != null && soTimeout.intValue() >= 0) socket.setSoTimeout(soTimeout.intValue()); if (tcpNoDelay != null) socket.setTcpNoDelay(tcpNoDelay.booleanValue()); @@ -222,7 +222,7 @@ performanceBandwidth.intValue()); if (soReuseAddress != null) socket.setReuseAddress(soReuseAddress.booleanValue()); -if (soTimeout != null) +if (soTimeout != null && soTimeout.intValue() >= 0) socket.setSoTimeout(soTimeout.intValue()); } @@ -422,4 +422,4 @@ -} \ No newline at end of file +} - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r820092 - /tomcat/trunk/webapps/manager/WEB-INF/web.xml
Author: kkolinko Date: Tue Sep 29 21:18:09 2009 New Revision: 820092 URL: http://svn.apache.org/viewvc?rev=820092&view=rev Log: Correct a pair of misprints Modified: tomcat/trunk/webapps/manager/WEB-INF/web.xml Modified: tomcat/trunk/webapps/manager/WEB-INF/web.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/manager/WEB-INF/web.xml?rev=820092&r1=820091&r2=820092&view=diff == --- tomcat/trunk/webapps/manager/WEB-INF/web.xml (original) +++ tomcat/trunk/webapps/manager/WEB-INF/web.xml Tue Sep 29 21:18:09 2009 @@ -93,7 +93,7 @@ - HTML Manger interface (for humans) + HTML Manager interface (for humans) /html/* @@ -102,7 +102,7 @@ - Text Manger interface (for scripts) + Text Manager interface (for scripts) /text/* - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r820110 - in /tomcat/trunk/webapps/manager: sessionDetail.jsp sessionsList.jsp
Author: kkolinko Date: Tue Sep 29 22:24:47 2009 New Revision: 820110 URL: http://svn.apache.org/viewvc?rev=820110&view=rev Log: Fix display of sessionList and sessionDetail pages in IE 6 and IE 7: do not include ASF License comment into generated output. Because of that large comment that precedes other content those browsers try to display these pages as generic XML, and fail. Modified: tomcat/trunk/webapps/manager/sessionDetail.jsp tomcat/trunk/webapps/manager/sessionsList.jsp Modified: tomcat/trunk/webapps/manager/sessionDetail.jsp URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/manager/sessionDetail.jsp?rev=820110&r1=820109&r2=820110&view=diff == --- tomcat/trunk/webapps/manager/sessionDetail.jsp (original) +++ tomcat/trunk/webapps/manager/sessionDetail.jsp Tue Sep 29 22:24:47 2009 @@ -1,5 +1,5 @@ - +--%> <%...@page session="false" contentType="text/html; charset=ISO-8859-1" %> <%...@page import="java.util.Enumeration" %> <%...@page import="javax.servlet.http.HttpSession" %> Modified: tomcat/trunk/webapps/manager/sessionsList.jsp URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/manager/sessionsList.jsp?rev=820110&r1=820109&r2=820110&view=diff == --- tomcat/trunk/webapps/manager/sessionsList.jsp (original) +++ tomcat/trunk/webapps/manager/sessionsList.jsp Tue Sep 29 22:24:47 2009 @@ -1,5 +1,5 @@ - +--%> <%...@page session="false" contentType="text/html; charset=ISO-8859-1" %> <%...@page import="java.util.Collection" %> <%...@page import="java.util.Iterator" %> - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r820117 - in /tomcat/trunk/webapps/manager: 401.jsp 404.jsp
Author: kkolinko
Date: Tue Sep 29 22:48:09 2009
New Revision: 820117
URL: http://svn.apache.org/viewvc?rev=820117&view=rev
Log:
Do not include ASF License comment into generated output
Modified:
tomcat/trunk/webapps/manager/401.jsp
tomcat/trunk/webapps/manager/404.jsp
Modified: tomcat/trunk/webapps/manager/401.jsp
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/manager/401.jsp?rev=820117&r1=820116&r2=820117&view=diff
==
--- tomcat/trunk/webapps/manager/401.jsp (original)
+++ tomcat/trunk/webapps/manager/401.jsp Tue Sep 29 22:48:09 2009
@@ -1,4 +1,4 @@
-
+--%>
<%
response.setHeader("WWW-Authenticate", "Basic realm=\"Tomcat Manager
Application\"");
%>
Modified: tomcat/trunk/webapps/manager/404.jsp
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/manager/404.jsp?rev=820117&r1=820116&r2=820117&view=diff
==
--- tomcat/trunk/webapps/manager/404.jsp (original)
+++ tomcat/trunk/webapps/manager/404.jsp Tue Sep 29 22:48:09 2009
@@ -1,4 +1,4 @@
-
+--%>
<%@ page import="org.apache.catalina.util.RequestUtil" %>
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r820118 - /tomcat/trunk/webapps/manager/401.jsp
Author: kkolinko Date: Tue Sep 29 22:54:17 2009 New Revision: 820118 URL: http://svn.apache.org/viewvc?rev=820118&view=rev Log: Correct wording Modified: tomcat/trunk/webapps/manager/401.jsp Modified: tomcat/trunk/webapps/manager/401.jsp URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/manager/401.jsp?rev=820118&r1=820117&r2=820118&view=diff == --- tomcat/trunk/webapps/manager/401.jsp (original) +++ tomcat/trunk/webapps/manager/401.jsp Tue Sep 29 22:54:17 2009 @@ -58,7 +58,7 @@ status pages manager-jmx - allows access to the JMX proxy and the status pages - manager-status - allows access to the just status pages + manager-status - allows access to the status pages only - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r820123 - in /tomcat/trunk/webapps/manager: 401.jsp 404.jsp
Author: kkolinko
Date: Tue Sep 29 23:23:11 2009
New Revision: 820123
URL: http://svn.apache.org/viewvc?rev=820123&view=rev
Log:
Do proper nesting of HTML tags and add DOCTYPE declaration.
Modified:
tomcat/trunk/webapps/manager/401.jsp
tomcat/trunk/webapps/manager/404.jsp
Modified: tomcat/trunk/webapps/manager/401.jsp
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/manager/401.jsp?rev=820123&r1=820122&r2=820123&view=diff
==
--- tomcat/trunk/webapps/manager/401.jsp (original)
+++ tomcat/trunk/webapps/manager/401.jsp Tue Sep 29 23:23:11 2009
@@ -17,10 +17,11 @@
<%
response.setHeader("WWW-Authenticate", "Basic realm=\"Tomcat Manager
Application\"");
%>
+http://www.w3.org/TR/html4/strict.dtd";>
401 Unauthorized
-
svn commit: r820132 - in /tomcat/trunk: java/org/apache/catalina/manager/HTMLManagerServlet.java webapps/manager/sessionsList.jsp
Author: kkolinko
Date: Wed Sep 30 00:01:17 2009
New Revision: 820132
URL: http://svn.apache.org/viewvc?rev=820132&view=rev
Log:
Do not reuse sessionsList window to show sessionsDetail.
It adds more sense to the "Close window" button on that page.
Modified:
tomcat/trunk/java/org/apache/catalina/manager/HTMLManagerServlet.java
tomcat/trunk/webapps/manager/sessionsList.jsp
Modified: tomcat/trunk/java/org/apache/catalina/manager/HTMLManagerServlet.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/manager/HTMLManagerServlet.java?rev=820132&r1=820131&r2=820132&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/manager/HTMLManagerServlet.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/manager/HTMLManagerServlet.java Wed
Sep 30 00:01:17 2009
@@ -985,7 +985,7 @@
" {2}\n" +
" {3}\n" +
" " +
-"{5}\n";
+"{5}\n";
private static final String MANAGER_APP_ROW_BUTTON_SECTION =
" \n" +
Modified: tomcat/trunk/webapps/manager/sessionsList.jsp
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/manager/sessionsList.jsp?rev=820132&r1=820131&r2=820132&view=diff
==
--- tomcat/trunk/webapps/manager/sessionsList.jsp (original)
+++ tomcat/trunk/webapps/manager/sessionsList.jsp Wed Sep 30 00:01:17 2009
@@ -99,7 +99,7 @@
%>
-<%= JspHelper.escapeXml(currentSessionId)
%>
+<%= JspHelper.escapeXml(currentSessionId)
%>
<%=
JspHelper.guessDisplayLocaleFromSession(currentSession) %>
<%=
JspHelper.guessDisplayUserFromSession(currentSession) %>
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r820135 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: kkolinko Date: Wed Sep 30 00:32:53 2009 New Revision: 820135 URL: http://svn.apache.org/viewvc?rev=820135&view=rev Log: vote and proposals Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=820135&r1=820134&r2=820135&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Wed Sep 30 00:32:53 2009 @@ -355,5 +355,15 @@ Correct submit URL so it works behind a reverse proxy for session list page Patch by Maik Jablonski http://svn.apache.org/viewvc?rev=819361&view=rev - +1: markt + +1: markt, kkolinko -1: + +* Fix display of sessionList and sessionDetail pages in Internet Explorer + http://svn.apache.org/viewvc?rev=820110&view=rev + +1: kkolinko + -1: + +* Do not reuse sessionsList window to show sessionsDetail + http://svn.apache.org/viewvc?rev=820132&view=rev + +1: kkolinko + -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r820153 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: kkolinko
Date: Wed Sep 30 02:41:25 2009
New Revision: 820153
URL: http://svn.apache.org/viewvc?rev=820153&view=rev
Log:
votes
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=820153&r1=820152&r2=820153&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Wed Sep 30 02:41:25 2009
@@ -239,21 +239,39 @@
lines in logging.xml:
+ If you have multiple instances of Tomcat, each with a separate
+ $CATALINA_HOME but a shared
$CATALINA_BASE then
+ kkolinko: in logging.xml:
++ Note that you may need to create a
++ $CATALINA_BASE/lib directory.
+I think that $CATALINA_BASE/bin is also to be mentioned as one you may
+need to create. Though it is mentioned in RUNNING.txt, it is a recent
+addition and I do not think that all configurations have it.
+I have not reviewed the main part of this patch yet, so no vote.
+
* Add additional permission required by JULI
http://svn.apache.org/viewvc?rev=813001&view=rev
- +1: markt, rjung
+ +1: markt, rjung, kkolinko
-1:
rjung: Since the above patches now prepare for using juli optionally out of
CATALINA_BASE, shouldn't we also add that location as a codeBase?
markt: Maybe add a comment but not an explicit permission?
rjung: Comment sounds good.
+ kkolinko: (
+ Regarding the setContextClassLoader permission,
+ for reference - the piece of 6u14 code that causes it:
+ http://markmail.org/message/nxnyxk2fnsl6uxe6
+
+ Regarding CATALINA_BASE juli:
+ Comment is good
+ E.g., there are permissions for ${catalina.home}/lib/
+ but I do not remember anyone asking for ones for ${catalina.base}/lib/
+ )
* Additional fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=45785
for extension validator
http://svn.apache.org/viewvc?rev=813013&view=rev
Based on a patch by Rolf Wojtech
- +1: markt, rjung
+ +1: markt, rjung, kkolinko
-1:
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47824
@@ -265,18 +283,18 @@
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47796
Fix OpenEJB integration. Reset annotation processor on context stop.
https://issues.apache.org/bugzilla/attachment.cgi?id=24222
- +1: markt, rjung
+ +1: markt, rjung, kkolinko
-1:
* Make FileHandler.java extensible
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/juli/FileHandler.java?r1=666232&r2=709018&pathrev=793882&view=patch
- +1: fhanik, jim, markt
+ +1: fhanik, jim, markt, kkolinko
-1:
* Allow configurable buffer size of loggers
http://svn.apache.org/viewvc?rev=814708&view=rev
http://svn.apache.org/viewvc?rev=814876&view=rev
- +1: fhanik, jim, markt
+ +1: fhanik, jim, markt, kkolinko
-1:
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46950
@@ -314,7 +332,7 @@
* Fix copyright year on manager app
http://svn.apache.org/viewvc?rev=817442&view=rev
- +1: markt, rjung
+ +1: markt, rjung, kkolinko
-1:
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47267
@@ -332,7 +350,7 @@
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47499
Don't swallow BindException
https://issues.apache.org/bugzilla/attachment.cgi?id=24302
- +1: markt, rjung
+ +1: markt, rjung, kkolinko
-1:
* Fix cluster replication problem: session expiration uses a replication
@@ -348,7 +366,7 @@
Don't rely on the platform default encoding being suitable to parse the
session ID
http://svn.apache.org/viewvc?rev=819339&view=rev
- +1: markt, pero
+ +1: markt, pero, kkolinko
-1:
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47324
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r820155 - /tomcat/tc5.5.x/trunk/STATUS.txt
Author: kkolinko
Date: Wed Sep 30 02:50:10 2009
New Revision: 820155
URL: http://svn.apache.org/viewvc?rev=820155&view=rev
Log:
votes
Modified:
tomcat/tc5.5.x/trunk/STATUS.txt
Modified: tomcat/tc5.5.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=820155&r1=820154&r2=820155&view=diff
==
--- tomcat/tc5.5.x/trunk/STATUS.txt (original)
+++ tomcat/tc5.5.x/trunk/STATUS.txt Wed Sep 30 02:50:10 2009
@@ -69,7 +69,7 @@
* Fix a couple of Java 1.5 uses that should be 1.4 compatible
http://people.apache.org/~markt/patches/2009-08-12-tc5.5.x-java14.patch
- +1: markt, rjung
+ +1: markt, rjung, kkolinko
-1:
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=42390
@@ -105,7 +105,7 @@
* Add additional permission required by JULI
http://svn.apache.org/viewvc?rev=813001&view=rev
- +1: markt, rjung
+ +1: markt, rjung, kkolinko
-1:
rjung: Should we also add ${catalina.base}/bin/tomcat-juli.jar as a codeBase?
@@ -141,7 +141,7 @@
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47225
Buffer length should be end-offset
http://svn.apache.org/viewvc?rev=815972&view=rev
- +1: markt, rjung
+ +1: markt, rjung, kkolinko
-1:
* Remove native test and examples classes from TC 5.5
@@ -170,7 +170,7 @@
* Fix copyright year on manager app
http://svn.apache.org/viewvc?rev=817442&view=rev
- +1: markt, rjung
+ +1: markt, rjung, kkolinko
-1:
* Fix cluster replication problem for o.a.c.ha: session expiration
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
