DO NOT REPLY [Bug 47769] New: documentation on web.xml resource-ref does'nt state optional

2009-08-31 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47769

   Summary: documentation on web.xml resource-ref does'nt state
optional
   Product: Tomcat 6
   Version: unspecified
  Platform: PC
OS/Version: Windows XP
Status: NEW
  Severity: normal
  Priority: P2
 Component: Documentation
AssignedTo: dev@tomcat.apache.org
ReportedBy: mgai...@hotmail.com


--- Comment #0 from Martin Gainty  2009-08-31 04:49:13 PDT 
---
 from us...@tomcat.apache.org
 There has to be some use of that resource-ref element. All the Tomcat
> examples and tutorials instruct you to create this element. Someone
> really badly wants you to use it, yet it seemingly has not function
> whatsoever. Something just doesn't add up, or maybe it's just me...

It's not just you. I've also been wondering why you should need it when
obviously you don't as your  works without a .


if web.xml  and  tags are optional 
could the documentation be updated to say web.xml  and
 tags are 'optional'


change tomcat-docs/config/context.html#Resource Definitions
You can declare the characteristics of the resource to be returned for JNDI
lookups of  and  elements in the web
application deployment descriptor. You MUST also define the needed resource
parameters as attributes of the Resource element, to configure the object
factory to be used (if not known to Tomcat already), and the properties used to
configure that object factory.

change Documentation to:
Optionally you can declare the characteristics of the resource to be returned
for JNDI lookups of  and  elements in the web
application deployment descriptor. Be advised that both  and
 tags are OPTIONAL tags within web.xml
You MUST define the needed resource parameters as attributes of the Resource
element, to configure the object factory to be used (if not known to Tomcat
already), and the properties used to configure that object factory.
The ApplicationContext.xml  tag within  is mandatory for the
resource to be recognised.


The valid attributes for a  element are as follows:
...

Thanks,
Martin-
For example, you can create a resource definition like this:

Thanks 
Martin

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 45255] support disable jsessionid from url against session fixation attacks

2009-08-31 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45255



--- Comment #15 from Giampaolo Tomassoni  2009-08-31 
06:10:36 PDT ---
I would urge to put Sellars' patch into the next Tomcat 6 version. It may not
be the final weapon against session fixation (also a cookie-based attack seems
possibile to me), but it is definitely good in fixing plenty of problems with
search engines and ugly URLs...

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r809575 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-08-31 Thread funkman
Author: funkman
Date: Mon Aug 31 13:24:49 2009
New Revision: 809575

URL: http://svn.apache.org/viewvc?rev=809575&view=rev
Log:
some votes

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=809575&r1=809574&r2=809575&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Mon Aug 31 13:24:49 2009
@@ -82,7 +82,7 @@
 
 * Dont try to report thread counts when using an executor from outside
   http://people.apache.org/~fhanik/connector-thread-report.patch
-  +1: fhanik, kkolinko
+  +1: fhanik, kkolinko,funkman
   +1: markt - would 0 make more sense rather than -1? Happy with either
   -1: 
 
@@ -105,7 +105,7 @@
   https://issues.apache.org/bugzilla/show_bug.cgi?id=37933 and implements an
   alternative that doesn't have the side effects described in 38797
   http://svn.apache.org/viewvc?rev=791224&view=rev
-  +1: markt, kkolinko
+  +1: markt, kkolinko,funkman
   -1:
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47478
@@ -150,7 +150,7 @@
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47515
   https://issues.apache.org/bugzilla/attachment.cgi?id=23973
-  +1: fhanik, kkolinko, markt
+  +1: fhanik, kkolinko, markt,funkman
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47413
@@ -158,13 +158,13 @@
   Without coercion, the concatenation of ((Object)null) + string results in
   "null" being printed.
   http://svn.apache.org/viewvc?rev=795466&view=rev
-  +1: kkolinko, markt, rjung
+  +1: kkolinko, markt, rjung, funkman
   -1: 
 
 * Fix the JDBC driver clean-up
   http://svn.apache.org/viewvc?view=rev&revision=789389
   See below for additional fix required
-  +1: markt, rjung
+  +1: markt, rjung, funkman
   -1: 
   rjung: I don't really like the implicit 4KB class size limit.
   I understand your rationale, but we don't know enough about other JVMs
@@ -174,13 +174,13 @@
 
 * Fix NPE observed when unpackWARs="false" with above fix
   http://svn.apache.org/viewvc?view=rev&revision=805153
-  +1: markt
+  +1: markt, funkman
   -1: 
 
 * Port Active Directory improvements to JNDIREalm from trunk
   Patch testing successfully by willing volunteer on the users list
   http://people.apache.org/~markt/patches/2009-08-06-ADforJNDIRealm.patch
-  +1: markt, kkolinko
+  +1: markt, kkolinko, funkman
   -1: 
   kkolinko: (
  There are several (two) places with a loop printing containerLog.debug(
@@ -237,14 +237,14 @@
 * Expose filter configuration via JMX (read-only)
   Based on a patch by Xie Xiaodong as part of GSOC2009.
   http://svn.apache.org/viewvc?rev=802727&view=rev
-  +1: markt
+  +1: markt, funkman
   -1: 
 
 * Use platform MBean server rather than creating a new one. Makes it possible 
to
   connect JConsole and other JMX tools to locally running Tomcat instances
   without any config changes to Tomcat
   http://svn.apache.org/viewvc?rev=677910&view=rev 
-  +1: markt
+  +1: markt, funkman
   -1: 
 
 * Add remote JMX listener. Enables JMX to be configured so that it can be used
@@ -252,19 +252,19 @@
   uses one fixed and one random port.
   Needs the platform MBean server fix above to be really useful
   http://people.apache.org/~markt/patches/2009-08-12-jmx-remote.patch
-  +1: markt
+  +1: markt, funkman
   -1: 
 
 * Make context deployment error message more meaningful
   http://svn.apache.org/viewvc?rev=802940&view=rev
-  +1: markt, kkolinko
+  +1: markt, kkolinko, funkman
   -1: 
 
 * Additional patch required for 
   https://issues.apache.org/bugzilla/show_bug.cgi?id=47046
   Clean up Jk components that only exist in the 6.0.x and were hence missed
   https://issues.apache.org/bugzilla/attachment.cgi?id=24125
-  +1: markt
+  +1: markt, funkman
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45403
@@ -275,14 +275,14 @@
 - test on linux in normal and failure modes
   http://svn.apache.org/viewvc?rev=804462&view=rev
   http://svn.apache.org/viewvc?rev=804544&view=rev
-  +1: kkolinko, markt
+  +1: kkolinko, markt, funkman
   -1:
 
 * Perform deserialization with the context class loader set.
   This ensures that code that actually executes Class.forName(...,classloader) 
during this phase
   works properly. 
http://svn.apache.org/viewvc?rev=804057&view=rev
-  +1: fhanik, markt, kkolinko
+  +1: fhanik, markt, kkolinko,funkman
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47158
@@ -299,7 +299,7 @@
   simple tags and tags and can't find any regression issues. The TCK also
   passes.
   http://svn.apache.org/viewvc?rev=804734&view=rev
-  +1: markt
+  +1: markt, funkman
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47699
@@ -312,4 +312,5 @@
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=44041
   Threading issue in classloading. Adds a sync so please check performance
   +1:

svn commit: r809603 - /tomcat/trunk/java/org/apache/catalina/manager/ManagerServlet.java

2009-08-31 Thread funkman
Author: funkman
Date: Mon Aug 31 14:17:37 2009
New Revision: 809603

URL: http://svn.apache.org/viewvc?rev=809603&view=rev
Log:
https://issues.apache.org/bugzilla/show_bug.cgi?id=47705

ArithmeticException: / by zero when expiring sessions via manager 


Modified:
tomcat/trunk/java/org/apache/catalina/manager/ManagerServlet.java

Modified: tomcat/trunk/java/org/apache/catalina/manager/ManagerServlet.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/manager/ManagerServlet.java?rev=809603&r1=809602&r2=809603&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/manager/ManagerServlet.java (original)
+++ tomcat/trunk/java/org/apache/catalina/manager/ManagerServlet.java Mon Aug 
31 14:17:37 2009
@@ -1106,6 +1106,8 @@
 int histoInterval = maxInactiveInterval / maxCount;
 if ( histoInterval * maxCount < maxInactiveInterval ) 
 histoInterval++;
+if (0==histoInterval)
+histoInterval=1;
 maxCount = maxInactiveInterval / histoInterval;
 if ( histoInterval * maxCount < maxInactiveInterval ) 
 maxCount++;



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r809605 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-08-31 Thread funkman
Author: funkman
Date: Mon Aug 31 14:19:52 2009
New Revision: 809605

URL: http://svn.apache.org/viewvc?rev=809605&view=rev
Log:
add https://issues.apache.org/bugzilla/show_bug.cgi?id=47705

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=809605&r1=809604&r2=809605&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Mon Aug 31 14:19:52 2009
@@ -314,3 +314,10 @@
   +1: markt
   0: Where's the patch?
   -1: 
+
+* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47705
+  ArithmeticException: / by zero when expiring sessions via manager 
+  http://svn.apache.org/viewvc?rev=809603&view=rev
+  +1: funkman
+  -1:
+



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 47705] ArithmeticException: / by zero when expiring sessions via manager

2009-08-31 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47705



--- Comment #1 from Tim Funk  2009-08-31 07:20:36 PDT ---
Fixed in trunk

http://svn.apache.org/viewvc?rev=809603&view=rev

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 47378] welcome-file ignores servlet mapping

2009-08-31 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47378


Tim Funk  changed:

   What|Removed |Added

   Platform|PC  |All
 OS/Version|Windows XP  |All
   Severity|major   |enhancement


--- Comment #19 from Tim Funk  2009-08-31 07:02:01 PDT ---
Applied this to trunk - so it should make its way into tomcat7
http://svn.apache.org/viewvc?rev=809596&view=rev

I am not proposing this for backport to tomcat 6. But wouldn't be against it if
it were proposed. So I'm moving this to enhancement.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r809596 - /tomcat/trunk/java/org/apache/tomcat/util/http/mapper/Mapper.java

2009-08-31 Thread funkman
Author: funkman
Date: Mon Aug 31 13:59:00 2009
New Revision: 809596

URL: http://svn.apache.org/viewvc?rev=809596&view=rev
Log:
Allow welcome files without a physical backing.
Inspired by this bug https://issues.apache.org/bugzilla/show_bug.cgi?id=47378



Modified:
tomcat/trunk/java/org/apache/tomcat/util/http/mapper/Mapper.java

Modified: tomcat/trunk/java/org/apache/tomcat/util/http/mapper/Mapper.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/http/mapper/Mapper.java?rev=809596&r1=809595&r2=809596&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/http/mapper/Mapper.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/http/mapper/Mapper.java Mon Aug 31 
13:59:00 2009
@@ -804,6 +804,36 @@
 
 }
 
+/* welcome file processing - take 2
+ * Now that we have looked for welcome files with a physical
+ * backing, now look for an extension mapping listed
+ * but may not have a physical backing to it. This is for 
+ * the case of index.jsf, index.do, etc.
+ * A watered down version of rule 4
+ */
+if (mappingData.wrapper == null) {
+boolean checkWelcomeFiles = checkJspWelcomeFiles;
+if (!checkWelcomeFiles) {
+char[] buf = path.getBuffer();
+checkWelcomeFiles = (buf[pathEnd - 1] == '/');
+}
+if (checkWelcomeFiles) {
+for (int i = 0; (i < context.welcomeResources.length)
+ && (mappingData.wrapper == null); i++) {
+path.setOffset(pathOffset);
+path.setEnd(pathEnd);
+path.append(context.welcomeResources[i], 0,
+context.welcomeResources[i].length());
+path.setOffset(servletPath);
+internalMapExtensionWrapper(extensionWrappers,
+path, mappingData);
+}
+
+path.setOffset(servletPath);
+path.setEnd(pathEnd);
+}
+}
+
 
 // Rule 7 -- Default servlet
 if (mappingData.wrapper == null && !checkJspWelcomeFiles) {



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r809661 - in /tomcat/tc5.5.x/trunk/container/modules: cluster/src/share/org/apache/catalina/cluster/mcast/McastServiceImpl.java groupcom/src/share/org/apache/catalina/tribes/membership/Mca

2009-08-31 Thread rjung
Author: rjung
Date: Mon Aug 31 17:01:44 2009
New Revision: 809661

URL: http://svn.apache.org/viewvc?rev=809661&view=rev
Log:
Fix comment - no functional change.

The comment was misleading, because we changed
the value of the flag without correcting the comment.

Modified:

tomcat/tc5.5.x/trunk/container/modules/cluster/src/share/org/apache/catalina/cluster/mcast/McastServiceImpl.java

tomcat/tc5.5.x/trunk/container/modules/groupcom/src/share/org/apache/catalina/tribes/membership/McastServiceImpl.java

Modified: 
tomcat/tc5.5.x/trunk/container/modules/cluster/src/share/org/apache/catalina/cluster/mcast/McastServiceImpl.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/container/modules/cluster/src/share/org/apache/catalina/cluster/mcast/McastServiceImpl.java?rev=809661&r1=809660&r2=809661&view=diff
==
--- 
tomcat/tc5.5.x/trunk/container/modules/cluster/src/share/org/apache/catalina/cluster/mcast/McastServiceImpl.java
 (original)
+++ 
tomcat/tc5.5.x/trunk/container/modules/cluster/src/share/org/apache/catalina/cluster/mcast/McastServiceImpl.java
 Mon Aug 31 17:01:44 2009
@@ -183,7 +183,14 @@
 } else {
 socket = new MulticastSocket(port);
 }
-socket.setLoopbackMode(false); //hint that we don't need loop back 
messages
+
+/**
+ * The argument of setLoopbackMode() is named disable.
+ * We set it to false, because we need loopback messages for the case
+ * when multiple cluster nodes reside on the same machine.
+ */
+socket.setLoopbackMode(false);
+
 if (mcastBindAddress != null) {
if(log.isInfoEnabled())
 log.info("Setting multihome multicast interface to:" +

Modified: 
tomcat/tc5.5.x/trunk/container/modules/groupcom/src/share/org/apache/catalina/tribes/membership/McastServiceImpl.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/container/modules/groupcom/src/share/org/apache/catalina/tribes/membership/McastServiceImpl.java?rev=809661&r1=809660&r2=809661&view=diff
==
--- 
tomcat/tc5.5.x/trunk/container/modules/groupcom/src/share/org/apache/catalina/tribes/membership/McastServiceImpl.java
 (original)
+++ 
tomcat/tc5.5.x/trunk/container/modules/groupcom/src/share/org/apache/catalina/tribes/membership/McastServiceImpl.java
 Mon Aug 31 17:01:44 2009
@@ -179,7 +179,14 @@
 } else {
 socket = new MulticastSocket(port);
 }
-socket.setLoopbackMode(false); //hint that we don't need loop back 
messages
+
+/**
+ * The argument of setLoopbackMode() is named disable.
+ * We set it to false, because we need loopback messages for the case
+ * when multiple cluster nodes reside on the same machine.
+ */
+socket.setLoopbackMode(false);
+
 if (mcastBindAddress != null) {
if(log.isInfoEnabled())
 log.info("Setting multihome multicast interface to:" 
+mcastBindAddress);



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r809667 - in /tomcat/sandbox/tomcat-oacc/trunk/src/share/org/apache/catalina/cluster: mcast/McastServiceImpl.java membership/McastServiceImpl.java

2009-08-31 Thread rjung
Author: rjung
Date: Mon Aug 31 17:21:56 2009
New Revision: 809667

URL: http://svn.apache.org/viewvc?rev=809667&view=rev
Log:
Fix comment - no functional change.

The comment was misleading, because we changed
the value of the flag without correcting the comment.

Modified:

tomcat/sandbox/tomcat-oacc/trunk/src/share/org/apache/catalina/cluster/mcast/McastServiceImpl.java

tomcat/sandbox/tomcat-oacc/trunk/src/share/org/apache/catalina/cluster/membership/McastServiceImpl.java

Modified: 
tomcat/sandbox/tomcat-oacc/trunk/src/share/org/apache/catalina/cluster/mcast/McastServiceImpl.java
URL: 
http://svn.apache.org/viewvc/tomcat/sandbox/tomcat-oacc/trunk/src/share/org/apache/catalina/cluster/mcast/McastServiceImpl.java?rev=809667&r1=809666&r2=809667&view=diff
==
--- 
tomcat/sandbox/tomcat-oacc/trunk/src/share/org/apache/catalina/cluster/mcast/McastServiceImpl.java
 (original)
+++ 
tomcat/sandbox/tomcat-oacc/trunk/src/share/org/apache/catalina/cluster/mcast/McastServiceImpl.java
 Mon Aug 31 17:21:56 2009
@@ -184,7 +184,14 @@
 } else {
 socket = new MulticastSocket(port);
 }
-socket.setLoopbackMode(false); //hint that we don't need loop back 
messages
+
+/**
+ * The argument of setLoopbackMode() is named disable.
+ * We set it to false, because we need loopback messages for the case
+ * when multiple cluster nodes reside on the same machine.
+ */
+socket.setLoopbackMode(false);
+
 if (mcastBindAddress != null) {
 if(log.isInfoEnabled())
 log.info("Setting multihome multicast interface to:" +

Modified: 
tomcat/sandbox/tomcat-oacc/trunk/src/share/org/apache/catalina/cluster/membership/McastServiceImpl.java
URL: 
http://svn.apache.org/viewvc/tomcat/sandbox/tomcat-oacc/trunk/src/share/org/apache/catalina/cluster/membership/McastServiceImpl.java?rev=809667&r1=809666&r2=809667&view=diff
==
--- 
tomcat/sandbox/tomcat-oacc/trunk/src/share/org/apache/catalina/cluster/membership/McastServiceImpl.java
 (original)
+++ 
tomcat/sandbox/tomcat-oacc/trunk/src/share/org/apache/catalina/cluster/membership/McastServiceImpl.java
 Mon Aug 31 17:21:56 2009
@@ -197,7 +197,14 @@
 } else {
 socket = new MulticastSocket(port);
 }
-socket.setLoopbackMode(false); //hint that we don't need loop back 
messages
+
+/**
+ * The argument of setLoopbackMode() is named disable.
+ * We set it to false, because we need loopback messages for the case
+ * when multiple cluster nodes reside on the same machine.
+ */
+socket.setLoopbackMode(false);
+
 if (mcastBindAddress != null) {
 if(log.isInfoEnabled())
 log.info("Setting multihome multicast interface to:" +



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



JSR 315 - status ?

2009-08-31 Thread Matthias Wessendorf
Hi there,

Does one know what the current status of JSR 315 is ? Will it be final soon?
I think last what I heard was that Filip said - on ACon EU, in April,
that it may
be final in September 09.

-Matthias

-- 
Matthias Wessendorf

blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: DO NOT REPLY [Bug 47767] [PatchAvailable] mod_actions and Server-Status

2009-08-31 Thread Mark Thomas
This looks like spam to me.

I am going to purge it from Bugzilla and disable the account of the use
that created it.

Mark



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org