svn commit: r805321 - in /tomcat/trunk/java/org/apache/catalina/filters: FilterBase.java RequestFilter.java

2009-08-18 Thread markt
Author: markt
Date: Tue Aug 18 08:29:25 2009
New Revision: 805321

URL: http://svn.apache.org/viewvc?rev=805321&view=rev
Log:
Clean-up / simplification.

Modified:
tomcat/trunk/java/org/apache/catalina/filters/FilterBase.java
tomcat/trunk/java/org/apache/catalina/filters/RequestFilter.java

Modified: tomcat/trunk/java/org/apache/catalina/filters/FilterBase.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/filters/FilterBase.java?rev=805321&r1=805320&r2=805321&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/filters/FilterBase.java (original)
+++ tomcat/trunk/java/org/apache/catalina/filters/FilterBase.java Tue Aug 18 
08:29:25 2009
@@ -22,17 +22,14 @@
 import javax.servlet.Filter;
 import javax.servlet.FilterConfig;
 import javax.servlet.ServletException;
-import javax.servlet.ServletRequest;
-import javax.servlet.ServletResponse;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
 
 import org.apache.juli.logging.Log;
 import org.apache.tomcat.util.IntrospectionUtils;
 import org.apache.tomcat.util.res.StringManager;
 
 /**
- * Base class for filters that provide some utility methods. 
+ * Base class for filters that provides generic initialisation and a simple
+ * no-op destruction. 
  * 
  * @author xxd
  *
@@ -42,6 +39,8 @@
 protected static final StringManager sm =
 StringManager.getManager(Constants.Package);
 
+protected abstract Log getLogger();
+
 public void init(FilterConfig filterConfig) throws ServletException {
 Enumeration paramNames = filterConfig.getInitParameterNames();
 while (paramNames.hasMoreElements()) {
@@ -54,38 +53,9 @@
 }
 }
 
-/**
- * Whether the request object is an HttpServletRequest or not.
- * 
- * @param request
- * @return
- */
-protected boolean isHttpServletRequest(ServletRequest request) {
-return request instanceof HttpServletRequest;
-}
-
-/**
- * Whether the response object is an HttpServletResponse or not.
- * 
- * @param response
- * @return
- */
-protected boolean isHttpServletResponse(ServletResponse response) {
-return response instanceof HttpServletResponse;
+@Override
+public void destroy() {
+// NOOP
 }
 
-/**
- * Whether the corresponding Servlet is an HttpServlet or not.
- * 
- * @param request
- * @param response
- * @return
- */
-protected boolean isHttpServlet(ServletRequest request,
-ServletResponse response) {
-return isHttpServletRequest(request) && 
isHttpServletResponse(response);
-}
-
-protected abstract Log getLogger();
-
 }

Modified: tomcat/trunk/java/org/apache/catalina/filters/RequestFilter.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/filters/RequestFilter.java?rev=805321&r1=805320&r2=805321&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/filters/RequestFilter.java (original)
+++ tomcat/trunk/java/org/apache/catalina/filters/RequestFilter.java Tue Aug 18 
08:29:25 2009
@@ -171,13 +171,6 @@
 // - Public Methods
 
 
-/* (non-Javadoc)
- * @see javax.servlet.Filter#destroy()
- */
-public void destroy() {
-// NOOP
-}   
-
 /**
  * Extract the desired request property, and pass it (along with the
  * specified request and response objects) to the protected
@@ -259,7 +252,7 @@
 if (isAllowed(property)) {
 chain.doFilter(request, response);
 } else {
-if (isHttpServletResponse(response)) {
+if (response instanceof HttpServletResponse) {
 ((HttpServletResponse) response)
 .sendError(HttpServletResponse.SC_FORBIDDEN);
 } else {



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r805322 - /tomcat/trunk/webapps/docs/config/filter.xml

2009-08-18 Thread markt
Author: markt
Date: Tue Aug 18 08:33:47 2009
New Revision: 805322

URL: http://svn.apache.org/viewvc?rev=805322&view=rev
Log:
List filters alphabetically

Modified:
tomcat/trunk/webapps/docs/config/filter.xml

Modified: tomcat/trunk/webapps/docs/config/filter.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/filter.xml?rev=805322&r1=805321&r2=805322&view=diff
==
--- tomcat/trunk/webapps/docs/config/filter.xml (original)
+++ tomcat/trunk/webapps/docs/config/filter.xml Tue Aug 18 08:33:47 2009
@@ -84,36 +84,6 @@
 
 
 
-
-
-  
-
-Microsoft operating systems have two WebDAV clients. One is used with
-port 80, the other is used for all other ports. The implementation used 
with
-port 80 does not adhere to the WebDAV specification and fails when trying 
to
-communicate with the Tomcat WebDAV Servlet. This Filter provides a fix for
-this by forcing the use of the WebDAV implementation that works, even when
-connecting via port 80.
-
-  
-
-  
-
-The filter class name for the WebDAV Fix Filter is
-org.apache.catalina.filters.WebdavFixFilter
-.
-
-  
-
-  
-
-The WebDAV Fix Filter does not support any initialization 
parameters.
-
-  
-
-
-
-
 
 
   
@@ -224,6 +194,36 @@
 
 
 
+
+
+  
+
+Microsoft operating systems have two WebDAV clients. One is used with
+port 80, the other is used for all other ports. The implementation used 
with
+port 80 does not adhere to the WebDAV specification and fails when trying 
to
+communicate with the Tomcat WebDAV Servlet. This Filter provides a fix for
+this by forcing the use of the WebDAV implementation that works, even when
+connecting via port 80.
+
+  
+
+  
+
+The filter class name for the WebDAV Fix Filter is
+org.apache.catalina.filters.WebdavFixFilter
+.
+
+  
+
+  
+
+The WebDAV Fix Filter does not support any initialization 
parameters.
+
+  
+
+
+
+
 
 
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r805368 - /tomcat/trunk/java/org/apache/juli/VerbatimFormatter.java

2009-08-18 Thread markt
Author: markt
Date: Tue Aug 18 11:29:05 2009
New Revision: 805368

URL: http://svn.apache.org/viewvc?rev=805368&view=rev
Log:
Add a new logging formatter that just echos out the log message. Useful for the 
request dumper, access logs etc.

Added:
tomcat/trunk/java/org/apache/juli/VerbatimFormatter.java   (with props)

Added: tomcat/trunk/java/org/apache/juli/VerbatimFormatter.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/juli/VerbatimFormatter.java?rev=805368&view=auto
==
--- tomcat/trunk/java/org/apache/juli/VerbatimFormatter.java (added)
+++ tomcat/trunk/java/org/apache/juli/VerbatimFormatter.java Tue Aug 18 
11:29:05 2009
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ * 
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.juli;
+
+import java.util.logging.Formatter;
+import java.util.logging.LogRecord;
+
+/**
+ * Outputs the just the log message with no additional elements. Stack traces
+ * are not logged. Log messages are separated by
+ * System.getProperty("line.separator"). This is intended for use
+ * by access logs and the like that need complete control over the output
+ * format.
+ */
+public class VerbatimFormatter extends Formatter {
+
+private static final String LINE_SEP = 
System.getProperty("line.separator");
+
+@Override
+public String format(LogRecord record) {
+// Timestamp
+StringBuilder sb = new StringBuilder(record.getMessage());
+
+// New line for next record
+sb.append(LINE_SEP);
+
+return sb.toString();
+}
+
+}

Propchange: tomcat/trunk/java/org/apache/juli/VerbatimFormatter.java
--
svn:eol-style = native

Propchange: tomcat/trunk/java/org/apache/juli/VerbatimFormatter.java
--
svn:keywords = Date Author Id Revision



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r805375 - in /tomcat/trunk: conf/ java/org/apache/catalina/filters/ java/org/apache/catalina/mbeans/ java/org/apache/catalina/valves/ webapps/docs/config/ webapps/examples/WEB-INF/ webapps

2009-08-18 Thread markt
Author: markt
Date: Tue Aug 18 11:49:26 2009
New Revision: 805375

URL: http://svn.apache.org/viewvc?rev=805375&view=rev
Log:
Replace the RequestDumperValve with a RequestDumperFilter. Merge the 
RequestDumperFilter from the examples with this new filter.
Adds:
- thread name to start of output line to make analysing output easier
- request timings
GSOC 2009
Based on a patch by Xie Xiaodong

Added:
tomcat/trunk/java/org/apache/catalina/filters/RequestDumperFilter.java   
(with props)
Removed:
tomcat/trunk/java/org/apache/catalina/valves/RequestDumperValve.java

tomcat/trunk/webapps/examples/WEB-INF/classes/filters/RequestDumperFilter.java
Modified:
tomcat/trunk/conf/server.xml
tomcat/trunk/java/org/apache/catalina/mbeans/MBeanFactory.java
tomcat/trunk/webapps/docs/config/filter.xml
tomcat/trunk/webapps/docs/config/valve.xml
tomcat/trunk/webapps/examples/WEB-INF/web.xml

Modified: tomcat/trunk/conf/server.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/conf/server.xml?rev=805375&r1=805374&r2=805375&view=diff
==
--- tomcat/trunk/conf/server.xml (original)
+++ tomcat/trunk/conf/server.xml Tue Aug 18 11:49:26 2009
@@ -106,13 +106,6 @@
   
   -->
 
-  
-  
-
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Fwd: DOAP Error Report

2009-08-18 Thread sebb
I've fixed the "projects" build to use:

http://svn.apache.org/repos/asf/tomcat/taglibs/rdc/trunk/doap_rdc.rdf

Please can someone on the project can check if the DOAP itself needs updating.

Thanks.
-- Forwarded message --
From: aps...@apache.org 
Date: 18 Aug 2009 01:31
Subject: DOAP Error Report
To: Site Development 


Errors getting files
 Failed to get 
'http://svn.apache.org/repos/asf/jakarta/taglibs/proper/rdc/trunk/doap_rdc.rdf'
 Status = 'HTTP/1.1 404 Not Found
 '
 Processing errors

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: svn commit: r805375 - in /tomcat/trunk: conf/ java/org/apache/catalina/filters/ java/org/apache/catalina/mbeans/ java/org/apache/catalina/valves/ webapps/docs/config/ webapps/examples/WEB-INF/

2009-08-18 Thread sebb
On 18/08/2009, ma...@apache.org  wrote:
> Author: markt
>  Date: Tue Aug 18 11:49:26 2009
>  New Revision: 805375
>
>  URL: http://svn.apache.org/viewvc?rev=805375&view=rev
>  Log:
>  Replace the RequestDumperValve with a RequestDumperFilter. Merge the 
> RequestDumperFilter from the examples with this new filter.
>  Adds:
>  - thread name to start of output line to make analysing output easier
>  - request timings
>  GSOC 2009
>  Based on a patch by Xie Xiaodong
>
>  Added:
> tomcat/trunk/java/org/apache/catalina/filters/RequestDumperFilter.java   
> (with props)
>  Removed:
> tomcat/trunk/java/org/apache/catalina/valves/RequestDumperValve.java
> 
> tomcat/trunk/webapps/examples/WEB-INF/classes/filters/RequestDumperFilter.java
>  Modified:
> tomcat/trunk/conf/server.xml
> tomcat/trunk/java/org/apache/catalina/mbeans/MBeanFactory.java
> tomcat/trunk/webapps/docs/config/filter.xml
> tomcat/trunk/webapps/docs/config/valve.xml
> tomcat/trunk/webapps/examples/WEB-INF/web.xml
>
>  Modified: tomcat/trunk/conf/server.xml
>  URL: 
> http://svn.apache.org/viewvc/tomcat/trunk/conf/server.xml?rev=805375&r1=805374&r2=805375&view=diff
>  
> ==
>  --- tomcat/trunk/conf/server.xml (original)
>  +++ tomcat/trunk/conf/server.xml Tue Aug 18 11:49:26 2009
>  @@ -106,13 +106,6 @@
>
>-->
>
>  -  
>  -  
>  -
> svn:eol-style = native
>
>  Propchange: 
> tomcat/trunk/java/org/apache/catalina/filters/RequestDumperFilter.java
>  
> --
> svn:keywords = Date Author Id Revision
>
>  Modified: tomcat/trunk/java/org/apache/catalina/mbeans/MBeanFactory.java
>  URL: 
> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/mbeans/MBeanFactory.java?rev=805375&r1=805374&r2=805375&view=diff
>  
> ==
>  --- tomcat/trunk/java/org/apache/catalina/mbeans/MBeanFactory.java (original)
>  +++ tomcat/trunk/java/org/apache/catalina/mbeans/MBeanFactory.java Tue Aug 
> 18 11:49:26 2009
>  @@ -49,7 +49,6 @@
>   import org.apache.catalina.valves.AccessLogValve;
>   import org.apache.catalina.valves.RemoteAddrValve;
>   import org.apache.catalina.valves.RemoteHostValve;
>  -import org.apache.catalina.valves.RequestDumperValve;
>   import org.apache.catalina.valves.ValveBase;
>   import org.apache.tomcat.util.modeler.BaseModelMBean;
>
>  @@ -513,29 +512,6 @@
>
>
>  /**
>  - * Create a new Request Dumper Valve.
>  - *
>  - * @param parent MBean Name of the associated parent component
>  - *
>  - * @exception Exception if an MBean cannot be created or registered
>  - */
>  -public String createRequestDumperValve(String parent)
>  -throws Exception {
>  -
>  -// Create a new RequestDumperValve instance
>  -RequestDumperValve valve = new RequestDumperValve();
>  -
>  -// Add the new instance to its parent component
>  -ObjectName pname = new ObjectName(parent);
>  -ContainerBase containerBase = getParentContainerFromParent(pname);
>  -containerBase.addValve(valve);
>  -ObjectName oname = valve.getObjectName();
>  -return (oname.toString());
>  -
>  -}
>  -
>  -
>  -/**
>   * Create a new Single Sign On Valve.
>   *
>   * @param parent MBean Name of the associated parent component
>
>  Modified: tomcat/trunk/webapps/docs/config/filter.xml
>  URL: 
> http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/filter.xml?rev=805375&r1=805374&r2=805375&view=diff
>  
> ==
>  --- tomcat/trunk/webapps/docs/config/filter.xml (original)
>  +++ tomcat/trunk/webapps/docs/config/filter.xml Tue Aug 18 11:49:26 2009
>  @@ -194,6 +194,75 @@
>   
>
>
>  +
>  +
>  +  
>  +
>  +The Request Dumper Filter logs information from the request and 
> response
>  +objects and is intended to be used for debugging purposes. When using 
> this
>  +Filter, it is recommended that the
>  +org.apache.catalina.filter.RequestDumperFilter logger is
>  +directed to a dedicated file and that the
>  +org.apache.juli.VerbatimFormmater is used.
>  +
>  +WARNING: Using this filter has side-effects.  The
>  +output from this filter includes any parameters included with the 
> request.
>  +The parameters will be decoded using the default platform encoding. Any
>  +subsequent calls to request.setCharacterEncoding() within
>  +the web application will have no effect.
>  +
>  +  
>  +
>  +  
>  +
>  +The filter class name for the Request Dumper Filter is
>  +org.apache.catalina.filters.RequestDumperFilter
>  +.
>  +
>  +  
>  +
>  +  
>  +
>  +The Request Dumper Filter does not support any initialization
>  +parameters.
>  +
>  +  
>  +
>

Re: GSoC2009 Project Wiki page updated

2009-08-18 Thread Mark Thomas
Xie Xiaodong wrote:
> Hello, Dear All,
>   I have updated the GSoC2009 Project Wiki page. I've got some design
> decisions to make, could you please spare me some time take a look at those?
> Any comments are welcome. Thank you for your time.

The wiki pages are beginning to look quite crowded. Rather than add to
that problem, I'll provide my comments here and let you update that page.

1. The main design decision as I understand it is how to handle filters
at the Engine and Host level.

Option 1: server.xml
Outline:  Provide support for a  element in server.xml to
configure Engine, Host (& Context?) level filters.
Pros: Similar to valves - can re-use most of the design
Cons: Access to ServletContext

Option 2: web.xml
Outline:  Provide support for a host and engine level web.xml files
Pros: Simple to implement,particularly with Servlet 3.0 requirements for
web fragments. Should be very easy to extend.
Cons: One instance of filter created per context, even when filter is
defined at host/engine. Would require more objects.

Option 3: Do nothing
Outline : Provides support for filters configured globally
(CATALINA_BASE/conf/web.xml) or per context.
Pros: No effort required
Cons: Some filters (AccessLogs, RequestFilter etc) are typically
configured at host/engine.

Option 4: Something else?

My preference is for option 2. I hope to start on the web fragment code
shortly.

Related questions (keeping numbering from wiki):

2. Ordering
Order should be:
- Global filters
- Engine filters
- Host filters
- Context filters
Where a filter is defined at multiple levels, merge the configurations
using the Servlet 3.0 rules with the *lowest* level taking precedence
(ie context > host > engine > global).

3. I think points 1. & 2. above cover this.

4. The long term aim is to remove Valves entirely.

5. This was addressed for the RequestFilter valves

6. See 4. Whilst removal is the aim, it may well end up making sense to
keep some internal Valves.

7. & 8. See 1.

Mark



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: svn commit: r805375 - in /tomcat/trunk: conf/ java/org/apache/catalina/filters/ java/org/apache/catalina/mbeans/ java/org/apache/catalina/valves/ webapps/docs/config/ webapps/examples/WEB-INF/

2009-08-18 Thread Mark Thomas
sebb wrote:
> On 18/08/2009, ma...@apache.org  wrote:

 - Trimming your responses would be really helpful

>>  + * @author Craig R. McClanahan
> 
> Was the author really Craig?

Enough of the code is his work that I'm not comfortable removing it.



Mark



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Taglibs SVN migration to Tomcat

2009-08-18 Thread Rahul Akolkar
On Tue, Aug 18, 2009 at 12:33 AM, Henri Yandell wrote:
> On Mon, Aug 17, 2009 at 10:51 AM, Rahul Akolkar 
> wrote:
>> On Mon, Aug 17, 2009 at 1:04 AM, Henri Yandell wrote:

>>>  The Standard taglib's site is not in a happy
>>> state so I'll be working on getting that setup next. Rahul and I both
>>> have the tomcat unix group now, so I'll work on moving the sites over
>>> into tomcat.apache.org/taglibs this week; and setting up the redirects
>>> on the Jakarta side.
>>>
>> 
>>
>> I can certainly push out a site or two -- if you want, I can do RDC
>> (and extended even) while you appease Standard.
>
> No real site for extended yet - but feel very free to put something
> simple together if you'd like :)


OK :-) Unlikely soon though.

-Rahul

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: DOAP Error Report

2009-08-18 Thread Rahul Akolkar
On Tue, Aug 18, 2009 at 7:51 AM, sebb wrote:
> I've fixed the "projects" build to use:
>
> http://svn.apache.org/repos/asf/tomcat/taglibs/rdc/trunk/doap_rdc.rdf
>


Thanks.


> Please can someone on the project can check if the DOAP itself needs updating.
>


Indeed, a lot needs updating over time (repository, various Jakarta
site references, mailing lists whenever we switch etc.). I'll make the
changes to match ground reality, gradually -- as said changes happen.

-Rahul


> Thanks.
> -- Forwarded message --
> From: aps...@apache.org 
> Date: 18 Aug 2009 01:31
> Subject: DOAP Error Report
> To: Site Development 
>
>
> Errors getting files
>  Failed to get 
> 'http://svn.apache.org/repos/asf/jakarta/taglibs/proper/rdc/trunk/doap_rdc.rdf'
>  Status = 'HTTP/1.1 404 Not Found
>  '
>  Processing errors
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 43656] ELSupport.coerceToType modifies BigDecimal Values

2009-08-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=43656



--- Comment #21 from Luke Kolin  2009-08-18 09:33:36 PDT ---
Created an attachment (id=24144)
TLD for tag

This is the TLD for the JSP where we pass in Number.class to coerceToNumber.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 43656] ELSupport.coerceToType modifies BigDecimal Values

2009-08-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=43656



--- Comment #22 from Luke Kolin  2009-08-18 09:34:49 PDT ---
Created an attachment (id=24145)
JSP and Tag source

This is the JSP and Tag sources for the JSP where we pass in Number.class to
coerceToNumber.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 43656] ELSupport.coerceToType modifies BigDecimal Values

2009-08-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=43656



--- Comment #23 from Luke Kolin  2009-08-18 09:35:45 PDT ---
This is a simple JSP I have created that should exhibit the behavior, along
with a stripped-down TLD and tag sources.

The key I believe is to look at the compiled JSP's source and see what is
getting passed in the setValue() method call.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Taglibs SVN migration to Tomcat

2009-08-18 Thread Rahul Akolkar
On Mon, Aug 17, 2009 at 1:51 PM, Rahul Akolkar wrote:
> On Mon, Aug 17, 2009 at 1:04 AM, Henri Yandell wrote:

>>  The Standard taglib's site is not in a happy
>> state so I'll be working on getting that setup next. Rahul and I both
>> have the tomcat unix group now, so I'll work on moving the sites over
>> into tomcat.apache.org/taglibs this week; and setting up the redirects
>> on the Jakarta side.
>>
> 
>
> I can certainly push out a site or two -- if you want, I can do RDC
> (and extended even) while you appease Standard.
>

A start: http://tomcat.apache.org/taglibs/rdc/

For the main site, couple of changes come to mind before deploying, we should:
(a) flatten out the directory structure a bit (stuff in this site
directory [1] can just go in the parent xdoc directory really)
(b) list only the bits moved over in the LHS menu.

-Rahul

[1] http://svn.apache.org/repos/asf/tomcat/taglibs/site/src/site/xdoc/site/

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Why 404 instead of dir list ?

2009-08-18 Thread bobgosling

I have Tomcat 5.5.27 running on Red Hat Enterprise Linux 2.6.9.-87 

I have a webapp which seems to work fine for servlets that I have deployed.

I have a kind of Application Admin Console which I am developing and from
one of my plain html pages I want users to be able to click on a link which
will then display a directory full of logfiles from which they should be
able to click on any file to view the contents.

I have an href tag in my page as follows :

/raceweb/_links/appserverlogs/YieldCurveServer/ older YieldCurveServer
logfiles 

Instead of showing a dir listing I get a 404 error "The requested resource (
/raceweb/_links/appserverlogs/YieldCurveServer/) is not available.

The "appserverlogs" in the url is actually a link to a directory elsewhere
on the host. I can cd to the raceweb dir under webapps and ls
_links/appserverlogs/YieldCurveServer/* shows me a list of logfiles so it's
not a permission problem and the link is working.

If I get rid of the links and put some test files in the _links dir I
correctly get a dir listing and can click on and read them.

Why would the links be a problem ?  I can see it could be a security issue
perhaps but why is it happening and is there a way to supress the problem ?

I have worked at a site where links like that worked but it was Solaris
rather than Linux and an older version of Tomcat and not installed or
maintained by me.






-- 
View this message in context: 
http://www.nabble.com/Why-404-instead-of-dir-list---tp25037626p25037626.html
Sent from the Tomcat - Dev mailing list archive at Nabble.com.


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Why 404 instead of dir list ?

2009-08-18 Thread Mark Thomas
bobgosling wrote:
> Why would the links be a problem ?  I can see it could be a security issue
> perhaps but why is it happening and is there a way to supress the problem ?

This is a question for the users list, not the dev list.

Mark




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org