Re: [VOTE] Release build 5.5.28
On 27/07/09 22:20, Filip Hanik - Dev Lists wrote: The candidates binaries are available here: http://people.apache.org/~fhanik/tomcat/tomcat-5.5/v5.5.28/ According to the release process, the 5.5.28 tag is: [ ] Broken [ ] Alpha [ ] Beta [X] Stable Regards -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 47628] isapi_redirect.dll as an extension hangs when restarting app pool
https://issues.apache.org/bugzilla/show_bug.cgi?id=47628 brett.prucha@scrb.navy.mil changed: What|Removed |Added Version|unspecified |1.2.28 OS/Version|Windows Vista |Windows Server 2003 --- Comment #2 from brett.prucha@scrb.navy.mil 2009-08-04 05:20:18 PDT --- isapi_redirect 1.2.28, Windows Server 2003 R2 SP 2, IIS 6 Did the attachment go through, it also has version info? I can't see it. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Making AJP secret attribute consistent
Hi, JK connector uses the request.secret attribute for setting the AJP secret property. However APR connector and Ajp connector use the requiredSecret instead. This of course (first problem is that it's nowhere documented) makes problems cause it requires to have separate directives depending on the connector. Since attributes having dot in the name cannot be parsed using standard xml property getter I propose we add the same property to the JK connector and deprecate old dot name (request.secret) Comments? Regards -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Notice : No more IBM support JK/Tomcat on i5/OS V6R1
Hi to all, I'm working right now on the V6R1 port (very needed for our company update). the unixd.h didn't exist under i5/OS. In mod_jk.c I could see : /* Yes; sorta sucks - with luck we will clean this up before httpd-2.2 * ships, leaving AP_NEED_SET_MUTEX_PERMS def'd as 1 or 0 on all platforms. */ #ifdef AP_NEED_SET_MUTEX_PERMS # define JK_NEED_SET_MUTEX_PERMS AP_NEED_SET_MUTEX_PERMS #else /* A special case for httpd-2.0 */ # if !defined(OS2) && !defined(WIN32) && !defined(BEOS) && !defined(NETWARE) && !defined(AS400) # define JK_NEED_SET_MUTEX_PERMS 1 # else # define JK_NEED_SET_MUTEX_PERMS 0 # endif #endif #if JK_NEED_SET_MUTEX_PERMS #include "unixd.h" /* for unixd_set_global_mutex_perms */ #endif What's this AP_NEED_SET_MUTEX_PERMS ? On my Linux box I could see : /usr/include/apache2/os.h:#define AP_NEED_SET_MUTEX_PERMS 1 See it also on i5/OS V6R1 : /QIBM/ProdData/HTTPA/Include/os.h : /* On platforms where AP_NEED_SET_MUTEX_PERMS is defined, modules #define AP_NEED_SET_MUTEX_PERMS 1 /* @A1A */ Later I could see : #if JK_NEED_SET_MUTEX_PERMS #if (MODULE_MAGIC_NUMBER_MAJOR >= 20090208) rv = ap_unixd_set_global_mutex_perms(jk_log_lock); #else rv = unixd_set_global_mutex_perms(jk_log_lock); #endif MODULE_MAGIC_NUMBER_MAJOR is which version of Apache 2.2.x ? 2009/7/29 Henri Gomez : > We allready have a V6R1 partition available but some pre-requisite are > still missing (like OpenSSH). > > When they will, I'll do the build. > > BTW, ASF will have to provide two binaries, one for V5R3/V5R4 and one > for V6R1 ;) > > > > > 2009/7/29 Josh Gooding : >> I never had V6. V5R3 and 4 are the last ones I had. I like the i5. I wish >> I could find one of the smaller ones with a small expansion cabinet to play >> with. >> >> On Wed, Jul 29, 2009 at 11:49 AM, Mladen Turk wrote: >> >>> On 29/07/09 17:25, Rainer Jung wrote: >>> Of course first you need to get access to V6R1... >>> I had V6 once, but it was Peugeot Coupe. Nasty beast :) >>> >>> Anyhow, perhaps Henri can upload some binaries >>> inside the dist if relevant. >>> >>> >>> Cheers >>> -- >>> ^TM >>> >>> >>> >>> - >>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >>> For additional commands, e-mail: dev-h...@tomcat.apache.org >>> >>> >> > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release build 5.5.28
On 07/27/2009 02:20 PM, Filip Hanik - Dev Lists wrote: The candidates binaries are available here: http://people.apache.org/~fhanik/tomcat/tomcat-5.5/v5.5.28/ According to the release process, the 5.5.28 tag is: [ ] Broken [ ] Alpha [ ] Beta [X] Stable Filip - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] jdbc-pool Release build 1.0.7
On 07/27/2009 02:21 PM, Filip Hanik - Dev Lists wrote: The candidates source and binaries are available here: http://people.apache.org/~fhanik/jdbc-pool/v1.0.7/ According to the release process, the 1.0.7 tag is: [ ] Broken [ ] Alpha [ ] Beta [X] Stable no major bugs found, open bugs are ok for release Filip - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
3.0 annotations ?
Hi, anyone working on the @Filter, @Servlet annotation scanner for tomcat-trunk ? If I'm understanding it correctly, tomcat will have to read all files in classes and lib and look for the annotation - and I would guess the only reasonable option is looking at bytecode. I checked BCEL - seems reasonably easy, but if anyone has different code - I would rather reuse it in tomcat-lite :-) BTW - there is a typo in javax.servlet.ServletRegistration - should be Dynamic, not Dynmaic. I can fix it next time I get some free time... Costin
DO NOT REPLY [Bug 47628] isapi_redirect.dll as an extension hangs when restarting app pool
https://issues.apache.org/bugzilla/show_bug.cgi?id=47628 --- Comment #3 from brett.prucha@scrb.navy.mil 2009-08-04 12:34:56 PDT --- Created an attachment (id=24100) Patch to fix deadlock when using isapi_redirect as an extension -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: 3.0 annotations ?
We use xbean-finder for this in geronimo/openejb/etc. http://repo2.maven.org/maven2/org/apache/xbean/xbean-finder/3.5/ https://svn.apache.org/repos/asf/geronimo/xbean/trunk/xbean-finder We also have a servlet 3.0 spec jar I've been trying to keep up to date with the glassfish javadocs. https://repository.apache.org/content/repositories/snapshots/org/apache/geronimo/specs/geronimo-servlet_3.0_spec/1.0-EA-SNAPSHOT/ https://svn.apache.org/repos/asf/geronimo/specs/trunk/geronimo-servlet_3.0_spec thanks david jencks On Aug 4, 2009, at 11:11 AM, Costin Manolache wrote: Hi, anyone working on the @Filter, @Servlet annotation scanner for tomcat-trunk ? If I'm understanding it correctly, tomcat will have to read all files in classes and lib and look for the annotation - and I would guess the only reasonable option is looking at bytecode. I checked BCEL - seems reasonably easy, but if anyone has different code - I would rather reuse it in tomcat-lite :-) BTW - there is a typo in javax.servlet.ServletRegistration - should be Dynamic, not Dynmaic. I can fix it next time I get some free time... Costin - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: 3.0 annotations ?
does it load all the classes? I think byte code check might make more sense if that is the case Filip On 08/04/2009 01:50 PM, David Jencks wrote: We use xbean-finder for this in geronimo/openejb/etc. http://repo2.maven.org/maven2/org/apache/xbean/xbean-finder/3.5/ https://svn.apache.org/repos/asf/geronimo/xbean/trunk/xbean-finder We also have a servlet 3.0 spec jar I've been trying to keep up to date with the glassfish javadocs. https://repository.apache.org/content/repositories/snapshots/org/apache/geronimo/specs/geronimo-servlet_3.0_spec/1.0-EA-SNAPSHOT/ https://svn.apache.org/repos/asf/geronimo/specs/trunk/geronimo-servlet_3.0_spec thanks david jencks On Aug 4, 2009, at 11:11 AM, Costin Manolache wrote: Hi, anyone working on the @Filter, @Servlet annotation scanner for tomcat-trunk ? If I'm understanding it correctly, tomcat will have to read all files in classes and lib and look for the annotation - and I would guess the only reasonable option is looking at bytecode. I checked BCEL - seems reasonably easy, but if anyone has different code - I would rather reuse it in tomcat-lite :-) BTW - there is a typo in javax.servlet.ServletRegistration - should be Dynamic, not Dynmaic. I can fix it next time I get some free time... Costin - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: 3.0 annotations ?
Thanks - so objectweb instead of BCEL. I'll try it out - it's a bit different from what I had in mind, it looks like xbean-finder first finds all classes and than reads the files using the class loader ( but not Class.forName, which is good ) and keeps track of all annotations. I was thinking of a simple File/zip based scanning, without any class loader - and just select the few annotations we need and write a web.xml fragment as it goes, without keeping anything in memory. I guess in 3.0 a deploy tool / phase is absolutely needed - we can't have tomcat scan all files each time it starts up, so the user will have to do something to re-initiate the scanning. Like touch web.xml, or run a re-deploy tool. I'm curious - why objectweb and not BCEL ? On Tue, Aug 4, 2009 at 12:50 PM, David Jencks wrote: > We use xbean-finder for this in geronimo/openejb/etc. > > http://repo2.maven.org/maven2/org/apache/xbean/xbean-finder/3.5/ > > https://svn.apache.org/repos/asf/geronimo/xbean/trunk/xbean-finder > > We also have a servlet 3.0 spec jar I've been trying to keep up to date > with the glassfish javadocs. > > > https://repository.apache.org/content/repositories/snapshots/org/apache/geronimo/specs/geronimo-servlet_3.0_spec/1.0-EA-SNAPSHOT/ > > > https://svn.apache.org/repos/asf/geronimo/specs/trunk/geronimo-servlet_3.0_spec > > thanks > david jencks > > > On Aug 4, 2009, at 11:11 AM, Costin Manolache wrote: > > Hi, anyone working on the @Filter, @Servlet annotation scanner for >> tomcat-trunk ? >> If I'm understanding it correctly, tomcat will have to read all files in >> classes and lib and look for the >> annotation - and I would guess the only reasonable option is looking at >> bytecode. >> I checked BCEL - seems reasonably easy, but if anyone has different code - >> I >> would rather reuse it in >> tomcat-lite :-) >> >> BTW - there is a typo in javax.servlet.ServletRegistration - should be >> Dynamic, not Dynmaic. >> I can fix it next time I get some free time... >> >> Costin >> > > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
Re: 3.0 annotations ?
On Aug 4, 2009, at 1:18 PM, Filip Hanik - Dev Lists wrote: does it load all the classes? IIUC no, it uses asm for byte-code inspection without loading classes. thanks david jencks I think byte code check might make more sense if that is the case Filip On 08/04/2009 01:50 PM, David Jencks wrote: We use xbean-finder for this in geronimo/openejb/etc. http://repo2.maven.org/maven2/org/apache/xbean/xbean-finder/3.5/ https://svn.apache.org/repos/asf/geronimo/xbean/trunk/xbean-finder We also have a servlet 3.0 spec jar I've been trying to keep up to date with the glassfish javadocs. https://repository.apache.org/content/repositories/snapshots/org/apache/geronimo/specs/geronimo-servlet_3.0_spec/1.0-EA-SNAPSHOT/ https://svn.apache.org/repos/asf/geronimo/specs/trunk/geronimo-servlet_3.0_spec thanks david jencks On Aug 4, 2009, at 11:11 AM, Costin Manolache wrote: Hi, anyone working on the @Filter, @Servlet annotation scanner for tomcat-trunk ? If I'm understanding it correctly, tomcat will have to read all files in classes and lib and look for the annotation - and I would guess the only reasonable option is looking at bytecode. I checked BCEL - seems reasonably easy, but if anyone has different code - I would rather reuse it in tomcat-lite :-) BTW - there is a typo in javax.servlet.ServletRegistration - should be Dynamic, not Dynmaic. I can fix it next time I get some free time... Costin - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 42996] POST with nio connector results in missing variables
https://issues.apache.org/bugzilla/show_bug.cgi?id=42996 --- Comment #30 from Filip Hanik 2009-08-04 13:34:18 PDT --- Created an attachment (id=24101) Wireshark output for a request that went wrong Jerome, I ran your load test. I'm not very familiar with what the app does, so maybe you can help me. However, when the application throws a 400 error (ERROR (2)) it does so when the client issued a GET request without a body. best Filip -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: 3.0 annotations ?
No, it scans via ASM for security reasons and only loads classes (with
no initialization) once you ask for classes that have a specific
annotation.
Sample code:
ClassFinder finder = new ClassFinder(webapp.getClassLoader(),
webappLibUrls);
for (Class servlet : finder.findAnnotatedClasses(Servlet.class)) {
// .. do your processing
}
for (Class filter : finder.findAnnotatedClasses(Filter.class)) {
// .. do your processing
}
// and so on
Additions are welcome if there are any features you might need.
-David
On Aug 4, 2009, at 1:18 PM, Filip Hanik - Dev Lists wrote:
does it load all the classes?
I think byte code check might make more sense if that is the case
Filip
On 08/04/2009 01:50 PM, David Jencks wrote:
We use xbean-finder for this in geronimo/openejb/etc.
http://repo2.maven.org/maven2/org/apache/xbean/xbean-finder/3.5/
https://svn.apache.org/repos/asf/geronimo/xbean/trunk/xbean-finder
We also have a servlet 3.0 spec jar I've been trying to keep up to
date with the glassfish javadocs.
https://repository.apache.org/content/repositories/snapshots/org/apache/geronimo/specs/geronimo-servlet_3.0_spec/1.0-EA-SNAPSHOT/
https://svn.apache.org/repos/asf/geronimo/specs/trunk/geronimo-servlet_3.0_spec
thanks
david jencks
On Aug 4, 2009, at 11:11 AM, Costin Manolache wrote:
Hi, anyone working on the @Filter, @Servlet annotation scanner for
tomcat-trunk ?
If I'm understanding it correctly, tomcat will have to read all
files in
classes and lib and look for the
annotation - and I would guess the only reasonable option is
looking at
bytecode.
I checked BCEL - seems reasonably easy, but if anyone has
different code - I
would rather reuse it in
tomcat-lite :-)
BTW - there is a typo in javax.servlet.ServletRegistration -
should be
Dynamic, not Dynmaic.
I can fix it next time I get some free time...
Costin
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] jdbc-pool Release build 1.0.7
On 04/08/2009, Filip Hanik - Dev Lists wrote: > On 07/27/2009 02:21 PM, Filip Hanik - Dev Lists wrote: > > > The candidates source and binaries are available here: > > http://people.apache.org/~fhanik/jdbc-pool/v1.0.7/ > > > > According to the release process, the 1.0.7 tag is: > > [ ] Broken > > [ ] Alpha > > [ ] Beta > > [X] Stable > > > no major bugs found, open bugs are ok for release AFAIK, most if not all the open bugs have patches, so why not apply them before the release? > Filip > > > > > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > > For additional commands, e-mail: dev-h...@tomcat.apache.org > > > > > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: 3.0 annotations ?
On Aug 4, 2009, at 1:22 PM, Costin Manolache wrote:
Thanks - so objectweb instead of BCEL.
I'll try it out - it's a bit different from what I had in mind, it
looks
like xbean-finder first finds all classes and
than reads the files using the class loader ( but not Class.forName,
which
is good ) and keeps track of all annotations.
I was thinking of a simple File/zip based scanning, without any
class loader
- and just select the few
annotations we need and write a web.xml fragment as it goes, without
keeping
anything in memory.
I've been thinking about adding in a sort of "filter" for the
scanning. Something that could be supplied in the constructor.
Something simple like:
public interface Filter {
boolean accept(String annotationName);
}
Then you would implement that and be guaranteed to only have metadata
for the annotations you cared about. In this case @Filter and
@Servlet. I actually already experimented with it in a little copy
of the ClassFinder, would only take like 10 minutes to integrate the
change in.
In terms of keeping things in memory, there really isn't that much in
memory, especially if you filter out the annotations you don't care
about. As far as needing a classloader, that is only there so we can
return a list of classes (or methods, or fields, etc.) when you ask
for things that have a specific annotation. Someone has to load the
class to get the annotation data so it's just in the API for
convenience.
Another thing I've been experimenting with is some additional byte
code reading optimizations. Basically if you know your annotations
are class-level annotations only, you can get a boost in scan time by
just reading the top of the class def and skipping the rest. The
technique is proven, just need to think of an elegant way to specify
that is the behavior you want.
I guess in 3.0 a deploy tool / phase is absolutely needed - we can't
have
tomcat scan all files
each time it starts up, so the user will have to do something to re-
initiate
the scanning. Like touch
web.xml, or run a re-deploy tool.
I'm curious - why objectweb and not BCEL ?
We (OpenEJB) already had a bunch of code using ASM so that's what I
went with -- I wrote it OpenEJB and moved it over into XBean later so
others could use it. I also know a couple ASM guys and find it's good
getting direct tips for best performance as well as getting any
features in we need.
-David
On Tue, Aug 4, 2009 at 12:50 PM, David Jencks
wrote:
We use xbean-finder for this in geronimo/openejb/etc.
http://repo2.maven.org/maven2/org/apache/xbean/xbean-finder/3.5/
https://svn.apache.org/repos/asf/geronimo/xbean/trunk/xbean-finder
We also have a servlet 3.0 spec jar I've been trying to keep up to
date
with the glassfish javadocs.
https://repository.apache.org/content/repositories/snapshots/org/apache/geronimo/specs/geronimo-servlet_3.0_spec/1.0-EA-SNAPSHOT/
https://svn.apache.org/repos/asf/geronimo/specs/trunk/geronimo-servlet_3.0_spec
thanks
david jencks
On Aug 4, 2009, at 11:11 AM, Costin Manolache wrote:
Hi, anyone working on the @Filter, @Servlet annotation scanner for
tomcat-trunk ?
If I'm understanding it correctly, tomcat will have to read all
files in
classes and lib and look for the
annotation - and I would guess the only reasonable option is
looking at
bytecode.
I checked BCEL - seems reasonably easy, but if anyone has
different code -
I
would rather reuse it in
tomcat-lite :-)
BTW - there is a typo in javax.servlet.ServletRegistration -
should be
Dynamic, not Dynmaic.
I can fix it next time I get some free time...
Costin
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 47378] welcome-file ignores servlet mapping
https://issues.apache.org/bugzilla/show_bug.cgi?id=47378 tho...@gtsquare.com changed: What|Removed |Added CC||tho...@gtsquare.com -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r801009 - /tomcat/trunk/java/javax/servlet/ServletRegistration.java
Author: markt
Date: Tue Aug 4 22:49:46 2009
New Revision: 801009
URL: http://svn.apache.org/viewvc?rev=801009&view=rev
Log:
Fix the typo Costin spotted
Modified:
tomcat/trunk/java/javax/servlet/ServletRegistration.java
Modified: tomcat/trunk/java/javax/servlet/ServletRegistration.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/javax/servlet/ServletRegistration.java?rev=801009&r1=801008&r2=801009&view=diff
==
--- tomcat/trunk/java/javax/servlet/ServletRegistration.java (original)
+++ tomcat/trunk/java/javax/servlet/ServletRegistration.java Tue Aug 4
22:49:46 2009
@@ -35,7 +35,7 @@
*/
public Set addMapping(String... urlPatterns);
-public static interface Dynmaic
+public static interface Dynamic
extends ServletRegistration, Registration.Dynamic {
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r801011 - in /tomcat/trunk/java/org/apache: catalina/core/ApplicationContext.java catalina/core/ApplicationContextFacade.java jasper/servlet/JspCServletContext.java
Author: markt
Date: Tue Aug 4 22:54:25 2009
New Revision: 801011
URL: http://svn.apache.org/viewvc?rev=801011&view=rev
Log:
Having fixed the typo, fix all the places it was referenced
Modified:
tomcat/trunk/java/org/apache/catalina/core/ApplicationContext.java
tomcat/trunk/java/org/apache/catalina/core/ApplicationContextFacade.java
tomcat/trunk/java/org/apache/jasper/servlet/JspCServletContext.java
Modified: tomcat/trunk/java/org/apache/catalina/core/ApplicationContext.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/ApplicationContext.java?rev=801011&r1=801010&r2=801011&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/ApplicationContext.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/core/ApplicationContext.java Tue Aug
4 22:54:25 2009
@@ -897,7 +897,7 @@
return null;
}
-public ServletRegistration.Dynmaic addServlet(String servletName,
+public ServletRegistration.Dynamic addServlet(String servletName,
String className) throws IllegalStateException {
if (context.initialized) {
@@ -916,7 +916,7 @@
}
-public ServletRegistration.Dynmaic addServlet(String servletName,
+public ServletRegistration.Dynamic addServlet(String servletName,
Servlet servlet) throws IllegalStateException {
if (context.initialized) {
@@ -935,7 +935,7 @@
}
-public ServletRegistration.Dynmaic addServlet(String servletName,
+public ServletRegistration.Dynamic addServlet(String servletName,
Class servletClass)
throws IllegalStateException {
Modified:
tomcat/trunk/java/org/apache/catalina/core/ApplicationContextFacade.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/ApplicationContextFacade.java?rev=801011&r1=801010&r2=801011&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/ApplicationContextFacade.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/core/ApplicationContextFacade.java
Tue Aug 4 22:54:25 2009
@@ -442,10 +442,10 @@
}
-public ServletRegistration.Dynmaic addServlet(String servletName,
+public ServletRegistration.Dynamic addServlet(String servletName,
String className) {
if (SecurityUtil.isPackageProtectionEnabled()) {
-return (ServletRegistration.Dynmaic) doPrivileged(
+return (ServletRegistration.Dynamic) doPrivileged(
"addServlet", new Object[]{servletName, className});
} else {
return context.addServlet(servletName, className);
@@ -453,10 +453,10 @@
}
-public ServletRegistration.Dynmaic addServlet(String servletName,
+public ServletRegistration.Dynamic addServlet(String servletName,
Servlet servlet) {
if (SecurityUtil.isPackageProtectionEnabled()) {
-return (ServletRegistration.Dynmaic) doPrivileged(
+return (ServletRegistration.Dynamic) doPrivileged(
"addServlet", new Object[]{servletName, servlet});
} else {
return context.addServlet(servletName, servlet);
@@ -464,10 +464,10 @@
}
-public ServletRegistration.Dynmaic addServlet(String servletName,
+public ServletRegistration.Dynamic addServlet(String servletName,
Class servletClass) {
if (SecurityUtil.isPackageProtectionEnabled()) {
-return (ServletRegistration.Dynmaic) doPrivileged(
+return (ServletRegistration.Dynamic) doPrivileged(
"addServlet", new Object[]{servletName, servletClass});
} else {
return context.addServlet(servletName, servletClass);
Modified: tomcat/trunk/java/org/apache/jasper/servlet/JspCServletContext.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/servlet/JspCServletContext.java?rev=801011&r1=801010&r2=801011&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/servlet/JspCServletContext.java
(original)
+++ tomcat/trunk/java/org/apache/jasper/servlet/JspCServletContext.java Tue Aug
4 22:54:25 2009
@@ -450,7 +450,7 @@
}
-public ServletRegistration.Dynmaic addServlet(String servletName,
+public ServletRegistration.Dynamic addServlet(String servletName,
String className) {
return null;
}
@@ -488,13 +488,13 @@
}
-public javax.servlet.Registration.Dynamic addServlet(String servletName,
+public ServletRegistration.Dynamic addServlet(String servletName,
Servlet servlet) {
return null;
}
-public javax.servlet.Registration.Dynamic addServlet(String servletName,
+public ServletRegistration.Dynamic addServle
Re: 3.0 annotations ?
Costin Manolache wrote: > Hi, anyone working on the @Filter, @Servlet annotation scanner for > tomcat-trunk ? > If I'm understanding it correctly, tomcat will have to read all files in > classes and lib and look for the > annotation - and I would guess the only reasonable option is looking at > bytecode. > I checked BCEL - seems reasonably easy, but if anyone has different code - I > would rather reuse it in > tomcat-lite :-) > > BTW - there is a typo in javax.servlet.ServletRegistration - should be > Dynamic, not Dynmaic. > I can fix it next time I get some free time... Fixed. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Notice : No more IBM support JK/Tomcat on i5/OS V6R1
The question here is : Why did we use unixd_set_global_mutex_perms/ap_unixd_set_global_mutex_perms since both call didn't exist in i5/OS V6R1 and I had to set JK_NEED_SET_MUTEX_PERMS to 0 to have them excluded. I'll commit the patches for i5/OS after I some testing on the mod_jk 1.2.28 built on the V6R1. Regards 2009/8/4 Henri Gomez : > Hi to all, > > I'm working right now on the V6R1 port (very needed for our company update). > > the unixd.h didn't exist under i5/OS. > > In mod_jk.c I could see : > > /* Yes; sorta sucks - with luck we will clean this up before httpd-2.2 > * ships, leaving AP_NEED_SET_MUTEX_PERMS def'd as 1 or 0 on all platforms. > */ > #ifdef AP_NEED_SET_MUTEX_PERMS > # define JK_NEED_SET_MUTEX_PERMS AP_NEED_SET_MUTEX_PERMS > #else > /* A special case for httpd-2.0 */ > # if !defined(OS2) && !defined(WIN32) && !defined(BEOS) && > !defined(NETWARE) && !defined(AS400) > # define JK_NEED_SET_MUTEX_PERMS 1 > # else > # define JK_NEED_SET_MUTEX_PERMS 0 > # endif > #endif > > #if JK_NEED_SET_MUTEX_PERMS > #include "unixd.h" /* for unixd_set_global_mutex_perms */ > #endif > > What's this AP_NEED_SET_MUTEX_PERMS ? > > On my Linux box I could see : > > /usr/include/apache2/os.h:#define AP_NEED_SET_MUTEX_PERMS 1 > > See it also on i5/OS V6R1 : > > /QIBM/ProdData/HTTPA/Include/os.h : > > /* On platforms where AP_NEED_SET_MUTEX_PERMS is defined, modules > #define AP_NEED_SET_MUTEX_PERMS 1 /* @A1A */ > > Later I could see : > > #if JK_NEED_SET_MUTEX_PERMS > #if (MODULE_MAGIC_NUMBER_MAJOR >= 20090208) > rv = ap_unixd_set_global_mutex_perms(jk_log_lock); > #else > rv = unixd_set_global_mutex_perms(jk_log_lock); > #endif > > MODULE_MAGIC_NUMBER_MAJOR is which version of Apache 2.2.x ? > > > 2009/7/29 Henri Gomez : >> We allready have a V6R1 partition available but some pre-requisite are >> still missing (like OpenSSH). >> >> When they will, I'll do the build. >> >> BTW, ASF will have to provide two binaries, one for V5R3/V5R4 and one >> for V6R1 ;) >> >> >> >> >> 2009/7/29 Josh Gooding : >>> I never had V6. V5R3 and 4 are the last ones I had. I like the i5. I wish >>> I could find one of the smaller ones with a small expansion cabinet to play >>> with. >>> >>> On Wed, Jul 29, 2009 at 11:49 AM, Mladen Turk wrote: >>> On 29/07/09 17:25, Rainer Jung wrote: > > Of course first you need to get access to V6R1... > > I had V6 once, but it was Peugeot Coupe. Nasty beast :) Anyhow, perhaps Henri can upload some binaries inside the dist if relevant. Cheers -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org >>> >> > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Notice : No more IBM support JK/Tomcat on i5/OS V6R1
Henri Gomez wrote: > The question here is : > > Why did we use unixd_set_global_mutex_perms/ap_unixd_set_global_mutex_perms > since both call didn't exist in i5/OS V6R1 and I had to set > JK_NEED_SET_MUTEX_PERMS to 0 to have them excluded. Because otherwise, root created file locking objects are inaccessible to the child process running in a restricted security context. Clear enough? Perhaps the httpd/apr port is whacked. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
