svn commit: r797425 - in /tomcat/trunk: build.xml dist.xml extras.xml
Author: rjung Date: Fri Jul 24 12:14:05 2009 New Revision: 797425 URL: http://svn.apache.org/viewvc?rev=797425&view=rev Log: Correct build.properties.default file name in more build files and explain more explicit how the customization files work. Modified: tomcat/trunk/build.xml tomcat/trunk/dist.xml tomcat/trunk/extras.xml Modified: tomcat/trunk/build.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/build.xml?rev=797425&r1=797424&r2=797425&view=diff == --- tomcat/trunk/build.xml (original) +++ tomcat/trunk/build.xml Fri Jul 24 12:14:05 2009 @@ -20,8 +20,15 @@ - - + + + + + + + + + Modified: tomcat/trunk/dist.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/dist.xml?rev=797425&r1=797424&r2=797425&view=diff == --- tomcat/trunk/dist.xml (original) +++ tomcat/trunk/dist.xml Fri Jul 24 12:14:05 2009 @@ -20,8 +20,15 @@ - - + + + + + + + + + Modified: tomcat/trunk/extras.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/extras.xml?rev=797425&r1=797424&r2=797425&view=diff == --- tomcat/trunk/extras.xml (original) +++ tomcat/trunk/extras.xml Fri Jul 24 12:14:05 2009 @@ -20,8 +20,15 @@ - - + + + + + + + + + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r797151 - /tomcat/trunk/build.xml
On 23.07.2009 20:43, sebb wrote: > On 23/07/2009, ma...@apache.org wrote: >> Author: markt >> Date: Thu Jul 23 17:15:55 2009 >> New Revision: 797151 >> >> URL: http://svn.apache.org/viewvc?rev=797151&view=rev >> Log: >> Correct the file name >> >> Modified: >> tomcat/trunk/build.xml >> >> Modified: tomcat/trunk/build.xml >> URL: >> http://svn.apache.org/viewvc/tomcat/trunk/build.xml?rev=797151&r1=797150&r2=797151&view=diff >> >> == >> --- tomcat/trunk/build.xml (original) >> +++ tomcat/trunk/build.xml Thu Jul 23 17:15:55 2009 >> @@ -20,7 +20,7 @@ >> >> >> >> - >> + >> > > AFAICT there's no *need* to customise any values, so may I suggest: > > s/for all/for/ > s/you must/you may need to/ I fixed the file name in the other two build files also, and made the text more explicit. I hope everyone is satisfied ... See: https://svn.apache.org/viewcvs.cgi?view=rev&rev=797425 Regards, Rainer - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r797151 - /tomcat/trunk/build.xml
On 24/07/2009, Rainer Jung wrote: > On 23.07.2009 20:43, sebb wrote: > > On 23/07/2009, ma...@apache.org wrote: > >> Author: markt > >> Date: Thu Jul 23 17:15:55 2009 > >> New Revision: 797151 > >> > >> URL: http://svn.apache.org/viewvc?rev=797151&view=rev > >> Log: > >> Correct the file name > >> > >> Modified: > >> tomcat/trunk/build.xml > >> > >> Modified: tomcat/trunk/build.xml > >> URL: > http://svn.apache.org/viewvc/tomcat/trunk/build.xml?rev=797151&r1=797150&r2=797151&view=diff > >> > == > >> --- tomcat/trunk/build.xml (original) > >> +++ tomcat/trunk/build.xml Thu Jul 23 17:15:55 2009 > >> @@ -20,7 +20,7 @@ > >> > >> > >> > >> - > >> + > >> > > > > AFAICT there's no *need* to customise any values, so may I suggest: > > > > s/for all/for/ > > s/you must/you may need to/ > > > I fixed the file name in the other two build files also, and made the > text more explicit. I hope everyone is satisfied ... +1 > See: https://svn.apache.org/viewcvs.cgi?view=rev&rev=797425 That's much clearer; thanks! > Regards, > > > Rainer > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r797528 - in /tomcat/trunk/modules/jdbc-pool: doc/ java/org/apache/tomcat/jdbc/pool/
Author: fhanik
Date: Fri Jul 24 15:24:52 2009
New Revision: 797528
URL: http://svn.apache.org/viewvc?rev=797528&view=rev
Log:
Add in Linux special case for performance optimization around locking.
Set default queue to be the fair one
Remove unused code
Modified:
tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/DataSourceProxy.java
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/FairBlockingQueue.java
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/PoolConfiguration.java
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/PoolProperties.java
Modified: tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml?rev=797528&r1=797527&r2=797528&view=diff
==
--- tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml (original)
+++ tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml Fri Jul 24 15:24:52 2009
@@ -353,10 +353,16 @@
(boolean) Set to true if you wish that calls to getConnection should
be treated
fairly in a true FIFO fashion. This uses the
org.apache.tomcat.jdbc.pool.FairBlockingQueue
- implementation for the list of the idle connections. The default
value is false.
+ implementation for the list of the idle connections. The default
value is true.
This flag is required when you want to use asynchronous connection
retrieval.
- During performance tests, the fairQueue does very well on a multi
core Solaris system,
- but performs terribly on a Linux Fedora 11 system. On Linux we
recommend setting this to false.
+ Setting this flag ensures that threads receive connections in the
order they arrive.
+ During performance tests, there is a very large difference in how
locks
+ and lock waiting is implemented. When fairQueue=true>
+ there is a decision making process based on what operating system the
system is running.
+ If the system is running on Linux (property
os.name=Linux.
+ To disable this Linux specific behavior and still use the fair queue,
simply add the property
+
org.apache.tomcat.jdbc.pool.FairBlockingQueue.ignoreOS=true to
your system properties
+ before the connection pool classes are loaded.
Modified:
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java?rev=797528&r1=797527&r2=797528&view=diff
==
---
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
(original)
+++
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
Fri Jul 24 15:24:52 2009
@@ -148,6 +148,9 @@
if (idle instanceof FairBlockingQueue) {
Future pcf =
((FairBlockingQueue)idle).pollAsync();
return new ConnectionFuture(pcf);
+} else if (idle instanceof MultiLockFairBlockingQueue) {
+Future pcf =
((MultiLockFairBlockingQueue)idle).pollAsync();
+return new ConnectionFuture(pcf);
} else {
throw new SQLException("Connection pool is misconfigured, doesn't
support async retrieval. Set the 'fair' property to 'true'");
}
@@ -306,21 +309,6 @@
}
/**
- * If the connection pool gets garbage collected, lets make sure we clean
up
- * and close all the connections.
- * {...@inheritdoc}
- */
-@Override
-protected void finalize() throws Throwable {
-//Runnable closer = new Runnable() {
-//public void run() {
-//close(true);
-//}
-//};
-//this.cancellator.execute(closer);
-}
-
-/**
* Closes the pool and all disconnects all idle connections
* Active connections will be closed upon the {...@link
java.sql.Connection#close close} method is called
* on the underlying connection instead of being returned to the pool
@@ -381,6 +369,7 @@
//make space for 10 extra in case we flow over a bit
if (properties.isFairQueue()) {
idle = new FairBlockingQueue();
+//idle = new MultiLockFairBlockingQueue();
} else {
idle = new
ArrayBlockingQueue(properties.getMaxActive(),properties.isFairQueue());
}
Modified:
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/DataSourceProxy.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/DataSourceProxy.java?rev=797528&r1=797527&r2=797528&view=diff
svn commit: r797529 - in /tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test: AbandonPercentageTest.java BorrowWaitTest.java DefaultTestCase.java TestConcurrency.java
Author: fhanik
Date: Fri Jul 24 15:25:17 2009
New Revision: 797529
URL: http://svn.apache.org/viewvc?rev=797529&view=rev
Log:
update test cases
Modified:
tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/AbandonPercentageTest.java
tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/BorrowWaitTest.java
tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/DefaultTestCase.java
tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/TestConcurrency.java
Modified:
tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/AbandonPercentageTest.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/AbandonPercentageTest.java?rev=797529&r1=797528&r2=797529&view=diff
==
---
tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/AbandonPercentageTest.java
(original)
+++
tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/AbandonPercentageTest.java
Fri Jul 24 15:25:17 2009
@@ -38,7 +38,6 @@
this.datasource.getPoolProperties().setRemoveAbandoned(true);
this.datasource.getPoolProperties().setRemoveAbandonedTimeout(1);
Connection con = datasource.getConnection();
-long start = System.currentTimeMillis();
assertEquals("Number of connections active/busy should be
1",1,datasource.getPool().getActive());
Thread.sleep(2000);
assertEquals("Number of connections active/busy should be
0",0,datasource.getPool().getActive());
@@ -56,7 +55,6 @@
this.datasource.getPoolProperties().setRemoveAbandoned(true);
this.datasource.getPoolProperties().setRemoveAbandonedTimeout(1);
Connection con = datasource.getConnection();
-long start = System.currentTimeMillis();
assertEquals("Number of connections active/busy should be
1",1,datasource.getPool().getActive());
Thread.sleep(2000);
assertEquals("Number of connections active/busy should be
1",1,datasource.getPool().getActive());
@@ -75,7 +73,6 @@
this.datasource.getPoolProperties().setRemoveAbandonedTimeout(1);
this.datasource.getPoolProperties().setJdbcInterceptors(ResetAbandonedTimer.class.getName());
Connection con = datasource.getConnection();
-long start = System.currentTimeMillis();
assertEquals("Number of connections active/busy should be
1",1,datasource.getPool().getActive());
for (int i=0; i<20; i++) {
Thread.sleep(200);
@@ -97,7 +94,6 @@
this.datasource.getPoolProperties().setRemoveAbandonedTimeout(1);
Connection[] con = new Connection[size];
con[0] = datasource.getConnection();
-long start = System.currentTimeMillis();
assertEquals("Number of connections active/busy should be
1",1,datasource.getPool().getActive());
for (int i=1; i<25; i++) {
con[i] = datasource.getConnection();
Modified:
tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/BorrowWaitTest.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/BorrowWaitTest.java?rev=797529&r1=797528&r2=797529&view=diff
==
---
tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/BorrowWaitTest.java
(original)
+++
tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/BorrowWaitTest.java
Fri Jul 24 15:25:17 2009
@@ -32,10 +32,10 @@
this.datasource.setMaxActive(1);
this.datasource.setMaxWait(wait);
Connection con = datasource.getConnection();
-long start = System.currentTimeMillis();
try {
Connection con2 = datasource.getConnection();
assertFalse("This should not happen, connection should be
unavailable.",true);
+con2.close();
}catch (SQLException x) {
long delta = System.currentTimeMillis();
boolean inrange = Math.abs(wait-delta) < 1000;
Modified:
tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/DefaultTestCase.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/DefaultTestCase.java?rev=797529&r1=797528&r2=797529&view=diff
==
---
tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/DefaultTestCase.java
(original)
+++
tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/DefaultTestCase.java
Fri Jul 24 15:25:17 2009
@@ -52,6 +52,7 @@
public org.apache.tomcat.jdbc.pool.DataSource createDefaultDataSource() {
org.apache.tomcat.jdbc.pool.DataSource datasource = null;
PoolConfiguration p = new DefaultProperties();
+p.setFairQueue(false);
p.setJmxEnabled(false);
p.setTestWh
Re: svn commit: r797529 - in /tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test: AbandonPercentageTest.java BorrowWaitTest.java DefaultTestCase.java TestConcurrency.java
On 24/07/2009, fha...@apache.org wrote:
> Author: fhanik
> Date: Fri Jul 24 15:25:17 2009
> New Revision: 797529
>
> URL: http://svn.apache.org/viewvc?rev=797529&view=rev
> Log:
> update test cases
>
> Modified:
>
> tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/AbandonPercentageTest.java
>
> tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/BorrowWaitTest.java
>
> tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/DefaultTestCase.java
>
> tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/TestConcurrency.java
>
> Modified:
> tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/AbandonPercentageTest.java
> URL:
> http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/AbandonPercentageTest.java?rev=797529&r1=797528&r2=797529&view=diff
>
> ==
> ---
> tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/AbandonPercentageTest.java
> (original)
> +++
> tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/AbandonPercentageTest.java
> Fri Jul 24 15:25:17 2009
> @@ -38,7 +38,6 @@
> this.datasource.getPoolProperties().setRemoveAbandoned(true);
> this.datasource.getPoolProperties().setRemoveAbandonedTimeout(1);
> Connection con = datasource.getConnection();
> -long start = System.currentTimeMillis();
> assertEquals("Number of connections active/busy should be
> 1",1,datasource.getPool().getActive());
> Thread.sleep(2000);
> assertEquals("Number of connections active/busy should be
> 0",0,datasource.getPool().getActive());
> @@ -56,7 +55,6 @@
> this.datasource.getPoolProperties().setRemoveAbandoned(true);
> this.datasource.getPoolProperties().setRemoveAbandonedTimeout(1);
> Connection con = datasource.getConnection();
> -long start = System.currentTimeMillis();
> assertEquals("Number of connections active/busy should be
> 1",1,datasource.getPool().getActive());
> Thread.sleep(2000);
> assertEquals("Number of connections active/busy should be
> 1",1,datasource.getPool().getActive());
> @@ -75,7 +73,6 @@
> this.datasource.getPoolProperties().setRemoveAbandonedTimeout(1);
>
> this.datasource.getPoolProperties().setJdbcInterceptors(ResetAbandonedTimer.class.getName());
> Connection con = datasource.getConnection();
> -long start = System.currentTimeMillis();
> assertEquals("Number of connections active/busy should be
> 1",1,datasource.getPool().getActive());
> for (int i=0; i<20; i++) {
> Thread.sleep(200);
> @@ -97,7 +94,6 @@
> this.datasource.getPoolProperties().setRemoveAbandonedTimeout(1);
> Connection[] con = new Connection[size];
> con[0] = datasource.getConnection();
> -long start = System.currentTimeMillis();
> assertEquals("Number of connections active/busy should be
> 1",1,datasource.getPool().getActive());
> for (int i=1; i<25; i++) {
> con[i] = datasource.getConnection();
>
> Modified:
> tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/BorrowWaitTest.java
> URL:
> http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/BorrowWaitTest.java?rev=797529&r1=797528&r2=797529&view=diff
>
> ==
> ---
> tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/BorrowWaitTest.java
> (original)
> +++
> tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/BorrowWaitTest.java
> Fri Jul 24 15:25:17 2009
> @@ -32,10 +32,10 @@
> this.datasource.setMaxActive(1);
> this.datasource.setMaxWait(wait);
> Connection con = datasource.getConnection();
> -long start = System.currentTimeMillis();
> try {
> Connection con2 = datasource.getConnection();
> assertFalse("This should not happen, connection should be
> unavailable.",true);
> +con2.close();
> }catch (SQLException x) {
> long delta = System.currentTimeMillis();
> boolean inrange = Math.abs(wait-delta) < 1000;
>
> Modified:
> tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/DefaultTestCase.java
> URL:
> http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/DefaultTestCase.java?rev=797529&r1=797528&r2=797529&view=diff
>
> ==
> ---
> tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/DefaultTestCase.java
> (original)
> +++
> tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/DefaultTestCase.java
> Fri Jul 24 15:25:17 2009
> @@ -52,6 +52,7
DO NOT REPLY [Bug 42996] POST with nio connector results in missing variables
https://issues.apache.org/bugzilla/show_bug.cgi?id=42996 --- Comment #19 from Jerome Louvel 2009-07-24 10:00:31 PST --- Some Restlet users encountered a very similar issue: their sometimes get requests with an empty content (the POST/PUT entity is somehow lost). I was able to reproduce the issue with load testing and chaining GET/PUT calls. It seemed to me that Tomcat broke some connections, while still allowing the Servlet request to go through. This was tested with Tomcat 5.5.27, Tomcat 6.0.18 and Tomcat 6.0.20. The exact same WAR deployed in Jetty 6.1 doesn't have any issue. See history of our issue here: http://restlet.tigris.org/issues/show_bug.cgi?id=843 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 47566] Update to NSIS 2.45
https://issues.apache.org/bugzilla/show_bug.cgi?id=47566 --- Comment #1 from Konstantin Kolinko 2009-07-24 10:51:34 PST --- Thank you for the reminder. By the way, Ant downloads from downloads.sourceforge.net are currently broken, because their site does not properly encode URL in Location: header when providing a redirect. That is currently being tracked as https://sourceforge.net/apps/trac/sourceforge/ticket/2628 A temporary workaround would be to use a mirror, instead of the main site. E.g., to define base-sf.loc=http://sunet.dl.sourceforge.net in build.properties -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r797596 - /tomcat/trunk/build.properties.default
Author: kkolinko
Date: Fri Jul 24 18:31:58 2009
New Revision: 797596
URL: http://svn.apache.org/viewvc?rev=797596&view=rev
Log:
Update to NSIS 2.45
https://issues.apache.org/bugzilla/show_bug.cgi?id=47566
This version adds support for the upcoming release of Microsoft Windows 7
Release notes: http://sourceforge.net/project/shownotes.php?release_id=688043
Modified:
tomcat/trunk/build.properties.default
Modified: tomcat/trunk/build.properties.default
URL:
http://svn.apache.org/viewvc/tomcat/trunk/build.properties.default?rev=797596&r1=797595&r2=797596&view=diff
==
--- tomcat/trunk/build.properties.default (original)
+++ tomcat/trunk/build.properties.default Fri Jul 24 18:31:58 2009
@@ -78,12 +78,12 @@
commons-pool-src.loc=${base-commons.loc}/pool/source/commons-pool-1.5.2-src.tar.gz
# - NSIS, version 2.0 or later -
-nsis.home=${base.path}/nsis-2.44
+nsis.home=${base.path}/nsis-2.45
nsis.exe=${nsis.home}/makensis.exe
nsis.installoptions.dll=${nsis.home}/Plugins/InstallOptions.dll
nsis.nsexec.dll=${nsis.home}/Plugins/nsExec.dll
nsis.nsisdl.dll=${nsis.home}/Plugins/NSISdl.dll
-nsis.loc=${base-sf.loc}/nsis/nsis-2.44.zip
+nsis.loc=${base-sf.loc}/nsis/nsis-2.45.zip
# - Commons Daemon, version 1.0-Alpha or later -
commons-daemon.home=${base.path}/commons-daemon-1.0.1
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r797600 - /tomcat/trunk/build.properties.default
Author: kkolinko Date: Fri Jul 24 18:40:55 2009 New Revision: 797600 URL: http://svn.apache.org/viewvc?rev=797600&view=rev Log: Temporarily use a mirror, while there is a problem with downloads.sourceforge.net https://sourceforge.net/apps/trac/sourceforge/ticket/2628 Modified: tomcat/trunk/build.properties.default Modified: tomcat/trunk/build.properties.default URL: http://svn.apache.org/viewvc/tomcat/trunk/build.properties.default?rev=797600&r1=797599&r2=797600&view=diff == --- tomcat/trunk/build.properties.default (original) +++ tomcat/trunk/build.properties.default Fri Jul 24 18:40:55 2009 @@ -45,7 +45,11 @@ base-commons.loc=http://archive.apache.org/dist/commons base-tomcat.loc=http://archive.apache.org/dist/tomcat -base-sf.loc=http://downloads.sourceforge.net +#base-sf.loc=http://downloads.sourceforge.net +# Temporarily use a mirror, while there is a problem +# with downloads.sourceforge.net +# https://sourceforge.net/apps/trac/sourceforge/ticket/2628 +base-sf.loc=http://sunet.dl.sourceforge.net # - Commons Logging, version 1.1 or later - commons-logging-version=1.1.1 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r797528 - in /tomcat/trunk/modules/jdbc-pool: doc/ java/org/apache/tomcat/jdbc/pool/
On 24/07/2009, fha...@apache.org wrote:
> Author: fhanik
> Date: Fri Jul 24 15:24:52 2009
> New Revision: 797528
>
> URL: http://svn.apache.org/viewvc?rev=797528&view=rev
> Log:
> Add in Linux special case for performance optimization around locking.
> Set default queue to be the fair one
> Remove unused code
>
>
> Modified:
> tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml
>
> tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
>
> tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/DataSourceProxy.java
>
> tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/FairBlockingQueue.java
>
> tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/PoolConfiguration.java
>
> tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/PoolProperties.java
>
> Modified: tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml
> URL:
> http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml?rev=797528&r1=797527&r2=797528&view=diff
>
> ==
> --- tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml (original)
> +++ tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml Fri Jul 24 15:24:52 2009
> @@ -353,10 +353,16 @@
>
>(boolean) Set to true if you wish that calls to getConnection
> should be treated
> fairly in a true FIFO fashion. This uses the
> org.apache.tomcat.jdbc.pool.FairBlockingQueue
> - implementation for the list of the idle connections. The default
> value is false.
> + implementation for the list of the idle connections. The default
> value is true.
> This flag is required when you want to use asynchronous connection
> retrieval.
> - During performance tests, the fairQueue does very well on a multi
> core Solaris system,
> - but performs terribly on a Linux Fedora 11 system. On Linux we
> recommend setting this to false.
> + Setting this flag ensures that threads receive connections in the
> order they arrive.
> + During performance tests, there is a very large difference in how
> locks
> + and lock waiting is implemented. When fairQueue=true>
> + there is a decision making process based on what operating system
> the system is running.
> + If the system is running on Linux (property
> os.name=Linux.
> + To disable this Linux specific behavior and still use the fair
> queue, simply add the property
> +
> org.apache.tomcat.jdbc.pool.FairBlockingQueue.ignoreOS=true to
> your system properties
> + before the connection pool classes are loaded.
>
>
>
>
> Modified:
> tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
> URL:
> http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java?rev=797528&r1=797527&r2=797528&view=diff
>
> ==
> ---
> tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
> (original)
> +++
> tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
> Fri Jul 24 15:24:52 2009
> @@ -148,6 +148,9 @@
> if (idle instanceof FairBlockingQueue) {
> Future pcf =
> ((FairBlockingQueue)idle).pollAsync();
> return new ConnectionFuture(pcf);
> +} else if (idle instanceof MultiLockFairBlockingQueue) {
> +Future pcf =
> ((MultiLockFairBlockingQueue)idle).pollAsync();
> +return new ConnectionFuture(pcf);
> } else {
> throw new SQLException("Connection pool is misconfigured,
> doesn't support async retrieval. Set the 'fair' property to 'true'");
> }
> @@ -306,21 +309,6 @@
> }
>
> /**
> - * If the connection pool gets garbage collected, lets make sure we
> clean up
> - * and close all the connections.
> - * {...@inheritdoc}
> - */
> -@Override
> -protected void finalize() throws Throwable {
> -//Runnable closer = new Runnable() {
> -//public void run() {
> -//close(true);
> -//}
> -//};
> -//this.cancellator.execute(closer);
> -}
> -
> -/**
> * Closes the pool and all disconnects all idle connections
> * Active connections will be closed upon the {...@link
> java.sql.Connection#close close} method is called
> * on the underlying connection instead of being returned to the pool
> @@ -381,6 +369,7 @@
> //make space for 10 extra in case we flow over a bit
> if (properties.isFairQueue()) {
> idle = new FairBlockingQueue();
> +//idle = new MultiLockFairBlockingQueue();
> } else {
> idle = new
> ArrayBlockingQueue
svn commit: r797602 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: kkolinko Date: Fri Jul 24 18:54:12 2009 New Revision: 797602 URL: http://svn.apache.org/viewvc?rev=797602&view=rev Log: proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=797602&r1=797601&r2=797602&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Fri Jul 24 18:54:12 2009 @@ -173,3 +173,12 @@ http://svn.apache.org/viewvc?view=rev&revision=797168 +1: markt, kkolinko -1: + +* https://issues.apache.org/bugzilla/show_bug.cgi?id=47566 + Update to NSIS 2.45 + http://svn.apache.org/viewvc?rev=797596&view=rev + +1: kkolinko + -1: + kkolinko: Now it also requires the following patch, but I hope that + sourceforge.net will fix their error: +http://svn.apache.org/viewvc?rev=797600&view=rev - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r797604 - /tomcat/current/tc5.5.x/STATUS.txt
Author: kkolinko Date: Fri Jul 24 19:00:30 2009 New Revision: 797604 URL: http://svn.apache.org/viewvc?rev=797604&view=rev Log: proposal Modified: tomcat/current/tc5.5.x/STATUS.txt Modified: tomcat/current/tc5.5.x/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=797604&r1=797603&r2=797604&view=diff == --- tomcat/current/tc5.5.x/STATUS.txt (original) +++ tomcat/current/tc5.5.x/STATUS.txt Fri Jul 24 19:00:30 2009 @@ -87,3 +87,12 @@ http://svn.apache.org/viewvc?view=rev&revision=797168 +1: markt, kkolinko -1: + +* https://issues.apache.org/bugzilla/show_bug.cgi?id=47566 + Update to NSIS 2.45 + http://svn.apache.org/viewvc?rev=797596&view=rev + +1: kkolinko + -1: + kkolinko: Now it also requires the following patch, but I hope that + sourceforge.net will fix their error: +http://svn.apache.org/viewvc?rev=797600&view=rev - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 47566] Update to NSIS 2.45
https://issues.apache.org/bugzilla/show_bug.cgi?id=47566 --- Comment #2 from Konstantin Kolinko 2009-07-24 12:04:55 PST --- Applied to trunk, proposed for 5.5 and 6.0. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r797607 - /tomcat/trunk/java/org/apache/jasper/compiler/JspUtil.java
Author: markt
Date: Fri Jul 24 19:06:54 2009
New Revision: 797607
URL: http://svn.apache.org/viewvc?rev=797607&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=41824
Need to use canonical rather than binary form when writing code
Modified:
tomcat/trunk/java/org/apache/jasper/compiler/JspUtil.java
Modified: tomcat/trunk/java/org/apache/jasper/compiler/JspUtil.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/compiler/JspUtil.java?rev=797607&r1=797606&r2=797607&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/compiler/JspUtil.java (original)
+++ tomcat/trunk/java/org/apache/jasper/compiler/JspUtil.java Fri Jul 24
19:06:54 2009
@@ -379,7 +379,7 @@
* Determine whether to use the expected type's textual name or, if
it's
* a primitive, the name of its correspondent boxed type.
*/
-String targetType = expectedType.getName();
+String targetType = getCanonicalName(expectedType);
String primitiveConverterMethod = null;
if (expectedType.isPrimitive()) {
if (expectedType.equals(Boolean.TYPE)) {
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r797611 - in /tomcat: current/tc5.5.x/STATUS.txt tc6.0.x/trunk/STATUS.txt
Author: markt Date: Fri Jul 24 19:10:17 2009 New Revision: 797611 URL: http://svn.apache.org/viewvc?rev=797611&view=rev Log: Propose fix for 41824 Modified: tomcat/current/tc5.5.x/STATUS.txt tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/current/tc5.5.x/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=797611&r1=797610&r2=797611&view=diff == --- tomcat/current/tc5.5.x/STATUS.txt (original) +++ tomcat/current/tc5.5.x/STATUS.txt Fri Jul 24 19:10:17 2009 @@ -96,3 +96,9 @@ kkolinko: Now it also requires the following patch, but I hope that sourceforge.net will fix their error: http://svn.apache.org/viewvc?rev=797600&view=rev + +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=41824 + Need to use canonical rather than binary form when writing code + http://svn.apache.org/viewvc?rev=797607&view=rev + +1: markt + -1: Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=797611&r1=797610&r2=797611&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Fri Jul 24 19:10:17 2009 @@ -182,3 +182,9 @@ kkolinko: Now it also requires the following patch, but I hope that sourceforge.net will fix their error: http://svn.apache.org/viewvc?rev=797600&view=rev + +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=41824 + Need to use canonical rather than binary form when writing code + http://svn.apache.org/viewvc?rev=797607&view=rev + +1: markt + -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 41824] Unable to use nested type in TLD
https://issues.apache.org/bugzilla/show_bug.cgi?id=41824 --- Comment #2 from Mark Thomas 2009-07-24 12:10:36 PST --- This has been fixed in trunk and proposed for 5.5.x and 6.0.x -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r797615 - /tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/FairBlockingQueue.java
Author: fhanik
Date: Fri Jul 24 19:13:44 2009
New Revision: 797615
URL: http://svn.apache.org/viewvc?rev=797615&view=rev
Log:
Remove a non occuring condition
Modified:
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/FairBlockingQueue.java
Modified:
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/FairBlockingQueue.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/FairBlockingQueue.java?rev=797615&r1=797614&r2=797615&view=diff
==
---
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/FairBlockingQueue.java
(original)
+++
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/FairBlockingQueue.java
Fri Jul 24 19:13:44 2009
@@ -100,7 +100,7 @@
c = waiters.poll();
//give the object to the thread instead of adding it to the
pool
c.setItem(e);
-if (isLinux && c!=null) c.countDown();
+if (isLinux) c.countDown();
} else {
//we always add first, so that the most recently used object
will be given out
items.addFirst(e);
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r797616 - in /tomcat/trunk/modules/jdbc-pool: build.properties.default sign.sh
Author: fhanik Date: Fri Jul 24 19:15:31 2009 New Revision: 797616 URL: http://svn.apache.org/viewvc?rev=797616&view=rev Log: up the version Modified: tomcat/trunk/modules/jdbc-pool/build.properties.default tomcat/trunk/modules/jdbc-pool/sign.sh Modified: tomcat/trunk/modules/jdbc-pool/build.properties.default URL: http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/build.properties.default?rev=797616&r1=797615&r2=797616&view=diff == --- tomcat/trunk/modules/jdbc-pool/build.properties.default (original) +++ tomcat/trunk/modules/jdbc-pool/build.properties.default Fri Jul 24 19:15:31 2009 @@ -27,7 +27,7 @@ # - Vesion Control Flags - version.major=1 version.minor=0 -version.build=6 +version.build=7 version.patch= version.suffix= Modified: tomcat/trunk/modules/jdbc-pool/sign.sh URL: http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/sign.sh?rev=797616&r1=797615&r2=797616&view=diff == --- tomcat/trunk/modules/jdbc-pool/sign.sh (original) +++ tomcat/trunk/modules/jdbc-pool/sign.sh Fri Jul 24 19:15:31 2009 @@ -15,7 +15,7 @@ # See the License for the specific language governing permissions and # limitations under the License. -VERSION=v1.0.6 +VERSION=v1.0.7 for i in $(find output/release/$VERSION -name "*.zip" -o -name "*.tar.gz"); do echo Signing $i echo $1|gpg --passphrase-fd 0 -a -b $i - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 42996] POST with nio connector results in missing variables
https://issues.apache.org/bugzilla/show_bug.cgi?id=42996 Filip Hanik changed: What|Removed |Added Status|REOPENED|NEEDINFO --- Comment #20 from Filip Hanik 2009-07-24 12:46:34 PST --- I ran this through a TCP monitor, and at the time of the request that failed (ie, it had 0 parameters, here is what it looks like REQUEST 8< POST /test/action HTTP/1.1 Accept: */* Accept-Language: en-us Referer: http://10.0.2.2:8082/test/#send Content-Type: application/x-www-form-urlencoded; charset=UTF-8 Accept-Encoding: gzip, deflate User-Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.2; WOW64; Trident/4.0; GTB6; .NET CLR 2.0.50727; .NET CLR 3.0.4506.2152; .NET CLR 3.5.30729) Host: 10.0.2.2:8082 Content-Length: 25 Connection: Keep-Alive Cache-Control: no-cache Cookie: JSESSIONID=A6DABF8D3A1FEB0A173CCD78D8CD8BE8 8< The request says there should be a 25 byte content length, but there are no parameters in the request. Another (succesful request looks like this) SUCCESSFUL REQUEST 8< POST /test/action HTTP/1.1 Accept: */* Accept-Language: en-us Referer: http://10.0.2.2:8082/test/#send Content-Type: application/x-www-form-urlencoded; charset=UTF-8 Accept-Encoding: gzip, deflate User-Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.2; WOW64; Trident/4.0; GTB6; .NET CLR 2.0.50727; .NET CLR 3.0.4506.2152; .NET CLR 3.5.30729) Host: 10.0.2.2:8082 Content-Length: 25 Connection: Keep-Alive Cache-Control: no-cache Cookie: JSESSIONID=A6DABF8D3A1FEB0A173CCD78D8CD8BE8 param1=Lorem¶m2=ipsum 8< -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 42996] POST with nio connector results in missing variables
https://issues.apache.org/bugzilla/show_bug.cgi?id=42996 --- Comment #21 from Filip Hanik 2009-07-24 12:52:43 PST --- Created an attachment (id=24034) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24034) Output from wireshark, shows no body Same with an example from Wireshark, there is no body in the request -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 42996] POST with nio connector results in missing variables
https://issues.apache.org/bugzilla/show_bug.cgi?id=42996 --- Comment #22 from Filip Hanik 2009-07-24 12:54:06 PST --- (In reply to comment #19) > Some Restlet users encountered a very similar issue: their sometimes get > requests with an empty content (the POST/PUT entity is somehow lost). > > I was able to reproduce the issue with load testing and chaining GET/PUT > calls. > It seemed to me that Tomcat broke some connections, while still allowing the > Servlet request to go through. > > This was tested with Tomcat 5.5.27, Tomcat 6.0.18 and Tomcat 6.0.20. The exact > same WAR deployed in Jetty 6.1 doesn't have any issue. > > See history of our issue here: > http://restlet.tigris.org/issues/show_bug.cgi?id=843 Jerome, do you want to work with me to help setup a test case. That way I can try to reproduce it. I was able to reproduce the error with the test case provided, but it clearly shows that the client is not sending any body. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
5.5.28 release candidate
http://people.apache.org/~fhanik/tomcat/tomcat-5.5/v5.5.28/ I have not run the TCK on this yet Plan on vote mid to late next week Filip - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r797686 - /tomcat/trunk/modules/jdbc-pool/build.xml
Author: fhanik Date: Fri Jul 24 23:08:32 2009 New Revision: 797686 URL: http://svn.apache.org/viewvc?rev=797686&view=rev Log: Add missing files to distribution Modified: tomcat/trunk/modules/jdbc-pool/build.xml Modified: tomcat/trunk/modules/jdbc-pool/build.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/build.xml?rev=797686&r1=797685&r2=797686&view=diff == --- tomcat/trunk/modules/jdbc-pool/build.xml (original) +++ tomcat/trunk/modules/jdbc-pool/build.xml Fri Jul 24 23:08:32 2009 @@ -250,6 +250,8 @@ + + @@ -261,6 +263,8 @@ + + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
jdbc-pool 1.0.7 release candidate
http://people.apache.org/~fhanik/jdbc-pool/v1.0.7/ Same thing here, if all checks out well, plan a vote mid next week Filip - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: 5.5.28 release candidate
On 24/07/2009, Filip Hanik - Dev Lists wrote: > http://people.apache.org/~fhanik/tomcat/tomcat-5.5/v5.5.28/ There is no .zip version of apache-tomcat-5.5.28-fulldocs.tar.gz The source archives contain the file container/webapps/admin/images/Thumbs.db which does not belong in the archive. Also, the file container/modules/storeconfig-ha/test/conf/catalina.keystore is different in the .zip and .tar.gz versions of the archives. Looks like a packaging error - perhaps accidental EOL conversion? There are no NOTICE or LICENSE files in the top-level of the source archives. The binary archives contain the files bin/jsvc.tar.gz bin/tomcat-native.tar.gz which appears to be source code only. When the EXE is unpacked, there is no RELEASE-NOTES file in the top-level directory where one would expect to find it. The server.xml file in the EXE is different from the one in the bin file and appears to be an old version. Likewise, the file tomcat-users.xml looks wrong - it says that there is no user with the manager role, yet it contains the following entry: > I have not run the TCK on this yet > Plan on vote mid to late next week > > Filip > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: 5.5.28 release candidate
how much of that is different from 5.5.27? Filip On 07/24/2009 05:44 PM, sebb wrote: On 24/07/2009, Filip Hanik - Dev Lists wrote: http://people.apache.org/~fhanik/tomcat/tomcat-5.5/v5.5.28/ There is no .zip version of apache-tomcat-5.5.28-fulldocs.tar.gz The source archives contain the file container/webapps/admin/images/Thumbs.db which does not belong in the archive. Also, the file container/modules/storeconfig-ha/test/conf/catalina.keystore is different in the .zip and .tar.gz versions of the archives. Looks like a packaging error - perhaps accidental EOL conversion? There are no NOTICE or LICENSE files in the top-level of the source archives. The binary archives contain the files bin/jsvc.tar.gz bin/tomcat-native.tar.gz which appears to be source code only. When the EXE is unpacked, there is no RELEASE-NOTES file in the top-level directory where one would expect to find it. The server.xml file in the EXE is different from the one in the bin file and appears to be an old version. Likewise, the file tomcat-users.xml looks wrong - it says that there is no user with the manager role, yet it contains the following entry: I have not run the TCK on this yet Plan on vote mid to late next week Filip - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 47576] New: Javadoc errors - Exception name misspelt
https://issues.apache.org/bugzilla/show_bug.cgi?id=47576 Summary: Javadoc errors - Exception name misspelt Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Priority: P2 Component: Modules: jdbc-pool AssignedTo: dev@tomcat.apache.org ReportedBy: s...@apache.org The files FairBlockingQueue.java MultiLockFairBlockingQueue.java use * @throws UnsupportedOperation This should be * @throws UnsupportedOperationException -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 47577] New: Unused imports and other compilation warnings
https://issues.apache.org/bugzilla/show_bug.cgi?id=47577 Summary: Unused imports and other compilation warnings Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Windows XP Status: NEW Severity: minor Priority: P2 Component: Modules: jdbc-pool AssignedTo: dev@tomcat.apache.org ReportedBy: s...@apache.org Created an attachment (id=24035) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24035) List of Eclipse compiler warnings Several files have unused imports, use raw types or have other minor problems. See attached file for details. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 47576] Javadoc errors - Exception name misspelt
https://issues.apache.org/bugzilla/show_bug.cgi?id=47576 --- Comment #1 from Sebb 2009-07-24 17:40:06 PST --- Created an attachment (id=24036) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24036) Patch to fix Exception names -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
