svn commit: r788642 - in /tomcat/site/trunk: docs/index.html xdocs/index.xml
Author: jfclere Date: Fri Jun 26 09:46:23 2009 New Revision: 788642 URL: http://svn.apache.org/viewvc?rev=788642&view=rev Log: Add a session about ApacheUS2009. Modified: tomcat/site/trunk/docs/index.html tomcat/site/trunk/xdocs/index.xml Modified: tomcat/site/trunk/docs/index.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/index.html?rev=788642&r1=788641&r2=788642&view=diff == --- tomcat/site/trunk/docs/index.html (original) +++ tomcat/site/trunk/docs/index.html Fri Jun 26 09:46:23 2009 @@ -3,21 +3,21 @@ Apache Tomcat - Apache Tomcat - - - - - - + + + + + + - - + + http://tomcat.apache.org/";> - + @@ -28,28 +28,28 @@ http://www.apache.org/";> -http://www.apache.org/images/asf-logo.gif"; align="right" alt="Apache Logo" border="0"/> +http://www.apache.org/images/asf-logo.gif"; /> -http://www.google.com/search"; method="get"> - - - +http://www.google.com/search";> + + + - + - + - + Apache Tomcat @@ -178,11 +178,11 @@ - - + + - + Apache Tomcat @@ -215,14 +215,50 @@ - + - + - + + +Upcoming: Tomcat tracks at ApacheCon US 2009 + + + + + + + + +http://www.us.apachecon.com/c/acus2009/";> +http://www.apache.org/ads/ApacheCon/2009-usa-125x125.png"; style="width: 125px;height: 125px;" align="right" /> + +ApacheCon US 2009, 2-6 November 2009 in Oakland, CA, will have a dedicated track about Tomcat topics. + We will celebrate our 10th anniversary as an Apache project, explain the futur developements: Tomcat7, asynchrounous servlets, + show how to get the best of Tomcat and how to front-end Tomcat clusters. + And the day after we will have a "geek day" where you can get hands-on advice and really join the ranks of the Tomcat initiated! + + + Join us in Oakland! + + + + + + + + + + + + + + + + Live Video Streaming of Tomcat Talks at ApacheCon Europe 2009 @@ -233,7 +269,7 @@ -http://eu.apachecon.com/page_attachments//0188/Live_Video_v2.gif"; alt="[Live Video Streaming at ApacheCon]" align="right"/> +http://eu.apachecon.com/page_attachments//0188/Live_Video_v2.gif"; alt="[Live Video Streaming at ApacheCon]" align="right" /> ApacheCon Europe 2009, 23-27 March in Amsterdam, has a dedicated track about Tomcat topics. If you cannot make it to Amsterdam this time, you can @@ -257,14 +293,14 @@ - + - + - + Apache Tomcat Versions @@ -281,51 +317,51 @@ - - + + Servlet/JSP Spec - - + + Apache Tomcat version - -2.5/2.1 + +2.5/2.1 - -6.0.20 + +6.0.20 - -2.4/2.0 + +2.4/2.0 - -5.5.27 + +5.5.27 - -2.3/1.2 + +2.3/1.2 - -4.1.40 + +4.1.40 - -2.2/1.1 + +2.2/1.1 - -3.3.2 (archived) + +3.3.2 (archived) @@ -351,7 +387,7 @@ - + @@ -360,17 +396,17 @@ - + - + Copyright © 1999-2009, The Apache Software Foundation - + "Apache", the Apache feather, and the Apache Tomcat logo are trademarks of the Apache Software Foundation for our open source software. Modified: tomcat/site/trunk/xdocs/index.xml URL: http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/index.xml?rev=788642&r1=788641&r2=788642&view=diff == --- tomcat/site/trunk/xdocs/index.xml (original) +++ tomcat/site/trunk/xdocs/index.xml Fri Jun 26 09:46:23 2009 @@ -30,6 +30,18 @@ + +http://www.us.apachecon.com/c/acus2009/";>http://www.apache.org/ads/ApacheCon/2009-usa-125x125.png"; style="width: 125px;height: 125px;" align="right"/> +ApacheCon US 2009, 2-6 November 2009 in Oakland, CA, will have a dedicated track about Tomcat topics. + We will celebrate our 10th anniversary as an Apache project, explain the futur developements: Tomcat7, asynchrounous servlets, + show how to get the best of Tomcat and how to front-end Tomcat clusters. + And the day after we will have a "geek day" where you can get hands-on advice and really join the ranks of the Tomcat initiated! + + Join us in Oakland! + + + + http://eu.apachecon.com/page_attachments//0188/Live_Video_v2.gif"; alt="[Live Video Streaming at ApacheCon]" align="right"> - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release JDBC Pool module v1.0.5
On 26/06/2009, Filip Hanik - Dev Lists wrote: > sebb wrote: > > > On 24/06/2009, Filip Hanik - Dev Lists wrote: > > > > > > > Cleaned up and fixed. > > > > > > The release is located here: > > > http://people.apache.org/~fhanik/jdbc-pool/v1.0.5/ > > > > > > > > > > Exactly the same path names were used previously; I assume you are > > referring to the following versions of the files: > > > > > apache-tomcat-jdbc-1.0.5-bin.tar.gz.md5:808cf400c4f7f4de7294b844c68108fa > > > apache-tomcat-jdbc-1.0.5-bin.zip.md5:3f20849d6b0dbe29bb9707cd519c456c > > > apache-tomcat-jdbc-1.0.5-src.tar.gz.md5:6a63d1e77c47c5d6385cf680dac4514c > > > apache-tomcat-jdbc-1.0.5-src.zip.md5:7b4870d50e498a18014031589b8a88eb > > > > rather than the older ones: > > > > > apache-tomcat-jdbc-1.0.5-bin.tar.gz.md5:b6081e6d34a8e9ecd70b505c90e73485 > > > apache-tomcat-jdbc-1.0.5-bin.zip.md5:76cb2efd7ce7093d71e4a989e71d2874 > > > apache-tomcat-jdbc-1.0.5-src.tar.gz.md5:d8d08870f3479080582d3261a4d1afe5 > > > apache-tomcat-jdbc-1.0.5-src.zip.md5:cc6992ff33524f15052f9b72588b628f > > > > == > > > > The source and test source archives contain META-INF/MANIFEST.MF files > > which don't belong in a source archive. > > > > > these are fine. > > > The binary archives contain MD5 hashes of all but one of the jars; > > again, these don't belong in the archives. > > > > The jars should contain NOTICE and LICENSE files. > > > > > no they should not. I think I've told you before, that NOTICE and LICENSE > files are for a release, not for individual files within a release. > > > There's no easily accessible documentation on how to build and test the > code. > > If someone is familiar with Ant, they can work out what the targets > > do, but the user should not have to do this. > > > > The ant script automatically downloads jars, some of which don't have > > Apache Licenses. In particular, the MySQL licence appears to be GPL, > > which is not compatible with the AL. > > > > > yes, I will remove this. > > > AFAICT, this is specifically forbidden: > > > > > http://www.apache.org/legal/3party.html#options-build-may2 > > > > The "ant test" target generates a few warnings, e.g. > > > > WARNING: Database connection pool evicter thread interval is set to > > lower than 1 second. > > > > Several of the tests fail. > > > > > I will remove all tests. It was a bad idea to include to begin with, since > they are not part of the release either. > > > There's no documentation on what database needs to be set up in order > > to run the database tests so I don't know if these are due to failure > > to set up the database correctly or whether the test failures were > > nothing to do with the database. > > > > > that will be solved when the tests go away In which case, how can reviewers test the code? That is not the solution either. It should be fairly easy to remove the dependency on MySQL and c3p0 - if not, then IMO the tests are too specific, as Tomcat DBCP should work with any JDBC provider. As an experiment, I tried using Derby instead of MySQL, and most of the tests worked. [I'm not yet sure why some tests failed. Unfortunately the output gives no clue to me.] I suggest changing the Ant test classpath to include whatever jars it finds in the include directory, and change the test code to pick up the database settings from build.properties Then all a tester has to do is put their JDBC jar in the directory and set up the database as required. > > > Ideally, the user should be given the option of running the JDBC tests > > against whatever database they prefer. If the tests require tables etc > > to be set up, these should either be done as part of the test setup, > > or there should be clear documentation on what data needs to be set > > up. > > > > > > > > > > > > [ ] STABLE - I couldn't find any bugs > > > [ ] BETA - I found some bugs but not critical > > > [ ] BROKEN - I found some show stoppers > > > > > > > > > Any comments ? > > > > > > Thanks, > > > Filip > > > > > > > - > > > To unsubscribe, e-mail: > dev-unsubscr...@tomcat.apache.org > > > For additional commands, e-mail: dev-h...@tomcat.apache.org > > > > > > > > > > > > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > > For additional commands, e-mail: dev-h...@tomcat.apache.org > > > > > > > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release JDBC Pool module v1.0.5
sebb wrote: On 26/06/2009, Filip Hanik - Dev Lists wrote: sebb wrote: On 24/06/2009, Filip Hanik - Dev Lists wrote: Cleaned up and fixed. The release is located here: http://people.apache.org/~fhanik/jdbc-pool/v1.0.5/ Exactly the same path names were used previously; I assume you are referring to the following versions of the files: apache-tomcat-jdbc-1.0.5-bin.tar.gz.md5:808cf400c4f7f4de7294b844c68108fa apache-tomcat-jdbc-1.0.5-bin.zip.md5:3f20849d6b0dbe29bb9707cd519c456c apache-tomcat-jdbc-1.0.5-src.tar.gz.md5:6a63d1e77c47c5d6385cf680dac4514c apache-tomcat-jdbc-1.0.5-src.zip.md5:7b4870d50e498a18014031589b8a88eb rather than the older ones: apache-tomcat-jdbc-1.0.5-bin.tar.gz.md5:b6081e6d34a8e9ecd70b505c90e73485 apache-tomcat-jdbc-1.0.5-bin.zip.md5:76cb2efd7ce7093d71e4a989e71d2874 apache-tomcat-jdbc-1.0.5-src.tar.gz.md5:d8d08870f3479080582d3261a4d1afe5 apache-tomcat-jdbc-1.0.5-src.zip.md5:cc6992ff33524f15052f9b72588b628f == The source and test source archives contain META-INF/MANIFEST.MF files which don't belong in a source archive. these are fine. The binary archives contain MD5 hashes of all but one of the jars; again, these don't belong in the archives. The jars should contain NOTICE and LICENSE files. no they should not. I think I've told you before, that NOTICE and LICENSE files are for a release, not for individual files within a release. There's no easily accessible documentation on how to build and test the code. If someone is familiar with Ant, they can work out what the targets do, but the user should not have to do this. The ant script automatically downloads jars, some of which don't have Apache Licenses. In particular, the MySQL licence appears to be GPL, which is not compatible with the AL. yes, I will remove this. AFAICT, this is specifically forbidden: http://www.apache.org/legal/3party.html#options-build-may2 The "ant test" target generates a few warnings, e.g. WARNING: Database connection pool evicter thread interval is set to lower than 1 second. Several of the tests fail. I will remove all tests. It was a bad idea to include to begin with, since they are not part of the release either. There's no documentation on what database needs to be set up in order to run the database tests so I don't know if these are due to failure to set up the database correctly or whether the test failures were nothing to do with the database. that will be solved when the tests go away In which case, how can reviewers test the code? you misunderstand "test the code". When you test a car, do you run unit test on the car components? No you drive the car on the road. Same thing goes on here. That is not the solution either. It should be fairly easy to remove the dependency on MySQL and c3p0 - if not, then IMO the tests are too specific, as Tomcat DBCP should work with any JDBC provider. Actually, I can let the build script download MySQL, or change it to Derby. Its not forbidden to download something, as long as the user has to turn on a flag to do so. As an experiment, I tried using Derby instead of MySQL, and most of the tests worked. [I'm not yet sure why some tests failed. Unfortunately the output gives no clue to me.] I think its better to use Derby. yes. I suggest changing the Ant test classpath to include whatever jars it finds in the include directory, and change the test code to pick up the database settings from build.properties Then all a tester has to do is put their JDBC jar in the directory and set up the database as required. Ideally, the user should be given the option of running the JDBC tests against whatever database they prefer. If the tests require tables etc to be set up, these should either be done as part of the test setup, or there should be clear documentation on what data needs to be set up. [ ] STABLE - I couldn't find any bugs [ ] BETA - I found some bugs but not critical [ ] BROKEN - I found some show stoppers Any comments ? Thanks, Filip - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For addit
Re: [VOTE] Release JDBC Pool module v1.0.5
On 26/06/2009, Filip Hanik - Dev Lists wrote: > sebb wrote: > > > On 26/06/2009, Filip Hanik - Dev Lists wrote: > > > > > > > sebb wrote: > > > > > > > > > > > > > On 24/06/2009, Filip Hanik - Dev Lists wrote: > > > > > > > > > > > > > > > > > > > > > Cleaned up and fixed. > > > > > > > > > > The release is located here: > > > > > http://people.apache.org/~fhanik/jdbc-pool/v1.0.5/ > > > > > > > > > > > > > > > > > > > > > > > > Exactly the same path names were used previously; I assume you are > > > > referring to the following versions of the files: > > > > > > > > > > > > > > > > > > > > apache-tomcat-jdbc-1.0.5-bin.tar.gz.md5:808cf400c4f7f4de7294b844c68108fa > > > > apache-tomcat-jdbc-1.0.5-bin.zip.md5:3f20849d6b0dbe29bb9707cd519c456c > > > > apache-tomcat-jdbc-1.0.5-src.tar.gz.md5:6a63d1e77c47c5d6385cf680dac4514c > > > > apache-tomcat-jdbc-1.0.5-src.zip.md5:7b4870d50e498a18014031589b8a88eb > > > > > > > > > > rather than the older ones: > > > > > > > > > > > > > > > > > > > > apache-tomcat-jdbc-1.0.5-bin.tar.gz.md5:b6081e6d34a8e9ecd70b505c90e73485 > > > > apache-tomcat-jdbc-1.0.5-bin.zip.md5:76cb2efd7ce7093d71e4a989e71d2874 > > > > apache-tomcat-jdbc-1.0.5-src.tar.gz.md5:d8d08870f3479080582d3261a4d1afe5 > > > > apache-tomcat-jdbc-1.0.5-src.zip.md5:cc6992ff33524f15052f9b72588b628f > > > > > > > > > > == > > > > > > > > The source and test source archives contain META-INF/MANIFEST.MF files > > > > which don't belong in a source archive. > > > > > > > > > > > > > > > > > > > these are fine. > > > > > > > > > > > > > The binary archives contain MD5 hashes of all but one of the jars; > > > > again, these don't belong in the archives. > > > > > > > > The jars should contain NOTICE and LICENSE files. > > > > > > > > > > > > > > > > > > > no they should not. I think I've told you before, that NOTICE and > LICENSE > > > files are for a release, not for individual files within a release. > > > > > > > > > > > > > There's no easily accessible documentation on how to build and test > the > > > > > > > > > > > code. > > > > > > > > > > If someone is familiar with Ant, they can work out what the targets > > > > do, but the user should not have to do this. > > > > > > > > The ant script automatically downloads jars, some of which don't have > > > > Apache Licenses. In particular, the MySQL licence appears to be GPL, > > > > which is not compatible with the AL. > > > > > > > > > > > > > > > > > > > yes, I will remove this. > > > > > > > > > > > > > AFAICT, this is specifically forbidden: > > > > > > > > > > > > > > > > > > > > http://www.apache.org/legal/3party.html#options-build-may2 > > > > > > > > > > The "ant test" target generates a few warnings, e.g. > > > > > > > > WARNING: Database connection pool evicter thread interval is set to > > > > lower than 1 second. > > > > > > > > Several of the tests fail. > > > > > > > > > > > > > > > > > > > I will remove all tests. It was a bad idea to include to begin with, > since > > > they are not part of the release either. > > > > > > > > > > > > > There's no documentation on what database needs to be set up in order > > > > to run the database tests so I don't know if these are due to failure > > > > to set up the database correctly or whether the test failures were > > > > nothing to do with the database. > > > > > > > > > > > > > > > > > > > that will be solved when the tests go away > > > > > > > > > > In which case, how can reviewers test the code? > > > > > you misunderstand "test the code". When you test a car, do you run unit > test on the car components? No you drive the car on the road. > Same thing goes on here. They are both ways of testing the code. If the unit tests work for you, but don't work for other reviewers, then the problem needs to be investigated and fixed. If a user test finds a problem in the code, then normally the first thing that needs to be done is to write a unit test case to demonstrate the error; the error is fixed, and then the users can demonstrate that the problem has been fixed by running the test code on as many platforms as possible. It is unfair to ask every reviewer to generate their own test code if they don't want to. One should at least give them the opportunity of testing the code using the unit tests; if they want to run further tests, so much the better. > > That is not the solution either. > > > > It should be fairly easy to remove the dependency on MySQL and c3p0 - > > if not, then IMO the tests are too specific, as Tomcat DBCP should > > work with any JDBC provider. > > > > > Actually, I can let the build script download MySQL, or change it to Derby. > Its not forbidden to download something, as long as the user has to turn on > a flag to do so. Yes, the user has to give consent. > > > As an experiment, I tried using Derby instead of MySQL, and most of > > the tests worked. [I'm not yet sure why some tests failed. > > Unfortunately the output gives no clue to me.] I have found out why the Ant output is n
Re: svn commit: r788214 - /tomcat/current/tc5.5.x/STATUS.txt
2009/6/25 : > Author: markt > Date: Wed Jun 24 23:53:11 2009 > New Revision: 788214 > > URL: http://svn.apache.org/viewvc?rev=788214&view=rev > Log: > Add thread safety patch. I haven't voted for it as I need to review it > thoroughly first and it is getting late here. I'll review and vote tomorrow. > > Modified: > tomcat/current/tc5.5.x/STATUS.txt > > + > +* Make access log valves thread safe > + http://people.apache.org/~markt/patches/2009-06-25-AccessLogValve-tc5.patch > + +1: > + -1: The following my comments are regarding AccessLogValve class only: 1. There is a bug, that sneaked in rev.781753 http://svn.apache.org/viewvc?rev=781753&view=rev That is: the timeZoneNoDST field is never assigned and remains null It was ok in 5.5.27. 2. struct.currentDateString is calculated in two different places I propose to encapsulate that code into AccessDateStruct 3. Invocation of getDate() in invoke() (the only place where getDate() is called): I think that getDate() also can be incapsulated into AccessDateStruct. Actually, I think of the following: 1) In invoke() there is already a variable that stores current time millis: "t2" I propose to replace that getDate() with AccessDateStruct.setDate(t2) that will perform the same job. 2) Change the signature of replace(..., Date, ..) method, and pass a reference to the AccessDateStruct instead of a Date. In the future the replace(..) methods of this class can be changed to accept a StringBuffer, instead of returning a String, but that can be another story. If AccessDateStruct is passed into the replace() method, timeTakenFormatter can be added to it as well. Maybe. 4. The log() method still creates a new Date() once in a second. The Date instance can be stored in some member variable and reused. It is in a synchronized block, so it will be safe. I do not like, that it is the same once-in-a-second synchronized block, that we already avoided once by using those ThreadLocals. Can be addressed separately, though. +1 to the patch regarding AccessLogValve. I'll write about two other classes later, if I find anything. (By the first glance, I have not noticed any problems there). Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release JDBC Pool module v1.0.5
When testing with Derby on Java 1.6.0 I get the following error: [junit] Running org.apache.tomcat.jdbc.test.StarvationTest [junit] Testsuite: org.apache.tomcat.jdbc.test.StarvationTest [junit] AbandonedObjectPool is used (org.apache.tomcat.dbcp.dbcp.abandonedobjectp...@1d6096) [junit]LogAbandoned: true [junit]RemoveAbandoned: true [junit]RemoveAbandonedTimeout: 5 [junit] 26-Jun-2009 18:33:20 org.apache.tomcat.jdbc.pool.ConnectionPool$PoolCleaner [junit] WARNING: Database connection pool evicter thread interval is set to lower than 1 second. [junit] 26-Jun-2009 18:33:20 org.apache.tomcat.jdbc.pool.ConnectionPool init [junit] WARNING: minIdle is larger than maxActive, setting minIdle to: 1 [junit] 26-Jun-2009 18:33:26 org.apache.tomcat.jdbc.pool.ConnectionPool abandon [junit] WARNING: Connection has been abandoned pooledconnection[org.apache.derby.client.net.netconnectio...@7bd9f2]:java.lang.Exception [junit] at org.apache.tomcat.jdbc.pool.ConnectionPool.getThreadDump(ConnectionPool.java:781) [junit] at org.apache.tomcat.jdbc.pool.ConnectionPool.borrowConnection(ConnectionPool.java:566) [junit] at org.apache.tomcat.jdbc.pool.ConnectionPool.borrowConnection(ConnectionPool.java:459) [junit] at org.apache.tomcat.jdbc.pool.ConnectionPool.getConnection(ConnectionPool.java:138) [junit] at org.apache.tomcat.jdbc.pool.DataSourceProxy.getConnection(DataSourceProxy.java:96) [junit] at org.apache.tomcat.jdbc.test.StarvationTest.testConnectionStarvation(StarvationTest.java:77) [junit] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [junit] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) [junit] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) [junit] at java.lang.reflect.Method.invoke(Method.java:597) [junit] at junit.framework.TestCase.runTest(TestCase.java:164) [junit] at junit.framework.TestCase.runBare(TestCase.java:130) [junit] at junit.framework.TestResult$1.protect(TestResult.java:106) [junit] at junit.framework.TestResult.runProtected(TestResult.java:124) [junit] at junit.framework.TestResult.run(TestResult.java:109) [junit] at junit.framework.TestCase.run(TestCase.java:120) [junit] at junit.framework.TestSuite.runTest(TestSuite.java:230) [junit] at junit.framework.TestSuite.run(TestSuite.java:225) [junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:420) [junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(JUnitTestRunner.java:911) [junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:768) [junit] [junit] 26-Jun-2009 18:33:27 org.apache.tomcat.jdbc.pool.ConnectionPool$PoolCleaner [junit] WARNING: Database connection pool evicter thread interval is set to lower than 1 second. [junit] 26-Jun-2009 18:33:27 org.apache.tomcat.jdbc.pool.ConnectionPool init [junit] WARNING: minIdle is larger than maxActive, setting minIdle to: 1 [junit] 26-Jun-2009 18:33:32 org.apache.tomcat.jdbc.pool.ConnectionPool abandon [junit] WARNING: Connection has been abandoned pooledconnection[org.apache.derby.client.net.netconnectio...@50d89c]:java.lang.Exception [junit] at org.apache.tomcat.jdbc.pool.ConnectionPool.getThreadDump(ConnectionPool.java:781) [junit] at org.apache.tomcat.jdbc.pool.ConnectionPool.borrowConnection(ConnectionPool.java:566) [junit] at org.apache.tomcat.jdbc.pool.ConnectionPool.borrowConnection(ConnectionPool.java:459) [junit] at org.apache.tomcat.jdbc.pool.ConnectionPool.getConnection(ConnectionPool.java:138) [junit] at org.apache.tomcat.jdbc.pool.DataSourceProxy.getConnection(DataSourceProxy.java:96) [junit] at org.apache.tomcat.jdbc.test.StarvationTest.testFairConnectionStarvation(StarvationTest.java:98) [junit] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [junit] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) [junit] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) [junit] at java.lang.reflect.Method.invoke(Method.java:597) [junit] at junit.framework.TestCase.runTest(TestCase.java:164) [junit] at junit.framework.TestCase.runBare(TestCase.java:130) [junit] at junit.framework.TestResult$1.protect(TestResult.java:106) [junit] at junit.framework.TestResult.runProtected(TestResult.java:124) [junit] at junit.framework.TestResult.run(TestResult.java:109) [junit] at junit.framework.TestCase.run(TestCase.java:120) [junit] at junit.framework.TestSuite.runTest(TestSuite.java:230) [junit] at junit.framework.TestSuite.run(TestSuite.java:225)
Re: svn commit: r788214 - /tomcat/current/tc5.5.x/STATUS.txt
Konstantin Kolinko wrote: > 1. There is a bug, that sneaked in rev.781753 > http://svn.apache.org/viewvc?rev=781753&view=rev > That is: > the timeZoneNoDST field is never assigned and remains null > It was ok in 5.5.27. That is an error in my backport. That line should never have been deleted. I'll fix that now. > 2. struct.currentDateString is calculated in two different places > I propose to encapsulate that code into AccessDateStruct > > 3. Invocation of getDate() in invoke() (the only place where getDate() > is called): > I think that getDate() also can be incapsulated into AccessDateStruct. > Actually, I think of the following: > 1) In invoke() there is already a variable that stores current time > millis: "t2" > I propose to replace that getDate() with > AccessDateStruct.setDate(t2) that will perform the same job. > 2) Change the signature of replace(..., Date, ..) method, and pass a > reference to the AccessDateStruct instead of a Date. > In the future the replace(..) methods of this class can be changed to > accept a StringBuffer, instead of returning a String, but that can be > another story. > > If AccessDateStruct is passed into the replace() method, > timeTakenFormatter can be added to it as well. Maybe. > > 4. The log() method still creates a new Date() once in a second. > The Date instance can be stored in some member variable and reused. It > is in a synchronized block, so it will be safe. > I do not like, that it is the same once-in-a-second synchronized > block, that we already avoided once by using those ThreadLocals. > Can be addressed separately, though. Thanks for this. I'll see about updating the patch. > +1 to the patch regarding AccessLogValve. I'll write about two other > classes later, if I find anything. (By the first glance, I have not > noticed any problems there). > > Best regards, > Konstantin Kolinko > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r788821 - /tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/valves/AccessLogValve.java
Author: markt Date: Fri Jun 26 19:18:34 2009 New Revision: 788821 URL: http://svn.apache.org/viewvc?rev=788821&view=rev Log: Fix error in r781753. A line was deleted in the backport for bug 46982 that should not have been. Modified: tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/valves/AccessLogValve.java Modified: tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/valves/AccessLogValve.java URL: http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/valves/AccessLogValve.java?rev=788821&r1=788820&r2=788821&view=diff == --- tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/valves/AccessLogValve.java (original) +++ tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/valves/AccessLogValve.java Fri Jun 26 19:18:34 2009 @@ -1104,6 +1104,7 @@ // Initialize the timeZone, Date formatters, and currentDate timezone = TimeZone.getDefault(); +timeZoneNoDST = calculateTimeZoneOffset(timezone.getRawOffset()); int offset = timezone.getDSTSavings(); timeZoneDST = calculateTimeZoneOffset(timezone.getRawOffset()+offset); - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r788855 - /tomcat/current/tc5.5.x/STATUS.txt
Author: markt Date: Fri Jun 26 20:16:34 2009 New Revision: 788855 URL: http://svn.apache.org/viewvc?rev=788855&view=rev Log: vote Modified: tomcat/current/tc5.5.x/STATUS.txt Modified: tomcat/current/tc5.5.x/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=788855&r1=788854&r2=788855&view=diff == --- tomcat/current/tc5.5.x/STATUS.txt (original) +++ tomcat/current/tc5.5.x/STATUS.txt Fri Jun 26 20:16:34 2009 @@ -151,5 +151,5 @@ * Make access log valves thread safe http://people.apache.org/~markt/patches/2009-06-25-AccessLogValve-tc5.patch - +1: + +1: markt -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
