svn commit: r767934 - in /tomcat/trunk/modules/jdbc-pool: doc/ java/org/apache/tomcat/jdbc/pool/ java/org/apache/tomcat/jdbc/pool/interceptor/ java/org/apache/tomcat/jdbc/pool/jmx/
Author: fhanik
Date: Thu Apr 23 14:40:16 2009
New Revision: 767934
URL: http://svn.apache.org/viewvc?rev=767934&view=rev
Log:
Configure fair queue by default, its faster.
Implement logic around when/how connections are treated as abandoned.
First one is by pool utilization, abandonWhenPercentageFull, the second one is
to add a ResetAbandonTimer interceptor, so when successful invokations take
place on the connection, it resets the time
Added:
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/interceptor/ResetAbandonedTimer.java
(with props)
Modified:
tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/DataSource.java
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/DataSourceFactory.java
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/PoolProperties.java
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/interceptor/AbstractQueryReport.java
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/jmx/ConnectionPool.java
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/jmx/ConnectionPoolMBean.java
Modified: tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml?rev=767934&r1=767933&r2=767934&view=diff
==
--- tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml (original)
+++ tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml Thu Apr 23 14:40:16 2009
@@ -329,6 +329,15 @@
This flag is required when you want to use asynchronous connection
retrieval.
+
+
+ (int) Connections that have been abandoned (timed out) wont get
closed and reported up unless
+ the number of connections in use are above the percentage defined by
abandonWhenPercentageFull.
+ The value should be between 0-100.
+ The default value is 0, which implies that connections
are eligible for closure as soon
+ as removeAbandonedTimeout has been reached.
+
+
(boolean) Set to true if you wish the ProxyConnection
class to use String.equals instead of
== when comparing method names. This property does not
apply to added interceptors as those are configured individually.
@@ -419,6 +428,18 @@
+
+
+The abandoned timer starts when a connection is checked out from the
pool.
+This means if you have a 30second timeout and run 10x10second queries
using the connection
+it will be marked abandoned and potentially reclaimed depending on the
abandonWhenPercentageFull
+attribute.
+Using this interceptor it will reset the checkout timer every time you
perform an operation on the connection or execute a
+query successfully.
+
+
+
+
Modified:
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java?rev=767934&r1=767933&r2=767934&view=diff
==
---
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
(original)
+++
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
Thu Apr 23 14:40:16 2009
@@ -654,9 +654,19 @@
} //end if
} //checkIn
+public boolean shouldAbandon() {
+if (poolProperties.getAbandonWhenPercentageFull()==0) return true;
+float used = (float)busy.size();
+float max = (float)poolProperties.getMaxActive();
+float perc = (float)poolProperties.getAbandonWhenPercentageFull();
+System.out.println("Abandon rate:"+(used/max*100f));
+return (used/max*100f)>=perc;
+}
+
public void checkAbandoned() {
try {
if (busy.size()==0) return;
+if (!shouldAbandon()) return;
Iterator locked = busy.iterator();
while (locked.hasNext()) {
PooledConnection con = locked.next();
Modified:
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/DataSource.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/DataSource.java?rev=767934&r1=767933&r2=767934&view=diff
==
---
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/DataSource.java
(original)
+++
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/DataSource.java
Thu Apr 23 14:40:16 2009
@@ -374,6 +374,14 @@
}
}
+public int getAbandonWhenPercentageFull() {
+try {
+return
createPo
svn commit: r767949 - in /tomcat/trunk/modules/jdbc-pool: .classpath test/org/apache/tomcat/jdbc/test/CheckOutThreadTest.java test/org/apache/tomcat/jdbc/test/DefaultTestCase.java test/org/apache/tomc
Author: fhanik
Date: Thu Apr 23 16:02:32 2009
New Revision: 767949
URL: http://svn.apache.org/viewvc?rev=767949&view=rev
Log:
Added in c3p0 to the performance tests, it doesn't even perform as well as
DBCP, which is contradictory to what the internet is claiming
Modified:
tomcat/trunk/modules/jdbc-pool/.classpath
tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/CheckOutThreadTest.java
tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/DefaultTestCase.java
tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/TwoDataSources.java
Modified: tomcat/trunk/modules/jdbc-pool/.classpath
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/.classpath?rev=767949&r1=767948&r2=767949&view=diff
==
--- tomcat/trunk/modules/jdbc-pool/.classpath (original)
+++ tomcat/trunk/modules/jdbc-pool/.classpath Thu Apr 23 16:02:32 2009
@@ -7,5 +7,6 @@
+
Modified:
tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/CheckOutThreadTest.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/CheckOutThreadTest.java?rev=767949&r1=767948&r2=767949&view=diff
==
---
tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/CheckOutThreadTest.java
(original)
+++
tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/CheckOutThreadTest.java
Thu Apr 23 16:02:32 2009
@@ -23,7 +23,6 @@
import javax.sql.DataSource;
-import org.apache.tomcat.jdbc.pool.DataSourceFactory;
/**
* @author Filip Hanik
@@ -67,7 +66,7 @@
for (int i=0; ihttp://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/DefaultTestCase.java?rev=767949&r1=767948&r2=767949&view=diff
==
---
tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/DefaultTestCase.java
(original)
+++
tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/DefaultTestCase.java
Thu Apr 23 16:02:32 2009
@@ -19,6 +19,8 @@
import java.lang.reflect.Method;
import java.util.Properties;
+import javax.sql.DataSource;
+
import org.apache.tomcat.dbcp.dbcp.BasicDataSource;
import org.apache.tomcat.dbcp.dbcp.BasicDataSourceFactory;
@@ -26,21 +28,24 @@
import org.apache.tomcat.jdbc.pool.PoolProperties;
import org.apache.tomcat.jdbc.pool.DataSourceProxy;
+import com.mchange.v2.c3p0.ComboPooledDataSource;
+
/**
* @author Filip Hanik
* @version 1.0
*/
public class DefaultTestCase extends TestCase {
-protected DataSourceProxy datasource;
+protected org.apache.tomcat.jdbc.pool.DataSource datasource;
protected BasicDataSource tDatasource;
+protected DataSource c3p0Datasource;
protected int threadcount = 10;
protected int iterations = 10;
public DefaultTestCase(String name) {
super(name);
}
-public DataSourceProxy createDefaultDataSource() {
-DataSourceProxy datasource = null;
+public org.apache.tomcat.jdbc.pool.DataSource createDefaultDataSource() {
+org.apache.tomcat.jdbc.pool.DataSource datasource = null;
PoolProperties p = new DefaultProperties();
p.setJmxEnabled(false);
p.setTestWhileIdle(false);
@@ -95,6 +100,68 @@
x.printStackTrace();
}
}
+
+protected void transferPropertiesToC3P0() throws Exception {
+
System.setProperty("com.mchange.v2.log.FallbackMLog.DEFAULT_CUTOFF_LEVEL",
"WARNING");
+//http://www.mchange.com/projects/c3p0/index.html#automaticTestTable
+ComboPooledDataSource c3p0 = new ComboPooledDataSource();
+c3p0.setAcquireIncrement(1);
+c3p0.setAcquireRetryAttempts(2);
+c3p0.setAcquireRetryDelay(datasource.getPoolProperties().getMaxWait());
+c3p0.setCheckoutTimeout(datasource.getPoolProperties().getMaxWait());
+
c3p0.setDebugUnreturnedConnectionStackTraces(datasource.getPoolProperties().isLogAbandoned());
+
c3p0.setIdleConnectionTestPeriod(datasource.getPoolProperties().getTimeBetweenEvictionRunsMillis()/1000);
+
c3p0.setInitialPoolSize(datasource.getPoolProperties().getInitialSize());
+
c3p0.setMaxIdleTime(datasource.getPoolProperties().getMinEvictableIdleTimeMillis()/1000);
+
c3p0.setMaxIdleTimeExcessConnections(datasource.getPoolProperties().getMaxIdle());
+c3p0.setMaxPoolSize(datasource.getPoolProperties().getMaxActive());
+c3p0.setMinPoolSize(datasource.getPoolProperties().getMinIdle());
+c3p0.setPassword(datasource.getPoolProperties().getPassword());
+
c3p0.setPreferredTestQuery(datasource.getPoolProperties().getValidationQuery());
+
c3p0.setTestConnectionOnCheckin(datasource.getPoolProperties().isTestOnReturn());
+
svn commit: r767956 [2/2] - in /tomcat/trunk/java: javax/servlet/ javax/servlet/annotation/ javax/servlet/http/ org/apache/catalina/connector/ org/apache/catalina/core/ org/apache/catalina/valves/ org
Modified: tomcat/trunk/java/org/apache/catalina/core/DummyResponse.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/DummyResponse.java?rev=767956&r1=767955&r2=767956&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/DummyResponse.java (original)
+++ tomcat/trunk/java/org/apache/catalina/core/DummyResponse.java Thu Apr 23
16:14:59 2009
@@ -100,10 +100,8 @@
public void setLocale(Locale locale) {}
public Cookie[] getCookies() { return null; }
-public String getHeader(@SuppressWarnings("unused") String name) {
-return null;
-}
-public String[] getHeaderNames() { return null; }
+public String getHeader(String name) { return null; }
+public Iterable getHeaderNames() { return null; }
public String[] getHeaderValues(@SuppressWarnings("unused") String name) {
return null;
}
@@ -132,6 +130,5 @@
public void setStatus(int status) {}
/** @deprecated */
public void setStatus(int status, String message) {}
-
-
+public Iterable getHeaders(String name) { return null; }
}
Modified: tomcat/trunk/java/org/apache/catalina/core/LocalStrings.properties
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/LocalStrings.properties?rev=767956&r1=767955&r2=767956&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/LocalStrings.properties
(original)
+++ tomcat/trunk/java/org/apache/catalina/core/LocalStrings.properties Thu Apr
23 16:14:59 2009
@@ -13,15 +13,8 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-applicationContext.addFilter.iae=The filter name {0} already exists in context
{1}
applicationContext.addFilter.ise=Filters can not be added to context {0} as
the context has been initialised
-applicationContext.addFilterMapping.iae.servlet=The list of servletNames
provided was null or empty
-applicationContext.addFilterMapping.iae.url=The list of urlPatterns provided
was null or empty
-applicationContext.addFilterMapping.ise=Filter mappings can not be added to
context {0} as the context has been initialised
-applicationContext.addServlet.iae=The servlet name {0} already exists in
context {1}
applicationContext.addServlet.ise=Servlets can not be added to context {0} as
the context has been initialised
-applicationContext.addServletMapping.iae=The list of urlPatterns provided was
null or empty
-applicationContext.addServletMapping.ise=Servlet mappings can not be added to
context {0} as the context has been initialised
applicationContext.attributeEvent=Exception thrown by attributes event listener
applicationContext.mapping.error=Error during mapping
applicationContext.requestDispatcher.iae=Path {0} does not start with a "/"
character
Modified: tomcat/trunk/java/org/apache/catalina/valves/AccessLogValve.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/AccessLogValve.java?rev=767956&r1=767955&r2=767956&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/valves/AccessLogValve.java (original)
+++ tomcat/trunk/java/org/apache/catalina/valves/AccessLogValve.java Thu Apr 23
16:14:59 2009
@@ -28,6 +28,7 @@
import java.text.SimpleDateFormat;
import java.util.ArrayList;
import java.util.Date;
+import java.util.Iterator;
import java.util.List;
import java.util.TimeZone;
@@ -1284,16 +1285,15 @@
public void addElement(StringBuffer buf, Date date, Request request,
Response response, long time) {
if (null != response) {
-String[] values = response.getHeaderValues(header);
-if(values.length > 0) {
-for (int i = 0; i < values.length; i++) {
-String string = values[i];
-buf.append(string) ;
-if(i+1 iter = response.getHeaders(header).iterator();
+boolean first = true;
+while (iter.hasNext()) {
+if (!first) {
+buf.append(",");
}
-return ;
+buf.append(iter.next());
}
+return ;
}
buf.append("-");
}
Modified:
tomcat/trunk/java/org/apache/catalina/valves/ExtendedAccessLogValve.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/ExtendedAccessLogValve.java?rev=767956&r1=767955&r2=767956&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/valves/ExtendedAccessLogValve.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/valves/ExtendedAccessLogValve.java
Thu Apr 23 16:14:59 20
svn commit: r767965 - /tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/FairBlockingQueue.java
Author: fhanik
Date: Thu Apr 23 16:33:16 2009
New Revision: 767965
URL: http://svn.apache.org/viewvc?rev=767965&view=rev
Log:
Dequeu is a Java 6 API
Modified:
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/FairBlockingQueue.java
Modified:
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/FairBlockingQueue.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/FairBlockingQueue.java?rev=767965&r1=767964&r2=767965&view=diff
==
---
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/FairBlockingQueue.java
(original)
+++
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/FairBlockingQueue.java
Thu Apr 23 16:33:16 2009
@@ -17,7 +17,6 @@
package org.apache.tomcat.jdbc.pool;
import java.util.Collection;
-import java.util.Deque;
import java.util.Iterator;
import java.util.LinkedList;
import java.util.NoSuchElementException;
@@ -40,7 +39,7 @@
public class FairBlockingQueue implements BlockingQueue {
ReentrantLock lock = new ReentrantLock(false);
-Deque items = null;
+LinkedList items = null;
LinkedList> waiters = null;
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r767969 - in /tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test: CheckOutThreadTest.java FairnessTest.java
Author: fhanik
Date: Thu Apr 23 16:40:28 2009
New Revision: 767969
URL: http://svn.apache.org/viewvc?rev=767969&view=rev
Log:
Add c3p0 as a comparison in the fairness test
Modified:
tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/CheckOutThreadTest.java
tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/FairnessTest.java
Modified:
tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/CheckOutThreadTest.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/CheckOutThreadTest.java?rev=767969&r1=767968&r2=767969&view=diff
==
---
tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/CheckOutThreadTest.java
(original)
+++
tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/CheckOutThreadTest.java
Thu Apr 23 16:40:28 2009
@@ -118,6 +118,7 @@
public void testPoolThreads20Connections10() throws Exception {
init();
this.datasource.getPoolProperties().setMaxActive(10);
+this.datasource.getPoolProperties().setFairQueue(false);
this.threadcount = 20;
this.transferProperties();
this.datasource.getConnection().close();
Modified:
tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/FairnessTest.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/FairnessTest.java?rev=767969&r1=767968&r2=767969&view=diff
==
---
tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/FairnessTest.java
(original)
+++
tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/FairnessTest.java
Thu Apr 23 16:40:28 2009
@@ -25,7 +25,6 @@
import javax.sql.DataSource;
-import org.apache.tomcat.jdbc.pool.DataSourceFactory;
import org.apache.tomcat.jdbc.pool.DataSourceProxy;
/**
@@ -106,7 +105,7 @@
for (int i=0; i
svn commit: r767976 - in /tomcat/trunk/java/org/apache/catalina/connector: Connector.java Request.java
Author: markt
Date: Thu Apr 23 16:59:25 2009
New Revision: 767976
URL: http://svn.apache.org/viewvc?rev=767976&view=rev
Log:
Remove unused / deprecated code
Modified:
tomcat/trunk/java/org/apache/catalina/connector/Connector.java
tomcat/trunk/java/org/apache/catalina/connector/Request.java
Modified: tomcat/trunk/java/org/apache/catalina/connector/Connector.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/Connector.java?rev=767976&r1=767975&r2=767976&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/connector/Connector.java (original)
+++ tomcat/trunk/java/org/apache/catalina/connector/Connector.java Thu Apr 23
16:59:25 2009
@@ -403,25 +403,6 @@
/**
- * Return the input buffer size for this Connector.
- *
- * @deprecated
- */
-public int getBufferSize() {
-return 2048;
-}
-
-/**
- * Set the input buffer size for this Connector.
- *
- * @param bufferSize The new input buffer size.
- * @deprecated
- */
-public void setBufferSize(int bufferSize) {
-}
-
-
-/**
* Return the Container used for processing requests received by this
* Connector.
*/
Modified: tomcat/trunk/java/org/apache/catalina/connector/Request.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/Request.java?rev=767976&r1=767975&r2=767976&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/connector/Request.java (original)
+++ tomcat/trunk/java/org/apache/catalina/connector/Request.java Thu Apr 23
16:59:25 2009
@@ -658,16 +658,6 @@
}
/**
- * Set the input stream associated with this Request.
- *
- * @param stream The new input stream
- */
-public void setStream(InputStream stream) {
-// Ignore
-}
-
-
-/**
* URI byte to char converter (not recycled).
*/
protected B2CConverter URIConverter = null;
@@ -786,70 +776,6 @@
/**
- * Set the content length associated with this Request.
- *
- * @param length The new content length
- */
-public void setContentLength(int length) {
-// Not used
-}
-
-
-/**
- * Set the content type (and optionally the character encoding)
- * associated with this Request. For example,
- * text/html; charset=ISO-8859-4.
- *
- * @param type The new content type
- */
-public void setContentType(String type) {
-// Not used
-}
-
-
-/**
- * Set the protocol name and version associated with this Request.
- *
- * @param protocol Protocol name and version
- */
-public void setProtocol(String protocol) {
-// Not used
-}
-
-
-/**
- * Set the IP address of the remote client associated with this Request.
- *
- * @param remoteAddr The remote IP address
- */
-public void setRemoteAddr(String remoteAddr) {
-// Not used
-}
-
-
-/**
- * Set the fully qualified name of the remote client associated with this
- * Request.
- *
- * @param remoteHost The remote host name
- */
-public void setRemoteHost(String remoteHost) {
-// Not used
-}
-
-
-/**
- * Set the name of the scheme associated with this request. Typical values
- * are http, https, and ftp.
- *
- * @param scheme The scheme
- */
-public void setScheme(String scheme) {
-// Not used
-}
-
-
-/**
* Set the value to be returned by isSecure()
* for this Request.
*
@@ -1587,17 +1513,6 @@
/**
- * Add a Header to the set of Headers associated with this Request.
- *
- * @param name The new header name
- * @param value The new header value
- */
-public void addHeader(String name, String value) {
-// Not used
-}
-
-
-/**
* Add a Locale to the set of preferred Locales for this Request. The
* first added Locale will be the first one returned by getLocales().
*
@@ -1685,27 +1600,6 @@
/**
- * Set the HTTP request method used for this Request.
- *
- * @param method The request method
- */
-public void setMethod(String method) {
-// Not used
-}
-
-
-/**
- * Set the query string for this Request. This will normally be called
- * by the HTTP Connector, when it parses the request headers.
- *
- * @param query The query string
- */
-public void setQueryString(String query) {
-// Not used
-}
-
-
-/**
* Set the path information for this Request. This will normally be called
* when the associated Context is mapping the Request to a particular
* Wrapper.
@@ -1773,27 +1667,6 @@
/**
- * Set the unparsed request URI for this Request. This will normally be
- * called by the HTTP
svn commit: r767978 - /tomcat/trunk/java/org/apache/catalina/connector/Response.java
Author: markt
Date: Thu Apr 23 17:02:02 2009
New Revision: 767978
URL: http://svn.apache.org/viewvc?rev=767978&view=rev
Log:
Another unused method
Modified:
tomcat/trunk/java/org/apache/catalina/connector/Response.java
Modified: tomcat/trunk/java/org/apache/catalina/connector/Response.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/Response.java?rev=767978&r1=767977&r2=767978&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/connector/Response.java (original)
+++ tomcat/trunk/java/org/apache/catalina/connector/Response.java Thu Apr 23
17:02:02 2009
@@ -415,16 +415,6 @@
/**
- * Set the output stream associated with this Response.
- *
- * @param stream The new output stream
- */
-public void setStream(OutputStream stream) {
-// This method is evil
-}
-
-
-/**
* Set the suspended flag.
*
* @param suspended The new suspended flag value
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
participate in tomcat 7
Hello all, my proposal about improve jmx for tomcat was rejected. but i'm desiring to participate in tomcat development. i want to ask if it possible to do the project without GSOC ? is the dev list can provide mentor to do this project in the summer? Anas _ Rediscover Hotmail®: Get e-mail storage that grows with you. http://windowslive.com/RediscoverHotmail?ocid=TXT_TAGLM_WL_HM_Rediscover_Storage2_042009
Re: participate in tomcat 7
Anas Ahmed wrote: > Hello all, > my proposal about improve jmx for tomcat was rejected. > but i'm desiring to participate in tomcat development. > i want to ask if it possible to do the project without GSOC ? > is the dev list can provide mentor to do this project in the summer? Absolutely. I think Peter expressed an interest in mentoring this project. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 47086] New: Tomcat6 64-bit service wrapper should be included in a Tomcat distribution
https://issues.apache.org/bugzilla/show_bug.cgi?id=47086 Summary: Tomcat6 64-bit service wrapper should be included in a Tomcat distribution Product: Tomcat 6 Version: 6.0.18 Platform: PC OS/Version: Windows Vista Status: NEW Severity: normal Priority: P2 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: phil.pick...@springsource.com Given the increasing popularity of the 64-bit windows platform, it would be nice if the 64-bit service wrappers (found at https://svn.apache.org/repos/asf/tomcat/tc6.0.x/trunk/res/procrun/amd64/) could be included in an "official" Windows Service Wrapper type Tomcat distribution. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 47088] New: Default conf/server.xml needs addition to fix constant cpu usage with isapi_redirect.dll
https://issues.apache.org/bugzilla/show_bug.cgi?id=47088 Summary: Default conf/server.xml needs addition to fix constant cpu usage with isapi_redirect.dll Product: Tomcat 5 Version: 5.0.23 Platform: PC URL: http://www.coderanch.com/t/86515/Tomcat/Tomcat-Connect or-high-cpu-usage OS/Version: Windows Server 2003 Status: NEW Severity: blocker Priority: P2 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: jwex...@mail.usa.com CC: jwex...@mail.usa.com See the following bbs page posted by Martin Thorpe: http://www.coderanch.com/t/86515/Tomcat/Tomcat-Connector-high-cpu-usage Tomcat results in massive unrelease cpu usage (100% on my machine and 25% on Martin's machine). This happens with the latest isapi_redirect-1.2.28.dll as well as older ones. The following should be changed in the server.xml file that ships with Tomcat (I would guess that this applies to Tomcat 6.x as well). [Martin] changed this line, which was the default Tomcat shipped with: To be this: -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 47091] New: jsp problem
https://issues.apache.org/bugzilla/show_bug.cgi?id=47091 Summary: jsp problem Product: Tomcat 6 Version: 6.0.18 Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Priority: P2 Component: Jasper AssignedTo: dev@tomcat.apache.org ReportedBy: huangf...@tongtech.com <%@ page language="java" import="java.util.*" pageEncoding="GB18030"%> test page <% String str = "AAA"; String str1 = "Z"; pa = new com.tongtech.Test01(); pa.setName(str1); %> <% out.println(pa.getName()); %> access this jsp page,the response returned by tomcat is: AAA ZZZ but the response returned by weblogic application server is: AAA AAA why? which one is right? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
