DO NOT REPLY [Bug 46915] Unable to get ResourceBundle keys in Tomcat 6
https://issues.apache.org/bugzilla/show_bug.cgi?id=46915 Kapil changed: What|Removed |Added CC||kapilgupt...@gmail.com -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46915] New: Unable to get ResourceBundle keys in Tomcat 6
https://issues.apache.org/bugzilla/show_bug.cgi?id=46915
Summary: Unable to get ResourceBundle keys in Tomcat 6
Product: Tomcat 6
Version: 6.0.18
Platform: PC
OS/Version: Windows XP
Status: NEW
Severity: normal
Priority: P2
Component: Servlet & JSP API
AssignedTo: dev@tomcat.apache.org
ReportedBy: kapilgupt...@gmail.com
Created an attachment (id=23417)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=23417)
modified foreach.jsp file that reads properties file
There is issue with ResourceBundle using JSTL in tomcat 6. The problem is in
using the following code
${messageString.resourceBundle.keys}
The above code is not able to resolve the keys and result in printing of
???keys???
Here messageString is a variable set using below code
I have tested it with example jsp provided in the tomcat's example webapp.
The issue is reproducible with both JSTL1.1 and JSTL 1.2 and JDK 1.5 and 1.6
However it is working fine in Tomcat 5.5
Attached is the sample foreach.jsp with modified code to read a property file
available in \webapps\examples\WEB-INF\classes folder under tomcat installation
directory.
Just place this file in examples webapp and view source
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r758596 - in /tomcat/trunk: java/org/apache/catalina/core/ java/org/apache/catalina/tribes/util/ test/org/apache/catalina/tribes/demos/ test/org/apache/catalina/tribes/test/channel/ test/o
Author: markt
Date: Thu Mar 26 11:06:06 2009
New Revision: 758596
URL: http://svn.apache.org/viewvc?rev=758596&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46866
Better init of Random
Modified:
tomcat/trunk/java/org/apache/catalina/core/StandardServer.java
tomcat/trunk/java/org/apache/catalina/tribes/util/UUIDGenerator.java
tomcat/trunk/test/org/apache/catalina/tribes/demos/LoadTest.java
tomcat/trunk/test/org/apache/catalina/tribes/demos/MapDemo.java
tomcat/trunk/test/org/apache/catalina/tribes/test/channel/TestDataIntegrity.java
tomcat/trunk/test/org/apache/catalina/tribes/test/channel/TestMulticastPackages.java
tomcat/trunk/test/org/apache/catalina/tribes/test/channel/TestRemoteProcessException.java
tomcat/trunk/test/org/apache/catalina/tribes/test/channel/TestUdpPackages.java
tomcat/trunk/test/org/apache/catalina/tribes/test/io/TestSenderConnections.java
Modified: tomcat/trunk/java/org/apache/catalina/core/StandardServer.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/StandardServer.java?rev=758596&r1=758595&r2=758596&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/StandardServer.java (original)
+++ tomcat/trunk/java/org/apache/catalina/core/StandardServer.java Thu Mar 26
11:06:06 2009
@@ -420,7 +420,7 @@
int expected = 1024; // Cut off to avoid DoS attack
while (expected < shutdown.length()) {
if (random == null)
-random = new Random(System.currentTimeMillis());
+random = new Random();
expected += (random.nextInt() % 1024);
}
while (expected > 0) {
Modified: tomcat/trunk/java/org/apache/catalina/tribes/util/UUIDGenerator.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/util/UUIDGenerator.java?rev=758596&r1=758595&r2=758596&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/tribes/util/UUIDGenerator.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/tribes/util/UUIDGenerator.java Thu
Mar 26 11:06:06 2009
@@ -31,7 +31,7 @@
public static final int BITS_PER_BYTE = 8;
protected static SecureRandom secrand = null;
-protected static Random rand = new Random(System.currentTimeMillis());
+protected static Random rand = new Random();
static {
secrand = new SecureRandom();
secrand.setSeed(rand.nextLong());
Modified: tomcat/trunk/test/org/apache/catalina/tribes/demos/LoadTest.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/tribes/demos/LoadTest.java?rev=758596&r1=758595&r2=758596&view=diff
==
--- tomcat/trunk/test/org/apache/catalina/tribes/demos/LoadTest.java (original)
+++ tomcat/trunk/test/org/apache/catalina/tribes/demos/LoadTest.java Thu Mar 26
11:06:06 2009
@@ -251,7 +251,7 @@
public static class LoadMessage extends ByteMessage {
public static byte[] outdata = new byte[size];
-public static Random r = new Random(System.currentTimeMillis());
+public static Random r = new Random();
public static int getMessageSize (LoadMessage msg) {
return msg.getMessage().length;
}
Modified: tomcat/trunk/test/org/apache/catalina/tribes/demos/MapDemo.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/tribes/demos/MapDemo.java?rev=758596&r1=758595&r2=758596&view=diff
==
--- tomcat/trunk/test/org/apache/catalina/tribes/demos/MapDemo.java (original)
+++ tomcat/trunk/test/org/apache/catalina/tribes/demos/MapDemo.java Thu Mar 26
11:06:06 2009
@@ -399,7 +399,7 @@
dataModel.getValueAt(-1,-1);
}
-public static Random random = new Random(System.currentTimeMillis());
+public static Random random = new Random();
public static String random(int count, int start, int end, boolean
letters, boolean numbers,
char[] chars ) {
if (count == 0) {
Modified:
tomcat/trunk/test/org/apache/catalina/tribes/test/channel/TestDataIntegrity.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/tribes/test/channel/TestDataIntegrity.java?rev=758596&r1=758595&r2=758596&view=diff
==
---
tomcat/trunk/test/org/apache/catalina/tribes/test/channel/TestDataIntegrity.java
(original)
+++
tomcat/trunk/test/org/apache/catalina/tribes/test/channel/TestDataIntegrity.java
Thu Mar 26 11:06:06 2009
@@ -166,7 +166,7 @@
public int length;
public byte[] data;
public byte key;
-pu
svn commit: r758598 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Thu Mar 26 11:10:50 2009 New Revision: 758598 URL: http://svn.apache.org/viewvc?rev=758598&view=rev Log: Propose fix for 46866 Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=758598&r1=758597&r2=758598&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Mar 26 11:10:50 2009 @@ -171,3 +171,9 @@ Catch possible ISE as a result of session expiration in comet valve +1: markt -1: + +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46866 + http://svn.apache.org/viewvc?rev=758596&view=rev + Better init of Random objects + +1: markt + -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46866] Seed from current time is useless
https://issues.apache.org/bugzilla/show_bug.cgi?id=46866 --- Comment #1 from Mark Thomas 2009-03-26 04:16:43 PST --- Thanks for the report. This has been fixed in trunk and have been proposed for 6.0.x -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r758616 - /tomcat/trunk/java/org/apache/catalina/core/StandardContext.java
Author: markt
Date: Thu Mar 26 12:58:40 2009
New Revision: 758616
URL: http://svn.apache.org/viewvc?rev=758616&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46822
Avoid redundant object creation
Patch provided by Anthony Whitford
Modified:
tomcat/trunk/java/org/apache/catalina/core/StandardContext.java
Modified: tomcat/trunk/java/org/apache/catalina/core/StandardContext.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/StandardContext.java?rev=758616&r1=758615&r2=758616&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/StandardContext.java (original)
+++ tomcat/trunk/java/org/apache/catalina/core/StandardContext.java Thu Mar 26
12:58:40 2009
@@ -849,8 +849,8 @@
boolean oldDelegate = this.delegate;
this.delegate = delegate;
-support.firePropertyChange("delegate", new Boolean(oldDelegate),
- new Boolean(this.delegate));
+support.firePropertyChange("delegate", oldDelegate,
+ this.delegate);
}
@@ -964,8 +964,8 @@
boolean oldAntiJARLocking = this.antiJARLocking;
this.antiJARLocking = antiJARLocking;
support.firePropertyChange("antiJARLocking",
- new Boolean(oldAntiJARLocking),
- new Boolean(this.antiJARLocking));
+ oldAntiJARLocking,
+ this.antiJARLocking);
}
@@ -980,8 +980,8 @@
boolean oldAntiResourceLocking = this.antiResourceLocking;
this.antiResourceLocking = antiResourceLocking;
support.firePropertyChange("antiResourceLocking",
- new Boolean(oldAntiResourceLocking),
- new Boolean(this.antiResourceLocking));
+ oldAntiResourceLocking,
+ this.antiResourceLocking);
}
@@ -1006,8 +1006,8 @@
boolean oldAvailable = this.available;
this.available = available;
support.firePropertyChange("available",
- new Boolean(oldAvailable),
- new Boolean(this.available));
+ oldAvailable,
+ this.available);
}
@@ -1091,8 +1091,8 @@
boolean oldConfigured = this.configured;
this.configured = configured;
support.firePropertyChange("configured",
- new Boolean(oldConfigured),
- new Boolean(this.configured));
+ oldConfigured,
+ this.configured);
}
@@ -1117,8 +1117,8 @@
boolean oldCookies = this.cookies;
this.cookies = cookies;
support.firePropertyChange("cookies",
- new Boolean(oldCookies),
- new Boolean(this.cookies));
+ oldCookies,
+ this.cookies);
}
@@ -1143,8 +1143,8 @@
boolean oldUseHttpOnly = this.useHttpOnly;
this.useHttpOnly = useHttpOnly;
support.firePropertyChange("useHttpOnly",
-new Boolean(oldUseHttpOnly),
-new Boolean(this.useHttpOnly));
+oldUseHttpOnly,
+this.useHttpOnly);
}
@@ -1170,8 +1170,8 @@
boolean oldCrossContext = this.crossContext;
this.crossContext = crossContext;
support.firePropertyChange("crossContext",
- new Boolean(oldCrossContext),
- new Boolean(this.crossContext));
+ oldCrossContext,
+ this.crossContext);
}
@@ -1303,8 +1303,8 @@
boolean oldDistributable = this.distributable;
this.distributable = distributable;
support.firePropertyChange("distributable",
- new Boolean(oldDistributable),
- new Boolean(this.distributable));
+ oldDistributable,
+ this.distributable);
// Bugzilla 32866
if(getManager() != null) {
@@ -1416,8 +1416,8 @@
public void setIgnoreAnnotations(boolean ignoreAnnotations) {
boolean oldIgnoreAnnotations = this.ignoreAnnotations;
this.ignoreAnnotations = ignoreAnnotations;
-support.firePropertyChange("ignoreAnnotations",
Boolean.valueOf(oldIgnoreAnnotations),
-Boolean.valueOf(this.ignoreAnnotations));
+support.firePropertyChange("ignoreAnnotations", oldIgnoreAnnotations,
+
svn commit: r758618 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Thu Mar 26 13:01:30 2009 New Revision: 758618 URL: http://svn.apache.org/viewvc?rev=758618&view=rev Log: Propose fix for 46822 Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=758618&r1=758617&r2=758618&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Mar 26 13:01:30 2009 @@ -177,3 +177,7 @@ Better init of Random objects +1: markt -1: + +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46822 + http://svn.apache.org/viewvc?rev=758616&view=rev + Remove unnecessary object creation in StandardContext - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46822] Avoid redundant instantiations in StandardContext
https://issues.apache.org/bugzilla/show_bug.cgi?id=46822 --- Comment #1 from Mark Thomas 2009-03-26 06:01:49 PST --- Thanks for the patch. This has been applied to trunk and proposed for 6.0.x. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r758620 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Thu Mar 26 13:08:32 2009 New Revision: 758620 URL: http://svn.apache.org/viewvc?rev=758620&view=rev Log: Propose 46822 Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=758620&r1=758619&r2=758620&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Mar 26 13:08:32 2009 @@ -181,3 +181,5 @@ * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46822 http://svn.apache.org/viewvc?rev=758616&view=rev Remove unnecessary object creation in StandardContext + +1: markt + -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46920] New: EL resolver does not call (overridden) Enum.toString() method
https://issues.apache.org/bugzilla/show_bug.cgi?id=46920
Summary: EL resolver does not call (overridden) Enum.toString()
method
Product: Tomcat 6
Version: 6.0.18
Platform: PC
OS/Version: Windows XP
Status: NEW
Severity: normal
Priority: P2
Component: Jasper
AssignedTo: dev@tomcat.apache.org
ReportedBy: d...@elegiac.net
I have created my own enum MyEnum which override the toString() method.
If I set an attribute of type MyEnum with name "foo" in the page context, and
use the EL ${foo} in a JSP page, Enum.name() is used instead of Enum.toString()
to render the enum instance, thus displaying the enum constant name instead of
the enhanced description String returned by MyEnum.toString().
It seems the expectedType argument is String instead of Enum in the
org.apache.jasper.runtime.PageContextImpl.proprietaryEvaluate() method.
A possible workaround is to create the following method in the enum:
public final String getToString() {
return toString();
}
and use ${myEnum.toString} in JSP pages, which is undesirable.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r758664 - /tomcat/trunk/java/javax/el/ResourceBundleELResolver.java
Author: markt
Date: Thu Mar 26 14:28:11 2009
New Revision: 758664
URL: http://svn.apache.org/viewvc?rev=758664&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46915
When resolving ResourceBundle properties, don't claim to have resolved the
property unless we really have resolved it.
Modified:
tomcat/trunk/java/javax/el/ResourceBundleELResolver.java
Modified: tomcat/trunk/java/javax/el/ResourceBundleELResolver.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/javax/el/ResourceBundleELResolver.java?rev=758664&r1=758663&r2=758664&view=diff
==
--- tomcat/trunk/java/javax/el/ResourceBundleELResolver.java (original)
+++ tomcat/trunk/java/javax/el/ResourceBundleELResolver.java Thu Mar 26
14:28:11 2009
@@ -38,12 +38,12 @@
}
if (base instanceof ResourceBundle) {
- context.setPropertyResolved(true);
-
if (property != null) {
try {
- return ((ResourceBundle)
base).getObject(property
+ Object result = ((ResourceBundle)
base).getObject(property
.toString());
+ context.setPropertyResolved(true);
+ return result;
} catch (MissingResourceException mre) {
return "???" + property.toString() +
"???";
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r758722 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Thu Mar 26 16:27:40 2009 New Revision: 758722 URL: http://svn.apache.org/viewvc?rev=758722&view=rev Log: Propose fix for 46915 Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=758722&r1=758721&r2=758722&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Mar 26 16:27:40 2009 @@ -183,3 +183,10 @@ Remove unnecessary object creation in StandardContext +1: markt -1: + +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46915 + When resolving ResourceBundle properties, don't claim to have resolved the + property unless we really have resolved it. + http://svn.apache.org/viewvc?rev=758664&view=rev + +1: markt + -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r758728 - /tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/DataSourceFactory.java
Author: fhanik
Date: Thu Mar 26 16:38:05 2009
New Revision: 758728
URL: http://svn.apache.org/viewvc?rev=758728&view=rev
Log:
Allow a user to configure a pool name through config
Modified:
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/DataSourceFactory.java
Modified:
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/DataSourceFactory.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/DataSourceFactory.java?rev=758728&r1=758727&r2=758728&view=diff
==
---
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/DataSourceFactory.java
(original)
+++
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/DataSourceFactory.java
Thu Mar 26 16:38:05 2009
@@ -107,6 +107,8 @@
protected static final String PROP_USE_EQUALS = "useEquals";
public static final int UNKNOWN_TRANSACTIONISOLATION = -1;
+
+public static final String OBJECT_NAME = "object_name";
protected final static String[] ALL_PROPERTIES = {
@@ -143,7 +145,8 @@
PROP_INTERCEPTORS,
PROP_JMX_ENABLED,
PROP_FAIR_QUEUE,
-PROP_USE_EQUALS
+PROP_USE_EQUALS,
+OBJECT_NAME
};
// -- ObjectFactory Methods
@@ -400,6 +403,12 @@
if (value != null) {
poolProperties.setUseEquals(Boolean.parseBoolean(value));
}
+
+value = properties.getProperty(OBJECT_NAME);
+if (value != null) {
+poolProperties.setName(value);
+}
+
return poolProperties;
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: 6.0.19 RC
Remy Maucherat wrote: > On Wed, 2009-03-25 at 17:22 +0100, Remy Maucherat wrote: >> On Wed, 2009-03-25 at 17:17 +0100, Mark Thomas wrote: >>> What platform are you running on these days? >> Linux. But OTOH, the filtering is 100% useless (except for >> ServerInfo.properties). > > Ok, it seems I need to use the encoding="ISO-8859-1" attribute on the > copy task to fix this (thanks JF), otherwise the VM's default encoding > (UTF-8 for my VM) is used. But it could break other stuff. I assume this will mean a 6.0.20. Any idea on when? Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: 6.0.19 RC
On Thu, 2009-03-26 at 17:48 +0100, Mark Thomas wrote: > Remy Maucherat wrote: > > On Wed, 2009-03-25 at 17:22 +0100, Remy Maucherat wrote: > >> On Wed, 2009-03-25 at 17:17 +0100, Mark Thomas wrote: > >>> What platform are you running on these days? > >> Linux. But OTOH, the filtering is 100% useless (except for > >> ServerInfo.properties). > > > > Ok, it seems I need to use the encoding="ISO-8859-1" attribute on the > > copy task to fix this (thanks JF), otherwise the VM's default encoding > > (UTF-8 for my VM) is used. But it could break other stuff. > > I assume this will mean a 6.0.20. Any idea on when? The issue is cosmetic, so I don't consider it important. Rémy - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46915] Unable to get ResourceBundle keys in Tomcat 6
https://issues.apache.org/bugzilla/show_bug.cgi?id=46915 --- Comment #1 from Mark Thomas 2009-03-26 10:02:29 PST --- This has been fixed in trunk and proposed for 6.0.x -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r758751 - /tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/jmx/ConnectionPool.java
Author: fhanik
Date: Thu Mar 26 17:17:22 2009
New Revision: 758751
URL: http://svn.apache.org/viewvc?rev=758751&view=rev
Log:
Some things you don't want to expose
Modified:
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/jmx/ConnectionPool.java
Modified:
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/jmx/ConnectionPool.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/jmx/ConnectionPool.java?rev=758751&r1=758750&r2=758751&view=diff
==
---
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/jmx/ConnectionPool.java
(original)
+++
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/jmx/ConnectionPool.java
Thu Mar 26 17:17:22 2009
@@ -146,7 +146,7 @@
// POOL PROPERTIES
//=
public Properties getDbProperties() {
-return pool.getPoolProperties().getDbProperties();
+return null; //pool.getPoolProperties().getDbProperties();
}
public String getUrl() {
return pool.getPoolProperties().getUrl();
@@ -224,7 +224,7 @@
return pool.getPoolProperties().getName();
}
public String getPassword() {
-return pool.getPoolProperties().getPassword();
+return "";
}
public String getUsername() {
return pool.getPoolProperties().getUsername();
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46923] New: AJP/1.3 Connector code/documentation mismatch
https://issues.apache.org/bugzilla/show_bug.cgi?id=46923 Summary: AJP/1.3 Connector code/documentation mismatch Product: Tomcat 6 Version: 6.0.18 Platform: PC OS/Version: Linux Status: NEW Severity: normal Priority: P2 Component: Connectors AssignedTo: dev@tomcat.apache.org ReportedBy: j...@ucar.edu The docs for the ajp/1.3 connector: http://tomcat.apache.org/tomcat-6.0-doc/config/ajp.html make it seem like there is only 1 implementation for the protocol class but there are really 3. The docs describe the properties for the APR-enabled class org.apache.coyote.ajp.AjpAprProtocol. They don't mention that if APR is not initialized, the class used for protocol="AJP/1.3" is actually org.apache.jk.server.JkCoyoteHandler which does not have the same interface/properties as the docs describe. In particular, I cannot use the executor, getting exceptions like: [DATE] org.apache.catalina.startup.ConnectorCreateRule _setExecutor WARNING: Connector [org.apache.catalina.connector.connec...@11e1e67] does not support external executors. Method setExecutor(java.util.concurrent.Executor) which is confusing because the docs make it sound like it works. The one message I found on tomcat-users seemed to be confused with another issue and ignored. There is however the class org.apache.coyote.ajp.AjpProtocol which matches the AjpAprProtocol interface and seems to work fine. I suggest at least making the config/ajp.html page clear and including JkCoyoteHandler documenation, or changing org.apache.catalina.connector.Connector to use AjpProtocol. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r758814 - in /tomcat/site/trunk: docs/svn.html xdocs/svn.xml
Author: idarwin Date: Thu Mar 26 19:39:03 2009 New Revision: 758814 URL: http://svn.apache.org/viewvc?rev=758814&view=rev Log: Repair simple typo. Modified: tomcat/site/trunk/docs/svn.html tomcat/site/trunk/xdocs/svn.xml Modified: tomcat/site/trunk/docs/svn.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/svn.html?rev=758814&r1=758813&r2=758814&view=diff == --- tomcat/site/trunk/docs/svn.html (original) +++ tomcat/site/trunk/docs/svn.html Thu Mar 26 19:39:03 2009 @@ -540,7 +540,7 @@ The Subversion repository has been structured using the following principles: - New major versions (after Tomcat 5.x) should use a single integraeted + New major versions (after Tomcat 5.x) should use a single integrated source repository. Each current module should appear directly under the tomcat directory. Modified: tomcat/site/trunk/xdocs/svn.xml URL: http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/svn.xml?rev=758814&r1=758813&r2=758814&view=diff == --- tomcat/site/trunk/xdocs/svn.xml (original) +++ tomcat/site/trunk/xdocs/svn.xml Thu Mar 26 19:39:03 2009 @@ -204,7 +204,7 @@ The Subversion repository has been structured using the following principles: - New major versions (after Tomcat 5.x) should use a single integraeted + New major versions (after Tomcat 5.x) should use a single integrated source repository. Each current module should appear directly under the tomcat directory. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46924] New: Session is lost when application is reloaded through touching the war file
https://issues.apache.org/bugzilla/show_bug.cgi?id=46924
Summary: Session is lost when application is reloaded through
touching the war file
Product: Tomcat 6
Version: 6.0.18
Platform: PC
OS/Version: Windows XP
Status: NEW
Severity: normal
Priority: P2
Component: Catalina
AssignedTo: dev@tomcat.apache.org
ReportedBy: adrian...@gmail.com
Created an attachment (id=23419)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=23419)
Example project
I tried a very basic example, based on Maven quickstart. web.xml is almost
empty, and a jsp page:
=
<%
String x = (String) request.getSession(true).getAttribute("x");
if (x == null)
x = "0";
int y = Integer.valueOf(x) + 1;
request.getSession(true).setAttribute("x", String.valueOf(y));
%>
<%= y %>
=
So I start reloading the page. The number increments. I can stop/start or
reload the app. The number continue incrementing.
Then I touch (with gnuwin32 touch utility) the war file. The Tomcat console
displays:
=
26/03/2009 11:11:28 org.apache.catalina.core.StandardContext reload
INFO: Reloading this Context has started
26/03/2009 11:12:02 org.apache.catalina.startup.HostConfig checkResources
INFO: Undeploying context [/example]
26/03/2009 11:12:02 org.apache.catalina.startup.HostConfig deployWAR
INFO: Deploying web application archive example.war
=
You see, it undeployed, and the counter has reseted.
Now, I tried delete webapps/example. After some seconds, the war is exploded
and same thing as above happens.
Then I tried to delete webapps/example/*, leaving the directory empty. This
way, I can manually extract the war there, and session is preserved.
Charles (Chuck) Caldarale, said this is an inconsistency worth registering.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Obtaining a Unique Connection ID?
On Mon, Mar 23, 2009 at 10:38 AM, Michael B Allen wrote:
> On Mon, Mar 23, 2009 at 3:41 AM, Rainer Jung wrote:
>> Others might have better ideas, but as mentioned in the previous thread, you
>> can forward the remote port with
>>
>> JkEnvVar REMOTE_PORT
>>
>> and retrieve it in Tomcat with
>>
>> request.getAttribute("REMOTE_PORT")
>>
>> Doesn't that work?
>
> Yes, it sounds like precisely what I'm looking for. I just didn't
> understand the significance of your previous message. I never used
> mod_jk before so I'll have to look into this JkEnvVar thing.
Now I have someone using the ISAPI filter in IIS with Tomcat who is
also seeing getRemotePort return -1.
Is there a work-around for IIS?
I've modified our code to look for the REMOTE_PORT attribute. Is there
a way to export the REMOTE_PORT attribute with the ISAPI filter?
Mike
--
Michael B Allen
Java Active Directory Integration
http://www.ioplex.com/
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Tomcat Wiki] Update of "Tomcat/UTF-8" by yyamano
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The following page has been changed by yyamano: http://wiki.apache.org/tomcat/Tomcat/UTF-8 -- (from the tomcat-user mailing list) - '''Note''' This method doesn't work with non-ASCII character. "stringBytesISO" is an ISO-8859-1 byte stream. We can't use it as an UTF-8 byte stream if it contains non-ASCII character. + '''Note''' This method is not useful because it doesn't work with non-ASCII character. "stringBytesISO" is an ISO-8859-1 byte stream. We can't use it as an UTF-8 byte stream if it contains non-ASCII character. '''Alternative solution''' - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
