DO NOT REPLY [Bug 46770] Headers are send duplicate
https://issues.apache.org/bugzilla/show_bug.cgi?id=46770 --- Comment #10 from Rainer Jung 2009-02-26 02:59:14 PST --- (In reply to comment #9) > The original problem was that when client-flush was implemented in mod_jk, the > default connector didn't look to see that the headers were sent as well. Now > the headers are sent, but the CoyoteRequest isn't marked as committed. I see, good to know. > The simplest fix is to change R580815to do res.sendHeaders(...) instead of > calling the ActionHook. But I'm not certain that it's the best fix, since I > haven't looked at it very long. I'd +1 this change if you need it in a hurry, > since I'm a bit short on spare cycles at the moment. > > Of course the other place to change this is to call res.setCommitted(true) > from > JkInputStream.appendHead(...). As I said, haven't looked at it long enough to > know which is better. I'll try a couple of options. > One thing that worries me is that you don't see it in 6.0, since I can't find > the difference in the o.a.jk Connectors. Yes, I retested with 6.0.18, 6.0 HEAD and trunk. None of them shows the problem. So I'll also investigate code differences. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46770] Headers are send duplicate
https://issues.apache.org/bugzilla/show_bug.cgi?id=46770 Rainer Jung changed: What|Removed |Added Keywords||PatchAvailable --- Comment #11 from Rainer Jung 2009-02-26 05:02:48 PST --- I found the reason, why 6.0 and trunk behave better. It's a side effect of r411577 ( https://svn.apache.org/viewcvs.cgi?view=rev&rev=411577 ) It replaces INITIAL_STATE with an variable initial. When FLUSH sends out the headers, initial is used as a guard against duplicate sending of the headers. I will attach a patch which is a direct port of this side effect to TC 5.5. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46770] Headers are send duplicate
https://issues.apache.org/bugzilla/show_bug.cgi?id=46770 --- Comment #12 from Rainer Jung 2009-02-26 05:04:00 PST --- Created an attachment (id=23314) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=23314) Patch using a guard to prevent duplicate headers flushing in OutputBuffer -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r748129 - /tomcat/current/tc5.5.x/STATUS.txt
Author: rjung Date: Thu Feb 26 13:08:08 2009 New Revision: 748129 URL: http://svn.apache.org/viewvc?rev=748129&view=rev Log: Add proposed patch for BZ46770. Modified: tomcat/current/tc5.5.x/STATUS.txt Modified: tomcat/current/tc5.5.x/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=748129&r1=748128&r2=748129&view=diff == --- tomcat/current/tc5.5.x/STATUS.txt (original) +++ tomcat/current/tc5.5.x/STATUS.txt Thu Feb 26 13:08:08 2009 @@ -229,3 +229,12 @@ http://svn.apache.org/viewvc?rev=708273&view=rev +1: markt -1: + +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46770 + Headers send duplicate when using AJP and flush. + mod_jk doesn't accept such a response (starting with version 1.2.27). + Only a problem before 6.0. + Patch backported from http://svn.eu.apache.org/viewvc?view=rev&revision=411577 + Patch available at https://issues.apache.org/bugzilla/attachment.cgi?id=23314 + +1: rjung + -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r748152 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: mturk Date: Thu Feb 26 13:50:59 2009 New Revision: 748152 URL: http://svn.apache.org/viewvc?rev=748152&view=rev Log: Cast some votes, and one -0 :) Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=748152&r1=748151&r2=748152&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Feb 26 13:50:59 2009 @@ -114,27 +114,30 @@ http://svn.apache.org/viewvc?view=rev&revision=719119 http://svn.apache.org/viewvc?view=rev&revision=719124 +1: markt, fhanik + -0: mturk: We cannot change API in the middle of the life cycle. I'm fine with + deprecating that in trunk, but IMO there is no reason to deprecate + something in maintenance branch. -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=38570 When checking docBase against appBase, make sure we check for an exact match against the appBase http://svn.apache.org/viewvc?rev=742677&view=rev - +1: markt, remm + +1: markt, remm, mturk -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=39013 When testing for invalid docBase, test for an exact match with the appBase dir http://svn.apache.org/viewvc?rev=742697&view=rev - +1: markt, remm + +1: markt, remm, mturk -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=39396 Don't include TRACEE in OPTIONS response unless we know it hasn't been disabled in the connector http://svn.apache.org/viewvc?rev=742714&view=rev - +1: markt + +1: markt, mturk -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=4 @@ -166,6 +169,6 @@ * Fix spelling errors reported on users and dev list http://svn.apache.org/viewvc?rev=746321&view=rev http://svn.apache.org/viewvc?rev=746384&view=rev - +1: markt + +1: markt, mturk -1: - \ No newline at end of file + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r748153 - /tomcat/current/tc5.5.x/STATUS.txt
Author: mturk Date: Thu Feb 26 13:52:03 2009 New Revision: 748153 URL: http://svn.apache.org/viewvc?rev=748153&view=rev Log: Cast few votes. Modified: tomcat/current/tc5.5.x/STATUS.txt Modified: tomcat/current/tc5.5.x/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=748153&r1=748152&r2=748153&view=diff == --- tomcat/current/tc5.5.x/STATUS.txt (original) +++ tomcat/current/tc5.5.x/STATUS.txt Thu Feb 26 13:52:03 2009 @@ -34,13 +34,13 @@ * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45576 Add support for DIGEST to the JAASRealm http://svn.apache.org/viewvc?rev=684234&view=rev - +1: markt, fhanik + +1: markt, fhanik, mturk -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=41407 Add support for CLIENT-CERT to the JASSRealm. Builds on DIGEST patch above. http://svn.apache.org/viewvc?rev=684270&view=rev - +1: markt, fhanik + +1: markt, fhanik, mturk -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45528 @@ -53,13 +53,13 @@ * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45666 Prevent infinite loop on include http://svn.apache.org/viewvc?rev=690781&view=rev - +1: markt, rjung + +1: markt, rjung, mturk -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45628 http://svn.apache.org/viewvc?rev=691282&view=rev JARs without deps should always be fulfilled - +1: markt, rjung + +1: markt, rjung, mturk -1: * Backport Logging of access control problems when setting up @@ -73,12 +73,12 @@ registered twice, so the messages are output twice. This does not happen for tc6.0.x and should be seen as a different issue. - +1: rjung, markt + +1: rjung, markt, mturk -1: * Backport: Handle session suffix rewrite at JvmRouteBinderValve with parallel requests from same client http://svn.apache.org/viewvc?rev=693378&view=rev - +1: pero, markt + +1: pero, markt, mturk -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=44382 @@ -93,7 +93,7 @@ * Correct wrong "No role found" debug message, logged in RealmBase even if a role was found. http://svn.apache.org/viewvc?rev=697158&view=rev - +1: rjung, markt + +1: rjung, markt, mturk -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45026 @@ -101,6 +101,7 @@ http://svn.apache.org/viewvc?rev=697183&view=rev +1: rjung +1: markt (also required for other AJP connectors) + +1: mturk -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45880 @@ -119,7 +120,7 @@ * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=42419 Support changing of JSESSIONID cookie name and jsessionid path parameter name http://svn.apache.org/viewvc?rev=702219&view=rev - +1: markt + +1: markt, mturk -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45996 @@ -214,14 +215,14 @@ When testing for invalid docBase, test for an exact match with the appBase dir http://svn.apache.org/viewvc?rev=742697&view=rev - +1: markt + +1: markt, mturk -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=39396 Don't include TRACE in OPTIONS response unless we know it hasn't been disabled in the connector http://svn.apache.org/viewvc?rev=742714&view=rev - +1: markt + +1: markt, mturk -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46717 @@ -236,5 +237,5 @@ Only a problem before 6.0. Patch backported from http://svn.eu.apache.org/viewvc?view=rev&revision=411577 Patch available at https://issues.apache.org/bugzilla/attachment.cgi?id=23314 - +1: rjung + +1: rjung, mturk -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46770] Headers are send duplicate
https://issues.apache.org/bugzilla/show_bug.cgi?id=46770 Rainer Jung changed: What|Removed |Added Attachment #23314|0 |1 is obsolete|| --- Comment #13 from Rainer Jung 2009-02-26 07:27:07 PST --- (From update of attachment 23314) This patch is wrong. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46770] Headers are send duplicate
https://issues.apache.org/bugzilla/show_bug.cgi?id=46770 --- Comment #14 from Rainer Jung 2009-02-26 07:56:51 PST --- My test for the proposed patch was wrong. The situation is (as always) more complicated: The flushing does not commit the response. Remember, that the servvlet does: response.setContentLength(0); response.getOutputStream().print(""); response.flushBuffer(); flushBuffer() triggers OutputBuffer.doFlush(). In there we already have state == CHAR_STATE. In this case we do not call coyoteResponse.sendHeaders() and thus the coyoteResponse doesn't get committed. Then we trigger ACTION_CLIENT_FLUSH. By revision r580815 ( https://svn.apache.org/viewcvs.cgi?view=rev&rev=580815 ) we immediately do ACTION_COMMIT inside ACTION_CLIENT_FLUSH. This in turn calls JkInputStream.appendHead(), which sends the headers without committing. Later from Response.finishResponse() we do ACTION_CLOSE, which in turn again does ACTION_COMMIT and we send out the headers a second time. I guess at least at the end of the first ACTION_COMMIT we should have called coyoteResponse.setCommitted(true). The question is: where exactly should we do that? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r748190 - /tomcat/current/tc5.5.x/STATUS.txt
Author: rjung Date: Thu Feb 26 15:59:09 2009 New Revision: 748190 URL: http://svn.apache.org/viewvc?rev=748190&view=rev Log: The patch for BZ 46770 is broken. Needs reworking. Modified: tomcat/current/tc5.5.x/STATUS.txt Modified: tomcat/current/tc5.5.x/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=748190&r1=748189&r2=748190&view=diff == --- tomcat/current/tc5.5.x/STATUS.txt (original) +++ tomcat/current/tc5.5.x/STATUS.txt Thu Feb 26 15:59:09 2009 @@ -230,12 +230,3 @@ http://svn.apache.org/viewvc?rev=708273&view=rev +1: markt -1: - -* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46770 - Headers send duplicate when using AJP and flush. - mod_jk doesn't accept such a response (starting with version 1.2.27). - Only a problem before 6.0. - Patch backported from http://svn.eu.apache.org/viewvc?view=rev&revision=411577 - Patch available at https://issues.apache.org/bugzilla/attachment.cgi?id=23314 - +1: rjung, mturk - -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46770] Headers are send duplicate
https://issues.apache.org/bugzilla/show_bug.cgi?id=46770 --- Comment #15 from Rainer Jung 2009-02-26 08:37:14 PST --- Created an attachment (id=23316) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=23316) Patch using a guard to prevent duplicate headers flushing in OutputBuffer This time the patch is a little more serious and unfortunately not so easy to review. It is still a partial backport from TC 6. I hope I did the tests correct now. Any comments welcome. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r748203 - /tomcat/current/tc5.5.x/STATUS.txt
Author: rjung Date: Thu Feb 26 16:39:21 2009 New Revision: 748203 URL: http://svn.apache.org/viewvc?rev=748203&view=rev Log: Next try proposing a fix for BZ 46770. Modified: tomcat/current/tc5.5.x/STATUS.txt Modified: tomcat/current/tc5.5.x/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=748203&r1=748202&r2=748203&view=diff == --- tomcat/current/tc5.5.x/STATUS.txt (original) +++ tomcat/current/tc5.5.x/STATUS.txt Thu Feb 26 16:39:21 2009 @@ -230,3 +230,12 @@ http://svn.apache.org/viewvc?rev=708273&view=rev +1: markt -1: + +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46770 + Headers send duplicate when using AJP and flush. + mod_jk doesn't accept such a response (starting with version 1.2.27). + Only a problem before 6.0. + Patch backported from http://svn.eu.apache.org/viewvc?view=rev&revision=411577 + Patch available at https://issues.apache.org/bugzilla/attachment.cgi?id=23316 + +1: rjung + -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r748282 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Thu Feb 26 19:44:58 2009 New Revision: 748282 URL: http://svn.apache.org/viewvc?rev=748282&view=rev Log: Propose XSD fix Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=748282&r1=748281&r2=748282&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Feb 26 19:44:58 2009 @@ -171,4 +171,8 @@ http://svn.apache.org/viewvc?rev=746384&view=rev +1: markt, mturk -1: - + +* Fix error in 2.5 web.xml XSD + http://svn.apache.org/viewvc?rev=747863&view=rev + +1: markt + -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r748344 - /tomcat/trunk/webapps/docs/config/valve.xml
Author: markt Date: Thu Feb 26 23:06:24 2009 New Revision: 748344 URL: http://svn.apache.org/viewvc?rev=748344&view=rev Log: Document undocumented valve Modified: tomcat/trunk/webapps/docs/config/valve.xml Modified: tomcat/trunk/webapps/docs/config/valve.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/valve.xml?rev=748344&r1=748343&r2=748344&view=diff == --- tomcat/trunk/webapps/docs/config/valve.xml (original) +++ tomcat/trunk/webapps/docs/config/valve.xml Thu Feb 26 23:06:24 2009 @@ -448,6 +448,42 @@ + + + + +Microsoft operating systems have two WebDAV clients. One is used with +port 80, the other is used for all other ports. The implementation used with +port 80 does not adhere to the WebDAV specification and fails when trying to +communicate with the Tomcat WebDAV Servlet. This valve provides a fix for +this by forcing the use of the WebDAV implementation that works, even when +connecting via port 80. + +This Valve may be used at the Engine, Host or +Context level as required. Normally, this Valve would be used +at the Context level. + + + + + +The WebDAV Fix Valve supports the following +configuration attributes: + + + + +Java class name of the implementation to use. This MUST be set to +org.apache.catalina.valves.WebdavFixValve. + + + + + + + + + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r748346 - in /tomcat/tc6.0.x/trunk: ./ webapps/docs/config/valve.xml
Author: markt Date: Thu Feb 26 23:09:03 2009 New Revision: 748346 URL: http://svn.apache.org/viewvc?rev=748346&view=rev Log: Document undocumented valve Modified: tomcat/tc6.0.x/trunk/ (props changed) tomcat/tc6.0.x/trunk/webapps/docs/config/valve.xml Propchange: tomcat/tc6.0.x/trunk/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Thu Feb 26 23:09:03 2009 @@ -1 +1 @@ -/tomcat/trunk:601180,606992,612607,630314,652744,653247,673796,673820,683982,684001,684081,684234,684269-684270,685177,687503,687645,689402,690781,691392,691805,692748,695053,695311,696780,696782,698012,698227,698236,698613,699427,699634,701355,709294,709811,709816,710063,710066,710125,710205,711126,711600,712461,712467,718360,719602,719626,719628,720046,720069,721040,723404,723738,726052,727303,728032,728768,728947,729057,729567,729569,729571,729809,729815,729934,730250,730590,731651,732859,732863,734734,740675,740684 +/tomcat/trunk:601180,606992,612607,630314,652744,653247,673796,673820,683982,684001,684081,684234,684269-684270,685177,687503,687645,689402,690781,691392,691805,692748,695053,695311,696780,696782,698012,698227,698236,698613,699427,699634,701355,709294,709811,709816,710063,710066,710125,710205,711126,711600,712461,712467,718360,719602,719626,719628,720046,720069,721040,723404,723738,726052,727303,728032,728768,728947,729057,729567,729569,729571,729809,729815,729934,730250,730590,731651,732859,732863,734734,740675,740684,747834,748344 Modified: tomcat/tc6.0.x/trunk/webapps/docs/config/valve.xml URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/config/valve.xml?rev=748346&r1=748345&r2=748346&view=diff == --- tomcat/tc6.0.x/trunk/webapps/docs/config/valve.xml (original) +++ tomcat/tc6.0.x/trunk/webapps/docs/config/valve.xml Thu Feb 26 23:09:03 2009 @@ -448,6 +448,42 @@ + + + + +Microsoft operating systems have two WebDAV clients. One is used with +port 80, the other is used for all other ports. The implementation used with +port 80 does not adhere to the WebDAV specification and fails when trying to +communicate with the Tomcat WebDAV Servlet. This valve provides a fix for +this by forcing the use of the WebDAV implementation that works, even when +connecting via port 80. + +This Valve may be used at the Engine, Host or +Context level as required. Normally, this Valve would be used +at the Context level. + + + + + +The WebDAV Fix Valve supports the following +configuration attributes: + + + + +Java class name of the implementation to use. This MUST be set to +org.apache.catalina.valves.WebdavFixValve. + + + + + + + + + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org