DO NOT REPLY [Bug 46571] read timeout while reading response
https://issues.apache.org/bugzilla/show_bug.cgi?id=46571 --- Comment #2 from krzysztof.madej...@agora.pl 2009-02-04 01:51:32 PST --- We are using gcc 3.4.6 on solaris 10 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46652] HttpServletRequest.getQueryString() always returns null
https://issues.apache.org/bugzilla/show_bug.cgi?id=46652 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Comment #1 from Mark Thomas 2009-02-04 03:05:38 PST --- Putting to one side that your test case contains a number of syntax errors that means it will never run, this works for me as expected once the errors have been fixed. I can't immediately see how you could have broken this in your configuration but the users list is the place to figure out what is wrong. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn propchange: r740638 - svn:log
Author: markt Revision: 740638 Modified property: svn:log Modified: svn:log at Wed Feb 4 11:42:08 2009 -- --- svn:log (original) +++ svn:log Wed Feb 4 11:42:08 2009 @@ -1 +1,2 @@ Propose 46606 +Withdraw serialization proposal - will shortly remove serailization in trunk instead - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r740701 - in /tomcat/trunk/java/org/apache/catalina/core: ContainerBase.java StandardContext.java
Author: markt
Date: Wed Feb 4 11:44:00 2009
New Revision: 740701
URL: http://svn.apache.org/viewvc?rev=740701&view=rev
Log:
Remove serialization from Container. Old experiment that didn't work.
Modified:
tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java
tomcat/trunk/java/org/apache/catalina/core/StandardContext.java
Modified: tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java?rev=740701&r1=740700&r2=740701&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java (original)
+++ tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java Wed Feb 4
11:44:00 2009
@@ -22,7 +22,6 @@
import java.beans.PropertyChangeListener;
import java.beans.PropertyChangeSupport;
import java.io.IOException;
-import java.io.Serializable;
import java.security.AccessController;
import java.security.PrivilegedAction;
import java.util.ArrayList;
@@ -121,7 +120,7 @@
*/
public abstract class ContainerBase
-implements Container, Lifecycle, Pipeline, MBeanRegistration, Serializable
{
+implements Container, Lifecycle, Pipeline, MBeanRegistration {
private static org.apache.juli.logging.Log log=
org.apache.juli.logging.LogFactory.getLog( ContainerBase.class );
@@ -1396,7 +1395,7 @@
protected String suffix;
protected ObjectName oname;
protected ObjectName controller;
-protected transient MBeanServer mserver;
+protected MBeanServer mserver;
public ObjectName getJmxName() {
return oname;
Modified: tomcat/trunk/java/org/apache/catalina/core/StandardContext.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/StandardContext.java?rev=740701&r1=740700&r2=740701&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/StandardContext.java (original)
+++ tomcat/trunk/java/org/apache/catalina/core/StandardContext.java Wed Feb 4
11:44:00 2009
@@ -23,7 +23,6 @@
import java.io.IOException;
import java.io.InputStream;
import java.io.InputStreamReader;
-import java.io.Serializable;
import java.util.ArrayList;
import java.util.HashMap;
import java.util.Hashtable;
@@ -114,9 +113,9 @@
public class StandardContext
extends ContainerBase
-implements Context, Serializable, NotificationEmitter
+implements Context, NotificationEmitter
{
-private static transient Log log =
LogFactory.getLog(StandardContext.class);
+private static Log log = LogFactory.getLog(StandardContext.class);
// --- Constructors
@@ -207,14 +206,14 @@
/**
* The set of instantiated application event listener objects.
*/
-private transient Object applicationEventListenersObjects[] =
+private Object applicationEventListenersObjects[] =
new Object[0];
/**
* The set of instantiated application lifecycle listener objects.
*/
-private transient Object applicationLifecycleListenersObjects[] =
+private Object applicationLifecycleListenersObjects[] =
new Object[0];
@@ -233,12 +232,12 @@
/**
* The broadcaster that sends j2ee notifications.
*/
-private transient NotificationBroadcasterSupport broadcaster = null;
+private NotificationBroadcasterSupport broadcaster = null;
/**
* The Locale to character set mapper for this application.
*/
-private transient CharsetMapper charsetMapper = null;
+private CharsetMapper charsetMapper = null;
/**
@@ -269,7 +268,7 @@
/**
* The ServletContext implementation associated with this Context.
*/
-protected transient ApplicationContext context = null;
+protected ApplicationContext context = null;
/**
@@ -399,14 +398,14 @@
/**
* The mapper associated with this context.
*/
-private transient org.apache.tomcat.util.http.mapper.Mapper mapper =
+private org.apache.tomcat.util.http.mapper.Mapper mapper =
new org.apache.tomcat.util.http.mapper.Mapper();
/**
* The naming context listener for this web application.
*/
-private transient NamingContextListener namingContextListener = null;
+private NamingContextListener namingContextListener = null;
/**
@@ -654,7 +653,7 @@
/**
* Non proxied resources.
*/
-private transient DirContext webappResources = null;
+private DirContext webappResources = null;
private long startupTime;
private long startTime;
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 38553] Wrong HTTP code for failed CLIENT-CERT authentication
https://issues.apache.org/bugzilla/show_bug.cgi?id=38553 Mark Thomas changed: What|Removed |Added Status|NEEDINFO|ASSIGNED --- Comment #3 from Mark Thomas 2009-02-04 02:46:39 PST --- Point taken. I have fixed this in trunk and proposed it for 6.0.x and 5.5.x -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r740684 - /tomcat/trunk/java/org/apache/catalina/authenticator/SSLAuthenticator.java
Author: markt
Date: Wed Feb 4 10:43:10 2009
New Revision: 740684
URL: http://svn.apache.org/viewvc?rev=740684&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=38553
A lack of certs is normal if the user doesn't have a trusted cert. Return 401,
not 400 in this case.
Modified:
tomcat/trunk/java/org/apache/catalina/authenticator/SSLAuthenticator.java
Modified:
tomcat/trunk/java/org/apache/catalina/authenticator/SSLAuthenticator.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/authenticator/SSLAuthenticator.java?rev=740684&r1=740683&r2=740684&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/authenticator/SSLAuthenticator.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/authenticator/SSLAuthenticator.java
Wed Feb 4 10:43:10 2009
@@ -140,7 +140,7 @@
if ((certs == null) || (certs.length < 1)) {
if (containerLog.isDebugEnabled())
containerLog.debug(" No certificates included with this
request");
-response.sendError(HttpServletResponse.SC_BAD_REQUEST,
+response.sendError(HttpServletResponse.SC_UNAUTHORIZED,
sm.getString("authenticator.certificates"));
return (false);
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r740686 - in /tomcat: current/tc5.5.x/STATUS.txt tc6.0.x/trunk/STATUS.txt
Author: markt Date: Wed Feb 4 10:46:17 2009 New Revision: 740686 URL: http://svn.apache.org/viewvc?rev=740686&view=rev Log: Propose fix for 38553 Modified: tomcat/current/tc5.5.x/STATUS.txt tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/current/tc5.5.x/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=740686&r1=740685&r2=740686&view=diff == --- tomcat/current/tc5.5.x/STATUS.txt (original) +++ tomcat/current/tc5.5.x/STATUS.txt Wed Feb 4 10:46:17 2009 @@ -199,3 +199,9 @@ http://people.apache.org/~markt/patches/2009-02-04-bug38483.patch +1: markt -1: + +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=38553 + Return 401 rather than 400 if client presents no certs for CLIENT-CERT auth + http://svn.apache.org/viewvc?rev=740684&view=rev + +1: markt + -1: Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=740686&r1=740685&r2=740686&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Wed Feb 4 10:46:17 2009 @@ -145,3 +145,9 @@ http://svn.apache.org/viewvc?rev=740675&view=rev +1: markt -1: + +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=38553 + Return 401 rather than 400 if client presents no certs for CLIENT-CERT auth + http://svn.apache.org/viewvc?rev=740684&view=rev + +1: markt + -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r740676 - in /tomcat: current/tc5.5.x/STATUS.txt tc6.0.x/trunk/STATUS.txt
Author: markt Date: Wed Feb 4 10:28:55 2009 New Revision: 740676 URL: http://svn.apache.org/viewvc?rev=740676&view=rev Log: Propose fix for 38197 Modified: tomcat/current/tc5.5.x/STATUS.txt tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/current/tc5.5.x/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=740676&r1=740675&r2=740676&view=diff == --- tomcat/current/tc5.5.x/STATUS.txt (original) +++ tomcat/current/tc5.5.x/STATUS.txt Wed Feb 4 10:28:55 2009 @@ -187,3 +187,9 @@ http://svn.apache.org/viewvc?rev=740635&view=rev +1: markt -1: + +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=38197 + Take account of jsp:attribute elements when naming tag pools + http://svn.apache.org/viewvc?rev=740675&view=rev + +1: markt + -1: Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=740676&r1=740675&r2=740676&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Wed Feb 4 10:28:55 2009 @@ -139,3 +139,9 @@ http://svn.apache.org/viewvc?rev=740635&view=rev +1: markt -1: + +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=38197 + Take account of jsp:attribute elements when naming tag pools + http://svn.apache.org/viewvc?rev=740675&view=rev + +1: markt + -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 38483] access log valve uses simpledateformat in tread-unsafe way
https://issues.apache.org/bugzilla/show_bug.cgi?id=38483 --- Comment #15 from Mark Thomas 2009-02-04 02:39:20 PST --- The fix was applied to trunk and 6.0.x but not 5.5.x. I have proposed a patch for 5.5.x -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46652] HttpServletRequest.getQueryString() always returns null
https://issues.apache.org/bugzilla/show_bug.cgi?id=46652 Lee Clemens changed: What|Removed |Added Status|RESOLVED|CLOSED --- Comment #2 from Lee Clemens 2009-02-04 07:55:04 PST --- Seems the request in the JSP is com.documentum.web.env.IncludedHttpServletRequestWrapper -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r740675 - /tomcat/trunk/java/org/apache/jasper/compiler/Generator.java
Author: markt
Date: Wed Feb 4 10:26:28 2009
New Revision: 740675
URL: http://svn.apache.org/viewvc?rev=740675&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=38197
Take account of jsp:attribute elements when naming tag pools
Modified:
tomcat/trunk/java/org/apache/jasper/compiler/Generator.java
Modified: tomcat/trunk/java/org/apache/jasper/compiler/Generator.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/compiler/Generator.java?rev=740675&r1=740674&r2=740675&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/compiler/Generator.java (original)
+++ tomcat/trunk/java/org/apache/jasper/compiler/Generator.java Wed Feb 4
10:26:28 2009
@@ -43,6 +43,7 @@
import org.apache.jasper.Constants;
import org.apache.jasper.JasperException;
import org.apache.jasper.JspCompilationContext;
+import org.apache.jasper.compiler.Node.NamedAttribute;
import org.apache.jasper.runtime.JspRuntimeLibrary;
import org.xml.sax.Attributes;
@@ -267,8 +268,8 @@
if (!n.implementsSimpleTag()) {
String name = createTagHandlerPoolName(n.getPrefix(), n
-.getLocalName(), n.getAttributes(), n
-.hasEmptyBody());
+.getLocalName(), n.getAttributes(),
+n.getNamedAttributeNodes(), n.hasEmptyBody());
n.setTagHandlerPoolName(name);
if (!names.contains(name)) {
names.add(name);
@@ -284,15 +285,21 @@
* @return The name of the tag handler pool
*/
private String createTagHandlerPoolName(String prefix,
-String shortName, Attributes attrs, boolean hasEmptyBody) {
+String shortName, Attributes attrs, Node.Nodes namedAttrs,
+boolean hasEmptyBody) {
String poolName = null;
poolName = "_jspx_tagPool_" + prefix + "_" + shortName;
if (attrs != null) {
-String[] attrNames = new String[attrs.getLength()];
+String[] attrNames =
+new String[attrs.getLength() + namedAttrs.size()];
for (int i = 0; i < attrNames.length; i++) {
attrNames[i] = attrs.getQName(i);
}
+for (int i = 0; i < namedAttrs.size(); i++) {
+attrNames[attrs.getLength() + i] =
+((NamedAttribute)
namedAttrs.getNode(i)).getQName();
+}
Arrays.sort(attrNames, Collections.reverseOrder());
if (attrNames.length > 0) {
poolName = poolName + "&";
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46666] New: Why is disableUploadTimeout and KeepAliveTimeout correlated in Http11 Connector?
https://issues.apache.org/bugzilla/show_bug.cgi?id=4
Summary: Why is disableUploadTimeout and KeepAliveTimeout
correlated in Http11 Connector?
Product: Tomcat 6
Version: 6.0.18
Platform: PC
OS/Version: Windows XP
Status: NEW
Severity: normal
Priority: P2
Component: Connectors
AssignedTo: dev@tomcat.apache.org
ReportedBy: do...@bea.com
In Http11Processor.java
while (started && !error && keepAlive) {
// Parsing the request header
try {
if (!disableUploadTimeout && keptAlive) {
if (keepAliveTimeout > 0) {
socket.setSoTimeout(keepAliveTimeout);
}
else if (soTimeout > 0) {
socket.setSoTimeout(soTimeout);
}
}
inputBuffer.parseRequestLine();
request.setStartTime(System.currentTimeMillis());
keptAlive = true;
if (!disableUploadTimeout) {
socket.setSoTimeout(timeout);
}
disableUploadTimeout - This flag allows the servlet container to use a
different, longer connection timeout while a servlet is being executed, which
in the end allows either the servlet a longer amount of time to complete its
execution, or a longer timeout during data upload. If not specified, this
attribute is set to "true".
The code above is waiting on a new Http Request and precedes the servlet
processing logic. It seems odd to me that I must set disableTimeout to false
to get my keepAliveTimeout set.
To set keepalivetimout, I must implicitely enable upload timeout whether I need
it or not. It seems to me that the disableTimeout is unneccessary in the
following line
if (!disableUploadTimeout && keptAlive) {
Do you agree with this?
Thanks for the insight
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46666] Why is disableUploadTimeout and KeepAliveTimeout correlated in Http11 Connector?
https://issues.apache.org/bugzilla/show_bug.cgi?id=4 Doug Drechsel changed: What|Removed |Added CC||do...@bea.com -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 38197] taglib pool bug when tag is used with jsp:attribute
https://issues.apache.org/bugzilla/show_bug.cgi?id=38197 --- Comment #3 from Mark Thomas 2009-02-04 02:28:53 PST --- Thanks for the report. I have fixed this in trunk and proposed the fix for 6.0.x and 5.5.x -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r740694 - /tomcat/current/tc5.5.x/STATUS.txt
Author: markt
Date: Wed Feb 4 10:55:37 2009
New Revision: 740694
URL: http://svn.apache.org/viewvc?rev=740694&view=rev
Log:
Correct link
Modified:
tomcat/current/tc5.5.x/STATUS.txt
Modified: tomcat/current/tc5.5.x/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=740694&r1=740693&r2=740694&view=diff
==
--- tomcat/current/tc5.5.x/STATUS.txt (original)
+++ tomcat/current/tc5.5.x/STATUS.txt Wed Feb 4 10:55:37 2009
@@ -148,7 +148,7 @@
+1: markt
-1:
-* Fix https://issues.apache.org/bugzilla/process_bug.cgi
+* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=36923
If EL is disabled, treat ${ as template text
This patch includes a port of the work from TC6 that rmeoved the need for the
text replacement hack as part of the EL processing.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r740682 - /tomcat/current/tc5.5.x/STATUS.txt
Author: markt Date: Wed Feb 4 10:39:22 2009 New Revision: 740682 URL: http://svn.apache.org/viewvc?rev=740682&view=rev Log: Propose fix for 38483 Modified: tomcat/current/tc5.5.x/STATUS.txt Modified: tomcat/current/tc5.5.x/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=740682&r1=740681&r2=740682&view=diff == --- tomcat/current/tc5.5.x/STATUS.txt (original) +++ tomcat/current/tc5.5.x/STATUS.txt Wed Feb 4 10:39:22 2009 @@ -193,3 +193,9 @@ http://svn.apache.org/viewvc?rev=740675&view=rev +1: markt -1: + +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=38483 + Make access log valves thread safe + http://people.apache.org/~markt/patches/2009-02-04-bug38483.patch + +1: markt + -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 45608] Race conditions on field countAllocated of class org.apache.catalina.core.StandardWrapper
https://issues.apache.org/bugzilla/show_bug.cgi?id=45608 --- Comment #5 from Yao Qi 2009-02-04 17:00:22 PST --- Actually, we use MTRAT to find this bug in tomcat. MTRAT could find potential data race and deadlock in Java program. Get more on http://www.alphaworks.ibm.com/tech/mtrat -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 43228] StandardWrapper#countAllocated isn't thread-safe
https://issues.apache.org/bugzilla/show_bug.cgi?id=43228 --- Comment #11 from Yao Qi 2009-02-04 17:08:44 PST --- I am the reporter of Bug 45608. We use MTRAT(http://www.alphaworks.ibm.com/tech/mtrat) to find race conditions in Java program, and Bug 45608 is found in this way. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
