DO NOT REPLY [Bug 41059] WebAppClassLoader clearReferences code break running threads
https://issues.apache.org/bugzilla/show_bug.cgi?id=41059 Mauro Molinari changed: What|Removed |Added CC||mauro...@tiscali.it -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 41059] WebAppClassLoader clearReferences code break running threads
https://issues.apache.org/bugzilla/show_bug.cgi?id=41059 --- Comment #12 from Mauro Molinari 2009-01-13 01:57:25 PST --- Could this bug be taken into consideration? In my case, I have the symptoms outlined in bug #43867 and this is caused by the following situation (I'm using Tomcat 5.5.26): - WebappClassLoader.clearReferences() at line 1617 inspects some static fields in order to set them to null afterwards, using reflection - one of these fields seems to be a field of an Axis2 class (I have an Axis2 Servlet with load-on-startup configured in my web.xml); field.get(null) causes the VM to pass through sun.misc.Unsafe.ensureClassInitialized(Class) (in other words: Tomcat is trying to inspect a static field of a class that hasn't ever be initialized before) - that method of Sun implementation causes specifically org.apache.axis2.context.OperationContext to be initialized; this class has a static field declared as: private static final Log log = LogFactory.getLog(OperationContext.class); - this static declaration causes a new Log4JLogger to be created; this is still in charge of the WebappClassLoader, so when Log4JLogger constructor calls getLogger(), a call to org.apache.log4j.LogManager.getLoggerRepository() is made - however, at this time the static field repositorySelector is null, probabily because it has been set to null by a previous iteration of the same loop that is in running in WebappClassLoader.clearReferences() (this is just a hypothesis) So, from what I have said, I think that either: - WebappClassLoader.clearReferences() should skip to inspect fields of classes that have not been initialized yet, otherwise they will be initialized at that point (and it might be too late!) - I didn't look at Curt's patch, but I assume he worked on this issue and he followed a 2-pass approach that also solves it I hope this helps in any way. Mauro. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[g...@vmgump]: Project tomcat-trunk (in module tomcat-trunk) failed
To whom it may engage...
This is an automated request, but not an unsolicited one. For
more information please visit http://gump.apache.org/nagged.html,
and/or contact the folk at gene...@gump.apache.org.
Project tomcat-trunk has an issue affecting its community integration.
This issue affects 1 projects,
and has been outstanding for 2 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk : Java Servlet 2.5 & Server Pages JSP 2.1 implementation
(for ...
Full details are available at:
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk/index.html
That said, some information snippets are provided here.
The following annotations (debug/informational/warning/error messages) were
provided:
-DEBUG- Dependency on commons-daemon exists, no need to add for property
commons-daemon.jsvc.tar.gz.
-INFO- Failed with reason build failed
-INFO- Failed to extract fallback artifacts from Gump Repository
The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk/gump_work/build_tomcat-trunk_tomcat-trunk.html
Work Name: build_tomcat-trunk_tomcat-trunk (Type: Build)
Work ended in a state of : Failed
Elapsed: 2 secs
Command Line: /usr/lib/jvm/java-1.5.0-sun/bin/java -Djava.awt.headless=true
org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml
-Dbuild.sysclasspath=only
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/tomcat-trunk/BUILDING.txt
-Dcommons-daemon.jsvc.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/jsvc.tar.gz
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-13012009.jar
-Djasper-jdt.jar=/srv/gump/packages/eclipse/plugins/org.eclipse.jdt.core_3.4.2/jdtcore.jar
-Dcommons-logging-api.jar=/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-13012009.jar
-Dtomcat-dbcp.jar=/srv/gump/public/workspace/tomcat-trunk/tomcat-deps/tomcat-jdbc-13012009.jar
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH:
/usr/lib/jvm/java-1.5.0-sun/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/classes:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/ant/dist/lib/ant-trax.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/packages/junit3.8.1/junit.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/junit/dist/junit-13012009.jar:/srv/gump/packages/javamail-1.4/mail.jar:/srv/gump/packages/javamail-1.4/lib/mailapi.jar:/srv/gump/packages/jaf-1.1ea/activation.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-13012009.jar:
/srv/gump/packages/eclipse/plugins/org.eclipse.jdt.core_3.4.2/jdtcore.jar:/srv/gump/public/workspace/tomcat-trunk/tomcat-deps/tomcat-jdbc-13012009.jar:/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-13012009.jar
-
Buildfile: /srv/gump/public/workspace/tomcat-trunk/build.xml
build-prepare:
[mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/classes
[mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/build
[mkdir] Created dir:
/srv/gump/public/workspace/tomcat-trunk/output/build/bin
[mkdir] Created dir:
/srv/gump/public/workspace/tomcat-trunk/output/build/conf
[mkdir] Created dir:
/srv/gump/public/workspace/tomcat-trunk/output/build/lib
[mkdir] Created dir:
/srv/gump/public/workspace/tomcat-trunk/output/build/temp
[mkdir] Created dir:
/srv/gump/public/workspace/tomcat-trunk/output/build/webapps
compile:
[javac] Compiling 1071 source files to
/srv/gump/public/workspace/tomcat-trunk/output/classes
[javac] javac: invalid target release: 1.6
[javac] Usage: javac
[javac] where possible options include:
[javac] -g Generate all debugging info
[javac] -g:noneGenerate no debugging info
[javac] -g:{lines,vars,source} Generate only some debugging info
[javac] -nowarnGenerate no warnings
[javac] -verbose Output messages about what the
compiler is doing
[javac] -deprecation Output source locations where
deprecated APIs are used
[javac] -classpath Specify where to find user class files
[javac] -cp Specify where to find user class files
[javac] -sourcepath Specify where to find input source
files
[javac] -bootc
DO NOT REPLY [Bug 41059] WebAppClassLoader clearReferences code break running threads
https://issues.apache.org/bugzilla/show_bug.cgi?id=41059 --- Comment #13 from Gili 2009-01-13 03:31:51 PST --- FYI, Glassfish fixed this bug within a week of being reported: https://glassfish.dev.java.net/issues/show_bug.cgi?id=6637 I'll leave it up to you to draw your own conclusions. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r734116 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: funkman Date: Tue Jan 13 04:42:22 2009 New Revision: 734116 URL: http://svn.apache.org/viewvc?rev=734116&view=rev Log: some votes Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=734116&r1=734115&r2=734116&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Jan 13 04:42:22 2009 @@ -34,21 +34,21 @@ * Fix issue where the first request for a deleted JSPs returns as if the JSP still exists. http://svn.apache.org/viewvc?view=rev&revision=683969 - +1: markt + +1: markt, funkman 0: remm (looks risky, very minor problem) -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45608 Prevent race condition for allocate/deallocate in StandardWrapper http://svn.apache.org/viewvc?rev=685177&view=rev - +1: markt + +1: markt, funkman 0: remm: The only unsafe usage of this field is to implement the gimmick loop-wait hack, which to me means adding any sort of sync is not worth it. -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45074 http://svn.apache.org/viewvc?rev=689402&view=rev - +1: jfclere + +1: jfclere, funkman 0: markt: The OP was using linux so I assume they saw some benefit. If this is goign to be applied, the docs should be updated as well. @@ -70,6 +70,7 @@ fhanik why did we change it in trunk to begin with if we are gonna change it again when the spec comes out lets just implement the spec in trunk, and discuss the simplest solution for 6.0.x but I don't agree with changing the default value + funkman: leave as gap until 3.0 spec -1: rjung: slightly prefer enabled for 6.0.x because of increased security by default, but disabled for tc5.5.x because of the small risk of breaking existing apps. @@ -91,13 +92,14 @@ * Fix serialisation issue reported by Find Bugs http://svn.apache.org/viewvc?rev=699633&view=rev +1: markt + +1: funkman (prefer to also remove Serializable from trunk) 0: remm (StdContext was marked as Serializable for an experiment; obviously it won't work) -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45933 Don't use xml parser from web-app to process tld files http://svn.apache.org/viewvc?rev=701355&view=rev - +1: markt + +1: markt, funkman -0: remm (it is a refactoring, and is not appropriate to me in 6.0.x) markt - It is a refactoring but the refactoring was necessary to change when TLDs were processed to avoid the bug. It @@ -106,7 +108,7 @@ * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45403 See commit message for details of negligable performance impact http://svn.apache.org/viewvc?rev=701358&view=rev - +1: markt + +1: markt, funkman -0: remm (I also do not think the patch is a good idea as a backport) * Backport NCDFE fix from trunk (TCK failures without it) @@ -119,7 +121,7 @@ * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=41861 Add major version number to Tomcat service name created by Windows installer http://svn.apache.org/viewvc?rev=710066&view=rev - +1: markt, rjung + +1: markt, rjung, funkman -1: rjung: tomcat.nsi already uses replacement patterns like @vers...@. So it might be more robust, to add another replacement like @@ -142,13 +144,13 @@ * [2] Prevent async close NPE on already closed sockets http://people.apache.org/~fhanik/tomcat/comet-close-2.patch - +1: fhanik, markt (need to fix indenting) + +1: fhanik, markt (need to fix indenting), funkman -1: * [3] Add ability to fix the keyAlias in NIO/SSL http://svn.apache.org/viewvc?rev=720587&view=rev http://svn.apache.org/viewvc?rev=720553&view=rev - +1: fhanik, markt + +1: fhanik, markt, funkman -1: * [4] Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45154 (add sendfile support to NIO/SSL) - performance improvement @@ -160,24 +162,24 @@ * [5] Fix Comet interest registration bug http://people.apache.org/~fhanik/tomcat/comet-ops.patch - +1: fhanik + +1: fhanik, funkman -1: * [6] Fix file descriptor leak during send file behavior in NIO connector http://svn.apache.org/viewvc?rev=729191&view=rev - +1: fhanik, markt, jim + +1: fhanik, markt, jim, funkman -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=42693 Fix compilation of recursive tags http://svn.apache.org/viewvc?rev=720046&view=rev - +1: markt, fhanik + +1: markt, fhanik, funkman -1: * Use consistent (and more useful) JPDA defaults in catalina.bat http://svn.apache.org/viewvc?rev=721040&view=rev - +1: markt, fhanik + +1: markt, fhanik, funkman -1: * Changes required to run with a security manager @@ -195,19 +197,19 @@ Exclud
Re: [g...@vmgump]: Project tomcat-trunk (in module tomcat-trunk) failed
I've downgraded the Gump build for tomcat-trunk to 1.5 for now (just to get rid of the nags). It will start nagging again once somebody commits a change that breaks compiling with 1.5. At the moment, the 1.6 Gump build http://gump.zones.apache.org/gump/test/tomcat-trunk/tomcat-trunk/index.html doesn't build since commons-dbcp can't be built on 1.6. "Filip Hanik - Dev Lists" wrote in message news:496c0d90.1040...@hanik.com... time to move this boy to JDK 1.6 as we move towards servlet 3.0 Filip Bill Barker wrote: > To whom it may engage... > This is an automated request, but not an unsolicited one. For more > information please visit http://gump.apache.org/nagged.html, and/or > contact the folk at gene...@gump.apache.org. > > Project tomcat-trunk has an issue affecting its community integration. > This issue affects 1 projects. > The current state of this project is 'Failed', with reason 'Build Failed'. > For reference only, the following projects are affected by this: > - tomcat-trunk : Java Servlet 2.5 & Server Pages JSP 2.1 > implementation (for ... > > > Full details are available at: > > http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk/index.html > > That said, some information snippets are provided here. > > The following annotations (debug/informational/warning/error messages) > were provided: > -DEBUG- Dependency on commons-daemon exists, no need to add for property > commons-daemon.jsvc.tar.gz. > -INFO- Failed with reason build failed > -DEBUG- Extracted fallback artifacts from Gump Repository > > > > The following work was performed: > http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk/gump_work/build_tomcat-trunk_tomcat-trunk.html > Work Name: build_tomcat-trunk_tomcat-trunk (Type: Build) > Work ended in a state of : Failed > Elapsed: 2 secs > Command Line: > /usr/lib/jvm/java-1.5.0-sun/bin/java -Djava.awt.headless=true > org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml > -Dbuild.sysclasspath=only > -Dtomcat-native.tar.gz=/srv/gump/public/workspace/tomcat-trunk/BUILDING.txt > > -Dcommons-daemon.jsvc.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/jsvc.tar.gz > > -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-12012009.jar > > -Djasper-jdt.jar=/srv/gump/packages/eclipse/plugins/org.eclipse.jdt.core_3.4.2/jdtcore.jar > > -Dcommons-logging-api.jar=/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-12012009.jar > > -Dtomcat-dbcp.jar=/srv/gump/public/workspace/tomcat-trunk/tomcat-deps/tomcat-jdbc-12012009.jar > [Working Directory:/srv/gump/public/workspace/tomcat-trunk]> > CLASSPATH:/usr/lib/jvm/java-1.5.0-sun/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/classes:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/ant/dist/lib/ant-trax.jar:/srv/gump/public/workspace/ant /dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/packages/junit3.8.1/junit.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/junit/dist/junit-12012009.jar:/srv/gump/packages/javamail-1.4/mail.jar:/srv/gump/packages/javamail-1.4/lib/mailapi.jar:/srv/gump/packages/jaf-1.1ea/activation.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-12012009.jar:>/srv/gump/packages/eclipse/plugins/org.eclipse.jdt.core_3.4.2/jdtcore.jar:/srv/gump/public/workspace/tomcat-trunk/tomcat-deps/tomcat-jdbc-12012009.jar:/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-12012009.jar> -> Buildfile: /srv/gump/public/workspace/tomcat-trunk/build.xml>> build-prepare:> [mkdir] Created dir:/srv/gump/public/workspace/tomcat-tru nk/output/classes> [mkdir] Created dir:/srv/gump/public/workspace/tomcat-trunk/output/build> [mkdir] Created dir:/srv/gump/public/workspace/tomcat-trunk/output/build/bin> [mkdir] Created dir:/srv/gump/public/workspace/tomcat-trunk/output/build/conf> [mkdir] Created dir:/srv/gump/public/workspace/tomcat-trunk/output/build/lib> [mkdir] Created dir:/srv/gump/public/workspace/tomcat-trunk/output/build/temp> [mkdir] Created dir:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps>> compile:> [javac] Compiling 1071 source files to/srv/gump/public/workspace/tomcat-trunk/output/classes> [javac] javac: invalid target release: 1.6> [javac] Usage: javac > [javac] where possible options include:> [javac] -g Generate all debugging info> [javac] -g:none G
